From patchwork Wed Apr 24 20:56:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 162812 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp1122424jan; Wed, 24 Apr 2019 13:56:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqxbfVvBG43PnR/9b8XwF8ObC8DrByjNOVmFrIFZoWeFd5FTKNPPES9TS8aOwj+847dWxnWt X-Received: by 2002:a63:7f0b:: with SMTP id a11mr30721551pgd.234.1556139383885; Wed, 24 Apr 2019 13:56:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556139383; cv=none; d=google.com; s=arc-20160816; b=xZeZggkxQZqFTQe8XazQpa9PlH+gBdLZTSltT4f3w8Fl9SHQPrD47hPR1sdFAgMd0N y718uq1LwFhx/pV916B2uwwajx3eRFlJTBF2tQelBulf6b+5AxG7fYi6+hncr1Xt0Bex XxXQvAF5qu1x6LCdxsgbNQxWRYRSwiawzvzISHfN5aN5wncKpwWUvvY9OJMC1F7tsA01 Csg7I7bGBA+PPD3aMdb9hsCEjYn1wU93FuKaW0QdtXUQT+zKpzcb+XZEi8k/mMBXbItl vBqQSFm8YeqRpVsEsP/tSK/3pxEY3MQAoSF6cdwbBSYQfsfLafPXf6eYauulZC238Er9 joFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=5EE9+Co3ayTkacb38Au9Wln/sou6mhdQB8k31OtlwZA=; b=GythcG+dX/XCgQcOK+vJSeXdBVisW/PBA1f5kHUCiVyKSZtyVrle6TXvN0R5T/ihCV k31cBQBRtrSekdfKRlrka8Cs129oopWQyOO6h7IRvdHomR2P3y1kWRmc+v8qfk+xJz7v Km7M/Nl9/4wbtfbsRXY+x8/ybnrKJqbTALtA/tvLhfOUZ5tOtLGWP2Txe+Bl4WhCnbf9 Oj3D+IxW2n4UiLJim5h7ZsPclctHCoFnLCjyzgYCgdAAv6EoCEh2UuF1TtGTJ76gzxfU 2LJn8Qhn/R+W8cd/FQhqLy5/gTNciWo6kUsAca3ssVXGP6oDZEcnaOWvxzEjjR6LvQsW mGBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AdBMmEfq; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r24si19531931pls.398.2019.04.24.13.56.23; Wed, 24 Apr 2019 13:56:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AdBMmEfq; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731808AbfDXU4X (ORCPT + 11 others); Wed, 24 Apr 2019 16:56:23 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:37987 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731741AbfDXU4W (ORCPT ); Wed, 24 Apr 2019 16:56:22 -0400 Received: by mail-wr1-f67.google.com with SMTP id f14so26445466wrj.5 for ; Wed, 24 Apr 2019 13:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=5EE9+Co3ayTkacb38Au9Wln/sou6mhdQB8k31OtlwZA=; b=AdBMmEfqJ99hne/CnLZg9ZzQk7AU5q7FPT1KQBVJEzNz87NMCq/mHmPNqruslAQeN/ /pr8tehnWcqSgrgXpPWzw0EFmu5qLQDg6pyM8WWeVK94QppLX51ZiZcKAls4+2cAUFF+ 1z1TqLbYA3Jh0H1z/VFCdgOV+n2/x6Aw/TibUJh2+e99tl2RGxyOWGzsZXl6zYUy/S3I /EpU+i+Ga2RIAk4zm8tjkk8tgvsiGG0FOi6d+9+h7GIyifBmjdkUciUMVZt2YP4iPPjh TMFc/PKyeAx9I6BWVZcuGbT3A1hmG+S11i6YQeoBUYlJ8+WUkq8p6EkbzmxvJB8LnzFv O8OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5EE9+Co3ayTkacb38Au9Wln/sou6mhdQB8k31OtlwZA=; b=CW6XmEZx2syWBSDdB2Iowm1kTPS7WYrhC53Aau5q9FM9/L+55nDemi/9jk4w6ht8tm r1x9y6Z2Da5UI/V/PSr4Ch+f4e6FZMQNI/sA5CtNEoBJBE02kh07yHJgF8S6PV/jLdmH fiGeOaUkkMX/Rpy4uoPak5lZ0WnNzQQG/jUPURpZeWNYNoy/GXKz1o8/5J1BB1vmfNqL wzG+7iNZWHjmKQKCT4kTtDLOk6XHdOEbrQu4FYbmrzI6SzgJL0lcNwfxbEF5aiUOYDvi 6GJnDYlT1QA53DAZPdx7qV+jppa4A9r4NOft2BgntbO8xfh7sa/pMSpKIjQ5Q5gEUlod PP0w== X-Gm-Message-State: APjAAAVdrSA4dRCxp65irStWpzH72f8ZLEzRk8Xr8/O2l3kOsEjH2DPz uyeGwkfg+kyxAt+5EgSVHRwdaQ== X-Received: by 2002:adf:f309:: with SMTP id i9mr22488046wro.258.1556139381049; Wed, 24 Apr 2019 13:56:21 -0700 (PDT) Received: from clegane.local (228.252.95.92.rev.sfr.net. [92.95.252.228]) by smtp.gmail.com with ESMTPSA id w10sm16225375wrv.8.2019.04.24.13.56.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Apr 2019 13:56:20 -0700 (PDT) From: Daniel Lezcano To: edubezval@gmail.com, rui.zhang@intel.com Cc: Viresh Kumar , Amit Daniel Kachhap , Javi Merino , linux-pm@vger.kernel.org (open list:THERMAL/CPU_COOLING), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] thermal/drivers/cpu_cooling: Remove pointless test in power2state() Date: Wed, 24 Apr 2019 22:56:09 +0200 Message-Id: <20190424205610.9376-1-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.17.1 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org When the static power computation was removed, the test with the power being negative was not removed. However, the substraction which was responsible of the negative value was removed and the variable is now an u32. A double reason to remove the test which does not make sense. Fixes: 84fe2cab48590 ("cpu_cooling: Drop static-power related stuff") Cc: Viresh Kumar Signed-off-by: Daniel Lezcano --- drivers/thermal/cpu_cooling.c | 1 - 1 file changed, 1 deletion(-) -- 2.17.1 Acked-by: Viresh Kumar diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c index f7c1f49ec87f..ee8419a6390c 100644 --- a/drivers/thermal/cpu_cooling.c +++ b/drivers/thermal/cpu_cooling.c @@ -541,7 +541,6 @@ static int cpufreq_power2state(struct thermal_cooling_device *cdev, struct cpufreq_cooling_device *cpufreq_cdev = cdev->devdata; struct cpufreq_policy *policy = cpufreq_cdev->policy; - power = power > 0 ? power : 0; last_load = cpufreq_cdev->last_load ?: 1; normalised_power = (power * 100) / last_load; target_freq = cpu_power_to_freq(cpufreq_cdev, normalised_power);