From patchwork Tue Feb 7 20:58:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 651585 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98B3CC636CC for ; Tue, 7 Feb 2023 20:58:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229775AbjBGU6s (ORCPT ); Tue, 7 Feb 2023 15:58:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229623AbjBGU6q (ORCPT ); Tue, 7 Feb 2023 15:58:46 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B188413DF5 for ; Tue, 7 Feb 2023 12:58:44 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id n13so11932829wmr.4 for ; Tue, 07 Feb 2023 12:58:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ig92pyMbU2zuSYAVil0uen1pAtlV0COrB7Gvugo1C0s=; b=MUpe8RWh84Giqhg4fNSII6pvgNJL95YzWbpB90rqFpF18Il8U42VPn4Dx5x0kgyUPc wRAuaVnM2hQol1S6jcQOVtJK39CV0S+mXCutMqL1BctyduPwifErwRNpngNmU0PnXziD jH4Z1+fruERiY/Cj4x7wVUJH2+rFCF7ITCyRmB0ZuZSNlaHzd6Hp82O5tZ/O7Ck9/7Ax rY+f96I3tng5z1waAUgjaqY4HzR/VJTqp0vubPfIkko6chBuPqF0RCnmqepdvazBC9u6 DHD5IoQ9i9sSTMZ4wrLQIxLBGMdVOKQt1UWMv5/av8D7LR+QZS4ApqUy4oxsZKGQdGiU u78w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ig92pyMbU2zuSYAVil0uen1pAtlV0COrB7Gvugo1C0s=; b=msTrlihprEeU1OlV7tkul/8tvGMZ5kc2ptaaX8diHXBeOQ2RqaEhMJHxalS8Bu7ElE vVxQKWpjCcgZRnZfs6vex74RNlCOzp2/r22x8oyPAY83pTVFXTG+KwOxYgzht/LOkhF4 WxwvQLPdqLXbsUAhuc+kuZW+uowZiEVLFh/Pc9ux7YGCRZWDIrtVWD8E0sCZAiA5wy4Z q4Ix7QAVtBfq1KFpXpaD3MYub4ZPvsSe8VxT3FsANhdRBzxkTEArChiDDxH8UP2I+TGg BvXQnVqb0nx3PCZrTsWBOIrM1hZIF2QoVZouF99u/AicC22whNozV7cBp3AkfAK8nC17 qQ7g== X-Gm-Message-State: AO0yUKX4KdgSznOjZF9ZpIVn5tsGQF4F70Lh7pBqLhqwGyeJ1d7NzuFp uvhFpQGpgAvNLSVHeEJxZ/Mi1FhmUCHPOHWa X-Google-Smtp-Source: AK7set+IQt2wJhcPIudLzOOHNQqXw0jcwOEm0J8mi1ZdCP0P500dXLXECHPj3fQHqtj7LnfzKFlh5Q== X-Received: by 2002:a05:600c:1708:b0:3de:e8c5:d826 with SMTP id c8-20020a05600c170800b003dee8c5d826mr4444405wmn.28.1675803523206; Tue, 07 Feb 2023 12:58:43 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h27-20020a05600c2cbb00b003db12112fcfsm16555649wmc.4.2023.02.07.12.58.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 12:58:42 -0800 (PST) From: Krzysztof Kozlowski To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 2/4] media: samsung: exynos4-is: drop unused pinctrl bits Date: Tue, 7 Feb 2023 21:58:32 +0100 Message-Id: <20230207205834.673163-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230207205834.673163-1-krzysztof.kozlowski@linaro.org> References: <20230207205834.673163-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Drop unused pinctrl header and pctrl member of struct fimc_is. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. New patch --- drivers/media/platform/samsung/exynos4-is/fimc-is.h | 3 --- drivers/media/platform/samsung/exynos4-is/media-dev.h | 1 - 2 files changed, 4 deletions(-) diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-is.h b/drivers/media/platform/samsung/exynos4-is/fimc-is.h index 06586e455b1d..c126b779aafc 100644 --- a/drivers/media/platform/samsung/exynos4-is/fimc-is.h +++ b/drivers/media/platform/samsung/exynos4-is/fimc-is.h @@ -14,7 +14,6 @@ #include #include #include -#include #include #include #include @@ -231,7 +230,6 @@ struct chain_config { /** * struct fimc_is - fimc-is data structure * @pdev: pointer to FIMC-IS platform device - * @pctrl: pointer to pinctrl structure for this device * @v4l2_dev: pointer to the top level v4l2_device * @fw: data structure describing the FIMC-IS firmware binary * @memory: memory region assigned for the FIMC-IS (firmware) @@ -262,7 +260,6 @@ struct chain_config { */ struct fimc_is { struct platform_device *pdev; - struct pinctrl *pctrl; struct v4l2_device *v4l2_dev; struct fimc_is_firmware fw; diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.h b/drivers/media/platform/samsung/exynos4-is/media-dev.h index 62ad5d7e035a..079105d88bab 100644 --- a/drivers/media/platform/samsung/exynos4-is/media-dev.h +++ b/drivers/media/platform/samsung/exynos4-is/media-dev.h @@ -11,7 +11,6 @@ #include #include #include -#include #include #include #include From patchwork Tue Feb 7 20:58:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 651584 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABA22C636CC for ; Tue, 7 Feb 2023 20:58:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229830AbjBGU6u (ORCPT ); Tue, 7 Feb 2023 15:58:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229585AbjBGU6r (ORCPT ); Tue, 7 Feb 2023 15:58:47 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36CE61E9F3 for ; Tue, 7 Feb 2023 12:58:46 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id bg13-20020a05600c3c8d00b003d9712b29d2so15606wmb.2 for ; Tue, 07 Feb 2023 12:58:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dRrfTafHWOPP66W8TWUXdxmmbu6jMm7VMDj6nUG7ys4=; b=DqtTAyD+/DfVIXIixTTLeibbPWfARnoKPtZ503G/plOAdpSOZov9AsNRpB3pUQJUCv 5FCNQSbkC0AV7x/c4JKBbGIsoJuPYgqyzs2xF/miMtoLpyWrGtikd+RQT0vvCwpOV1c/ LVTXvBnhyoXTiKlSEA51+3WcZhlTyji8x5IDX0Mn2tghG16exPAaIpGzWridsqZMAxkx VxKKiazE0E9AuPVSkwv+0S9b9bro79BmeeJuIJsR8uaXenubEjuo5LA+Zoz2D1YzSnPv MGCiAbPamcfmHPYxaGJLC6H7KwYpZsFvUAOhnYsAIRJaKV7/5/MSyTniqrwxKqarbPsk QrEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dRrfTafHWOPP66W8TWUXdxmmbu6jMm7VMDj6nUG7ys4=; b=IL79+utv85bRFEWU/p9u4bqK9/UuMoBSboHIqNZEdYpM7JR4sBBci3Rwx5XUBlZmKG GgmvyxmnoMQu+iiWNedUiyWCI9GAbCyFVwEtfbpl+22Ih2fMmO+Skwv235baplPWs8+b eACHwP+BUstDKA6kIo0bdVLFjCQVNhz0tnGwMVBjzisPALELaG2+yK84bjCyRJi8Rar9 LOJ668BzPBekzdGwOBGGSahLaSNC+VW3V+1O8zTqfvClX1p98P617cgcQR0fZ3yXPLoy 98UbVpmAj+/nEbISny4oZr1LhaOVMNfl0gQTPBq3LyPCaqeDF0T5FisO1VTbdzqhnY7Q OJrQ== X-Gm-Message-State: AO0yUKWgGx/xSThxRXaKI3FveKmmmMM1dpOSNdGi3Rc/w8kNO4+sGUVL 2F9OBeLiip0NnT2Wd4YRJwE6mw== X-Google-Smtp-Source: AK7set8unV2JpGoXq+wRRje/TXgj4zlNonWi0Sr7sORRaCG8wxSrplHwWE6VetjIA5RfaZHnpx1ibg== X-Received: by 2002:a05:600c:4383:b0:3dc:57e8:1d1c with SMTP id e3-20020a05600c438300b003dc57e81d1cmr5511078wmn.9.1675803524727; Tue, 07 Feb 2023 12:58:44 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h27-20020a05600c2cbb00b003db12112fcfsm16555649wmc.4.2023.02.07.12.58.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 12:58:44 -0800 (PST) From: Krzysztof Kozlowski To: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Sylwester Nawrocki , Alim Akhtar , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v2 3/4] media: samsung: exynos4-is: do not require pinctrl Date: Tue, 7 Feb 2023 21:58:33 +0100 Message-Id: <20230207205834.673163-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230207205834.673163-1-krzysztof.kozlowski@linaro.org> References: <20230207205834.673163-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Driver does not handle pin configuration switching and several DTS provide empty pinctrl property, just to satisfy the driver's requirement for it. Drop requirement for pinctrl property as it is really optional. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. New patch --- drivers/media/platform/samsung/exynos4-is/media-dev.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.c b/drivers/media/platform/samsung/exynos4-is/media-dev.c index 98a60f01129d..22baa429ed5d 100644 --- a/drivers/media/platform/samsung/exynos4-is/media-dev.c +++ b/drivers/media/platform/samsung/exynos4-is/media-dev.c @@ -1470,10 +1470,8 @@ static int fimc_md_probe(struct platform_device *pdev) goto err_v4l2dev; pinctrl = devm_pinctrl_get(dev); - if (IS_ERR(pinctrl)) { - ret = dev_err_probe(dev, PTR_ERR(pinctrl), "Failed to get pinctrl\n"); - goto err_clk; - } + if (IS_ERR(pinctrl)) + dev_dbg(dev, "Failed to get pinctrl: %pe\n", pinctrl); platform_set_drvdata(pdev, fmd);