From patchwork Wed Feb 22 06:57:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 655740 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F274C64EC4 for ; Wed, 22 Feb 2023 06:59:27 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3D8E3E96; Wed, 22 Feb 2023 07:58:35 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3D8E3E96 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1677049165; bh=HZpjx30Se9SsQHbHbRwxCn11/vC+ZfXM4QSlLyjUbl0=; h=From:To:In-Reply-To:References:Subject:Date:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=e4RySE4UnWZXcEDoAVMr9OGQ9sgQMCAJQQRp8Eb5Isrzd7b2yOUy0DPbuddXc0YYx kE8eNI/IQrxfpqxxK04R/QaJwnqNDJS1o1oa3LOC49uioLr5aPSmbMWoKOmnLEfB8G yPLxYaxrICC2sjPEJqDy15TFic6nJb4hq7VwxIlk= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 979F9F8047C; Wed, 22 Feb 2023 07:57:44 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id AF63EF80266; Wed, 22 Feb 2023 07:57:36 +0100 (CET) Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01on2070d.outbound.protection.outlook.com [IPv6:2a01:111:f403:7010::70d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5723CF80125 for ; Wed, 22 Feb 2023 07:57:28 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 5723CF80125 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=renesas.com header.i=@renesas.com header.a=rsa-sha256 header.s=selector1 header.b=ovWFWn5Z ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZZdeoi8sNXEGBPVA/yVf92PU87Z/6/pOhxYy02N9zZvDcXOqIOKYbPxk0GgyF4uPLzK+lmdexMtFpg6SiWTflky3zy5ScbY4hC7Xxi2cYJFqJGo36hv36HLiRDGbntbL2ZE+VkdDT0pFwR30Gi1BzTvfOjkn22UmwD7PEJQuqXaoi9dfCUNipdhljvBN/m82FULd2sS+P0gHf/HW6/wq9nJjqC51tOtTeVy8Y+drvWJmf3mI7Ek7tCS8icYw4Tgv0g/kOmmCAshQIqxK4zDf5EpqLxXZSLhvGSBLxrpvh9o4GXQbR/ACCFHLaXb7vvM3fUsX09D9Xj1QvsNgMAX/MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rmDNud1kgb4WAQKdI7SN8s1Vm9fyt7CZLa3yRcI0lSE=; b=i+UEAl1r4+26rdQtDFrW2oGg6iW8+BZUD1qdavjZOF5VqNZa9ZD9TvZfJz+gv/NlsGFu7hlg9N2o/2uKnhJQ1bOxxmwxEzM0LY4euX5qy74XyeXeyBPkrRAFEM1tXIDKyRCv7R9M/H21rmyeFKHzz80yESVRwyz7jbHDShi6bP83IIomQZe1NWYLnf0rsGhRESzREee8ARDnngj2+pev7u8h1TsOWIY8ql2HHFyJXOcVlxDtuEL7pgOH7+Ik7ysO5dA9bOgOgRkeg+x57tQNe5BJGrXqbYt95q7LIWLsuHqRG3IjY2PyogNZ/d5seTlkCjEpLyad8d3NHWPrSrczKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rmDNud1kgb4WAQKdI7SN8s1Vm9fyt7CZLa3yRcI0lSE=; b=ovWFWn5ZhxHwRhckhVaXrOUMrpETzHJPYKNr9mw3lLs1UuHPk//OpMRm7BV7nEw47qGv1iD0TAKwHnDpBA1Y050CiA0ddUroYH7D3BD07MB3MCuFIRW83z/m2AnRO87/HBX7BhJ3T+Iu0SMrhXRVg86RoBRQkPzHF+c5pjYowls= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com; Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) by OS3PR01MB8892.jpnprd01.prod.outlook.com (2603:1096:604:17d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Wed, 22 Feb 2023 06:57:25 +0000 Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::e03e:1938:695b:f472]) by OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::e03e:1938:695b:f472%5]) with mapi id 15.20.6134.018; Wed, 22 Feb 2023 06:57:25 +0000 Message-ID: <874jreqjaj.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Mark Brown In-Reply-To: <875ybuqjcg.wl-kuninori.morimoto.gx@renesas.com> References: <875ybuqjcg.wl-kuninori.morimoto.gx@renesas.com> Subject: [PATCH 1/2] ASoC: hpi6205.c: check pao in control_message() User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0 Date: Wed, 22 Feb 2023 06:57:25 +0000 X-ClientProxiedBy: TY2PR0101CA0003.apcprd01.prod.exchangelabs.com (2603:1096:404:92::15) To OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3PR01MB8426:EE_|OS3PR01MB8892:EE_ X-MS-Office365-Filtering-Correlation-Id: dcedda34-b579-4a68-d5a9-08db14a20de2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KaQslfJbjANEAJUea/FH8VcSenty8Y2g3+J6/DYOuzLGqCw5FUXTsSBJV2wef3kySvu5syCerfl9EvKzl+vl7lUOu8lKsMBwONr/FJstICtHqJhzdsZN0TTk1It7azC6o8S/jHbB5CzIHxMhmOVAH52gyX1YrUZNaOgju9dEGVunl4592gtLwegaQR8F0oqdYuoLuZnoqJDKRQFvVHo4vVrWMdd5hi4Ba9nZxQioJ1DuZX8JdzPLM3GQ+y/acT4RuQh6vRqljOn0nxhojnxHt9YYWXcJZs/WLh2PYlhfWbqE21QeCCe5yPq8hRhmfr9AB6qzEivTsXzG49qswYeAJL5AfvhBLavJVSVc7dN2jCwnP4zCgY1DAJbqAhQA+4QRAIYqSYWV3ABUZ9z+TygbpMuzeGoyMazCpLKxptvn4sAFeBvcL3ZvWbhEf3ncFm+9Om9L1rk7WkRnnt+wKnNMgEGkXUX2VBX5vLsAXNjimFeVat8TEGLe66TmgrTTRkzHnAK3cdxe3wPkbFIM+PIRIB4W/3p6+wqMl9h+scMmIsdGCZbDJXbhOdgQFHm5nTozvYUi6ZepKuB03J4Cr2qYqxsE6n7ciuoCNDDm4VEdOI9NWCw2xs58wawF/6tDhinsUK7B7KK8Yew+84maWzCtPJKdREej/csRBiZCymLJFVuuNcwUme8HxuNhfBxUf7WIvlYWB7CMXcPUIZPve4h7CQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS3PR01MB8426.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(396003)(376002)(346002)(136003)(39860400002)(451199018)(5660300002)(54906003)(8936002)(2906002)(41300700001)(2616005)(6486002)(52116002)(316002)(4326008)(6916009)(6512007)(478600001)(8676002)(66946007)(26005)(186003)(6506007)(66556008)(66476007)(38100700002)(38350700002)(86362001)(36756003)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: VPsIYGemdR0i4EO5aPNHeT9IhZZVuQ6LVWIxfFvpS922Hz8+ILTjBN5sw1sxqHdbHfTEY9k1xvtWVz1KitLR0SuVCzoKllFLzlPo4ARIkHXgqaf87zJecRXMvFP0ekrcxrMPVFIGWw164zaNTaSH7giUU2bYUx+1O/s132fVloaO1ZkpoNzJopajK7M0XVlPkKHNNQwCr81x86inq6vFcPPof2NmLVdxFHcnIGuwbf2VNd7nIs9gXnenltIcpEROP9U708JhrVPkxFy/VAJNSPHHjzDe2+4lTXcpq1sBu4FwsxnY1RHtF9T4w7nfwQmSmkt/4tKYp/9qmW49mc2wejpdummVoYlWv139uMyqTLKuCDFP3vZPcnZF2H+panEyBPuEScC6Zr6PYBVYMJUJ52DkSp8CP9liYBOzVjpDCyo91N399rMLfLo28EofC+k05DsTaOL/g2xNfdDJ+8v1PFnsBRC96NWFriWZpIaCZXyUQHqjPkSbhhCIeqJ7fOqR1owoG4WplOiDj+FBhm7hgXY+D2Bk4CI2sAWoPeaudRy73giA/Hx1zyeGASH86bP7tdogSSlbthI1nXlZoRcAvOdm3rhKcYR7AtSmcUTc1QICSFzF9gAsF+xknWkC7mm0T/QFK2eBEoLYNnwWFnfesMPHB/qvu9lLSz1wT/ZWw5wT2x/geisOf/pIgqf+fgKz2LDes+ByfZhtFciKsjAVnU/ZP4eoHNLjNiJsFr9ijUr8RJx5Bo09DqO+hnUpFMYuHaVwh7zkKfnPMxw/+Hz3NpGLSRtrXTL4HTHloBCpqmw/JN37QFFlo/euWKJZF+Xv4G8QePgAOPpPpkFN79vOj1ZXDdVzjtue80tzQdUy0AJ7eUu2Ht/wdb1vAzZOPew6sGHjC581+kEz/Fn6svhYxoCuM7lGqD8PtIVrCWo3/rNL53Cw1PSkv/dD6o1p5c6Wikj1hIPMIup3JQxCArQX6+zBECCUmmyUmXe9QmnsUWypNtALNU7v/tlcWlwU2Vh92piS0VpQHW0S27RQ2MCKhi/osbnp32NJ6bmzvS9s3YRnW++4AVIzCatRF1L1GshV6LlNK2HaUGH/0pRA53FkmXyOgZ+2BhYEDXCmW5MZU9R/um02iThefwevDl2EP/cUQb8XctsRK//DONIQL9GQIlPkHao7/4ZRM8fjjAM9kXxt8GeqcUmasug4ajtzHoGNmtnlg6QOidfpm10o7mx/IgIss37uhW4YfCaMaxTRrDQKVCLLeEf+J8WIUjfPZXUuEPumvWAe7PWES7MMTnR++G5wXjQGgwW7PC4XI0MUg96eP0mY25YzmqvrRx31PvJAGwpusO36J8+l4gYJKimpvaPMdbId2M1Ljuk2JsCxqWSNZwI/HEY9BfDYPINIfOxkpDZOqK2GIk8BNpZMYKDC5kwFUyOklcf33l207G3m+d4gQYky7NIl0RX3FFlopJVaqwwvx3fW1YifSbHLphmdw5y298QF5iLyiSSpdhG/3tEuc/6y6VhTKDgi3QizNZJSAmgAKh203cThQL7kSC0A417LpAUlUlw6WYal0z0aXU/9Ox3v8kvnpR212/zOV2iCb00JPcwsjcbf/sRQjUXzc8FImtcoxprTxP57O1w9jUQ= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: dcedda34-b579-4a68-d5a9-08db14a20de2 X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8426.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 06:57:25.4690 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fALmeLK4RYaRqMKKnIVDjBbC6LfWNG5bVjbnWhc6/Zc/qDvIt9tdsQSngJg5/JTxlwZemS6dwtnUVKvvr/d9FeiiguMsBxePoiGbwu+Ul1CB9OMl2dLSKhAJNQfMr5Q8 X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB8892 Message-ID-Hash: OVPOOWUCDU55SSCL2KQFBMESODECML3S X-Message-ID-Hash: OVPOOWUCDU55SSCL2KQFBMESODECML3S X-MailFrom: kuninori.morimoto.gx@renesas.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Linux-ALSA , Takashi Iwai , shaomin Deng X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: control_message() might be called with pao = NULL. Here indicates control_message() as sample. (B) static void control_message(struct hpi_adapter_obj *pao, ...) { ^^^ struct hpi_hw_obj *phw = pao->priv; ... ^^^ } (A) void _HPI_6205(struct hpi_adapter_obj *pao, ...) { ^^^ ... case HPI_OBJ_CONTROL: (B) control_message(pao, phm, phr); break; ^^^ ... } void HPI_6205(...) { ... (A) _HPI_6205(NULL, phm, phr); ... ^^^^ } Therefore, We will get too many warning via cppcheck, like below sound/pci/asihpi/hpi6205.c:238:27: warning: Possible null pointer dereference: pao [nullPointer] struct hpi_hw_obj *phw = pao->priv; ^ sound/pci/asihpi/hpi6205.c:433:13: note: Calling function '_HPI_6205', 1st argument 'NULL' value is 0 _HPI_6205(NULL, phm, phr); ^ sound/pci/asihpi/hpi6205.c:401:20: note: Calling function 'control_message', 1st argument 'pao' value is 0 control_message(pao, phm, phr); ^ Set phr->error like many functions doing, and don't call _HPI_6205() with NULL. Signed-off-by: Kuninori Morimoto --- sound/pci/asihpi/hpi6205.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/asihpi/hpi6205.c b/sound/pci/asihpi/hpi6205.c index 27e11b5f70b9..c7d7eff86727 100644 --- a/sound/pci/asihpi/hpi6205.c +++ b/sound/pci/asihpi/hpi6205.c @@ -430,7 +430,7 @@ void HPI_6205(struct hpi_message *phm, struct hpi_response *phr) pao = hpi_find_adapter(phm->adapter_index); } else { /* subsys messages don't address an adapter */ - _HPI_6205(NULL, phm, phr); + phr->error = HPI_ERROR_INVALID_OBJ_INDEX; return; } From patchwork Wed Feb 22 06:58:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 656026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34EB9C64EC4 for ; Wed, 22 Feb 2023 07:01:29 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8A5F483E; Wed, 22 Feb 2023 08:00:36 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8A5F483E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1677049286; bh=HMqy37WxfTqkKliIi9hhNeX5H3Vpi2aBAICvaxAgPmo=; h=From:To:In-Reply-To:References:Subject:Date:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=UDVsEFnkZr6LQvxw45Jcq9bWUhLHh25qDG5Fiefll8gFWYJOB4Zn7WqwUDTo4AqX1 OiecTtfMNsGZtPwQrMqIKjXMh1aVMYhZKru+ccBJa57KByxl+Qej05+SaywllNYWJT nPzqMAJuf0CMtwF2BTSBxfgJlisfIlgrqkK+1GOM= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 12229F80083; Wed, 22 Feb 2023 08:00:36 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3AB8BF80266; Wed, 22 Feb 2023 08:00:31 +0100 (CET) Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01on20721.outbound.protection.outlook.com [IPv6:2a01:111:f403:7010::721]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DCE7CF80125 for ; Wed, 22 Feb 2023 07:58:37 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DCE7CF80125 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=renesas.com header.i=@renesas.com header.a=rsa-sha256 header.s=selector1 header.b=p7tonAl/ ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cXqUNISX/eUcv1wq1mtZQkUurruhHcSV6rg7aYJEmy2yI0/74Si9MgxSD5AIRyb1g2FbPAVq8kPIygY8HUL1o9i29J7EwZ95LY4C5WsdrWeI+FT203/E+iCIqTdceTYq9fKj0P+FiEM9iW2wUgXxV6T7exQzocp1gwANkcNPfXBfVq0/aOC2NAAKEvbgsg0bqW/k7ny4VOjkxNCq/Tw8sCkN1r2LZAFJKt/DgOUR2f9psnIyYGkFpzgtVs2F5Y9cNdJMDRrPZieBzlBc01OoH5YaJWPmPw/MzZuZpuUgv3eYoK3A+OLpEuFLGGYqMjEh1VtsjFcgw+qPZUkA1Mbing== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nvoitf4TNjzW8os/z0eZWqyAcsvlpD+FZuTfpjJ3maY=; b=Fn2ROT8x5R5bI/UKALKf7iJhr5UuLOO2GaZrCN5v6+yDchX0rJS3JeD2pg8huam7PdrXGWw5YWTRX0dF6lWJ0Xk5xR3oXgLqFw4MYS8+WxB+BTbVThJrrpCQ0lVNmq/27nw50bVtsQCnQ3EUOhny7ouV/1UHwasH7ObgFDCnDZHOQlQdw/bAzx/HajvNYYgdzMhW0LOF2Hm8+jdvnmvCOWE++njNbSdMwfiAAoIIXKyGHrtcdZq2tiN4X60Y/7bkAxDJT19VgkCBtwJj5rIhqgzn0B9bp1krM7oJ3f9Vn4JUW70ib6e/k4lx4dykWKgqQSuI57iue8+DKQAqnMBZDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nvoitf4TNjzW8os/z0eZWqyAcsvlpD+FZuTfpjJ3maY=; b=p7tonAl/UfRg8zG2RsSzizUg3DbZWFpkv383hTSMI1RQdVkJpFqnnAFp419YRNu8FmCubJWrdqg6R9R8enEBTB4iMDEfd7Sd5ZIsRi8bvC4Sar/VHVhmZnqu7umnKxtJRn3y3JgAO0UgVpdi6boapg0uXffn+qSQdIw7Icds2BI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com; Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) by TYWPR01MB8790.jpnprd01.prod.outlook.com (2603:1096:400:16f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Wed, 22 Feb 2023 06:58:34 +0000 Received: from OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::e03e:1938:695b:f472]) by OS3PR01MB8426.jpnprd01.prod.outlook.com ([fe80::e03e:1938:695b:f472%5]) with mapi id 15.20.6134.018; Wed, 22 Feb 2023 06:58:34 +0000 Message-ID: <87356yqj8m.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Mark Brown In-Reply-To: <875ybuqjcg.wl-kuninori.morimoto.gx@renesas.com> References: <875ybuqjcg.wl-kuninori.morimoto.gx@renesas.com> Subject: [PATCH 2/2] ASoC: patch_ca0132.c: fixup buffer overrun at tuning_ctl_set() User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0 Date: Wed, 22 Feb 2023 06:58:33 +0000 X-ClientProxiedBy: TY2PR02CA0021.apcprd02.prod.outlook.com (2603:1096:404:56::33) To OS3PR01MB8426.jpnprd01.prod.outlook.com (2603:1096:604:194::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: OS3PR01MB8426:EE_|TYWPR01MB8790:EE_ X-MS-Office365-Filtering-Correlation-Id: d8690cf9-6a9a-4be8-1cf9-08db14a236e5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pIMtXcztbZy3QLR6AA+bqlGLrQpfT2VeKpNYcOUDet3NCcThzf/7vWcTJobkTA57sI2GKufeZTiCfTgeqkraN2hZCNJb4C1HDCgwWJMzvSluRBUAZ36Ii74uL9TbyW+sx+giNLaw5UFkjDL+X52QunE+C1auC9Tg1OKi2rbxmneoY/1jT3ka5IJ7Ci0YMunSg0BVl3FJ354H0Mnu8NRbggztFIq18P5ORk3pzonakxHBqUjWGarDJ7a8NRXnSNGZmHsOz8SDfQoK4QOcERNEG+nlG7f9Zm0SQNDuFUz8GAc0H6L7wiTUM50oAq3zJH8sC432f8ljWjbtoFx0bKPVhHpWNYoxtcu+KjiNsi5eBwqDU1yTSrpMZghrlywn/booZve/gYsg0d84N95wrRMjHGv+kNj13hlaQvooBbyPDOAFgfF4UWOaZsc4OD/GM+lCvmnCCqFTnCbmng+F9XcOuHagDML7YQ0wvYtJ3ZJJHF6GI7qnM5zCZaw0wIW0i4GTLMqoKexX6rSd5z2jPc70trv8XoKG0Mm6jF5DtHZyrSZ6X+xnYaBfu8Ha3gSjReSLXQ4k6rgfhOel/4z6V7hHpnvSFgjRZ098yM12aQLW+F1HdDP6EsfbM6dU906zmjH2ve6/3sBilxThv954XZr/poORvytqecfMGad3fxLXux6cDoLwINkenvcFDYpTCVSQZ2emZL46RvSsZ0/cLWESug== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS3PR01MB8426.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(396003)(376002)(136003)(366004)(39860400002)(346002)(451199018)(316002)(6512007)(186003)(6506007)(26005)(54906003)(8936002)(41300700001)(4326008)(66946007)(66476007)(66556008)(6916009)(8676002)(5660300002)(36756003)(6486002)(478600001)(52116002)(2906002)(86362001)(2616005)(83380400001)(38100700002)(38350700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: t4Yge6he1VON4Xwvr9C9ZWAMtdZ0Ho2haeMy6DeSUKKsFGWLJAOYzTiv28FJwyGXmXV6ZB57wQdmI4x3emP+GYbH9CQSopYqYWsEKivJ1vQeELUNHHfym361TkBY9M2Lm2aDsqXMCDPALZpoRLLwdDvPV0CKUmMr5soXg/cMH2HEYlHGATEKbl9MAXIRjMs9c3vV4voIwpWmetjNyFh6NzXFdOlFINYggzsqE20kgattOS+aD3GQ2I/TiyuUN6qFOplGla2YsgD3PpYg1DQeh5L51zdWVDcMNFd7PHM9hVN7XYkaRSzbtYsp8qFpFc1b+pCHs1JFYj19zhF7NE/b2hyRNkCJe2vImnJ4qVr+6xRqSys348GyTV2xs77BD6p98PSJG3jCrp+sQpOFgd3mTGEX0l8RWoVWW6J0Oyf6LNkh5kJEwsUNxIsYgKW21SE8kmz2Xv6FEVvovATPUWois/tYUtBUXo6y171CY/pabuHmwVdjDr4PlCUd2RfkFoXGoLYNyGRHjjpEH9fagEH5qiL88676+o/EM5vxW4buqt7tR8ARJdWHQgSyj47N5TmhRtFZ8zXBRxREa3vK0ZbhbcXJCPj3JpFj1QdP4JyKuhzd4DWfcfI6B3O2tWmK0WvFuEBksPgNJlQZ9aAI9H2xrUTDew70WFdTT5eSXe0Y0sOEIGfMuSH5MVlzFefQlkWcX5rm4ESEgG5AO5TgQmVTrVMpzeWVu1HM0Lrud69Je3kyRH/g+CZd4tWv574eA1RfupsfJ7YhxIeAXKLOOo0VjQBT8Uw1mSzxv/5o41bMGWQlilYAGJMjb24yZNMwTs08uk7EQengPKXE/P7A2NqGEXy5X8jeJT2/tPwBYF0iYVlqEh2RBY/MPdn/uHG5J6cvYb8yOlbs/r7TvGb40uyeli971+GfbRo4RWPfkHXOY4sh3DADMzTbdEjVnJ9Be9Z7ZC//ryR85stG66+VcQKZseAspPSfnwQu5S45Ye8pQJb36d/M+MbXEPgJsH6sZt7azC7eF5xJ4LSe03Qq4UW3Gd4BexYSB59FQSkX+OKA9Xs5gO+ncceL12AYIHcdQqjD35n5d2CPVzYEjhoCbDRXFIlQuledJ0vQ+KjYEKCDF9gjqpEbN1K6G2IpgJkJyd4WU312dyEo8oNoj7CX5E8g9jExd7csRBiNON77IsfjU6WySst3JROp1zFx+WNO78RTx7yUc9qnpMU75rh0UYIaQqJuV2ScUcWLlc4WX2PEIbzMXLQhKmRQcSrjl2QsoqyYdYfXMYXWZPLcxKWAqyOvAW7HLVrDzavmOWyRZCjq9GH0V25yXRAjnu8ZQPiHvqWCboYIrf9e8Uq3mKBP6Ll0wYsX0tQApyojYUUxYp8SIY7GnOLs1vQUX5oHNgw010hw6XwP5T3FhfuVkQ74BZfXjMtQoQlmar081pV3bZUQqdNRJh1mzSZpU6Nr22LJw+mjyCggOsQKzGOJYLFVhhh9EJ271pB651QCz2GDyLhDIXGrH1WLQosX5BurAUAb72oyuHwyoa/zzRcxy2A5zx95HhOkcHXxLJIJ/sSWgvfJBfeUTQFAqXFGxWMe5KCggd5NtEVDkVurmnGh14QrF6Za53JgpCuPZKSluMtnUQku/IM= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8690cf9-6a9a-4be8-1cf9-08db14a236e5 X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8426.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2023 06:58:34.2549 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BPxVpojeFoDyZ1Ea4Wa58RHJ/Uhqtd7JMb/UE+YC+w0toGfiqjx5UmyNlpX8QoBuOXFG+QqvorJPWn4isH3DAN2Otvm0f58ZUZk9I2f2UHVBcy24tayOXiKVbttr7fWj X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB8790 Message-ID-Hash: M4RIDKK46PEX2DMZPH5UUOBF74UJ7N57 X-Message-ID-Hash: M4RIDKK46PEX2DMZPH5UUOBF74UJ7N57 X-MailFrom: kuninori.morimoto.gx@renesas.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Linux-ALSA , Takashi Iwai , Xian Wang , ye xingchen X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: tuning_ctl_set() might have buffer overrun at (X) if it didn't break from loop by matching (A). static int tuning_ctl_set(...) { for (i = 0; i < TUNING_CTLS_COUNT; i++) (A) if (nid == ca0132_tuning_ctls[i].nid) break; snd_hda_power_up(...); (X) dspio_set_param(..., ca0132_tuning_ctls[i].mid, ...); snd_hda_power_down(...); ^ return 1; } We will get below error by cppcheck sound/pci/hda/patch_ca0132.c:4229:2: note: After for loop, i has value 12 for (i = 0; i < TUNING_CTLS_COUNT; i++) ^ sound/pci/hda/patch_ca0132.c:4234:43: note: Array index out of bounds dspio_set_param(codec, ca0132_tuning_ctls[i].mid, 0x20, ^ This patch cares non match case. Signed-off-by: Kuninori Morimoto --- sound/pci/hda/patch_ca0132.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c index 0a292bf271f2..5ce4b5f62983 100644 --- a/sound/pci/hda/patch_ca0132.c +++ b/sound/pci/hda/patch_ca0132.c @@ -4228,8 +4228,10 @@ static int tuning_ctl_set(struct hda_codec *codec, hda_nid_t nid, for (i = 0; i < TUNING_CTLS_COUNT; i++) if (nid == ca0132_tuning_ctls[i].nid) - break; + goto found; + return -EINVAL; +found: snd_hda_power_up(codec); dspio_set_param(codec, ca0132_tuning_ctls[i].mid, 0x20, ca0132_tuning_ctls[i].req,