From patchwork Thu Mar 23 17:57:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Weiss X-Patchwork-Id: 666790 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F1E9C6FD1C for ; Thu, 23 Mar 2023 17:58:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230267AbjCWR6t (ORCPT ); Thu, 23 Mar 2023 13:58:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231152AbjCWR6r (ORCPT ); Thu, 23 Mar 2023 13:58:47 -0400 Received: from mail.z3ntu.xyz (mail.z3ntu.xyz [128.199.32.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E65944B8; Thu, 23 Mar 2023 10:58:30 -0700 (PDT) Received: from [192.168.0.26] (2a02-8388-6582-fe80-0000-0000-0000-000c.cable.dynamic.v6.surfer.at [IPv6:2a02:8388:6582:fe80::c]) by mail.z3ntu.xyz (Postfix) with ESMTPSA id 93155D2584; Thu, 23 Mar 2023 17:57:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=z3ntu.xyz; s=z3ntu; t=1679594279; bh=/s3YATkQEynaY97oNVGkN2PAZTRMQ7bXwfDtDYia87A=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=yM9VfVmMzCxKjXTHUR4QnZsf7Wpyqk5zUCMBfRn9LmBOy4MvCB+c+1kmRf+GDiIls qvBK4AVdqlBCoFuNUIbJ7kU/qCG6YxdcDCMg7IkspWzH4Twr66X2mMGoAeSMW/YCav lWlW4PSHpGexxQLBDpPgrEamB7obzeGmes4AC87Q= From: Luca Weiss Date: Thu, 23 Mar 2023 18:57:49 +0100 Subject: [PATCH v4 1/3] media: dt-bindings: media: rkisp1: complete ov2685 example MIME-Version: 1.0 Message-Id: <20230129-ov2685-improvements-v4-1-e71985c5c848@z3ntu.xyz> References: <20230129-ov2685-improvements-v4-0-e71985c5c848@z3ntu.xyz> In-Reply-To: <20230129-ov2685-improvements-v4-0-e71985c5c848@z3ntu.xyz> To: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Shunqian Zheng , Jacopo Mondi Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss , Krzysztof Kozlowski X-Mailer: b4 0.12.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1586; i=luca@z3ntu.xyz; h=from:subject:message-id; bh=/s3YATkQEynaY97oNVGkN2PAZTRMQ7bXwfDtDYia87A=; b=owEBbQKS/ZANAwAIAXLYQ7idTddWAcsmYgBkHJMjVW/e2Q2s/jXJLNba4KenAFd/cI/tE9sLS bxV8NVpRvaJAjMEAAEIAB0WIQQ5utIvCCzakboVj/py2EO4nU3XVgUCZByTIwAKCRBy2EO4nU3X Vm/tD/4h30/j1jv5gjaQlVt6aI85HqI/Uml4zfwAuaEDDinWDDBtOQ4RlYrBM5M8pfPj4zSGNRH d+UKndm3lNFif/ZP/Gg8+2DlPf1+U9j0slcm3QfDbyTuAMLA+5ipJPzBLQ/22vpy5+vWAnFZOc4 VL4rpbi0aMZmq6J/vNSkmER4nxLFb4BMtLSkofbNBfLCTR4Ud5FmWXHKyLnrpux8Tsd5txN5GEt rU5s4UHz/z6EgXAsWOPlkMnUX32UoJRhrkSfzjplbLT0u34XGn8acvLGPQgCEqbN3zbfFNvUZFi dAeMsttdlfYIWEvThbtWmvuL+vM9cU5iubYRKKwzijBCJp82zMKs+MDp6vRMllw/30Zgc0aif1i 1+s8FzcE5ul+KmL6JHZEujJxF+5vFB6el0XLe+UW8e4ErW7KvN8vsakZ9bLI5a5JlMBSC632KRn +HHFSwu/XvLA6MkQ+Imp+VqYc2i+C6MwhPSxN/cWAIP6qoRz490Cw1ApPdDNqnE07lFH/J039t6 uzBHcmWZknXO5GkPkSZc4JFpJoQ8ZdbenflVOYyW/eGxrRAlFEZNFaauTQKzcPHvpADWYnu4IKC AeaSh8QdNxlMR2ZgQog0nCFoYHCa5WCaJQqClDi9eHmM6UOKcyFbtm245rQ8yeXOhH4OTExF6tG Um3eYXgvn7FvKLA== X-Developer-Key: i=luca@z3ntu.xyz; a=openpgp; fpr=BD04DA24C971B8D587B2B8D7FAF69CF6CD2D02CD Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org With the upcoming conversion of ov2685 to dt-schema let's complete the example so validation succeeds. At the same time fix the indentation of the port node in this example. Acked-by: Krzysztof Kozlowski Signed-off-by: Luca Weiss --- .../devicetree/bindings/media/rockchip-isp1.yaml | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml index b3661d7d43572..0bad7e6401486 100644 --- a/Documentation/devicetree/bindings/media/rockchip-isp1.yaml +++ b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml @@ -212,12 +212,19 @@ examples: compatible = "ovti,ov2685"; reg = <0x3c>; - port { - ucam_out: endpoint { - remote-endpoint = <&mipi_in_ucam>; - data-lanes = <1>; - }; - }; + clocks = <&cru SCLK_TESTCLKOUT1>; + clock-names = "xvclk"; + + avdd-supply = <&pp2800_cam>; + dovdd-supply = <&pp1800>; + dvdd-supply = <&pp1800>; + + port { + ucam_out: endpoint { + remote-endpoint = <&mipi_in_ucam>; + data-lanes = <1>; + }; + }; }; }; }; From patchwork Thu Mar 23 17:57:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Weiss X-Patchwork-Id: 666400 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18D60C77B60 for ; Thu, 23 Mar 2023 17:58:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230499AbjCWR6F (ORCPT ); Thu, 23 Mar 2023 13:58:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230367AbjCWR6C (ORCPT ); Thu, 23 Mar 2023 13:58:02 -0400 Received: from mail.z3ntu.xyz (mail.z3ntu.xyz [128.199.32.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08A492122; Thu, 23 Mar 2023 10:58:01 -0700 (PDT) Received: from [192.168.0.26] (2a02-8388-6582-fe80-0000-0000-0000-000c.cable.dynamic.v6.surfer.at [IPv6:2a02:8388:6582:fe80::c]) by mail.z3ntu.xyz (Postfix) with ESMTPSA id 2883DD2585; Thu, 23 Mar 2023 17:57:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=z3ntu.xyz; s=z3ntu; t=1679594279; bh=QEe/z0x1YIt/MXdaImskhcwh5eKk1KzQFXz+kV0iHHk=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=ca0T7PqAeaNhUWQDoGISbgPnO1sZJ/ZCH0GmSH63dvxL/0yjhMvGp3SlKLin2bGow LK2UCgIXSh6UyQZetVIOCqbJXwz4Tyi8DmBOobU2nMawBC5qRMitzwf6U6nuOrWbL1 AKraEUU4UmWcJEeo+46muR1hxzPSfbkIFbSlz90A= From: Luca Weiss Date: Thu, 23 Mar 2023 18:57:50 +0100 Subject: [PATCH v4 2/3] media: dt-bindings: ov2685: convert to dtschema MIME-Version: 1.0 Message-Id: <20230129-ov2685-improvements-v4-2-e71985c5c848@z3ntu.xyz> References: <20230129-ov2685-improvements-v4-0-e71985c5c848@z3ntu.xyz> In-Reply-To: <20230129-ov2685-improvements-v4-0-e71985c5c848@z3ntu.xyz> To: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Shunqian Zheng , Jacopo Mondi Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss , Krzysztof Kozlowski X-Mailer: b4 0.12.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=5191; i=luca@z3ntu.xyz; h=from:subject:message-id; bh=QEe/z0x1YIt/MXdaImskhcwh5eKk1KzQFXz+kV0iHHk=; b=owEBbQKS/ZANAwAIAXLYQ7idTddWAcsmYgBkHJMkIONBl9L8PQFixgBJWgg8z74ZA3pWxIji0 4i1TyI9k2yJAjMEAAEIAB0WIQQ5utIvCCzakboVj/py2EO4nU3XVgUCZByTJAAKCRBy2EO4nU3X Vpx/EACJ3t8MMr4pJOMqcQA6UP1HGSBLy/oKTpZ+EA2rRzowW5fbKo3ZU8/v4RTVeJECytmpAu0 eFiDlirCeKJPHOybyqxlMte4kx/qnptmEXqWQJiC2Sc0H3uLtb6ZmhVMFES11BwmTAFV5NJWFF9 ZtbGkPXSbljlaE2RoLGlPTWgHIRZQ8U5jI2qMXpe5einulpm/MtpMZo0T4H+D6uk7Gu/8Kxq7JG LNKZvRj2D9GMA3sEI9/5FFlseRKJgGlH7AiLX32ug4esFlok2OeNNHRM72avjNhFnvHmUmgAYMm 4gwe0hSEsOdohGcBrWSC8Bf3J+QQgFKERAlapxMfkvgc1eZJo88PNk7KdOJNiF0TCkr8CAQ8/C8 ukHYHEz8fQsjUZrqcCUCYroYwwehDsUeun69MCk9RJHL5aymiawsf/DrBGj1cAmrk0eVpJxxvaO rMzI6YJgx7q6jFgCcvvblCgoKIVlfDIYbcmR6vZcwOOvkQ7WNP+o3GsYTbK0D/UVKaWEFDth9/q JPVtt+dL2ONY4QN+/LA6GrJH7QfG7dbOFZWSlG7zRKNh9/p/x6pcrr1IBwhTk4wPcZ2S5sAQXEL WoSbh+y9jal3vdZKyvf2LoAABT3WhN+vESNzJn9D0f6gYNPoPktOVW9xcw+D45Njib4tbA9rjDw GrHJjvO4Gu09Adg== X-Developer-Key: i=luca@z3ntu.xyz; a=openpgp; fpr=BD04DA24C971B8D587B2B8D7FAF69CF6CD2D02CD Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Convert the text-based dt-bindings to yaml. Changes from original txt: * Take wording for various properties from other yaml bindings, this removes e.g. volt amount from schema since it isn't really relevant and the datasheet is a better source. * Don't make reset-gpios a required property since it can be tied to DOVDD instead. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Luca Weiss --- .../devicetree/bindings/media/i2c/ov2685.txt | 41 --------- .../devicetree/bindings/media/i2c/ovti,ov2685.yaml | 101 +++++++++++++++++++++ MAINTAINERS | 1 + 3 files changed, 102 insertions(+), 41 deletions(-) diff --git a/Documentation/devicetree/bindings/media/i2c/ov2685.txt b/Documentation/devicetree/bindings/media/i2c/ov2685.txt deleted file mode 100644 index 625c4a8c0d53d..0000000000000 --- a/Documentation/devicetree/bindings/media/i2c/ov2685.txt +++ /dev/null @@ -1,41 +0,0 @@ -* Omnivision OV2685 MIPI CSI-2 sensor - -Required Properties: -- compatible: shall be "ovti,ov2685" -- clocks: reference to the xvclk input clock -- clock-names: shall be "xvclk" -- avdd-supply: Analog voltage supply, 2.8 volts -- dovdd-supply: Digital I/O voltage supply, 1.8 volts -- dvdd-supply: Digital core voltage supply, 1.8 volts -- reset-gpios: Low active reset gpio - -The device node shall contain one 'port' child node with an -'endpoint' subnode for its digital output video port, -in accordance with the video interface bindings defined in -Documentation/devicetree/bindings/media/video-interfaces.txt. -The endpoint optional property 'data-lanes' shall be "<1>". - -Example: -&i2c7 { - ov2685: camera-sensor@3c { - compatible = "ovti,ov2685"; - reg = <0x3c>; - pinctrl-names = "default"; - pinctrl-0 = <&clk_24m_cam>; - - clocks = <&cru SCLK_TESTCLKOUT1>; - clock-names = "xvclk"; - - avdd-supply = <&pp2800_cam>; - dovdd-supply = <&pp1800>; - dvdd-supply = <&pp1800>; - reset-gpios = <&gpio2 3 GPIO_ACTIVE_LOW>; - - port { - ucam_out: endpoint { - remote-endpoint = <&mipi_in_ucam>; - data-lanes = <1>; - }; - }; - }; -}; diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml new file mode 100644 index 0000000000000..2ac0ca8a0413b --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml @@ -0,0 +1,101 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/ovti,ov2685.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: OmniVision OV2685 Image Sensor + +maintainers: + - Shunqian Zheng + +properties: + compatible: + const: ovti,ov2685 + + reg: + maxItems: 1 + + clocks: + items: + - description: XVCLK clock + + clock-names: + items: + - const: xvclk + + dvdd-supply: + description: Digital Domain Power Supply + + avdd-supply: + description: Analog Domain Power Supply + + dovdd-supply: + description: I/O Domain Power Supply + + reset-gpios: + maxItems: 1 + description: Reset Pin GPIO Control (active low) + + port: + description: MIPI CSI-2 transmitter port + $ref: /schemas/graph.yaml#/$defs/port-base + additionalProperties: false + + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + maxItems: 1 + + required: + - data-lanes + +required: + - compatible + - reg + - clocks + - clock-names + - dvdd-supply + - avdd-supply + - dovdd-supply + - port + +additionalProperties: false + +examples: + - | + #include + #include + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + ov2685: camera-sensor@3c { + compatible = "ovti,ov2685"; + reg = <0x3c>; + pinctrl-names = "default"; + pinctrl-0 = <&clk_24m_cam>; + + clocks = <&cru SCLK_TESTCLKOUT1>; + clock-names = "xvclk"; + + avdd-supply = <&pp2800_cam>; + dovdd-supply = <&pp1800>; + dvdd-supply = <&pp1800>; + reset-gpios = <&gpio2 3 GPIO_ACTIVE_LOW>; + + port { + ucam_out: endpoint { + remote-endpoint = <&mipi_in_ucam>; + data-lanes = <1>; + }; + }; + }; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index 8ea325040f355..5904f47756fe1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -15410,6 +15410,7 @@ M: Shunqian Zheng L: linux-media@vger.kernel.org S: Maintained T: git git://linuxtv.org/media_tree.git +F: Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml F: drivers/media/i2c/ov2685.c OMNIVISION OV2740 SENSOR DRIVER From patchwork Thu Mar 23 17:57:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Weiss X-Patchwork-Id: 666791 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21B1EC77B61 for ; Thu, 23 Mar 2023 17:58:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230482AbjCWR6E (ORCPT ); Thu, 23 Mar 2023 13:58:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230267AbjCWR6C (ORCPT ); Thu, 23 Mar 2023 13:58:02 -0400 Received: from mail.z3ntu.xyz (mail.z3ntu.xyz [128.199.32.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78B0E2132; Thu, 23 Mar 2023 10:58:01 -0700 (PDT) Received: from [192.168.0.26] (2a02-8388-6582-fe80-0000-0000-0000-000c.cable.dynamic.v6.surfer.at [IPv6:2a02:8388:6582:fe80::c]) by mail.z3ntu.xyz (Postfix) with ESMTPSA id B0939D2586; Thu, 23 Mar 2023 17:57:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=z3ntu.xyz; s=z3ntu; t=1679594280; bh=ncpXLQ6qGgg6hVHefO9DqumuQvrhX7L+dhXzJdi5hVA=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=xauDcQvsQWTNROmsZ/waVuFjN6M43bG0+gulylEte6y7OK14ej1K5FV1O9BYTVy7s W0JUygJ3R+0Dfj1EPZFLQYEPRkXfHgTEstC2Jq35VaWVTEzR502xYfjYWn0Q+vTjq7 Fvhdih/lLsHszJMrdBq1K9Sk/cI0S7WEP0JNFWmg= From: Luca Weiss Date: Thu, 23 Mar 2023 18:57:51 +0100 Subject: [PATCH v4 3/3] media: i2c: ov2685: Make reset gpio optional MIME-Version: 1.0 Message-Id: <20230129-ov2685-improvements-v4-3-e71985c5c848@z3ntu.xyz> References: <20230129-ov2685-improvements-v4-0-e71985c5c848@z3ntu.xyz> In-Reply-To: <20230129-ov2685-improvements-v4-0-e71985c5c848@z3ntu.xyz> To: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Shunqian Zheng , Jacopo Mondi Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.12.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=955; i=luca@z3ntu.xyz; h=from:subject:message-id; bh=ncpXLQ6qGgg6hVHefO9DqumuQvrhX7L+dhXzJdi5hVA=; b=owEBbQKS/ZANAwAIAXLYQ7idTddWAcsmYgBkHJMk5TIQR0cLMxfZ28w9hmVhXNFGqcUgpMKQz EuErPxrI8SJAjMEAAEIAB0WIQQ5utIvCCzakboVj/py2EO4nU3XVgUCZByTJAAKCRBy2EO4nU3X Vv8yD/9YkeSVJ8+GVv4ZKNLCeSGzKFGEurXBBitFIx13KhGwv5RziY1V0DEZo9hvHPi5oxoeFOp lO3yy2CcMU2boIWovJT8B2fmZ42WKHX2yaMZ3934HfdMktjEQxBdRC7WFrYCLXb9vdzcHbiStiz W3U0+3grhCtpqU1cSMtna9b0HY+LpC8NI5IOJHUiqowb0mS/l2RssmR/rzaueXvNm3xJA4HRjUM UeJyTKdPHGV8k9xBBCzIiYHb/0313bNoP3Le4GZUlXT6e4+44HwtprbTieOZX+nIsEVxLZBXXOI 4AQd/lrQC0k07nPJq4wSXeRNrFUFrORL1R/EGOM14f9Zf6j4bvg0wWj0eUMNLW4QGULhJap2L0I EiI/mA/kswoSOKRv2WOn6NRW+ngrqSjlf+sekb1yKna54Crk/jkOx00MriofUcGgY7HV/+/M8hk T8Exh8xIiQ9ZxmnvKyk6vCd4jJcHxCEbd2JinYgISk6iKpITn6PWthG8fD1bopzA0rShrbdejS5 z1aZvTIPk4dbiJumIZbwcfJx+ndflrMYA8oUAUDqzDDPYiMehxr61TAFbB7ybjTpOTzJQ14Rh3k GhvdKghKRqJur9+cDOWhqIdL6GhEe3hhKkR9y2VRb+nJeLjZdcHKAce9w6g0IBrbqszykMUWQIP 3AI0ruNoGN4U9EQ== X-Developer-Key: i=luca@z3ntu.xyz; a=openpgp; fpr=BD04DA24C971B8D587B2B8D7FAF69CF6CD2D02CD Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org In some setups XSHUTDOWN is connected to DOVDD when it's unused, therefore treat the reset gpio as optional. Reviewed-by: Jacopo Mondi Signed-off-by: Luca Weiss --- drivers/media/i2c/ov2685.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov2685.c b/drivers/media/i2c/ov2685.c index fdf3e06133302..f119a93e7c647 100644 --- a/drivers/media/i2c/ov2685.c +++ b/drivers/media/i2c/ov2685.c @@ -807,7 +807,7 @@ static int ov2685_probe(struct i2c_client *client) if (clk_get_rate(ov2685->xvclk) != OV2685_XVCLK_FREQ) dev_warn(dev, "xvclk mismatched, modes are based on 24MHz\n"); - ov2685->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); + ov2685->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW); if (IS_ERR(ov2685->reset_gpio)) { dev_err(dev, "Failed to get reset-gpios\n"); return -EINVAL;