From patchwork Wed Feb 17 15:02:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 102757 Delivered-To: patch@linaro.org Received: by 10.112.43.199 with SMTP id y7csp50492lbl; Wed, 17 Feb 2016 07:04:50 -0800 (PST) X-Received: by 10.66.253.169 with SMTP id ab9mr2826552pad.62.1455721489739; Wed, 17 Feb 2016 07:04:49 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n63si2441393pfj.185.2016.02.17.07.04.49; Wed, 17 Feb 2016 07:04:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965374AbcBQPEs (ORCPT + 30 others); Wed, 17 Feb 2016 10:04:48 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:62770 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965324AbcBQPET (ORCPT ); Wed, 17 Feb 2016 10:04:19 -0500 Received: from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue004) with ESMTPA (Nemesis) id 0MYrHb-1aSbGA2uNH-00Vj6Z; Wed, 17 Feb 2016 16:03:41 +0100 From: Arnd Bergmann To: Greg Kroah-Hartman Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Paul Gortmaker , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Masahiro Yamada , Peter Hurley , Jiri Slaby Subject: [PATCH v3 3/5] serial: 8250/uniphier: fix modular build Date: Wed, 17 Feb 2016 16:02:33 +0100 Message-Id: <1455721357-4008289-4-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1455721357-4008289-1-git-send-email-arnd@arndb.de> References: <1455721357-4008289-1-git-send-email-arnd@arndb.de> X-Provags-ID: V03:K0:NsRjEmef2OR1Kss9X6ZUywUs0jCUnC8FQ2vzaES/SiY/bZ6EoCz c8XK0Zt2Rkwkq4o/7e6vZez0yLOW2m+4dXqlPd19NHVj6BGC0UUOYe8ccvJKLwJSPcbAze6 V3SpZWAMmndHijYQHwLL6A/q/HaZLgzlRq++a1+JGBJ0K+a8zQZ6487ylwLf9/p58mRuyYj PlNlL1xq84oz8snpS9hQg== X-UI-Out-Filterresults: notjunk:1; V01:K0:d4Vbhle1AU4=:TB0JuC5gf78siQ2ojtR/yD TPFtfqsNzo+wf5QsPDdfz4F9iLHIwymSdHAGS8UK15aOuJiKoNxLFXnjmipA+E0jQ+lXRNa7B wEU441LVLyGUF/5ihyM84CATJhXifufDG2Qv7ZkOHdQ2zupi9Yt0qLEBEj8x7F3W6SCclB7ag 7aQTntBr064PStLeHCvGqdI6ll2qAZ+A/fQWyOOuktl8Y2Za8UL3iYDrV7tKZv7eqGrpvb8kq 2VEZU95w+3QcqrUNfq2h+zzeNiCkUGdc2YFZOyTKBAzF2OJRWhn7f3n2claRA4RbLwarc1L41 0d3oI+FvTKdA1CmDFZLElrwh4BtSqt9nINhbpaB2I5kFbM44jgqYlIWpbWpSf/YdvvV6Riimj lmvXVawoqUPvCkTnT8HwKHpL6HC1D5pqjhIbqT1yEh8TXtirIpU/us5oMKKlNfipEd5lCrAcw 2SzdOQJe6Qp2dtRL0z8uVMEvoVGbFbPTyp4l93VUfc8nGAtQcvgJEbFydMQCYH97aZ7Gj78Bq LE2cOzhAPPoglX/RHiFtvD2DoId+Ay2ZK+oCQJC5028Lg9vYFnXtyXrbt3bHVe8mwOsb6kmh9 Hf41R0YQCoq98DDX75/NQX3d280F0fuPX3WGrZHQBkpL4KXffcY/VOwEEB+WlK3ASAntJu985 6km+dmRTZ8W66uaeU7Yr5/OEDX1ND0gaPhFg5yPzMa5LtxqgFH/KfOsNpAqmT0zYan40= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The newly added uniphier serial port driver fails to build as a loadable module when the base 8250 driver is built-in and its console support enabled: ERROR: "early_serial8250_setup" [drivers/tty/serial/8250/8250_uniphier.ko] undefined! This changes the driver to only provide the early console support if it is built-in itself as well. Signed-off-by: Arnd Bergmann --- drivers/tty/serial/8250/8250_uniphier.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.0 diff --git a/drivers/tty/serial/8250/8250_uniphier.c b/drivers/tty/serial/8250/8250_uniphier.c index bab6b3ae2540..1b7bd26555b7 100644 --- a/drivers/tty/serial/8250/8250_uniphier.c +++ b/drivers/tty/serial/8250/8250_uniphier.c @@ -35,7 +35,7 @@ struct uniphier8250_priv { spinlock_t atomic_write_lock; }; -#ifdef CONFIG_SERIAL_8250_CONSOLE +#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE) static int __init uniphier_early_console_setup(struct earlycon_device *device, const char *options) {