From patchwork Fri Apr 21 20:55:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 676383 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87110C77B76 for ; Fri, 21 Apr 2023 20:57:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233008AbjDUU5k (ORCPT ); Fri, 21 Apr 2023 16:57:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232989AbjDUU5j (ORCPT ); Fri, 21 Apr 2023 16:57:39 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36DD21723 for ; Fri, 21 Apr 2023 13:56:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682110612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=P7RzzGtL5Qme9j/hdre25JPbFnXeBl/FsBkZ1xbOQB0=; b=S/N0lMLqKqgxR3L/lwWJp8mz1qZnYYN774AkF8nrlU01cIEldRVDg3WgzCtPhR+c+wxY+n F+CCFHUoUDOo/rhPzWtEZP9GafmK0g7PSTk0oNsjEiJtwg6KS/kjsPPGQn2zvJ85WSFCDT 9j0Lhz96teqZm/5V1xdxkY/vrtAcEAU= Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-549-6hMwvV57OcW-ARlTth2Wfw-1; Fri, 21 Apr 2023 16:56:51 -0400 X-MC-Unique: 6hMwvV57OcW-ARlTth2Wfw-1 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-5529a6f9f28so31149237b3.2 for ; Fri, 21 Apr 2023 13:56:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682110610; x=1684702610; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P7RzzGtL5Qme9j/hdre25JPbFnXeBl/FsBkZ1xbOQB0=; b=GHXhltsH362i2BIBErI0MPmcuYW6jSFRQneeWZ1DfY83TzrG9RPZf9qHfk0UgCP+cw TLRPUwI0Sm6gIE+CQ62zTyuadLJAbZBAtk82N4908wWpKnf/q8BHfgW8N8zUYOOSZrqS 6q9CPCaUTX+u5KnDGwG5kIaM+37sgxyKdY0vIs1NnyqFG2UjSNQa+QGVvpPIV6oOJFEK tP6NHbjpIghc7WMw/gFlznUR4rM84CsKICxXeUDf0GdqFBgpgM0W6fO12bi5/wYnO5vn pTX1xOFdIcNTFHQFSAiazxYeEjwhxpBH4ghiLSNoYe45JjeVg4qUkXnDz7Eba+4T68Fz j4rA== X-Gm-Message-State: AAQBX9epVlBTSfoagAF7XIcSaurbdUUdT7Vk+uBxsBGB+4G8ngpVn75I 7fkoV/qkp/zCDz/7DN679CurOJL3w/ozXZGx6zEVHwwqnRZ/dXIGnv1h1OOMFmeJBWA3MNUHeIi lknv4x83Xq/FypInIC16VHw== X-Received: by 2002:a0d:db06:0:b0:555:d2a9:4187 with SMTP id d6-20020a0ddb06000000b00555d2a94187mr2537991ywe.23.1682110610620; Fri, 21 Apr 2023 13:56:50 -0700 (PDT) X-Google-Smtp-Source: AKy350Ysv83zsjjr1cp1Suy4HWlK3tdWVEM6VXyriWG1GQF2XZOnobMkx4hDq6giIytxpxtehgZ8vg== X-Received: by 2002:a0d:db06:0:b0:555:d2a9:4187 with SMTP id d6-20020a0ddb06000000b00555d2a94187mr2537972ywe.23.1682110610145; Fri, 21 Apr 2023 13:56:50 -0700 (PDT) Received: from halaney-x13s.attlocal.net ([2600:1700:1ff0:d0e0::22]) by smtp.gmail.com with ESMTPSA id x67-20020a0dd546000000b0054c0be459dbsm1179999ywd.39.2023.04.21.13.56.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 13:56:49 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Andrew Halaney Subject: [PATCH v3 1/4] arm64: dts: qcom: sa8155p-adp: Make compatible the first property Date: Fri, 21 Apr 2023 15:55:09 -0500 Message-Id: <20230421205512.339850-1-ahalaney@redhat.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org As stated at the below link in another review, compatible is always the first property. Follow suit here to avoid copying incorrectly in the future. Link: https://lore.kernel.org/netdev/20230331215804.783439-1-ahalaney@redhat.com/T/#ma76b4116bbb9e49ee4bcf699e40935d80965b3f3 Reviewed-by: Konrad Dybcio Signed-off-by: Andrew Halaney --- Changes since v2: * Collect tags Changes since v1: * None arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts index 339fea522509..029b23198b3a 100644 --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts @@ -352,19 +352,18 @@ ðernet { max-speed = <1000>; mdio { + compatible = "snps,dwmac-mdio"; #address-cells = <0x1>; #size-cells = <0x0>; - compatible = "snps,dwmac-mdio"; - /* Micrel KSZ9031RNZ PHY */ rgmii_phy: phy@7 { + compatible = "ethernet-phy-ieee802.3-c22"; reg = <0x7>; interrupt-parent = <&tlmm>; interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */ device_type = "ethernet-phy"; - compatible = "ethernet-phy-ieee802.3-c22"; }; }; }; From patchwork Fri Apr 21 20:55:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 675987 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E42BC7618E for ; Fri, 21 Apr 2023 20:57:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233029AbjDUU5v (ORCPT ); Fri, 21 Apr 2023 16:57:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233145AbjDUU5s (ORCPT ); Fri, 21 Apr 2023 16:57:48 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6C8D1FD2 for ; Fri, 21 Apr 2023 13:57:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682110621; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gCHyO7KsVFQpse/HOUPR50ds379wRgjHgpb+I1FLJjs=; b=cQQJzN5NHyvvMHmgwkX3C9YdwLqOvZ4kwhdjLXMOa5bl6ZtDiv79EPTLlTsfTAZleTjlGp Et3FHHDyzMyFLeYDySrOuxqdNjFvOlI0srGmy7iNBdDidECt+eeQvOQgYkLH0KhmgpEc3t EAyBWdya9eA69ytlUM8Z0UUe5gbPaeI= Received: from mail-yb1-f197.google.com (mail-yb1-f197.google.com [209.85.219.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-Q6eudg5jP8egD8Hpxf8scQ-1; Fri, 21 Apr 2023 16:57:00 -0400 X-MC-Unique: Q6eudg5jP8egD8Hpxf8scQ-1 Received: by mail-yb1-f197.google.com with SMTP id 3f1490d57ef6-b8f606184a3so3725076276.2 for ; Fri, 21 Apr 2023 13:57:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682110620; x=1684702620; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gCHyO7KsVFQpse/HOUPR50ds379wRgjHgpb+I1FLJjs=; b=JaZYC7EMSAnBRyPGxNonDu0HZtT0KYkZKXc+QhJspJvLl5dmio6mkBqkqqjS0prpnv jpMErtTjo+7uyDDSx44JBjZUoSthvu+x+M5JYKDdm1uRo/V/lgCgt7SORzpjtuzm+ccF vhtBxO+7+yym1XoIPzuZY3fOFVkiMHgUGBvmSfIYkPA3Yei9klyXK2CFFgtmsJvmYKeJ Sk5Kapp5UPvPyknDEZsthtngrN5uHKejT1rLSD8MXQljHWrVZPgTBaArZjG8dt+cTKm+ xWHXmbMjGidI5tE8iGbh2mF3C3f1+Fapj2ylv/saR6IeCjj2HI0Iaw0YFmHb1Um2fIUf pmdw== X-Gm-Message-State: AAQBX9csqgznZkAzgGTxZeRklvC0hlRIkMjLMYNoe2T6GDu7cOeFE602 /LqRfDsXufAq5PxSUwdN/ujBtaGxggE9RjUgSbqOJxi15hnF/B9AuCPbU6SDorhLi7Fl4Pz48QZ gqv2lEdfzNqGyAAhM5m0KUQ== X-Received: by 2002:a25:ad1e:0:b0:b97:b56e:8db6 with SMTP id y30-20020a25ad1e000000b00b97b56e8db6mr3556710ybi.60.1682110620268; Fri, 21 Apr 2023 13:57:00 -0700 (PDT) X-Google-Smtp-Source: AKy350Y4rqY6e3Xy/x6/yshw27j9TDzxWo+pJ+Kpzmmw6FsdnANP5euaf+uvyWc6Ge9omHanCEvu0Q== X-Received: by 2002:a25:ad1e:0:b0:b97:b56e:8db6 with SMTP id y30-20020a25ad1e000000b00b97b56e8db6mr3556699ybi.60.1682110619973; Fri, 21 Apr 2023 13:56:59 -0700 (PDT) Received: from halaney-x13s.attlocal.net ([2600:1700:1ff0:d0e0::22]) by smtp.gmail.com with ESMTPSA id x67-20020a0dd546000000b0054c0be459dbsm1179999ywd.39.2023.04.21.13.56.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 13:56:59 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Andrew Halaney Subject: [PATCH v3 2/4] arm64: dts: qcom: sa8155p-adp: Make -cells decimal Date: Fri, 21 Apr 2023 15:55:10 -0500 Message-Id: <20230421205512.339850-2-ahalaney@redhat.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230421205512.339850-1-ahalaney@redhat.com> References: <20230421205512.339850-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The property logically makes sense in decimal, and is the standard used elsewhere. Suggested-by: Konrad Dybcio Reviewed-by: Konrad Dybcio Signed-off-by: Andrew Halaney --- Changes since v2: * Collect tags Changes since v1: * New patch (Konrad) arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts index 029b23198b3a..ac52a8dfeba1 100644 --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts @@ -353,8 +353,8 @@ ðernet { mdio { compatible = "snps,dwmac-mdio"; - #address-cells = <0x1>; - #size-cells = <0x0>; + #address-cells = <1>; + #size-cells = <0>; /* Micrel KSZ9031RNZ PHY */ rgmii_phy: phy@7 { From patchwork Fri Apr 21 20:55:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 676382 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06F06C7618E for ; Fri, 21 Apr 2023 20:58:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233509AbjDUU6H (ORCPT ); Fri, 21 Apr 2023 16:58:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233446AbjDUU5z (ORCPT ); Fri, 21 Apr 2023 16:57:55 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC3C92109 for ; Fri, 21 Apr 2023 13:57:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682110627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O0Mtszdjlm4MgVhkShoWxFcn7UkV33phtqGTpiHGGr4=; b=F7q+120Z2AOzr1aP8thEuh4DUPkEs6jk7Xe1Ad5u87+Vs9Zanu089OfwOxHHi7ooxvXda8 ubbF4HhB9S/XIx6FNbLcxrxHKIMBzZLNq1g4UntN47h5FdNh9zKAnzWsJXwwMYfkvFCnsc BQx5l8Aw6jScyjEN4a1croF/sY5X4eg= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-245-mMEik2YNMHGFWpR6TfMIrQ-1; Fri, 21 Apr 2023 16:57:06 -0400 X-MC-Unique: mMEik2YNMHGFWpR6TfMIrQ-1 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-54bfd2c7ad6so33615767b3.2 for ; Fri, 21 Apr 2023 13:57:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682110626; x=1684702626; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O0Mtszdjlm4MgVhkShoWxFcn7UkV33phtqGTpiHGGr4=; b=Oil1PS+E6ozCJXwGUsqwMGw5LhO6ioqd/gjQnWrReQn54H84CFEHVhlWHVax7tGDoU +P6niT5gpIZFYeKivDPbKRQH79cpMsjtLFlYch7W7ZLrZDmW74sFtkNqMkUmYYiw+yUK bMFx8lFhYM0LPCCThCfAWHUAOmI1MC52Uh57YJUJkGSsypHro/6fM5BZn3LvhU5Ja+8U bwuX/1xhvqXMmUI/wY+OL643XM+Yw41A0FDNZ1olOFotoFczGpBbnAIJKzzT/fxxq74S QKMS4IavAJOzT4w1UNnO0WlzB3l4aDX3g0OGD+9+L6HSJdMzv/UEK1X34pM8xQnQ6uCd gbkg== X-Gm-Message-State: AAQBX9eAX3xcBXo06B0xounolksIhFlCt1uDwgY6gZlJwTpssoBylc/u uvkd880+CZ8uCKMDkJIC8v2BMTXa5S607tsNLdqqzfjNkRJnRCe3DD5VVzFvpQnG78h6na6pjz7 5coGCvBFwgxKB3Sy3vZccdA== X-Received: by 2002:a81:6c44:0:b0:556:1182:958a with SMTP id h65-20020a816c44000000b005561182958amr2790564ywc.24.1682110625952; Fri, 21 Apr 2023 13:57:05 -0700 (PDT) X-Google-Smtp-Source: AKy350YQDiTLclCcBihczFE91vxXgq6wBX1hK5ylVIS+7QncrEBEYfPYI8ILhGObrfq57VG337mb4w== X-Received: by 2002:a81:6c44:0:b0:556:1182:958a with SMTP id h65-20020a816c44000000b005561182958amr2790554ywc.24.1682110625659; Fri, 21 Apr 2023 13:57:05 -0700 (PDT) Received: from halaney-x13s.attlocal.net ([2600:1700:1ff0:d0e0::22]) by smtp.gmail.com with ESMTPSA id x67-20020a0dd546000000b0054c0be459dbsm1179999ywd.39.2023.04.21.13.57.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 13:57:05 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Andrew Halaney Subject: [PATCH v3 3/4] arm64: dts: qcom: sa8155p-adp: Remove unneeded rgmii_phy information Date: Fri, 21 Apr 2023 15:55:11 -0500 Message-Id: <20230421205512.339850-3-ahalaney@redhat.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230421205512.339850-1-ahalaney@redhat.com> References: <20230421205512.339850-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Using interrupts-extended already indicates what the interrupt-parent is, so drop the explicit interrupt-parent. The comment about this being the phy-intr is not helpful either, since this is the only interrupt in the phy node. Suggested-by: Konrad Dybcio Reviewed-by: Konrad Dybcio Signed-off-by: Andrew Halaney --- Changes since v2: * Collect tags Changes since v1: * New patch (Konrad) arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts index ac52a8dfeba1..b65e0203d783 100644 --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts @@ -361,8 +361,7 @@ rgmii_phy: phy@7 { compatible = "ethernet-phy-ieee802.3-c22"; reg = <0x7>; - interrupt-parent = <&tlmm>; - interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */ + interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; device_type = "ethernet-phy"; }; }; From patchwork Fri Apr 21 20:55:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 675986 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12C5BC77B7E for ; Fri, 21 Apr 2023 20:58:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233221AbjDUU6I (ORCPT ); Fri, 21 Apr 2023 16:58:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229698AbjDUU55 (ORCPT ); Fri, 21 Apr 2023 16:57:57 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0C76E74 for ; Fri, 21 Apr 2023 13:57:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682110630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GHdC3CO7d7h9QJ4WwIQBRA4b+ojZKpdU+4dGZcHHyn8=; b=bQOTqZloz1HSoIx+jB8Aj5uMCYJPSQ+Mo+6ZZ3HI/oMoT6ZYwbsEkgqq+fJ56xomI4mmmk OnjcNlgFKyhvv2TIdF+/qUf0iFlEfkJ3YBUT4Twf26bo3P3Kiywo7pCw9lI5C9qcCvpVQg jgXocHYeI2X5wLV2iqnmXLBLNG+qmAU= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-519-HzaBswq9OAShzRRB5N8jPQ-1; Fri, 21 Apr 2023 16:57:09 -0400 X-MC-Unique: HzaBswq9OAShzRRB5N8jPQ-1 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-54f6dd3b329so33740517b3.0 for ; Fri, 21 Apr 2023 13:57:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682110629; x=1684702629; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GHdC3CO7d7h9QJ4WwIQBRA4b+ojZKpdU+4dGZcHHyn8=; b=JE3CQZK0HuBX0XvWM0VCJAvjET43ZRZ4fWvyH1DZsYZaXdfHV8tlwAIGj9R4LjpE34 5E7GiFYnZq5Gg/evGRtlFn+YFdiJSqySXXv1g8PtyHf7ZLwbbFMK3zdbvWscIl5kJYlX unejiBNLEafSBtIbLzOJh57LBlmUESmf9wYSVFAKVrapPmDoQgUZx88xfuXoaduB6fRS kZMHvX4LleGWNvBQwQI/pbXUhb4lx889HveQOj0g4LCnuMhHL26byffi8ix0fALlA94M 3Enr29xlUjKQS9T5kdpPY0G6p439WhkVtaPm9TYkKpeUW661SpqS4Z4BMw+kcFMosTXK OGwQ== X-Gm-Message-State: AAQBX9fcBD7+0cyC94EaRuCA1VHQ/syg0lw/kDXTaJrT3vrnhRoOpT7D J9Mq07bMEsBPl0Dld9z5UKQmnIsX4C7BsNOBcrpdFLEEEyzMk17h6zStVv7/vrnD9XphOIqA4oM gjpVQMaZiyubxFmk2TyJzZA== X-Received: by 2002:a0d:e80e:0:b0:552:9fae:d0b with SMTP id r14-20020a0de80e000000b005529fae0d0bmr2961325ywe.16.1682110629207; Fri, 21 Apr 2023 13:57:09 -0700 (PDT) X-Google-Smtp-Source: AKy350YhmtU533lQoik67y8f8UrJHdl4W7EW+ZwOU08LNuM8hqNta/4muproajIhj5BU+Xb9HkSvqw== X-Received: by 2002:a0d:e80e:0:b0:552:9fae:d0b with SMTP id r14-20020a0de80e000000b005529fae0d0bmr2961319ywe.16.1682110628977; Fri, 21 Apr 2023 13:57:08 -0700 (PDT) Received: from halaney-x13s.attlocal.net ([2600:1700:1ff0:d0e0::22]) by smtp.gmail.com with ESMTPSA id x67-20020a0dd546000000b0054c0be459dbsm1179999ywd.39.2023.04.21.13.57.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 13:57:08 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Andrew Halaney Subject: [PATCH v3 4/4] arm64: dts: qcom: sa8155p-adp: Move mtl nodes into ethernet node Date: Fri, 21 Apr 2023 15:55:12 -0500 Message-Id: <20230421205512.339850-4-ahalaney@redhat.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230421205512.339850-1-ahalaney@redhat.com> References: <20230421205512.339850-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The mtl nodes aren't evaluated unless they're under the node with the compatible. Move them so they're now evaluated in case future patchsets modify them incorrectly. An example of this can be seen in the link. Link: https://lore.kernel.org/linux-arm-msm/20230414145844.wyg6pt623pzqwh5l@halaney-x13s/ Signed-off-by: Andrew Halaney --- Changes since v2: * New patch (me, after realizing this on another platform) arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 46 ++++++++++++------------ 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts index b65e0203d783..02d04ce877c9 100644 --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts @@ -47,29 +47,6 @@ vreg_s4a_1p8: smps4 { vin-supply = <&vreg_3p3>; }; - - mtl_rx_setup: rx-queues-config { - snps,rx-queues-to-use = <1>; - snps,rx-sched-sp; - - queue0 { - snps,dcb-algorithm; - snps,map-to-dma-channel = <0x0>; - snps,route-up; - snps,priority = <0x1>; - }; - }; - - mtl_tx_setup: tx-queues-config { - snps,tx-queues-to-use = <1>; - snps,tx-sched-wrr; - - queue0 { - snps,weight = <0x10>; - snps,dcb-algorithm; - snps,priority = <0x0>; - }; - }; }; &apps_rsc { @@ -365,6 +342,29 @@ rgmii_phy: phy@7 { device_type = "ethernet-phy"; }; }; + + mtl_rx_setup: rx-queues-config { + snps,rx-queues-to-use = <1>; + snps,rx-sched-sp; + + queue0 { + snps,dcb-algorithm; + snps,map-to-dma-channel = <0x0>; + snps,route-up; + snps,priority = <0x1>; + }; + }; + + mtl_tx_setup: tx-queues-config { + snps,tx-queues-to-use = <1>; + snps,tx-sched-wrr; + + queue0 { + snps,weight = <0x10>; + snps,dcb-algorithm; + snps,priority = <0x0>; + }; + }; }; &qupv3_id_1 {