From patchwork Tue Jun 4 15:42:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 165795 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp6024997ili; Tue, 4 Jun 2019 08:43:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqxQSmgCDTn/9o5DH+EQ+ZtOkVdDm6kRSc//1E2neid9p9tyuZN7eBjhRK5XQ2l19pdph2AB X-Received: by 2002:a0c:c612:: with SMTP id v18mr26791800qvi.215.1559663026827; Tue, 04 Jun 2019 08:43:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1559663026; cv=none; d=google.com; s=arc-20160816; b=wj/aV3ChsszU3L7mK6fEw25Elv6oqWUZIfA8ssx10PjN9ZfCPe/ljZE9a7YqF5PF42 GDyC3Y7R3wa8W5v3qTrLaF86LnU685mg67JVyYFeGn/0ZkprjxWuNv8u2BZ2VjryWhxF DuS4vqsVcIabH16QzK7TSxPPm1TbPj4HEpNBZz21+Oj4gqM3nPMYCREDdBCTy0kInTO7 ZGP5gNddU8uVOOznCXphi47dCskxOTHBe1bCOKkV2jcTDECLmo6g/YvsR6jQ106EgZ+V dY7NAjetorOTtxXFL8Wq1u8aW4C+5/o7PGQWsa68Wzayhac/tgTcosH4uumcrTCrY5jH LZjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:message-id:date:to:from :dkim-signature; bh=Bqs/6JZQ2VMQZfbn/Hm0GGVCQE4XtYgUeQQ3q0dslq4=; b=KrlcnvwJDbyQjuR1/jucQDCHEUZmvemo/LBsVCkdLv4D6GJ9BlUMI15JC7mV7qDD39 A94Rn11R/8++0YfhYMm7gENpjtChg9XjELV2Nsjk/w07CSNd5ztNqvof3eQhi0QmtjMg ZcdlJnKxT/Wu4LrdY0q3IBrEbwW4Kf8FfyLCkpMU+u6CEqzTEWXoHYllDE+K7XRI93Ly Webf6oddsC39X8ncu7QxBvROo/cKu05tb++L1SMvEngj4S60eHNDSMg0jkAwyamUMCM0 pwShiw+ia4r89iJVJxUQU9mf7gv1rLEL7m7MEG6tE/wSZMXk+iHJCy2efhczZymh2FBM Qpew== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="J74/MtX3"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id s79si4464502qka.243.2019.06.04.08.43.46 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 04 Jun 2019 08:43:46 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b="J74/MtX3"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1]:54197 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYBbG-0007WI-E5 for patch@linaro.org; Tue, 04 Jun 2019 11:43:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hYBa4-0006pk-Pd for qemu-devel@nongnu.org; Tue, 04 Jun 2019 11:42:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hYBa3-0000u0-Td for qemu-devel@nongnu.org; Tue, 04 Jun 2019 11:42:32 -0400 Received: from mail-ot1-x343.google.com ([2607:f8b0:4864:20::343]:36722) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hYBa3-0000sy-O0 for qemu-devel@nongnu.org; Tue, 04 Jun 2019 11:42:31 -0400 Received: by mail-ot1-x343.google.com with SMTP id c3so19983059otr.3 for ; Tue, 04 Jun 2019 08:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=Bqs/6JZQ2VMQZfbn/Hm0GGVCQE4XtYgUeQQ3q0dslq4=; b=J74/MtX3Ie2v94DpsEUc+TefzmsXIPBigCvEkGmUevRrgI9BPWVgyVQfUo6t9itxD5 YB5c8jis6U3LOxJ9v3J4Bmy41N+igy5N7A/5ynwCnKL1K3yhMsDTTX8n2IY+rX1DF/9Z Kd0tg6I/HTp8f7c4A8vqDwRPaxUbnmmffWw8JZ3S2UaDEKzNP/ww3jQi5VyrPXIIYrae c9bzTjqo7+E9zvfFj1UE0Anpx9mC9TUcNHxmhwH+yGkM6Lw8GmlgrkuvPa0OrFgfK5Qh 2ObGnbsKYDuzeSvryQeamo8LStimXINoQSfrRYkTTaurQHZPEAe/lrjEKQgtA5qvwywr HucQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Bqs/6JZQ2VMQZfbn/Hm0GGVCQE4XtYgUeQQ3q0dslq4=; b=rEnrWw91MQezixzOCynS2sVZQv+uDdAY+EYZj/yQK2DMtnZGzT4K0jUON89/KwAAGS Selrm8Kwg1OA7t70Rfm5zaPWSvUgpBZMG6TqQHRrzluhiCG8Xnj/wW6bbUIq0m5Cq6Ih Dqhqh0IC0+Q6+yJqosPzgI2UkzduovxyBgoyvN90+4U4PHNarJ0cwWWv+pHXON22Xa75 bqMfb8RpknGGaAzwse6aUKwBRabxZzGnQCjm9EQun2PA7ZfYVDc4UrOSOxQwa6RfCXeT Dclvt4tiGqJ8WJx1Jm1gTKNnj3zmNnTaYcvaRKB0ACjBNY+QPJ0vje2A833m3yjSnPaB VBqA== X-Gm-Message-State: APjAAAWIhKIQ51ZjJ9gkq4N5wM4GhtJP9bY2LyxLIumLygw7lew8flz3 7W0111q1pNj9Gr6I7i/fkn2g053q0rmc/w== X-Received: by 2002:a9d:7dd9:: with SMTP id k25mr4460406otn.350.1559662949922; Tue, 04 Jun 2019 08:42:29 -0700 (PDT) Received: from localhost.localdomain (200-56-192-86-cable.cybercable.net.mx. [200.56.192.86]) by smtp.gmail.com with ESMTPSA id e4sm6277421oti.64.2019.06.04.08.42.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jun 2019 08:42:28 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 4 Jun 2019 10:42:25 -0500 Message-Id: <20190604154225.26992-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::343 Subject: [Qemu-devel] [PATCH] decodetree: Fix comparison of Field X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Typo comparing the sign of the field, twice, instead of also comparing the mask of the field (which itself encodes both position and length). Reported-by: Peter Maydell Signed-off-by: Richard Henderson --- scripts/decodetree.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé diff --git a/scripts/decodetree.py b/scripts/decodetree.py index 81874e22cc..d7a59d63ac 100755 --- a/scripts/decodetree.py +++ b/scripts/decodetree.py @@ -184,7 +184,7 @@ class Field: return '{0}(insn, {1}, {2})'.format(extr, self.pos, self.len) def __eq__(self, other): - return self.sign == other.sign and self.sign == other.sign + return self.sign == other.sign and self.mask == other.mask def __ne__(self, other): return not self.__eq__(other)