From patchwork Tue May 16 13:22:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Nyekjaer X-Patchwork-Id: 683646 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 953D1C77B75 for ; Tue, 16 May 2023 13:42:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233691AbjEPNmJ (ORCPT ); Tue, 16 May 2023 09:42:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231921AbjEPNmI (ORCPT ); Tue, 16 May 2023 09:42:08 -0400 Received: from www530.your-server.de (www530.your-server.de [188.40.30.78]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CE0E525D; Tue, 16 May 2023 06:42:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=geanix.com; s=default2211; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References; bh=os+G1rXah/n1/LkF2j06vBjeVF9v8Ni3Nx7kcpejEtg=; b=BfRTSDAhCmGWAMkKGs6A6DRixE DKIDo8AtrBRtdb0kBFWwAd1feS9hSTnJoCl7uMHZsbBAq7aHaSzK1RnE06T/aedo1BRYfrxn6YJnn dDo/T1dpIKjlS0sIjhRDI8omMQQGy7Wrsc0ejGCoo7/IOUMVSZT0cxsFBdcS8uDb11vZhefyVlVDY H85JrxHaKkcvkLc/FaBAr9eYgDeyNOiN3cSrT37wUxWosjE7qX9wsIL/LGUi29acTIhjL+gkXlhwd y0+JS+NSVxRAl7XPojtbjb5Mdbt1jBfe/TT1hhaSaxgXFViYtGOeJ44b/dAWhjaQM2zGEhspMokke QJLDxmhg==; Received: from sslproxy03.your-server.de ([88.198.220.132]) by www530.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pyudZ-000AIx-W7; Tue, 16 May 2023 15:22:46 +0200 Received: from [185.17.218.86] (helo=zen..) by sslproxy03.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pyudZ-000NS5-KO; Tue, 16 May 2023 15:22:45 +0200 From: Sean Nyekjaer To: robh+dt@kernel.org, Lee Jones Cc: devicetree@vger.kernel.org, Sean Nyekjaer , linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] mfd: stpmic1: fixup main control register and bits naming Date: Tue, 16 May 2023 15:22:22 +0200 Message-Id: <20230516132225.3012541-1-sean@geanix.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-Authenticated-Sender: sean@geanix.com X-Virus-Scanned: Clear (ClamAV 0.103.8/26908/Tue May 16 09:24:20 2023) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Fixup main control register and bits naming so the match the naming from the datasheet. https://www.st.com/resource/en/datasheet/stpmic1.pdf Signed-off-by: Sean Nyekjaer --- Changes since v1: - None drivers/mfd/stpmic1.c | 4 ++-- include/linux/mfd/stpmic1.h | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/mfd/stpmic1.c b/drivers/mfd/stpmic1.c index 8db1530d9bac..4c9b18d9dec8 100644 --- a/drivers/mfd/stpmic1.c +++ b/drivers/mfd/stpmic1.c @@ -19,7 +19,7 @@ static const struct regmap_range stpmic1_readable_ranges[] = { regmap_reg_range(TURN_ON_SR, VERSION_SR), - regmap_reg_range(SWOFF_PWRCTRL_CR, LDO6_STDBY_CR), + regmap_reg_range(MAIN_CR, LDO6_STDBY_CR), regmap_reg_range(BST_SW_CR, BST_SW_CR), regmap_reg_range(INT_PENDING_R1, INT_PENDING_R4), regmap_reg_range(INT_CLEAR_R1, INT_CLEAR_R4), @@ -30,7 +30,7 @@ static const struct regmap_range stpmic1_readable_ranges[] = { }; static const struct regmap_range stpmic1_writeable_ranges[] = { - regmap_reg_range(SWOFF_PWRCTRL_CR, LDO6_STDBY_CR), + regmap_reg_range(MAIN_CR, LDO6_STDBY_CR), regmap_reg_range(BST_SW_CR, BST_SW_CR), regmap_reg_range(INT_CLEAR_R1, INT_CLEAR_R4), regmap_reg_range(INT_SET_MASK_R1, INT_SET_MASK_R4), diff --git a/include/linux/mfd/stpmic1.h b/include/linux/mfd/stpmic1.h index fa3f99f7e9a1..dc00bac24f5a 100644 --- a/include/linux/mfd/stpmic1.h +++ b/include/linux/mfd/stpmic1.h @@ -15,7 +15,7 @@ #define RREQ_STATE_SR 0x5 #define VERSION_SR 0x6 -#define SWOFF_PWRCTRL_CR 0x10 +#define MAIN_CR 0x10 #define PADS_PULL_CR 0x11 #define BUCKS_PD_CR 0x12 #define LDO14_PD_CR 0x13 @@ -148,14 +148,14 @@ #define LDO_BYPASS_MASK BIT(7) /* Main PMIC Control Register - * SWOFF_PWRCTRL_CR + * MAIN_CR * Address : 0x10 */ -#define ICC_EVENT_ENABLED BIT(4) +#define OCP_OFF_DBG BIT(4) #define PWRCTRL_POLARITY_HIGH BIT(3) -#define PWRCTRL_PIN_VALID BIT(2) -#define RESTART_REQUEST_ENABLED BIT(1) -#define SOFTWARE_SWITCH_OFF_ENABLED BIT(0) +#define PWRCTRL_ENABLE BIT(2) +#define RESTART_REQUEST_ENABLE BIT(1) +#define SOFTWARE_SWITCH_OFF BIT(0) /* Main PMIC PADS Control Register * PADS_PULL_CR From patchwork Tue May 16 13:22:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Nyekjaer X-Patchwork-Id: 682698 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B944C77B7F for ; Tue, 16 May 2023 13:38:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232834AbjEPNiD (ORCPT ); Tue, 16 May 2023 09:38:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232657AbjEPNiD (ORCPT ); Tue, 16 May 2023 09:38:03 -0400 X-Greylist: delayed 912 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 16 May 2023 06:38:00 PDT Received: from www530.your-server.de (www530.your-server.de [188.40.30.78]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0408CA; Tue, 16 May 2023 06:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=geanix.com; s=default2211; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID; bh=4OVpla0e3KhLB8EpKpRBFad9oNXZVOLCvEDNQKceCdM=; b=A2eVFsVZ6ivdKi28ZHruVlSUvr Clze0kziSRRWxUPjXgwdYnsXE5o1eqBSuVISLnamRXVKO4z3sA94HdgVWzWI0sR3Fex31thzrq8dh YoCLPCZEOwkjmv+QWeo1zm1cjiYs1OYMLxeJxoGKasUKq2vK6SZVFiwP0Kx0WjetLmywLvL+stiHN OWWoVKXqxXhDFnF/31wvqstuAV6DNPOGpcq9U53a8cuLXk4fIr7M2SGht95/dTpSLcfn+rGwCjK4S brApjDiqxYtcusrs/abErYAQ4wLHx4Dts3dXW4z8nbyvDJylRoALO4EKiti8DN59ZQ5Zox2WCFhgx z+5kMeLw==; Received: from sslproxy03.your-server.de ([88.198.220.132]) by www530.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pyuda-000AJ6-EB; Tue, 16 May 2023 15:22:46 +0200 Received: from [185.17.218.86] (helo=zen..) by sslproxy03.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pyuda-000NS5-5w; Tue, 16 May 2023 15:22:46 +0200 From: Sean Nyekjaer To: robh+dt@kernel.org, Lee Jones Cc: devicetree@vger.kernel.org, Sean Nyekjaer , linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] mfd: stpmic1: add pmic poweroff via sys-off handler Date: Tue, 16 May 2023 15:22:23 +0200 Message-Id: <20230516132225.3012541-2-sean@geanix.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230516132225.3012541-1-sean@geanix.com> References: <20230516132225.3012541-1-sean@geanix.com> MIME-Version: 1.0 X-Authenticated-Sender: sean@geanix.com X-Virus-Scanned: Clear (ClamAV 0.103.8/26908/Tue May 16 09:24:20 2023) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Use devm_register_sys_off_handler() that allows to register multiple power-off handlers. This can be enabled by adding "st,pmic-poweroff" to device-tree. Signed-off-by: Sean Nyekjaer --- Changes since v1: - Removed superfluous function drivers/mfd/stpmic1.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/drivers/mfd/stpmic1.c b/drivers/mfd/stpmic1.c index 4c9b18d9dec8..5b82cd37d57a 100644 --- a/drivers/mfd/stpmic1.c +++ b/drivers/mfd/stpmic1.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -117,6 +118,16 @@ static const struct regmap_irq_chip stpmic1_regmap_irq_chip = { .num_irqs = ARRAY_SIZE(stpmic1_irqs), }; +static int stpmic1_power_off(struct sys_off_data *data) +{ + struct stpmic1 *ddata = data->cb_data; + + regmap_update_bits(ddata->regmap, MAIN_CR, + SOFTWARE_SWITCH_OFF, SOFTWARE_SWITCH_OFF); + + return NOTIFY_DONE; +} + static int stpmic1_probe(struct i2c_client *i2c) { struct stpmic1 *ddata; @@ -159,6 +170,18 @@ static int stpmic1_probe(struct i2c_client *i2c) return ret; } + if (of_property_read_bool(i2c->dev.of_node, "st,pmic-poweroff")) { + ret = devm_register_sys_off_handler(ddata->dev, + SYS_OFF_MODE_POWER_OFF, + SYS_OFF_PRIO_DEFAULT, + stpmic1_power_off, + ddata); + if (ret) { + dev_err(ddata->dev, "failed to register sys-off handler: %d\n", ret); + return ret; + } + } + return devm_of_platform_populate(dev); } From patchwork Tue May 16 13:22:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Nyekjaer X-Patchwork-Id: 683648 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 522E6C77B7A for ; Tue, 16 May 2023 13:38:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233643AbjEPNiI (ORCPT ); Tue, 16 May 2023 09:38:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233298AbjEPNiG (ORCPT ); Tue, 16 May 2023 09:38:06 -0400 Received: from www530.your-server.de (www530.your-server.de [188.40.30.78]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1086CA; Tue, 16 May 2023 06:38:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=geanix.com; s=default2211; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID; bh=Tc4N6cacmpKk5k4on8VEF7pB3edhIp5X8MzTz70xu0Q=; b=V4ydLiGbTg7AztiSATz1zSo8dd DlIqofKsUzJRdOOOpdJkrzr2lEM6WLJUl85oHIz7IEhdy0L+1m3enmVBD8rqHhx7IMz/0rPeDb4IS uz4zS3Q3eaVS8qxMrJPKO0CtQdJzn3GyeAswiDYe28gMofn0hyBOvKM79cwYKmDTQt8ChzlHd5/lG hVzYTnuPZtlfEEybVZDjanyl9Y4fVsvDdgjvQNEeg9O3DMjclBjVYYYylhCE1ppgrYwU/w99xYO77 jJsgQTdV0hPKWRkgF3vMNiDOkyHqfhTBB0VllVO6OAHqiOuV/w1aPTyc+oJtYj4vr9kkqKFcniFk3 mPWZNKmg==; Received: from sslproxy03.your-server.de ([88.198.220.132]) by www530.your-server.de with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pyudb-000AJG-94; Tue, 16 May 2023 15:22:47 +0200 Received: from [185.17.218.86] (helo=zen..) by sslproxy03.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pyuda-000NS5-RA; Tue, 16 May 2023 15:22:46 +0200 From: Sean Nyekjaer To: robh+dt@kernel.org, Lee Jones , Krzysztof Kozlowski , Conor Dooley , pascal Paillet Cc: devicetree@vger.kernel.org, Sean Nyekjaer , linux-kernel@vger.kernel.org Subject: [PATCH v2 3/3] dt-bindings: mfd: stpmic1: add fsl,pmic-poweroff property Date: Tue, 16 May 2023 15:22:24 +0200 Message-Id: <20230516132225.3012541-3-sean@geanix.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230516132225.3012541-1-sean@geanix.com> References: <20230516132225.3012541-1-sean@geanix.com> MIME-Version: 1.0 X-Authenticated-Sender: sean@geanix.com X-Virus-Scanned: Clear (ClamAV 0.103.8/26908/Tue May 16 09:24:20 2023) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Document the new optional "fsl,pmic-poweroff" property. Signed-off-by: Sean Nyekjaer --- Documentation/devicetree/bindings/mfd/st,stpmic1.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml index 9573e4af949e..5183a7c660d2 100644 --- a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml +++ b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml @@ -26,6 +26,14 @@ properties: interrupt-controller: true + st,pmic-poweroff: + $ref: /schemas/types.yaml#/definitions/flag + description: | + if present, configure the PMIC to shutdown all power rails when + power off sequence have finished. + Use this option if the SoC should be powered off by external power management + IC (PMIC). + onkey: type: object