From patchwork Wed Jun 12 10:27:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 166535 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp3500873ilk; Wed, 12 Jun 2019 03:29:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqxFUHjntTcz2PMH0JUIRp4Hebp9J0ifOB3qYBVEahImNf2w8C/MMHUGrhGNQ1hUi6Bdxs/P X-Received: by 2002:a62:834d:: with SMTP id h74mr41197287pfe.254.1560335380443; Wed, 12 Jun 2019 03:29:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560335380; cv=none; d=google.com; s=arc-20160816; b=v0AqNYBGQcl9rJ94tqwrr1VRiLR1+a8dHxJCngudpj7e3eC1oFSoWvKU5EeiLRIS9z 9v+BAkx6JZ43PlIMm3xvnb2+K+PXhdeC+bHJRSCVhCd63pwpb0ap/V9WE4iBi73cVodH gTS1AGtYhRf3QsTjKJOfwlhPliFVcdMrtoMrm466sQt+pYfxAIlMy9RmfRw7awfUDOJ6 wZwESCe4E6bvFxERz4HT9j4axObgq8Ugh/zfPqsIkD9v52OymHvQs98Mm7MJnhcujf4w Ml3FyYGs047la+yPf5wOrQ7BVugx+Z+7AqKvljDyNCTOJHLTo2bpJ4MWkWYyHeLqClTZ PMtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=zxm1FjfX6D/JCJLoutYxeRUaHa9o4a+DtA7mM8KCfTA=; b=PwT1laSs7ph1w4ygof0f89egMh4Q+696CrTD/leJK6bzVGjy7i0j5JRKKOfPFC8+NE woUyQMSkO7PAn7uerL96p34DYR7R2cGRziRsLRKSrjtAn0srdRV30uMGBPMhRdDq06Ye HK6z9k7pZ9HmUkSafLd1N02d+HyK0e5VDRrvXodZAz/zMjCjJ9KvulAMTgb/JUvFAE97 GRS+0/0bPAKmnCNCERHHdmwy+/9b17EBYUGQgiLxEfFsnGrKQO5aFRd7lMsoyDPCVvZH BXrtBxW3jHlCvZKfMNhEdPXZSH20h6doo49DPQn4vKpvRKywDC5oOZZhFbcK25u00xUN HfUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=wi60MvvI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a8si9182572pls.118.2019.06.12.03.29.40; Wed, 12 Jun 2019 03:29:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=wi60MvvI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732150AbfFLK3j (ORCPT + 30 others); Wed, 12 Jun 2019 06:29:39 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:56396 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732130AbfFLK3j (ORCPT ); Wed, 12 Jun 2019 06:29:39 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id x5CATbEG031899; Wed, 12 Jun 2019 05:29:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1560335377; bh=zxm1FjfX6D/JCJLoutYxeRUaHa9o4a+DtA7mM8KCfTA=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=wi60MvvIm+gMGlnlBpdcrLUC3rEekZeUiBp/8KDwm2PU+8qH3aHd/+7GpQozO3pw7 QbOjxIYrNhjnyxuR/XHweMBcLNz7hZRemepBfDCo4VY/qecJhaxyI6TE3aCKWaKJCC 56sSBjI7AbFZ5j8sbejpotrzw3wDeQwSEvLRrZmU= Received: from DLEE107.ent.ti.com (dlee107.ent.ti.com [157.170.170.37]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x5CATbPX085272 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 12 Jun 2019 05:29:37 -0500 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 12 Jun 2019 05:29:37 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Wed, 12 Jun 2019 05:29:37 -0500 Received: from a0393678ub.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id x5CATTJX128310; Wed, 12 Jun 2019 05:29:34 -0500 From: Kishon Vijay Abraham I To: Greg Kroah-Hartman , CC: Subject: [PATCH 1/6] phy: qcom-qusb2: fix missing assignment of ret when calling clk_prepare_enable Date: Wed, 12 Jun 2019 15:57:58 +0530 Message-ID: <20190612102803.25398-2-kishon@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190612102803.25398-1-kishon@ti.com> References: <20190612102803.25398-1-kishon@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The error return from the call to clk_prepare_enable is not being assigned to variable ret even though ret is being used to check if the call failed. Fix this by adding in the missing assignment. Addresses-Coverity: ("Logically dead code") Fixes: 891a96f65ac3 ("phy: qcom-qusb2: Add support for runtime PM") Signed-off-by: Colin Ian King Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/qualcomm/phy-qcom-qusb2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c index 1cbf1d6f28ce..bf94a52d3087 100644 --- a/drivers/phy/qualcomm/phy-qcom-qusb2.c +++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c @@ -564,7 +564,7 @@ static int __maybe_unused qusb2_phy_runtime_resume(struct device *dev) } if (!qphy->has_se_clk_scheme) { - clk_prepare_enable(qphy->ref_clk); + ret = clk_prepare_enable(qphy->ref_clk); if (ret) { dev_err(dev, "failed to enable ref clk, %d\n", ret); goto disable_ahb_clk; From patchwork Wed Jun 12 10:27:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 166536 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp3500936ilk; Wed, 12 Jun 2019 03:29:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqzs8+nsREzcZa42qgcmMeOFeugzwDZyFkmTtc9Hz+lnSRz9yzMA/pg7S8oqzhQ50wJeIEbD X-Received: by 2002:a62:4e0c:: with SMTP id c12mr83939438pfb.17.1560335386172; Wed, 12 Jun 2019 03:29:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560335386; cv=none; d=google.com; s=arc-20160816; b=QF29yAJTzcHycXoySCRXgMR/a289kkY9c1Om4yLB5ekpVRlD20CbMTcWtd2C99Q7Qy 9Rf9RYNA7di73vl87UxBIyW7aFjcfPGuN1ruVYma2DkCc7TPLDU/zQY0nOvoq49zPzlj MBqHuWFcCrl2SRljUh/kxBqICood+q+hN2F6bW2zsnleyGl1Lc/iWaRYxA2oVaGKo8pz psQ/DTRgm7BKIwcwb2G9mW847mWTmJMAHrmFxOOHpa3VN7oAHrCfrF5xww49/t31FOXZ THCMWC96Olun0XTScvxF5aOCYh77MO2lt7yhi8DFLXKW5nYbS2J2f5+Hq23HZOdQtm+k bojw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=XXQQt6ZHl5//GgviHhkN4bTJC0kM8bhZ0blS56iER00=; b=Dr56/h8yfioGcTWOGbj2ie0e9QUdwpzQBfwGMmbixPEJgzNXShoS7SzWCfxgr1XnVi 3DjKKAId8v44mJZxb/inkvoU2Xi7ewXlWELAUy+MnmGznFcjjjsMOCW2Z60offKfptaQ fOiRGUOMRRoA2Pl6df/BZLsI8LvCyzmykKBfU+MmoH4WSdKq6CInxsnwFUmv1uT7f2yE iwyt3zvz99QJPHHHE/NNV6LqMPqcGeoXn5uxGa1f1aviBeMbs2D9ACceqRbfc3/i556V S2/AFTRAzzOnOcW1HaZ8W0PtmF3y6AKy6o5mstagiwoAiHRHCTjOoRXW6luTf+M+cT4h 0Byw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=UeKd8cFz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m7si4960819pjs.63.2019.06.12.03.29.45; Wed, 12 Jun 2019 03:29:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=UeKd8cFz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732170AbfFLK3o (ORCPT + 30 others); Wed, 12 Jun 2019 06:29:44 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:48708 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732151AbfFLK3o (ORCPT ); Wed, 12 Jun 2019 06:29:44 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x5CAThgQ130060; Wed, 12 Jun 2019 05:29:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1560335383; bh=XXQQt6ZHl5//GgviHhkN4bTJC0kM8bhZ0blS56iER00=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=UeKd8cFzwa9AZ9GwxbAV6VYbVIUV/+VBy0y2594XmqkX5c/BceAYwpaH2vQqNhrd3 C4Gwvi3FrAU1AxjdaoVb4WAyvz5rq7wx2lDNv3lmj5Ncbqz+N9eetdKBpInSOr8d9R V+HW+WcujfBV4pHDF0xl21ZqtQreDb3wcgvQ44Uk= Received: from DFLE104.ent.ti.com (dfle104.ent.ti.com [10.64.6.25]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x5CAThE3038492 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 12 Jun 2019 05:29:43 -0500 Received: from DFLE113.ent.ti.com (10.64.6.34) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 12 Jun 2019 05:29:43 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Wed, 12 Jun 2019 05:29:43 -0500 Received: from a0393678ub.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id x5CATTJY128310; Wed, 12 Jun 2019 05:29:39 -0500 From: Kishon Vijay Abraham I To: Greg Kroah-Hartman , CC: Subject: [PATCH 2/6] phy: renesas: rcar-gen2: Fix memory leak at error paths Date: Wed, 12 Jun 2019 15:57:59 +0530 Message-ID: <20190612102803.25398-3-kishon@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190612102803.25398-1-kishon@ti.com> References: <20190612102803.25398-1-kishon@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yoshihiro Shimoda This patch fixes memory leak at error paths of the probe function. In for_each_child_of_node, if the loop returns, the driver should call of_put_node() before returns. Reported-by: Julia Lawall Fixes: 1233f59f745b237 ("phy: Renesas R-Car Gen2 PHY driver") Signed-off-by: Yoshihiro Shimoda Reviewed-by: Geert Uytterhoeven Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/renesas/phy-rcar-gen2.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.17.1 diff --git a/drivers/phy/renesas/phy-rcar-gen2.c b/drivers/phy/renesas/phy-rcar-gen2.c index 8dc5710d9c98..2926e4937301 100644 --- a/drivers/phy/renesas/phy-rcar-gen2.c +++ b/drivers/phy/renesas/phy-rcar-gen2.c @@ -391,6 +391,7 @@ static int rcar_gen2_phy_probe(struct platform_device *pdev) error = of_property_read_u32(np, "reg", &channel_num); if (error || channel_num > 2) { dev_err(dev, "Invalid \"reg\" property\n"); + of_node_put(np); return error; } channel->select_mask = select_mask[channel_num]; @@ -406,6 +407,7 @@ static int rcar_gen2_phy_probe(struct platform_device *pdev) data->gen2_phy_ops); if (IS_ERR(phy->phy)) { dev_err(dev, "Failed to create PHY\n"); + of_node_put(np); return PTR_ERR(phy->phy); } phy_set_drvdata(phy->phy, phy); From patchwork Wed Jun 12 10:28:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 166537 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp3501010ilk; Wed, 12 Jun 2019 03:29:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqwctGzQ6UGt6eK4JMnVzHAhVCroq33NZargFxtTajt2a+72Ppwkp2cUAgl936lME1FMfdXw X-Received: by 2002:a63:6cc3:: with SMTP id h186mr24223816pgc.292.1560335391050; Wed, 12 Jun 2019 03:29:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560335391; cv=none; d=google.com; s=arc-20160816; b=V/AK0PgZjER5q2AvKqD1lhCb8jCxMA/3RWhUw3rc6/05lt0j8KYSYQ5wSAgXg9C4Pv 4B1mygFPFRG2hQ2HyMZX+MInCuQneblg42VXzaEJHvpRzByrCI9RcM601BKYzPgTWFd7 97yj9nVv6CEprNUnsETMnEuPEfvJIVOB9sQRtdVJEoA9ygRWkWYvuWCgHCM4MffETvih /i9E8yUhFnknoiolo+NW1v9/YLsxzwD2kLGFxHKf7t2dfsbp2hpvqr6IH71vOJhPCqQ1 kfbzCjPm0oWrEsSteGbiflUFfSvxPLAOFZie2h/3CIriw0Lsf8oht6eB8qDPRmr9Tjdw iekQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=ivsc2x+9Cpl6a1E43O1kQ1pwGbkzvrUAuWeBZqbf3o4=; b=MpWK1SZogw7kJyI3ggH3Y5wNI+SrXma9JFVu4vLCRMCWqT6Ze3BqlR4BU+/go1cIh3 IUYbf9pXk6/hIst5Yjn9mwF2xq44wsLDmBEJmGbDTZNfW38inidOya5pXmilISauXZdf ax4TClR88yPnQaRi5mp3EftZnlpUicq/Yelyu/FdBBaEKduh1B3l8FaEgQVuS4KTSUxb wDJHUDQTk4eNwkKcJpQ/58DaRZwPxDcUYVZ5KnqBMqevUuaRqbqY9KUThpuWUdUlvdRY PqKCpChCTMSTigjDZtWJ1y2VhYVi4Om7QMFdLa4JFFCqTYGYy34hN8y2h5o/kgjHlQ8F pXdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=Qmn73KdF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m7si4960819pjs.63.2019.06.12.03.29.50; Wed, 12 Jun 2019 03:29:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=Qmn73KdF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732186AbfFLK3u (ORCPT + 30 others); Wed, 12 Jun 2019 06:29:50 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:44122 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732151AbfFLK3t (ORCPT ); Wed, 12 Jun 2019 06:29:49 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x5CATm2X040369; Wed, 12 Jun 2019 05:29:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1560335388; bh=ivsc2x+9Cpl6a1E43O1kQ1pwGbkzvrUAuWeBZqbf3o4=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=Qmn73KdFoZaYqSzzP0oL4UxSgyZ/LFJyrGDQOaSZ1UQuyIBuAThg1Iy+ibWtrDKyY fgKa6BygTZ3R0bukqK/UppJ6XlQFAP6A7JqW02RmanRM0qLog8B/RKF83eYdJyDhlr R5bs88mmIZSfhCRQnGI/LD9KEJ1kJbyq9uojQpGU= Received: from DLEE107.ent.ti.com (dlee107.ent.ti.com [157.170.170.37]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x5CATmdK089701 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 12 Jun 2019 05:29:48 -0500 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 12 Jun 2019 05:29:48 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Wed, 12 Jun 2019 05:29:48 -0500 Received: from a0393678ub.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id x5CATTJZ128310; Wed, 12 Jun 2019 05:29:44 -0500 From: Kishon Vijay Abraham I To: Greg Kroah-Hartman , CC: Subject: [PATCH 3/6] phy: usb: phy-brcm-usb: Remove sysfs attributes upon driver removal Date: Wed, 12 Jun 2019 15:58:00 +0530 Message-ID: <20190612102803.25398-4-kishon@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190612102803.25398-1-kishon@ti.com> References: <20190612102803.25398-1-kishon@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli We are not destroying the sysfs attribute groupe we registered during the probe function which will make subsequent probe calls to that driver fail. Correct that with adding a remove function which only removes those attributes since the reference counting on clocks did its job already. Fixes: 415060b21f31 ("phy: usb: phy-brcm-usb: Add ability to force DRD mode to host or device") Signed-off-by: Florian Fainelli Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/broadcom/phy-brcm-usb.c | 8 ++++++++ 1 file changed, 8 insertions(+) -- 2.17.1 diff --git a/drivers/phy/broadcom/phy-brcm-usb.c b/drivers/phy/broadcom/phy-brcm-usb.c index f59b1dc30399..292d5b3fc66c 100644 --- a/drivers/phy/broadcom/phy-brcm-usb.c +++ b/drivers/phy/broadcom/phy-brcm-usb.c @@ -376,6 +376,13 @@ static int brcm_usb_phy_probe(struct platform_device *pdev) return PTR_ERR_OR_ZERO(phy_provider); } +static int brcm_usb_phy_remove(struct platform_device *pdev) +{ + sysfs_remove_group(&pdev->dev.kobj, &brcm_usb_phy_group); + + return 0; +} + #ifdef CONFIG_PM_SLEEP static int brcm_usb_phy_suspend(struct device *dev) { @@ -441,6 +448,7 @@ MODULE_DEVICE_TABLE(of, brcm_usb_dt_ids); static struct platform_driver brcm_usb_driver = { .probe = brcm_usb_phy_probe, + .remove = brcm_usb_phy_remove, .driver = { .name = "brcmstb-usb-phy", .owner = THIS_MODULE, From patchwork Wed Jun 12 10:28:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 166538 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp3501090ilk; Wed, 12 Jun 2019 03:29:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqwnww4OYCa3GGKsXoOf1bE1yOyHbe93XYpSP+aPoDTUXbbAqucr9TcV/WUK0hjYtLP3i3vW X-Received: by 2002:aa7:8083:: with SMTP id v3mr6980910pff.69.1560335396256; Wed, 12 Jun 2019 03:29:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560335396; cv=none; d=google.com; s=arc-20160816; b=pvWnfA3o5GsUpEuTSQq5wwYz6LAg/ZCeShUqL19PQ8dpdy8gHNT0/SfqXNUFSPZhhc 7fYGINFIW1gMmN/bA9cw/RdP7jZq4rZxI7T4O5hY0DwSlET/R/c6tsHCM2Fl+x5i7BWj 0ncDtExv+CuZnQJrUt/qlsqTawcxrT/JswFsEvueQVW8QpL6PsmxN6Sp43054DigWRw+ HDF0ZNcdDgzKN0K+u1FuWBal6qIYYE7/QtctBbUdfpXUojuf5u2QWuobibcccb16hCfg FO4c3KTyHwtTwnquKQgxf6LqlbSfNkDj0Pd3BTFEZnbIDBluP/qbquwI98BLXHpe/4Ym RLkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=IdaQjdXlt1IrKCg6uSGP7IL6H1ZHedEZAA0iGbkCJKA=; b=tQYzqa1bppwEpr87OqdsXrTnBP8izF0e2THtM9O5JbHyEcSJcOJ/F9rKR3PcjQj7CC dSxmldVwMERBPmjTcFmFkjyJrwRCd5gDGDenynbNiNNCQG6qCqra5f2u5Xh9S1Q47q3h ktD3BLX4bnXQQjCwKiYBpV2yIU6es+9CwqHxezM2SuslQP26AcMvlekGUFQIBajKVo3Z ElDQ1YKQy4ViMQMOWz2F56JrLDWowzyY10DiMPacI9zdUQmP7QGApC74UqtDDL39Y5Md 8KnoX4/zhsJgDmtSrMngmW02ZJv/ghIDAM5HC0Eat4zUD8Hg1Hx2IMwvKqIlM8lOgH6i zMbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=UZSfp15x; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m7si4960819pjs.63.2019.06.12.03.29.55; Wed, 12 Jun 2019 03:29:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=UZSfp15x; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732199AbfFLK3z (ORCPT + 30 others); Wed, 12 Jun 2019 06:29:55 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:56410 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727846AbfFLK3w (ORCPT ); Wed, 12 Jun 2019 06:29:52 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id x5CATpC1031934; Wed, 12 Jun 2019 05:29:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1560335391; bh=IdaQjdXlt1IrKCg6uSGP7IL6H1ZHedEZAA0iGbkCJKA=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=UZSfp15xhQUA01lGq8g/mVjJrFVH6cLh8pYyGhjagFLuLsWNJUiaE1BLlsXGOwD9k ozHS+GUcYlOlv/laVcoPT8CLBXJviriGr5Y4pPrRej9PXJVD92ySsbcMxRWirSNrVN df+GYprFd0HxmNvqA19eRD+OJCbasn3E9yTUGeK8= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x5CATpBj085393 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 12 Jun 2019 05:29:51 -0500 Received: from DLEE107.ent.ti.com (157.170.170.37) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 12 Jun 2019 05:29:51 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Wed, 12 Jun 2019 05:29:51 -0500 Received: from a0393678ub.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id x5CATTJa128310; Wed, 12 Jun 2019 05:29:49 -0500 From: Kishon Vijay Abraham I To: Greg Kroah-Hartman , CC: Subject: [PATCH 4/6] dt-bindings: phy: tegra-xusb: List PLL power supplies Date: Wed, 12 Jun 2019 15:58:01 +0530 Message-ID: <20190612102803.25398-5-kishon@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190612102803.25398-1-kishon@ti.com> References: <20190612102803.25398-1-kishon@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thierry Reding These power supplies provide power for various PLLs that are set up and driven by the XUSB pad controller. These power supplies were previously improperly added to the PCIe and XUSB controllers, but depending on the driver probe order, power to the PLLs will not be supplied soon enough and cause initialization to fail. Reviewed-by: Rob Herring Signed-off-by: Thierry Reding Acked-by: Jon Hunter Signed-off-by: Kishon Vijay Abraham I --- .../bindings/phy/nvidia,tegra124-xusb-padctl.txt | 12 ++++++++++++ 1 file changed, 12 insertions(+) -- 2.17.1 diff --git a/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt b/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt index daedb15f322e..9fb682e47c29 100644 --- a/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt +++ b/Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt @@ -42,6 +42,18 @@ Required properties: - reset-names: Must include the following entries: - "padctl" +For Tegra124: +- avdd-pll-utmip-supply: UTMI PLL power supply. Must supply 1.8 V. +- avdd-pll-erefe-supply: PLLE reference PLL power supply. Must supply 1.05 V. +- avdd-pex-pll-supply: PCIe/USB3 PLL power supply. Must supply 1.05 V. +- hvdd-pex-pll-e-supply: High-voltage PLLE power supply. Must supply 3.3 V. + +For Tegra210: +- avdd-pll-utmip-supply: UTMI PLL power supply. Must supply 1.8 V. +- avdd-pll-uerefe-supply: PLLE reference PLL power supply. Must supply 1.05 V. +- dvdd-pex-pll-supply: PCIe/USB3 PLL power supply. Must supply 1.05 V. +- hvdd-pex-pll-e-supply: High-voltage PLLE power supply. Must supply 1.8 V. + For Tegra186: - avdd-pll-erefeut-supply: UPHY brick and reference clock as well as UTMI PHY power supply. Must supply 1.8 V. From patchwork Wed Jun 12 10:28:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 166539 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp3501125ilk; Wed, 12 Jun 2019 03:29:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqw3amfXu3FvYf8gqKmLOnJ6gyNdFMgmhYCz5euvHRgP6quSKOXg5tuWwhwa2tkuNEKjG43x X-Received: by 2002:a63:1a59:: with SMTP id a25mr17414894pgm.173.1560335399552; Wed, 12 Jun 2019 03:29:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560335399; cv=none; d=google.com; s=arc-20160816; b=Wsjjh9eUXb0YeOJwCFQLCWaEo/B59RbJaxiIjK5Ahyyw40oXCPHW8F/WIBEDQ9e7ZJ 85yLy1O1ZmVjNqZXqbGqg3534Po7kC3YN4VuPie/Z16nlIZtbohDC5dHvS2gI6l+NKRI tlZoYLTe5ghjjZc190YGzIQkhb3awSvdryG3kdHusaDaLs3weh1KpaeTahU/+GnP7/H+ MYCzGqDCe9uQG0Iw4CopcXCg1K9LFK7vsbJ+gMgpxd2SGYtuEnHkkPdEB8hYLhrB5Q9n Ox8bKVDP6CUCFqCcsx3k93DdBU9hgRU9DQOgLxdthjiYIoX3eog1qhlKImJTL7nymgd5 a8Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=m/camuLRbAZ3IcPBA6b6JbT9L7ibhWAGZHCG5yYnaN8=; b=Yv2rwjomn/S4Y8Z2t7dMQdjnSBOmtmmLBu3l0o8falQhTc5nGy554hFnjq3ySLTvge tlGQWsBxNmOQU1I0paeBLceGwhJnsqpsDLOBCRARdnP6gkLvDEQdvuofBnWbngBAjglc 9FORc0vII6vG/YEC85MwwwsCYliZB36Vfqe11mNS75lT8rO0pdEBvZ31sFOEOWgZL/vm Z45UDreDE6Smw4d2B+evtFg7gEsYtyZ52aM0QDSO8JjwB5oQZzepjUcI4zGHAjDZ3MAh xWoPTK3mGJ0NRe5WXx9wFgOktzMfRKANEvlG/L+cVftFhh82G7BzRuA7rcMKIEwyqBoK 6gzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=gwINgRPM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m7si4960819pjs.63.2019.06.12.03.29.59; Wed, 12 Jun 2019 03:29:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=gwINgRPM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732211AbfFLK36 (ORCPT + 30 others); Wed, 12 Jun 2019 06:29:58 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:35062 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727846AbfFLK35 (ORCPT ); Wed, 12 Jun 2019 06:29:57 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x5CATu8q062201; Wed, 12 Jun 2019 05:29:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1560335396; bh=m/camuLRbAZ3IcPBA6b6JbT9L7ibhWAGZHCG5yYnaN8=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=gwINgRPMtHskh4fiPpi4Szu533q8OgZGgXX8wGXbMkPTuVVgJtmHd4mC89s9CHwbe lpSjPTk2Kt5tLvXl2h0ohpKfsE20ka4dkmO5BKxH7STJlxuguIqnr0bGG5wrs262gp b/4S/83ZUDYPNPa22o4RAWZHHdnkuQB7R0OzsVj4= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x5CATu9Z085435 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 12 Jun 2019 05:29:56 -0500 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 12 Jun 2019 05:29:55 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Wed, 12 Jun 2019 05:29:56 -0500 Received: from a0393678ub.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id x5CATTJb128310; Wed, 12 Jun 2019 05:29:52 -0500 From: Kishon Vijay Abraham I To: Greg Kroah-Hartman , CC: Subject: [PATCH 5/6] phy: tegra: xusb: Add Tegra124 PLL power supplies Date: Wed, 12 Jun 2019 15:58:02 +0530 Message-ID: <20190612102803.25398-6-kishon@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190612102803.25398-1-kishon@ti.com> References: <20190612102803.25398-1-kishon@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thierry Reding The Tegra124 SoC has four inputs that consume power in order to supply the PLLs that drive the various USB, PCI and SATA pads. Signed-off-by: Thierry Reding Acked-by: Jon Hunter Tested-by: Jon Hunter Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/tegra/xusb-tegra124.c | 9 +++++++++ 1 file changed, 9 insertions(+) -- 2.17.1 diff --git a/drivers/phy/tegra/xusb-tegra124.c b/drivers/phy/tegra/xusb-tegra124.c index c45cbedc6634..254592c47b00 100644 --- a/drivers/phy/tegra/xusb-tegra124.c +++ b/drivers/phy/tegra/xusb-tegra124.c @@ -1721,6 +1721,13 @@ static const struct tegra_xusb_padctl_ops tegra124_xusb_padctl_ops = { .hsic_set_idle = tegra124_hsic_set_idle, }; +static const char * const tegra124_xusb_padctl_supply_names[] = { + "avdd-pll-utmip", + "avdd-pll-erefe", + "avdd-pex-pll", + "hvdd-pex-pll-e", +}; + const struct tegra_xusb_padctl_soc tegra124_xusb_padctl_soc = { .num_pads = ARRAY_SIZE(tegra124_pads), .pads = tegra124_pads, @@ -1743,6 +1750,8 @@ const struct tegra_xusb_padctl_soc tegra124_xusb_padctl_soc = { }, }, .ops = &tegra124_xusb_padctl_ops, + .supply_names = tegra124_xusb_padctl_supply_names, + .num_supplies = ARRAY_SIZE(tegra124_xusb_padctl_supply_names), }; EXPORT_SYMBOL_GPL(tegra124_xusb_padctl_soc); From patchwork Wed Jun 12 10:28:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 166540 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp3501175ilk; Wed, 12 Jun 2019 03:30:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqxNDklZ82AmGU0lWUQDMK1AM5N9HNwVJ3ROoXvxKbqOSx+N0T+8BcuPRUsXnyqmr15KxnQT X-Received: by 2002:a17:902:b215:: with SMTP id t21mr80306955plr.152.1560335402590; Wed, 12 Jun 2019 03:30:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560335402; cv=none; d=google.com; s=arc-20160816; b=B1D9fIVx06BSuhF9G1QWQxpZWagZlTQm1DiBgxAjuKYP5X4nwZpKx+KAGfTMT9sjAp KJqVw5qsC/vCRijcbanS35+3apFPsbjv/iXuyXuBe63+A4td5tSMR4VoUS2HrjPO2x5b prsWE6KrREcEcS5WSSQgqJNP/3wnULqfQAIOLevnFPUMn2Ra7YLUXXzNBotP1Y2mcGE/ 1je8PtD5SFQhP6mVEOPhWBOVZpEDm6U2hZGuVqZK7dOpMml03pTbsA/fSkl0CML78DZ9 kRsjI6qhSu+xCKAZhULONhZUE35BzHgHuLXi+Ju47uDZZW6lDSIpWhoZtCjevj1tKbdM Ca7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=wwNbg1w9v5IkgOhwYOOeoAu3oTH9oE2LfzyI39Kb0+0=; b=fyyN88WzUtUAlj6ubl64jk5hOJ2oDYTRMom6+dyuPXmUS4Q9NKUUUUp9C8pjKYdlVe r7SNfTJZKNAnlWr4VVF1pFY7VDxNTpLiq0OOaCqqc6V62PrRNzMqIQwApIJiD1Hx6gmO FfQBJSWXQ1OGuHjawsutUQBNlUwIceXV5P+X6RjnxEpsWVLYGz2rJz5C5HE3rs0EGzCd /gQdG3nG0uRWczVCJOzV4pkG+hI0sv/5oH54UHmpho3laTdK5ja0ifl6nyfkoPXfQIvL GZ+++uMb4B9rc5f+wqA7VomwbfebF4AmLAgOIlNKkYNNCQ6WDveqovJzE8y8PiLcL/df pE7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=ubkLiEay; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m7si4960819pjs.63.2019.06.12.03.30.02; Wed, 12 Jun 2019 03:30:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=ubkLiEay; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732226AbfFLKaB (ORCPT + 30 others); Wed, 12 Jun 2019 06:30:01 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:35070 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727846AbfFLKaB (ORCPT ); Wed, 12 Jun 2019 06:30:01 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x5CATxjB062212; Wed, 12 Jun 2019 05:29:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1560335399; bh=wwNbg1w9v5IkgOhwYOOeoAu3oTH9oE2LfzyI39Kb0+0=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=ubkLiEayWkRYVd3mfzWVQCNgLU8GbntEDtHR+4jlbpT1ECqu6BdE7H7z4JF4tDep6 toRBMlCU7ANfsPkZG0GgUzVwKfE9ZflpwL/9niXwF6UoceEtiPFfIvr8qr+kZ5kfVT 0ku7bCLoVRrwJGLoYDj2aZQt1uwIHykMgEJN86zs= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x5CATxdA085469 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 12 Jun 2019 05:29:59 -0500 Received: from DLEE102.ent.ti.com (157.170.170.32) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 12 Jun 2019 05:29:59 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Wed, 12 Jun 2019 05:29:59 -0500 Received: from a0393678ub.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id x5CATTJc128310; Wed, 12 Jun 2019 05:29:57 -0500 From: Kishon Vijay Abraham I To: Greg Kroah-Hartman , CC: Subject: [PATCH 6/6] phy: tegra: xusb: Add Tegra210 PLL power supplies Date: Wed, 12 Jun 2019 15:58:03 +0530 Message-ID: <20190612102803.25398-7-kishon@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190612102803.25398-1-kishon@ti.com> References: <20190612102803.25398-1-kishon@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thierry Reding The Tegra210 SoC has four inputs that consume power in order to supply the PLLs that drive the various USB, PCI and SATA pads. Signed-off-by: Thierry Reding Acked-by: Jon Hunter Tested-by: Jon Hunter Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/tegra/xusb-tegra210.c | 9 +++++++++ 1 file changed, 9 insertions(+) -- 2.17.1 diff --git a/drivers/phy/tegra/xusb-tegra210.c b/drivers/phy/tegra/xusb-tegra210.c index 05bee32a3a4d..eb754baa8d71 100644 --- a/drivers/phy/tegra/xusb-tegra210.c +++ b/drivers/phy/tegra/xusb-tegra210.c @@ -2017,6 +2017,13 @@ static const struct tegra_xusb_padctl_ops tegra210_xusb_padctl_ops = { .hsic_set_idle = tegra210_hsic_set_idle, }; +static const char * const tegra210_xusb_padctl_supply_names[] = { + "avdd-pll-utmip", + "avdd-pll-uerefe", + "dvdd-pex-pll", + "hvdd-pex-pll-e", +}; + const struct tegra_xusb_padctl_soc tegra210_xusb_padctl_soc = { .num_pads = ARRAY_SIZE(tegra210_pads), .pads = tegra210_pads, @@ -2035,6 +2042,8 @@ const struct tegra_xusb_padctl_soc tegra210_xusb_padctl_soc = { }, }, .ops = &tegra210_xusb_padctl_ops, + .supply_names = tegra210_xusb_padctl_supply_names, + .num_supplies = ARRAY_SIZE(tegra210_xusb_padctl_supply_names), }; EXPORT_SYMBOL_GPL(tegra210_xusb_padctl_soc);