From patchwork Wed Jun 12 11:03:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 166541 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp3533017ilk; Wed, 12 Jun 2019 04:03:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqxepdD4rwuPq+D6FHQK5RO6ju0+YL1SaCeLi1DjGPTBbtjDKJ+K4mj96xp+sBOrQP7CHEjR X-Received: by 2002:aa7:8394:: with SMTP id u20mr74293308pfm.252.1560337439145; Wed, 12 Jun 2019 04:03:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560337439; cv=none; d=google.com; s=arc-20160816; b=09U3wQpIDd8+fYKvfOOUedtd1GsSFU764gUK7+t6xqYfqsFl0N6PMCKrE3MKuJvatl V73CE1Um32PdoVgULMftF78//1K1pGe8PszRv+hbQRhCmiR9xkZ6EfGEF+7HVEebufTg vqoo3Bx7anKTu3DR4pZP/Savsb14dJaY31SbREdQT3clcAA2rvteIcBE7iQ4e+qXxqzF p+/QZxTuWyVSso17QrC8SZOH8wH5V7nPH/wE6vY59IE2gRkGiwPoQizdDGZNF80Obd6A 8+ro40S+yCJ0p02o7rj/yy7Yy/r6uZJp5FXvxLS7Yk0FYAR2NqPAAvKK1Ks0hd4KgoBK Ft+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=MRVsNIFezwN+iFmcBdbEviK/+CqAMtf2Qx3jn0k/cq4=; b=IQv9+EW53V1IOCAJQiqZONPZ41w5zgDIPPLd7OIQUVzT6pPVr0RxtHiJQWvgixVvNv lfDaZk4WOucdFwwElVNBAyQ9vHmesmEBQFcuEAU245AR2FJulKOevgDo70Clp7NQGBsz tpIIyYqW/+uYe3ICYeysfuFelA2tDv1+/7+u+Lgiv/J9wZ1h2T0elrTvEA7yJsCefHB5 mPtZ357sLei4CtlWc1wLI8ZrH/iJZAJ/7zlJJZYTZC5DB/lb2jpJIz/GMEEevUXKSYNa 7XKrz6xjJrNhHBU5mLwzhCaK/rKLUZkVhl15TblcArzHUOWx9kNGFbM8uaJOVd1etW8J F4QA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KZX4u5D7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 70si16381341pla.2.2019.06.12.04.03.58; Wed, 12 Jun 2019 04:03:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KZX4u5D7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408937AbfFLLD6 (ORCPT + 30 others); Wed, 12 Jun 2019 07:03:58 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:54974 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406521AbfFLLD5 (ORCPT ); Wed, 12 Jun 2019 07:03:57 -0400 Received: by mail-wm1-f68.google.com with SMTP id g135so6105605wme.4 for ; Wed, 12 Jun 2019 04:03:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MRVsNIFezwN+iFmcBdbEviK/+CqAMtf2Qx3jn0k/cq4=; b=KZX4u5D7ed6FD65XeikM9bjph1fJHoblo5WeT7sGLQNEZjhJtFnUVUMGOdAcqBs1FH MnLgXdWolCNAQ8kgyPppetW/t0GsZ0icP+UnP3hEAOWPOncSEFktdLNIn5vS23Lwi33u zCs0Z2VVIYiTx+78GEYCFt4gAWn8LjJKgIohnTcWZwfMC6TKHC115kYybpvyGdImEU32 XygnPlgNTVKgl1U+SBKuSan8sX3hfxfHaeRx9jeK8giAgR3yIyC//OjUozPyedh9yq5O xqRtajj6T6Qs3iC+KbdKo0wH2B3CD4mkPEGbiQU911mpFBQVFt1Ej4ydiGb09BOjTRpO vFxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MRVsNIFezwN+iFmcBdbEviK/+CqAMtf2Qx3jn0k/cq4=; b=K8YGBGMz/P/95Bag15y2sQkBnsaQA624su0PVMmDi3qcDyB6gsUry97oGjJEVkrp4+ +QZYL63RxR8lU/L8mLNbDhGiny8krBMzPf1YQoUgGamykUHh7PGBW2s+znUjHzvDxKsE VnEd+Aunb9NhAWiRWouH72Oo27jQ3F0tuyrhBREO27LKURFM+r2L6rG5E90BjerJp0FC KvfOiRkwq5QB0rzqV3k2EiarzCAh0s+2FcB+fbMgP35HqsVOUtZHAMDcMgjeHIaMTv7r 1Wwelwuuf7ss1gKUCYrwPlmtH88Sk7IIUkBvS2BJpxQWqpBGX44IighBaJv/Ksce6pGP B+bg== X-Gm-Message-State: APjAAAUypAzhuCAtkr0WB+iCV8ioWxQFlmpAlc3d3FsT9MVlkrh9GqS2 zUDYJ9LFy36RYCKigqzCLHxjcw== X-Received: by 2002:a1c:c907:: with SMTP id f7mr22192836wmb.142.1560337435377; Wed, 12 Jun 2019 04:03:55 -0700 (PDT) Received: from srini-hackbox.lan (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.gmail.com with ESMTPSA id h8sm5317940wmf.12.2019.06.12.04.03.54 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 12 Jun 2019 04:03:54 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, Srinivas Kandagatla Subject: [PATCH] regmap: fix bulk writes on paged registers Date: Wed, 12 Jun 2019 12:03:43 +0100 Message-Id: <20190612110343.4463-1-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On buses like SlimBus and SoundWire which does not support gather_writes yet in regmap, A bulk write on paged register would be silently ignored after programming page. This is because local variable 'ret' value in regmap_raw_write_impl() gets reset to 0 once page register is written successfully and the code below checks for 'ret' value to be -ENOTSUPP before linearising the write buffer to send to bus->write(). Fix this by resetting the 'ret' value to -ENOTSUPP in cases where gather_writes() is not supported or single register write is not possible. Signed-off-by: Srinivas Kandagatla --- drivers/base/regmap/regmap.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.21.0 diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index f1025452bb39..19f57ccfbe1d 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -1637,6 +1637,8 @@ static int _regmap_raw_write_impl(struct regmap *map, unsigned int reg, map->format.reg_bytes + map->format.pad_bytes, val, val_len); + else + ret = -ENOTSUPP; /* If that didn't work fall back on linearising by hand. */ if (ret == -ENOTSUPP) {