From patchwork Fri Jun 23 07:28:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Bara X-Patchwork-Id: 695681 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0899EB64D7 for ; Fri, 23 Jun 2023 07:28:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231209AbjFWH2V (ORCPT ); Fri, 23 Jun 2023 03:28:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229958AbjFWH2S (ORCPT ); Fri, 23 Jun 2023 03:28:18 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B380519BF; Fri, 23 Jun 2023 00:28:17 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-98cd280cf94so29181666b.1; Fri, 23 Jun 2023 00:28:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687505296; x=1690097296; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tE3E2dKV+FoleDfxJ/RhJkgCbuoMdh5riKIj8EEGJsc=; b=harcNWpa5uQa0AwY39eMRlXzFMQH33Cl9t+0B407s3RoASvRIxvrWRtEJ6yueYjjU+ KaKn7mj2QRZxZRMJ2rnArdB/JVVnZgOJzu/APgLYNKUz4yDKN6l0iiuTMtRwafnh32qP MumN77C8jkzXoLYIqxpwNFWyW07MGhYHZ981GAAPTiME7x3KbwB6yEAOYXFzJwHHBEAH ow+MzPWC508jeh/pPJgCs3RUBRC169hxhWrHzTAC5imUj3bPUi4csQ8Ir+lLpvcWah9W GmLoRbF2FkrN9q7/gpy5IENE6mIi2YKJFrDZOxADxpF82/iu140YlI8MpV954DGrrXL1 0/Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687505296; x=1690097296; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tE3E2dKV+FoleDfxJ/RhJkgCbuoMdh5riKIj8EEGJsc=; b=XHpGqj0OXrxOalyZXnYDEJZzKcSQODHcRbOnSdzwA9NPnYH23ewgH7o1RBhGpQX4Gi H1MstKbrJb8SGnlmv8F/1Jj7yapNpMG8QIho4S/QSY+MftFivI005ZkxA7bzTgNlwFnQ 1NQgC5IvEctvieLrOzjFQj/53y+xZpmKUOwWqe6uiNUILDlUISE/qg6gAojNi4QirQVI xrMLJD34qTPouYLW/sjKzQcv7akErUr4wopqoinvFpyeTOGzulVKFt7kgmzfLtQAcYoF 2V1WRrdaf4Ae9+NdKSlty+8M7PFj/UX3sGySpTtJ4jY7FuYfqIRrEkao545kiEHMY+8x hjUA== X-Gm-Message-State: AC+VfDw3SM82IwQtRXvdQnVCTcqzF9FevO3PnU4hTR9N3ROwCAlDuFIB F4fQe18c3DD/Jx8l5AogcSU= X-Google-Smtp-Source: ACHHUZ5MOAGy5T6hlzGL3bZBFVsMq0IywnIyOLtA6gREYcCTA8aT4zxjlsGxwAinkCurKzB3auftWw== X-Received: by 2002:a17:907:2d91:b0:977:cbaf:bc56 with SMTP id gt17-20020a1709072d9100b00977cbafbc56mr20732424ejc.43.1687505295974; Fri, 23 Jun 2023 00:28:15 -0700 (PDT) Received: from [127.0.1.1] ([91.230.2.244]) by smtp.gmail.com with ESMTPSA id y19-20020a17090614d300b00982d0563b11sm5637811ejc.197.2023.06.23.00.28.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 00:28:15 -0700 (PDT) From: Benjamin Bara Date: Fri, 23 Jun 2023 09:28:12 +0200 Subject: [PATCH v7 1/3] usb: misc: onboard-hub: support multiple power supplies MIME-Version: 1.0 Message-Id: <20230620-hx3-v7-1-f79b4b22a1bf@skidata.com> References: <20230620-hx3-v7-0-f79b4b22a1bf@skidata.com> In-Reply-To: <20230620-hx3-v7-0-f79b4b22a1bf@skidata.com> To: Matthias Kaehlcke , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benjamin Bara Cc: Alexander Stein , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.12.2 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Benjamin Bara As some of the onboard hubs require multiple power supplies, provide the environment to support them. Signed-off-by: Benjamin Bara Acked-by: Matthias Kaehlcke --- v7: - %ld -> %zu v6: - %d -> %ld v5: - use ARRAY_SIZE(supply_names) for MAX_SUPPLIES v4: - set num_supplies=1 for the existing hubs - drop duplicate num_supplies in onboard_hub struct - clarify connection between supply_names and MAX_SUPPLIES v3: - fix nits mentioned in v2 v2: - replace (err != 0) with (err) --- drivers/usb/misc/onboard_usb_hub.c | 37 +++++++++++++++++++++++++++++-------- drivers/usb/misc/onboard_usb_hub.h | 7 +++++++ 2 files changed, 36 insertions(+), 8 deletions(-) diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c index 12fc6eb67c3b..b31548cd60e7 100644 --- a/drivers/usb/misc/onboard_usb_hub.c +++ b/drivers/usb/misc/onboard_usb_hub.c @@ -27,6 +27,17 @@ #include "onboard_usb_hub.h" +/* + * Use generic names, as the actual names might differ between hubs. If a new + * hub requires more than the currently supported supplies, add a new one here. + */ +static const char * const supply_names[] = { + "vdd", + "vdd2", +}; + +#define MAX_SUPPLIES ARRAY_SIZE(supply_names) + static void onboard_hub_attach_usb_driver(struct work_struct *work); static struct usb_device_driver onboard_hub_usbdev_driver; @@ -40,7 +51,7 @@ struct usbdev_node { }; struct onboard_hub { - struct regulator *vdd; + struct regulator_bulk_data supplies[MAX_SUPPLIES]; struct device *dev; const struct onboard_hub_pdata *pdata; struct gpio_desc *reset_gpio; @@ -55,9 +66,9 @@ static int onboard_hub_power_on(struct onboard_hub *hub) { int err; - err = regulator_enable(hub->vdd); + err = regulator_bulk_enable(hub->pdata->num_supplies, hub->supplies); if (err) { - dev_err(hub->dev, "failed to enable regulator: %d\n", err); + dev_err(hub->dev, "failed to enable supplies: %d\n", err); return err; } @@ -75,9 +86,9 @@ static int onboard_hub_power_off(struct onboard_hub *hub) gpiod_set_value_cansleep(hub->reset_gpio, 1); - err = regulator_disable(hub->vdd); + err = regulator_bulk_disable(hub->pdata->num_supplies, hub->supplies); if (err) { - dev_err(hub->dev, "failed to disable regulator: %d\n", err); + dev_err(hub->dev, "failed to disable supplies: %d\n", err); return err; } @@ -232,6 +243,7 @@ static int onboard_hub_probe(struct platform_device *pdev) const struct of_device_id *of_id; struct device *dev = &pdev->dev; struct onboard_hub *hub; + unsigned int i; int err; hub = devm_kzalloc(dev, sizeof(*hub), GFP_KERNEL); @@ -246,9 +258,18 @@ static int onboard_hub_probe(struct platform_device *pdev) if (!hub->pdata) return -EINVAL; - hub->vdd = devm_regulator_get(dev, "vdd"); - if (IS_ERR(hub->vdd)) - return PTR_ERR(hub->vdd); + if (hub->pdata->num_supplies > MAX_SUPPLIES) + return dev_err_probe(dev, -EINVAL, "max %zu supplies supported!\n", + MAX_SUPPLIES); + + for (i = 0; i < hub->pdata->num_supplies; i++) + hub->supplies[i].supply = supply_names[i]; + + err = devm_regulator_bulk_get(dev, hub->pdata->num_supplies, hub->supplies); + if (err) { + dev_err(dev, "Failed to get regulator supplies: %d\n", err); + return err; + } hub->reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); diff --git a/drivers/usb/misc/onboard_usb_hub.h b/drivers/usb/misc/onboard_usb_hub.h index aca5f50eb0da..41a4127a92dc 100644 --- a/drivers/usb/misc/onboard_usb_hub.h +++ b/drivers/usb/misc/onboard_usb_hub.h @@ -8,30 +8,37 @@ struct onboard_hub_pdata { unsigned long reset_us; /* reset pulse width in us */ + unsigned int num_supplies; /* number of supplies */ }; static const struct onboard_hub_pdata microchip_usb424_data = { .reset_us = 1, + .num_supplies = 1, }; static const struct onboard_hub_pdata realtek_rts5411_data = { .reset_us = 0, + .num_supplies = 1, }; static const struct onboard_hub_pdata ti_tusb8041_data = { .reset_us = 3000, + .num_supplies = 1, }; static const struct onboard_hub_pdata genesys_gl850g_data = { .reset_us = 3, + .num_supplies = 1, }; static const struct onboard_hub_pdata genesys_gl852g_data = { .reset_us = 50, + .num_supplies = 1, }; static const struct onboard_hub_pdata vialab_vl817_data = { .reset_us = 10, + .num_supplies = 1, }; static const struct of_device_id onboard_hub_match[] = { From patchwork Fri Jun 23 07:28:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Bara X-Patchwork-Id: 696213 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2294EC001DF for ; Fri, 23 Jun 2023 07:28:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230379AbjFWH2W (ORCPT ); Fri, 23 Jun 2023 03:28:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231169AbjFWH2T (ORCPT ); Fri, 23 Jun 2023 03:28:19 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8048E1BF7; Fri, 23 Jun 2023 00:28:18 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-51bec86b9c9so271873a12.2; Fri, 23 Jun 2023 00:28:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687505297; x=1690097297; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fzzWIUqJqm2OuJAK4dd8g4504MuqeTJf8AOG83ShyXE=; b=eybeGszegtYlu85i8eqPO8VWOoRF4h+nnaYfdo6yu/jE/3s4D3eDra73Y21vyvzbtY f8DMnhqvUdz/nxIzLGpHfSzuKjNdfBSWZ8D+6iRS4ttbYGJV12m4UUY1gracHXB5qFu6 Pm5gQXDm0e+fA+xafKGWB83hg3q3SCCoGkstRELAIrmM4f4t/PF5DzYl0raGFyQIjw+3 UGbxEH+/YDoB9MW74008yBA4gCFZsBe89VFco1pJHwx7Qq5p1m+GYAjnQ/yDGdbKhEZx hWnQb8BLGqZgdS2IpH37GpXVCNW7qjppT0JaFFXFDu6gKVALb2NLFUfKyO6v44RDdFs6 MWyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687505297; x=1690097297; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fzzWIUqJqm2OuJAK4dd8g4504MuqeTJf8AOG83ShyXE=; b=J1sCLdOCutQXDj+rcaEQq6YuMliMQKdz/OwR4k7gQuqN6yS6UH6GNXldsFol5qSpVk i3D3+CXW29PObb4Pn7JMxOkUJ4wcvB5LffVqLeUwVF6hu0yMhmi8ZOZBecX1UBLmtuHl yzN2nNW1IetqHbIE+VKAAHC+g38u/FV4JDnbERPV6ZegbRdB1eJvC5ALtWu7QEl8lYg5 Xy81MMyPWM/PPoxHlffFuIRGCLyLDgA0UIUNvWDzYQO9vriRLOMWhj85RNUghSVZFXVv pN3+SQeulnmfZ/jHar1FLEfu7PiyqUZ4SW8Q5g9WUlkbksvOX7Is3ZLhQmE/vpgK3nH1 jZOQ== X-Gm-Message-State: AC+VfDxBnWLen4yVcKouOPdAznVPJtdzI7y8FaH8DZ5+51CUFHbAD5s8 75w4qy1n2vXVelJds6ReOdY= X-Google-Smtp-Source: ACHHUZ4zFfs6lrFuFXitVlLCFimYeiT8ZJNngc8oYzOFzjbjQwkYh+FPMaMFxMs5F8fhzkkmv4YhHA== X-Received: by 2002:a17:907:843:b0:982:84c9:96c5 with SMTP id ww3-20020a170907084300b0098284c996c5mr19530961ejb.60.1687505296795; Fri, 23 Jun 2023 00:28:16 -0700 (PDT) Received: from [127.0.1.1] ([91.230.2.244]) by smtp.gmail.com with ESMTPSA id y19-20020a17090614d300b00982d0563b11sm5637811ejc.197.2023.06.23.00.28.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 00:28:16 -0700 (PDT) From: Benjamin Bara Date: Fri, 23 Jun 2023 09:28:13 +0200 Subject: [PATCH v7 2/3] usb: misc: onboard-hub: add support for Cypress HX3 USB 3.0 family MIME-Version: 1.0 Message-Id: <20230620-hx3-v7-2-f79b4b22a1bf@skidata.com> References: <20230620-hx3-v7-0-f79b4b22a1bf@skidata.com> In-Reply-To: <20230620-hx3-v7-0-f79b4b22a1bf@skidata.com> To: Matthias Kaehlcke , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benjamin Bara Cc: Alexander Stein , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org X-Mailer: b4 0.12.2 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Benjamin Bara The HX3 comes in different variants (up to 4 USB 3.0 ports; multi-TT), e.g. CYUSB330x/CYUSB331x/CYUSB332x/CYUSB230x. It operates with two different power supplies: 1V2 and 3V3. Add the support for this hub, for controlling the reset pin and the power supplies. Reset time is extracted from data sheet, page 24: "The RESETN pin can be tied to VDD_IO through an external resistor and to ground (GND) through an external capacitor (minimum 5 ms time constant)." V_IH min is given at 0.7 * 3V3 (page 34), therefore use 10ms. Also add USB PIDs for the USB 2.0 and USB 3.0 root hub. Acked-by: Matthias Kaehlcke Signed-off-by: Benjamin Bara --- drivers/usb/misc/onboard_usb_hub.c | 3 +++ drivers/usb/misc/onboard_usb_hub.h | 7 +++++++ 2 files changed, 10 insertions(+) diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c index b31548cd60e7..b8d6b26cd531 100644 --- a/drivers/usb/misc/onboard_usb_hub.c +++ b/drivers/usb/misc/onboard_usb_hub.c @@ -350,6 +350,7 @@ static struct platform_driver onboard_hub_driver = { /************************** USB driver **************************/ +#define VENDOR_ID_CYPRESS 0x04b4 #define VENDOR_ID_GENESYS 0x05e3 #define VENDOR_ID_MICROCHIP 0x0424 #define VENDOR_ID_REALTEK 0x0bda @@ -428,6 +429,8 @@ static void onboard_hub_usbdev_disconnect(struct usb_device *udev) } static const struct usb_device_id onboard_hub_id_table[] = { + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6504) }, /* CYUSB33{0,1,2}x/CYUSB230x 3.0 */ + { USB_DEVICE(VENDOR_ID_CYPRESS, 0x6506) }, /* CYUSB33{0,1,2}x/CYUSB230x 2.0 */ { USB_DEVICE(VENDOR_ID_GENESYS, 0x0608) }, /* Genesys Logic GL850G USB 2.0 */ { USB_DEVICE(VENDOR_ID_GENESYS, 0x0610) }, /* Genesys Logic GL852G USB 2.0 */ { USB_DEVICE(VENDOR_ID_MICROCHIP, 0x2514) }, /* USB2514B USB 2.0 */ diff --git a/drivers/usb/misc/onboard_usb_hub.h b/drivers/usb/misc/onboard_usb_hub.h index 41a4127a92dc..6f446fe7d2f7 100644 --- a/drivers/usb/misc/onboard_usb_hub.h +++ b/drivers/usb/misc/onboard_usb_hub.h @@ -26,6 +26,11 @@ static const struct onboard_hub_pdata ti_tusb8041_data = { .num_supplies = 1, }; +static const struct onboard_hub_pdata cypress_hx3_data = { + .reset_us = 10000, + .num_supplies = 2, +}; + static const struct onboard_hub_pdata genesys_gl850g_data = { .reset_us = 3, .num_supplies = 1, @@ -46,6 +51,8 @@ static const struct of_device_id onboard_hub_match[] = { { .compatible = "usb424,2517", .data = µchip_usb424_data, }, { .compatible = "usb451,8140", .data = &ti_tusb8041_data, }, { .compatible = "usb451,8142", .data = &ti_tusb8041_data, }, + { .compatible = "usb4b4,6504", .data = &cypress_hx3_data, }, + { .compatible = "usb4b4,6506", .data = &cypress_hx3_data, }, { .compatible = "usb5e3,608", .data = &genesys_gl850g_data, }, { .compatible = "usb5e3,610", .data = &genesys_gl852g_data, }, { .compatible = "usbbda,411", .data = &realtek_rts5411_data, }, From patchwork Fri Jun 23 07:28:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Bara X-Patchwork-Id: 695680 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B50B5EB64D7 for ; Fri, 23 Jun 2023 07:28:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231274AbjFWH2Y (ORCPT ); Fri, 23 Jun 2023 03:28:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231181AbjFWH2U (ORCPT ); Fri, 23 Jun 2023 03:28:20 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65E8719BF; Fri, 23 Jun 2023 00:28:19 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-988aefaa44eso33257866b.2; Fri, 23 Jun 2023 00:28:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687505298; x=1690097298; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=vQAW8yZCFSnADhBud7nfo4RU3cNf5kaZDT6uTQ+OwQc=; b=WLwNwwXJL81ydxxMH8W3bUqs1JkG9L3tzw5sYwCMGRUeSyKhrz3b3mn2sokXi56yNY NISOHlpjPmelvIDtVkxsCzU8uAb/oH8+WE9gmuvkwesuPpNZT5AGV82+VvVLqIOTl7f4 5+bBBwqYadyM76vgEm6KAZfUr7GS4/+SWRn/cOLagB0Xm5NHOWt9xO0DGGyo3vSMXWXK W5KnQAmuuFyPfZyAf+Z7VW1BjEY+Wk3u82V3aRdbwW0G35Mw6UUDro47d2m+KeX9SCwn 0RHezvIynmP3K1FWWqKwjnd/1E3TSK4qffhd5qH+nCNshCJ4ThTmLIQ9o4/3WunK/Ej7 qJEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687505298; x=1690097298; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vQAW8yZCFSnADhBud7nfo4RU3cNf5kaZDT6uTQ+OwQc=; b=h0h/FWBXnBbUo4Y7bdkpdbH4qmzaAs3MrIJlwZxfZuhB0LfeBR0cGYo1gaznkFIXFz s1RI02GmOwRo6T+x124f53rrOWmSss8Mu2W4XuBS0/m6LWbfkU12ObPZku3KN7VDhHmZ 7RCrW1Qu+GR4RLeTUeu69yzCDR1KAk3EOT+Bv0zFKgqZYODg2i2TnhNHga2BcsBiKB8D E/UUhnHihMDGLAQEQuXevYZtU5DY9vAc47SM9HvfXmDK7jN1iGD2VTMpR2pzzK91STBd HSVR6+wYKxNUEmRd9T8AUa7qfXqH8cHn0I24I4K3jcQNwC9vdR96id/zWt1/izfKhPBl PZbA== X-Gm-Message-State: AC+VfDz+CBBOBQJ0s5fsQU0XfBBT+aXS4fosKOtIVQrkpKq8yM7aJxr4 XTLh4gZNDJv4Wlgz70fBJ9s= X-Google-Smtp-Source: ACHHUZ64S0PU2CibTDqtbntbr658so5FMj8Ky0zBReLz2hhtgAH/FxtzwPWKd9Kui2ozk94o+XyqKQ== X-Received: by 2002:a17:907:1c09:b0:988:2037:c67f with SMTP id nc9-20020a1709071c0900b009882037c67fmr16189345ejc.2.1687505297662; Fri, 23 Jun 2023 00:28:17 -0700 (PDT) Received: from [127.0.1.1] ([91.230.2.244]) by smtp.gmail.com with ESMTPSA id y19-20020a17090614d300b00982d0563b11sm5637811ejc.197.2023.06.23.00.28.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 00:28:17 -0700 (PDT) From: Benjamin Bara Date: Fri, 23 Jun 2023 09:28:14 +0200 Subject: [PATCH v7 3/3] dt-bindings: usb: Add binding for Cypress HX3 USB 3.0 family MIME-Version: 1.0 Message-Id: <20230620-hx3-v7-3-f79b4b22a1bf@skidata.com> References: <20230620-hx3-v7-0-f79b4b22a1bf@skidata.com> In-Reply-To: <20230620-hx3-v7-0-f79b4b22a1bf@skidata.com> To: Matthias Kaehlcke , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benjamin Bara Cc: Alexander Stein , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring X-Mailer: b4 0.12.2 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Benjamin Bara The HX3 family comes in different variants (up to 4 USB 3.0 ports; multi-TT), e.g. CYUSB330x/CYUSB331x/CYUSB332x/CYUSB230x. This initial version of the binding only describes USB related aspects of the HX3 family, it does not cover the option of connecting the controller as an i2c slave. Reviewed-by: Rob Herring Signed-off-by: Benjamin Bara --- .../devicetree/bindings/usb/cypress,hx3.yaml | 77 ++++++++++++++++++++++ 1 file changed, 77 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/cypress,hx3.yaml b/Documentation/devicetree/bindings/usb/cypress,hx3.yaml new file mode 100644 index 000000000000..47add0d85fb8 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/cypress,hx3.yaml @@ -0,0 +1,77 @@ +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/usb/cypress,hx3.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Cypress HX3 USB 3.0 hub controller family + +maintainers: + - Benjamin Bara + +allOf: + - $ref: usb-device.yaml# + +properties: + compatible: + enum: + - usb4b4,6504 + - usb4b4,6506 + + reg: true + + reset-gpios: + items: + - description: GPIO specifier for RESETN pin. + + vdd-supply: + description: + 1V2 power supply (VDD_EFUSE, AVDD12, DVDD12). + + vdd2-supply: + description: + 3V3 power supply (AVDD33, VDD_IO). + + peer-hub: + $ref: /schemas/types.yaml#/definitions/phandle + description: + phandle to the peer hub on the controller. + +required: + - compatible + - reg + - peer-hub + - vdd-supply + - vdd2-supply + +additionalProperties: false + +examples: + - | + #include + + usb { + dr_mode = "host"; + #address-cells = <1>; + #size-cells = <0>; + + /* 2.0 hub on port 1 */ + hub_2_0: hub@1 { + compatible = "usb4b4,6504"; + reg = <1>; + peer-hub = <&hub_3_0>; + reset-gpios = <&gpio1 11 GPIO_ACTIVE_LOW>; + vdd-supply = <®_1v2_usb>; + vdd2-supply = <®_3v3_usb>; + }; + + /* 3.0 hub on port 2 */ + hub_3_0: hub@2 { + compatible = "usb4b4,6506"; + reg = <2>; + peer-hub = <&hub_2_0>; + reset-gpios = <&gpio1 11 GPIO_ACTIVE_LOW>; + vdd-supply = <®_1v2_usb>; + vdd2-supply = <®_3v3_usb>; + }; + };