From patchwork Wed Jul 5 08:50:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Minjie Du X-Patchwork-Id: 700092 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D347EB64DA for ; Wed, 5 Jul 2023 10:31:40 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3507E83B; Wed, 5 Jul 2023 12:30:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3507E83B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1688553098; bh=ePZxcXYWoSwvUadn0Elu6W1Dwcy27K3NYEb+Ozl38Uo=; h=From:To:Cc:Subject:Date:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=NStL78sVR38Bs4kyy/vtvuxKrVQr8xvF1ADbR5bSM8mYKBS7wCpg7sKfVcaHFw/fd PlbDIDQnqzWfVmO+UhKm7nPfowwfaf406ypE7t8J0kuxMGXyJk97ucIk4Pxham1wLm 2r52fiBpj2dCL/L+kszBzn5i+Nlv9RndPii/EoOo= Received: by alsa1.perex.cz (Postfix, from userid 50401) id D21CAF8053B; Wed, 5 Jul 2023 12:30:20 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 0534AF80125; Wed, 5 Jul 2023 12:30:20 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3B876F80125; Wed, 5 Jul 2023 10:50:49 +0200 (CEST) Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2071b.outbound.protection.outlook.com [IPv6:2a01:111:f400:feae::71b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 34942F80100 for ; Wed, 5 Jul 2023 10:50:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 34942F80100 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=vivo.com header.i=@vivo.com header.a=rsa-sha256 header.s=selector2 header.b=Zax5rl5X ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kv8tWCWaD/YroYs4+T83EJtzraTeTgB2JgsUwpHM/mvWfJq7VMHoCIQJnQ7KU7rvlNnjl4depi1aFCeFOPh/Cn6jPAZYGfqdODv/0v6/xcckGGdnPmckIsXd7qzspffGVUvQjAbqp4Pjro+5EJuwfzTznajjNIadPTrvCDTvUlZc5OQfAINL9PCaESGsakqYxQeLPdkIPgJS54mlRDaDjxxbqnMG6j8jsXMZUHPkaY3KHd6nwz95c+R0SEAV0qAzldQHlBnyYmU6JEJu/RbslIZS1dTvJoh2nDmB9LJAIRASTe/W1vUGmhQ+ps4nhXZp+AkC3H/DTlw/qlvwESyrvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fbB2tjvqEux+nu8pBQzW3kjEnTTtIsGYIQMBFJI/9rA=; b=AUOjZsw3e7NEqP0A6FOrfhfqhli7Tx9YkB/FDChPuzFxIfSkqjRtKn1bRIUtfd3rhzvNggr+SUBs4u5qR7tmsw1J9ZSMIs6ENg5CMcna+ewLKLZ/7AjfulOnH+VfU8ciUHILTdJBb0Odtp1GhJkHNJgzhksrquBVRzlUmVxgRjk7lFjsyCxF6rNYp2Uww9pO0KJa3S6O/a3JJVCo1tZMVvSjcze8RoNKtemuigGwFkq7brveJJnZquwImEvy4to60kNHQoravUqwsTqPIfnVp0NyQ4S5drKNt+KPFmYRu9fsleLmEDFkUVV7KfVjgemwQ8j0SmN1NwKulDSJ76HDFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fbB2tjvqEux+nu8pBQzW3kjEnTTtIsGYIQMBFJI/9rA=; b=Zax5rl5XKB7Ou7KXpRDHaOeSVDqEVz5YOKFo073nA/vApmvZh0KZJx90KVxHz0s2Z631xOto+l2keq2Aqux44TlXaAH+atUQcsIPmFzmdZSdQXoyPEDxhFwvmuy5On3dPd42EdfjTDWfOcDrrBLJx/Y/NznPZffIFyQVY/CnVzJ4LnKRH0jc5IWsUgIA4qRk1zGdB70zljWEgW0wn433y1t/uFHGkLfDW4fKj3coYFu1Bz2yL+Kf+4gsooLuF+iW4paYcOTRXtSgzo+xBN4rkNPnyiDxkLfyNGmT9pJUvpXSSO7DOivKCZw7eHpPzQRZT7EDRWj/oM6VKAUZ+ly7fg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYZPR06MB6282.apcprd06.prod.outlook.com (2603:1096:400:429::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.17; Wed, 5 Jul 2023 08:50:33 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::fa0e:6c06:7474:285c%5]) with mapi id 15.20.6565.016; Wed, 5 Jul 2023 08:50:33 +0000 From: Minjie Du To: Jaroslav Kysela , Takashi Iwai , Minjie Du , Stephen Rothwell , alsa-devel@alsa-project.org (moderated list:SOUND), linux-kernel@vger.kernel.org (open list) Cc: opensource.kernel@vivo.com Subject: [PATCH v1] sound: seq: check struct system assignment problem Date: Wed, 5 Jul 2023 16:50:22 +0800 Message-Id: <20230705085022.13078-1-duminjie@vivo.com> X-Mailer: git-send-email 2.39.0 X-ClientProxiedBy: TYWPR01CA0033.jpnprd01.prod.outlook.com (2603:1096:400:aa::20) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYZPR06MB6282:EE_ X-MS-Office365-Filtering-Correlation-Id: 936f4a2a-be03-43d3-1b95-08db7d34e433 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RwwAmz1DhFf1Mf77YxI401WFqDTjS6Tn41vNatxyhsbngTXulL5Noj9sCKePLyctX7ajIXCjlQ5dZcJR9Xhqu31tO/mY/diqcWsfjMjB2BS1xTWqrJ1pPyY7gNFnJ+nL6YWyXykulbY8yDt63G76wm4wQeVHPCeGuz1F7jE185q/xoOMcGLIUIGT87DWxRDQUVyJbQz03OSL9aMDsYV77QAYnT7FXE/Ld9hxlicu1FkqJJD3G5neHaxvJiD38a3enDJ0kOKgdQK0/3N5dPW6UpwHpBlon4bP/0tE6h3O4bLHEhQj5+6MdINMuIbPy0Ks6k6xqEA+CfCgi3q1q0pu1hQwLQMcd5pvTIzRYjOLz4ZZCxDZr6VsAiovDJzc10Xt1+zSkWizOAnMgEjMtN09MLUCJV4r3pcgjiq5eEmDeUMZkKqaBMTEZGMKs15/JEE7+cV9E9dU7P3D3tcNR7z5p++WL0ibLgxiGUIeiDvcccW6Wbo7mafAGILMKydvRNujrRNKlbS7v42cgT/t/BDygm/+17XDieZF7iqr1axFYm6fwAWNROliQf5aGlWPlwzwy+tXyLxLsBV3EsOiMSymsGLLpTd4aQqh/rUg5SlEEFsGHhGZEHFm8QcJOvRoThF3 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(39860400002)(376002)(136003)(346002)(396003)(451199021)(66476007)(4326008)(66556008)(66946007)(2616005)(38350700002)(38100700002)(107886003)(186003)(86362001)(6506007)(26005)(1076003)(83380400001)(6666004)(478600001)(6512007)(52116002)(6486002)(110136005)(36756003)(4744005)(41300700001)(8936002)(8676002)(2906002)(5660300002)(316002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 4XMqQH3AN5/wZ7ALvzPv4v5PjcYXJXeYHtl7MecLDDhnGDxYRKZ/X5Dd5t4AgDPcsY44bJl+ljLSm/9kJ1UDqHFvFu+oeo3MEPRtSeCSUeiYcF0VdEr5hFHFznOYoh27S0LZvAvdXZqsGoLFYHi4z+mffPnEJ4zkR3AF/RroukEujgN6ULuSNfj46HFZI8ocbo8hy3SbzRbsfflKYUxrEyu8kEujdqTLG+/L2IKr/TkBajA1fgkd1sKWEJO5SUU2iC4hHCkt9SwkiepivEjZj4Z+72nhKA9bxY8VVkh62UIy34Gp6V5Xi9rcwBsxdRDsgIYVzOvDJyITttF3sV0xb6JsJHAEb1l5N8HEe//JsnuXR51g1ZDLWNyW7fzJRF7QqtwJ2vt1JmOZ1GO91EsG4v3tKOgUUSCy6MSSuFjPbYF4gxL9zYRNMe1hv3HjWBTU8H/eqLeVrjzYrC2t2e1O0APGamdZQlEObRp6MszHy4TAITOYDXDa8wp0qCER3Ja3xf3k79pifsMUQOhm1qK5wwq1jLlZT3bpMQaNr0pSGpybVKuzJlAz3mmL7/n2Vb5nAo9e5ciY2pIKS+0IDkqDAtn3Dm53+0VnzoP83hQGLkx0SErKsm8Z5aEiShM5DRxaoJaryKRJjAtR6vZH/e4fdlHr2BbiUTEn3kWX0raUEPh1XEIUkveDeadO3dPXUT/UrjfnTbb2lgUmAqWD93gdKdF1wcPykd/SWt8T+iEWqe4WdH1r6lxARIAEOYTolPm5wLiz16pupAyONJHvmnjXt0MIkinGQTVCECfl/FbxkHp051YwSPftLrbQdYl+x676kMHHJMRk11Qrw48mygNzLkhajsuWe4q//4PjhtFt+8JBYZyFfsppI9z+8ZnyWyodraKxD+fHkky6nauT5xW7wmNz4cDU1i1g5td0RSbBWBOwl2rJwNdyKFfOKF4OTNLJe55zOOuvGmccEmrIJ+asxBHPOvYu8kmfgbkTl0IDscbQg4A2i2DIbaCUwor77wIqclhoWZ7xnrLlooDhfrHnOejliwsw9S3WlgUzqwzCD3Yy/6W5zDrRz8sSrJhdYVIExB51zj1WiwEKztJqVUcCxGy3pwJN75dw/4kfhHzSKft9g9h4F/83Tz/dl1BrFTPiU/nUWwyuFCBsm9tA2C2zqZQ/GoMLtJ8uYXAZfdPrqGkSBQyw+NvjR/hVSqhovqsYlhAmPCYGSeyUQRMMjTzs1x4p3TlrIQ3TlqK0B1UiMmh0uRDREB5bVw0ikZ15tMHsQh5WeFPHryClLbxPnSE/DTBKTartpQeJRplP5dhiQONy1hoknZOZUDQk/g46gDvn2yERFkTRagzk/bHfwynaLmEAmYPf2j64w/6g77nsBi4kHulRy4UBNiGOPL+OKP8pS/yXznjrKJojAmdZpveSHnrAlKXUn0jdtplEk+SVpafLrn/p61xgD4VRuU3j+ptotWULvazUkV5JO1lcoNp7Xe3BwgbL1voP/0sWdhhK+YZY3QQPe5U4II8Fjbm8L9DN5+dgX9JoJoSkLRk4h/Q66SLjzRNOYp8WA751A7GtF6+6assb/ixf31pHfMMZHHyP X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 936f4a2a-be03-43d3-1b95-08db7d34e433 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2023 08:50:32.8764 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Kk7atITCcsRTWHqhBWYo5qzf6CndMPUQjsEGmJQzBykyUoB2H+B9RaZ70Czvp+raB7E9t05q1f3QxMwynxu8Jg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6282 X-MailFrom: duminjie@vivo.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: OFAUN2WQ3G2PFLOVCWN26DOZKVRVEJBR X-Message-ID-Hash: OFAUN2WQ3G2PFLOVCWN26DOZKVRVEJBR X-Mailman-Approved-At: Wed, 05 Jul 2023 10:30:13 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: make data->system.parm1 avoid double assignment. but note writes "RT message with two parameters to UMP" is one of assignment is for system.parm2? I'm not sure, Could you help check it out? Thank you! Signed-off-by: Minjie Du --- sound/core/seq/seq_ump_convert.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/core/seq/seq_ump_convert.c b/sound/core/seq/seq_ump_convert.c index eb1d86ff6..60e637149 100644 --- a/sound/core/seq/seq_ump_convert.c +++ b/sound/core/seq/seq_ump_convert.c @@ -713,7 +713,6 @@ static int system_2p_ev_to_ump_midi1(const struct snd_seq_event *event, unsigned char status) { data->system.status = status; - data->system.parm1 = (event->data.control.value >> 7) & 0x7f; data->system.parm1 = event->data.control.value & 0x7f; return 1; }