From patchwork Fri Jul 7 06:33:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 700208 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01CD2EB64D9 for ; Fri, 7 Jul 2023 06:33:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231334AbjGGGdm (ORCPT ); Fri, 7 Jul 2023 02:33:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229775AbjGGGdl (ORCPT ); Fri, 7 Jul 2023 02:33:41 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA8711FC7 for ; Thu, 6 Jul 2023 23:33:39 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-51d7e8dd118so2032995a12.1 for ; Thu, 06 Jul 2023 23:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688711618; x=1691303618; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=e1W0PEIp2Z9O+/54QqCCTT57o1K3eq1ISnoT3iEkIG4=; b=Ji+vp0Rf7GnjgL/ryIs4zj5psew4pNxA0cs8GFKCCt4E8wh0ztH3y1BPKo8A6Kr5CR Ssh+LsCi0ePSmFr6nLgrN73CA2MGcMaJIrfjpg/jM7aBYCC7QstmFfJTkw+D0od4S9CL fK43PEE9RS+gtkkroUsHTHuZrB4sb2u/XCw+wBuIGWfkCD0UmOg1nuWcTcVNjB4Y9lBJ XtIxHr9Fe2nvRTn/d7F6dMPhkKhvs3PfzluZg24d0Fqx/c5HsGGJBo/U2On4yiyKU7x2 jekKm74a17Mc0FGyAaRQgC6mRyV6NJcMAVHpqNP/NinRZ88jHW6ZblkBXu+EnDP5KDX+ smmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688711618; x=1691303618; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=e1W0PEIp2Z9O+/54QqCCTT57o1K3eq1ISnoT3iEkIG4=; b=e1QiZZOP2rxAQOvxmAX7YOqZEJVaaa2RenJosrDZG0HUJibCJXMyOrXvY7ZK2orD9B xl4Bbduvfwn/VV963Z6BUqVHYWKET7R2KkqyJ0dvLnlcFsRrNUWsQY9xV9t5UVO8rJVk KKf7Ve+ueGA3Qy1Ic+mmol2EYXuz6PnYGylJXRG3gJiWzlxjVsiIrbGvx5PjjZswWs2m BGyManlMFreBnfVWBuMXzjnMEYGWKkcBCnviDrQC1jbGuZ63MPWoZrhf1DvEL6lnTNZv GDNf/ABrb0xmuR+tlXOlUMYmRzbDZgSOlvekp4b7TUwfk3jzKaevBhxrgpA3s04K2/+U HevQ== X-Gm-Message-State: ABy/qLatm4jILW9gufu9jvCoW8hW4uZL377uFwad2bQ4iuNZaegEc1H4 JXr+oM/BCmuuKTF8VNYpNKoYKQ== X-Google-Smtp-Source: APBJJlF+EQzCxlpuXGk2rbnxNVji72DYX39eyT/xKUrWXgFmOCWnAUyM7SHtccK5tqS/eFhQSlzXhw== X-Received: by 2002:a17:907:75f6:b0:94f:449e:75db with SMTP id jz22-20020a17090775f600b0094f449e75dbmr3160188ejc.52.1688711618411; Thu, 06 Jul 2023 23:33:38 -0700 (PDT) Received: from krzk-bin.. ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id s24-20020a170906169800b0096f7500502csm1724803ejd.199.2023.07.06.23.33.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 23:33:38 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 1/3] arm64: dts: rockchip: correct wifi interrupt flag in eaidk-610 Date: Fri, 7 Jul 2023 08:33:33 +0200 Message-Id: <20230707063335.13317-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE. Correct the interrupt flags, assuming the author of the code wanted same logical behavior behind the name "ACTIVE_xxx", this is: ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH Signed-off-by: Krzysztof Kozlowski --- Changes in v2: 1. Correct subject and commit msg (active low -> high) --- arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts b/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts index d1f343345f67..6464ef4d113d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts @@ -773,7 +773,7 @@ brcmf: wifi@1 { compatible = "brcm,bcm4329-fmac"; reg = <1>; interrupt-parent = <&gpio0>; - interrupts = ; + interrupts = ; interrupt-names = "host-wake"; pinctrl-names = "default"; pinctrl-0 = <&wifi_host_wake_l>; From patchwork Fri Jul 7 06:33:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 700422 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33731C0015E for ; Fri, 7 Jul 2023 06:33:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231796AbjGGGdo (ORCPT ); Fri, 7 Jul 2023 02:33:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231691AbjGGGdm (ORCPT ); Fri, 7 Jul 2023 02:33:42 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6286B1FD8 for ; Thu, 6 Jul 2023 23:33:41 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-9939fbb7191so285123266b.0 for ; Thu, 06 Jul 2023 23:33:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688711620; x=1691303620; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2gUQGEXg3NwnR1jgA5o6lKwJkp5ln8c5jv9qArkjhok=; b=sk8oCY0kkiy/wQ/T3PrdyQFle55qJrxLJxCZ13gyQrboPMWCk6ag5YJu24CBFoVacr E1FkxQTtKjBt5g4vZF9jTM4+MgIVlyTd64hzg21sNVcsIl62YD7WycredOLAT5i7L7If JTxIJmky9s2SSiiugSYOZVbgAVp9PlkQ0h6Slm7erVmqSxMTPkNvtCzufmFX+8UCHBkY qBG7dEUj9oHyRpcAFm5GbSMB2H673Cjbl6kWvdjfWNHKaXQFVPkK2urVkRfIuOV/ls28 O034wkpRgYcMfqZ+fbyybp2R2I7/uyaBs2Ug1bVVPBFIFlpuEGAacghxN8nWmEMrhFUU NcnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688711620; x=1691303620; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2gUQGEXg3NwnR1jgA5o6lKwJkp5ln8c5jv9qArkjhok=; b=kjZOsIW0GhRFhrsNQg0YpJ85WJ44R1j1It6Ph9nBBpD2q5ajHjugOaWmhPqiAoe8gZ fpz3vUL6qSUBYAmVfPdCExco0RhdXzmgqNSQGhJzsHBs/7nQLzZDpyqJDPcQtHcCLQvG j7anIqA2XO3WDlXceXke0YqMs95h++ghH/hEONH08D3o1RlKUisD1GuQn2bnMykx1pQH BT4Edsbt4Eh7L2wRS4UbGajGaCfYg0xnrID7wKB1D1cCMrE+wHUNois9pEqSd0/hL/XL bO3ZshKVRSAXw5wlHayHTYBm/wbe7DFPwuIx0oXbya5EUZzpZrRcPhKdBbOjv1OYK29g l82Q== X-Gm-Message-State: ABy/qLb1uEDf09tDjOo3SjQ5aE/Qq3/t4+pfj23Hfdf0+bCgYsJoobqJ BNIo1iktRtvA27agn1KMRxyw0Q== X-Google-Smtp-Source: APBJJlH96voHWJqw+7toXEhMMh6gynJRIf12CWBLI1qv1yuI+YA1nsA1kJzUNcK9ofFPaNqH2e0hIQ== X-Received: by 2002:a17:907:d15:b0:992:103c:43fa with SMTP id gn21-20020a1709070d1500b00992103c43famr7378130ejc.30.1688711619777; Thu, 06 Jul 2023 23:33:39 -0700 (PDT) Received: from krzk-bin.. ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id s24-20020a170906169800b0096f7500502csm1724803ejd.199.2023.07.06.23.33.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 23:33:39 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Christopher Obbard Subject: [PATCH v2 2/3] arm64: dts: rockchip: correct wifi interrupt flag in Rock Pi 4B Date: Fri, 7 Jul 2023 08:33:34 +0200 Message-Id: <20230707063335.13317-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230707063335.13317-1-krzysztof.kozlowski@linaro.org> References: <20230707063335.13317-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE. Correct the interrupt flags, assuming the author of the code wanted same logical behavior behind the name "ACTIVE_xxx", this is: ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH Signed-off-by: Krzysztof Kozlowski Tested-by: Christopher Obbard --- Changes in v2: 1. Correct subject and commit msg (active low -> high) 2. Add Tb tag --- arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts index cec3b7b1b947..8a17c1eaae15 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts @@ -31,7 +31,7 @@ brcmf: wifi@1 { compatible = "brcm,bcm4329-fmac"; reg = <1>; interrupt-parent = <&gpio0>; - interrupts = ; + interrupts = ; interrupt-names = "host-wake"; pinctrl-names = "default"; pinctrl-0 = <&wifi_host_wake_l>; From patchwork Fri Jul 7 06:33:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 700207 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B916BEB64DA for ; Fri, 7 Jul 2023 06:33:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231833AbjGGGdp (ORCPT ); Fri, 7 Jul 2023 02:33:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231781AbjGGGdo (ORCPT ); Fri, 7 Jul 2023 02:33:44 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5C4D1FC9 for ; Thu, 6 Jul 2023 23:33:42 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-51d7f4c1cfeso1976691a12.0 for ; Thu, 06 Jul 2023 23:33:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688711621; x=1691303621; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2rZJMXQqBbYtG35iaT5k3WfIhsJUmOKUvW8i0uD8NBI=; b=R6ZFDYFtiyI8QhUOPF6/ZqW8UzJswYZ0EN+ADhSd2YTyJsje3D0PZj3nDoKg+IU2g6 oePk+WhsqDnjZIloNBJmSLMHqjTh7jSs/l2GuCbZETzeD4fx6VwJvnlNXfHHZ8GGPRsD 5ICdV+l8u7Nf6IaA+Rsx6fDrSi/rctd28Y6urlyxFCJiagJlNi87Cr3wP6dis1J8wMc1 eTAl9POvBZ3rb38PLgSDNFPh8k2X3OUDM+GRlL4FpHdIPiyxXES1wcNDdpM0Btn4wxCt QIB9RujK6e936OkZFLvYEedcYoGVRECEYmBhWA9J2y9lkb4N+5Iey2L4FSf/Pl1ycqFq inwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688711621; x=1691303621; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2rZJMXQqBbYtG35iaT5k3WfIhsJUmOKUvW8i0uD8NBI=; b=TNPfU81uRKlqKSig9wJoG8DjxfsKVM5gOEbzubGXRS1IUtWW1SMxK1J3YRPYqQcGNC hMqaunZgFZ97IK96kZbDs9mPoOibgYRWAOymUXjWub99w0OJrPLMS4jOphleN+diJKFy 7lV/K7PWr15BH8q/LmNHOLcxLyQL+JoHBiSIItrmNZpoRUR3vcpXt3JFAuJ5RvhmbNei vWRFf6SC6gGN/o6vCPQ4/WS8+eRFqkFTvl63v9Qk0cEohN2FYip6aXCsfRNgF+JfWz1Y 14CiLiWPqdkLmZYZKHkXPonXlBQTmKKFhB3V+XFZzuo4PDGiQx3bV+tOVkmDCvlm+G7c JG0A== X-Gm-Message-State: ABy/qLap29pGWMDZf810v2Eaxr14KMYcahPQiDw3+z4wRn6Gu6qIZ373 +v12LIi0Q52ZL/91Ug2JvVKl4w== X-Google-Smtp-Source: APBJJlFbgp3bzMYcY5DMSqClEkgQHsd57Rd5nfrMO9olrSVVPArWA9IWaAqP0FBML7kLKVnjeSzKyg== X-Received: by 2002:a17:906:d7b1:b0:98e:1b9b:aef7 with SMTP id pk17-20020a170906d7b100b0098e1b9baef7mr2683392ejb.64.1688711621156; Thu, 06 Jul 2023 23:33:41 -0700 (PDT) Received: from krzk-bin.. ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id s24-20020a170906169800b0096f7500502csm1724803ejd.199.2023.07.06.23.33.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 23:33:40 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH v2 3/3] arm64: dts: rockchip: correct wifi interrupt flag in Box Demo Date: Fri, 7 Jul 2023 08:33:35 +0200 Message-Id: <20230707063335.13317-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230707063335.13317-1-krzysztof.kozlowski@linaro.org> References: <20230707063335.13317-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE. Correct the interrupt flags, assuming the author of the code wanted same logical behavior behind the name "ACTIVE_xxx", this is: ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH Signed-off-by: Krzysztof Kozlowski --- Changes in v2: 1. Correct subject and commit msg (active low -> high) --- arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts index 322f3e809f15..0c18406e4c59 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts +++ b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts @@ -416,7 +416,7 @@ brcmf: wifi@1 { compatible = "brcm,bcm4329-fmac"; reg = <1>; interrupt-parent = <&gpio2>; - interrupts = ; + interrupts = ; interrupt-names = "host-wake"; pinctrl-names = "default"; pinctrl-0 = <&wifi_host_wake_h>;