From patchwork Wed Jul 26 03:59:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706847 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BE63C001DE for ; Wed, 26 Jul 2023 04:01:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231293AbjGZEB3 (ORCPT ); Wed, 26 Jul 2023 00:01:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229535AbjGZEBG (ORCPT ); Wed, 26 Jul 2023 00:01:06 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2131.outbound.protection.outlook.com [40.107.215.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A857268C; Tue, 25 Jul 2023 21:01:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fh7YWxdKOALah58bnDCmiZ2sCI0qE/25krITgbQQb4JAyj3GqXK8aPyU4nyEmLtnMTeCavsk3rANyBrQcsK0ZWx1I9IVyBz48owFCUA9x8G29QZfyzID5LaHg2AnCiuVGpSKj5go3k4rEwjPcYokxeAhpao+NmYNUkO8eTf/gofE7BQgzT9Z05d3nIwbojHxygbcn+jXIDkqcFSbB5ilgaSnfO3CRHderFZb+Zb9PGZ4W4LVl2DkTo2ANVIdJcaVlYWrgLQuWjcDGrZM4wYUkn0JfpHSAzowEu1+Ae4wDuL4c3679V+VjhQthGG272zYEUqk0CrZ3IR2bLTP+c1P1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0QdurEMlGIZsmiqW8S2xEYZCcDPaCpY8fWT4ehR5P58=; b=H4jErh3ybX48QhlrZGay7/tVz0PTb27F+7xled3A/i7z0trUt+foAGzgFRlAMtaK5dRWbRna+1KuisEphodWakE6edWCorXMrwaYWpXr2dBGa96jzmqpYo+ouLPreUF+Jj4xlpM+/DhZM+4m6I/pd2O6rZYID7LgJP+CLAtl0+uEUukdeOuFUF4CpK9Z/eRHBEcHz1q0s1VkZSLlPlMJqPo2o9/16QUaNqe5rHfgRKLCOA7vUohEnHVLNJ0ETi36HzhTPWRdkwrXAzKWo35RcpwAo9weufSTsHgRlgwOPg07OeyxQdevXxmyIeGMXHgHVgs7R9fdnA2o5xZXrjquWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0QdurEMlGIZsmiqW8S2xEYZCcDPaCpY8fWT4ehR5P58=; b=NruAjOg31qMr1XZqENKd9LE5/XDm4XlRqoNJfmhdPRF1bnSwe5GJdzQM/Nc3Nf+L9LtrWG5B/xQIbEwjxr5eDNQ7CuXdz3X9At2qfUltF0zlhMxr2BfQily8YvminzhTDxyVPDBUYhJeI1qHIDEZzyo4P9NMwnx7If7IetvdFLWezCTXk1R2+Il4N3mFZ0RGAtmLmD+h5MBzGeIRVk7FJ0lyaVOS/ZgWm0diqX3AX7yHiIBkzT6jZmdvovrHylAbi/Sge+TznqDqalGuZv09ERqrqmzaL/MXWW3NGpsgE6TrjO8yP8TAi06p0OxqjTiMReFJY2fR0MvaGHjfsEeQSQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB5463.apcprd06.prod.outlook.com (2603:1096:820:c3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.25; Wed, 26 Jul 2023 04:01:00 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:01:00 +0000 From: Yangtao Li To: Ulf Hansson , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 02/61] mmc: bcm2835: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 11:59:42 +0800 Message-Id: <20230726040041.26267-2-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB5463:EE_ X-MS-Office365-Filtering-Correlation-Id: 08d442b0-130c-4a34-4066-08db8d8cec08 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R2ZWFXdJVmAefUSR8IGC57U5g3OJ3sfLkfxhxN4uMM4Ycdi8iAxNNCeuAK//v/U/jRvrXFUI6K509ELVKTXkiFLRFRF5IlrMsUaoQkRb0EVk7YFTntX65az5AaMrFUUPDQPDRhT4xqthid40olHSrPwkFEp3+XQMCvrsiDpH4i6OGBTv+BuIHRendPQYAx1YK1oJMOPq96OimaA6qCuHLMhrpW/ZY5LBu96CbkS3x4Hkz7GbMtNoZ85iI/kKNJm5zx6xb3CYGJB1+kiq/d/7j/SQJHGmb62biXrPSMFh3nZEiVke2hQZkla04msGuXlE/bvPo50HuplaU0OtrhQsSiIjXcaztQMqjw+wlTywyCXYWicm23/GRcDvfjoWVIf4aml0s+nVNbmfDVGwRuaqGBicFJbRJIqwmrdO86k5l3lMd5xphE6Gyym4u1Hb8I5S97rnuuBq7KLd8W7ExTUpVqCA9UI9YXgSA+cvGj7jWnFl0JgwBwGSW1gPpF7r4ub7WrxeuoP2tm0nYkOxHCZEBtDzgkQZE0Q7u1zbN5H1qtCw3feMz6zDVQFqVlSxYVCviSir9uJA34FkQQzjwc/T7Fdi+KAxdRGeG4bGFxhKyolNySPnIUmiTi8fkKcHNSnn X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(110136005)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(6666004)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(6506007)(26005)(1076003)(86362001)(7416002)(2906002)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?d5/4socpRjLIihxLzkLhVUsrk4jS?= =?utf-8?q?DvV1JzP/BejVD8b0AEGr5p97mFBRPKmHDC6Ae+RMgVQyLyyFPTayKn9Jr2VwLizf6?= =?utf-8?q?r2FM55MobwRyCUEVdFJjDVOK6rIFjdOf0KJXtp7sYwU74fycKsZcR+atwVAbvT0VO?= =?utf-8?q?wcg3OuB5Pu1/uHnfmjO/t60SOJ77NpLrzhh0vAMG+omWb5cgSui2vM98zPOuebmGb?= =?utf-8?q?miCHIfUO/TXrO2ZqIlqgBdGIz5bTjwn4cDscs97Y6rcJEZ4MiJz10W95kHZrwRAp8?= =?utf-8?q?2x2ESqmunF/Y9pYbrEYUaODZthSJQEZshhyqvvHHVt/qJ0Q9O8EAMGRPtVNSzQN2m?= =?utf-8?q?81KBkNetanyX3fMqlCC4n/tvfsPifTYGQe05c7G0eoKHhH/u3X3Ax/zI84PfHwjI0?= =?utf-8?q?JkCyQuIIkwLhEELESlpnrF0XrIdG36ZSMNYQK5u/+l3gUl28057qgTnZ0mhoOeWmZ?= =?utf-8?q?IpipyEJpx7I4nGrYVg9xbpxqdYNnmpdz96+ugJ5ygAjVpYxo4Gxu6jWR04k+T4+sc?= =?utf-8?q?gc6ufWvXevWSJI1n5KLJs8J76zYyPoi1Wh//Kq9Pjr8vGeJEunNgRyusc7zfBwAhz?= =?utf-8?q?p/Y9VGT/gQFuqDpR5Ioxxa8hDH0u4ABlMhH4pD6Mvdy7gW5pYQOU15/hShkijekAb?= =?utf-8?q?RUDmCvrr9kiul6HnZkBsNRbVm2+YcsRixh4lRSNJnGNsEDRw/033zYjecJAWubUFv?= =?utf-8?q?ghLragaODKfCLB1AAjgjZZUVLiLEOTGHqbg+VSY10zSfzbRY3zUnylMfDjmX2CsrU?= =?utf-8?q?BB6y+9HD2YO3WJJ8Ip1CGiOoRRSND1SsumWM9p4dsQWO5yqcCVF9TY2y1k8q0KbIO?= =?utf-8?q?em0G/6r5S9cBaIAXEDETxxbPMwYRXyc4MVbbnNlq7dQMHJy4eL/aHGF7g48+0GloG?= =?utf-8?q?Zmqj0N3DEJ2wFWa+q022PYkqe15W0UxXwcWnSGjWzxs1B+uvNh5brs9m4s8Y2xaqh?= =?utf-8?q?z1GC50OLQlsUxi2FX/ARJQltCFMT34dQunhrRo4JvAB6V4sZEoGOvYGz3dB4Uxnam?= =?utf-8?q?yhDCEp8R2nnMeTcpjWKpljg6x26qutEgtdyQbjaOnoqY5GvgDUikIYU8El7x9SjRB?= =?utf-8?q?QlOtKgNUW8wahLCFmviynpCLRC8Vsjuc4zO62dkdttWUtdVqMONXEUdCo2eUbOFRv?= =?utf-8?q?vJXkbCOv8vU6+LK5PpHA9OTnEZDfnoqlvkQd7TzblWeFZPCbabLpI23it24SLU5MJ?= =?utf-8?q?/SHyN9nd3Q8d4yf9ELbzHvNuEpfEDML9YmrwG+uR1YA7e54VoVfoFbuTTNQDEVFMz?= =?utf-8?q?X9yLBRlSTv9hKMk8A89HULGoujk7T38OCoaisnL8gho/AE3TDgxmanUpN6XzfVz6T?= =?utf-8?q?STG2y79+QfPpnISDFKfHeAHXJ+4hFxAFeIBjz+vguGgwN0JR2v1LWp35NmPwpEdQW?= =?utf-8?q?m464+7aCJIn8hmcMLVF1Ga+Dqp0ey3R7Vrdbm0q5SHrFGaWxTR2xpFEb31Fgaa0BU?= =?utf-8?q?N2MbNGC/Mv3p9s8VPf/65bpw3fuabphvQwrUYkHaY5QAFKhSr16YLi/mYBxlBYjx+?= =?utf-8?q?1pXPDYBlR4v2?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08d442b0-130c-4a34-4066-08db8d8cec08 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:00:59.9743 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oKrN8aINOvnirejrfeB/CP03i+jJQVk/0hkfLGw67uh4vWaqfE4ZAg7ksyG6kAsfR6NmlOXisYKBlAzz2iHSlw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB5463 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Reviewed-by: Florian Fainelli --- drivers/mmc/host/bcm2835.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/bcm2835.c b/drivers/mmc/host/bcm2835.c index eea208856ce0..35d8fdea668b 100644 --- a/drivers/mmc/host/bcm2835.c +++ b/drivers/mmc/host/bcm2835.c @@ -1431,7 +1431,7 @@ static int bcm2835_probe(struct platform_device *pdev) return ret; } -static int bcm2835_remove(struct platform_device *pdev) +static void bcm2835_remove(struct platform_device *pdev) { struct bcm2835_host *host = platform_get_drvdata(pdev); struct mmc_host *mmc = mmc_from_priv(host); @@ -1449,8 +1449,6 @@ static int bcm2835_remove(struct platform_device *pdev) dma_release_channel(host->dma_chan_rxtx); mmc_free_host(mmc); - - return 0; } static const struct of_device_id bcm2835_match[] = { @@ -1461,7 +1459,7 @@ MODULE_DEVICE_TABLE(of, bcm2835_match); static struct platform_driver bcm2835_driver = { .probe = bcm2835_probe, - .remove = bcm2835_remove, + .remove_new = bcm2835_remove, .driver = { .name = "sdhost-bcm2835", .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Wed Jul 26 03:59:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706850 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 064A5C001DE for ; Wed, 26 Jul 2023 04:01:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229966AbjGZEBV (ORCPT ); Wed, 26 Jul 2023 00:01:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230050AbjGZEBK (ORCPT ); Wed, 26 Jul 2023 00:01:10 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2131.outbound.protection.outlook.com [40.107.215.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A1FC26A5; Tue, 25 Jul 2023 21:01:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GMep3FonivACgSzPK+gHB4L4PwO4bp7pZIEgfg/sfcDlBCSY8y3RMtFxbDyPxhv7gs+nElSwJfcoSGyzVC44GnDVvs1dRkwO8bVjPxFW3BHuRR1Ogzw746sOdrj8YPjQivGO6OZ4TkmHD7GUdx1vHBUUHSUBjiYi6twZxM8ivkjBRHQNHpNKTfmeS7oWYSBTJK6/CwqOpD2/CIB20mzE+GRXr1xl95KIHm4tdpCkKiNO4lwuXorLmpPlb/JQFhwCyuoW3Wn/eJLjG0QEqfgUzPsaxfqZ/CG7yaqjUhXJx8BYRUUSZOGGffJLOMdQhD/pwtDC4pzsv/aSOqQ/QChbMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g/FjFXOniG69N9nJR/0wcardmXaPuoPDf1/5LYlD30c=; b=Z+/+gdUtFxIL/0DUNMrFmH/oZLMxWX6V4m6hN5On+3YHxI0meneUh25gS03iVd+ErjUSswQR4TRkeM0k74FNm90UWtpscN5TATIOUcm9tRVSsCVrJR9E7ZghLx/4AoLSW9dxnjzy5Tx/4nQ1maWbDaKqj5fbHn/Ox3Ea/GZiTLgm7p+OzF7WdDfBLrISS4uGAF9lYQ2HP5py81c7PZ4eEQnbWWcs4+GLjF4JnnTToUxiVmvpVfGoNwjzvpjYRyP8zDYsbzcvt/O/P1stmOtrfngln/48o2PdiesufXORPLKY4aTwVXsJMS8I9wOoNSe56eh5xyFJtnxKf9nLfGt6jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g/FjFXOniG69N9nJR/0wcardmXaPuoPDf1/5LYlD30c=; b=PmsyaZ7JH27nwgeQuzanaD3MbWTI/Ej//oc18UB+/BkefVCHHkZbHxtL1UaIvJVlYp2pT/Tmb+a60fj+zzeaepeGuRyBlV4D3KmL1ZwPi7gQWkuorYDf9VWdfxvmYY3FUhAZUCL2kX98uM4YizhrYN3ICUU9had4FCfWFOBtUlpDJTGPnKInX+4Lovxeda7l1J2ztidFgOihdh60HQFzKVqQKdXoR07/wG2+Xoy2HIdEXU+4NNi/SFObCJ/ScFRUXVk7hTHmN5L1i2ZWrcacpyCZ+USztqv5WHKAumjT3QbwORll1zO+4byPWroQUmCxFPJupDMF0Ntgd7VgpED5EA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB5463.apcprd06.prod.outlook.com (2603:1096:820:c3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.25; Wed, 26 Jul 2023 04:01:04 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:01:04 +0000 From: Yangtao Li To: Ulf Hansson , Karol Gugala , Mateusz Holenko , Gabriel Somlo , Joel Stanley Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 04/61] mmc: litex_mmc: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 11:59:44 +0800 Message-Id: <20230726040041.26267-4-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB5463:EE_ X-MS-Office365-Filtering-Correlation-Id: 8790577c-d439-41fb-1f0b-08db8d8cee49 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ffd3mD2VrfUdkopFRFpkxDyruaSNi1SrEfvteXGEKFwjJaFDL6wfKLIuiZNzkn41AcOQxOxFznk7UEIUmiMwQ5cCAio0I1ZDCr5acLxgBxH+GhdP1Qfulf0TWaAowJz8lwubTTBsSzGdKixS5OIJI0rTMF2Hw5l/KQJhOevy/tHwXE8ZkVS7Mnfrwy9jdKmjFU31aAdViPj4mx6ARG/6XDnO/Hr3EvnRnxjCMPvLk0yFOkn3xjmawgNO0GXwIcI2yGQx1lVJoNT3127mGHqjW5H2eIS8OKVbaW7MfZ6H9Z4HqLhhQeMCPLfFewGUf+t/NlCqq6gQRPWjo6/aFuzdblQJFVaOlmQe1Y/k1VJZCORSdie/mkonjstBmXNR+ZpYGHSanyZIlvvaLs1Gb/jcPmUE8TCXREacl3izx89Vkp7k5Au7amnEBWifooKGd4a9kOJN212eygidB41Uiv/DxCIYyP4CkLpt7V0/mtXf9YzxzMurs3kOYn9jwUsQG/JkTMP4JUk+qNHBUtTgDclOXCwdXQEVENZpk5RUztVkVGFttj2n7wdiOkIT5vuOlSnKEsnHhoMKdeV4NttwjdDGUuS5Q49EoQjUG2ajCaHs9KXsOSeLZbVkUG+6zlAXLN2l X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(110136005)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(6666004)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(6506007)(26005)(1076003)(86362001)(2906002)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?xC/t9Kk+3VRHRaTMyJQjuoim1erV?= =?utf-8?q?VwsnNKuAThdaeGUkT5eISLKQZJSaCkES6z6vdjkivd5pUYCCUwX1CFi8sGIH6NqeI?= =?utf-8?q?EispTNnAeGY+ekdaGBKQoydsnX6Gi1GmGSi9AsOMR8IDGPFq+Oq3UPG2pyAKdnudZ?= =?utf-8?q?DVS4tl8R5iHe/aLr5FnQV/bqZaqV2JUN1abDMZvBWBWiTvhfzu5pj4IYgHVnv4Jbp?= =?utf-8?q?xnYuCYgzqPyOyapesAU5HYqcUVCygpdqqWOxNveO+Wr+h2J4X5SgTz5Xlz1gpNdsf?= =?utf-8?q?WxKBlzIWYIOqQwevYbmdzrRDnXWeWGFUbBzTI/mp3+NHOV3e5SfCO3y0GJvCMg23r?= =?utf-8?q?RccUV4mVTPpmABqWQcb7qM6JAUaMZifodE92geNmUziv7wKyZCZZWlgUT8T4hbieo?= =?utf-8?q?ulJCkXnOoPbGgol5EdeJ2ufSq+pGn952hx8fYwWYH01M4//y6lio13ZtsRDoNW9IG?= =?utf-8?q?yaL6VJ6q8J6LovZoOskwiGkd/J4ZJYYsAJMlPxa9Fy6njd4c3MqtzAXUDBRZC7H0M?= =?utf-8?q?Db6vL/CiTVYMvuFZBUdQIP5Uur/PDUcLljuiqpQM0oevMpDEPncwxfBejNYazZb38?= =?utf-8?q?/ZM154r1KarsBnyWnsc8FS/KHKWUcznSW+6MQ+jye64XQcR5DPORTsw1fPaIgM8F3?= =?utf-8?q?tvxB8baXhibcdcRHaobwnTF78u3Ok05at4FNpZWVSq2hyjWlt5/Z0czbgt7tf3oIe?= =?utf-8?q?reSwPk4Lk/zFcKnZCZ3c6lSvoEQzY5dy9ahsZTEZYRgWrumYlfNMKYNpN1Xcg4iNC?= =?utf-8?q?JoN1Vz6J2yrcPUoC4L4m5Z5sjAKK9V7YltjaV19GvrEXlITuvEPZ+XC2Yn9JBNeAG?= =?utf-8?q?YMKuZ+GrSiJgjfBvrKBwVXbbtpBH+LiUkjEiGt10G4duevL+IWvDS2AZlbssZ6hxm?= =?utf-8?q?CSRdNrNkbddT+wdIAvNHxUqzuKg+2zIIvV0exG/s2djKcHOnZnIkfiNuqCPW6UbLQ?= =?utf-8?q?DqA27eav9MacxAt+B3Vf8bhq7K9p3UggdN1dtno/pWqmq+f/7wIDpEM9R11MpoAEu?= =?utf-8?q?O5xkcHkSbozuKz3wXt6KQ0XK7Htpg3wO+7YpYkFYFxVeJW3P6KjL2yRQzRC4xduNL?= =?utf-8?q?0ahtJiEVVtMUuQUHjAPCwDXvNk+viyZXU3ydrsGbOQTZEQMt4TcHcEMcN8n85HciB?= =?utf-8?q?BwdkxbcHAMJFNkN/DVYll1+A59AJLSQxAy4rtGMt8rtVUZHflwVjoGE2GD120uwvV?= =?utf-8?q?WzxQWWsfiA6+iF1aPEiTu6lUcW6pDbaxh82OziGe1/fIQQQN2jIgUb9BG4nXP0vOu?= =?utf-8?q?j1RvXn8UMQofdbY8/rPVGjbRdVflhxCCfF0dHuVTX8XQRq+E/A7keIVV8eyXqzXqH?= =?utf-8?q?OXtn1GUiKAeydnvxoHxjZQRKBl+pV7qMe1Pn0rlKbtw5ctSVmKakUQAtLB89Ad6w6?= =?utf-8?q?wGfq6zrV5mY2su+Dc/EC3SwcU64td9kwRPCb19zXMVjYA4zg8+F34yYF/YZ1GFuJ/?= =?utf-8?q?canwNovLO53ZAjXVhVkYIXwzkWlDmUE4F/PtEWvCZZVfsiE5M4Bg5CVSgAEzV00fa?= =?utf-8?q?QVmTEWgLsmrA?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8790577c-d439-41fb-1f0b-08db8d8cee49 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:01:04.3134 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BQwbqI8mJQsWFR/fXQ/enZJDZSTKqJ8204YniEcowyJjVrASTPlH2Vi3OgVYVn4sC9ko+qzSTZUNcOrEEkBoFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB5463 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/litex_mmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/litex_mmc.c b/drivers/mmc/host/litex_mmc.c index 9af6b0902efe..4ec8072dc60b 100644 --- a/drivers/mmc/host/litex_mmc.c +++ b/drivers/mmc/host/litex_mmc.c @@ -629,12 +629,11 @@ static int litex_mmc_probe(struct platform_device *pdev) return 0; } -static int litex_mmc_remove(struct platform_device *pdev) +static void litex_mmc_remove(struct platform_device *pdev) { struct litex_mmc_host *host = platform_get_drvdata(pdev); mmc_remove_host(host->mmc); - return 0; } static const struct of_device_id litex_match[] = { @@ -645,7 +644,7 @@ MODULE_DEVICE_TABLE(of, litex_match); static struct platform_driver litex_mmc_driver = { .probe = litex_mmc_probe, - .remove = litex_mmc_remove, + .remove_new = litex_mmc_remove, .driver = { .name = "litex-mmc", .of_match_table = litex_match, From patchwork Wed Jul 26 03:59:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706849 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 213C2C001DC for ; Wed, 26 Jul 2023 04:01:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230435AbjGZEBY (ORCPT ); Wed, 26 Jul 2023 00:01:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229659AbjGZEBN (ORCPT ); Wed, 26 Jul 2023 00:01:13 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2131.outbound.protection.outlook.com [40.107.215.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B799C26AE; Tue, 25 Jul 2023 21:01:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q6Fj2eaCRx8IYRQ1S2pTdSEL5ARbT8T1qV6G9GIOxcxQZ1AVN3bFvaJM+8ykxobvEMor/GThm0vaiJaTL3ziXTNuv+TfPt48P690gqdFnASRotCTfIjUwplw4RNG89TeEPAZyT+Ep39TYGLWMulXFA1oLv25vGZl1Sqzfk2MVqR/u4zBoUM31BxVXaR7uS1RkVYPwKLULdkSdv/mquxlmtxJj3UPUsj/L6c4SqIPoKIPqg0+ed+UaE61BM4GC8b469ipG1k5xe7GVVMTcz6W2ZjCvYnFE9lp90SxWqip2ZbYvt2sOCxskfVIZw0W3B9xk8MM9+5kaVH8o1KbdsorMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cO/T/iqSahPS1fYBVSCrfdexxtG7yArNkbxS9PglIXI=; b=Fd9oFGRnnzLi+AlbLo8y1jFKTXmyoDmbwne7NVmEz3v6sybuCYSUw+StAXyHlB4gS87NDL7QCIPiKQ0H6RmmIDDeo6xbpi3LBLhixwpkRsTf+h2DCGgX7YTo0r+m7g3qnVRu7ZBeD3O790fRjtWfXZ4qNXkRj6d0mJKcayCJ1+fp6pb5wg+/sTkvg1VBI8/PWM1p2TKQL7UfFxMWZLwAW4k/p0BCUQ0jVE7M1hUZ30ARObhz48FhpNzzM8lUk4drohzLw4EeWMnVr2GU1JS/f3eWbUwdAy0NMtgIjinzSgzrLXYEiZM1TT8u6NjU0lfNgcCZJyiUoosuHKpDzGhHRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cO/T/iqSahPS1fYBVSCrfdexxtG7yArNkbxS9PglIXI=; b=QhMbmKRDdXg/OOQl6guPZoP+oZy9Zw7wimdcwfz21ME/zvYegLzLrQhJNP6GJzaZ7rleJE+mFuv6MCJxLHKP6Y7WWrZ5L5lBburryLpFkYtuU6H+V3M8PDYO0FsCi2LEAmNuJ+oh1IudwNcPhSLhltIRN22J14ZJpudo1M5I82BK/YNokH0x/LjvltoDdjuEiSzt/AAKrBM9SaUNoDa4jg20N0xfdthwrBwtXDhZKh3+fgJqk/tVTZhjrvofKOXa5I/zRc1wptjMt+M97pKLJ8xsXOXLWMy0msojDyS1j0XVe2on5F+0ykUynkkJPkYJO0o+M5ihzVtXTI2kEM287Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB5463.apcprd06.prod.outlook.com (2603:1096:820:c3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.25; Wed, 26 Jul 2023 04:01:07 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:01:07 +0000 From: Yangtao Li To: =?utf-8?b?TWljaGHFgiBNaXJvc8WCYXc=?= , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 06/61] mmc: cb710: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 11:59:46 +0800 Message-Id: <20230726040041.26267-6-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB5463:EE_ X-MS-Office365-Filtering-Correlation-Id: e7f4c318-dcda-4de4-0f5f-08db8d8cf09d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wLQCY1k12dIcrpD6mDGr2zwjvt7VUyMsPucb03BhjehQmdPbveh5ZKpCqCOwK45KjPkYtOTNL62MJHnFoMS/6Gxhbft4YlxR+KUtLtG0YRBgJhMQdm4TiU+vNR1sAY5bVN4GhfxDkU7iqQ1eX6aH5hz1qaysLCtxcgCcEmPfZpMCJXLofLsclJunctrEVkMU7Bbdd46C/tm0vnwwYEBKpMe30BCchBcSJpmt2lBghH5MVwaJ8GlaNq0ZBfHloHydOGBcLJ6pNLM/cmdod990TieIXHYTMVs8MA9hPQtdfi/c4sLHniDSquqIraTkQ/zYH0bm0GVfc0aCm0DHEi/9/OgUSJ5CRd742k2X9necMSEInaqypfGD03PKVy4aq4YgHQQehgTX7nOsxu6soj3GuTCLlv3Mo+IQ9cJnewiRvRbrIynvg2uUxytI1orKvjvbFVnj+wr7SNJpRPHH8l9Bi2i5zZhSS2verJh9YtgR0CXh7pu40vXUZUWwc1MbWd25mzDA58aZUHHPhIv6QpnplQjaBcN0q9FuZfs1YQHQUD6jMURD4/Mzdtcq2P4Fj9gMU75ujF+2oeys3DlCeIfZ+W1bOaU1yO2xxNh6l0cVUtM74Ndv5vrlbzRg8yNFMuzs X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(110136005)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(6666004)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(66574015)(6506007)(26005)(1076003)(86362001)(2906002)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?k9KjAdbL/AhGgcizUpSPUwNNcq6K?= =?utf-8?q?16vR/CrwT+Z6rdb+g7lUQ+I2E2+easVpDspLqAWMR1AP4ytO9HnuAUSKWagcBw1DB?= =?utf-8?q?LsU/48gxxNlXiPmCw6qikDaRvj5Vt2YAwqc+ZYswSQSIRzVwhXAZp1FXf1AEM8xX0?= =?utf-8?q?WS8tmUSOnDoqbHUK0/hYx4ZEWk0VnLQzX7P5/kZbItH4NqTn1O4/rfpqAtY9RFyYO?= =?utf-8?q?1EAm+Vg3Rm3c6rWwP7HHtcTQ57ii2vjx2R5pySAqeSlO1mGvBcdqlA9DvWFxdDnyj?= =?utf-8?q?g1W2l6VEI6jJSEInoYNwgkS0E14FM6kcIjDaLIKDmSbHT7f1/eRQ6op0W51tIC9bD?= =?utf-8?q?MjyJhREwDck5XnuBzoB/mPQDYH0LRqPpkPemwWdroEkZ102YdCCFbdq7K9u7OkJec?= =?utf-8?q?Z9Yy6XirGUgS9B9WS037LcO5ZV2Im5ZKYAE/EVIoGtnG+kVzCgbynUB5eyuFq2lSS?= =?utf-8?q?V2ErsM2ne6LOmE0zJMuTHIJPyuCIEl+0Wrw62spejsNYZ/mUeIPVtNNOps/WvEzrO?= =?utf-8?q?/JnSeZNjd+JjAB/4NwogE2KOYVL5F1OhnYI+Vd3kO5HrwUrL4SafT9jRUewe6kaR3?= =?utf-8?q?EEBzQfihNNUi4jfdW21pZm1kilQ3apVT5d5ET241g0LIUgZdkJSaWzadRScdlf+22?= =?utf-8?q?bEUb3xaeFdksISDTPHnfoM21n//pnS3hqEw7GC9TDP8J2HQLBlZPW1Q8QiIB/4eGv?= =?utf-8?q?lte2QZiUOvj5/LDd665jSaKbAHlKtRqXaAWzbcn407FbdeVD8NtBOXOzRKAm3SDCF?= =?utf-8?q?NEPu9gOIw0kzlrT3Xfij1JiSlZJlO8UARvWVVQNSSz82Xb30w/WDGXOu8eEOzUteR?= =?utf-8?q?OcOyut/iNXQZ/DwaLdndFGfwfDIvA46q8KUdowG7cCrW5RjMLrhbbZRmXj3PPf1z/?= =?utf-8?q?IW9Wy7dco8eZ7gcCB1QV1SkfLzH6CwavvAiqO753sgB3bGK5UadYxvzthS3rgZ1mF?= =?utf-8?q?290vYPkyw5xCgHq83YOsGiY+pbHEkndvjvx13ewwUozvwdAusCZkNsc9NLWGCwn2n?= =?utf-8?q?Z2YgwA8btadOQR8PMWhdY5bN8aq4I5q37qdThBbnDqqHx830HwH+WlWWrIghBn5fh?= =?utf-8?q?SLApS0GjiqdfcwOMFvohVJu2mhGoJAV2K4hMxqYEDG3bH88b2d5/iZztDvGyPwR04?= =?utf-8?q?rWBPfMMxNCH75dRllHkdrYMUaRWhkVivzfuBVlFPOJadyVQhqM6yxURHIydUiX4/X?= =?utf-8?q?00i3w2cWgjfFiwG++aJh/HC8Ojr7BSnLo+DTyCSOW4+XeGsl7WznfyopLea4CGHTH?= =?utf-8?q?tGIUaGtSjdik+Ord+eBsPBB7MO3txy3OGx4MJcRk4/yLwff0x/lqUJ8R2GZODaNoB?= =?utf-8?q?wqyOGb16PnBLTjG3Vay8fVzOlbK6C46qX5rQ2GRXDQ1zpnUtRa7ZH5xrD35uBKFie?= =?utf-8?q?gR2NekZeNEU6L5KU5LdK7gPuFPY5n7bz6lsDFaoxzhrnSMI/NG08h3lAR5HT5rYYj?= =?utf-8?q?ePnqN1R/fKq9vsmWf8YrVOLQmsCkHSxNW2Ok6F4UIiavUfYrjvUKig8piFjIId4qs?= =?utf-8?q?/Hi8MbOhQ+TP?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e7f4c318-dcda-4de4-0f5f-08db8d8cf09d X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:01:07.5966 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XUcIEx4xz10cX0FJjvBbUcd0h+GklEfN9Pqbhpnxak2irWl4W/01ec+sgjNeUdCo3fsubaw3Jsh2YZlmcbyhOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB5463 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Acked-by: Michał Mirosław --- drivers/mmc/host/cb710-mmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/cb710-mmc.c b/drivers/mmc/host/cb710-mmc.c index 6d623b2681c3..0aec33b88bef 100644 --- a/drivers/mmc/host/cb710-mmc.c +++ b/drivers/mmc/host/cb710-mmc.c @@ -745,7 +745,7 @@ static int cb710_mmc_init(struct platform_device *pdev) return err; } -static int cb710_mmc_exit(struct platform_device *pdev) +static void cb710_mmc_exit(struct platform_device *pdev) { struct cb710_slot *slot = cb710_pdev_to_slot(pdev); struct mmc_host *mmc = cb710_slot_to_mmc(slot); @@ -766,13 +766,12 @@ static int cb710_mmc_exit(struct platform_device *pdev) tasklet_kill(&reader->finish_req_tasklet); mmc_free_host(mmc); - return 0; } static struct platform_driver cb710_mmc_driver = { .driver.name = "cb710-mmc", .probe = cb710_mmc_init, - .remove = cb710_mmc_exit, + .remove_new = cb710_mmc_exit, #ifdef CONFIG_PM .suspend = cb710_mmc_suspend, .resume = cb710_mmc_resume, From patchwork Wed Jul 26 03:59:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706848 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEC3AC00528 for ; Wed, 26 Jul 2023 04:01:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231314AbjGZEB2 (ORCPT ); Wed, 26 Jul 2023 00:01:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230291AbjGZEBR (ORCPT ); Wed, 26 Jul 2023 00:01:17 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2131.outbound.protection.outlook.com [40.107.215.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A237826B7; Tue, 25 Jul 2023 21:01:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V6LPhN9ibixv6tv9Eb66+rOiCuyAVFXRI7u3VTdMaJ8B5LOsn5P49IfQs3VD0BolNeA4m2Lhc+Q5t7XHwf2FwpHVPVd+MBvNsFtOSjJw5SVrzqWm8W+9MnP72DjAxQ99o8nOLCQoA2y3yi7UKNWsT1N3cI8LBCGk/9A3KGW9qvuGNOO2uzSI8C4LtXFp0mV5yatnXfW66R6XMbwSYEkZGvIV70p/iFD0c03sQHVe1xr+syzliB/l4ZPMioHklVPTbwNciCahQIH0f6V29MLFM+YBgbbsEUuMdrajyRWiZQ/WcUT1ISXrB6n8kc2GLB5kMSAJ1Sr5h2JbwvuaZwFbqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N7okkAtAy4Ay200gbDx0jngJNeo2uhW4SadPJUa5pIw=; b=kaf/Snv+sEh/Pg8G5cnF083FXELxXPGImeB/Au5tsMfKQKrKRItmZdjrL0YKnBYGUb6eFKFtVfYIG0pqnvbouivveHg0mBAE1TW97PmvLVt+W/OUZZc91ZWtocl8br6kSgP38L7RiIj+ypW6UGH5jrfLWsdqKjL3JdLDOHrpF4CHL+CKz0PE7yHfM2j2uWca7Fc60DkS1pR71+UFrX10JWGH/hTQLb09bjIhi6nv1WUnDbyczcVg6cdaCU28PUhXl/DXYaYRWar9NQg530qWD+ds7FAmejseHtoD/sfwaoYWF4QWZg06pc2o90pVbEnT1Zc0tzfQSqQBm/++XbMiIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N7okkAtAy4Ay200gbDx0jngJNeo2uhW4SadPJUa5pIw=; b=Rf74xZWHQb42YSn+uFw4yGdkTZZw1WQWQ1tBRjvrEo2JxCnqpyQVxTGlxUkuZOV79riwxR0TWSny4XUtND+o57mlf9VAX7N35MvyHlftWNUR0jgim7CpI6/lhAq79FY4nKJJKCeBic643jOhJ1gn/ahu/Jcd61OTeVNDiHKF4G/9yqnpEY6YfzD1M7ntLzR1gzWg6UKoR4giKujCFUI5Rg6n1LNn2Bkz/T/yreRy/DJak8oNhOun7ClsHidE3HDC+awyPQ53E0MC/k+QqTAxEiHIl/har2FUF1XftlPt3yeZMRCuXj5LQ7Q7S/4M7Sj8c3bhO1x9C6sVCCoSh2Ewmw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB5463.apcprd06.prod.outlook.com (2603:1096:820:c3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.25; Wed, 26 Jul 2023 04:01:11 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:01:11 +0000 From: Yangtao Li To: Jaehoon Chung , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 08/61] mmc: dw_mmc: hi3798cv200: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 11:59:48 +0800 Message-Id: <20230726040041.26267-8-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB5463:EE_ X-MS-Office365-Filtering-Correlation-Id: 4914b60d-ed6c-4986-6aa2-08db8d8cf296 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AfPLXcy+B0OSU+doe+6n9k+/ihtNEEqqicfY8owA786ZU9n8khQWVwHTLNrISQBlwEiLpTMPZEluf7H48Nl+USQAyq9bY9BLBQaWp797Sb+uvOQ83gpL4DfDnTDuCKiJKld6pwo6BD9IjM4i2dzQRuBTqs8Tro/HSHNRCjM2O21/wQbO/VN4Vely6ZUtJdSVaOLtc3UjEjzY5xKS36JSXqxEgwrC1rqTTfJTZmkoOoa0lwTRIokujUqaZ21kGJ9KPaMu1rXoHmUcFTGXAZdGRqrDtspxCDjaNQDst7JLZI9Z9JHNAcyuLlCcND3uXwHfi0hzjLX4o+OzqzW//9YS6aRUCtYhDNkiwopir7fZgA4152A72ew7dXAPqSkFCr8gf5V+BEyYn39sWXVdFZ3skmlwxMv1t+p9ls/uFZWWfi9bL7khYIIoCCF7/mFd+5oJLa+ixQbrCR16IrrOSSZMz0L1Gboh3aPkFKzl9kjscnr4/rMFg7rs5a6RBA2C/sKbQGsyIsrZ28U3eFZsBIRpLavLzQx3s3DLCnN/N+lvqT9EOzP3hF8P7Fsr5H7t/YatLURJJ+T9ghN7TrcpcCfDkg8rOpDP8AUrel+BIhRd9iaTQBrJkCAcJO33L6R8oqK9 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(110136005)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(6666004)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(6506007)(26005)(1076003)(86362001)(2906002)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?O/nE+qdj3FW1RSZbr/4+abZjH542?= =?utf-8?q?vMqtU3u5nmebanL93FWRP1FpwU+/iFVYzOiJOLrVidg/fG9uPGmsrZEES4lq7sEMI?= =?utf-8?q?R7hZKusaoYc//qUdvgOR7MnKUfH+UOta1xb0e40zD1kNDCewX9RsMQnsWqdCGL6Dv?= =?utf-8?q?rmzu+RysswGLeiJXzp9hVj3fF5uXQMJ5p92CHbOVdOvRqllZ4Yco1J4Ji4h+2aVwj?= =?utf-8?q?Kw2KpWmTURf20d6ubYfvFrF7bP13lAkZ4guOeYIHzE/Ob+bgJ7awJx3gyoXD4wB3W?= =?utf-8?q?gmvt5iV7wZyNVbX0BefJdqhQ3MXmffZCk29tGXgp6UH/nXzFQq0g63ApZY1jUtUF1?= =?utf-8?q?WDLT1FtyPmL77JpPFvxBttVhP5FlJ6j4cCFW4THZT4BXmZQKFthGnr9VAo6oqJz/4?= =?utf-8?q?t5ThmmTowMLR3Kn6RrSmYinirO5C+iOH7Vlm5uQsopHW9rceFLl+wyTH0DgtzHkzr?= =?utf-8?q?+YB+kaeCVE6KtHYJeO/+LC0Iq9VpxRw/Et/opi5VTLGirfVfS0yMYEG/AMNR6dlP8?= =?utf-8?q?/3TEeQGCq1nV9rGrqFhqZaW+NrmmustHRCfwxRt3zS4hx0XuIkuszzDIwnStN/Li2?= =?utf-8?q?CzMkgBqlCA/i2GgODPKAuqIyOopy2RJ34bWpjOyYidnLiV7513whvuW7aVKYafpIA?= =?utf-8?q?kPpd0YP/pZp7rzKBkpVMrPnCQ3Yq6CTzq9jUJyzXd3ttZd631oz4epQtAIugIs5yl?= =?utf-8?q?TeZ0IB1TYMxKZVfGnAJU7tAsfykMDZvFNLT1GkWXqxb0QslSC+bfcHscuNTBlSdOw?= =?utf-8?q?iHbdlyW3vsAsgmqOD+bsKy4weWtHp75K1JxuP7P6gHvsS5anfAwW8i4OuYKJeE0dZ?= =?utf-8?q?v84d7764MX3b0FHyubQxp2HdjFkpm2pPGUw47CXMZOxJUEYVvooSfH/aI0hGGnEDQ?= =?utf-8?q?nukHYPzX8jpP5G34EVqMvOmig6XTo+zqub+q7uC2de4dRxj+Sh0ZaWAS68gTEl04t?= =?utf-8?q?m5k+xBV4U/5UCf5tlW4hDO0cKte1GV381qVV8XXFiOF9P57fD2SR6JTcUJ7jgBrtt?= =?utf-8?q?/Kup5+eQgmRXMGX0yp14avHgrmzPM2eAi+5JSrbz+0Gipr52sa+jQcmFxe/HAY+Cg?= =?utf-8?q?HsrJyMLtUMinaORF0k/mo63ZWHewOsjNqgX+qF1hGwNjX4pptgnsayfU/9elsrkca?= =?utf-8?q?Od3HeaUCJeJf7fm8jquteprtWCHAN7s9CPH8FHR2E7jdg8A6m+RKokvIf3QbzYTA4?= =?utf-8?q?7zpE/VYQLjor5wi+UzO0NxlF4gggmPxs8C4qZS30gvboCXjI1FZx+HEfmf06tVzAz?= =?utf-8?q?5/sP4niP6190adLUpRL5yZNCIrhPM1VJNFjW6a3zFiMBiYgmMduE5KOWXhQziMVAl?= =?utf-8?q?AxfuD6m+NHkSXHkKF8ogwuSli6muzzZ5/yE/TwfHcJKvPMtBmm83bLC/rnFqrH03o?= =?utf-8?q?WY00WoWmQkLN+C8ATp5hqkZf+RlokZQoEcflzg+QS6GFBUjw0+Zs22BqWpZj0nLK0?= =?utf-8?q?RnzMD3HPmMA/525iuZ4Yx5diYFG/uX0TEwMAqPir25GbOkOX6bRr/pAu1vU/+vcrR?= =?utf-8?q?evB+nRqhPTvW?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4914b60d-ed6c-4986-6aa2-08db8d8cf296 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:01:11.0231 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: L8W9Fuy5OwlDay7ItYgUAji0p6yDBKDOyxZqjfHRQKteBd+ViBW/U3UNp5TQUo5Batj4aRu+GAF1+FK5NzG9Ag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB5463 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/dw_mmc-hi3798cv200.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/dw_mmc-hi3798cv200.c b/drivers/mmc/host/dw_mmc-hi3798cv200.c index 6f22fe054087..e9470c50a348 100644 --- a/drivers/mmc/host/dw_mmc-hi3798cv200.c +++ b/drivers/mmc/host/dw_mmc-hi3798cv200.c @@ -171,7 +171,7 @@ static int dw_mci_hi3798cv200_probe(struct platform_device *pdev) return dw_mci_pltfm_register(pdev, &hi3798cv200_data); } -static int dw_mci_hi3798cv200_remove(struct platform_device *pdev) +static void dw_mci_hi3798cv200_remove(struct platform_device *pdev) { struct dw_mci *host = platform_get_drvdata(pdev); struct hi3798cv200_priv *priv = host->priv; @@ -180,8 +180,6 @@ static int dw_mci_hi3798cv200_remove(struct platform_device *pdev) clk_disable_unprepare(priv->sample_clk); dw_mci_pltfm_remove(pdev); - - return 0; } static const struct of_device_id dw_mci_hi3798cv200_match[] = { @@ -192,7 +190,7 @@ static const struct of_device_id dw_mci_hi3798cv200_match[] = { MODULE_DEVICE_TABLE(of, dw_mci_hi3798cv200_match); static struct platform_driver dw_mci_hi3798cv200_driver = { .probe = dw_mci_hi3798cv200_probe, - .remove = dw_mci_hi3798cv200_remove, + .remove_new = dw_mci_hi3798cv200_remove, .driver = { .name = "dwmmc_hi3798cv200", .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Wed Jul 26 03:59:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706846 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CE22C001DE for ; Wed, 26 Jul 2023 04:01:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231295AbjGZEBc (ORCPT ); Wed, 26 Jul 2023 00:01:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229608AbjGZEBT (ORCPT ); Wed, 26 Jul 2023 00:01:19 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2131.outbound.protection.outlook.com [40.107.215.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC4741BF2; Tue, 25 Jul 2023 21:01:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mlPRj5kaBhVAXZhijrNOl9+WR1LUNPc9HMdyap3C/Tc5PMw8/or4o5RxVy/JhYIc3ysrsBbiRmxF+NWcpnDTgpBfpL9BeI/CUIEjlQkaJsp5wFyxzS7nzfZJhQwLJipjWALTFINLfJdCLIYdqv/lCnLFAC5YFmBYGhHR/uYG4cH13KWeh1RzkeWDLnkcCIvMqWiibt3i8Al5McXnO6US4lp0WopABh/LYMNV/ZTpSY+KqmmzUYpEBZ9URi6XhSC9dHCdaXWCz+hnWe5qeIV5CZHGECVObX2kFZq4Y+mScTvJhGmqBCHU0pfgj5nFlEFrjGgcia7UG6O1PhPime7gBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=df1DKbWeg+xqkSYPtOjL8RorXDmDCAUtgwB9kJK//H0=; b=dOlRFHjbXSfRtfMrPLL0EZkmj+D6/Hse8xEMCAz7SuoRdlgc+Gs81FbF3wD9h48xdUW/spT0n3BBazSz+BoBAgpEUSuTGV04ZOi4BhC8tUYsPUjnWTHytLHhwvb+pona5BQ8JpwjP1GLUfkOLHqw8/HUUqk71BL9X+ecEya2t3wg/3VlP9LAbd1H6bhPVuyIPWk+HnXnPbtDnX930jGi1qGHJgCrVFo4sABeqrXXpfjGUnYruAplWohRzr8fwtVf/8RucElyQLz4wT5r1kgMEo6qu+N5mgIYHsbaflt9/G6QnUqb/geY+HLg8Iovpy8CI03yyhibTpN3OAok4sAT6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=df1DKbWeg+xqkSYPtOjL8RorXDmDCAUtgwB9kJK//H0=; b=PupFyPMKH+vsGTMU9kT2SpTvFBGVzJ5XELDhpU1FsiLRKV7gOa1B30wGGBXhJgg31aUxzMM+7SgSMZjz25gdTE59VjVygobpiw4b0MUCO9VvUshmo8dy8RAFwwJAyFvq4F8dYxFuU8UCH54pBmwdap9xa5dW2eMECu2h2zc8lvzXPtHeBPQlLZ/mo6ZwPKG71ITfCtv2hoazEJ9p1Wtprya0kIkR663oCbKAe12Hn84CqBsnSaqJKLbcj8XXEQShS7MHOve5EyiN0B7Lk8bQbc89ug3ViC02S6+VcRNfsP4xfvNMuOKrgLQiG5d1FXfMaLb22Hq7trJ28vk7O7CuGg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB5463.apcprd06.prod.outlook.com (2603:1096:820:c3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.25; Wed, 26 Jul 2023 04:01:13 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:01:13 +0000 From: Yangtao Li To: Adrian Hunter , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 09/61] mmc: sdhci-pic32: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 11:59:49 +0800 Message-Id: <20230726040041.26267-9-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB5463:EE_ X-MS-Office365-Filtering-Correlation-Id: e2090779-55c8-4c6d-c23a-08db8d8cf3e1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 94mWmF6BEXjC32Y+jBnbE770+FWGLS8/nU2LYaGfjJugNIbtufydom0L7mDAQGo/DsSjI768LXYlUyLwJBiFWZxDGVm1n7bDurJ0CF6wGJzZQdrt6r4mIsUKAiOUpQM1gXLcWOEohlFeOKw95P1HNNgxg0EOZEa447DnlxgyL4/dalnqOc3v2P08j7Y49dWnqnJOi12+ckfHrWy2aq4N6qZbw2foxaJjuLBjaP60/Llbn+WORQH3dVpIzCiGNb0CkTGfZSoloMkITuYlRguXXJJ6sh0icjXHtWo5QaUo+Rury2B5bIXtyb4Va2BhFxmtsUYRVW3rgs5oCFtVqLJx8ndpO0OFCqgaUmuON4Qq2PQrHdSSr3Hmn0f7A+3wyUg/VDWW+QIR2ULct19SDoKV+jy7/n+sLQc8E80X5A4WJV5ESWm/M2Klcjs5zFz7BzCqRJ+BjPnHl5HDFndHG0Sn0zC8N2Y4pAR4890RNNIlbiYMp2Cl8nR8fnmNC4+YQWg17C9Q0jENSxGVr37nmXIYWM+pdELq+eDjfTWtr7bTclmuZ8pnU3f50oYvr3PAn5GNTP8mkkIcb7VhOz481feHEQHzTsIykFb7NoZzJgo4f3JnuPGckfZfyuuwEoHv1YdB X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(110136005)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(6666004)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(6506007)(26005)(1076003)(86362001)(2906002)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?IlNstXskqZ6m9GVdp0gJYkYmU0ck?= =?utf-8?q?2x/BFZx1TLiTwlUmRmc2zKxvweEIMmDnkBQv9DqXWqqrkwiPT7MUj7WNB7MQeOq8i?= =?utf-8?q?NWgFyI35QUIcIJS4LwTs/p2/uZ9GilONhw4+OiGxTDsbenTbJvu8V08nPKVwVv7T+?= =?utf-8?q?+pUael8bMhJh1EbHOFi398p/Tu5/0ZxOtBdsYJF0Y81nPBM9aCGmPDHtLg2yJE4jQ?= =?utf-8?q?PM9OAj701oX+cjGQOgnY7rSX4x8k9+NWJqDEBibeqZsNlf/9yJCo9eE83RDoI49FW?= =?utf-8?q?VBFEZV47J9Kuxdks+xXkAhnsD2qe2IkucoLujBvTq5dwqw2c4WwlYnjCLJxEEQNEU?= =?utf-8?q?/ZaaA3gLhcCtuMHjhhLw22EZzdESP9G3dKcCwbUazvBKcVygBiHt/tOPSsvHaYe1v?= =?utf-8?q?9n44g0BNvzLVmPUmhjl0hakgL5Guc9FFTOOMdoXYjInmlS9QC7o0XD6bpwqWJqBjj?= =?utf-8?q?HQ1qgB1tvsV+rJFu7IX7Cd4MuWicoSRQZOtS3FE75PYAMX2p6GqLothyX3HFAieMA?= =?utf-8?q?SNXwOgk67wtYLugLf2ebyfWT3KnKxOyrBIuCRnHkXISba+NaXfGBpFLIMsNybLYuc?= =?utf-8?q?5ihdg1qW9Wp9Ys3jnwhQuF6UXydagaWHq+kc9AObw+OpENoJM2XWok3mbHpWFjr4J?= =?utf-8?q?3E/xPV6IhQ5kLySHvxBUcZlrWWFU/7osBfFEEVoPQvqjNdi/LJcawX5BAlM+m0L/C?= =?utf-8?q?H+TjrFwvSYLIqjvwSnZzT1dddTWQelCvID6BxjyoFNP57hurBP7Mf0GbmF/g30I3B?= =?utf-8?q?hY5o+AGSWYT4DGvcdK9guv8d+hks468d20i577JOoCoGf4ulRRix5fZZtbYTdZufP?= =?utf-8?q?IQdSGNNF+KZvB8YUiFBYRKPnKpyKkgb9VirZhEkcLzCWerWwcHbgVj363imtClclN?= =?utf-8?q?pCE7848Z/ES9yaNXv8xcm2hdzuCcygy8MGiX+GAzhDaysKRReggBvuLw+ALBlJFso?= =?utf-8?q?C75MzD4golsjhXi4BgbhVhkYWb4ziG80BvcoASZACLHRjhflwT6xvSCuFdpCkyYnt?= =?utf-8?q?eP0Kyf5uQzth7kNPhJMgWZ00X0R0IReojJNQFc3OSUlJU4b3j9hgyklCKkK3nxedK?= =?utf-8?q?4qBhsmeC9XP7GGxWPFS4zuXJfaP0uekK9BtUsoi+AHIIa86bddZp1/TgBBMPKqWcQ?= =?utf-8?q?KwYkfoZpIfxwT04OAufmf77ql5hiz7pRilZwC5sU8S0DsZBsyrMJGNBxOGD3o9A1Z?= =?utf-8?q?v5kXFx3DGrkXMRoPXHYLYBzLJUwmY9lpi+LSha6eeRJbIHZ93SqiYQuKOY1OMJAN2?= =?utf-8?q?su7qDg1nh1xoHxgujzoaOF/o/udSS+uUgIL0FklqAxHoyTdnRJm+hKsg5V5BpxLZ/?= =?utf-8?q?coahsuO4B+UdTYVgVL1Jv0Xny8+oMiBXlzHz7dji5wO28byANTdynRYKIl5Z0v41c?= =?utf-8?q?38iWZVtNLcCxnWbMmL00PX2Bn4keRAWshTctZUrTVJ/+LGGSCcZBsgUX3Igk58mWU?= =?utf-8?q?z7deF+YWt9v4gepYpQO7LVs6SUwbzdtMSsXfb+fUX5+59PU7CWb2Oz/XywoQPRMfT?= =?utf-8?q?QnQ+7snIIuRz?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2090779-55c8-4c6d-c23a-08db8d8cf3e1 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:01:13.0956 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XadAvm/ctYxHikaGSEO4I0VX2B5oy5TqIL2G3A6/LMNagKRRkZmwneFb/NgtEdhrGNJJaBP3bYQpSidvNjhqIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB5463 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/sdhci-pic32.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-pic32.c b/drivers/mmc/host/sdhci-pic32.c index 6696b6bdd88e..7a0351a9c74e 100644 --- a/drivers/mmc/host/sdhci-pic32.c +++ b/drivers/mmc/host/sdhci-pic32.c @@ -210,7 +210,7 @@ static int pic32_sdhci_probe(struct platform_device *pdev) return ret; } -static int pic32_sdhci_remove(struct platform_device *pdev) +static void pic32_sdhci_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct pic32_sdhci_priv *sdhci_pdata = sdhci_priv(host); @@ -221,8 +221,6 @@ static int pic32_sdhci_remove(struct platform_device *pdev) clk_disable_unprepare(sdhci_pdata->base_clk); clk_disable_unprepare(sdhci_pdata->sys_clk); sdhci_pltfm_free(pdev); - - return 0; } static const struct of_device_id pic32_sdhci_id_table[] = { @@ -238,7 +236,7 @@ static struct platform_driver pic32_sdhci_driver = { .of_match_table = of_match_ptr(pic32_sdhci_id_table), }, .probe = pic32_sdhci_probe, - .remove = pic32_sdhci_remove, + .remove_new = pic32_sdhci_remove, }; module_platform_driver(pic32_sdhci_driver); From patchwork Wed Jul 26 03:59:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706845 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED93CC001E0 for ; Wed, 26 Jul 2023 04:01:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231404AbjGZEBf (ORCPT ); Wed, 26 Jul 2023 00:01:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231201AbjGZEBY (ORCPT ); Wed, 26 Jul 2023 00:01:24 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2120.outbound.protection.outlook.com [40.107.117.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 909B91BF2; Tue, 25 Jul 2023 21:01:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=emaD7xU43pIwn2+JlF6P9d4QPBlkwx68rAJXSJVnrZzBaVjWo+XLr7UJe+7z6JzgS/v6xwuqrF94j70be5YR/eT/g5DW0BD4qUscbhwxKTPoAxNYxQ33ihG3HXOmXoEDlK92bFQsZY0yxLgucRPcFqoF/0EH253bygkiBJ2nSef3Vrb3y9J4CWWZhEGzuAbOHyQyZ+3oWnCId0p60V/N3oke96tzRFpihiM9m6ge+CjcCWr3//3/j8xdbmXM+Y4n9XLEZPKjln5DgMJh6PU0a/tLDeyTehiSd/zL0rqPt3VP1WNvS8CAVMT/x/K9WUyEtHALOAxaolfnDTy5q+knTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mjvydvAOnf9fdqZRVZUVRLRXIIaoxUyvKCR2No+4ygk=; b=Jmzzn4oAvglzBUVChj2gvNcdPRy1JmYiqzQUAVmi9PtJGCD1Lz3x7EAnLCZDRJ5gLNk1UR0dc1t6NcfX3dPsCdOcWHcU6yczbNNAeSohdLGwQGPNB+s+lxFsiKxBJRNmkPxHGZR5qgtG8dImhKhfLl6xNbk3d/m9q/qCxayJwnRmo7cWJLAxKl3jLq2h3c3rF0Tzl5ir4feoYuPrWknHyyrrdyRyqa/OsAFnk2Mt7n7e+dJnnbQ5YB6jttCzm8YmQv/nrE49X87RapS6TlYqK9ABmBFjvLX8jZod0DzXIwsDLW9CLqvkI1lt4SZGbdi+s4tfMTVxaVNdtXDPySleRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mjvydvAOnf9fdqZRVZUVRLRXIIaoxUyvKCR2No+4ygk=; b=Re1h/w6VxQcwZ5ZGuwNZWeiYxlX9BmOkWMgMyl2NPvPHMtEaYEg8KO+6TaGm1A8wSNhNwlSxwoKOCzDeOvMHKI7WZG/4EHVI/WHjk5fdtFI6Ih3uabio7qOVtCkQIXPX7LfXuTbtPmmBb9Smtklr59EzidtGFt3RxT5aEoyF8ptk0kEd9ekU26WolaUje7rwNfbwy2robYdmqlklAlmPd/I/mRP8I6bHaW/YSU4ewd5qKZepQi1jiyghutDayZixyVf/X9fIGTBMme4sx0fcXZUfFFZTdrKJywlbg9UgbWFAJl5Pm7qYuNqoYtIA7uEn3kzDU9OVQdierbEifwq8tQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYZPR06MB3934.apcprd06.prod.outlook.com (2603:1096:400:7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Wed, 26 Jul 2023 04:01:17 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:01:16 +0000 From: Yangtao Li To: Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 11/61] mmc: omap_hsmmc: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 11:59:51 +0800 Message-Id: <20230726040041.26267-11-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYZPR06MB3934:EE_ X-MS-Office365-Filtering-Correlation-Id: d90d4c21-c888-4d6b-0b94-08db8d8cf5c8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4OPzs28baHS6UGL5nLs0YguIXlTvr8xjlW0RwvZn3I3WFvOw7Qyn5JuTXrYgnAelA4ayzm001/PwbAEZqhy433Y2yDOt7RQKFpnTiCKmNkfGWpGbPIhY7n3YeolT2TnCcK+ARSZXXNhHPTisElxE2q78PVmaN1p1Z/HWZueb5v0ZhXHgUUM7sbWWeEBjNx8Xn3cHHn7EzhRE1awUMkjxAjkl1ynij0bWqzJZB6YpmhQ1qvYdyRIa/Ua2zyF1OOKPeH2UChb/Mv/GmvOY/qkJYXxKnK96qvybo04/do8rA3xpFh8F4zW5St5Dk+Yrrfwo7GbDeLe3fjdtBOZ/JdQ3hVSqoCZT+rRBk9+GDLaVXpvuvANWsrwiqQO2LtotcaLdLQRL79caYWzx/RTVP/pXdr5a7C1AYKzxtlaqopj+lSx3aUmnTkjgCEZo46REg4XoATXGtuCEL3zp0hY/Y4IRQIaLwdSqwhFUCjlaLk4KM0JHABXl+UVL+3I2jvD0nynRFoEEi/+W1zTINx54w1zvq7imXfMFl1B1riD8cpbpzAmMEiJvO4eujHNjmezKcipkUpaplvwV7C+JXKccs0TWcONesHHnga7Q8HOMTMnuEjOMbccDNhZr/9LF3XplIct5 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(396003)(346002)(39860400002)(366004)(136003)(451199021)(66946007)(66556008)(83380400001)(2616005)(41300700001)(38100700002)(38350700002)(86362001)(36756003)(8936002)(8676002)(5660300002)(478600001)(6486002)(52116002)(54906003)(66476007)(316002)(6916009)(4326008)(6666004)(2906002)(6512007)(1076003)(186003)(26005)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?ChxdbENK+5FBbwRaus+OhvQ3cYGz?= =?utf-8?q?CYPrYI9xSL01wTNaN8h7UwAyCYWi/qNYEFXQ6WEI2YboraKOmTNIxj5VBQrAc97O8?= =?utf-8?q?bqqVnCYxaL3z9mZCohkRb7+iUjIgRP/ZYhIwg2xkuTfkxEcXxQBD6eqyxV9gwNX76?= =?utf-8?q?lvJ8NGyFyOMKl0iwbiOwSknLDR12rZq1DHTzTHbuXonwEH5Oe0mm0/HFxHiratNyh?= =?utf-8?q?hiQ/S+KaYDLLnYy0o7rqQPr0pZgk2qcTMeUgDPAnpN9w21Wigs1WVA4CVjg1hFf9w?= =?utf-8?q?BsxcCe+cgWYHz53Mu0T7ZHnQ1tPaM7SgHPtT/2gDmtpEinWDcVONq5J5Hvtri1OSb?= =?utf-8?q?QUbxjGUpaT+aMQXyLba/kx+IJ08Oybk2/aEjMyZ8WPYP5o2SokyfBivp+IYx1Mc6F?= =?utf-8?q?vKD54XJs8dOpqzXCRYG3svko75Ae+/O5kDmwCVwegThRNKp0VvIBpPhs8PDNXvNVB?= =?utf-8?q?NBIQuUJhLXBJ3EOW8/fxpln2QO7t2Zlv2OWIPJC2HdP85GSW+hoUhDqE4QAJ2PBkk?= =?utf-8?q?xg5ZD0rppS2m1unhZbggUTjlp0G/MlDHO/0btvfiVgtwiRCfoBWQkFpyWxOB+i5/6?= =?utf-8?q?m1vfhHuMnVMaC431G221cBLgR0s84FgtE9gyHLRWoDGQ6qyE0w8EVN2kvxgOPPzV4?= =?utf-8?q?hD3V3ma9ijArW/8OA85Cv1zDkZ9r8wxaBYmDmNuX9q9K4krKUYZ3uPc2ffHgPu+Eb?= =?utf-8?q?7L2VAbgNJTu/6F9rLXfzHehBDgwLvxrQGzx7Gf3bq1louTMjd2fsQebkqbqgikPrQ?= =?utf-8?q?yrcsn7Jt5OluGBdMSObVDoMwMKu+jrxiQEMaTfpSZRc6jyvcY9+0Q8nSX5Vmeibin?= =?utf-8?q?ERC1syIb7Ko0RNvnSp1y0kDlQUgUKFTu5mE4gl7Vdomo1H+cDI1oV+kxeAVJGjMI1?= =?utf-8?q?W3vECssmk9xb9n9JWwlcZzxHYaXNZSmlLuAQFwKp/bAQmU8J4hW6lZcmdSHW/XPgC?= =?utf-8?q?UFkyvnomDo0aH19/5BSH2l9aLXK5C7+qW5DlFNPgWBWGmdpqd1UhOz3PEM1It04Oa?= =?utf-8?q?WtyQR/pETWs0J3o9rAci6xK4hCBOBQ2DjMVxts4MTtC3jq80KZljd4KT5p4KvUGCz?= =?utf-8?q?zYxgJjvoqd4VnXqkqyde6GkEcrt4Zh02zvtpfRh/oTPCaE45CGDU3dnvPCPmCZpnu?= =?utf-8?q?TVDGbZYinvFnjb79xLZpssjyrxVgwr/e7gjtILszbtIUB5IBAjmoeR8jvdVlxFzjY?= =?utf-8?q?WHPNUK3ZXzZeQs+S+nY/OdU6vm5Czh4lg5uXKn647h7YM0H0ZB/J0mce/lFDWsZ/m?= =?utf-8?q?zRrNnfUPVT5DwkOvSem1QZWHKaQwfpPZIVmuAq/g0mQXx5WKXk2yo1RsXudjpL/hV?= =?utf-8?q?0SByoSK00Os9J5pc2RqHzmCAUUfKFwJO/tGIncQ0XmF5uj9jUzIcW9Dox+6mpAfcz?= =?utf-8?q?4OJkbbJF8lmssNYkIBnvUc0z2eIUej07Ic69T5V+O7wy6nQDfmXqsaLVpHEmuV9hJ?= =?utf-8?q?Pic62IhJnw1JkXR++MV9I4ikNsq2FudYBaeXnNTjNbFRptQ6FYahDbFNcCO1psVNJ?= =?utf-8?q?5o2l83dMI2Fr?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: d90d4c21-c888-4d6b-0b94-08db8d8cf5c8 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:01:16.3255 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jLXouBuCBTwR4mZrrJ5Of5m2rO2mU8Lmkwx5XB62PkQ201pEjqoVQU4sD+fdxbD6Pfkbe2/xme5tWIUUW7tMPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB3934 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/omap_hsmmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 93de00a06aba..e120aeb869b8 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -1979,7 +1979,7 @@ static int omap_hsmmc_probe(struct platform_device *pdev) return ret; } -static int omap_hsmmc_remove(struct platform_device *pdev) +static void omap_hsmmc_remove(struct platform_device *pdev) { struct omap_hsmmc_host *host = platform_get_drvdata(pdev); @@ -1997,8 +1997,6 @@ static int omap_hsmmc_remove(struct platform_device *pdev) clk_disable_unprepare(host->dbclk); mmc_free_host(host->mmc); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -2123,7 +2121,7 @@ static const struct dev_pm_ops omap_hsmmc_dev_pm_ops = { static struct platform_driver omap_hsmmc_driver = { .probe = omap_hsmmc_probe, - .remove = omap_hsmmc_remove, + .remove_new = omap_hsmmc_remove, .driver = { .name = DRIVER_NAME, .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Wed Jul 26 03:59:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706844 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4924DC41513 for ; Wed, 26 Jul 2023 04:02:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231550AbjGZECp (ORCPT ); Wed, 26 Jul 2023 00:02:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231300AbjGZEBq (ORCPT ); Wed, 26 Jul 2023 00:01:46 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2120.outbound.protection.outlook.com [40.107.117.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AD3826BE; Tue, 25 Jul 2023 21:01:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DY057Tfhwgdy0BUfSC9gZwNAeHnb/t9YvFPpdjREDiaHiHeq1oE/F+0SRE/TJHUet9wcTRuEQPa+7I7Hk6W2p4TO25r7hM96jGigf6h9pJ72gOtIq2vm/CCh+1ikxn6ksjC02XewxonJKsGLMXkJCutHmEmHh9TW0joakaJOgdCq2EqJ0S0Fsulm+Z7/2MvebzCX+gQGNpuRMyRApFtKbkVKusA1gDmb+q33JC20IeRJXHrR/0BKavztccsOC1pjWcj6iMgm6p9aVZSLJRsnUezmUNTRqLwQJqwV0Tdr4nI+0lHNfNfEQxwx/hN3sK0ZHApcR98+HSbaumv7tuh+4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gkUpr7l0pDttVGz3kqCsUAr3ho/CgWL/40WVT1faxUc=; b=OqqFZ1+en6kCqadR+K9gqTU4KMnMEr0UhAUnsl/xopgKNKnonUqpAaWN0gFGy0SF8jRw0fDMaIY/O89DzfKmL90iomU4H640RWsrTF2yLUrBOL1DEj+dnX0yqapKa/0BOX+I5WnUrFBnH18N7asH+faKZZNk5Nd2byXnmM8XrgrKtMPd+thTvl1SssdpMO5/cuVLxkrBho4YH1A1aRg8M96upNLmBZWeokKW2YGxpkNB93Dc9H8ICP5KarGw796yahRSAm5hw9edpyEpr/Soj8GXJvWifGMmtdrOQ9zF2C8C76n0oLeMp82TGmpBTemYdLBD+LV1MVq2mvUTGLD33w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gkUpr7l0pDttVGz3kqCsUAr3ho/CgWL/40WVT1faxUc=; b=SRBEHQlamksChbKgSfHcY1AqxC/Ij6/BdidGTaxV+EQleUR8zhqQnd4dt0C6A4g6s+w5Gv7br71NSF3GVNu8v4zeqYLA5MQCJInlEsb+jVBOfWHcv73XYqXjmglbSDwwdOcNvxCUbMOY+yQq6BcNiikWCeIIoQSBEeQzGAw9Oq8h8WJ638NpBmNdzx0/yjkcCK2/ySsV7DXXsRz/9qxTi1mSHjH01YxR+DagpUskJv8eGA3Bt04cJfQpvxQw/gOhJtHEcp4jvcKnXijWC7G9/X5zhO8yXwKQb3SpO2SRPVC726ZT+Y0X2yzMIt6FfKfa7rtksCkOFQ7N/IA60IYGDA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYZPR06MB3934.apcprd06.prod.outlook.com (2603:1096:400:7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Wed, 26 Jul 2023 04:01:22 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:01:22 +0000 From: Yangtao Li To: Jaehoon Chung , Ulf Hansson , Krzysztof Kozlowski , Alim Akhtar Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 14/61] mmc: dw_mmc: exynos: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 11:59:54 +0800 Message-Id: <20230726040041.26267-14-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYZPR06MB3934:EE_ X-MS-Office365-Filtering-Correlation-Id: 90722416-c551-493f-8c1b-08db8d8cf981 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wX6EFvNIuIQd/649CJtu3yTHPnck52lzHQmccPYxKC14qYXI8SlBovs6aFAV/JT29q3doV5BnGud2fo9fgRze8yzbpeWydJXFHcoFby3sKppeQ1ckK/9J9oSmaDfqTQEO1ZhBOIXKP3ilHNqXfHdoEZpY+KZu6yWx32c3TtM9cCYvevGCGT+uloXnZeeVKnDC0zzOPghu3Zdm0yhK8Vhp08Bbo+9YWUoXADn4IX7BvUnquDKl61faitCFyIRvSOEyyS9DpM6bgB/PlmTXyI5z1u+5KAv0eO88rvTdtIq+ciKi1h0CJ6tLfWfWyjxB6zLyWW+vV4tPbD89oMae/fYR4okM3KbuBVdLMvKufQQyoFGzv6MncS8080PMF0r8KkQuaNMERQh6b7WDae85vVk7VZte/8wcYnv3EO1L6fWAnJEIwn/llPehqLrw7MDEQv9iKkl6NYDGRO7UA+VpqaDtpzgYQXu5yPKQI9s1RWTcrYSDzJnPHZTMhjch73DH7qamgu7MFk85SwvX30Sk8uDNBVHqGu63AwVXhQ4W9mzNRY0ctm/RqsqIIMORtADzdR/o1OFqQ56pwMAo/TUxvlwUhkIame3DDtc1gBH3mchbe6Phy+bvrrrdNClWfpBQrsf X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(396003)(346002)(39860400002)(366004)(136003)(451199021)(66574015)(66946007)(66556008)(83380400001)(2616005)(41300700001)(38100700002)(38350700002)(86362001)(36756003)(8936002)(8676002)(5660300002)(478600001)(110136005)(6486002)(52116002)(54906003)(66476007)(316002)(4326008)(6666004)(2906002)(6512007)(1076003)(186003)(26005)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?PcDvSZW1fuIx3dK0Xz+HZOLQaxMQ?= =?utf-8?q?GmqRnCV3P3VSAGuax4BqHWY1TrSrIUFD9Pv1HqtMHhcrSZ8Wh681TmVGTEs+zndz5?= =?utf-8?q?CYs0NRP9v2s0J/Wcty2wnOdo6M2gtprYDhRk2PRR4slP5hDR6CG2w3qu28iPIXfRg?= =?utf-8?q?woMiPHxpYnNC0MOW16K7E6buwlPPgpXK/3i9B0siZ4xJ9x7kGFdtN0u4iJEdm5xr3?= =?utf-8?q?JGzayuxg2kLxVqbyxtXuIDZJvLmQ3Le1jNXtKhTALRUE4cbbWvMIWGMyO6GhShx2Y?= =?utf-8?q?SOjFA/d1GzVkBkOfbgG1a4/PQVxXZgQnPV1YeXRmGvvHxTYckm3kb5QInvcil+9eC?= =?utf-8?q?rxqT5eEyNqbjUhCj3NTk+HtBXZ56YchKKkAEn8jZ+Pv0CUTA7gE2husBAAWYQPmYk?= =?utf-8?q?fqjhhpyMf8DSVI34hwVanbZuxnXhIhcQTFj5apyg6DTsyBjtKtHeVY9MJyPVM0Prh?= =?utf-8?q?HLAD9j4yPx1s7HEMXDdlyStpWcbv2xXRScznyxVP/uGnctLrgt5WNUtXYtJ6aAYJ4?= =?utf-8?q?HawK1Jkp/Gljev1+M8fIwrlwzihgwMsfkQ6D+y5tRbjimR0NTd6Nhq4ch+Yvnkk/E?= =?utf-8?q?e1YpC68LVC2kFlET6h/k4WwnFkfhK4JRGHfK+druMAubvMI62WDPpUiScYXDdz76N?= =?utf-8?q?8VkDIlT1GrOubu0ZFkeeVuo4IioUnV/RXb/UAIGggzn8/oB3FpAc3oVacROSAo9kR?= =?utf-8?q?Lm9HYJPb5OdHT2BH7Cr/SttRuvWGXeXvQNpCQ2Kc3tRgg9Iv8n6KKjZSnFIAuiiAr?= =?utf-8?q?CzYDga93LoYKb9V8cdF0PIq4t/6dD9K1osVFk8i/hbrz10/fDQ/Q0x8qkrFYnBZQg?= =?utf-8?q?a4px85++mGu22A8ngo3Qm+mQZlJArUuckoaOO0q6V3pZqxQmnFvnhUPdds028INv0?= =?utf-8?q?iJBJ2Zkcz8RjZBCPqGO2PbwlqidcRDKvGzd59yXGblg70WtBB3Fwhp37EGBSXYPbp?= =?utf-8?q?XFrufyKCqB/3M61RAoiwx48DPBfpSTX9CznSz8QmEVYiXc+CSskahkxlYbq5DwBz5?= =?utf-8?q?UKpMwL9i85xFTGaSabeOcZyEtr4/32xCMIQWXFe/8Ad+LZCMq9NWeHdqJhM2IR2li?= =?utf-8?q?wzGTJ1YItGnU+CrhKT3S6tZlsQFdUzkDf9h2V5Da6GEGimloW+YGaXxeKRJ4jk2Nn?= =?utf-8?q?MBuA6+5vlH2GYnhoqrp7UZmGavZy+tPzJY7HlwgIHB7Sw88tFR05B5oRfeOAuKGk7?= =?utf-8?q?o1qI5iwdx3qAB3TfXBb0+hW5nxLp8jfR5wfr8Gzxjl/UcXBgWO5uCJpRtHJiJTLDq?= =?utf-8?q?wVJOdndb1llm2337BPCgNupKkayD5Bymd5eXB+/Ig08d99JIYPcY+CCylASN4OvdW?= =?utf-8?q?lYVAIE2VJNVcEyMDB2+JEew+KLJ07dMCnllNFDy63MfOGSWw7b4x9OHHxE4tgNKWi?= =?utf-8?q?qmeBXhKUBh5NTScOJ6BiaRz8Yc1lBTue2D13vXotedXSGyaU2zX2724HAQhw/P5sI?= =?utf-8?q?6wtVJ9Q9T+OV1PYgXE3LZNCyoaCbOczSSpVzY7S9b2taxgkqrPYwVatfueOpUGEEz?= =?utf-8?q?SNyr91UGCdRY?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90722416-c551-493f-8c1b-08db8d8cf981 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:01:22.5419 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: un1xXXYFNLo+qJhvyWWu9J/Vqx+QAWFJCNkKIO2pQRRnSdYZWCw1tJEMlY7TGD37GfxXfldPngq2OBpc3Ocnqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB3934 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/dw_mmc-exynos.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c index 9f20ac524c8b..698408e8bad0 100644 --- a/drivers/mmc/host/dw_mmc-exynos.c +++ b/drivers/mmc/host/dw_mmc-exynos.c @@ -664,15 +664,13 @@ static int dw_mci_exynos_probe(struct platform_device *pdev) return 0; } -static int dw_mci_exynos_remove(struct platform_device *pdev) +static void dw_mci_exynos_remove(struct platform_device *pdev) { pm_runtime_disable(&pdev->dev); pm_runtime_set_suspended(&pdev->dev); pm_runtime_put_noidle(&pdev->dev); dw_mci_pltfm_remove(pdev); - - return 0; } static const struct dev_pm_ops dw_mci_exynos_pmops = { @@ -685,7 +683,7 @@ static const struct dev_pm_ops dw_mci_exynos_pmops = { static struct platform_driver dw_mci_exynos_pltfm_driver = { .probe = dw_mci_exynos_probe, - .remove = dw_mci_exynos_remove, + .remove_new = dw_mci_exynos_remove, .driver = { .name = "dwmmc_exynos", .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Wed Jul 26 03:59:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706843 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01C9BC001DC for ; Wed, 26 Jul 2023 04:03:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231516AbjGZEDU (ORCPT ); Wed, 26 Jul 2023 00:03:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231666AbjGZECy (ORCPT ); Wed, 26 Jul 2023 00:02:54 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2110.outbound.protection.outlook.com [40.107.117.110]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB96230F0; Tue, 25 Jul 2023 21:01:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CY5dvD8eVSKw7kSxj+2HqZ5jDL3Xk7YNZWQOSN2Dr+9comgsFcPJKn5kRp4LaMgjk0kz6zF10qpmlmL0u/3Lutd1JvZq1+/hHKD6ht4pzNB4Y+25MoQRFvm5l6OfVT3Ipt2H+/XswCg1w3sRxXcFQVQ3u/aWiOzbeFDZU1q68rLgDN2BOvAt9ahy9bs0zn4qp4ZKwgJehvEfJjw1I4iJUMk9YkQFUAodBUIaVf0JhD1wDupBlbNOpVu7UVMVf0s8WOWecTXy3aVcZLPLivLXVD79AMWBo7bx6DjAHHG1GrlCJZ4DDGqJjHCgoxw2oxulejZv0qIQklRX/hGrZ/nPHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kf/c3z4jK3Dfm6LT+fxuyv4IoKncH6+TN8IV41mX6co=; b=X1nXqh3lCJsTxOZPJ2F+UhZGmHqZNL3MyH9n1aBv5/o41rCdKhFR6WFVoCqui3ixIS9l1itrHTYqN5ldtljo3sfHhcjafwo9g+USllbJijUfW7cnn1kY4swiJT9GmbTnhEVAsH6sqVW92GX0vHC1V9F/GCAevGNaoXG5Q3dIuEPDfqkj9X3AtSkkS8S4n/nVBMe5A6EKMG84wjaTpM9xKLFDfZ1P4xioer13f/Mj2sTsPejUN98sBRO8eyQH6Ab9/sRgCHaaNP8zJtFBP4Ekw3j+sk1e5BUovo0FCxsoYKCxWqkum372hquUhopRHlQjM3OQErtOCOaN4ktx9ZdWJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kf/c3z4jK3Dfm6LT+fxuyv4IoKncH6+TN8IV41mX6co=; b=KIO620I07EL6bFgsh8kkO95r5crbvKCyu5PaCh8p2IzOddxSYxhuGYpFWxil0aaiaDaA5cZUDQWKAQlxbqjpFfEspePqwCRrnyIzZ5lVtK6SmfBFiRrpw34cwU0onfeoMzcB0l/XRLoIjbBJpvTMre+U7B/b7Vgz/1NSke2P0BdihHNMLHRclmsAX/xQh+XvZZ/1c9Orz8ueweKbp6N7EmwaxAq4mU1d5GPQvS9E3QJxfdhARl8Gh4X8Z1xSF4noMibRegxSHN5PZL8nu5g3kZSTbMejA6c/WsBwSX/9tG6x66QF1wnVRj6pmrpOTD+tgaZlVFlooRnyVtHs2L1yrw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYZPR06MB3934.apcprd06.prod.outlook.com (2603:1096:400:7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Wed, 26 Jul 2023 04:01:26 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:01:26 +0000 From: Yangtao Li To: Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 16/61] mmc: rtsx_pci: Drop if block with always false condition Date: Wed, 26 Jul 2023 11:59:56 +0800 Message-Id: <20230726040041.26267-16-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYZPR06MB3934:EE_ X-MS-Office365-Filtering-Correlation-Id: 5202d598-0408-45b3-31d0-08db8d8cfba8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B819JqcATNe9qM9hYXgmqPD14CD7WPFd2PkoGBHfTIOLFCtTI+91dslpyna1fWYezQVloahUj1HgcWzCiVK4jGHVg6FkZW/0nFi9mnbAg6UexVnnz9pZIM6LJzb28PYe+BdM/A5sV5EB+coiDXXQk7uJ8SspO5NTidAqZ9i6UGiedYUwEsG2GaVS/nC+N0W4Or9qGnqPOasjbXk8TpJcPfegGCxEifMI7kZof+uraaM+5eRzgb2yubrjBhD7XZtyNBuJ8Z29zIpTMEMYs8Vjm1T66Bokuh6ehqkZYdJSCDk9lD+AzQAtvz7EG0sBhCqojtQZvft/UCQA18VdHBoOYjNHC3SXqiOkdJg2lId6u1uQPL/tQbp25r+rp+CqtMIwiFh9FIk4gba1NKzY8ud2SKN7jj/7atq5j/UYRNIjTf+aaEDRd1vAjmGM25mNSgdt3PLSzstC1L8tmMFk4mSnaDi8b6O/vXnRy9ccHyP78gVUzmvOjqLYVa1wnxp8kxTExgCgMfUrszsfwHnNdu+/0yzK3/2l3TiL55oBqKsJEnHez1hl+HgPYEdVLHq09mxFnq5xZXOx/9imYKQk893GFyqagWJgQOsNT9o1bhF59d6F3dIun5jPiMjMiLD9y5bO X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(396003)(346002)(39860400002)(366004)(136003)(451199021)(66946007)(66556008)(83380400001)(2616005)(41300700001)(38100700002)(38350700002)(86362001)(36756003)(8936002)(8676002)(5660300002)(478600001)(6486002)(52116002)(54906003)(66476007)(316002)(6916009)(4326008)(6666004)(2906002)(6512007)(1076003)(186003)(26005)(6506007)(4744005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?0Bnrjyvggw5lDFB8+h9QmDSvHPrt?= =?utf-8?q?S48JquE49MFgJtRhzv0FVkPkXMfELjZl0WQltb25jPvjjUkDPaN3zzDVYAj6jKL0C?= =?utf-8?q?5jzcxb4xj1POz7Cv78o6tUTtpysP5pLtm6UZVqXUsxgYuqyc6d4qye+Je5l00wXgX?= =?utf-8?q?tZfFXkAkQPWbQZAQoSOPT4vdXYxrKlNyP9zSYAon+TRTkd+m84WK0SYZWXkPZaSye?= =?utf-8?q?SEVlQbPjJr1DYHA05igIFOvc6QN9c4aTJYWBS88BenL4KIhketvwApQMoZAWho2au?= =?utf-8?q?IZkHxZASBxK6FvgHH8LkGBPrELUON53Z5WZTclzXjsHKkmLQ7ACDLOa4+OrAuovFQ?= =?utf-8?q?rB2UxF6TBcLJlm4E6aopqsRID55ClEsnZf3iWzmQ+PaKW9ZteZH8JmrlO/i6qm8SJ?= =?utf-8?q?LC4xLFOvV1bvGbYy+KvoAW0pqNcAjrrC+WtKplNO9s3EXm7kW6T+6BUsWANGRYpVC?= =?utf-8?q?pHvEUf3PLeW9u4tp4ZZ5cFlVgKnw0Bd5lr93x8/+bmaqiz2ETfgjb0ocj2HoagIA2?= =?utf-8?q?HYdClEGBzVWKc+t+TcmqPXSLD6yBPqS746JQ7Mv1GsOJDSKSGZR0EY4PhYu/Vkbqd?= =?utf-8?q?He7wZyU+lku+e7XN9jvAYasgfD7ztwcWlTgDyQa7WMdR9cg2m/X03pTwmi6m3f/c4?= =?utf-8?q?WsBIuJ7J8MvCfCeQFG2bEyBK99eSbQG5LP6INpT9YCRKqYkHHPDwKCB1at4vNqmRo?= =?utf-8?q?hVXzwhgi+/ERslVy7kBTxUBqv8oAqzbZznFYTfPbtxvxc+NITZSeCWr0XgqvftsKY?= =?utf-8?q?/9QDYiVjshIzhmXZlQB2r3SeDWkUFM3A6yvmgYMu0dMEO+dhFRBT0YBPlctekAcsV?= =?utf-8?q?R8mMiTdLXUX1t6wbgN5ehmbNnjDnRb6LCLWlHPb2Lx8OhhcA4pw8DrH9uSXYL0PZm?= =?utf-8?q?wWeK6iOo8c9qLj1r4a5eNUKqNMdmInW8txHiD2aifyTTkKoT2YUmf9eo89azvFNaB?= =?utf-8?q?kt06OINmNJM95BRU/AaL6U5u6RkrKNw/yUndZM45wya0gO8rYj8Gxd/IfTIR/5bqy?= =?utf-8?q?01u/yAe7rfs1LhH46LiWIPEKeD9Bpnjv1oJvX5mMN2swd8razXob6XKtELiezcjnS?= =?utf-8?q?3XjAmfppflwdyLkNG3Cbr5naw0J6CP/S+OXb/kBoNSdS+X0vRCEJ5ELYr8/q8/k8p?= =?utf-8?q?/k0qrxhwBzDcADg6dMFxRTW5vhU0e3rvaZvaIdkHeAmyW+8SOMLaYzDym7Rqiv2p6?= =?utf-8?q?+IRMBy9tMXHBFcZQEag7ZBAOhgYG3dVu3+lUk1/hIiY4nZsI6+3wUUGoo1JKUmRiS?= =?utf-8?q?6drVr5MYBBVV7InCEgBQYysvQbz6IraLzw9o3Gssia0rd1ivk8wRYh5tXQdg4itGF?= =?utf-8?q?KVFFfbk666juEPdnp7XyrsxExgZMaQa/uRJUrA17Bj1QLxkhmT9TZnOlW9YSb69Vc?= =?utf-8?q?M+n7mmv50DRnLnnsvabsOEKED8rYqipIukULRa1l7IMtdygewUzqhlinzPWzIaUmr?= =?utf-8?q?ki0MqemskHRe+dh4gWl51ZfXjr9zdGKD9oFYLlMFE0q2d0q/0Elkl7TagmVxs+jMX?= =?utf-8?q?tovZPTbG/O5q?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5202d598-0408-45b3-31d0-08db8d8cfba8 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:01:26.2065 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TKsUSwmPsYn3/wYiMVBsT1h9qk+Xa53U4r5rSrPgJfKH0PqUVCDmhqUebC7jTPa7aSB7uZZ11x7ntT6y4rJ3kg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB3934 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org rtsx_pci_sdmmc_drv_remove() is only called for a device after rtsx_pci_sdmmc_drv_probe() returned 0. In that case platform_set_drvdata() was called with a non-NULL value and so platform_get_drvdata() won't return NULL. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/rtsx_pci_sdmmc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c index 8098726dcc0b..062d07c2ae5e 100644 --- a/drivers/mmc/host/rtsx_pci_sdmmc.c +++ b/drivers/mmc/host/rtsx_pci_sdmmc.c @@ -1529,9 +1529,6 @@ static int rtsx_pci_sdmmc_drv_remove(struct platform_device *pdev) struct rtsx_pcr *pcr; struct mmc_host *mmc; - if (!host) - return 0; - pcr = host->pcr; pcr->slots[RTSX_SD_CARD].p_dev = NULL; pcr->slots[RTSX_SD_CARD].card_event = NULL; From patchwork Wed Jul 26 03:59:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706842 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8EB5C001DE for ; Wed, 26 Jul 2023 04:04:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231449AbjGZEEK (ORCPT ); Wed, 26 Jul 2023 00:04:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231443AbjGZEDU (ORCPT ); Wed, 26 Jul 2023 00:03:20 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2131.outbound.protection.outlook.com [40.107.117.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 908C23C34; Tue, 25 Jul 2023 21:01:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JOuGWEIf4z7ANQc6Ww1CBYhujHy6sB2JTOgV2MjXo7YEhN6EEFzw/o/bfxra6yv6bPVK8KpL00C91tVlg++tJ2Bh5BSfxUip+zHzihaJfif9oar+se3KdHoce/l6N4WMVWxCK3lYPmOpHDz+8KBNtuuHstlHV1XSFzalnr9562CMQ6Pbk21uv5HIIfp3QgPMRvANiiTIP++wbEcRJM4enSvcj5G9UI19BgqFBf/jOH6mRgVE2Z43dCD4c+NaWMMqHCXOTg85JgYMGkshVtGdRbvH/44SoEMPoVYgBVDXviHvSko3BUetXv+aYtRzsvIMCBXdJYgm6gpt3Srx33erJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w+CTem6dHExq17DY+SzLyRt98v7BugU2JDEv1g8WLeI=; b=J7vD7Vp4I8SdWjlY5+/f++Y3kXqtv8pRSHTy3B2GSqQ13jBDDvBb2vCg6a9MQf3069UXYR83iiICaKbIQUdC0RVaSJjDmDR/GxCeyyYiEAcVXxAp/hYZ/3TLXDdu2884cHaTLC/14D4l+6ah+QLbd8g6w1JjdT0byENme19O8xWqIzq3zde2JrktVDhhR7vpTv1TQyZhRzNXIuQ0Rbd/N6IOR7NqWIKxWhvpG7Dp3zACSl5jgtFda5LxVzk4FJFaSFFwZ0fCtqZoSuc7M3UZj0xFRgKCw2lZo9pQWDQKtd02GnslEo3/SCs7hWdTNXYhbnXDHDm4zgFiEnIIxoadzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w+CTem6dHExq17DY+SzLyRt98v7BugU2JDEv1g8WLeI=; b=HeVOa974vcZRLKI/Ih4j+/45gLspk7xMVl6nAEvmcKOQbe+VRYzU8pWKql/YBvlxi5VHL3HtMHRPBEkP4e3W0743/CWQkBB/TfxRSuKkMLzzJciTmdkuXuSmDi8UoCsnlKU/ZUCdvDC8NHuSlmVG6Tz5Dz9sJB5rLk/9gqez1wFxQO9tGOB63IbCg5ATVXt+pd54dFj2rkxRKmqXJ+5OR99qNZrFhab1NDeU6PF7bUyCjXlcAFfbFN1CaYUhtfEiY+k/3bV4GIpXVk5Ku0y+fsXxX1KAyVPNwi7V3+8l2u2MYC6OdOObhE9J9zzEm6xbaY2ZxtStK4t9MyVqlutGCQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYZPR06MB3934.apcprd06.prod.outlook.com (2603:1096:400:7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Wed, 26 Jul 2023 04:01:29 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:01:29 +0000 From: Yangtao Li To: Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 18/61] mmc: sh_mmcif: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 11:59:58 +0800 Message-Id: <20230726040041.26267-18-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYZPR06MB3934:EE_ X-MS-Office365-Filtering-Correlation-Id: 5866640d-67e3-438f-1b9f-08db8d8cfd6d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L/8K3AEWZVJUKb/Zz68mpWSQSMDGAlYgqjWFrcyXp8FLeAcXYyg3GxsXiAN/pfEay7EXEl9wqS/pN6w6mqmhnykprlGucXjjIChDZA7UDMEt3BgG51fm+1art3HzYYpJJazj5otejxYCsFCCgWZVwZkZRb8vhOLGT2exhTJ5wuhC3hDsMvOWOXLfp3/OYXlfLi0f2ZblbsujMRq8ulEfnoPEY51RyM0XpbmoslurBN8KUKnr8guRHmZ4U4exPScPYQnCA8rpaWBPGDfQ/BtsKSS4RCPf+eqGn2+PLDsNgyDoee4sbUCRLujtc+WJMnLp3Iae21LKGWZL3VuCRUhv9/cicZ5474ED0IM6mH+twEoWZZSm0zO+0KGMblYxWPZFPvC/hUSARJELr92ZdzcObmZa1usoVHf2zCjB1EN3iYci7m0fkw+obQrZ/DTDNUMDyN0Hf0LefB3nTFRjWORfUs1L6G4hB6tnqVPCi9osH9nbuVREgTe3NaeCQPsqsMuqxlxY73Sqww+Y8NWIGGSYGvNu6JaxsadqmcNMqvEHfJhjsZyMjnqayve6wdUzbr2B1KXGWo04XRA3ojEGpqXAZAK4ICKDUtgsFeUg8XEvQS0eQmdwOpVdOyPhApBdQsl+ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(396003)(346002)(39860400002)(366004)(136003)(451199021)(66946007)(66556008)(83380400001)(2616005)(41300700001)(38100700002)(38350700002)(86362001)(36756003)(8936002)(8676002)(5660300002)(478600001)(6486002)(52116002)(54906003)(66476007)(316002)(6916009)(4326008)(6666004)(2906002)(6512007)(1076003)(186003)(26005)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?oaCLQHzh4066rqd7j7F8QsPns4Cj?= =?utf-8?q?u1J3Coug4l8uUVKEyUAUHf0qLAsnUVP9rk1Z7fw7T0Bpj6b2xXfoOtdNg0PF9hI7s?= =?utf-8?q?pLAPxEu1g2ctR6Qf/aqOnAvugPwmLKOY6Aq9Ie5uaaeNuvQ3poVz3Rlma6Zt3SpA4?= =?utf-8?q?TG+6psFPfy50mom8924v+Obv2P5FI/jr6hkS+9RzSigE0qChFzEcE4Bm2TRitB4Vi?= =?utf-8?q?/GdDlnUxcAJIuYjwAcgkbwdBAnPaBxyPgtYDPvLnRBu1CZfknvJgPllUQOnqcbGtm?= =?utf-8?q?Wg/oVDi+qe3PHymaJf4X1ZBruRtjS4GtlbVviOKrl05IB27qtnVxB0IMA+yr79bI6?= =?utf-8?q?xa0w9rks8HaXEyX99jqUlWa31Ni6RUThfyMzoPDb9ooStbqqNKX/RvSRWitURDVt7?= =?utf-8?q?SYRIVaCJWz2Ec9Oob2msDol6+DnAQfd771m5f0Fkq+d63Mg65sScXzOVK7Wx7CvXJ?= =?utf-8?q?RmIDFMNAdKIkAsfYuJNFBHtOCDsnA1vqz2ckMZBjHij7oP5u2GlrPtGbydKeo+Csj?= =?utf-8?q?bEnIrGq1IAHZeCdCWXaLTzHeKZbbAhE5on9QG8VQP69viGbXFO6P9AuDpEWVnNK2F?= =?utf-8?q?etyLYhZqYP7itVi3yRdvQKLQIMPaGiuUTc16WyEqzeGZ28TDX49cpkyR7i/hZS4Co?= =?utf-8?q?UbXSXYJDZQXPdPEBgcTY5zoQpz/HDhSTJ/hdV8hd1zWNLE4kzO+vWga+uzW1uT2tG?= =?utf-8?q?/tX2zE29JywlulUIXDqJSwV3aWB8UuKLPCoOgvS/rPozBpjOyN5rba/yENn3ILdID?= =?utf-8?q?/ehdOQFJnnnrLB6Wqfih92LOXqeMhihVAhsWkAgJ5bkResIiSEFCgRWiir2Q4S84g?= =?utf-8?q?lgxbijGHilLabArddAzv0Z4Qnmroo1sefv+lsIqQGlu2j7Dz6y6YJsJ/UyquyiUS6?= =?utf-8?q?/+xSBeBRi1eGZFZRdaAipq13V9ErdKZgXABw7H38Ec5/PafOtuxJJvWPkp/pbmKMw?= =?utf-8?q?gCTfRaSpY9GL9ssSnpz5O7GXGUkzWvEmR9cZwLKQmUCGGChbIP1v7DoDayQQqUuPY?= =?utf-8?q?0cxp4eTJITyWQdhcJZwUG1GARt+hdFM9t1dvIZnGD0yLHV5z1ACiloHOq7JHN3IKp?= =?utf-8?q?1xhNzSAkdmvxBHJX2E89YVHwKhOj4U+/3RkZQOi3ln9u9fO+Mf+IZAj5gyxyNNnYp?= =?utf-8?q?0/ntDMD2C3uZPD6LQ6+ZaFUkXeBHPDX6rBamburJEWxTbPucNJAyiMl2saXZJmt+O?= =?utf-8?q?b9tHTxDL920UMiC5SJyl02auxV1bvYIzmNCzug+WusPtBRorRw1ohDJ6hsrtRg6SU?= =?utf-8?q?Eh/+mAjNmR7epDVwzmUqnAxx7hFOdXVBBwTAFV8W+c/4KAYpkkEDp/pCTX5Fm2otO?= =?utf-8?q?T5CMCPIhi3jMhY6d7uwxgonKLnvicDj+/M1/SOVOoSmw6p26oPEqzrVVJh3bx7RPx?= =?utf-8?q?GgWpZtf4PZNZXaQvt57vmY07X6pmXg8VH5xKT6iQlD2Gs9DS5EdW0WcjBaPA/mopm?= =?utf-8?q?YuSfP9v6Lr8pe9OooJgRxzR/3TwrBjJe7mUmk8iNAQ5bCbejJjnT1t5N/yyuLL5sF?= =?utf-8?q?6mUif1Wb4BXb?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5866640d-67e3-438f-1b9f-08db8d8cfd6d X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:01:29.1309 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IunwaduPF2ElWdgq+y8oB6lXUjS6FL4QIhtVrhCKxEvZgDoNM2A+E+fJ5jHTA7/V0i8vXhnTh90cxSaDsiv/MA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB3934 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/sh_mmcif.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c index 5cf53348372a..1066e0c2831b 100644 --- a/drivers/mmc/host/sh_mmcif.c +++ b/drivers/mmc/host/sh_mmcif.c @@ -1509,7 +1509,7 @@ static int sh_mmcif_probe(struct platform_device *pdev) return ret; } -static int sh_mmcif_remove(struct platform_device *pdev) +static void sh_mmcif_remove(struct platform_device *pdev) { struct sh_mmcif_host *host = platform_get_drvdata(pdev); @@ -1533,8 +1533,6 @@ static int sh_mmcif_remove(struct platform_device *pdev) mmc_free_host(host->mmc); pm_runtime_put_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -1561,7 +1559,7 @@ static const struct dev_pm_ops sh_mmcif_dev_pm_ops = { static struct platform_driver sh_mmcif_driver = { .probe = sh_mmcif_probe, - .remove = sh_mmcif_remove, + .remove_new = sh_mmcif_remove, .driver = { .name = DRIVER_NAME, .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Wed Jul 26 04:00:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706841 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55B63C001DE for ; Wed, 26 Jul 2023 04:04:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231624AbjGZEE3 (ORCPT ); Wed, 26 Jul 2023 00:04:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231656AbjGZEDx (ORCPT ); Wed, 26 Jul 2023 00:03:53 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2120.outbound.protection.outlook.com [40.107.117.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B744E421A; Tue, 25 Jul 2023 21:02:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DTXJD69KgUZTj2u6GKGwFlL79BlJ05p+Gv5e8ng0W4TNTxMspEVKjaSkb7o0nAHpwlkr01UhKxjhq4OXx+Lorrm0Q4WGfyNwBdAAZorg9pjH/AV3X0dy99K3GJoQ4Lfd5IUtAKrICLv3jd8wZnEVk6cx7d7Y31xAzEeTJ615NtrANuPO+LbNzxogb02N8S4dXP/aQ1YGZpeqD7AnBmSfCa4XLbEsik+qUsfuMm421UEVdDDHCT13Vg7a4QwdF2wPqrw6UqNrmaCRYHhny4gamtGNrx3vvZj44kARQrgcr1EFSZJSXPQVW695iV0dWhrcX/VMm7Sj9fLHziizCppY1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+nPOwPKYNeq/2Tv4iqOeh7ZkKMvKEp8wvhNPamOgGPQ=; b=UZUokC+k8+odT7uAU1cqE0wG42trolnTN66wiKHPsU3aP6rLwrg6S6kQ4NANoZxbpSCt/6JLbYbC8LWM/dyYDU9aYC/5OFod+kyjKputqr++aL8grzCKC2iGu7PyhofoDJZjRCGaEmAI1oeRHuSU2c/fFF92eijvVPdjYvIriHDU801ae1LwpUJ0XMiWXzQxlUxcfLOjLvdOPL+W1z/9xolE597Nrb1bGp6QgkbbqvDEEXu6OiG2NNj4imDG6j9I4TJJNyOnjUxnoB2t9MSZPoiPM0jnHzVj3Ogv8C3fmYMwVmbsUZcsjBgJ+xCBRJ1Si2xYa42ESmLLue+NX7aQpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+nPOwPKYNeq/2Tv4iqOeh7ZkKMvKEp8wvhNPamOgGPQ=; b=EtHqE/pcLApsjrI1sGAcpsDHBbDnRAlsQ1DsYZPSHkIYOQVqYfAbA+qnmqDzN/0VDjYZXxAmgxHetsoW3dhppzkR/RhaG3Fh4+sfM7IGBkLJ71YW2x2sYCOHVfc8isKa5UTLePA6c7tuM7eysUJAO3E337nfkbe4/5fgf2Wk8PfDjpgmkk51Im/qoc7y0j1RFJEguVfXqAPORzrY+tNpML5Q9YeAew0ORSl3hpXLI53KhPD5Y7a6y07DCAT8DyGFz7sfZgihEVu/eNmifFYWIwRbi1wr4qk9ieQ+Z41TG1UWxf7aoXURJ0wf+95yET+z48QALatT9BKyg561BUPyuw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYZPR06MB3934.apcprd06.prod.outlook.com (2603:1096:400:7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Wed, 26 Jul 2023 04:01:33 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:01:33 +0000 From: Yangtao Li To: Adrian Hunter , Hu Ziji , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 20/61] mmc: xenon: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:00 +0800 Message-Id: <20230726040041.26267-20-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYZPR06MB3934:EE_ X-MS-Office365-Filtering-Correlation-Id: 9195fc04-7526-4576-f174-08db8d8d000a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EOLPvLgUmj/KlX4kWOaC1X1eFDvFeAph+ZBKZzDfUESQ+c7ua940Ec403ODv0SsAc37LVONQi8topJRQGJCHLS5hA1y6uRBa3wzaQ0eUZMKVRbuVhxxDSkp0o/nPkTL4GPfV1qz5K5rL7fOqCpFGXY9zGx14npc99QBMxRp6On6+ArsIMXXDO+ZlF9hAdwk6AUKZN/rXQH3BEn46PEoqnQ+7cKy6Hs3zpxyj8T5wW+xsBnLpyGWk97vcpIWACNqOWzovCathyhK3MsR+Np1rqp4/qAX8JvgqucYb9/S7pxHzAcwMcLQvM/CNEAzA6G35xOn9ZU0xHNss+EcOe+4ehoxKESAlQRA+iVfHXhM5IxvnWUud6X3G3wmQwlak4qlDkDgXJ2Rro0Kjy3CqIQfvRNnVo5RMGFy033eRLlti60Cgih1QLjfoKXkvHGDociUia0DfK7p9gqFzypt4NClz0jZNFJZIordDpUP8Xt46ej7WRQmX88ZIowBwBMaJVQ5ZyGLQ5kwlk8k0hPoVfFSrH1ApMa+BnmG/Nv+yjTs2V+mk5JzNArnqkwvwKtcuWyJ62pk2J6fcJ4BioftyEd+K3/80g+lwoIuqcmytnrN9wjtkVPu5WFcLJ1cfl5/Y3gpo X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(396003)(346002)(39860400002)(366004)(136003)(451199021)(66946007)(66556008)(83380400001)(2616005)(41300700001)(38100700002)(38350700002)(86362001)(36756003)(8936002)(8676002)(5660300002)(478600001)(110136005)(6486002)(52116002)(54906003)(66476007)(316002)(4326008)(6666004)(2906002)(6512007)(1076003)(186003)(26005)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?7pK3tX23mkDul6AwFHEgo1ysEP8O?= =?utf-8?q?kuNUATT4Rw26KgvRSJCn1c+zvCq0RLNgpVLCoeIWVNVY+JXI2ON34XYzAR24wo8qq?= =?utf-8?q?LFNjrrPyZJiUcSXKPuER3qDDhH7RJct+jMR2wd4G+AReVL7kXNw4Xbq3xzCYStPpE?= =?utf-8?q?5fHe5eDNBDvbXtjSIJg2WHvCHK2VfMUH6PIkT/Tw9A1yX95j99C//+g95rR6jvjA/?= =?utf-8?q?NqxYzlU2bOhPjmuqI/3olpGqPv0Em14PvcxBRQMysCbPgi6Q5KSq8O1LiJ2wdMytt?= =?utf-8?q?KWyMKBzjc/c2/6RRVc7QtqCbfxeTVyCvTgVWk/d44ku2EPqEqCC42dV6PDpa3OoRj?= =?utf-8?q?9aIs5B4CjnHLFrlAcdHHvchGaovIwG6FHv8UbIvd+ptN5znehQVwr+nyqO05Dk94e?= =?utf-8?q?4KCnooUyClV6c6KaMPmUZxoJC/7KV3sBuKrQ916II9ty4VAkBxaVl1C/H1ntiZMcq?= =?utf-8?q?Sea4+GnNury0HvPY3Kuq++abzc4PsRoqjqD8w+/kvbMcy3aIyipaXk2vL6xG4TP0c?= =?utf-8?q?QsWMpg+7HVlnQm+0Y80wAsuN04Ypwk9+HMh6/XPC2n/tHakeyzqKgK9p9S9w+fW1P?= =?utf-8?q?AklnT9ltsOVnckJXk3IXirutcBHIw2M12o9qVJqWizHoD75HTPY/op0hiT2GbXqX1?= =?utf-8?q?HVIfGld3+tB5fW2+9Fj+7kHCcxTTcrMj8qIDHbMWzMdwyksoeIDh5SIkY523KGNy3?= =?utf-8?q?OjuXSbdszs1IMzcIGm5IZd9pZQgE1lzAUV9swzLH2X47hWo7Hd6dKNDp3Lg24NZEh?= =?utf-8?q?g85EgMYGCZl7KBZVZqfbcxeWLvizXseOeHCI+0f0H/JeIXqAWmEARKjcu0MeoHPT7?= =?utf-8?q?b/gXFW/lJxxtxlfGxfYeb85zp4jmjY3NHlsWX/5/Es2Ay4LApDglkg2yEgvrlRDwO?= =?utf-8?q?C3SYPk9pSxs04r2Q4cEdf9rtfnYxTvaD8rWaPGH/CoSgrlPkWNd2y7PYYb+cOuxx7?= =?utf-8?q?90gUa6lXJEu/WK9sW9LwtCq49nElA3PcIzdK9p614a9nftIE7k5GRGRijRAB5D1d1?= =?utf-8?q?9vsWsSjBacz3cRnxgwOgb4uPjaQpyiBY9iuSxXLmKbqBlLOAJ5JZy6maL8cJvx+Z/?= =?utf-8?q?NiDFA4AhLSAqdR0qQejBSyXYfm5XEo2hsRzG4CXwOGxsSAL/IoW9uWGPhSI/QFUtQ?= =?utf-8?q?SFKJzSv5EMk0wYOrPaq6zpcdxO7WlM4RQSo5zYuY5xdLw81/V8rTIqucuus0ebYRe?= =?utf-8?q?wmGSNOquFjD81qAw/8eXMgaxWyh2brEPrNT+rKkIHMksZ9LXZsVA1tpmYkelxfd1G?= =?utf-8?q?n29ELBvfIvZL8a4jAadVM9v5D0syi/YZkNm+ZtlMYOMebcG2P/qs6Lq8YRTuUBmmV?= =?utf-8?q?MCkbx+KMesS5ZZMeJsjQ1i1gxbxc0OZKcI/t3IcwBGp0+mUvFD3vpjJvPfXYqUeGc?= =?utf-8?q?+u6tVwmoa0C2hZtYr9K2Tg1nEAfG2Ku8FLqAP5M1vE5IzsNtpvlvQ24KIZfQ7sAcb?= =?utf-8?q?3+IB1/LlQZY70/9969Pok+3xKaXf5pQijRD8DvnpcusC+a7MCIh60qobfuQIB1AV0?= =?utf-8?q?6A0Wj0M8VJEH?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9195fc04-7526-4576-f174-08db8d8d000a X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:01:33.4898 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R508bRrtVvNwVFdspoPTKOLOPDFnwShiuxJqMPiped+jd2sV2Z36uZo7RQ1aCaDHJnwlcEKT1O2xoKGoRLRXkw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB3934 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/sdhci-xenon.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-xenon.c b/drivers/mmc/host/sdhci-xenon.c index 08e838400b52..25ba7aecc3be 100644 --- a/drivers/mmc/host/sdhci-xenon.c +++ b/drivers/mmc/host/sdhci-xenon.c @@ -578,7 +578,7 @@ static int xenon_probe(struct platform_device *pdev) return err; } -static int xenon_remove(struct platform_device *pdev) +static void xenon_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); @@ -595,8 +595,6 @@ static int xenon_remove(struct platform_device *pdev) clk_disable_unprepare(pltfm_host->clk); sdhci_pltfm_free(pdev); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -705,7 +703,7 @@ static struct platform_driver sdhci_xenon_driver = { .pm = &sdhci_xenon_dev_pm_ops, }, .probe = xenon_probe, - .remove = xenon_remove, + .remove_new = xenon_remove, }; module_platform_driver(sdhci_xenon_driver); From patchwork Wed Jul 26 04:00:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706840 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C804C001DC for ; Wed, 26 Jul 2023 04:05:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231443AbjGZEFQ (ORCPT ); Wed, 26 Jul 2023 00:05:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231214AbjGZEEQ (ORCPT ); Wed, 26 Jul 2023 00:04:16 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2131.outbound.protection.outlook.com [40.107.117.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A4CD44A7; Tue, 25 Jul 2023 21:02:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OGIENbdYjRbiGW0YhVP0b07eMC5DMUN5orG8xs24xgp5PF62Empy0NE9UEgPCp9Y8/xUgeR7h+vTU9QJRuHgRNVA4gYFpnV+OR/f6SDBF8XWv0lghdTzglTWgeGCIO9uP+KZwgsbB2BSenCDHw6S4InRKGHH6NlsQ5Vh1FgoxLfVaCukZJnkLnjjNuEUWnPJWaP11AJSMHz370WlDUw5BBP7KyFaTdBkg88FzpWOxPrupuuOuaBn5YoByp2HITIL4x13hGA3wboRe+D8mCpVV72IIwfjq+DXxD5qdG8nAWcTn2HTQCUaBLmtnNAIi2TMz0lBP7ZutLR1fOu90v+KbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bj+WD0ujQJJoGOzm0bS7zDFDRH08DzA9OwwXsON6vZ4=; b=KkakbZmMxcK4WMzOpqPm4Z3atFYKKg38f1ef3u5KurRK/ZY+i8qtYpv+fammfuJToEr5Wsd9dmDKL9hVVHTr2Yyy4nT1EbMYghtNMsgiDS8qirg4WQDpdIt04IU+kqcmrq7YktIFs7XhVAYgbeJdSUS4xsMiWX3R2DpkYKkQgwolPzmQFObA/NDwkazZXaX5ZO1Ekwgm0MX45qxzJQCQ7qoAaNlsarABPIuTHbaVmE+FgDS5mV4FD0AHfJUW9b3d5bWvBIUFUApPxdeDhavAMQrTcWcvymmpALTfSi22f1r3AJyCYKjGZ2raiv2FCGynUXBbNnc/5EM4TaTc1V076g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bj+WD0ujQJJoGOzm0bS7zDFDRH08DzA9OwwXsON6vZ4=; b=Yv+0WnfCRU7UzwqiIqY6jAU30ernzXVcfJT4DzxlD4KxWJbS4l5RHGJ/mkeumE9vHeolS+v0EhSS0GKfRXEUD/SatGoIs9iBcgQamgX3YcKtLty2Lw4FHfU+q9IIVOyAtLQD58GAbA5iG8myi/d0z7Raw/tsAlHVnn6+PMJJ0eaYzcVBys0TpNm15TynLilVx5B4LUFiTKmkPKmFo8SHSsMuTfSGKRPZ2WIXTlYIU1uC9NGniZoHCBTqW5iq1UY9ZGbCrDp6rOWeguJ9cWk0510XItSyRSy7hOtOkLM+FSuT7OtPNW9/gisUtRLEQ8CK9zA0t8Uw5z0zqokOAXFMOA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYZPR06MB3934.apcprd06.prod.outlook.com (2603:1096:400:7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Wed, 26 Jul 2023 04:01:35 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:01:35 +0000 From: Yangtao Li To: Adrian Hunter , Ben Dooks , Jaehoon Chung , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 21/61] mmc: sdhci-s3c: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:01 +0800 Message-Id: <20230726040041.26267-21-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYZPR06MB3934:EE_ X-MS-Office365-Filtering-Correlation-Id: 39a1a542-a6ec-44a6-9ee9-08db8d8d0107 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9VMWCiDM1IY6H+4vXU5+gmSA3r0RwIMTJrjfWCMK+Q5stOfyQVrKohh+K50fXRiK06epvKuCE+Dn9qXASN0VZCPAM7E7SAh6SeLBWwpxh6ibyJDjcgnRrHQoSSZpU8Cv5uxLzxEroJuvxTGUho71b0VDQWaHpzIy2fJMo/iS7XChTcHiSBCI24spww7MFQlY0qS3B4mbAtSZHlUaJeZ7taSXmDUSFms2woRj5SMCVXiVvbzk5x881vC9/9nYCF66rpmsYBCKu+BmaDF4NsygUzwPdcj9fRdVvfIcN4Z+R3UGparCSM8vhEKOB8arJYsSNZPdQHZOe5uJuH9Bgvrg0JMk8LVm6LNOjelNLc4R7icyzS9F9zhufEBI36VGCUm5ZX05r5yGewEvYlppDWOTKi9YiS2YwvASf9FX4GsaXGZ2I6jxk5Ob9GQeCmlGcp42hxhjqBmGTHw/NXP2xsQHjXcTmr12RRR4a66sTwvweyG6/jtJ035i1YROwfA66N1HgQLhCocQQWdsCxMil0/15Pi3tWVDmK69ZySQHVCI7xS8E8LSWy7QwuZVN7hBTghXlQ1fWP91UYpeHMhHOYnFNQ1j9ATD4y1sdUOo5LEFCNbQnXOtwwNlLFKZwGm53jx+ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(396003)(346002)(39860400002)(366004)(136003)(451199021)(66946007)(66556008)(83380400001)(2616005)(41300700001)(38100700002)(38350700002)(86362001)(36756003)(8936002)(8676002)(5660300002)(478600001)(110136005)(6486002)(52116002)(54906003)(66476007)(316002)(4326008)(6666004)(2906002)(6512007)(1076003)(186003)(26005)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?fBpi3IHbra8W7gz8l2qebSba8lTN?= =?utf-8?q?d0t8s8jG1Ta2mQzVi99bjAIFhBw6+jXCJwLJzh+tEyCgZMdVb7DtXQrv0S1gS0t2q?= =?utf-8?q?4FqJmtB+rr2tGvoR17VimmJwcCDElbiODPABy7ggONGsqB4f4XcmVntpFZBsxDzxw?= =?utf-8?q?v0/o03cvX0BPN4zxWEqg3aH4+skOkgLqQUlrc8Alb+aUop22h4EId9WjE+/nKQsRs?= =?utf-8?q?sP4jUUAZlPrjzUR1c/n58lHHT7T0zqToo7kxJJw3vsIvps94kLszbGzAwqLgH+G5x?= =?utf-8?q?VoiOdRRUDy1s60nethBpLN5LBvqMnEYh1jpEOaPK7O5PNAr3OS/BNOMNpyBCBvh3I?= =?utf-8?q?GEWgfDHaRNqkF5rBqJnec/NYxCtMinBRXMjX3xOxP16jpFyJj+vdj+AhmHi44UQ8D?= =?utf-8?q?BhMxokKbh5Rf2CNgfULoxWEWjVwF+KZMUa5b3LJxK7ViWRkZpIBzQ2LYtCL2bO4pQ?= =?utf-8?q?mmXN8du63e6jDinM0+r11Jw1zVv937LDXLgZjq4xqH8SF5OdHsyA7TFJH4iIgM7QX?= =?utf-8?q?nrc5nFW79haZ8l0oCSl/0blbsaQenGRmN3iwt1q1nK+ehAAIeBe4UByAk6km4aLHR?= =?utf-8?q?8J6SjHAw7ihTQS1sxjLQI1y5vaMZ9klcoXCooWOAuZ1yng2gYPP7Gr5PjHSc5isLg?= =?utf-8?q?JDH57U07wluQ31SgrOwnK65hBcI87DLvDrglsw3bdk7GN9Tgbe8kqlMU9TnUE6Twb?= =?utf-8?q?+PHjuxMwNIv2YDFIAElixBlCwWA24+ANRrS00TH+nSFkEqJcAWRQ3I0/v3F4k4T7b?= =?utf-8?q?li9w1q5K3vrNVFBsPcx6LK21pFEt+kBElKjzd3q30YAZHt9lCMCyfTyB7OGu3LmUG?= =?utf-8?q?GTSKe/3kIeDE29n1JsDFPNGY94iraErgg4ppZolDGpfx3pjB1yZbGsQ8CPcl8xDxa?= =?utf-8?q?AJSC6saXM6Tp1jw3cOW1MhWAuQAslf902LXX3+b1iHgHOYgksaRs9ufQck3E89FcQ?= =?utf-8?q?veE4CClkTA4EssjCvpYsqnBP+9n/0Hx+jlgkV0cFgA+Bm5n4xWx4fRkXJ3lP5COv1?= =?utf-8?q?zKNqNamwQEEeXkbibMmRVQ5v7Xc+bq9DTXnBjpOeoFi/TN4mp3AO3FFmL3lNkWkL9?= =?utf-8?q?2+fL8lqP5fyE28O7toQUPvzzbeacxPT/Zaxp9ZxcX7H3ua5+ueCKqjIlmlYX/b8Ra?= =?utf-8?q?K9qtS5//XHmih/NKdCF99FYn1tZTS+WGwtwZQQ8m3LhT3Rt1VXcCRHquSJvxrMXlO?= =?utf-8?q?KEIsmVogHMKcFD2wblLMYGawiGUu8FQuhS6FVjL7fI7nxd2u3dbdt8oXkd48ugUd2?= =?utf-8?q?rr3DzBy0CIdLj8HNbXh1ZNKarXglM13fOBcL351jNAjqmFEg5lMOrn0SvpmgOQcJU?= =?utf-8?q?7zrn6LiBKgSQ9mR9hZ4XqPVqPo+ZRXXzeIIrUUlXq9il63rL6IE93tu3N3+CDv1sE?= =?utf-8?q?s2kD2fJJrP6YWs022L5vyDUZrq2z1Eq1uAtodYPuRpe06z0CIgsExMuCUDq4kYL+q?= =?utf-8?q?77LsmmPjm6ZwTnnL2/5mGyc7rHMQ1wls4OWGohkOK6ApjZz6q8WHvxT8DMwkres2X?= =?utf-8?q?ofLEd9JIxbsA?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39a1a542-a6ec-44a6-9ee9-08db8d8d0107 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:01:35.1508 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XgsziMUJnyKkrDRiYuAlX/GatOzSfry+HMJtTdSRasSp8qJjJo0YT291pHMScVMKgvVocAyIT9wFBWCOr5ybbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB3934 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/sdhci-s3c.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index 504015e84308..b61f12d328e0 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c @@ -668,7 +668,7 @@ static int sdhci_s3c_probe(struct platform_device *pdev) return ret; } -static int sdhci_s3c_remove(struct platform_device *pdev) +static void sdhci_s3c_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct sdhci_s3c *sc = sdhci_priv(host); @@ -688,8 +688,6 @@ static int sdhci_s3c_remove(struct platform_device *pdev) clk_disable_unprepare(sc->clk_io); sdhci_free_host(host); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -776,7 +774,7 @@ MODULE_DEVICE_TABLE(of, sdhci_s3c_dt_match); static struct platform_driver sdhci_s3c_driver = { .probe = sdhci_s3c_probe, - .remove = sdhci_s3c_remove, + .remove_new = sdhci_s3c_remove, .id_table = sdhci_s3c_driver_ids, .driver = { .name = "s3c-sdhci", From patchwork Wed Jul 26 04:00:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706839 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F0AEC001DE for ; Wed, 26 Jul 2023 04:05:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231672AbjGZEFc (ORCPT ); Wed, 26 Jul 2023 00:05:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231671AbjGZEEn (ORCPT ); Wed, 26 Jul 2023 00:04:43 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2120.outbound.protection.outlook.com [40.107.117.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2101D469C; Tue, 25 Jul 2023 21:02:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fLfu9+Qs/BNPffXQB/Dp3MMPWkVYDSDbojNbyWJqyS/ajwWlLXsTD9NDINuNH3raoPTkuOePmUoHeciG2UWeCGWQ7cmLjMwXN0//9TzOSpQoNGza1ppozw0RZzQj+TRMlaHRuxzoIX2J56Nh6+S+eonPTTM362+iyAaRQkF7lRgH4F8FwDWxj6qic2Y694XCZF3mxWTvizHCweJWIeDpZ3sD4ICVzZy76gNT2yViKQQ84MfUk0wl1tSa4LWIzvHORkm1SIpR2VEt/+1kOuZWD/hIcJrN4Ccpv09N/wzClh02LxwqqnOMkOFJ0jdaELrCBqNwTBBGYPhm321xTb7FHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9QwyjiAPoUwvuuL+fTQzivWNofmwHauOj0YWTiKbAgA=; b=PkH+X9z7iwL26R28YXdG16DtJ1d5+jzCrK44jy9TjvIpq3GRDXzkfiAiNw8Xj8ike+RZgq7Dk1RdpFc4I/ZGIQzP4fVDPYWQVlA4mTRiNBbjsPkObKPr9FcZ6wvC+MDW60ws+1VIMFD4zvXm0Y9zH2RsY+0QnvyIl5oVmWDVzfOK1VdkuLg9CcHAKy8VkVqN1gda2kug1bSWMLMIffk/oweOA1JzNl79Q55FdN04BMHGH1vJhL2rSIlX3REtp2j6yH4IiEMNr/WIyUpUnuTHEIc4t+1is2rd+VupH6bBiA/OFkqm4vQnBt5K/iZ9l2BkyyrGZ1umTN/2tnKLCTceQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9QwyjiAPoUwvuuL+fTQzivWNofmwHauOj0YWTiKbAgA=; b=Q845ViZ17YoLnlQCaht+nsTaVOyqWtnXWG1VPVtYYTcRFUrTk1TafAic3gxXvibninb/Z6p1bVhCh81laf/DpmqOwJMcvRprvZFm7pdD78nwUMyZe51YVCUhGEr26nm1ZgO715Ietd5gCGOx8ERqiVBIOn9RpCub5WHPhii2vIrhbg4zSYmT9HYLRzm4N7Cf/nylsK3n/t+SyQ8sgOygYnSKJRMqIr/BKzppAKmNvyzH26GtO5TOWChB+hkK2bIhGBH5FaHnV0fOB4pN510rP1aLdlFzoZnF7MIJe8+U1Ssc/C1+QgI1I+4puv/Vxe5ZSx9J1uU+caRIG6Cje7LwLw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYZPR06MB3934.apcprd06.prod.outlook.com (2603:1096:400:7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Wed, 26 Jul 2023 04:01:38 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:01:38 +0000 From: Yangtao Li To: Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 23/61] mmc: rtsx_usb_sdmmc: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:03 +0800 Message-Id: <20230726040041.26267-23-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYZPR06MB3934:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d669155-5e32-4496-70fc-08db8d8d02f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lk6DxO98cHo1SC4UIUtEU8zZsAxOxN6uVxkAlf+rnZgNmWmVA9D9j2CsL8crFDIMTTZIbJDI4hbyy7ipkJBlnj5piTC0rAjnwCPEFSHupv5YoRGgKBVOHPUNud5oC3Rkjvr7/KlikXyu1EbZ/vqyJ5Eydnbrj+JrdL/y1ljAa/WnLCiMRy+oNxiX+wogZb60R9SqYAUyq++o6PODLs+jKG4wBkRCdS/4k05Z4vZmq/lA2I1xAWzJYqYEZhBk2vZVZB00Ak6wvqR8F36Tm1UTzoDfW5MJ9vBYyZd3rBLEKvdUUrEcxv7epjPcktyIZd3mOpGVQFlqdl6hWvPYc80reUhkhR/V0tfDY6GdOF3m3jhkBmWUbu+KY4lQM4D2vLqLw8g9r4My9gRVLVddvuCzWkQPEolwjYb9+m38/viqOpOV0cZJl8Nhlerv2psf6S3HA28sypBmuGyYYJg7ZcfSU/Z585rhDd/6cnw2r3OeLTijrpk4loqRaUcF56KueGQwYdI56+dI8LlIcUXDjZa2G7F0e9TO0rvPDQmCfkaS4ebcKeFMqnKH9VTptpPW+JLr1oSe3tlgvI6MRn6eXCzywoSO34SBGEwgx5xiMzY5oG58J7YtJyOd1EXv/wgNMwcR X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(396003)(346002)(39860400002)(366004)(136003)(451199021)(66946007)(66556008)(83380400001)(2616005)(41300700001)(38100700002)(38350700002)(86362001)(36756003)(8936002)(8676002)(5660300002)(478600001)(6486002)(52116002)(54906003)(66476007)(316002)(6916009)(4326008)(6666004)(2906002)(6512007)(1076003)(186003)(26005)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?nQL3cZ7BTevQUaJxpAp8VGHg5+ns?= =?utf-8?q?nXYKsQjSGep9sztQwsowlQ5pebxJ51XKcxfqR1370aelVBJEkVxWLR3ZNx6WAqFo4?= =?utf-8?q?p/WxsUcEOqg6AiQytMhhK7MT6+3iDLBascPOH6MzvePH66X1lsgqXUEbhiEu9keDI?= =?utf-8?q?pnpYWd9uXdI+YpeMrM3xpn7SzVKpnDyG2iTOAHL9Yf9LsPUTO6H5J+R+VRX5/bgQg?= =?utf-8?q?iep/a6o+ps7qnz7Q5/EitBIm00OChPOxKrXkzpKi/XeHiMiFR6IXrYsr9buCrNQdd?= =?utf-8?q?bhoO/0nbXLeYzvFqHRmZyzgIpgh5Z6pxPBcwCczrllIkzYD/XAWvZfYLihCj/wnZp?= =?utf-8?q?QK8yPHRbhICgSxQ6u+OtbMI0Z29OUUhTFN8qV+vxQgBgpeMbrfmvk00xmU8a/OiWe?= =?utf-8?q?QIgVTx0rHXZkRxK0ug0TmbUJPHGYfe9ZN3ZA9hq6QuWrhGY+e2M4L4U3aFNPU6EM0?= =?utf-8?q?NrWgjAF1LcuhPL0a+/Wflsl45RAGCN2YOMymOpSzgdRQyhtA39XfSAhI9oWF7AGET?= =?utf-8?q?q5feC0uiC2JHhRqMz4WpHMJEgnkf7A6SLACFPco5GUS6gZnO8VFKKqnV+zPualL7d?= =?utf-8?q?Wvm9KgJO8dTkDEGa69sHWCnZ/489iIoPsrHhz5sy6fpSw4vRhfZwjE2sg5PokQgqr?= =?utf-8?q?GySMfM5uc44Q0ogdLEoDrRf0q99AtHwOwVfCzIgwK0f5Xe5C4lqTFSUN3HgZflpNG?= =?utf-8?q?iRy7n8Y+NHAxhsrCRuyd32Q//s8F7NEbLzvRu5sQnNOQwQ1mHzFQ2H3JD68l1VKqU?= =?utf-8?q?zJdp5oqsEKT4Zf9aA/uHJZuTz9wNSM0kLe1N0Al7F8fC9zBpHat8l5scwHQakQI90?= =?utf-8?q?eNskFv/DJX4NcZE/e9bCST8rGn3hUB9DFaxDFFRwHG7/9uetxQuNE/0pmx0Y8/rZ3?= =?utf-8?q?U8yAh/t7ejxCOQFs55/11sEvd7Ipp6Wcs4F7c3GkVVr8y/3UyTqI4SrUawutBSeD2?= =?utf-8?q?dDtn/qwCD4jvvMNYQv1BUkwDJDF43kRgerJQLercrBFaCPIpCc8jt8OB5oTkbcHW7?= =?utf-8?q?EBlE2YoK0FQgLNNYJcAAqGTNUssmZAJcZoh3+uwOUQPM3lX+fc4rILfVIcVnUHcuB?= =?utf-8?q?wVwa1qroFrczNsO2H/2CoNy437crHnvbMsM+KefRXFUyMnORAfkaJFmiOGsmtayaI?= =?utf-8?q?fkVvcNTwSzTvX+D5SJnHzPhmbTlhyKSKWgz0yeTchhnvUpYTR6yjq+KBnWWRvPWr3?= =?utf-8?q?e2ZJrY34CkyuqAglTtgaluqdoyT5C9hl1ZN2uleE1WroNl4dujRKCGrGWkGy4sdwJ?= =?utf-8?q?MXEyjQ26MAdxhrass2u0b+phUcNKulrVtmwfoMg1Kzy2xWHUDY0ibkrLwmMeQw1Ph?= =?utf-8?q?fi3WDgWUqZ2CFyapLq+09vGG2WFai+lvfV3K3tppy2dqWr8APH79kbK90WI5JkqBO?= =?utf-8?q?NqjiWb27A48g2co2AN6WwP9njwR5sLQJE8ZZ2bL+gd14C9/13RvQH4eklo5M1lwv7?= =?utf-8?q?xiFVeGkPjOqwJI518ExC1PfcZGIb73lu7wx86H4NUysr9+htgjwBdjlcOwAoyJ9cu?= =?utf-8?q?snX0BiLMtGAJ?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d669155-5e32-4496-70fc-08db8d8d02f7 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:01:38.4419 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 651XlgwWR74ma3d+owc5ldBzFPf9etPZI4iC4e0qSDNJ9HwD+RVQoaV68nEZRpCUZEOmG3cTpuIfiRjS/bIaig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB3934 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/rtsx_usb_sdmmc.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/rtsx_usb_sdmmc.c b/drivers/mmc/host/rtsx_usb_sdmmc.c index 2c650cd58693..ded9b6849e35 100644 --- a/drivers/mmc/host/rtsx_usb_sdmmc.c +++ b/drivers/mmc/host/rtsx_usb_sdmmc.c @@ -1379,13 +1379,13 @@ static int rtsx_usb_sdmmc_drv_probe(struct platform_device *pdev) return 0; } -static int rtsx_usb_sdmmc_drv_remove(struct platform_device *pdev) +static void rtsx_usb_sdmmc_drv_remove(struct platform_device *pdev) { struct rtsx_usb_sdmmc *host = platform_get_drvdata(pdev); struct mmc_host *mmc; if (!host) - return 0; + return; mmc = host->mmc; host->host_removal = true; @@ -1415,8 +1415,6 @@ static int rtsx_usb_sdmmc_drv_remove(struct platform_device *pdev) dev_dbg(&(pdev->dev), ": Realtek USB SD/MMC module has been removed\n"); - - return 0; } #ifdef CONFIG_PM @@ -1455,7 +1453,7 @@ MODULE_DEVICE_TABLE(platform, rtsx_usb_sdmmc_ids); static struct platform_driver rtsx_usb_sdmmc_driver = { .probe = rtsx_usb_sdmmc_drv_probe, - .remove = rtsx_usb_sdmmc_drv_remove, + .remove_new = rtsx_usb_sdmmc_drv_remove, .id_table = rtsx_usb_sdmmc_ids, .driver = { .name = "rtsx_usb_sdmmc", From patchwork Wed Jul 26 04:00:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706838 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80DDFC001DE for ; Wed, 26 Jul 2023 04:06:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231587AbjGZEGP (ORCPT ); Wed, 26 Jul 2023 00:06:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229778AbjGZEFX (ORCPT ); Wed, 26 Jul 2023 00:05:23 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2131.outbound.protection.outlook.com [40.107.117.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4507273E; Tue, 25 Jul 2023 21:02:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M13qXiC/LcyMkfESAVlG6XWOnbjryIziGoQy9Gd2tsBnVwz/k4dO0GAmXGGciM+Swb0Vgp5jRgBJUgOIlj1s1ZpQ8PX+xQVYYuK8WaHe2lClL7qdSDsC2hg5tZOc+tTxuviSnWVYQ1i5EKIVnEp165pQQyDDsQ3Np9lVsZVyeNK+G6HHDHiXemgRkLoxw6Ikf/bJFO16fmlbSZ53+VV4UwtDNlhtkkJjTgiqM+J7gCEi4xMWFI5xEx8P2g8Ao9vBhc4ifVFkII5MJVXIhEkhgH5KmIPzFRCZnqT9DFpcvhvBkEzEZsBkfagGXLmWDbxR152TQDZcKiDx5Ogb2FZlTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0VnGOYi45hwpGU2pMDgLIc+XDvJEY43fviyLsFSsxj0=; b=QuQg7+w8iA8dWJKMcg4pY01yd5Rbu7OqEH/wUQgECK1pqOjsJt3yY1573LHAZsHsRSObW20u+Vq1uSrvJdtBItCci6upOMMLBda4uvwQKxZm4cRI1dl/pMClgC/pX0oVKMhwW/ofOmEOqnUfAYaeCUemVXVKKC8Xq+PPvb0ayfvBCetuRf5IxBPOQRlBPbKoml2MU/r8tEkaJ+5JIGLM80dd2s/61gHPUZm6sPFuB6VW/qTNE6ybwaqiAKaORPugJ1f8pSVSQSHQt0Kf+nC/4bWh/PjbSz2/crbREMK2NGTJ8mBDjZRr/czKxqoi42sYn2j7XT8YdouiKexf0Kbg/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0VnGOYi45hwpGU2pMDgLIc+XDvJEY43fviyLsFSsxj0=; b=j9R/JW1zeTFlPWC1RXn0XiBjKmHlarat2SF5An6UGNPX+BLzuVCkMkz+earYOtaqPu5qQDVoYQWLCiYnxlPcYiYzmR0XrBO1CTxJlPh3UROqX5Xo3qywFopoZgaf3jfvsUtPP3x4BseHMXUocKzKP53rnotJWjn1wNCB89ud3UaHJV/0mag47vzpZl2fMmFLkjn9P8Rz4UfeI3WqrovpR/Qcx/h+GE6d+sbDTJ8N7UGS+D9NWGwu54tQFF07OUejUZWnigIrQIzGu5WsBpOzjF6eNppJGwP7XjFrkKuTRsGdi4l3EBndvhbWXinBLh4S0SdDsNZCfxPqThxBnDjZYQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYZPR06MB3934.apcprd06.prod.outlook.com (2603:1096:400:7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Wed, 26 Jul 2023 04:01:40 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:01:40 +0000 From: Yangtao Li To: Ulf Hansson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 24/61] mmc: mxs-mmc: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:04 +0800 Message-Id: <20230726040041.26267-24-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYZPR06MB3934:EE_ X-MS-Office365-Filtering-Correlation-Id: b78077ad-7320-4ac1-f21d-08db8d8d042a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CcT4S8uAF4USK9v2vG56eRvFfmJOToOdOUxUT21ak9rBVKKXbBrRLfD/y5GFqUYYqUPylbzMsGmRUGgsMkUZz0/MrBQ9yOhN9JaUXsw8T7Al3hYCv1ZlSf4Bj5L7qg1n6xQ4EymioE5ee2751j0xZC3WMBiRGd+r5fAhvDwFUZ1ps0dVZ6yglZ8pbpk0XbEormY//zgfzKosknd7ZqU4VubQgtEPsbD0PX9PDEJDtA4CrMcllVhjE/08L+ggmCcQGe+KqX0GCF2XKkJOy4Jz3TovoHTsxD+oTgLe5a+nf6mbp0mZhfyBw99jj+0nnSnL1pGY+laiJqEoM2Wjr3gox4VFg/Y5sI4w628xlnH5Qj39vQqSV+7K7ULLxbzhLmtXXKfVl5KhWyE+HARY3iBwRtUzZDyNDYHE61XZbbPFFtvb22EyrXV5ioySrcQ53KNyEgcegYm0roOYSDCmZw33aDT0BYbLXqo93Wuc2rIiyzlefTZSjebCm4/FJEE3S1KBVD0AieGe7AaM/CZIGMnKlV2eE4rVCTxLRg9QhLG85GgLpxHBCOmMcDgO6NzX5N3qp1R0ufKv3g0LrvsjVRN13WtZd+abNo+7rfg9YMG965h3nT1e+AV9EDPW3QenkXSD X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(396003)(346002)(39860400002)(366004)(136003)(451199021)(66574015)(66946007)(66556008)(83380400001)(2616005)(41300700001)(38100700002)(38350700002)(86362001)(36756003)(8936002)(8676002)(5660300002)(478600001)(110136005)(6486002)(52116002)(54906003)(66476007)(316002)(4326008)(6666004)(2906002)(7416002)(6512007)(1076003)(186003)(26005)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?tsbpk3vmZkF7nit8Np6NKozKXnTv?= =?utf-8?q?I3z5L+jd0kJjXtUA17TqJaavk2AeW2XoKPDHxfs87+h1DQ+niasBHnkcvrEL7ATaH?= =?utf-8?q?RrqJw7dhPX1pew52LkmDygv3s6GilEFKM88Z7nUywhSaZsQqQmIHkK/cVtON8C9dj?= =?utf-8?q?eutjD5h54iqnNNoDbNpIr2k8Jm0tjk7xcWKg7xgAEbNJmnsMcGTZsIz/BfpAPCJsD?= =?utf-8?q?HqIa3cKyuKKnagRtMUySOr0THUH2QVkcHLLipoLDICR52zKcnrO644DGnerXgldv7?= =?utf-8?q?eGTcaeBKKXmARFEZmuRuxqs6HdVcUSzv98U6jb3huMuQbJwSrea0HiBLm9yTQk/wM?= =?utf-8?q?kaACJVD+lNZmWIZZTyoTNIcr2iBfO8x8woLpph4GIHXsKugWCCl/oGW/3taLUePyt?= =?utf-8?q?TFcWoIPCFwhwLKpMxoHV7FfCRgomgtAQmjgOCEKvIGWEeielp4fL+DKLsfVE7r5zN?= =?utf-8?q?T3tBxcJCy2lJaB27I8Irrzmu4s/3mydZwr1OgErWtpKNOtFGsT/1CAFiyMdkcA54k?= =?utf-8?q?bYVhiYfaN4ODUBSmcp7tE7b+drk00R8/rmvwEYEP4O/XjVuMYYKdPwz99eoJyOW73?= =?utf-8?q?WCM+a8TsfJSUW8adhPuagxiMfvV7hIJyNd3+lmAVRXDd71Jxcd2zAFxapERfOoKvI?= =?utf-8?q?X+HD0gZUMpfAjm/okoJBKqAtSqMvv7fuje6pmtsaxAIc4MbZCXpK2HJQ70Mjd/T1d?= =?utf-8?q?eBgPu2rIThVRX3IWaU7n6pquYyfa1EBORqRhV0P6nhu84n54sAniD/RW8yXv9aw0/?= =?utf-8?q?lIQOqHh4r9qxmTo/pWU8FF9OzYcoYPezCLTIwgBOGn8aP21JZopWaf3aRNEZq+78r?= =?utf-8?q?2J1FDSoCdnq1rOwB+M2WEp6g5m7+/m4ce14Qk6kgWctO2LJSA0nlRbUyk7Qa7ekC/?= =?utf-8?q?V/x4pbiZy46uMub/5VZdZzQjXNYaf8RER2HaMQv4fozT6vx3jihYiQwFDVavHYs0X?= =?utf-8?q?P8+VAkQaeetgpOmdwKzuaRbKhBSE0Z8fe9OATlrISopfY594ZpyamfnFCyb6RjXlm?= =?utf-8?q?5nYi84xi8X0spSWEUdLXvQBOiUDD1st3vNJvDRLtSetNM4AzMStJKmQW5oq2ZvMTw?= =?utf-8?q?iI3jP2HsmbgnnQv0aFgd3+erciGBhrPzMYAnoRqpbo5raaRBdBl1h94qQGx2AS3u4?= =?utf-8?q?TmzLGT/ytpDp0BCJw6pa8qKKv0HeFL8nrnb+xoPhhC3H/pr4ayJf9oebsCt9v3Hjp?= =?utf-8?q?YqOAe3EV02x8vBJ8xLxW15FzCAaZp26Zr5bSCeTMxEuceEvMcCgbOIJyymK5mM58Z?= =?utf-8?q?DP7hxMXlG6dx0VLtAE/iVlMYnar4eUbwvJS/yZYHa4kL6K3r2slh2HsGpnvVhBKMc?= =?utf-8?q?/3Ti8KW2G/f2R7KTYH+4AxP2kRTg/bLOEyRZw1QdlcKNJnnXwdvx2hVez/42x7unG?= =?utf-8?q?TwxwwppjiqSQFRBtLDaDG2hONiI1nD4+t2vAISX/7PLDDV+Vj1Wf5Mnfzl00xlqhN?= =?utf-8?q?m5R4OKlZAU75sXa6a6JL6G6dNIFxb/VQQfKj+TsVPGn93IyK3FeAlDgNIbhHkvMS3?= =?utf-8?q?Hl3rx3HG9AnB?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: b78077ad-7320-4ac1-f21d-08db8d8d042a X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:01:40.4205 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Hp379q+pZabz9riJk6/T+/h2FM0Dzxl04AWv0xYDgFVkj6qTFv94wwhfx4Qe2P3tVeDiiaTO1EvcchYRNUZInw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB3934 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/mxs-mmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c index 8c3655d3be96..9abfb169464b 100644 --- a/drivers/mmc/host/mxs-mmc.c +++ b/drivers/mmc/host/mxs-mmc.c @@ -674,7 +674,7 @@ static int mxs_mmc_probe(struct platform_device *pdev) return ret; } -static int mxs_mmc_remove(struct platform_device *pdev) +static void mxs_mmc_remove(struct platform_device *pdev) { struct mmc_host *mmc = platform_get_drvdata(pdev); struct mxs_mmc_host *host = mmc_priv(mmc); @@ -688,8 +688,6 @@ static int mxs_mmc_remove(struct platform_device *pdev) clk_disable_unprepare(ssp->clk); mmc_free_host(mmc); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -717,7 +715,7 @@ static SIMPLE_DEV_PM_OPS(mxs_mmc_pm_ops, mxs_mmc_suspend, mxs_mmc_resume); static struct platform_driver mxs_mmc_driver = { .probe = mxs_mmc_probe, - .remove = mxs_mmc_remove, + .remove_new = mxs_mmc_remove, .driver = { .name = DRIVER_NAME, .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Wed Jul 26 04:00:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706837 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DF33C001DC for ; Wed, 26 Jul 2023 04:06:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231686AbjGZEGd (ORCPT ); Wed, 26 Jul 2023 00:06:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56726 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231690AbjGZEFh (ORCPT ); Wed, 26 Jul 2023 00:05:37 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2120.outbound.protection.outlook.com [40.107.117.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8FBB2D65; Tue, 25 Jul 2023 21:03:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gqcVB9J5OazVS1JxNg4p/2D90npr7aEIf9dh3+jYMeO+dpYQ734jkizbk11nWVkUijMo2zKzh2iqDMDvsduXEMvWUcsVieynRKP3azrvzaplyTlh6roQGAFY9kAGmvBWRHogpN6ETXywgRHWuczZp8SB+fe/uk23u2PdsjXMUHs1d9YlVpae/ydlscwb6FNOIrKFqXUue6DpE0T9Gme8J8hvDcL5CCzwc7fr2V9xg9zqEDQIMSCRmfNpmVd92r1uzvTkCFPPwCMhtUqilDFg/zlcYCn8tgiMxkVIYpd9P/hsuVttMtrebYPpZ74IxyyrwPcstLK07F7JGSBqNe2puw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/1Zc+RUhord8kJyLZmU9Nv573/MVj8Cm1en61bIyoSc=; b=bgktIhcQ6oWFp/nYRYI1n9IiBb03nut410hIWSg+jyAYIjrRlBj5EbJBMizKH+M5MTbQiz/KPGH4q2L6x2bIPrhlurdJnGt3N1VOn72RQfXnDXS9kmg/RunJ6T0xkuIqL0070TqtGhsmu7A1aMfdSpSjgxeqkiokrghYvPUzp5ESs3GpkQCltjL2qYh+gt5DXDggtqv1kCicuh3RqMNmVp0omgH1IeMUfjKMBmomqy9sv0Sg4/uccWbSfyTOOdtfJnkXE10vBq5JTRX3QyCqcJxNIxzLGUDKgvRpxq43TiLjW322kKuHK7qrjtgCtRQxo+N553pjbxS9/HBFgvUPeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/1Zc+RUhord8kJyLZmU9Nv573/MVj8Cm1en61bIyoSc=; b=ZA6RIM9gZAV4BxvQKco5IcZRSi1L90XfA8A0+c3H3sa9tf+sLExfEt8trYRTx4ccKhONKvxD+q/Pg9BXzRto+Fn9q2citbeFK42obDIhBCs/tc2Gn7ypbctcp1mlW93ViDzWSNKLIy+BrcDBMuUwwrn4TznwDzEzeICPKh8GdupMdwHX1iP58GUKG/OsFpABx+n3wEW8GRma7Bq8ZdJdR2E2GyIKxFNnTVIr0KZhC5qUYytgbGerLK/o6XxSTL9jby4RsQlzTGFj8yAgXktj/wzIbjSbd9iwq3Kuly7y6FlhN5eiyG3obILs/cPAW6iTEPSKKRBELBJEijvup/ZmNA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYZPR06MB3934.apcprd06.prod.outlook.com (2603:1096:400:7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Wed, 26 Jul 2023 04:01:43 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:01:43 +0000 From: Yangtao Li To: Adrian Hunter , Michal Simek , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 26/61] mmc: sdhci-of-arasan: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:06 +0800 Message-Id: <20230726040041.26267-26-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYZPR06MB3934:EE_ X-MS-Office365-Filtering-Correlation-Id: 5219fafe-634a-4528-c71c-08db8d8d05fb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gtZwPbC0uOD9dXWAZmeSy4Io4fuFx9JvI8qgxlF9eEGH3PFTLv96gS/OjXKA5yY+hzz3KArhgzGyLPzlemC6pLdHmyp8OxOJL8t2bbKZYODENw8bAVlQytmlpywJxw8lWnHun9MwY0GWnqeEH5DMXddOWLaP4jRYHGd4KzMK8lGYQJA9uxKO/fzZgG/bigXZB8u4mzHVt5n2Lp8/R9tR4NuuuWGFbw9lvCX5C7cgSrpvQMUWcOMAG7hc9Ulhgg9fNeHfycrMqGXIFX8uwo0CJmkEuy5XhDNmL8+c57+hbd5WyAJT2XhtSg4qyU8+5wdJ0yuQWeFHkVuZwIAWvVcMiti1aIWn2v/SPFToanHhSabztKyBRmcuWkhNLLkxyA8mIyyajvaHllJE+/IuFfkPICI9bgq/Qt2XM61iPF3FPUvKUWzNfCRYrSfw40WYpbvvqKxrEeV/SFum6T0oG45HoRoDUCCjFdm7fNd833/alGgoLSbKuaN20MFoTTMvc8VF69p9AzOEJZwTNa+9M7XAU1decS4GNoQw5XJRjlJu8jebIycYKS/1vFUuIoA13c4Oy5n53W+OuN9pNoN8FEVho38CvUBL13ohnW8ACYhhp199SWpgtw5ZyICjYlFjrNYR X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(396003)(346002)(39860400002)(366004)(136003)(451199021)(66946007)(66556008)(83380400001)(2616005)(41300700001)(38100700002)(38350700002)(86362001)(36756003)(8936002)(8676002)(5660300002)(478600001)(110136005)(6486002)(52116002)(54906003)(66476007)(316002)(4326008)(6666004)(2906002)(6512007)(1076003)(186003)(26005)(6506007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?nDJrmOoZus4XvIa+2Gu9u6tN8i87?= =?utf-8?q?Yp9ynhUg0fpQLVXhwrdTgiFDZ2h9iQBJBWcYu8IkBRUiP4XdCAOyQw3IIJ/DLKHaI?= =?utf-8?q?c+yi+N3WAWMgHXZ66i39+4598dqCs6hKKBxlHpgrw/ujtQ7X2ims9NtrqXMjnbA7C?= =?utf-8?q?IHv55DTHtKf46HeJU8V+Ke4TukrVY6pYAv0SZjetGY5aNc0jxN/Q557Rl15NQTT9T?= =?utf-8?q?7fc+P0R1qblZwW6K1BqTZOPjkLpb77+Ak2N2c2ZRMrf2elwcKtJ9zWe4vFOOzdJ8Z?= =?utf-8?q?hpk2cljqTTYI0ocUaVIpWI8UoDRyPKqLk2dHkGfWEuEhF+3T0CGEU+9NyrhEMAUts?= =?utf-8?q?ZG/A/ObLm+pPh4xygHG0tDck7njh4JvNx+waToZPb0I0Ld05iVO0vcACeUWQw0EoQ?= =?utf-8?q?tRR/Kv4RedxSswHxNFwB45kAljrYZaBExO6l16dXkmHR7hDqhhrwUo9hvawEOwmMr?= =?utf-8?q?d+pmu0lJjpIi0145OVCeku11w5NsKiEKKcvVut1NvGAErfUGQ0liLmucAd517/q01?= =?utf-8?q?05HGX0Lba3vlMSG3uTEmO/hdYM7BKq5QcpJRM1HRYjLkBfSnvfqeNgrcNpr7uXcEX?= =?utf-8?q?FbMSjQJtjo7sMRUBfa1SGlJT9TnwQj7OAfGRg2edmfYu8bpNqaX18abT76YiXqZA2?= =?utf-8?q?Kynuztyn9uJ3F+gtHvHxhP+Zati1hssxy9nJN+LgGQiE75gcSJCvEraALXoiT0AQi?= =?utf-8?q?gscmWHSdqwL1BxSmoN6kZQKLA+g7Q5ZtklFuJNl1O3P/YghVnv2LBfcVFpRTjwwcY?= =?utf-8?q?53kSLenO2BJJkQ/7wxuFGjpf48kY0px65BVJF69+Na8Qxif9smwatc+/vKHEm3/PK?= =?utf-8?q?4QqPBGEAbJecRYEGf/DftNrH+msRptU0wNnlYpSmqe4OfPMLCpkDk8g2weeSCM1yO?= =?utf-8?q?LQe3OWxo+hU5PThIEpcdwPzB1/kxHTy7pmb1Le4djxVSZupzBlR/JOl+2m1M7iPXe?= =?utf-8?q?XC+pUBmJpcn5Nvv/0azbNPFTSHbLS5QAUZKs3zhx/UHz7UIs88RAwVXnenC7lEALR?= =?utf-8?q?nqtYYgI9NSVxDtkpo9fInLSak38GlIZTkJX7xJg3yCaTP71Yxl59rxB3J+Vjydhes?= =?utf-8?q?uwAOpAtaQ0ueHaCs16XtcHEZ4KR7xjjIgLZDzInZTFs9FsjNldp7AfP7845huWXsE?= =?utf-8?q?cgNyQynjfbEMvUy307kWz/h248d6P/pmWx3pgRIRoE96c7IcBwq/UEbdlcoKtiGSl?= =?utf-8?q?xP2Mk4BnyA11uDfJXD4xqg+QZjRnKkNs32/Zfg8KTVRw2KjZ/eoWuIyHjGajRZHSy?= =?utf-8?q?pJdkaVFQ73QA2c6sZQF1zTuTFrTGbBd8RSZ/9WhK/TjAotB0lkbuIwWYenVD8R3iU?= =?utf-8?q?WFt5HgIaFX/rQF/R7KYtSReLL+F47ZQf52Q554Rzwfg2IgFvs8xE5/W8zQKPxaRqz?= =?utf-8?q?BryJUe3oXwRvHgCIOwZ12B9zxtpodkr2Jexy+pS5Gfnna1EIA5cbxGlY9F3TjmY0G?= =?utf-8?q?ejI25+G5UJdvs9S6QpRLVY1IihlqBQBLcS4kRN/JTSeLvKhe7FDXjT3qDIT4vJpVy?= =?utf-8?q?LqBQJn4lmV4b?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5219fafe-634a-4528-c71c-08db8d8d05fb X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:01:43.4530 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FWsJ7rjL4jYgswUzvuPBRUxBqcMVlqz5IdBlw9pEDZpsM8Rlou93jzNG4u0ogAZQsGcoZR8WBJ2eg9U30YdbxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB3934 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/sdhci-of-arasan.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index 294dd605fd2b..160bab0c437c 100644 --- a/drivers/mmc/host/sdhci-of-arasan.c +++ b/drivers/mmc/host/sdhci-of-arasan.c @@ -2016,7 +2016,7 @@ static int sdhci_arasan_probe(struct platform_device *pdev) return ret; } -static int sdhci_arasan_remove(struct platform_device *pdev) +static void sdhci_arasan_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); @@ -2034,8 +2034,6 @@ static int sdhci_arasan_remove(struct platform_device *pdev) sdhci_pltfm_unregister(pdev); clk_disable_unprepare(clk_ahb); - - return 0; } static struct platform_driver sdhci_arasan_driver = { @@ -2046,7 +2044,7 @@ static struct platform_driver sdhci_arasan_driver = { .pm = &sdhci_arasan_dev_pm_ops, }, .probe = sdhci_arasan_probe, - .remove = sdhci_arasan_remove, + .remove_new = sdhci_arasan_remove, }; module_platform_driver(sdhci_arasan_driver); From patchwork Wed Jul 26 04:00:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706836 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DF7AC001DC for ; Wed, 26 Jul 2023 04:07:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231484AbjGZEHB (ORCPT ); Wed, 26 Jul 2023 00:07:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229778AbjGZEGU (ORCPT ); Wed, 26 Jul 2023 00:06:20 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2131.outbound.protection.outlook.com [40.107.117.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FB1849F6; Tue, 25 Jul 2023 21:03:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bWoaSlAVcgObvVTnCHlYciWuFsyftkiaMdMgPrNZx+yJGi2l6D5jAi3PrMl6oAcMhVsphPoc7s/GbTY/Dg5o0jZQXz3GcZAoZW8cbz6WNndXiAzEDXspQHLg4HF/BdSp/pHbe/QdofW6DtWHB6gjwkni8wqMwN6TFNXkSWFDm7ctmarQO2+mfqOduxrqbWJiZnfIaU056F8etBc1Hqrr8OxnrPBgDvIgw0z+pcJP9VgYp8vLc7TuyBu1I1CcMXvkGoanVbgEkTgi+lvYHWaMjNjLOa6ZTDdPHTwJClMMu8Gi68Yk93lNSVnp6cUTFowIA7eRbfWIO/j7+6KYuXj1dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SpY6vRX9+fV+aGIzDgKV7CSAOZ5ZunmmE0jQlRuvPxo=; b=Zm+IluGQ8gmKJ7fkjXNQV8KQPbm5YHis121TbIgOcC33qNkbru3f9HXcNNN2d73cEm9VQ7uOHs/6Sa5NJpdKqVMveb0ifS7h6reJNeSFl81I/15TFfLpr9e4AjpNe9rJWJVt8YHfmIXV86N1GoH2N8eyQeVrAVnIXnmxtcA+nZ5kckUTeiFoiQef5029o0LhyF+JSNTuVXJyqvkSnI/guXeEK1ejcshzTr4b7N1w7/MinP6OOK+ho1NQRCalZrYFc0Vu82d7PzUB+DMHRZsEqXST6YebR+L0NRGhXEw0cij8AXbxPy1Ax0SPmr9najdvsEg78QdiGyml4SyjqMPL4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SpY6vRX9+fV+aGIzDgKV7CSAOZ5ZunmmE0jQlRuvPxo=; b=Kcs9Hb2E9wiiiyQK0VrVF+Z+XTMWUtEQRP5CdaiFmvm4v5cK1WkAgX0lZ8zfN4uHDxJWd47OlniWWdTTMlnCxAPeYMM6DuwiNkmLI822LdKvAOLOPSFXnxQWlOaNopne+kuAGz7X9NSxtwEKosBLH9CDuzTFgPXiyz4E68344s/Vo29LM5xEbOLg7ooapOYMfJujfpv8f74p85+t1WkZ7rNNV/GPmw1zoAuQkd664ZJ/cH+LequSYTMYxojk//1mLBJrlyY4+6TmjH8zSL2H5jtxU7TVLgFPNUr57yImGbh4lw9PuCfzZOS0Uuy1o8xN6CnDAmqBqw1NJuDG8GhMfQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYZPR06MB3934.apcprd06.prod.outlook.com (2603:1096:400:7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Wed, 26 Jul 2023 04:01:44 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:01:44 +0000 From: Yangtao Li To: Adrian Hunter , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 27/61] mmc: sdhci-of-dwcmshc: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:07 +0800 Message-Id: <20230726040041.26267-27-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYZPR06MB3934:EE_ X-MS-Office365-Filtering-Correlation-Id: 0de16ae8-35d6-446e-ee79-08db8d8d06cf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: awX8Ert1yVo77p9waaq10jzd1wLV5XCgt1mN2JWBJ5fj/QxS6HtvOF7VM+gYqlYSV1yDENGFc+5dntp+xNqg7T6doWz4l1h+0kR+ucIn4eqWkXGBo4tNn/1Wz2O7HCNnIzvIxoGBoEJ9U5NVXIaz3Vf6qEwLKmx4dOSINMcR+l3Uz0iv0FCCiaE1QBb8AyAoZn8j0tKz+fb/MRI0dXCnFdW17O8j3V8AIXmZAqdaQOHaHMQKA1je6PUHTFOn5aQQqJNNTZJKprvsP7KRCxRw2dApPqdV/jb/HYwPCiJuZr59NgqSfD4C1Kmsn3JbkiNWQhiTcFgL6RYefYEp3ztPIKfo+EHt8Y1LghYgRU4mhxdiuYiqbal4qYegWNOkNuiLkWDOHMSov8jVH/jPpH6RBG/x1DKcjzTRZGscfYMQgQnxnGoo5nfxO100HB4rtQrWYLUgXO282xAYuCGoQvvU2KcA2xkupCRqTFzSPt66HIogz/0UK+ft7i4aJuQkmELzmkHEu4yb0DWo+LKyWd3jzr3l9duHJfHKmvDmFyWfyCf0AGZa7bxPpIduq10Q1iZr7OOHjXDUHE9gATCwhgJ2dtrxLBrOGw575NSGt9a7WuIfK6ymsmO3OsC0Nn1RLz3/o7Vs6+tygFN1lcrxItq07Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(396003)(346002)(39860400002)(366004)(136003)(451199021)(66946007)(66556008)(83380400001)(2616005)(41300700001)(38100700002)(38350700002)(86362001)(36756003)(8936002)(8676002)(5660300002)(478600001)(110136005)(6486002)(52116002)(54906003)(66476007)(316002)(4326008)(6666004)(2906002)(6512007)(1076003)(186003)(26005)(6506007)(133343001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?4YLERURMgPletYkVUbvxqO+AWTOP?= =?utf-8?q?RO9pzvJFR+9efqAphojv+dsZ6yiSAnvDfmmAk/Iap/iefgvw/9LZ0Wj56QjnXe7h0?= =?utf-8?q?cy/4LvxWjUDMosU54m7K58bNovJA4SVoHTegNVvvMWqkXSD1IgU/olabSx1OYVuqB?= =?utf-8?q?9Rg6g9EL+WwBYNbV3j0ffaHCfdXNNEHCZlcEBNL1ZkfAaC997DIcjYVxc/A+yArDK?= =?utf-8?q?oeeXPRJUN9v0wxXkfmNIs3kl2WcWBCM4FwCUjKAPAqElhIqLzjXH73iyfoeJwY9QS?= =?utf-8?q?zp/VZr6zRWbFBnETuhSTjzVzHq2DIFlbQnS66ckzYcA8JEM/p4zrJJfbHVxggKCWn?= =?utf-8?q?kisYNQq8GwNQuK4MnKckdvEHw5qTJFInpp0MOb0mcmH8EvUNFmDJdl0RQgx6Fz5PE?= =?utf-8?q?vDct4iXRuR4LwgbobFByZ2ewDa72qoQxuS1NbwhECOUqipkNFOeBQYWG2+f3W+uUC?= =?utf-8?q?W4+gclb+pXwmRZY6dsm6NLrDEcEj61EbhB0AehlvPpe4VTqOlLcc0I1+6feLu1vyW?= =?utf-8?q?IdY8C8tobzn9O2MUElgmtuEXi3vjumi4eEefSE/kIt/R84vJlawBhLdC8rimBkxq9?= =?utf-8?q?z8daaToFk2kgV6DX0qtJ9Bc2cia581gZ1vs+9ZC/R8/QzD/V7+F10gPxlnn42yfog?= =?utf-8?q?6MKZjyGzTR0fp982+9rtMf692ILI07ZR/GNA4XErA1inD8gEJ3IagDTvD9YPMJbNc?= =?utf-8?q?j1wX8arS8LGdaIUiXNrBYYF1zLMdQmTntWSBrheIcW4ddNz+vbNSvctilFNUpPPi2?= =?utf-8?q?lXXlaTbs95nh1Iq1ACbDlbHAX/tZrVnuJ3608kx/5XoQ0vuEAcUsl/LHXmJCAjnPt?= =?utf-8?q?GduL5atNh3cPMf4nB7ochacQPl8OgB7D/h2AcZc0+9HwoZGICM67RjlSZcsi6ynBj?= =?utf-8?q?rkyn2Iw/LCaBNgzfUe8j6s08bD0kZa4KhOIXENyeHTL1U+o1iCzhBw1bCpcOEYFVr?= =?utf-8?q?FV1vlpcJRBG1Q9vjHQ5ETOWN6rmv6i8y2KnMvumhX/vT8Q5zWtCK0d7Bk/sqI7IRB?= =?utf-8?q?SRZB1xkytKJGIYM4owupvbh11JJ9q87BnRWl65ffj7U2cr7uHNIbsWDW2ptIu50wr?= =?utf-8?q?Y5ChtsK0dR9/aRlgVu7eLyqpuB3gFvXsxMQIOO0P6aKfWN+psguhLHJYcWCCfYk7L?= =?utf-8?q?LejiXGJZfrMq28okGbU9o/PLm2KsPUt69LiRHkbjg+lWApTy7PyCrw4a3Sk7tguDP?= =?utf-8?q?0q280PMVPGDXP4Z/Pm0hAJqN7MBwf+GxPTriD6004V5CKX0lYXdBT627Koy6wcoer?= =?utf-8?q?5fA1YLBSHb2pPegHVQlWfzqqKfyPLMEc+EIS0avVbAIV84H6VFMPrICmpdqLOM4LA?= =?utf-8?q?XYCvAL112kbOp+735lIMX/Q+9sPdFu13A6xAguUK2NCz0CCo0xWGVt5YEz43G2iwD?= =?utf-8?q?badz2hjk4NwZa2oZYMS3OOoZccnLItcvOcoIox4xVZj+I8N83e04KHtvqQBgaz6jF?= =?utf-8?q?mxA8+Ad7fCsKzdACp7PCpnchLbCNsslGYNAVk3r9Uhdy9QaT/NXi41fXYecWa2QqJ?= =?utf-8?q?D1v3GPIfPJD9?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0de16ae8-35d6-446e-ee79-08db8d8d06cf X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:01:44.8783 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vdcvNDIJbxBNL9icY999IUoxSkg+nEoD9jGlQyjhZgoNesTKHxcfEorTapCfon9pknBhzNHhGB4BX9NPMIvDlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB3934 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/sdhci-of-dwcmshc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c index e68cd87998c8..5cfd24cd33fc 100644 --- a/drivers/mmc/host/sdhci-of-dwcmshc.c +++ b/drivers/mmc/host/sdhci-of-dwcmshc.c @@ -574,7 +574,7 @@ static int dwcmshc_probe(struct platform_device *pdev) return err; } -static int dwcmshc_remove(struct platform_device *pdev) +static void dwcmshc_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); @@ -589,8 +589,6 @@ static int dwcmshc_remove(struct platform_device *pdev) clk_bulk_disable_unprepare(RK35xx_MAX_CLKS, rk_priv->rockchip_clks); sdhci_pltfm_free(pdev); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -657,7 +655,7 @@ static struct platform_driver sdhci_dwcmshc_driver = { .pm = &dwcmshc_pmops, }, .probe = dwcmshc_probe, - .remove = dwcmshc_remove, + .remove_new = dwcmshc_remove, }; module_platform_driver(sdhci_dwcmshc_driver); From patchwork Wed Jul 26 04:00:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706822 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACFB2C001DC for ; Wed, 26 Jul 2023 04:13:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229573AbjGZENa (ORCPT ); Wed, 26 Jul 2023 00:13:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229969AbjGZEMf (ORCPT ); Wed, 26 Jul 2023 00:12:35 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on20715.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::715]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E979049DF; Tue, 25 Jul 2023 21:06:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G4V/6frPZcW4FMjoVNkOcaspGo+swmq2yx0C1PyQsr1vJecn+L1Bqt+GK8DADH2GnopsNO0d6OkKjDRqW+nqIQahoPl9Rr8A0cYQmnhK7BumCG9QMj29g1/65hdeaU9VTlXge0QfnBq8fV79OawtHnLCgBAmuCLtblboYv9T+SJ89jGCGcxDDD3W4uEu/V1kYh909ZsCH1/3wiTYknXm4/vfynfmAApzqo2P3w/crFk80mfCc1d5I4YDYqJYLKUHG1PL9pEyVBAQFbnK0Yitba7emlGdU+Ltc6uVnu6a2wij4lxBwb4Cr1eo/qUjIUQv3r/bZ3aviXMBoW6HsT50PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uMtEtYh4yggL3P4Ktr/c7Zr9RRKQR6LhGA6gTsORCp0=; b=AnKPJhoVozAzcWi8YwnS6XpJOWXaUUGiesAZtgULDHQhmjM1S7KSWrDr0R93oX3AQpJG8s4cDwvPcUKALxV870v061aus2RPFy46eTHwInpCHQVDwn9AymyzpXsPoR55ss/6qr6kJ9ysrLNn9hKl4frp5aWm0uHTJ17NLGMXlKL3DO5sMgBAdiK+2Ymk1P0ATCz5VBEoyt+Z/EE26yiym43gqMhhhRBzTr1M9jbPlUhl3xdT38c8NZ6x3LFbReLej5KBvzY842/LJrUnxN+y3fmMbzR7lIYAAaOH6A8yEIGkYW2OVEqsLG+RYPY338yWkLJXMzZgL0nMWOb+DlD8sQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uMtEtYh4yggL3P4Ktr/c7Zr9RRKQR6LhGA6gTsORCp0=; b=ojocoCYpCeQjEArK5y0HDcpzsvhgA5hjZkQN2/9NDbl7IUVbgsoZxI7kItuaOlIv0ZyAn7/ZkM+9jTxQAKKL4JNTDLuQj4b7pEmc57cJjaf2BjMIGuGwxDZ4mIwqgjohXKY/QyH3urFLpssNUdwVvx927ExZtWmKnbQ0QNc8GDk65AQqGjO27EmugHuD5kxeGtjN4gpVi/Rj36Cp1Z09dwBFggSmDtXlLL6DqzC+FPLZc4Qk+4vc78W1pxQXheqongN7uOBIG1DfNiZnz7TK919VLyeKvn/r9ttxwKqYWFycxoK8ViYfKZMIu18j5aqkSqQyPfd89xn5EfFHisdc2A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB5463.apcprd06.prod.outlook.com (2603:1096:820:c3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.25; Wed, 26 Jul 2023 04:02:24 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:02:23 +0000 From: Yangtao Li To: Ulf Hansson , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 35/61] mmc: meson-mx-sdio: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:15 +0800 Message-Id: <20230726040041.26267-35-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB5463:EE_ X-MS-Office365-Filtering-Correlation-Id: 37aa22ff-92ae-443f-fe98-08db8d8d0f41 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hbam9d6l7XOUl6ysMZwFRiRuBIQrhp5a3KR48jAH9K3EmiJxMoJbgYw6NPErsVz/HNBRztQXh7LYY4WlcfTB3BBJxL+JRIh+eIw1zdOI+ZgHECtDIGqNHnwMlRr+xYkTYag67zaUcxDPeftyJfp22B1rai1AwEYnZU2w0EK7GtBgxKMoXhimyMegTRQFoqa4zG+oLMvsgcltasoLf0XoLu1r51JKt/PFX3bngBNbDQ7q9CXGHrMahh8MRMoxy1VRQBI4Qwmdn3j7Qc0rYzGN2UhuYxblhyVTVCP7bU+ak7OQdmGLUpPckFP0pMHzS13/v018ODWAFjiXWD3MAtypeasHitKXEhoyFwv+QcViuSsTHXeqZ+2ZMe8roGBDBYygcPlBAZoMfnXVlqu737M8QfNwxn8kpSTVWF32iFAcRtvfNbRa4VLtneETTLcVbdB2VV2nJLNpR44DEBEEz9mahZbjBJhblCiIOTznH0Mmyje9TVdcJV0VeIkFFi7Vh4IIC1ZRzY/EfxIjPjP1TSifLqYxWuabxV/+IqPxTVHBNdym8TOtQSt1oqfdDJNNMbossmUoyhVXNU7aer/eGSqIohd/FtwSpBU6ZY23EMhSZ1Y+0Qv9cPlFHyaiP008w0LM X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(110136005)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(6666004)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(6506007)(26005)(1076003)(86362001)(7416002)(2906002)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?TmtXT/OpHK1C3V3Z4AtFZdOMPCEv?= =?utf-8?q?VETqMQAXRwL9k0+X+Nnz1ZVEJ9+djEwT9xlPD+AyULQnWcKtX4uyQuRQp/vNHLMqT?= =?utf-8?q?hIyPWOhwBzA+nrWAr5xHiN2So8EPen/1+pJxzjuw8Q24BladFp5fyl1B+KESWpruW?= =?utf-8?q?tL425YN6Qv6R3obM7csDLhgzBVJuGoGOzlZYw4BSutO7IekKgTd0jEL30Au+qjW73?= =?utf-8?q?2hMGbjl4hR4MY6UkI/hAkUsvcf+cb6Gh4t2QaOmRYbnKzi+jWJGcmqEczaIQNkGuI?= =?utf-8?q?kdrUnrKXpq7JwKkfDMJ+/kXRNxvo1y4LBocEemJtj48/mst4sC0x1dwlGSE1CC+Tc?= =?utf-8?q?fQ7kwwa0RoJnffgVM+mjU9XycWtupB+7knEtflKk+PiYRIy2/oHUzKhGbLxyQdgIn?= =?utf-8?q?Di1OeCsQY300ekye7yCpOdFp9QUQASW5CCm8nJcEYAaDNkwbl75gOId6QLb2hPB7Z?= =?utf-8?q?2sUKm5TObpuq3lMcgBdWuRYVJC11PLhu152/tudP6iG2pswjEkb2TM/BC1KKXIaDx?= =?utf-8?q?mLzzbQyg1B1fTA4UPUmFKzOS9UjOAsjbJJtcTh8TgonrEchThMX6TbuLObiuex1wS?= =?utf-8?q?7uRwpIwus/b9Iva+6duLjfSOuC7xM6cvetYVNAi+KbWxq8aQlfkFp/JxgDJ6/6UTr?= =?utf-8?q?DdjZxMHfx90NO5S+i4FJ0o+DuUxJDXYeC0OUNWKUDLMr5EvEk/LBTZXY00R6n7J2h?= =?utf-8?q?2+mwdpKAOMatlxIEdhsaXWW3kUAoe7VOjh50HBWrf/07idLktyKrHoLe34xHbz83A?= =?utf-8?q?YEwaC8cP/9JQaHhXvp5d29V7a+HavOeXG3i4W0Rngfazp+2qxCoSfeHC/henyzIXl?= =?utf-8?q?97Rkc2jXATcHQJWnXXbu1+/K42KbCVohqgdBZJlCr7eJ8kb0IWJAZ+OSrR3nrRaNv?= =?utf-8?q?8pEdnYP10hPoJvrKYtuEp7ovTmBakMtPvT+Cxjwu20fdeHotqiFrdAHI4L3PisXhr?= =?utf-8?q?7r8/rE+sC3bh4Zb7Q9nc7r7OlkzB0ckt+IzUgw7ZWIJ/TEmU/q9pW2EBZqJgNBv8d?= =?utf-8?q?8Qs2D2nHNWDS81pgbyJwOM+mYf96yuCHx34zP7x4odiI8+hYIMljb6Sq4rU5nDeNa?= =?utf-8?q?QAxu++5J2S+8t33HQQYOEmXuC28x6zlIhOOfJgFp+Pv/ZEioq8rxMeFh8wlbEARTZ?= =?utf-8?q?E2I1OVhcnaNmZEL4TkGoNLO2tmI3jXGdTMWyQGsWfYgrTQv7coCHTzOwIApAIztq1?= =?utf-8?q?NxwEmuemqbk7J+gLxUE+0R6vffnfU9I8pftD5iFzTuvpsJC3ZhP1iczTAnXbw+/w4?= =?utf-8?q?TYAEKgPaoB+mn7ICV1zcPsr2u01xyZVUrjsZJeNMRwYVR9f7RZpqUeOepkW+vG9BD?= =?utf-8?q?SZIo8y+Cz4IZT5w0+u7VsD/7HyTYLwEOL18pz1noKt/OfLWOGck2b6zm0QnSyB3Bn?= =?utf-8?q?qrqxbX13fV9RJ0j1LNDhXtr7lGuq5bdVs2B88DIA65Jzdi0d0zchtsW9vMcWu2hkf?= =?utf-8?q?nh1QukGAI06EtWCnyvPGH8enHGwBVS0GeAEZZzJj/2MPrDfEIt4DrmcXoAVyf0NTh?= =?utf-8?q?hGdVWfMQ+9GE?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37aa22ff-92ae-443f-fe98-08db8d8d0f41 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:01:59.0234 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gFemOGYolw1aPGhILnq6p4rZNgOP0Z6aEg4Nq0ti/T4ZjmBobImDKiWslG1s24MVNHROCJriwy04TNRn7mp+ow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB5463 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/meson-mx-sdio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/meson-mx-sdio.c b/drivers/mmc/host/meson-mx-sdio.c index 3a19a05ef55a..a11577f2ee69 100644 --- a/drivers/mmc/host/meson-mx-sdio.c +++ b/drivers/mmc/host/meson-mx-sdio.c @@ -728,7 +728,7 @@ static int meson_mx_mmc_probe(struct platform_device *pdev) return ret; } -static int meson_mx_mmc_remove(struct platform_device *pdev) +static void meson_mx_mmc_remove(struct platform_device *pdev) { struct meson_mx_mmc_host *host = platform_get_drvdata(pdev); struct device *slot_dev = mmc_dev(host->mmc); @@ -743,8 +743,6 @@ static int meson_mx_mmc_remove(struct platform_device *pdev) clk_disable_unprepare(host->core_clk); mmc_free_host(host->mmc); - - return 0; } static const struct of_device_id meson_mx_mmc_of_match[] = { @@ -756,7 +754,7 @@ MODULE_DEVICE_TABLE(of, meson_mx_mmc_of_match); static struct platform_driver meson_mx_mmc_driver = { .probe = meson_mx_mmc_probe, - .remove = meson_mx_mmc_remove, + .remove_new = meson_mx_mmc_remove, .driver = { .name = "meson-mx-sdio", .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Wed Jul 26 04:00:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706833 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87ED1C001E0 for ; Wed, 26 Jul 2023 04:07:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231536AbjGZEHu (ORCPT ); Wed, 26 Jul 2023 00:07:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231230AbjGZEHI (ORCPT ); Wed, 26 Jul 2023 00:07:08 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on20705.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::705]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D69FE3ABF; Tue, 25 Jul 2023 21:04:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NBfZv26qTrnUb6ZTYT5/UDZwscYFtj5UOTzAfaYrj2QfvV5/rKHOOy5GXxp4xT5ycgtjhVnX1B4176ZOmfrlNNfrNIUOgbO1W1KSyZSjXOhxso17N2S0SLp040eljOMhnvjdqHJ21qBI7LDTINYNo5mbow2vPfFlkP8xGKQzmMHaiuM8qL4hm3v8PReMYQ2PZY+GZR/pS/Qv3sSoGGujyoE7e3COW4wbSfhaW5KEnOXBzMYz3NmnR41DfvjbGJSgllkv+ZlHrYFiyqSMlMeGk9UK2KO/ONTALNUokfM2S4YGQYA5xkHSELZl+cK/gq1S/49Jck/7Rck/JnzRoahWAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iRmZXFCwumSmLXQwjvRHThU5yBcyjcWZ8ZYYoqniSk8=; b=KEOU5Q+Yn97+iC41TJ46s00sMt2FHIWBJhU7xY8ja4vf2VTzeyyDMXcREKRCh0C9lwwvm9Dw/E6Fdu5cUWGbatqffDVnlvqc21u017otjhQpA3eM6ohtwJ+j4yFqE/39pV8Ii9yXzk/+OWtcri1/2CvNYvdvCidwXTCvXvql83AN+iOfuPh7zW2SksIRjJtA2k0sqUrkHdH+W/4d8il0AB2f61eITTdIWWGrINsq41hX2O/LyZAjboc3coTFguOpyiVQubjidqn7aCB1L3OnJapfvSWBkVjoc+NPMSDOMd0mV11FR7frJe1m8BetOxv4AwZNB7IrQ9pTKSqeQTf20Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iRmZXFCwumSmLXQwjvRHThU5yBcyjcWZ8ZYYoqniSk8=; b=OBRSfebgUVCAL2S1ZroyffWlKVIVzZmowf6GYbTgHZJfFbjNIGUyuFCKyt1+2C9jYsOsj+Di78HiMtaAakXPc+WcKlKFchqOyhKdZA0vdq221XO69Sf/ZWcSx+Gb1Syji1b8oLnEx2GfNXoPigj/g03Kgj6m78jquAxbXd1kHG/GIIj5U8jRL4G6UOiFhgQXoeoFKLGWVzl6I82YiDtjlmHInd/XA28771jdTxnCVuF1kv7huZn6IxFewLOL6QdqG8DkMgBA+Y4Y0RxEd18DTOoJouUq2+Feio6dugasnHn+CaR58IxS16xqqG/KEDm6hdnRzphM382h9bkGHpgFBQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SI2PR06MB5139.apcprd06.prod.outlook.com (2603:1096:4:1ae::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Wed, 26 Jul 2023 04:02:24 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:02:24 +0000 From: Yangtao Li To: Adrian Hunter , Ulf Hansson , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 36/61] mmc: sdhci-sprd: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:16 +0800 Message-Id: <20230726040041.26267-36-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SI2PR06MB5139:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b8482f6-4488-4ac7-5bc6-08db8d8d104f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PXbxExiTw5sQHN3z8cuhug2xFU8yhR7tfKN8eKADnhg1vb3nO/I+o/G7OnPdsz4KiI69vTy+CSQ6z2GFBUC1w+t37Vo7bi4OdBI2HeXDMVbE6jhuwjzkXseAZ8eUI6vvtCrMTuxfRRNOVmexio42uQ57q+gliQtgKkoGhIQinQNs4PzTwyBUcS3C3DcO1qhCFRqX1G0O+f2VyrjPoSworOK68gBoc+5BmLR1jMWtsIwORcvBvTTAKomza+PKlIhObe3M39im49+DQRaQVq1fdmeFKTPPMlEaD7nesGM/HWwGMdXz6ekweVx50pUqsUSpNuYpugyVtTm9/xdwduX0Z9YvF1PjonH4on/3iImADgLPAnBKw6Ikb5Lb0T0uKq9mrS+spk3fOeJU8oVf5T+VlvX2Pg00ID8yt7X54MaqHOG3dd5GBtSKiIV+LRQE6FZzsGwAYkPeggSVVYSPSf5KD7B8o/A9c16XPIl3vJieBfAx2+ttbpaRt9Pv+SfFQtck/+GHwWaCGH+53n9HpSXEb1ejp1p+jEUuuLvYXmxicTnZNMoKvuMWW34JrJoWEf5A/3QAUoADj+MWFxeElSzQkwOFIuvELeqooZQuk5kzEqx7pVjrEsf149y+ddnCJoBJ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(110136005)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(6666004)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(6506007)(26005)(1076003)(86362001)(2906002)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?3q10sAqSJZavq3Smu6kJ45XvzOie?= =?utf-8?q?x7v6WkZHnQbEQnQbGaIK6uJG9y+StAG3qG1vgvQ9qhaRTFwy8FU/dbeE1KcQWl0EW?= =?utf-8?q?6795BRMT+qWT5j8D6rPL50z/AhpIOvp12SrIU2ylr3HwXSRoesATIbH/Vj04Auu8n?= =?utf-8?q?U52yP5iT0hkDNibWGHQDPLKjXK0MxhtHZT3hu4dZaW0rI+5weCTJF9Mrqw1z7VGzt?= =?utf-8?q?r3c+CXfoh9UkPEPlXsfBJ3hVV5uOOOmZPmVE4vHplJ6bJRA+TL7CGc+kQIFt34hf9?= =?utf-8?q?Gl+L/4VOnUgeV9DR1nFUI7SxxuncOhxMBiXm+MRWa6rkHzBj3DpjsBG4V4jeTixly?= =?utf-8?q?fpT603pnLJ05BT7hZPhU/OjOhmPVrjWnWRTAu/X2lzXgvUg66Wv3CLvOSxu3i2We7?= =?utf-8?q?6f7f3R6h9PIXbYsw7CYPb6M8Coq8fnyVVIXNeV7/ktRqp+t+lsxutziCtmDLiDI8y?= =?utf-8?q?mJ/lWN0soabgGvQlYOXrBkqfhzR9ppuwGrOjZDnW8b86dBlWeMy27vnXgyFN7E+HD?= =?utf-8?q?nOx9e3iPVXWBkqSVcSmHVwbrvsHjZsQZrYpeV0OYE9aPb1F9ZfQRSjolmCwY+iJ4r?= =?utf-8?q?qXbCZS509XQOwsZPKIjOmJ6c6es2A7WeWGYcZCzwBbj5XHZHZWgCU3c70lkrHWvS3?= =?utf-8?q?D7MHowgoE8QEiq9TduA7TPcfURQvbNY5G2+T9LWl7YGhvpcH8QpuOJgwlmh/FWmgV?= =?utf-8?q?vKEZyqVDsY/bLgAEcpX9oIde39q7UXXHxvSnR5/c+cH6WhwIMI3sm9tREImHKE7cK?= =?utf-8?q?8001/FjRk3qK2VzdTY2xBUFM7utjB3+IFmqecMKzIA31sCs53DXEF4cb44857rp/a?= =?utf-8?q?jtR1hS5EE32u8kXXpxsqaoLiw3xBC3/paeD7ZIpfvgUokBDd1EkVWGfI2v3l/+lLD?= =?utf-8?q?4YPoy7MXnRdCt+oCgshv1cxyR+1dbEXpZC1TsdlTY2GmEmAP90GQNDUVz8kp0nNRi?= =?utf-8?q?6n+o1fsTgJmI3e2A9n9IIKGFqZEPRrrpLBdSNoM6oE0dsvqByocf9bFrHEbOLQbH7?= =?utf-8?q?G4JfB+bgCF2k9MQbAroTyaJgpkVkCxaXynzhlVQX8+9ocWKfKnEVcIx2HKY2D1uED?= =?utf-8?q?fWDcjtm3g3kTeRRbUEnJpcCkpguaV5pFxD6q2KIHIvSiNyiI5R6qy+C4aTp38BNZI?= =?utf-8?q?A2w9q/kTtq8eznzx7lbOXiOPXBmJRI3h2PcZhko7qFEZYF9NK469saS0N8JKsPesP?= =?utf-8?q?GmNAJCXPuoZlEhs2vkReY1yXCIPvR6hVp3ZLUjCOdkS0Z1Ug8rxtnbiK1R+apXQ+k?= =?utf-8?q?baPDr98B9CYgXaVUFiSzWvkzZXFvca5eSEiaimYNundInSOQJxDLCuPMQJnpoftLN?= =?utf-8?q?FBVdPhHKzyFzTS8TvRK4A4BIg+E5tnoTfpTJ1kR2YzqvzMmnjLZ8Byl+LmYwDPDQw?= =?utf-8?q?D1hY3zBN7MH8mBIw8thr5a0DtAbhIxWvsP1TRMrGZDASSmIKnXAtf21oQMzVsibb3?= =?utf-8?q?zxCMvCCP5h2K0XL4puJm2VPc93g2B+VDmsk171TEI/j5dhH2eZJIeTV2MJgXYlHXn?= =?utf-8?q?Md9va8/ALkAI?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b8482f6-4488-4ac7-5bc6-08db8d8d104f X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:02:00.8132 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IIY9JHLlas6scAZxPAzI+etjYm+i87hnS/qGS0wd9L9BuWHG7ZZzapYg5wzIKMp2+dV1ZE/ht8MtFHl9QOZwag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5139 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/sdhci-sprd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c index 7f4ee2e12735..379cb3892757 100644 --- a/drivers/mmc/host/sdhci-sprd.c +++ b/drivers/mmc/host/sdhci-sprd.c @@ -720,7 +720,7 @@ static int sdhci_sprd_probe(struct platform_device *pdev) return ret; } -static int sdhci_sprd_remove(struct platform_device *pdev) +static void sdhci_sprd_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct sdhci_sprd_host *sprd_host = TO_SPRD_HOST(host); @@ -732,8 +732,6 @@ static int sdhci_sprd_remove(struct platform_device *pdev) clk_disable_unprepare(sprd_host->clk_2x_enable); sdhci_pltfm_free(pdev); - - return 0; } static const struct of_device_id sdhci_sprd_of_match[] = { @@ -800,7 +798,7 @@ static const struct dev_pm_ops sdhci_sprd_pm_ops = { static struct platform_driver sdhci_sprd_driver = { .probe = sdhci_sprd_probe, - .remove = sdhci_sprd_remove, + .remove_new = sdhci_sprd_remove, .driver = { .name = "sdhci_sprd_r11", .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Wed Jul 26 04:00:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706834 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 101BAC001E0 for ; Wed, 26 Jul 2023 04:07:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230286AbjGZEH3 (ORCPT ); Wed, 26 Jul 2023 00:07:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231176AbjGZEGq (ORCPT ); Wed, 26 Jul 2023 00:06:46 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2070b.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::70b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F01635B7; Tue, 25 Jul 2023 21:03:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n+5TNHiqleWCIH/+9g/U7+ocgdnbvZCb+4tmCfkMalmEqUNuQ022LPdOsiseQ4wgY5MXgfoJwOQ6ybFD9FozD90WoeFlxUoa0o1d2BH0e+img+77tpSOunB9Y5VcEjA9KqbYRprYLTWHoVgjy1wb522Te9+oL8+4ltKH+5gjEKtL8qdB2hWRSMk43SURWk6kQ0CX2djgt+c9ctXoiN7WABpqr+1YQnEmmTDiPahiAxdGreOmCtvRaFkj2FeLNwLjsfQSGAdagCTTGYsjh1yEnwR14XhokIB4LL7rNy1LJrSlOcCiwGVT5bvyRGgVur7/9FkVV7EMOz60rDuC4cLTHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vyhbeNXUgBwkQepDAzaYajBffSTDYfSaQABURS0z/Nc=; b=SWX8e3QHPYzEBpXESt95y8xEs6WfsOI5cxTqs1erwlJbUHjbhMWLPNczWRO5jKD4yujQxm+pStjqUB2R5WA4WzBKJJiZqyZch2MXtKTuVKd5B15yU6KS2qUJMJE1NY3nBscRVq0TPdIZ50nYe1ktZhlsiNYup1Fzp5/XnyGlb5oAdmYcug6r8X3bxhjOPZGZulIGNJ3gYr/vq5qJTiVMZYubug4o7m1RbfJxJev58NUbhowMzP6ngUDg1RKcEfjol1qYRX2QUF1Lvr/L0QUatlsvvG5bPlrhExohLdqhX6cdER+s3zh4Yp9QuZTIFktcZH6m7AyvAvbKMTfF2EnvYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vyhbeNXUgBwkQepDAzaYajBffSTDYfSaQABURS0z/Nc=; b=K7qIgoDEYmQjHHv6rwMfmhvUY0Z6VNIJv4uc22BozO7YhRHl4ta4KWxgTI/pDUXoubJQ2ZEGcCtiisxjc4F9Sj5A+iBMPvbM60y3zcl0Q0j0i+pfVsiO/Bjz5zXTqqWB/I+XWOJ35AXnY1LtvgaDiUntjShGROVi8xBoEx5Ng6YGq7o9GRX2zNn05nZ+j7F2iEgGeOn8Qltu1ZKgpA79Ze3+/zc4WH3pyxeesVTR25YTYAuSSg/hZzy+8/Cmwaf7n9UfefAUNp4jsECKhrQxHh48pxSJrWa8IfQ3XSQILOIgJxfBi1rav15wg1STqw/82kSIUv6k/AVo8uH3ySLePQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SI2PR06MB5139.apcprd06.prod.outlook.com (2603:1096:4:1ae::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Wed, 26 Jul 2023 04:02:25 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:02:25 +0000 From: Yangtao Li To: Adrian Hunter , Ulf Hansson , Thierry Reding , Jonathan Hunter Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 37/61] mmc: sdhci-tegra: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:17 +0800 Message-Id: <20230726040041.26267-37-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SI2PR06MB5139:EE_ X-MS-Office365-Filtering-Correlation-Id: f4e702cd-3a7e-4bcd-1b5c-08db8d8d115f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ioyyv0vlWHmSbvE1dObAAe9sQe6zl3nXNC42xzl/A2afPKpI4t+28Sl9ce4vmtx+29w2w9jGiwYIS+C/a7ZgKDOChgyR6mIfKd4vs/Ox2lyPuS4O56Gs5mPaGbz9u8oErge9MbCet/UPp5OsBixD244YfnlEc2AFeiX0QP09VlayrR4Pra3aFqPTZPYcEYforpN/oNWnpcR3F5xiXzTU2/6RnD+kYlUcaFv5q3Gjr1FSPdvZ3gA0814H/5qDC8U4zpD06lKHrYLLB0W48YNl5MbFB/qywmjgSe/gG391Lhhc1ycO7orC9B8jmWlH9dy0zWF59RxvwLDFgoZxF6wkQKsED6sIixesySsgbWXpMSygFcuwoa77lGda+UczrgJDsYkywCnMhLi5+gmiRqJiIZefBNG3MMVtuK8eUXM9sPoDqduvdjcGE+rYbHQZ3VTEiXuiTnFwy4GkCBMC3bpccOymhw9kMuDETzBqawqVExiXiMWdzb6TUCzD9kWuzFivv8yW7cEudt1baz/KeFIZxx+rMTeYTK7Dss0da3WdGGB9flnM/mzLtcss3x8Q6J7/ZDnkivypV79Yk62WhVW5tGTalPprcI3XA5J/RqQPORmlivTMvj+QQmFrVoOD0RBO X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(110136005)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(6666004)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(66574015)(6506007)(26005)(1076003)(86362001)(2906002)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?BnyDN/EqmK0+f8J30l+eX9YBRnvi?= =?utf-8?q?7JQchMH0sNWq8WcJpGwePLSHbz4x94QOij9S8iJuKYoiVi03al7jEUGt8oPEi/ZOC?= =?utf-8?q?u7B5yD8x2I2CIBZ3zHD8bMLCRMEL+uClyR8HWKkPj6fIGtbkPpdauqCepR64IgscR?= =?utf-8?q?fgIOqRT71Wv6HoASjC9AwQaG+J2/dKSdc62yVafzaIF7pDACYBA9pKo+nbymv0gN+?= =?utf-8?q?ILqIy/V5reLhZXXrzYsCmznxnLNq/gGyL1nbiVfX4nohA+hwzU1Les2xLpRX/J+P8?= =?utf-8?q?+3e8QrvbI04EWzZpF1Ob3xJHJyQb3huppC9j6VZS1Ov9CF/VDjcQFR8jmYzguJ3LB?= =?utf-8?q?dMzUwiKllcGly5J6M50GSyFrsxwMJrCno7kMrESxZyVQ6qsY32LqpoVyXC+2cRAs1?= =?utf-8?q?fUWpMOK8hnPcGW20nhQCmCOcO1rPx+LVsOA+aFgp1PSJ18Ram9ToYeu1LKZEgbpbW?= =?utf-8?q?EDBMhtA+GbsxfZCMEg/f17Vnx3Lznm85jULRYFGhXDCFG6rKYQi5DbexiWakDw7An?= =?utf-8?q?rDh2hveoRQc4q3zc37Ey/JLBtQk27dsvO0HwZZ+q6idolGbGpvCDrorB1YmJL+Wec?= =?utf-8?q?/0WpZdDryFJk7vyTLWcdVg52izDxGWrzI1Xfhr3NxhLp3ZSQSOn/9L0FC1wkXqCQE?= =?utf-8?q?t7zSNZMsekxYsLJ1l/pI45KQ9LWkrqbUxUkXqU8SpQ2iIAo4E7gpz4FPAH/q21+nv?= =?utf-8?q?SwWfE0dSCQv9UdKp2aGePTSD8z+6nqHn4LRWrIKYpmtl+kEcoeb9tKtjKpDl184S0?= =?utf-8?q?ls+tQMnIGyp1w0rNv4pUinmFwYAwmTnkgFzVwl7CZ3tO/3rsJU6N8f3+owqZusjgo?= =?utf-8?q?x6SUVvA8bnErWYOpPf0brIPmxahjAenJnuTtVKJlshvt26vJuj6Kv+8AZcT1G6Kx7?= =?utf-8?q?d6a2/jSg3S+7oJCn5wdX0ajIGTwcwFVF/teOunFm08fOfsOoGYDGRBSxkMlcdQ1tQ?= =?utf-8?q?P4iONjDwONlJf9pm7Vcn18pPpujpH+qdvHRqCvKialR4F+5xtJV/eSwZIlhjAOmId?= =?utf-8?q?jr6d3A6Kba6yv45jFBcElDZ4VA0787Q7yTm0rNJAB76+M2I9cVKUtTlJdb6awOb61?= =?utf-8?q?98rMIHsX/40So+0e2HeOo/VeBnJQbgYtyyYuavkwM6fRQ6t7aXulLGTSG+lWogj7O?= =?utf-8?q?SPqOW6swVjqCGUUFOFaAiMDLogJiOk3YUKUf17VmZLlbSqd619SSd1laq6xeTjkB2?= =?utf-8?q?2bESIkWd07p9p17j1SYFoheOb0GEZmS8iV3uosvtgG+qm+yBaSJ1PjYBEWIJdKvW0?= =?utf-8?q?eqxY9zkqc87XkQZANr9z+zSFp+Y9WJ9WKdgrGi5WlcXuT97q0+loR7l5HCKdEJQi0?= =?utf-8?q?mp1nCWeR3gsH89VfyUmzixQkca6QQjZfOPVRc0SqacfsoloXTcHZmpyTHMFcse9y+?= =?utf-8?q?XGyzWbrfu6NNLm9X4pSXMniGjlUEvfop0CQh9t3mwzrekpndvGbB96hvdsy490Rcw?= =?utf-8?q?4AygCwDAPdj7h6c+t+g4/KG+SQtWdkhTIPf/rC2Wu2DYGeaTt2CPvbHyrZIYur2ZH?= =?utf-8?q?kWeWzP4UitEX?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4e702cd-3a7e-4bcd-1b5c-08db8d8d115f X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:02:02.5632 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XidedTjoX/aLnEy9wT9E6UyMdi4EBcR1Ulc+Wi5ID4cs0xUxFPh13d0WsN+21v2tUa7lCbYPWSJO4C1czcIc1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5139 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/sdhci-tegra.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c index bff084f178c9..6a50413afc8d 100644 --- a/drivers/mmc/host/sdhci-tegra.c +++ b/drivers/mmc/host/sdhci-tegra.c @@ -1818,7 +1818,7 @@ static int sdhci_tegra_probe(struct platform_device *pdev) return rc; } -static int sdhci_tegra_remove(struct platform_device *pdev) +static void sdhci_tegra_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); @@ -1834,8 +1834,6 @@ static int sdhci_tegra_remove(struct platform_device *pdev) clk_disable_unprepare(tegra_host->tmclk); sdhci_pltfm_free(pdev); - - return 0; } static int __maybe_unused sdhci_tegra_runtime_suspend(struct device *dev) @@ -1933,7 +1931,7 @@ static struct platform_driver sdhci_tegra_driver = { .pm = &sdhci_tegra_dev_pm_ops, }, .probe = sdhci_tegra_probe, - .remove = sdhci_tegra_remove, + .remove_new = sdhci_tegra_remove, }; module_platform_driver(sdhci_tegra_driver); From patchwork Wed Jul 26 04:00:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706835 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D10AC001E0 for ; Wed, 26 Jul 2023 04:07:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231743AbjGZEHL (ORCPT ); Wed, 26 Jul 2023 00:07:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231671AbjGZEGc (ORCPT ); Wed, 26 Jul 2023 00:06:32 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on20718.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::718]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B7854C03; Tue, 25 Jul 2023 21:03:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sf4VW/IwItlxlqPBf+tZBdK1G2yi8ix7xMMPTcVc7Wz/Rz0arEOyhSehr7xAPU2KfWLM22PeNu0HgnUk3jgxDt75WDYTefB+Yjpjsm8JnFOrPO8FTIJvzrGWtQnvQ1wDw9PoVD6Ud8f/fE0f+rS08KpwR8HtnjxZ8Zc25WH+x1fPC6p0sIgFiTa9s+BowTSn3QFwiGGSlS4fwAD+iOhU6g9GArt4GYu5LTiiS23OL5i7m7ZuHWMROzFyGuflkgxd/7j19TAap1IBO7zivlfnaOPeXBoDxqhnUN2t4x2Ib2hq+YtOKsOtxGEbWUlov8wmMYeQ1jDkff4BcNc6SllOsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/zfGaaJRqU+i/vJRxACVy8ivU2sos+SCFqN4m+wofmM=; b=ga7xew43ZZXS7k4sBq3hIxYjFURXSfJv9XbcSjhQLAKpFNdlEQVTc7hz0C8KtDLUrlydXHFqpx3kn2WuYxqKCzxryWyzrncQd5k5CUBl9YnLxVOH5WD4eUIfgt0DfWwGMK2P4VXlYsDswuKYLN8UvPQjYmzulTOpF4QbGh7rpnE2prk6O+HfxhdpQpxfZeXBqwpXmBoZiRSIJ/DgMA2A9rc7fnE40JZufCQPTuiTf6UP2AMKFjESKIQZGu33sD5tBWTxmbRTHVxhpfA6hKfvHlJ37HwP/l7rjAxhEtmlMn09bPI8pnY5+BgUhE1mRssyvNWCD591QoKhD45RLKOerw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/zfGaaJRqU+i/vJRxACVy8ivU2sos+SCFqN4m+wofmM=; b=mC6gWS+sTnA/1gTGU/g2eovkSxYP8+fs5E9fHAsY6HDkW+je8OBe/VmQGMgDZT7uW4LG87D7QRJX553/SLE8nMSdZl/tfM1lDHSE1jlzdGZ4qYbgQPCJZcLh4I6fTZd5cS7EJARNHx1rJ+Iafl0KvgLmL+LgkRUua6xPKW6skehrfN2c39956HQ3OfglOOByF8xGAJqllO1BYzmCf+Nr6KaLCE71ocguQ8eCsUhdkV/m0oBICdv28gbXvvx7+54CzPkj6JbrdtJCe9JO+lXAuiER/f8e752qbppybvDy/y107EZIglOXqH7oWTvFg4VXy9TIqycBpfRTjoQ2JKB2BQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SI2PR06MB5139.apcprd06.prod.outlook.com (2603:1096:4:1ae::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Wed, 26 Jul 2023 04:02:25 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:02:25 +0000 From: Yangtao Li To: Adrian Hunter , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 38/61] mmc: sdhci-acpi: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:18 +0800 Message-Id: <20230726040041.26267-38-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SI2PR06MB5139:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c3e8e53-42ed-4f5c-5196-08db8d8d1265 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: keFaUUfoVmkW02imy3IBFCz+CgUgFH9gb4P06VMO7EtRgYsx3kF+/swF5tIJpbRF2yn9hoscmjsnAZ9iBwf48xdf4RClGzBxai6swen4eMzbCQdv90n7/XaXo4WrmMa1YwglpMxVgvTh+TwCbD2UFhk6+kGfgyV2VyRb/E9ptH1awXK65INXQyILMve4fj7rFVaGIgRcSUQzB5b1GIL2QgVPFQ3yIeHwdlKhXuTMsXFPbJIZrMTecOswcTvxN9sWVFOCze8pgmyRVlgnzAmSQKKFAWscbfVrANN9dyv2f2gUI195SK30P5qtlQ6mCwn0Ct0HUkSfOgNhPnx1mOrPicv0QpnlJDGQc6pkieVjuzAciaQLmR2qDmsSlGxXvrQUsdQ+stsj1QxAdr4bHtBHpLk0khUQNdmrIQffvKf3eK7a/i/n/90DMApzA3z3itj0d383TNahN1N/ijy1luzRRbUBuHYlDUAmEEtiJ/hZcGufOAkO2Ik7RoPNpUeT1xcUeacUQtOrfEAxaNN5FVxKiz30SoyZf3cIjmaeWddLfpD49vUytzNuYHvo/j55Avue4CwqiMBGIpNOAzqTLNQEIVvxZV+J+im5/RClo+n34R71LlTWGMvsHW2dpcHzC2s8 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(110136005)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(6666004)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(6506007)(26005)(1076003)(86362001)(2906002)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?qjSJygs+Ue8N14E8/3z8O4U1erm8?= =?utf-8?q?UUo9yYrLZufJFESYnW4Htvekv30ztIWhFjBaQ/LoZZYIT09p+pbsaeEjAfl6JcRmf?= =?utf-8?q?cUEP9IFOQvDvJVpoAqrwlO0tUt28PvXL0inzcdYox5z/hWY3Yx8qpVY1LNQ/GfSIM?= =?utf-8?q?Kkxj9y/JO2hP+9Su2BD1KzCB60RJpFvhD2wLWoWHmhJ3G7Gic09FItd5I9P2g0seb?= =?utf-8?q?3fNBVvavY12W0OJkXGhgFQuqqlXObgwnn0GTicN56FJgIEcmRggrKoINHAVDoei1b?= =?utf-8?q?+sHV4Qgaae27h4JX89amY/nQqK0QZkoRYAKv75QuDes28gKWgIB0GROVH1h2yBEFK?= =?utf-8?q?WnQaEhYhGCq1WfpLU2Nu2NVk0YOkR3napbW0qehvESbeygh/89lK3p30Zo7RdqAab?= =?utf-8?q?SCi0Mb82mZWY9GL2lKQUug54aALCSqt6vTZu3CPwvQwq08W5g2WUsreAfIO6RAK1A?= =?utf-8?q?vkK+M5TmAqq03E1iNtInYBTHARTk16ghvyJ0UQW3CC2WU1joh2Jgc1LrB1wqNmEv+?= =?utf-8?q?okkaQrQpkjl9dkzcQ9Y9vvm5Z6UnIEOg59MXl/F7IKFNXpUzMif7m/TVm/Ce4vG1C?= =?utf-8?q?eu8AOae98gfPJAvmQAOdPXh7esRmA3jDCpNVesC67iqo349glcIwCupuZx0wGEku8?= =?utf-8?q?w3ohLa6FPWPIiGD3J+HcDkZbHsiQOg9+QosMQt1rX9WvJCWbd4VvVFY1eOD6q3ipY?= =?utf-8?q?LmLw9bF02bzbCtwcXumLIgieULfz+9ozpwxY5gLkhAQxp9CWyeStki9d4EtHk7hiM?= =?utf-8?q?s370LpA90mS/W4QFUGgRZLbtVHBLnIsBmU6k0c1tqDFV1edfsI7JV7xdfoOz+xs69?= =?utf-8?q?6El3h7BzfjQmqNQ/5mTcKcoKR/4o/IqY5NZGOhSIMSnuov6K7a9SWBLuPYoe9rc+q?= =?utf-8?q?IqvX7waxs2YdDfq7453vBpn2hJqe7YOnyeE0MgBV+UyBAyFFXwx9eWLcDd36K8pRp?= =?utf-8?q?CLsBYv/cS1BVaZjMo75Czyo5fEdZfUjClzsm/yfRIkdJNKNNz8WN9vYXs/MNJtszR?= =?utf-8?q?V9SxzhTcINxqnfT1XAPM2llkOK5UCpu1N90zezYjHoKYEma/zl95kS/WSeYvNmuns?= =?utf-8?q?QHWHhN7T2l1Er2Qm6ncQ9rOuslsANEEVzAhB5F0eyU8q60hjbqMl/Fiw8UfCaw0C8?= =?utf-8?q?8qqAHfXcF8x2eC4OGkkRIxJlFdAqBThmgHSrP8QePXtHmggjlhLvhOsnlM4SBCWY3?= =?utf-8?q?EzMDEnWD7zuZwDbBgYRvzirVEQrHlsnbqk6Dq55Jo1iIJtEnEAOAznSbgn48slIZ5?= =?utf-8?q?UdQhZai5ctxL2AItj4Ojd+X4rRYXkMrNp1jD17df9DH09d4XP6m8eavfffzu7l54s?= =?utf-8?q?xWMv0HVgIx8ZIedPrc+WdxgivvPY8V96mhX/aWoByadBBig7D++q5E5Pwrske2dd9?= =?utf-8?q?DK2Qu4BAjAMB7QywqeWJfA2/8NAIeb/a7mUwnHap1kZIW4spcCqtUeCqMqIOS8LuR?= =?utf-8?q?GW7CyCaFClwqeLHzqwjte6JMwdmVUaXQUWBIYysfI232EMgG8K2/AD+IJCDyfqFVI?= =?utf-8?q?2xDxNf/jjWXj?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c3e8e53-42ed-4f5c-5196-08db8d8d1265 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:02:04.2835 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GdWGnOvKlOfg8RJRgquJS9y92JvK89uPt3E8Ysvf6IeEtaDo8ods7Nk6ZATan3dlbQwQqxXXFaDIaSBbGy48ug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5139 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/sdhci-acpi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c index edf2e6c14dc6..acf5fc3ad7e4 100644 --- a/drivers/mmc/host/sdhci-acpi.c +++ b/drivers/mmc/host/sdhci-acpi.c @@ -917,7 +917,7 @@ static int sdhci_acpi_probe(struct platform_device *pdev) return err; } -static int sdhci_acpi_remove(struct platform_device *pdev) +static void sdhci_acpi_remove(struct platform_device *pdev) { struct sdhci_acpi_host *c = platform_get_drvdata(pdev); struct device *dev = &pdev->dev; @@ -939,8 +939,6 @@ static int sdhci_acpi_remove(struct platform_device *pdev) c->slot->free_slot(pdev); sdhci_free_host(c->host); - - return 0; } static void __maybe_unused sdhci_acpi_reset_signal_voltage_if_needed( @@ -1033,7 +1031,7 @@ static struct platform_driver sdhci_acpi_driver = { .pm = &sdhci_acpi_pm_ops, }, .probe = sdhci_acpi_probe, - .remove = sdhci_acpi_remove, + .remove_new = sdhci_acpi_remove, }; module_platform_driver(sdhci_acpi_driver); From patchwork Wed Jul 26 04:00:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706832 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7F18C41513 for ; Wed, 26 Jul 2023 04:08:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229877AbjGZEIa (ORCPT ); Wed, 26 Jul 2023 00:08:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229602AbjGZEHv (ORCPT ); Wed, 26 Jul 2023 00:07:51 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2071e.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::71e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 020BA4C33; Tue, 25 Jul 2023 21:04:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gh5W0xiBJCF3WANhwgZzi+AmCkigtVOV20QbfUbEkOK3kucjD0bgI1apsqL+6zEdrga+3Qs5EA6T4sRbM5s7OSZiDqcU760lL047AbtYvgIIh/lCSXy8bKdKXFi1q/vAMeODl8NaBR3VqfJVdK35bZCEE2trlDEnC4CiCZAp99f2Exnfmvgs0DL1xC+ku1gRnh6scdlNRwUiuHeTOdh0qS8qWouKBvjtFuTceN2wsuzgmEP2ZR2tDz4VnMf2g3KsDQAL6mjiiCA07H6p0SKdztdttx+9ST4HLLJuPP/MkldDF1Xd9FEDixINXVD7Hcgj6I6KZWpXEphOEP+n4td4CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ojpLTgBzv5+ZNx3nkgEvgE/P4GpJkxrZ7R2nyuhf08k=; b=gxWc0SVul38YkHEGB6CtfTpa4KkHli3SLYgjN8/jyiyEkyn3j9aGIh3NvlYRGtAAbHAinvIjagJIsmSFnsXROV96NbcaahvA3eWFFzf+N9+i6TO2SCFhox7Ttk5AyGdXvwGFb/QAcvdfsjtb3tMOMPARlkzN4RhhIYU0+oO6rYuz1QeCYHK5GO7m3gplnZpi8vGJhhGiGeI4Hc/vdqM+YGbIa4uvEFGh7Guc5+KfoJBFFSrxwY+oZ/FSSngQMvvNpnghLPqA04weXuFMgS7BEwmtmnEGK7wgkjYZzJaR0ZtbsN64qYeTmrzpizEgfI4ZiJ161Klz+MlyrbBdgbKrRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ojpLTgBzv5+ZNx3nkgEvgE/P4GpJkxrZ7R2nyuhf08k=; b=XqR+bNrbpJrse062qN2STVA9mrFmZmXIFMdHiePX/VgvNQ63RZo9U+PeCvCCeOBq4cRMsnVhMtdXZVsJlP3lA05jncjUi7v1/r3i77NWKOuvylWQ3m7c33FldRGJV9q1qA3mjGMzOoK4iwJhw+EJLATcjpTgJbQIq3gZKyQqCADloho3UbzsOwiSh7l0LH0f6Pn2HYvrBeesRpUIf8lhvGfPYxr7UPnboFROwDsYDd8FHLgBonVFeEt1lKjK/WSb5bWr1pkHYUqYfceswcP1u3I86LfUUHRdOFousC0TjHTXOOSjyS0iEkQdc3/HFxKoJjqb+7l4fkDTyUlf3N6OaA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SI2PR06MB5139.apcprd06.prod.outlook.com (2603:1096:4:1ae::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Wed, 26 Jul 2023 04:02:26 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:02:26 +0000 From: Yangtao Li To: Adrian Hunter , Haibo Chen , Ulf Hansson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 39/61] mmc: sdhci-esdhc-imx: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:19 +0800 Message-Id: <20230726040041.26267-39-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SI2PR06MB5139:EE_ X-MS-Office365-Filtering-Correlation-Id: 8a480c50-3244-4a0e-2f03-08db8d8d13d9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: itUbjkEO4zZXJDKYJ5XKGOc0eHjlweu+/kHS+hwqgL/VrIasvJXfELWpO34T/i7cwnmRmtKEU3lgrbYSuGJUuE13B0/bnm2XKvZq96/MZwy8/vKawFmYxMhvKxhGaAJLNozJT/EujJ6k7lbT4Ey5OB16UeMqqV1+XxOY0DcEybuVkAd3qHiK4+XAgPnPeYztaOVPeEDApP7sfuDzuyx1Bdbc2JZl38c9YUKnvtQzmv8bQhIXTKz49JEU4n0b7JOqzGSZ6N75ImDcI9QCi6vO5KTRTAHc93NPQRqsIsdqbKn03I4Q4BNXr3v/MiIURu9d0H2SvnfsGhHRRkRf+2Eaa5My2HBCXz91M9Je+c+hix8Yh0jAQQqTTkoAfRjVZzNgtssEYQ3zl8WxTwGAd06xPGdNuZDHyqWo1K6sJUMH9+3fsGIL5AblP2NB8ghs/7F/CT0U51hWuGu6yPHH3JNWedoBR2eTeUBxSSgVRYHaCrbtPJAP0nuWpAAZP6SE19aoR8dC77c/2dnJ7v4YgQeQ5FIq7Vv1a0cJmxavbLAZ7omWNVtK9ixQPyFts+0HYyyvA4t8DDst04KHib6J4V23UdFinXlAo3D2tUittdlOxoyiSL1YVfdMvtIUpDcZUBUZ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(110136005)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(6666004)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(66574015)(6506007)(26005)(1076003)(86362001)(7416002)(2906002)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?1O2a953KBYE/yuAUHt2UDRjxT4yP?= =?utf-8?q?hwZ48UPKPpputvsuAvSdx2sW1a1JlXqeK3QAnvadHIp+veobqZQVOrtJ09yy0bwj0?= =?utf-8?q?Vjt/ZIttEndl8szwbwDSb0IEjPLtVdcsh5DFKCRA6MuZpoHbG5tRxHFq9LS9W3Hvf?= =?utf-8?q?2b/VGqBrv9L6LegPH/FQlDBE5QAsejo6Mk2kuH8v5ch+bL/t9ubG7H09zuyQFu62j?= =?utf-8?q?1aIgI8HVty1pAe8GA+87n3YUPI9YsZcKXYLmPZbNRfHf6TKYBXxT29VWg5dnRghU1?= =?utf-8?q?d8Czjy1jIXvi3tmIX6PAZ2uBn/31tzxucA5UzhxPYIQmYmxtqtYo5R1u+uWJk5VY/?= =?utf-8?q?aFNh0n7Px5DeXTyecoNR5e3hKGy7bavW4vWhBbjaHlzo7xCXRqUTMa4NVNgfXh9W1?= =?utf-8?q?YIHA4tXRMao1tuQthQMtzIuhc0pk0aunZyJ4oGbo/333WwYmpgS8x/8vIRN5OIs9U?= =?utf-8?q?dRXmnU00YGwdkP1qomoNudQdKHggsTHR5nhsf24oKVDM3pD0P8XvfxEaZrxGO+s+l?= =?utf-8?q?Ca9ZoA7kx46vX6ZyK+14+rZEcE36Ply0rlmrJlKPwssSpLX2Ykm44qPmwjihBsbjN?= =?utf-8?q?LD4A+bEVV7AB38HuIq9ycVVk6Kmd+mBpYOOCfEHQ2w92CebD/tW5IbZ3hw3qOpZwv?= =?utf-8?q?zfIfIDdrvPE0t5dmGipZ44pRn72TY/8JfHOl36NgNU2BAVYrtS2ZwR9IYDyD7/SAS?= =?utf-8?q?qzojjRv9C2KNFQoZqh/qSNTdD8v0f40u8JvXdBtFM5FKMNHJxWXLlfKIHW08Mp8dl?= =?utf-8?q?ZEB4bX1y7beZnjnzA5M0I/kjeTsVRG/ug+zrG87YThFEVkwnuPjWNgocTIk2kYM5p?= =?utf-8?q?LAZSRWw+/C209GOPChUTQfhShu02XjM+X58sHhwdHN4ctYm5wXiCdFEuoFDJ3SmAv?= =?utf-8?q?OKuqXlclt6ds/bIguMs+nuUUCX8ftF8LNqoSqTe/oIZ4oDkR1EXqSMGCvFx+aVMOD?= =?utf-8?q?4RGgaTkdtZx//wd4F0CHKrJEFv6yAT0GgG1fL3X5Gmh9pwnsw8wrAisIXlUbEjQvM?= =?utf-8?q?P2uWsjXWrNJ9JwHE0rSxi6uxsER6kYJeAOv++E4uhuCeU7qxE54AA/52xCi93e+uw?= =?utf-8?q?LxCcc5tS75RWLxhF/yVYq1xWrX/+KDwdTmM4d6v6coRM75rKA63AMhVClK4uSA5Y7?= =?utf-8?q?rxqWZvyW0D26/US7xprbM6isF0Qjkb58SgBKhamY1U/JXlE871NR4X+cH1+9EeAhY?= =?utf-8?q?Cd4JEY1YPFcyj9M1UbUTBscUvvIlbkVMD1AZjwr/CN3Sq3eK0YsXwceJ06M6oIdIo?= =?utf-8?q?1yRsYRvLzxUGaXH5ajj0g0Q18jxSCB08Dskc0/rqz8Kjb89YEta/PnJLfCvbDTjmW?= =?utf-8?q?+tTXigkFmDsMy/Jxtmg/zMWrXNbDHIxdep6sZ3OOAW8jBHDvSRTj5ZSLjwMI0q/F+?= =?utf-8?q?ZJn6pK5oF6eGkx9XHqknXiFTlz1apQs0sqwyngfPiny8sPSo9vgOrqTBrk7kVDqoT?= =?utf-8?q?Iu6TSlqkrJaOd7OejgFGIClqx+iVkcBmvaAuSrAFCK+5/kLTjoXAIwx499ChSTz4n?= =?utf-8?q?i4PAliQDMqU9?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a480c50-3244-4a0e-2f03-08db8d8d13d9 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:02:06.7239 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uEdxugz02KiGPYpZA1W4cadtHhAtloN/qBMSOquU9d4DKGgWIRQ6Jy4cp+VE2laxW1si5ZLCcVaVm8bBUxxo7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5139 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/sdhci-esdhc-imx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c index eebf94604a7f..e882067366da 100644 --- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c @@ -1802,7 +1802,7 @@ static int sdhci_esdhc_imx_probe(struct platform_device *pdev) return err; } -static int sdhci_esdhc_imx_remove(struct platform_device *pdev) +static void sdhci_esdhc_imx_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); @@ -1824,8 +1824,6 @@ static int sdhci_esdhc_imx_remove(struct platform_device *pdev) cpu_latency_qos_remove_request(&imx_data->pm_qos_req); sdhci_pltfm_free(pdev); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -1986,7 +1984,7 @@ static struct platform_driver sdhci_esdhc_imx_driver = { .pm = &sdhci_esdhc_pmops, }, .probe = sdhci_esdhc_imx_probe, - .remove = sdhci_esdhc_imx_remove, + .remove_new = sdhci_esdhc_imx_remove, }; module_platform_driver(sdhci_esdhc_imx_driver); From patchwork Wed Jul 26 04:00:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706831 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 531A0C001E0 for ; Wed, 26 Jul 2023 04:08:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229993AbjGZEIb (ORCPT ); Wed, 26 Jul 2023 00:08:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231730AbjGZEH0 (ORCPT ); Wed, 26 Jul 2023 00:07:26 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on20718.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::718]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D31E23C32; Tue, 25 Jul 2023 21:04:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eTBet43sGs4UslfTD9yGSHwVGbVEBqP5zOQSUw9Q2UHPIsG2TKt0LVIH05ycSYUKBdybLqBIcqLTQU7EAgVYBHYjPESQnBI6R15mbQph9MozOXeif9h9g/82CprtlulpWdAKfiv/F/a85yRtRMuUgkJ9KEMY45EOhlGpYsoK9Q92TB7o6fYr5y2b5AUmyaoAEdCHmVIMVVl6S7QHLeAyo8muQjFmYgfHNeiiOz+4YrLzLCA9uigsAmy57i5OI3W+KWH4Vw3xrOTu47tdwE6lh4G7O1rEyyHYhu6JZLs1dAQb96XEOs6v/oSg84oskY+tZyVlezMCjEb18dU3KU5Nyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iHKArmtjsh7/y1Aplpgib/ppYsMir3MLAx1CuQ9EKjQ=; b=JfcwhU3rGz5syUzfnIVdY1Qfx/CkIz5GCjuLzfwDVapFS1TZ8sItuLF1NWDXsPBWe+WrkxiuVHbE2342bH3/f1C+dNLrdC7UVe9DJBtuVfFAFd1UbQjSNid3KnX8jhphwbSWMJKXAQzUWuPpsybwUNvJWtHt5zrbGA/mEFKWlUgJOUjU60R5cqWrzJikuajO3TOnFulmHYmnzOda8qw/4WjjzAP0KD35mMfsnthTSlECy7tjvYmLNBOvIocaURPAAdvfxC4aIXVpqB8EuD/bsSbcSOjE7DjISRkYKRrJc86KAPOpn+I7QT6Y7VAc90/JRnBvftWHdrO//+iZqFUs7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iHKArmtjsh7/y1Aplpgib/ppYsMir3MLAx1CuQ9EKjQ=; b=jsu2PTDJnzhnmNnQcYjypHsA2sSS7++l5g/xucfs3HzR1+oxrexxPJNE7jeK2/gqC/C0TZY+nKS1lGijYrj2N2DevBrYY7Rnv4KgdgsFKDVNbqLhYLAK4JuLXyWeYxiWChNE6rtO9YxxHiY0Y8tqjquKy2sJQpVbE8BR7D+sP1L1hDGGltE4e1QwTp6HLOfLwC8OvX8rcrqczif4SFisV+wq/O3JHEjrGl1/eSOYOdSbQVebz+L3NH/pfkFejZOEMu/Kd9GoM72yOlKDAerHfer168oMi8e8Vd2ty9gVI6lPtjOYXlf+mgkQulb7AuNGgjSR9OBls1L37V+U0Jn0aA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SI2PR06MB5139.apcprd06.prod.outlook.com (2603:1096:4:1ae::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Wed, 26 Jul 2023 04:02:28 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:02:28 +0000 From: Yangtao Li To: Jaehoon Chung , Ulf Hansson , Heiko Stuebner Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 42/61] mmc: dw_mmc: rockchip: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:22 +0800 Message-Id: <20230726040041.26267-42-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SI2PR06MB5139:EE_ X-MS-Office365-Filtering-Correlation-Id: f2b143fe-1a52-45d9-84e0-08db8d8d16dd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iZsqgPvWHHA7TbxIb75YKDzCfyYBsWZkfPLcq0Oo/m5vV9kdW0yOhofFT4PM4krxKjvb4034H5kv6MSwICzjMTUo/crSHLMOZgJ7mfU9nlHaYQQdSIIvbXJu/ZSZeZfdQar61aAOsK6WGdB7fbFS/ACJgMZ4e9tRtPx3Lwc96PdDkCVM2yQFwvj3xbqSR17vNJNjeSLIoP0Lj6Z1OgX/bRs7bbYo85TLhIBmCkMwYrkcmUNRsjRZX1CrYx99DYC1ehpbBwb8PjQ1ygn1zuCEacimaK3kQ9KhkUEgxmsCONoXpd1+ZekuiHaN2iuW9t+0hBjfV83XLBmabgy4nBwv1pUbXMSXYgl0Zq1F37F6hH1FtAcMFXh3RUBq5E02oi5RMhwXAiMljPSlgT17edsp+eEAUHieMR+awPtQqtPc7PjJNyPxofhyoK2+t1lUEA/icoCwm0AhoVGzbkx+ETNrcoTe8qEhMcYTpvor4mUmh3eLTxahTJsy6Dw+SsHbof4bjYcQ6+oPXkrQ4dRhb0sJOVJ1nnyqqxicxnWZsw8wUO/Un5eVS4nevq3LHVKZhjTat6EmvqLLat54oUBaV2A9eWxjFu5yJZwvkKLSB0GIM4yOv5Uend9CT1JBORA0p8Pe X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(110136005)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(6666004)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(6506007)(26005)(1076003)(86362001)(2906002)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?0cIvSMzdq5/q60es0oDip73ZtlKk?= =?utf-8?q?Z5/+JLUWCDwYGngM+ilwMD7bgPLveHczJi8R0re/5rPiSoaNsytXO6F3Nr4P4Xymk?= =?utf-8?q?zjM5kaBPCcZ1pSgoyYZ2tkgVkBT3l5dAmqY1c6kYi1GHa9lmXCNMokptrjiOkZ5OF?= =?utf-8?q?Mhz5t5ccpbekhVaBnLl9Y1RlYE4O4EanVLQINitEVisxzJNItD+ifcQFTIWwsYTuv?= =?utf-8?q?QQ7m6lX/Exiw56HgrmUJOPFTOuEnx1Zi3GNez0fNLDCR1ywfONlts1rhfgU8DsTBE?= =?utf-8?q?LTnwmLjaSc+4Rfc0Kdr2yd3dA9bL2+gg++cr0tBUfY/4d9Mwd+m+OK+oxBsNCw2hK?= =?utf-8?q?DXMv/rvq/sXzMj4bq1dIV26fdR1DItlmC2XxfQE7wVFvRpDNJpJG21O2RdePUGZrR?= =?utf-8?q?LI5OJvHmc7G0W+vyPj4i6XgIWtCI34o3IuGDQtXEYQdthkyVhja/DvRHa/Lrhz74f?= =?utf-8?q?zwM1cqOxGco9zMJbEDaqAodnn4hSOOgARp2vzGZ+7LS/HCe5JTCtlSC3s3YkPDK7B?= =?utf-8?q?taByz4FQyweIbbS+BH6y9RXQ3Tq3zbYNWmfH9ySUSjkVcPjAZp/+BRFXENdl4VhPP?= =?utf-8?q?iaT2HBlUPiadcyXJ7YxPZFdcG2rtQOcIA5zkFW959cpz16CaheP59neZP9FW4e92k?= =?utf-8?q?RxegZ7Ho/5F6JMWt4V92toCblbdxQq3RxnSrLRyZ5pPqB8Ch3xh5JlDLYhIxrZ2bl?= =?utf-8?q?cYsOgztJGRxXpSPM2aeWqY4p68fXIxBLNHVMtk2hkVeWDoh0eiya4phrxqWOoYTPB?= =?utf-8?q?5qwWmaJI8zoaRxIgqHNVS5Msf0QHxSN7FKUSJonBB6YxySGh1SbPaf627yIq6lDD9?= =?utf-8?q?fW9pt1/rjjn/9KsZjst9k8eoN3qbDAQ6Ra6hocbRPpiX+tpdg7YHudNGcSfJE3gdj?= =?utf-8?q?20QKhtaVBUtp1mOOA07W+bcb6bK9NgUIl6FRQ03a9OZShNqkYwoqH7lcmnSPt3mw2?= =?utf-8?q?Cen+fKfkDzetyPhijkxcygfJqBO++/jd3MBcAQ013BTyVp/WdC4aL+jhwn9+b1uHx?= =?utf-8?q?5X1/lZ8gOWLHyNKgBozpLUR32VGFJhFAdW6zHN6Go5WylEQuQcYiG0JB7CgH9Tymx?= =?utf-8?q?ecB92+/vT5Da80ZfDZ8azRdJNRxwGo/KB5BHR1HdqjidX2xs6zLTbuze7xTxrO0Af?= =?utf-8?q?7t6rAvJXVGFbSNKtGimn3cAz+Jpe880WTScTP8RiNYuvJTwjiJB6P48gbbyNqb2Eg?= =?utf-8?q?Q4rUF2m+mOc1HAhF9//0G2y5yb5HGCxkCAfbl9fkRiuxESh4U4X+guiOFvdoxIXMN?= =?utf-8?q?L4qZzBjoKozQEiIB3aHH+V9sZ1EDCCCWVKwUQvG3UakZMdY5P+BiOukV2smzfBtOB?= =?utf-8?q?6Sx1lE2Lt4g6W1NnITydZv7sjW9K/0SYCKLEGrMsCn7F9X0AaHC6w6+oaE9vvGC4Q?= =?utf-8?q?viStGI7ieCG/r8LPzMzqIvmFsSe+G4tDFUepiHhQ/bYiJqiu7Yrui86UIDGSLikMl?= =?utf-8?q?iz6/dE1Mbi37Cl7ECLYXwqyhBAJp2228UuD74kTh/T7EnJMAazSm9G0MGTia2APSD?= =?utf-8?q?p6CIUtdjYtOb?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2b143fe-1a52-45d9-84e0-08db8d8d16dd X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:02:11.7833 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tSgCGb4HmaZ4XgsTvTg3NFgNfbSazPb6G9Q1Nw7ZcKUxm+DfoTUL8yKaTwcTthBSUahP9ryGtkMo1yv9KUOVrQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5139 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/dw_mmc-rockchip.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c index 2a99f15f527f..b07190ba4b7a 100644 --- a/drivers/mmc/host/dw_mmc-rockchip.c +++ b/drivers/mmc/host/dw_mmc-rockchip.c @@ -371,15 +371,13 @@ static int dw_mci_rockchip_probe(struct platform_device *pdev) return 0; } -static int dw_mci_rockchip_remove(struct platform_device *pdev) +static void dw_mci_rockchip_remove(struct platform_device *pdev) { pm_runtime_get_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); pm_runtime_put_noidle(&pdev->dev); dw_mci_pltfm_remove(pdev); - - return 0; } static const struct dev_pm_ops dw_mci_rockchip_dev_pm_ops = { @@ -392,7 +390,7 @@ static const struct dev_pm_ops dw_mci_rockchip_dev_pm_ops = { static struct platform_driver dw_mci_rockchip_pltfm_driver = { .probe = dw_mci_rockchip_probe, - .remove = dw_mci_rockchip_remove, + .remove_new = dw_mci_rockchip_remove, .driver = { .name = "dwmmc_rockchip", .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Wed Jul 26 04:00:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706830 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79400C001DC for ; Wed, 26 Jul 2023 04:09:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229939AbjGZEJM (ORCPT ); Wed, 26 Jul 2023 00:09:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231945AbjGZEIP (ORCPT ); Wed, 26 Jul 2023 00:08:15 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2070b.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::70b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC6D5448B; Tue, 25 Jul 2023 21:04:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UdB/XdIWVSEd9JjSHBpH0gLVC+RB2BlmqviEtAuWAlmtPycm5Wwwu29PJpt0/pdxqrcVuK41hmrk96+fJUQYM8svvpkblHIMr5TukGbOWTgBZE9i5f6BG45SnJ9vMCs6xRjYx373SeWwpnMxfI4Rfr2vE/unr1JaxW556JsANHEMUycwmZV9BirXort12imlBB5R3WzlIRtWFMuAheMIvHT7a9AB92LhbZVOXmIrlFQL5zTjMoyY2uCryvFSp3MEtfTMzRCbZrWwiBo2w6f1rRBDIXfds7k5xM4Ra1AaysmBu468LRrfgRjpznTlXQGPU6tXzH9vyLpPY/77wUKYVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TLrIU4EUdrLqb7T0bkwRGkvgLMm9bmDLScwtsrZ+fTw=; b=GYT+UU9h4q29QXBkznNbqqKc8dPCdB7A5/J8LobsHTrOJSkjkkqhCnvuMiZ09xsUHIA2fJvSHsHToQ0bOKm0ALvrshSFMmDGq4UPZIXXTa7x1wbF4Lj43/DphV+a0bJaj/VX9O0czqoW4jmaAmPQ2xtlvWXzBtfx5glK4eRzsMCSUa5P3drOIQa/KxmTe+bJeDEWW9jduMi9N4+KwXccfIxGOy/lRa7U7tLgkwiUH6XuofFqFmIUV/rj6tok+NdV8Lteg4BbusiHq6loaZDxb+HikBc6BiSClHrSSnloco5oukQ22/1IOLHUN/14t6qepYSGGEaEnGt8llp5bk4ksQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TLrIU4EUdrLqb7T0bkwRGkvgLMm9bmDLScwtsrZ+fTw=; b=KkeUS5e5t5KO0lbgTwqPUg3E5/iUUqA1rYVvMWQAmvVLFdvd4XxeX4EuigWhvZJDF8ql5LuhxG81oPMhwjpAlrqfaRj3GjJFoMeqWEXkm1OsJy7mxLc+iFCL91DGLfgNnAvHIwWzcsJvsG2PoINA/3Ux7b/CCh28Il5msJXHCU5kkS0u2FynWDapcQ3CdRNXKXle2itf4Nbu1Y7jE4H8uhv+TuTWnfoFwC8pro62jVjMNFEbUMlxd8R8MvIuuSId2k3rFhZH0KK0ZVdCfURfVQq1K90LPS85ifEZb5jItMAVZpHc7qcT0YwNqgY3E9WjBH4911Y77ojgVDAyS8IorQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SI2PR06MB5139.apcprd06.prod.outlook.com (2603:1096:4:1ae::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Wed, 26 Jul 2023 04:02:30 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:02:30 +0000 From: Yangtao Li To: Ludovic Desroches , Ulf Hansson , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 46/61] mmc: atmel-mci: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:26 +0800 Message-Id: <20230726040041.26267-46-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SI2PR06MB5139:EE_ X-MS-Office365-Filtering-Correlation-Id: 83d037bc-e351-41cb-f384-08db8d8d1b50 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nfrcrJ8WAKh5/WhuybRFhX7if7YMlxEHhPny2vXchuBTqEB11hbDDXOGAO8UlbSf0ZRviKkoOdOQZVEGvQjDYl5HkWvqKoOpD7Ah7u7ruu6ECIHzDvBi/sYNF3JbjGYFoM9SizFXX80+gLPE1JoTfjT8zJYafIKOusGvYTNircgEyZLiTWdlSwx0R7aItwOfvPrAGjSefWz4v3CQNFcPYYBI15EeaMhow+LHMFrpQRQfwD0F/lhkx0etLFsdh+jOGvCPuIZNy+sjTh29ss6kmR5jnEt6+Zx5BVN5gkumhK7FbZl9h1znsTCycW+uW4yfChlhAGVlTTBH5AC2V0hp/+0khpBrlsTMFiyA8byI+oiuG3FtG3V+OwQKsdNkBwRe5XcY7tpVmhJbZ6l5dxWvYFDxoReUDkHtdytcReZXUUfxiUFgrBuOHsc1IW/Hf1F+gK+Gf1RFCLiUELL0/HrnnLNd1bXPP/hFgAVni+EY6BWjUsfuy/FbhEXMpgTqwaP/e7VVfYwbfUNUN3uRQuXjh9sUm0fnJzlLMqIrytc9VMYuGlb7CsN21h7NIbsjzc1qibC68yVE4baAce1JVK82wdtu94n6h7qC7uYngbuVMs9JaRk1bXnR4jd91FgChAxK X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(110136005)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(6666004)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(6506007)(26005)(1076003)(86362001)(2906002)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?FQZKsbmWlG37WFcJMkYZrggyJWP/?= =?utf-8?q?DNZy3Tc2LKzipuTKzzUdU+/Gmb6fglgjGty9Jc+aKFqrHykbLRt5dUe6ZR2kRndMU?= =?utf-8?q?2kzeMAv5Hepaxxs4XRQhp9QDeuhHC+YXzen3RNIhNRzvTyAbbjd0jhphRdU47QW2V?= =?utf-8?q?o+KwXle3gwsB3oiqzuCswl4hBwhwrISX0aO4AV1LAKk1vtic2HmxZDVpBpFD37Pdw?= =?utf-8?q?UPY3p4hTraFL5eYMdlT7828U/dZzQ7QDPiCmWZL5EOcs5j6GQtU5tcjqCriTitwo/?= =?utf-8?q?AGTVhA6GGi4DETeIDtvujW4h3wvdd7qXKRKZfAZIPB+DZ9lHLDmSw2i8tIRsfj/7M?= =?utf-8?q?ExAPKkn4uWM/kOecTLS9h89PyjEsxwS7hK6CBtSBrQzpp1PJ6rYp7AKu6ngbvgdXS?= =?utf-8?q?Bs6f1DdxXpjSXxKr4XK4DyNlEhFvx4YpaKWw4CayP3JJ44ZdL7mcKs7snyikjh2Y1?= =?utf-8?q?XVt0mUzsioduHQUnEWyrsRJTWVTUjDR1iuM7lnTcrQD5o+m+Zx1Yyt6WWM08iUeAr?= =?utf-8?q?oVk2oHqUzCYrlcS1Y8OJCP2mOrpYelQgr11AFRCOo5PaTTZdd8RuXuXDe5ZLYsTm+?= =?utf-8?q?+NdH5qYXEwehuf/2SsfJFWvObyffK7YQt3P4fB9aTkoxiXUNFAsf7lMllV7V2UBHU?= =?utf-8?q?uYrjxs26Xaivhh88ZFMw3xdzBtfhPofHeb5H+9ZS9YR6zPvte8tEwZ7aAjzWKKLD/?= =?utf-8?q?3KmB07rPv170amnsKbAMNfRqon/XudnKOpJEy8RTzqdBxFtJDDKFfh6bVPP4fglO+?= =?utf-8?q?FkpYkmp8ojfRkLIEbHqMX6Pwl/xfjAzAsTSk88iXkg9DGcKonyk9moBpGAiDoSOg7?= =?utf-8?q?YZf8Qz81lsaYwXxhblsL9g3s+926MscUbUKkLOhqmfeSL0X1inniNRp/J/6Q8AxhG?= =?utf-8?q?JF52OGSKIV16aZ01K09uUxOeyRdGgGSt5vUuwQCXbBEJTKuPNuw5+Ls3/IdrzMK10?= =?utf-8?q?+dJZQ80O4Fd0Pq2X84b394aGJAMxMtrDnMN3szzdvRTApebN/ojUBU3ejnzYLg2uY?= =?utf-8?q?NPRcg+oNtgdUAUv6olEUVuFBpZgjHLbvFHpRSkQmQidx9tN/Jf7/I12vWskpPDkrS?= =?utf-8?q?nPhk8FYUTs4IkcrAU6Ohm9JPei0vkD0Ialdj17p1ijPKjDgxQgk0LfKfogBV6F69J?= =?utf-8?q?/eNDyMwga7X5+Ojh/GQuAuggCWxuoDHK+Uab2cvmKFu+CWSZKdI5gNgxWJ5M4rDv5?= =?utf-8?q?ychqsvXzl2tInwOVS2km9llwSNyfRst/iTp+VaRF5wxxMXp47FTANzw1EL+T+EtRM?= =?utf-8?q?HuLUOWBDl2UhC2b+LPqEYi/uXmfqKEJKqvaX4kSF4tXWL7FDuhfkPRYNvjtmhQoj9?= =?utf-8?q?rIVDYUiurCuM89VL7fxRpGfwGI6wilKufaIFuXNN9qhExRYs6XcSlVCYBH/QB9LAQ?= =?utf-8?q?gKZRImk4hIjIGPjefTgRellzwvQxxTFydvCM7ZemlnYJzBRU4eDzMqztuRRxFYAbF?= =?utf-8?q?toKO6GPeo4d9Styqb+uWiqb7457lXmCEvZCa5r7E8msIhagdpNt45PtiYRznZ9GdT?= =?utf-8?q?+v16TYJDnYoC?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 83d037bc-e351-41cb-f384-08db8d8d1b50 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:02:19.4463 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z29OMKT9BH6Z32B73HHq4n667wnITKP5sHFDOKyHAv7OVfWKvV1oSkAEGM1ayqnVDKICR3X1/6po63rvJV+FuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5139 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/atmel-mci.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c index dd18440a90c5..b4ae9aa939a5 100644 --- a/drivers/mmc/host/atmel-mci.c +++ b/drivers/mmc/host/atmel-mci.c @@ -2600,7 +2600,7 @@ static int atmci_probe(struct platform_device *pdev) return ret; } -static int atmci_remove(struct platform_device *pdev) +static void atmci_remove(struct platform_device *pdev) { struct atmel_mci *host = platform_get_drvdata(pdev); unsigned int i; @@ -2630,8 +2630,6 @@ static int atmci_remove(struct platform_device *pdev) pm_runtime_disable(&pdev->dev); pm_runtime_put_noidle(&pdev->dev); - - return 0; } #ifdef CONFIG_PM @@ -2664,7 +2662,7 @@ static const struct dev_pm_ops atmci_dev_pm_ops = { static struct platform_driver atmci_driver = { .probe = atmci_probe, - .remove = atmci_remove, + .remove_new = atmci_remove, .driver = { .name = "atmel_mci", .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Wed Jul 26 04:00:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706829 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53B1DC001DC for ; Wed, 26 Jul 2023 04:09:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231817AbjGZEJ2 (ORCPT ); Wed, 26 Jul 2023 00:09:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230396AbjGZEIZ (ORCPT ); Wed, 26 Jul 2023 00:08:25 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2071e.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::71e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0C30448E; Tue, 25 Jul 2023 21:04:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j4XHDPI1lHO+plL/VmcgemDDo1eAWJAsFIDKYZFeih4dpVpejU5v+LzO1SdacgZkNZ4vQQ8d4DGD/umOZCgtT+UfRFieoEIkhq4ASfhhq2REXEDwDFm8i/V/Fp7nQXQlTLsGyy9y/xNQTLkfA/hB/NOaUCxkI/b8fGyugYqMDJhO5y5oCe3W9tpY2y1dmTKG50KPAKhq1TWU+tcsH05bHPHquDc+8WhgkoE1/iQS2bWGATF8WU1xshLjLFHTKvLly2hF2B71WNSvCJSzC76z74UrtnnXCmrJcf41b2IL3ZyKrWsf24ywGvc0TNJcZ2J95R66BoBsPuX9U/Ziy9pwhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lg9rpO+O+Vuwq16/2wqHAmJUAen0JpqCAiTPkimHe0w=; b=XCp/M99SFUhm2aT2Fpx4vE9avbdVGwAxKnGCzyPNDYeJzQCrqOabFcAXOLrW7pNEF52213f8ehvmnBQCzIerNdBB+q+8U8FZtKYg9M7AonMblPEqyMvHtdkFauzB+GfS4UCcT5Z2QU+Ulx9e2Pgnkef0ZDbNz5pN1v4VCy9DmxpHVeA7Up/p45uYA+b+IAmJQiKpQYEuNh+5lcdbO/+ZhRZfgj/el1P1vP7ewnGU9IXC/V7zm1Sk95HkVA0Cm4xy02V4Pq43zfwACIXGCrkYDjcON3u9evDI+/EKKKtDdQuq8bl6+IzvaLRU+ZIT700qDqPT2S50T9h8pGCWNuEOog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lg9rpO+O+Vuwq16/2wqHAmJUAen0JpqCAiTPkimHe0w=; b=X8zy3zNtoFEIPoyvS+JTVGircL8d45et4Ip4b6WnSc/exjicFvT3bofyGESVII5jhtNlymePgb1nwKScqYYm/mJyN2vYvsgsZq+dOi0v4q3I/h9IRlS+XEKY1/cuu9nGdI40uERkPMriLX3c/kyAntj6BVYqV4cv6+Ov6wsEs8YhVdZpWn6Yzc0RAWE9DU0bzBzLrBpPJVESJyDErCFQfRfYcDFbV6FzI+vTiYR3tLtCo4sK7RfmcQcBFtz53R+mj8Zs4orL5CjSauZCoiR2OoH8DKCFuXOuRixFlInZeZQFQAV0DoUip7hds+NHiv5TlgnsOGEED/uVUfUIgHTADA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SI2PR06MB5139.apcprd06.prod.outlook.com (2603:1096:4:1ae::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Wed, 26 Jul 2023 04:02:31 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:02:31 +0000 From: Yangtao Li To: Patrice Chotard , Adrian Hunter , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 47/61] mmc: sdhci-st: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:27 +0800 Message-Id: <20230726040041.26267-47-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SI2PR06MB5139:EE_ X-MS-Office365-Filtering-Correlation-Id: a9eb9e51-28ae-4395-4ad1-08db8d8d1c9c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4KOa4FuVgukNi4sySAOxPdfLBvTLVrsSwfKYb4ParvQItOXQfzORcPfINP5+st5T6/I1uPCVReqozM8rb1gJBgQmxINt/WPWtKVVIgqRvX/NiUX3DSaggjfoA7rs/n9JuTWzErJa/mdOSRxKBb5vDywhiLFm1zTdBMbm6rDllfFjmadVsEGUJKwQ5y9hcQPGOir/zYtx889EOnZIc7v++NpumTBOz8T1IpsHwXqRDIqF5+b/JVSUtGDKgRaetwsVKMbvlHrOz0WFedGb2pWUWYS/FawZn8VtxXw1FQh8CNdjpvsnFc6f9odKmXOZw/iBnLyr5k6axlGyMba0cT+4kJpeEVW5sTzGO4avWmwX3xMVBlE7fhe94PTZ0NEKSBlXnAeS1yg79loda6SG1KDQlYLZSxrOW6ULZyqUBl66JK72BmtQparEodzLAKlOpJuhraY7xgVrUrgYqthy78pe8fNkMI9dqBDNfA7vGynMNEStcmTsWQd7awHE91L3Q326G4/vZmGAV71nGwZseo26Ecouwt6uCT5gH+fLR7rRzvmb4vNCJiZEYfI3nX6NO3l2h/gV9kAT363GJS1K+q/mR5FCVR/CshE9HRJb8xY8tW2IUMpvWdRnKcsbn1o2NigG X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(110136005)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(6666004)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(6506007)(26005)(1076003)(86362001)(2906002)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Si1w1PPOtvmAtr91fPyPR2KLq4g2?= =?utf-8?q?eUc11ZMOP51QXjteBt71NkHRpgd6OInKaG14uR0JBQmol0X5Ha0N1Mzh9AylLyPaG?= =?utf-8?q?Xfz+POrmSCDHiVmhzMUurLsn1PEQ+UOruHEo+vEiPvsPbhbmhodyqz8GieOWNLU+P?= =?utf-8?q?8DvcD6/6GdPo3yOJQzJ39c9K0Rxuu5KfIElM6CbkVpDD2FKTsj2+tzAjWymcmj5tc?= =?utf-8?q?q8g7PuyayUe84Dp6WrRGWFKvrNQgu9rpda9kWlYfUhlERbJmiExxkA4dPVENaCAsQ?= =?utf-8?q?H4xsK4NN5rU8IPez+khc++xPha/f5h50fkvkf4aD16wgtwzwLTAab8/E1kk4LBaIY?= =?utf-8?q?UTrvTbFV4tEEb+6w4zQwtg4SnjxY7es8Uz0oII/OQCaEAFKAxqho4tEJ9/CBjY443?= =?utf-8?q?m0l8t+AmJD/wWRqze3F1afhvocGDVhbjBTeiU4QIywakjcfUwsU3YgG2omE1u9jyD?= =?utf-8?q?8HJGnQIJ9dkmBMAELvPW78ZO3iXYbETxuX2i07yB6CAN/dX5gfThJv5C0m15fnphV?= =?utf-8?q?8vWU9Ohq2fmC27pBA5h+5zQx5WMw1+FJEKwp8jsGZ3vJFP0HExuTe8CBsuTRzya5a?= =?utf-8?q?TewrieO82vzIe+jg2qPTZoPCVd00jmRjDx+BPky73rzqp00L0Zx6fjhgcwkshVe9t?= =?utf-8?q?Dipqq/Swmbh9LmsvKT3audh83OobhPcbNg37H6GLVapFNuoNB4BNn8tLAXY0hoqKV?= =?utf-8?q?mB+beK+0BETrA2GBX7tei7fNyoSFtU9nyk9fjP2t05KgM9Q/SSfZGCA75I8tB0NDo?= =?utf-8?q?Iut0E7YiJxfJK74qYrNn292Dq1LiiNDtlJofclP4Rm9oZSCbhpM8sJ6opfcHSqLLv?= =?utf-8?q?3YMJqXpW+E8xuLGzuVMU8ZaEQdr+olp0ducVg/9Indl2yX/LXpBjw+BWFPwrmFg1x?= =?utf-8?q?IlFt2uCayLRI1FXrnvK9fmuWASf+THGOvb1lG+sFj0lvfWAT9nm2XOpbJolhn49oU?= =?utf-8?q?sy4oxn+or90Ohfrz+Q4gswx6MgGfUEgpdGT2Nn5CgvX1JHLM+lNy5mr2/TrkrNabE?= =?utf-8?q?wQ4D88B5X3vqS7aPGDm3V1vCArHz2WkoqBGFNrFOHJADJW0R+iZ206My3GmMfeFXZ?= =?utf-8?q?UYGNDlWb/76lubrBsY3oA0Znhmi61t2YIIoPIcCy+ttSbl0/uP2cy31pKseIfMWUF?= =?utf-8?q?+pVTJ9Ejm0NW6qqOMhV28s2gwNSrT33/lmyOjft547nggc2IBVm7cpwzVFQSj/EXL?= =?utf-8?q?mkluagztLZxHu61/4xl8Ck5/4bY357GfpZaSe8pMkyaPl89R1NuQ8ENsmwKhhAmhC?= =?utf-8?q?C+SsUKU3aNbM9fC68/EPzR7whicuFx73sZKdVu5g7p73hLM2pJqEi4IQSLmlSrSVn?= =?utf-8?q?fK7dC9HrmNhMDBK1M4xG532HIVnBsuDIHUII74a+jT0MeQWMjZsYqdbZNBlKuM/c9?= =?utf-8?q?I7c6ecEJF/Zvj0NEA8aWlCFFJWfJlUxTGntzmxrMRPcnE0EwpW1jwr1R7kfjtmQuC?= =?utf-8?q?qqlwRRxAUCtiXsvlS5rNV9aLnZKnnlzG83Ve9SQ4fjefLtPqXvRr7nsWJpBT45zS6?= =?utf-8?q?iTHwlkIU/hKH?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9eb9e51-28ae-4395-4ad1-08db8d8d1c9c X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:02:21.4588 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XUR2cmGN+Go73rY3Xn5lUxneYW8DTNS118ZrBg+kHsgDmpZms78CEVIYAvNoVlnEKn0wd8mImY0+ahLi8lM08w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5139 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/sdhci-st.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c index 6415916fbd91..d955b5f4b7e9 100644 --- a/drivers/mmc/host/sdhci-st.c +++ b/drivers/mmc/host/sdhci-st.c @@ -434,7 +434,7 @@ static int sdhci_st_probe(struct platform_device *pdev) return ret; } -static int sdhci_st_remove(struct platform_device *pdev) +static void sdhci_st_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); @@ -446,8 +446,6 @@ static int sdhci_st_remove(struct platform_device *pdev) clk_disable_unprepare(pdata->icnclk); reset_control_assert(rstc); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -510,7 +508,7 @@ MODULE_DEVICE_TABLE(of, st_sdhci_match); static struct platform_driver sdhci_st_driver = { .probe = sdhci_st_probe, - .remove = sdhci_st_remove, + .remove_new = sdhci_st_remove, .driver = { .name = "sdhci-st", .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Wed Jul 26 04:00:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706828 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33936C001DE for ; Wed, 26 Jul 2023 04:09:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231684AbjGZEJx (ORCPT ); Wed, 26 Jul 2023 00:09:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231700AbjGZEJL (ORCPT ); Wed, 26 Jul 2023 00:09:11 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on20718.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::718]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E49055253; Tue, 25 Jul 2023 21:05:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L0743ghStL1fhL0oYcZkD2DecqPTFbAyV+j7JKpoto09YzIAtB9qHRBwAf8YDbH8AHhVR6BlvssG3YSK+O33tWO7FHAvrjkuxhzg/3TC077OmFK2L72mqov7TzUMwzzvU96+uycwGuS1967rHF9RKNgZ/fH1qB77bPEKiMRBUqbBxREWJ3ZUiUU3aAAVeGqnVts829mOELNA2k7S8WY13tZnNkKPmkZJDcMHnS3XLAgNWmId1DMKJ4SN8cRw4W9yCg+aIbRC/bbapRcIA/hfqEIx0JMuS0xbZeZ/q5Fdqmko88mHqS+MuprLd7utQKjm4xqzOMMglEJtwKmplVpmrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VT7qOQ62I2XJCm8fWlnztBkYfBsGaUpc/87KVtpwDDE=; b=Eib3BMpdi7j3AHhVkZ+1Oxl2qQGS11DeqOanpTtotzbg9dx5s45p9r5vExddV7MrmtjJffHhZYoAKn+D60BGFxGIa50p08t1hDoE9aNnN7XAVBvQNvxUB93omRX5GN51AoBcOEyuYChlFKa8KkJD3N6xChpeuv6HIPmBKTUH2DKITl0S4Xvd3/Oi30Z5M0A9yHTim+U6eLX4UxLiifpbpIdXr/nLhTB99ObM/hNL0J0ZHAmM5MzpQ8ZKlyRop0oRvAUfiX4Brvqw56cT7i6P4n42Kf3lsBJ5phxFSSZiKu+h8IKjiuieQnBaAtXm0QvW+//VUUNzDGKfeiUycc2IrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VT7qOQ62I2XJCm8fWlnztBkYfBsGaUpc/87KVtpwDDE=; b=AjLoFDB9aFbTu9vqm3L7g0XZRXzKGaAdDoiwYQTl0QzohKaR074OhoGWQJOFSQg4N5xJf9WrsIOwJGl8slZEzsIAR18n5cW5mVfeGqoFns6PEtz6Mo02EQG/vwkQXwdeL53SSVZ1xh0z7WWa9r34ydsJhMKhSEbJ5DibmGANkf6JG+ji6bbnynIgUPYG4M3m+BcQTi0MiaW+B0sj8tsCNkGYltmMoF1Y6pVnHxMllQgUK+yclkpujpU2Yb4yJifuDN2cMWc8RReJxzUIOQwduhVHtN7dCL7/q20DGzm0Fc9Qvy7bX1jJ4pihJSyKfgwZxKNVw3DTgGyYkEpKyFH2PA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SI2PR06MB5139.apcprd06.prod.outlook.com (2603:1096:4:1ae::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Wed, 26 Jul 2023 04:02:32 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:02:32 +0000 From: Yangtao Li To: Adrian Hunter , Angelo Dureghello , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 49/61] mmc: sdhci-esdhc-mcf: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:29 +0800 Message-Id: <20230726040041.26267-49-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SI2PR06MB5139:EE_ X-MS-Office365-Filtering-Correlation-Id: c9890010-9db0-4489-4369-08db8d8d1e93 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r1IW+v+vJdTiPZfDeONYNb2raq80F0cq3HQsmjP3DpCfSAfgp5Pqv9PRwECZ6C4LdQTxbcfWXcDGEp3gt85SdnoXMq5tFqLiamxHsw4zz2afVYfDuG7lKHhKKmMu/Ly2VXLqsdNOsnYyHXBEXrS73EQy6h+VcXwn+7d1XvOmKZ6zr7Or8x7wlk79NGoUt+VfP8OahTaFaKOI6WmJhOGrKN9b33l5Nto6SuDX/kqLxF5nJrjfw9eB7R6Er3lvfublZTU/doWpnT5WqTthuzoG+46Mc/pg1IHMQT0CPYIsBjQXsYyZA07IooJRwKNYU6rf1o8zCwxIQf7A7lrCANA4dup9RMmOyYY7+BkQcMcHqbwP19Con+X9T8LJY2mgETRnZrrPdCgM996B8jazI3ELO9jx6Ld9zILsXTV943k/9rIgMfNeew8uFvC/4Z7GMSPo5jwyzyXuEXeYKm4Xc7+AFsWGb5F2q9pYNWuHKoK3FEJtOMUvq0VQpYg2V4hDkydXlfi6hiVPs5WF9WQNnKXc/09JL+0A7H3oDMCLrv8sSHLQ8dezg8qscAPqODWL4QdYqv/jUdByoL71t/kr4Y265oXSz+ErtWzBN0XuIB38dndn0jy9lABLIllXYyBeUQo4 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(110136005)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(6666004)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(6506007)(26005)(1076003)(86362001)(2906002)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?NioL4kPb+WmvegL9HDhfvvXMS8/H?= =?utf-8?q?Jz1ADk0SgURVC35fWsfC7pLNMgB3qRfXBGCtOusy8scqlx4sFWsl7NFTIQZRt+7A5?= =?utf-8?q?tgDykyQAbWGS7+decsMfhakKNsEvKhi+falE1RBpAXmJ71wuTgbe9c4lgP3/TUOiZ?= =?utf-8?q?sF1fDQnB3m+/MNa68QNNBD4i8OH3f7z+dnbGQaesA6+Vimooh6h+jajYOh65arXEA?= =?utf-8?q?2ZLocK6c7/nDiavBfW2WQiyqS9n0+Aui3S5BybHQhj6w+Ot4pNyWNrAKKTidunkDA?= =?utf-8?q?laqHFJLFA2/KBhLKkX0ZNDDsi6kHXQBd4vbwPaRbWQT6eB3Y5GRBkv4F4supxpaWj?= =?utf-8?q?IX4Ae00lypvW3FpA6s45FegeqgaBlEzdN3a023O4HweVsSK9ZCuu9hLYiPFQRGyyU?= =?utf-8?q?QShRxbKABy86z6FxfebC1qYRIWOBLGoY+Uhbp2BIRW24dABvSa7rCpG+B5y7mI+p7?= =?utf-8?q?WURYpmREgtUbK5+ZWkDaNbSOtmehrNjMEP0jOY1TfNYIyIUS8wHwz1i/v4GY834gq?= =?utf-8?q?YBVAtGMyI0nutpijVP5hm8LduX+bct3M337+d0ckU5dgp13/JfqzGcnFdSXtAmQWK?= =?utf-8?q?ls32xQ4blO2+CUnzDab4rsmyl5CytvWZZ+ErUrPY22G+HtQdFBwxO2CmlELMUHu/H?= =?utf-8?q?v59hIgqSJyEsjMikyUM6lMLx8ruTu+Vj/wMstcu3hyiNE0F1v1I2ovw3/hDshFcEA?= =?utf-8?q?f8EEs57fNybnxOKJlf7/jefw1nwg8ShQqwuv6OxoopqzpWqcICitA5c/8Gmjf9MrL?= =?utf-8?q?8d58KoYsY+96afbkB8qWyg2LXAJLEDkijrJfL8jCSszdIjO4URNj0rWA4zELq1P+m?= =?utf-8?q?X3tdBju99KQDqIynwaL6DCc/R0hMXG+0VUPiOi1rbh6e4YWeznjfAtn4WUpDEZvl5?= =?utf-8?q?nrGCe+5OaKHwdNPbWNWlVBmj7/dqwvAnAbaHBrc1W50ENAvCk92gIy/3akg1rZuWd?= =?utf-8?q?cM5VMh+j04jMfQYQMtEIfyRjyR7Tp92+Sjw502UuQoJDM+j2+F+xkHSFOBhVQs1bz?= =?utf-8?q?yZEUDRhbOdM1jtgqR1H5KaHQm1E2LKRkJXtSOHvSyH662SfUbzA1CZyfoGRTcNnKr?= =?utf-8?q?a9Q+L8wSpX3ilGBu82azv/5+h6Go3LItb1KAkdl0vCvICsGzFbMXx1UrxlILz0Wuf?= =?utf-8?q?tKse+LfZqCbPPflxKC+zFeIcBDVf1T6Aa0X54VNNpIwJZJCi6+H/ea1r8kKvucKSA?= =?utf-8?q?hjkeNBjkkpaN6yr8Uc2EMAqwSQAAvcWzrH++vuBMLX1Z3mrQ3/YRcmMTnO8GKmKsI?= =?utf-8?q?v86M/+kssC+Wmd6jJwV/HfrqUAErx6h1v5IuA8c20tLB3BuqzIuEStWHcgPTJr1Cx?= =?utf-8?q?P6IkptRT26ShRjZjiPRPHTQ3XBeGSoWZCVFvF028jV5sSA1MBCsrbi78A4OWWA1D4?= =?utf-8?q?g+FsRcbvStiosI1rrbSqBlknbJ1tEC2KapCrKnxgrMjPKUuSnP+EIZP6vK3Ei/8zT?= =?utf-8?q?E34OoStCRr+/G1dSPSoW7eGEQAhOgrM/d34iK4iWZfbjK2QJAqUYReAvyCI+mqod3?= =?utf-8?q?YzkaezaOWYmi?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9890010-9db0-4489-4369-08db8d8d1e93 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:02:24.6947 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2e6/KT1yLzCuutA7LTshaDm6CJd7CQMXvjbkehI05pG/DvMqSoAvaGyZ9yeZ/uI3msAxpWwltp2FhVhQFFMRPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5139 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Acked-by: Angelo Dureghello --- drivers/mmc/host/sdhci-esdhc-mcf.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-esdhc-mcf.c b/drivers/mmc/host/sdhci-esdhc-mcf.c index 05926bf5ecf9..a07f8333cd6b 100644 --- a/drivers/mmc/host/sdhci-esdhc-mcf.c +++ b/drivers/mmc/host/sdhci-esdhc-mcf.c @@ -489,7 +489,7 @@ static int sdhci_esdhc_mcf_probe(struct platform_device *pdev) return err; } -static int sdhci_esdhc_mcf_remove(struct platform_device *pdev) +static void sdhci_esdhc_mcf_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); @@ -502,8 +502,6 @@ static int sdhci_esdhc_mcf_remove(struct platform_device *pdev) clk_disable_unprepare(mcf_data->clk_per); sdhci_pltfm_free(pdev); - - return 0; } static struct platform_driver sdhci_esdhc_mcf_driver = { @@ -512,7 +510,7 @@ static struct platform_driver sdhci_esdhc_mcf_driver = { .probe_type = PROBE_PREFER_ASYNCHRONOUS, }, .probe = sdhci_esdhc_mcf_probe, - .remove = sdhci_esdhc_mcf_remove, + .remove_new = sdhci_esdhc_mcf_remove, }; module_platform_driver(sdhci_esdhc_mcf_driver); From patchwork Wed Jul 26 04:00:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706827 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C02BAC001DE for ; Wed, 26 Jul 2023 04:10:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231808AbjGZEKR (ORCPT ); Wed, 26 Jul 2023 00:10:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230138AbjGZEJf (ORCPT ); Wed, 26 Jul 2023 00:09:35 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on20716.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::716]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEA5E5275; Tue, 25 Jul 2023 21:05:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h4yQtpfsikGP+qZbYLyEYz9uAzb/jC9SAK01Rt/9z5Cd+MY9UzLMIlyFDzxOROgB1PSdrQ6dZxlAf9YXFsdEaCTzoOPgpHmuH7/Aa7FDrjdxZxmIMhHE8NbCYKs7MUfM1ZG18gyOS5q7cFesp97+VTtvYUdNAEd2iLHi9Li0eAWc+FKnHUcZhqEjpea72IBhqi00Excc6D3fPSwb6fn5jUWxOiChJ8OYzIlufBmuST3Xxr+dhzdb34cfzcxC0oNL8G/3RLuJ+x3LaSdonvB6FeImneCbpHqBJ5m9vOaH0vlURpZZp1RvoKbA4L4DHjXqWY4FpcgBFnlAIoYKT4kZsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TEBm7LsosykrIZ36xdCU79ltEaLYPmnrbi8vErCUUN0=; b=jTk45OyIKvO41egTVt93tjH70t73Su0CsVUi+xRarkJXe74Mh/332u+Bwy3f28pmLLV4IHrc+SyBiXqBBxienGjEncByZjhH15BYtTRQcygEMPkq7LAw2SBuB/tg+wT+hVnC8kxi1MMmjf530NAj//p8ai/+Oq3Tm276Pv7mNKsbKdiK0BduDKTl1xJ1Gh579mcieLdcOYVKTHJMgbr0bCc8mwEw/oGukMlceHD7khOBkzSF3opF59nPylhycS/baQ/0K8Y2IUls3qhiNqZhVsFQIaW/Ew3CEyYJSqNBE/MI0ziVbG+mWm+m2FW3yrODpTC+vJ3c2UmyKC9DhE+Liw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TEBm7LsosykrIZ36xdCU79ltEaLYPmnrbi8vErCUUN0=; b=atPNBvvYs64LVQUOmNacUMTLfBb5kF10Uhiyon2Vgsi6QI9qFcAVdzoT4OTAljOnZSj4v3XLlZIlJLik6YzOHvgIVwjgRlH+5wXtqvPU8xUpLzjwmAJYR4RKt1gzA2jnED/pfHUTnoD1W3tg1Yu2rfItenUxT6IiZYU4xH+xpU9IdDlFwqWrFbH5SPFluX9vxRjgB1wM+XfgHCAH2/xiNBRgVSOYG+ya5t1PfcDSLEKzn4oUHetFV1JQDbS1GpK9sE2PNMvS3wi69AQUGs+dLMZEotNjuL0dO392zR68l3+wUniKGXjFDj6sDXvzwfHWpgUVI3vez+bk6Mncc9Xx0g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SI2PR06MB5139.apcprd06.prod.outlook.com (2603:1096:4:1ae::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Wed, 26 Jul 2023 04:02:33 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:02:33 +0000 From: Yangtao Li To: Adrian Hunter , Viresh Kumar , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Viresh Kumar , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 51/61] mmc: sdhci-spear: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:31 +0800 Message-Id: <20230726040041.26267-51-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SI2PR06MB5139:EE_ X-MS-Office365-Filtering-Correlation-Id: dadbe81e-e41d-404a-8c63-08db8d8d2079 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j33NjLcSB0uobzIPCJJvC/W/UE+awO7J6fWB7Po0shoGQ2OWULPU3Y04tYNiVLr6Zffp7P7PlSY5UYOSC9Ppwmpf46ExJJcPDV78bMSsGzwfZoflnG5c//zfpujiYvUmVv9P/AGfe6ShAFEc4TfCXRyq7Wwpsw7lP/5rjM7ZeQM2824YRaL8gJ64uu2sCAN1RXKaFI2Sk2uYZ18KBeQ2vslZNNDnKOcO5LcZL4rVVz249u/pBbp5jCRcG7x5QZ9ZHFflxR5nfOE8W1q+TvF4TOWP4BybGxMqUG7kv+cVY/eDfTnoSkX2u8hDdsiPEblID2KryE5DR+cgm5w+tzJP5ru0hL6TAS9tKallcJmMs8ZxR1U7xFTc5Yw9h8BY0x3ybqUn6g8ZQQqQFnbRmI/Y+NqiPCOPSRgNcd3ItlSTNcF7EZV+M+hy7ep7GZ3iGBfJsWJq/EUihfh0rJH7aDkIseTAoWd/wOgRsX30/AlLkBTLWULuiy2S6oDjZDbHGSjszJQ9fSyq8hdheYHCnNlq6zq+cKVe/qPN/H0bVV9mGz7guT02lhCARhp74t2nkppTl8C7rlAwDcA06cFGcRmWZfAtnAD8epwAOdmLTJzNV3fOhErcBHGVjQYibVP8ganz X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(110136005)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(6506007)(26005)(1076003)(86362001)(2906002)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?YWAt1dvYWadZ/gmz77Gw7QoVdUWh?= =?utf-8?q?u88NhwLTV8g9ODlphXs8RGiF20nJ5jVL82HEcVGT13gNypk3/RviW8W3CXb8RhOu9?= =?utf-8?q?hmhSpHYXGX9bQ9eIyk5lFQsI3ua7NE0NfDn0p62Wf1a6rOeDvjAWSpoyeW0WaGBLP?= =?utf-8?q?MMkboHrP0Ey9mfoAh3t6RqbU8bARD3ANy5R2WS+TliWXmm73J2YJACskXxN+M39Wr?= =?utf-8?q?Kms9DCuBMba7OTypEvEquZqqB0PkxwdGJvoSLuey8dMKk1L/DzkTbvP0ut77byWzz?= =?utf-8?q?Vk5H2NqyDHdL0IYC1quH1ABXn9U6MtUrs+9Jtqa4YL9SbZNNB45jJacpYOBGrHvXl?= =?utf-8?q?DxSYSHhCI3xP8c88xv+QQv3/iHTANP6p2v/wJ4/aujxXcfna1exHu8xPv5029fu2K?= =?utf-8?q?1oviHIVHSNBZSmD7HmtH2bF3gdUnTJ9N9xtG3SlLu4AB7JRx6+uiHHfMBocg2EMbr?= =?utf-8?q?SuU+1a6jmdyYqjHwAFdnoANMuDUmIoc5PZ+YH+2j6x3gWknSvz7Gp0DPtky3Eeb2R?= =?utf-8?q?mjyWs5gTQXHoFYwIbvxaLMzfVBgF+2uAwU1GVDYLtKL3ZJvadji4GX3C/4cXHoa9I?= =?utf-8?q?3OkP3/uVcOJD7YjRyCA4swUMWjZTqrXKYZ+5Tks742p43RT1/7BkKsLbGWhdzST1R?= =?utf-8?q?hqV3aJMzYl7MCRp6LyukmKFsl9uM6F4H/MnJl2D7vbzZPfZCsgh2Z7vO7YfjABZ3C?= =?utf-8?q?aR5Xt7jp1UPU3OHd65/1rG4tPBkqPQNGZscPw4vkWsWU/ZWT0GgXle9I32uAF7emi?= =?utf-8?q?U7BxORIsWpe/bVYdsyuOd3RsRweJtQrDxPXF7qKYeienvjEjhTtGGXqbNEUaiuGQo?= =?utf-8?q?pfL0nOedQUlmvyVC5pGRHMnk6rp15EiuNNOtvBXyPgqKntyCS3VarNHPIJXsVWD97?= =?utf-8?q?CiOTSZFVX0sS2L6ma5aPpjU5Cnexw3doPQqGylA32tP+DOgIhgM3AYhgF11Jz0sxJ?= =?utf-8?q?ufmFpDs7CGf4YQKh4DIQ9q6Jq/pHQcTr0P4cOTY5DWMqfoiu+tALYtU04DTkL05Kg?= =?utf-8?q?ShqUnKWtmR4OOnM6vFullu32Sp8Rs5+O1AnkCr+YNGV/RZdbPk097/+EZOC/AiaHr?= =?utf-8?q?nlMcIl6G8C4RCmJI1QCX2WmpsJB0n9/+IMUzOWChyO+rBQJxRyr1qv8PTo+5wiD0V?= =?utf-8?q?0joDPqGKQ5MxKWI5DE+93itOAgLWcyuxGu+e7uC97U7GUSF5r9r5BxESADVf+aNdD?= =?utf-8?q?tfcuGkMwoiC3MF/+/jZl5Q7GTxiXdYYOwLFZKdk8OI2a2EHzsfhi1sWap5yVCxvzd?= =?utf-8?q?z4Ff7mYIJFXxmwRe10dVrejlKX+alH4V8WEgSkX5byeKHCagp0eqPIEdBfvASn7Tm?= =?utf-8?q?5gzcIvgxuRVnTWDloWRrBCXWb4sLxufIk6X6bnNwqPSokfXzJ91cQWNsYl6CkEYUS?= =?utf-8?q?F0o3VpqIca9Xfr0XP/FiuczJWr8PE9+tyGrGVTa45TUsn5MXA01ez+6OMb+tPODP9?= =?utf-8?q?qGMneDifM21/Btkr2PvqTCNJMdh2iyDFLdN1v+b9py51DrRfW9qqw3FEdneZeEaz1?= =?utf-8?q?qr0bvtM/qR50?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: dadbe81e-e41d-404a-8c63-08db8d8d2079 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:02:27.9395 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Eby7EtEoMiuMK9Sekm9VIb48YO2FHXu3GizbaJ+wF4AwLsX5NX9hvAytANckVV+XczEDD5gUnpfAeo0t1nkJ9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5139 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Acked-by: Viresh Kumar --- drivers/mmc/host/sdhci-spear.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c index c79035727b20..ec6c7d8e3736 100644 --- a/drivers/mmc/host/sdhci-spear.c +++ b/drivers/mmc/host/sdhci-spear.c @@ -117,7 +117,7 @@ static int sdhci_probe(struct platform_device *pdev) return ret; } -static int sdhci_remove(struct platform_device *pdev) +static void sdhci_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct spear_sdhci *sdhci = sdhci_priv(host); @@ -131,8 +131,6 @@ static int sdhci_remove(struct platform_device *pdev) sdhci_remove_host(host, dead); clk_disable_unprepare(sdhci->clk); sdhci_free_host(host); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -186,7 +184,7 @@ static struct platform_driver sdhci_driver = { .of_match_table = of_match_ptr(sdhci_spear_id_table), }, .probe = sdhci_probe, - .remove = sdhci_remove, + .remove_new = sdhci_remove, }; module_platform_driver(sdhci_driver); From patchwork Wed Jul 26 04:00:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706826 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DF92C001DC for ; Wed, 26 Jul 2023 04:10:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231862AbjGZEKh (ORCPT ); Wed, 26 Jul 2023 00:10:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231535AbjGZEJu (ORCPT ); Wed, 26 Jul 2023 00:09:50 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on20705.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::705]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4DCB10FD; Tue, 25 Jul 2023 21:05:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XtEYlxloX5axZx4BeX3VCE5WQeJC5Ipybp16FlmIw/MbiL2c1Oo5VzTgZ8j+tjTNzawxBF7CM6xhlF9eIZVvK17cgma70H11M1kAC/swl2HtFnjZO88tThQJ61Eq9H0cfaVCnS1Jg04mIscNxfAF2YMAhpSrl/gv5+rezZEL5V332xz/P2KZB/7XEXKHoJFfx8ulqU6dB/ym1M9jdVDW6tkK8ruj3ZiBnd8GwdnH47RFAdlPFIA48GyotAtT5OnW5hqdpnVqFfpF7H3fQJ1o/NmHnxQ3A/j5isUtOzLBCbkLhsfeUlUAGr/s3wltnrRIuLaCohmvLoJMbFXZudWX7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wphu4Q5Iae50th4Q/VjZF6H8HkQGUHhGQ950+qm5eQs=; b=Nr64vaYahLzjogNYX5NJOebtpnoP/kQjoeuZ3cP5XpCM5hao7rXF8RxyewqHwvWPl+oW3CUfiItUNgRwdF9iB3aUi+E/1byo2jCJRPoyFto8zcskY+W7g4VKyGIBr9vaOEO9jCFb1806+ZoukHEJqH0eYAfmdqcFF0CP3rHPMl1FGpTXyy4YKHcrUVzrwLqQbKyPIpRt0PIPbJ5rWfAC8XiuAQeg5an781W71N4jQTr23Nnu0gEsziTxPmjw2onArqU9V+Y+Qp1e4LtU+0pYnO4SnQqm+/hdWNVC7gwTdTbUW97dAwCj/KwdDbgrHIxnSJcj7nGIj//RKg7EgtL0BQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wphu4Q5Iae50th4Q/VjZF6H8HkQGUHhGQ950+qm5eQs=; b=htPkndb4I7o2fT/YTB77qbP6kGRXk6m33JaTBiA6itx7BD//IW5kuxRISiNArkZibAhkgq+FJhMc3h7UqBZby1g6oIfgq9PpuPT+TBFKQBh7Gr9ho8L7RP9H705TJRadN/3jrKliQPLQS7ZNx+Ee9nVosnQKTuYDrFmKaXMTxH3A57QvkTjXZxaNuNqHM9k47G4xhLpCadg9NxHHwjS7sA8eb7PEMBg9KE1P7ga6RC26IEFF8diAxNQd6qDusvyWtSEu8IUrkE+M0+e8DMoT9Krpjp+alD0BjN423qNvvZYZhWKFTShTLy++MBWEko0jbaY36xvpmAbpezGQqDJa+w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SI2PR06MB5139.apcprd06.prod.outlook.com (2603:1096:4:1ae::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Wed, 26 Jul 2023 04:02:34 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:02:34 +0000 From: Yangtao Li To: Nicolas Pitre , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 53/61] mmc: mvsdio: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:33 +0800 Message-Id: <20230726040041.26267-53-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SI2PR06MB5139:EE_ X-MS-Office365-Filtering-Correlation-Id: 9048407d-38c0-4672-b455-08db8d8d221a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w3RgvNhkKnTKokoDxonbEs1L4gsw6ZU/kmyEaXlGCROKEqOOQ/7YI19OBgRKkLpYh9SOv3Ylnq6cOQ0Bli9uJt12dsLMiSx0eomNcJhVW/V7TerHrNrzAROGUzdYH6RnyWkoFjgATd06yy2LPwKn+hNgkwl4hHEnrzaJ89ajdii7Cz/xc1ihoT0wz0xrr5QC3d+3KrW3L1LPjRZhVqw/mSV/2AzgDcgpi+XWngVCIJLJwi6aPH3Pee46MlI+7NPl0luYmv40TNbxpkZbgQ0iLVeXjbrf+kmExByxdF2djuzHYFTDnCvyIZdwM4lEf1IzFsEc93OE3ThCnfevIiPSrJHjMNj1gPvOIsX/bdT8x18hj4b5t+CUhghYYUStXwqkLB8HosvaF6Ldi3K0i1lC3m1Bu6KYB7l66U48xveX4gdK5Xn/6+tJHfhB0zk+jcviRK8GR8DkAs4FZxdIfGNY6436sbBArg1NdxstTNmR22u6CjBv0c11om84UgYrx/VHBBMoDZuDZDsnAgg04bK9pXQ/X3nIohDJ5PzKM7Da+zd9JrfZJ6Xft0kpP5jx+4/nxk351o4S+kGS4FrPLcN+emAki3vhBL+MDITD3ykjLEsiuICZxfBeVL+AnfwtoWwJ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(110136005)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(6506007)(26005)(1076003)(86362001)(2906002)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?3QuqZSzt+o1CQeF5hUVSZCe4QC7d?= =?utf-8?q?bUsQcI8zN58KS+bOFR054sY+JEz+mJIFxZ7jJh9VzOpDNlejt4Ilyc4gig7bPOLta?= =?utf-8?q?Zk4+HuRXU6aJIjAB3POeN/e5RhitWib/y9MzD+xvMYwadQwr5pp5uWwEBuzlZpTJ5?= =?utf-8?q?EEebgmITQxHxl9+MYf0auCLmJuwAbWoEtiy4nb5c18XPEKlRPKDhXyTOKgQvKKJef?= =?utf-8?q?+66v9qv/fZRyOAV4xFtA4yqko4amDw/Ne2Xf1EnSk0mQO2JH70qNnySNaY9KMHTcb?= =?utf-8?q?po/2XVA/WKv5TcOnEf2xRuDMEa/OEiQ5VqHht+0bUWAGp6XU32WxPVGMZ0CJeTLH9?= =?utf-8?q?CUbEpbzBKOmMIMbmYm08tk6yWuABxGL5L8b9crx7XAezbpX3FgLzldpr9D5omsmQh?= =?utf-8?q?xwsuaMI/E7NhLwGfWLVPe3jnvO8WMeGr8VdfVTOZmc5i2ywz6Td41EmPjoizQuwn3?= =?utf-8?q?vRquh/06sNAz7IhrMkWS6hEyx2WXJxLOoITmmLMN/8Eos/jsriUPWS+CW1el5i9Q9?= =?utf-8?q?UH1f+Xr7Q1lJ89EsCB75E9v/4ayXbfoEZIXDuFGTmSQ/Iz3BpLTnFipvnBcJJRNSN?= =?utf-8?q?6dwEiEsT80MGmWIUQSsBFje92uw0M/Ptq2BDspz3DuHxbgCYK1kM8OIZf+2Ywlzn4?= =?utf-8?q?jOeOFkOUM5itueMh69KRgvwHPCQsUcpfDVhIyy89NGEQKv+ba+XyaWt4+TMEJF8B6?= =?utf-8?q?hjoDlqY3J6Y2F+jzXg1W0bGdF8b74Rlz9wGeYJCupZJAHHRMjeZxZ/68oHEQ+y7QQ?= =?utf-8?q?kn7L9BcKtK7aAmnlkb0lGAnWEKjGmFq9EniI7LuVdIjIuzJJQhryQCkEEwIQ+JIFr?= =?utf-8?q?vKTMXVAV3HKLvGeHQOAwSDD9DFwg6QeP3Nm4AqoPjbSSAZP6diV9vIQF7e6qS+7ZA?= =?utf-8?q?9TkuEMuw5dCkXV8yAI5oDJniIK3kkdxR6Qhod4qWYaVpzDWSgOd6la3hPCyOxqB6u?= =?utf-8?q?cv8kkuaIEgztB4ED4ofIe0hjs6d5w+r2ZUFCtiY3IHUBwcWLxGD/qugCyaTL5+Pj8?= =?utf-8?q?7V4nRcLn0gkk1dbRQb6K7IRMoKTDiRXjDhcD+bMdohLkRvTjPidWuvgtSBG8o9O2Q?= =?utf-8?q?2AOnhf9wK4D6PdPmOT3SmztIBdff4GRygLxNTygLpSBoUSQVTGZwwagELNNLOM4kS?= =?utf-8?q?IBodILM8bCssM80fv0wv1UYMNDQhNuwNzugtr23qN44s4jydLHzFvOVpIgzNrIMbR?= =?utf-8?q?dVzdLzE0zkAYpGipqPqyUf8HC475n2oT0zFhzcw2JVBgHLasiXaCn5o/6IGc/115W?= =?utf-8?q?2y0YirccoxFndf+pcZWr3IBhwD9T7IAtd7EWRkFxsFQyyWjuKm9Nuyia8sWkmJwPL?= =?utf-8?q?7+CJPGG2DZx0D6tfcVH+UQW7jGbvGnDMhlke4LRrOkezUCShB2vFmEBKH6fnWQL9i?= =?utf-8?q?pa8p4tSBGW9G+REQrV8/5Klqufdy1AjBV9KlDJWSCwuRzwIKrhusvfRmqXJNIitp2?= =?utf-8?q?1ooUEONrdXDRCaXm3xlyvGndxmRaptz/UM2ILlj5XABIKk9d29CgdWg+PsiieYnZX?= =?utf-8?q?16rhHRYK1+Hs?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9048407d-38c0-4672-b455-08db8d8d221a X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:02:30.6317 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 15KPZ/xfyuXs1zJFJ1sTNqY02xX5JwDpN12Wf4Ji0njwk62BHHZK6FtO4yN3cF0gXYLPfc/OP3s+axp8L9BDcg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR06MB5139 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/mvsdio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c index b4f6a0a2fcb5..ca01b7d204ba 100644 --- a/drivers/mmc/host/mvsdio.c +++ b/drivers/mmc/host/mvsdio.c @@ -796,7 +796,7 @@ static int mvsd_probe(struct platform_device *pdev) return ret; } -static int mvsd_remove(struct platform_device *pdev) +static void mvsd_remove(struct platform_device *pdev) { struct mmc_host *mmc = platform_get_drvdata(pdev); @@ -809,8 +809,6 @@ static int mvsd_remove(struct platform_device *pdev) if (!IS_ERR(host->clk)) clk_disable_unprepare(host->clk); mmc_free_host(mmc); - - return 0; } static const struct of_device_id mvsdio_dt_ids[] = { @@ -821,7 +819,7 @@ MODULE_DEVICE_TABLE(of, mvsdio_dt_ids); static struct platform_driver mvsd_driver = { .probe = mvsd_probe, - .remove = mvsd_remove, + .remove_new = mvsd_remove, .driver = { .name = DRIVER_NAME, .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Wed Jul 26 04:00:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706825 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D432C001DC for ; Wed, 26 Jul 2023 04:11:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231789AbjGZELH (ORCPT ); Wed, 26 Jul 2023 00:11:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231803AbjGZEKN (ORCPT ); Wed, 26 Jul 2023 00:10:13 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on20726.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::726]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D25B2706; Tue, 25 Jul 2023 21:05:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ClzoBSL9brjrcUt4PccevHiac55DZ1/sKNIeZWjrbJr8xEgM+ajbxRmSZ3ccKbHOD128mh/VRVu8oPp5ZY+9RBdO7bvETU5VPx87UWPs6rW3lMQX9fkmaDtIjLtleUofm4aNTIW7ltT5U3NCILp2Ri9jMiOgZMAPDaa1OmbQMkHsXBEtvxNDZDerIarD70HrPJHLLQ2rxG9NFHvSz72jq1IZf9iuchazNuIp8N9McHIeQYLUPDxt0e3lSfIJXDDhr557q6GIGye0vcR/ZFgQW0eTaOPaNYKIpRU6cMR9awHr83Z5TEhj2ad8TyJI+9xOdBRzuGMVooBJnTmxdjBGJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VbvoRarTmihEE9SfYnfLmCP64NcG9T0qKBlCHawhwDE=; b=QuCueWqNKCcn1oVIn3P1EvkMwydnH3t7wthN644aq9yab0AKxcc0Hg2w++XqHwbFmrbIbKplGxRgjVsaru3uiontP62uTveEkBBnACEi17m2YdcM+ukFIpJ+KozEXsRhfbEg0+rRBY0sI/8IZcqQOKPQnKgrM5sKcnoFHU+g5mJ8rt0LMzkHN8+vkucqTknjsdpcLqfMQM1OcGZ4OAdq2Ip58nt4ebQGgGy2qpgORuBYJk0mrkeanZRsQL5Ug3T0JLDyS5kKhUS5h9nffc+JcmOwYq80vWOaM3Pt2ZWzJhIW/56M0SkFwOktCRvahvWt2GRRTD1IOxEKO3QAlvKkfg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VbvoRarTmihEE9SfYnfLmCP64NcG9T0qKBlCHawhwDE=; b=X+QYr1rwFc0DhiO58whUOCKExCTX1vAhVe6Xndglb2Vw8kkKMueFiUwWYi3fgJmCIqFM25HcZm7zbJTdS0skY9CH5nOvcoyYkJXnKlbBWbdLKTMhaQJAe4CYaYKEUIXhxWXynEGkFFYDryRhcVr7SW/jM8e6dBlhjcyxK0TMj/KlY7ACjOyK30Dj5aW4rVm2NOqhnSZKpTGg8ma8iUyU20Dgh7nS279tbYDYFe75Sj2h+6cms7Mf7xBux3dmpWlkOI1G36SU8yCk7pKGEfiuR9vj5d+rk5POQqvoH5ub8FcZmG2Nl6bKdhV8VmNUaFyBprohdxhuYl7CmokAaZiNFg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB5463.apcprd06.prod.outlook.com (2603:1096:820:c3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.25; Wed, 26 Jul 2023 04:02:36 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:02:36 +0000 From: Yangtao Li To: Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 56/61] mmc: pwrseq: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:36 +0800 Message-Id: <20230726040041.26267-56-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB5463:EE_ X-MS-Office365-Filtering-Correlation-Id: 255304e8-317e-4ac9-0665-08db8d8d2471 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XDuo4RgKKkmlz4DpeqahPkRKYddJwsJ8XM4dWjwXqNv1KsgpA6aGgn9y5wtc8hb80cY6S1srGYCqEFD/pa7c+GSgLxU80XpTnASgjDl2GyJamXM/Xprur+2I5GZlEN9efMb43eEZD21W5FoblBDYEZCrDWa+pFgmHbeMWPpEty+az2J7rDSUNvQNyT5eA/J7kh9Dsmtj36CV28U6qIChfBlaj+xMDWX43B4/VmMUSsctxgjHYo/JNb0g1uMBAeUtNNLvMjlwXS+3Ck5QOBeeaB6/kPk74QEiI0SKCJx/ceL+zApYD2i6hG8aNgrA/6QG3fBpoYH0XDQ0OrGFmWD1O5xGH3RwzczuI47AGBBcbaNFX5/2iy8ojRNyXKptu2YcUIGEmrXQ/LO9VEYc7ys4yYNvscHU8grymsNm3j4MPjg+zCa2vqXGfE4mZi86QFOsW9pL7HJvlF2dJrlRy1WszH+6lsA8JwXX3/nnECV4TkVzllzFETWtavv1WribtcJ8BZJv0sTSzWJdlMODIFcJ1FO7bfjUnv02hnM9gAPWmvS/O2vwKVzF4iR9ojkJUfnvRGxmYp/NOGmBXfoSnqggIX9ZNvC5lYuDIycdNQmm+rWA5mx71dzbo5N3Zpe+ZlBw X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(6916009)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(6506007)(26005)(1076003)(86362001)(2906002)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?e7gBNFO/mNdT3eeGpBMh8a+EDipy?= =?utf-8?q?kBWZnf5R+VBySCRg8jM0muByksvt3lZ78TilUui5Kudx1ew+2IXlo5TsmqxNmTBQ8?= =?utf-8?q?zk95fw/FrzrC4AsYP2qpKmzKoAZBDB6pnFsPJlA+qedpKQ+bKDFku+2aZJyy2iHOC?= =?utf-8?q?mAxWWpofr95EjEKIZxP4PFHrmuvZ9AIZA/SYuLq2PREkKY2jwxlFf0FxTx05D991g?= =?utf-8?q?yei9IGc46LOciBDwlPGN4xHgPnucEmMrLpQXMX1hdyKjrjS/tEem2sowRZbLNfMzt?= =?utf-8?q?BQbXX4t3lCpj6CKG4TQSzMYfPphBHnLA7DzO4h/bFV4AQzFvhxpC2tVHLnedOKrvX?= =?utf-8?q?BzyApUUfIOHfWUQYCoXWBUhnfRaR7movIUDd1E/xVTzPn54cJjRm2BKyBBly6fpVx?= =?utf-8?q?2RCds4wyHnbYFOzPQbbYyRhcnTBrGjNOYRf8oeOcBp5v9StQcluOfVBSvbty22ILH?= =?utf-8?q?BL6zadA7eIKO0EtClzOwS5UlGIlyCSbmN8d4bDrWOWNshRpKppCa4Rw7KKfcbpt4D?= =?utf-8?q?acxX3n2zNZoq1IBYmdIK5JpX3xOOTZIBe20OAWukKfO3k/GFTjXLAG/oh4xpqCqj2?= =?utf-8?q?xGnAVXfIqBgOuymehHL++f0SPaeRFvcXnqWd5nSz7VTagkzclfGrdPJ2dZF7Ab8QA?= =?utf-8?q?O+N5t6juLfhb7EO/yezSGc9EnKtil7TGCVTcTOU8G4bi+IEFvimvBmzoiYoC5JCOy?= =?utf-8?q?lghGhjb9VJX1+d+6KSkM8RXxZSf3PQ/6WIlEPJlZpRUKS4HFRbqwLAGHZDg9MP/1R?= =?utf-8?q?BYmiSnPm+pN04aisGp4GuUTh4r7ATYpoI6gueiYyIcTomgvFFuergKw5QGdz+tKyu?= =?utf-8?q?WLM7w98bikFn4GclMu+pkIuSXKxyNKYh/v9Qn7hKwz0Scp3IYgK5LniJwYvZFXqyz?= =?utf-8?q?gEOKRMzi6vQOIprhzI7+kvfH/PKIQJAr/n4pYtv53lVNOw/Pcf3w1rSz6KG0eNtKB?= =?utf-8?q?8Yfe/wHllmKFHMqWomVKCiaHaedSNrHJkOp1Ah/wvRpSS1uATjV86AR2Rn61j9+Ac?= =?utf-8?q?H3Fm8zUfwe04G2+Y+gtK9RB2wf5K7pQb7/tgyGqgLplRx2crNq1jOItjmPGSO3F4B?= =?utf-8?q?/6kdOo+TOIlLviuIqHiSa7ibZGWWExK+4AIxqmNm2gFTaEQZCq4HCMx2hG5KnH7Z9?= =?utf-8?q?YTV21ve3sDNdgxwl+7yXnrOLnliqlp/+H6w1Okai5vZkXpNz87Ovj6A53gKXPmkLp?= =?utf-8?q?O78yqmJIs5rCKROpe9VmpqN+/LGmbt2WsFo8DOzq6HSn803O2lynuNic2hiVU0iuC?= =?utf-8?q?ANJYxntT/sa67SkIMcXueHtVzKvrCinu6+awICk3fJpWrEgSG+H+GLLnS+RRGvkW+?= =?utf-8?q?HvdM4ccuuIBbiNKmmMTQzp3dG/QxQLLZhCPOxdgqT0B0tfnQ2/DMkHqqErM8E6eKe?= =?utf-8?q?f8E8K5KD9oMAlAHtQErhsMvcLYgX/emN0R/M2j7DvyaFr6UTLxlpIaZvpQKurHHpP?= =?utf-8?q?l/zGWXFmw9spZzuGRULAVePCmWEcNlub5tTRthUhO4ADdN+FDcXn2SpCIwxXqAHNm?= =?utf-8?q?fW+9zrwqbOH3?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 255304e8-317e-4ac9-0665-08db8d8d2471 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:02:34.5672 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +rSQuygig4aqXYqv+R4AvGmDGqrURJVVwSuEQTSc5LaHpYELzGfZKP3773E1Lk3n4FMV8S/5hHCe0CEndPk17A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB5463 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/core/pwrseq_emmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/core/pwrseq_emmc.c b/drivers/mmc/core/pwrseq_emmc.c index f6dde9edd7a3..3b6d69cefb4e 100644 --- a/drivers/mmc/core/pwrseq_emmc.c +++ b/drivers/mmc/core/pwrseq_emmc.c @@ -90,14 +90,12 @@ static int mmc_pwrseq_emmc_probe(struct platform_device *pdev) return mmc_pwrseq_register(&pwrseq->pwrseq); } -static int mmc_pwrseq_emmc_remove(struct platform_device *pdev) +static void mmc_pwrseq_emmc_remove(struct platform_device *pdev) { struct mmc_pwrseq_emmc *pwrseq = platform_get_drvdata(pdev); unregister_restart_handler(&pwrseq->reset_nb); mmc_pwrseq_unregister(&pwrseq->pwrseq); - - return 0; } static const struct of_device_id mmc_pwrseq_emmc_of_match[] = { @@ -109,7 +107,7 @@ MODULE_DEVICE_TABLE(of, mmc_pwrseq_emmc_of_match); static struct platform_driver mmc_pwrseq_emmc_driver = { .probe = mmc_pwrseq_emmc_probe, - .remove = mmc_pwrseq_emmc_remove, + .remove_new = mmc_pwrseq_emmc_remove, .driver = { .name = "pwrseq_emmc", .of_match_table = mmc_pwrseq_emmc_of_match, From patchwork Wed Jul 26 04:00:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706821 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14C60C001DC for ; Wed, 26 Jul 2023 04:20:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231909AbjGZEUk (ORCPT ); Wed, 26 Jul 2023 00:20:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230138AbjGZEUH (ORCPT ); Wed, 26 Jul 2023 00:20:07 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on20723.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::723]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDCBA5B9C; Tue, 25 Jul 2023 21:13:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qra3j3Y2Bt84uI9mArcwYulDpPtgSh8BY0Nq0eQDFGfYsmlo2IeCjdus6nUnAwxeGQJWnUjqRz/hMAR+6tZDqi+wt9L8r0trm520BXW2/omfLjgCmU0SPVc0tbfd3nTtSVH2icfpAl9XJibgXmUs7+O+ffeBdjMmhoybhv9XhUOYWLBsAzKwAmOmc4KOdkUievD1XO06+UPTgL9u7agOomAuVdrmowKT+MKnXV5m9LV12DHhrkHvo0q5tORTytAqz8RJ7P01O9Ur37TOmjLcISm77++oBQ/o+Bc3TYhOXF8bDsrVOkWyeda29IYqgg1ImfHCSmG8U7lYa/imqnEqgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J5jSVvTfy21nexuFITYTeRJZPViozYwLNoQA6yut0bE=; b=F/14DRGxIniXezdfgCrCpsVo2hpRtTvEivsLcjiwAUg8q6RziN1uL7BA0VMbomdzcPcHXzbXNZOO36Tk418fEcKe/mixzZlZgCnkRfP1Dgkk/ALHUK9cppW1JSiOK090r3T/zCC9RZtax7Dgt6VHB2okAZjburWP3FgadWRnE1mG7c0+utjoxNL8yEYQmNq9IkR20bIiztYG87RsqydGApi3Hnipdxugs0CwBCDyYFyjXauHxLnSGHAvrJWVZV+GXHRSyvvw78X+OBvo3drqR0rOEZHUIWX1v+UNPE+B3djW0EuhF6O4GENQGw2zyoB/HXDvQTtDTfXKsn9m/4WFpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J5jSVvTfy21nexuFITYTeRJZPViozYwLNoQA6yut0bE=; b=p1LexOyjqnbBzq+FoyYzcoSDgywW22IRtWTdyv7SbeHEirH3FL36OYoWH91hMeTsAWdZD9h46MhKKMEgWLLv4yifLXvuFIqvs/oSz9lkYQx7hpze0akQ9VPXE86oYhr5UXLsWOlwEJaOwNTUk+gTh8FMccNMBZmeqOkuWx/DOV7p2bcC1KSEz24CgV5D/X4xbyOpoImkr+YGK++eH3MO6TibTy4yTI8wcIasfVgQJZunSgm93sH2wtcAWcLFHYp5ljDB0kNvePy7dBLTD+xL5Pk9TSSRKftnIaU0fFbSaiCSotj+29Cy+hgogRSWqpJBAo4X4fS+Ya+HWm05MJc0ew== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB5463.apcprd06.prod.outlook.com (2603:1096:820:c3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.25; Wed, 26 Jul 2023 04:02:42 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:02:41 +0000 From: Yangtao Li To: Ulf Hansson , Kunihiko Hayashi , Masami Hiramatsu Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 59/61] mmc: uniphier-sd: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:39 +0800 Message-Id: <20230726040041.26267-59-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB5463:EE_ X-MS-Office365-Filtering-Correlation-Id: 77260e1e-3cea-48bb-c51f-08db8d8d28d3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kS/072Ljm+QuZ3gkGCffYjgIRNrcJ9DcHAz9hpUY8S14vurIsNoYhZOIVoMjx2H/FJmjhH7JoJxtFIiV2/i4MY6LRHIWuvlsqz2ELxyoNHBTwUm24g0Xg6vy0YT7yN/VQiNlU50h1Gbjqsl1EbONEVRdgQWeaDT+lU9PkvkvQBe2j+7sDAU3M7xNfwy7Py3zEe66L79Tw92mNoRYHuUCGs2pkK9MIcFDO7GpSMEJCt0DAqnvbsde4/sC5SsAFAJyI48FbpRF80jVFbe3UAAq8E+9czHmsXe3Jadj2ZfThLIAzUn0x4apw49Xk3CUzIxVg4TdsT1/H2U8XHzdA/vy2pQq0UBg42WNpVpRz7bodnDou2zj+ik0m4OjjNyOZi6/WKyZ2YbyrLHGxd4Oz0opXCk/MUPPNBJRmG9fdpPv2RDOCMJQMVz/KsAUjVeSb9/T/FU4IB4nn+YGVQtS3iLkUfVtKBVpKDUBoqGAdNafGaIxuZERZjTrb2CFvNA9VhMmWGjgvlASjaJuDSqNdERM+99FgxbOPmaaj3+Y4tyimnNDWaQkuA0RQ60udgxiOIQ1g8j98o6J0eaQ7FXtZw7c+X65aTrHtWHaIoMyQK0paB1Xxj6wifssXTsqytYanoX8 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(110136005)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(6506007)(26005)(1076003)(86362001)(2906002)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?kCVy00+Meq1it1j8//9zhbHUe8p9?= =?utf-8?q?jd5BnBK5PD3/LUwJGYcABwHzw+kOuxQHeUEErmC3GRYed8UUw/yN99/0WKFBTPolu?= =?utf-8?q?O8W0bNmHKMm+78IO5EYi2tddaA6uSZraW0BudMqIDuMdVwRpy4qfMMRabJdNrFBBc?= =?utf-8?q?KzuIlg32Ngh24FPKSZObVXmmkIlrpO9ruuCImiaCFfK4Sz8LdABD0l00NLis11kyL?= =?utf-8?q?5JYIj/izNWNqSyvdbmsmw2H3bbjl2awoZKrdykpZs4Gw2HkqRepsSAuA31akhSaq4?= =?utf-8?q?5z5wRjqr4KiQ+f+4Atk3DUmzdkoXhVHERtrl6bpt0BmzBi/T2Cp9QWm0fB6I4NtlG?= =?utf-8?q?bE8HVuxwFKJ4vxbKDZc9EfBc0tjlMve3ZAlEAVUsTc7lIu0uw5zMbVsZbn7wsaSaX?= =?utf-8?q?312K03XRqZNzbRVaPQH9WMg+HVencpP8o4XdSug/jXwFQMEx8HPjLURHr9Ixv9upu?= =?utf-8?q?BCIthyGNR+hatqF4TecXh58V3PdJ1NXB5GVEUP//N9E2OTXmRj8bG0LpNEy0qK9Z5?= =?utf-8?q?VIaBMy36jVfh+cEBw8+auTTNRb4ZodpjdBA2iH23oa7v792hoNRqTiw2UQs+r1cMw?= =?utf-8?q?B5m2UNWVCy/SayFxE5JwCUBkCO4qsL1V/KW9FHkH2nLVo2G63iVViR90solqKn6oK?= =?utf-8?q?4d1+dNQ7TQ+t0sMguY2fTMk2p11cF0qwaq24WYNQk4XguX/dYwN7znU8xPPQ8d8vp?= =?utf-8?q?CxnXIrQg3uzpg6em3QkRXPSRPc2PGA9mpIo/a4Vzifb5sizSuwE43Y4D+jWJNkhLG?= =?utf-8?q?JeVq99bFSbMB8jINXU5NcDbspmX7Dd8hLwULFRXP+GSYLqYjRk7CmYqdwzvxu6jsL?= =?utf-8?q?ymPLSWczE2PfxxkEYSDymHoat/iIZvI1nKP1PatCBBgoBkv6MGGPR5xlIRssCR7XJ?= =?utf-8?q?lTW7xCHrejcbNgC690A96mr++mgW9OHzQhP/3WE6MBxPU2WMAEQUCa8n3u+0Gr8HY?= =?utf-8?q?NIsAisaGJ/v86UBPyn0FGfvZAYrHvQBstuzZ5tYyZH1CrGGkjsZwEDk5fUmXRGtgB?= =?utf-8?q?fuKchl8sKUWdwboQ4QXkIPQ71grN7gtfbrxZmSiYKY608qG0ldPSCsLada3awlGou?= =?utf-8?q?TUOdcgmNh06/Jsdut2HQZa0A0NHy081nLJ5+E/LO1A+G9M9crNaDKXvXtCVHEtcVM?= =?utf-8?q?LQMdhxuxtUHmoRnj6le51qIcXzb+G8drWvqNB3DiB8SsWgz5HfkE0Lyn4Jn+MCiwf?= =?utf-8?q?we0duiYBhg1brlXeSf3yHlY9GYEFEfNOswDgFfgfqt48JAYPNNl575UEtDNMLdt+t?= =?utf-8?q?dElGcK8Qvy5bzj+dzpNwq9JyVTbT1rN4V9c6ieQBrk8kD8oR0iDuGbWCjf9RRjyrU?= =?utf-8?q?tvjPofP5IAH7LogDWrUKk93DwRFRbYuUHMVsLzD1aWDCEppMYqRc0oqYVVN8/y4qT?= =?utf-8?q?q7388Jh8HXP+6qxhLRuudstan/grxvr2HfpIykW+CooLjF34mxRet3SKvoTvkUVLz?= =?utf-8?q?SAdg4UGYQYVqX0s5BOGIL1isElMldbyGYNoB7NdFuPATjx2KC/IchlZ0igw1KzA0Q?= =?utf-8?q?HUYnGiVIyao9?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77260e1e-3cea-48bb-c51f-08db8d8d28d3 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:02:41.9288 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iA9diAx8kMtmcQ4RVlwGZy4aLJ48rKAME1kPN2SBTEr8MC8Me2QwinKFdTF6tNNZpI/03iIK+4s6yyl0veVieQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB5463 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/uniphier-sd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/uniphier-sd.c b/drivers/mmc/host/uniphier-sd.c index 61acd69fac0e..33a4d1c6ef04 100644 --- a/drivers/mmc/host/uniphier-sd.c +++ b/drivers/mmc/host/uniphier-sd.c @@ -727,15 +727,13 @@ static int uniphier_sd_probe(struct platform_device *pdev) return ret; } -static int uniphier_sd_remove(struct platform_device *pdev) +static void uniphier_sd_remove(struct platform_device *pdev) { struct tmio_mmc_host *host = platform_get_drvdata(pdev); tmio_mmc_host_remove(host); uniphier_sd_clk_disable(host); tmio_mmc_host_free(host); - - return 0; } static const struct of_device_id uniphier_sd_match[] = { @@ -757,7 +755,7 @@ MODULE_DEVICE_TABLE(of, uniphier_sd_match); static struct platform_driver uniphier_sd_driver = { .probe = uniphier_sd_probe, - .remove = uniphier_sd_remove, + .remove_new = uniphier_sd_remove, .driver = { .name = "uniphier-sd", .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Wed Jul 26 04:00:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706824 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F84AC001DC for ; Wed, 26 Jul 2023 04:12:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230399AbjGZEL7 (ORCPT ); Wed, 26 Jul 2023 00:11:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231672AbjGZELS (ORCPT ); Wed, 26 Jul 2023 00:11:18 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on20726.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::726]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 206B22723; Tue, 25 Jul 2023 21:06:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LZzz2k23tY9E9DkzcFRmbjaNpQrBOTGkJRenj75ZDKzKnDndjCmTNKIVU7/4XAbD6eFXQwut8qnbDrRokFHPaZW1zfKD/+/1ykS0Nt2y2Fc5zvcbqGdZhuhFKseMvlC4vhS+ENQXD2yEeZW4j94XDEidEM8tkYfKdH9EGksnCSWOPga04iLO2QRZZOSL4UgSBr3nKzr/wbbCae2QcoWu3MYaubo92NvQdo8tJhCv/9Q1hZnrIwrVIeD3rGy19YY7pAFa1pJEiRYxFmGEUuTn2woBkQacOqbS0upnMrxEFwqyRi8E/bKfFrIDKV7lLt2eewdGBDWcxWzkM1NuI+6jPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E5kSZGu3d+Pk6TuHZ/mAu3D5XOULVl2/U1CyZRthij0=; b=V3YF1yyS4ud2582uxEVjvzBC72F55wDH35VNgUix9Pvmcz4jPVryupf6LISrmNIDGBRTmSHxsnKxNLUdWtAwvJg1pHTfOSMn2k+OCLaoA49M+XXTiL64N4hG7/dnXaPW4OUwPwL9RD4X1Kod9IkDMCj1Jv/2scL5SMCRbNlxEXKcxXaraguFak2Y8XzUnibzzaI08YqXsC0wcYVnEtWHdw+FOdUyvyQlchblJDkoHHOhFY5whAgVv+P2qqXHbydL5JRGHBmC0uMLy8GHOsAoTaQ3HzeXAoShLZlV+YdpntTx9/Y7Qf+2fezeQ0wewByQavAO6qPFTEdYWe0e345ktw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E5kSZGu3d+Pk6TuHZ/mAu3D5XOULVl2/U1CyZRthij0=; b=OcfGKrzDfFmG+sNI0yjO9px+fioRXDMmfy2PgFfKCu8Yhq6zCV7/bD3hl9JE6LPYTW7wyfOhMJcBU2o9Da+TGPq8hdsMbCcJc1E5jlrRQDFHGP9m617f0yksojjO0VoVhTE1AO8en1it1LG6AIDoVTEKLlvCYlEjjcmdK0SHt1KsBecEXEgqYqHLdLS74ODlIMaoiGgRmMVaOoU4k93Lk3fd5Wk2vx4yAp8H8e4FSJJ+e0NpyTC3pmqmefYORtBS7wlAjcRFCVvuDkRU1j1aXKdibJlWUU3NMqq0gqYtxB2Bkr+uOS+C/VnRURuJtWjcx9Ybgg8LGxVyu2gw5hvfnQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB5463.apcprd06.prod.outlook.com (2603:1096:820:c3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.25; Wed, 26 Jul 2023 04:02:43 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:02:43 +0000 From: Yangtao Li To: Adrian Hunter , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 60/61] mmc: sdhci_am654: Properly handle failures in .remove() Date: Wed, 26 Jul 2023 12:00:40 +0800 Message-Id: <20230726040041.26267-60-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB5463:EE_ X-MS-Office365-Filtering-Correlation-Id: 299dbdc6-bba1-4a3a-b0e3-08db8d8d29ac X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BjGX8+A+3DlKQM0PJnERwdyS1WGD5sKBYnpy2C48ArFo/Zez1KoBN56+dBIFjNU1ZqSR/M0PW4vtE4GOX1QFydUcjQOq9QISNJ/wmee9dvbWX4mnDIzys3G6yBa2I/CCarwechGswChtj9X/RjhsWeBnXWyMIQ74BfIp/1LzdaiAl3Yzs5hErdsMGnhOtWr6sKE2WGPnEG+OEseDQo53bVX50Aaccuyy7ZUS14gHEgU6rfbWBAYC7uh+4ONJxgZVDCtTEnQ0HE1A+/IhcMRHdbQq+m0Niz6aHZwLfyM2cHA0p54FVoVTFRwBW+EjrFmCaBrRTI8T5R2EayDxdz6jG9DPKNAjM7+My3f7J3eRhNVsBxx3VhEELMwzQ1hceYRPb4/+p6ngk+wRIYV2dyhOEuCNG3vblxUUYQlunDp3tM/FVtmNvsqjz5CZJ5CeyONbRG+UOYvkpv/fxGhDXC3D9XVhYiWhaThxzFYN6QTADzmXVb5uwilggNFBI6jdnw9CeuYgT+ZU/8nThEF69PDaB/qmsDvWg3lu3iS2N7RcZXLt3rq0QZj0DWKWQtpZKeuarXpwhQAquZV9B3iVX0rxG9oBjkkZ6KwUQZXDT7UorMzqTQ0Z4shI/NLytFnXMvq4Xflvf4syEWDQUO+QLU61GA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(110136005)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(6506007)(26005)(1076003)(86362001)(4744005)(2906002)(36756003)(142923001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?vTYNiWug5Rh3swS946ANa/1ZsOdw?= =?utf-8?q?m1lqbFET3ClSQo8Ro/GSFAbovWaMMa5KL2+DRT0hkqmn0C39kA3zeRTRtZFO52I52?= =?utf-8?q?NeswSXat2nA1kyStfS4XhGvqcVoQj7RqDo0/7s4PQjQEQwcXvh272fXlvCc3PMmBV?= =?utf-8?q?l5yLa7bMjyJeZxSdxY2gODQSVFrIqBUp+z9ehdohL3e3XlRKN6q9wkN6QJ9M1+Gu+?= =?utf-8?q?YC05vSmZPBM6AdJb7RGafpUBRvEKvgSHBlzg2w6Mg0/WjslTdNqdelu09Ky61BqFP?= =?utf-8?q?OvnxwwtXqTZMWfhN2vk+UoF7sgPxEgJgyEnrHqW3mALzH8MDI78BtGvpXmzxNHSye?= =?utf-8?q?lHiVPWs6RfxrxFoj2l2z3a+MLvhhxgeVteETJX+TgeWnq7OPizwJTcXaTX7/pxv0Q?= =?utf-8?q?zJUUkKtm7+TM29zuxIKuYuXG2PHvLFv2Mv4RJAWuKKA8dGxJZSbQJemTgpxOf58Gf?= =?utf-8?q?CsZqZWh61IBBis3iIHxsgwtS3TJSfVwatb9FmVyiyUAOU53Bsdy+AMW0Wj3B53JoI?= =?utf-8?q?X5gbzWo6OrQNz2noPttUtDw+evOUgnIq1uDOzKNI/LnsgNvFfszzrYgv3imfoN5Mq?= =?utf-8?q?30QsbUONF0gC9EdEOrxw8FE8uDiHeP2GjX/oKW6BSznKdPLedpTFPy+wfh6/6+jFh?= =?utf-8?q?Hbl8JlO7kh3maR2z06SfdvQ8iSqZdzm2jWRk0AZ3LA0fMTrOsxpLlNcJhIkeWe4yW?= =?utf-8?q?L7VOOKkeL1xCu1FuEc8lCUNtrtc2jyu1ZVic0B8kKucf0mt5IXiT68w2tgkxU/+J1?= =?utf-8?q?btCw3G4fJgHuMUhHegS9LtVIlg9o0gdo56Mfb6aNM1Xgs04OEE900S2kO9eXfe7Im?= =?utf-8?q?T9pgsA1BV982lRIuQ9VsAyuDlfvJRS9ZqUiJFNCXQh2j7gdLB1NQpAHkevxXuFvRL?= =?utf-8?q?DIuhZHWRxpi6x8KgZiyZ7v/2n9rctKAiRtszUrYx5YNvno3aMYwuQjEnA7sRiE/QI?= =?utf-8?q?FfjklP2iD82JAvy+bFkP9X1QDPSzinUMB53Bungzv/jRu/SpFuGHInbXpk6wI7E6v?= =?utf-8?q?Fos91AWVxjaEgtihe1xBvE18WKasntoiO20WIc4WwQ2nwPmJcbVP50+bgt2WFqL07?= =?utf-8?q?3Qlnd/in2is+q8IZf5u437Jfoib6oC6aAJis+Jciik0VLzlWBaLxyQGHhVsN19uLo?= =?utf-8?q?dsPa0+snX5yZPjsVKmycKkDJj75HsRJ6xA1ReeHIsNW2WLc938KsxP+9snhBouL1o?= =?utf-8?q?8r0VpcaVJPePbbFhgg3k8AXqjRyXEmwpuSOUEFUBC7epy05Aw8CBa6dktjtAm3l5Y?= =?utf-8?q?Dt3mf8cB5QcdEecOawTp80FJ85tMyRWtnQ5+r/8bCFznEfl+uawnsywBPsoScfIIz?= =?utf-8?q?3V03p3w3iTZFGc2pYG5wvNBr3hmB1AojmaxFyF4lK1iiIr6hy00C9w1MfWNOWzlJw?= =?utf-8?q?cTCB2Zt1sXthhu4/ajNCo72He2piV76aOe1/n3ldVqdHyFIyUjWF5brTMtjQPyMV6?= =?utf-8?q?7bC22L37D866Nsz7TF/i1yLJe+wzGVqduIfNruVwk8tofhapwjeEAN8bemQeWwPBA?= =?utf-8?q?I3ZUihzjT97w?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 299dbdc6-bba1-4a3a-b0e3-08db8d8d29ac X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:02:43.4139 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nzmImaRH4xntLXGWw0CUzhdvlLw31KrdFlRZ/rj7c9dTox1fVRrvKlo3NVKBaaE16qUcard734UTY14HwK+gRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB5463 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Returning an error code in a platform driver's remove function is wrong most of the time and there is an effort to make the callback return void. To prepare this rework the function not to exit early. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/sdhci_am654.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c index 7cdf0f54e3a5..abe83736d396 100644 --- a/drivers/mmc/host/sdhci_am654.c +++ b/drivers/mmc/host/sdhci_am654.c @@ -873,8 +873,7 @@ static int sdhci_am654_remove(struct platform_device *pdev) int ret; ret = pm_runtime_resume_and_get(&pdev->dev); - if (ret < 0) - return ret; + WARN_ON(ret < 0); sdhci_remove_host(host, true); clk_disable_unprepare(pltfm_host->clk); From patchwork Wed Jul 26 04:00:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 706823 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9654CC001DE for ; Wed, 26 Jul 2023 04:12:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231865AbjGZEMS (ORCPT ); Wed, 26 Jul 2023 00:12:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231703AbjGZELf (ORCPT ); Wed, 26 Jul 2023 00:11:35 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on20715.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::715]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60AF759E6; Tue, 25 Jul 2023 21:06:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mgAsCjfdC/TUybPe7ZxwmyGgNKzdlDO0oxtyHwxw1C2EnQqX2kGjFrsGkFCd4PIHLW+6FsYvJ4CaK3FW3RrPM3ZSJlHbJO6f61Lbb0nTH4z/Oi4RrY8BPXXPL5uhoK/XKkTM8x/k+RMI9HwR1sx68Ok1ipk1pBAATl8L70bF/tL0NkHAaOG/0hb1ZDQf78TRhWvX1U3AQ9lHSvrQwDVYAew3pTFhOrQ7kC7WB8ceYoiqqQtsZ8c74wOCIszujg2zrfpWpr7US7it0NjcIGCOMIEB1/ME+Q38JsNK53O2GtgUUwD3UcKz14y0Yng8sz7KTuYUprXl9qO6cK+xe4UXmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cJjqUjgHWeahu5kEIR/X9k3lXldr083Lgzi2wWxD1eo=; b=DejwugKGuIOnjmGLkiLQov4/9RwJa1yW3zMn0jeDYg/tW4JM0/5mYwWoWHbo7GHTmjQIeTCXCVKYx73H2vL654ltkgqGntZi2s6or5HlsNHUnOe7zX1Dwl9wYND3iX2GxgD+vRqoDhcs5fNIsaqi6sksMgLAK15dmO0wvTYbQ8QSJHPWWQdnbkhSXTiikyLvZ8lHMKCLTP70OduovhC/jDLsNwWGkC26GKxKC2vNwp2ktbHtH+OGU4aUFo0ub1V0NHhhTLUJif2yEfQpDHz7ZPQ5WSLPTNdfMnFjMA+lIjLIIZQ2mN+ZqatnMS3rXd+87uM0cQmxotYZmqITiQaGWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cJjqUjgHWeahu5kEIR/X9k3lXldr083Lgzi2wWxD1eo=; b=dYCKlaJKIj8PCUaW1/Pn4s4RQShxCdV+PdA6BdZftg2Ym8SSgbeEbO8FLjCFNfEPK+qpS83sCGtfzBqILy+4VMdZB4b1AgmkeeJy3/INu7/r0Bz88vCEwFr/vQN6j5dYOitoqCDNBt4G1KL7i7qV2vL5ZdGsyCH12P6cAVo2wJL+WY4TggQFs8y8rYCUY/HhFgXVbeg+j3oKBpfwnNEzWCnJkDC7mcq0rQrx8cSt4h+yt8RcSEebbYvjmG9xRMPcVKGhz4Nj7vBiFIhZK+MAJvFt/7qm9jcd/1xLTvHJYVfLz4cWAFScqps/7akjhY3SMw6u8vf+XUcmzmrn+b8gzQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB5463.apcprd06.prod.outlook.com (2603:1096:820:c3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.25; Wed, 26 Jul 2023 04:03:14 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Wed, 26 Jul 2023 04:03:14 +0000 From: Yangtao Li To: Adrian Hunter , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 61/61] mmc: sdhci_am654: Convert to platform remove callback returning void Date: Wed, 26 Jul 2023 12:00:41 +0800 Message-Id: <20230726040041.26267-61-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230726040041.26267-1-frank.li@vivo.com> References: <20230726040041.26267-1-frank.li@vivo.com> X-ClientProxiedBy: SG2PR02CA0093.apcprd02.prod.outlook.com (2603:1096:4:90::33) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB5463:EE_ X-MS-Office365-Filtering-Correlation-Id: d0bc3305-0b5d-4b90-25c2-08db8d8d2a8f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n63cqTxZRuX5C1c58SSmh8ZcPuWf0F27TU04u7WOrmce7VpeXxft/bWrUlusJr9UUI0+5Xq6LzAsEeLxwkqxkwCA6ITl4IsCzoVOSNp3OC3ZwCpsjjMWhlXgiJUj2L1HngkVuMdTWWit5InONPFEkq4alA4u37oxPFJGXEvXfttq6HAbFT7fgrjX0nSLrRnEo4AfgvJo3kGfjts07n1hQvWbQ4rhP/BNF6Wf7z4ww+EvjKU2D2nKiPvfmdG7UIsIE/NCkgtjboobQT6zklD48+q5chyWBNtBovO3n/JlNynir64ph481Dss6Wv3vTCkEkguHokqRoDw/YXX+CDTYe3/Du2Xla+isOhyOvV89kI2zFDvbjKntmDkyDeFomz1CbEpRHV0+CSDWib1tVqxbJXvc2n8Ir7awRvM0gWDvjbknhkBxk643KDbjoc/rDs1C5+Z5u9NtWgnpJ2k2ZJzeY0pCtjz+KUt4Un/fSlTm/Ec= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(451199021)(110136005)(54906003)(38350700002)(6512007)(38100700002)(52116002)(6486002)(6666004)(478600001)(41300700001)(5660300002)(2616005)(8936002)(8676002)(66556008)(4326008)(66476007)(66946007)(316002)(186003)(83380400001)(6506007)(26005)(1076003)(86362001)(2906002)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?6xnWqi13xKh73B56wqNTpGGMfkoM?= =?utf-8?q?E8vP16nVi52aO71Nk4dpfMa6I/6BYJwD2PWjdBFiqbdOLdOb/t4ti1aO2bV9yIE+Y?= =?utf-8?q?nXmYaY30dAi4VJZTrtkpkkcbcv92t5OMtc72WG8UJnINOrY7HjnaM7n/YlOleyBG7?= =?utf-8?q?tQk5t8GCGOqB5bqSOLS6XzPmqIyyc8jZRlWipNE6Y2yJxOhr77DyWwyWrYOFCrCLA?= =?utf-8?q?4b+BLE7IqiZfEJFxftC1h+YbWInoRiumpGKiZBzhbq6Hzswi5mxG5jdj9Q4DxKibo?= =?utf-8?q?y/if3RusYRC6VRzeNIwc0XxEMWTHuPnV4iTxhMKIfWAezo/4gWP2JcqWQquoAJkl4?= =?utf-8?q?U5X3mYbWAiojMzDV+JZATnKju29oUcMKXC7NwThlksmMjFal0IPUxTtQDYp0LxJzT?= =?utf-8?q?IR8otMxlC5BotD7Br02ujsnSqFMCilzSU8rlEurcsLNzWqNlK2D2RlQ8p/N/fuLnD?= =?utf-8?q?rr1uGvkoOcpnY08/Tvm3hum5gjT8kUxo1T3nDhvk8chTCS6UkxnUbE3MzF+Dis3kH?= =?utf-8?q?j/cq/G7Yc6KyE/vEookCXKNgouBR9Y7JqAwynI+U92PZ/0RORu59v/vb0OAa1mpTH?= =?utf-8?q?TMztBmsEOlgCExfAsL3z2fl86dvQus+p0a4GPgpu6V2YXuniL1gTGwa8G2NTNz4eo?= =?utf-8?q?QE8BQHRacioxHE+E/AptKS4egtSN3j0V0Zag1Zm7Mb17NCdmneXla7pKv6zhTTK3g?= =?utf-8?q?CZN/8EPt/YEZb+L8ivfICZzEbwIBkiBoSES5dvTzSBTB7waJ+OXzbDae9W7fq1pts?= =?utf-8?q?d4+XpF7qSq8sRB18hxHNO9H7cyAsDTWdla3+qFgao/oPKyhrceWFroQY65t0TuMPR?= =?utf-8?q?jP186npzHWCDmk3IeCLMORJUorOa3wM/RhUtgsKflhdgV+2M20kIk+XLFle2WsVLq?= =?utf-8?q?Dw/Pbp/NtIDy3dCY9tzmRaJK1+ukUL6Lhn1HMEp7/i8Elphe+yf3X0KNH62PGshtT?= =?utf-8?q?c6grxkRTrbq1xkfhvzdHArzNaW4QZq7D/Qpb6VMriVPNKN+8o+deUdk4w79QpvQsg?= =?utf-8?q?G5Ku8YPyTB8OMPO57W1VN8gY6RfuesC6OelWlvlhWd4Nfh28mft/JembGgjpTepz6?= =?utf-8?q?JEoIBybD7uuZRcG/aQFMPPKKU9DkuJzJc6fFUzGhNXfNOG5+9cLQnBUPNQW6TiXIA?= =?utf-8?q?0ioyApr5L6jeN8b+sByyqveLw3x+Ft3v97IFacMvs7tTtMXyCDF4WGbClVxDX7XMc?= =?utf-8?q?vJNmXmalI7J629oi3G+DpFXxt6ghdfUO+O/2rmrcK2QmUFT5AR2DQFtwAPxAVRVap?= =?utf-8?q?wzoClMcWrROWaXPLPGwkvuo5KBgQRiJ+jG8WAGHEB38/rhec/bbBhXT3Oe1KisGpv?= =?utf-8?q?wsJMd6IiwcktGkfeUOhdso/D1BlYu+OqN4tmsf2KVvzRutzbgZtas9RX34JwhCzEd?= =?utf-8?q?CH7EbYhG1TnnNFGFReOhUe/of6UR/mko8jqGnH4QBx8NVkHFx8RoQU8W3iVgaH9eG?= =?utf-8?q?HFCYnDmpGpHlp6mGV4/+EnIcKaVDW5MLJkYSeEJKxMsicB/IZrtooymwm7zNeO2of?= =?utf-8?q?hcaHHYxz7CPk?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0bc3305-0b5d-4b90-25c2-08db8d8d2a8f X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2023 04:02:44.8292 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fMCkyedP41wVUv3Adej1EieyyD7LzSzNalaygVgfMYvYHfpKuhkADKWJ0va4cNYo+b78S11q6GNFPv2l5Kb+Pg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB5463 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/sdhci_am654.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c index abe83736d396..a6ff09ead28f 100644 --- a/drivers/mmc/host/sdhci_am654.c +++ b/drivers/mmc/host/sdhci_am654.c @@ -866,7 +866,7 @@ static int sdhci_am654_probe(struct platform_device *pdev) return ret; } -static int sdhci_am654_remove(struct platform_device *pdev) +static void sdhci_am654_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); @@ -880,7 +880,6 @@ static int sdhci_am654_remove(struct platform_device *pdev) pm_runtime_disable(&pdev->dev); pm_runtime_put_noidle(&pdev->dev); sdhci_pltfm_free(pdev); - return 0; } #ifdef CONFIG_PM @@ -992,7 +991,7 @@ static struct platform_driver sdhci_am654_driver = { .of_match_table = sdhci_am654_of_match, }, .probe = sdhci_am654_probe, - .remove = sdhci_am654_remove, + .remove_new = sdhci_am654_remove, }; module_platform_driver(sdhci_am654_driver);