From patchwork Thu Jul 27 06:59:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707409 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3548FC41513 for ; Thu, 27 Jul 2023 07:01:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232796AbjG0HBR (ORCPT ); Thu, 27 Jul 2023 03:01:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232784AbjG0HBN (ORCPT ); Thu, 27 Jul 2023 03:01:13 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2093.outbound.protection.outlook.com [40.107.117.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDE9226A8; Thu, 27 Jul 2023 00:01:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hh5bLWAVK/JEBE1WOI9kiYHZB1+uavj4ilI/IaeAvaUfVrwOddHtu+sXI/2SfZrbZkWxY9oTyR3gyMvmmHnv0kasjEnd99B3k6FGa8lLE89flvtgtDOZYTbWuoZ/PwbU4Eg2e296vyURnsd18z2iFR33P/O3Lwp+xQT7JFJW1YCXlS5+7I+iojlQUc7jHpeWTNk+/6oij9vz69/Hg4qX6fYj/GBIy64o3Wv+jXx4lN0npnWyj7WtxiuQ0Q3YEFXuRN24EMAFb7nVdbK9vWcvq6JzB3FTaVk+zt3V+YiQ4LA4wi7Kb+CoKhoy453BXN3VYZZGbnsqXk46S/gjRORVfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0QdurEMlGIZsmiqW8S2xEYZCcDPaCpY8fWT4ehR5P58=; b=etbIZOC+HxYEBIVdsKAgak6csW4ZTo6fZWebwB/s8TddLdfnSCf4FteupS6QHwgZylmkWCo15AlZ+rGsJbnhiIjj7H6FqnhfNVZjLn6d4FUB4KAinVIW9JadbEpFLh1bsfAzJ6OSy/psE4qgCYiV+EpZMcYLBUwuyNYn48yD6aofoPwOEf9s2DQUdFbG3hId+0cMgAx+t1/jyBRWpQ7Xm9MY01QAs01aGwIaZJabfcJ1OW1N4zPsSrZwhHy/tQ400zHScjoeDjfPgPQ2OG9D2CJrd3W59dDgcwsHdteVEZH5nvPrENrYWaa1P3TOTlCY1VCXOBpFkZIkpQYidDDobw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0QdurEMlGIZsmiqW8S2xEYZCcDPaCpY8fWT4ehR5P58=; b=IyHDCuqrz2YOHS2j9lwl1i0zdOqLZuB3oQy2Z/6jlr8lVcRf7+L3D7SGltKmVgvubsV8kFLC2AAbiimVV+hTtJBzBHUAZkl35TuSqMSQMgzRFeZMymIq0L5pMQqFnKbiCkActi5uqhbrCcOIX7ex37xM44Q4sQLgW0i7r6tJ6aI3gvgEfZTdbkXrrvdeLyCz4pSavITaLisuGUgY9GcQnix9+6nfKRHFCJc1DphYTrV41L225YrrBJIER0u/sgSxVkX+m4PeBGOkovxM23M3GcYMgQ6TYa6EDH1lEEjY6Mr3LpVjMy0IykX5DrV7KszmDj6cXJwf42pwOaU+oJkzQw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYUPR06MB6027.apcprd06.prod.outlook.com (2603:1096:400:351::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:01:05 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:01:05 +0000 From: Yangtao Li To: Ulf Hansson , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 02/62] mmc: bcm2835: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 14:59:51 +0800 Message-Id: <20230727070051.17778-2-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYUPR06MB6027:EE_ X-MS-Office365-Filtering-Correlation-Id: 0138aed2-a23f-49db-9c5d-08db8e6f3f2d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RZG76KbSoD9pwyH+hBC4G5gyzXMYWVQYRe1Q3RjlCVFizCio7tQA3zt693Zm7U+VMSnJtSjbsV1N53vsOd6phlSS+lPL5pJTAO7WsXbCImr3jRMhqBs1Dy9m9yb3jC2RwORwz4on/P+ZXflQq7VGReJvOzFCjjLyDt/BOFK5+8zW2S6zR/SEY84UcaNTeUrNxbA7cwMSpg1Trw8RbzJEhk7YSOxo5TKmWbRBfoxwpiin1jPxlrQv0uVKT3QYgRW0nWmX+uX9MGd4917IxYpudKGtoK/T2wrJkbCIcHKyXTepBmT2FMo+mW1PrQ0ZPgbvIwrFpl9Wby2vzrwvTaPrRHzLe+cmVu0uBF1t5EN4kajMgOkmjr35oOkXm3Og/Xv0gzBAC6LfVhYwBAb2gy+SpUV88yijOgSuVxuaK76WQWJn9XGBY4ndMbOvfpo5dmZ4FqOqSc7wiEI168EfYREzjDwwxocI2jS4FnLvxCsH7VUn5SCpL9e46aB+NmgHYHSYD9UjpSjt/QlODf1t9+lX8nNB4Y3aaawPRWUoTZzVALB5sEH14e2b0etDv4/ITAj8QRRiFQOHFqWSzFN9R3uQG0qW0Oa8SzR7Z9GqxklpMOlqpnEIiY+qHWhxg90wLRdV X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(366004)(136003)(346002)(39860400002)(396003)(451199021)(2906002)(1076003)(6506007)(26005)(186003)(86362001)(316002)(38350700002)(38100700002)(2616005)(83380400001)(5660300002)(66946007)(41300700001)(66556008)(66476007)(8676002)(36756003)(8936002)(7416002)(52116002)(110136005)(6512007)(6666004)(4326008)(6486002)(478600001)(54906003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?gIpXRcZjqrLsO1hLlc2mlrnq5nfd?= =?utf-8?q?05vDZbQ3op7I64SfC/PYi+RQhp8Z2p3P+seStrNFOfcR54hPbNZ3oDVM16VIbHi7G?= =?utf-8?q?0uEeIoOwT7+DEMVFA1SVrLzOrfqy35Vy66P2wR0KnkJ0MUfSfj9FNK4krWP/vTXpX?= =?utf-8?q?LMv4XWzhdj0ZjMLyrcOsbYxRr9obRO1XDNeOVV1/3vbb000Cvv4iiYf/n1pxECuWX?= =?utf-8?q?Rfju5oV9BQyJ0EhnT7Xi6kGwH1MEJwY3JAae+tIYyfzlAXBe+wcwt0qrMmrDn4rLY?= =?utf-8?q?DA5j550kTJO9mASmj8FCcwUU7NoebZL0emwCq4FOn9sudIb+qGuraBqtdMrx130el?= =?utf-8?q?ouLmu183ceRXrpjcGsKBwgG8kvMjLhTGAEXihwPRxfzubCznFKiCg+uC1fiHoQslv?= =?utf-8?q?XkJNgfza6umDTY+X5ukjdzZz/MOcMB1OT2wcH1n9bv1NXPeBwtRH92wrwXBo4ASvc?= =?utf-8?q?2glcZUwvLrC69axQVLLMDzjmqBrCCCaCOC584E5SKYLVKidtpXCvOTF9mMLXiuYNW?= =?utf-8?q?GPjBT52ofOtUQI8gObdFUuACk+xSY+jLM4ZmCs3bkjaanQtdd7r9SZleMSPv9IsW/?= =?utf-8?q?cQzfF2hL8UYtqJ1hOlsQsG3ne+5bRCACwRekMWv47FEcPwQXM3YilqxAuQJm1lAEP?= =?utf-8?q?rKMvyWjRB3uZcn2YXDzCeuMSu7PJIvXGGulesrnfiJMdbJk1DNTVDKZNxx1p4DRlG?= =?utf-8?q?XnEFkeJo+OL7XwRIik1CrdHB4n/6oqX+Zcg231ELb5bEpoPC//7b9/ImG3nmb+0C+?= =?utf-8?q?hX57Ewi/XqJVhJN6gCtgW9aEkGwMRP6B8XoZ6cXVZ0yjm9D/EGbI/1nKbGDaVVfKR?= =?utf-8?q?595YPteabluw+hFOvEmYJL2L9917WOsbH4ZEqHXtX7ojsTow3QbPKsn3vV6HUU6zK?= =?utf-8?q?aZ+GYCgOtUvWTyu13U2a0k1GCdKrHksr7aM3vg6PUHBTOWquTbaQmmCi32MI4okWu?= =?utf-8?q?efwtGbqY6m6bVBDemhGwxi55HP6WQX64EMw6yPKuNoscp3Rne30tnEYCic0RuG9mr?= =?utf-8?q?WevYbJ4C6mDyNN/hKG/QPAg5mqr/eCtrVEg0NcnTGOik2F2eUudY5B4U6oft89bBP?= =?utf-8?q?uz6sf/Vfhau/LZ4STYgUxbkA2KIj6IGY6HS1Wo9D8Lzf2J2sIvSZdNoKyjEnPnjDx?= =?utf-8?q?9A2/MwqjlsSnmDtMn7I5yuNLUgqxLySvvAoK+883cx50K06bCxZMTykw764gyirzB?= =?utf-8?q?FcMJE4wYTIzk/krPCXXyAbWzVXEi6hWplEYt2MyW9D3I3xMr/jP+7J3b5SFQ49X8a?= =?utf-8?q?e33f8x0TR34+0rKYe+szucHZBoipbmdHJRmUXjng8rMLca+5vCMeIp1XOjvBqnzUM?= =?utf-8?q?k24tanyUpDOAIpwOT1pNRTtzImFLqtCleJ3jmc82SifbmkUVQlKCtIk3g5ir2fp7g?= =?utf-8?q?BfrxlfxvCxJulZJQZj6jWWimNfaSz5sTzXbxyao/jxAbnGay3sCWP3FOe9OoZDMq1?= =?utf-8?q?H/0COPC/aoAZUVxiTHoUXx2f5l0WK+trye+1Fgld/z3VsOoe8FwrNVweFEXt1BNjn?= =?utf-8?q?Qjcix7MyhEgo?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0138aed2-a23f-49db-9c5d-08db8e6f3f2d X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:01:05.6922 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OPhGKlukEo87AaMGy3jUccm54hayZrwfpuhE4mb7WG18Ytl7/D4aLzHF3ziZpA5hqfaK0wN5RALsN9tR9Wgz2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6027 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Reviewed-by: Florian Fainelli --- drivers/mmc/host/bcm2835.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/bcm2835.c b/drivers/mmc/host/bcm2835.c index eea208856ce0..35d8fdea668b 100644 --- a/drivers/mmc/host/bcm2835.c +++ b/drivers/mmc/host/bcm2835.c @@ -1431,7 +1431,7 @@ static int bcm2835_probe(struct platform_device *pdev) return ret; } -static int bcm2835_remove(struct platform_device *pdev) +static void bcm2835_remove(struct platform_device *pdev) { struct bcm2835_host *host = platform_get_drvdata(pdev); struct mmc_host *mmc = mmc_from_priv(host); @@ -1449,8 +1449,6 @@ static int bcm2835_remove(struct platform_device *pdev) dma_release_channel(host->dma_chan_rxtx); mmc_free_host(mmc); - - return 0; } static const struct of_device_id bcm2835_match[] = { @@ -1461,7 +1459,7 @@ MODULE_DEVICE_TABLE(of, bcm2835_match); static struct platform_driver bcm2835_driver = { .probe = bcm2835_probe, - .remove = bcm2835_remove, + .remove_new = bcm2835_remove, .driver = { .name = "sdhost-bcm2835", .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Thu Jul 27 06:59:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707408 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85FFAC0015E for ; Thu, 27 Jul 2023 07:01:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232804AbjG0HBU (ORCPT ); Thu, 27 Jul 2023 03:01:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232733AbjG0HBP (ORCPT ); Thu, 27 Jul 2023 03:01:15 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2093.outbound.protection.outlook.com [40.107.117.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D2392688; Thu, 27 Jul 2023 00:01:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T58UdoufVXVKb2vvVqHK2Yhp6bAcBOgJQGFg+sHs+hvTAd3IULLBzaRraAcWDOLxAznf9ZU1m12jOVoHsKhVX1o5V5D0UTUimfvPruBsQx5kBHG0Ek7XbCRbDnYVMcy/VOYsK0MZik2YFwbr7y8Tli3Wfg4qZu1X/NUfeh+8vosr7WVmZMLhFkvN5/zD7wgr3WTVJ4ok0yPYhFxKkV8yoTnM6HnnpzsD9z2+pxRXkYavA8pzYcbJs5yYd0eU9aWjl7Ye6ApOkInkZB/9+gJHJxU2xA3xQZtxB0eLWYd/48q1w63wHPWMKDfgz6RrQ//kDFmioCLrOSIIrjSyxYlJdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g/FjFXOniG69N9nJR/0wcardmXaPuoPDf1/5LYlD30c=; b=a+cfSVG0/zTs8C85pmqzClISJ/+BfmJsx/mV9LbX6Ob4olK0BZd4zmwV50oj41CoDNDGo15SoLiFzyIv01LVLIiKGqPgtnJ7PsxuAhY96nQa9bj5ZzWDr4fI8/+aRgmfBt8NQ5t3rjEHCwiAdQuJNryretr36zyXFRnrW7QZ3ndc3JyeOge1siVr6pDFSBlMhOWR3S4Smae/qeGz7dTvGz1PCwWixHK6kJX1p1f6L+SmOMwgfYtno129+sYDGhasvfpV4EjiFrglC/6nnrqTcqn1kgT0+kfJoXV7H5q5PseBEz+Hk+0D9r1nK1+gI579/TAhRZ4IHiJxCryed5Av4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g/FjFXOniG69N9nJR/0wcardmXaPuoPDf1/5LYlD30c=; b=aEKfCZ/teHvF0Y3Ot1Tcx1v+kNS09ILtcwF5uNoQI+Ni1CLzjtoqCTGUo+adFw99ZcSPw9et3YQXbtdmRRragDzMKpe4MJwNg3MJycnCTgeIf3eV3kBhMaWgxjIkmlwG65c7OmLTjIBhr2OYB5GB9l/Q3dyiUGNg95QWNmKI0pXuzMBULdRk1uU0BU/q+KqCNELR55xqdg4prFPD5wiHnlKyrLWqMLdKvUriN87wyvp5R7mbEYKYWtMw7QWBPmfeDL/NpKnsTSUS7kUqN6Kb4LX0RE92WzTa+F8qTfNg8h4FdQW4xWZzmZMsGQHDGXidzc8dfAMtyrUL4Y5VdEc/Hw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYUPR06MB6027.apcprd06.prod.outlook.com (2603:1096:400:351::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:01:09 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:01:09 +0000 From: Yangtao Li To: Ulf Hansson , Karol Gugala , Mateusz Holenko , Gabriel Somlo , Joel Stanley Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 04/62] mmc: litex_mmc: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 14:59:53 +0800 Message-Id: <20230727070051.17778-4-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYUPR06MB6027:EE_ X-MS-Office365-Filtering-Correlation-Id: 6281c39f-3092-4a35-a6fe-08db8e6f4137 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1iyLwjcVwaZ1qt9ZwPEvvR2+UTJ8JH6qJJCFtsdnaEUkGn3F++vl8v5f5JWuXHSXnVUu07KUI5ULSVHAHBUqLSAcWKeOin2yQPxvx7VD3uYoGec5ihqyGbjOfQxq+6qm9pvGzuOyde0WOsV7rrfnG8qGoxmqAeL9mJZsaVIkD6BIMdCxK+9fZid8rdhh7j5SHgrsfR99tEUmG6mUkaQ6UEqVTFwcobXs0VYUoTpdzmtFjFPyXuTV8vCFKylw/a/olJTikzkKg8HS6UJBeE0YKbA6QkFhZsxpNvk+l3xIQH7Xos3ZYBL/tM0/y2s1BMiG4qvZuSk4mNOa9bh3LB4ocB9w6+XhT5AiqaFNr3WHLGTfzbN0wZ/wPojvfzx9hep/KMfV+gCpvccdcnnVHdrnhN6KrzgGybdkHCbtWoAhWA3vsi432g5QQ32erQVFrr8+bX68BKwPboiM3UI2RULf64MSg0XbpF/Zqgdrme6nOnt85y/nwb77gjA9jBhpFIuvbSbRh3x4FXzAv872ROS68erIAJkL9EVRHQL+BEKgfgpnZZJwK79iJ2rxioYzB/G8lSNSTwlZjad4Yo7gbGu04jEfRHCuj05gKZNpWexRZAw50T+3rrpG52beltVjGyj9 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(366004)(136003)(346002)(39860400002)(396003)(451199021)(2906002)(1076003)(6506007)(26005)(186003)(86362001)(316002)(38350700002)(38100700002)(2616005)(83380400001)(5660300002)(66946007)(41300700001)(66556008)(66476007)(8676002)(36756003)(8936002)(52116002)(110136005)(6512007)(6666004)(4326008)(6486002)(478600001)(54906003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?BWubmoUjeB9NFqvfK6wTrJ7d8fJx?= =?utf-8?q?Qbk/q0HORbCDz0KyagSFKjeZeKUOsKXVY5OyHeWBuC9F62ikBOxAFBAwxMLvtJSgJ?= =?utf-8?q?81ZtOLwu7wzH0HGMCjxDopV9hTWWfJsNnpr5qfH+fsZl6J3W9l1Moo7UMkAEHbnSq?= =?utf-8?q?9SzAuoLrLDVAc+CE+ktd1dstKtZkT9ZMqCNr7oIGkzGU6w+xBgv/S4VoAhRaGy5zA?= =?utf-8?q?MSpVMTbCPlY6vuPgSSpA/wopJRz/yS975z9Mvf538O0/emT+IKF/Ag3kIjHnA2jY/?= =?utf-8?q?kqK4KwO7uQXXoYFI2I94BgblmUPvTPnm0zCj9J0MSt5I7+pvkD2fA4EWDgVyzZ9Kv?= =?utf-8?q?7WFatUMXXc3dNGQEUkH/2KMlPi9Uco1udpd8tDlTndcMbHWCb4eRcL5frYi8+67ys?= =?utf-8?q?9x+BTIxLpUGLl2ciJcX5VN1zJ/gvkA9fmps/DDhJk3EA+SCZx3ne8GPnEsplDkj8Y?= =?utf-8?q?fnuwwvRMS83W/CzSlnA8r4CfBagpGL2+xXtejo3Yv9ZoC0y05NmKOJuHWPmgqilFj?= =?utf-8?q?2JCLxjZfABpwGaXWw2IPc8Mu4XGYjtE503bYENnUparkXKkQ0SIdSf7TLO1j+n/0A?= =?utf-8?q?I74ISXVUM5O96qYiRKAjB4FF/6pqiOHGI3XvMVBfr3uZ3bKz5X8ex+7jcg/GrEzAB?= =?utf-8?q?ALtiTmwU6QRG3Yu0OSha4RCZITR7nFJfI6QRuk3FTej/w4GVsDmoGe6e0dqktdWvM?= =?utf-8?q?WHA02T/ynngVux+BV+0oyylwcOVRH3NBUbveR0AnXvdasMcJhC77SG/7AdSyJxD8p?= =?utf-8?q?zNj972rw6B5d4u8urX2xLUN/pBzKiQggTzKicOlsVK8cSdcO9T/uS5zGrgzYfbZjS?= =?utf-8?q?Dl1rt67IsWBSjj++HxpRHN1vVLopaGtNKDwgISzm4aK2u/8yn+smpcy3JhoucV2jn?= =?utf-8?q?QB9yaFVjU3Eh+QysBijaficLbNrhKOhjSTdV/MSkdlXEkBqYlDJKhnKYbaGqbxxn0?= =?utf-8?q?jk/qmb/WG7XBDlD5OFutO0sr/LMRDgA2auKVVx9RlYcjh8HKPuN0SNsRTAMj3uKBW?= =?utf-8?q?hVnxZKJlsslDhRJ4QdpeCYfUZbjFWURhkeLbRsVuyp4l+L6d6b/lUzn8s1xkhb6tL?= =?utf-8?q?lAYkLxi7/C/OTSe/LHvhfSeAJCIiMmp7zQ6LNx2rJgPjZS5MC/wl7GBm4Q/N6pnYh?= =?utf-8?q?M43WnZTX2IHoPQgJ6T9mjCes94rhCmpOmvzkPt2uZqFb5DHfcqBT4rBAAGtggQR0v?= =?utf-8?q?v0hCDQwpRbEv80Bb1RGHcr2hgOUxfNYAdgNfbWl1ZTq61i2mRMVIcI4oWNwaTFZE1?= =?utf-8?q?4t5/LYx2bMAbGngNYWUkDnA6uQ+tFtN65iXnuxGCTYji72Wl6Ks0Z+iOb5AdkFTt2?= =?utf-8?q?6M6dIvq5uPYfw8QdlcxqxrWv9vCKQkO3bhiijOx1L6TnUvBM8TJcV4H1JkwGbUi6h?= =?utf-8?q?lQb807iBg92tpE7IoXF+uJdHwpDVC0UZN25nDT4ATmSNCYI/m1TKcaKRsxj0zrHQx?= =?utf-8?q?BEhIqM/xGtCskU158bYtAabVP+yMmcLYupm6mCGrwZT5uQasgWxKCwMyTTahledP7?= =?utf-8?q?Sf53i4n4VSv8?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6281c39f-3092-4a35-a6fe-08db8e6f4137 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:01:09.1289 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xGXpyvwRqXWH6y9cozQHNmJLuawhEOHNBe9qg7/yjgb3ufb7JYcsZRFHEetU0FYFXYcnXT2JcNr8kLlCRLWeLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6027 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/litex_mmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/litex_mmc.c b/drivers/mmc/host/litex_mmc.c index 9af6b0902efe..4ec8072dc60b 100644 --- a/drivers/mmc/host/litex_mmc.c +++ b/drivers/mmc/host/litex_mmc.c @@ -629,12 +629,11 @@ static int litex_mmc_probe(struct platform_device *pdev) return 0; } -static int litex_mmc_remove(struct platform_device *pdev) +static void litex_mmc_remove(struct platform_device *pdev) { struct litex_mmc_host *host = platform_get_drvdata(pdev); mmc_remove_host(host->mmc); - return 0; } static const struct of_device_id litex_match[] = { @@ -645,7 +644,7 @@ MODULE_DEVICE_TABLE(of, litex_match); static struct platform_driver litex_mmc_driver = { .probe = litex_mmc_probe, - .remove = litex_mmc_remove, + .remove_new = litex_mmc_remove, .driver = { .name = "litex-mmc", .of_match_table = litex_match, From patchwork Thu Jul 27 06:59:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707407 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D2A9C00528 for ; Thu, 27 Jul 2023 07:01:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232774AbjG0HBT (ORCPT ); Thu, 27 Jul 2023 03:01:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232736AbjG0HBQ (ORCPT ); Thu, 27 Jul 2023 03:01:16 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2093.outbound.protection.outlook.com [40.107.117.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 866091FCF; Thu, 27 Jul 2023 00:01:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YbzSfAyL/esAQASL7Bu02p03BN93Y17xGgwu8X9JxnT6Ezet3Y1sMtgr5Cteia23TdZq2E/jG+LLCMG0WfuiNX8Rv0rBEp8iTgiOYhcVAjA/aRXpMIfMOztAvlb/dPT6FxRPUp9iK1Qbw+qsHc4BKYTbPcjN3Xzez+cqIlNiz/QBO2iLnvUvC2IeI7vEu+w/52QXTq85JSHc8hrFNmFAOMLMvOgibXErooZbKe79yysF8Snt0Gdi6cgoEQMooboP/e4Es2+mmz7qJ/sojSPUl8sKrrR77gFrZNoLoTqIEjtV8ixspME/RaxNSB8+4MIYi5E7B9qDyug8fbHjiULH5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XGvwJMjXkY+aIWcQi5FBmNL1QkzER169wqMxqG1gqGg=; b=dImUVLP5YKPyIG4kDVV3Co8rhavefJpZtFSZmbr/rrIdnpvQ85OXBh4YGy2OH1i16OuLvcIEIo78IydNn7ITareZTzDvf96E4XcuExLVg4emCmBLmS6MHGwXll8cAZi+6B/YNcmc+w1tDyIbJDTm2BvvwVlBAxDnaWo8S6ui7cW6cqo8pcE+erPz+Cv0r4gr/uGVj3A2NEiOQdzhkxd9gY8IrqQ7OOvQQfkOECpYsTjpVzuSqemQvlTmhp9Q5H58yBXJGyDzi/YqLhW23iX1Lt6WSJOA9TJFwnMicPl2KF3rYTr6da9vL45VZFa2+sLpsP022amT3dnhRy5KR1wyMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XGvwJMjXkY+aIWcQi5FBmNL1QkzER169wqMxqG1gqGg=; b=orMpc7VJ8hxUJ1dEAatFvtGatJLWxHtsEYvHx/WDZS9IBYXVa5CCSjLuoH6lDbjCdNluhgKFmXmyvrVpqI66M2pnDD8WfniqAOl22XMaFoMYUMNZAmzDX+dEaT4f5iKdzaTTnCUU8t20McmXDfnSWzVJSOc7esINWoUGV6xTJw5Q6WGQNNDf5+a7Vkgi/EyUVDN7ZIyKk3MQPUkRiQ5dcrIQFlhEShSwpCuQ/yXExJWuORDFPNTd2aD6//XvSF0amD5j1sAc1sflPAN6o2cRz3QZx0geAxupREtvfeRdZN9/TcHhhNrRuJLFY7qdPWod9545K60A7Q64ztRAN84jSg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYUPR06MB6027.apcprd06.prod.outlook.com (2603:1096:400:351::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:01:11 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:01:11 +0000 From: Yangtao Li To: Chaotian Jing , Ulf Hansson , Matthias Brugger , AngeloGioacchino Del Regno Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v3 05/62] mmc: mtk-sd: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 14:59:54 +0800 Message-Id: <20230727070051.17778-5-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYUPR06MB6027:EE_ X-MS-Office365-Filtering-Correlation-Id: 2e7c6b32-30f9-459d-1563-08db8e6f4258 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dNIVMUIk94K5b0FrqRVedTmq3dOB9u8iXD3BNfzMG1bzE1wu/kDSKZDqPL5fc0+66x+meyaODuRA2amiN9Zo4KwXMlwgXS1UPJs8sMedDsxID2s6tVPR12cLJaau6OUBz10aRxEX31rsVbZuf90eMbPu0hlakfk9XuzgWcpaH0pfPE03Fvzv2hiH3ERjJtAid8GKHetOOBQuYcJVxBNddb2YrcDmJYSeUcwGtulvlnRAi3wpEwkaVhJHS9YSbSQ+VZLUt4p0Yjmq7OLlDcVzgw+dfKnRi1UPO+OPKKW3tRn5ALxC5PL+meUySZ/Y4L3/orD9l0fXAUPyHYWrywCb05R3p0enGN68h6zcYsq6yWgEwc7+S+xhjR6D1BrdoaQn4zZs5I8158wr3Wptzfp4u9yIJz+2nOdRUkXzDf0ACQb3v7749Daj+9frs9oxRY2s0XoVNImdMmmBMhad2cvSwwmXWceMi8RBqtcc06nfsjkJTYxeEJgo9g6Vjm2ucob6Ui+0hLJB7v+XsZs34oIOIj2a47Er/gOgvg5d2rTPDjdTVirT7/Pp1VgEbTZWyErTTg/Av1ORpPu8ym4ZVtcHTruLU3G+ziFkycl1Y60I+lwV47tNrCG6xt31G5I/HSXO X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(366004)(136003)(346002)(39860400002)(396003)(451199021)(2906002)(1076003)(6506007)(26005)(186003)(86362001)(316002)(38350700002)(38100700002)(2616005)(83380400001)(5660300002)(66946007)(41300700001)(66556008)(66476007)(8676002)(36756003)(8936002)(52116002)(110136005)(6512007)(6666004)(4326008)(6486002)(478600001)(54906003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?4mTRqV2K12dpDhPknfNxVk1fmxgM?= =?utf-8?q?0bpvcKxeiQxQKUQvONrRNGM8LB29LoRNhvfMepX1b4MunkiEu89QQ8s5mxpC/uQKJ?= =?utf-8?q?gctGEArb8jK9o5QRxpFHo0pf+RVlsiuY5CL31otNNXvZBTYWwJdQ2016JGumY8zH/?= =?utf-8?q?MdIZunbimGqXDBYuINmfYoq6UBN13iBBHOAFZePPchJA6tv1O0waW2DBYJd3ryNqh?= =?utf-8?q?Vo0wl5gVpAGrEvM03UdoKko8wQOexN25U7GpnT7S2o+kiwTlxXOlJ6VGvQXf0dS2e?= =?utf-8?q?p+aLMdBPWlbbw7tM4rLcn+v4Me29smQicu5RsF2qcKy/xDuGe5esJMpJKvLoVIQaU?= =?utf-8?q?3ideS+FlFxeaG7uQjibR5Nt86xtD0qQDx3tJYCQcGU077K6b9F4JjPxs2BXFVXh1p?= =?utf-8?q?B1dh1ymeP93qNLaqGecZ0eQ0Ni4atpcSS9gkrdtHOSCD60RKR6404vXer3iPOc+WW?= =?utf-8?q?TqUqBaIZChCejrYWYXOrqhpBfPkqaW8EH36vusrA5mPH31OwZryJWq19Aebuke674?= =?utf-8?q?HdG0hnL35LADBA+ze+MKlDSCm5o92iyvfM+VL3p94H7k0rcajbDleY2WwGReSY04a?= =?utf-8?q?sLHQna5NbaSWG7O+zGyWIjjIFtFccLtAOcX1iHFBDKKJ/l1XbSqY4JTh8NRxgOYOL?= =?utf-8?q?E9aLGIgQk6kJnERRhFC/5tvy91s47UYnOxmZ3/BFqtKzoHeecs4Tp90B10oC+pLZI?= =?utf-8?q?zNqCr/aK67bkY+BjBkgVTvgbu9jNUzL4p7Yl6RIwFGrlc/jz+zC13CRcmiGZzNPJe?= =?utf-8?q?xNV/3TYX7CSIaixXOK3lRYv1pzSTbkhYv+bhFvmEFqacH90lBSRpJY297XVdy+NUY?= =?utf-8?q?nzlYJUfd0EM4oiimgznv9i69/D9Jn+0MNMsAa4p+ZAvYjNEo01IlLeA5E4vwfjuB6?= =?utf-8?q?zn6bmmGiFmPhphGYH3Xcghp9VeFar95B/hqAqO8m/5y1otYhx+VterMwD4vCQWtJN?= =?utf-8?q?66b/CTN7uO2Yfbezfbj0+dj64sOWtWhBerEmjMcabRKDL9lrNG/pDWX2VpgtG9Qqz?= =?utf-8?q?mh3yguBfl/8Biz/n8ftOoEcXBihYjuPDby5OEUw/qQSBqQUmU6lShOIgoCJOIUb15?= =?utf-8?q?DIxxYZXdy+75OarJADXnZm9/XCMji7muxhEBON0Lf7K6vp2bG9Rcfh3/znmH7y58f?= =?utf-8?q?c3lNahGhlj4GoPWiJhGaPK3I2OaRnvziGNS9ns5Y52BBUZq1hy8O7tm6IiJ8r9di+?= =?utf-8?q?JF+RL/wj/e404NW2lP0tZcKfPH5IU1N8jEMkQld3IGhvzkfrjhJdYRJehczH2U+28?= =?utf-8?q?prss+L0qcep9B15jEtV1+lVxIAyCuyGT103VQ/6Kgnn9obo+Yfka2kBcYMRprPE0T?= =?utf-8?q?/yTaFq3tkAFG4w1vQZsqR26ENRcaTRqm1LZf3NnPsMIrZxL9ztIupdFN7nzKc5jTT?= =?utf-8?q?s/HL53D7JzZUPlE/me03gfkSSndrwfMEsRuRQUHjn6ogDnGaX0sv4gZAIH0CZuQ4q?= =?utf-8?q?g7G0xxSeHMsuTBYAQnKN8XYp+8sjB/9HWh+qJvXYso0cHFnvqyx+1ZV++nByTQbRA?= =?utf-8?q?w0EXugj86n0a?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e7c6b32-30f9-459d-1563-08db8e6f4258 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:01:11.0148 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d9Zw3WftG5PuUdJFBaOiV9uudrU1iecBJy+55xXogGlX40MLOQudcX9OdR7He3b4wRgbA832u169CtQMq+wWWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6027 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Reviewed-by: AngeloGioacchino Del Regno --- drivers/mmc/host/mtk-sd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c index 02403ff99e0d..9e2debd1edbe 100644 --- a/drivers/mmc/host/mtk-sd.c +++ b/drivers/mmc/host/mtk-sd.c @@ -2887,7 +2887,7 @@ static int msdc_drv_probe(struct platform_device *pdev) return ret; } -static int msdc_drv_remove(struct platform_device *pdev) +static void msdc_drv_remove(struct platform_device *pdev) { struct mmc_host *mmc; struct msdc_host *host; @@ -2911,8 +2911,6 @@ static int msdc_drv_remove(struct platform_device *pdev) host->dma.bd, host->dma.bd_addr); mmc_free_host(mmc); - - return 0; } static void msdc_save_reg(struct msdc_host *host) @@ -3054,7 +3052,7 @@ static const struct dev_pm_ops msdc_dev_pm_ops = { static struct platform_driver mt_msdc_driver = { .probe = msdc_drv_probe, - .remove = msdc_drv_remove, + .remove_new = msdc_drv_remove, .driver = { .name = "mtk-msdc", .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Thu Jul 27 06:59:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707406 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCBD6C0015E for ; Thu, 27 Jul 2023 07:01:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232816AbjG0HBZ (ORCPT ); Thu, 27 Jul 2023 03:01:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231423AbjG0HBV (ORCPT ); Thu, 27 Jul 2023 03:01:21 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2136.outbound.protection.outlook.com [40.107.255.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5760268B; Thu, 27 Jul 2023 00:01:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IdfqWrCDkPMf0B4r5l0YDmMIFoo3GUe9yLpLkthOh0hjpIThN/ayOwm3tAxankX1EfnlmYiZQvX9tTKwDsIhZIvTlfDZhQ/fu/iyIOuIX5sTCyjiZa8szSYxqsIovsKNgHlyh40LXzOv3oiU75/PPu152XhtsLpmLbhLDx9t4BFDVLI7OycpVYW/DHQVPoX/16v0aS2Lj9pVKfxpzxjvFyTC8MZAnr7Yy0nqMZgqZRzt6+eM+tEXqiG5U1D6bLRhhnM1f6mNfmICL8WRPj3xd6CMsolNxHRBzxWNI+0YDjV3PcHLfAX+bfk8/Ikl/v4gM1BEBsDlwOKBHX0I8mFC4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N7okkAtAy4Ay200gbDx0jngJNeo2uhW4SadPJUa5pIw=; b=bUXst8yk2XKPzXhSH4YVJdYuFAuHv+Zv6tw6cKUCRwslTm+NFMcvqy+rTKSWkuwMgADfCHkPPiviir/FROiBqgIpz+rE6NhDQCDRzYxNhzSK2+IpWBumga2+oEOmmyDvuKLl7HuysWcjCKR8F8qQYgbIQNMJenXV0Nkhyc47fePnWLVK1tgty86X40PrxeEu0KQdRfcxgT1DYIf1GBPD9C7vsi1QDeivdWbTQhUEeXs9rklIhXAuL7zcNdWMqdjHQe0MCH817j7gBDU9YTHi11twszvAOK/aoPjuMtUDwjupbrTYtBk+9zlsc+jlelIrUXYQNPkedp+/xTjTc0goZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N7okkAtAy4Ay200gbDx0jngJNeo2uhW4SadPJUa5pIw=; b=RdjFo4TWUqrVmr0FRhI8EKIIzUcq1KM0iwYpacKLUoboLmnV5I94pB0L+Yrc00rSCeD2YBpxtwZCuTsWsesrXWOGFtTZOCiGqpc3tPmxQeEIPEGcI+e4wuwfEIcoHHV8fAR0ZAGPvK2AVKGVRejEZU0FDuMYozK2ZffXBkwMUmCVUbZKkKnVm25nw/NbpWXisWm+E0NGNlbofuDjH8FRCIXhuQon95qXZn+Ppfctf2NHvHlMbPNuHySCExVJPYGX+3OprhQhOoYMqlUttUAv5nz0WJeuc8tg0DbIL7PcY1/iMwpC6Sn4h/GPsZ4tN1JgDuJzisqh5Qk6q7LgzatUJg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB4276.apcprd06.prod.outlook.com (2603:1096:820:78::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:01:15 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:01:15 +0000 From: Yangtao Li To: Jaehoon Chung , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 08/62] mmc: dw_mmc: hi3798cv200: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 14:59:57 +0800 Message-Id: <20230727070051.17778-8-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB4276:EE_ X-MS-Office365-Filtering-Correlation-Id: 621fd040-264d-4dcd-764e-08db8e6f44e0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +I71yupEiYIK9mGrudvf1CySr+AQll6z+IivwGplBaPoV8PVbSwgmV6ojvYY8auz8rRCLEVHboOf0veE7vvD91Jn2nxM9sYs7W1TTW0htKVxKz1GTCSzHqmL/0Q0Az5nWozu7a6zEqpgx/5G3uwtc7KE0SN868viisevogV+ZtC/E5JsiR29FwOvezbuZxkxE3f7jsWnYHorIQ2LwmTQIV7NmM5tuuOwUkRrBk98WpQ+TELp+DO/zLH9DSINyYSx7wNRGIcqywYLEb++/IWmHcsHiZrJzI8cWcM1zvxKZNEiJM8mr8RtcEw7if5bSgpUyHUnBhf84RgNDaPEjCNoJldbbbUTcMu+Oa/mL2m9/yC0GLoCJlFOs8Fg8bhAEdK5Dtcc7UjjTgNyNYbhIP646wuRw7Ozzq/+x2j8OQTQLUiOpJLhA0hd3hsCASR8+VXqNIrncY+pAa6T1nyV74bj4zLHJ9NhSUeAIAztXMv2J+hOyLOUbHiY6zUaFBm8pujstpn6ecsUaDxOULjFYnfTftljCyWsScoA3dOUT2Z9WV2utlx2+9J4m4lZWDl493aiOLrj68Qfw4fwf/7YjFBlCEUg1bUXKgo/uTA9AGQa02FJlVdxWjfPfI6IvXJ8GT0m X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(136003)(366004)(376002)(396003)(346002)(451199021)(6512007)(6666004)(6486002)(52116002)(66946007)(66556008)(4326008)(316002)(54906003)(66476007)(110136005)(478600001)(38100700002)(83380400001)(38350700002)(26005)(186003)(6506007)(1076003)(2616005)(36756003)(2906002)(8936002)(8676002)(5660300002)(86362001)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?2WaSgFAOiyC0JF6upO61fqYmprl/?= =?utf-8?q?EqnebCQHUkSLk8+JXAo3I4zhYBtT3jcS2S04QXCsLhumZPZHLPmFnkpBbolScmedX?= =?utf-8?q?aCp/43c0Jy2K9y10aBJDxy02rqavIuzE+cw1OlRI+R/kP0c/cgodyHcknwUDrjK4f?= =?utf-8?q?vNxpzbqgYFmHW/5tNFsamqq5UFYZYp5afJJZKCYZzidMZRpOQ19bP5yVgmOq29BzX?= =?utf-8?q?GkJ+vQiJcBLvCXogLMhJ1shmN3plyoGnEObYwlmPp0h2SFT0UH+cAcMwcX6suZLpE?= =?utf-8?q?QYoiqyrjgCVr0Ob/2HbzT4cSNrxMgZdw11j1I55H5lmVP2G6maX6spHiX8w4HTT4M?= =?utf-8?q?8TDvNXJClkATlcg64ByTDG+zxY0imrfQt9U7jKODITm3WzA7yZpWVinoAueuPiP2c?= =?utf-8?q?/45ckD0ELTPu0ffJz2egGtNjcjI3oDjnr1F5EE1p9T7zYvWwmrcokwrT1RX/g/Szy?= =?utf-8?q?3hRhMu8xlQs+hfvmYZ87+YRRMLC4ZwHs5QWR4TEJn3aY6E2Q88bCxD28Dgj9JXNr5?= =?utf-8?q?3Ai9kHcdQpDy38qlTn4MqK+8CY/+TR4OqUs3Od2efkYLWrm3lihixiTKcYZRtoIuU?= =?utf-8?q?ZCtIUOzO2Vvsbp8tg/2lJWkd5VDLT9hLhoFaZIbdMTGNL/gL2sVHMsqAY2Wo/6kBD?= =?utf-8?q?gwN+vON9NttyxAkwbR2kvnIEKI2nCcKLKHKgnl5eOQRKkNeZFvQNQnHdEt9BxN7U5?= =?utf-8?q?NdhVoOivH3i/Jl6dclRv94lulE+zbrsmCKD8unwgevo4x0lvfs7x1M+DT8o059C7y?= =?utf-8?q?vaTHZYDe7306UOKuvNZKvQeB7t1tjKgyGrHYyI9do7pBP9BF2qVjoByB33AoMGOo/?= =?utf-8?q?USiMEhqOZzVn5nVIzOWQ1kNyflPejEZNv6NSRAanjK5EsBv0lM9VocmOoC8X+V8QW?= =?utf-8?q?YUEVC/yOsgE8i29MYxgkkF9HRG2fJOSFVefIk6CtE+YsD+wf1oZgWxKplL+CVdkOX?= =?utf-8?q?FgidQC+uJvnggx9+z0DqkdY97FD79mpRwCjtNx+iXHDxj4WaDaAvg/HbIY/7P5sdq?= =?utf-8?q?K52pzzyysvAS15J7PWgo/+7hocdNNJqPKiHX2ypmbdciwpauFGFKCpT0BOG2TAbyj?= =?utf-8?q?G80Lw058+3Rw3xmw188Ghwkq7iznmMEPbC9pu4Vb06scyFuNzlhmbStQxGbIAOETJ?= =?utf-8?q?MQQVxfJFUgUp6FCXPaEQ7moQtginu1+6oIYm31HdW5tGdEmoecd8FEiW/hIEcnDZt?= =?utf-8?q?G698MnO981WdZJkeIzTZmDotIPsSrhjxBAjbrGXaDlDTStmt6AMQgu6FLGvOMpXTS?= =?utf-8?q?ckbiPzkY+nVJr0W7iBdh5LlByeuff/YTEw3fzV7HCfdb9kkYr9JdFtvsn8cieX3P1?= =?utf-8?q?WQvVyq2H6Ct1ShdLjuT/Of7U5l3V0EcEMnZxy9wNC1W969uAiTsUpnisI1qaVjqZR?= =?utf-8?q?uUqYOimIS6Kihov0IGvWjq5VdFNTDExA2vzPx3AlVETnj3bj51Xq664Tk3e2GxSsP?= =?utf-8?q?KayhX8Xp9R0MwF8nIPqxq+OFhXV7hMkDvY/BJEYvLUS7QDWEUB18pk/kmlhFgS2fq?= =?utf-8?q?k7LgHGnUNo6r?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 621fd040-264d-4dcd-764e-08db8e6f44e0 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:01:15.2378 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +7VNosngJElp3aPuh8sfbZ4wb6FAwyvKFuY1z/QJfd/PxlLgyhSfshGQB/jhKIErm6ZGJigJ7P0wKXvMELRjuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4276 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/dw_mmc-hi3798cv200.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/dw_mmc-hi3798cv200.c b/drivers/mmc/host/dw_mmc-hi3798cv200.c index 6f22fe054087..e9470c50a348 100644 --- a/drivers/mmc/host/dw_mmc-hi3798cv200.c +++ b/drivers/mmc/host/dw_mmc-hi3798cv200.c @@ -171,7 +171,7 @@ static int dw_mci_hi3798cv200_probe(struct platform_device *pdev) return dw_mci_pltfm_register(pdev, &hi3798cv200_data); } -static int dw_mci_hi3798cv200_remove(struct platform_device *pdev) +static void dw_mci_hi3798cv200_remove(struct platform_device *pdev) { struct dw_mci *host = platform_get_drvdata(pdev); struct hi3798cv200_priv *priv = host->priv; @@ -180,8 +180,6 @@ static int dw_mci_hi3798cv200_remove(struct platform_device *pdev) clk_disable_unprepare(priv->sample_clk); dw_mci_pltfm_remove(pdev); - - return 0; } static const struct of_device_id dw_mci_hi3798cv200_match[] = { @@ -192,7 +190,7 @@ static const struct of_device_id dw_mci_hi3798cv200_match[] = { MODULE_DEVICE_TABLE(of, dw_mci_hi3798cv200_match); static struct platform_driver dw_mci_hi3798cv200_driver = { .probe = dw_mci_hi3798cv200_probe, - .remove = dw_mci_hi3798cv200_remove, + .remove_new = dw_mci_hi3798cv200_remove, .driver = { .name = "dwmmc_hi3798cv200", .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Thu Jul 27 06:59:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707405 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6FE5C41513 for ; Thu, 27 Jul 2023 07:01:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232841AbjG0HBh (ORCPT ); Thu, 27 Jul 2023 03:01:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49900 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232797AbjG0HBZ (ORCPT ); Thu, 27 Jul 2023 03:01:25 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2136.outbound.protection.outlook.com [40.107.255.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8E3F26A8; Thu, 27 Jul 2023 00:01:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JlA0BtWEaoC+EeE2oNqRU4v2wiXOWXmFXllqb+fWEA4qRy89jY4LNc1RUmzYQB9G6f3bf/bY8LcKEVAABW1q1U7BUJVXTx5iXtYdLScjwa14q/vuwy+62h97N6e4f52EC2mNMjUdKyOuYr6eMF8iWYUSQHKuZRnIPStAZdglmNlF1nla9ZDWLW/ne5OYjTF26/7TCM9Qz1O+CemslWiZy8cuXeaUC3fSadSDCfCpyLKjfQshPlbXkVCiNtn+QzRgGFdlOgpMZQo0I7K6wi5svLQyuZkdDhM007jJxQMGZH/xuM1byOenulOVI9owXz8BpLmFJ8ATo1RLf0DZV90pgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P4JU8APsrhrkPun4Q9xIy3FDPUIcIdpxAJYFh5ztE9Y=; b=Q4Z/RCVQKdjsOURHO6bDGMQxuw0ThwH7qbmbu97fXERTemcqcJDddL/lWCwytQXaSMNJJ39E0W1wHz8HfwJhMHUqDJAHh4xi7X+CXXMBUTH8VWREhqN/pge3KHc2cv/FJNCQblQkTPP6R/oIAe26q/pyBitr4dkYMv+v3twrDYFv34mMB1SUIRNqWNYwWyx5r37MjsD4TDct+IT8HF/KtBHYgU4R6KXE3ltn9n42TSLhNnASNFkMVLgojjiDtLvKIs7HMZeN4DyRuTbAoXtKtfilAK/tc4+J34SuBHt2w7polS8v5/N1Q5NXmj/0ClDGBG9MnhFVK9SpwYN3TfaR5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P4JU8APsrhrkPun4Q9xIy3FDPUIcIdpxAJYFh5ztE9Y=; b=YZ4EHclvN33bMd4dSDUvs13CAjhk+vLm2BG44nnWsURUbIcLZWum5CoSqpviFRKm+wiMMS5XcDEZogPW3R6GEuzeasf+q0dqZuc6r1rV7jRVYuI5z/e7DiZ2gUJiVCtEk+EFlqRM2g9BAcoEz00MesH3Pqd7omGtZs7GNs9RyFlaY8wZ6BbmZwhXO725rc/cQ04dRNPhUzNuT9RunpcVL0zKy8s4RIscIeqWaiybRmouqU9N8DIrdmYfbPto5TcmXmM2gaflCD5UNDTjn7DzQtdDEOal3nbG27BUCx8t+9RB6gcIfosc/Bjjpk/JqNRP+e7YrBvE1tdicU+3/CYedA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB4276.apcprd06.prod.outlook.com (2603:1096:820:78::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:01:18 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:01:18 +0000 From: Yangtao Li To: Adrian Hunter , Ulf Hansson , Taichi Sugaya , Takao Orito Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 10/62] mmc: sdhci: milbeaut: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 14:59:59 +0800 Message-Id: <20230727070051.17778-10-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB4276:EE_ X-MS-Office365-Filtering-Correlation-Id: 10ae0dac-0a7e-4a0e-47b5-08db8e6f46d0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cX1sb+/h95KeivzdjfXnoFKL7WK2sLrp+Edg9vSTHuEcL6scTQfeerkC/ryyFDBfqfAs+242UBu2wPoLvCs7tbRUgEU+xPWAY3VoNOU9aKN5jpu6yx/z2lepUPBZ1cpyg3kv8UJLzkrnx+Rmb9+mzfhER3zTn+nelEM5wRa69pbv8UUInhrB97MBCsa+HlyPRnkFmJfMbAfeTD6P7uFipLdC9eUWWB3Y3ASmDg+i4+jQUFj0MPIGYVl6QhyVu04hGTdbnYn+yClVsM90Kv4Abx0ADr6XqelRd855C92ZmSRVNhj6hqWWgWSEHUfNQNBkS999Ir3+tL6siHzvEUKL+iqizvDmNOgd/JsKiH8E3ggZcFJz9ipJ6KObi67gIhrBe0tBl3WvhbI1+piNu+3yyKIAs7bkCw0sPfU0e3GhfGSn49FGf7lQ93KPzB7veHADp9V19UnStpm2io7DOvdv5FXMKoU3VJWe7fTUhor2i2GQ6BaFnX49JFAYnnrkhrd0kHFu4dmtk2/ln0EGBYd1poPZhZ/jDVHZBvh7eF/GCqUO5sDjPxgGhpsBdP705tNqvQE8XRNcgFRkGbTNkzV9GkCL4iJuvxlKLWngPFHy7LV8reeY7Df0m+oFXE51NLv8 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(136003)(366004)(376002)(396003)(346002)(451199021)(6512007)(6666004)(6486002)(52116002)(66946007)(66556008)(4326008)(316002)(54906003)(66476007)(110136005)(478600001)(38100700002)(83380400001)(38350700002)(26005)(186003)(6506007)(1076003)(2616005)(36756003)(2906002)(8936002)(8676002)(5660300002)(86362001)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?T3x9XsRzL8vvwALvAffW74wlVacx?= =?utf-8?q?32t9vuCFmt3Sm/U8XSC/ovuho50u5IYkRD0HETxhUreR0nzpgxZrFAUNooDPm+r3O?= =?utf-8?q?UKWuoraxWT8FqDR+BCp2aLvesvtw7D5GlTC5pWtNhh4CxcJFoCF5VfihxeDTiZJK5?= =?utf-8?q?Nxx77PrlUjmg7miO1XBtPZSMOZkYuSJk8H6lM+u6RIDttpw2o5IUFkAnoAI5e2l9I?= =?utf-8?q?Cg5vlZnY74C0Wjuoi1QYXZxtnbkv5LjmF6O2MhbsTaNcA8iepsWcnaYRRID1n2fd7?= =?utf-8?q?CvMLYXCWUukVn4jVWmLEd375WWZG8fV80sCQMyivAUQPkrlPZzGnNKDKhdwuDnbq+?= =?utf-8?q?iYLfTeIicHH5ojtE4V2qpCKTIy2oM7mTjUibhmkV5u3aXD6H/bg0+WEqQaEmAf64J?= =?utf-8?q?kle0U0q2yIHlhxbMkNU03Yo+u/eCcrRdF4mYI5NYJedt9hZnc/18c59BJ6knxhyVN?= =?utf-8?q?Rdis4bhh1dRr9jGryqoZbxUm8kcH1a9Sfla2v2oGfh2T8+C+vX/kQgoE9i3iERlI2?= =?utf-8?q?UHHvt3CRkOsw7GxB7CzQk4VNCLlkT9X+NnNi5XgZgjAxVJqcRb0YF8ivSt4vb8V2A?= =?utf-8?q?Ul0iZlt/ecNMtfgLapMxBKFrJafZtE9cfQHkMkzT1Ot4+9/aVUTdrRX/FJ2HQeu1m?= =?utf-8?q?wPYidUK7MUyPRgpq34nr8NHaaFrFiQA+3I9L7Yh+OIORhuYk9fjiC1h3QSsDLwCjm?= =?utf-8?q?xKKPbqCuPB6iO66JVhhdqrKsKmu+q807jcYz+EbN2hVFHggO87+z7MzUUqX07Zv8D?= =?utf-8?q?lbNWFUjliP0+rpfI7OpkekWOGVL+ij4l+UUscN1jd2ag6iXwfjXvfIqLb5hG2TH8I?= =?utf-8?q?rH1DcoklFgVrz1qM5XLVXbzqnjONwkpWxQoxjsTOryQ4HwEOOpUdC3/5b8UBfSiJa?= =?utf-8?q?x26dVBpvO7BHCKBIXw5XT7M7Cc7TybmHbCUZnulz7UyRbCAuPox5AZxjC0lxJk3kP?= =?utf-8?q?bbD8vAUsZ5ubVZ2W11oVgUftIjbsMO/fAoCgFOGZdDTrcxKhKh1FY97M53kVzKnNg?= =?utf-8?q?IThqzxJxYHUD1EHJndo7I7wJCF7alOtcpwy1H7GTwS48AYSwMt53CeRDm36lUPZux?= =?utf-8?q?Cb5huyL7OXhEqTVfpjzolNtsgNw2xww00XONk9uNXzJI5vGiC6zhwYbwxz0TLgoWp?= =?utf-8?q?p3yo8r8q2PKOMAKzlAge89nhTKBMCM/uR+VkYq+OBLPMSlrrVyLcqJwM8LFb1exEg?= =?utf-8?q?rSRDOEXNby4lPk1Zx/GkpZ9niD83aa9+9cRVng+mdbpUWU9AVTMYN46JOTT4QZ9gu?= =?utf-8?q?xaIEvk2U+KIAV68POik9rXazn3yVhGnXtDqPmzkZE/e8JjJXCii6M45Xgdz/IvTLV?= =?utf-8?q?HEbbvRco8HjcgSnYAQknRD/Me+C77EBNkzIcyevoMXd/cbh3lxO5mU2Q74YTeCISG?= =?utf-8?q?JhINJgN0epdSvxrgJqhSMoFeCRSWdqyjloJV22Jfbkd9DgwrwgMnyOYcNPqtDu2dh?= =?utf-8?q?0iqze4WkTNzaW3Kfnpn+SdRH9U0d568Ojlz6ufesGN9brd3g1xg2ICrvz0/uYrz8I?= =?utf-8?q?B0pN6KbEXZ76?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10ae0dac-0a7e-4a0e-47b5-08db8e6f46d0 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:01:18.5142 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ePt8gonIoXTx+GxTnma+72AoJJ7BLeqwy57obaW67kjGTHX+feo/SC2mgOQKiCbmmpHlXxG9R9pf4AtJ88qhkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4276 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-milbeaut.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-milbeaut.c b/drivers/mmc/host/sdhci-milbeaut.c index 148b37ac6564..ee4514c90eea 100644 --- a/drivers/mmc/host/sdhci-milbeaut.c +++ b/drivers/mmc/host/sdhci-milbeaut.c @@ -313,7 +313,7 @@ static int sdhci_milbeaut_probe(struct platform_device *pdev) return ret; } -static int sdhci_milbeaut_remove(struct platform_device *pdev) +static void sdhci_milbeaut_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct f_sdhost_priv *priv = sdhci_priv(host); @@ -326,8 +326,6 @@ static int sdhci_milbeaut_remove(struct platform_device *pdev) sdhci_free_host(host); platform_set_drvdata(pdev, NULL); - - return 0; } static struct platform_driver sdhci_milbeaut_driver = { @@ -337,7 +335,7 @@ static struct platform_driver sdhci_milbeaut_driver = { .of_match_table = of_match_ptr(mlb_dt_ids), }, .probe = sdhci_milbeaut_probe, - .remove = sdhci_milbeaut_remove, + .remove_new = sdhci_milbeaut_remove, }; module_platform_driver(sdhci_milbeaut_driver); From patchwork Thu Jul 27 07:00:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707404 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FFF9C04FE0 for ; Thu, 27 Jul 2023 07:02:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232975AbjG0HC2 (ORCPT ); Thu, 27 Jul 2023 03:02:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232930AbjG0HCO (ORCPT ); Thu, 27 Jul 2023 03:02:14 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2136.outbound.protection.outlook.com [40.107.255.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD30E2D59; Thu, 27 Jul 2023 00:01:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LoPNkdNf3CwBF8fpYaiIjivGUhuAvSL1Q+fswItYF95l1wJn6hyZTK9nWa042TEgmU/T7GUO7ekbxL0csiFmQdeWMrSoiHWYta13N9aFXCJXpry2pWlso9LK+j681M0EBjRQo6EI0dkcTOlgyEecmsOevHFaExgWxGZrtcbksohwFmUxL4e0i2JqqlI4BtLqz06pe40UDvSGTGiUrBjGNRNmFsiSUoycn0k3UQ3afKnlt9VkUuY5OKGimZT3R6VykLY0TLbC4CpXW6YRglfNj4zoWzTap2IOBdGWceiTdWR79lj4sQisPZbU+7zBrv+Ty5myCxErfIk8OZve/tDaGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tOU6V6CM4hDWvK8Wspv66nRWzHcyqIZmd9G62GfyWvg=; b=hztcn4MBj7Cj6blueolPyd5+6VNLPFBdigPSEhOL1j+8B6f1G1INBeaW0ZYp5ydVHmrN/ytsY0CVfZsdJortCwrkEiMpTi8n9QENiV4rLqJ0zbOmuFOzgIqIOfeZ9fjqCC1BEbUFBr5weJN6PUbJHBLQB7lpY9MiiCXiwn4tALfQU0HAf8KNk5tRMHFlG+wQBNFlG1HQZB0Li2BKfBs4vfzpvwmfaLScFwr+yz/dCKqQUWiJebB4IMJo/oQVmKNyu1kr2ScPDHzvEEb7iPrVHaT72sn/j2QsAIWG7WAGCC5XJH6EJ5NShUrTXAhAAzgcTJlMjb4kmetK6Y1He+iMaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tOU6V6CM4hDWvK8Wspv66nRWzHcyqIZmd9G62GfyWvg=; b=F1nQSZvNtlxnABkzwvxiM0QQLI+q96F6VAJAtYbnOLMJlDlNK9YO+o8U+QbzMLGi2RIFONF0D2BrpX1SHjRfBSobGEj06RjwbSwSu97ZOFrjV0RHc1tGzLhrvkC452kz9nZfNmgeEYsTo1bin2xrrkEI5A6oGXdqpNnOQwQLdHR7qqKYXCcewB4ygnXvu1jhkd/Uu2ZaOCa/1g2heMJnDUCCBmsBNsCtHbKva7sO9jqWd+45nNynVWtP/4whVzfMR25G2agC4PDm3oX7S8qacdIMORr4rTQLGqVyvpiS3l9HcH/sjfKYDkdRKrj9c2RtEq19KfCbqNQOqRLc0d0pUQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB4276.apcprd06.prod.outlook.com (2603:1096:820:78::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:01:22 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:01:22 +0000 From: Yangtao Li To: Eugen Hristev , Adrian Hunter , Ulf Hansson , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Claudiu Beznea , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 12/62] mmc: sdhci-of-at91: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:01 +0800 Message-Id: <20230727070051.17778-12-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB4276:EE_ X-MS-Office365-Filtering-Correlation-Id: 74e8dd74-8c5e-41fe-2850-08db8e6f48f2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HHQzDhAkjaF1gmCxf+M2t3UJVuxarh5r94EW5lScEcLf5xeqhbOV4gWZDpwwYGsr5L6JrMqojdSkYr4yUNugmbkUkhtueDDydqIbdubUa0VKz+/8RUzB2TgoJyurztbj6+18LA/Q6tcvOxL25sTFOVQWlKBeLMF9Jfre9gT+ItI/uv5WgWXtrMzht7d0LUctlNizry5ICqOLAA5CSys+JKX9lB21Y696HIZybSmqMK/fo4j1PD/EG/S6hD9mbxojzTqfdtyWUp4GLrjGKedjZpTdeu109b4b8GAkiDh1ezYm16UnemxHd7WDHDNGqJ1FB6/NDUTdeHdGGIr/LkWfRMKcMQ0przqRBzPZ7j38uTAYnFkmP21URtA8p5/rJgp0hDs3G0xdsW8vsYxnTq/h8Y0Tn2F7771RQrfINy+GTn5wp7gl7Ic0K/mivhFYNWKRvJ4lGik2aNoynvKQxe73d8aLCmYAfWbJ8s0kbKUC2Z/vNbDlGpXQMJ/uMM2ukxJATIfymlvt2coMtg98Elcra0QA+UZgx0iGXnl+wLdw0L8KFFvt3h54QFObKaQ+s24dEUqSjL2sdQadr4LfQgD44zc7C+wV6j+gWPEVKCclprsBtivCRIQkdQWfNKkKHzlc X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(136003)(366004)(376002)(396003)(346002)(451199021)(6512007)(6666004)(6486002)(52116002)(66946007)(66556008)(4326008)(316002)(54906003)(66476007)(110136005)(478600001)(38100700002)(83380400001)(38350700002)(26005)(186003)(6506007)(1076003)(2616005)(36756003)(2906002)(7416002)(8936002)(8676002)(5660300002)(86362001)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?C5SLUL0dvT3ASCWscxb+hD35qj7p?= =?utf-8?q?cYdXJ1l/vDsMyF2Zf2UIeNbDGwjR4za61HA5eeOB0iqCGm1/U+H85azGHrXrO0mKA?= =?utf-8?q?CdFDztRUCQ789uwsEeTLibyNOpjcg22x8LggyW56O7Sc08Aq/E7LFFK1G5cj3gZij?= =?utf-8?q?ed94pTeU2Sr3r9yuwRDfzrMlTajkLmyz2G8yhsu4LTma4Mmtp4ROp3PDBIzQQEMrp?= =?utf-8?q?SGWGSRYEUbi0FDfcWjjmh4Ody0Zl71dQRne+6WUhgvKU+FcIms5IHF4J5LWfeGBxO?= =?utf-8?q?NU9IQdFKABljh+5UpBWZIAozO6X+RzA6XfB3FrMdczJNyvAYPG/NYZ3Ho0pBLG3zQ?= =?utf-8?q?i1JUM8dyQK1VelONvybviHCXOHyeuIe0Y0s2Au0GfvvbmAiWRyQlfSDsI2oPIIq7G?= =?utf-8?q?DEwTmMVe6FxLMBmaY/zhZdkFLwsop7GPOKeYae/D+fLoUutIEqNBVsS7QDHeKh9Ay?= =?utf-8?q?VWm0vWzWQe9zVbHGL2Ar5GOhiBRHjB+gmX6uGH8iPbx0Lkja/k5vXCBNr6KvTvyiJ?= =?utf-8?q?GJMe2sQih/WG4N/k0RTiHM5sGmOBy0x4vSJ+WwjXz6bYnyxec4foAOh7MIMhJfEJE?= =?utf-8?q?gircxXONEhCUoBF1ni3154OtLX98CFqRqdtRpkerXu7rn6EOzdCIaM9cOlEMKGo2X?= =?utf-8?q?TTAvc250izJ4l0iolHM+BxPKzQqElJcOeG8P8SOrZwrG3/0Gb+LAqLhkm+p9JsW7v?= =?utf-8?q?4hhMVwnqITOEdJ8rgFpC9JR/2exsYpBAZgHOsXOPsdWmNXXhjmK3nwy3MC7OWcgOE?= =?utf-8?q?bpSNQoh4Ftkry4H8tsU4q91s2l1Q19g1Gp8Ub5NOOgDAJzVA4tJMP9ZRxba/5aTtG?= =?utf-8?q?gROgrzYsG8Yn6S4w2S+M5+uWkD+PyxW3q86qzyzs7x45alcJWR3EtkwhiOuGRu89N?= =?utf-8?q?6bPWiSQbcYeK0mlSqdJMj+ifw9qxYhtUx8zfK7cTPAL/9AKDqaofFjsMHpv+07rA5?= =?utf-8?q?+2oXMp6AIc019BujDuRPt2tnNxswAjlexFSBsA4d/bxAFIN17/2yFMfJIPvkeF+0e?= =?utf-8?q?1BWxkqzqv+YRA4SqYjo5dzxes20qf2hDksBUrlmxCAq1TwaGL/tu40DNgne0CrBta?= =?utf-8?q?RAn1XbWGXqwCoGgycRdAj4LxtEOZbwI2GglBQKpw+DZ1zt/rutHA8mOELj6G8VNPL?= =?utf-8?q?JKrNj3bhIKsFVNbjAINJT8GUa8WiGC7hnCf2GVivZ1SI/DNV4amVEYteppmVra+ij?= =?utf-8?q?lTMwj04y1z5hVdu0ak03PNLp54w4qVa+PUqtn50JQLCVUwOsW9v4XndrJO7a0SJ+6?= =?utf-8?q?1aHJJijSCVGXa1kuZ6bsvpqx+89yHiUklHUbYPJXwUeOCJ6aOkz5VqA4AmbNqO92G?= =?utf-8?q?bgoiu/OrSwQUxkWXvXac6Za8Rp0kT+UgMQuK4zWmfqZUwu+ZmHLL118bqHCYciqVb?= =?utf-8?q?Lzqv5UVNtJvCgs2DdX9gDZms6dw/8aaU/lvf4KbsbjVve3KwUjI66NFVOA4khdRJP?= =?utf-8?q?d8e2hOlx9P1IxDrLC7NbgtnzBA58SMdNnpofAihSlvFI4sYHTfDelJnVsBTIm7wDQ?= =?utf-8?q?bZLJTz7j9VgM?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74e8dd74-8c5e-41fe-2850-08db8e6f48f2 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:01:22.0611 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 02Iq30tRozaMujh21xEbKBaOo5gcD6NiTdPSP9sP3wOw89rpf4ohtEJs2AulMxBIS4zC66Pr4kSfvDEHHrwE+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4276 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Acked-by: Adrian Hunter Reviewed-by: Claudiu Beznea --- drivers/mmc/host/sdhci-of-at91.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c index cd0134580a90..af5bc0caf29b 100644 --- a/drivers/mmc/host/sdhci-of-at91.c +++ b/drivers/mmc/host/sdhci-of-at91.c @@ -443,7 +443,7 @@ static int sdhci_at91_probe(struct platform_device *pdev) return ret; } -static int sdhci_at91_remove(struct platform_device *pdev) +static void sdhci_at91_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); @@ -461,8 +461,6 @@ static int sdhci_at91_remove(struct platform_device *pdev) clk_disable_unprepare(gck); clk_disable_unprepare(hclock); clk_disable_unprepare(mainck); - - return 0; } static struct platform_driver sdhci_at91_driver = { @@ -473,7 +471,7 @@ static struct platform_driver sdhci_at91_driver = { .pm = &sdhci_at91_dev_pm_ops, }, .probe = sdhci_at91_probe, - .remove = sdhci_at91_remove, + .remove_new = sdhci_at91_remove, }; module_platform_driver(sdhci_at91_driver); From patchwork Thu Jul 27 07:00:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707403 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF277C41513 for ; Thu, 27 Jul 2023 07:03:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231423AbjG0HDX (ORCPT ); Thu, 27 Jul 2023 03:03:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231359AbjG0HCu (ORCPT ); Thu, 27 Jul 2023 03:02:50 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2094.outbound.protection.outlook.com [40.107.215.94]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4761B3ABE; Thu, 27 Jul 2023 00:01:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G9AzfFUttcn+qHrEEt9WGAWWvF1tflGVJXIlP3/UMrpuTTMkVUx7UWxaRi4h7Sro0GZ9Zh1xjpDzIT7lraPqu/eiEfzK/yydlIXE9j1RYBmlIpzMfCkQDsgbhmrq3+133LBmN+tXe6AgXTBdnMAwKEtKGvunW+2kfDlyehovcPC15LE3GojQ37jTjaVLRKVxK7ah/mmtvKbY+IyI/qQTHIikL8gy7VvmqRjfpwQgipj/iufaeE3OllpoGT6KbbJiPwTLl+uAYu46DB5DAmyypdWmIqK7z9J93A1ikxqpmCFNFZMbYeESFMXTG4hN9IiYnU799FPV+AMGAOqt8ZbxLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d4WNf4YdQgPLt01IdeoKmo0VQ8uGwhUq8MCThQTK3fA=; b=Cz/HwabeP498kwWVKSqAN/W+o0PXq10qiZ6soo5S49n6H83jqW3UR5qMx5HgbmbjSgjfdlqTUp+BEh5Usnn4jWr5JvXTb9fie5PcRJ23R1oFl2MjTgoyORBU5Y6TXWKUVSsLGDBDfHllu8kdtr5zdM4EYCd+4YIpfLIHeZSvqFmEB+DLfZeXarbpmdVkQ/8FwxJb6oi8cDC9nxDkc8mDm49p5xhzRrzXuDUx/pNW8lGEQW13XnZVxO6RqW+XvPfeVDOnDxQFjQCE8ldYEJpjhFxl7XvAj/KIB0hXiY9HvOyH2xheca9+f8TUMM8w1pTNNyb1OuW9prw2IDq9Vt6jgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d4WNf4YdQgPLt01IdeoKmo0VQ8uGwhUq8MCThQTK3fA=; b=U1EUq1L2whdYL+lb40QA7K3uR/sKp/IVmUAeehZm0IpBEgTGrxFkwmt3IiZr0WvAEiyOinF4kfC3tHyK77fEJdfQB22T6/ZfWwGJ8SZOJDy5s21723/SFj7aLOPX/n5Vedy/wu1C5OdlZjpfyu/f6xjYbkm72Elv426M1Nsp3GgukLNY00G62bOfZ9Z5Sa/8zApVWkJzedXA1awYIVDwY9BCLQg3H9RLBa+aZVKHOFJ47tQTM4zRWX24HKoFpnb98ESsd2Aj52w2eRpqFBZpTkCyABF38XlRTMLVH2kEnLJv+20tgOn9ZZUOzDU9qplTO/JDtPv9Hr9KS6n8lbL3iA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB4276.apcprd06.prod.outlook.com (2603:1096:820:78::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:01:27 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:01:27 +0000 From: Yangtao Li To: Adrian Hunter , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 15/62] mmc: sdhci-pxav3: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:04 +0800 Message-Id: <20230727070051.17778-15-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB4276:EE_ X-MS-Office365-Filtering-Correlation-Id: 3b98ce56-cbc3-459b-cade-08db8e6f4c04 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h02ss6hO0pivW5YabyHVw+4QxAONs1wDih0bDSDzHuBS8ii21daYyWOMMdBjpSF6v/jhgommdQ3l2xOGOp39uXX0scjhE1xfiYszEyNwr02dEPsxK3VQWf2laxTruZmYXaFbdcrjyJ1isBfrDjNsBJSF7K7JdefprVkPVm3gSpJBe0cOCxHTiFFTf32hAtF+EvKx6Tg812o0gP3dPvomH4gz/rglHByalwwFRTQ+2MleiyPiQPXgeSe65zCZLOJYlBKULd0u3q1HId1+45K1JqweaMmdVeB58J60ufU3BQXrZDeMfwyrQNQlsmXbB2ww0Pq2/TsiIidAxSU9tTHjXg1GOg87S8TRKhy5Mm1ZCj/TyAfls9FQUBs+k2Mwzafs4juz/9/4uT4Mzx2atGPuKw2tK9vsxCJJzE6Ka4S0WDtcNgajN+stAsIYyqcx7He8g4zVe3byhXm/OOG0sthI6LmcH1OwpRJz6GoBWBkdJknlp9Tt1wbO0LzAoSd2DQ1ThCC3MfuL4Z7cN9Q5EyIlAoqTe08rP8s1KCk/h5gD6PifnpcrLSeTbBpZhLhPS5/szDQlo31UQLzCgddmCzpSgPzHfyErTrGAxsa1YPqs4LHqHDstYXJZr3kTAmB6NsfN X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(136003)(366004)(376002)(396003)(346002)(451199021)(6512007)(6666004)(6486002)(52116002)(66946007)(66556008)(4326008)(316002)(54906003)(66476007)(110136005)(478600001)(38100700002)(83380400001)(38350700002)(26005)(186003)(6506007)(1076003)(2616005)(36756003)(2906002)(8936002)(8676002)(5660300002)(86362001)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?aBNpAodJ3GgunmPnOttx5Lckodd1?= =?utf-8?q?FaZ/GGWKbyIwNnmCJNkach+7YP7qsD2oXsXKOdsa2MtJ/pZ4GpspZrT3JsMBPcXHl?= =?utf-8?q?i6Sz+QRl2AOqINlq2VPBvroZRiTN7ZbIvlnjOpzliAEbE1OT16pj5NP+lW0AEjYW0?= =?utf-8?q?J7Vmz2HWmdUxfl1jwcb/ioYiu+1kgWZWPW0Okn0Y4SCc3AFju9q62qXKwDBVIMaal?= =?utf-8?q?JRodESoYswT5hCgNW1AURSKJ0Iqt3al/U8W8+ScDKnvcYhwegLQ47Kre8xjMNhCWj?= =?utf-8?q?noccyAi2W2jRX80c56HIHOyuFsI5MXvbhFDObHWa/bLouw9qIQ8Bo1WsZOLs8bOxO?= =?utf-8?q?tfNt4sb74/VjFSGddFbCo3Fd3GESIdQ1HBz9Eg8Q9SNAc1ktB+WCO6cv0kppUDWYI?= =?utf-8?q?5IbHqwG8fB6fEts5dBW4ohfUzKlJQUh6gV9fQGNE9GeC891Qv9yUNwepHGWlG2Myq?= =?utf-8?q?LROE7cbFCkq4VCzlgIP8rqKolzxdHyGP3xgzrgI/LqGHFiMeUbUskZNJ5taldAeiY?= =?utf-8?q?NuNdVD8mgLX7oYqXlnGxffGFI8iJjdbvWreWGcD4DpiL4kAcelrAloFb9s7JekOd7?= =?utf-8?q?jMV4miBsKPIUVlFCa8GMLDFKb4K+29vHucdxfmgJY6NvD8Hm4cDuj5U3eL3ze4WDU?= =?utf-8?q?kI3y7bDFyo7oRmX1hi/NsgWSv9N1MElpL7rBCZBv2gwZ55bQgaIq/HIIhRUrZUzYs?= =?utf-8?q?f+N4DeRzaflV0lhvnQiMBTJpC3mEqmA+aeWTaDRMUxMYs6riycvsEhF2DnXIvf6wE?= =?utf-8?q?P5cL6vW0vTsmgRBfYaNbEgxtQkNwdWoku2cjcLiSctMOsQwbN/khUeKvXp5vzpkvu?= =?utf-8?q?b4/BhxyQ5RvI4qFcb1+m9J0N0iqNK0QQJisCMcaEjpbj/R/iLiQQbs3pXfegVcqfx?= =?utf-8?q?UKxUWsay37eMPeHnsiL7wnQfeaPuTnIbBe0Dcwep1z2wzafn7zpA2eyJUhiFRqB0a?= =?utf-8?q?LLDlu1fNhOuHQn4B6QsyKvxZrEzjKpp7BYMxV2rO1V+jh9KMBusQLOfe/ZDBILPP1?= =?utf-8?q?uKAlSZm6TgH1NVFR8MR4gXNTptfhk6B+/1qgHgRZdwT7+NSYmVJNqXsj5J3bHdsJq?= =?utf-8?q?0vvGZPMSm7djWrVbQNA0E8FHaGMc9c2pMgi6Xcu+ofgMGr6qVaQQEQlwmNRoSMkDO?= =?utf-8?q?CtP66SDvr2f9Xh9QA6Be9+7kpQSdPjo78OIrx3X/DVcwB446QWnEGZCJJnEftNW1k?= =?utf-8?q?PbdJOCLZTnu6+agLmyGsr0tnWAfTRL3zeg41jVfb5Bu5+GncPBLUrtUTeHk5cRXZc?= =?utf-8?q?QjV2lfqdJCg3bttN1T3RbG9TbTlceOOZWZD9k/0c56r7mGPz9JU3tkFXeeDTstVEN?= =?utf-8?q?xRuVdiUxo6QVH1sU9KKkOLFmjPbluKw7VxlQ3BgLKETNRZ2vFIrW9gGNu6tAY/sti?= =?utf-8?q?Azj0EN4g/jhMR/TmNROAGbOMj96LdlBtfrX85den/FUSbe64+4bboeYc10nT13cc/?= =?utf-8?q?LukWgGDXw9gO/yd6YcmOXF8hM3ZZAwg3Irtk0TBb+w+ME3oIcuK1XFmyk1uEdmftp?= =?utf-8?q?KDKh8GXh8ywq?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b98ce56-cbc3-459b-cade-08db8e6f4c04 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:01:27.2335 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pEKD/f9k5v5LirrsBbH7hX8+JYBdJmIca8Fu5fquWf+VQ0tcPcx+szRRqetmumIaJRMgr+aXfu2h2gCCTapk3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4276 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-pxav3.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c index e39dcc998772..3af43ac05825 100644 --- a/drivers/mmc/host/sdhci-pxav3.c +++ b/drivers/mmc/host/sdhci-pxav3.c @@ -470,7 +470,7 @@ static int sdhci_pxav3_probe(struct platform_device *pdev) return ret; } -static int sdhci_pxav3_remove(struct platform_device *pdev) +static void sdhci_pxav3_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); @@ -486,8 +486,6 @@ static int sdhci_pxav3_remove(struct platform_device *pdev) clk_disable_unprepare(pxa->clk_core); sdhci_pltfm_free(pdev); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -570,7 +568,7 @@ static struct platform_driver sdhci_pxav3_driver = { .pm = &sdhci_pxav3_pmops, }, .probe = sdhci_pxav3_probe, - .remove = sdhci_pxav3_remove, + .remove_new = sdhci_pxav3_remove, }; module_platform_driver(sdhci_pxav3_driver); From patchwork Thu Jul 27 07:00:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707401 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB273EB64DD for ; Thu, 27 Jul 2023 07:03:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232932AbjG0HDq (ORCPT ); Thu, 27 Jul 2023 03:03:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233083AbjG0HDL (ORCPT ); Thu, 27 Jul 2023 03:03:11 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2136.outbound.protection.outlook.com [40.107.255.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 342CF3C32; Thu, 27 Jul 2023 00:02:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bIUFxUoswohzQD8IyBKO0/M1vcoi+94kZtxt+6FZHCy892eOIdGseMj2rvHP7DB6/NpV7J+srNFrMAr+qZid0tx+cV6fF6QM9hfsWmQoUIrc1Yp+5K+oWHUMpPBAp7g7t9IGIWSCAFiSguyJ6rwHR8OSPRkdNgewjlKUyLEdlCaWobasU9On6/itM9f/aEjX6ZhEHCTHAgumVHjxQOiMlalhyo6/n4UNTp+ZKQpnNpq6F5tEaWQCvsxoeJuhNZRsUOTBtgTG6VSw6EAQsdluArj813n8HdvZPsvWrf4DUhCNR6AtO4stHT4nu9W6OLL6YhVSJwhCv7KswHZd4O5vDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LsBYm0syPr7thxBEbMPEsbcgZPueQUhwrbcvN2FuDVM=; b=n/N6FNsOXad65QvOBoT1qVycXYwNBBP5a3UN2BRYW7/oPsyL4wWYr3OndcGtcm0MkChiEWAWjUh7myqBNQXVhRpXDouLV1el42uON/Ymz1R3Iu/muRGYQ5PEdXzeGsqMl8SDci+6ammQ5BP3HKze4YwqiutYl5jhM7jnbxsvp2XE5SWsbCpRPgxR3H+2n5mmbXN+KCcffevsEKMaQ4/3tQjtMu7BCvIoJpDsSvppJne0nUh/keM8mb3hQw0x/fQRd3b3MJEBKtOng6mP8a5VNNg6BAi/Zg7DcGlwadFnCsauM5Be+7lKBYMVYxzgR/E8ktBWf6JRcNq3VqCGV1Ak4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LsBYm0syPr7thxBEbMPEsbcgZPueQUhwrbcvN2FuDVM=; b=G9l9ACKifca4p7xw1ME4pZtHKpyuu30S90kry/JhVpppWx7jvX0VHZT0zPLtvPiaks7Oy7QDRbtXm0bUbNHlq0BxVKvQe7yvSBanbiiAEHHEDVkt8mjNPoHzHgEMNOTcrfDWubbizvNdbxptIMOO1bocaxS3IPop6u0dErH3UuKd55W09VhMMfr0BE0wpuyklrxZA+6sRFd2RHwmivtYrM8tQeMq34Q/j+WQi2xjftBPaBrR61OzsKyoFTj6VMJRtvRyGTTjv/QwJR33HASiv1XG8SqdTZ46SZKyBHQepfjWa4pqGfi1tGUm3kWofn/+nf5ejTLBmWo0RcP79Swf2w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB4276.apcprd06.prod.outlook.com (2603:1096:820:78::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:01:30 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:01:30 +0000 From: Yangtao Li To: Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 17/62] mmc: rtsx_pci: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:06 +0800 Message-Id: <20230727070051.17778-17-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB4276:EE_ X-MS-Office365-Filtering-Correlation-Id: 2582d20b-098d-4ba7-9048-08db8e6f4da3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Iu4qch+4ZUDdp5su2LbUgomBcKqSRmPyZ98p4vcYYHca75TGAJWVwJruzsK/INa9hepmA0q3uRDs2lcJVRsoBcAx0HgrxxVCLdJGuLY0b1ehEaVwWGrOJBayW7+1l5KFppXQf8zB7QRnRkD5ct9z9JgSaA3MnNb0naOrGSOfdpr+OiVGYUfpMmGhrqCObeGxwZI7ERXFIhnTvpqMRfxcHdWfyyH84MESG03eaRZpjNyB76fIEaaLHwtxm18hSr8GWCgkOaheWyd9VxS7N9hNX+iCC4ATf11GxSVsqrwWZzBTv653+xauFS+Khcnn2qtsH/29aSinWczYI3imcAe7nCNBFugx7PLJ8diFBfFWDJDSRoQq8gQaH3O6IrA6aoQbslkL0siTO+BNYfomzLYdJ6rKTnvW6OuGqOlcUzP71nV1NHz1BV8VrR7arH+L4d9ajwiQWDwUkN6M1tg3hKlH172R4uIKTEYJU4uo5sRXvWDkxUc05Ab1aK2+nWxmUXByKCiTd75U90vvyjxn5avd1lsP86JmR6cjrru8ckYp34kx1iLYK4KCueWFA0xkWyxM8OXZI6To8sAd7QFwwVHcbKOpej2zEP9BF95Ll180YfJ7tu0+p80TvZAN1vRKFzUN X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(136003)(366004)(376002)(396003)(346002)(451199021)(6512007)(6666004)(6486002)(52116002)(66946007)(66556008)(6916009)(4326008)(316002)(54906003)(66476007)(478600001)(38100700002)(83380400001)(38350700002)(26005)(186003)(6506007)(1076003)(2616005)(36756003)(2906002)(8936002)(8676002)(5660300002)(86362001)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Vyfz5d1Hpy0kBtGdMP9ur4cIDx/p?= =?utf-8?q?0kLoWTIz3Qpw7BYbcSdumur9AFTuDTl7d0vDCU2SwRAgIGIvx+kZxOhEf3/ObmlCu?= =?utf-8?q?hIeq2Tw7ntOmTAs5pudFQOSxaZaJ17zMVGM6X3dHkE9UgTd33OpHztTpmLo1NwbRu?= =?utf-8?q?bdHfZhfl3BYdE+k2P3GvfWAPO0Y7nErS2tbhx+YqQbGYEUY4FcrP9bo9Kc3X97CTu?= =?utf-8?q?zSToB9ma2o/7vV7SynMfFfNBvaaVlWR5D84tyc30lzHPc02bhjC0h0+TcfOf7aAWH?= =?utf-8?q?JHAhImicZfhttRlkZ7ak7GmEqloI+djMPhznqNrWWipMfCMu6Nujmac8zc4F+0CAD?= =?utf-8?q?sqOQd+rM6VAJpsnGoa/c8S54kzdArsltBTkQ3El/7VBjv/Hl2WsQwjCPDNcgSSpXM?= =?utf-8?q?5xU1i8dYSK8zhbFPGVjHvx+ny/QuiJSxNpv81k9PBRCx9ibbPXz0dKxrIpSc+/gYl?= =?utf-8?q?NfSbqMYX7lqpvnJNN13wiBIrmnRLo/YizIP2UdBizMf0wDGkT10PDWmpDadOimI4u?= =?utf-8?q?6oBCFJJwagDxhgpUeVDWsEvNZORoEdrva7doY66Z9jmXORpmFYdcQD7cSDLo7QGfP?= =?utf-8?q?LNtbei0ls5xS95zeozp5K+iKpc87endayUDK7pZ4lcvluNWrxN51HC5xEc266dP/+?= =?utf-8?q?V2ekh5u53/PXMCRgmNdFemj3nTtfRB5qeUqcCkPcDPYena9dPJMP9hj1sXWoxN83L?= =?utf-8?q?NGQV1LtKq6BLYMP4kwfy77aC57tGkVnA3JWk9cE+Yrvw0udzxSr94M7OC0+PJlRNf?= =?utf-8?q?jww+6fmxEh9+KkaV04+sPRW7Gm9IvD9gHlDDdBIrS2hGIs3OZZPVM01aCOzN8mGK3?= =?utf-8?q?JQ7LQgtwk4lj7nKmeC2pvMkcMSSg5evudpT7JhqkROlc6VqF6/KiVdsWMuHx9KrJi?= =?utf-8?q?k6iGxAzijYKFHonTZug98ehbTUxvd4vzceRI+6zQz3aLGWwhShrJGnlhPN2ulXwVs?= =?utf-8?q?IZIeDTw9BSbjT24r/JBfvsFF/bAXRdTEG5PYF4JAfqhxjxdmqIwYumwuzLWkD99Ph?= =?utf-8?q?rEEOg2P6kCO4rlEsaJCQ3yvP9LzPGAwzi1ypZ2BgGqAY5atf2sKzhd+7YvI6zsxSN?= =?utf-8?q?qwG/jT3GulpwICpIIXRiCLQjne2pBROtXCPbLVmcJ9iAXy6XLKY/7YI1S1zPVyC36?= =?utf-8?q?mPUHvHfGTAc2tpwHmEJUXLWdHAumFRrw1Ly0pLKLZWtcpGQqfCE9wTD3ANKVelgAz?= =?utf-8?q?X4Zw6WPMq8UaI27Krp1bOpXwl+exFjEgULaiPkuyas8kE+WyRCbWTWyUsKIZz2H9L?= =?utf-8?q?BwWpfUKRAP6t7rpT/SaVJW16Mfm9XQzY/g7p+WDNjQPEG0qBftT6dmac28uicU0Vr?= =?utf-8?q?yk2NQ13AO7EEv9UH8YOYMqUwonJ1TAFWwNdD9M6E9l8h9uLTRDMducvAtvz3KCyJa?= =?utf-8?q?UY32OAFi0qMBd8bpnfn+1N2td7wjrOLDPWcJo2c9Ry2WwZ8VYoGov4q0miALEKh4q?= =?utf-8?q?T/xFR2to2J6AqRDnepGXyDXkt9BkS4xp+RlsqkpqBJ17wYO0OI1Ezgi3J3+it3H3v?= =?utf-8?q?Lhe7ogW80W4/?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2582d20b-098d-4ba7-9048-08db8e6f4da3 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:01:29.9480 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PvJY1y+8QKzUuRxVPI+QrmAhQ2seikZ5OEE8uNzh1XmEtCHR7eZ/qhkBnHj1yPe5YfiE8touer3yEVEvvrbXSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4276 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/rtsx_pci_sdmmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c index 062d07c2ae5e..87d78432a1e0 100644 --- a/drivers/mmc/host/rtsx_pci_sdmmc.c +++ b/drivers/mmc/host/rtsx_pci_sdmmc.c @@ -1523,7 +1523,7 @@ static int rtsx_pci_sdmmc_drv_probe(struct platform_device *pdev) return 0; } -static int rtsx_pci_sdmmc_drv_remove(struct platform_device *pdev) +static void rtsx_pci_sdmmc_drv_remove(struct platform_device *pdev) { struct realtek_pci_sdmmc *host = platform_get_drvdata(pdev); struct rtsx_pcr *pcr; @@ -1563,8 +1563,6 @@ static int rtsx_pci_sdmmc_drv_remove(struct platform_device *pdev) dev_dbg(&(pdev->dev), ": Realtek PCI-E SDMMC controller has been removed\n"); - - return 0; } static const struct platform_device_id rtsx_pci_sdmmc_ids[] = { @@ -1578,7 +1576,7 @@ MODULE_DEVICE_TABLE(platform, rtsx_pci_sdmmc_ids); static struct platform_driver rtsx_pci_sdmmc_driver = { .probe = rtsx_pci_sdmmc_drv_probe, - .remove = rtsx_pci_sdmmc_drv_remove, + .remove_new = rtsx_pci_sdmmc_drv_remove, .id_table = rtsx_pci_sdmmc_ids, .driver = { .name = DRV_NAME_RTSX_PCI_SDMMC, From patchwork Thu Jul 27 07:00:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707400 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1445FEB64DD for ; Thu, 27 Jul 2023 07:04:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232591AbjG0HEN (ORCPT ); Thu, 27 Jul 2023 03:04:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232680AbjG0HD1 (ORCPT ); Thu, 27 Jul 2023 03:03:27 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2091.outbound.protection.outlook.com [40.107.215.91]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CA0D30CD; Thu, 27 Jul 2023 00:02:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NU9w8CswZOLv+NIayUbWeV+ITuVFJFuptpIi9EXQG4Iz1YjRXnGAf2alf80M3HudD9WciIK7IRmDtmjbY/PykgPq8JgF+eI9ne49Z7XgwcgF4D/Nd1COtyqpe5ehEdNXkeSCK2MQg+0cUY61pa8nIHTufXCt9ZgAsVK/MKm8mfUq7F3G9tszki/sP8+DMhwA3uJGfY0ZGH2qxuh2tPX6ircJvjwhaPaLIPpxbs0vx1ANrlWHrQrB3+06ZMnM67cXCQOWnnxsyYpBQp141O7nCsEVPlzIzPh4HgLKVim+zpoZr+UZii2zUZrDlEISbCFA4FTb0QxvDKqTBNqv4jWn+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bTCEmJzZRC/a6SHh4C2nbpGEXcRFJ6SVNGbm/AwkaN0=; b=Kfu9VKKUKUJQwFbvihCHRIej4xPqQ13yTsu11eDCFC7YItQTW5hqWEMlh//rdXWPso64I5xZY7duw0uT6EaPmLhIWMI6ad6xDXIhwnr3z0U5BswnPRAd7DBgkSk2TbKxpGT9lz+toX0OxufGJQtRXZNS9uohdpJYqHm5s19wmgl9XRROeWLgvCaRiE9wYUzoZiPnYnwYJPJk/uSKDQdptIRymks96bFEc3tJqPsZXWN8ukuykZgjaqQr+4xsA5MhFIKWKGvjsH/J6X+CezJ4TY3zGNDtYc2XPW2C/J1l1Bp4puH1DLzaXXF+TzV6ALEyQ0RlABdIXq3zgD8Nel7blQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bTCEmJzZRC/a6SHh4C2nbpGEXcRFJ6SVNGbm/AwkaN0=; b=ReVjkWZjMTv4Z0U0aR8zmGIyvSVu8jHc2V3POb/fhEX5fSpvkzaeemiZjLFUoR8aQ9uewQTBAQCqGiKaPHk6xvIUffzn3C6yPL6XJ5Mf0GH8TK9zuI4q09Tzfm0ANphzzwnZn+H2ar0dIeFnVQ/XFY/Z3a/aa3LMT7GKCyW+n76MnXDFZqGCH14+KSB048KJUm90vGBX7+hgl5Xkse+S32s5i5a/Lrr109EDYXhEQEdy91h58xUcy2j+UjSowotIT1VMnRoex0mvoAVWC2ZeXokQbTeGXT/Je4wrtBSUXgGrTKI1mfXQYs3ahz8quoBMGz5rjgsp6QpId9MTdD98Cw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB4276.apcprd06.prod.outlook.com (2603:1096:820:78::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:01:33 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:01:33 +0000 From: Yangtao Li To: Ulf Hansson , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 19/62] mmc: meson-gx: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:08 +0800 Message-Id: <20230727070051.17778-19-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB4276:EE_ X-MS-Office365-Filtering-Correlation-Id: b45d1d8d-42b2-4a97-118a-08db8e6f4fa4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 85bdBFipXxlgLKe7q09VQn91rhXt1lWOFnHfKMqVc1RSWBz3v97ar4725j66zKIdoV+bs3oV+adS4g+rBHr3BI6Vto8vEBr3Z/29HpABVqxMAsQhl4GlprYQWPtpA9qbUHgG78u5y0cPpo0Bt+IPH1x4qG0lylXMspCJ15VGk0O6xF3+AiaJpqgvVAXR2YZE0kLvZ0Jlbj5PjFtswZwQqjzddIajcbzJlchbyhdUxcnh6QrXI+gAGeY4hmQ5NFfO/9IxUdO/91IDAQ0c+PWYoQ1C0aTp/Mu/hXpnUTHK8DDW0POv45mA05DdACy0f+IV41xLFBZA/B+c81BrK/qiKLp2gIma18kJvPL9UaqwJI2ze8bUOs9q3M089gzYHgUA//eCxb/JEO11EeiDWW2wZewd0qnpJ1bKDktg77khvyhk1o1dYKqtcf/A2m6VXEZuNzCDF0pvjGMeVeiXI4Hvolf+15DcASy/dZ+H2iXmq7MsJu4e6UiCO4S5OO/gl1r1gpH6FAzBhYYwLzZ2f75MrDeMn8+2D3CUS4r/7gF4me1QA4HpH7xgWn27HoFyOruDtxtRgZyDk8Ab2IjpDJboQxDf7xLGtnECsp3XqqHItAAWJ3udhzLhAziut+u8iMFZ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(136003)(366004)(376002)(396003)(346002)(451199021)(6512007)(6666004)(6486002)(52116002)(66946007)(66556008)(4326008)(316002)(54906003)(66476007)(110136005)(478600001)(38100700002)(83380400001)(38350700002)(26005)(186003)(6506007)(1076003)(2616005)(36756003)(2906002)(7416002)(8936002)(8676002)(5660300002)(86362001)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?6zjPhJwM00eDrSntT649zGVDE8+e?= =?utf-8?q?hCQO+vDc2UTU/eTm0FR/JwWlJDW8xY3bGz+IbhuF6h1cVnOKRslHD+h3nTFSwe4/Z?= =?utf-8?q?fjW8L0AdU6jLU9+bxCF91ap4Py3RZLwry/Ty5GP4BIYD6T5jcV6HmUC12LvV+ieRw?= =?utf-8?q?0yvgOPWIA2ZWHU8R/kqJQUusiHskyO4QD1Ea4OYH7YTzzkRi1qvf/2FwnH0HWDSDH?= =?utf-8?q?QMITOULroFFgLE1ATULMjBqgHaTsojh3Q4+Tbkm8Whgg288MXkaMlohd/Vk11iR00?= =?utf-8?q?4CzJIcr3YpTOU48yznXR0QqZsijJxmA2CjnoKe50q1nXptn+yhsuQAKHFV/COWfwy?= =?utf-8?q?9HyFMezOQPNmkOhFLGVo9I2D8WuqXpPQsg8845R6CBTP9jYFd0spErrsT4U0yBLcB?= =?utf-8?q?uNVGw3fZDacIEfGwJrUsddu1RRFsYm723HAVWYzA4rXDrnaXivkUQth9zNnrboeL/?= =?utf-8?q?+/SzKifK4f96EyMLkn1AchIAaqXbptQWFw44VgHm16nJXs8PRY3fK+rh4rxkMcWWp?= =?utf-8?q?4a418ZHcIOJaMHEcfAmWiDEZuaSM3m1vx07x9RYD9aW9QwVbKgLaWFjCj/vOu7Oza?= =?utf-8?q?rhq1fL6tL+aqpVA8TNdm+Oe+B6SQr4n1N254dVPGWHgU5hzUzU9uTqjXn6c2v2bQt?= =?utf-8?q?1pP58OTHq8nqBHJRUas0NhDAnm28lpUeQFo7ZdAjmzfMlKXQQYTccDTqsXOjrnprV?= =?utf-8?q?2icepHrcWXBf8f74K96MkNgckzPQebsVAq00PP8tgqnkBkX5Ya6r8yjshaj77bmMk?= =?utf-8?q?99JxpL35AhC2HDfbrUItB7KsDKGJmiU7DircZe0NTbI+yMG5NDarChATbWUk6Ki1x?= =?utf-8?q?DgBs1ILllQzT8oTTVgzCNfE6eUICubTLDh6YsMnBVjY9DpdLReTMOAOYBl9H4y+ot?= =?utf-8?q?BcD8CciisCjLLk1tX7etcpsL0D/Y32jAaNGDFgI6LvemE1HKrGXYXZDG5yy9Yn7Ah?= =?utf-8?q?Al/vf672ySswvYoIKOY9/V0QmKWZHYJ+LlrvKdtQSHpOmoDcmDjcx2DSWJHv15e2H?= =?utf-8?q?HKil2V7Rcgmz6XkEV9KHVDlbIH66Y/JP7iy7hqNxTiAUUF2JOBTIjKYUm00ZHmBsa?= =?utf-8?q?GjbdPTYgILiofzVg+0YnPG2ONbVPixxq2fzNRlkhgwcho2H/SlBnd4YHE+tVMBFc9?= =?utf-8?q?PaHMtsTZdeUoeWrEGTbDXGXm75xmV55XAvHh0MVgtonj9DGt6JAmOmrd+t12cRDac?= =?utf-8?q?K5+lUm+LldIFKhB/DoEWzkL/xHJG0AT93q/zn40WQYWtPMLxStyaTNv39nxcS8xMI?= =?utf-8?q?3yve4ZmJ3TtvLSV2docJiwf+xUxfv1T7RW45WeHNzvuOlBQ48D/SG1cINeTMbk67y?= =?utf-8?q?w8yjLXM3fxfKm/hko+giyCTcm0hh3cv0ddq99eKfYp76hjVHkk6bwDPhy/I84P/ox?= =?utf-8?q?Y0W9d89i+NMtTWnlkDM+A1Q3Rc9h1CPVx1JeqyhhQKtHZaBIvP1KRTPEbyIILeohV?= =?utf-8?q?KmdW01wcEkROQESeNc3niyEvRcbk9xPhFFklc7WAgOnOaELQOQ/7heUzSlUy2tuJr?= =?utf-8?q?V+26IQz1rf3s?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: b45d1d8d-42b2-4a97-118a-08db8e6f4fa4 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:01:33.3174 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PrVm4GwDhCOIG/TevFu+MkR/Y4kSRrudbHSOqReu5P3Z8wicv/3fj9vWFgt5X3aggvdUcUNxOdQ24WTZyTkV6Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4276 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Acked-by: Martin Blumenstingl --- drivers/mmc/host/meson-gx-mmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index d652374f37b2..a2601d0ece71 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -1294,7 +1294,7 @@ static int meson_mmc_probe(struct platform_device *pdev) return ret; } -static int meson_mmc_remove(struct platform_device *pdev) +static void meson_mmc_remove(struct platform_device *pdev) { struct meson_host *host = dev_get_drvdata(&pdev->dev); @@ -1305,8 +1305,6 @@ static int meson_mmc_remove(struct platform_device *pdev) free_irq(host->irq, host); clk_disable_unprepare(host->mmc_clk); - - return 0; } static const struct meson_mmc_data meson_gx_data = { @@ -1337,7 +1335,7 @@ MODULE_DEVICE_TABLE(of, meson_mmc_of_match); static struct platform_driver meson_mmc_driver = { .probe = meson_mmc_probe, - .remove = meson_mmc_remove, + .remove_new = meson_mmc_remove, .driver = { .name = DRIVER_NAME, .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Thu Jul 27 07:00:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707399 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD8B6C0015E for ; Thu, 27 Jul 2023 07:04:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231849AbjG0HE3 (ORCPT ); Thu, 27 Jul 2023 03:04:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232956AbjG0HDv (ORCPT ); Thu, 27 Jul 2023 03:03:51 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2136.outbound.protection.outlook.com [40.107.255.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E18E30DF; Thu, 27 Jul 2023 00:02:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=El5GI/FID4kj13Lqs37Mvf8hdiXhowWrjHmbvK3ibwFnGHBsSETzZ3mRKqaYWknZwTnLRFkvMpCEko2ssU4+0qoyRIrh9f1FsjoBLfzyAjoxHjPTUMU2/j7Wp9geSCwZDcHfy4EHyvbnmKPDMZSXWIN8p/xpQR3BjnIBWESpY+kwr42csJNRkRtR8DB/XcdB9xV6M75XQkWWov1NXuRDPYUuuThOYvx0g4BSnslPGiiWBrwHuHZWKy/CClSlYdBB8sPbctZYDVgHTJhNlThIfH6PsVSs8MeLJNS6U4lBvx40uGZTIGxivkvgXxC0+GpyA69YjwATCiE0lF1Wu06Rvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NwbBGaxbfpdU7ahifnwy37RYBYAlU62pqhLf97cjF/M=; b=lzcELnG9he/7mNylmxp2wmDugoIjVtsrBZxVB7oERMnY0HBFI5zpPmZW7h4SkVhhicCBJDoVJb4X4rl38nD4kXForciv0MaShS6qf3wDRJQkIdxdINiNScHUHfRc1dCLiPbcMFbE2MvNgxBfRQYTBZvEv0i0Kewe3bXxbWue+SQ8vuwblr66SHHGLPcL/0T7quG8ufqAn6mExh5H4+7o9bAPG38unzY+uB4EP9AOxGS6iixJluPMXkMlKn2N8ouJOHjnWAI5jberrWy6gTMMeyyogO0u1nFuidiiXfXTGJD0eiEHD9eggEjJOpxVYc67AKn+xu8BEkYiVQTidOyucA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NwbBGaxbfpdU7ahifnwy37RYBYAlU62pqhLf97cjF/M=; b=YnWL/TYB2On/rht9+tfrIsLdY/HiRqlOz8MbhgsWu5HQh89MfDLu+Gan8OYTstTOF8G2Ja4AZCO+jCqkn+HYqrTLb2seTsB2gKmTiBqH2mJYJKw4IUeBt5lqDPGK/FUPl9yyWVLE19lPEK1mr3ew/gA4imEXoyKDGWv3fNekHLemzrqi+fxCpubdHsdoIC2Z7hl2rldpxoIk4ZetCHg/b67h81eUcGJIEtnRRCClqqPyMC05HUp18yKR1JEbBJOXtwWx1nwZw0gE9vnXDx7JBmf53TPISsGvxUfa+iVWlVY5GrhHacHeWIQ8jLD0WGpnesMrpcX8ZjlWnRhBI56O2Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB4276.apcprd06.prod.outlook.com (2603:1096:820:78::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:01:36 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:01:36 +0000 From: Yangtao Li To: Adrian Hunter , Ben Dooks , Jaehoon Chung , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Andi Shyti , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 21/62] mmc: sdhci-s3c: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:10 +0800 Message-Id: <20230727070051.17778-21-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB4276:EE_ X-MS-Office365-Filtering-Correlation-Id: 8a5957d9-1f5e-429f-7df9-08db8e6f51b0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ya2dLncvJs0eWmm2AK7SbhpT93Vk23AZuvnI+BwuSloLOqxsGZpEbWiPYYcJDCRujU6gWCZvVsBq5A25sCP1ua+OWcvfUlLlOpLnmqUbDgMK/ZlXD7tJtpK2+VAHv9ENYLhRZ5ALdFpTwbl0uhCQK5HcIhVurMymrgPvFejyZdWtHMYbm7OfLfnwJeuH+OfU0hfghEcNAz9aEI7zPzoOxNtWIcQX9CTyl4BvT2s/TzzuxM2UiFwr250bxhB4jE668356m3HYKqvNgVb7+aOdxcTBoJIdVkt4uoc8D33WfkYm+TP+Jv/vnqBZLycXlbwSr4ibdZ9mtbdsuWCHJdiibhCu1hdOzTMtbLnzZDXltysvDQMjrF7NDiqwednK0F28560bU6d0E0tN6Ck16IRDCqfNwGa8jmNhNT7lnGBNHrL+ts/br7WQk+69YbdQXwq5stGbqRD/XFyYz/Si0NpI/4+cU0o0GWcx1bPbPahIGECKP0s/+Xz1OsDpv9R3fW6GePYlKSKg0bXXbWsrpwBMqknHTbEPuhKwU69Qi7RhFYikb5dfM6117WjlT8F0YjKcwccb781ErlGzg8FbkSXZeHAfQQRrTihRgqZeMKJ+9AlPG5KZuHObRg7GUlZl4/W4 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(136003)(366004)(376002)(396003)(346002)(451199021)(6512007)(6666004)(6486002)(52116002)(66946007)(66556008)(4326008)(316002)(54906003)(66476007)(110136005)(478600001)(38100700002)(83380400001)(38350700002)(26005)(186003)(6506007)(1076003)(2616005)(36756003)(2906002)(8936002)(8676002)(5660300002)(86362001)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?lJGojUduazbE8mxlk6ZMcfCW+l0F?= =?utf-8?q?/hbxHRLzEje4tQK9Sg1h3pnAbwsiVGYxe50xCd9ro3kJT/2EfapCW4RGn8KFfvs3O?= =?utf-8?q?jQ5DV5jWM1Cwev8C31TyHkNKW98vOu4LXV4HESkRPweUmhrL5bXXCjDd1/cAmIGzQ?= =?utf-8?q?2QIoMeXh3BkiaR5R+0qM4n5MoT3TVZPKVxPJIcobhE9hmsQ+gfmOupMrI59itNVfx?= =?utf-8?q?TW9r8+woRk5LKqLleoFD89PIlPwvfA+83mRoKYZgKyniTb0tixh76YXCz+BLlIRyK?= =?utf-8?q?4qLrEdGWrrN0/x7mdZUiiojTXBTA0GD2tPvTXcKkhLIDuCOW7GErGE8uA7+QOI0fq?= =?utf-8?q?JOFl+qdVJ2xHh1k8A+un67Il+A85Jq1N4aDbKU2Z0MPKgeOl9AwnvidW1WGCPMZzc?= =?utf-8?q?28JlQp4xhYTsTxNIaCcJ2EaMaN70vIP97FPnF84Ziqq4Onk0b4/8YixmDdaRo+2c+?= =?utf-8?q?F5XcK+6Qmrv90uq6IAGWrT2kKKVDz/Uy8dO3az4VnIqmOGQuruHHlN8sJwXp27q9N?= =?utf-8?q?v/Koi1Mm06zhsywpwzUAf3QJdVVPhM3yMWCw1Z5U/TDF21KBEq5WC2IuYtbbUPcO7?= =?utf-8?q?1KpcYOaOJBMffCW4VpQa6p0FwouugPC0q+vq1i+QJt7T+WHDMIBrFmFIg0KrMf/sR?= =?utf-8?q?MRhlrTrnF7dK6MUxVhCqsnkY2HcU6qFJeUGVSxOqqYSJAGxbiV4XpByT1SXPUvN7J?= =?utf-8?q?H30zxGeTKpmFjI+oY64V0vzaqbJzjzmGhmR9xTffmJVLqq09j0KnKI5UmWeWzqAiM?= =?utf-8?q?ooYBWGegCJyzYaVsngfe0RrYglUd6m7rz8tpTJhR2eURaHgAuc2cQBI1gb+zqW7R9?= =?utf-8?q?iBN1yiZC5mUQOtYdrvcjxK4d7QAMC369ctQHl+kYEylxBHeaKpvydEZom1dhCJYsH?= =?utf-8?q?QonFpOWN0+RgmhlldYTSa4BXmc4hWjBdtAy7wpLxT74sho2ynOKWN6diW9Tq7I62k?= =?utf-8?q?ZwrG+2uPBHp4ihoqdWfusKLFlprX2EyOrHqp+nA+k7kl+St07EFh0O7rnnOcRFGyh?= =?utf-8?q?JK95I5Dr/zw4xMDQKynBRNia8tEw8CJ77pG1BGnvwanRBIMRjGMRhIoeEPdVBCHGO?= =?utf-8?q?G6lXWBTkeYhxv3//nfmwiJpGDcznARPPvxa5EY+UEiNJ0twpFKNxDFG1B8ulHFqVy?= =?utf-8?q?Y2JPbqXMW5YMT0XRauzUkkzPzHGlkU7wfLjzgiwEefv/0w4gY45cdiSMvWdT0knTq?= =?utf-8?q?tTmJjDWPeb5oLgVN9Rb/ePcLxb8/8hVuJ8KPSyweoPhaNRDIBtL5PK/bRYTiGurew?= =?utf-8?q?3iixqSAp4a2z80wH/JiB6BEEniRL3rI1jvaHDsxs69sEBHhHyMSSeX5UduZynV2d0?= =?utf-8?q?maq6UUyaZvC8RahoozBay9ejNAxdguc4Zn9chLQIUz4LYCH0BJV1doFK0dDqY/Q4o?= =?utf-8?q?U+UvmRymm3IgYny/7UAmJVi4B7Of8lY4Tyzuz/2ZDMcObtro/mjASK5r8WmI2erEF?= =?utf-8?q?OrGZ8NL8K7PSY4GnvBodN3XTGYdJPW5ckkj0hgTfcZUmleD/W6LQ5fsh65ALHfhIT?= =?utf-8?q?lv/RWnerWmIW?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a5957d9-1f5e-429f-7df9-08db8e6f51b0 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:01:36.7446 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tteKqgKH7X7tIiNEa4vTYfbcyU83SIu+5k4JYYh4/KlWYxkB2z/kIwcCphXd57a7PZK5N0rMai/sLmMUBgvjBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4276 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Acked-by: Adrian Hunter Reviewed-by: Andi Shyti --- drivers/mmc/host/sdhci-s3c.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index 504015e84308..b61f12d328e0 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c @@ -668,7 +668,7 @@ static int sdhci_s3c_probe(struct platform_device *pdev) return ret; } -static int sdhci_s3c_remove(struct platform_device *pdev) +static void sdhci_s3c_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct sdhci_s3c *sc = sdhci_priv(host); @@ -688,8 +688,6 @@ static int sdhci_s3c_remove(struct platform_device *pdev) clk_disable_unprepare(sc->clk_io); sdhci_free_host(host); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -776,7 +774,7 @@ MODULE_DEVICE_TABLE(of, sdhci_s3c_dt_match); static struct platform_driver sdhci_s3c_driver = { .probe = sdhci_s3c_probe, - .remove = sdhci_s3c_remove, + .remove_new = sdhci_s3c_remove, .id_table = sdhci_s3c_driver_ids, .driver = { .name = "s3c-sdhci", From patchwork Thu Jul 27 07:00:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707396 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB32EC41513 for ; Thu, 27 Jul 2023 07:05:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232491AbjG0HF3 (ORCPT ); Thu, 27 Jul 2023 03:05:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232909AbjG0HEi (ORCPT ); Thu, 27 Jul 2023 03:04:38 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2136.outbound.protection.outlook.com [40.107.255.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE2FD3A85; Thu, 27 Jul 2023 00:03:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gHBSGuWwsvKHN+7rJoOrILYLu5wcaxzXM40jxJpzCtWdS1wFgS0ODfwfehPrGipSCRKnXnoxxCJASyn0As2MWXNzYFBsNGB4YJV8LyqME0m/BMsfnBtJmjwR7lKuFwljM1CpF6n/4jGddkbila2x09qZNmGmiQCdZyiS23HX2JYqkHlyZNhEZhpVdyrZwc/tQ32q7u/KZOndbFP8jlkPw5vKmrH/gtM0FeIpMcA6HA8qpZdreQS8Y8wsas/OIOq566FONVQ3mvRDnyGdxhxCKGA6ebwBi6s1XT9Gevg+3c8pJlx5Fc9hFMR2L1/c2lvD7x5BJ7RDeTPt7mAq8jjvbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0VnGOYi45hwpGU2pMDgLIc+XDvJEY43fviyLsFSsxj0=; b=Ik+DbOF05FHOv/qke+mj24r1ssqdQ8CmsFEBPhObqhDSjZghwBan8qOiSA4WrHCk7C/rzmKya8RL8z3yKOegrjxzfl+l6NKZYRsxDt6RtfW21yHwi8myMSqgce73IoSL64kfpPK5MVzhne8YBYuXHeXgqGYvSQjcMBZMTFpH3/f0KX6NRnDBMz52ipOoYDq88xsjQP9SIqyhhxbeHxSOsZ6CM3sUzvXY7xsaixdaxaA78vMsh/kp30QBqwoa+8HfO2YJNAasDQp0qaHB28tH2rI7U6HOHCn2JeTI1ssWruiSi9zLtlQ/MvBXnd97WKmD4SWOcyuO0F6N9IcyFQ8vMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0VnGOYi45hwpGU2pMDgLIc+XDvJEY43fviyLsFSsxj0=; b=UQ8EgVz7Wx+8m5qzwTJ43XDYw31X8/SklE95zD+eZJ1ICCxluoCUVhlSAHHNUZfRdY217TRKxAYfFbMsF0AloZQEb/dNubIWek0WSmoq3tdwwN4M8G/+nyg5biIi5WcGNE4+uVzlmfvdr8rxb9k9JNw5YuRKulHmHiRXhQQG2EAUlqhO7CgLW0apcWdoNKCYjq4zyeeuVIgdYFbHHjpJwSn4RXrp9pIsugkySFXlM/+LPP3gcc6Br0WKh2tp0D1LRLxBks2cl45JaLmjwr+XsTAAJEmYrOrMj4nteRk95ukc6Z9XWu0w8vDRg31+KBJlnrWuFjvMA56DY2XvyUQtxA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB4276.apcprd06.prod.outlook.com (2603:1096:820:78::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:01:42 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:01:42 +0000 From: Yangtao Li To: Ulf Hansson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 24/62] mmc: mxs-mmc: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:13 +0800 Message-Id: <20230727070051.17778-24-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB4276:EE_ X-MS-Office365-Filtering-Correlation-Id: ddc2938e-9556-4c51-df1f-08db8e6f5505 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 45K9sinYp2fD/GfRcK/Gy3TNPXxwuBsTtWu+p970jYiqP+xQHQrg0juL5LQFsSMzyuAG82CsQyrs3LfArXhlkAlTRxEV40raC+jzgo9faPVMmLfVUa/mnTaVQP3pfFi3ThPw/3Es8bzwAInR+QgBs7fBDORnDVgsdhl0hP1nQaY8cedIobzDiMHbCagEusoihlOAmmyqMrj40VLYhikvjlZab20zkKUZax/ESP+95SzeRy6UhvzsXI2XLHPW3uRkz6amj+weScwLsTll2nyTWvg8DOiiwOgDajn6Xpn7jbwa1eJJxng+n/yLHAsNnZk3wG3lM34bHLHd1lKVPd2gQcr4iphwRFhUakd1rO7+GOc9R3hKmMdl0MlWo3EjpYCX+yhy0xyKgAeCmt3P2AYLp7EayKn6MSsQ941sEaHp4HZuPfsk+QtLU4fnUYpIf4N6J0u0qQj+MhfpooUVAhM1b4atTH/LOM+E9chVEtfy8Q6qlcGTKrGGuM5NAKgHP43F6b8GQK11Fsn4VK5XRJOmuAXLeJgbOyUKbVNq36KnrONdDLROy7eTPrKIfNVO23HukQ7KDt9MG22UABxXWTEgJ+v2IjozIQBgrIOjZPRO46k+00rso5I5nFSWwyjj6RNV X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(136003)(366004)(376002)(396003)(346002)(451199021)(6512007)(6666004)(6486002)(52116002)(66946007)(66556008)(4326008)(316002)(54906003)(66476007)(110136005)(478600001)(38100700002)(83380400001)(38350700002)(26005)(66574015)(186003)(6506007)(1076003)(2616005)(36756003)(2906002)(7416002)(8936002)(8676002)(5660300002)(86362001)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?ZUQzpHTAzQS2B++nPM8r9WoLvFky?= =?utf-8?q?+5lx4269TeMfn2hjZPIuXv+xbh1uTVtkpJ5wh9EnCnA17vTJI6a+Vjh+D5r2GoG0b?= =?utf-8?q?aFT/EAYgcF/KWrI3ZVHCWrYlNEkUSIKS7G0xxH6Ve/LodtB+cFsZjFeYG2cU3KfMb?= =?utf-8?q?UcQKIypL9TKmfKKWyZ5g3fBnXHdNt9D8lyc9cMUMzy+LlWeCtYwyUgHkwYdUL+oHP?= =?utf-8?q?MLLq4V9LomNUCblgStS7FjygIz7JjwIxbDRujqWBe75U2Zbpqma20LvLNprMihrAQ?= =?utf-8?q?bAHF2qWZy74UQFLCw68IFIFFTAdAIo1KAZdzwmYC/QndxFlPv4AeBYOKnDOX+ueCO?= =?utf-8?q?f5p7PdNzY7DFFgHDSvUXPs0SwvA2uUNHPZIXy/+Y5XlLcOBeaHHMIMbGwZqjzUGJ+?= =?utf-8?q?87nL7aWEMVtkD3asW6OiVWUgEShDMcmYoKghrEGfBy3B+dJZCH3Q/mbHsl4AxZ0AT?= =?utf-8?q?4AY8lkgH1H/fgHUQxPeoXjg7aUmk2q2Skoqfjph7NDoYTsuw/RMckTGEzCOdZalh5?= =?utf-8?q?1VWSmTQ4PFazyepqry0gQaqtyHh5Wl9Pdn7DbZxVKOiUMV+goqcEHtmGUt+kmWkvp?= =?utf-8?q?dvE6d7IJAd1BNHs1bZk48kzKOm3TmgEuVWGAeH7pbpFHNJosofa6sKqHkCUsirZlP?= =?utf-8?q?XoJEBAbtZDhwBRWJTtFLGvH9wQG2HlrGrOTWVGJczSxh6NNHoW0XIvNRpltdb46sq?= =?utf-8?q?7PJ3G0YwYSPbuOMs/l4QZPVtxj0NuROU7sEaVMNPZTmwaIwGgFZNr/3fKpWhhRWbC?= =?utf-8?q?nkuFKBUuOgsr4hbl9uwZx6nkH89d/0PKh1B6wWCqiG13DLLRMK67HsQ56+R+S7xCV?= =?utf-8?q?SupBZPDZg4Me9HXGsCZ+HOs2Ckz2/VT3j/VAY7ZPfSmnY4oB3kmW3kyOFPvlE3WkQ?= =?utf-8?q?FTYlNpXR1rGCbdhrcuJ0zCvdL1/TBXrqUGSRThv6FuHIhWsJ4nxnziZCv14l+qSqV?= =?utf-8?q?xKwSgVi0B/FK7RuoYkThnOGHM/DGExkegJxzGlZtV7etW5swVdsmheFivZE9wftxv?= =?utf-8?q?avMadDhzENAMfiZJSpdYrDbNJl8LmKn+nNLHxXElOsgFjuJPJABU9BrkG5HMBld66?= =?utf-8?q?TjFjr+BUm4syn2wdCasqAlrXg8e/WcecygR39N3w2PGJCzu7Uw5m/QMeUdKQblDUM?= =?utf-8?q?OrKPXZDp67Q8AnJR1cYJ2Yn55EZS+vB5GGHyUo+z3ecFGTUn5ywlib+b2SgTJyfqd?= =?utf-8?q?U1niAQ3Olnty2qYgUukGvp207no6FQD1pt3FAy7w1GsuJQaPPEHnlcameb3TN6fi5?= =?utf-8?q?zHSEaUcihmSPMqchQo4Cd/nOIeoMQbtn5AoXyOBLsU4rHIzYvucwjxzs2GKlJZt9W?= =?utf-8?q?Rf9CbgSBUf1k+hylWMbVJNXn6T5guI4SS9GlNYu1sVoRT8aEB2f4FlmX2wpzkBi84?= =?utf-8?q?nMICStd35rJNui/kBv2KDag/SuJstukgTn/Q8KcWiV2ufy+/CaAmYeBfwRFxsXBs3?= =?utf-8?q?sFKb0LsYmayVs4mOSvqoOuboexC08iXUTMCno+MqblYHiqWIVyM9IGEPxq9e2fUIg?= =?utf-8?q?/lmRc4FRbSnY?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: ddc2938e-9556-4c51-df1f-08db8e6f5505 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:01:42.3343 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Nk3IKa3ftWMV6/+2ZEuIOGE8VkgkW1IbZrLMSHkhsTJ75SUeGUJcuybJoSZNlPN3uaeS8IOy6IPGksr6Re9vJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4276 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/mxs-mmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c index 8c3655d3be96..9abfb169464b 100644 --- a/drivers/mmc/host/mxs-mmc.c +++ b/drivers/mmc/host/mxs-mmc.c @@ -674,7 +674,7 @@ static int mxs_mmc_probe(struct platform_device *pdev) return ret; } -static int mxs_mmc_remove(struct platform_device *pdev) +static void mxs_mmc_remove(struct platform_device *pdev) { struct mmc_host *mmc = platform_get_drvdata(pdev); struct mxs_mmc_host *host = mmc_priv(mmc); @@ -688,8 +688,6 @@ static int mxs_mmc_remove(struct platform_device *pdev) clk_disable_unprepare(ssp->clk); mmc_free_host(mmc); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -717,7 +715,7 @@ static SIMPLE_DEV_PM_OPS(mxs_mmc_pm_ops, mxs_mmc_suspend, mxs_mmc_resume); static struct platform_driver mxs_mmc_driver = { .probe = mxs_mmc_probe, - .remove = mxs_mmc_remove, + .remove_new = mxs_mmc_remove, .driver = { .name = DRIVER_NAME, .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Thu Jul 27 07:00:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707402 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 977C6C001E0 for ; Thu, 27 Jul 2023 07:03:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231630AbjG0HDY (ORCPT ); Thu, 27 Jul 2023 03:03:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232133AbjG0HCv (ORCPT ); Thu, 27 Jul 2023 03:02:51 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2104.outbound.protection.outlook.com [40.107.117.104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82CA426AE; Thu, 27 Jul 2023 00:01:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Maf8scFMRz58zsHamLKIVJ1UHN7aAfec4z7+lCdxfNAoYK5ceYF4c6W3//mP+eR6INrPK8WxnOpreC0eZXoSDFdLVJ8cE74cxiN+SBSJ+heIAGhplFezBlM07gHwFDYMOU14x6hbgE5il1590KzDUAf5ywo1KeDndOo392xTCPCk2ZKN9x34QLNuihaQ3B/Iu8V3ilz5znP99ThnXGPcnbJqZhWTOLcygmNX5Lhw304AH4XiV7TT8kK7gVvx+vYBIdlNrz9xajTNw+rn0Yvw1bVQltHkhl0lx6p0w+p/z91f23GDeIJf1ryuFeXcurz2CWiYtY5fBISeNmuxR1dv4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YnEm4eeaXUww5eDuPQKSh3EIaMee7cr4msQcxUd2bqk=; b=mCBl3vwlixRtymJsJAGNcylwF66NTobmJEtffE4OQWnHBLr1tHmgf2aY1WkaTn9BhO+46AZfYEb2PDA1kw160N/azZtCoq3l5CRm+d47olVvtvbRAfMGYNGIsmDJkRufBwdIiWIvXclkO3F7IGzxzqARo1WylINNM/PcHrazoZvoT5BvihSs5Zw0hka6kxa1GNg8o60y3Me6ZsbZE/MY7WGdw7HxYG/+5aN61LTnt75z5lwG4YBigArNCnfK0RSjD7IoC8ALxNFTscRFMVTeWqbMorPBVNcCqL7Xdj0TqRHPj774VtFaklog/hAqNIXnWJpvOkz6mvRRkezb4aEvyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YnEm4eeaXUww5eDuPQKSh3EIaMee7cr4msQcxUd2bqk=; b=WD5kf8K13FJaMws5FU7HZ5YfNmRj658WPEtPVif/AyB74R8nk3+l5Rce92yhiepQ98fNib2lmwgKZIz1YOcuGCvTR6T/tlMrSXtkw2Q5K7sNaJ6BVRr1pZGuCDPzPoQzOxQ51VayIKGGmyvsDW1e761wgKEAP1Qs07HR5wGdmdgVPcu8NqH+L6fdc3VC+0vsG0ZzkSDoRrQCYbFg/0SL56jkr4wbEsksoVVvIP4BJQHuscSvApv3mpbmTg3ZCG0iDq3mYygXEDWamA4Dwi8v8VFiDwi8dtX9R+18cXks5RIUv1ctU36o2e0dFziQInc+WIXQx13tqqJhBXvLd6ANTg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYUPR06MB6027.apcprd06.prod.outlook.com (2603:1096:400:351::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:01:47 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:01:47 +0000 From: Yangtao Li To: Manuel Lauss , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 27/62] mmc: au1xmmc: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:16 +0800 Message-Id: <20230727070051.17778-27-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYUPR06MB6027:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e47b5ab-dcd2-46ca-2537-08db8e6f57d8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 23zHms9rPzA/krfBl5bpxKzIMgYbE6zRgrxK/WASAddevcYdp087pvdQo6B8EncpA1WmTU1DSE+sRfnOElAxiJ0bBOZtyW8/3SL7EN1TGqLKUCJP+iyMfeGjYBWAlX2MC7OhO+e/VdeFSwlILOZbV87fvXyPlqpZOxJ5j1nt5zBu2k45HHrUNh15yYxd1ZGcygJQjl2iXNJu6wX8GLK+ldQj60eCaC1J2nt6fyC8/14VpAus54EThZxtOByrrIniGTYaVFDlFpcFTqm9mbLBc/jUjTqaROI0m2HktaD+oz8qs4kosmLUatDfW6Te+qYEsYbJ2Fj+gdcrXl1HsOLLZ57OVbz3GNZgTMbHXBp1tDg43wCsJ6I4GubSm8jwKlWfc85HkXBPjaLdf82BQ/4GHCSGX3WPBwE1XbzuVdgQLiaSCT3UPX7U4pxMj8lHWCctzjhLuMf1VTS0hQU/iaIk5jdgyT1lH4oCbPn51Dl/KP0vLJlqLxrikqty+/o0QURMvtYmGviIrjvydSnhokYwV+qgBtomG4/8eIfgi32weGD3NiWDX9FF17bDV3EOAieWRuoGGMU5v7Jq195qXZZ9n/qheg0RQ+ffJzJiJ/AwuWWpLJ74usZifWnt7FgSmLf3g87hKynhtLu2x4RnXgRvCQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(366004)(136003)(346002)(39860400002)(396003)(451199021)(2906002)(1076003)(6506007)(26005)(186003)(86362001)(316002)(38350700002)(38100700002)(66574015)(2616005)(83380400001)(5660300002)(66946007)(41300700001)(66556008)(66476007)(8676002)(36756003)(8936002)(52116002)(110136005)(6512007)(6666004)(4326008)(6486002)(478600001)(54906003)(32563001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?MXCgiP8zuicrmU4VCBWxken18kcE?= =?utf-8?q?43/rqdRw41gYe7KDDvvG2R+x3MEyirD/f+oGDWnQxkU40oRl/s01JvFxQEw1Gb/R1?= =?utf-8?q?nAgI6gWGDDdQbnaKujgT3hA78tmBwR0+BeW5TYnXQ3NEiYzR+WldA3kmbn0o4Fltv?= =?utf-8?q?1f/SRAo503rL2086b9d3tscxFnVrIUHncYutag243HYixYCg00UMgCdD06gVfRK9f?= =?utf-8?q?hiRxR8awcJy3SiPi6mwqAly9+ywrXx2wV7Df8krPJ310GDeGECyX3LOLT33E1DmfK?= =?utf-8?q?NIxVn7HpnbOmrW3CHtI/9END0anY4O7yw3QDJk68jrxDPfTUJUB7LHHiJxcZVDB7Z?= =?utf-8?q?CJvFOc66RwGQ36SheUQ9hysu0v3NGV9PW/Ri6n3ozjEUyy+IPmM5myDLFbTg2Joh6?= =?utf-8?q?7Y6RE6E+b2czCQJT+1CFqAQ9kW9Gv06K0m6/6RFHqt8eoYZSDBKy1DfMwH+psRP9q?= =?utf-8?q?ZDpWIR7rARg6z8HS8vXlfld3Ce6IyqWeY7u3kMZ2GHuDUpB/RTJTPmGlCrXmgse5B?= =?utf-8?q?J4W/8wp8q0f7iW7s0uqPdgSEBBCSMEsXPFNFfZ3+jIaBHkP9xQ49jx2KhBiz4cSN9?= =?utf-8?q?wBmoODWzwD29h+6SiA//Mk98Fnox7AguQraznwp/ppYnYpJEjxmgMkWjwxehFpFid?= =?utf-8?q?N0kHU2N2opmEmbiki4bholfICEtKOmCkIS73L44L6t3HuVaTiM8rJjHi5/2jfNpui?= =?utf-8?q?0thXZipHw1crroqy1Jnwcr88eKq/e8Lgikd8FlTmOYtweLXrZUz5YyRi45meXcIbn?= =?utf-8?q?K0NHhDGEsrtZ+RAfqTFtt3OHOV0JIe1Yag2+AZtCKVR+wcR23UJ00+2nhoSt7CpgB?= =?utf-8?q?P05PA1YWEcceNjkn4Khh1PvLQfX3J8NKQWzDQ5ZYGXUZVjKR5e+7+mbOJZgSpTU5g?= =?utf-8?q?i0B07I2zTBq/pDQ+7uyrUlq+ym/52KY2SK1DhlVN2hDs7Xc4zU8v1jWAU/1rKOYBf?= =?utf-8?q?pwbTZVhySyKOxqX72tHKCVUiIvkad66f10gWcIQSO33Uu2nFvijLPNbrBiAADmsKw?= =?utf-8?q?kzAevoQVzkmBtbtgeqIRMtzkgCB5tCJST694yHv6/WN6xstRG1qNtZwWBEfJLbYNf?= =?utf-8?q?Tqx8VWW0qav3ehFK/PKS8/S17LpNJArzyHlDxDxbCRq7Bae3baEnAiahAJp/Aw3l0?= =?utf-8?q?f7RLnnEOBpk58iAVPCR5qu7LyvjvLBuuz0x2x7sPy7Ql5tKlnZwjipkQumq1RhfXI?= =?utf-8?q?8SDemwBs7dNh6Qs7XVW8TBWLPSsLClOeRPHNTY1Nx2DYMQDVDJKOxKXmy4BQ/0vVT?= =?utf-8?q?fYoPDIf3kioj5w/gkh3kg/eMx175zKwPhRdxLX29pVE3/J/I8K08HAWPUG0lrz4gv?= =?utf-8?q?+9qrwlG68Ossz+uA5setjy7DI+ApfjF9Y/bQZ3/J+QmTllEBZHglEIcTKTwbr7Ke7?= =?utf-8?q?4YqWsYRw89jTcJmZ+sWkMbBTowE8Hw/FqQLX5VMgdMLFlnzwGtd6PgFS0xwyqDF0k?= =?utf-8?q?Gt0EfPXscAF1dJ+bzZdqosJrTlCc9Cbt/ntORxvo/20ObxYDpoCf2lRp5Gb+kuGPI?= =?utf-8?q?2wbmEEApYo1A?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e47b5ab-dcd2-46ca-2537-08db8e6f57d8 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:01:47.0576 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e3zkVkISmWyteOi2ZjdkfAqAL7oVwhEpHmFVv8GlBs9UEcKPCeeCEUwbDiAA1PH44JuinlS5VhsOi4LEw0C/zQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6027 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/au1xmmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/au1xmmc.c b/drivers/mmc/host/au1xmmc.c index 82dd0ae40305..b5a5c6a2fe8b 100644 --- a/drivers/mmc/host/au1xmmc.c +++ b/drivers/mmc/host/au1xmmc.c @@ -1114,7 +1114,7 @@ static int au1xmmc_probe(struct platform_device *pdev) return ret; } -static int au1xmmc_remove(struct platform_device *pdev) +static void au1xmmc_remove(struct platform_device *pdev) { struct au1xmmc_host *host = platform_get_drvdata(pdev); @@ -1153,7 +1153,6 @@ static int au1xmmc_remove(struct platform_device *pdev) mmc_free_host(host->mmc); } - return 0; } #ifdef CONFIG_PM @@ -1185,7 +1184,7 @@ static int au1xmmc_resume(struct platform_device *pdev) static struct platform_driver au1xmmc_driver = { .probe = au1xmmc_probe, - .remove = au1xmmc_remove, + .remove_new = au1xmmc_remove, .suspend = au1xmmc_suspend, .resume = au1xmmc_resume, .driver = { From patchwork Thu Jul 27 07:00:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707398 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2AFBEB64DD for ; Thu, 27 Jul 2023 07:04:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231359AbjG0HE5 (ORCPT ); Thu, 27 Jul 2023 03:04:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233023AbjG0HEL (ORCPT ); Thu, 27 Jul 2023 03:04:11 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on20700.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::700]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0263435A9; Thu, 27 Jul 2023 00:02:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VKaFGLFwzVmtpL6ek/Z1GEoNnP1dytgJ4yYWk38GmwoPlNlaD+Y3dBp/Xt/5ND+TA+3rAWlegGeBGISmIKpY/qjA/zVZuWeWb6jIKCQmSvqIZXz3qVdEj2924qQxqULT0dXelt2gCLIPeYR/vaOaa2gQkGMNJKDmYn1jyfNQ1+HarhkPjf+4dIf5qAvuv7YYvI/yqFypfTjPlt0tLOzskmVRYFpC5F0J7mmmlWIeqCdiJMXtBPb0wxTQQU3vU56U5XNRKiVy9++Lg2KFJA++yOAloVnZEYPYo+FQ/fbnPnwmoX2wfqbPMKbneFGc6Ki8ipP30AkERkIgH2nKEMHuJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5dtSozXRpKhBSknQ+s8s/18Y8o9VbBvC6Adg572ej9s=; b=Ze8s9YTJDVAcT9F8S3lKLvFlN4BD1uQDqmLvaJirXroB5ZToviLE3pCnVSucdnRFjWBxkMZoloe8sReBxngleLbJAfn5GKmObzk6IzT2QlMUZRdtkqi2x/hMLI8/t3FQXDEvOTaTCYhtsSE8kV9arcK0u81+xMEFrkFbgFPAFZEyIuHXgIyYnOZZ7jH3+J842FX3x0NM8HL65gQty8KoA8Fafl3JUEmHZS8gN/pLjv2x3HlEgKEY85ASzL6qS2CWK/RbfQOoh8cy8aWREi2c3DkOVDEyfzRAiMXG8xhCQkHKVMZ4PGLn2MmPCr2/uexqDh69h6GBk/rayJ0k6GTvmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5dtSozXRpKhBSknQ+s8s/18Y8o9VbBvC6Adg572ej9s=; b=o4ww/8idn4fZeNcS6w2D1nrVz3mZzQxkNKFxNZTd/5snV66QFD2LoXf4WvFPafCzpnkkHyZdXMl5ZZ2rPvdMkaw1ozdExYoSec/mmerwxRJdWt21bWykOtV64e2WhaD1QAFWPTMieqPcJ7H4TRCsz54KTO6WPGJbSfcSIPgXzQtn7Prh9kL5L/NDan2zWc8YUKltNeki7Ig4m4+JJ8DxHutBJ7MfKy8OTUsXeY8KTphWwI0E3oVmgiORvPvTunkuxJSSvxYWesqvIW4CYUDsb8MAqXd0c1F9Ea+oyWrK/KOe+HP4LpN+++yEmWZvG/Cy6UQHrt0kSJrui2rh6h/yIA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYUPR06MB6027.apcprd06.prod.outlook.com (2603:1096:400:351::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:01:50 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:01:49 +0000 From: Yangtao Li To: Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 29/62] mmc: pxamci: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:18 +0800 Message-Id: <20230727070051.17778-29-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYUPR06MB6027:EE_ X-MS-Office365-Filtering-Correlation-Id: 2172ce7f-8f20-4e83-3818-08db8e6f5985 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uR0C6So0XWwJZCrHKyer+wHkY86vKSNfCC4iGtu5gFDGqyvc+DdOHhphBJFivqsfjggE1x4pMaHj3+A+7/0b/fgNVzMqa0XiFZ+Isrbjew0Y0YM0bSLxOdYgknc00anXklGeYdOUDsEFuPBwFFSRSZPgJfBtZoRVlu+5vqf8uP+HDORluFPl2vg+VgcTdZ9lOB2NdGLzTqesTtToA2bqKXIMHKJvC6D+3FORhaSeydcN1AZTkMMl1wL89GiHR0dAoxVQ3jONNZyVejIuWUMV6bbps8C6bN1a7zvxapIJ5c7oAusi/G3V4yg5puBvnYxcArYojSbATX5bueQp4gcICPjwU2d8jldk54XIxfzdg3Sh3gC0oibp2mEsqQ6IZfaC4dcCSbBH4oPvqvEZwm8L7kkgiKQt9tKRESK7iIbQ7AWbfaWSvD2wos/QC2zW5kfzYpNLjP6yHP+Q1xirEKqSVU19LKxALmSIqyaQwvc6kxoLn7shpyCHBebg2jtz+05uSasZz5ZMHBudYPALcJv08PAZADT1o3xXklQM6Tiv5N/3BF1B2F7JZL+JxQQuHjoQIvF6M+2WgaOpums7SsNxXy/JMzMW82C7b096urpqYyapsppaOjTDAIt5Eqw7CLgY X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(366004)(136003)(346002)(39860400002)(396003)(451199021)(2906002)(1076003)(6506007)(26005)(186003)(86362001)(316002)(38350700002)(38100700002)(2616005)(83380400001)(5660300002)(66946007)(41300700001)(66556008)(66476007)(8676002)(36756003)(6916009)(8936002)(52116002)(6512007)(6666004)(4326008)(6486002)(478600001)(54906003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?xPmdsasOhFeCRmzQanteeWia/llx?= =?utf-8?q?zCe9c1mFEl38x64TpxGUdrpW4yCSXc4r38aDVuchPv0s0o1pB7AZmopTtaqvGm5gi?= =?utf-8?q?/7i2MPN9TXt9l487srk0NvZUryx5r/VHrDMwwC7qZblglJcSEdKRT/r2xbAMXsm2w?= =?utf-8?q?LqTogiT8PmfGos4B2QViMZ77Vh0l66d1htiP1OpJ9S9zgE/rGRl+elzisT9hpgbx3?= =?utf-8?q?R0W8Z9qgRJy1eSJN3bV+fOdIZF8tSZzWdEfXhHP/Vl1qEmpZ+0oANBTOUxNcoQJv0?= =?utf-8?q?6N3qBl2BGf2fX663L5UN0j2bpRvLZjovhM9z+5fwLxSi8gI4fwMD9WEEl9F9Mb0u9?= =?utf-8?q?NQpVtMMnaYBG2KvJMQgikh0nS4Y9b3FRwsfLrSEBv6Z9QC47exzrEoQpjSFkVRe8J?= =?utf-8?q?sZWxmSdd5qnqeTZ/s7MDLHkUQfqPyXmQgtL8F0Oyxe78PaqEPWJegTpAQ1/onuaSM?= =?utf-8?q?EuGkIJL52jzesQeOmD+vn9H7vq7MaCCxndsfRdSTQDUponKJ+jST++Svw8TDyLEkw?= =?utf-8?q?O6WnlN4NxiH6jej7DGjhbzb182xCtYl4c/Golqu+h7XmxO1FvptJkVCspfIG15fZU?= =?utf-8?q?cpJT3nuRmh6pTZwscB7ftMs6gID6h+Ox7h+R3KVNGZYUIuGBROspFDu+oK/A6YKek?= =?utf-8?q?LNOv5dJNpbdCoyzVg1sQqbqGQatQ2DnJEXvMmeysG4fMamWcMGuJy8NGHg6gIRF3G?= =?utf-8?q?Y8tSYgK7QUU0j+WgIgMPKlOPXi/dIO/jLOr4US5YhdsTjcr5YRUUoM2mCUtuEnEUV?= =?utf-8?q?RVUoQKhz7eg+VSx2e4PmMQHysONNv0ILy4wdUEuguh7qDA3ac+f46YEVlSW2l9LYQ?= =?utf-8?q?qhOjWOjLlviDYWreJRV8RDqZPPoaWML4uHmvIxAAVoXE579zYcBdA+VUAWba4DtEB?= =?utf-8?q?MQ9z3LY/c15cY9G885t4WVG7POVxfYUoNJti2a6/5axks+6mOAi9VqtnLV/Afwn0d?= =?utf-8?q?fELKmOELkN2ursOvZclZOd8vldhgzKZVyWSzQGuCSDBOFYnKPx2jJd+fbnyuKFxX7?= =?utf-8?q?aN6no39Gx/MHnN92mIHwW/iS6zqwl+ZL0PJAXTJfjmcI/9NbiwRHMC1wW5IPcjPy+?= =?utf-8?q?pYvZbPllw14rJB1lgSYv4CYOt/v0ML3aMUmgVmZEBYfDWcboGxay8ndW696sGv9HR?= =?utf-8?q?PHuF+GZeqRhWaFlGyV4Eu2DoKVdU8nTSlhI8U8OLfXhNbtXdnYY6z2mCKgvy6IJ9W?= =?utf-8?q?hpHFO+9Nttni+M+GeADI2z7VNsRDCFsHTvADoNPYnB4cQn8zjED5VM2Is7QF8u/Px?= =?utf-8?q?hWyVDnjD7nAdWrncm5OHE/q6OmHpxBb7YQaBtDAnbH3yqpdCnDG1j6HGH5CKzT9+T?= =?utf-8?q?9w2NCkl5Wv9qOdtHAF/sk60QrcK1zOOC0AiUtlP/1Pu0F9h4WdX9BrX9tR3hY2tYY?= =?utf-8?q?n3Y4WyxuzuLXGAftARi9Lr6QfNzx31BMprxgssWrl4owmDKpmWsrEJTF9kAwes0hi?= =?utf-8?q?ETv2pwnWg37OJ5RNXPpRpVGm9S6BNY+4Z7VUW1k76etOgNSCcTxdqY4TasD4qmyB5?= =?utf-8?q?wucwQvWj697G?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2172ce7f-8f20-4e83-3818-08db8e6f5985 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:01:49.8747 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qlkYbRHWb9hdqYaoU0HGrz7Rwxq7ug5pMiMAthsESv9E0NoKW4cBFiPUx9bkF6FInmqX+OYfgVnxGWl/TJCuVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6027 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/pxamci.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c index 1142cd2368f6..e44c8ff6b303 100644 --- a/drivers/mmc/host/pxamci.c +++ b/drivers/mmc/host/pxamci.c @@ -783,7 +783,7 @@ static int pxamci_probe(struct platform_device *pdev) return ret; } -static int pxamci_remove(struct platform_device *pdev) +static void pxamci_remove(struct platform_device *pdev) { struct mmc_host *mmc = platform_get_drvdata(pdev); @@ -807,13 +807,11 @@ static int pxamci_remove(struct platform_device *pdev) mmc_free_host(mmc); } - - return 0; } static struct platform_driver pxamci_driver = { .probe = pxamci_probe, - .remove = pxamci_remove, + .remove_new = pxamci_remove, .driver = { .name = DRIVER_NAME, .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Thu Jul 27 07:00:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707397 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82E94EB64DD for ; Thu, 27 Jul 2023 07:05:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232680AbjG0HFH (ORCPT ); Thu, 27 Jul 2023 03:05:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232938AbjG0HE0 (ORCPT ); Thu, 27 Jul 2023 03:04:26 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2104.outbound.protection.outlook.com [40.107.117.104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2990A4226; Thu, 27 Jul 2023 00:03:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OsDZ53fe1/Uvctacb+IdXGaC4bF0q8ox8SfJjyavJYo/aMPgg+rN0e/LZqsYn/axPlC3oJ2rILGhi6r4HOzM22cAC7+nycs9old97TQWBQW/DRj3n9PMe9LMQZwqlNqHj1/BaO04scFbiRdJIyp7ITO1y+NT/y5fhahE5pJOAuSavWbmHvaQb1SG7Mf8SCBJlaVcuHgSKQ0TFqIJdwcO0jHpxNgJElHUYULR87+QdIHOOBK2pKq3gVt2GuH8xa/XuhgLyPt0aXASNsjpRFwexcZJDzkM0aBzbxE49wvJA/C3JF09O2Akln2x40dvfvGvpQRcoYDmUOW/GANNU7sXoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZHeI4VADTP325Q2WM85PJChNJujdvQV/fU1uFiPIvKM=; b=du9zBbEpRGlS0KRA1mOZvDh5GNGc0dgRlKfQ3bGfycQ209oQl8BHoBB5GG/IU88ceVlJ1cXrMqyGRTfUO8SfFO1R/9kpU5tYPcywXMNLyQvQdPAzrEQR9U//uEAPgVX3nsD1gfprsKtaLsVqzqjQumA9HsLLau+QbaIsYjNWljakhD/BQwt54iVyO0dsC/BNMVNmgOkeSyY5YThduDq/jJoB8hID17Bf8ep732JX+tWAAlFwNYM3EV69EdpYWmlshfTv9IABj9m94vGxwLhsBuIKJ/GqA3RYbYJXq1elmLToVf49xNLBx7wYvIRkFVK2UDeeOZFkwlFfW28SbJ1R1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZHeI4VADTP325Q2WM85PJChNJujdvQV/fU1uFiPIvKM=; b=gTt7/XliYlPZBfoJHccG2VVfgTatatCrtpPXKm0UL9YRpbn8cOzjiEUWzJTHrgdMH5JavqzsvmeYYVxfA+xh9jL7KrqTALJu7l4KbOeaaYaFeFZJVNAh7qqctsqX5MIx2nGZpTo8CIdNHn9R0KBTJyxR1JT8w9n7fZe4e3OlU4/GC0QKS6JQqWs6d0Xd8YlzpQw+9Fh/XDCDljmmnT/La+Fb0gzU7EEAPCaYxY5ehOfcL9PNzUvG8b8Pc89a6DzFboddrfjra+Wi36uSldt+YYze9uDG8Mni/ww3bDF/zowF73WceAwStq4F04A2ewFUZgN0wygS/bAz9xjUId/jCg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYUPR06MB6027.apcprd06.prod.outlook.com (2603:1096:400:351::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:01:53 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:01:53 +0000 From: Yangtao Li To: Adrian Hunter , Vignesh Raghavendra , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 31/62] mmc: sdhci-omap: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:20 +0800 Message-Id: <20230727070051.17778-31-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYUPR06MB6027:EE_ X-MS-Office365-Filtering-Correlation-Id: ac22902d-f09f-4094-b92e-08db8e6f5b85 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s8hlRJCG66UWq1xuffSu8RcapNknrYaMW8cF1ybFzF1sRDTyleL8QkjMGQebCsk7HgKAD/ke/W2uhV2obWs3PlOvIEXt1JnUnoj+YwdLEwLIfHZG8NIUoNAdvxPPIe/j59BRaA/qhzBNzdReVQxUnULV6+ftJTpQxM2QU7sdkyfQC80UxlIO3kpKvQ1MHtQOMAtWeaHJgZtToqIqhGbzYsEl8tyRSZPv3HO5+7vDQwpZP9cWcYme+Fl+vXllaghYMJA/llFuj8A3wHX6kQvYN2xvWR29PWijoex8XCdBB4krbL+2DDotKOVJIMwCqL1KBUokNLcO/GuvEjgEJ/4/4gV4VY8TZrdueNfGjKTQ3Wf/4zxB9TW5/EWTBQaROW4Vuw92UK0pMuyzcQ5BKYuqzWbTCHgxLYpS5TP30s8dyDWrs0b0lKYBKnx63O2JlauUmS1QqFQgU2W5o3i2INj+QsoB2IO3RmWKjNRi9B5IDQy4+t4wMo3d35xQz5i7Dccg61lrvl0BQoeAWv5BQ/toqHCSNnAPKCdjNiv0Fw95gWxdPFUI75DAlj03sTO7uT+Qh9Dy/N28laepzH6Bj1g0H9F9QtFAWBrsTVpI7j+lH4JeABWHnrbNCr70xeMOTwH2 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(366004)(136003)(346002)(39860400002)(396003)(451199021)(2906002)(1076003)(6506007)(26005)(186003)(86362001)(316002)(38350700002)(38100700002)(66574015)(2616005)(83380400001)(5660300002)(66946007)(41300700001)(66556008)(66476007)(8676002)(36756003)(8936002)(52116002)(110136005)(6512007)(6666004)(4326008)(6486002)(478600001)(54906003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?YElxQCGnsRaJtgSo/22O2i9mzOBB?= =?utf-8?q?IPbYunaXvy+qimw8FIC+Xj+igJp9dO5QdK8NIWhaXK6BEPGiIu9D0aTFplc8Q262i?= =?utf-8?q?Cn4c8bxPgELh/hpO3q7bovyw0VhbDK0nCWHYvYcGoaG96WZCGmGVHJPpnfADuw4g6?= =?utf-8?q?BcZMhSI41WA52tHqc00is0Qd3wniXQOlEpxVkNkT97EJQuRL4IjXSakagobnkmli8?= =?utf-8?q?HDSPA+kGspBxNUZPcyU1Ft9MzWMZYPT2hfolnXtc7Dr4xt465A/dCerYASMSyg7Od?= =?utf-8?q?b24A46gZuxJKEWTwVwJpsQfyxeWuPITmyht6ZLTCF8l8f1cve9G1EV2H4ZZj1CaQi?= =?utf-8?q?k9a2kXkoDYx/lGyc29l+KbcIFhU5qjd7g3NIlY6EKlCcPO6y3RK0VgfMDU7d4WohM?= =?utf-8?q?AiNwJJfvp2IcHzHXIe7Rfyl1YlaBNB/yjWWRyFSns4sbOiRoQKGO+L6smS9/n2aZk?= =?utf-8?q?DdR8XVlMrYSv+WmCVYzDUmqsIw+hxQFN6D+ur2SvY0hy9xS4vmxQaI8zAx/fIRmSp?= =?utf-8?q?USN2e5dwWRmBKJze73gvhbQLu+ZLGL0B72QWTJceIMUvNVqKWjr03prry2wycAxik?= =?utf-8?q?+0FKxc8UrTwAdaiekCXiSD4TaTwd7k22Jrn+wo6NQqbV+hYWvH8uATCVUt3GDB0Z7?= =?utf-8?q?+LnXq/RL3F1L2s4NM+quZbMOXXoWpgvlEzaDRC2VswCE1WATZtzaUUSygViW5TgSI?= =?utf-8?q?6XoxR7e1bdlyRgaUDCnJvptCoj8YXxfCbIY/vyXKMQDyXBuF9Ac4LkmMmsbN1ChpL?= =?utf-8?q?TsPlf0m3kpyA+NrcfQf/rlvFD/esXF+ns32B2Rlex4elPUo9YX3/0bT9KtbVnM1CH?= =?utf-8?q?AaYCdFn1Cx0TvxVXGMASVI8aPS1xwceFlT0Klt3FwbaEC+PYX+O6QHEhBzN2bAMUy?= =?utf-8?q?Co7ai4kcEeKnJ3yeJxRb2RsnzeNulBHrgEZEXZL02EQof2/6xNTkEze1dWY0gzc5W?= =?utf-8?q?e/lCi1F6mgFRCu8cS0B8eTwQGTmxoNbp9XHGmB0owf6Tzn7Z+mOOgFDE/qNH22jOT?= =?utf-8?q?X0I3oqT6R6BVkLjY19loCY+FMuML6kDLLZZVqmqPRixQ1cc/AQeQFqF2fh3DArn0k?= =?utf-8?q?wag58oInIaMIgQKehliOr+w5gB8Zpk5j5F3RED0Xj+ghO2XKIomSP+0hBHknzXb6l?= =?utf-8?q?LwOxbi0zsVaGPbjNv8o1tkqHCQO9Ui2OEKkc4lxeFXSP9Pzamt4qopz2iEkLY3v4K?= =?utf-8?q?DV/Pi5Kpz9Q/i9pUqi8D1gJ+oK9yQG31q41wp5TT+QoPi5rrdHU9FbZuohJpKo6+1?= =?utf-8?q?o7/36xAHsEzm+6pzkBS1eP0Ba5aDzOD+ZH3OoyQsVmCRU5sZbHrI7Xm+xnIyUjWXW?= =?utf-8?q?n1Pw9Tl9Afru0yKzmBDRLWXCaMBCZtZ4rTJwjzp4ZjTXPem6M18m2K7Eu2f5CIZK4?= =?utf-8?q?Ay3kNrU3EtnodBOLV+8MNpXGsi09EpF5XNGd8Aq/cW34BA/0f7VcwAaQXNngZKd5r?= =?utf-8?q?kixfDV+HxP0bzvgOnjwQwALSBxMIFw26smo5hg7qLaC0GtGOyQikt1VcV3IMR/f3C?= =?utf-8?q?tCBStTnnmBrj?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac22902d-f09f-4094-b92e-08db8e6f5b85 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:01:53.2385 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AmgXOYqfA4fLru8d+dPhCENLGGSGx1TzibUQQwiWeylr9ulQXap0wm0qFkjB7d7Gcx20CKcjMj1zSOBN+mCOxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6027 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-omap.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c index 8ed9256b83da..6aa77eb4a3fb 100644 --- a/drivers/mmc/host/sdhci-omap.c +++ b/drivers/mmc/host/sdhci-omap.c @@ -1394,7 +1394,7 @@ static int sdhci_omap_probe(struct platform_device *pdev) return ret; } -static int sdhci_omap_remove(struct platform_device *pdev) +static void sdhci_omap_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; struct sdhci_host *host = platform_get_drvdata(pdev); @@ -1408,8 +1408,6 @@ static int sdhci_omap_remove(struct platform_device *pdev) /* Ensure device gets disabled despite userspace sysfs config */ pm_runtime_force_suspend(dev); sdhci_pltfm_free(pdev); - - return 0; } #ifdef CONFIG_PM @@ -1478,7 +1476,7 @@ static const struct dev_pm_ops sdhci_omap_dev_pm_ops = { static struct platform_driver sdhci_omap_driver = { .probe = sdhci_omap_probe, - .remove = sdhci_omap_remove, + .remove_new = sdhci_omap_remove, .driver = { .name = "sdhci-omap", .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Thu Jul 27 07:00:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707394 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 319A1C001E0 for ; Thu, 27 Jul 2023 07:06:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232433AbjG0HGJ (ORCPT ); Thu, 27 Jul 2023 03:06:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232882AbjG0HFB (ORCPT ); Thu, 27 Jul 2023 03:05:01 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on20700.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::700]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64A093ABD; Thu, 27 Jul 2023 00:03:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GF1y6zdQxyWutIiU3x+EildjwOF4AeBz+YPS7G9hNB8ni9Mv3yMXNECO3B5Y5SEL6QqRX81Rw+BYqb4tZkDsBWLugmJoWVq/XoYaDCr6MrvsfMkZd8gmWFAF/2Rp3I5zAimnwxLgKlkpLSZ1Z4a+a2yJ4SnSIVY14c6c6tQPAGM4Vp2UTZANb0duF6qY6qS1hdHnUU3zy2JGeHblXN75hiOqJw1RcDlFnre/027j+tNbqsIVCYsbPiyjYlDBn3kGBDtWPsjDCG89499P0PFHelPu6NRWk045moWQ7UGV/rICTH6mfJTWbytBn870GNdNk9wLgn7dm2MN/aYZw0TXdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ky6VZARD/+JhPhEudXHQb/Xqz7DgERGqgfv+ZV13owc=; b=jURD9EmBdSOX67XQCqiI52jxulKiuIkKVG+igE2OfT9VlXiG+agbXR+QOVvjORqUbam9ivTc0JlqKbj9IR1mGABtlo5fetw663rPjX1lSwybwJIG/I3sV+T34b54NreHvjgzuDaJ+vFoHvmWIQ/L2N1Kd1tG7fMAG4RgajnYuSm5AYv6gM9WU6mG0sefKZFcOMy0W/gxrslPo7U5twPzTg7odDXvHktxqMDsolBvGFh+SpJAapXtrV/ndLVPFGTkFdPlUULqiaJifGZ4bN3ftwPXDwUS9RTGfbtNVn3/W4eSzIVs591OpsaXKGBN0K9PBw+NEFnLaacNRD0viaizvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ky6VZARD/+JhPhEudXHQb/Xqz7DgERGqgfv+ZV13owc=; b=N5lBB5hCooH5YyLMTlmX3XrlKIOmRRi9yPoIeCmzwlm6R/JnTTWFQwlq2Yn7NpKVmm8J9nIdU1FJnejKQGjJN1SkM9N5Bja4Tp6LVFbCe1JneawVB+vRbHtFoF/D3p1cnDBW6kuwaWBqWFuTExH37C8/Zhc0l/tG1KsbwDDYeQjlMwEduhD6M+mIwjBh28hZiJLsXWocvfe9MWLDtr8vPfb53+4cE8p3p7DaDTEFE5rQySZJDYFA1X8tl+GSVlDGdf4kdBcSO9F09AbIr0t/qEg4ICuk7hSqL38jcpxJDEAScoaMcMy5ur01pQ6vdlkfniJiqE7Vdk7W83+FPYn4BA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYUPR06MB6027.apcprd06.prod.outlook.com (2603:1096:400:351::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:01:57 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:01:57 +0000 From: Yangtao Li To: Adrian Hunter , Andrew Jeffery , Ulf Hansson , Joel Stanley Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 33/62] mmc: sdhci-of-aspeed: Convert to platform remove Date: Thu, 27 Jul 2023 15:00:22 +0800 Message-Id: <20230727070051.17778-33-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYUPR06MB6027:EE_ X-MS-Office365-Filtering-Correlation-Id: a24d2538-caee-4288-e14b-08db8e6f5df3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jEldcW3C4DL4Ne1aYPGoF6kK/pcTDSQqE4JOFGTmpVt13r679qt4OjiWicWYIqUzvJq8JKBOtdmT0r20+wCVLj9VRjdibK8UaEmRRqeYwkCd+6XA6iFTfaDuRhncLa7fEkXUV71mxshcnpgQqq0ymMSjrYTchgKd/E9oviQJDTcaded6D8EosLsCUI/k29OsIPF8cqCebE++pt0Qv6ypCIy+gEL5/1oBqNtu32G1BIwyQGwD1gKi+phr6550h2I6Lh4WsYSkvRSuhuHRtf8KGkSHrnk6dQzyM1koNQA8qrhh3s+2S3Kr69jyDJeZBAiSerGOOVCd+V8R0lEeCc9EMUHKef3bliYIgeftBFLQ15K5PFBpuVfseUxvvSEzcNMxnv14kOFWeM6k61WlF+ZwJ3g+r+zXsyAMuiaGfI4c8Sxa7OWA5vZYrTRwY7DFugVwCH2saI0/vogF+9CXXrb7/P7DiNIt2khGhwOKqLz4BfR8BhUf2NzBZWVwQDmn3qIDn9qP0Zx3C6evX9GaxE/h5FxZY05GEeN3MbTHzpM3E9OIqIlDtjGIIzSHVHip2NrouEaMHiYeJqA95ibQHQWqggKDrpjNU/4V7eSIvRJ+Hcz+SYNZcKgUXr7cvJiH4PxV X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(366004)(136003)(346002)(39860400002)(396003)(451199021)(2906002)(1076003)(6506007)(26005)(186003)(86362001)(316002)(38350700002)(38100700002)(2616005)(83380400001)(5660300002)(66946007)(41300700001)(66556008)(66476007)(8676002)(36756003)(8936002)(7416002)(52116002)(110136005)(6512007)(6666004)(4326008)(6486002)(478600001)(54906003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?tA5L5hWN3Wy2Kt6dlGtl72XvHvWj?= =?utf-8?q?3HrYxyOPAkgmiO6zaJsBQq6GlDJkxU5FJF0ES5lMyUqsHb0cLCE/uGoPs10rUdnbX?= =?utf-8?q?3Z2D/yanQHOii+31UoEiYfq+o47fPgbiKKcIJ8GRlF6qA7SHAZXKz8VGqT3Ox8n97?= =?utf-8?q?GJgkALgQifiZxnVWVP6n5Y7lvM5DPauyEO8mPgs9fEIkmtTdBEP4+vUrciDe3ahSc?= =?utf-8?q?xBtN5/AVySxk0QRE3C15oqcZvjaEIBXH5mTZgZBwIcyHhlbP6HXH6JkqfpuFHVqOD?= =?utf-8?q?5fVTHmH/gkz0mQcSND9aXG0CehPLx9CA3jDRJX7cbOvwfZjYEfN7KcDufjpe4351Z?= =?utf-8?q?4Zb+UhtGUXzCCnCjXsy9SIDvcfcU+gyM0EYAnjarmAbER1etF3WHnlRez+IO/BDOg?= =?utf-8?q?2mKNgV2eVjrsCg5Sq2YGVtwFinxRCvLg6nxae67ljnAnRrib9DkaEWyoqO99BLiEz?= =?utf-8?q?T/ROb3mRPx5pVqWvcG7oyECmcCg/mNuhPSkqkkElaGm2TeqAASEhKzg7kx1RRfvKk?= =?utf-8?q?HY5P6ZIlp+4DFHp7FLxMsvyLljFx8kda3bS7GCgcIcPz+SGWta/CHqKl21JI5RWwW?= =?utf-8?q?DRKEvNHQseXu47es4pndj/ZVbiq+yKOP+Og8XGYKN61lsYQyPNpufMFPu5honIZju?= =?utf-8?q?oE9G+dPAcfvciBGhYDXk8+y1K3UJ2kGzesw+/k78HJ53VuvQGz9YkQclPXmJhjaUy?= =?utf-8?q?Y6jb4Hcww+/3HNksUR64afLLJZRkKtIz3yySM4qi62n4TU41PDVbCsUmeqFdz+mnc?= =?utf-8?q?Covr5Ao7pQOxxgbzhG+tQM3emXHexUTxBIOPFJBD2Fldwz8PZtKDx6DmO43ICTA7L?= =?utf-8?q?V7vSazwRqafhdA8DHIsedg/43jFk61Hg3C7+Jcocymye/OD1WG40FUpH5n8NmsgMg?= =?utf-8?q?0q1fVvXdS8SPozyZsxcU7BSg3kuiaLDjI+QAbqwCA+Ga8hp0BarsLlJVDA//HzBdL?= =?utf-8?q?rsI3t9OjDbJYip+YG/bUOjhykJr/wYPBZueWZh4bejKmgHw7Hc5g2dWNE90nEeMgU?= =?utf-8?q?vPLp8iJBKEq9YykcpqSMA/vrWHuPPCy45O2eLH3Vl4dnz/Eu1UjZv+9W2NlWBCRF+?= =?utf-8?q?SZHNyI/59prOe/Qi2R6zgUN9EIydgOiHI2IYQRkfVBqREb4Hh+Zqp6l9NDf4rR37z?= =?utf-8?q?2ipGAeniS1B43d3lwm5pu2qu0aOPuZ4Gw3prpHKqdKkQeDELrIgs/Lz8gcVOLgm78?= =?utf-8?q?n1vzlABJ3AHXK16RxsbzEJ/inqcOcK3g5MrRcQlM4LhBtgBogSNiizxV1IcW26K7H?= =?utf-8?q?fdEnMeRedmrflpwz0AZ++G/jW3MS18HM9fx9LwjlM960Udc1Xu2Vnx/A0F1WMozgy?= =?utf-8?q?JAGKjKC0phuvrxczQDl6c3IexhiKjCIk8VLq1j8y0ZzCcpZ/6kZdKFFpd2c03ADdp?= =?utf-8?q?GYnS3TgNhwmyCJYdy184LpqyZ343cE5oLI53MKOLud3WL9VLDoX55q7FgFVub1IIn?= =?utf-8?q?i11EQhLIUsZAifckpg7VluSegyc2isJul2xuy2WFyrtiWxWBOkkdnlHJhbNXQ59YS?= =?utf-8?q?ozILcxH1pxa8?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: a24d2538-caee-4288-e14b-08db8e6f5df3 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:01:57.3128 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XQrPUbk+4XE1Esq4cjs3HG4fCUhRQe1m+ffc55Vfhw2oGgf4ImVhDcHCESo1s+sAqbMQszaCEJ7OVJAr75dG9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6027 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-of-aspeed.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-aspeed.c b/drivers/mmc/host/sdhci-of-aspeed.c index b4867bb4a564..42d54532cabe 100644 --- a/drivers/mmc/host/sdhci-of-aspeed.c +++ b/drivers/mmc/host/sdhci-of-aspeed.c @@ -450,7 +450,7 @@ static int aspeed_sdhci_probe(struct platform_device *pdev) return ret; } -static int aspeed_sdhci_remove(struct platform_device *pdev) +static void aspeed_sdhci_remove(struct platform_device *pdev) { struct sdhci_pltfm_host *pltfm_host; struct sdhci_host *host; @@ -463,8 +463,6 @@ static int aspeed_sdhci_remove(struct platform_device *pdev) clk_disable_unprepare(pltfm_host->clk); sdhci_pltfm_free(pdev); - - return 0; } static const struct aspeed_sdhci_pdata ast2400_sdhci_pdata = { @@ -520,7 +518,7 @@ static struct platform_driver aspeed_sdhci_driver = { .of_match_table = aspeed_sdhci_of_match, }, .probe = aspeed_sdhci_probe, - .remove = aspeed_sdhci_remove, + .remove_new = aspeed_sdhci_remove, }; static int aspeed_sdc_probe(struct platform_device *pdev) @@ -573,13 +571,11 @@ static int aspeed_sdc_probe(struct platform_device *pdev) return ret; } -static int aspeed_sdc_remove(struct platform_device *pdev) +static void aspeed_sdc_remove(struct platform_device *pdev) { struct aspeed_sdc *sdc = dev_get_drvdata(&pdev->dev); clk_disable_unprepare(sdc->clk); - - return 0; } static const struct of_device_id aspeed_sdc_of_match[] = { @@ -599,7 +595,7 @@ static struct platform_driver aspeed_sdc_driver = { .of_match_table = aspeed_sdc_of_match, }, .probe = aspeed_sdc_probe, - .remove = aspeed_sdc_remove, + .remove_new = aspeed_sdc_remove, }; #if defined(CONFIG_MMC_SDHCI_OF_ASPEED_TEST) From patchwork Thu Jul 27 07:00:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707393 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC7E5EB64DD for ; Thu, 27 Jul 2023 07:06:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232956AbjG0HG0 (ORCPT ); Thu, 27 Jul 2023 03:06:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231896AbjG0HFW (ORCPT ); Thu, 27 Jul 2023 03:05:22 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2104.outbound.protection.outlook.com [40.107.117.104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDE223C1D; Thu, 27 Jul 2023 00:03:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kiy8fpqcp+uNTV8EGISWkzfm6FYRJqrhdHDdxc6Uoc0RfOXCUKsdJzeZox4RV9pED9gWhv/VW0R22qGhNVOImeFd83pxs+Th2eyfxSxSn4vBWq97f7FrzoaMveQgTxTOJRFpL4QSI4rK7cKqjN5g8SuRorDbSB7RpKnybnjVIpy+AxHIj5s7OIGPBadMGWcF4B0KxAAKki/H0eZaTvOZ9iUd3MC2HhwwSbtub15MQPCVZ7tZmdlhJ3ORxZykJ5igfC9zOSeUep7xcL8WwEyf3aBSPpqDRwGq5gBFOYrDX8KzBqWwX5swem3nmG+pfmdsZD8tx6b3YgIe3vXTs9LDbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uMtEtYh4yggL3P4Ktr/c7Zr9RRKQR6LhGA6gTsORCp0=; b=C/8wYarhD0g763S+2R0YVLoA8YWma4oSOAa6lSGF3wZ3Jdil/S7vy2epA05lHEiRIgiVYsMUAoz0Kv1K2vslF/g5+k3TyQT0xqjuQjDRtO3pLd9K2suSlG6TLK0vnyryuQ+h+RRxkZxNTr75M1cS0r6YNj6qlVSU2cmgFArm31tikDSOv9Vvy9CswROhAuPZjdQiXy48Nr0hh0ddQHRbL7SAx8SZApWCcrEk0dbQi9ZiYsfF6kQg5ObPzfBy4KKiIB5cf+3u8Kg3XcU31lmxiB4ulgeNH7xITCZl8jVM+iOQabBDt5RxNmV/ES5v0iCRfB75fuFhAAkNLSYS2NhjLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uMtEtYh4yggL3P4Ktr/c7Zr9RRKQR6LhGA6gTsORCp0=; b=RFNIOrLd7nMRu6PF734qYE16QISHRovR/ECDUObPbc6D7CEGfg8T2OzknJdxboJa1X5M+B8rdCQMnSw2Dc+Y5SZUqz7k5CoXZE8Hvck9utSiO4S8u2IoJ/CNlZ1yMuQGUQ17ejRP1G7+0VqCyB7OFPvh/4stiag+9lx3MSrQvM4k4jr+2x3sOqTfHdsLOH3cG9ZYnehqcrfJor+c2OA4p50GzJMpBrCD4a3205HuYHI1XRzcB6jJgjVd/Ra2O3ykJWCJPzS59bbBGIow2HV9uW6aDh2wv350V+4mDU2xvQMYPUZhEtR+G0pIXfwZIQlYgDm7wtxM0hwTT00H0KXncQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYUPR06MB6027.apcprd06.prod.outlook.com (2603:1096:400:351::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:01:59 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:01:59 +0000 From: Yangtao Li To: Ulf Hansson , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 34/62] mmc: meson-mx-sdio: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:23 +0800 Message-Id: <20230727070051.17778-34-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYUPR06MB6027:EE_ X-MS-Office365-Filtering-Correlation-Id: 01ec279a-c658-4fbd-3b46-08db8e6f5f20 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o6XoQrqFprSoK1KdhqPVLq7ymr3BXLNLLfQzFhp0fsXsQH3EjQp/hSaibvYZEwaEzTekM5eqHdrDotP9CK5S3S5miiIc2Au7jnRsmV7D4SUodym8TQW6/wBCc05bj2TTF51fXga60ze6k0J9q3ubgkujUmRTcwaFDiojbvke3sr+wPOGHjhSWn3Htjla1nal8MQ+dwBvQuabmOY80BIOpwbzXlF77FpNeEzibbLAPTP1KACCc07hsVLLKJzwUJxrRPRg4y+WE32jxnE9OpE5n/c8oowxvqQZtLu/J1i3DKNy8oatYfzmJRx25xGjBEfcjSzZg7RRjc9YNcMVG+xlLQCHLI/4zeuW0lshxfmXAebUbRfgtZhVByKzotu47qk5+HOnMCL47ILsjjLVozLBnwuEbqVnfXAX4YqS0rPVDobqIbO7ZZOyxL6QuKnsg8FvRG0Da8ogu7evhcJKKTJbQYJiEely7TjOpFNTXeoJF/tUsTKT9gosawC8+rlvLEllKaVLaJwESpZhxKj7vqtdqV76sE3j3EfiuRfnMGIbD1JyedgdZMirzByawLRIsIy3z9K0fOuf75wrEc+Y4VSRL8yZLqk5y7M30lC8Uxk+B9MVUB9G8M7A6VjSu/O5c5Ze X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(366004)(136003)(346002)(39860400002)(396003)(451199021)(2906002)(1076003)(6506007)(26005)(186003)(86362001)(316002)(38350700002)(38100700002)(2616005)(83380400001)(5660300002)(66946007)(41300700001)(66556008)(66476007)(8676002)(36756003)(8936002)(7416002)(52116002)(110136005)(6512007)(6666004)(4326008)(6486002)(478600001)(54906003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?+Nn6h5iXTLuKFFmRnKVFXfZJfJrt?= =?utf-8?q?09+uKovAqVp+GoHS+sc6xdoOmdIHkLl0rB6KRiV4gX+kA8be5yLCcTEn/4cp4IkaX?= =?utf-8?q?z+1ahoVC30MHgBPge1FGa0WT4uCd1EZ5kLtfVe65Ev01nWA+GjFiYtOgjR0eXS9UF?= =?utf-8?q?l4MT2wZkP0y+vheG5FQp/Tr0nD1TZBD2eNRWwudwwA4P5zLH1ZpWQivlnZSvJOZ8b?= =?utf-8?q?AD99L5YT6cMp45HtNzFMzyg3DeMCvfWhiAJ1spWeJ4ObBI5QojoHJq5dlA/TIYXXZ?= =?utf-8?q?MERiQKyfEhnKfciJ695IHVH14IaLa40Vmz1nSb8vITtuQum07NjTXUk9Ld0NI9juh?= =?utf-8?q?BqInUjXl1iLvdxhtl1QsGBar3iGlPxRtdHA22pD3aQZ4e+be1rSUEHTUX1wfpYGpQ?= =?utf-8?q?iY1IsExH8RC+k/pC3efpBxzxdU/V852iYJPam4w0Yr1W6p0ua21tCBTs2JEdq7Jya?= =?utf-8?q?kG6wAXtFCb22QFlrTMx5dQea9F6iREkOM216lPXWgSfpQm0HaWu8qrX7oLhE1S9Xy?= =?utf-8?q?0vspKj9zEpQmrQw0ltg3QYLkQ//ece7b3zB2k5T7vKsCjQB32GFdAs6LO2AliAn02?= =?utf-8?q?NQXXArkVA7bOtlY3qdN0IXOw68jfa4q3qlqJNaWCce+qmavzFB+XOH9qbuqxGVt4W?= =?utf-8?q?skHUC7ZjhcJtWMAtkLWHA2nuxZ+8QPItIr3t80X60u2yPyM+WFH447pEr5vWPMbYp?= =?utf-8?q?gnE9Zt8McYMPgfxcPHbznhz+9HNOKqRKrfA3xO4EB7Y6AlCae2d9Ljm6pnb/l+31Z?= =?utf-8?q?hljg8dATObnH4gjGj0vwh4Uva8mzDUjNYDH6UM40LGuclL7TE3SyhHvhcyeav4gFW?= =?utf-8?q?CnIep9MWYhcwQ2tK+p+aEVBQ5BcTyK8guLfRzhvlOeO00exiVAPBUBAMEURZIhmii?= =?utf-8?q?UFajw/paKMRt2IBzlTsYFTIzpp3NL2sk8y6nhU788e4m5C92pfk5QhcYiVq9higGe?= =?utf-8?q?cY/XdFx0Hz173n4YhnV/kKOKE2T8sk0oomtBBQcM7nutg2mjg3tqtL+9CW6GamvuK?= =?utf-8?q?8HA6IAchZqJIdHA9xRh1ZbuITk40IgnTz4iJl2F4fzu/jZlaoQ/U3hnyrSaXm4kJr?= =?utf-8?q?jCnmAIMWgpeP6dGkKXtBiniyZo9EztMCPDbjmugQNNKz22rHccL5CwMU5BI7vJK6J?= =?utf-8?q?sgsF2miaxSEcx6MCNiBOUMyPybcLWne7DRaY9kbTh8xGmLrj3o90u11z9txnSiiOz?= =?utf-8?q?M4cb8jD8q4Tysu7Egr6gPH/tkuZX90ZVNmpTmJMKuyBPjkS6clyfl0oK8AuX0TSvq?= =?utf-8?q?y/gz0NTQQ8SBteP3p0ZQmbcOkThce1T4P3IiYhk4vlNSRY71GTwncam9qCdpU5c70?= =?utf-8?q?hVYbrSM8H7iJXV6k8LKSMa+IufL5nwofZBezWFeyPwhLKiG1Z7H2UdArZMzvDPLoZ?= =?utf-8?q?AcGWjvkOBlnWhdccoNJSgGS4ncBxAXsSDkpVXJ57Lq1yx/aI9pmsSNCustAKmhxG3?= =?utf-8?q?F4t0EyObQuAut0WkSkWca+muInp9n3Ua+lNqqvPJNbK+hQf5jX6+0KHY1zVQmN+CI?= =?utf-8?q?itJyMhSOs99D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01ec279a-c658-4fbd-3b46-08db8e6f5f20 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:01:59.3414 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3hzrNXyFfTDAKTY4M9mihnw0CU/7Yx41Mu+vb0rLBSrLEStUm2fN15U9PUijxzFSsbiM0rabtqPgDoODjTrJZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6027 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Reviewed-by: Martin Blumenstingl --- drivers/mmc/host/meson-mx-sdio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/meson-mx-sdio.c b/drivers/mmc/host/meson-mx-sdio.c index 3a19a05ef55a..a11577f2ee69 100644 --- a/drivers/mmc/host/meson-mx-sdio.c +++ b/drivers/mmc/host/meson-mx-sdio.c @@ -728,7 +728,7 @@ static int meson_mx_mmc_probe(struct platform_device *pdev) return ret; } -static int meson_mx_mmc_remove(struct platform_device *pdev) +static void meson_mx_mmc_remove(struct platform_device *pdev) { struct meson_mx_mmc_host *host = platform_get_drvdata(pdev); struct device *slot_dev = mmc_dev(host->mmc); @@ -743,8 +743,6 @@ static int meson_mx_mmc_remove(struct platform_device *pdev) clk_disable_unprepare(host->core_clk); mmc_free_host(host->mmc); - - return 0; } static const struct of_device_id meson_mx_mmc_of_match[] = { @@ -756,7 +754,7 @@ MODULE_DEVICE_TABLE(of, meson_mx_mmc_of_match); static struct platform_driver meson_mx_mmc_driver = { .probe = meson_mx_mmc_probe, - .remove = meson_mx_mmc_remove, + .remove_new = meson_mx_mmc_remove, .driver = { .name = "meson-mx-sdio", .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Thu Jul 27 07:00:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707390 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 300A7EB64DD for ; Thu, 27 Jul 2023 07:07:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232901AbjG0HHP (ORCPT ); Thu, 27 Jul 2023 03:07:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232306AbjG0HGM (ORCPT ); Thu, 27 Jul 2023 03:06:12 -0400 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2116.outbound.protection.outlook.com [40.107.117.116]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C859944B8; Thu, 27 Jul 2023 00:03:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BG8HdyImjNNEhkLXVK/kPMQVxcGFgh2OqAkvRTHd5tAAiVNDfdnmGnu5zAlRVvKbx8e/hszbK03pUXRH5agi8O7JPychybFEdKndLAhwjt7wNnTMVGNX0vA9k2JvxX26R2+EwUEeYaZUX+ng4ZwX7b8yfNnUNhHm14xVWSbb2cO2DF37tTqiP3+PQDmb5MKZKKyf0mhO3+5R1wMyDCKySWj8v0w5fmIomoE9N0yNwrKNVal/UH9gJ64mbpN/qlkM10KJ86KIX6rGo2tDKtTJkc3Ko+84fboInTvDk5RbZKlecx0Dxsjo12RecHJmbiSJQK9Z+9DS79daFrEO8+eiIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ds1a60oaC5v+9oM6ou+xAQphrPqkP3uRTm0nyn/ukQE=; b=FqAbsVjezv969l7BRLtEAaElOhSwFT75HJGpZ2mwlY+6SDRug64d8N+7zolTujx5GEcQvZOdJj1hiiCuq3+OuVTJFApHVJX08+pYCZfLPA2I77LC5JvQ7amqiYYk+PGVVAwuYpJG81Av3GcumoAf7Lxz5dwKhzRmscRU4c5mrdXWI41mitkouAVU+cPp8Y008Pb7yy99EOFFAoGPPOgzcsJAhLJfwtJK2RSrwdqyYkZ782UWVOtSGSWkpY21Ff7ny6DMqa0ZxIIdEw+ajp/mZ+zzOY2r7l/0vCs7hd+d7INL2bQtSf8rFmboWyIL2Y3QchyMjXaZ0Vj1j6YadwPiUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ds1a60oaC5v+9oM6ou+xAQphrPqkP3uRTm0nyn/ukQE=; b=aRXeThsRgFEwXG+4G69yKWRrTEfdqz6MaLpRO5urKzEXm2/zFgJhIvNtKWQCbxBbvFzLUV0iB+qElOZgEahmhEstpShFOF+ijxslsDbDb7Zy8AELcGn1Je77RgsXtqMD9T0nH1wk+YOMMks8IUAUgcGAKSYOt04HmoDvPUQ5jRWtEBQynYFT9TpQfIlTBy4S5aVgclHIfEMNXFD2gG6WYRBDws2Lskw4+IcH+w59glZ0LUXKIiNgEyNVZPPLCzfyHqyF8Y9GYhGM1CWJkxaA7ytq3smFffOgvI9GGR+ZHQcMc0PbUxsgEckSmuUs2B+2g97fWhRUyFK0q2kMXGy+7Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by TYUPR06MB6027.apcprd06.prod.outlook.com (2603:1096:400:351::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:02:01 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:02:01 +0000 From: Yangtao Li To: Adrian Hunter , Ulf Hansson , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 35/62] mmc: sdhci-sprd: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:24 +0800 Message-Id: <20230727070051.17778-35-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|TYUPR06MB6027:EE_ X-MS-Office365-Filtering-Correlation-Id: 871047a0-c260-4daf-211a-08db8e6f6037 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t7hR1tpvQWjPqc1xJ+qhIwu9YW0/5KI1Xia/6B5HIExbM0Pc5Y4P4suhGNV1Mz7nHVx382Z90/s4qdY/lhpPx08F2Uwa57Z/3PWdlw2tfKPPMCSYumw6uB0LG7mgU0VdO+bBxQs6gt5uBrlTMFbP5gdZGX7J+8LQTB8pztUs3b1Lj2ANf9uh097k/J2PxEY8F95s3JeQaES3AS4OaQpzVxQN9yzQyJv1G7W4XqHc7XtWxn2AaaWaVurl7IXM9nhhVbuEY265tl3adqDphvIHvQiIpecp2hhQyQaz/kxOs75M0q1MfaCnioFkb3b+Hud+hN6GGzyKPLxB7AYgSpwBRTQsMYOkPrJRKp4yNWC+Fnfdwe2X79VD6eYO/YAQewg8uaNfHSmRh+xJomAHgCzfKzg2zFSyP1Zj+9PO5imhoini+bY2Y59S/XtpcpJdx6rmkZwHciIphV45cgqWWCqQqCPEtXS6ig4WTtvncNjy5oOpQW5mx+hnrSBAfxPwT9WN7SrefWYC/Cpy81O4om7mfQKmb+NopJI1TScut9vyCvjJo04XRUSp9gEKyF0KD06+gUcVqO2CMXZex6vdf2B2iNiG+ntE04EoS/zjdHdHA/aChB8q/kVFZit982OLv/jt X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(366004)(136003)(346002)(39860400002)(396003)(451199021)(2906002)(1076003)(6506007)(26005)(186003)(86362001)(316002)(38350700002)(38100700002)(2616005)(83380400001)(5660300002)(66946007)(41300700001)(66556008)(66476007)(8676002)(36756003)(8936002)(52116002)(110136005)(6512007)(6666004)(4326008)(6486002)(478600001)(54906003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?qbUEstK3g0M03u3VZME+0R/mYLx5?= =?utf-8?q?mwh9bxVeAcrbnAHzicWfcB3JY/ODPUk5kUpC0VBUt7CtFgFMNo/l8wI1yv87m879D?= =?utf-8?q?A6SX//0A7kZA9TnHVyP+If9LPaTayxvGD1+VcpAohcQ08zukuxoYxfFZm+lGsNCO2?= =?utf-8?q?ghaZsS8psEVZxZLLhXdMYn8DyL41FNVUHaVnd5hLFETfwtQ6phwIQa2r04Z/E2bZA?= =?utf-8?q?AN3fMYkj3fv8V26Nuq11L3H0N615P5JS4QgoJrFhaiE+lKB8D2Nw2auhs38c2ELtR?= =?utf-8?q?pSzvFJEcKJL2GP3YxVNmmJ53Vz6mkLLP295DFJXDkxwEWRDMxlcmG1btX6wUgYz8C?= =?utf-8?q?DRBPQ2DvnvPVtrHfNizdGHw/bkHkfUIy00fZxfJ6qyEmuwKErD+CnIDsiVoY+wrcu?= =?utf-8?q?wTZI4YIu1vfv9HX3QKQYhUb0y5zUzpzSPxV22T1tZhex+ikEn2HlGNi73Ue8ez75h?= =?utf-8?q?Gil41nblS6sSU/B/sIKT5xCcc+UuCqBS7Qez4+xTKEs92saglrPK9iTTLEYzwEfsj?= =?utf-8?q?aiAzfblK9w9/DxydYCMaIf8N2nU16y/LkXedEmg0avkiJsymhnnIS9CmcdaTXBoiU?= =?utf-8?q?dYWyVdXMA9YDZ3w/VWtzw6XXH0FsoWwsaPYKqD25xkMug3HGph9eOL/troEXMYY+V?= =?utf-8?q?DBJoCypIsyjjybs+LOP2C6ZBcAzmWdF0FHaOHXgFUzu3iAtvxMiwHMurO2CagoNrG?= =?utf-8?q?aDUWpv1fXk5YI+YewdQ2ICeeaGSzkxa2D/aKx0ur9mOj0NdPuF0So7QMT1SlQmSqg?= =?utf-8?q?JRVokCZD9xKJynPs27utntr+dgIclGmt9WPxWLYZ9RoNuJ6VOh8DimzYGPlVJQU8Y?= =?utf-8?q?f8dMEvwi9Ub4qU8E4bo0zCpSeE0/Gq+MhK4fvVyycjAFzn6qfZ7tDS17GZQrQW/96?= =?utf-8?q?LXr4JTXYIGD5O92pPynPQ4UYX+gV3AkUUJLcmg0CqvcpqosftesNKVgXN4R5gvuCE?= =?utf-8?q?nCziSszrqntVZdmOvKImvHC0UFKpePka/gABmmx+loiWI6xj0FupNWI53Dv5VVT4F?= =?utf-8?q?03GnIJJ8VOFt1jJkrud/9c9d9BYRPldKzEJiZYX++8vKhgBzejbmSnsaeNkssAd6O?= =?utf-8?q?HjU8M+lpyJrSQaXN8H2Xg3fb7NXm02zgWBHY7ePLRpkS9isK0bBKNgoh2y4A6EW50?= =?utf-8?q?/JIX7UH3RP3XG3PrJSGcbJHUuXvoVktKp6p1SK3KSvNgdMRoeKeCDkYKlYm8NKVy3?= =?utf-8?q?TLzBqxRZHK5y6pNS6ZOd88wbi/BDJR9LSwoMKUopQ3Si7bTUZuhsecAdP9kRONDHh?= =?utf-8?q?k84cd5Cs6iVaTgOmnxpqvL7I+fpHIsbw+v7W7pEM/hb9fA9VKe/m5b/xuwArSM81y?= =?utf-8?q?VOx4br3rrVSSo1SMJA7OGZKXXQqxpZL363dAye6dAC+UQspwX/Yrf5E+77ZMYEb3y?= =?utf-8?q?iamOKSAa8/+YZn+gmNUh9r0+wXAVKRA7us1wESVxsknPVSqJYARhZVKOQJ54/MCXY?= =?utf-8?q?VqJgLfxPeb+fHM9jy5403q3AGhmDljM1x91zZJeAJs1L0g+3swmTyBH57JlyHwabV?= =?utf-8?q?FruRcGAXKxk8?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 871047a0-c260-4daf-211a-08db8e6f6037 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:02:01.1150 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OBEGAPt8I4uNL20YaK2TfZNDPiFCmCC0yASEpV5MxDsQL1q5nU+01XTZpNk9lxIQ9Ppkm0Qzzwh5ipJr8DQpYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6027 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Acked-by: Adrian Hunter Acked-by: Chunyan Zhang --- drivers/mmc/host/sdhci-sprd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-sprd.c b/drivers/mmc/host/sdhci-sprd.c index 7f4ee2e12735..379cb3892757 100644 --- a/drivers/mmc/host/sdhci-sprd.c +++ b/drivers/mmc/host/sdhci-sprd.c @@ -720,7 +720,7 @@ static int sdhci_sprd_probe(struct platform_device *pdev) return ret; } -static int sdhci_sprd_remove(struct platform_device *pdev) +static void sdhci_sprd_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct sdhci_sprd_host *sprd_host = TO_SPRD_HOST(host); @@ -732,8 +732,6 @@ static int sdhci_sprd_remove(struct platform_device *pdev) clk_disable_unprepare(sprd_host->clk_2x_enable); sdhci_pltfm_free(pdev); - - return 0; } static const struct of_device_id sdhci_sprd_of_match[] = { @@ -800,7 +798,7 @@ static const struct dev_pm_ops sdhci_sprd_pm_ops = { static struct platform_driver sdhci_sprd_driver = { .probe = sdhci_sprd_probe, - .remove = sdhci_sprd_remove, + .remove_new = sdhci_sprd_remove, .driver = { .name = "sdhci_sprd_r11", .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Thu Jul 27 07:00:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707391 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 712E4C00528 for ; Thu, 27 Jul 2023 07:06:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231770AbjG0HGu (ORCPT ); Thu, 27 Jul 2023 03:06:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233006AbjG0HF6 (ORCPT ); Thu, 27 Jul 2023 03:05:58 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on20709.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::709]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7726844A0; Thu, 27 Jul 2023 00:03:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IrRkVKHEoxamx9QXYM5DjP7JvZYT6rylLnkwqbCe62vIUzy7qVxQ5p0pVeiQoCOsXDtSsfFmivbn/h8uGpZn7L2Kr8tFuwTYeZ1C1bgpjnMHLlTwXss7PjT7h1SiUQEZRgnbTWL1SvS0l6uNz85jMXuUtiFK7qkbFyzRw4LZVuB++ZItgAZp9BoNbf92cEQcVjQTVGudycJ/KkZFH3ZMF2xo9pHtWecZZ1iWvV6s3KXLj4xZ2ljFciHebPzzC11TdXqLrxQHYkq38oQglQHiKbqt8gbpJ+ulk+AH1NM6mgDFyNW9rbcE9jZ9lHD0TEC9TRQAiqQp6txefYFp06RhSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Km5SLI9CwGIZCQi+0pIE2z3vwwmcgtBqTHQpN6fP90g=; b=ePTjRbphOzp1xBq4Ik4JgqYyTq/Zoos3pemFweUIr7gqKHmxECDqwdFILrLNmmVSO7Wmqpsn2ubosBoMvngE7bkdNs0w4SVxUSUi1RRRq/pwwETZKRFxxf8GfpzNZOWdm91A8NL7uWBsg/AEpI3mH8g6CxQpkp6knl5X+RGYcKp4ir6FOmdB9IoxMsH48BNjHBDuz48ZquZj6CmTtiLGxenAg4bu83J2J7Kx+Nw8GotArMD/zzhzO4j1jdZIAcSK/2JQVQZkN0sNTRwmX0HsmmK+6NTu13X8TFQJ16iBy3Blj3TFmb61r19+l0j6+p4uc3/JB4FhZVCGY3dwq2KW3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Km5SLI9CwGIZCQi+0pIE2z3vwwmcgtBqTHQpN6fP90g=; b=LG0fl5uWqI07gVDrSSsxev8xPeFsLo0BoI5OP8IrW7wMdTgRhKfzWYy5dSv9HTmoDTqI2QwwQ6r8EmdW24PV2Wlhcsu9yq2lBQW4vCzPsBkj9bKcE5TT/k1bq7vtdTSgPNFBjpE6+TJgpf10xfiUankEWdL/GcVGjQfx8Jhpxz5N7D45uE6YvspTVm6YhrGvMRMt6UHRShvown2EquvSekOWGIykKGaHwW+/azW8+hgjYWuU6wLA31RpdXYc+wliKCTsHS/1OWLShFYJ8wXSYybsx/FsjtMiJD2xgOqjAv8IWXpMIHzfFvuRsfxIfAZFz6+hyWP2W9XwEDyjVIHBSw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB4276.apcprd06.prod.outlook.com (2603:1096:820:78::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:02:37 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:02:37 +0000 From: Yangtao Li To: Adrian Hunter , Andy Gross , Bjorn Andersson , Konrad Dybcio , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 39/62] mmc: sdhci-msm: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:28 +0800 Message-Id: <20230727070051.17778-39-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB4276:EE_ X-MS-Office365-Filtering-Correlation-Id: ebd6aef8-6ee5-4147-b2a0-08db8e6f64d0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yKtsxXqBGSe7s8f9/ibhccb3492unw8jK/arkaEKvkJqfizEsMavQ2GWHCmtfYY9/ugTNTKE81k7hP5GY459OQwtyg3FU96hwSf0KPET4yG8zCDdZNAvGwrTpctuBFabDTw8n3e9QzmgK9Pb9loeLAqIHfqOW2fLahVNq9nHtS2BnjeSL4vyVVSviZ/+0HB0uHoK0GpRu3t+T2gMHrEGXS3//OUF/XSHyW48s0qPKrCoxQPp8HKJZ6y3kjgAIoRpsYySW+3snOhd36UM7187iLbgFZmTp0u1QnmT1+aGFNhvQUpgXv5rTGhIe/pF5mads7Lz9BrIBY3cOYJL/IJA/5ByvGmLqC/Qx5f4vm4mJA3NQ5QexBcA07vaUjhP2P5+o48EmrulMFsZ+xqUzBd1mDmrJdrr8oOhNqV0mpDoXu5b30T4LL3UcXMNpZmwvzMpLdT9bv9zbmeJjN0RRJTago0JLMddT8c2LxDQt9Kai5Muj1XalIiiBKfSILuu8jLLe4bCpFuBS0GHKL7x1h70Vh5zaEI+kPzLYL1Y/dmRFESKFPgTKAetvq6B+zKax39sMrCv4fosHZCQs5gdwoDuEtUSmnqXU2gjdVbJZl+uclPjLWHvBoAyBE8OsCGeROQP X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(136003)(366004)(376002)(396003)(346002)(451199021)(6512007)(6666004)(6486002)(52116002)(66946007)(66556008)(4326008)(316002)(54906003)(66476007)(110136005)(478600001)(38100700002)(83380400001)(38350700002)(26005)(66574015)(186003)(6506007)(1076003)(2616005)(36756003)(2906002)(8936002)(8676002)(5660300002)(86362001)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?AembRaAXxOoLT7AcmECZhRtqgfke?= =?utf-8?q?soZG+oPzrFhrYbIysoLqHxktTvzqqRwBIFh/Z9h143MR/k7Evi5mGcWF4Sj3A7cCW?= =?utf-8?q?zAPFRSW3OYQ7EHqkU+ItQLEj8daSQhm4rWd2trtYFwQyq4Y9Mnc9haiY8SOC1Iemd?= =?utf-8?q?m2+uACpD+4BZQgzNLl91ZzohVqEtlfj+zY3olG4/34aNoMRs2ht6CB1qpDFolU0Pk?= =?utf-8?q?uzSahJjN69iE3+48rnnlouTaR0ZW7diZc5x1HLMCsFIdY3w683VOijeIWfmW1hZQP?= =?utf-8?q?//a9fUk0MXvjsCbG4t1ZsGLeBMm0/F9SUiVhJT5eWBcV9yIO1Jbb6CuFmcCV5I9qV?= =?utf-8?q?k3e9PCi6Wq2ZbkDTwauTLHzFxKNS4n9nlMG6c4ehYAg5ilU35eKAEt22gcaHuueH0?= =?utf-8?q?VXX8pApskDv14Q48isgGMCTJz4xthr1a7tPQjRXcY2mxcxG3P5rX5XgXjytq/ZW0F?= =?utf-8?q?MXfL8JcEBhGUcL3kXhjvKnS+6wrRoedvZNL/uE58nX8pVRMwPmEqukpNFs8ypF/G9?= =?utf-8?q?PCC2h0s9eM6rt9ew2Scrhh9YWJRU/NJRqWmtTkNnEDzRRcaymFFHmANbOiKe/4xGR?= =?utf-8?q?eSByX3FkNBF+37aOAOsgYfnBglJoZ2ilgImvkY5LGgbyF/dHDHibeygyKW7UZn7nr?= =?utf-8?q?VMy/lKgYky+IY/b+w3GttK48JpESf/xlZSqI+ZJC10IPGWya2hyvvtyFi00ZtRrQY?= =?utf-8?q?/8OmR6OxM81d2HaXjG3eblxVo1hL0saAR9lJb0llilO7X1BDuw0BF+hjD34p8Cw9M?= =?utf-8?q?FYR0jHxrAkxeHuTZC4IjQvRGoR+412DCrpbd4UFqROR6ackXIOcgOIC/ykUsBafhH?= =?utf-8?q?B1caRhJ36++PT8JIO4H88RKZ6PmWGW2Jsc/qu2Is7G0CAL+sxlMx/9HlZ5jsGsaUj?= =?utf-8?q?EqqHYL80np8GfVwq05lYgTSePUy6wgWXUs4Vy7XFh5fS/eYOC1y0UaJuttwOU2zVw?= =?utf-8?q?faTu2mzxMsWsadv8CO6Jm0c3wUuCsNruZYHsfy4+pZ17YJyK5ht5rTPxcwHJrgJlK?= =?utf-8?q?FUrNrG2YEhqe4el/L9g/R2sVAVlpg4zixQx0slAGL6siS22HkkGBsJ0FMo/LUVsqf?= =?utf-8?q?8DUlLYKJTcjss5CVhob1NkScfZIXqR416LzQpmNZEk+6OYNvc/68Jvz+RFW3CW+Kt?= =?utf-8?q?EQjwtehEnzvnxyWd7SaNDDJ1Td2PLzlG30Fu6weortqW5anOjXB1SenMTiVpCmybv?= =?utf-8?q?OhZq1yf5YWGtaYl/jgio/pq70/G12MSM842tcwgNrKfMuMV+A5dKMGJxuEFbHWhU9?= =?utf-8?q?PngPGpC0H/AGZppzLvsE0fT5on+5e4yDVGsYWzZeN4Qgt3Z5gSvu8lFlCMid56SQ8?= =?utf-8?q?qjns0PdVsx+JB46JBjilM0gSTagOZe2T58GcJZmnmmCAWuKCZb5j0AyMAkMmBCoeS?= =?utf-8?q?eOm/xE8DxBbU/pSXvQZdVUo6I7aBKV/p+D2MZ8V+AbqDbdObr45OHf5R203Y61JB2?= =?utf-8?q?8oRGykacqolJsTNxS4g6CNzA5UUm8wlxUEk8mSu07mYBis+7u98/qQaHgoCq/Xqjy?= =?utf-8?q?NCI5K77XxNG2?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: ebd6aef8-6ee5-4147-b2a0-08db8e6f64d0 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:02:08.9240 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: U/v5oBPRnWDVpQKHQi87fnp2GlnSk69uvAjuYbxSIcA1XZUTPFTsPcy7T3lJPgXubBccH6cTRvMTpPt6M8urjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4276 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Acked-by: Konrad Dybcio Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-msm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index 1c935b5bafe1..80e376802ee0 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -2668,7 +2668,7 @@ static int sdhci_msm_probe(struct platform_device *pdev) return ret; } -static int sdhci_msm_remove(struct platform_device *pdev) +static void sdhci_msm_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); @@ -2687,7 +2687,6 @@ static int sdhci_msm_remove(struct platform_device *pdev) if (!IS_ERR(msm_host->bus_clk)) clk_disable_unprepare(msm_host->bus_clk); sdhci_pltfm_free(pdev); - return 0; } static __maybe_unused int sdhci_msm_runtime_suspend(struct device *dev) @@ -2740,7 +2739,7 @@ static const struct dev_pm_ops sdhci_msm_pm_ops = { static struct platform_driver sdhci_msm_driver = { .probe = sdhci_msm_probe, - .remove = sdhci_msm_remove, + .remove_new = sdhci_msm_remove, .driver = { .name = "sdhci_msm", .of_match_table = sdhci_msm_dt_match, From patchwork Thu Jul 27 07:00:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707389 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B21AC00528 for ; Thu, 27 Jul 2023 07:07:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232934AbjG0HHS (ORCPT ); Thu, 27 Jul 2023 03:07:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232943AbjG0HG0 (ORCPT ); Thu, 27 Jul 2023 03:06:26 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2094.outbound.protection.outlook.com [40.107.215.94]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17AFE44BF; Thu, 27 Jul 2023 00:03:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CASQwrGoY9Uvcb9CyqlGcLdazCIyLTrBvOM6TyMxuFrgPnY+x1PPK9x+mEe1fq+kdGWVmLYcISSumbTjBsKRrTWSpsdxPPP30z/KfF/W0bEDCmT11+TYUM+7v6kpFhfAXXF8z1/VmtzF6TjuhWFBT2+sFvsky+tAMefQFYL8vkoikHDYfoMtZyej/X21bSoyw7dq3TyWd2Kgm3CGjLcsgpYlnLAky9osQ5MilGouh4O12ABEvz6xB32JaGtttjZ5aXzjkVcFkzNNTQnTpG5pNt4rjFNH596isIqlXFx6gov1lwnmhX4OTWfn+9/4QAHARCNoOTycZyXdXyyBoh7Weg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WVnebS5xmKX74dwA/QiihEaSwS42iXdHIK6TKi1CgBE=; b=BfJ6tPEVKXYp9MQIcVE/j+9Eehcf5lkK/B9IyGnHdVmb8FPk1WWLShfIcXj3YjbTpNkoVIIvIxgKRoJ8qkv5hChrEakq/dveoRemDMdyjNB6oGvnQIVSo7OIiTijy5sTBwIxbPjWbycNE0QSxNH2BluCnw0LBS2k67RBe5j+5SVe0IXmnuokIULB/fsdPPr7IBRCdNjG+5vt2d4n9/6QDy7aGhS1NHGjlnjLVcI+BA2ZgLWtzcrvqUMgFcjE9rUwTjpMn/lAQpJ5O4vYLD7ZBH6fx1JG6gXZMheGakfNcUGcAy7R/Af6zFghZBaCJ9TA44ZhHITianx3D9rC7ATQPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WVnebS5xmKX74dwA/QiihEaSwS42iXdHIK6TKi1CgBE=; b=YC3CwH6xulM/fLRG1ffnb6n2dbavKoIe6n2BiAxnc1m3Z44/TJaxU0gRcedvBZWy5abVcd8L//7mXA4I5tv/YKsEh3elSfLunIn8ZxS3zgzm6s6Vhjzx3uvn0DDcXI3WHb7Km3dks94OZCRRwJ0O6d9KXzkdPZejKuUwd1y/dx4H7Q38cdO/6R7CV28roWB3dspMbsuI+cxVhlvDV4A1sO9W4a610DDNPT5RFFGsBM9kKqzglbLHJhYS+6HjAlo5WYK4L/byhELzf2iGGdtFwN+YwkcGpK1WFXZw4c3+VApN1qeuvb/gSm82S2rvA8bKyy//f04++CDfs6vaxlkrQg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB4276.apcprd06.prod.outlook.com (2603:1096:820:78::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:02:38 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:02:38 +0000 From: Yangtao Li To: Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 40/62] mmc: alcor: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:29 +0800 Message-Id: <20230727070051.17778-40-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB4276:EE_ X-MS-Office365-Filtering-Correlation-Id: eb3bd1b4-99e6-482b-9e42-08db8e6f65a9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Gaykgs1wB4z3hjEFhgQk+TUUbRfMU2QBEO5TUTvPe7BE4uha9n1ajIM8nThmT5cS2Y4cMA/BUz36gcI93ZG9raOXbp8A9HvQ3RkKNEPCu8B41PW2iZWKNjJpcrWpwtQe90klv8uOyDQ+tieH4e5wG8npZ4KHczmCNlJp7x7KUM2qXGUA7XHclp6loJRNUwCeakNdxUsyyMK9wI9rvhSilN1WvDofsLkXJmiLZOJFtlcFMcYKQDMl4kRj6nQVbnPYRcwdnKnS6tgpNoupXrk2pBdhP6SRBg98SVxNETdmfFk/msAcoQdBe6K2GQpJOJ76nZ1Rks1l0YF4ogD+XMz/+2ADrwwnNVHVKWu9EhAn+Q8kTH+IvXyrr8orQ0hCw3NS1TyT6NlMn1pU3q2NRqSDcqi99wRKIxp6mAH0W4BjeOZkrg/9VIrJaRJLDABmG7RHTcQedbOUWZ426jqAuAf/iPhEbH/6xvNcNE2xyWOrSkFyQqIjKWP6APZEQCB+77jDac8BtpRJbxDroxPs1eYsy5Gu7F784MRml2hn2z8dXOZ8orQGo5UnYytX4oimRvF7ON7pkhoCJQMLqf2jF6Uw5sSa5EYC3Zj6fg/FqqjpiVzet1HI9R6ZQ387qY71DDRs X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(136003)(366004)(376002)(396003)(346002)(451199021)(6512007)(6666004)(6486002)(52116002)(66946007)(66556008)(6916009)(4326008)(316002)(54906003)(66476007)(478600001)(38100700002)(83380400001)(38350700002)(26005)(186003)(6506007)(1076003)(2616005)(36756003)(2906002)(8936002)(8676002)(5660300002)(86362001)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Fd8ux2dxPC0AOkY+QTOjd5s35+Hs?= =?utf-8?q?KP+Q02K/osmudykLw9SsXGoe4NQtt95S+r2GkZBAUqXjZACXZtM4BqEsSn432eqbw?= =?utf-8?q?5Rgf+X2yBP1vA6j2Cp3QCPCVREODK0WrHX84wXAdpv5gOAkO0894O3ZHF3bN0m3k8?= =?utf-8?q?8366baAqVclYHyFDNdfocFk04G2YtvbYj8G82r6zW3v/1TGdTkVBx3btDk3KkmMZd?= =?utf-8?q?/GAGPQ8/9KdQ2Ovpw/4viNa8TetNcKCRsPH4lqCEMl4Ht1N1TDJNTOENYCg07SYVq?= =?utf-8?q?rWpkEbSncbhl3JVQFOyPZ2lTw0Z5D3kewKX/b8p5mguE0Is9Hi0fxL1Pe9PtVEeIN?= =?utf-8?q?MwZXoEYzvajl31FnIdEqEVupcWem5vNyhP6dFXH9QPTAg7RDEgfe5cU+5Pg85GsxR?= =?utf-8?q?Q8KgWdQ6zREh/zb03/DmHJ9ARIGN5Gx+fyWIkRu1Sd8durx2rLdDbrEQug9wTP1LB?= =?utf-8?q?SdKUewG06Y+nbzSBCP8NTAmS8kvAZTE7vWyIKAavUpdLLYIkM14q2N4P3Aa24EZuM?= =?utf-8?q?TbbLFoOXBMXBMBTmpK5Zfuy2u31Q4ykTQbJxW6KLpbWd6snII96m4fTSPs/HHAE9h?= =?utf-8?q?GoyDCuJCDvk64ImHQZB1jwT1YP8Jmy+Xwh33rtMStCYtIbhXdBo1r3TSukzQbzZrL?= =?utf-8?q?aBWGe06+DAFaN5GNOE/yTOSofIfkr95rj/+4CX2gIm5HGAM3m7AxYm+1mbFwQGd5s?= =?utf-8?q?KHfBAGe1tkaGmOWjhru3ayBzgW0liqJFmkQ7CxmzlMwBaLTCQwoVXzlxmqa0Xi93o?= =?utf-8?q?Di0ecfQFtzwvXB7IxfZebGhK5IG13WgJMULb+HZnQFrnew5UqLFVQwQXAqeSGXJsF?= =?utf-8?q?ZNWrsVoVX0mCs0LOLz4N7L6gY097ldi6jJROKw6Rp9h/+jeDqVs3//igaZPkSCIo5?= =?utf-8?q?1sOVvgzq6/z01yMrRUgh9Q0KjD4gxXKUofXcD4SXu0zUqVAb3PSKSlEQFPkad9QkQ?= =?utf-8?q?qQVN9C51fe7/Vvl6z3+ve9irhL3Ru6tXHA3IQy9wNBLLFUg751DbLtONvTDaTcTch?= =?utf-8?q?ED3+TZ8zXroY7vljgKZzhQllMvvip1lUemJfEz25fVMr+9FffDh7e1ethlAgSuJb3?= =?utf-8?q?bKjRKjhGdxURq6Id9bCcNtukTLv9qN7mpeplgbtAlAYql7pjz2Qkdb99nk1DjDVZm?= =?utf-8?q?kboMXRGnC3g0J4Tr31zMPfri5Aputn4cYOp1PtPVlJBzeXKvmcPQj+iKBUQ0GsgiB?= =?utf-8?q?jv3V3Nlmf27ly6FqBwq9kSjMD8byfHZQQlhdmzLzuW9TXW/dN/g28C4LMsk/wcprU?= =?utf-8?q?sZjzfa1Z1pVZAnSA4KjURaKZdwHgd5+JfPH7ocYEbaSFmCqLZ29XQ+IyvzBOTatFg?= =?utf-8?q?VwBvvBxTferiZQ5wZlfjeNCGPCn8aHyMJAjTKbDvMedeB8LyjSZZl1V6SGtJFuCY7?= =?utf-8?q?4y8pV58czbF4tiwPIux63lgF8NpGecWo3/w1QZCnP468dgLszeUepo3OA0aYsCs8q?= =?utf-8?q?wiZXOu3hzKbc7iCwTnOZCQJwEvwanTgHLATZXeKqhsTK9mNqsccNCqvl4eDoF9F9V?= =?utf-8?q?KiytIbb/ERH7?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb3bd1b4-99e6-482b-9e42-08db8e6f65a9 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:02:10.2669 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0RnKQO+q05Eky2lBYtR+QyVPSWdLtIRNtwQ8yXUP+y5zuOFqgWslZmKEBzwRNHSku3+mmF3zTk/VEK7x6Y5q3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4276 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/alcor.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/alcor.c b/drivers/mmc/host/alcor.c index d01df01d4b4d..42aa43740ba8 100644 --- a/drivers/mmc/host/alcor.c +++ b/drivers/mmc/host/alcor.c @@ -1125,7 +1125,7 @@ static int alcor_pci_sdmmc_drv_probe(struct platform_device *pdev) return ret; } -static int alcor_pci_sdmmc_drv_remove(struct platform_device *pdev) +static void alcor_pci_sdmmc_drv_remove(struct platform_device *pdev) { struct alcor_sdmmc_host *host = dev_get_drvdata(&pdev->dev); struct mmc_host *mmc = mmc_from_priv(host); @@ -1136,8 +1136,6 @@ static int alcor_pci_sdmmc_drv_remove(struct platform_device *pdev) alcor_hw_uninit(host); mmc_remove_host(mmc); mmc_free_host(mmc); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -1177,7 +1175,7 @@ MODULE_DEVICE_TABLE(platform, alcor_pci_sdmmc_ids); static struct platform_driver alcor_pci_sdmmc_driver = { .probe = alcor_pci_sdmmc_drv_probe, - .remove = alcor_pci_sdmmc_drv_remove, + .remove_new = alcor_pci_sdmmc_drv_remove, .id_table = alcor_pci_sdmmc_ids, .driver = { .name = DRV_NAME_ALCOR_PCI_SDMMC, From patchwork Thu Jul 27 07:00:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707388 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CE80C001E0 for ; Thu, 27 Jul 2023 07:07:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233076AbjG0HH0 (ORCPT ); Thu, 27 Jul 2023 03:07:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231361AbjG0HGg (ORCPT ); Thu, 27 Jul 2023 03:06:36 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2091.outbound.protection.outlook.com [40.107.215.91]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA1792D4F; Thu, 27 Jul 2023 00:04:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DNkbUR3uw/2zGpNwd51ncm6P9uPRLCwOHPDWGN26V/CiEYjp01VV5qg4bt2uh91Jz2F5GXQ1Idx2X2o/ID0jKqcQQAvmDkslkBuMGTcpKT6jn5/XoNKPW2zhAmn8eblZMy6d8OFe8UoY+u7jMtGYMLwNJFI3hi5JgcipfOJHmIPbD0QC3Rkz6440agXiVa5r6hp9TvexsvERyR9fcoVCvQ8utK8caIM22Lr5hhhhmOUEOXjEClj9xKtsiGvyCZ26rv6pt5/QVT8CKkiXNuAdVQOxgZXcX86lotGX9qJVpLZ9bG7CCFj1YObUMgewLT9SU68qpaFhn7r8FmjA7doFPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iHKArmtjsh7/y1Aplpgib/ppYsMir3MLAx1CuQ9EKjQ=; b=mwJC9EWYS9DoS3f7h6J8kRSoplv9gjBtU/yVdgF0D/KpEnRpM0sWum0ENdStELoPlnLc3qsXEduOvN16Balz1ucLw+Z7fLTPctPDJdthxmbc3ypB/P8HQ4JgIefFJ2rIbSZXY9VYYJ10o1+4uiMeymvkALY4GRAPlbV/lOKVRYDRr6ViCU7fbBB8r+GIHyHhIYHSY/u8dOx+QtKm/kjddle+i23YLQeVOU+OnPRDv5Y59vf363/z056bQ5tcTzBPLb2TbFqAxbsugAqN4Ux7NarhsbJIU76j8cfBlPLtjYhnvV97MDbwUZ8PU5wjBLwK+MK7k6ErxBDpZtZ/GuoOIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iHKArmtjsh7/y1Aplpgib/ppYsMir3MLAx1CuQ9EKjQ=; b=I7+NvsVgIIfF0xhp3teWQOmx2AqrwEgMHt6jK5sXHMLqRh2O4nAARXqGy/yOi/ScmaFkjVJlk6AZaO4dHTySz4VWIikbdDaCue0qSSguWbpIvV22ePqbcOLCjjmUYu7p+oNSlFmxpUHuelUkDu66blBTsMcFxwUEP66DQSC+7V8L3upvhqu1YbMlcdAwfSRcCwRVELmhmtoBs0xlclC8E8DJsVHXOQSmfOZdqjQ62DKPwXpvjQ3f0y8W2csZMY4lD17ncTu+4l2bge2BUvSe54NLF6FD5CTjdG4sCc2V0JwJpgtVBGU/phWaWStQ8XRKp9Pc3xXt2YiQipr+FtD2yg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB4276.apcprd06.prod.outlook.com (2603:1096:820:78::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:02:39 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:02:39 +0000 From: Yangtao Li To: Jaehoon Chung , Ulf Hansson , Heiko Stuebner Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 41/62] mmc: dw_mmc: rockchip: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:30 +0800 Message-Id: <20230727070051.17778-41-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB4276:EE_ X-MS-Office365-Filtering-Correlation-Id: e8723842-9120-46da-fb2b-08db8e6f66b6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wLinV5srOpqqZU33Ugr6J3sfa0fs1o06ehwMPHlAs5KMFkFQH4OenGd2Eno2hj44vcQq72vg8xYGHPdiAAGxeub2nXkeILYNr/ARg0k7LkBs9zEBN2mIIzCJlsdH5lm+l8uhosnkZwoRQRw9P51DW1CQMvSK5hi0W7jeFp2pQNRuUJQ5Jp9VOeXaORUn/jG6nernblykjHPZdK7YD4E3pYV25wK0rNl/7d8HtZVBNQycaL532Q56uWj2L0nEl2RaWTZ/Ob5/lshd8A4md9Jk7WMg38Dk69yqyb9IX3Hv5OPsYy0CZ06f5JrWbVq098c8YTIGC0+Vz0Kff6hEkwXCOysZjo3v6KDTv5II4q4a8D9vxHPt83ar7gBZs0/5B545p4mVe96ti7T1AEXSmsXKPea8j2nrAMYH4uUj4eSFp9dZSS0xFFQK8YX5ik9vjxHJmo6ErrIAqyH2hnVMFQlsGyfi+/zaTlHYaSLlE5o3D3Wf1z09PO6HLNDS82z/a/1xPoD91H7T/XTnD0HQ+/2VpMNixNeGpAAYWgUu+AI2eXeVwef+HdCVMon5bbQz6HC2PFaHNelDSRrgFYgsb5mjF1dFGD5fkmtFkHPbMjL8crR9fJVGOtzZUIwhMFPKMq7x X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(136003)(366004)(376002)(396003)(346002)(451199021)(6512007)(6666004)(6486002)(52116002)(66946007)(66556008)(4326008)(316002)(54906003)(66476007)(110136005)(478600001)(38100700002)(83380400001)(38350700002)(26005)(186003)(6506007)(1076003)(2616005)(36756003)(2906002)(8936002)(8676002)(5660300002)(86362001)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Cy4PfJDsuAy5IPxWV34CMm161ffd?= =?utf-8?q?85Spr7Dg29h7W3Y8+z9yqEtg9I+Jbfg3UVAt/WYnRZGwjcIiA4HGHYgz4Y1GmqWJB?= =?utf-8?q?Wp0PjSIzCwIKorS1YIpZHa7B1BCjX5l+b/w76ZX1+pXY4UWQygUoPIcd1PesWLWlJ?= =?utf-8?q?Q1qEGjDSnALks8l0m1yKfzcnPkvaUSIiHj8PylYa2/ydlmhtiIYkFyAzQP3X5yB5K?= =?utf-8?q?Th1A44AC9pmTg59Ilqga1S4x0+eirC+nhTe8dVQvWE95Yx9YqfS1Umpw5FGj1mKf6?= =?utf-8?q?2mzCkppXFyqdExpr3zxIHpdZouHSrSUDWrnClDFqYmdCcp/sHsXNn9hNPhbApFjpv?= =?utf-8?q?KapXWmn3L8cUtkNNmyHnfMc/dpbRK9Ztq32i2ay19Uh87QGVW5nKAVZr3T+Fqy2Lh?= =?utf-8?q?0vqzptATyBvmD/wmZAEMVS9fAoDJ8Fz4437Okahy8MJDcWLjyNHlyrGo6RxaaNQe4?= =?utf-8?q?2pOWd4B/h1IggEQOFo9TqxjqjIxrlDyoLm5awSbTMjh87/31ILX2GsC2SKSeXR3RH?= =?utf-8?q?ph9JG6CpIxShaTv5XBMERT3BqTf5SvyK91VIALckqlaUkLrvLAOQLHcQoi7zYEO23?= =?utf-8?q?8THYgDdSUmTWrk9SzGMVUZfGNEIcpw8CTRQZn8X0vPew3Tw+K3N2C5sq8ejQzSNEU?= =?utf-8?q?59EMZbZUreMROB1rGJUC3bqB4mWsmzXHlWbgBe3EvdgG/ucKpoeT7VUWtEXmQMa4Y?= =?utf-8?q?vuYIi1g8jLR9D3TkrpxQ5HUiGzWel+uofcRviGQAurN9iPXvAqPr+KknUwCCXQ9XK?= =?utf-8?q?Ajdtl91tcnXOV2oLilMi9EOb85LEIwKfcVw8aphEebJ6vJO4L4GWhrVxEUYVm1u5U?= =?utf-8?q?DFkB13T+PecVp8YkylUFZ3mO9g0pgmwrr1tI9flMuXDonnXq0kl5AsqipCRxA6i/4?= =?utf-8?q?ZZsGSuWpYwNptKUkEne3xs0CHWov1MXxatc+R23R/oouK80EZBJZjq3Omzp6QFLlS?= =?utf-8?q?+hLce/vvahS5QrGOMdWbgY9YguuDH/f4Xe3zTh7P9iPGo2rjHVv9iopqzfiboVhqu?= =?utf-8?q?sQDW7vDLd49SwgTWYDeNsBgudPkAjUcq6RfEb1zooXbBdS6IIe6Y5JQDkMi0I6fyy?= =?utf-8?q?hYq6ho08xM3IjdJ3AIZ2+LaRcSg/mxfQntR6ZUYQkik7v+pP5rDSsIJFIkwU9s9hA?= =?utf-8?q?bsBwPiTEcRW3vb4xhzQ6AonCKoAINaf0fA3V4arDBFpv3+RHvo6R3fzkcTaXspndG?= =?utf-8?q?wFl6PfcqgV+Ru/UhZCv6GyJ1RF63HH93FsBcHSliVysqEJvDJ4aUrVEq9iqYvDWMF?= =?utf-8?q?qLsRDqv0+7ANDlLqt+GrmYnIIp1BMOm+tL1iQhpjxC0zX0BOfa/OveT+yeVCkoD83?= =?utf-8?q?AjZipMOsT/1TXK93GVsfnBINtgYYYc3JNdHSLJJWFxuLRoKumKnhcUb2SQSQOuuhW?= =?utf-8?q?gZmGnmZ9t9A+aQ8HcYDD/Wk5emUAsBhowx2luqIoCcmmDSIuojawgC1bYr8pk2TI+?= =?utf-8?q?GLtfp2ngrkf0PP0RnE5FFgwNoUqPHMLjRYa54S3udRHM5yTZuhwgJ37OBfLnOrhDf?= =?utf-8?q?FlDK4FIcunQ1?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8723842-9120-46da-fb2b-08db8e6f66b6 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:02:12.0229 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 26g4anAd+SAAekuvTVHAtv4vm6BwI9JrDj2W2abY28EzKuQARV81fVAcfI01Kr+rVSk5NeqWGRsZ0Pj7vSarQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4276 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/dw_mmc-rockchip.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c index 2a99f15f527f..b07190ba4b7a 100644 --- a/drivers/mmc/host/dw_mmc-rockchip.c +++ b/drivers/mmc/host/dw_mmc-rockchip.c @@ -371,15 +371,13 @@ static int dw_mci_rockchip_probe(struct platform_device *pdev) return 0; } -static int dw_mci_rockchip_remove(struct platform_device *pdev) +static void dw_mci_rockchip_remove(struct platform_device *pdev) { pm_runtime_get_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); pm_runtime_put_noidle(&pdev->dev); dw_mci_pltfm_remove(pdev); - - return 0; } static const struct dev_pm_ops dw_mci_rockchip_dev_pm_ops = { @@ -392,7 +390,7 @@ static const struct dev_pm_ops dw_mci_rockchip_dev_pm_ops = { static struct platform_driver dw_mci_rockchip_pltfm_driver = { .probe = dw_mci_rockchip_probe, - .remove = dw_mci_rockchip_remove, + .remove_new = dw_mci_rockchip_remove, .driver = { .name = "dwmmc_rockchip", .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Thu Jul 27 07:00:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707386 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1AA5C04E69 for ; Thu, 27 Jul 2023 07:07:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231890AbjG0HHp (ORCPT ); Thu, 27 Jul 2023 03:07:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230497AbjG0HGv (ORCPT ); Thu, 27 Jul 2023 03:06:51 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2136.outbound.protection.outlook.com [40.107.255.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 929FA4216; Thu, 27 Jul 2023 00:04:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BJtNqUind90S16XBXmX5DsM88OebyBK3UkTgXugCG/NyXrClNDnALRjslaV9Sh/221/i8M3hvzMJ0VE5CZGYiSba2q2MLnCtnbifrJpw64EalIWjJwO8QXVOcS95hvBg0D9MxYjgrdgw92YD+cj+lz7xGhduCQajlpJgjHe679PKd0F0YX0Cl7Dwv0fvFvodsyXre62s7SLVmbKUb2GtpakDUtuCs7eIQEcJMWHtuDUofsdIm3aqGnmUjyZMe6p7JdnGatImZwcnFBT040QjpxTiZUbp2mrCd1eXtJzCgFjoAwP6vE2AgdDCHMWB8H4CAW/vGdqMWERxV8eP8z/4LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sc43eVj8D+jXjv+UOKZmNNsyrS57jCHl9PeQXr9Ahyc=; b=HcaVCda5kOjsTYdmxEO31kkNRrQ8MrBQHyn/kt6f33tgBSjZANQX04swiZQ45BQhAT5K7W69BXBHxDahM7GRF9gun0RnyOgJiGdpjJLTNpRap4+0KqIu0vndIbQ8Ygjpbhujac0VDfPR3uAm3Z5KzMRJKbCDAApIYgc20TSkdSCFqUu6fJhLqF+tuo8XtiOJrhJz6G5UWjCoq0gpCf1XeBZ6x0/jSery1PVwpn584pqaRx6K2TPR8h7iS8hLFuQ6I3etkoFQfHO1s1gC1aLcHyB0p+bpBPetCfxPyJAk6uE0R0PTpLzsKIf3gzfdolRK+doSbxMWekBD7+cq3wrr/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sc43eVj8D+jXjv+UOKZmNNsyrS57jCHl9PeQXr9Ahyc=; b=S3kXDDXNkqsSUL79sO70cZxKvaSy+d1+OxhWnn5hmeIz2Wl0AF1bxE/B/IcUC+YdA69X54xzuBVOGPuNIWtVjpaOgvtlcbyfNSrO64yp/mZ1Yi/PoX5qp1gjVk4WlZ0qtF0SuDPz1Xn8+60lcqu6k6prhOF0TAyMH4glSiHxulIlXi+JazF8eTS46pJuES60TyDF/VZ7qFp+ycXU3uIy2K0m14X6YWLPHskk4Zw8usfOvwb1S3UIwIOosyWzmmndtXw6SHWB08o7uRSlI1uKeGEnEWmzwsnqScdXfjkoUzm6bxP2xWDOq83YioQ6+BWU90+JzM8zoXQNvPT12Dt+Pw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by KL1PR0601MB4276.apcprd06.prod.outlook.com (2603:1096:820:78::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:02:40 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:02:40 +0000 From: Yangtao Li To: Pierre Ossman , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 43/62] mmc: wbsd: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:32 +0800 Message-Id: <20230727070051.17778-43-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|KL1PR0601MB4276:EE_ X-MS-Office365-Filtering-Correlation-Id: 49d1e544-941d-4c83-a5dc-08db8e6f689f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0k4UTof/FV7/J4v8u27VAPpxLVC+g8+ExehW/Nu9xK3nL10yvey9e/i2gncg3eP3d1L1l7FJv5hJEsJ6OUlGLoUvg659pw5MwLwCIWFRSWJ/OZbeJSVGkwRVa06j3ubtD8bnepU5zWNfAQwrlv2vLDARIm8I8du3jAlo38Kf95KrFpHtdQrNMcb9+bD/jpvJjrbWGwgvpt8oTlOjDFU+r+yQeWwrdkPdPCNNxjMyV7CzgRoHVg4HjPvKEubUzrfR8ot6ruaUjMphYP+7QG8FIoL5DZjhA9LjLyAaa/ohK+SJH0rvQ++qpBoL5ZfmoHDUuM3nJ+TLNQccuE8eiFw4y5aiS0bH6DWLHDdem+lySZWHHRZhuLjqqermgipuIIHoHI1qzyJxcRne5Z+eeqe/GJ6c3gM3t3KPQxmVcz9nnLHq5UhrC4P8Pv4yFES4GvrtWbxTWhWy+n8nwKPI068vI1yIPPkVAMdSUrvDkSPdHSTMKD4Kjeqzi3vwa1gUblo9kSBmJrwj+s8uRT1Iq5cBMSAdz37c5eT5FQ31HQZXTpHdkxf64g5npXauqU1fiz8cBZEZqkZEMhFYn4PtEwuo5xtyL1/BYQ46ZpXuOkapoLqQpFO9pxJ5aenq/uxKY3Wg X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(136003)(366004)(376002)(396003)(346002)(451199021)(6512007)(6666004)(6486002)(52116002)(66946007)(66556008)(4326008)(316002)(54906003)(66476007)(110136005)(478600001)(38100700002)(83380400001)(38350700002)(26005)(66574015)(186003)(6506007)(1076003)(2616005)(36756003)(2906002)(8936002)(8676002)(5660300002)(86362001)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?WwK8P82w1uB97lTo7AEGxWwNlI1O?= =?utf-8?q?cn54WJAUH45fRVCbmpNbnkM7/6bnTHXDhzjkWHAAgEr1or6fpy6d8LjgenoH97HmF?= =?utf-8?q?fuzcEhWkZemv7/NWTm5RN53QeEjnBJEpOJW5dH7oC6euQpuoA16i6ETE4+E0vRZLg?= =?utf-8?q?Jo5QAfVO2i4WeoEEwcgpNwY5TA36uBu5Gs7vqWpMSjT7zstogoH9QEkdhnJ//MgkE?= =?utf-8?q?7cjAi9cJ7+ITP7J+cPksy9T+Mse8oOfC61z68CSHUCBoTCyyHevXrzFBEnKwkVZ/k?= =?utf-8?q?hSaL5xU7AGbIq+ZfPGpkoTFESAs8GTn1BMCjCoc0xSXbbOfASOlit4g+TED9usZZm?= =?utf-8?q?6ykGkqZFc2Ohzx9kkDrTyJ4WY+qe789HhdDj1TjXo4y/pzi6WP8OGNHOF9r25ENni?= =?utf-8?q?Cql+ffiTcorhJgBpF3OMGp6rl9Emh68okh8YxtLIE3hsv/7BBMK5RdrHmrd1+8yt6?= =?utf-8?q?foqBX6ZxSyBP+s0Ghkk4sHOxg5C2vz+Ix22DA83amQHW0+VkKHhBaBT57rELdsm1J?= =?utf-8?q?plwakPQPL4KBF5WvF9ZNTmToUYSf9w14GT+9bGAkVtZc/ZRUNFMw1tTThJ4Ehz6Yg?= =?utf-8?q?Emg2bbZoq3hVfkNm+TIUuphwM8wkKZf1lwIEEA3XcfYUfPmCzhlMQkPQcHSvB3Qng?= =?utf-8?q?gid6u/+XJVPFjOiLZdeGg2/oMP7Kgy4+Zz4GrG8NEEzBx6gVZkC5jEWBP6ulmO1Or?= =?utf-8?q?ephV4B5vR//oHvIdnoN7pmPg/6a5nRKmXzkogMNVGY6dv27gOnDsFTiBDPH4cXX0Y?= =?utf-8?q?hG7JfNOvgYVGT8FyVp2sC04HvHwmWxcjEDiI3HRv03Cl6Ob0JT9sc7NjBvae0AYZt?= =?utf-8?q?3OIyBb+C2+k/qp7LpQUdmqisWokh+mPtp+GYFcxQjEc5bG0PCFiWCOUGTAsK0bX8O?= =?utf-8?q?agqaJmP+EfYWnryeIctWo6Pww8mYkszFE+XXzMtex+WwofY6iqmaR0h8NPofaCKEE?= =?utf-8?q?yJFduu7FG4bKYqrv6HXOj5daGYTV9FJKMNXoEj0qdGqg6AuZiurs2tU8RH5vNZYMW?= =?utf-8?q?8LGE6lMKB9WWxbtji6H3iiLKCvap7DCfa05f01/WaLpx/XrBgdCxIpWgQ36MDJDZ6?= =?utf-8?q?ievqKLXD/Cl5ywfpqPf6s1XidFVRQw3tFrzNgc1bqMz02p39VsflvSYd1FZgGxf7i?= =?utf-8?q?LmI+eC1hpcNVjYMcRtviR+NsVqoh6SpKGnZlCTskATFj0HuBk5OkYwo+hd97usH1c?= =?utf-8?q?4wUEwH+VQZ1z1Yz5dls/iU3T8ERvPlnEnefeadhyo1IH7bL0+03koZC/c/ax8MSGU?= =?utf-8?q?oF6/hxErc1dexzcfope95paAijAcvDPfd9+zPJb6eIh+MVEh9Y6Siy5BwIkSxF963?= =?utf-8?q?/iHBr7g1/2+U2Ewdbk6Eert1U0V9AzK5GQBUmvcmvHC+nPN0l/+esKkwgaH4UzNJA?= =?utf-8?q?SOndRld5u+mHWZiwMBqOu7HYi/w79iNlh67JZxiVqsnyUdRcHi8Sib/LCzcJMLkI0?= =?utf-8?q?uW0mg67a+9XkRjPh2w/jeQ+RUfjo+5V09mE+F/U+cj+GQpYZBpiitAlp7eqqIlSkL?= =?utf-8?q?HurTdmU+rEcS?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49d1e544-941d-4c83-a5dc-08db8e6f689f X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:02:15.2309 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kbU8b6XzLNNYzcCd99/8B9sO5CvMZOE6gSop6bxSVMelOckqbob1R1tVYnhwtzq0azby8N7bueZDjZrWBgkndQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4276 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/wbsd.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/wbsd.c b/drivers/mmc/host/wbsd.c index 521af9251f33..f361cefcee01 100644 --- a/drivers/mmc/host/wbsd.c +++ b/drivers/mmc/host/wbsd.c @@ -1758,11 +1758,9 @@ static int wbsd_probe(struct platform_device *dev) return wbsd_init(&dev->dev, param_io, param_irq, param_dma, 0); } -static int wbsd_remove(struct platform_device *dev) +static void wbsd_remove(struct platform_device *dev) { wbsd_shutdown(&dev->dev, 0); - - return 0; } /* @@ -1904,8 +1902,7 @@ static struct platform_device *wbsd_device; static struct platform_driver wbsd_driver = { .probe = wbsd_probe, - .remove = wbsd_remove, - + .remove_new = wbsd_remove, .suspend = wbsd_platform_suspend, .resume = wbsd_platform_resume, .driver = { From patchwork Thu Jul 27 07:00:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707385 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5464EC001E0 for ; Thu, 27 Jul 2023 07:08:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230238AbjG0HI3 (ORCPT ); Thu, 27 Jul 2023 03:08:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231661AbjG0HHN (ORCPT ); Thu, 27 Jul 2023 03:07:13 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on20725.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::725]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC37C468B; Thu, 27 Jul 2023 00:04:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P0VC2JSKZMuMeKx/F6NU++nG214tV5/zro1CnIm7dL2OU8/kdJq/wIs9J5vafHVTw4VU5bwH7CnNfiLXCAmcHMnYSZOX72zmYYOFoMZZg+TcyP1DD7rJSAeg8L9iXuUUtXwn9PmEMaHk+ITCT+bUZZPZ0Nrk2OORv5dcp51cLseSjM2wa0b25nn6HUJQ6kLWuuoQVk91jCW16JXZe+z0/RvZGEWjCo8jZ240pzBvF6z/T3Feng8t3JU+uwQa+9YLajB4bwS0h1BpwCKfTxlApwFqvPdFuSGoXvzgKIDJWbo+9l/bj83WlnI+lPVxkVhQcbxzPaE1vc72l2Ch+TgBNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qi3BsQ5K6HMVxVVaKmclXYMikJ6itGQu0ZOMQX+rjdE=; b=aQIKWjyznAFrZJ1F1kavvTH4qrOpRnjskoRk42lUdiRovGiHSYIuDpAtBItewX870b0Jc4PSXQo3o/hDayEqlQluneYQ7P3yeImH1dnQOACMz3fJIN9BhbKK4XtNQeBM/5keLu7WNuPCLoP0RJwF+oZRzItpmSDbcuORKxXrCzwsBoietxBttyXzG9/YBS/8phAdlHOXz5I2G5h0EZdIIXRqxd6Yr0mbtYH8tndQCxCg0JU2UtBTejzuIzvA/0q+StLyH071lN5z93S8WWRfXbmTUYecICfdoS6QXWD53KooUtbwI0v+7SUrA55nJhlc4u64ueKkQ82TwctrkjsC9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qi3BsQ5K6HMVxVVaKmclXYMikJ6itGQu0ZOMQX+rjdE=; b=S+kUvWkgsUcfQBimio+7thiVFGCBtNRZaJvKOZFFTxzv+Nh3sHDnOs3+EQlY3CHL9NrGjWvAVz1Y5/b6sLcmWAlCsgzId5vN+LRR8JaSwYRoPq5fLgmAdaE9WkrxK5CiTl5rW+jx/gWsIv4Pa1Ed0xZwff8J1uUP67IG0BMR+KMc6qr2ftQNv5opMHWUWgGg1K07kZRmwMewZDQ5QkpVQC4kG4je5kuvAGtxBw0/XnoFGcQcjaOM9DnFPuWDg9aZMrevBvzEwsr7btDag01H7neSkKiMYLjCzKsEZL0e4NavNIoGbVmnwf653ikLp6vZ0HcFfRzn/DGFU3ACgWvB1Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SEZPR06MB6644.apcprd06.prod.outlook.com (2603:1096:101:181::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Thu, 27 Jul 2023 07:02:43 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:02:43 +0000 From: Yangtao Li To: Angelo Dureghello , Adrian Hunter , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 48/62] mmc: sdhci-esdhc-mcf: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:37 +0800 Message-Id: <20230727070051.17778-48-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SEZPR06MB6644:EE_ X-MS-Office365-Filtering-Correlation-Id: 89a6310f-b0f6-482f-c96a-08db8e6f6db2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zZJNecrEJYWQ+v0H+c9ZEG3vuaV60lIPxCfPe9DwVgox4nHSpDu3cQdgqWV9BFTCIQgkpHGVyxj3eNf3/7IQsIAkLdjQB5aLC8qcxhTD15bRAwDvojbEwFFkGrvfpAEoGuJI5XxfP/3H8dQw3bp42iBuGKBLKbwL+GjCkqUiqnkVZsi9rdqPy4NPJih6VVIWyIuI6/WHtHzcrFFzBSFB1qqfxgau0dyxfnPrfzkDhAx/BecEMXRStyQxTcW+pTj5+wKC/385xsgzXdZklvMuEPNcujxvSqVmkqbxgVu41Qakh1XuWPiDB9npmiIRY9Z0GCJa9ZiUk2It0BE3G5TkvDgm4GKSypxRV5XgimIB9OsCGqR/b+wXU+qKW1uDZ11EtqwIHPYgtrCtA0rYhOUrWWOq9epIGzb6Acw2saG4gUHqEJRvmOFNrbr/5TvdO1TnK9HIN+au8ZMrVzrldX0oZzh2wWzgrI0V2W8Omq5FmwLxAEZpSLe+xrkAEoR8ObPvfTjcDLRKS0SsrLSmgvsOM+rUs1zbYXG1lPeKxEc0HPNo9+ruyGqaQAsf8sAXR/3xJEQ4u0A3T6pJxhO9eVzjnspVtBnz1flq18y0JxamUxEq2Pqr40WZzSj42je8SSBs X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(396003)(376002)(136003)(346002)(366004)(451199021)(6506007)(1076003)(26005)(186003)(54906003)(478600001)(6666004)(110136005)(6486002)(6512007)(52116002)(36756003)(83380400001)(2616005)(66946007)(8676002)(2906002)(5660300002)(8936002)(38350700002)(66476007)(4326008)(86362001)(66556008)(316002)(38100700002)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?qgKeD3fWpswqh0ivv895aXysTgUM?= =?utf-8?q?nY78tuLDDlquwcd7uTRIkfA641xiz0DQxj37o5cc5NYM87wVfwx1bDlVllNQfyslH?= =?utf-8?q?hFt3P4h4KnTwQNdBJ/bVXjM/k0ZBfshDUxArm9ilj+UYUV1tyRncIEOANuOPV2fhm?= =?utf-8?q?q2LPfCCqjGEnb7mMsvoklVtTU3d6gfWY1aUvwpKmqR60sKy1rSDlSPnBo1e/59aRR?= =?utf-8?q?gEfTpuRj7/d7KywLmiQmo56Ty1jBYUdVrD4gZ1oaXXM043dmLT6nvuwrhA3ijan5g?= =?utf-8?q?H+JPUxc4sjAqhA1xfVlLw6kcuUX/thc2/AGIz+9JEOO4fX7TjHQAShqh9VdYteVFZ?= =?utf-8?q?G6a/LLq1rKAFoRcDhdxFnhRJtFWFqHos6z1rsktE7NgAT7B98UyWNojnv8dUbhqkD?= =?utf-8?q?rVZavQmjg2psVr9YJP6EoHjbvJ+spP16G0GWAFkErgKNnojSadAoIZ6chxmdxDVc/?= =?utf-8?q?vVpP2KYOHkOjb4aoSNXuMJZMJdSXXwwDnzsss/HVJpP8+KGG+KL745YOCFNlire3y?= =?utf-8?q?QDVTk8sdg7jtquUTIBahn+o3jz4NTS8YeQnkth7j4BRK1DXdhWDbzVCrnFO5sUi8D?= =?utf-8?q?RvY7qv2IGzEOG1IeskDhwucGmHHT9RrRfHO6YjhIwqoPIVmy4ioD6lagwR1k/oBXJ?= =?utf-8?q?ms+JTqpFTsNbk/y3/v7035n1J2cgpH5lP3PyKWFXGbUBaypJC9kws8dBVl0KnGFJ6?= =?utf-8?q?mdkKD/uSg81PQBOLo+jGJasG2m9MMbyH+tcDK97+XOFVlbP1NYoZ/QaaMea7HJ3qh?= =?utf-8?q?5PCLlzr/0AAp5bFMU00JhGupjS+IdpMjYpppIB4DKkF3fkitwrMtrnRFEKnFa5abI?= =?utf-8?q?8bkRnwYmfzDSohmp9OECuYw8JB9j2TkN3qmyJrqLTNpoovSRqbuqSabnCnwy0yaqX?= =?utf-8?q?jqjdJPfLeBwUXgX+ztRFcaXL/UByKFCZLVW3pJo3QC1ZPBbEmQSXRQNr3OR46V3rK?= =?utf-8?q?nxRwU2o48kCIoCKibM/YCfNCJvEdOgJgo7X50N8tG2XSgvuRobAAEZ8Xf97iydVbK?= =?utf-8?q?QZMCrAE3iQWE7r0bn+Rx5Niuo/keUXcsSqWx4W5ntKsKUCndwWnyzQUm7kH5TolPs?= =?utf-8?q?g4P1rbuqiGmmGacGC3wghcn3rzE2NJNAKtsjU2DTKDLKXLG4nyTHYen4vzs8TrJqm?= =?utf-8?q?fAJqYkXbBMCCNTYKjBtwkyXS8mmJZO8s8iVjwxx9M/4a6UmGuJ4uanEHcvRh2X+uZ?= =?utf-8?q?akxEVwVNo0Mq1JZrEDIRol+yOCCtVTZc32nlwzUc+N1NzpQh3ZgQnx7af1d5psi77?= =?utf-8?q?YBrD8e0c8KaV7/j9GOu/s4a38FJR/+RSOEktxVl4a/LsrpXU/8GZb+TBusHZ2gpRn?= =?utf-8?q?nkDfnUpXGhkya8k/WCbMrSRUCBhu90B/a9Uja3AarBiaTawKCqyOIcCRkFZLHU/nc?= =?utf-8?q?1iw8EYtPALJt6cgD26zfY10dpSH7N0t6TcoDKUP9oDdngdq9zXtoiyn3ZbLyCuES4?= =?utf-8?q?736ohnGrvWLNUf3Dd9R8EHbZTsn4b/qtFB2IJ4h5YSH2/nO1swk68F20K+DRvK/LY?= =?utf-8?q?YVGW3vGlpR0C?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 89a6310f-b0f6-482f-c96a-08db8e6f6db2 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:02:23.7631 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l6qZtsKcX/P9EELv9oY++AMTPNF7ymWakIX0YNSh0fnZiqJA+zeazMdrkmuCgGqTLeMa11PszLRpzJgisnGC3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6644 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Acked-by: Angelo Dureghello Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-esdhc-mcf.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-esdhc-mcf.c b/drivers/mmc/host/sdhci-esdhc-mcf.c index 05926bf5ecf9..a07f8333cd6b 100644 --- a/drivers/mmc/host/sdhci-esdhc-mcf.c +++ b/drivers/mmc/host/sdhci-esdhc-mcf.c @@ -489,7 +489,7 @@ static int sdhci_esdhc_mcf_probe(struct platform_device *pdev) return err; } -static int sdhci_esdhc_mcf_remove(struct platform_device *pdev) +static void sdhci_esdhc_mcf_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); @@ -502,8 +502,6 @@ static int sdhci_esdhc_mcf_remove(struct platform_device *pdev) clk_disable_unprepare(mcf_data->clk_per); sdhci_pltfm_free(pdev); - - return 0; } static struct platform_driver sdhci_esdhc_mcf_driver = { @@ -512,7 +510,7 @@ static struct platform_driver sdhci_esdhc_mcf_driver = { .probe_type = PROBE_PREFER_ASYNCHRONOUS, }, .probe = sdhci_esdhc_mcf_probe, - .remove = sdhci_esdhc_mcf_remove, + .remove_new = sdhci_esdhc_mcf_remove, }; module_platform_driver(sdhci_esdhc_mcf_driver); From patchwork Thu Jul 27 07:00:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707395 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93FFAC0015E for ; Thu, 27 Jul 2023 07:06:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230480AbjG0HF6 (ORCPT ); Thu, 27 Jul 2023 03:05:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233050AbjG0HEv (ORCPT ); Thu, 27 Jul 2023 03:04:51 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on20725.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::725]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F8923AA5; Thu, 27 Jul 2023 00:03:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kQYhB4tsjPc9HPdaHuHpmIx6o0x10O/8xvLIiC0xJMs951rX6v0+shLqXL+IjyQLmBryHGG51fZYnGVprYXVybVsarmCtlLnt8DAvK7G/Jngtere3n0tS6DwDMTp0n64J7aZC/FYXQ65+b+f2yxJjrbsKBO+yJ7JD6XvnFKuGoDc1I2JyezYHBUZYPZhe/m6/fww91cc8Pd2yspNegfek4jCnuz5Xpe5CGUox/4k95Ge3Zv518rT22lyR/kvABhjc9P1CajKa3WBPxB1DLZyhlv2TXalCjB6MPbBFlhEpFdk+8qEgcGiKO0vwP5x9pCg4y9B97itaTyJMGGgCFm3jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FXZpNO+3dmb0lnQ8WXsQM3rNh0ZF61gf7J5F6UfMTHc=; b=Mm1hh4DG49UzQGFE5yPO6cUP0WuUqvtmswJWwzHecWIKzQ1vUDcQTu8CL6jzvFbczd5ttiWyuWfhhbixA1sVBMuym0iPxp+cJAmGnWKLk/prVjWfBy6/U26oOIgXsaBD8Yd0k7g+RC3Mhn3dHQ4taM9WWnhLBU6hi2GbjbHgfWT9HqBOJESaMWRbrIeFe6jT0t0olioP/jtHRs6W7jjNWJuooQ19AuIb+ODtX29A3H4QC5Ux/zjFFe7dSOG0zZ3DO/4ItlqB7ebbSBpT1y41PlM7mFbxRdRRDbFOiwIThwfWsYrvaOwDgMGEorxGFtLPoUErjuz04fKClgF8xPrQTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FXZpNO+3dmb0lnQ8WXsQM3rNh0ZF61gf7J5F6UfMTHc=; b=jB7EGA3+6DdO+UuEIO+yCElpuv1WdFo4D6AkgNZUH+7GgjDSrmQpYYgW5V9rk3lQd020qjulIo1S3THzyF/sZ9FlOY+rWSqVFpyfECAcSPtgDv2l4B/dCIU52cd+/Goo4AZ2BQ7GH3RPYaWpjx1v2c+Kra4l3xN4dzYN4OEPyhn9gdxFoUDACj+iYiud+CHtAZ12Vir4jwHuC3tN93rlYHhVKEjESuFEQrNKrbOqmcW9jQEW4ZBoRmPrJoLr0jWBFbyKdTVeanMciiIZkec4xJcOlXEPuVnScSb99lki+Tu8SNLa9drxmjGrTl7FnhFPCAMzYpSMao6NaCPBo/NmLA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SEZPR06MB6644.apcprd06.prod.outlook.com (2603:1096:101:181::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Thu, 27 Jul 2023 07:02:43 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:02:43 +0000 From: Yangtao Li To: Tony Huang , Li-hao Kuo , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 49/62] mmc: sunplus-mmc: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:38 +0800 Message-Id: <20230727070051.17778-49-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SEZPR06MB6644:EE_ X-MS-Office365-Filtering-Correlation-Id: 28f76511-c70a-4270-2938-08db8e6f6ea1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m9XUME3szuqM09seQbNp5zr18IQqDqJKjwRN4mCSfFmXd1vDNQsFvF01Cg1VJJsgse9xFp/RWrolBJrIBzdYlFvJ2GvHlr69pc732zqWYSFCBgogpv7G5JGQmKnHcoHsBcJkEtmxbc6OudclXWF6Dv27m8HwdifVIhLnvF6ANSBMbG99mX1w0S/JD70UWiGpTwfaxV5JEzPcv85dVyaAPuW8Upq+eRgcgTiqck62/Dy6WV0wbHqeNvz9ra/73Z6nrwCZgk6+5rDn2fauAHXBPYI8c4uUrueaDmebUJTdKWbLoRO+7R3Bn3BMiVOTyftWmfQoLCgMOrqOWhboc2y92oznxDDudDVhwzc3jCa/3fYonHV0Rw1SmfW4WXQ+fajnHs2A/jeCi5Ry2PUDrpgUKTtz3oFdHW1PKziAPHobPOVgefYzkMaEfY+gVRGgjODWgEu1ldU/BchgDmttm3EWFKT9Ndr4dIPE1tCwCMefo4yIQ9kF38UBgWGr1AQzkQ1bSBoBW3C3EuO1j9tX1bF3BH8fiw3hkI0mvm0jljlESMEhh1TmNMLd1ENnRCtAn093S5uJR0QXugTYuce1P0dz8MX8sWmpQHPD66lnwnrjT9YhPY1VticvALS2C+xhtI5V X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(396003)(376002)(136003)(346002)(366004)(451199021)(6506007)(1076003)(26005)(186003)(54906003)(478600001)(6666004)(110136005)(6486002)(6512007)(52116002)(36756003)(83380400001)(2616005)(66574015)(66946007)(8676002)(2906002)(5660300002)(8936002)(38350700002)(66476007)(4326008)(86362001)(66556008)(316002)(38100700002)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?w+tJF83Q9q7dMxx/3uZKC6bTEpFs?= =?utf-8?q?P4HgitphH8PkEMKO7wp83Vu7qbhv2K+Fot35w5tl0+cXxQoUqoLPV1axkAYxyzA37?= =?utf-8?q?rrmEyUcVILpuwIIMsDD05fHS0i/zoa4OyelmwHVLGAZ1HklBrSGyztA5EVSt0u+fX?= =?utf-8?q?zUJqcX91BarebLa+f8Putn85rX1wGeEhbA6mk7Pi5WN6+JFQ8o64GAGjsAu+PulId?= =?utf-8?q?sF5LaFr/OgRqn3jxXbo9NO3OYQkyy6IMbmjXPCTHddK98V2YCVGvmTNLTRfwEmjHv?= =?utf-8?q?99exPH840BYNHUOHR9+7pzh3g0VPVLN0+cRj55QnIU2w2FSq4Ps5T1d7TPnLIfkDb?= =?utf-8?q?/a+WVLJhRQezeAJn2On9FVcwAGcaTaKM0/TX3fVvACOrCMf9I8rRC4VP9v1HCdx2a?= =?utf-8?q?NYN+StI4NpzqdLdD7IFd7j874M10z1a48QIGXpKoNGrtJxANPHwZGwLM5gnFoazPn?= =?utf-8?q?TTvOYHy+F+yQUJMBipfve/y7T9l1AbWsG9eWztfFicYKXc5q7ecNvh0TIrEQZpF91?= =?utf-8?q?iZ1jjLO0bBBszSr5QJSeaifs9hWsFyr0Nn4sdYYU0bVbtswIhZEmNuhpll8+LQm3r?= =?utf-8?q?Az8tgO1mWRsIkXk/HA9fa+sNwOzncUpoIKeebr3x/RniXjUVyZndqoQfBO8NCXXPP?= =?utf-8?q?c0UExUS6AMMCRN7aTMadX8AId/YRC7bO255hl5mtFqa93QUrg2J4RGKShG/dzZUYt?= =?utf-8?q?4Z9Q/OORzZCgjtpBKa+MTz10OdJzOkteIQ1Ez8Poj5mgqqrilF/38uAQJIZqpzm8g?= =?utf-8?q?MqNsi3LMxizX+VRQv/dq50J+9mILhwk9ks/5bM/Ai0GDYwUnzQ0O8CRpbzDTgfmWQ?= =?utf-8?q?LBESl4TIm/cY6cF2CzbSbSdULpUK2uOnr/Blz9b7wES17zWazudQxir43HTSJo4WU?= =?utf-8?q?LFTk3FQgGQ+d7FCRs5w8/M3R1GbDCzkNJCrDEcqo6qqUjeYbUEfd8h9jA89ghcdTL?= =?utf-8?q?r1SGwm5GM0J7eAJAPMnvmKoeAfdVowiiZ/QAjj/0AJQvENM9+Fv8E17u45KW7Ssnx?= =?utf-8?q?Qcn93d1AUTRUniEJVWTZUvO+QzSlWFSvsGwD3qYmRRhk3mIMYngEzC+GwbhHh4WlV?= =?utf-8?q?11BrEij0CB7PchV0D2nYk1XxMc3SkhL04drGOs4/JelFQ5csbrvtIFNaOzxR34b5y?= =?utf-8?q?WeXmrFD2jxJvkN+7cu7WYYzUh9jPmNxHecHAdXAJGV6yc23Q2FwoDaCw25kqMuD56?= =?utf-8?q?jPrcsUkqBD+qiVmNzXCOLCV/kMMVi31hVRBozor1x5nokH31zauLSsXfhjldm8KlK?= =?utf-8?q?gYlmXIJw2ZZhs4nufIxxtybJwFQpWZcapGyDeLt4x3UXg7AB+lXJt0W9iWF/0e9hC?= =?utf-8?q?aC9lbvAsB4zXINLBC2kBHdtUQY/ACCGPmflwtIm7XWGvEcveqGW0KwylrNIAUhnY1?= =?utf-8?q?ZPXALnrkBY8PL5mKOKclHuYn72mteYHVUsKVIdm7baRFWBbg4cRVJ4eW3bzR/mUcs?= =?utf-8?q?ouT/bwHjnoxDMiviaRF68SPACmrd4EAuJsCeSC2Sjc9AIaJj3bwBHiP/8wZfbi9YA?= =?utf-8?q?QEp5C9tI+0wN?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28f76511-c70a-4270-2938-08db8e6f6ea1 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:02:25.2964 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jE0FBfdW1sZ9P3UAMt92hos8nO00lyTGfn5acWmdggWgK16/3peod/ZMGQyXc0W4DQseexsX5+vWCmgZKQ411A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6644 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/sunplus-mmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sunplus-mmc.c b/drivers/mmc/host/sunplus-mmc.c index a55a87f64d2a..2f30a683a17f 100644 --- a/drivers/mmc/host/sunplus-mmc.c +++ b/drivers/mmc/host/sunplus-mmc.c @@ -946,7 +946,7 @@ static int spmmc_drv_probe(struct platform_device *pdev) return ret; } -static int spmmc_drv_remove(struct platform_device *dev) +static void spmmc_drv_remove(struct platform_device *dev) { struct spmmc_host *host = platform_get_drvdata(dev); @@ -957,8 +957,6 @@ static int spmmc_drv_remove(struct platform_device *dev) pm_runtime_disable(&dev->dev); platform_set_drvdata(dev, NULL); mmc_free_host(host->mmc); - - return 0; } static int spmmc_pm_runtime_suspend(struct device *dev) @@ -993,7 +991,7 @@ MODULE_DEVICE_TABLE(of, spmmc_of_table); static struct platform_driver spmmc_driver = { .probe = spmmc_drv_probe, - .remove = spmmc_drv_remove, + .remove_new = spmmc_drv_remove, .driver = { .name = "spmmc", .pm = pm_ptr(&spmmc_pm_ops), From patchwork Thu Jul 27 07:00:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707380 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35FCBC0015E for ; Thu, 27 Jul 2023 07:10:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233134AbjG0HKR (ORCPT ); Thu, 27 Jul 2023 03:10:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233140AbjG0HJU (ORCPT ); Thu, 27 Jul 2023 03:09:20 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2136.outbound.protection.outlook.com [40.107.215.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 185D74C1D; Thu, 27 Jul 2023 00:05:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FvkHurdC6Bsf/dlmd8nGKveZU5XNdV6VtQOUpSBlt0yVzq1nDJYVt2CK4jvMckCmhKi3I2QSkxBtHJQvKqAMfDF0uf6udYa8Juj0ehm5Oq+197GVuoYvRg7osX3ktlreHW/LaFfcrDyv6QM2dWBZAh90Zr67SS56wPs+N54o3/a3xDZkDwe18eIohsEwfqjWsEhto2M8qAob+0JpXTAqj2PcKt2QCejzrmj7PVyxxUMBAtIXb25Dkv7OTGkhmhxy+E7tvJ1eRxjj6VNLwBPPHRcZ2KDxVwjyrEWSK3sd4n0b0q5tyJhbFHnl1eqkRbkv24eWs6+afkkMEjK5a5pTew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/w/6Fs9xKHR+EexM64kh9CpY/b+Wy9xMwnRnCjo2yD8=; b=UeV6l2Q9wdJTzmLcuiyEOSUfUHghSk7kUm/sVr0NNODBXvkC0XcEPY8Ry61kD9tWSi4kQ29WqeR0Adzdut1pk0X1erciFstxZh8eau4cGMeuDGE/seqC18OdyFScSfWSdUHmacIBtezkJ3Qq/M2dZiNU137/PTmbLwvIPgAGjWYazzY0KwX7dxMwWjj2CGZK57+iClDFeQ3ZYj4A0ZBHwrnUplP6zByx5ewJK9X0DDx11v+s59EiawBSBzfRJSxSZ5eEzdqf2ZqWeAlWVhvcEe54ue0l6rI7hiN4cko1fbmd7BVWkY38blsi5fsmq1ic5BQjh4TFj22epaVK9ZGhTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/w/6Fs9xKHR+EexM64kh9CpY/b+Wy9xMwnRnCjo2yD8=; b=MFFJfyPotjjQxf3vBJS1sL4JzAC/ZnDfPvPaA6rlZ5HO/I77iadavi7hfHqGrJkTGpa6muhfa7jyKnM8zCCzjvh2e2W7bMbnVTaKtkiy4ytqiMtPXMywKpeWG/nCp5xv2zeSiCGJ5OEGk9XTfTzog4aI2eeGubKDYTOxV9Sc/eHuNdiFWcqVw1S+2sWEsSnUb23UVFcD+yKXXItl0svQfSwhZn58Z0haPHTEathdPetAeN95h1t/EipFIOQOttRhzS9/q/N5m0vl1IuLUHilFsg03md26PGPVHZ0UB4UkiFut6pJG/lbORmCIcAP+lpamSGa/bJGBwlB/ABq/vKu3w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SEZPR06MB6644.apcprd06.prod.outlook.com (2603:1096:101:181::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Thu, 27 Jul 2023 07:02:44 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:02:44 +0000 From: Yangtao Li To: Adrian Hunter , Viresh Kumar , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Viresh Kumar , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 50/62] mmc: sdhci-spear: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:39 +0800 Message-Id: <20230727070051.17778-50-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SEZPR06MB6644:EE_ X-MS-Office365-Filtering-Correlation-Id: c7819afd-98f6-4992-d65a-08db8e6f6f9d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZAMJNADZb4w7SVadaLBU8cEVtjUkVY6UCWujfRyiF56f4/UY3bOX1jvmmZ4yNwioyrokZAAEY2ZLFNadPAxHojnFjncNA8NgPVhq2vA3rxk0IfV6DR6Y2IGlW7RWH9/UtvySYmACLtZXc9ozD/CbNgM8r/yZe/iEpBvGhOkGCv5iwFr4g3NWKtlToE2/vAknhLraBzlriG9ppiCuWOfac1EXKUhsV/AWvHzTD7m3Bhjt3h21t3iJbxz2lmwNMZjWz9eWVTcbzZC48K+wd91IaY+6RxzSQXcWvkS8Z64hGslzYutSG7SJyQL9gOf2dgYbWfJ36EPnqeci7me4yA5YRnGTlOsTDz//9Ou3fc7gkth/ok3j4W2BXDjm46dnrF8zrvbHVl5s8o/mNkVRVWyLMeuioLl8wCWZsEicnVc6LoHuwSzrl8+ukE0l3Kl5oUGsQdbMOkcgLrDw2ZFapXksjlK2JPndsRBHbli0VAk8O8cgpRW3sT+7L6a+iLU2uu5ByqPUQq3DOLCuQbmrybUmkE0GgCxDnGcWuvtVriqORcbpApV9vneUAAOfakeR2jv+HErdpfNZGZNzKs0fCatGKXpWxhH74iPp2idNZ90r6vhEIwqIQ1g0HM+kQj2424QD X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(396003)(376002)(136003)(346002)(366004)(451199021)(6506007)(1076003)(26005)(186003)(54906003)(478600001)(6666004)(110136005)(6486002)(6512007)(52116002)(36756003)(83380400001)(2616005)(66946007)(8676002)(2906002)(5660300002)(8936002)(38350700002)(66476007)(4326008)(86362001)(66556008)(316002)(38100700002)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?6G+5gLP9A7iV81qDS39M6jTkw1da?= =?utf-8?q?fh9Q0/mC9vqEZyIDpm0LbPIxjOUpf82VNfDulWzOm3iekefg+aViHlXQ65mMJhell?= =?utf-8?q?XpRYAsr0qEounAY5OTSHKu5YN8K4Kuhdf/GhQeQDJeVN4ogDXOHv7hQedXVIVggzb?= =?utf-8?q?HRisjvRylIxoUOXXYst2D9hTZC4ep3rzb1rJB5GjAiRucQpSb29v4JClAo6H5+kkZ?= =?utf-8?q?onlDx4Sq+5Q0keAAWZH7MQ17nMxvwx/V+Gl2NrhcdsuUhT+aa8n/KsQWwJ8jhuP0O?= =?utf-8?q?gm4/b405A5PXSZlVwNxNUJrbnyTPrrqFSiniVhZ20nbLjGTqq5HHx3d45sokKDkxW?= =?utf-8?q?1OwdqhTP8dUo3bCcB4OqvQM+Y4WuWhRTupUQcbJ/IkSooaGINX74sSJqJrHRcG4sE?= =?utf-8?q?Hp9EYXNYouAYQ2OaLN+M43AA9O84rZvyIb9wES0MKx0HMuOwzcujSag5Lrbgz6S0Y?= =?utf-8?q?Eb4TM+hgEsthfsdFsXlENUKpwtDoDGEolryOOKQY0BnPKtysFt+zdz0kzb5QUpTQ1?= =?utf-8?q?Wi/y4VscBiP2Sno07X0W4kfHcjYVePRfgO9eXWyMQ83EGKMrF9ugH/Dh4ze1lmeum?= =?utf-8?q?1YQUhWKw53bHbrllblAhQfxxndwQNO9r546mQIx6hVx18QqoIrtP9X+J+Dmc1kdOC?= =?utf-8?q?xb3/QoGPoVfz4OeCp1WQB8GKNfzhPsAa2qGMDOPGwOjh89rJLiNLS8Kc/5nIBGQPA?= =?utf-8?q?FZi0uUxRvjWuciT9IM6ZJxww536e4smFW7MqY5z3i7EKKp9eBcfAuiRhVvWBmaCNQ?= =?utf-8?q?3DTGQz/p9PDwMhfFfKCZ+Dzp7Mm/PIsD6UnbckzwY9gJ3L2Wi7n30NpKk+rInHms0?= =?utf-8?q?mLX3UfPrU0Pgu1rX12E17iev9UCbniLYs3VBGJPC36JOAwnHqxLupaufc99PrbMDY?= =?utf-8?q?31Tt8rpCNNR9z6gnbl4LAXI3aihW0UG3BbLNqoKuWha0oUU9hNFyr72XFYVUge1Ka?= =?utf-8?q?723tu1Qkpdx9kOcrQClqDYAgBtfvpshbabudsm8qmbGgfVt4plKrQbnlx33OapC9i?= =?utf-8?q?AZP80Gn+77KFM2B6KEQ8lCyRfDlvckV+HOtdJbGg186rjnH2ayFZDpeizWlVGcWcx?= =?utf-8?q?BwimBoC1cUgk5nhzqZNvV7+Y0pYuUPUH/pVL+ecaxqga2mNoSVDj5XyZ6mmeKdX/1?= =?utf-8?q?sGO6OxoZDHyv0OZMVEj3DPlQ9GdgPFGtWJ7KdUIANmyyIEoOSZ6tEcy/tjxa9PhrJ?= =?utf-8?q?sRiVy6LAiAkCOilFsvBZsKFJa4JdREv/swKfZ+y7/oPS05wNludvd9UEbuTLfzEKN?= =?utf-8?q?AiD/A3HZpyBjhAIMu0g2h+qz9U9bWbwcNTCxzbvrZ5XpKc0bE16bWr+leJgPzD1dE?= =?utf-8?q?yQxDQFMuqm2GeaBNlNuWrPj2tXuVx0cXjyqeJXvVNRYX1reijibvcNjBLWVQ2uVbT?= =?utf-8?q?nQTe73tpbVEKXvR3h3PUF+co2gzHsSlrziSNVSI5BQ+LPG5g+oN9GfbLZEHagO/Dn?= =?utf-8?q?DKWoMUynA/MAmsmNK6dhvZznx3sQ82WOL5LNAoRkQUGurDqNqlhI+HdkZG8gmgYR5?= =?utf-8?q?GQFi2E2d/h14?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7819afd-98f6-4992-d65a-08db8e6f6f9d X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:02:26.9525 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H9ALygSHYvuPPJqeEVbHKGk3SatsPF2QpC+PXShpsyMGH70TcCWKphnpUvQV0dIhQhBH22V1MJ7o38nvRtpMNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6644 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Acked-by: Viresh Kumar Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-spear.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c index c79035727b20..ec6c7d8e3736 100644 --- a/drivers/mmc/host/sdhci-spear.c +++ b/drivers/mmc/host/sdhci-spear.c @@ -117,7 +117,7 @@ static int sdhci_probe(struct platform_device *pdev) return ret; } -static int sdhci_remove(struct platform_device *pdev) +static void sdhci_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct spear_sdhci *sdhci = sdhci_priv(host); @@ -131,8 +131,6 @@ static int sdhci_remove(struct platform_device *pdev) sdhci_remove_host(host, dead); clk_disable_unprepare(sdhci->clk); sdhci_free_host(host); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -186,7 +184,7 @@ static struct platform_driver sdhci_driver = { .of_match_table = of_match_ptr(sdhci_spear_id_table), }, .probe = sdhci_probe, - .remove = sdhci_remove, + .remove_new = sdhci_remove, }; module_platform_driver(sdhci_driver); From patchwork Thu Jul 27 07:00:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707379 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 636AEC0015E for ; Thu, 27 Jul 2023 07:15:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233210AbjG0HPX (ORCPT ); Thu, 27 Jul 2023 03:15:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233114AbjG0HO6 (ORCPT ); Thu, 27 Jul 2023 03:14:58 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on20711.outbound.protection.outlook.com [IPv6:2a01:111:f400:feab::711]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B240872A1; Thu, 27 Jul 2023 00:09:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j4mW8h5PnrLFdbw/N9wUEPDikqhdEN852t/6buh7BD07rXqq3Vq47Swuid6vsz8bDP6hMJivHB22c6U8YEgkJ+0IjocevewW60G977Wh9eHELx9n6AWZTrFIVVeRumnkLu7HbD190PrzSxTkQQk2IXlb+qRKZwLckXjgOh7GDIVCSc3M6Fwy9XP4JJX+zvp/7YUKr39vBeinPBJibvLomRqFrLXdjysRO6cHHZudiHQ3qglGwQwozLKMvK4AvM0WrqqZjbe3bKwhs+P/woO6OchLr2gNs+Ezdch7DNKKmgks6XIZybGkuDFYExfjeNi7D6o+ji21k9fjyYBQjv33/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+AftkKfw0z8AD4ham5M5MC4dYIWJjDbvgy5EIjA9X60=; b=mdr11/Zw5dP/BWs8+EwtFXDpnJYC7qkcajCl/fX/mCPt1cDMq3Fs46XTa+tJIuwHQNfSbFRhzI7be5fWKff6zSOGGSBQdYE9Z6ju/H37iVCiK2dRdXLOJDEegdmuTTl0yXKa0hJq+5EsSQ6UBm3JwJYEOZFbvSppWqOu3zw4vE9WrW+FHypmb8xG/EMuPkPXdcOrn+XOCjYH4Yr9Ct4n6qAsuqZeR+1Oc6mIpeEd3bDK2IMSMtvgbzL75Cr8E/s/jmFtZlhrofJxoyribuzidHRmWFJPi2UypU6Trg4+zhtK0UkimdB2PdmOiMyQKaFjUV4EPFYmcfB0h0sGbmmPig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+AftkKfw0z8AD4ham5M5MC4dYIWJjDbvgy5EIjA9X60=; b=Ykl4jBfGWj2kKMfTnw7L+a2uxHb4VnkV1QXQb6nE9BDSOW2Oihskc3VPyaV4xokj2WTWJ7unVTjmNDlzGIIAfYFGN7FgJWTT7YfZqvX/mbJ1DPSrOyxzB3bvPNr5A8IgmtwnD50L6LLXy/YWpmIUlKw0uZV37kajMtcx616vHcd3yhUqIfWgTu4nv9MQYTR2QovE3i1TWRIiCNvglhEKaOTySfLnx+mdF1hCGrqmqnzdXy1JO6qLstLBP0Cfem2YET6FTnWdnTS2RXAq4GGS4LnhhO6RbHhkeBVgyWmX/i4jjsIVTCLc+QF+3DDVtR2+dHl1RS+hYFlGCZ86dydCjw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SEZPR06MB6644.apcprd06.prod.outlook.com (2603:1096:101:181::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Thu, 27 Jul 2023 07:02:45 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:02:45 +0000 From: Yangtao Li To: Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 53/62] mmc: pwrseq_simple: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:42 +0800 Message-Id: <20230727070051.17778-53-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SEZPR06MB6644:EE_ X-MS-Office365-Filtering-Correlation-Id: 62204229-a88c-4a76-60b4-08db8e6f720e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hCBheim7O+eGCQyt1jjaQZKqXh5Bt979nAJ4zKFR8N0DVqrXF7W9b3iYuw944FJPswBf0XKC3BPYoBw6tCO+OIZmUqxyp7wVBb84vjaO6molR2gZ0p9OImz3qCqz7M2ctQgEcermueNnzmkfUlmtjZn+M3Ny/w9lGADC/chnRozWTZfUsc4aO/OGXWEZDcQS0Yj+k7goBXWwPv7QtrulBXnWslH37r0tl5+wMbOHtJgTIL1R5V2xxpFd168HnPULkzBg/JiMNu7Mjitrnj86eWYUhH2ljJGRdSTaAXbC4VmaMwgFVfgU8WP6U8gLLaOxIP0fvlNkf1/AsAXsWOPDFMcXg0/pIkRvbpUwsmj65k+rTWUue0S9qbfiKwo7ocGNlUdZEWlQev9fF+97GCAgjVzm39eeDxjfmW0yHYT0TGXOFZsuVK/rqMyWnWe1iw3BMgEtt+StROKifnX8p9SjaeBB2CzvuDBu/4uQUipCVT9VqV3HDkkX3bsD8nPd0cRFFbRpWFYTv2u2y9LbHPCjgoQ+LeAPdUF7kykebSp3fSucRQxaJambvvL6WBnY4D7dMqA0vUTH5wuxS8B27MR6kEebuO5aMh+rx8Gg1hcEbNQLrcFc561m+f+XrgMOn2NZ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(396003)(376002)(136003)(346002)(366004)(451199021)(6506007)(1076003)(26005)(186003)(54906003)(478600001)(6666004)(6486002)(6512007)(52116002)(36756003)(83380400001)(2616005)(66946007)(8676002)(6916009)(2906002)(5660300002)(8936002)(38350700002)(66476007)(4326008)(86362001)(66556008)(316002)(38100700002)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?E9NX6gQJyHq831xE10EOWVW0p/DJ?= =?utf-8?q?0uZ8ux4dFcRCJcKBOG2tNKfipfk0rK8Z3fp4/xuXS385FQ0rXfJteKNd/gOFP3d5Z?= =?utf-8?q?t91I1JR7nribk8nCTFLRQRUbZ6preBX1yXg1BfbEe/RSMZikqv4efaOEEkrRE8Ht9?= =?utf-8?q?+RVLZh5IPmLy5hFNuN2uyUea/1YmcJHGnfyKdh7KYBjdjoUI0VSC4U2+b7oXYrK5C?= =?utf-8?q?IMZW3w4NB4CeJCRbgIRLjme4PPVDEPqWY7dKUQYIl3A3TFBNJs2uIj5DTaREkVhxm?= =?utf-8?q?N5RAYCSZvhaiAOWH5z7wKNdA08YuCuJMUFQmv8R59Y+D7HdjGcXLf+dQ+aiUyCBSL?= =?utf-8?q?N5HUhSmUdCzJHrAV9Tt0Pw2eO5XZeyXM1pjIiEFsvfx0pmFSH4UZjJZ1Znf8nyGFc?= =?utf-8?q?zSiibNMg61NV0Xtn6RyX374o+fooCLw5N0HvkwsMl9cu70XV9SG082CiNFlyqo11m?= =?utf-8?q?EdzSHeaxvIA6mQ5LYJWui+JI+fPTAdwoQpnno4DWjINr2UcEvDCX1bmMf6cK9JVEP?= =?utf-8?q?cOjR8ZdQEb5XkXKM8r+psRcW/TpSzFkPBOe84K2LhgHNnc8EtjsuoGlDZomX51CWK?= =?utf-8?q?fpx82waVX0F7/UjUA7OMXr7boCj7ag/jVYncVeXYb70L2ckcZLDqcbtStL6ALsOKf?= =?utf-8?q?wcjFZzKeJ/ja06DUfF5cAnzSUujcsebc7Ad9P69wxds+TVdBKe/TbN00hfnoWlw9O?= =?utf-8?q?aXY5fn0XfpDG0G8+Y8nJDQO15yylb1PJK25Y2tnauCsxOsUyoxOc7iatnBXKJdjwG?= =?utf-8?q?SimpIdipIvuEcRWG/lsGKPkWE8Hz0ylQ5/XHjjItA/1nuzuq1KyWluwZbzrFtNHAo?= =?utf-8?q?7bxn5yOWCws3lVP95Inb1ULS4kXGpdos26i/hKBGYjFda/A2zChoKGETBcwkqFJtT?= =?utf-8?q?E1A4KsOOwtDe7v8qHAGGLVp7XkxYdA4es1rOvOYmxDUDhpUDXWzSV6tp09fyTVWXR?= =?utf-8?q?3YcVJBrVU5JKOMNFhAu0q1dgv3PV194RW4JKPLJJWDaW+oJ09nzkluUNm6TVmosP8?= =?utf-8?q?6UB20mWqvGxiGJPbx9QwgrPbVdjBHaSgl5tsg0/2P38SY/svciVzuYqYysONkwjp7?= =?utf-8?q?SwqVqiZEKsOL34FFARaX8PDsVvkjapeXqqM+0KwHAmRXqKgMvZ2eHeG7p5XtXe+oQ?= =?utf-8?q?RECBYIH3Lfg4H3+dkvjYOEz6Sswk+3AGQgI5i3YAD94WZhurNtfp3QYdnqnnpQ33l?= =?utf-8?q?5N4nsUQfsYLNz/I0V7N6k87nA59vhkJlAtZ2EMfWPLpk2/6hz9k+WtqpZ3oPAdXjy?= =?utf-8?q?ig3PWCIGNbnQ1ltNMeUFn+uAY0VcTzQysY1s4KMQTYO/e+zYpPc2B+c8887tKyMmD?= =?utf-8?q?wTM0joISvPGqyCI5qL7fmPoD5fGe8icKUI6JQwk3qLTdkBTruUR4RtKCnKGHomD3+?= =?utf-8?q?acCoj2nYNprm9idLMaxwurHJPOfmfEj/rJry8A4fFDx4SwtiN3L0Kq5L4P67V9Smp?= =?utf-8?q?JDTcIlETRBDU2Nody0VHWxQfW1TSg6PkdX4iaS05zd/oVX64jP0gOZiceugwaffbU?= =?utf-8?q?D+ouzynowUH7?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62204229-a88c-4a76-60b4-08db8e6f720e X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:02:31.0340 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v59jLg8A8N2RnRtcUQzugxwMLungP44UeqgFvf3/sLBKjw21tJit2poVsELHS9IEPYoGgZOa6f8bk0HVItIt2Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6644 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/core/pwrseq_simple.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/core/pwrseq_simple.c b/drivers/mmc/core/pwrseq_simple.c index 3bac1e71411b..df9588503ad0 100644 --- a/drivers/mmc/core/pwrseq_simple.c +++ b/drivers/mmc/core/pwrseq_simple.c @@ -142,18 +142,16 @@ static int mmc_pwrseq_simple_probe(struct platform_device *pdev) return mmc_pwrseq_register(&pwrseq->pwrseq); } -static int mmc_pwrseq_simple_remove(struct platform_device *pdev) +static void mmc_pwrseq_simple_remove(struct platform_device *pdev) { struct mmc_pwrseq_simple *pwrseq = platform_get_drvdata(pdev); mmc_pwrseq_unregister(&pwrseq->pwrseq); - - return 0; } static struct platform_driver mmc_pwrseq_simple_driver = { .probe = mmc_pwrseq_simple_probe, - .remove = mmc_pwrseq_simple_remove, + .remove_new = mmc_pwrseq_simple_remove, .driver = { .name = "pwrseq_simple", .of_match_table = mmc_pwrseq_simple_of_match, From patchwork Thu Jul 27 07:00:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707382 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13957EB64DD for ; Thu, 27 Jul 2023 07:08:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233087AbjG0HIz (ORCPT ); Thu, 27 Jul 2023 03:08:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233243AbjG0HID (ORCPT ); Thu, 27 Jul 2023 03:08:03 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2136.outbound.protection.outlook.com [40.107.215.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9D3749EB; Thu, 27 Jul 2023 00:04:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G5DRWNE1r+LRv/HQeA4yOAag9T7ql3SABtqRgiCViL+tmiJvSIYFm1uuNSN3zfC1Mi29Qr6yW6FZh8P5UzH6UYHESB/xz8Hy5SGRdCg83tUT2HdsBe/t5/JR7JNO4VSH7ZZxgskR8StRLEG1ZKC8wXczm6Y27wT941Eed7fzkVAk6rtii1hckVrYTwsAcLePWBFRN12ND2uXmPbwW7yhiAaeoZkXKUJ0o4bnr9fjyt13GhW5FFPQiquyDre0BQqeSY6jTAy93c6E83TrLYCVld0O+nNSVu1UF5C/4LfFnfC8SNcoFDkzgEbKhWFIhsPEKLtyLN3JAZ97KFxyAtz5Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bSVSY0tmOM4h4fHb2UFkj/zeTOsEVDjfwp+nRZtPSG8=; b=ItvpSKFXCA7MFdDiTWko1bRjTvPmWNKHYZtUDIEql00E3+3wIh4OJeGhTMP9YPLllrj+t6iK6M86wqkKkd+jNGRFIZk3bd+tLOhXSvztRdP5iQPYYmZS/Te4oD1HEltDU18zZkQn5O/6C2jj+YH0XGcOJjIKNEt90sEK7ZARoScZa8oRWp70+UuwB8neqtv9QOP+cnvPbAt5cWSH6W64+LQ6eeQiWD5Pnr0KaooHM1q9H3gC0QIaHBaKWwFrIk2FGtosaDESbqsK/kqbyy0MprT23Qau657Tp6hMiFES1hT0udK4KPvEA2gifIxFRvW2Uhb+mgDPdZYz48QwWk7ljg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bSVSY0tmOM4h4fHb2UFkj/zeTOsEVDjfwp+nRZtPSG8=; b=BreGQRPyjhEEYjg5dglmMkjCaoUPB2IWarwdNiBRq4k860RkPWgMSEkhccpk1cCgAhX3PMU4DWv9rprMHsa89zLUdrrkC17y6WQTvX5mdzJ1GObVdm7T+yuAcN3sTGRmAqtuNOaDoGckMNAVQeQGtWzN6kRi00n/aJIwlH8cjMdyUk6rm0rqgBYg4tEti5f9eg+koS41bKo7rrqFqx5cVnfHvJwRXMmVpJ7shaRuoX1cuAOyxvyQrI1zkR2Bpi3hIE9fj/ZDXUzqU/VWRaVqDtYl2m+aQcbc1jaS9wnPVD3JquEdfCY7O8BgKeZir+4imF2UFiyAN4gbc6ILMzY4YQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SEZPR06MB6644.apcprd06.prod.outlook.com (2603:1096:101:181::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Thu, 27 Jul 2023 07:02:45 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:02:45 +0000 From: Yangtao Li To: Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 54/62] mmc: pwrseq: sd8787: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:43 +0800 Message-Id: <20230727070051.17778-54-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SEZPR06MB6644:EE_ X-MS-Office365-Filtering-Correlation-Id: c59eafa2-8874-4d42-cf75-08db8e6f732e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FuDH2aEExJ9sfiDvKUczpK5+nGPCbDtR4uslrMk8n2v3v+NMAS+K2DeSwMtNtFTrdR2FW1yEUBGVtd/fItYh3YjfJOksNJigQVBKRdrqu9v+Bud1ao+mOzUGErVuZ7GGS+5jXvAisdTzr3sjhI8eVvAD9LZo09gefGk3X4uteJBK96muzGiUv6onIGOV2VSmvXZ0IOIktDFSUQ4xd2/JgbU6ijVzEP+YeIT3cMWmYDPBZC47n1+c59boTloL1fNXOGZC7IUGj89MErkbWcnNW6Kh+YplabCMm3tQNgNOC8DBpnVW/MfXDO/sKiRod0j6JvR7xYi5IQfr4W72Ii6Ay0Ba2lBqiPnzzer1H8XHUDYm9cosQ8Gk6IHZ2l+BT8ri3E5suGJ7Ar9ndGmQpOqQbind/0+dzBI/tgQGlMvsumISHDaN9d+oqaSxVhCA3jtC5B4/gtr1tUWtq9c+vV4qvGcsZX7xBaj+cmA7QQLe7CM+xFVfd1EzXHx3fJPoj9ULrzQbTyrY7Ug2mJ8c0XIK7gMjDAbetwQynONHHAJ83HToFSzQq2EGl9bd1mIJv7uWdXBU2AUI4dtXAGxeCzqExOktCaS2XbOe9e+IcR5/l5i0krZXxRQHBCNEh1OyuUiG X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(396003)(376002)(136003)(346002)(366004)(451199021)(6506007)(1076003)(26005)(186003)(54906003)(478600001)(6486002)(6512007)(52116002)(36756003)(83380400001)(2616005)(66946007)(8676002)(6916009)(2906002)(5660300002)(8936002)(38350700002)(66476007)(4326008)(86362001)(66556008)(316002)(38100700002)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?8t3TXpH/Rg0ZtQYfIFRMUV/j0EKl?= =?utf-8?q?enN8K1RHiNuGBI2jFO9TLmB5R6APiV9L67kT9wM6q5mWHhk1eFKizmGngwrlelriT?= =?utf-8?q?SgY5fEEwdgPgg0ILXog+UZ5QNSj+PZMnK4X1Z3rdeoO62z1M04FQZkiAQhcADwe4A?= =?utf-8?q?bvsD+L6QrFGvgfZRDbvsr0vbpHYiE51EmvkrsmH0T2FCdDalLWyw4yB58PxEk/DUJ?= =?utf-8?q?96CsFlVehkquiqyXmrkjcI/uH+65lPYYUo0rskH4wMngbMtA8M9158chrpxDEM0M+?= =?utf-8?q?YlGt7upoPq8XBXJ1g1V6hQftk7A0IVcTuWjwOG4pQWNSEZrMTB+zJPHRWtKWlSvHB?= =?utf-8?q?8j1rZSWvDmyRM8O2lLcyR8qHgf7fWan9eujr+GooJeXt7sjiVe73w2rpg5hUqFj68?= =?utf-8?q?lZBqiDHEsDanJjWh5yMS4LxPCjyEIjbXdIx9q7jKmRABm5Fh2LOabHAynr/cbETpo?= =?utf-8?q?ADiFOVxOglWX3GlQCM1Kugl2m6C8aTalRrZrEOlzQ/IMlq/cpKy9CbcfsJhJYxrq0?= =?utf-8?q?hGo5SRw7uJbz+mzLxU221FK0YQwJbiGX94w8tftELn5mfyID5r06eflTAK4OnMFt0?= =?utf-8?q?KFpKTZeLsGxtz8zMk/U2bApP+zKmQqAMWnDCMac2E5jnTcbAW9DcQIuaQaVbbgTsf?= =?utf-8?q?KTwq4Z4paI/Cv8x1BX/Mn/vURtlTN5dYoFxM/3tBT8VA50CiFNAeDC0H6Dps/LoKk?= =?utf-8?q?oIP5d3vARGwUMwalO2sERlO6Pq7oGPBcds+RCGi+nThjPvMnIQz/D1140uUmE95mz?= =?utf-8?q?a1rxrhyqwRflg403k2A8zac5WahNZSvXFjZBPboA57bi8E7C1xXn46NqyipDAS7M2?= =?utf-8?q?TYav8XzT8MUPl6/mqiSQlaH0MrxcJaj/2v5KoJtRuiNo1Y8v4c3gvyOPCT4+gHUBa?= =?utf-8?q?W4xSV5I+FIa8k1lW+QwIQ7zaZmA2M4TgtONkfBfwGmGMLM/A5pH3viTVD8JpDqVCG?= =?utf-8?q?MNnO/QhzeYjztXY3LPRHp8mtzsAwn/WT6rLh0L1or+4HGqXnXNYmI3Reg3PTD6jA+?= =?utf-8?q?++kgHfwM5U3T+v7vqV0ofN4tWG6LjLxp3VIm8dNvYq93Sv+voPxRLhm96G/X7gbNK?= =?utf-8?q?lJN7aqnBk2YNVbcBRTmezhrClWMFbfsD/rkqK23kmH1EXfL6R89yaP75S3Kw8qf6A?= =?utf-8?q?G83T64SRLOmMPFc+QWc/4wOxHRKXOrkRo9zwFZWmQsHD34ne947VbdnQ6ta/zy0QO?= =?utf-8?q?5PMdoE0YUCOry7AHr1TLF46t/WSY++/srEGq4KNF2nabyvHce0j5kTWa40sF0cpAc?= =?utf-8?q?bwkJ5vsxlB18dFidkUib6b+6VFPEMgKwKbGCVSbklJhhNlpNotvOwPs8Z+cX6YkJE?= =?utf-8?q?bDLjRJ5L8waCcEYDPyJYHy1H5cmWlNeCh1Qd0IlNtN7FK8jEpwxmSnvstNVDGHzEo?= =?utf-8?q?HezXZjCMi13qrKxS22qrEZbwgSIQZwVDN6VFU32WsDw2kywOz5lGNMxrb+nCaBSKs?= =?utf-8?q?fdAuTZLhvm97wDUhgHNcXrY8KArW5cKV+CNmXNs+IXt5M69v/LO5Mfdc1ylvKQNLr?= =?utf-8?q?yjhndKIz+Fny?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: c59eafa2-8874-4d42-cf75-08db8e6f732e X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:02:32.9445 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T/e9MMDH7i02wcyK4eSmz7PBnfGaxR7XiiBGGWgaR9b8co5EUd0BIyHg68L9KVgQZoIsRyFJXsjHGM5QYAL34g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6644 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/core/pwrseq_sd8787.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/core/pwrseq_sd8787.c b/drivers/mmc/core/pwrseq_sd8787.c index 0c5f5e371e1f..0c5808fc3206 100644 --- a/drivers/mmc/core/pwrseq_sd8787.c +++ b/drivers/mmc/core/pwrseq_sd8787.c @@ -113,18 +113,16 @@ static int mmc_pwrseq_sd8787_probe(struct platform_device *pdev) return mmc_pwrseq_register(&pwrseq->pwrseq); } -static int mmc_pwrseq_sd8787_remove(struct platform_device *pdev) +static void mmc_pwrseq_sd8787_remove(struct platform_device *pdev) { struct mmc_pwrseq_sd8787 *pwrseq = platform_get_drvdata(pdev); mmc_pwrseq_unregister(&pwrseq->pwrseq); - - return 0; } static struct platform_driver mmc_pwrseq_sd8787_driver = { .probe = mmc_pwrseq_sd8787_probe, - .remove = mmc_pwrseq_sd8787_remove, + .remove_new = mmc_pwrseq_sd8787_remove, .driver = { .name = "pwrseq_sd8787", .of_match_table = mmc_pwrseq_sd8787_of_match, From patchwork Thu Jul 27 07:00:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707384 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE6D3C00528 for ; Thu, 27 Jul 2023 07:08:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231157AbjG0HIa (ORCPT ); Thu, 27 Jul 2023 03:08:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232480AbjG0HHR (ORCPT ); Thu, 27 Jul 2023 03:07:17 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2136.outbound.protection.outlook.com [40.107.215.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28CC230D3; Thu, 27 Jul 2023 00:04:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MJEPaObnPj4dUfnTti7hg3zYkuBsuSRjQl3K9r1T1cfLxTZ+ObTdnrKLBIrw0nRVuCrUN84jrm0VKGKk10bBbGXaw/vguLCwaooxRDrX5VWJqivGBOCvj0STSNK7CyeAp4RAbHEWYX1sCbM6cSIaIdzmKobcNtSbL/pIBK2ikhXnS+somy5O9sD0Zljv+GyLyhjOfNnp02VpUQmTnD0mzL/ApjGzxEU5C1AKTLzSVYXX3W67Fuwfn1tNnIOMLdUyObMg5/XdG1Ob5rP3P8LynjmyEdJtxxVBIVsY0kC5shiXrY968zB+PyX+kIbcSgxJEwbYSDFf0FDKDLTdspcYsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VbvoRarTmihEE9SfYnfLmCP64NcG9T0qKBlCHawhwDE=; b=GyDegS8k9jCpoX9bjfV2gl6CV0fu/Dny3qTf0GRR76K5oScUERcZK48u6pxVFgDI4ncjLP/kHaF+ZMZs0VVYJFa9OOxdKm7PLyTxTav+tV/HZCJZc0a5qBHTplVjZCnS61cd/cxUD0J4xdO28ql1UkbgGtZ8S1mw45nXaVk1t6zraEvVi3QG24OR0fOs6VTgq0++lKLxFpF2USc9aGcBVT8uALUsiY8qNl07d4ZoDsz0LXDLZ98mWYFTc8frh/aBdbfK0fw2spMnq0/bUXX8276l3kxAxIYpf4gnftfPAOzkpxgCpffE1ZUUiEBnPMRocXDzDN3cQA31Tp9E4yibIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VbvoRarTmihEE9SfYnfLmCP64NcG9T0qKBlCHawhwDE=; b=DsK6lYUhYdErJ/jH2AjAKGnJhFqpasNL5QAbBhGjbyz9bjXZBlH0l7eRKsyPlL1q+nFGQUmZi/RjkrpRBjyX3IvIiqkJ+wthEX3T1z1j7RO3pNLqxLaryX3U6TFVO6HVrbQGq/sKpzH2rr17mz8gg8skdugr+hGKHPWNKH2jDxZNg6okYJnE+pxTR7u5jvk3GBU2G0vXOR1+TdgHjvSOqXx6/V7Eh68ns40SMXWjhMCH+2OQpoDPIaqP72SeUZS6cEfEwk311y7fL9NeWIfMo98yC5RT+K2NRmTgeBozXsiNqOUjh6LwmQKn3GMNQfYtY9WqSmMYrnhuF3ecy3YkxA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by SEZPR06MB6644.apcprd06.prod.outlook.com (2603:1096:101:181::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Thu, 27 Jul 2023 07:02:45 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:02:45 +0000 From: Yangtao Li To: Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 55/62] mmc: pwrseq: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:44 +0800 Message-Id: <20230727070051.17778-55-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|SEZPR06MB6644:EE_ X-MS-Office365-Filtering-Correlation-Id: 03f7b106-0f34-4f27-6dbc-08db8e6f73f9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Tbw0nkQN63OYFRB2ByhL42oIC521u8zv3qM971wfHDkMPirHlxJWhBAp9S5Odn0wNc2uWqvraU6TtdDrqOg112KGkpjwkc3ocAsqarR9Ffa2Tfr7u4OLv7v8r1Uj9x/6uDFQ0Qad1gx+wRPrWyI1OjpPciyyFaXZCBgCR45TTjq1UZCFM0gBcbaSFkdaapdcvLZimKGfmZbeb6fYUiqCc0QykPvC6uKd/I3+DnX0UoAo9y5pIjE0aMpvl5Hy10hQvlnZD2UOn85W6acDAU51AHeRzH/KfvMNEYiedhKacG1vwov5JiQjFoJXRgUYagXm9ZXlwJy+fEsK2VpF6GEWlU4GRhqxBZdmCB/hZ2OXkdJwEfY1HuvMLw/Wf0bKVOSgdb5lJ1wHUVHOtF4dIJJi0sQK0RZRL6E1oIybugvWlqmXS+a0wBa1a7Sb6FR18lfzuoDux6Jqa2ej3alRFVf8aywOVYVT879OyMXlSB+fvDlaDr83niv5ZNlorVtQVWJv2rEuRzt0aTMdeZKowoTKKfBoHulIHYI20+zGEQ5JvXvS+hnTFlMm0L8pJ9VCB6R5RWcKcpwJu8a3nY31k8xh03wDzL+ycVWT3/QRN98mQJJHlVUx6zOx3HS3QlSNiZSQ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(396003)(376002)(136003)(346002)(366004)(451199021)(6506007)(1076003)(26005)(186003)(54906003)(478600001)(6486002)(6512007)(52116002)(36756003)(83380400001)(2616005)(66946007)(8676002)(6916009)(2906002)(5660300002)(8936002)(38350700002)(66476007)(4326008)(86362001)(66556008)(316002)(38100700002)(41300700001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?dI6lHusV8dzP4EoBXTVfU4GuIt8c?= =?utf-8?q?CXhTOg9LyLzk/0+X1KB4jAZKtenJE7/mRUka8SeIjS/hnmcyy4cmf8Oox2M6xgboo?= =?utf-8?q?1w0ZT8SccQMJD06OcuEhRMAAq9J1y6K7JUx+eYxLSDgVH4hm17lju6TmVtR3wLowx?= =?utf-8?q?Hjwj84cq8M4aeOHS1OOKKR/2Pp/K7tmf8BvoFGNgHq9O1beIac37Ol12rwk6BUzAk?= =?utf-8?q?7eGTW+Frke5UzpzqJI4z/GytJpe50gBE3W8mYnGMZHuJ6UpLvBdLIUX0Q4/72OaTK?= =?utf-8?q?ItNKvFX69Fhx/AvVRe5xF1hG7L8Fonv/DId9zjgvCvDRuktkevrZYkJYCa52WDB25?= =?utf-8?q?LEkBBKPf+GF+rFHJR+1WZA9Awy6Q0IVLmHyDqtFjMgB5CC1dwksxw1nu/59yGbyjg?= =?utf-8?q?cQ1Elhmekrv3stdFqlLdRcZyY1FtNOgA4oHnLUdcuRShFIcY62tMZR99lmBNlWd0x?= =?utf-8?q?+6PK2bgkzSrnzPrrQThkoyqbiNlS8eyrwW7lxMA31AiuEvY7LxGxgNZkeLWHbGvPm?= =?utf-8?q?5CZjoQV2Q3IfdRFFUOGF6+raeSE918S8f4MYIltVwJQIBIF8iVeB4HeiDcK8+0pi6?= =?utf-8?q?ORp1OVcA83dcKNDVciyD17Hv77vtO+Gk2O0dnpjCLtjwgEbIqUq6ujBsytxIY7drR?= =?utf-8?q?RPjTOr/dJHz8ankIEkllKW725FWojd0C6Wt2+fZyxpqfWDcsQSgNsjC/olfoRefSO?= =?utf-8?q?cVSecnyqOHkHqdIptS/0JNNbd7siouNWgyY149TiHzj4VcLlWqWvb4DRdjWGaKseI?= =?utf-8?q?DAvWAJ6H4ROEz1I8Mc/RgbqeSRog4tLUBwTZxwAT96Wo2NULGrBvWYS453bCBck2n?= =?utf-8?q?+Phuoqujdd13xDUafwgx6IqJam8IsZPHNBXcC5SYuzJBipUsXzTEKO1+igx0QPzX/?= =?utf-8?q?u+6IhRervZ3usUdCL2lMQFyreCszPgelRQpTEJRfjPJMbu2KWWpyKk67iFbxjZ0e8?= =?utf-8?q?+Q2Owy2m89ROCO4+jS4GMIa7ZwzkO+FaeoYMv6KkMfFOlA8J5RRZzUVQv3TDgUb5Z?= =?utf-8?q?epICpSVaTT0S/MIms2DznX4exOMVBBoBMoW7hBw5hXmcDwZt56oR1qWlOqr4oui1C?= =?utf-8?q?6+hD17dpwtyo2gYaoY4obQtnXmttc2NW7quuaMHFXiwPX8OGDe5Ag+lhudkKMz65z?= =?utf-8?q?Ik80Un5TRJtD3rU3fBXNCJ0iNH/24KxCNLdKf8aggZUuW6gQ2Lc+tMlG5afzF79S1?= =?utf-8?q?uWAW/E+HKVWW0j3gRebMJu2aWVxeZbQVa6LSl3DdcEHB9294UE0rLeTygTOvQmgs/?= =?utf-8?q?i0cdG9lgoKuApXDG7kfooJ7jCJkEJsM8oLm8zVN8+MRWNFpWXB+vdLbeH1ZmHlm02?= =?utf-8?q?nM5Pnkpih3shgmmY2lvCN7BJ+y6UGMT5xNQCQuWH//c+YJK9KQyZefmX5LMFDY/Ix?= =?utf-8?q?0DKjZ03Hd0zr8MZUpAp3nTZsSoJwtRGvNQlZDY6SdfNWSnxs2v2g65QHJ9VSUAzDq?= =?utf-8?q?epTexk8eIdqsbLK7BtsGNGXC0GqMO1UBU8w/cQSIJrC35Eqyoh3efMH6w37zdREm+?= =?utf-8?q?nLCZVOtbn7mq?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 03f7b106-0f34-4f27-6dbc-08db8e6f73f9 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:02:34.2614 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2mq7O/EEHX8F4mf7C6dypowY0WDP9ooKCYv91/agnRphOzHzRujblEZJ+vghVhdfYMLSKT7R3s7uwd0S2jiPfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6644 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/core/pwrseq_emmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/core/pwrseq_emmc.c b/drivers/mmc/core/pwrseq_emmc.c index f6dde9edd7a3..3b6d69cefb4e 100644 --- a/drivers/mmc/core/pwrseq_emmc.c +++ b/drivers/mmc/core/pwrseq_emmc.c @@ -90,14 +90,12 @@ static int mmc_pwrseq_emmc_probe(struct platform_device *pdev) return mmc_pwrseq_register(&pwrseq->pwrseq); } -static int mmc_pwrseq_emmc_remove(struct platform_device *pdev) +static void mmc_pwrseq_emmc_remove(struct platform_device *pdev) { struct mmc_pwrseq_emmc *pwrseq = platform_get_drvdata(pdev); unregister_restart_handler(&pwrseq->reset_nb); mmc_pwrseq_unregister(&pwrseq->pwrseq); - - return 0; } static const struct of_device_id mmc_pwrseq_emmc_of_match[] = { @@ -109,7 +107,7 @@ MODULE_DEVICE_TABLE(of, mmc_pwrseq_emmc_of_match); static struct platform_driver mmc_pwrseq_emmc_driver = { .probe = mmc_pwrseq_emmc_probe, - .remove = mmc_pwrseq_emmc_remove, + .remove_new = mmc_pwrseq_emmc_remove, .driver = { .name = "pwrseq_emmc", .of_match_table = mmc_pwrseq_emmc_of_match, From patchwork Thu Jul 27 07:00:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707392 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0650EB64DD for ; Thu, 27 Jul 2023 07:06:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232996AbjG0HGb (ORCPT ); Thu, 27 Jul 2023 03:06:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232909AbjG0HFg (ORCPT ); Thu, 27 Jul 2023 03:05:36 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2090.outbound.protection.outlook.com [40.107.215.90]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06888448E; Thu, 27 Jul 2023 00:03:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QrMGg0VoNOb5BL9E4PkFmGzJ6fs3b8malkIC9PyGqMJlsHrOKAfYcDBYr0XwLf2t8wUA0reCMqOy/WbMFHYAi1ptnNzYWsoQwS02380IX75xdy2GUdIregF3JiAWX9sXmWibFQFjMgDslxJbwQ3UPbDU7Kh7arzhapc71FxtioCYkqW0/kO03KFNgqGLKKjj9P/LGUKTF1nFMR8E72uBdfZQChIDouBGz6k8+WpQq61mjtM3ZZKhpg4xbH1tWyyre9E0Jre8jsXVxVtcrGtHILtt/rJGMV6EyI8RxlZ2hqObr1j/Ir/78qfwppAcGcdCt37wsdl+pYPeD+W+V8lgSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J5jSVvTfy21nexuFITYTeRJZPViozYwLNoQA6yut0bE=; b=MeeaEKrXaEshNhaf4YMer+1fIeDuPs1WJrBEl9w1Z4MIm9oL6GyiJPZPB9zfvm0pEzJtWCTviMeBjkjjolVIZ5meASObCqsVe2fa1LCalGump+qqrEyHJGWTCty5aAvigQf8uc6fAuxshMpHFEYNjegZcq5Aif5tcYTCRgORFftYqVG9Xwz7bcObDa+a3tyrDzmL+Bz17KpNLpPSl7kl6iE7rMCtjPi25GUkPGaxt/6ihy4XATGR/N+m0Fg5owfeUnTIFySpjkyTi5MvZmYxcTq+04eVxNoq9vhrQ/+QXCIiz86+pPC6H1l+02dJCXE3hVr89ggCX6crGRw/fvCHvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J5jSVvTfy21nexuFITYTeRJZPViozYwLNoQA6yut0bE=; b=X4uEj3J0X9lAfGTbA5/KCkv9O6ofhqPNtdRH6syxfSj2Rfh07FiAg1Ubxj0GKIJ3WXEj1DO29pWpdMqcVFFbNJbDWlk2woN/J27+sZhjqoO6iShRyrEJ6fF/xSesCLML20KSilQnYPTDQy+58K6bUP3VqmCow2FBlIyV+LoDefrFVRI42UGVe9GN3tFKXjppt4PAGGoAED8ntAvfm+wkI01svaLra37vwZZ1PGPbltluO+6D+1ML3TfhPkXJ4enmMU6Dx9bPihhBbvZMWlms/6GmeM/5ofvO9gv3lNNgD1Pl3BvKBZj9ktpk03KEyX4F40X/wR1I43VQS7Z+5MP8vg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by PSAPR06MB4152.apcprd06.prod.outlook.com (2603:1096:301:34::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:02:46 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:02:46 +0000 From: Yangtao Li To: Ulf Hansson , Kunihiko Hayashi , Masami Hiramatsu Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 58/62] mmc: uniphier-sd: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:47 +0800 Message-Id: <20230727070051.17778-58-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|PSAPR06MB4152:EE_ X-MS-Office365-Filtering-Correlation-Id: f64abb1d-ee8b-46c9-c092-08db8e6f78b6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hzCw2saiXh5oij8OiezOTxeXiP66wLtzh2CijXgl3EuxhEXJAw6cUAgzahhs1pT3dlzPrgt0fvq+ExwVaNPPAeVIJAXvXrlqIF9gqXGATks1qAFuJ5G9NJeON6W3f0A4BrR/OdOBP6DWMF3L8zNmzU2kxy5KgfxI8MBsqjL5Pdw0Zry74P+BwRut70MgYDgBWvD1wuIcBT/84OzxCIA7N30ghOKlFmHX9FD2IkCku3taWqQ1hTPdTr4UsRNtdxSudO+6giexUZwguuSxVDGzIA+aVKXuG3DvUhfD4DD6SFMMLFjjEmXdlAdl55PNAPnGSbGJXmYIxp9YttMc9THY2j3PsiYYit6dq+7yMRlauw9PZ5VFebs//s77RhZqJxxj5GsxQ141vH855hq/vhvhXRTpkB1YEceVdjJiquvTleD2pi22mQK39v3btyIMMVK7QJt3tKGLS8WqGerhpHJWw1x8AMjTbE+6ZREmXR62BSvBtBAu3Nk2E9c/4Qs69cF0Sci+aVWvPY5YMyI+88QdkRWUbz3a7fOf4PsazMAaC4QzUiLL5Ob34DgPTaHEj1dXJsFSRFbM3xzOf4XHFmstxV/eZTrmBKxsW6KaxhZx0vdMiZ2bKwftU/efZEjC6vyS X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(366004)(136003)(39850400004)(346002)(376002)(451199021)(6486002)(478600001)(52116002)(83380400001)(26005)(1076003)(6506007)(6512007)(38350700002)(38100700002)(66556008)(66946007)(4326008)(54906003)(66476007)(110136005)(186003)(2616005)(5660300002)(316002)(8936002)(8676002)(2906002)(41300700001)(86362001)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?5gu0n/9CYi6dFrWw9e8kFXgQWCuk?= =?utf-8?q?85DubcPVnkoECNN6nJ2Pmz3R9+Bg6Za8G8zap6fPRDK/cZznqP9UGB6KR7Dby0oDg?= =?utf-8?q?xsEGHNdYsPpWkKkdgwY2K9ueF3CoHuY2vxw4PNJ7Ib9KB/JGwDSvYhR0nlR5f3mJL?= =?utf-8?q?JbKOG7+qApA+CxHlJqFZ0p2BR2oKqPJjGPed7b9iFCMXRCsRMjA1cgPKKTbk11KdU?= =?utf-8?q?j/6tznTUKC378tMovhLYrpXxZAuIY/tMHYShJcqozTrSP2jM/DRRDUyaRQ10S5cjP?= =?utf-8?q?/XHu4WwMuz7sK8NxxAYp/DQn8dPnlBuyM14+RfYHsli014FXW1r4ZttdkgMFiruZw?= =?utf-8?q?j0PxBn7mbwFEzfrY7SBZMVUsXWOqrtB9VaKqFtr8v64/UR62WRmKcBuN5Hb0CxJru?= =?utf-8?q?pEovdtn7QWCnQnN5CSYTzVywAveekn6F5DEOrqCj+l/22OReVfD9c6L+bsXbcJ5uO?= =?utf-8?q?sHuXHskprg1Eq2ZTlJzbNdQzF+kyMcZcjh78fYtWcAk3u5UPn4r33jJydcrkl3frG?= =?utf-8?q?eu/p8LvILdZF6SGFncnWOBsYylO23rcfVPeQc+0zONP17pGj+6FrLj9M3v6j7KBh2?= =?utf-8?q?50J1NnktJ9iIgjZo+cuIGKelxU9zGwLCZ0mi1CijqAQDQpNi6Ae4C8sTtoGDeFnX9?= =?utf-8?q?2AvlhkCG9xC6y3wQizUxjBP+l9LTrmN+DNxb/D3OuJka+JRzzIuKKrC+8+N0N7STc?= =?utf-8?q?zSzP7D0Aev3gTSALcgVrrOuhqpetum69/mT8DQcjolc218tb1lAyhIwV02ZD9Prs3?= =?utf-8?q?XS4f3V5ZHEOWOkfdHWvsanZiNuN+TCmOMxShkqhZGRGEQpromYKCRHcZGV7+EuO3b?= =?utf-8?q?9pYBedZ0cyNLoQ8sxi3FYyCY2NFmPwsl2/Vyec/5qXtqWV+p4Iv/O0pjdz+wXVcjR?= =?utf-8?q?5TvgMEH47mtBDVGFIaNej9Q+vi3cRQuWufaTRQ1yfOff+vn+f3uJE3OayPiFOLqB7?= =?utf-8?q?n7hC4Z5ROx9Q1YE+o/Bh27p1Rxd+Wk/IDLsI5Av3oWQKXr2cdJy6CzpE0umYddDtk?= =?utf-8?q?PYbe4jQhSd/8pw+Mi6loNWApzclle//vR8TyIMDA8JUQMQkBYGX6TgMLsVXhlRraa?= =?utf-8?q?Owqs75e9aUqV0eTnb9C6hW0l7FKp6R9J+vsiwiE79RYYkX0KkWunKp/aJCkRy2Za0?= =?utf-8?q?KEsdGz1/BCsdKaz77NzkmMienKDT6nSKENAyOvPGBz6RpI3BV6+R6EoL8i5FOnuPz?= =?utf-8?q?Dk/RiiUM8Swq8YXH/K2vJn8g79KQQqW7RqQ97n7UUXO+l0/YYf2y24Z4RMw29Y03R?= =?utf-8?q?7R1pacy6O3m0x0mC9J4H6EhggVRG72s+g6XxX5DouoKQTJiMmxI07AcHC80G0zJMW?= =?utf-8?q?bGRHTUXZccK83zkknEYrtWw8HzHFWRzS8z7ExVt8utaY992L/2VxaX7t0uhZS0CKL?= =?utf-8?q?/ee2YuLs6H/J4GUOcgSZ8HQ82wqzQHJC/h39yvNMdebHhzjgwpHVdHcEkW9BG/gAl?= =?utf-8?q?iIQmIv2JlC+HyUkS1PIN2YggP0737f8phKq0TFCBcIoHyRq5T2ei7nES1d2cY+n6d?= =?utf-8?q?KUwIvljWi+Uk?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: f64abb1d-ee8b-46c9-c092-08db8e6f78b6 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:02:42.2000 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /248dpgNnj3tYJb7auMysIoahVR1WPleQWcFUJpMOe4B2EdSbPJEhzYPlznDTuSD2QjVjefggUnPOV6nPWhSFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR06MB4152 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/uniphier-sd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/uniphier-sd.c b/drivers/mmc/host/uniphier-sd.c index 61acd69fac0e..33a4d1c6ef04 100644 --- a/drivers/mmc/host/uniphier-sd.c +++ b/drivers/mmc/host/uniphier-sd.c @@ -727,15 +727,13 @@ static int uniphier_sd_probe(struct platform_device *pdev) return ret; } -static int uniphier_sd_remove(struct platform_device *pdev) +static void uniphier_sd_remove(struct platform_device *pdev) { struct tmio_mmc_host *host = platform_get_drvdata(pdev); tmio_mmc_host_remove(host); uniphier_sd_clk_disable(host); tmio_mmc_host_free(host); - - return 0; } static const struct of_device_id uniphier_sd_match[] = { @@ -757,7 +755,7 @@ MODULE_DEVICE_TABLE(of, uniphier_sd_match); static struct platform_driver uniphier_sd_driver = { .probe = uniphier_sd_probe, - .remove = uniphier_sd_remove, + .remove_new = uniphier_sd_remove, .driver = { .name = "uniphier-sd", .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Thu Jul 27 07:00:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707383 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7D19C001E0 for ; Thu, 27 Jul 2023 07:08:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231691AbjG0HIc (ORCPT ); Thu, 27 Jul 2023 03:08:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232101AbjG0HHq (ORCPT ); Thu, 27 Jul 2023 03:07:46 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2090.outbound.protection.outlook.com [40.107.215.90]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09C69E0; Thu, 27 Jul 2023 00:04:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KZmCHmTEMhCbD/7vGHr9vp+LZfBMVDQ0yZT+g8Z2P2gLjnc59IWiuCamZV9YNugSzw+gU+hjSZUWrkboCfhflm0U5mgNXOU/BtsgzhWfLw7zIKt7peaW8l2HPEtu8MdMP81Xe1n+aHIF0Nj/KO3OvwEq9ud4MqMnI9a06tjYCboGaNCXTggS6qUNI72QCZGCzowIGKWpXLDzM1ALBbMXJhGbCR16AaOSaALPiKoWgbRcyguTHzpvap/OVjJbFyI7cBxOQQgOKP7cqsNb6rzLEuM22TgLAr3rGVXWLSGq+IUzJAV22nW8eOrEjaUmjuBRYn0dLmYSU/byGVORJlTCLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Wq3D3MP18gp00gViiexlDEzaE6ODfTIsN21lyfNhC4=; b=UUZXl0TwLfLyAZ+KilbasVyAOgFFfmPpr5faEK48dk5wIo2JtUwWMyMoxkmGPECyQ04gJHGptDI9H9k2laTuxtTBc87094gREnbLHFpWPfhweQCNmWjrJeYU/BSrDbe3a5WAq6rI8Y1RvS5tEkxVVcdWoJ4qigxQDZZ8WdfixmxpFwD3TZPikbrBsCbgkeMAWi5z45haCsvYkhLFwhKRSFMCeBLPz7/Lreu52sUGz3q2LK8Ly1NZtd9bDgAxU8oB9kTU5O2APotOBIGlHldcwQB5pe5Lze8vABSLS/3AKKEVHGofoNv/YZw1wxXqft4XVaZgIHcUF/GlV9BZepG0Vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Wq3D3MP18gp00gViiexlDEzaE6ODfTIsN21lyfNhC4=; b=iDNb0JaUjEm0NE71hxkwX13JWMSchrNaExE9DOq9ZClKM2jXmifaQWUZIva4pTjjuXTkDXEPU3wg0N2ALlJChPDu5gVkNFrfrYg/JlyXNrv/PrmMNxfGPLuw4IXGfeKqpnWqCbafyLiyen2b9tELGklHF4fSmq4q/crm3vZwS2gOo2fgTgYlmunbyIhZkfWg24pqMgoLN1ODF5dGMXRbf5XY78pMql7cepa64e8OfH5N8lyrWKtWZt2/+VSdYVwVpHL6olDxG4U6BpPyD109KV2etOk69L9eJX5KYy859wkg16Ct25PSuFhqZTV3/PZOny05wPOFnw3A+BRHBTVl7g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by PSAPR06MB4152.apcprd06.prod.outlook.com (2603:1096:301:34::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:02:46 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:02:46 +0000 From: Yangtao Li To: Adrian Hunter , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 59/62] mmc: sdhci_am654: Properly handle failures in .remove() Date: Thu, 27 Jul 2023 15:00:48 +0800 Message-Id: <20230727070051.17778-59-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|PSAPR06MB4152:EE_ X-MS-Office365-Filtering-Correlation-Id: afaafa2a-a1df-406b-e7c6-08db8e6f798a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZcWnBz+gIw8bqywvX1/HTp4Y21SGp1Tr8MvJ4F+brgQ06W8fQiYBfZj1/LBz/yq+Ok7i6+S4NqoeRChZo1zFBJEuJso/dZyb9NZxmhRIjLvkVM44FC+BRc2qYt7Eql2MRnSQ+mk4TVsIMICg3s9rBZ2S5oPAHFE9clznVHHJmnyIVaOMZ2v/XytLHLoQunWWEaa4wylF0tM7TKgCbiaidnEbZz7LgQz0Zpq60sb+njoTiuVF4hDKWyGQmF73jblEVl3DVLIavhhoClZecTEvTZ8LHapiWQ/yUgykcUQuSRUIoRU8Ks3CNIui9U+ghGCY1H+meZqecsWdyHrE1E1eJA965FJBXa3nFQCkBrMe52/xSgmb+vPO34Ui6FBSltrycY5/EHNFhykgOuZwb0vEIaeVtI2wHqVTzqPOKsKjK/m3TA7V2bUONVuHLG3PBdeCD5nwjRMQuJH5Gge95DWVrN3iTgFcJ7qoNneqg+tEsNMqwJAkuaemRWjCBP3Mb5TDfzH76+FsWlfrNobFQJv6T5OL/JIe3TB2tCrujCf01MOo/saiLcaoAHyJtuzIH/Ga3OwCJfnOzkFTCituf4pfKsfmszicnYaV8ypRPbqnEb0JgGWkrEHqRxcmbQtgytT/ZN0iKJhdCDjcL9ixI1w+VQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(366004)(136003)(39850400004)(346002)(376002)(451199021)(6486002)(478600001)(52116002)(83380400001)(26005)(1076003)(6506007)(6512007)(38350700002)(38100700002)(66556008)(66946007)(4326008)(54906003)(66476007)(110136005)(186003)(2616005)(5660300002)(316002)(8936002)(8676002)(2906002)(41300700001)(86362001)(36756003)(142923001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?kldXSR59jXEm7X/hZAaLWnUT6wde?= =?utf-8?q?PqBZDYYt5TkCD8OKNf6cD/TFDz2f2jljr+C+wRzjKeBCM1DhkYiUBw88BU6XnblcX?= =?utf-8?q?HWyC47xgSI/6iPEgmt4tzw3/OhjyD3CnRjLrrGRMmh8QbYTD7OpP1ps5KiZfsTk3V?= =?utf-8?q?1E9UvMW27IhR2fpZ70wiufFTV391SFffMvjBzGGLoGKI5mLhaW9SL1UHfKbJYRv6w?= =?utf-8?q?e1QoVAdC56qs+vdTG2g/E6DVr/Vs4Y/iJfBKKr60uG9o0179BVNHD5pjrFR0ONi+O?= =?utf-8?q?ylZku3L2TUeVc7U+4vV2Cox2/CQXrOTJDDzSMP4fzxF2u63F3LKxoM9a8kNVOKgC4?= =?utf-8?q?mC2adeuxr+q4WBPM5ysm6e85Pu2vUF4pJovAaz/hxusKUk/qqVDw6YwMf6Q/qzLwt?= =?utf-8?q?P0PWxO35t1Q01OZPgYQ+E24L1xnQHmZneJkKe7BOW9wd5TYRbXB40Wd0xt3nnv1B9?= =?utf-8?q?eCRHIrkf1QecR1Yw9Z6nzUaCfBmcrdIqng6wrxPcscgGV/WGXiBAAYUxg/ZJER92t?= =?utf-8?q?1cEo3EX2IsV2tXkdQi54OeCTd5ysEAG04lKXxIGsJW1ppR+PoHp+76J1yNU0TJ9Wc?= =?utf-8?q?UHbkp16zjNvy0yKWaOM1Cu9PoS3t14xc09X1ZcE7Ha0qzthFHCCgYivTDoVJ6xyzT?= =?utf-8?q?47UiGt71C7eCCipWgFb9l16fZ95a9V3qCTNrgIFtcEfM+P3O8yI7/Kc1ZGaxm1SOR?= =?utf-8?q?otStcY8UgzKL4zQUNCyqd9kqfJ0AsqIWnavBA8kWnD5YIyTK/M9RYZ55f73WLS5xz?= =?utf-8?q?7CfFMq24PZ4fnnQpKxhTlJ1EG79iehGYg5gmlpeFBgSSzp5Mse3J7sad5mHzMRGEI?= =?utf-8?q?dlT0zj3PvHeCDKDaVyKVPRP/0J/h9QUi37/aWrO0yXVELwJZZJ+SqPWr7sO/I5m3R?= =?utf-8?q?/Kw+aqORANwcbmmy79KEOtyx3/1mB4wKZlYaglvYC4NIctpioycsPs0EXl2q/1WnC?= =?utf-8?q?4Xb4m9CJ8C0UnuizICRzOBL6u6SPBASwwIZqwkOGhLZvASGbvu2D3urgkRtrfxg+Y?= =?utf-8?q?kc3W6wieSRvA+HlNj4d9v0EDKlDCSi5y2mqvX3nXWCkgFE6bhux/8JgIhikWqNHzn?= =?utf-8?q?xM5n0FXuPpRVGnAuUbAQAaN6S0Lt9YMnlqfOxVE6cUkMYR7OFYxKeHO2ElVymb0Fj?= =?utf-8?q?To/ZEJGhcYxyZNos50QkPq7sfUUPd742BhpT8s0H0dnwqXXnn1DVwmYLxVgmu+tr2?= =?utf-8?q?pZX5wi8tOapPlGuLrv8FjTmBUXMqf+moIMNCKL7BNIXoAn9fuymjWJFb5wRj46syy?= =?utf-8?q?CPgugWQh+SMZwrIfSAPeUa7mekFToDvl5WukYYoXaH/kuZpnZub9J9P1pHt+kB3Qj?= =?utf-8?q?Hy3P+ZPjzkg4UA1nayo10R6sp4duF5i4IYlbC4XKUSqc7egaoY1WgaMFJXgUfCy0p?= =?utf-8?q?02Vx7p//w0cZQlPVgnNunU826vQownaWZsfW6NilZFOUXlgrfjhlbsny+3mpKaxez?= =?utf-8?q?xIJrR9Exd3keSCiGCqlIkvI//GFVxkEkSKYlLt3kwB2ddtYYsSvlzx6EaVu3d9Qfg?= =?utf-8?q?wlZUi/fh0JS2?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: afaafa2a-a1df-406b-e7c6-08db8e6f798a X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:02:43.6893 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DKFCjM3yAPKXNTcm+9+ZYdlmR4IEkMDe8J46lnS4KWVknFJv2Q8R8HROkkunF4s8ATzAWhGELBuhOTuO2z4gTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR06MB4152 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Returning an error code in a platform driver's remove function is wrong most of the time and there is an effort to make the callback return void. To prepare this rework the function not to exit early. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li --- drivers/mmc/host/sdhci_am654.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c index 7cdf0f54e3a5..1cc84739ef2f 100644 --- a/drivers/mmc/host/sdhci_am654.c +++ b/drivers/mmc/host/sdhci_am654.c @@ -870,16 +870,17 @@ static int sdhci_am654_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); + struct device *dev = &pdev->dev; int ret; - ret = pm_runtime_resume_and_get(&pdev->dev); + ret = pm_runtime_get_sync(dev); if (ret < 0) - return ret; + dev_err(dev, "pm_runtime_get_sync() Failed\n"); sdhci_remove_host(host, true); clk_disable_unprepare(pltfm_host->clk); - pm_runtime_disable(&pdev->dev); - pm_runtime_put_noidle(&pdev->dev); + pm_runtime_disable(dev); + pm_runtime_put_noidle(dev); sdhci_pltfm_free(pdev); return 0; } From patchwork Thu Jul 27 07:00:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707381 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BABD8C001E0 for ; Thu, 27 Jul 2023 07:09:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233171AbjG0HJY (ORCPT ); Thu, 27 Jul 2023 03:09:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233298AbjG0HIK (ORCPT ); Thu, 27 Jul 2023 03:08:10 -0400 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2091.outbound.protection.outlook.com [40.107.255.91]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF0A049FA; Thu, 27 Jul 2023 00:04:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FgbjmGfMUG4FyTuiT1cw74YlwgVpH/bY7/1m7Ogc5bu+c8XBNvVurO7tXERO0MPktQq/Ef1w9b2OTZelrBOm8ZmoMB/8SIbAvpsSSV1TClWGeqhr4Kd04CGe6rtSK2laAgXZIyJI4CYVh0qzS4SY5OHndJx6AkzU6GQpsIvS7aPHCFNA2tAuus4k1JZks1oNrposB2+vSEV+WWB3aY94wkLUoRdQs0qW3QcweBY+iTJTKWgSp5b1ajPKVhZpRE7c/uKH8QRek+OLb2xYde9SfS9AtQjFIr3Pll6tZ52DUsWDhAiRDFUSUD19DmieTj4CsC2U860X3yh6wKq55VeKnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ea1uyoB9OAes3hLHcB2QP8c9cVmAH7ysXueKFlnpsyY=; b=csrNYWkiadUz/0eUNkFOmJurBiJqlJRX0whvRK39TPhXOqm14Rc36ZrBX9Zt8hQ5cZsQx6wLYIzS7djVaUKjhhyYOIWRGdruaIGBJexPwzoR6LAV9uAIRo1WU8qpBkKdrOyvF1fjZTz0MVz30Y7A31524yPlKUz1SAkdG2e/GWL2Q7waAvMrMelblaIpONAsdwKz0Lg0hhR3q85fezTRcjDLajG5fEhjb1rOYXe3bc4dDds6Z7lB7LydDcK+2KOVRL9e0HuwtK0+xsw/iMQrZdc3VSMHB4+giG36YL93qNaMhPRSxbxvvGip2OPU8GO59x14bmbGJYPDfarybtbL3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ea1uyoB9OAes3hLHcB2QP8c9cVmAH7ysXueKFlnpsyY=; b=Hn3q31PsTVEgtF4Ub00cSV6fkhzqM8PuvcnpcE7C6H71OPzLsVVrl5DByv99wuPYdC+9ZhjimX/pUMClKhCz0pusYuAEZ0ULS+FdfQHAV35m6DUR8f5OzRxx8Doa1+AEUpcTz66SPhMpce0D+ixDOz0u6RSwfeqn3MgQzjov9KSjzYefEqYKzpJnAtZENPiZs/skrtcDGKGYohLDW6DCuFcVcWsN4DrQLSG79DB83oVCeHmKQz8U153MfoidpCT7lOSn1oA+FfCK5TIYjGnYmRrI67HD8t0qPIKkvdeUGZyClVlIR+TumneMKO0yAfITQ2mYIHDLE6amlafGgqk8rg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by PSAPR06MB4152.apcprd06.prod.outlook.com (2603:1096:301:34::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:02:47 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:02:47 +0000 From: Yangtao Li To: Adrian Hunter , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 60/62] mmc: sdhci_am654: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:49 +0800 Message-Id: <20230727070051.17778-60-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|PSAPR06MB4152:EE_ X-MS-Office365-Filtering-Correlation-Id: be7a9570-4a16-4db6-bea2-08db8e6f7a6f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BVrZ+K9OvOpUmae369NymOq4bn+eqzZBBQKOyNIUJKHAx5C0+KmrFgPAhYWr3jQ6gewTqHxm9SzJtoDAt4oh7DfSva3jFBMaqKm5T92Otl1qUWvdQY0FNfE1zESJA2ZoZkq+b0LmUc0XEZGusvqTwkjwJEGNIFSWPYn/lpMOBolZuUAEt+4ycbsAUkdzVHULcOd2t0sDvGs6kbnxfH7ZHD3xxKX7qrFneW+LWVT/CrJjQGfyaQmTGlR2W+L2RJjPgoUEr92qEz4DGtctPyoAwRZeWz8h7vXbM2lDv6fTaQFQRJjE6pxj8uvygUjy9ZiH2eHqBH9lOgUwh7O/qW5HSOSppyPeH3jbqEXpoT+7AoI8slp7N8NJvjP3SwKijQHIHTpQGHSIEiBkZ6/lt/bL3/x0r6ase8KnNIOskaqi1evtmmQkhHj7SKGnkVaW1xnZSIrVgwA8WAkitl1C9jnFhFSvC9LReoJhevOlX2ZbzMDAn3B1nSmnyoNTM3SgnENCE+syRmBDCSyWCv1fpCdOBbuOi0xFkgVS39zd4NGnt5ow/CiRPielv1Fb+nrWpbfpy0jHhIT1T/DoGM5Wp8vDCwf0PRlbMXI8YBp9U7FoDZCw5zYvVnOCeiFLxLEY1SFO X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(366004)(136003)(39850400004)(346002)(376002)(451199021)(6486002)(478600001)(52116002)(83380400001)(26005)(1076003)(6506007)(6512007)(38350700002)(38100700002)(66556008)(66946007)(4326008)(54906003)(66476007)(110136005)(186003)(2616005)(5660300002)(316002)(8936002)(8676002)(2906002)(41300700001)(86362001)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?NLTmzvo+r3c/2jCdtOSWfjkoU+Bi?= =?utf-8?q?SDf4aeVAfybCfkZipEBdwBqqkh1HHRtOVqUKqgYZCHoR6nzMkKaG5fhwb7rMkXUYM?= =?utf-8?q?Dm8pIZSKRFeACJ3dplapLyy896Hx+TtMUKTTT9ozvQ0k7BIuGd90pEW51wJ2SZfUr?= =?utf-8?q?5dcrZrxrVeo1HpRMPXkMx2xMzTXPP2jAbRXbPLhdQZcq9KgNYIOC50vOH6wdAU+Cn?= =?utf-8?q?7AOmg70j43OouopRChVDjvM7BGSxBREYz3GEtKrJGtt++UStdr5po3U7jBS0ZieJZ?= =?utf-8?q?czckdC0eoYyz6RN/ow8kvI6K8DWWPYTDE/2ORA/CB1AClY/D2DhlChIvz4IH8XE24?= =?utf-8?q?2TZOfZf7PqncSXGkmqiPhN2PtCGlcXpOpEPI4ipx9SDAYus/Q/ltOxxLv9uKW9pwz?= =?utf-8?q?UlmuK3kdOKuDIwfSarMEtg8baFRQrFy0stxp3/du2tO6n0JdgF6F4efhpqK7EjHHm?= =?utf-8?q?BSl0sr5X1sinLzqtR9qY2ljUlJOzfkgByPZlof/+v6tqFzm7q4hxeVpDWr8H0K7w6?= =?utf-8?q?wslN0c6VBkvM8Uda0NjJ0WS12pOZFR6e3v8zoJl1gYp28W667tXgbY3ci6zNJ+QUr?= =?utf-8?q?JYMBxeyB6VUaNcdplMRVJCj9E7Vrk1FwRgY8QvvFJ8+VTV7HGbDg8dXp/BGdJHl6H?= =?utf-8?q?SfhxIJmz7/TAZkyjbazDV5sH9BpS1BAfm8Axek/fyODQpD1L8bvqdWXjHn5T+VqCl?= =?utf-8?q?YtTW2n6zO4PmZybmigI3NZJjo1KPCIGw13s1no6w88dcZcoufWJRfUkw5xZIh/CFL?= =?utf-8?q?qK0YBU+WpN1J2FS9oB2qLJST3ajT/Jg2yC5AiGkYfCcBe1hUbRSCuhyPlB2xytoZ0?= =?utf-8?q?lSB9NtUU9dfCd42Akl22k01SDgmZPYF4EreHE5XHljuA/y0xws5NfDKRtXZzaVz8s?= =?utf-8?q?GFF9E+MUsDQ8dei9hXpqW+jt6KkPBl8QjznOiYGq2/XfqPhgJGDm/9HnrYKt6o2bi?= =?utf-8?q?6kUBD5A8FtDhJPVegTpFXZy5+ONzG5FvrGpzzEmKeyO6BTNKcK0NMLguyq/REph0J?= =?utf-8?q?rBrh/M5McNVuvO6bwJDvRvq9RAOvd+iWp7qPSnH6PX7mK0mT+lUt0yG5Uf0Co0OKk?= =?utf-8?q?Oe5i34EErzCqLZunKibeKklt6nuX7vn+8DhQFONg8HjRHwQgaSjIbm2BX2WMBTqTZ?= =?utf-8?q?gM6LjiP1TBgPVcUkhu1qVSM33kzs0gtcX6RalXR/zCxf04qXPKy+Xa+dcSyukDoQg?= =?utf-8?q?KbiqGE3wPGDC9DIizvxzkHiYOP6nj4nU7C2ieWgtyINZ0TYWJbt+53snBK7nWgXKF?= =?utf-8?q?/wNuGEITtSO2/f48H1bc3Zww3sWDpMDUFMNzzx2806FRmhywNvw1kD4hlHQfYUg/F?= =?utf-8?q?dbmA7i1D8T+28Ny+1FFCr1xuCThZAMuE5CArzvojScCJlGINFEhG9/Zx4FpSVhM7R?= =?utf-8?q?W/FkiwpoPbRlHn08gyZ+Rce9/OGxeJRxi4YZbT+fkScdLM3RXVafTvybu3/yacjW3?= =?utf-8?q?TG02cW5ASGAFk1T8csgcN4H5lacs4T/TpPg2rcnrdoFr461M5XfrizMm8yZdDBRro?= =?utf-8?q?XT88lMHB1SBW?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: be7a9570-4a16-4db6-bea2-08db8e6f7a6f X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:02:45.0923 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VqlMwAEra4lAqjyvVDHWctf6k4zkM7lUv4z0QDextpF5I6Mh6pTIq108rYffm86asQ9BWMhXP/8PVPIrN8vP3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR06MB4152 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci_am654.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c index 1cc84739ef2f..c125485ba80e 100644 --- a/drivers/mmc/host/sdhci_am654.c +++ b/drivers/mmc/host/sdhci_am654.c @@ -866,7 +866,7 @@ static int sdhci_am654_probe(struct platform_device *pdev) return ret; } -static int sdhci_am654_remove(struct platform_device *pdev) +static void sdhci_am654_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); @@ -882,7 +882,6 @@ static int sdhci_am654_remove(struct platform_device *pdev) pm_runtime_disable(dev); pm_runtime_put_noidle(dev); sdhci_pltfm_free(pdev); - return 0; } #ifdef CONFIG_PM @@ -994,7 +993,7 @@ static struct platform_driver sdhci_am654_driver = { .of_match_table = sdhci_am654_of_match, }, .probe = sdhci_am654_probe, - .remove = sdhci_am654_remove, + .remove_new = sdhci_am654_remove, }; module_platform_driver(sdhci_am654_driver); From patchwork Thu Jul 27 07:00:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yangtao Li X-Patchwork-Id: 707387 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92608C001E0 for ; Thu, 27 Jul 2023 07:07:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231512AbjG0HHn (ORCPT ); Thu, 27 Jul 2023 03:07:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232371AbjG0HGs (ORCPT ); Thu, 27 Jul 2023 03:06:48 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01on2090.outbound.protection.outlook.com [40.107.215.90]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 136F72D63; Thu, 27 Jul 2023 00:04:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dlcljh/lY1roGLeghwutf9d3JvuGcx/4TiVIW55p02f+xu49b2MTfBQOniUPGikCXIMJtelOncn/gMCqrZQpQQ9huz9+JoOrWf/D9cE0bmwZsm7jcQaS62A3Dv5k8khvmYtqgNNZBE3uYt0APaTqnvkhm9iELlxG157o0Hav8jjqHacQmHL/W5SMTWTb/WaD0s09PFaWWLqYRyzin0lipEtL1lWGNe2tDjwLW7rDgcvlcosSXBMjPPfM/N9RVQ9GCMs/nqzC0YjtzAdDYUqzj2+mbeESGBB7lahvi4mDHN2ycKwjTtFX1CpPAKkBibQGYZgsBqeeSXGlktyYLJVQTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UgkpH6iKKcR7a4wKXniEGd6Oga+gRHlJdFEF4UCfl5I=; b=KOAOPs+fIAV9iDZ4amwmUmFAMHR4HUow+VBhoHEYY5IUlahA4o7Uo4a5EEm6wGpuBNUA9qR9zQnSWouI7X2hdvplZ5SlmXgXkf3U36hYpWM1X24gIVKLfXVPxIGxjZ27SppUFV10Ru/Eqw7U/kDlwpYIsVlxE/cOlpCvntZXa/Uwe2R6qQS5SAaZgGBnNeHXYOWlewBygaw0BjqluN+ywLDNmIfNM8fMH0TLGN5C8q3D0j6EDcIJoQJc9x5tCmQZ/mPRDghZzJHbFdFiPFvkiU5ANcynuVZRcswD0QaVL7127cGIkc+xTi0+CteDTbb5r5mfLQbUuZYfWW1NknniAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UgkpH6iKKcR7a4wKXniEGd6Oga+gRHlJdFEF4UCfl5I=; b=fa5NxtQjNgF/XvnDgEBbKlGpeuQhPHR4vKWfCYlUW7KVHxLPZNjFnRDlmM6nmfW1VLq5cWokCbzHHB99N/ScTBgYL47xVEeu/jrUoPkHROZNiYyINEYORdJt6xp/loG7YII1RLqB/qhncUfB4A92PIt1T2st2HKaqL8PO9LgOsttTLr99W6ybVu5Bgknl69q6+kvCTkfomAscybFmmw3ZkD4UwQDfe6BLbGKwVEzJy1n8T0voyCrXIMTbTu+IJWKTTrFj0aMrktAf9rF2A0AjdyEa45dF+tsxiwa9XHDsV0PepXimOyh8i4PJ46iVvKPaOxhYaf4DvHWhxSKPib0mw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) by PSAPR06MB4152.apcprd06.prod.outlook.com (2603:1096:301:34::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Thu, 27 Jul 2023 07:02:47 +0000 Received: from SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b]) by SEZPR06MB5269.apcprd06.prod.outlook.com ([fe80::732f:ea1d:45a1:1e0b%3]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 07:02:47 +0000 From: Yangtao Li To: Adrian Hunter , Ulf Hansson Cc: Yangtao Li , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 61/62] mmc: f-sdh30: Convert to platform remove callback returning void Date: Thu, 27 Jul 2023 15:00:50 +0800 Message-Id: <20230727070051.17778-61-frank.li@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230727070051.17778-1-frank.li@vivo.com> References: <20230727070051.17778-1-frank.li@vivo.com> X-ClientProxiedBy: SI2P153CA0017.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::10) To SEZPR06MB5269.apcprd06.prod.outlook.com (2603:1096:101:78::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5269:EE_|PSAPR06MB4152:EE_ X-MS-Office365-Filtering-Correlation-Id: 1212ea1f-6995-4399-47e5-08db8e6f7b46 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o7B9fHdbSVjtabl/FnTD+NnstSLfwtNZL7JOMlqHsCuDOPjG2YczKfeQ6M7CdTRiyU9LBVZZb1Z11p6sL43wwjPz2PzNrrFc1cXEMuhf1A6wIDLmLrPLBChNX7SvK1tXmwp6pqb7lYgEqAfFiyrpOyuGuFP9dkWGpsUvEZJON+QhcApGkWlB9CNkiycqUt9W/+M7aAW9CauEo1+dhkMcahtTEoryngTGj7sVZrt7nvY/Lva/zRNyPiFmXGkYXaN9nFHtSXkUnFiUQqza+Aa/sa8oVSBp4Q/EBHRMKWkyh83cAy+pjL3GB0twFe0+6GCNXSQyRcYPuKKuZOadLpnHck0DesRlI5lMUT49+9wWtuJgdnMS9K857yv3AFBF/I7UEhwhS75oKUdzKSKACTUgLGhXpU83Ufcqc/MAzmMHl6jQm7WfBCgJmM9wiX09pfunwNLa7cTIKBB+Mmxo7Tvzk2Ml8YrSKMSLZctMMu3w7Wq/NdorqYFASfl16oEXngj7/53kyyiyWLqzhgCSFSF3PDj+aySBCFaC9KNGa98Sod4jUrH5ZBCpF7Y/KTpPfkqdqsg5pJpIQl4xhqYa+Ew/FlFMpiyNhhsl7mu3kLZiubEhTYPXDASxWIxOdhg8m7mQ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR06MB5269.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(366004)(136003)(39850400004)(346002)(376002)(451199021)(6666004)(6486002)(478600001)(52116002)(83380400001)(26005)(1076003)(6506007)(6512007)(38350700002)(38100700002)(66556008)(66946007)(4326008)(54906003)(66476007)(110136005)(186003)(2616005)(5660300002)(316002)(8936002)(8676002)(2906002)(41300700001)(86362001)(36756003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?drFpk9SmMR1A+Qchkb2ZsPf7KGRP?= =?utf-8?q?CvV3dp1ST4QjpumpCDktChqHExPixfIGICOP8WO8ECwLFOsa5qDXFRh1dgH+7BkMi?= =?utf-8?q?bg/0SdFei25oyAQSSmsTNNFuc88iafgAA/YyJmg3DwcNVacUckg2X6WMd4fst29G9?= =?utf-8?q?0L2IML9wlnGVRVzL1mMWl/LHTEx4Fohb8ljXeN8Qu7H5vf3s7fw4mvEfxNanafdsT?= =?utf-8?q?BEwSBjvBv1bgAxdaCSAwNA3YMJzkApieU841bI6HLhHQElngI5fQdMzF8vkE0+6k+?= =?utf-8?q?guR8zwaG+YufpHPs1gGqcyGR4EFdgzNKWcvjjcf1ntpV4O1LMZyIJhDVkjAhFFRXD?= =?utf-8?q?fEG1d6KH7De6atmCnOzSWXJI32/pJlHT91cwIC/jRxOFrhx5M2dIcYRF4fO6oZaQp?= =?utf-8?q?dmZyeZT/x6naAI65EiHQ7P0n5TrUtlBDnQ7BzWBIloLcFgJQRMg9hqWK9s26AEp6A?= =?utf-8?q?0Xrfx8ODJK3+4pDPFZFBlp/SdzwMrUqaoGxYBriyi9K6bv6Vmh2jyfo4bAteVtf6m?= =?utf-8?q?0B9FoT8Sesq65JoNpAwC0u0lZ6NWAXvoAKJQmdVKXajuKebvMw4snOB0Q7Bh5g6T7?= =?utf-8?q?XCELSjsTSD0XT0uIlG1TPpb/5ijkXBLoIhkZZLQMjnZ5wWB5FFqNZfVchYnc6/ffn?= =?utf-8?q?S+bbTK1oK7ki8HBPsQmXvOU9HChqBpd0vQnXvk4TIMTYK9Cq6mzeztM3HbTYyPGeA?= =?utf-8?q?ZMcY4GiieqzJ36ZMGwzsOllR5ksKuMg3BRQUaEW7O2JVz0mpdpheDYUkBJzzaLMOA?= =?utf-8?q?2kY2+/KxJcA0cdXxtqCFd548razSecAuSrV9mEN81BZbIaBcodBIuHoj51YEQul1S?= =?utf-8?q?gjD+lBIDMS4oaw/AM0rFeRZbArt/VmNM8rgU/HlNM6IeZq3iGviXksurQVHuzRdyr?= =?utf-8?q?Lv8XS2s3TL3f5orFn78LF5PC0KOn+zi4QWS65eDfwAWHioq0rtoTv9pbWScfbn/Xv?= =?utf-8?q?90dmOcmjAFD7TCn8QJHSUnADukc833KPrZmNPhdwTWVYKdq9mfjqMtD2Gvm5bHLsQ?= =?utf-8?q?Gc2Fm5s42JrCXj+HtjxBj+y8dlbpMd6NBlq3egACO4Ht1XvvpqNo3toDzID3w783X?= =?utf-8?q?iCveZpx/tmZb5P2Yu8Ey+ofwPK7MGap2Njh4uRPmVPp62voiNePKMmkYFiaNnWGjp?= =?utf-8?q?u3HV+NOak781irOMyLos/H/Vs8SIm960sbmI8yEw3WEB9vpeK7ZLJ8BxO7ecTvaRL?= =?utf-8?q?VlFGlZktjSo1k1pMvgqHJ0ZpgEZq4iGtBK2bSCjQjvdA9YhERTuEkycGQHz8glZVN?= =?utf-8?q?U/c9qcGDLrmyLYAB2IrMoF4qkjX0AmJp2+EPzchOE3qeM3IQSPO4I//AF6jiAA3K2?= =?utf-8?q?ZvEZXFCllgo7Gghb1+yTUffJAIBE8FSKxlSGUNS52tgla+p+BOxBIsBKxFLT4UQSZ?= =?utf-8?q?0HhcoWgBbQlA8jiDzkbyUxgKYB5rgln6xkC47+L069SWhM0EaI0NyqpD0U+VcYWhZ?= =?utf-8?q?8SjWrHAtKD6GpZfUJ0s1oT/uPJqZaPazowU2DFJ9l/LMLYBhFrAEMguXZFWHGzIyz?= =?utf-8?q?mKqmmteSq1Nf?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1212ea1f-6995-4399-47e5-08db8e6f7b46 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2023 07:02:46.7675 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BCrOr199+mh8cbOIIhI4Kve+/3kkp3YQ1zZvXpAP1XICvWCW/rpNM+6SnG1p7YwBaE/8wuisImCP9h9KpxerBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR06MB4152 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König Signed-off-by: Yangtao Li Acked-by: Uwe Kleine-König Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci_f_sdh30.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/sdhci_f_sdh30.c b/drivers/mmc/host/sdhci_f_sdh30.c index b01ffb4d0973..840084ee72e6 100644 --- a/drivers/mmc/host/sdhci_f_sdh30.c +++ b/drivers/mmc/host/sdhci_f_sdh30.c @@ -206,7 +206,7 @@ static int sdhci_f_sdh30_probe(struct platform_device *pdev) return ret; } -static int sdhci_f_sdh30_remove(struct platform_device *pdev) +static void sdhci_f_sdh30_remove(struct platform_device *pdev) { struct sdhci_host *host = platform_get_drvdata(pdev); struct f_sdhost_priv *priv = sdhci_f_sdhost_priv(host); @@ -216,8 +216,6 @@ static int sdhci_f_sdh30_remove(struct platform_device *pdev) clk_disable_unprepare(priv->clk_iface); sdhci_pltfm_unregister(pdev); - - return 0; } #ifdef CONFIG_OF @@ -245,8 +243,8 @@ static struct platform_driver sdhci_f_sdh30_driver = { .acpi_match_table = ACPI_PTR(f_sdh30_acpi_ids), .pm = &sdhci_pltfm_pmops, }, - .probe = sdhci_f_sdh30_probe, - .remove = sdhci_f_sdh30_remove, + .probe = sdhci_f_sdh30_probe, + .remove_new = sdhci_f_sdh30_remove, }; module_platform_driver(sdhci_f_sdh30_driver);