From patchwork Mon Jul 8 12:42:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 168625 Delivered-To: patch@linaro.org Received: by 2002:ac9:6410:0:0:0:0:0 with SMTP id r16csp6503183ock; Mon, 8 Jul 2019 05:43:28 -0700 (PDT) X-Google-Smtp-Source: APXvYqzmHRUFqZeyEnjWm23KXaOmJ8ahJu//OwHI4aJewcP6i5g1yXtijIcQosxznKIAUH5RpIwC X-Received: by 2002:a63:d0:: with SMTP id 199mr23435544pga.85.1562589808039; Mon, 08 Jul 2019 05:43:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562589808; cv=none; d=google.com; s=arc-20160816; b=cyEPgJWUD0ElkF03VgMx4VVrvFVabX9pa5En/YZrK+UVX73Ocui9P0tu3jFeCLmXJD UnJsfENoE+wue61ss1jB0JPjeQYIMhS/tsX4xZgF3BO3HzAfgQ4CQvFLEAaN03XBb7Es JOMk/BC7SPmd2FjcA0vmXeGPXhUWgDF0rYGGxKUiHX7tapNgz/af7kI309FcqzUZbluS nU59nZfck6AxjfQ8iH668sXaXGgoESi1nheaRqEJ83BEZarLn9PTLbhE510XYPM+KEUe 0d2LUxVfZ8N8Y4cw9Nu5t0NcactD5+2AxtI3Gpytgt9qjeEEk/aM0h9f7WfFTHffoZv4 zxbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=PwFHJQGlL7c9RUcZjy0sA4Reqz7pMArMsCYlUC6e16M=; b=e36a6gVU17Tmf0aluwoCPEITk00Jkfz77yYvzP+b6Fme7rEnkdg8VBk4PPoYRfUNQZ HAkernXTSPi6j+5trWBY0evOHL8CFVqyGW1ZkPb/FXkpnf7AXnk4f+Yd7BYmVoruiVZj tV/3AqpSeExKnGoZrHWcOlXPv+YYzf3tG66wiL9oQDgdzOmjcYaIVONM7IPFnLCkIJSe /K/QwjQ9RE0zJ/Eub8JkK68T+wQuEu9fN2LP8lnEGw6dmSZD8MmjuPzL16w6SuQY8GjD 3eKUzaAeqk3liLykxoJDhHzJNLWXsfvly3oEUlb8Mihv0wtc3+5pg/pa/JySrCBMcA/O sddA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i18si19375627pfa.23.2019.07.08.05.43.27; Mon, 08 Jul 2019 05:43:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730714AbfGHMn0 (ORCPT + 30 others); Mon, 8 Jul 2019 08:43:26 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:44587 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727052AbfGHMn0 (ORCPT ); Mon, 8 Jul 2019 08:43:26 -0400 Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.145]) with ESMTPA (Nemesis) id 1N9Mh8-1iY7ev3NFE-015Mij; Mon, 08 Jul 2019 14:43:13 +0200 From: Arnd Bergmann To: Ohad Ben-Cohen , Bjorn Andersson , Maxime Coquelin , Alexandre Torgue Cc: Arnd Bergmann , Fabien Dessenne , Ludovic Barre , Loic Pallardy , Arnaud Pouliquen , linux-remoteproc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] remoteproc: stm32: fix building without ARM SMCC Date: Mon, 8 Jul 2019 14:42:51 +0200 Message-Id: <20190708124311.3448056-1-arnd@arndb.de> X-Mailer: git-send-email 2.20.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:AkGDgfgp15g2CwVR7Facqvx2UQWGiD85o226q8pCrj+7T3ngYhv IfLF3dxuiyn7foiSJbI+CjDMOWeNFw4kgugGEH9s7CEP/ITyLDc0js2XWpv06vcn8jwcVdi htFSeTonIiSmWhiJ6NokkctrmpdXI6ajXctroI5KnraqIYGMuHO339AkvcR2SGhILxsSPPp oXbARlZOVAkKCNuffxW2g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:NOG3AWT7dhY=:I1yuk6/XhruMMQoRCnVKYH Dprmazilp2kNoyya7NhsRMMlH3fEEHyN+t7vYmASH7wZsnO8z9QnyNDYZD8PoF3PYbRSudiJr beYiBGXOaQDkiZAklGiIcNdrspzn35663iyk0GQfGE9iK7UrGgJIHznTWOtzrtjtNLGhAYLRr vVp1P2qtvMpmIk01cKQUB4BMDTDMHGU7IkkZHt+PtfqbkJD4ZqaPyNwpAKBnnFtEHJThM/rOc mTKdXDWuUc0e8XsvFrwD8FN+5L4eBVlO0fkt2Bj8deLez+mlSgC75Bk++RkbBTAXKgtqYwlj5 4Ir7mGd2pIZRTZk1Hyb5EKQdvhWXWClUp2sRj1lKVTQ5wBq2zhdk63UKWUmr16rgK+CdZZteb XEKXOIEAfhTry3H0vfA8bm8WyJy4ZaJF7vFLzmxLit52Lt73TE9XN6giBVvGYS+hdoNcbNm3C GCDm3qZZYwx9kM2wq/NoJE3S7283goKM3I7NfeaNIzon+gR9SQCxDQIE1OJOvrIPulXpjd51R 0tUD9uoBueidEyEuuoRo+70FeDZZgh+PxOSgJFtOFxfS25GLarZZN5Ezaq+wacrZQ4DVFqZ8S kmm1yamO+hiwkGBvfEC17KEgSZoRmfRDrGYdwG1X842K8zQCkf/Yrxw5PaPEQMtlk28+F2Qie Clb7hFMAFS8EayWbwBwUwmuGm8WCiTDZ+uff7WLeLLuCyLgm+yfCb2YL/PGJrq56E4kUi6UcY asXjZrOREjS+2fK2M//YtVvqIQpUbo66EFHOQg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When compile testing this driver without SMCC support enabled, we get a link error: drivers/remoteproc/stm32_rproc.o: In function `stm32_rproc_start': stm32_rproc.c:(.text+0x776): undefined reference to `__arm_smccc_smc' drivers/remoteproc/stm32_rproc.o: In function `stm32_rproc_stop': stm32_rproc.c:(.text+0x92c): undefined reference to `__arm_smccc_smc' Make the actual call to arm_smccc_smc conditional on the Kconfig symbol controlling its implementation. Fixes: 13140de09cc2 ("remoteproc: stm32: add an ST stm32_rproc driver") Signed-off-by: Arnd Bergmann --- drivers/remoteproc/stm32_rproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.0 diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c index e83077b9ebf5..e2da7198b65f 100644 --- a/drivers/remoteproc/stm32_rproc.c +++ b/drivers/remoteproc/stm32_rproc.c @@ -344,7 +344,7 @@ static int stm32_rproc_set_hold_boot(struct rproc *rproc, bool hold) val = hold ? HOLD_BOOT : RELEASE_BOOT; - if (ddata->secured_soc) { + if (IS_ENABLED(CONFIG_HAVE_ARM_SMCCC) && ddata->secured_soc) { arm_smccc_smc(STM32_SMC_RCC, STM32_SMC_REG_WRITE, hold_boot.reg, val, 0, 0, 0, 0, &smc_res); err = smc_res.a0;