From patchwork Tue Jul 9 18:48:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 168770 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp8919546ilk; Tue, 9 Jul 2019 11:59:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqyymxxcP/A5Dxg55/Che0kEGb0bj5FqxPDLQd3F9uv3fhLSdf9vSXqfPCZw/zzgxNHvuhm+ X-Received: by 2002:a17:907:2114:: with SMTP id qn20mr22826985ejb.138.1562698741874; Tue, 09 Jul 2019 11:59:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562698741; cv=none; d=google.com; s=arc-20160816; b=vcNskqoLdU6FnnZAnBZU5VkRuztoyVk2LvCq3u17rz0JUuAHnGYsCev9gpWb/WP7pP IjkNoRowWlDTClkbxCEwf72oufxvGZT8hLMPr5DOMwYX7jAYvwhYh2w0GcC6Y3tLaBeF QeiCCBE+WUSHpYkaIQuvUtvDvoHEH9D4GUqn8zSntmWNjcTDPXQtooqlDTmin77BIdf7 nRDVyvNfF+5GoHf+32HPNeiJoSzsKKpLG7quMx3axvigVKQjHbVtejo+tkyPCIJS7dXr n+qtEaFOuIP5L6A29BA3Oxw26f672Jb0eBQg4hcxtqIJ5DHmSSbvDyufM+ecbArufeVT 9PUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:message-id:date:to:from :dkim-signature; bh=gDlgVI25OoW0xspyfr2L2TQqUz8qHKNkpsVTkhApndA=; b=XfY3nwYgfycMb08oOS99m5wyrCqC7gKHoLOxq8CW1UadW7PjAkMvLvp6gKmHJ15t9y K8RTix8yq6nSd5S6OfnZnYtwNIu6mEHgMj3uQdtwBYY4F0r3CBmxzsVCuv3NiRdpuAsF oQTPzzESZOsV+2tp7+SYgw0wkrNi/fwBxoByowdh9/VzAnXXl7owha77d++pXx5w+9q3 QamJoa7BHGo08shEo9YrsBggCUaZd5HSYpMDkG8u1rBVsCwCsw3dZy+BOdoQMP3DbdlF jsTOsp+FiN6dEA50VuIDPj7fh1b1/LNQOWbbDPkYZ82lLJgol06StqQ0oMomdHk6i7uj JMxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Y2i3TnB1; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id o5si13619658eja.221.2019.07.09.11.59.01 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Jul 2019 11:59:01 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Y2i3TnB1; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:52878 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkvKO-0002v7-P5 for patch@linaro.org; Tue, 09 Jul 2019 14:59:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44062) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkvBL-00034j-Ej for qemu-devel@nongnu.org; Tue, 09 Jul 2019 14:49:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hkvBI-0005pE-W6 for qemu-devel@nongnu.org; Tue, 09 Jul 2019 14:49:39 -0400 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]:36868) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hkvBI-0005C3-JP for qemu-devel@nongnu.org; Tue, 09 Jul 2019 14:49:36 -0400 Received: by mail-io1-xd43.google.com with SMTP id q22so23588712iog.4 for ; Tue, 09 Jul 2019 11:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=gDlgVI25OoW0xspyfr2L2TQqUz8qHKNkpsVTkhApndA=; b=Y2i3TnB1Z88m+7WBQYUSSmoBQKpq4tx3IJGeyRurWMDYA4y+WgB2t3IDuv7Pq2IG0y KxZW2/nJX/+LuXcCNOlVkT5a9eOfBpCyoSe7XGIozo3ACR+OONl0B/k4jYFdPK0+6Y5B vJYx6txXBBFPRr0a6vbkd+o4y75yEd6WKM5H3hO6/XPIlkHcny4l14Fdrn06kqDV1U/I DcOGyPSiXa0w3hg2jd7wtXcQN62GxpB5A2nauQSb/GGYbulZ7CPLzHJRACVS9WiVGUlQ UFepSwssX3i1Uejbhd1xvqr7Z6SktrmrLv0njyod8kQPRQVknoqQit8VA9EWY5fKeaav a3YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=gDlgVI25OoW0xspyfr2L2TQqUz8qHKNkpsVTkhApndA=; b=M3e7/8Kri8y/mpw2n3TFxU5LvH/GLQ3hQ2QF73bG90U/nrDfdBmOAYkcec2wL/BFIX M7Re7begoWPMnugLo3jlR2cvTo6wwZz9IE7bxZI/rA5ReSUfOpxqgHr4yk3wvD2QxtIZ JgH3JQKbagxrI8ycEcFcOLlUyiH6qtyhEZvCgMds9KFjLu2r6Y0gLcvUrtB05P74g6bG OIC8GtfWdzsMWVnI9thE6Z6eGu1d50ZFem6ptSCQo+6dBXzU20pYGl1IVT1PmjpDRNWP VfirK0XIOhjblN7wMp1LFtyAPdPTxPmFIshWjNayYQHOCzl7L3jzuFPuv49vch2A+zWc RH6w== X-Gm-Message-State: APjAAAXQiIb16+Cy6Hf0YKW566BXaeQIpdgrf6VCswdlIrqeDlEsB7il Mbkdy5j4UBDvF0tVy7UbuHoEwtA3+vw= X-Received: by 2002:a5e:8209:: with SMTP id l9mr8516508iom.303.1562698112477; Tue, 09 Jul 2019 11:48:32 -0700 (PDT) Received: from localhost.localdomain ([172.56.12.212]) by smtp.gmail.com with ESMTPSA id s15sm19083349ioe.88.2019.07.09.11.48.29 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 09 Jul 2019 11:48:31 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 9 Jul 2019 20:48:23 +0200 Message-Id: <20190709184823.4135-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::d43 Subject: [Qemu-devel] [PATCH] tcg/aarch64: Fix output of extract2 opcodes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, beata.michalska@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" The aarch64 argument ordering for the operands is big-endian, whereas the tcg argument ordering is little-endian. Use REG0 so that we honor the rZ constraints. Fixes: 464c2969d5d Reported-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Tested-by: Alex Bennée diff --git a/tcg/aarch64/tcg-target.inc.c b/tcg/aarch64/tcg-target.inc.c index b0f8106642..0713448bf5 100644 --- a/tcg/aarch64/tcg-target.inc.c +++ b/tcg/aarch64/tcg-target.inc.c @@ -2226,7 +2226,7 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, case INDEX_op_extract2_i64: case INDEX_op_extract2_i32: - tcg_out_extr(s, ext, a0, a1, a2, args[3]); + tcg_out_extr(s, ext, a0, REG0(2), REG0(1), args[3]); break; case INDEX_op_add2_i32: