From patchwork Thu Jul 18 06:51:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 169190 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp1994039ilk; Wed, 17 Jul 2019 23:51:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqw4tscwXBaLmpIUosOtN5zI2N00lXz/VK0eB2KkaRFHtrU358DeTLqOAXAsiinxeIofcFrx X-Received: by 2002:a63:7e42:: with SMTP id o2mr45506332pgn.162.1563432706529; Wed, 17 Jul 2019 23:51:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563432706; cv=none; d=google.com; s=arc-20160816; b=pOeVTHdFN6jkYMgfqp/qE4Sjnehd+6Qswg3kRzfYioN1JWXEWSmKgLKnvbD1R94mik GSq9aF3vgvR1nLwS348CY5cLrcHHJfUHcWr74N/lnJfCz4e5mZYVdDn+C4ZdRVLjhyih 7WXarOHMoLL8RnqAVBnEl//ImAEBFQdxrXrxdj3M0LmnczDUSsFhrtmtgwrN1PR/cQNX jMf0cPTY4f7zvojRVolKTe1xnRktTZ9vBqC8sj8UuGhKpvPvMgdVrBqPi9ZmgCGuHSel LBNsh80yhfu8zCD/pv8KFuHDBFtkPxlL+xRq14cdW61fcONRkadRr1FV+w2WYnaHy/O1 tx5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=ZhDfduBxSN7i25VRGia8YNv8px3x7GeUSF1hPbqj3LU=; b=eWcMemW5RpB3t9pMiTEVSfdfGXf17JTzoiZeeRJVCqaZVINhHEp3Q4m0zqI+wAAcVr 2ln016VcKooYzz21S/O8AUKOORZCJUqGhWn7fE9UMVZNzXQyeDNGDYo2oYEh+MEuK9Ti js8mD/4Gbyes/n6Zry1hZtxuK4Oe7CgJqZcytAc5ckpjDdoLjeev1yJwJikaNZA6t+Mn 4/vZEG+CUi81H+5Y4+HaHbFGW+hgcXsVtMJpfBytMIZaHxTcpKLpESKQljnQi0XlDHzm PDebZMTAbTPl2i++O4Qn7wpZ5yRlxgCEyNb4ErXyTnAVbPPBfyOLorZY+xvK9RsRanC/ nlGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=BQUMM2Pq; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g13si418178pgk.369.2019.07.17.23.51.46; Wed, 17 Jul 2019 23:51:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=BQUMM2Pq; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726423AbfGRGvp (ORCPT + 5 others); Thu, 18 Jul 2019 02:51:45 -0400 Received: from conuserg-07.nifty.com ([210.131.2.74]:36276 "EHLO conuserg-07.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726397AbfGRGvp (ORCPT ); Thu, 18 Jul 2019 02:51:45 -0400 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-07.nifty.com with ESMTP id x6I6p9ST017611; Thu, 18 Jul 2019 15:51:10 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-07.nifty.com x6I6p9ST017611 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1563432670; bh=ZhDfduBxSN7i25VRGia8YNv8px3x7GeUSF1hPbqj3LU=; h=From:To:Cc:Subject:Date:From; b=BQUMM2PqBjQldXgRks4B2tHXeL+fCcUba6f9gjeYYXVgbhLUkboZ4cPmrsDhO8ziF +oMFxoX3052q3b4eS03q7yLzplHv8JHGBfzg81gUfb40uff4unZXHwApfakjniUph2 uM5HrDTa4OGwkX5NaOxpUYd9e1dwBhh+QHr+V2/Q7fQ2osiYA2Ouj1H5Gr+w0ME9Fc 5gQbyEMJNAiPjrfIOnRo1KSNmlBB7o1d3Af438PZZUt667PYZCde8HDZ2ORvy4ySGa ORNgsvgH6E6rrhgYvG6/k73fnAobar9HMbMxzlXnCkLs2YdUvNpqOyWhSt9WMgt/H4 NRC6oGRR0FZVg== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-gpio@vger.kernel.org, Linus Walleij Cc: Stephen Boyd , Masahiro Yamada , Bartosz Golaszewski , linux-kernel@vger.kernel.org Subject: [PATCH] gpio: refactor gpiochip_allocate_mask() with bitmap_alloc() Date: Thu, 18 Jul 2019 15:51:01 +0900 Message-Id: <20190718065101.26994-1-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Refactor gpiochip_allocate_mask() slightly by using bitmap_alloc(). I used bitmap_free() for the corresponding free parts. Actually, bitmap_free() is a wrapper of kfree(), but I did this for consistency. Signed-off-by: Masahiro Yamada --- drivers/gpio/gpiolib.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.17.1 Reviewed-by: Stephen Boyd diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 3ee99d070608..5ac2daa01a53 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -350,7 +350,7 @@ static unsigned long *gpiochip_allocate_mask(struct gpio_chip *chip) { unsigned long *p; - p = kmalloc_array(BITS_TO_LONGS(chip->ngpio), sizeof(*p), GFP_KERNEL); + p = bitmap_alloc(chip->ngpio, GFP_KERNEL); if (!p) return NULL; @@ -391,7 +391,7 @@ static int gpiochip_init_valid_mask(struct gpio_chip *gpiochip) static void gpiochip_free_valid_mask(struct gpio_chip *gpiochip) { - kfree(gpiochip->valid_mask); + bitmap_free(gpiochip->valid_mask); gpiochip->valid_mask = NULL; } @@ -1626,7 +1626,7 @@ static int gpiochip_irqchip_init_valid_mask(struct gpio_chip *gpiochip) static void gpiochip_irqchip_free_valid_mask(struct gpio_chip *gpiochip) { - kfree(gpiochip->irq.valid_mask); + bitmap_free(gpiochip->irq.valid_mask); gpiochip->irq.valid_mask = NULL; }