From patchwork Tue Sep 5 16:19:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 720224 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25DF7CA1001 for ; Tue, 5 Sep 2023 19:26:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229451AbjIET0B (ORCPT ); Tue, 5 Sep 2023 15:26:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240160AbjIETZ7 (ORCPT ); Tue, 5 Sep 2023 15:25:59 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C2921709 for ; Tue, 5 Sep 2023 12:25:29 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-401f68602a8so27940765e9.3 for ; Tue, 05 Sep 2023 12:25:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693941926; x=1694546726; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ca2eAe6pvMNyR6imFqpBniy7ICyAfe/hANZLQ25/e0Y=; b=efCeBcOqegql7z2PqQvmjHrcUU8YZG/WRM5DTNRPApkjut8woq3Vyo7YG/xhfUDe4B iUvYoY4m9ewdhd9ayUzLnLEeerCXmSCHw2Ri9rYUJUXC6a/fMoxvhZfJg+OOpbq9sYJ5 1HnAhwwHnAtRe3DrLQ506YOhu34FzcJZdUPmKRjmT43Hm5tOEQYCreyJRk0UKFyduiFF ourOam+orCgn6uoroOjU6//X+IlbCLVowhZqCs07zoK7bfRbjkwsCWlY3P2hssP8t32U nKf8CUvRI2Kd6b/rfFEjoUcTHPUYgVOmLZeQGH1+Nctpwc2xbyCu7YosXj7UEn81V6Hc PBKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693941926; x=1694546726; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ca2eAe6pvMNyR6imFqpBniy7ICyAfe/hANZLQ25/e0Y=; b=QtWZLhbHlRgz8pfz/U1swH6/G4IypgnnWhPCDc32pEnSLy+Czcik/ZXvLYo8wjZWXu vVYPaq6LzQYBdKC83RYiqjXcZ71KlSpPx8CAjwI3yDgqDmaxqqguYJ/CjIjasW1rjOGH JOH2HSV4mJ6wkqrfE7dTZWbQL17mHBJ+DCbNnL8YXKh8gNVF2PCRK8yNp2KEcR1+suqv OONu/aoQlTdVt83gP7xd9ooHYnYWSB95BRPiTQ/CuOSsnTOvcTDRX2KINdgJhXVhsMkT N6UST0ssKCoKAPQgKB0fRt4ZIyl6e3odYElm64bZMWMNE2RJ4FcHMopVoQiJEHZLw596 gyTg== X-Gm-Message-State: AOJu0YwM2s+M28oocvnIHnBuDwjmCFRqEHH3lWDj0J2iefnP06Zjqaxr qx8uXVTk0fjaBInkMD9VU3Kxp4PZ8Pe7hqXdIZo= X-Google-Smtp-Source: AGHT+IG+oCDVe1qnz0Eh4bx1Aac6LkewwnuG8hvHtmfCrkF0hc+vfTNz3AZGaXnbaYCTFMaA43jutg== X-Received: by 2002:a17:906:304a:b0:9a2:139:f45d with SMTP id d10-20020a170906304a00b009a20139f45dmr267866ejd.43.1693930768881; Tue, 05 Sep 2023 09:19:28 -0700 (PDT) Received: from krzk-bin.. (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id v26-20020a170906489a00b0099cc36c4681sm7743165ejq.157.2023.09.05.09.19.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 09:19:28 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 01/12] arm64: dts: qcom: sm6125-sprout: drop incorrect UFS phy max current Date: Tue, 5 Sep 2023 18:19:09 +0200 Message-Id: <20230905161920.252013-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230905161920.252013-1-krzysztof.kozlowski@linaro.org> References: <20230905161920.252013-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Neither bindings nor UFS phy driver use properties like 'vdda-phy-max-microamp' and 'vdda-pll-max-microamp': sm6125-xiaomi-laurel-sprout.dtb: phy@4807000: 'vdda-phy-max-microamp', 'vdda-pll-max-microamp' do not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts index 272bc85f1719..90b5f22ea9dc 100644 --- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts @@ -406,8 +406,6 @@ &ufs_mem_hc { &ufs_mem_phy { vdda-phy-supply = <&vreg_l4a>; vdda-pll-supply = <&vreg_l10a>; - vdda-phy-max-microamp = <51400>; - vdda-pll-max-microamp = <14200>; vddp-ref-clk-supply = <&vreg_l18a>; status = "okay"; }; From patchwork Tue Sep 5 16:19:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 720226 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AA92CA0FF7 for ; Tue, 5 Sep 2023 18:41:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235467AbjIESlt (ORCPT ); Tue, 5 Sep 2023 14:41:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231915AbjIESls (ORCPT ); Tue, 5 Sep 2023 14:41:48 -0400 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B494E74 for ; Tue, 5 Sep 2023 11:41:12 -0700 (PDT) Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-402c46c49f4so28082155e9.1 for ; Tue, 05 Sep 2023 11:41:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693939147; x=1694543947; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1I6IwceD9yMG95Xy3C5UFcBdFWUjpLzegH+tNAfDOaI=; b=nhznZt6OuS3mFsoCJ1UFwxI8AutQ9Lr0qmCl7snV/Fn5ix/wCT/hF2YFULYv5mm1Yb REcDNRjZJtr+883/rAfaCLn9LnOYtZksQf1OL0VlAQxL10owIylNROWW4mFPoyngVLX/ dnuOnQzBtWs3PJwrO6F2suDTFWT0J4lm6o0enqU8u0TiFyZBhAZ8JVUseasolU16hlOt G57opiRe+4+rWxU5+P1F9PokBNKyTiHQjf78OgAlHZAzTcB5Z3X2BqqdbP4TcwY5MNHA MSXkGMoRDoyH7F3Hln95giv9IWRI9D+haHPt2nM4Ej67FCxob+35Re4BCrf9TMGzMG/j h/iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693939147; x=1694543947; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1I6IwceD9yMG95Xy3C5UFcBdFWUjpLzegH+tNAfDOaI=; b=J1n1IsVZm6NIYsCR5sNG1W6e/zI3LwIiesgkEY6s1kNEa0iOL2G2zNME6R8FXyy4bg s6PA1DQV9ZuHL7bnDSdZ3Z5VlMdHPNvN+XPZkuub+yj/KrCF3cZGQDX0ocA+6rKXAQtl YUfuTNHDFZIzZf6aIUzIKrWYk3HnpRdyO5m1qehd444UsUlpXStc10wd2hTJU3+iGJv/ CQHHHU4WNDWo+wBpK77iv4266PJ7+ec3QAE731m54L0KujdLcsi/4BWE4ijz7WQ+gRfL Hh+bu6ULF6Vasq4xouGemipWIywmP9BZFzvQNhJJn87T5V3bTWW/nRum8Q7FYUFVjRVe DLwA== X-Gm-Message-State: AOJu0YywhSXANjoZGLqEPok2n59dS2HQGo21KF1nTIBBxWa17wXHAqoB FB14zdCs4MLt9Tfaq7XnZaamj6OFknVbz2gNe+M= X-Google-Smtp-Source: AGHT+IE652HnpOuqvnVBGDDLrT5wGDbZm60/a3Eibz5HpmZ0r1doLgr270vkCnEhcqO3UeDgCRLTVw== X-Received: by 2002:a17:906:1db2:b0:9a6:4fe0:4552 with SMTP id u18-20020a1709061db200b009a64fe04552mr203290ejh.46.1693930770138; Tue, 05 Sep 2023 09:19:30 -0700 (PDT) Received: from krzk-bin.. (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id v26-20020a170906489a00b0099cc36c4681sm7743165ejq.157.2023.09.05.09.19.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 09:19:29 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 02/12] arm64: dts: qcom: sm6125-sprout: correct UFS pad supply Date: Tue, 5 Sep 2023 18:19:10 +0200 Message-Id: <20230905161920.252013-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230905161920.252013-1-krzysztof.kozlowski@linaro.org> References: <20230905161920.252013-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The Qualcomm UFS phy switched from dedicated driver to QMP phy driver. Eventually the old driver was removed in commit 02dca8c981b5 ("phy: qcom: remove ufs qmp phy driver"). The original driver and its binding used vddp-ref-clk regulator supply, but the new one did not and left the supply unused. The Qualcomm UFS phy bindings were also migrated to newer ones and dropped support for vddp-ref-clk regulator in commit dc5cb63592bd ("dt-bindings: phy: migrate QMP UFS PHY bindings to qcom,sc8280xp-qmp-ufs-phy.yaml"). It turns out that this regulator, although with inaccurate name vddp-ref-clk, is actually needed to provide supply for VDD_PX10 (or similar, depending on the SoC) used by UFS controller. Bring back handling of this supply by using more appropriate regulator - UFS controller host supply. This also fixes dtbs_check warning: sm6125-xiaomi-laurel-sprout.dtb: phy@4807000: 'vddp-ref-clk-supply' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts index 90b5f22ea9dc..a49d3ebb1931 100644 --- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts @@ -400,13 +400,13 @@ &ufs_mem_hc { vccq2-supply = <&vreg_l11a>; vcc-max-microamp = <600000>; vccq2-max-microamp = <600000>; + vdd-hba-supply = <&vreg_l18a>; status = "okay"; }; &ufs_mem_phy { vdda-phy-supply = <&vreg_l4a>; vdda-pll-supply = <&vreg_l10a>; - vddp-ref-clk-supply = <&vreg_l18a>; status = "okay"; }; From patchwork Tue Sep 5 16:19:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 720227 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EAC7CA0FFC for ; Tue, 5 Sep 2023 18:10:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241037AbjIESKZ (ORCPT ); Tue, 5 Sep 2023 14:10:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239893AbjIESKO (ORCPT ); Tue, 5 Sep 2023 14:10:14 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F60A6606D for ; Tue, 5 Sep 2023 10:00:26 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-5007f3d3235so4344709e87.2 for ; Tue, 05 Sep 2023 10:00:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693933145; x=1694537945; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RGaxUhsaWm/cp+r2DPolOLK8u8MC47KqNdL9YaScpsw=; b=BhBnHNUG+KSGUhVgGF63CgsXMGt1xLPlQd4r6yrcMCTO1gGiXmfpzHoDCB3n3dHa6U bRBis+VEFxanRSZDoh3EY9m9z8Rq7q6PeJMoOd0DACJlwqliwQdkQbVUbEyiFa5MQ4fr EMwhUHyHHWLYwmyOqkK74hS6Tonfgf7KdOjm4CEI4rivmfOhd8O+S91N4MHSQRDcnes8 dwxZ3gagUrqCWO3bkVDwjXdbqp0lcv1TWcuCL4pvoiOBO59C/tg0lpy9wrgH2mSCc8ml jhCEZLJd6fpHOtadayPMbad5jEFDEthG26Vl+BjE6vVjRvTN67EB133ip8oaOTrGU8CA 7tKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693933145; x=1694537945; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RGaxUhsaWm/cp+r2DPolOLK8u8MC47KqNdL9YaScpsw=; b=Iqsa0MaKSBCbMoPuM9Eq4KCAWAS742a7E0cxrx/1phR1cdu/uua9pRE02OZYFQZVKe SAqt4+xxgASxe4Vn3Vp0DQkkDQsXZ7mzTJ+M9l+a3wMKhicMfiMfMf0ca0PL5VRiIxwR nPMUW/0VnURGXltZCSwt2QWImEiCfbYxChV33Mqtyr1NKn9pQ9gAfogmUAIK2CCwpi2N kCl6sd7rkoASXv+4x7aEStebooXzkF5Ab8/bSv47KD99MiWy8FAWh4xByAvFRdBrN59W i6ioFUQWUr56ukWkC+v9j7LApqH90EeS3car5sfgNBuOiBMzkJUcUw6JptccsTewyYSP GmzA== X-Gm-Message-State: AOJu0Yw3jp0ufB02rl9Bre03Y+AREWHuTifTggjr0kiscrqYyfyK4N60 3A+c2qOp1UB5jQON9cGUzXCWk+Xl32kPt//f7QQ= X-Google-Smtp-Source: AGHT+IEp1DTEiq7Z2Jiw52W4zhnCePvt/4EW1RpyNiAdy2vPAMIQNgxfwDn0BPDatgDGfl5TO898Pg== X-Received: by 2002:a17:906:20d0:b0:9a5:b8c1:2ce1 with SMTP id c16-20020a17090620d000b009a5b8c12ce1mr242650ejc.31.1693930772320; Tue, 05 Sep 2023 09:19:32 -0700 (PDT) Received: from krzk-bin.. (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id v26-20020a170906489a00b0099cc36c4681sm7743165ejq.157.2023.09.05.09.19.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 09:19:31 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 04/12] arm64: dts: qcom: sm6115p-j606f: correct UFS pad supply Date: Tue, 5 Sep 2023 18:19:12 +0200 Message-Id: <20230905161920.252013-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230905161920.252013-1-krzysztof.kozlowski@linaro.org> References: <20230905161920.252013-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The Qualcomm UFS phy switched from dedicated driver to QMP phy driver. Eventually the old driver was removed in commit 02dca8c981b5 ("phy: qcom: remove ufs qmp phy driver"). The original driver and its binding used vddp-ref-clk regulator supply, but the new one did not and left the supply unused. The Qualcomm UFS phy bindings were also migrated to newer ones and dropped support for vddp-ref-clk regulator in commit dc5cb63592bd ("dt-bindings: phy: migrate QMP UFS PHY bindings to qcom,sc8280xp-qmp-ufs-phy.yaml"). It turns out that this regulator, although with inaccurate name vddp-ref-clk, is actually needed to provide supply for VDD_PX10 (or similar, depending on the SoC) used by UFS controller. Bring back handling of this supply by using more appropriate regulator - UFS controller host supply. This also fixes dtbs_check warning: sm6115p-lenovo-j606f.dtb: phy@4807000: 'vddp-ref-clk-supply' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts index c2d15fc6c96b..54da053a8042 100644 --- a/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts +++ b/arch/arm64/boot/dts/qcom/sm6115p-lenovo-j606f.dts @@ -344,13 +344,13 @@ &ufs_mem_hc { vcc-max-microamp = <600000>; vccq2-supply = <&pm6125_l11>; vccq2-max-microamp = <600000>; + vdd-hba-supply = <&pm6125_l18>; status = "okay"; }; &ufs_mem_phy { vdda-phy-supply = <&pm6125_l4>; vdda-pll-supply = <&pm6125_l12>; - vddp-ref-clk-supply = <&pm6125_l18>; status = "okay"; }; From patchwork Tue Sep 5 16:19:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 720230 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFFE2CA0FE2 for ; Tue, 5 Sep 2023 17:33:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229696AbjIERd6 (ORCPT ); Tue, 5 Sep 2023 13:33:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231474AbjIERda (ORCPT ); Tue, 5 Sep 2023 13:33:30 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D991029812 for ; Tue, 5 Sep 2023 09:59:33 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-31ae6bf91a9so2239103f8f.2 for ; Tue, 05 Sep 2023 09:59:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693933108; x=1694537908; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VSrCRSGbYpW5ai6iRwGDzaSKxkP5+0TJhgHCmN0LPbE=; b=ZJfdvrg73vgwPW1vCIFEaVfwjYQkmnqiZDxy296wZGjQJxkHFWI8F7cAGiJJ+GSHcW QwqgAcd8u1Ol52RqcYF1ORtV+DBUsSgeRO1+6yHrDPfyiRNZbRTuqw8DNK1lpEDAbCLH U2JJ4HAmMOEzj8Q1y7w2QFslJCW6O/aXAntq+g4KyggwBDPrOFE38afL7aj3aAqj+4LW 3Mxa1LJKMSDjcS/p7Jg9EJJYmThiH2sD14McyMCFBU4uJggMzNL7+m5PU5p+QMQ4fNbK 3mym2/pwsjxCjTpMXRn7vKGHHAf0Dg2B5ZIqdzCH1NdgS3PwCoqJWa0dTpQAkzFWi49N tJ2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693933108; x=1694537908; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VSrCRSGbYpW5ai6iRwGDzaSKxkP5+0TJhgHCmN0LPbE=; b=AcWwcRzVc7Q/yeB51zNLbM+OhBGzECJir0EkglhWRm4lS5uWGwM9FQWJOqHNXASGK2 PiWwxOv0jV3wFjmq+RW9Ofu17yTWwIwv4wGm7yF6EFBUiEHR220cW9/i8dsVco/Khda8 lZ+R3tevBJX/xXlXYKDht31buICHqySSfLJxbLKGcUtbtsAR0Jf27IBSCPSzDNfGeZ7j kDMysp52eZ6rRoNseew1pLklICfsBbpN3PWA5Brj6c0wCFNKyg9xjjlvRpmkVJM14tCp yoiscNZhbds3iFEAm5sPOgdSPlEAp2E82RsG5F5fiMd5m6C2DkMlSfoJO7MO1dsYA9BS NJNw== X-Gm-Message-State: AOJu0YxIMX2z6SGLEQLO2/ZbnrnfszIuQNI5DLc0jd7HP1uOkuNJ201U iM1JiS4gLrNklXoaTFtQiLD5NbJDUP8TukjYqTg= X-Google-Smtp-Source: AGHT+IEvHvDkL/lwj2z18NbyDp5Lnix22wGCXyb6dsIf/iVENXsMx/XhwkxQAS0wyyCd41yNwAxfYg== X-Received: by 2002:a17:907:7811:b0:9a1:aa7b:482e with SMTP id la17-20020a170907781100b009a1aa7b482emr259657ejc.26.1693930773471; Tue, 05 Sep 2023 09:19:33 -0700 (PDT) Received: from krzk-bin.. (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id v26-20020a170906489a00b0099cc36c4681sm7743165ejq.157.2023.09.05.09.19.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 09:19:33 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 05/12] arm64: dts: qcom: apq8096-db820c: correct UFS pad supply Date: Tue, 5 Sep 2023 18:19:13 +0200 Message-Id: <20230905161920.252013-6-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230905161920.252013-1-krzysztof.kozlowski@linaro.org> References: <20230905161920.252013-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The Qualcomm UFS phy switched from dedicated driver to QMP phy driver. Eventually the old driver was removed in commit 02dca8c981b5 ("phy: qcom: remove ufs qmp phy driver"). The original driver and its binding used vddp-ref-clk regulator supply, but the new one did not and left the supply unused. The Qualcomm UFS phy bindings were also migrated to newer ones and dropped support for vddp-ref-clk regulator in commit dc5cb63592bd ("dt-bindings: phy: migrate QMP UFS PHY bindings to qcom,sc8280xp-qmp-ufs-phy.yaml"). It turns out that this regulator, although with inaccurate name vddp-ref-clk, is actually needed to provide supply for VDD_PX10 (or similar, depending on the SoC) used by UFS controller. Bring back handling of this supply by using more appropriate regulator - UFS controller host supply. This also fixes dtbs_check warning: apq8096-db820c.dtb: phy@627000: 'vddp-ref-clk-supply' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts index 385b178314db..d2aaff3e0d02 100644 --- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts @@ -1091,7 +1091,6 @@ &ufsphy { vdda-phy-supply = <&vreg_l28a_0p925>; vdda-pll-supply = <&vreg_l12a_1p8>; - vddp-ref-clk-supply = <&vreg_l25a_1p2>; }; &ufshc { @@ -1100,6 +1099,7 @@ &ufshc { vcc-supply = <&vreg_l20a_2p95>; vccq-supply = <&vreg_l25a_1p2>; vccq2-supply = <&vreg_s4a_1p8>; + vdd-hba-supply = <&vreg_l25a_1p2>; vcc-max-microamp = <600000>; vccq-max-microamp = <450000>; From patchwork Tue Sep 5 16:19:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 720225 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D73F1CA0FF7 for ; Tue, 5 Sep 2023 18:51:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239198AbjIESv7 (ORCPT ); Tue, 5 Sep 2023 14:51:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238521AbjIESvy (ORCPT ); Tue, 5 Sep 2023 14:51:54 -0400 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A30DAB for ; Tue, 5 Sep 2023 11:51:28 -0700 (PDT) Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-31de47996c8so2513555f8f.2 for ; Tue, 05 Sep 2023 11:51:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693939522; x=1694544322; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mMNkXS33DtIakBT8aVq/Dj6pUL81sh6O1LziCE6q1vo=; b=z3bFyz3fdfxl7xEeUo4GlI8k1yr1slNUYxbh0Fa+lI/DZaue/nprus3LDy+KtbkQty qFA9eKAZeFT9NuL52qQlNNyEpUPssvlfKFFiqLGrt9StkqZbZrIkH+a1Prf6V2gmGPzs prgkGqKQqjbUcw/6j9AFXhTz8uGh01xyHiBLAgkpiAcHa+ZMZczzkKtBgxBZMH46CQFr XjeMjMM6080fph31EQtOGZcHNJ1vN62HnFNCSwpMtbXd/Zi16Dg2lg3F3Jwb5WYfV5wD y31qE+LDkPKyypcqVjhBgEIZJppwFsLF7yZQva05wrFjr5+trQpl+SQ+VAAdYnbFoFMT aaIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693939522; x=1694544322; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mMNkXS33DtIakBT8aVq/Dj6pUL81sh6O1LziCE6q1vo=; b=eKtRm/xpg3PEn+3PfUmp5HYyJxbHJX43mngmRSwDCigMmGE9X03h7Lr2S7YtlKKjDL QmH6wqSw2WNF/xpOvZfKuuqrYOj+8Hfxhc+/tFCzMKZi5m+E6sKpuifOexmiOaeEq/3y bcba1LaonPQe8t5dUfBXmyMxAYoaYqWIxY7Y84FaSBZg046OdBIkPo8UBrRNCUcZh0yK IBvuoHCUkIeYk0e8uY5W8NvwYENLAIRchn2h47u+2REWgS4CGw7/tXKz23cSjvcATaV1 XgJHP8142kIvPIQj3w0vzx4zUSC32TvNzvNpNIc5GCdA0jG5CidFep+9DqxbRDuR6nBr /QJw== X-Gm-Message-State: AOJu0YzWBIhgTs01hKcIBGS+I2eVcETNFs7QZhE5r3bm1JpydWmlgtBT QcUugSsi3NJNI0qBZF8rXWjBfs4fL6l8ENZxOU8= X-Google-Smtp-Source: AGHT+IGmyLK/Hbbm+7HnS3z13fq4dV4e1JrpqkFp8l1qPK6NmNZOQkho31QqBdTtFI3mKQSlm7zjcw== X-Received: by 2002:a19:2d55:0:b0:500:94c5:6e06 with SMTP id t21-20020a192d55000000b0050094c56e06mr191521lft.56.1693930774506; Tue, 05 Sep 2023 09:19:34 -0700 (PDT) Received: from krzk-bin.. (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id v26-20020a170906489a00b0099cc36c4681sm7743165ejq.157.2023.09.05.09.19.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 09:19:34 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 06/12] arm64: dts: qcom: msm8996-oneplus: correct UFS pad supply Date: Tue, 5 Sep 2023 18:19:14 +0200 Message-Id: <20230905161920.252013-7-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230905161920.252013-1-krzysztof.kozlowski@linaro.org> References: <20230905161920.252013-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The Qualcomm UFS phy switched from dedicated driver to QMP phy driver. Eventually the old driver was removed in commit 02dca8c981b5 ("phy: qcom: remove ufs qmp phy driver"). The original driver and its binding used vddp-ref-clk regulator supply, but the new one did not and left the supply unused. The Qualcomm UFS phy bindings were also migrated to newer ones and dropped support for vddp-ref-clk regulator in commit dc5cb63592bd ("dt-bindings: phy: migrate QMP UFS PHY bindings to qcom,sc8280xp-qmp-ufs-phy.yaml"). It turns out that this regulator, although with inaccurate name vddp-ref-clk, is actually needed to provide supply for VDD_PX10 (or similar, depending on the SoC) used by UFS controller. Bring back handling of this supply by using more appropriate regulator - UFS controller host supply. This also fixes dtbs_check warning: msm8996-oneplus3t.dtb: phy@627000: 'vddp-ref-clk-supply' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi index ec5457508fe6..38035e0db80b 100644 --- a/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996-oneplus-common.dtsi @@ -772,7 +772,6 @@ touch_suspend: touch-suspend-state { &ufsphy { vdda-phy-supply = <&vreg_l28a_0p925>; vdda-pll-supply = <&vreg_l12a_1p8>; - vddp-ref-clk-supply = <&vreg_l25a_1p2>; status = "okay"; }; @@ -781,6 +780,7 @@ &ufshc { vcc-supply = <&vreg_l20a_2p95>; vccq-supply = <&vreg_l25a_1p2>; vccq2-supply = <&vreg_s4a_1p8>; + vdd-hba-supply = <&vreg_l25a_1p2>; vcc-max-microamp = <600000>; vccq-max-microamp = <450000>; From patchwork Tue Sep 5 16:19:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 720232 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9245C83F2C for ; Tue, 5 Sep 2023 16:45:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237334AbjIEQpx (ORCPT ); Tue, 5 Sep 2023 12:45:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238846AbjIEQgf (ORCPT ); Tue, 5 Sep 2023 12:36:35 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E12C2469F for ; Tue, 5 Sep 2023 09:34:01 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2bd3f629c76so45198531fa.0 for ; Tue, 05 Sep 2023 09:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693931552; x=1694536352; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=trFwEkPHlkfNhWfOX9Zlwo/iFiG9jTiXGcKaA8Pa3TY=; b=J/iTRYNOTWYYM+cTNz9h70R0401ZtA2bSZh24WQY2zhIfo+1Qq330hAJ1ZIMLUsK1t NdEOFdnF1z0I1TFtJvncoUbxyb3swVuVnsWt+Zt+PrhN9RuAAPWZ69Shc/Sdsw5qMR3b o0zLfZDBvrrgO6P8NBuzm9IH12JR+zSX84xMf6UyrITeUTN1IW8LY/k4IOC1DP9LiCcF fL9yCQItl/yXE3FacCTVffdyrLMauq+K+0GBX1w2bS98U/YY5EWh/vmNeu/ejZOkvoor 62WTJoMiRcW5ksU084l9uwTUOO6wVMGJNHQSJ0DgapA/Pi6HHPMcyex89EcEXZyzCl2S X7hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693931552; x=1694536352; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=trFwEkPHlkfNhWfOX9Zlwo/iFiG9jTiXGcKaA8Pa3TY=; b=FGVRHlj6+n2opabTNJSJ0TxP1mevksF9+dljWk0jhsixUBNhgoKjbuJqkbGLK4TUs0 N1+BsxxKKSS4Vd4NOiM1EgOD2NOnw6se6hATUTbyre3ZgHeCxDmVcWuIJCUOypLIbyJ9 NpN+OQY3jqISfDlLpPLtRkxsFqVycx8uN5QT799v0wI+x94kbZlpx/a4aeXRI/qb/bQU ztPWj//CCBLUL2BJ0mMoaaxdpzFc/DOh7xU3RlsdVafymCVQONcHp1nqBZHuBA7oBrla uEIU1WtlRitWWTnDJVziEagQwAk/Df6aw/EicxIf1l6aw4OIy5PPfST67B5XcY7KMNuz oQBA== X-Gm-Message-State: AOJu0Yz7Tk4ZbkA8x1JIK2/s7B+qorc6sIbFRSpMlnZ+Qr/JI2KQQ+oJ cc8emVsteTUC1RT+vwTzYtqf4HMYN0EL48kbMj4= X-Google-Smtp-Source: AGHT+IEmQSd2edyvfFattJQO+ByTRQHwtfpRZPVH9fJSPo0gW/FR1OCbHCt1pdWtw63JsCDL0UuBEA== X-Received: by 2002:a17:907:789a:b0:9a5:b874:93d5 with SMTP id ku26-20020a170907789a00b009a5b87493d5mr254649ejc.76.1693930779404; Tue, 05 Sep 2023 09:19:39 -0700 (PDT) Received: from krzk-bin.. (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id v26-20020a170906489a00b0099cc36c4681sm7743165ejq.157.2023.09.05.09.19.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 09:19:39 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 10/12] arm64: dts: qcom: msm8998-oneplus: correct UFS pad supply Date: Tue, 5 Sep 2023 18:19:18 +0200 Message-Id: <20230905161920.252013-11-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230905161920.252013-1-krzysztof.kozlowski@linaro.org> References: <20230905161920.252013-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The Qualcomm UFS phy switched from dedicated driver to QMP phy driver. Eventually the old driver was removed in commit 02dca8c981b5 ("phy: qcom: remove ufs qmp phy driver"). The original driver and its binding used vddp-ref-clk regulator supply, but the new one did not and left the supply unused. The Qualcomm UFS phy bindings were also migrated to newer ones and dropped support for vddp-ref-clk regulator in commit dc5cb63592bd ("dt-bindings: phy: migrate QMP UFS PHY bindings to qcom,sc8280xp-qmp-ufs-phy.yaml"). It turns out that this regulator, although with inaccurate name vddp-ref-clk, is actually needed to provide supply for VDD_PX10 (or similar, depending on the SoC) used by UFS controller. Bring back handling of this supply by using more appropriate regulator - UFS controller host supply. This also fixes dtbs_check warning: msm8998-oneplus-dumpling.dtb: phy@1da7000: 'vddp-ref-clk-supply' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi index 68e634f8212c..e6a69d942a4a 100644 --- a/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi @@ -534,6 +534,7 @@ &ufshc { vcc-supply = <&vreg_l20a_2p95>; vccq-supply = <&vreg_l26a_1p2>; vccq2-supply = <&vreg_s4a_1p8>; + vdd-hba-supply = <&vreg_l26a_1p2>; vcc-max-microamp = <750000>; vccq-max-microamp = <560000>; vccq2-max-microamp = <750000>; @@ -544,7 +545,6 @@ &ufsphy { vdda-phy-supply = <&vreg_l1a_0p875>; vdda-pll-supply = <&vreg_l2a_1p2>; - vddp-ref-clk-supply = <&vreg_l26a_1p2>; }; &usb3 { From patchwork Tue Sep 5 16:19:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 720231 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6EE4C83F3E for ; Tue, 5 Sep 2023 17:00:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241953AbjIERAD (ORCPT ); Tue, 5 Sep 2023 13:00:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235708AbjIEQ54 (ORCPT ); Tue, 5 Sep 2023 12:57:56 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92B6E3ABE for ; Tue, 5 Sep 2023 09:21:02 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-9936b3d0286so420585266b.0 for ; Tue, 05 Sep 2023 09:21:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693930780; x=1694535580; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wa8S3640iWUkpmAXcApvED+QJgBuG0siUdi8y84+QOg=; b=zSThOYB2hTL/eUV+RF9pTbmJp1ssw6irK2KPJGGWRO/cqFE+h0AH8yrWH+ewbPB1LL wLLfZrGVX9iKlcXhLM/2Hy/gvAk83Cdy3zpfdWJjnvx/VcsTuEdylG5Nl1GKtVjuygLr q4kHebnzhg2Ti+h4M9dBYQMAF7IFcmGnFctITo7v3ECLtzvIPGt1NkHJvMHK1JaFpTps wzW8DXUmo0iCJyB9wt3pK0Xykfbau2SRaIpbB7ivGq/fA1VhgAR50dN4dKEq14TIchrK C5PZMVJc3NFLwOxga36CSZ32mJGUFJOA0FQpTJs27D+HpEq+lxarMwbgWQW573g4c4CS n18w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693930780; x=1694535580; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wa8S3640iWUkpmAXcApvED+QJgBuG0siUdi8y84+QOg=; b=JGtaPye6cMBRKt+DKRRiS48fq3s7efW79A84XuH9gkF791tXAQr/3omW0Kft3BBMHA XAOHmEbLqjJ7Lb/cxbso58o72YBB0bG+qp54mt/ubyUtrXzpICD/ArDhsSuQQ8cmdkp4 o21q72/RFWeBkeaRXpeeNYP1nnV/saybZrbottpx3y1LJu5/NkhXwwWXlUAVJcL9VzyH /JtuRJYn1BdVu7v8IyLjynvRs8DjHQTUfCXTVe0fbQmbf0yWqV5hGSDv7SxyuYRSeeyv TfFzFuZuuku66pl2j2/yiJbV1/pGDeLKpXnUUKdsxpKApZLo7Ks5kmjHp5OFMzzSyGE4 c8yQ== X-Gm-Message-State: AOJu0YzRUyuiBy7nSSCPBBnZYanGHQg+uE56XRdXnWpI7k3iFOaAYxnC lyC9MlvlL0IQCfED1u3vRyi4rA== X-Google-Smtp-Source: AGHT+IESfv2tKGY9sWI6xhuBrGlNmksCn2wXFYAMdyLFWK3lMFwDIQDIPWPCxfg7uX/4mXrqjrYqBA== X-Received: by 2002:a17:906:18aa:b0:9a1:d087:e0bf with SMTP id c10-20020a17090618aa00b009a1d087e0bfmr237260ejf.43.1693930780565; Tue, 05 Sep 2023 09:19:40 -0700 (PDT) Received: from krzk-bin.. (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id v26-20020a170906489a00b0099cc36c4681sm7743165ejq.157.2023.09.05.09.19.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 09:19:40 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 11/12] arm64: dts: qcom: msm8998-sagit: correct UFS pad supply Date: Tue, 5 Sep 2023 18:19:19 +0200 Message-Id: <20230905161920.252013-12-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230905161920.252013-1-krzysztof.kozlowski@linaro.org> References: <20230905161920.252013-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The Qualcomm UFS phy switched from dedicated driver to QMP phy driver. Eventually the old driver was removed in commit 02dca8c981b5 ("phy: qcom: remove ufs qmp phy driver"). The original driver and its binding used vddp-ref-clk regulator supply, but the new one did not and left the supply unused. The Qualcomm UFS phy bindings were also migrated to newer ones and dropped support for vddp-ref-clk regulator in commit dc5cb63592bd ("dt-bindings: phy: migrate QMP UFS PHY bindings to qcom,sc8280xp-qmp-ufs-phy.yaml"). It turns out that this regulator, although with inaccurate name vddp-ref-clk, is actually needed to provide supply for VDD_PX10 (or similar, depending on the SoC) used by UFS controller. Bring back handling of this supply by using more appropriate regulator - UFS controller host supply. This also fixes dtbs_check warning: msm8998-xiaomi-sagit.dtb: phy@1da7000: 'vddp-ref-clk-supply' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts b/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts index 437b30cc8bdc..0cac06f25a77 100644 --- a/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts +++ b/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts @@ -667,6 +667,7 @@ &ufshc { vcc-supply = <&vreg_l20a_2p95>; vccq-supply = <&vreg_l26a_1p2>; vccq2-supply = <&vreg_s4a_1p8>; + vdd-hba-supply = <&vreg_l26a_1p2>; vcc-max-microamp = <750000>; vccq-max-microamp = <560000>; vccq2-max-microamp = <750000>; @@ -676,7 +677,6 @@ &ufshc { &ufsphy { vdda-phy-supply = <&vreg_l1a_0p875>; vdda-pll-supply = <&vreg_l2a_1p2>; - vddp-ref-clk-supply = <&vreg_l26a_1p2>; status = "okay"; }; From patchwork Tue Sep 5 16:19:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 720228 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A05A4CA0FFA for ; Tue, 5 Sep 2023 17:57:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237035AbjIER5k (ORCPT ); Tue, 5 Sep 2023 13:57:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238431AbjIER5U (ORCPT ); Tue, 5 Sep 2023 13:57:20 -0400 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C92EE6580 for ; Tue, 5 Sep 2023 10:52:20 -0700 (PDT) Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-99c3c8adb27so424129066b.1 for ; Tue, 05 Sep 2023 10:52:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693935946; x=1694540746; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eDCWmN0mPD6hCatLBKjMrDlxIVWIUgJK7MJJd+ho5Vc=; b=yO8nmYxcbU+TYoE7RhGDEeDPLmMBEaz5LCtiYScL/t/ojpt/SqnCt8LVMG86UyTAJw YSgO0e6Qb13JKrMRt0FK3/OMTh5XOo3tCxvfINDq6KJJRh0PU50dnSgLcRrFosAJpn16 xo6scRFXhXSE6d6TlMfqfGF38dgzFqUYW+2xbomqRYAezEUEjxy7bU2dQCgPTPmoZrDo /0CLG8rrhGRfGnX72vEReUu2yBuDiw2IrNfrysJfclNysmuTAuAXTTdWRcAHZjv+46CC sIX21VJXUtTNWgmDFDFY3l1Np6bUu223UYb35JsTAA9fM1fTKmO9l702mWnt91p1FYz/ i2pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693935946; x=1694540746; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eDCWmN0mPD6hCatLBKjMrDlxIVWIUgJK7MJJd+ho5Vc=; b=UEW3zw6pnGy94tgaAp7t9H2nu2whrZP64DX9zwgoLjDXjzd/uZqYOI3u6Wxofz8bDT SpOWpNAlYuy2vJ7cnacAr1+D5QMnPpPVQqCS63FZ2syEkbSG2XWVblDZlnK3ujkurQ7j ziMtHGsEQ+f/J14o4B7/TszxLErTXCztzP8B9dekBAfEp+4a9oQjKyBVDmIe8cILc4QT zx75lXRWcBOZj0IziIIB5PCHMelm2jbI0rP7XPksO1Q/rH/ob8aMm/f40NPQquJzNjOU 9FB8JIh9JcaFUomi1KPnpktN+MoeoMXy81DvpgqcxCu6U6JKqvdzPrTdKQrM+0vxylNa oBtg== X-Gm-Message-State: AOJu0YyM/9kQ531hc7l7yi7eW8jIOZ+txA8QVoBrOjOHJ0uATSxbZEyB QJ3W9tgl7+8tgL9R7Fb65inlAS9azhODSAJAfN8= X-Google-Smtp-Source: AGHT+IHP6OBBOhp2XqNXHnK7pnzjbPCbx0swl8k5IRAOAeEg9BeQC0c2Z0DhbmOKSgrSC4rz+j6yMQ== X-Received: by 2002:a17:907:2cd8:b0:9a2:2635:dab6 with SMTP id hg24-20020a1709072cd800b009a22635dab6mr235384ejc.47.1693930781780; Tue, 05 Sep 2023 09:19:41 -0700 (PDT) Received: from krzk-bin.. (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id v26-20020a170906489a00b0099cc36c4681sm7743165ejq.157.2023.09.05.09.19.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 09:19:41 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 12/12] arm64: dts: qcom: sm4250-billie2: correct UFS pad supply Date: Tue, 5 Sep 2023 18:19:20 +0200 Message-Id: <20230905161920.252013-13-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230905161920.252013-1-krzysztof.kozlowski@linaro.org> References: <20230905161920.252013-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The Qualcomm UFS phy switched from dedicated driver to QMP phy driver. Eventually the old driver was removed in commit 02dca8c981b5 ("phy: qcom: remove ufs qmp phy driver"). The original driver and its binding used vddp-ref-clk regulator supply, but the new one did not and left the supply unused. The Qualcomm UFS phy bindings were also migrated to newer ones and dropped support for vddp-ref-clk regulator in commit dc5cb63592bd ("dt-bindings: phy: migrate QMP UFS PHY bindings to qcom,sc8280xp-qmp-ufs-phy.yaml"). It turns out that this regulator, although with inaccurate name vddp-ref-clk, is actually needed to provide supply for VDD_PX10 (or similar, depending on the SoC) used by UFS controller. Bring back handling of this supply by using more appropriate regulator - UFS controller host supply. This also fixes dtbs_check warning: sm4250-oneplus-billie2.dtb: phy@4807000: 'vddp-ref-clk-supply' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts b/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts index 75951fd439df..2c7a12983dae 100644 --- a/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts +++ b/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts @@ -225,13 +225,13 @@ &ufs_mem_hc { vcc-max-microamp = <600000>; vccq2-supply = <&vreg_l11a>; vccq2-max-microamp = <600000>; + vdd-hba-supply = <&vreg_l18a>; status = "okay"; }; &ufs_mem_phy { vdda-phy-supply = <&vreg_l4a>; vdda-pll-supply = <&vreg_l12a>; - vddp-ref-clk-supply = <&vreg_l18a>; status = "okay"; };