From patchwork Sat Sep 9 14:34:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jernej_=C5=A0krabec?= X-Patchwork-Id: 721936 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A032EEB594 for ; Sat, 9 Sep 2023 16:25:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229840AbjIIQZN (ORCPT ); Sat, 9 Sep 2023 12:25:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346440AbjIIOfJ (ORCPT ); Sat, 9 Sep 2023 10:35:09 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BECC18E; Sat, 9 Sep 2023 07:35:03 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2bcfdadd149so52381981fa.0; Sat, 09 Sep 2023 07:35:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694270101; x=1694874901; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iki1B+UVY8QtKWRaiKUBi6caCXXzC+9RSfzALEjfpWg=; b=Hke38LqH/seqsZ3Nv23kTm/xrlmuNO2TxryXv7YjBftMTcRkZaHXAp0g2viIksTfU1 WrptBmd+44SdFUR1tG0zrweIHlPJ5Ngz1lGtSPArCIvW++o2jCd3N3wRlCBykzsOfyLs YVefjjKzBXlPMDfhEDJihuILWfomXARf4RugvnRv9CxXmvt7v+Gred1UlXICChUBWJ0k /7oi79hCBfHRaEjIs9BHYePPkSaC19Z+MQn0r6f/8fboegw860Ajm95Q8PywDyF4vQHA a8wpZzF+o754gdZCgqBx1/Nlm2i2YFlT1ccpQqlhG5P/7DFX3kGmc4dix2bptACYXVq2 vGeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694270101; x=1694874901; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iki1B+UVY8QtKWRaiKUBi6caCXXzC+9RSfzALEjfpWg=; b=nmpXkrtszslRqE7FN4mZaIs9IobtKw0dvdEE3OKKspXRL+PZWdvESDae/IZ60+BzhZ 8pqGJwCdIs+vzDNWN5zjL9lK3Uj5c/UlRPabLSw9RX7AVLjfQj0BXGHiU8bAUyX/Ha48 r/d13aJ9muzs3l8DOENu7/KXfssm+Kp9LGdgbM9PYJ+79nVsLDa0EiWlRfuDjmlZVgIv e8KsuLzLwQ2kpYG6QboHf7oa5YvRstnCuWyKB/2rVq4ChrMb1tNsb0wWf3n0Q1fKUIj/ bNgx7SBivpWd/1vxa7S8ejes4QBY6JarRrpQ2PQcdEYIZi46xD5fhDJDd7IRSter4xWP w3lQ== X-Gm-Message-State: AOJu0YxctMJ5SC5HX56+GHiQBkbmJJDudKtzHvKfnUqQ7FTW25luNR2H nK62VVdp5bDSmyYkCDKqM30= X-Google-Smtp-Source: AGHT+IHxPBbjRmcU9UUxIkNPf7aH/Onjp+K36K4TO618MMh3FEVtGgL/hVdmq16BuXaoCrtvWQiIvQ== X-Received: by 2002:a2e:a168:0:b0:2bd:19c5:3950 with SMTP id u8-20020a2ea168000000b002bd19c53950mr4189535ljl.33.1694270101202; Sat, 09 Sep 2023 07:35:01 -0700 (PDT) Received: from localhost.localdomain (82-149-12-148.dynamic.telemach.net. [82.149.12.148]) by smtp.gmail.com with ESMTPSA id n3-20020a17090695c300b0099bc8bd9066sm2433945ejy.150.2023.09.09.07.35.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Sep 2023 07:35:00 -0700 (PDT) From: Jernej Skrabec To: linus.walleij@linaro.org Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Jernej Skrabec Subject: [PATCH v2 1/2] pinctrl: pinmux: Remove duplicate error message in pin_request() Date: Sat, 9 Sep 2023 16:34:56 +0200 Message-ID: <20230909143457.9149-2-jernej.skrabec@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230909143457.9149-1-jernej.skrabec@gmail.com> References: <20230909143457.9149-1-jernej.skrabec@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Detailed error message is already printed at the end of the function, so drop redundant one a few lines earlier. Signed-off-by: Jernej Skrabec --- drivers/pinctrl/pinmux.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c index 2a180a5d64a4..301fe0157b02 100644 --- a/drivers/pinctrl/pinmux.c +++ b/drivers/pinctrl/pinmux.c @@ -173,10 +173,8 @@ static int pin_request(struct pinctrl_dev *pctldev, else status = 0; - if (status) { - dev_err(pctldev->dev, "request() failed for pin %d\n", pin); + if (status) module_put(pctldev->owner); - } out_free_pin: if (status) { From patchwork Sat Sep 9 14:34:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jernej_=C5=A0krabec?= X-Patchwork-Id: 721181 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E178EEEB597 for ; Sat, 9 Sep 2023 16:25:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230166AbjIIQZN (ORCPT ); Sat, 9 Sep 2023 12:25:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346441AbjIIOfL (ORCPT ); Sat, 9 Sep 2023 10:35:11 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 804CF18F; Sat, 9 Sep 2023 07:35:03 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-99bcfe28909so363964466b.3; Sat, 09 Sep 2023 07:35:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694270102; x=1694874902; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wy2Lb/rUwudSvnIiRGCw4FsxCiBdrK+e4ZEqb1+9uQ8=; b=skLSs9MB9e2ADKRFJLoY5nOAGsLsMCEC4zIEd9KcomfxGvp1XWoqouxJqUnX0olxN7 na/LL3MtUF4R1GiMJbGv0+WOMtzJwP+WUIrP7EFD/EHKBxA/WuNA/CbMFX+Ggv9374aO 4pkxtCF+rCS4ZiwUtM4F7nddh23pz6TgLha0rXnYE6fa5Be8xS+w6ZQonEDXDTjBjgO4 p6+qBV+cYLDo9VvTZ63JbsM4SdTTUWzyPCLLMbKKOWIPZlLhl1DTWu0cszF8rOOcGXCu /5zgSABqqkjv3JcGFnKF8ti1GCTV4Yf3Btl2c0xeVqhmEce7qmXmdal0mrkFjOuppGGM wncQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694270102; x=1694874902; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wy2Lb/rUwudSvnIiRGCw4FsxCiBdrK+e4ZEqb1+9uQ8=; b=vSukfpCpaLNtZccsF0bRPCA25hjHrOYIX8soQKODVnpR9qNmjBc0OJGLjSgD2YYNVN NqnpWxOFuMRnoZoWFSiEc2wfv/acPPPr3b07ixBZGh8zIMGkQtU1ULnotX+ghHUxzzSE kvJ5aIdR29ZmTTYBEjzMgEfre3+MH1jK2uv/UJoRLwy3EioOnv7A2UbvCtkWxyaHIthD Ef9pNz2yC4Jfhgn5mPZHDji8HJWh18aNexkioOENd4zIgRrfIGPPq9t8ScXbnc9i2vSF t93u3MLgmiXBI94FNyPOqWQLIuwZRjqMsKOga6Q+NzADU1FFXWP32ZIV8Nz1PT0BM0nj dseA== X-Gm-Message-State: AOJu0YyxG9+kMqF326H0gI99ivJmZaLgxnldmrR44doTdeWFg4NZeSI2 etvZGzbcb8GoQzp/JjFLPEY= X-Google-Smtp-Source: AGHT+IFH86sAgB8w+MEEk41VvHbNk14lx+2i8CKF2QuTWtf8BDB/EC2E+tnIa/qWbEuz4SJf0RfRgg== X-Received: by 2002:a17:906:23ea:b0:993:d617:bdc2 with SMTP id j10-20020a17090623ea00b00993d617bdc2mr3608578ejg.75.1694270102010; Sat, 09 Sep 2023 07:35:02 -0700 (PDT) Received: from localhost.localdomain (82-149-12-148.dynamic.telemach.net. [82.149.12.148]) by smtp.gmail.com with ESMTPSA id n3-20020a17090695c300b0099bc8bd9066sm2433945ejy.150.2023.09.09.07.35.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Sep 2023 07:35:01 -0700 (PDT) From: Jernej Skrabec To: linus.walleij@linaro.org Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Jernej Skrabec Subject: [PATCH v2 2/2] pinctrl: pinmux: Use dev_err_probe() in pin_request() Date: Sat, 9 Sep 2023 16:34:57 +0200 Message-ID: <20230909143457.9149-3-jernej.skrabec@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230909143457.9149-1-jernej.skrabec@gmail.com> References: <20230909143457.9149-1-jernej.skrabec@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Use dev_err_probe() when printing error message in pin_request() since it may fail with -EPROBE_DEFER. Signed-off-by: Jernej Skrabec --- drivers/pinctrl/pinmux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c index 301fe0157b02..0ecd74ce5890 100644 --- a/drivers/pinctrl/pinmux.c +++ b/drivers/pinctrl/pinmux.c @@ -188,8 +188,8 @@ static int pin_request(struct pinctrl_dev *pctldev, } out: if (status) - dev_err(pctldev->dev, "pin-%d (%s) status %d\n", - pin, owner, status); + dev_err_probe(pctldev->dev, status, "pin-%d (%s)\n", + pin, owner); return status; }