From patchwork Fri Jul 26 11:27:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 169815 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp12908983ilk; Fri, 26 Jul 2019 04:27:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqyjlXufxku3M5npfKH++MPQt0vySRfqKnVoXCg/MAAiZ8o+YzA3Bvfp8V7GdY6li4AecGWC X-Received: by 2002:a62:1d8f:: with SMTP id d137mr22288082pfd.207.1564140469867; Fri, 26 Jul 2019 04:27:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564140469; cv=none; d=google.com; s=arc-20160816; b=ItEkewspb+fA95P/1mlfc9/Ti0qdjRJKnT7nCcgPKDEw9Hky07UpdxlLRQKclSurK6 qrntS7d0mkq6JUcewW9guFWkaHzuZ/0tHahJbL5Uhq7ZrvrcNIld6mZ7I7fZOUAgQcuP 2HL9EGXorAP/HbiHy6REXCsi7RftPvZv37feiSlM0+jZzUtjQEkHB4vucnuQx04nnPgP 9k3aoL2YkXOm1uheKr1RPry+z+2ap1SPEmzUXxb/GirH0F3FFW2v7huoFuQT9LClt2zq tZ8c0ECeCFsqzOPPsp8NdAim1480g9yLO58N891DFdWQkusOB+9ru1OoHF5uzUlJ3PgM L9pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=tkrBq1SnQkOBmUfMH8XCY0QYWm6lQdUCAmJmwMI79D0=; b=1CBsOGr3ZhKFKIw7D3Xjg/GF09LXhR2oHMQ7dyTkzv9Df4p9ASbjg3uwM9OiQAizoW Wf1tGqbESJ8B3EwJyIPaANx3OvVZMuCzdsNtzQ5CU10LPTy5jAWiEJQHfnYDOw2Sx71M f9YFRF3sVW7C944M7AhLeFi6H5+OhgmCEF5JawVfcixDXMlF0GFqSzmMtgP6EXrrhQWV dXh2k1nuvcXxe0mlN2Uj6IbRCA09oqnXfdIelbWd9PQxNfrh5jdElIPMHhjXdfHcr9dW 2ug+k80SBtMeBr+zmnQiGH/eG8T5O5bnOC3d92nDODDeolstgPVcWTgkxOTSUvaa3kiN nYSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=M1iiTaju; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c35si10444818pgm.51.2019.07.26.04.27.49; Fri, 26 Jul 2019 04:27:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=M1iiTaju; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726989AbfGZL1s (ORCPT + 29 others); Fri, 26 Jul 2019 07:27:48 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:36760 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726004AbfGZL1r (ORCPT ); Fri, 26 Jul 2019 07:27:47 -0400 Received: by mail-lf1-f68.google.com with SMTP id q26so36876549lfc.3 for ; Fri, 26 Jul 2019 04:27:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tkrBq1SnQkOBmUfMH8XCY0QYWm6lQdUCAmJmwMI79D0=; b=M1iiTajuphNdCuVUNMETkotkLA2uwCvt8+fc0HhCeN8FY+jFkztC4vtaGleozZsjp0 6RMNu1DG/drs0/txBSzX43RNK90A7jWVLQKj7569hfsTDoGateqOXe1wyVw2ycSt2flz WQE50mSYm5i94JOt4yAmI7YS+QcvOophZcWXbxWG5SMmo6KvALzHHE/IkQL/6c4yP81B RIPsLIdqUHaX33s/nJ46/ywpe+27JJ3KnbewYtlEdXxprzRmSC8RwalTuBTXMkecFgst ogj0phHtXMzsMPeheYDnkX5vAAIX2ZSvetV6x7plm+lhzWJymY3iXk8EpWfyRmHC/sI5 JVRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tkrBq1SnQkOBmUfMH8XCY0QYWm6lQdUCAmJmwMI79D0=; b=KKIK6tDJIKcvj5rgjLFSDBDA5kh7lufFJWrmjCLIvky/gPKFYxj+7eyAbnqIXprmzI WwQDb3V/95NxDvFLt0pvQLFQVyXfwRPRYPJipRbQhlP7HV6XRvgBpfRfy0wktl5B9tZL cLrKs3X+wKnd8MQZivvS0QLIFsdCBvED9y/O262+B+6T7GMTkW3Qd+/1pWLZaFUu5iW0 gc5z+jYFoArSSN8huaLq9JSMoIqir/Z8ANnQQrvRjXdlEaFXCEAfHM0wy1aRtD1rIchP fp25Hi/ossYUk3IzAuXLUnzX8YXLF/tbW/DmZPy9ROqzKyjmGwjw45/pJhNFd9EOyBeO 13yA== X-Gm-Message-State: APjAAAWk9h1oKZC9pTSpmYdXNNrVjRoPKYUJ9ek9iQtlHJ4VhMC+PG7v /21qzy7azdoNpIDpe78j7eCP3Q== X-Received: by 2002:ac2:5b09:: with SMTP id v9mr6868915lfn.22.1564140466048; Fri, 26 Jul 2019 04:27:46 -0700 (PDT) Received: from localhost (c-243c70d5.07-21-73746f28.bbcust.telenor.se. [213.112.60.36]) by smtp.gmail.com with ESMTPSA id u17sm8391919lfq.69.2019.07.26.04.27.45 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 26 Jul 2019 04:27:45 -0700 (PDT) From: Anders Roxell To: airlied@linux.ie, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Anders Roxell , stable@vger.kernel.org Subject: [PATCH] drm: mali-dp: Mark expected switch fall-through Date: Fri, 26 Jul 2019 13:27:41 +0200 Message-Id: <20190726112741.19360-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When fall-through warnings was enabled by default, commit d93512ef0f0e ("Makefile: Globally enable fall-through warning"), the following warnings was starting to show up: ../drivers/gpu/drm/arm/malidp_hw.c: In function ‘malidp_format_get_bpp’: ../drivers/gpu/drm/arm/malidp_hw.c:387:8: warning: this statement may fall through [-Wimplicit-fallthrough=] bpp = 30; ~~~~^~~~ ../drivers/gpu/drm/arm/malidp_hw.c:388:3: note: here case DRM_FORMAT_YUV420_10BIT: ^~~~ ../drivers/gpu/drm/arm/malidp_hw.c: In function ‘malidp_se_irq’: ../drivers/gpu/drm/arm/malidp_hw.c:1311:4: warning: this statement may fall through [-Wimplicit-fallthrough=] drm_writeback_signal_completion(&malidp->mw_connector, 0); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/gpu/drm/arm/malidp_hw.c:1313:3: note: here case MW_START: ^~~~ Rework to add a 'break;' in a case that didn't have it so that the compiler doesn't warn about fall-through. Cc: stable@vger.kernel.org # v4.9+ Fixes: b8207562abdd ("drm/arm/malidp: Specified the rotation memory requirements for AFBC YUV formats") Signed-off-by: Anders Roxell --- drivers/gpu/drm/arm/malidp_hw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.20.1 diff --git a/drivers/gpu/drm/arm/malidp_hw.c b/drivers/gpu/drm/arm/malidp_hw.c index 50af399d7f6f..dc5fff9af338 100644 --- a/drivers/gpu/drm/arm/malidp_hw.c +++ b/drivers/gpu/drm/arm/malidp_hw.c @@ -385,6 +385,7 @@ int malidp_format_get_bpp(u32 fmt) switch (fmt) { case DRM_FORMAT_VUY101010: bpp = 30; + break; case DRM_FORMAT_YUV420_10BIT: bpp = 15; break; @@ -1309,7 +1310,7 @@ static irqreturn_t malidp_se_irq(int irq, void *arg) break; case MW_RESTART: drm_writeback_signal_completion(&malidp->mw_connector, 0); - /* fall through to a new start */ + /* fall through */ case MW_START: /* writeback started, need to emulate one-shot mode */ hw->disable_memwrite(hwdev);