From patchwork Fri Jul 26 11:27:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 169816 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp12909039ilk; Fri, 26 Jul 2019 04:27:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqym18PQjkRb/0WwMF1wuVC10caXUYDzlZnbeU2X9mGM6GAgxfFo/qCpRjTlQiO9g4oc9JXP X-Received: by 2002:a63:7a01:: with SMTP id v1mr92979289pgc.310.1564140473972; Fri, 26 Jul 2019 04:27:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564140473; cv=none; d=google.com; s=arc-20160816; b=efaBD8YwuDClub5WoDtGgtbCPFeWfjYnpbWpPwCWBcvhXhfEStzGnaCfPi0N/ejp0k V0us+7hb2tZoU9D0Dnrh0dk21wINjcIeOPfIzv2Ik6SS45Qre7O37vH/FcMGMf12z+xa tIXnSY3honIJGSE8FbnE9Ka+grbE6PZIabWJh9u92EKuQDJCkXf/95b6h/n8pmzAkmaI n2PMt3LQFRF2+z6dL7Kqu9prei9AebH7nRvrCNhI/iOygsKae6wkPHjixVP+Y2x5Zr2K Fs5VQuGoQmlDrqXmA2jy9oFoS9Lx1wsgpAycbsynXv1mg8y7LzyYKxQdNwRyK8rgh3Ri vZ+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=dQH4GnL/y7NNHvqjapmVG2NpS/ejAHj8nLLRQ4EYloU=; b=MTwEMnS+iF43C49DvqpEJDFm+NyGgCbbnoLcmAgNx4PZGo2KTCGB83Dc6xHJ7zbqvm NUPr87tZZ8nJ7c+XE8Hhn16LWzfnQf+zLWPMxTy0AJhbzpAvTdkx6M49T1XzDkeFgteK K8azx3fJEzqElMXcnwthZtFEaEgVitvmSAvDynI5xr+zojMBb1V1p/YcOjZoOXyR7xwc 6EC1q8IcpU/m7F65l3qMXp1970S1LhP5cOdK9gOyhCv9rZM8Olgz3GyQlmZniMaeqiPi FuQsxZ8XoI5SiIzOZOaJ3R8QPW2vvDY3MN1Wq0ySbjx2vBsuaKRsCvFKTooPF6dh+xAq WsjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="MeM/PtQC"; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c35si10444818pgm.51.2019.07.26.04.27.53; Fri, 26 Jul 2019 04:27:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="MeM/PtQC"; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726329AbfGZL1x (ORCPT + 15 others); Fri, 26 Jul 2019 07:27:53 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:43570 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726302AbfGZL1x (ORCPT ); Fri, 26 Jul 2019 07:27:53 -0400 Received: by mail-lf1-f67.google.com with SMTP id c19so36843688lfm.10 for ; Fri, 26 Jul 2019 04:27:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dQH4GnL/y7NNHvqjapmVG2NpS/ejAHj8nLLRQ4EYloU=; b=MeM/PtQCEY3Pof5+eaMTAWxOiKj2b/a9tQSd91Y3IuzC6dgUIHxOagN/qoHqAHA2rs Jkr2mriESm2QVd3Bx/UMF4Qut41yjn7Vn3M4jDMaSnxQlZOfx+P0EOR0E5piucx7sbw+ AGAtaFLkRXdpa4uKjDiXEQZZtdqBMD1XnDbZfF4aflyRQsHFJ/lNAq0WE5+jKUY7Iuyi xKzL5883lT5fmNnJkIpB+OrR1rJg/xzD+lJGlw62fRf5G2FpiEQxZyzt7sj7IQg87xDp X8YA9i+Gmtmy87qydkMAz5VMETa5mpEiMWaKMBmoHYggHLm8A92JgRnRNdCTkyGqAsH0 9DRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dQH4GnL/y7NNHvqjapmVG2NpS/ejAHj8nLLRQ4EYloU=; b=MTmYcF6cLeDe+6K6rohthuKqq1qyF+ungNqOJ8E+7ro1U7/I0DreLw99oL/3tmb5iL 7X8n9weHAy0CKv8DU4ftn6MedpCfbpXndM8MDVprYNSBi4Pr1x8UgFStFTP3OHFJokwU sF4p//UZ0CRfp8/m1gc2hbpav868XXOPjzQteQkr3K4N5vRth0vV109bn+yTzmh1wTwb eHkvccJODMlAO8DiBcOvdtWIMv9XREfS1Y3MWGxBEarLMVDNwGm8163CKazuXxri3blI VlgmFK5LEdxZuUvg9c4cCDDKtc2fC+dbErcMNlj0+Ru4IbqiQl5YSAKJoKT3zj4CK0wM 030A== X-Gm-Message-State: APjAAAX0bZA1/ASfK0Mn7lGxzoQqYtD/5iNj0DR3XLztXf4TIf9mzkgS cdM/ecXt6pwJ2F4jlWvEvJyPmw== X-Received: by 2002:ac2:59c9:: with SMTP id x9mr41706584lfn.52.1564140470939; Fri, 26 Jul 2019 04:27:50 -0700 (PDT) Received: from localhost (c-243c70d5.07-21-73746f28.bbcust.telenor.se. [213.112.60.36]) by smtp.gmail.com with ESMTPSA id m17sm8218208lfj.22.2019.07.26.04.27.49 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 26 Jul 2019 04:27:50 -0700 (PDT) From: Anders Roxell To: robdclark@gmail.com, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Anders Roxell Subject: [PATCH 1/3] drm: msm: a6xx: Mark expected switch fall-through Date: Fri, 26 Jul 2019 13:27:46 +0200 Message-Id: <20190726112746.19410-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org When fall-through warnings was enabled by default the following warning was starting to show up: ../drivers/gpu/drm/msm/adreno/a6xx_gpu.c: In function ‘a6xx_submit’: ../drivers/gpu/drm/msm/adreno/a6xx_gpu.c:116:7: warning: this statement may fall through [-Wimplicit-fallthrough=] if (priv->lastctx == ctx) ^ ../drivers/gpu/drm/msm/adreno/a6xx_gpu.c:118:3: note: here case MSM_SUBMIT_CMD_BUF: ^~~~ Rework so that the compiler doesn't warn about fall-through. Fixes: d93512ef0f0e ("Makefile: Globally enable fall-through warning") Signed-off-by: Anders Roxell --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 1 + 1 file changed, 1 insertion(+) -- 2.20.1 diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index be39cf01e51e..644a6ee53f05 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -115,6 +115,7 @@ static void a6xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit, case MSM_SUBMIT_CMD_CTX_RESTORE_BUF: if (priv->lastctx == ctx) break; + /* Fall through */ case MSM_SUBMIT_CMD_BUF: OUT_PKT7(ring, CP_INDIRECT_BUFFER_PFE, 3); OUT_RING(ring, lower_32_bits(submit->cmd[i].iova)); From patchwork Fri Jul 26 11:27:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 169817 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp12909107ilk; Fri, 26 Jul 2019 04:27:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqxhsdrQFxR37cfO0XFotmUxzjSZuLv+hZLX6ZV8kTaUZXZRLvYc/UTV4JhCP1rSwRxklPN6 X-Received: by 2002:a63:20d:: with SMTP id 13mr80079877pgc.253.1564140478571; Fri, 26 Jul 2019 04:27:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564140478; cv=none; d=google.com; s=arc-20160816; b=tEgX56tipl7HTaoWG4U0ZAWFTeGjQM9tTYtYHElNMQ8tFnEtfONwoj9VR3M3SyRuur IbPql0wB+PHYYyaaFkZuds1P60CV9bOB39CTwDcOq2isli9AFe23zpZcU8f6kieh201m bB2rToMYlUDNG5+6OSqZL87CExSdjSA8CFZR/lASONmJbE9MECmPLpkNCm90RThDMFZQ ntq5J4KU6ygQzXUzE4gysCrST9caZVeXM+vAkooQAQ+4P7AJzs9kDYEy8hUMcncaaYvD +NmtFfGAC3ayffFLot8XE6qk6PTMYNajBXRT5vQhb9dgNJMokiK8pZDcCHO8N6M1rZ6Y KorA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=mhZxThgFyoxuQkXVr0Rs3Bv05HhD+nUqY4oSH8BKepE=; b=o3UhTS2Fa7p3jVaMbSg86DcuzrYDG290HyX9tlv8QcQjbkMIVY1si4wQkMwLRfY2Hu FzYkGXVGtatqUg+uIc8jYcBpIS4/XZjOKphv7Kg4KGu0VDn8vob/cT0jjjEm7EUx4OjW +0cxGvFxBfBxxFkxniy779RYYcb4m++3sShbCzCDcTkXmqoGhVrMXVDbmGd5GvZ+Noj/ 2mg1pWCl1vjw1NIrORFk4S98fcCqnEUWTZSakh44ouHiJkFb3twVGwp8iAK2TsjGe7dj 3WA8oBTvvjnQqUGilMyBmZkXQFZvNqHgXHzKEi0YCCqXzuvb8n8I6ERF+V7lLdSd76Lg 4elw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SjTC7eCV; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y193si19708860pgd.108.2019.07.26.04.27.58; Fri, 26 Jul 2019 04:27:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SjTC7eCV; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726956AbfGZL15 (ORCPT + 15 others); Fri, 26 Jul 2019 07:27:57 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:43574 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726302AbfGZL15 (ORCPT ); Fri, 26 Jul 2019 07:27:57 -0400 Received: by mail-lf1-f65.google.com with SMTP id c19so36843809lfm.10 for ; Fri, 26 Jul 2019 04:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mhZxThgFyoxuQkXVr0Rs3Bv05HhD+nUqY4oSH8BKepE=; b=SjTC7eCVIgTYtXnx7wObMb0ka5YstKwcZt/k/di80kRHdujbyS/FGyHfIdL0+e5y5E lqNmDrIWjd3F9+9qNIu4+G/nKrBArgVH4eRkpSgNjIXUQQL7OqX6HUs2x1Ml+I+sZnno pX9ipCGgGEy+PzZxblaZr+5iGjAtNujUqzId+cjtqMooZh4FFYyb3Mqp8+wyp89GbEc8 S/X/V6xNLx+1QVsSv3+xGI8bHqkzYa+wYLHyJNbhHBQ8AwbrpN4BRpYeHEoZPCiCftxX vPR8yGPV9CnGyRSDMW7ctHuhGVRHFFfSE8q8D8pC8txmN0jZ2KdSIq5gvMjpAZvoSEQE FuIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mhZxThgFyoxuQkXVr0Rs3Bv05HhD+nUqY4oSH8BKepE=; b=g/1nbmJrHMaayES4YvFZIHbc+K+tEXPVMMdn+duFA6Xs8pCgfii4Mk2qXmEUQvWn55 Omh3AtcrUvLF11F5q1AikBlGs4iT3G2OAXC+t0RMazM5wDjCoxLU24woSBnZEEG33EPS SIDxndf/yUv3DH8fIko8IpLtR60eRoljmDFXfj0B7g/1TKixZNHvgwnJAkHya6j05ksf DRG5QUHL5yv+MoCRr8vfjrJiv+Huu6JW29I81SFtlGASTaeq8C8csnUkJnDpCfHZFNTa 5QJ3OdD5tWEk36lb6o3R8IpaqPJCE/IoABfbBzhOAFI4Ox0y4DF2GJpdnStF+VfUS+tM SeCQ== X-Gm-Message-State: APjAAAUh4d/nZTMPEh7zNNFJ+42CXRxZ6qbM68ecQ9I0hqs5Nx5jlO1M 6KiHKg01Z2ro9S4bMNU1ZMwi3g== X-Received: by 2002:a19:6557:: with SMTP id c23mr2265309lfj.12.1564140475478; Fri, 26 Jul 2019 04:27:55 -0700 (PDT) Received: from localhost (c-243c70d5.07-21-73746f28.bbcust.telenor.se. [213.112.60.36]) by smtp.gmail.com with ESMTPSA id l22sm9911343ljc.4.2019.07.26.04.27.54 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 26 Jul 2019 04:27:54 -0700 (PDT) From: Anders Roxell To: robdclark@gmail.com, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Anders Roxell Subject: [PATCH 2/3] drm: msm: a5xx: Mark expected switch fall-through Date: Fri, 26 Jul 2019 13:27:51 +0200 Message-Id: <20190726112751.19461-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org When fall-through warnings was enabled by default the following warning was starting to show up: ../drivers/gpu/drm/msm/adreno/a5xx_gpu.c: In function ‘a5xx_submit’: ../drivers/gpu/drm/msm/adreno/a5xx_gpu.c:150:7: warning: this statement may fall through [-Wimplicit-fallthrough=] if (priv->lastctx == ctx) ^ ../drivers/gpu/drm/msm/adreno/a5xx_gpu.c:152:3: note: here case MSM_SUBMIT_CMD_BUF: ^~~~ Rework so that the compiler doesn't warn about fall-through. Fixes: d93512ef0f0e ("Makefile: Globally enable fall-through warning") Signed-off-by: Anders Roxell --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.20.1 diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c index 1671db47aa57..71397ed3c99f 100644 --- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c @@ -59,6 +59,7 @@ static void a5xx_submit_in_rb(struct msm_gpu *gpu, struct msm_gem_submit *submit case MSM_SUBMIT_CMD_CTX_RESTORE_BUF: if (priv->lastctx == ctx) break; + /* Fall through */ case MSM_SUBMIT_CMD_BUF: /* copy commands into RB: */ obj = submit->bos[submit->cmd[i].idx].obj; @@ -149,6 +150,7 @@ static void a5xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit, case MSM_SUBMIT_CMD_CTX_RESTORE_BUF: if (priv->lastctx == ctx) break; + /* Fall through */ case MSM_SUBMIT_CMD_BUF: OUT_PKT7(ring, CP_INDIRECT_BUFFER_PFE, 3); OUT_RING(ring, lower_32_bits(submit->cmd[i].iova)); From patchwork Fri Jul 26 11:27:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 169818 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp12909240ilk; Fri, 26 Jul 2019 04:28:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqxXSIyIoka4nbxCZnnDpbwJDNvF+UfjYts1m/dLpUISDuayZuQL/1iF405dwrntVjgKx+sT X-Received: by 2002:a17:902:f204:: with SMTP id gn4mr96758624plb.3.1564140485053; Fri, 26 Jul 2019 04:28:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564140485; cv=none; d=google.com; s=arc-20160816; b=B+D+gi3TocqbBjTI0Gf/WOm2S9PS0rnteCkbqBSarFME1fwVC5/ZwF2Mu0jDqH8A8F /CBDnPjq64trli0C9EddE3wa3fz4+EsKSwedzfe7e1PpZj6BbJNYz2I1AC3ixlOLG6lG oGNniKsKp4D/6lV9UjYQSKS8AsdjgWg7AALzGQmU5REXGNYNAvf+Ld/feK3YPlpJyUQ+ D61YjdDNijKUEVk3wiX8H+bXEZopIKbVyKGwBR/MrgmkAOXGlHcPWC3DwDiIUQDRibTj znpdWREK2aQ7RNBO9PyYf7yYaxoM6caSbN+RrhG20EhDwcjo1rfytUauPRBb9fx9/9sV fSAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=K7MgO7LDfJLI1re2AmLs6fSClTgO04pZ2Z1SN3XHnLo=; b=iatzPROCQilxzdYK6cn3xHZgg9zapvpdW6SAjKbKstaFvDSJttTTJiM1/NyimaYhWG DWedi7cZYDzOEmbwX53KKzT8O+Gyc4qM0BIMw2FpOYyg5Yz3aRW+OyrKA5xscR63HLQR rG4wKYPRtZb5Mz/yCRUVY6e9bNvD62uhxYglesLcgwFFmYhP6C+GFosvsesA30AJdkAh iu9NcH1MF8rWkPtpM/0Hg9PhBT/cfGWkDsmDfvC4fsoRhFNdJQzjxJ7c9gcc2mq6QdB5 szbJpkXPVtgXCnmXRxCFWpuhtxupqCxLDZIqvo+nrnWgyHIt5x4Jrr4WwQEKU6eMba13 TvLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="L/TZ3vb3"; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f131si18248623pgc.265.2019.07.26.04.28.04; Fri, 26 Jul 2019 04:28:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="L/TZ3vb3"; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727034AbfGZL2E (ORCPT + 15 others); Fri, 26 Jul 2019 07:28:04 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:40223 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726087AbfGZL2D (ORCPT ); Fri, 26 Jul 2019 07:28:03 -0400 Received: by mail-lj1-f195.google.com with SMTP id m8so17546716lji.7 for ; Fri, 26 Jul 2019 04:28:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=K7MgO7LDfJLI1re2AmLs6fSClTgO04pZ2Z1SN3XHnLo=; b=L/TZ3vb3T22EK1HJo+QpkSQL7fhtmr9agOpQ8pWUpl20813rj+CmWCzmfwqt2D54to DWNS4kJSBjnHDUgf+X9oCYLxE1orEFH+x89VNk7jykOjUABheMYPrvsCnQNaVFE8SZN3 3mIK54oD4QUmhWcOZOTtN9UrJT1zKoZ9HGzKb0Yrxq1RtjXRr6tjOY9B7hljvZbC13OS reks/ePwtDW5kj50ROfXjekOPnxhGDdp1a0fTE9/FMdR/hVF2EFOeZtoVTaA71eVQ0k5 mobVZ6zgAuegz3xyvBto6aiJKauJC+/adkzyU7FrLXgarhBd3YqqpBfJgEE4a8Ay7TK9 1qTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=K7MgO7LDfJLI1re2AmLs6fSClTgO04pZ2Z1SN3XHnLo=; b=V33IxFyXJ04uC4ZHUv1lWrnjcMv7wg6r6Q4oxmxo41+Y0gur0UQ0kjfUZwtbvWJJYD 08lvRS8f00q5/YYGUv5PwLtJ0dzns7enw2p0dqzOaIfq+/IxRqq7XinLzCB0B0qNBlKZ kyJB7djdg2/HHECKllEtB//DDcqbzQCl5GG3u4DSkJ3nrylie2zsYGjGSnNPRmV+pL7S 6lF5r/wYgsu/vS8azn6hIWIqeJLVqkt3wcVMO5Dy6kWXzVz2g5Flk8jKz29NQqagrjVJ +30a/3lfes0w3NpnynwSnw9FcmAG/P3UM+hMTchTwBVotXcpjtSpjXqqLvFtDDdTao8+ DXBA== X-Gm-Message-State: APjAAAVSCIZrfJlzIh+XbqaMnFhLBDxgqpp1LAa1EOKF7uOhjY7JwR8L qKkdZRwjjTHiNh9BtSbP0DXWjQ== X-Received: by 2002:a2e:8e90:: with SMTP id z16mr1684039ljk.4.1564140481817; Fri, 26 Jul 2019 04:28:01 -0700 (PDT) Received: from localhost (c-243c70d5.07-21-73746f28.bbcust.telenor.se. [213.112.60.36]) by smtp.gmail.com with ESMTPSA id v86sm9926234lje.74.2019.07.26.04.28.00 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 26 Jul 2019 04:28:00 -0700 (PDT) From: Anders Roxell To: robdclark@gmail.com, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Anders Roxell Subject: [PATCH 3/3] drm: msm: a3xx: Mark expected switch fall-through Date: Fri, 26 Jul 2019 13:27:55 +0200 Message-Id: <20190726112755.19511-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org When fall-through warnings was enabled by default the following warning was starting to show up: ../drivers/gpu/drm/msm/adreno/adreno_gpu.c: In function ‘adreno_submit’: ../drivers/gpu/drm/msm/adreno/adreno_gpu.c:429:7: warning: this statement may fall through [-Wimplicit-fallthrough=] if (priv->lastctx == ctx) ^ ../drivers/gpu/drm/msm/adreno/adreno_gpu.c:431:3: note: here case MSM_SUBMIT_CMD_BUF: ^~~~ Rework so that the compiler doesn't warn about fall-through. Fixes: d93512ef0f0e ("Makefile: Globally enable fall-through warning") Signed-off-by: Anders Roxell --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 1 + 1 file changed, 1 insertion(+) -- 2.20.1 diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index 9acbbc0f3232..8fea014f0dea 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -428,6 +428,7 @@ void adreno_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit, /* ignore if there has not been a ctx switch: */ if (priv->lastctx == ctx) break; + /* Fall through */ case MSM_SUBMIT_CMD_BUF: OUT_PKT3(ring, adreno_is_a430(adreno_gpu) ? CP_INDIRECT_BUFFER_PFE : CP_INDIRECT_BUFFER_PFD, 2);