From patchwork Wed Sep 27 08:49:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: chenguohua@jari.cn X-Patchwork-Id: 727004 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30290E810B1 for ; Wed, 27 Sep 2023 08:51:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229985AbjI0IvH (ORCPT ); Wed, 27 Sep 2023 04:51:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230248AbjI0IvE (ORCPT ); Wed, 27 Sep 2023 04:51:04 -0400 Received: from jari.cn (unknown [218.92.28.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B1120F4; Wed, 27 Sep 2023 01:51:02 -0700 (PDT) Received: from chenguohua$jari.cn ( [182.148.12.64] ) by ajax-webmail-localhost.localdomain (Coremail) ; Wed, 27 Sep 2023 16:49:44 +0800 (GMT+08:00) X-Originating-IP: [182.148.12.64] Date: Wed, 27 Sep 2023 16:49:44 +0800 (GMT+08:00) X-CM-HeaderCharset: UTF-8 From: chenguohua@jari.cn To: aradford@gmail.com, jejb@linux.ibm.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] scsi: 3w-sas: Clean up errors in 3w-sas.h X-Priority: 3 X-Mailer: Coremail Webmail Server Version 2023.1-cmXT6 build 20230419(ff23bf83) Copyright (c) 2002-2023 www.mailtech.cn mispb-4e503810-ca60-4ec8-a188-7102c18937cf-zhkzyfz.cn MIME-Version: 1.0 Message-ID: <38a151ef.88d.18ad5d47214.Coremail.chenguohua@jari.cn> X-Coremail-Locale: zh_CN X-CM-TRANSID: AQAAfwDHZD+o7BNl7_u9AA--.630W X-CM-SenderInfo: xfkh0w5xrk3tw6md2xgofq/1tbiAQAHEWUSpy8AOwAts+ X-Coremail-Antispam: 1Ur529EdanIXcx71UUUUU7IcSsGvfJ3iIAIbVAYjsxI4VWxJw CS07vEb4IE77IF4wCS07vE1I0E4x80FVAKz4kxMIAIbVAFxVCaYxvI4VCIwcAKzIAtYxBI daVFxhVjvjDU= Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Fix the following errors reported by checkpatch: ERROR: that open brace { should be on the previous line ERROR: space required after that ',' (ctx:VxV) ERROR: open brace '{' following struct go on the same line Signed-off-by: GuoHua Cheng --- drivers/scsi/3w-sas.h | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/3w-sas.h b/drivers/scsi/3w-sas.h index 096dec29e2ac..3443ccbf73e1 100644 --- a/drivers/scsi/3w-sas.h +++ b/drivers/scsi/3w-sas.h @@ -46,8 +46,7 @@ #define _3W_SAS_H /* AEN severity table */ -static char *twl_aen_severity_table[] = -{ +static char *twl_aen_severity_table[] = { "None", "ERROR", "WARNING", "INFO", "DEBUG", NULL }; @@ -152,11 +151,11 @@ static char *twl_aen_severity_table[] = /* Bitmask macros to eliminate bitfields */ /* opcode: 5, reserved: 3 */ -#define TW_OPRES_IN(x,y) ((x << 5) | (y & 0x1f)) +#define TW_OPRES_IN(x, y) ((x << 5) | (y & 0x1f)) #define TW_OP_OUT(x) (x & 0x1f) /* opcode: 5, sgloffset: 3 */ -#define TW_OPSGL_IN(x,y) ((x << 5) | (y & 0x1f)) +#define TW_OPSGL_IN(x, y) ((x << 5) | (y & 0x1f)) #define TW_SGL_OUT(x) ((x >> 5) & 0x7) /* severity: 3, reserved: 5 */ @@ -204,11 +203,11 @@ static char *twl_aen_severity_table[] = (writel(TWL_ISSUE_SOFT_RESET, TWL_HIBDB_REG_ADDR(tw_dev))) /* Macros */ -#define TW_PRINTK(h,a,b,c) { \ +#define TW_PRINTK(h, a, b, c) { \ if (h) \ -printk(KERN_WARNING "3w-sas: scsi%d: ERROR: (0x%02X:0x%04X): %s.\n",h->host_no,a,b,c); \ +printk(KERN_WARNING "3w-sas: scsi%d: ERROR: (0x%02X:0x%04X): %s.\n", h->host_no, a, b, c); \ else \ -printk(KERN_WARNING "3w-sas: ERROR: (0x%02X:0x%04X): %s.\n",a,b,c); \ +printk(KERN_WARNING "3w-sas: ERROR: (0x%02X:0x%04X): %s.\n", a, b, c); \ } #define TW_MAX_LUNS 16 #define TW_COMMAND_SIZE (sizeof(dma_addr_t) > 4 ? 6 : 4) @@ -310,8 +309,7 @@ typedef struct TAG_TW_Initconnect { } TW_Initconnect; /* Event info structure */ -typedef struct TAG_TW_Event -{ +typedef struct TAG_TW_Event { unsigned int sequence_id; unsigned int time_stamp_sec; unsigned short aen_code; @@ -348,8 +346,7 @@ typedef struct { } TW_Param_Apache; /* Compatibility information structure */ -typedef struct TAG_TW_Compatibility_Info -{ +typedef struct TAG_TW_Compatibility_Info { char driver_version[32]; unsigned short working_srl; unsigned short working_branch;