From patchwork Tue Jul 30 15:30:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 170075 Delivered-To: patch@linaro.org Received: by 2002:a92:512:0:0:0:0:0 with SMTP id q18csp2779363ile; Tue, 30 Jul 2019 08:31:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqzXsaN2xYgNXRxJZRFvXdPQii/YfiwVFQs2LZj6t5AD7HXKSmEpMW832Bym6672h2ZOZRZe X-Received: by 2002:a65:6081:: with SMTP id t1mr110926646pgu.9.1564500676398; Tue, 30 Jul 2019 08:31:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564500676; cv=none; d=google.com; s=arc-20160816; b=Qiq3Ib3EscNcPAa7hTQdhqGIHkgL7Pw+0DfMettAHRnViIz+eNIGGV5hAB1ZZDTPj4 K9gqqse+OUVkNL43rj/oaVNWodSo57aCrarObJoilzEb8kwpF0KXmym/UHCFIEHI+qqZ JDIKca+baH+JTXAopAodzZ+9q2LarnJTIyphdADrH+mAV+LW5s/+LlFD9pQskqmacbu6 LRzNCWp+knGU+t1KOz+lJV3sDpkhNKsX+noWb5o71Tnwz/QSTgfR1LUj/XnEkLYIQUFT wb/lzDTEDmSybT6b3FADkaeWmT/ZdHWuEogAB93YcKLprkjXknZx9GpGuM3n85vNCdCv QF/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ijf+IXMFVOGyvl/6lR3Dl4FHOPijwIT8zlA3D+mB5Zg=; b=w+9SyIMy678nKw/cuYM0d2Or0F7uHpcrxZxceFr/8+xUSvG0v5m4PgMJuURvjA12er ZplHu+aBppCxG7O2bBDtA4l3uoxIHYLJOil13Ws/qBQdTmCA4bNHQxxPtK7e/ynTI/Bh oM936yyt+Q7F1A8VbLBI3N3Yaxqo/SsepZO3M+2IV5b1NvQhN1Jk/jDhi+wOj51/DMUa NdxS9AxQr/W5T3BnTUeOJtt5Xfi+WARcmo328IbJmeFXjIBxujfQ59GSn/aU3EljySs+ cr+k1IP7KfpL9wAp9XXiGyNsIqqL9FTpwYg0YFydF6gYbgv64Chl+J3ObNapsQ4APiJ3 pTcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ky12He8K; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q8si30566854pjp.61.2019.07.30.08.31.15; Tue, 30 Jul 2019 08:31:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ky12He8K; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731879AbfG3PbO (ORCPT + 29 others); Tue, 30 Jul 2019 11:31:14 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:39822 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731347AbfG3PbN (ORCPT ); Tue, 30 Jul 2019 11:31:13 -0400 Received: by mail-lj1-f194.google.com with SMTP id v18so62456731ljh.6 for ; Tue, 30 Jul 2019 08:31:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ijf+IXMFVOGyvl/6lR3Dl4FHOPijwIT8zlA3D+mB5Zg=; b=ky12He8Kf8tUIMDwGJbIw/FAZCNoOYc2+0deJeoUMUYn71ibisQOQBx3k6VOLHsTuo B1dzMxoZdynUB6zjeAwIMLthlkJ+ZjykQ1XLvWnpUkORJ49J2i7rTLTrcxe5S5wVazgY sN4tUbFcMmf6azm9wd2Vt0HGmw8R3gjYK7q4u7dP3xcI6T0V84NL7ri6cxhfjiIWcTk8 szRtTwondYA84H0RtHLJ59dTa0a8GMLmHcwNszu7oJaWMsbBkpH80NIHAuBR3faQ+lBp jC5V/LgKlFNaEWIBprf+MaSxhio7gITyAIw64IdCi+q4VVkTkoEPpDHFuEv0fQQHIDiz 22OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ijf+IXMFVOGyvl/6lR3Dl4FHOPijwIT8zlA3D+mB5Zg=; b=bEmaDRJMBb0cJXW5REWmUP9xgkdsbScogLjcaJ3RG5k2efsLe6d2Eib6H/Gm/7ztTp mdSI43zVsJ4TRewHPyW4g8bVeoN58kr1chtFs1Bhiff4IN2TCjve57zWc7z6encccoio U0ykRdHkpqYrAfbh1bpKAY2hzlcL8SamFhuIYc6eYKeBVArBDPJnxveivmKoqBQIwSrx Zz9pfIbnqLGMisamoum/EEGut6/50yizOv/UHkE6X+9xh00MOtA0SlyYfm6oGVeFDpyR ilQGYoYoJTG2jqTKrw5m4YY6UtMiko5lNaJeg31EtAGhfVrzdLK0rH+z/XSJ6/d0JaSa hZdw== X-Gm-Message-State: APjAAAVrpGqFeGQblaIn3oewhIQlP7yjZufFf7xhA6QU2fdtxDZoe8Hq cgtG1ipwLLydO63A771tmAd4PkOGAxTfug== X-Received: by 2002:a05:651c:1b8:: with SMTP id c24mr63473072ljn.2.1564500671320; Tue, 30 Jul 2019 08:31:11 -0700 (PDT) Received: from localhost (c-243c70d5.07-21-73746f28.bbcust.telenor.se. [213.112.60.36]) by smtp.gmail.com with ESMTPSA id l22sm13409494ljc.4.2019.07.30.08.31.09 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 30 Jul 2019 08:31:10 -0700 (PDT) From: Anders Roxell To: malidp@foss.arm.com, airlied@linux.ie, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, gustavo@embeddedor.com, liviu.dudau@arm.com, Anders Roxell , stable@vger.kernel.org Subject: [PATCH v2] drm: mali-dp: Mark expected switch fall-through Date: Tue, 30 Jul 2019 17:30:56 +0200 Message-Id: <20190730153056.3606-1-anders.roxell@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that -Wimplicit-fallthrough is passed to GCC by default, the following warnings shows up: ../drivers/gpu/drm/arm/malidp_hw.c: In function ‘malidp_format_get_bpp’: ../drivers/gpu/drm/arm/malidp_hw.c:387:8: warning: this statement may fall through [-Wimplicit-fallthrough=] bpp = 30; ~~~~^~~~ ../drivers/gpu/drm/arm/malidp_hw.c:388:3: note: here case DRM_FORMAT_YUV420_10BIT: ^~~~ ../drivers/gpu/drm/arm/malidp_hw.c: In function ‘malidp_se_irq’: ../drivers/gpu/drm/arm/malidp_hw.c:1311:4: warning: this statement may fall through [-Wimplicit-fallthrough=] drm_writeback_signal_completion(&malidp->mw_connector, 0); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/gpu/drm/arm/malidp_hw.c:1313:3: note: here case MW_START: ^~~~ Rework to add a 'break;' in a case that didn't have it so that the compiler doesn't warn about fall-through. Cc: stable@vger.kernel.org # v5.2+ Fixes: b8207562abdd ("drm/arm/malidp: Specified the rotation memory requirements for AFBC YUV formats") Acked-by: Liviu Dudau Signed-off-by: Anders Roxell --- drivers/gpu/drm/arm/malidp_hw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.20.1 diff --git a/drivers/gpu/drm/arm/malidp_hw.c b/drivers/gpu/drm/arm/malidp_hw.c index 50af399d7f6f..380be66d4c6e 100644 --- a/drivers/gpu/drm/arm/malidp_hw.c +++ b/drivers/gpu/drm/arm/malidp_hw.c @@ -385,6 +385,7 @@ int malidp_format_get_bpp(u32 fmt) switch (fmt) { case DRM_FORMAT_VUY101010: bpp = 30; + break; case DRM_FORMAT_YUV420_10BIT: bpp = 15; break; @@ -1309,7 +1310,7 @@ static irqreturn_t malidp_se_irq(int irq, void *arg) break; case MW_RESTART: drm_writeback_signal_completion(&malidp->mw_connector, 0); - /* fall through to a new start */ + /* fall through - to a new start */ case MW_START: /* writeback started, need to emulate one-shot mode */ hw->disable_memwrite(hwdev);