From patchwork Thu Oct 5 12:15:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mahesh Talewad X-Patchwork-Id: 729766 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C73BFE75451 for ; Thu, 5 Oct 2023 16:35:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236515AbjJEQeM (ORCPT ); Thu, 5 Oct 2023 12:34:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233266AbjJEQcn (ORCPT ); Thu, 5 Oct 2023 12:32:43 -0400 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20630.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d00::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 379D5261A6 for ; Thu, 5 Oct 2023 05:16:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M5byRVOGjbeRrqGTd1QWOzErnR2hm/kDFcCMHiDCP8QyAqlF6v/YOH1/DXHilHZ2ZMiMSjabfsh6ejE7OmbWQOnqobF7aN64dkaf+j6v4kaBOeGW56/nytyImxi4008C+3RWUjou2WQmGM0aqmp94iwWcvhPKBqYryHmhwXZIfvXlKppPb1VDmYP2IiqZi8mJ2wdHZvIemgvihgY1ti4kILJHzNRiHXsLWxlXtbU1PHbrLRcFZYoh3pqqZuDZ3TFjqVQfxVWDZABM+e54wO9yH7DHbIJmo3ktcxYkffW31uWk06KAufZV6nACzb6IHsyb3UZzJy4LgcBFjJveBwv8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bsIxZdhXj0SoDed03rKl2vhKRi6xkFgFfka8U53Q0Yc=; b=UEeZSy1/wglqfY+HP6v0TbAbUdNGYLnAiBkBLC6B47miz1aO73zS0o/2kQ1/001zvg/Fo9i4Nke1jkIpgnMoXhMqfZ07x8WwdgW5i/V8LZ2s9k9kC1xk4IxlkoIrhm+HellCGGjaLElb+y6BsuWkz9fDasetLPrWg5a/OIBm8CdcgyiSQVTVQ+Jr7MbcQbxVTHFR/obhfVCYAaCJPCWA4RsyLb1kxY7VSk/uKNme7UIDPSE+fXEznE801nfk3rQYu2gR9i2SwZh28fms8RVRQlG6EJPvubMCksGJjF/eRAOHHTSsxqlbUugwWcSvevGwYGNbJa1cwIwOvfhJqsAkcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bsIxZdhXj0SoDed03rKl2vhKRi6xkFgFfka8U53Q0Yc=; b=dC8LPn0oM8ZTHcmFB40qKqX6QOk9LdBZ9JnoIK5r1JBwoYwiuheQ0ZalnCUSseE6XE8KQ5GjVCVgXyoCOGKns0Foqek25U3PT7RWjhHw0KXGLCRtiy/7rejg+T7XP/F4Y0SSjqGzGx01WsDHDqWrIIDimHTcjg6EXjXOKC9QmWg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS1PR04MB9654.eurprd04.prod.outlook.com (2603:10a6:20b:476::22) by PAXPR04MB8928.eurprd04.prod.outlook.com (2603:10a6:102:20f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.35; Thu, 5 Oct 2023 12:16:14 +0000 Received: from AS1PR04MB9654.eurprd04.prod.outlook.com ([fe80::74d9:fef3:348a:ef3b]) by AS1PR04MB9654.eurprd04.prod.outlook.com ([fe80::74d9:fef3:348a:ef3b%7]) with mapi id 15.20.6838.033; Thu, 5 Oct 2023 12:16:14 +0000 From: Mahesh Talewad To: linux-bluetooth@vger.kernel.org Cc: luiz.dentz@gmail.com, devyani.godbole@nxp.com, nitin.jadhav@nxp.com, mahesh.talewad@nxp.com Subject: [PATCH BlueZ v4 1/2] unit/test-micp.c : MICP-MICS unit test case implementation Date: Thu, 5 Oct 2023 15:15:43 +0300 Message-Id: <20231005121544.306495-2-mahesh.talewad@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231005121544.306495-1-mahesh.talewad@nxp.com> References: <20231005121544.306495-1-mahesh.talewad@nxp.com> X-ClientProxiedBy: AS4PR09CA0017.eurprd09.prod.outlook.com (2603:10a6:20b:5d4::11) To AS1PR04MB9654.eurprd04.prod.outlook.com (2603:10a6:20b:476::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS1PR04MB9654:EE_|PAXPR04MB8928:EE_ X-MS-Office365-Filtering-Correlation-Id: 0769c345-a58f-48ff-8a6d-08dbc59cde8c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Zw4HMWj/GiQTqR7Zj3gL9jM4k2Vy1lbYWg6ErwqRXf5Rt7WHY6t5YUeLWRmNXiLt3ENV6kRKEM0EORogqPUP+7+MEljKP48/L/XcuVdrn1Guk7gHe2sKz7z6M/jhGfvvtYVf+ySWGoJdnpkNqzzk3bgVJy0ytCffJpydLF9GYc2UQRYgM5wxbavlWbf9VAF4uq0Lx42qYFHjnzn8w89kzkV4aQ746BF/HR7OQ+rSdgeW6elPaPxsgYIOLAkqSHa/k0ZdqY5QCACIPURiR1qiTxtOBOIHYov8YNdcLxPd6/yl1KPw6lirdasyLmUjdzOUpGkBtudosmeg/c0kyxa5I3PvTly1O0SwuXK3AAGYduhVJJW9y9R5lAyFieHzhFUbzDe0opYWhp84U09ZwqLU6CFffdRDYh6FBORF5J20N8E/DXAKnmEg3OVzjTA6WS0auA+f5ibgqLwjQlB6p6SDnE89iEdPYM+zyuTl/xgaMrEICoA8GimqHGnlt1gE33bHfdaUQe8dRd/sGAa939w16ODKi0B/3ZnhEkIeum8avtt8hvdcOMqJ/ApqhARZf8tiWpv81Z43O8GkO26FOBi1FCl8iB72Fmh3PVupjWmdE0Q2B6888gdlBB0dNPANe94r X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS1PR04MB9654.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(136003)(39860400002)(366004)(396003)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(6666004)(6506007)(52116002)(55236004)(2616005)(478600001)(6486002)(83380400001)(26005)(1076003)(6512007)(30864003)(2906002)(41300700001)(66946007)(6916009)(44832011)(5660300002)(66556008)(8676002)(316002)(8936002)(4326008)(36756003)(86362001)(38100700002)(38350700002)(66476007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: AwVU+72tFV/FtMyZa+U4AeggmrwyXv51CgslGnLfuxdRmMwJE/1ESoxIrOoK3HuAffq4fMf8ZkBEXdadTYqU/AbEWUcC2maFUnBrAOtYVCuOv8LJ2VeGxaXzrHmfclK0zMWENoCnuqCy7elt4BR4d3ByC0iZBCzhmjvc6ttZT6l9K6ppRGBRBx8CFKRX6aUhrZ+gadxxgoitHgBqqcNW24Yh99/pcKnqCH9wSOmus/kgLa9DH1npfkbSLiQXvONvnXErNj3DZpRuGh3N9dKsKHWX6AvIHgtORW1Mg/iLZIPKMze0JzJrMlnng998HQcfQVJp/0oNVT8jlXZpJcnG7sxSnVbctCxkCzwcvwtqgphtwQJd4JqqmzBKAb3rAelBbkw6ib9z3MNa1EJosHpxIt7lcTf8+bGR7vlz9Cpesc1DIOlbKvOawEKjUu3dVS+iIS3mrolDs3P4lLema3RRr/cjlRJEKwsxOkpqo6yMlBto6EODyFB2u06jVFt8JzYqFde0WuNq4JmMsLlg3HZbNOMVrWz+vca6N7tRRKpccl1mpr6hEYZApQzOHIFDi5wmn7BXjaInRZXVdpuOfleAq3d8/9B0Flaj2nBNQCp/eA8lbHDFtW6adYoAXNKzPlyXssWZHgG1W6pvCyWXezZST4h6I0fNggfXtAf4iEXEIzeEb7XvDg3wvoOXZkUzSeuQV3zmn1Qx/uw7+d5tfPRK+kPd8FOTADx3s+hEJ0vWuHZVPm8dgqgd3cX/jBe2JGJ0IirTA1Mm0Dvvgfg9sugYvTNZpgBLwZpRfPA+N8lx7usspbagbBnRFJDzC9tnZBVGkqW+J+BahwH0yWhj7hMPbk21GrLUqmTfy40lQTVswRRprxkt5Tmu/XMRYmKphKa4xugYj+5j/D6gE2LRx9hqA43aRuDu1QIdfeIErbGim7B44aTBQmyV3HMaAnZ8BOvwlY1RmXFs1Q5Kl7qnz52m1n+DaVUNmDkTYeSMu98xE0t0NYeaucA7UE4NkycBNleTJvGcy/jq7qzHAF9TLFL6vT+WjWYLCwip2TzVKPqxhRyRrRCLZpbm2o1xWIWuMM8nhNNBVtDB4mwb2zRcLSILqIAVEvrZ+/SPUaTEewKRRXryt7TFegTPbTmeDNbiEDI3F29W0ZV4fV9U8AvIw1TCDOjoIhjg5jm7sRheCXkTd0lk24mxuJuDZ+Xv4b9Lw82EVmnNB97L9518XwY/0yrDQ+plpSXJ4TyLyGMBckjqraME4UtQQS8YqdaRZKmFK1Zyx85uvkIpnVfcYWElEUmPQKz71NTYANM854tvsgB1bkTvknWk90n/x5rCjUFVfB2diZvEe+wOknWsa24SdTNvg9IUItUU0adWOJbnJ/z7SSIHkd5eeKCLFukBdqLdJmJ25R4IumXqVW1cShOjQQHsfnChnhzv5dNm1h55x+LwvQrKrVpbg9KDErjBvqmw7W8wMYqY23kKxoNv5ATh78ggP4Qm87zOMDvr/YkQ2Bst/uOL0/ENmZ9r6yAatomr1uRSbVkGGnlA1lZ74TFWZjfmC6TLydFQ3B20/V4wJfe/8Z9YvjO5W5f96aIHAGICwG7oIWHYDI21J827IClVprv7XQ== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0769c345-a58f-48ff-8a6d-08dbc59cde8c X-MS-Exchange-CrossTenant-AuthSource: AS1PR04MB9654.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2023 12:16:14.4749 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SO6xVwm4IM4XyqNs8QLTA+2FM/5faHM65USPRxm0sy5sprXxR11rMglVbso65a7uQI3wGROOK9VoV0w/dkaDmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8928 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org From: maheshtalewad -Added MICS and MICP Unit test cases in a single file[test-micp.c]. -Fixed the issue that occurred while running all the Unit test cases at a time. -Tested all Unit test cases and working fine. Co-developed-by: Nitin Jadhav Signed-off-by: Nitin Jadhav Signed-off-by: Mahesh Talewad --- Makefile.am | 6 + unit/test-micp.c | 838 +++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 844 insertions(+) create mode 100644 unit/test-micp.c diff --git a/Makefile.am b/Makefile.am index c28c59a05..ac63c7ad0 100644 --- a/Makefile.am +++ b/Makefile.am @@ -579,6 +579,12 @@ unit_test_bap_SOURCES = unit/test-bap.c unit_test_bap_LDADD = src/libshared-glib.la \ lib/libbluetooth-internal.la $(GLIB_LIBS) +unit_tests += unit/test-micp + +unit_test_micp_SOURCES = unit/test-micp.c +unit_test_micp_LDADD = src/libshared-glib.la \ + lib/libbluetooth-internal.la $(GLIB_LIBS) + unit_tests += unit/test-bass unit_test_bass_SOURCES = unit/test-bass.c $(btio_sources) diff --git a/unit/test-micp.c b/unit/test-micp.c new file mode 100644 index 000000000..e2975c298 --- /dev/null +++ b/unit/test-micp.c @@ -0,0 +1,838 @@ +// SPDX-License-Identifier: LGPL-2.1-or-later +/* + * + * BlueZ - Bluetooth protocol stack for Linux + * + * Copyright (C) 2023 NXP Semiconductors. All rights reserved. + * + */ + +#ifdef HAVE_CONFIG_H +#include +#endif + +#define _GNU_SOURCE +#include +#include +#include +#include + + +#include + +#include "lib/bluetooth.h" +#include "lib/uuid.h" +#include "src/shared/util.h" +#include "src/shared/tester.h" +#include "src/shared/queue.h" +#include "src/shared/att.h" +#include "src/shared/gatt-db.h" +#include "src/shared/gatt-server.h" +#include "src/shared/gatt-helpers.h" +#include "src/shared/micp.h" + +struct test_data_mics { + struct gatt_db *db; + struct bt_micp *micp; + struct bt_gatt_server *server; + struct bt_gatt_client *client; + struct queue *ccc_states; + size_t iovcnt; + struct iovec *iov; +}; + +struct test_data_micp { + struct gatt_db *db; + struct bt_micp *micp; + struct bt_gatt_client *client; + size_t iovcnt; + struct iovec *iov; +}; + +struct ccc_state { + uint16_t handle; + uint16_t value; +}; + +struct notify { + uint16_t handle, ccc_handle; + uint8_t *value; + uint16_t len; + bt_gatt_server_conf_func_t conf; + void *user_data; +}; + +#define MICP_GATT_CLIENT_MTU 64 + +#define iov_data(args...) ((const struct iovec[]) { args }) + +#define define_test_mics(name, function, _cfg, args...) \ + do { \ + const struct iovec iov[] = { args }; \ + static struct test_data_mics data; \ + data.iovcnt = ARRAY_SIZE(iov_data(args)); \ + data.iov = util_iov_dup(iov, ARRAY_SIZE(iov_data(args))); \ + tester_add(name, &data, NULL, function, \ + test_teardown_mics); \ + } while (0) + +#define define_test_micp(name, function, _cfg, args...) \ + do { \ + const struct iovec iov[] = { args }; \ + static struct test_data_micp data; \ + data.iovcnt = ARRAY_SIZE(iov_data(args)); \ + data.iov = util_iov_dup(iov, ARRAY_SIZE(iov_data(args))); \ + tester_add(name, &data, test_setup, function, \ + test_teardown_micp); \ + } while (0) + +static void print_debug(const char *str, void *user_data) +{ + const char *prefix = user_data; + + if (tester_use_debug()) + tester_debug("%s%s", prefix, str); +} + +static void test_teardown_mics(const void *user_data) +{ + struct test_data_mics *data = (void *)user_data; + + bt_micp_unref(data->micp); + bt_gatt_server_unref(data->server); + util_iov_free(data->iov, data->iovcnt); + gatt_db_unref(data->db); + + queue_destroy(data->ccc_states, free); + + tester_teardown_complete(); +} + +static void test_teardown_micp(const void *user_data) +{ + struct test_data_micp *data = (void *)user_data; + + bt_micp_unref(data->micp); + bt_gatt_client_unref(data->client); + util_iov_free(data->iov, data->iovcnt); + gatt_db_unref(data->db); + + tester_teardown_complete(); +} + +static void test_complete_cb(const void *user_data) +{ + tester_test_passed(); +} + +static void client_ready_cb(bool success, uint8_t att_ecode, void *user_data) +{ + + if (!success) + tester_setup_failed(); + else + tester_setup_complete(); +} + +static void micp_write_cb(bool success, uint8_t att_ecode, void *user_data) +{ + if (success) + printf("MICP Write successful\n"); + else + printf("\nWrite failed: 0x%02x\n", att_ecode); +} + +static void micp_write_value(struct bt_micp *micp, void *user_data) +{ + struct bt_mics *mics = micp_get_mics(micp); + uint16_t value_handle; + int ret; + const uint16_t value = 0x0001; + + gatt_db_attribute_get_char_data(mics->ms, NULL, &value_handle, + NULL, NULL, NULL); + + printf("%s handle: %x\n", __func__, value_handle); + ret = bt_gatt_client_write_value(micp->client, value_handle, + (void *)&value, sizeof(value), micp_write_cb, NULL, NULL); + + if (!ret) + printf("bt_gatt_client_write_value() : Write FAILED"); +} + +static void micp_ready(struct bt_micp *micp, void *user_data) +{ + micp_write_value(micp, user_data); +} + +static void test_client(const void *user_data) +{ + struct test_data_micp *data = (void *)user_data; + struct io *io; + + io = tester_setup_io(data->iov, data->iovcnt); + g_assert(io); + + tester_io_set_complete_func(test_complete_cb); + + data->db = gatt_db_new(); + g_assert(data->db); + + data->micp = bt_micp_new(data->db, bt_gatt_client_get_db(data->client)); + g_assert(data->micp); + + bt_micp_set_debug(data->micp, print_debug, "bt_micp: ", NULL); + + bt_micp_ready_register(data->micp, micp_ready, data, NULL); + + bt_micp_attach(data->micp, data->client); +} + +static bool ccc_state_match(const void *a, const void *b) +{ + const struct ccc_state *ccc = a; + uint16_t handle = PTR_TO_UINT(b); + + return ccc->handle == handle; +} + +static struct ccc_state *find_ccc_state(struct test_data_mics *data, + uint16_t handle) +{ + return queue_find(data->ccc_states, ccc_state_match, + UINT_TO_PTR(handle)); +} + +static struct ccc_state *get_ccc_state(struct test_data_mics *data, + uint16_t handle) +{ + struct ccc_state *ccc; + + ccc = find_ccc_state(data, handle); + if (ccc) + return ccc; + + ccc = new0(struct ccc_state, 1); + ccc->handle = handle; + queue_push_tail(data->ccc_states, ccc); + + return ccc; +} + +static void gatt_notify_cb(struct gatt_db_attribute *attrib, + struct gatt_db_attribute *ccc, + const uint8_t *value, size_t len, + struct bt_att *att, void *user_data) +{ + struct test_data_mics *data = user_data; + struct notify notify; + + memset(¬ify, 0, sizeof(notify)); + + notify.handle = gatt_db_attribute_get_handle(attrib); + notify.ccc_handle = gatt_db_attribute_get_handle(ccc); + notify.value = (void *) value; + notify.len = len; + + printf("%s: notify.value:%d notify->len:%d\n", __func__, + (int)*(notify.value), notify.len); + if (!bt_gatt_server_send_notification(data->server, + notify.handle, notify.value, + notify.len, false)) + printf("%s: Failed to send notification\n", __func__); +} + +static void gatt_ccc_read_cb(struct gatt_db_attribute *attrib, + unsigned int id, uint16_t offset, + uint8_t opcode, struct bt_att *att, + void *user_data) +{ + struct test_data_mics *data = user_data; + struct ccc_state *ccc; + uint16_t handle; + uint8_t ecode = 0; + const uint8_t *value = NULL; + size_t len = 0; + + handle = gatt_db_attribute_get_handle(attrib); + + ccc = get_ccc_state(data, handle); + if (!ccc) { + ecode = BT_ATT_ERROR_UNLIKELY; + goto done; + } + + len = sizeof(ccc->value); + value = (void *) &ccc->value; + +done: + gatt_db_attribute_read_result(attrib, id, ecode, value, len); +} + +static void test_server(const void *user_data) +{ + struct test_data_mics *data = (void *)user_data; + struct bt_att *att; + struct io *io; + + io = tester_setup_io(data->iov, data->iovcnt); + g_assert(io); + + tester_io_set_complete_func(test_complete_cb); + + att = bt_att_new(io_get_fd(io), false); + g_assert(att); + + bt_att_set_debug(att, BT_ATT_DEBUG, print_debug, "bt_att:", NULL); + + data->db = gatt_db_new(); + g_assert(data->db); + + gatt_db_ccc_register(data->db, gatt_ccc_read_cb, NULL, + gatt_notify_cb, data); + + data->micp = bt_micp_new(data->db, NULL); + g_assert(data->micp); + + data->server = bt_gatt_server_new(data->db, att, 64, 0); + g_assert(data->server); + + bt_gatt_server_set_debug(data->server, print_debug, "bt_gatt_server:", + NULL); + + data->ccc_states = queue_new(); + + tester_io_send(); + + bt_att_unref(att); +} + +/* + * ATT: Exchange MTU Request (0x02) len 2 + * Client RX MTU: 64 + * + * ATT: Exchange MTU Response (0x03) len 2 + * Server RX MTU: 64 + */ +#define ATT_EXCHANGE_MTU IOV_DATA(0x02, 0x40, 0x00), \ + IOV_DATA(0x03, 0x40, 0x00) + +/* + * ATT: Read By Type Request (0x08) len 6 + * Handle range: 0x0001-0xffff + * Attribute type: Server Supported Features (0x2b3a) + * + * ATT: Error Response (0x01) len 4 + * Read By Type Request (0x08) + * Handle: 0x0001 + * Error: Attribute Not Found (0x0a) + */ +#define MICP_READ_SR_FEATURE IOV_DATA(0x08, 0x01, 0x00, 0Xff, 0xff, \ + 0x3a, 0x2b), \ + IOV_DATA(0x01, 0x08, 0x01, 0x00, 0x0a) + +/* + * ATT: Read By Group Type Request (0x10) len 6 + * Handle range: 0x0001-0xffff + * Attribute group type: Primary Service (0x2800) + * + * ATT: Read By Group Type Response (0x11) len 7 + * Attribute data length: 6 + * Attribute group list: 1 entry + * Handle range: 0x0001-0x0004 + * UUID: Microphone Control (0x184d) + * + * ATT: Read By Group Type Request (0x10) len 6 + * Handle range: 0x0005-0xffff + * Attribute group type: Primary Service (0x2800) + * + * ATT: Error Response (0x01) len 4 + * Read By Group Type Request (0x10) + * Handle: 0x0006 + * Error: Attribute Not Found (0x0a) + */ +#define MICP_READ_GROUP_TYPE \ + IOV_DATA(0x10, 0x01, 0x00, 0xff, 0xff, 0x00, 0x28), \ + IOV_DATA(0x11, 0x06, \ + 0x01, 0x00, 0x04, 0x00, 0x4d, 0x18), \ + IOV_DATA(0x10, 0x05, 0x00, 0xff, 0xff, 0x00, 0x28), \ + IOV_DATA(0x01, 0x10, 0x06, 0x00, 0x0a) + +/* + * ATT: Read By Group Type Request (0x10) len 6 + * Handle range: 0x0001-0xffff + * Attribute group type: Secondary Service (0x2801) + * + * ATT: Error Response (0x01) len 4 + * Read By Group Type Request (0x10) + * Handle: 0x0001 + * Error: Attribute Not Found (0x0a) + */ +#define MICP_READ_REQ_SECOND_SERVICE \ + IOV_DATA(0x10, 0x01, 0x00, 0xff, 0xff, 0x01, 0x28), \ + IOV_DATA(0x01, 0x10, 0x01, 0x00, 0x0a) + +/* + * ATT: Read By Type Request (0x08) len 6 + * Handle range: 0x0001-0x0004 + * Attribute type: Include (0x2802) + * + * ATT: Error Response (0x01) len 4 + * Read By Type Request (0x08) + * Handle: 0x0001 + * Error: Attribute Not Found (0x0a) + */ +#define MICP_READ_REQ_INCLUDE_SERVICE \ + IOV_DATA(0x08, 0x01, 0x00, 0x04, 0x00, 0x02, 0x28), \ + IOV_DATA(0x01, 0x08, 0x01, 0x00, 0x0a) + +/* ATT: Find Information Request (0x04) len 4 + * Handle range: 0x0004-0x0004 + */ +#define MICP_FIND_INFO_REQ \ + IOV_DATA(0x04, 0x04, 0x00, 0x04, 0x00), \ + IOV_DATA(0x05, 0x01, 0x04, 0x00, 0x02, 0x29) + +/* + * ATT: Read By Type Request (0x08) len 6 + * Handle range: 0x0001-0x0004 + * Attribute type: Characteristic (0x2803) + * + * ATT: Read By Type Response (0x09) len 8 + * Attribute data length: 7 + * Attribute data list: 1 entry + * Handle: 0x0002 + * Value: 1a0300c32b + * + * ATT: Read By Type Request (0x08) len 6 + * Handle range: 0x0003-0x0004 + * Attribute type: Characteristic (0x2803) + * + * ATT: Error Response (0x01) len 4 + * Read By Type Request (0x08) + * Handle: 0x0004 + * Error: Attribute Not Found (0x0a) + */ +#define MICP_READ_REQ_CHAR \ + IOV_DATA(0x08, 0x01, 0x00, 0x04, 0x00, 0x03, 0x28),\ + IOV_DATA(0x09, 0x07, \ + 0x02, 0x00, 0x1a, 0x03, 0x00, 0xc3, 0x2b), \ + IOV_DATA(0x08, 0x03, 0x00, 0x04, 0x00, 0x03, 0x28), \ + IOV_DATA(0x01, 0x08, 0x04, 0x00, 0x0a) +/* + * ATT: Read Request (0x0a) len 2 + * Handle: 0x0003 + * + * ATT: Read Response (0x0b) len 1 + */ +#define MICS_MUTE_READ \ + IOV_DATA(0x0a, 0x03, 0x00), \ + IOV_DATA(0x0b, 0x01) + +/* + * ATT: Write Request (0x12) len 4 + * Handle: 0x0004 + * Data: 0100 + * ATT: Write Response (0x13) len 0 + */ +#define MICS_EN_MUTE_DISCPTR \ + IOV_DATA(0x12, 0x04, 0x00, 0x01, 0x00), \ + IOV_DATA(0x13) + +#define MICS_MUTE_WRITE \ + IOV_DATA(0x12, 0x03, 0x00, 0x01),\ + IOV_DATA(0x13) + +#define MICP_CL_CGGIT_SER_BV_01_C \ + MICS_MUTE_READ, \ + MICS_EN_MUTE_DISCPTR, \ + IOV_DATA(0x12, 0x03, 0x00, 0x01, 0x00), \ + IOV_DATA(0x01, 0x12, 0x03, 0x00, 0x013) + +#define MICP_CL_CGGIT_CHA_BV_01_C \ + MICS_MUTE_READ, \ + MICS_EN_MUTE_DISCPTR, \ + IOV_DATA(0x12, 0x03, 0x00, 0x01, 0x00), \ + IOV_DATA(0x013) + +#define MICP_CL_SPE_BI_01_C \ + MICS_MUTE_READ, \ + MICS_EN_MUTE_DISCPTR, \ + IOV_DATA(0x12, 0x03, 0x00, 0x01, 0x00), \ + IOV_DATA(0x01, 0x12, 0x03, 0x00, 0x80) + +/* GATT Discover All procedure */ +static const struct iovec setup_data[] = { + ATT_EXCHANGE_MTU, + MICP_READ_SR_FEATURE, + MICP_READ_GROUP_TYPE, + MICP_READ_REQ_SECOND_SERVICE, + MICP_READ_REQ_INCLUDE_SERVICE, + MICP_READ_REQ_CHAR, + MICP_FIND_INFO_REQ +}; + +static void test_setup(const void *user_data) +{ + struct test_data_micp *data = (void *)user_data; + struct bt_att *att; + struct gatt_db *db; + struct io *io; + + io = tester_setup_io(setup_data, ARRAY_SIZE(setup_data)); + g_assert(io); + + att = bt_att_new(io_get_fd(io), false); + g_assert(att); + + bt_att_set_debug(att, BT_ATT_DEBUG, print_debug, "bt_att:", NULL); + + db = gatt_db_new(); + g_assert(db); + + data->client = bt_gatt_client_new(db, att, MICP_GATT_CLIENT_MTU, 0); + g_assert(data->client); + + bt_gatt_client_set_debug(data->client, print_debug, "bt_gatt_client:", + NULL); + + bt_gatt_client_ready_register(data->client, client_ready_cb, data, + NULL); + + bt_att_unref(att); + gatt_db_unref(db); +} + +/* + * ATT: Write Request (0x12) len 3 + * Handle: 0x0003 + * Data: 00 + * + * ATT: Write Response (0x13) len 0 + */ +#define MICS_MUTE_WRITE_VAL_00 \ + IOV_DATA(0x12, 0x03, 0x00, 0x00), \ + IOV_DATA(0x13) + +/* + * ATT: Write Request (0x12) len 3 + * Handle: 0x0003 + * Data: 01 + * + * ATT: Write Response (0x13) len 0 + */ +#define MICS_MUTE_WRITE_VAL_01 \ + IOV_DATA(0x12, 0x03, 0x00, 0x01), \ + IOV_DATA(0x13) +/* + * ATT: Read Request (0x0a) len 2 + * Handle: 0x0003 + * + * ATT: Read Response (0x0b) len 1 + */ +#define MICS_MUTE_READ \ + IOV_DATA(0x0a, 0x03, 0x00), \ + IOV_DATA(0x0b, 0x01) + +/* + * ATT: Read By Group Type Request (0x10) len 6 + * Handle range: 0x0001-0xffff + * Attribute group type: Primary Service (0x2800) + * + * ATT: Read By Group Type Response (0x11) len 7 + * Attribute data length: 6 + * Attribute group list: 1 entry + * Handle range: 0x0001-0x0004 + * UUID: Microphone Control (0x184d) + * + * ATT: Read By Group Type Request (0x10) len 6 + * Handle range: 0x0005-0xffff + * Attribute group type: Primary Service (0x2800) + * + * ATT: Error Response (0x01) len 4 + * Read By Group Type Request (0x10) + * Handle: 0x0005 + * Error: Attribute Not Found (0x0a) + */ +#define DISCOVER_PRIM_SERV_NOTIF \ + IOV_DATA(0x10, 0x01, 0x00, 0xff, 0xff, 0x00, 0x28), \ + IOV_DATA(0x11, 0x06, 0x01, 0x00, 0x04, 0x00, 0x4d, 0x18), \ + IOV_DATA(0x10, 0x05, 0x00, 0xff, 0xff, 0x00, 0x28), \ + IOV_DATA(0x01, 0x10, 0x05, 0x00, 0x0a) + +/* + * ATT: Read By Type Request (0x08) len 6 + * Handle range: 0x0001-0x0005 + * Attribute type: Characteristic (0x2803) + * + * ATT: Read By Type Response (0x09) len 8 + * Attribute data length: 7 + * Attribute data list: 1 entry + * Handle: 0x0002 + * Value: 1a0300c32b + * + * ATT: Read By Type Request (0x08) len 6 + * Handle range: 0x0005-0x0005 + * Attribute type: Characteristic (0x2803) + * + * ATT: Error Response (0x01) len 4 + * Read By Type Request (0x08) + * Handle: 0x0005 + * Error: Attribute Not Found (0x0a) + */ +#define DISC_MICS_CHAR_1 \ + IOV_DATA(0x08, 0x01, 0x00, 0x05, 0x00, 0x03, 0x28), \ + IOV_DATA(0x09, 0x07, \ + 0x02, 0x00, 0x1a, 0x03, 0x00, 0xc3, 0x2b), \ + IOV_DATA(0x08, 0x05, 0x00, 0x05, 0x00, 0x03, 0x28), \ + IOV_DATA(0x01, 0x08, 0x05, 0x00, 0x0a) + +/* + * ATT: Find By Type Value Request (0x06) len 8 + * Handle range: 0x0001-0xffff + * Attribute type: Primary Service (0x2800) + * UUID: Microphone Control (0x184d) + * + * ATT: Find By Type Value Response (0x07) len 4 + * Handle range: 0x0001-0x0004 + * + * ATT: Find By Type Value Request (0x06) len 8 + * Handle range: 0x0005-0xffff + * Attribute type: Primary Service (0x2800) + * UUID: Microphone Control (0x184d) + * + * ATT: Error Response (0x01) len 4 + * Find By Type Value Request (0x06) + * Handle: 0x0005 + * Error: Attribute Not Found (0x0a) + */ +#define MICS_FIND_BY_TYPE_VALUE \ + IOV_DATA(0x06, 0x01, 0x00, 0xff, 0xff, 0x00, 0x28, 0x4d, 0x18), \ + IOV_DATA(0x07, 0x01, 0x00, 0x04, 0x00), \ + IOV_DATA(0x06, 0x05, 0x00, 0xff, 0xff, 0x00, 0x28, 0x4d, 0x18), \ + IOV_DATA(0x01, 0x06, 0x05, 0x00, 0x0a) + +/* + * ATT: Read By Type Request (0x08) len 6 + * Handle range: 0x0001-0x0005 + * Attribute type: Characteristic (0x2803) + * + * ATT: Read By Type Response (0x09) len 8 + * Attribute data length: 7 + * Attribute data list: 1 entry + * Handle: 0x0002 + * Value: 1a0300c32b + * + * ATT: Read By Type Request (0x08) len 6 + * Handle range: 0x0003-0x0005 + * Attribute type: Characteristic (0x2803) + * + * ATT: Error Response (0x01) len 4 + * Read By Type Request (0x08) + * Handle: 0x0003 + * Error: Attribute Not Found (0x0a) + */ +#define DISC_MICS_CHAR_AFTER_TYPE \ + IOV_DATA(0x08, 0x01, 0x00, 0x05, 0x00, 0x03, 0x28), \ + IOV_DATA(0x09, 0x07, \ + 0x02, 0x00, 0x1a, 0x03, 0x00, 0xc3, 0x2b), \ + IOV_DATA(0x08, 0x03, 0x00, 0x05, 0x00, 0x03, 0x28), \ + IOV_DATA(0x01, 0x08, 0x03, 0x00, 0x0a) + +/* + * ATT: Write Request (0x12) len 4 + * Handle: 0x0004 + * Data: 0000 + * + * ATT: Write Response (0x13) len 0 + * + * ATT: Write Request (0x12) len 4 + * Handle: 0x0004 + * Data: 0100 + * + * ATT: Write Response (0x13) len 0 + */ +#define MICS_WRITE_CCD \ + IOV_DATA(0x12, 0x04, 0x00, 0x00, 0x00), \ + IOV_DATA(0x13), \ + IOV_DATA(0x12, 0x04, 0x00, 0x01, 0x00), \ + IOV_DATA(0x13) + +/* + * ATT: Find Information Request (0x04) len 4 + * Handle range: 0x0004-0x0005 + * + * ATT: Find Information Response (0x05) len 5 + * Format: UUID-16 (0x01) + * Handle: 0x0004 + * UUID: Client Characteristic Configuration (0x2902) + * + * ATT: Find Information Request (0x04) len 4 + * Handle range: 0x0005-0x0005 + * + * ATT: Error Response (0x01) len 4 + * Find Information Request (0x04) + * Handle: 0x0005 + * Error: Attribute Not Found (0x0a) + */ +#define MICS_FIND_INFO \ + IOV_DATA(0x04, 0x04, 0x00, 0x05, 0x00), \ + IOV_DATA(0x05, 0x01, 0x04, 0x00, 0x02, 0x29), \ + IOV_DATA(0x04, 0x05, 0x00, 0x05, 0x00), \ + IOV_DATA(0x01, 0x04, 0x05, 0x00, 0x0a) + +/* + * 1.reads the characteristic value for the + * Mute characteristic + * 2.update the Mute characteristic to 0 or 1 + * 3.sends a notification containing the updated value + * of the Mute characteristic + * 4.update the Mute characteristic to 0 or 1 which ever + * different than step 2 + * 5.sends a notification containing the updated value of + * the Mute characteristic + */ +#define MICS_SR_SPN_BV_01_C \ + ATT_EXCHANGE_MTU, \ + DISCOVER_PRIM_SERV_NOTIF, \ + DISC_MICS_CHAR_1, \ + MICS_FIND_BY_TYPE_VALUE, \ + DISC_MICS_CHAR_AFTER_TYPE, \ + MICS_FIND_INFO, \ + MICS_WRITE_CCD, \ + IOV_DATA(0x0a, 0x03, 0x00), \ + IOV_DATA(0x0b, 0x01), \ + MICS_MUTE_WRITE_VAL_00, \ + IOV_DATA(0x1b, 0x03, 0x00, 0x00), \ + MICS_MUTE_WRITE_VAL_01, \ + IOV_DATA(0x1b, 0x03, 0x00, 0x01), \ + IOV_DATA(0x0a, 0x03, 0x00), \ + IOV_DATA(0x0b, 0x01) + +#define MICS_SR_SGGIT_SER_BV_01_C \ + ATT_EXCHANGE_MTU, \ + DISCOVER_PRIM_SERV_NOTIF, \ + MICS_FIND_BY_TYPE_VALUE + +#define MICS_SR_SGGIT_CHA_BV_01_C \ + ATT_EXCHANGE_MTU, \ + DISCOVER_PRIM_SERV_NOTIF, \ + MICS_FIND_BY_TYPE_VALUE, \ + DISC_MICS_CHAR_AFTER_TYPE + +/* + * ATT: Write Request (0x12) len 3 + * Handle: 0x0003 + * Data: 02 + * + * ATT: Error Response (0x01) len 4 + * Write Request (0x12) + * Handle: 0x0003 + * Error: Value Not Allowed (0x13) + * + * ATT: Write Request (0x12) len 3 + * Handle: 0x0003 + * Data: 05 + * + * ATT: Error Response (0x01) len 4 + * Write Request (0x12) + * Handle: 0x0003 + * Error: Value Not Allowed (0x13) + */ +#define MICS_WRITE_MUTE_CHAR_INVALID \ + IOV_DATA(0x12, 0x03, 0x00, 0x02), \ + IOV_DATA(0x01, 0x12, 0x03, 0x00, 0x13), \ + IOV_DATA(0x12, 0x03, 0x00, 0x05), \ + IOV_DATA(0x01, 0x12, 0x03, 0x00, 0x13) + +#define MICS_SR_SPE_BI_1_C \ + ATT_EXCHANGE_MTU, \ + DISCOVER_PRIM_SERV_NOTIF, \ + MICS_FIND_BY_TYPE_VALUE, \ + MICS_WRITE_MUTE_CHAR_INVALID + +/* + * ATT: Read Request (0x0a) len 2 + * Handle: 0x0003 + * + * ATT: Read Response (0x0b) len 1 + */ +#define MICS_MUTE_READ_INVALID \ + IOV_DATA(0x0a, 0x03, 0x00), \ + IOV_DATA(0x0b, 0x02) + +/* + * ATT: Write Request (0x12) len 3 + * Handle: 0x0003 + * Data: 01 + * + * ATT: Error Response (0x01) len 4 + * Write Request (0x12) + * Handle: 0x0003 + * Error: Reserved (0x80) + */ +#define MICS_MUTE_WRITE_1 \ + IOV_DATA(0x12, 0x03, 0x00, 0x01), \ + IOV_DATA(0x01, 0x12, 0x03, 0x00, 0x80) + +/* + * ATT: Write Request (0x12) len 3 + * Handle: 0x0003 + * Data: 00 + * + * ATT: Error Response (0x01) len 4 + * Write Request (0x12) + * Handle: 0x0003 + * Error: Reserved (0x80) + */ +#define MICS_MUTE_WRITE_0 \ + IOV_DATA(0x12, 0x03, 0x00, 0x00), \ + IOV_DATA(0x01, 0x12, 0x03, 0x00, 0x80) + +#define MICS_SR_SPE_BI_02_C \ + ATT_EXCHANGE_MTU, \ + DISCOVER_PRIM_SERV_NOTIF, \ + MICS_FIND_BY_TYPE_VALUE, \ + MICS_MUTE_READ_INVALID, \ + MICS_MUTE_WRITE_0, \ + MICS_MUTE_WRITE_1 + +int main(int argc, char *argv[]) +{ + + tester_init(&argc, &argv); + + /* MICS Testcases */ + define_test_mics("MICS/SR/SGGIT/SER/BV-01-C", test_server, NULL, + MICS_SR_SGGIT_SER_BV_01_C); + define_test_mics("MICS/SR/SGGIT/CHA/BV-01-C", test_server, NULL, + MICS_SR_SGGIT_CHA_BV_01_C); + define_test_mics("MICS/SR/SPE/BI-01-C", test_server, NULL, + MICS_SR_SPE_BI_1_C); + + /* MICS/SR/SPE/BI-02-C: + * In function *mics_new(struct gatt_db *db)[src/shared/micp.c] + * by default the mics->mute_stat is set to MICS_MUTED[0x01]. + * As per test specs, Testcase MICS/SR/SPE/BI-02-C, Initial + * condition of mute state should be MICS_DISABLED[0x02]. + * To verify this Unit test case we have to modify the initial + * state of mics->mute_stat to MICS_DISABLED in code + * [in func mics_new()], build it and run bluetoothd. Then run + * this unit test case and this test case will Pass. + */ + /* define_test_mics("MICS/SR/SPE/BI-02-C", test_server, NULL, + * MICS_SR_SPE_BI_02_C); + */ + define_test_mics("MICS/SR/SPN/BV-01-C", test_server, NULL, + MICS_SR_SPN_BV_01_C); + + /* MICP Testcases */ + define_test_micp("MICP/CL/CGGIT/SER/BV-01-C", test_client, NULL, + MICP_CL_CGGIT_SER_BV_01_C); + define_test_micp("MICP/CL/CGGIT/CHA/BV-01-C", test_client, NULL, + MICP_CL_CGGIT_CHA_BV_01_C); + define_test_micp("MICP/CL/SPE/BI-01-C", test_client, NULL, + MICP_CL_SPE_BI_01_C); + + return tester_run(); +} From patchwork Thu Oct 5 12:15:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mahesh Talewad X-Patchwork-Id: 731121 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA34EE772B6 for ; Thu, 5 Oct 2023 16:05:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237638AbjJEQFa (ORCPT ); Thu, 5 Oct 2023 12:05:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237604AbjJEQEI (ORCPT ); Thu, 5 Oct 2023 12:04:08 -0400 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20630.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d00::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BBDD261A7 for ; Thu, 5 Oct 2023 05:16:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mwN0vlX9SEsgl/cWZ8vzK+lzypFDH+z1EzlzlN1Ml5ovbDNh99dJtjkgUWsT4hdrPR2nyl2th967nvaNcuxpSqGPjZxYUjnvgi/dO5k/6bRnvmqTX0xMNbOc+qxU5Ec37jN8CsbKms+l5wwqNVVuqfMLfxwu1r7uKBB3CrDpd+jft+6/1D8qUJRWmoobQIRNJx2meRcUm5itfElXqYHX+2XqF6pISQxXME9+QEajfcl6OhsmESmuNAU/ED51r21rfv0iZKuuqWFxKZJE2ve4SG6NRiN/ZNgVAeDW/CDE/XX1ER8NJEKu3ktO8xhvBG7OR76oaAsZlX8tieo8pzBFSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hcoQ1J1Pf1OQUAK5JjmSR5ysmhT0O/avzIfiDMMI/5s=; b=UaxypCSYeWkctcEP28Xm1U9KYRamNZ6ncmNWlRT/XxfiqrOLJBYTPBel3NTU9j712KoaeBIinit+82sLDhZoCxcG8VkiTLOgeyW7U+fmiFERbMT2I9PL0dyEeCdTvgOFWuVsDCX44p8yexiP9LaGbOBtdjNsryGashphXVpyIS6CzSauz0Fj9cqAsTgLj9VYalWSSnR8UHNKebCG1tSJ0AhhP7w849C02ULC9g/BBWkE8Ic8jI0n3UDywE/ia4e+pFEK1FhnLO3o12Zp0tt1E7/Zj1uScAItTzNRcMulFJndoyWeakWaDhKPPtYuHUJ3Q9sD8XPSnEEPHBIMNaNPSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hcoQ1J1Pf1OQUAK5JjmSR5ysmhT0O/avzIfiDMMI/5s=; b=TyqEgWKdUBkpU+SWvrW7xI0zO5lFjs3JjhNbPrQiBzkOPvwhEesE3tMAa/IumRbLOEiqe2WwesUoTRUz/NHgd4RcVJdPQKnxWsJsPnfi6wA/Q5nrhJTM3Kf1SwVuVjwl0sUhxIVJ70BhqMlTxokRdNuiRpsAjnhE0OWhh1PO7xw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS1PR04MB9654.eurprd04.prod.outlook.com (2603:10a6:20b:476::22) by PAXPR04MB8928.eurprd04.prod.outlook.com (2603:10a6:102:20f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.35; Thu, 5 Oct 2023 12:16:19 +0000 Received: from AS1PR04MB9654.eurprd04.prod.outlook.com ([fe80::74d9:fef3:348a:ef3b]) by AS1PR04MB9654.eurprd04.prod.outlook.com ([fe80::74d9:fef3:348a:ef3b%7]) with mapi id 15.20.6838.033; Thu, 5 Oct 2023 12:16:19 +0000 From: Mahesh Talewad To: linux-bluetooth@vger.kernel.org Cc: luiz.dentz@gmail.com, devyani.godbole@nxp.com, nitin.jadhav@nxp.com, mahesh.talewad@nxp.com Subject: [PATCH BlueZ v4 2/2] src/shared/micp.c :MICP-MICS implementation memory leak fix Date: Thu, 5 Oct 2023 15:15:44 +0300 Message-Id: <20231005121544.306495-3-mahesh.talewad@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231005121544.306495-1-mahesh.talewad@nxp.com> References: <20231005121544.306495-1-mahesh.talewad@nxp.com> X-ClientProxiedBy: AS4PR09CA0017.eurprd09.prod.outlook.com (2603:10a6:20b:5d4::11) To AS1PR04MB9654.eurprd04.prod.outlook.com (2603:10a6:20b:476::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS1PR04MB9654:EE_|PAXPR04MB8928:EE_ X-MS-Office365-Filtering-Correlation-Id: a56c47dc-37d8-4936-7adf-08dbc59ce1ad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AhougToV04BhcSjfllrKyJuCzYlUaJuvx3BGUoKuCWlgBUnXk7lwPwmCrkLw1gFw8iJOxi5aT2J42TVYcBLt5gnM6WJANdS0z8wbuWNXoMSFLo2nDn4PCmC6efn+ak9Eu/Dmw4u4ILm7guLNaNFGMlrR7nPtgg6wwwdxU2y+fsXF2/MSiem+F97BUU5+iRsVzs3RChJxol8ZEoWrL/UzEPztEYo1Spi0/Godmb768WMzNLE/erlduJXgHSskCOE0Xvnh5SBJtF/WeDvXyYgdl0XRSv8hOkRN9fErbCVJqzCa9URk+Hwe31HjER5sHWh7Zbp50z94xCBw3c69rvJa/InmXZA6qrbvyO86ojscS63q6XBb886UZ0rQ7w9rBACSgwpNbrpOhZpi8Y9TYHW+lqdnmrItM76lqZJ8k5QDA7/5RPNIu3HaysX8tW9wIOj0i3wpz6zhumEvkNaWO8yxrjBWEas7yPgCHL0LdbhYbOVAdPdA7Y2OhJLOCV7EULrFRIAB4qaRXNy1vp7M4mtpQrVpgPJKjP0OwmJ7VCZgPkVhsbLmW7N6t4beRTA9injGjEAClyGzbgqixU0os63/s1R0qABqkxPBK7Cx7sGSb/+Ux0MSbAyKCq7O1ClrOkeo X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS1PR04MB9654.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(136003)(39860400002)(366004)(396003)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(6666004)(6506007)(52116002)(55236004)(2616005)(478600001)(6486002)(26005)(1076003)(6512007)(2906002)(4744005)(41300700001)(66946007)(6916009)(44832011)(5660300002)(66556008)(8676002)(316002)(8936002)(4326008)(36756003)(86362001)(38100700002)(38350700002)(66476007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: bHs/uIgcJjzDBRHbJN2Zpdr/qBUAsbEU/Kh4qDaSNO1gT6/QR988J14B/mktWaZCexo42i8BwitPfYi5mHpcjA9HuxPVB3b8DHYpCHIwbWq8eVidfvffwTs9hY159v8fLLjkveJdIScG0WE+ZgTuop7JPY39474JmzpQD8yhd9OciTGMNQuvuNsAHQSKelthKLFwVeJ2bwGnh0JU+GHk5cVvHbYCjELMnBN8hHylg1m8Xx2WzBKnb88nh99UzQIpordCpJnXuz/8jSm85JSNqtImz1EjQXnidMTSLUOas4AbdNIt1r2K/Yt+sSQh6pfMaLXftfeFRuOlXEGYbOVDVtE3iT4B/0DENTz68j2ziJ5p+x0WwSKmuesHq1Q48RXB/ehuAoMUcXjZwyxBSC8ze2LRoEHu/Y6RpaYggem8XVwo8o216quup/bvRGZNrc2Z2vbgJ9LK4FIcPQ0yjuLLL0HGIjFPuT35OeFj+cTiKXDPu8e576swxolOekWGroAmk3Pukja/aLm84cLfkh9uefF/Zkh4i4qG/lJygrgGZmeaRUPDeuash0QRwQH4j2kPn/sFY24LIYj1JBN5pyh2FBHSS4V2Wd9txzLYU8lixVwBKJDqF9OhmuskmVosr80R5aDA0Ab5fxfkNsE0IEaiRH65xfF85nhzAkwVGLB8AMDugXaT5PMOqZmdZ1K3ECZfv+gDzrCNC47uFmN9Mt7bARAUBCD8PG0Su6/oAE3HXdtBtgrJGof8c3EgsSZJ4KItqimD7bTcOYr71R5QuWF5Rr+kMtP3zEEzkNWVCizNAYK5/Kp1kx5V3nPAxFqPdGCYpG16eUkGaYKWb5nOUd3cFmIXkYSklOEZXuW/p8ro/7BhqAAedUjLNEbGxQ+8aDaNLPhqjdq/cgWo2F3KPhJeFYu/sO2+favqKUQ+2ASHHogMkUlgeCmj6UjCrp34QUpiHScG1pSg3OcQ9+eX7nMenog4t3rtFfgBqNyUPXdn+C8Uex92Pd22FUIgh8ONNnjKNUuZMgeYsGPhVLoo4sHdpztii/lvLVfUnevxUwfWbkcVGxUiKzHI7+WnAvafo1RiCklZuxp6hO/pAqQebSmPV2h5goI9v7UriV09mY6EFdR0E+TElngWdGpVTZPiPYqLnqqJgoMcr377Vr1NHNYSDCc9MX74MBHmrZkBQ4yzgJKTpXyysWzuXqvVbSQfwtq6R4hsaO8X5oC47+fMnnXdDopZvIBbVaLfEf6+Mu8OalVRv6D6bDpyVAiENzG5oWjr6Sg+rEXahm3p0f4LFOONhDOiHuIOHnAR2jdjT4sHJ+dLHvHRyZURfH/0iEtwSL+jlXhRpDSWrhaWEMksI+b1vL9QDqyYZbH2bpqVi4z3JSty5/B+HSS5EimWq1o+IalrGGjZkpx00qhH2I5HiBqTBpXLwpBA9H+WfUyuy6r3mAc1Zs2YrZlvhqiVH6hti8grmTarwz/gCwJGrEce500s5hAxTDaSqBAAltq/DI8G8aLjVCTavoErUO1BPzaXtUvoMUAGuc4vQa9Xtg0u80T4CFzJO/lgV3q9CsNez67WG6fnBtID1aAeUGFIv2gVIwfm/jZCqbWKul0NPaA7Qfi/FQ== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a56c47dc-37d8-4936-7adf-08dbc59ce1ad X-MS-Exchange-CrossTenant-AuthSource: AS1PR04MB9654.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2023 12:16:19.6258 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BZ0oBP1D5aP/1lb/lBKZTsFzQUT0ab/9o6QNyi/JocUcxwUec3KWlRRLmCKAXFtPziJQ4YmSV2QoKPvYrU6MNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8928 Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org - Fixed memory leak issue --- src/shared/micp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/shared/micp.c b/src/shared/micp.c index 90d05b301..b82bd92de 100644 --- a/src/shared/micp.c +++ b/src/shared/micp.c @@ -138,6 +138,7 @@ void bt_micp_detach(struct bt_micp *micp) if (!queue_remove(sessions, micp)) return; + bt_gatt_client_idle_unregister(micp->client, micp->idle_id); bt_gatt_client_unref(micp->client); micp->client = NULL; @@ -175,6 +176,7 @@ static void micp_free(void *data) micp_db_free(micp->rdb); + queue_destroy(micp->notify, free); queue_destroy(micp->pending, NULL); queue_destroy(micp->ready_cbs, micp_ready_free); @@ -594,6 +596,7 @@ struct bt_micp *bt_micp_new(struct gatt_db *ldb, struct gatt_db *rdb) micp->ldb = mdb; micp->pending = queue_new(); micp->ready_cbs = queue_new(); + micp->notify = queue_new(); if (!rdb) goto done;