From patchwork Sat Oct 7 18:24:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 730667 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8668E95A69 for ; Sat, 7 Oct 2023 18:30:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344088AbjJGSYr (ORCPT ); Sat, 7 Oct 2023 14:24:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjJGSYq (ORCPT ); Sat, 7 Oct 2023 14:24:46 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82720BC; Sat, 7 Oct 2023 11:24:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=QMmmdka+5r7TnWgQ+zRWrvp3h9M2Ione/vlBDmKezJY=; b=Brg9Yo1VWlk5XfNL843e/POx5h qm+gnZ/1DEEN9vP3mSkDoZTD8QOvddRbrrPCdCnQdDfVsmas3NkZ3uUSwRWuvrwiOI4TPOzPDbrJf gsN9q1pFxkAn8pYECarc5RQCBw85lkUdK2V/9Ii0SqapsFsKDmfNqT1ClFxx0ACgU4mhkKquatWUh XQrEH7kAkP2RqHSZGZXfm+Hy5RlL0vd9F6VIOrfibELoYt50gkCLAUkll9ur5VYXGXywFkgBARt7l 0QMtyHzFg7nN2bAPvKZFeay1IFIoIEiP5zLaeyFrmopy7ZL08W4DaaYTLxGzGiI4A1NXZg/a66MP8 QeUJUVZw==; Received: from [50.53.46.231] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qpBym-007nvV-2e; Sat, 07 Oct 2023 18:24:44 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Michael Buesch , linux-wireless@vger.kernel.org Subject: [RFC PATCH] ssb: relax SSB_EMBEDDED dependencies Date: Sat, 7 Oct 2023 11:24:43 -0700 Message-ID: <20231007182443.32300-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org This is a kconfig warning in a randconfig when CONFIG_PCI is not set: WARNING: unmet direct dependencies detected for SSB_EMBEDDED Depends on [n]: SSB [=y] && SSB_DRIVER_MIPS [=y] && SSB_PCICORE_HOSTMODE [=n] Selected by [y]: - BCM47XX_SSB [=y] && BCM47XX [=y] This is caused by arch/mips/bcm47xx/Kconfig's symbol BCM47XX_SSB selecting SSB_EMBEDDED when CONFIG_PCI is not set. This warning can be prevented by having SSB_EMBEDDED not depend on SSB_PCICORE_HOSTMODE, although some parts of SSB use PCI. Signed-off-by: Randy Dunlap Cc: Michael Buesch Cc: linux-wireless@vger.kernel.org Acked-by: Michael Büsch --- Comments, thoughts? I also tried changing arch/mips/bcm47xx/Kconfig's BCM47XX_SSB to select SSB_EMBEDDED if PCI but that results in build errors. drivers/ssb/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -- a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig --- a/drivers/ssb/Kconfig +++ b/drivers/ssb/Kconfig @@ -134,7 +134,7 @@ config SSB_SFLASH # Assumption: We are on embedded, if we compile the MIPS core. config SSB_EMBEDDED bool - depends on SSB_DRIVER_MIPS && SSB_PCICORE_HOSTMODE + depends on SSB_DRIVER_MIPS default y config SSB_DRIVER_EXTIF