From patchwork Wed Oct 11 16:46:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 733645 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2BB7CDB467 for ; Wed, 11 Oct 2023 16:47:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232512AbjJKQru (ORCPT ); Wed, 11 Oct 2023 12:47:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230292AbjJKQru (ORCPT ); Wed, 11 Oct 2023 12:47:50 -0400 Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CEDC8F for ; Wed, 11 Oct 2023 09:47:47 -0700 (PDT) Received: by mail-qk1-x72c.google.com with SMTP id af79cd13be357-7757f2d3956so102650185a.0 for ; Wed, 11 Oct 2023 09:47:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1697042867; x=1697647667; darn=vger.kernel.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=yH9UYAVOTpbitNpatu+5LwDak6jVrw/FFwga9RZiacQ=; b=EiG+veYZLL/I0ItQR4q6QLjBtKKBgP9VpXbK5jkBeyFaxGhkHGVE8qwFoCruAQU+L5 fpN2+yaC3eyJfkTHAsWTRureuq+nTbebk5JLrhfsdmmvJGeCqiDHvep9dRHckCsEmE7A d73f6d5W/olsflTdcPEMy5T/Dm1+TDOLMHW0g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697042867; x=1697647667; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=yH9UYAVOTpbitNpatu+5LwDak6jVrw/FFwga9RZiacQ=; b=TvD2CmEWhV/KkDaSV0RO99TVAuolSYueUJ2GxNmytxwJzPSP9rb/edTzoZ/w4uZPNx roF9mauCDpj/UfOyQTI1gSla0ndCMIXCPMFQAPGaTkE05giUm7GCX2IbbD3RkmiQJUOT jR12Q9ZK0p4pBnXo86wZ+qZlgOqdu0pHRnqtVidH9WOEY4J3hwqv7ww/yp+Oq97Gyxed 2AiHFHxFyw10Z+/nIBSQQ7JVsgjklYDNADzLH74+iZD7VXnT67iBL2HU5/CeEyoS8Tcb slavw90Imv7xcZJ8rQ9Gf7jLz2Ea2Yd+ar17XrPUeNA7ZOjhhZY/jSByiUqcOetVBx0N QrwA== X-Gm-Message-State: AOJu0Yy0TEFDJwVM7q0ZwzIIlgJ1MljbcluPtoZfDIicoeCh87v6AkgF 6kaZF6guhHJ58CpyHSlQUPp08A== X-Google-Smtp-Source: AGHT+IEQVzLN89/EdvfZheK0lp4J6jfe0BP65NP796kpX7DLb3ibpJV8wiMeInE3xEYvAdQ5P2l0cg== X-Received: by 2002:a05:620a:c45:b0:76c:b7f0:2bc9 with SMTP id u5-20020a05620a0c4500b0076cb7f02bc9mr26509977qki.16.1697042866716; Wed, 11 Oct 2023 09:47:46 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id c24-20020a05620a11b800b0076ee973b9a7sm5357492qkk.27.2023.10.11.09.47.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Oct 2023 09:47:46 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: mmayer@broadcom.com, Florian Fainelli , "Rafael J. Wysocki" , Viresh Kumar , linux-pm@vger.kernel.org (open list:CPU FREQUENCY SCALING FRAMEWORK) Subject: [PATCH v2] cpufreq: ARM_BRCMSTB_AVS_CPUFREQ cannot be used with ARM_SCMI_CPUFREQ Date: Wed, 11 Oct 2023 09:46:54 -0700 Message-Id: <20231011164654.3671490-1-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The brcmstb-avs-cpufreq driver is considered a legacy driver and since 2018, ARCH_BRCMSTB systems have been using scmi-cpufreq. As a matter of fact, when SCMI is in use, brcmstb-avs-cpufreq is unusable since the SCMI firmware takes over, this can result in various problems, including external synchronous aborts. Express those constraints such that the driver is not enabled by default when SCMI CPU frequency scaling is in use. Signed-off-by: Florian Fainelli --- Changes in v2: - address Viresh's feedback and reduce the depdendency to !ARM_SCMI_CPUFREQ drivers/cpufreq/Kconfig.arm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index 123b4bbfcfee..207618043ee0 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm @@ -90,7 +90,7 @@ config ARM_VEXPRESS_SPC_CPUFREQ config ARM_BRCMSTB_AVS_CPUFREQ tristate "Broadcom STB AVS CPUfreq driver" - depends on ARCH_BRCMSTB || COMPILE_TEST + depends on (ARCH_BRCMSTB && !ARM_SCMI_CPUFREQ) || COMPILE_TEST default y help Some Broadcom STB SoCs use a co-processor running proprietary firmware