From patchwork Fri Jan 5 06:53:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artur Weber X-Patchwork-Id: 761378 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6CB5524C; Fri, 5 Jan 2024 06:53:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RrkYppV7" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-556aa7fe765so1392683a12.2; Thu, 04 Jan 2024 22:53:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704437596; x=1705042396; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Gs6Zdo5lqPMyDcy2Y9AErHFR4G8ZNcqDUY2nx2C99rw=; b=RrkYppV7GS5pAgoWjULWHTkXfxsqthD+EjVrcHBbkIOZI1UDZp3qqafR2sVTbjLZOF WC2EflvjsHg2aB8jTTESeFTzmNLVTeX2nOzFbVZdsrwvL1j+LNEab3O/6TgoJ09Xl1zH 52fo1OovpxyofJaj9IfAWCTx5K+cjSuLL9rYwQeObMcy2DtJn0NTzFQjRe8TlWzsdCp6 aYbEBY8o2mglDlEWzFz/KzXh0E2wqNZc+Rv/AAT+OVngo60H13y0FHY4+ge9KiB25zW4 Bi/Y/iXNuPIpynZOcsaw2mX522e66TS/LUhdI7+tXp85FKPxqhDvginwbQDVPdy9bYgd WA2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704437596; x=1705042396; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gs6Zdo5lqPMyDcy2Y9AErHFR4G8ZNcqDUY2nx2C99rw=; b=BA6USypRFJsV8uORtrr5ygRMw0zq0+rGGOtrnRWbmwVKOGoawaBFB8x3ksAbxVbddO Tu4OMLRTVrLV0cKznZ84/DFiDeYFbRoolNoyA2F5BCY21xHlPzz38ewgsvzVqkz2LRyh cQF8PmBzsMpwO9KCYxzvEZfCZHQL/P30+ZQYWX66tVUUmUIlNWbIrz1n32CSd5yZ+6Ee yRaBerZ6SSkHKtB5oEkDMGTH96uPqn6aeVMIaGs3WaRoncEwBDts3APNwP21fBlyaV7M c3MoAn/OGgp3dUMHpO8nof1bwkE7IJFXRa2y8+E5LR/iu+zkh13nYdZXRG5Pn+nSmEBN 8E1Q== X-Gm-Message-State: AOJu0YxmfRQKu6M28hx4lZDYTCL+WXFUc/WFuELNn4y9UhA2nH6BukLy muyK7tJ9bFgbC83irV8SOn0= X-Google-Smtp-Source: AGHT+IGK9xkg0CCNYNDKzTYncS8IxaFYD6jd3LQSs6N1y6nKezYqqpIO5ypVgZmxqvaMktFrE99/jA== X-Received: by 2002:a17:906:c55:b0:a28:77b:bb36 with SMTP id t21-20020a1709060c5500b00a28077bbb36mr797610ejf.134.1704437595580; Thu, 04 Jan 2024 22:53:15 -0800 (PST) Received: from hex.my.domain (83.11.207.119.ipv4.supernova.orange.pl. [83.11.207.119]) by smtp.gmail.com with ESMTPSA id g23-20020a17090669d700b00a28e2b72db2sm518809ejs.56.2024.01.04.22.53.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 22:53:15 -0800 (PST) From: Artur Weber Date: Fri, 05 Jan 2024 07:53:01 +0100 Subject: [PATCH v2 1/2] ARM: dts: exynos4212-tab3: add samsung,invert-vclk flag to fimd Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240105-tab3-display-fixes-v2-1-904d1207bf6f@gmail.com> References: <20240105-tab3-display-fixes-v2-0-904d1207bf6f@gmail.com> In-Reply-To: <20240105-tab3-display-fixes-v2-0-904d1207bf6f@gmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Artur Weber X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1704437592; l=860; i=aweber.kernel@gmail.com; s=20231030; h=from:subject:message-id; bh=Hj/KIXM8+wrf3C6zb6NPg6hk9u+G2N6Miq9I309cmwA=; b=y9TBDXAW40WhQZ9RyljbqE9HKhzBXZ64rvQTNoPAID3ula15xCJhQhW/2iksx6g5BkUiOZ9Zd PdpWEQ9LjCzDZWJLsH+POGdfXFFhAi1McL/WcJTJJjyZwgTczWGXKVr X-Developer-Key: i=aweber.kernel@gmail.com; a=ed25519; pk=RhDBfWbJEHqDibXbhNEBAnc9FMkyznGxX/hwfhL8bv8= After more investigation, I've found that it's not the panel driver config that needs to be modified to invert the data polarity, but the FIMD config. Add the missing invert-vclk option that is required to get the display to work correctly. Fixes: ee37a457af1d ("ARM: dts: exynos: Add Samsung Galaxy Tab 3 8.0 boards") Signed-off-by: Artur Weber --- arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi index d7954ff466b4..e5254e32aa8f 100644 --- a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi +++ b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi @@ -434,6 +434,7 @@ &exynos_usbphy { }; &fimd { + samsung,invert-vclk; status = "okay"; }; From patchwork Fri Jan 5 06:53:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artur Weber X-Patchwork-Id: 760400 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5544199AF; Fri, 5 Jan 2024 06:53:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gwgEeP2j" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a2821884a09so101177466b.2; Thu, 04 Jan 2024 22:53:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704437597; x=1705042397; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gN9G9Kb0Ei3BRgzRKo9RDwtoeSks6/gH2+/hiv2p4q0=; b=gwgEeP2jg6OBS4rczZYF/iNSJD6JjqVIzh421UolFl3ylPDJv9h3uCrHAsYMkcoHgW V10VgnQ7H1NFASmONwjQMl5I3c2G/h/0YlkYb59XNMs6OacJXE1mplU/jGkquKbbh1fh 230WQLyvuGbbRig6KmuLWq3tSs1Am4wFVPo3NST40dlq+7ueOeR38J1S52bTVmXDQNdB R5vXN72ThqEwdnJl7Qd9f8oRhQprtf1wzFHmrbXxa0XODw2rCvqalGNqiztoDFmczSTT EvyEhZJ4hYQHwmjUr3SEcKeAg1S+F9bhm/LH8MvtcexAwAUb/UCkWlzSTBZnBsJuRi78 Ixog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704437597; x=1705042397; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gN9G9Kb0Ei3BRgzRKo9RDwtoeSks6/gH2+/hiv2p4q0=; b=N7my8stlDpM1O9XzuaRONtTUFe2+rFHhIZoTOcKT5R0xuTeN0qkmyp/oacHsjnyXC8 a4wq8+xsC0nvvwpVU6/2KZit+C+LA5cYsPiiYxxRV8cF46U8HHmuzLnfwed9Qs+bDH5D nLyU0qsFgg8wJFmkjckyFBejO+WTPkJDJAaIP+kckytP26WEafQkvIXlLJct68P7Xu9n Q0atcZi9cJobn4WH97zFaxGnP75sArdo44n2+GFexbj/imXgON47iQkTGAr6aVM9TrXe pEzKB2tl4OoE+/7iMUP7E6GGZ761ApMOYtwMYdeyokro2g2KhYPSj88D9ae1iO3+qSLu k+fA== X-Gm-Message-State: AOJu0Yx4e6xwQN8KZ36yZkyHoglQITKc+OPhskwrwipnuRaeexFQrvqx DyWUiYMQz6VAEZKReqQ+1wM= X-Google-Smtp-Source: AGHT+IESYsMQvwgG8Vjc2evgLPbZfxJkSk1hOrSDFtYcr8hG6M1PSfHIVVY+DSWVNgmznTt1z7F9yg== X-Received: by 2002:a17:906:fa0d:b0:a18:4b1b:9522 with SMTP id lo13-20020a170906fa0d00b00a184b1b9522mr921754ejb.41.1704437596911; Thu, 04 Jan 2024 22:53:16 -0800 (PST) Received: from hex.my.domain (83.11.207.119.ipv4.supernova.orange.pl. [83.11.207.119]) by smtp.gmail.com with ESMTPSA id g23-20020a17090669d700b00a28e2b72db2sm518809ejs.56.2024.01.04.22.53.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 22:53:16 -0800 (PST) From: Artur Weber Date: Fri, 05 Jan 2024 07:53:02 +0100 Subject: [PATCH v2 2/2] drm/panel: samsung-s6d7aa0: drop DRM_BUS_FLAG_DE_HIGH for lsl080al02 Precedence: bulk X-Mailing-List: linux-samsung-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240105-tab3-display-fixes-v2-2-904d1207bf6f@gmail.com> References: <20240105-tab3-display-fixes-v2-0-904d1207bf6f@gmail.com> In-Reply-To: <20240105-tab3-display-fixes-v2-0-904d1207bf6f@gmail.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Artur Weber X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1704437592; l=1183; i=aweber.kernel@gmail.com; s=20231030; h=from:subject:message-id; bh=zbV+r29VU46Ob/u8YrKcYcH1MdK6Qsp4rJGmvF1IAUs=; b=VrgBYBiZXrQxVeRGeUJTG5/9Lpc//qRFKYcfsvWONuxI8I4GIlZmC0QPmRikzgvYRGQ5U8gLD rcnhxSXRzcoD/ck0/wclvhBbGoIp3yABok93VCTPc8c70RJYq0/NkNd X-Developer-Key: i=aweber.kernel@gmail.com; a=ed25519; pk=RhDBfWbJEHqDibXbhNEBAnc9FMkyznGxX/hwfhL8bv8= It turns out that I had misconfigured the device I was using the panel with; the bus data polarity is not high for this panel, I had to change the config on the display controller's side. Fix the panel config to properly reflect its accurate settings. Fixes: 6810bb390282 ("drm/panel: Add Samsung S6D7AA0 panel controller driver") Reviewed-by: Jessica Zhang Signed-off-by: Artur Weber --- drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c index ea5a85779382..f23d8832a1ad 100644 --- a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c +++ b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c @@ -309,7 +309,7 @@ static const struct s6d7aa0_panel_desc s6d7aa0_lsl080al02_desc = { .off_func = s6d7aa0_lsl080al02_off, .drm_mode = &s6d7aa0_lsl080al02_mode, .mode_flags = MIPI_DSI_MODE_VSYNC_FLUSH | MIPI_DSI_MODE_VIDEO_NO_HFP, - .bus_flags = DRM_BUS_FLAG_DE_HIGH, + .bus_flags = 0, .has_backlight = false, .use_passwd3 = false,