From patchwork Tue Feb 6 17:12:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 770398 Delivered-To: patch@linaro.org Received: by 2002:adf:a40c:0:b0:33b:4b49:db74 with SMTP id d12csp66185wra; Tue, 6 Feb 2024 09:13:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IEBu3nAAmtJ0i0S8KEPZBSinFGCoNbveO+JPOfl+3gctKX7gRmzkieFL55fVIcGxxLIiDVJ X-Received: by 2002:a05:620a:2993:b0:785:3749:7cba with SMTP id r19-20020a05620a299300b0078537497cbamr4239466qkp.65.1707239629515; Tue, 06 Feb 2024 09:13:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1707239629; cv=none; d=google.com; s=arc-20160816; b=EcfoL/Dfloqstz+vg7Haj80iKtBjI/2LQglHROnx89AWIhQyOKfACrJHE+VClIFvIf K/ShYh+VIS9rcy9q9pJND1K62wWwD4Dr22q+yaLygNATRBZCejglg43aQpw/BqKed+fZ zFN35eJebBeP/tzD6iix+kHw8dqoOpSpJ0k1Ed2UAFXJbf6isdklzqYZHNuTdDdfCycv gSYMS69uIJ2Cr1XW6HtUESLTQ+OhAskfcW0kNC82xhqHGju2yvgYLLJJwE5ogtxqOQF3 RDkb0WjfV+aVg/hWyH74RloZRJ9yo+lv7V92bWhYClFYbUwkz9Xs67NmBmXoD83oypYd 66uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=PrRJ5d76QadE8MBCkQGSm2LWsORcf86H/9Nb7qmGBtc=; fh=K8EC0sAmOmk8wAXz+JOZq9aV/wjcbIB7qLXU1SJeEmU=; b=PBqA4NpynomAZAiUfzBiaMGcgRTTHmdSzpSCGHD34aCqrhPf0FE280qlY3IS7ybpNe cMOxu7zuWPn5+fa/9PIIsni5cm0HZyzeAuhqq9nS3pCRFh1zThY04KA3VA/2IdmvltsH afIcvOyTYWwyswAgs8nennK77eQfcBTJIh6CY2E5RvNgJGUIBjLA3Tb5Z8LVll3H5xKE XKJOeml/QjzxrGnrvvf+WV5RlD50HiVFiOALMNM/e+9xgQADEmye35glZawDqar0jVah 5FB/UJKc0r28nMMzymit4kB7mWSsm1H5nORKpddBT/1TrT81JOHEKc5uycrL8tEVwlm7 l3ew==; darn=linaro.org ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ojx3gydl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Forwarded-Encrypted: i=0; AJvYcCW9HHxD5PrCzewrbWnFFvu+aZ2bGAaBQ/1PLJrNe5n1etG1zG7vC+wZ2yKyO3V4e/ztcQuX6R3bAHbqQ1tiXzdT Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id vv16-20020a05620a563000b0078321c60d62si2721431qkn.762.2024.02.06.09.13.49 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Feb 2024 09:13:49 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ojx3gydl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rXOzv-0003pJ-49; Tue, 06 Feb 2024 12:12:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXOzt-0003oo-LX for qemu-devel@nongnu.org; Tue, 06 Feb 2024 12:12:37 -0500 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rXOzq-0003XY-Je for qemu-devel@nongnu.org; Tue, 06 Feb 2024 12:12:37 -0500 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-40fb3b5893eso47649065e9.0 for ; Tue, 06 Feb 2024 09:12:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707239553; x=1707844353; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PrRJ5d76QadE8MBCkQGSm2LWsORcf86H/9Nb7qmGBtc=; b=ojx3gydlZ84j1rkyFXhGxr2oYHB73q3gjJeAEjmLek46Mgz3kLbhPbq87jObFmfxzA 2IIeWYw3oLQHNS927OusX48HhIZEGHIixzP4s5DLm9CXboxSCztFT8hgRn4Epz8CBst9 2AIqDRzqEOuGgCeYJTg/v4q+KtWHkSHwPmZyiv4Uzmmm+0TgxRak51c9G26n6zCKTI0K 6L0ag67z24xV+vo0hlCrXW3cV+3IMjDi9SoaCwuG7oCCx8Ab022sNF9DHFAfrjLRcVZF 5XObIFUvaWsMyi9ZA+TgTVRmMTQSsLJSW7Z02pkkWdSCMlNiLe7UjNVvCbavmFstULXx +MMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707239553; x=1707844353; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PrRJ5d76QadE8MBCkQGSm2LWsORcf86H/9Nb7qmGBtc=; b=fLhEAvSr5fq7q5fxnxAzrW6jpxWJ6HgaL4fE7oWpD98+M5fVhLQb/oMSsufiqrPHEj N7QDfEDEKPLw0/xoDPgd9zVzIxPoxyLwSDP7or81gYbjsObZen5M8X5DMMbiESKWGJaH PUtX6v7r1dzF9IrSstCMWxvfjAnjRcBysa0qcVeinlyOpvhyE+0YWK1d4+l9li/J6lC0 dEcoDtCTcyidmFcAS3q28w8E8CSkVm8ZCvURWGZkaOgJiTBaDOlFeQzDYXsGPtOwBnTP aEIy/NXAeAcljkgzotvCl0wMqjXL3WL8HBdMwP490twhL1T47GRXLxqJeTcBGVZSdzvu gaEQ== X-Gm-Message-State: AOJu0YxHz5pnkjgLpRGd4rGNOtpL+pH9yN3V7Da9gJjNNZ5dbqa8Q0/u GXceuQ4RIlXMu28s8WxTd7/b6AxgzKApQudwBgCCgmpWhFAWV4j9JkpxDdcY3jgr5CR7d+Rn44O R X-Received: by 2002:adf:cc8d:0:b0:336:76de:c171 with SMTP id p13-20020adfcc8d000000b0033676dec171mr1726208wrj.62.1707239553103; Tue, 06 Feb 2024 09:12:33 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWrtJt+URG6QvNQSw7sNjxDtAWWtLTan3pIGQKX7+MclM8g4YZyfgLNZ5F+SWfrzDbMwfhwMa/rRzwieUPjjca8A0Wqq8BpyJ7/W+cltLz8HuyQHB2DGK5Io2WagPOeL7sCqZKSivf6rS6PgT/DZBlxxmGg Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id l12-20020a5d4bcc000000b0033905a60689sm2561284wrt.45.2024.02.06.09.12.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 09:12:32 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: David Woodhouse , Nabih Estefan , Hao Wu Subject: [PATCH 1/2] hw/arm/npcm7xx: Call qemu_configure_nic_device() for GMAC modules Date: Tue, 6 Feb 2024 17:12:30 +0000 Message-Id: <20240206171231.396392-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240206171231.396392-1-peter.maydell@linaro.org> References: <20240206171231.396392-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The patchset adding the GMAC ethernet to this SoC crossed in the mail with the patchset cleaning up the NIC handling. When we create the GMAC modules we must call qemu_configure_nic_device() so that the user has the opportunity to use the -nic commandline option to create a network backend and connect it to the GMACs. Add the missing call. Fixes: 21e5326a7c ("hw/arm: Add GMAC devices to NPCM7XX SoC") Signed-off-by: Peter Maydell Reviewed-by: David Woodhouse --- hw/arm/npcm7xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/npcm7xx.c b/hw/arm/npcm7xx.c index ff3ecde9043..cc68b5d8f12 100644 --- a/hw/arm/npcm7xx.c +++ b/hw/arm/npcm7xx.c @@ -710,6 +710,7 @@ static void npcm7xx_realize(DeviceState *dev, Error **errp) for (i = 0; i < ARRAY_SIZE(s->gmac); i++) { SysBusDevice *sbd = SYS_BUS_DEVICE(&s->gmac[i]); + qemu_configure_nic_device(DEVICE(sbd), false, NULL); /* * The device exists regardless of whether it's connected to a QEMU * netdev backend. So always instantiate it even if there is no From patchwork Tue Feb 6 17:12:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 770396 Delivered-To: patch@linaro.org Received: by 2002:adf:a40c:0:b0:33b:4b49:db74 with SMTP id d12csp66106wra; Tue, 6 Feb 2024 09:13:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IGZwu/n3S8sAALLE7ES7OB0Y7NOZ3c+wtCVxHNX80blmzwwoVg5Iu1NxgxbF5ZJcFeWnKBo X-Received: by 2002:a05:620a:1364:b0:785:8a90:240e with SMTP id d4-20020a05620a136400b007858a90240emr3179919qkl.24.1707239619905; Tue, 06 Feb 2024 09:13:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1707239619; cv=none; d=google.com; s=arc-20160816; b=Ubc0R4RfHNAgV1cQp4QyGv8FAT+HTMHz2isdb0VwYBe/5ePvEyxhYlEmjsbgJ7wWP4 SE8HZEiDI/jMw7hpAGWP5En7oVKjWO8wGZOtn3fMniRVxSzHbabdHypFbtCne8G07Eib zPn5LqwtVcyJKDqt4i/SxDvvGE0tpUD5oWWTUsR+LLQct4DjYV0sxOO0YbhqtLHPawYG Noq8YJVybur4G9fv28CW9SvzFqpDiWOITh3dNovRHv3TnRdV6fa2TmLKYYmy16JSGcC+ W+X0Cz8+PC+cdGCCqfk19aUfKgIvYoabYb/I/QUS+yE5Ri+ogpBoXXsVkSZcYZvvIQnx BeUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=MH56YTCLqm7CWs23iAH4TIELKHifi0GITJ752eBfDjw=; fh=SQVtGBi0X26Dctkop225ZgyFabZ00gq5Hn5AG2g+6q0=; b=HruV2nG3yf4lwLT78NyNPkJ+9CiQShL8pn67qKHqW4SkcfZiUgzeIex3OHJL6vfn5U BaXDXXGyABDqHYb3X3g2tvj0ToN8uILS/wbwhuspLQmSOKEvpoi4NV/ojW7yTvBMoDkn Zal+tjiDOdy+gfDuUe/vZ4s15cPBZNEuZasDyPcNtbIn+/Dh9cwprhkdSTi59S4KQhXO /lJImZUbg/mClKWsCBhuI/ntY7PJxdVHaV8/z+LxlUyZueJ+ihDRwChmMiAgonv4e+wK OQ5/IPjvaAVCcP+1/LX7VzNRGjB8cHF4QoYItPyIG1l71hpSMKKmZkgD12fuqhOFE0Tm FP8w==; darn=linaro.org ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=n6CxjObG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Forwarded-Encrypted: i=0; AJvYcCXfPyf6dCRCHCLx/6aIbzAg+ZBYV+8Ny8rUPHOdhbWh4VKeVxbfCcRDw2QkhkBozAGECseBfkH0vpCn3nmljgqx Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id h15-20020a05620a13ef00b00785951690fbsi857748qkl.11.2024.02.06.09.13.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Feb 2024 09:13:39 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=n6CxjObG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rXOzu-0003pB-IQ; Tue, 06 Feb 2024 12:12:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXOzt-0003on-LT for qemu-devel@nongnu.org; Tue, 06 Feb 2024 12:12:37 -0500 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rXOzr-0003Xk-4G for qemu-devel@nongnu.org; Tue, 06 Feb 2024 12:12:37 -0500 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-40ffd94a707so893045e9.1 for ; Tue, 06 Feb 2024 09:12:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707239554; x=1707844354; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MH56YTCLqm7CWs23iAH4TIELKHifi0GITJ752eBfDjw=; b=n6CxjObGleqwMRriOnpzRu81mjCflQa5feqBYbaH2GRaU713fP/4Ud6eOUojWwB8lR 9KJd5ScFa8IjDXCEtZGPJOl4//483tGckgtIeHvdZ6ITUWlIX9gKGNF5CRD79Zoyp4pC cXWJIwFxU6DeCkk0TIsnDiKQfwhyEt1G4k6TOw9PUO6M19iJEZWNj73SpiHF9vkC3Ii8 L8f7lIZUi1vxq2sa0RBugAaXPICi8JUAT/8JrRH3wxNGsIfRKRNdzqFnXJ/tHPBLkCzx +pC3hykk6vkr1FMn/G2+6/+3VX2kByj4Fq3sDNLd2EYi2SpetQ1u/xsglgFglO67zO+1 FRvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707239554; x=1707844354; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MH56YTCLqm7CWs23iAH4TIELKHifi0GITJ752eBfDjw=; b=Cq5TIwxLjgOq3BIx65NU1+weX0Y/ufRP9HU3ML4KZv83UMKUt35WLbUs17FSSBl7Y0 0/zBXYpauB6jHnF3HPlHbXVpdqqBDqGwOGDAOvBhBOs9kBWYD+CW60uyy/SUDIFZA9n3 drLs2EjElz0A/9+Efe/X0CoxqyeOelj44kbZrwvnQSn86RvOWaO+ZOOK5/BvTAaJ/JaU UzNl/xgAGioF4LOAZFuX/KLXw/QhqT/3qrpZeqH5GHFtTJ8NYxAd6+uuozdDKaxMOiob jZ5xEIf8k4VzkUwuimC6NHAttfAHuugTtBhucVGSFxh9QuTYwPm4iMUAz1NzoDNcre6k VPpg== X-Gm-Message-State: AOJu0YyE0JffuWfsdlI5dBvs5Axk9cS8iy3sOyGhxB874r/N8JX/Y5yf m8OHyaT/HoKXcxp4yVDZYKcRcvQqQqb0X+VLyjDgnH/GZW8/YhY+agkyL+wP+Ug89w8KQk5yYPg 7 X-Received: by 2002:adf:ce0f:0:b0:33b:21e4:68d5 with SMTP id p15-20020adfce0f000000b0033b21e468d5mr1757035wrn.34.1707239553719; Tue, 06 Feb 2024 09:12:33 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWjoe4nxjJudTv3JMKkultf+xyz2bo4vKQlN5voMvzq4tv+9Rtb5n27S1VJTVTvhEmjZhvFYy1ynmx/kFtB5o+wBIy0IVxD6jUlAFutQZ8bTDz29+cIXfkolx9u74zSscViTCxKBiYVdVCLJIddSyffbKpE Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id l12-20020a5d4bcc000000b0033905a60689sm2561284wrt.45.2024.02.06.09.12.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 09:12:33 -0800 (PST) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: David Woodhouse , Nabih Estefan , Hao Wu Subject: [PATCH 2/2] tests/qtest/npcm7xx_emc-test: Connect all NICs to a backend Date: Tue, 6 Feb 2024 17:12:31 +0000 Message-Id: <20240206171231.396392-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240206171231.396392-1-peter.maydell@linaro.org> References: <20240206171231.396392-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Currently QEMU will warn if there is a NIC on the board that is not connected to a backend. By default the '-nic user' will get used for all NICs, but if you manually connect a specific NIC to a specific backend, then the other NICs on the board have no backend and will be warned about: qemu-system-arm: warning: nic npcm7xx-emc.1 has no peer qemu-system-arm: warning: nic npcm-gmac.0 has no peer qemu-system-arm: warning: nic npcm-gmac.1 has no peer So suppress those warnings by manually connecting every NIC on the board to some backend. Signed-off-by: Peter Maydell Reviewed-by: David Woodhouse Reviewed-by: Thomas Huth --- tests/qtest/npcm7xx_emc-test.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/qtest/npcm7xx_emc-test.c b/tests/qtest/npcm7xx_emc-test.c index f7646fae2c9..63f6cadb5cc 100644 --- a/tests/qtest/npcm7xx_emc-test.c +++ b/tests/qtest/npcm7xx_emc-test.c @@ -228,7 +228,10 @@ static int *packet_test_init(int module_num, GString *cmd_line) * KISS and use -nic. The driver accepts 'emc0' and 'emc1' as aliases * in the 'model' field to specify the device to match. */ - g_string_append_printf(cmd_line, " -nic socket,fd=%d,model=emc%d ", + g_string_append_printf(cmd_line, " -nic socket,fd=%d,model=emc%d " + "-nic user,model=npcm7xx-emc " + "-nic user,model=npcm-gmac " + "-nic user,model=npcm-gmac", test_sockets[1], module_num); g_test_queue_destroy(packet_test_clear, test_sockets);