From patchwork Tue Feb 6 20:55:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thiago Jung Bauermann X-Patchwork-Id: 770403 Delivered-To: patch@linaro.org Received: by 2002:a5d:40c1:0:b0:33b:4db1:f5b3 with SMTP id b1csp4431wrq; Tue, 6 Feb 2024 12:55:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IFTjPF1glgsiRASalfNeTlsmihe2+CBbJuF17UoBovStzH19InYmlhzXt4KMynewV52p9pE X-Received: by 2002:a05:6870:3290:b0:218:4c81:4f55 with SMTP id q16-20020a056870329000b002184c814f55mr4657757oac.44.1707252939823; Tue, 06 Feb 2024 12:55:39 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707252939; cv=pass; d=google.com; s=arc-20160816; b=hHw1oEIboaEMiuQTprf6bnPH1niPF4t5h96rAIJGPiiULx5OmYC0hyuzWECgHhARRn WByUxu0Nbs0m5uCV4IlzrzZM7kcJh20JBdGK2yOqj1N9zwAesnZHAUv9kpgXidGFwBw+ ibk11sTQXonsm+0ejFfP4MybgJzz7KIU+uPCx5qO1W1jFYsrhAp6q52x1VJgCaIh6MHq l04HJhByhECZTsjUlHqn+Vetx0fcgweQaPzM7+Gcf8f6ccOa02L0iLB8Yl9g/k1MH74k pGSXklAUG/knPSPJ+wlF+3RK9CazZdvkkfw8FLIkxq/pWDvZ2SdFMB1HE94wuGQzh/bY HHhw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=3+8yq57a73Nvo2BbN8ZbipE3NUGTsVjf5gSxdtRYNoQ=; fh=MJKHu24WdR+H9AytF8IpNS4ckMkwuhGLnOYo7s2rF5I=; b=ptDsHJErFRi78Afo6IXli4ijIhyBWyJJZNIW/m+OTDcwQiFptI9WHlzRykP1BHBNY9 M6AH39ZAEk72SaiYQAmBDWvdWKY0ZlrL8a6Gp6ptPKs1bO3EKUHIB1JNKC7YmhleLN8u 6HW2OnqAClTjH4VD5P2uHv8Prdkey66todSg35/3cnx3TvQVX3QeA66lX+5j+xKrGXKG CcKbP2z1angLIpqGG6xhiJDasexFrGJSfliHi+MdI+YloIVvuieWv5cvbiWvGN9vOWHB 2SlHL49mYG4y403e+CneKEi+josB9+gMr/ako6Li0/QfFtlh1YimqUeWExswQBBcOCJp +qYQ==; darn=linaro.org ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fVScbijE; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+patch=linaro.org@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+patch=linaro.org@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org X-Forwarded-Encrypted: i=1; AJvYcCXrqVjJz4Piizo3OZFOIUNPRjuMy8Ou/zr/Dp07SlWscDzpYQHUh4XOcFrKozBcKaiVHXIFS74nd1+LJD+CQ0mA Return-Path: Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id m15-20020a05622a054f00b0042c0d9329f2si3176225qtx.254.2024.02.06.12.55.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 12:55:39 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+patch=linaro.org@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fVScbijE; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+patch=linaro.org@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+patch=linaro.org@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4977D3858415 for ; Tue, 6 Feb 2024 20:55:39 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by sourceware.org (Postfix) with ESMTPS id CA7B63858D33 for ; Tue, 6 Feb 2024 20:55:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CA7B63858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CA7B63858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::102c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707252930; cv=none; b=thQvAe2D3crzMIJ+KJv/sbeGnrBfsEYhn90umPkdWenlrDez/q/eDgLdYkxvexMfaLrWpf2WiVIeCNo/3d0IkRZ6woagyYnA4KxqYoRxH0yC1js45qDCVm//RtRNNbp+CnZxgshZDLKwYOZPrxLaMd3F16LLefDwYpyLmnq2pQE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707252930; c=relaxed/simple; bh=cl1aAWLlQsT2bAPmfQ8vch1kjOQgfc6Ls1A4Rmkg6wY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=CISei/TUdlT0VZwbrahOyQ7rgu2hVUklbQiKrg2kB5p/1we957uqMNmH/WOH9O/uNT8bYzyuMr7UVcv98SDV9i5uwiKdpRe0itQaTiJ2hZ9nd8Ku7yTE1AhT+mEiGSzNYcNb7WRKTgCUUiolVaN+0zdB/JsE4t1Xn1D3H24BveI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-296d24631c0so626341a91.3 for ; Tue, 06 Feb 2024 12:55:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707252927; x=1707857727; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3+8yq57a73Nvo2BbN8ZbipE3NUGTsVjf5gSxdtRYNoQ=; b=fVScbijErYMa1NYFoUk89XYPnPFgND4WLBTbAx8qW+gkdEMWkMM+2CH4vZVcXrUOSx sFI+H4jNo0wvp1LD/ka4YnM56/h78/kLyjmvyMPauSRg1y8Cfg7qHihki8wrNVgnrpBU /ETYaUUxIMsb0f6xdtZbtrIVtb1Zu72PePmDsZJElQUomGcCC7vG3NWrDg9xIvm8XZ9U sCx+cgrlwWL9OVZwLllsqps94t7ZsZUSiFDuXsDiUPMcWnJ34wz8IcAL49PJa6RYwqHH 16yARWedPt0V9t8sKEYup6DIwdFjqt1Zq6HTd+4wzvLZioyaAFbnU8rsx90ecGUDYRcF weFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707252927; x=1707857727; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3+8yq57a73Nvo2BbN8ZbipE3NUGTsVjf5gSxdtRYNoQ=; b=SkQBwE/gz5aMn4O4nwXRC4klYljGrJUVe3MZtUCoHC0JNQR+YHj7DJNPrGkiIvwcgj GQL6OTthLNwrDxQlwr99Mey08a4smY3LlgbrE6yUi5w0zEsuyAeY1EL8F2SaoCnJVuTN 5HrI00j9z7RhkOWHSUdQqifhEdgdUyQR/bewEdnI7O/0PRvnJFFL5qdbIegQCpQF2I4c DUvjUJicP/zgCsV9yzhlJJwqx4WThTioQ8IWTkSs37KClSEbJPVnp6p0/o77W/ijHK59 V7f5ENIRpdt9YEweFhYQNMSVQgbYzErZ9JAjll9SmBfnWIIx+Qgrt4L+5eE+l91xBfh0 IjVA== X-Gm-Message-State: AOJu0YxXv3ha5zD5mLAm+/WMITul3AzxgO/yxxC25lN3qxvMiyWin4eZ fzmr82QgczLWezTGNplxh62Cy5PeR7wuYPXmc0jvy4HSmdNn54BZbXDThAT1LvNeDFYcUIUqYkR 7 X-Received: by 2002:a17:90b:1909:b0:296:2578:a54c with SMTP id mp9-20020a17090b190900b002962578a54cmr680919pjb.38.1707252926662; Tue, 06 Feb 2024 12:55:26 -0800 (PST) Received: from localhost ([2804:14d:7e39:8470:77d4:c80b:adc2:997c]) by smtp.gmail.com with ESMTPSA id s18-20020a17090aad9200b0029652c53a32sm2165378pjq.33.2024.02.06.12.55.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 12:55:26 -0800 (PST) From: Thiago Jung Bauermann To: gcc-patches@gcc.gnu.org Cc: Luis Machado Subject: [PATCH] Fix disabling of year 2038 support on 32-bit hosts by default Date: Tue, 6 Feb 2024 17:55:24 -0300 Message-ID: <20240206205524.71766-1-thiago.bauermann@linaro.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patch=linaro.org@gcc.gnu.org Commit e5f2f7d901ee ("Disable year 2038 support on 32-bit hosts by default") fixed a mismatch between 64-bit time_t in GDB and system headers and 32-bit time_t in BFD. However, since commit 862776f26a59 ("Finalized intl-update patches") gnulib's year 2038 support has been accidentally re-enabled — causing problems for 32-bit hosts again. The commit split baseargs into {h,b}baseargs, but this hasn't been done for the code that handles --disable-year2038. This patch restores the intended behaviour. With this change, the number of unexpected core files goes from 18 to 4. Tested on armv8l-linux-gnueabihf. Approved-By: Luis Machado --- Hello, Yesterday I committed this patch to the binutils-gdb repo. Since the toplevel configure should be in sync between the 2 repos, could someone please commit it to the gcc one? I don't have commit access. configure | 3 ++- configure.ac | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 874966fb9f09..1da0e67c28fa 100755 --- a/configure +++ b/configure @@ -10301,7 +10301,8 @@ hbaseargs="$hbaseargs --disable-option-checking" tbaseargs="$tbaseargs --disable-option-checking" if test "$enable_year2038" = no; then - baseargs="$baseargs --disable-year2038" + bbaseargs="$bbaseargs --disable-year2038" + hbaseargs="$hbaseargs --disable-year2038" tbaseargs="$tbaseargs --disable-year2038" fi diff --git a/configure.ac b/configure.ac index 4f34004a0726..fa508a0612a3 100644 --- a/configure.ac +++ b/configure.ac @@ -3420,7 +3420,8 @@ hbaseargs="$hbaseargs --disable-option-checking" tbaseargs="$tbaseargs --disable-option-checking" if test "$enable_year2038" = no; then - baseargs="$baseargs --disable-year2038" + bbaseargs="$bbaseargs --disable-year2038" + hbaseargs="$hbaseargs --disable-year2038" tbaseargs="$tbaseargs --disable-year2038" fi