From patchwork Tue Mar 5 12:24:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 778241 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E83159B5E; Tue, 5 Mar 2024 12:25:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709641528; cv=fail; b=h+zpnEiRe1o/tHaOzOpiexmrKl4LptL+Q7WNbLZHArAdG4GCu7+be3IsM/HGHupPV/hlX5uMXJ+VG1FogKRIiKfnqhCgHH33mAxskIFt0Uz01xdmWUmHwvWOxBM9P7Sq3E9oqNWS6riQ/heSYWFwn+TjVweUktBvdZxt8mTqoQs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709641528; c=relaxed/simple; bh=7iIdsSOoZMxpUtexm/xuAq+gnfuh642xxnlJHB+o4FY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=J+XiQVCU9VPfOc/fNkF4Tih5do77Y+8I3QIcImZ5VQTJFcWpQet1CQJunAUzzt7DegPKhZ2TJI074TUrwx3uDjOdMujmfv/XpxXrg3O7ZHeNwrS1pp1v6IyotgyHaBgmTSkvKG9ae7+PdjUNK5ufLLugi2MZ15jUzqicAN6ZVgQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=nf/DmSCL; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=gCL/VjHU; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="nf/DmSCL"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="gCL/VjHU" Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 4259jUx0013901; Tue, 5 Mar 2024 12:25:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2023-11-20; bh=1V/+6TbOsqTR44lrvZ2byboEZcSMkQx4E88WgOPQ1kQ=; b=nf/DmSCLGhSd+If9+Wtz1RBPZP0ijb9IhGbY1EOeWEFnBWjGr3HcFdY/kb6WZ+DWyD7u gSrCaaTIQokDeYVa0w6TtMyyP4S+FJA0mJuKCHpJht+e1UABqeu50joe5J2kEujkf3ap MJZ+QC2T7DMtiN9u2gHjoihkQKrA1u2PD3X/6DLzqOQIJ/KJ9ZERzNruAQxsjveKbKIz 4501q2PVYTRMfqvqlD7IfKarj6j7RzgGQFey/vbL8k6sMo3I/BNTvrzUoHfmBMidknVm IlX4bpPfYP/YHoqlgqIa2ozhVNsTIQ5F7Rr6FsintF1yl6vdkapQle9uERjKW53t+oi6 LA== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3wkvnux2j6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 05 Mar 2024 12:25:11 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 425BWTxM031969; Tue, 5 Mar 2024 12:25:10 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3wktj7r6vu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 05 Mar 2024 12:25:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MkXhT4OM0orfCFrSqxnvaijnUH7GbO63J9b8eqvKtZammrIIHtDvBgsol0kuREvEUUnigm2LAYp8OgMFcTsg61LibRONkMlwvFhq3xvJxRURsw8ssE0N38GfGGmfq5utAdegHpZ95aVCZBBmNjkqUJH82smjpke5qIAU/8m7CPnVhu4c0xmFwxn5BC4iHnEo8NCRNWq4u1RZubFZX4a4ga/1Vv41alN+I9zzqVxCL1+E3iEve1VTbhGqvHy3sxSXWsL8su7xlq4x1gXZM1cJpgvbTq3u2wQev8LksKgcsr99eZWXsGybBH0+dUBBznF+6d0aIiOOO9mJB3Que3zEsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1V/+6TbOsqTR44lrvZ2byboEZcSMkQx4E88WgOPQ1kQ=; b=JZeHolWjvJAX5eZoVESVxj1OmDM61dY+FfyqBjVuf7zaZqKK5iae4QosgLoIBV7HaeHGkphV4AKyZ/iLNfE9VX9/yJYdYasfe0syDsZ4Ry9vXQvkSfNw3pvomgxdEGXOGhvJ+OuQBRvZd58xZILWonjwvszE03i5Mkgs/A8SRA0QoSleU0e4tOa4pIY7xryBk2jDUVve9wGPV/9GPBSWpqxWlpAHVc8F2HuOpj0A9T+MkXljQJMHlUikyXSAUrtznIa/TP7aTOs85cxgjcn1tPDN9etG/BKlBnvi7iGhDBE547mnhBBRW8RLxJU54NeagMe/qkjFWG1pkb1Q9XSm8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1V/+6TbOsqTR44lrvZ2byboEZcSMkQx4E88WgOPQ1kQ=; b=gCL/VjHU84ckG77MyDszPZVGx2GDocr+ZdnFtugduDAVUfpYm/96x9Bn9bKuzZ5EWjRPwudiCHnbhu90j/kYSDNF9wFLJOU+h1ZjZQ6IGPQfIIPVn7HV1TF1cGII5eAsAMilEtBWNTcMWvXTbY3/ekSg0cqdCe1z1HYRMoiaIq0= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by BLAPR10MB5122.namprd10.prod.outlook.com (2603:10b6:208:328::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.24; Tue, 5 Mar 2024 12:25:08 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::97a0:a2a2:315e:7aff]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::97a0:a2a2:315e:7aff%4]) with mapi id 15.20.7339.035; Tue, 5 Mar 2024 12:25:08 +0000 From: John Garry To: jejb@linux.ibm.com, martin.petersen@oracle.com, chenxiang66@hisilicon.com, jinpu.wang@cloud.ionos.com, artur.paszkiewicz@intel.com, yanaijie@huawei.com, dlemoal@kernel.org, ipylypiv@google.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, John Garry Subject: [PATCH 1/6] scsi: libsas: Add LIBSAS_SHT_BASE Date: Tue, 5 Mar 2024 12:24:47 +0000 Message-Id: <20240305122452.340471-2-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20240305122452.340471-1-john.g.garry@oracle.com> References: <20240305122452.340471-1-john.g.garry@oracle.com> X-ClientProxiedBy: LO4P123CA0010.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::15) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|BLAPR10MB5122:EE_ X-MS-Office365-Filtering-Correlation-Id: 68ca406c-4705-4b18-9bf8-08dc3d0f4b99 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dnjHGOdd8SrLKBZT3OztSZkExWcOvs5jMfZK/fecFd/Ba08nGPwTG8ooIkBc9ZXLNpWSAdhSuTTfBfGD0sYT/EAn45Ojm/jejz45nsceqX2cXIbGzpq3/rc+T/FWN91FmOn7pi7FDlml5m9mgeQhQiHL7aJ0QEeHamKM/zXTp54NIzOB2U5+XcHxwh2HnvBqqSO4R2F7vSYzMc17MlyOifjECZ3zY8rQOaXvVUbIbTlFCJ1RTyOzl8kUV+j6pbbDgGYgcowcxq+X+JQ6xWcugeUNohCQMgICZTNuScRAkIuiP0l3OJvwlblpPzG4yBtyEG+788GzGmOIIqrcvM48YbUdjvY5rNyhkHFhC48RWdpF22F1k+LrhMzCrGegJAHAZOyk6wkZF+8m86mzA3iTggGkF86OPSUvWuVxMXcnG+oRfkDRmxsHnU/BSu3iJUoCSVR7usr35Y5168yrdpXg+z1c7gmrK/3ocxLS9B9jhia1O6psmKHZon+/GOXLji1QpPvlOPIR8+ON2zwoNIep4luWn9tif9xX7yVNdAWLsRRKDbFg35Jo5P2mC8kPknISCSwkWSauzk9xql+VZaypSBGT1zbwGezQBJmxXWdILnElLMUrS2IQ36tkQk9yF8MwNmejVgz80JJMzy2kOZIFPj8dDzgXp6hTn26T5RcWf5I= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR10MB4313.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: SkkvqHkn2nvWg0YMDEI8kxY/EZLmLeWYk8pJdR621r4D8Nf9ACixTCbeDban+MvmjQoD475bT+97gttd6C3wg5V0pmBOJZjKlpoynGh11jMqwijYm1MHmkpbxisaE8e+3mx7+hdOaB3nvnDsOKXuICzY9X028x4lYLXpn4zVWTaUQyupEIBv2APkgvTdRIVbLP9hkLSvzh4/Na3kR4jlgz5kjY4MgIoekfYr3v3oyqk/pGZeOh/lKcdtrs+tXGoJbd5s9g2ETU42Gptw0nVsDjiYf44Sn2NwZqCkUBqmWjO3Za0DCGLd8GkFjfMbUtZbGoX8xxsvbUjImcVK5FViABaafQNz+MnpE6uonP+qDl9qHVUWKbliYge0Tr0RWINMQObYpCrqcysLf7hNxjLRMESVYIAWPuyVy3Du/pJzOxhlduM69+fiE5Nt/PmmYqX3nZeq5mxzfxLCC5iYH0raf/n9W1kiHTZO42Q2Akq+zQovSN0c7WDFpAtIa35cz5oamFNXuzL0C1A2GUMVvtJtKWcBaK1NpMrlQY5aSyr2/F8VhVdruZvElVBXoz+9mSDn6Khi4WV2vZIMBV39lodkpBG8fXRLQTm679LYFm+Tjsyz8J5PsVigiBm1MeKsw6I84aoyi5BoA0vKtoTL4Y9JT05p0bJmSFNKHbviKNQ0TgXFea+toLkuUphVjTmD5m/p43ShMiC98K4vYTc+u8495NiCJfPuNEIKeTvRibJsVy97GOaZ4sVpN7oQ8fWludHoCB8IMf3mdEHMTdNviIBcD8SJq7UJ/PRxF4F3fVQ/4cS8V3q0f5uKL7K5yZC0B7PFGZ7BiVyOT4IDkXV/jSljHs4KcIm2mr+WBxnEyu2nx96vdH9MMGC1iJKv0TFO0/t5sAAil2MwvvFvqyTdjrRNOpCL8y9eZQnVqWJSSU6UwK8iW2gzJUiQ3kxXJoOhDcBKIx2tRyG11anq10olS1aQgrC6al0LM+OMFJxo2w3Lhy9LqdZTJxtDYR0lVGqHcfkW0QLr/FD2vzmdY/PuRnP2yrEFrZlzMvDgIhUk4ndjmSY84Zh6MVS4O5fwcki4QFgfqYE+KCDPYOAMXP10xnIMnDlw6IUErgtpl/IZwHaecY14uCzZTZMMV6Nm3p/YvAvSJiI8i80I3JP0+YTsgiP6FZASBSgqQNkil+a4up2gxToGxeo6/CkZvPUaN9JekRoMBTLc0UrpCC2ZQXWI8hd7G4IhUP1oRbLJaRiaF9qSmdW6JPR8Me2zbEepFHlGk1R7md+XVUoaAqYCYf9nweVP/+HrCe/hBuBHT9xSASp7wckcBMyl+OP3rjjZvMkEhKGc1uJzOOkY7fMl0//EWdj+MO73/tZX82BghwDsRUShpWvjsyi8wQprz+kkmFX0rt2i3Z+o9NdrFQe8Hb3jrboZ1XJIWcajCIpD4L1hdUe15Ixq/GSJsdMGt/zlOL5Qlrzj6hcRdj07V/Z2p3z7uCsh77mNeX8Nv5K7A2JmyFUnXV7zpIp3egphK3bSIewu0jOiKhnQPKSpKitZ/7Dh0tVx2TkM3Y5QBH+U7wQ/TGXbqGHBjDvlciSzpdRmRzRdi1+OmIa3u0iEf2iR3vTel8xkdw== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: weeV+c61wLWxqyD2XIFLFQCwyyDdab0QQVCLHWWF+S/jYkVUIjSzyRc9IIijrQZ7/P2dAXT+DFQDkzSszMHITdIHy0rWz9FqIKt+sW4uDvyzpX1R95jXa4F/cWWXJXXskAMJ66V8xmNv0d3T7oHGhidixltXFMCt1xAMFz0WWIj50a8RxvBVK0rpslHR4gmQDx0YISC/ygf0Az7q+ej3Mcg/FXEvpa9Kpi1FIjIcdAGhfdpd7+Mk5dpIO05higQBlV5OrAKQLhH76eaR8AAQreCps4ftp7ZiHYOjb7UI1TVJDrnkz/k81+2k3MnbT6hKkdXGgMCBcWNSejGpeeP6KbfXp5uL7A62fSy01FEb1O0nLmojStDlSdYHHooVi0Lx4w/X9FYtnnrDM9eYXzEenvsCIqXpXnsVVQ8+QNiXoCj6wncJsyN4UZfCBJQA6L9/kqudxswN7CiZUgcGFhr8vS5pg2PHtO+XbTnpWjfGv3Ya3QS32niGuhMVT6ubSup11+vUb/6/FpBfUD4tIGlugHjCgENErOIVlS64xTUrCPW6Vp8lKOXx2zpbxiE5eSWotNFPYPig8bp8JtpmvsTTLHGzOsXxNHIMzRiI/70ulAg= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68ca406c-4705-4b18-9bf8-08dc3d0f4b99 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 12:25:08.4070 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UZMSLIfHtpDFk9735VlzKPt1Mk62/imdqf/lUCnqScc4Lj4P4kXKBap3sTW6bAXjr/pjR5JBPK3lt8N/FCSLhQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5122 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-05_10,2024-03-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=999 spamscore=0 phishscore=0 mlxscore=0 malwarescore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2403050099 X-Proofpoint-ORIG-GUID: 9aH9hmdqXJ9JbuOHDPzLvyzAFVCnN9eU X-Proofpoint-GUID: 9aH9hmdqXJ9JbuOHDPzLvyzAFVCnN9eU There is much duplication in the scsi_host_template structure for the drivers which use libsas. Similar to how a standard template is used in libata with __ATA_BASE_SHT, create a standard template in LIBSAS_SHT_BASE. Don't set a default for max_sectors at SCSI_DEFAULT_MAX_SECTORS, as scsi_host_alloc() will default to this value automatically. Even though some drivers don't set proc_name, it won't make much difference to set as DRV_NAME. Also add LIBSAS_SHT_BASE_NO_SLAVE_INIT for the hisi_sas drivers which have custom .slave_alloc and .slave_configure methods. Signed-off-by: John Garry --- include/scsi/libsas.h | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h index f5257103fdb6..484cab72e711 100644 --- a/include/scsi/libsas.h +++ b/include/scsi/libsas.h @@ -726,4 +726,34 @@ void sas_notify_port_event(struct asd_sas_phy *phy, enum port_event event, void sas_notify_phy_event(struct asd_sas_phy *phy, enum phy_event event, gfp_t gfp_flags); +#define __LIBSAS_SHT_BASE \ + .module = THIS_MODULE, \ + .name = DRV_NAME, \ + .proc_name = DRV_NAME, \ + .queuecommand = sas_queuecommand, \ + .dma_need_drain = ata_scsi_dma_need_drain, \ + .target_alloc = sas_target_alloc, \ + .change_queue_depth = sas_change_queue_depth, \ + .bios_param = sas_bios_param, \ + .this_id = -1, \ + .eh_abort_handler = sas_eh_abort_handler, \ + .eh_device_reset_handler = sas_eh_device_reset_handler, \ + .eh_target_reset_handler = sas_eh_target_reset_handler, \ + .target_destroy = sas_target_destroy, \ + .ioctl = sas_ioctl, \ + +#ifdef CONFIG_COMPAT +#define _LIBSAS_SHT_BASE __LIBSAS_SHT_BASE \ + .compat_ioctl = sas_ioctl, +#else +#define _LIBSAS_SHT_BASE __LIBSAS_SHT_BASE +#endif + +#define LIBSAS_SHT_BASE _LIBSAS_SHT_BASE \ + .slave_configure = sas_slave_configure, \ + .slave_alloc = sas_slave_alloc, \ + +#define LIBSAS_SHT_BASE_NO_SLAVE_INIT _LIBSAS_SHT_BASE + + #endif /* _SASLIB_H_ */ From patchwork Tue Mar 5 12:24:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 778240 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3BCB5A4C8; Tue, 5 Mar 2024 12:25:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709641529; cv=fail; b=srJEaXmoUTbFaFC/jyDwp13gpnWEcQVbwIuSteZsJlAFlOdaLjodC3ODYib8Ex3R0wG/oqXmsVEkyIF2h98oCOxQbcNjlEV9OyJkdWIGIkYhmRHVjb1hiZvKPjg00iJY2sMfXNQjuzG8xgWZJD4Rvu/NrUcacAJDUpQGyOrfIdk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709641529; c=relaxed/simple; bh=vNqd+bjMiJ2WCkNE9isBfRItPa9mZecsN4F5gRWVu48=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=uTJmrBaNZgZVYWKL+YCtDtl80jra+eFTjgUsz6GQkfIriFMCl0W7EBTRspXYRvb/4lY1WA2l0XYriYmop8V29GLsTCBs0rAIlGXWF2vzRlD/+0kyBUftcgKCJgMb0fVKN6FJi0lurNb1lCkhMlsdOC7kuKx2j4lhYUAmPNbLoGI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=DrMR8nCr; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=r3WUYiA4; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="DrMR8nCr"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="r3WUYiA4" Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 4259jRxp024627; Tue, 5 Mar 2024 12:25:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2023-11-20; bh=l8RU4Na8lBBWN8JNbUugbRRKD7vvJG9EfLByvE/hrGc=; b=DrMR8nCr3m0oapr4IQg75SCHkd8rrGV5joWME3RvkUFjQtx1vL+Ccz/yGUPrmYW9fuQF i+y4a9YuImAYp/flGuv7N61G99ph3XNcgLBVXwNp8fRRui4uG2kaRAXCMVFgWOHMzF/F lrrhcns8UF0U7aCRrKibXaXXnBFoKd+zOAdFeHzuOOAl4YJ2pV/XlH2luCKpEteYlHe2 g/O0Yuq0oXeDqxwjRF5iZwv4Lbe2+c52ozxCUFi4bKQqusJBMAbr5bedIIkh5tsz00ua lmJ8Qa+ImXaOY63S8AWoawMEKvAXKhnLKUDwCkvz03c4wLNOHcRz004s2aon3JZFHLZO EA== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3wku1ce40c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 05 Mar 2024 12:25:14 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 425BWS7s031907; Tue, 5 Mar 2024 12:25:13 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2169.outbound.protection.outlook.com [104.47.55.169]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3wktj7r6yq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 05 Mar 2024 12:25:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kfzAj4dFuA9yBumWtfRnnkYqOFwQU7IaZpuo49R2LCZpAi6PYq+rrPT9TNvo68DrXF5ZI7JLIjb9DM1knDsy4ue7y3vP/30N4kNfGE0h3s7wQlfpBCkbtCbxEzlC6lBD1Sq+QZKuMmj/3dQ+SacHJLYVu4EkVLptEisHb3/teqd2LaVLvxeRmzAWwTvyicvlA5aBlLdhHEz6f+fs+5uBKEqAHL8/fOPts4EUlLd03gVEdvl6bjuX23bdT3sbJwIjK7P/1P/l0Bn1bDEsUD+LYih5uD8+x4zKBYvSc7VKHSUUs12EFHEuR5Vn3GMqUXUKQR3jZWrfzW0GAjK7r3VyRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l8RU4Na8lBBWN8JNbUugbRRKD7vvJG9EfLByvE/hrGc=; b=dU1N/oCMOeZgULkaYujEy5BSsaP4xsmEvRlickXgvnaZ6qGGe0SN1IsPwapRzSzKflVlU5bGC+GPit8BhMfUFQGRicYb/aD3McJNuOMbxmLwarafn4Ua8CBZ2extEo2xMMwTtsaHuJYCmcUNh/a3s/ZvMbN02B86crOBFwqNek7gLKHDFzZIJsmcaRL56BVu/Dp5bNDroCbAcJ9vr7HQ7XF+8HUqA7FD1+Trq0B7xfdnjdjeeK0i1ZWOfklFcBYIlm2popwN676Twv9iUfJJ8pv8/TwwuPh/wlimc/LtuwNOfvKz1hAOwKeEW+4YmA4i5eZjZyUS0s2DAoPXpTkUVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l8RU4Na8lBBWN8JNbUugbRRKD7vvJG9EfLByvE/hrGc=; b=r3WUYiA4r3o/zqU0M3SEWxCGQMBGNn83INYopwBDYd4lI9gNstDrsjbxsdC5DKC+YjeONkaK2TFrzBDtSqWzD0fM5rzm3Ju9lCBlOQQYz9sssGAC1JCmnRwGXYwboPmbDol7jrVLJIiB1pYS7HxKaJqY/ek5DJBfU7uPx8zeTzg= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by BLAPR10MB5122.namprd10.prod.outlook.com (2603:10b6:208:328::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.24; Tue, 5 Mar 2024 12:25:11 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::97a0:a2a2:315e:7aff]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::97a0:a2a2:315e:7aff%4]) with mapi id 15.20.7339.035; Tue, 5 Mar 2024 12:25:11 +0000 From: John Garry To: jejb@linux.ibm.com, martin.petersen@oracle.com, chenxiang66@hisilicon.com, jinpu.wang@cloud.ionos.com, artur.paszkiewicz@intel.com, yanaijie@huawei.com, dlemoal@kernel.org, ipylypiv@google.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, John Garry Subject: [PATCH 2/6] scsi: pm8001: Use LIBSAS_SHT_BASE Date: Tue, 5 Mar 2024 12:24:48 +0000 Message-Id: <20240305122452.340471-3-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20240305122452.340471-1-john.g.garry@oracle.com> References: <20240305122452.340471-1-john.g.garry@oracle.com> X-ClientProxiedBy: LO2P265CA0500.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::7) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|BLAPR10MB5122:EE_ X-MS-Office365-Filtering-Correlation-Id: 882b2c1f-b2e4-4c23-5b3a-08dc3d0f4d72 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yv/4DScXgK+tLdnATnROPlkDaDnSJ3ALoHB/Xe0Rj0uWh0ZdyQ1iwbS+Q8Ev23u2z8nAwQGW0GEuB7nsUoPIYSJN/2h8CbkhRv04sVBo3l4xSFvKYxSBcyCYCH+P0T5hCw1zRYHyd8Eg+1Pb6xOiaxPzjSrVTGXBzBBrkbVUgDpiOBFf53pJJ4awZoQXAROR9CjvVCxA3nbU4eI6xYzOHSaGRw9WaNI2BTmZDLYzTIYOKTClBMbe6rOQApVpgezCwEYPN9I6jqGZYpzn/80S2pp89vfO4iS+ZCCIH8TNCRR2RHN70+PGhOEFVqWlljSc+K+OgCmI2+YpEpo8U7iZPk//ZgCNuzWlLni6Or7skRk6qmngySUYoEOMEG/AnGBcBvNPT57pr1AJYiwqVX+MTPCAykeTQxlotV3H9FO0uR9f31c+jO9xsftiqyuuhknw9QfjF+M3x88s84MjR+SG2fqT29xSdxShTyL0CE+MFI02QAWtmYe+LEu31c9F2hQlhU7kYgn2KsduYdXuOLc6bpW7+79NqETGqi/HYgalYDslqGMiXMiDiYCDiLbHY4R65GNHzYWHvay7hgmcXxcO1bNJQ9SR75M2Jb86sMypAIxpqILiA1Bs/rJYJOR8DYQ9lO543v1sQJA2IHOyp8893sHlr7I0rfZyYovUUYgpD1Y= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR10MB4313.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: mn3Js3irJz/cso4FhPRasDxod7v/07SIfWXBuxKU5YrERHPYJWCgMavuWzX+c6+gWFVAIebLAEm3s35nTJRpcWqh41Eh60zsmsvjf97wxMxkOfVtMUGYb3TzrRIrwyrEmoRsiKR3tubr0Ql+UOUqf+HMBXlB7CvCfaEvcuvxD0u12nnIEWZv4mT1P26TTHVB8E7iB6dGgsb8k82zl2ZBJHfIFO1qES+vjXRuEuIqbc5TcV3NBgWTvPMZaRQwoWvuKxaTh9K0d/K0COnSSyVvDA/vUIGnfmYlccB2xMrFq1kI+7LfTqHWvrb2EQj7m/tH4MgpniW48cEtdzfLBfnjopRYHg6x2xoTvDkUZI0UHg0fBn0tbvie3GQkm/mllqTyLKzsUV+E8mT0rMvz5nALjW+NSHG+FI7iZfTUd51WdXb0Rfu+manSMsmHxpHLDkqAJbjuUlvn6KxmMI0cwnm8PIVSa1irxC+lhkFsybWXxcI70My8+I8XECFdqQGg1TFWRpfKV6N0cniadH4KH1l1vQIt08jMQV8kDfA2ThimN3qj0l6oYrqlYgtMuOVZtUtmenaLuzkB59wEmZPgWAgOZ+uMmauR8CbYc1E6v/uHEv5Mifsl899XrrKNQ01k4Ofd7kW/qodof/cOArpzuLm92lrDK91dSEny6nkXW9iEgy9macgqnSUKgyc7nKyoEno6WTf7ajhQ70XdUMPOdALSTZyB50D1cUnbrmddp5+JD2zxV3qlE+87L8NTVYwiISHro0SjuJH6zw677KNkGb+k193aYlR2R/s/wZl76hiLPkceKzYws1tE3i1NRnYKVZQT39hW3fonDTZuYexhjPqHY0YSZ7szNfiZ0A8ZmMdYzw1QpHUDb5FRbvF3D4VALJFOMhNzAwDBV6h7qHiQ/nkTiPKTz8UcYVzbkj3o+QZBArOQT4CzZ38HaPMy0tn1TcK7UAlt2rKdOpFgMy2lSY9cNc6p2AYiW4FMBNbbr6DQGSKqQLdA4S75j9GnqI9VaDMZprbOLsY7habbzgu14IcMXUk0S6O/pgvNzYby8gAgP9ViBDqiNj/AJhCWPDpFT+/fAZzuURdQLhATWdPqvL1Wyd0cP5y3zCvqQe7xwt2Pgc20t/w+OlrSzAcgkiBJJHIAKk2DQCTIQEwinefZuoz3CPhNOMDtVVUPW/zn+FVfC7qd8crYfuozjE66rWbFSUbO58lqmHTQNwn2YXN+vHqGy7vU2oho/E98Z6RMT7fEQu9SEzgX2gwpv7FE6ViR7jqCfAre+IylLmfvJ1wwG4iPLdAGh0jpnc3lhypMAI5I/NyBaQOI9UJ5FTiu5HDIsazawBt4t7TO2U2O+KrNS7gpCV4SPXm39YqElhg6J+EgEHY/3T9SEmIwym/73d/P61nU0ag+KtM5tePsSHF1UKbkTIN6GUeZf5PiKpq86WSw0sREIZXN1YcJiNFszmzWqq2Osjqrpfnv2TWRdXrnUDqWBzRie/fp79AxBXVRAmZnc/yBFx1XLGULwsUeW/2zLbZzaqC80MdgF+4p4Y3T/uO514e06FcCn/mO382cHgjrIlfnQ+seBoNgX0qtkMdjepSLdK4p5RF/2YO7dcD53fFAyQ== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: RbGtAoPNS6u/EmhygYBE63XFzbP7mjMSAe30Dd/ht+j+chnOMXmMWZiYEh/jT99lyivGpiow0MRE2zerZ7LJSSFmMr+Z4fTxBqzCFk1SginBAW5dSqK/jMd+5M5wDXQB60HDqNmcRUfyRMabTucrH7ZUnVPKAF2CD7/9ulKXA5JKzR+y1+dzEv3rVPuxL06hnuXKSp+osePHrMqqxpz7caMn23gIzsfQEU7D5pkgIA0nu/cactOTP1jwgtJL5lUTgzhiIpF0EUIgQfXeVGIZ+LbuGigIPV+9+FuHaKIgu4J81rEK+sQhZqkRwgN7HuENekZA9jxRzaDu5h55xayUH6/KFq4t9W9o0Bnbe4U2jn97CpOSdawbDi0uhi82DXYrfoNpjgd4QBZ3Qv39sUu/erw6goiqTj5keT+fj/N9ko0PCr7aKA3aYS0z/b65YnI1GjJ54XAQYH+Qc4MhOYf8etAOWj9gGLGQ4Q/YcNMhRdVEQ8YfgXSfUouw9y23udaYEGVvQIzbbA+wY9CTOg94cLexLkBNnQ0KH4f4yYkVnWHojaXmn8c3EpLlHMwRzGqnAHT1weWns1FV192QHaRkjElfv7zW3kSbiBfFkAdjG7E= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 882b2c1f-b2e4-4c23-5b3a-08dc3d0f4d72 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 12:25:11.4606 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AOjbYALkJrO43inARfIGPd1/z9EnZ0vydyd8aBUNLs3dw8u7BiUbGclEXTZpnC+UfcwxMaCxsUm8mphbsjUhEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5122 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-05_10,2024-03-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxlogscore=999 spamscore=0 phishscore=0 mlxscore=0 malwarescore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2403050099 X-Proofpoint-ORIG-GUID: Uoy858zjlH4yF3Ib7t1Es0VfOpATfg1m X-Proofpoint-GUID: Uoy858zjlH4yF3Ib7t1Es0VfOpATfg1m Use standard template for scsi_host_template structure to reduce duplication. Signed-off-by: John Garry --- drivers/scsi/pm8001/pm8001_init.c | 20 +------------------- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c index e6b1108f6117..1e63cb6cd8e3 100644 --- a/drivers/scsi/pm8001/pm8001_init.c +++ b/drivers/scsi/pm8001/pm8001_init.c @@ -110,29 +110,11 @@ static void pm8001_map_queues(struct Scsi_Host *shost) * The main structure which LLDD must register for scsi core. */ static const struct scsi_host_template pm8001_sht = { - .module = THIS_MODULE, - .name = DRV_NAME, - .proc_name = DRV_NAME, - .queuecommand = sas_queuecommand, - .dma_need_drain = ata_scsi_dma_need_drain, - .target_alloc = sas_target_alloc, - .slave_configure = sas_slave_configure, + LIBSAS_SHT_BASE .scan_finished = pm8001_scan_finished, .scan_start = pm8001_scan_start, - .change_queue_depth = sas_change_queue_depth, - .bios_param = sas_bios_param, .can_queue = 1, - .this_id = -1, .sg_tablesize = PM8001_MAX_DMA_SG, - .max_sectors = SCSI_DEFAULT_MAX_SECTORS, - .eh_device_reset_handler = sas_eh_device_reset_handler, - .eh_target_reset_handler = sas_eh_target_reset_handler, - .slave_alloc = sas_slave_alloc, - .target_destroy = sas_target_destroy, - .ioctl = sas_ioctl, -#ifdef CONFIG_COMPAT - .compat_ioctl = sas_ioctl, -#endif .shost_groups = pm8001_host_groups, .sdev_groups = pm8001_sdev_groups, .track_queue_depth = 1, From patchwork Tue Mar 5 12:24:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 778239 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 784B35BAC2; Tue, 5 Mar 2024 12:25:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709641535; cv=fail; b=NLRilvpj0jred4Wczi0a0HPknss8DGhINTJ49bmcn3EiU4IqU7A9j+U2mM8hvzyHULb5EI3IOI4SCu0/IXpwWwGHDLIxciODysj4ZgJ//WMn38SSn1o+gTfTflQ3gkWMkRp2WUtH79n4xJELdGDNa8D9qlqY+LOgddpsmugdX5c= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709641535; c=relaxed/simple; bh=SvpvN7SqYiuaL8SbKBFdXmDJS0vxFwJu90qkoBf582U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=niRL8xIYdDt5VF0d9F38BnpGTvyj3H/iAYXpm7c1jd41O4lQGUj/qtXv1/Ropyx0xqS8nbGv7jQ5trmJ7yOiOl22aC86zLpGvNOPyeBd2l1vH3lSIyK06tyt5QlZ+ZHl6YcG3qDXcVJVp/MijTBCT5RsMn7lHCAu/xUBKCJrJMg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=GA7d0Psy; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=CuWYT4PI; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="GA7d0Psy"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="CuWYT4PI" Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 4259hoh1008900; Tue, 5 Mar 2024 12:25:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2023-11-20; bh=13n9ouR2zm9X33sNFnsZjnNWn1NaVlv/mOpl+rAf6Ew=; b=GA7d0PsyFpBFTLGQP9thN64MOnnIp1Fgt6Mv346bNGkpH3S0he4PmrwC9WIcQ5hyqHzy E7KvS0WnbXDl9muyEpb/YhfhuzOuEr3zlxlOQuR3DrIUYx49w6m9Cg3qkVNMlL9EjASB 2kJouyLM9ZHKjeZEjMoQNpK0irWFDtj3jM2eIv0DUELg2x/Jj0Xya//qT+4Dbi3GC7yK aYF2l/ajkX2KTxZFAIcTtlYUDsoJq4joTjkmRtU2L07+Jv+LZ6E9Ys6nmvuXTXpyq4eE 51vY+CVTWls2p8DPV90rkTes3f1o9tGEIusrONG1XbnjffwNj+yIxZihQq+hYDaCONvG eA== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3wktw46081-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 05 Mar 2024 12:25:17 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 425BXZnt012375; Tue, 5 Mar 2024 12:25:17 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam02lp2040.outbound.protection.outlook.com [104.47.56.40]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3wktj7frwy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 05 Mar 2024 12:25:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IDq42cqJRnKFskX72n2BQLbS6c+sxXFdh3CCpdhbpcx/wRxghqu7Cb6XE2WILOBMVBwff+q6j+USVQ85Fd6fZb+hDBNC1Yi6zeg1p5EPGfIGekhm0uC9usmWBn3PVpPKpm7q1wjKYWOCx9128I7H9/dudUyRLI1hHCcFU0gJ2bhtPHXrQQHaYXtS78xEXfwfn4UZCYx1d2tYAoVADHyF263yfV/sQXUqs2HMhlN1vvckyWp2pGuVc1mAx7X6FrErZkh54qIvvgYRhHNqur9IE5otqym064I3qw3ZE+RLjSs41x8J2X/IUUnE52AeuUTQQoPMFs362GYnq5Sau9B7xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=13n9ouR2zm9X33sNFnsZjnNWn1NaVlv/mOpl+rAf6Ew=; b=e7T5+Qxsih9IfCJRr5zqaQFViMfyre+HsNG51T0LjdoqGHP2aYZ1O3njRhL3v22fw2BsDzxTXGei2B27U6CGK2EpXiUD3KCfgWnRWxX4bktkNnwol6A/BIESx6TQ2tqziE7E/vLNvUxDmgB9XbhMFtNuJxcg1eRjSGgxMTxMntpVxEq/s/ryopOZk6O966ARdfjN/H9Ngqdvmd2+1mvkRgPAQ/4UNlyv/75e4bhwJKoZTB3kd2Rey9oyZ61YyqeEWVY7Te2XfPcNfxU7ROL9kDwcHpQZOXt5inkChXD2VWd6nU36/xrn5+0k8sWItiE9Ewz5nM+XonvfMTgVbDdDGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=13n9ouR2zm9X33sNFnsZjnNWn1NaVlv/mOpl+rAf6Ew=; b=CuWYT4PICniRwnp7ydQn/SUjr9uqZGQdIR1FPEimes4OHA/O+YIoUVdo8xlQib625Fekz18zgBqsG0R4sLTXm/uoIVrThdWSKU90E9PlqcLwCV/xZ9IyEmqzsXoacV49AnVuCz2Z6DQCXfGKiXy0ZkDdxg5fNgIfq1FgiAwfJIQ= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by PH7PR10MB6507.namprd10.prod.outlook.com (2603:10b6:510:202::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.39; Tue, 5 Mar 2024 12:25:14 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::97a0:a2a2:315e:7aff]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::97a0:a2a2:315e:7aff%4]) with mapi id 15.20.7339.035; Tue, 5 Mar 2024 12:25:14 +0000 From: John Garry To: jejb@linux.ibm.com, martin.petersen@oracle.com, chenxiang66@hisilicon.com, jinpu.wang@cloud.ionos.com, artur.paszkiewicz@intel.com, yanaijie@huawei.com, dlemoal@kernel.org, ipylypiv@google.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, John Garry Subject: [PATCH 3/6] scsi: hisi_sas: Use LIBSAS_SHT_BASE_NO_SLAVE_INIT Date: Tue, 5 Mar 2024 12:24:49 +0000 Message-Id: <20240305122452.340471-4-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20240305122452.340471-1-john.g.garry@oracle.com> References: <20240305122452.340471-1-john.g.garry@oracle.com> X-ClientProxiedBy: LO2P265CA0273.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a1::21) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|PH7PR10MB6507:EE_ X-MS-Office365-Filtering-Correlation-Id: 20fa29f2-d70c-4aab-f980-08dc3d0f4f6f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iRVE6wzQ04lBIFEkv5ONo8uVIwa2h77vdi6pMobSgE2F5IKvrbibSfgc8nhrdH/H469JQRoHHyDlNul9UieHRGPA/PIYP5Vz6qGvLCPAGSSL7fD/yDB2wCik9QNjwk4LFxVLEaJLFBoSECriTzsr1kLOzw/beGIRbuI0LEwwZM4g4/hFOIx5cB7v/GycTMFCf0V+jfyT5QIqz/KUnCdULIBEU7YjDGfd9cLaqoBbYNQdN1N5uKbvMMRiY/Exf/sgXtVutDETEITff9RXS0Msa62ZCnsjY4iDNx/9JDAHWxlDtRE4ZPVhGFZER6orNxOlh4f6EkArYxBxB1V2JxERrS/YiZqERCoeZhXm0tgiVrXRLLOUooUlCq7lz5gqYkcxz2PEk/M4thouKUZzarGOia0Nq8u5kgYH8y/0an/ezPBp/6/HOielwGV1lu/rRt4/cThWFCOmOMNriyIh+ktpVyjkXDk8EXeVIKTlfXNJekyHwMWAH1tQ3AZ7qodBCgMhhcho12ow+dmo0hrpIcpBRW890lMMEpmxauVs7S+xeADIZC8jATePv1VPl/Z1hfSkzbIOpohEaVVFpBHdlyTJIdNBeEyuZYKKGjSdOMYHOFJArsC0oLQTdtF3kw2UnKT+V7uQzBSoWb9jFqBY5HIqPV/VqYVp2E7i8Toh/yZTaLA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR10MB4313.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: aYuZrTVODFBqJfYb+AFyShrsoFEUjJK5uPxalmZVSnNfpRHdiiZEKVz1b/TLl/bVL9A99SydQ+NpLxpUlUHPXZzdL4QAUnoYP7Vx4/asX5TwzaCmgwR54oIGfwwfkZQf2Pm3ELHEJaCsmmC+Lh5VoQ3aL0PZyz5gsYADJH54A0xIoS+U4rjyvSjz16b5lDUkS1AiqNEELh9/M7HAH+UQL/kUojemxUTcubOiZfZMKkZkoXs3zmRTHLDujER0OmFtHh2o6ryl0sEdGH38bQOaKTo59bBEMMVPiiIGIdgeW2Oo5fmp5TDvNJaAoZA2gKMeVN73lpZ+WBiUTW36453UhSCtLFbgtKaQSwUjtxD57VNRruXLy0KzHimmzXwLfUJf6L1q72hjZdBulnShnmtcHQQAa/d8PeALepZDpiq7wzjf5iBuGV4cQF0ow/Wu3EBY+L+Gu+IjroUtSlwCR9QWQtV4lO4Kxhgp3rqD7N3OEsqZ3As1KeA8lJajSIdlCCYsnWAxrze/eYBSqsuMmd2AXDCYZKnXwnsaEJ1V+evvK3XiJAwdMsuck99coZ0W03KspeYtsSVHtgRTMNKiOQKjJLJGqYnWOommoHYxeJPxxdyTXKRZbDiETwnC7cvD5puBVACxkF9+HOFOSTPlzfAPgvG8zOAynwDLM92am0GMJj1XpTzR4wHPEiSXD646qYfZq4xHo5if5xI6mDMgnaIUxjiSb4orX9wFxvy0uhXc2Y1AXWKl2OKgNCRaE8MZO4O101kM2fCfkgxrs/TpRkEbNucwbwXo1UwvTx1Iv5AMMSKTrcJOOP7tbkiDniEKh9CzBkVHnozPa9ms5TeVGWcZBnoeW4VP4cy0t3/4fTZuMgOY5l+NAJ+nObPD/INTULrjBM41k3raVxudmTwEywCAB/CXTcBsAFL5ihs9W5P2tFel9qi7kYUvjWiDn0sY/wifLV7KCGpwkhvOEYtZz3EkRKki5iaRd5Qalv0Zkoet0INLdTiZ0vSWBTq2h1pIJN7Artl+RDGtCzbW1umqKvGY76NB4SOfGBG3oO3nN3QIfx6XUk+qx8PrjchkFNemLJkv1zHc7LQx4ww5BXXfNgOgVjFkw61S17sqGe5qqqlGTjksiFjyaVf9Iciz9AiU78xH5eQuC4v+V5ln8YNTlQxgK6JIS9yxP+UpfKLjZsRzyDYJkbinGZS6Erw6YhhZTnFh3Db+DWim9VeVMKCwkYDnQVPfcoOeYFu/4jAednefFRALU4dV0SBZTcxndpSrb3dhm45cDWq461zPFa3lpRmpU3ytM9/L+vJW2J8bQCSebIznRsuPNsP+FOXKwb/YpCAxyKsPxwMjwzrmLWG3od/qYtgqVn+lmKSJU8jhlDdr7cc2hRigkxWv8BFjP+BaYVYLKRbDiMnNSHW/GF4Aq+u4M/Cj4uzB5BqBS4pasKsqB/40Bb3N2X/CwjnskRW5BuV0oe4szoLA7Z9aiNvzNpYUKe+QFfZlEYMz7sGpbNJ/8Njm0/RMLAiMB815u8Hlo8nnuQLDbYDqX9PXmxxcatKqO0dZFRnK3cL5CRw2vIP6ZnZiBG+C5Uso11EZLxuZL2O9M+JhQtMoq0O63OWcLhyqJg== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: uAkX712/xQrIeeqyZV3lwbbiIcr9g2NCtRUwIhmkYoWRPwJsKXXsJ7GI9/6Erg6wLXaA9QJWtfUtNnKKH5cbO22K56B3du0cHKntfdr4q3dW2nZgdhN1E8EBFIcSvf8x36N/cn8um3vfSbpJ01zoZQ4Ws5VWDkEuVf0ulFpDKkGA2DhT0R5C/oYyL4skYbseZZ1rsTuOuJFolTG/R++cLZQhdcl8eyRSJ35S84S1YwdaEE7hFt6VHymdhPUiyLfbQ+KUIS2AKq7Hk7IQo3YpD8WwiU0vS/BDcjnWv3yzrxAcuFoC2CRPsI4m15goE1oRJDkaLdf7zRNA8+Ct5aIiQW7gxYkItFsg+DPMpeml06JEEjiadPJ063IRX9ogiyeSZ3otdOJWQJB2jumwmmlY4LPBhMUm9HUSRwqIpFnbp94O35gXF28RJC3cAqu1JV15fhzYYutTyTqDtT5R28cdmHAds3vA9objsV3kXMlkQsHYUD3iETUA0upJCstDR2QvPWmyLjsApZuJYi6r1Kc9aXF3qojhhIHmSeMjSWIeOANdSQYCxH4TaeUqE1Ou/IRI+OcY1QAm0lqHmrWcWP6CCnQHIJ9KQk4ujwUFAkw9CCw= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20fa29f2-d70c-4aab-f980-08dc3d0f4f6f X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 12:25:14.7325 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Zqx4x1z3HfLJlBbo9/MweGrujMMKGUKxMKAUr4YEunN++MUbJsA43OFNis2QVMsUOrtnQh+YDYtm5NR7BdSRSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6507 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-05_08,2024-03-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 adultscore=0 bulkscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2403050099 X-Proofpoint-ORIG-GUID: l2VgYEvPw5ihwECjbr3R24HrA6gcWAXU X-Proofpoint-GUID: l2VgYEvPw5ihwECjbr3R24HrA6gcWAXU Use standard template for scsi_host_template structure to reduce duplication. Signed-off-by: John Garry --- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 18 +----------------- drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 18 +----------------- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 18 +----------------- 3 files changed, 3 insertions(+), 51 deletions(-) diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c index 3c555579f9a1..161feae3acab 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c +++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c @@ -1735,28 +1735,12 @@ static struct attribute *host_v1_hw_attrs[] = { ATTRIBUTE_GROUPS(host_v1_hw); static const struct scsi_host_template sht_v1_hw = { - .name = DRV_NAME, - .proc_name = DRV_NAME, - .module = THIS_MODULE, - .queuecommand = sas_queuecommand, - .dma_need_drain = ata_scsi_dma_need_drain, - .target_alloc = sas_target_alloc, + LIBSAS_SHT_BASE_NO_SLAVE_INIT .slave_configure = hisi_sas_slave_configure, .scan_finished = hisi_sas_scan_finished, .scan_start = hisi_sas_scan_start, - .change_queue_depth = sas_change_queue_depth, - .bios_param = sas_bios_param, - .this_id = -1, .sg_tablesize = HISI_SAS_SGE_PAGE_CNT, - .max_sectors = SCSI_DEFAULT_MAX_SECTORS, - .eh_device_reset_handler = sas_eh_device_reset_handler, - .eh_target_reset_handler = sas_eh_target_reset_handler, .slave_alloc = hisi_sas_slave_alloc, - .target_destroy = sas_target_destroy, - .ioctl = sas_ioctl, -#ifdef CONFIG_COMPAT - .compat_ioctl = sas_ioctl, -#endif .shost_groups = host_v1_hw_groups, .host_reset = hisi_sas_host_reset, }; diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c index b5d379ebe05d..d89e97e8f5c2 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c @@ -3567,28 +3567,12 @@ static void map_queues_v2_hw(struct Scsi_Host *shost) } static const struct scsi_host_template sht_v2_hw = { - .name = DRV_NAME, - .proc_name = DRV_NAME, - .module = THIS_MODULE, - .queuecommand = sas_queuecommand, - .dma_need_drain = ata_scsi_dma_need_drain, - .target_alloc = sas_target_alloc, + LIBSAS_SHT_BASE_NO_SLAVE_INIT .slave_configure = hisi_sas_slave_configure, .scan_finished = hisi_sas_scan_finished, .scan_start = hisi_sas_scan_start, - .change_queue_depth = sas_change_queue_depth, - .bios_param = sas_bios_param, - .this_id = -1, .sg_tablesize = HISI_SAS_SGE_PAGE_CNT, - .max_sectors = SCSI_DEFAULT_MAX_SECTORS, - .eh_device_reset_handler = sas_eh_device_reset_handler, - .eh_target_reset_handler = sas_eh_target_reset_handler, .slave_alloc = hisi_sas_slave_alloc, - .target_destroy = sas_target_destroy, - .ioctl = sas_ioctl, -#ifdef CONFIG_COMPAT - .compat_ioctl = sas_ioctl, -#endif .shost_groups = host_v2_hw_groups, .sdev_groups = sdev_groups_v2_hw, .host_reset = hisi_sas_host_reset, diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c index ebdfb7e7c88d..756660588a1e 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c +++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c @@ -3320,30 +3320,14 @@ static void hisi_sas_map_queues(struct Scsi_Host *shost) } static const struct scsi_host_template sht_v3_hw = { - .name = DRV_NAME, - .proc_name = DRV_NAME, - .module = THIS_MODULE, - .queuecommand = sas_queuecommand, - .dma_need_drain = ata_scsi_dma_need_drain, - .target_alloc = sas_target_alloc, + LIBSAS_SHT_BASE_NO_SLAVE_INIT .slave_configure = slave_configure_v3_hw, .scan_finished = hisi_sas_scan_finished, .scan_start = hisi_sas_scan_start, .map_queues = hisi_sas_map_queues, - .change_queue_depth = sas_change_queue_depth, - .bios_param = sas_bios_param, - .this_id = -1, .sg_tablesize = HISI_SAS_SGE_PAGE_CNT, .sg_prot_tablesize = HISI_SAS_SGE_PAGE_CNT, - .max_sectors = SCSI_DEFAULT_MAX_SECTORS, - .eh_device_reset_handler = sas_eh_device_reset_handler, - .eh_target_reset_handler = sas_eh_target_reset_handler, .slave_alloc = hisi_sas_slave_alloc, - .target_destroy = sas_target_destroy, - .ioctl = sas_ioctl, -#ifdef CONFIG_COMPAT - .compat_ioctl = sas_ioctl, -#endif .shost_groups = host_v3_hw_groups, .sdev_groups = sdev_groups_v3_hw, .tag_alloc_policy = BLK_TAG_ALLOC_RR, From patchwork Tue Mar 5 12:24:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 778238 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FDC25A782; Tue, 5 Mar 2024 12:25:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709641546; cv=fail; b=Aiu7OOAO/wg4ypwGlwJsfN/Hbsl9IlDhMJoa/9zfVIEwSsBWA6SVGCwYZ/TK7+CUpjXIvpseQ5qt1Jv1iAVQxJDautqm0pyp47mZCCV/Nuz3CzN1O1XyMrwo4mJ/lVMIBgusi2LMkCEx1D1OdQRQXnXSukqw3KmYBXetSHTBzDg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709641546; c=relaxed/simple; bh=J+HUoIPe64MNmCWEjIY8rByj/JZdON21xNbDlAMXEPk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Wd3xXTnE+6y+tv0+gPK8fTkFRDrh5J1LPkawM08JRDqijW87++wCR2N2s62/xum66xhcsoTP8oDbvBXXjrqcwKAMaxaQK9WaubeGJbX79cAn8DiUKly7huwQN5Y1Nc/Sb/yaJdAHUcmDvCeRaV+8ZdeAcM443m+VK6BLqFt/m4c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=dPbnjh56; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=wFFR2G7Z; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="dPbnjh56"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="wFFR2G7Z" Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 4259hjct008661; Tue, 5 Mar 2024 12:25:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=corp-2023-11-20; bh=xYkRLZfVHfuOdW6TM0xPCxKwhxhbBH+gJXagOvV95Mc=; b=dPbnjh56J9ZFVQy8EDwjz056ZCwBocUy+4oVvCRVg2OwQbn3zjblg8X/IgwpckwI0KIE XmB7KUjeYxfSv7x1zKpUi7svLHnChQrMeGwspJim4RKy100XNq3FdbuLWmwIP0KfPYmR SipIcBs160NLixtY+m7TGnROJoaN0ZXfczS4E+TfOUEoLxq7Ov63kD+UK3eIcn/4ljq0 lzmHiFJ5uTBPvRl9+I0MQMBir+v5zZogkYlrnHKuqFQmd+9KYaaH9X0pbZNdIhvrPYgu 0hiJUXcW8YzcWFqDRwrFTB1nYmTuOrtD3sfF5gdOTq5PqEPaYFsTFCum34Wgierp+BsZ XA== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3wkv5de71j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 05 Mar 2024 12:25:20 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 425BXVtD012259; Tue, 5 Mar 2024 12:25:20 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam02lp2041.outbound.protection.outlook.com [104.47.56.41]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3wktj7fs0w-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 05 Mar 2024 12:25:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OzcERrKe4yE7gqgIEJCCKlRws0k232522Up3mhQ3f510AekJFoE4rc+SmEjWLaS+zQiV1i1J6CeMWL5xqHIfx7LJpP4IN0fAjtXhGkLgtrWFeydEf2kQu+2CsJGE2i8KLpNIS+qGb+4+jFAHtvRnpBcIddmTt0UB49rIGVNft+dz9SdAP5NX0SJleMSSC2yMFPr09vEjuWBoR2hmTFdIdlHH3T/RZpBYgig1CcKLrNz735w7dhKKeE6PtSE/bEOIMHISOQC5bdxZ1Zit3rxQizxwJfetBkZw3nJ+XSPNb2DfuG8wxiTCgBB2komdIVfamoLulRxfDJLexU7TKeLK2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xYkRLZfVHfuOdW6TM0xPCxKwhxhbBH+gJXagOvV95Mc=; b=KujtxEueg1BUcUYIyjjIkM/ElJGqScxl46USc6w8GlnPQF+JakIx2iAlNUHWmrYZ+MdtELCQQMx2cttuqKAArTIQR7kQxmPwSJkwRguE2n7JjLUuRf/V7IvR8/0LURQ/p5mw/UvQvpE/Ajz0wf8KbHMy7AjVFAZfLnuXyXzoiobH7wNLeKgWtD8eu+i2mBS4GvuxF2fMh/8JGrRzFR7d/k8GMMmhL1gAS/eKGLb/iSI5dBu9fkIhzsOEF4NwBiIwTu0kn1K/EuvNOR6FFoXhU4SxNj2OcG/PV57YUaepvCiiUj1HMtgcEarZF7FCTjvIHc7+uxUsl5yrz/a8oEIwaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xYkRLZfVHfuOdW6TM0xPCxKwhxhbBH+gJXagOvV95Mc=; b=wFFR2G7ZmSTiQtvbFhQl/+o45e87KoICDs76jBn0i+eTTx59wJI2YkjHwRSB5Mabzbvg+nZWNnoGhcZCw0yw3dHIF+hYoliVKPKYAhiiUOHQ7qP4HpAMAhiO457abwvPxEaS0vPZgcyFnGcXjnWQSKBJX3ebMrOKbxWmqBpNLOs= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by PH7PR10MB6507.namprd10.prod.outlook.com (2603:10b6:510:202::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.39; Tue, 5 Mar 2024 12:25:18 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::97a0:a2a2:315e:7aff]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::97a0:a2a2:315e:7aff%4]) with mapi id 15.20.7339.035; Tue, 5 Mar 2024 12:25:18 +0000 From: John Garry To: jejb@linux.ibm.com, martin.petersen@oracle.com, chenxiang66@hisilicon.com, jinpu.wang@cloud.ionos.com, artur.paszkiewicz@intel.com, yanaijie@huawei.com, dlemoal@kernel.org, ipylypiv@google.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, John Garry Subject: [PATCH 6/6] scsi: isci: Use LIBSAS_SHT_BASE Date: Tue, 5 Mar 2024 12:24:52 +0000 Message-Id: <20240305122452.340471-7-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20240305122452.340471-1-john.g.garry@oracle.com> References: <20240305122452.340471-1-john.g.garry@oracle.com> X-ClientProxiedBy: MN2PR08CA0026.namprd08.prod.outlook.com (2603:10b6:208:239::31) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|PH7PR10MB6507:EE_ X-MS-Office365-Filtering-Correlation-Id: e64776bc-90ea-4583-32aa-08dc3d0f5198 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5T0qAOpx8LfSztoB4yOS4i5O6QkTuAnld7viA8SwdIEiqy6kknHuOfWxsLmBzVdssgZFVDll49KaUpyDNfTbRDEUDDQeQcDnCVC77fZ8WNJ6jXNEdAOzexWCf63DL9RPjmzbZzaqdBW4+LnPq4obi2OHMozVwP++SIYRlddoiKiLwcIWCJcazXJvutd+Nc2cSDf4+RLo42r8zPDq/v0+9NkqycqHvoY7CBfczOx155wEaTaxZAI44UTDjkliN2QiOavlx0Qf9MsNt4ZEwLyzmlotEF07EYsEi9FZADPfpbP4eCaCmQ+AEaqdhNbVDzTFN8WnsghuHEmq9DK3REoWO4zX4c/RDD3cBD6F5XuKiDj4I1aKYjPJoZ2P7LEYM4qh7+yZfzKLaXejlVx2DaAX2cF71FJ5+DLuWWcdvwqDYETYiwMty4WL9nXwi356F/Q2zGUGb6HSFDfLeViU9AiTl3oqBd6zWNRBzE8cYZvl3a8rS5bT0uajDiHgZytb9NGMl/xOnI0j8NrchzbVrHEDjjd7xS1UrvPhdLVvRJUaCjyT7/L/fpYApbUDGtyiM9CgvoUdI1jnZApVjr2V87CkAMiB+cb7BsiV0eA4bqpy3vzwbzj+kd9DUT+RxMqzxynx6gz5G/C7jh7sp72U9UNwCNUdM8OeOMMqzKXjszQZZhE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR10MB4313.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /k8W5kMu9Eft4cw9iVFqMmUjMKpznYFEGgZ1y+9F1byRvQlTL5qEpeioIUcWJD0OxrdjZ5Rlb0qKLgS7JZ3EoHAqekR8LhWSY6OyCHvI+5CyN8aSklkL+qz7XSBs3ai9cPH7neYJb7GjuLYwmcBVXn4YD0OMAg4HMgp5RhEB129CbyB+OrkzwpDH0mfrAPTsKL7RIY2QwFshOReQZ908vV9NCexn8x3gHl/2/979BVBNwnxmvwVJhUoqvgWyprjWATVO3FkkP9RXLsL8P1Q1WsSb12NfJCs9Ci8xkVVoBn3qi3lelA6LHS2EGdpXNX2qt/qwBIMWG3nyuM9kBu/xjPfm/7+PAKl1zm9fwLTC2gVCWyYjeslkypSkqQSnifDDV85XpfvLmyadmTJonMdsw3fruhPbLPGYOerM3MKp+4XZYHL44C7qBppFUE2De5zqLhzybOkKFcYmU2mRN+Ud2vKVsS6grlovjPubJ60Tx9NYQjd29WWrxF81fUO6/JwgobtphXfiy8AygdvXmEsmaOzItowftEswGjUql+swkbmBxd5dxR/UO5x6+kzuMhlC394GZ2eVuqGgFbULyqBr6qagsb88zvKxqTit3IMHQeYfSqfLF5uPP/xPo4IPowkC/AzV2inLGfl4SW4nEFlHT3uHusClzKvXWvlaT3qccmkcbUbJjZgKND+3N8UUDfCpWQf8kHM6xaZ2XH5hrA/IeSjWp3zJvo4arhTQluUifDV5Y9paNahu2zdZoihzNwj7F29JoxfMX11yOWJwwqkqhH/jQwGzHaT+1vc8g70Rf7gqeXY6scKELNYyewV06YIN7l9qMI6egh1gpXHFI9bQ3swxx4O6gw7uNM8lXjgZOY9DCg4NdzdBvjwBwb+zTwy1Iq4NWTbks2meW7X6li9XNw6U5o2BlFGXGKpJ7/SMWzAqxXL2E95nHg9uzZy7+HdaeIAP1t4Da1eT53sXSo4AZVwOcKxK0JqY8J+BPb+hhtBZrrGydJ8A/eOe73S6qfTXaHVl6KeF1uRaAy2aAmGNQrbD5nzoD6Zyj54eUNFqZ04oovq/TT3Xq7vGTJHXHY0XQ6i183zRB49KlY+c7LVlWLtD2uZuNtvCohNrrUL1tEQrd1tnV+/tYGHJZ/ar2pLa6iILg3K7SWCDl4wHEwbkLARqtfV8Y81+4T+ox7TbPHBpvYQECSQ9+SNTOLsbntMBXByin3xg6s/gfICGnj5Zsou0RjOogk0LChNuDZqGEWWZqL3B7fbvREDwGpmuV7ZcQdVdlJ3XOS5wVxhZG36z2BCQcS1/KUsK7EuLJkuAjjWFZWibU+S6WqiokDfXAyK3X+2l6c+DlC8ZASXKtxGGSgJXwSb5IPNjf50L75gXOamC6ledgZTlUyuxRI7Z2/V+aj6qLelLsZd2x3xMqv392kf8TNXtw45soXlCvRTju3m2YmwM/UtVszpKdubNUIOWe3g0xVWqHu4jrth4aSxueOlfkGCUmkZ7DTZLBb0SNdHq6kCbBQs1OsKkGS1uE54s4zdfrlXeusbNfT5uIepQYKwcvyyxRwruOB+yPeL/M53UGVS19H+BYIeC61FxElXQSqHtbZl3VZl8R3zD2wIhPQ== X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: /8LRxD4oIsLJwBx3RqsFLawrDtWiuz/batX0NFVAx3K4ADvhSzs2CzVO8kgd+g3eI1iTLp/MObOHPjaQZVDcv3dNMh4PosBs0aGiCM8/mz9jawuZEjPAebrM5z/5u2NhhLiStcvOlKhG0ofnRS0AHzm55B97PePZqNaWPokKQH+SNZZC2s0DNdXit5GpZxlwLmH3yZIplS4uklLK1CAwT/TPFuoU2x+KMTelQD4vQ9EduCAmZ9KqrBjSIaTAwRH+riuJL3DR61NFlDbH5e9ThcYU98zkWtipab/plieT+undawnOUxeb0M0ANhH/iSiSKrrbg0T6IsnOxkc4wsoVd0r+rqvKXkOqADfLT4c7xXzYL0/LD24b+KTwdBT1x9N4sqBSPy07tov5OtRjV7HQ81sZSPHfHlZuf1pd/WTQ2bq7GTgzkxK6Dj0ggA2GvmUT3eBoeEJF6tQuEz2m2tup5MRkij8BjYVEt2hbDJCVlTwKtRZocYkdtLG+F102ipzRlPMQH3gvcIUjNpUJmwFjqTz1t+vcUkuc+HVRVUGAxXZY2WXRBw5++KGUj5kwCv8zhNVn6VGW8NgVEJcdLWOZRC5oloFNxWVUBUfb/OjvuE4= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e64776bc-90ea-4583-32aa-08dc3d0f5198 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 12:25:18.3601 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pdCZsxaf7lN3naFQh88WOKc8Dsf6MkjoPt8a7B6X7IVqmeG76MHpHG5SIQwNhaK2829jbWgTYxWn/BDp7/egxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6507 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-05_08,2024-03-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 adultscore=0 bulkscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2403050099 X-Proofpoint-GUID: DLiiPi_zdNVt4UyX5_Cjg7HAtaBuvdnQ X-Proofpoint-ORIG-GUID: DLiiPi_zdNVt4UyX5_Cjg7HAtaBuvdnQ Use standard template for scsi_host_template structure to reduce duplication. Signed-off-by: John Garry --- drivers/scsi/isci/init.c | 22 +--------------------- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c index d0a23ce4afba..49e64232def1 100644 --- a/drivers/scsi/isci/init.c +++ b/drivers/scsi/isci/init.c @@ -155,31 +155,11 @@ static const struct attribute_group *isci_sdev_groups[] = { }; static const struct scsi_host_template isci_sht = { - - .module = THIS_MODULE, - .name = DRV_NAME, - .proc_name = DRV_NAME, - .queuecommand = sas_queuecommand, - .dma_need_drain = ata_scsi_dma_need_drain, - .target_alloc = sas_target_alloc, - .slave_configure = sas_slave_configure, + LIBSAS_SHT_BASE .scan_finished = isci_host_scan_finished, .scan_start = isci_host_start, - .change_queue_depth = sas_change_queue_depth, - .bios_param = sas_bios_param, .can_queue = ISCI_CAN_QUEUE_VAL, - .this_id = -1, .sg_tablesize = SG_ALL, - .max_sectors = SCSI_DEFAULT_MAX_SECTORS, - .eh_abort_handler = sas_eh_abort_handler, - .eh_device_reset_handler = sas_eh_device_reset_handler, - .eh_target_reset_handler = sas_eh_target_reset_handler, - .slave_alloc = sas_slave_alloc, - .target_destroy = sas_target_destroy, - .ioctl = sas_ioctl, -#ifdef CONFIG_COMPAT - .compat_ioctl = sas_ioctl, -#endif .shost_groups = isci_host_groups, .sdev_groups = isci_sdev_groups, .track_queue_depth = 1,