From patchwork Thu Mar 7 05:46:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manali Shukla X-Patchwork-Id: 779361 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2069.outbound.protection.outlook.com [40.107.223.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82F161BC3F; Thu, 7 Mar 2024 05:46:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.223.69 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709790411; cv=fail; b=NV5r079ivq83ym2lK/KBGqMbcKxCkVIDA1ymZuS7xp3V8prvAsxius0a2YTmkgfNK6D8VAmXNgwvrU3ynSBbwucbAhFfE7eZRMS6bLoiLl7BineO6bAWp4msYygh/fTZiPkR2MbYJJS3q0exEVOTZVR45mu22jHaTHXBy8BlCbo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709790411; c=relaxed/simple; bh=p66pOu4hk5yPz5/RDqTvRaO7zFdqQSYsEvygh51j9vc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=eQX/qJ2oik3Wust28ScrjM+eqUaMbYaqnGHOeQwiTrI4vFAyPS1VTNeXknAdD/xSZJ9VesuVgdx7wa2z3GclMlttMws9cmN9M+NtzWtWMNF8Q1C39wIwOC0n43b3P7M39RNzxoF23L7NXoEP8S63zVBDUH7KeMXrV1x5BpWHGRU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=BvCBI3+c; arc=fail smtp.client-ip=40.107.223.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="BvCBI3+c" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ElWu2w8M5mrXaUI5LGnr7EHMmkapNG1NpdrwJpk04zKRIB8ND8AVjDTpMU3khoRBjMgejjZqiWGRRwlbyMPvB0S7xGmPGYFw+gZ+mX0DxMspkaH+jW6Ta4X5NidXUgXiq3G8N9w1LK2vGZPR67dUDiAzjTJmnLJb7cL/09XPDV17HTjcVI6FwkYEG8l92Ojw93vnaS1Gcp10yFHjunnFfN76XP0SXcBQSA17dcce6AN23/yJUmNyVwrEMvkT9CrmU1inY7Wlwsas+OLrwgck1g+Eir9kKFs8lKJpdEulA5B9tZ4SEZUHNtkmA6VJFcehxK2ojeDAN1f8Y4e6FFgTsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+GSbtpFp+P6NxHWqU8u4qAbccBZRsl5v+noGEr96OTQ=; b=n60sygavI1euT+dHxfAmaSm8oNj/eeRMQc2bY+kOch+9GsOUT2r3KHVs7VSzb6eR1RVw8UR31yoEGustWhyjSLmOCmFTUnR3WzKMuE+ApstO5YlKoLp3zYBh6PKmIQpfOlJbFrbn0o2K4J0qhjPcLaX3FPgIn+FfzxazzlOnFRk1GRheVwRjI6bphN3H89pw1MakXlIYPq4Mp6FmmoWDku6lEgPI4nK7CIrJt73DgYTV2w/9gu4RtrI8+Awa6b6hl3Nmh9ho4Bzfim0R9lrArA1ffwggfuuwuFRZE4G5TafpYjuWlpunwPO4HF+q9b57rrdDILtreQ/3IIQtTyIWTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+GSbtpFp+P6NxHWqU8u4qAbccBZRsl5v+noGEr96OTQ=; b=BvCBI3+cf6c4Kn4RgDVu0WwFTztIpAIfe6EDOs+qKokmB57+M9rL35yMSCJQJlM1fttGf6Kw7Chmu8nmkuZtjDxF5/Qt2EqKNdXTAPXnkJdJ/CdiyYB6xycHS+FKdEATVUpFYbIwyPkgXwk62wz2hLSysuYie3hTTeciB11rYa8= Received: from MN2PR05CA0007.namprd05.prod.outlook.com (2603:10b6:208:c0::20) by CH2PR12MB4054.namprd12.prod.outlook.com (2603:10b6:610:a6::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.24; Thu, 7 Mar 2024 05:46:47 +0000 Received: from BL02EPF0001A101.namprd05.prod.outlook.com (2603:10b6:208:c0:cafe::f5) by MN2PR05CA0007.outlook.office365.com (2603:10b6:208:c0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.26 via Frontend Transport; Thu, 7 Mar 2024 05:46:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0001A101.mail.protection.outlook.com (10.167.241.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7362.11 via Frontend Transport; Thu, 7 Mar 2024 05:46:46 +0000 Received: from chalupa-4a00host.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 6 Mar 2024 23:46:45 -0600 From: Manali Shukla To: , CC: , , , , , , , Subject: [PATCH v1 2/5] KVM: SVM: Add Idle HLT intercept support Date: Thu, 7 Mar 2024 05:46:20 +0000 Message-ID: <20240307054623.13632-3-manali.shukla@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240307054623.13632-1-manali.shukla@amd.com> References: <20240307054623.13632-1-manali.shukla@amd.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A101:EE_|CH2PR12MB4054:EE_ X-MS-Office365-Filtering-Correlation-Id: 3ec768e0-924d-4a47-5aee-08dc3e69fa1f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0Ov/I6Wff2X+VB8ggPYOsCeFJbHGrlPcBS8w+0+NWcH5i9FOmiB9oYqtng+sYRZC22SYxYF1MCzsmH9C2SiovcTQdLpOijdAPefBoqGkWIk5OaWneEtfK/mnmEUtgif6XUFH+x27wJwvQ6dSD1s/1n4UtG7abqNEp34015fMEjrOZgfmKRvKiNw6Cav3+g8jkqv5shB7NXKA4FJL9B7aGSEjs2aF04a7f/k1/IW6OBwFlZTXgWZfzyz/zL+Ja7Z67QxNaN7Xu75LErI8rj+KNrKc0zn+HiYXH/9whyrvrw3maGmqslXP8XDxFwEUcNW+dmt/rHXKJH8V+fbG4Lk8ymOlmtMCa5hjbgsGD17jWOtPEXqkMP3CH8qguiIXmXHqi/Ad/bXIuswe4bG4RahdHqg2wdsa1Zv2rl2LOko+uN4VulEe8hqQBZWj5es0gbqNOR32k9w5q0BFzz4Thvsf6sN4NJ0ha3UURJpk0eyMA0P0ejijgbb4Gnw43Vcgulb/gkkqXTItd6gC7/28An9G7Y88ZEJ9rk5ecnAFfTbJnrCs/juCFOrxG0YZk68BjPn/oJ0WjiWvtsTuPWsFuBG1Nhic1r/G6M+e8j2pBFpLKbRQaQlE+damcR9+3kM105Gemw8qS3SzkTfg12M024Lu/y9g2/xOHnYLlYSeFDi8lXclf0d2xreod3gp5x3eXix2CUlVImmuU5hKhsX4zabzmtJEyrS8jLHIA0G9/KAbFU8VJlibcAlRpofEUUTNiNTd X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(36860700004)(376005)(82310400014); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 05:46:46.8146 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3ec768e0-924d-4a47-5aee-08dc3e69fa1f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A101.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4054 From: Manali Shukla Execution of the HLT instruction by a vCPU can be intercepted by the hypervisor by setting the HLT-Intercept Bit in VMCB, thus resulting in a VMEXIT. It can be possible that soon after the VMEXIT, hypervisor observes that there are pending V_INTR and V_NMI events for the vCPU and causes it to perform a VMRUN to service those events. In that case, the VMEXIT is wasteful. The Idle HLT intercept feature allows for the HLT instruction execution by a vCPU to be intercepted by the hypervisor only if there are no pending V_INTR and V_NMI events for the vCPU. The Idle HLT intercept will not be triggerred, when the vCPU is expected to have pending events (V_INR and V_NMI). The feature allows the hypervisor to determine whether the vCPU is actually idle and reduces wasteful VMEXITs. Signed-off-by: Manali Shukla --- arch/x86/include/asm/svm.h | 1 + arch/x86/include/uapi/asm/svm.h | 2 ++ arch/x86/kvm/svm/svm.c | 11 ++++++++--- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/arch/x86/include/asm/svm.h b/arch/x86/include/asm/svm.h index 87a7b917d30e..68ff0855a77b 100644 --- a/arch/x86/include/asm/svm.h +++ b/arch/x86/include/asm/svm.h @@ -116,6 +116,7 @@ enum { INTERCEPT_INVPCID, INTERCEPT_MCOMMIT, INTERCEPT_TLBSYNC, + INTERCEPT_IDLE_HLT = 166, }; diff --git a/arch/x86/include/uapi/asm/svm.h b/arch/x86/include/uapi/asm/svm.h index 80e1df482337..9910f86a2cef 100644 --- a/arch/x86/include/uapi/asm/svm.h +++ b/arch/x86/include/uapi/asm/svm.h @@ -95,6 +95,7 @@ #define SVM_EXIT_CR14_WRITE_TRAP 0x09e #define SVM_EXIT_CR15_WRITE_TRAP 0x09f #define SVM_EXIT_INVPCID 0x0a2 +#define SVM_EXIT_IDLE_HLT 0x0a6 #define SVM_EXIT_NPF 0x400 #define SVM_EXIT_AVIC_INCOMPLETE_IPI 0x401 #define SVM_EXIT_AVIC_UNACCELERATED_ACCESS 0x402 @@ -223,6 +224,7 @@ { SVM_EXIT_CR4_WRITE_TRAP, "write_cr4_trap" }, \ { SVM_EXIT_CR8_WRITE_TRAP, "write_cr8_trap" }, \ { SVM_EXIT_INVPCID, "invpcid" }, \ + { SVM_EXIT_IDLE_HLT, "idle-halt" }, \ { SVM_EXIT_NPF, "npf" }, \ { SVM_EXIT_AVIC_INCOMPLETE_IPI, "avic_incomplete_ipi" }, \ { SVM_EXIT_AVIC_UNACCELERATED_ACCESS, "avic_unaccelerated_access" }, \ diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c index e90b429c84f1..a08a53508469 100644 --- a/arch/x86/kvm/svm/svm.c +++ b/arch/x86/kvm/svm/svm.c @@ -1289,8 +1289,12 @@ static void init_vmcb(struct kvm_vcpu *vcpu) svm_set_intercept(svm, INTERCEPT_MWAIT); } - if (!kvm_hlt_in_guest(vcpu->kvm)) - svm_set_intercept(svm, INTERCEPT_HLT); + if (!kvm_hlt_in_guest(vcpu->kvm)) { + if (cpu_feature_enabled(X86_FEATURE_IDLE_HLT)) + svm_set_intercept(svm, INTERCEPT_IDLE_HLT); + else + svm_set_intercept(svm, INTERCEPT_HLT); + } control->iopm_base_pa = __sme_set(iopm_base); control->msrpm_base_pa = __sme_set(__pa(svm->msrpm)); @@ -3302,6 +3306,7 @@ static int (*const svm_exit_handlers[])(struct kvm_vcpu *vcpu) = { [SVM_EXIT_CR4_WRITE_TRAP] = cr_trap, [SVM_EXIT_CR8_WRITE_TRAP] = cr_trap, [SVM_EXIT_INVPCID] = invpcid_interception, + [SVM_EXIT_IDLE_HLT] = kvm_emulate_halt, [SVM_EXIT_NPF] = npf_interception, [SVM_EXIT_RSM] = rsm_interception, [SVM_EXIT_AVIC_INCOMPLETE_IPI] = avic_incomplete_ipi_interception, @@ -3462,7 +3467,7 @@ int svm_invoke_exit_handler(struct kvm_vcpu *vcpu, u64 exit_code) return interrupt_window_interception(vcpu); else if (exit_code == SVM_EXIT_INTR) return intr_interception(vcpu); - else if (exit_code == SVM_EXIT_HLT) + else if (exit_code == SVM_EXIT_HLT || exit_code == SVM_EXIT_IDLE_HLT) return kvm_emulate_halt(vcpu); else if (exit_code == SVM_EXIT_NPF) return npf_interception(vcpu); From patchwork Thu Mar 7 05:46:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manali Shukla X-Patchwork-Id: 779360 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2046.outbound.protection.outlook.com [40.107.92.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD65A1CA81; Thu, 7 Mar 2024 05:46:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.92.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709790414; cv=fail; b=PVwFrkb90XFXFcpVqfDmjwGnM+xc5kLu0reV2BbU0/dfvxashDRWTK2SyQJsbICTd0odfZ23stdp6nMLVR9BOM4BvUfQ2T4sEos3egJv0LYFzjtwBF71cKM9TDzvWwO71QUVwhjyMGVlPV9GckkX2NYEPnC3jxj8Ov134YdI7ks= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709790414; c=relaxed/simple; bh=c0qqNCoZ1BjWCamzX8Wj0FI8tw5sFKTIc977NKQ/RAo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=M9zVN7qGKz4qAAIZ4OguUFEn5L81fBIjprXaM4yOKSX9HH30PsEdLkwfjCV+QhLKn9DvN3bV+qgymXWZUwnrQBTDXgRhoU22F/FawoTBovrsX/1LI2WYkfRnR/dErafDihiyvGPjZyesQkMkHR4FNvRgx3WBhVfK297Mdcyilh0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=Lzibkzoi; arc=fail smtp.client-ip=40.107.92.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="Lzibkzoi" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CRuistx740COSSwjvgjBNSj5MY3WQNjAwxZW7wcpaPENramivCF3X545/Brxm2SM3sU4QggxBqofPaqOzgveA2aEu4N2mH+2mV9dI0QOm4/s4ys+9NG9Oeg0q+Jd95iRL7nPkDfsXB3kpGV/r9Z5hYKlrs5YIbnsA1UmtQzYysex7QC2pArsS3ucbr9emmOf9BEzGoBkAJeh0fZ1Wf47MLQWkxq7/C7R3ijbmlXeFgELd3nBBlmOBpVMBfZv72ZKprG5s8AAXvAvfLU4+KZSbL8nlZb6tlwF+lqm77K5rmhJJ/9Fsrk4t8yJYnPUPo9ibQWWvH1g/yeyXxyQXTSROA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a6MVw/l1yHU3lulYT4ZVcMcgUWub85R8yT6m9cZOkFw=; b=aBb4kUXR5mwH/q39dW7YxSN3IsjHnoOdw78r/+iLF7Hs0c92Bnye0dMNnxdYNcKc2kuixnhZowpGOhzU6Hv16gibAKzW0WjLj62ZhZjZkmHIHWLP1r27oKaKgQsLvb7TDaSWPT64v0m7XFDaCUEAL7A1cg86NO1B49Gw0lsSA4mBTtCprUkkdaRB6YTQeWDx7YCCSjHmtqyZVwnyTL1MVoupQJpjglJ3Xu86rH4G8hfNbbx7XBWYarJAFhS1A+gnhWobi2NtFUZTUiiy/G8DZSsAjPpivkx3tBPdtWq2u2APumauDMxppdJ4Q6Z56vAoiz7d366SEQwS1qLhfxXDeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a6MVw/l1yHU3lulYT4ZVcMcgUWub85R8yT6m9cZOkFw=; b=LzibkzoigiegNKgoUMcptAoe4FF+bFa3jCQHt6MHYJ/t9uo4GNBvLsqHgbDqscZTJqgtqThtd/hJHDrEM4JsEe7p7NSMVSDNdLWYkTkpNUEVH+i3IyRYlniuR0iU8lt6E2weiFXrwQRT5IB8hSnr0r8LmGawseSwPtlr+AopIs8= Received: from BL0PR0102CA0012.prod.exchangelabs.com (2603:10b6:207:18::25) by SJ2PR12MB8848.namprd12.prod.outlook.com (2603:10b6:a03:537::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.24; Thu, 7 Mar 2024 05:46:50 +0000 Received: from BL02EPF0001A108.namprd05.prod.outlook.com (2603:10b6:207:18:cafe::f8) by BL0PR0102CA0012.outlook.office365.com (2603:10b6:207:18::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.26 via Frontend Transport; Thu, 7 Mar 2024 05:46:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF0001A108.mail.protection.outlook.com (10.167.241.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7362.11 via Frontend Transport; Thu, 7 Mar 2024 05:46:49 +0000 Received: from chalupa-4a00host.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 6 Mar 2024 23:46:48 -0600 From: Manali Shukla To: , CC: , , , , , , , Subject: [PATCH v1 5/5] selftests: KVM: SVM: Add Idle HLT intercept test Date: Thu, 7 Mar 2024 05:46:23 +0000 Message-ID: <20240307054623.13632-6-manali.shukla@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240307054623.13632-1-manali.shukla@amd.com> References: <20240307054623.13632-1-manali.shukla@amd.com> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A108:EE_|SJ2PR12MB8848:EE_ X-MS-Office365-Filtering-Correlation-Id: 60e0551a-e8ea-4bb8-f8c8-08dc3e69fbcb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8AFR0dLH4yhZpeIXrXWiPx0LZoFobvd/a7QfCl7ncizdK65piQSKpehylibcsqHaIJR0jTQEVmkGWWmzkaRVdDPQaO6V89s0M4aQVSZMJzSI/n8urQQ1XTda+YaRliV95EKRyp5zsuXRKgW9x0UE9VyjM/Bah7n/RNbY+3NnW9a743sm1i5DHsSHGWtW+JXWE+QFQLGv+309gjvKu8bI/bUyUtB4uZcxpK5s27hCx27/qQkIwQ8r+R0fKnAITBlGdF48+Nj/1YRw2AVFm2VVhp2Aei5Ps+8XN5hwY3uyXo5GAsffw71Zdf99L64ivo/Jo5NrvWZJGtgl2NykXAK5g4ogBd/S6jDTr7874WQ5eGXUjgCXFs7EmKjsTWRBEugobsNFZSe2nfAT7h6TH/NCHVFHIDx2BFYnHanMkX6bx8EeZIP58DtxZe8X9sm1fCGuigwndo7D9vVdOMhWbO7RBck4y1ZzebL/o3GJVZEe+e3llk5mnr+qwwlbO+StNGrTp66mgLRvCrsNyKypGe4Me4bpA2uKpFYRYlsXwFnWB6+2dtzEFArw6jinXzr86Yx5ZdDjrK5HlY8yvdT6PssHFWkX/0IMvLFqvbqXJPATtXqw8+yZfOOvdBA4pFo0ZI7psVavcVMll8kEHapF6eNs2Ofvh53iHPIN5CMZIcqiWLFDs/Kc5ryd4rbkZvkw/WTjS8WZuqNcMDxLNUOwPE3/gcHrX6E/4fNn6xCu4k+joTFJb8S7yKTdJdzCo989CQYC X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(36860700004)(376005)(82310400014); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2024 05:46:49.6235 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 60e0551a-e8ea-4bb8-f8c8-08dc3e69fbcb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A108.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8848 From: Manali Shukla The Execution of the HLT instruction results in a VMEXIT. Hypervisor observes pending V_INTR and V_NMI events just after the VMEXIT generated by the HLT for the vCPU and causes VM entry to service the pending events. The Idle HLT intercept feature avoids the wasteful VMEXIT during the halt if there are pending V_INTR and V_NMI events for the vCPU. The selftest for the Idle HLT intercept instruments the above-mentioned scenario. Signed-off-by: Manali Shukla --- tools/testing/selftests/kvm/Makefile | 1 + .../selftests/kvm/x86_64/svm_idlehlt_test.c | 118 ++++++++++++++++++ 2 files changed, 119 insertions(+) create mode 100644 tools/testing/selftests/kvm/x86_64/svm_idlehlt_test.c diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile index 492e937fab00..7ad03dc4f35e 100644 --- a/tools/testing/selftests/kvm/Makefile +++ b/tools/testing/selftests/kvm/Makefile @@ -89,6 +89,7 @@ TEST_GEN_PROGS_x86_64 += x86_64/smaller_maxphyaddr_emulation_test TEST_GEN_PROGS_x86_64 += x86_64/smm_test TEST_GEN_PROGS_x86_64 += x86_64/state_test TEST_GEN_PROGS_x86_64 += x86_64/vmx_preemption_timer_test +TEST_GEN_PROGS_x86_64 += x86_64/svm_idlehlt_test TEST_GEN_PROGS_x86_64 += x86_64/svm_vmcall_test TEST_GEN_PROGS_x86_64 += x86_64/svm_int_ctl_test TEST_GEN_PROGS_x86_64 += x86_64/svm_nested_shutdown_test diff --git a/tools/testing/selftests/kvm/x86_64/svm_idlehlt_test.c b/tools/testing/selftests/kvm/x86_64/svm_idlehlt_test.c new file mode 100644 index 000000000000..1564511799d4 --- /dev/null +++ b/tools/testing/selftests/kvm/x86_64/svm_idlehlt_test.c @@ -0,0 +1,118 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * svm_idlehalt_test + * + * Copyright (C) 2024 Advanced Micro Devices, Inc. + * + * For licencing details see kernel-base/COPYING + * + * Author: + * Manali Shukla + */ +#include "kvm_util.h" +#include "svm_util.h" +#include "processor.h" +#include "test_util.h" +#include "apic.h" + +#define VINTR_VECTOR 0x30 +#define NUM_ITERATIONS 100000 + +/* + * Incremented in the VINTR handler. Provides evidence to the sender that the + * VINR is arrived at the destination. + */ +static volatile uint64_t vintr_rcvd; + +void verify_apic_base_addr(void) +{ + uint64_t msr = rdmsr(MSR_IA32_APICBASE); + uint64_t base = GET_APIC_BASE(msr); + + GUEST_ASSERT(base == APIC_DEFAULT_GPA); +} + +/* + * The halting guest code instruments the scenario where there is a V_INTR pending + * event available while hlt instruction is executed. The HLT VM Exit doesn't + * occur in above-mentioned scenario if the Idle HLT intercept feature is enabled. + */ + +static void halter_guest_code(void) +{ + uint32_t icr_val; + int i; + + verify_apic_base_addr(); + xapic_enable(); + + icr_val = (APIC_DEST_SELF | APIC_INT_ASSERT | VINTR_VECTOR); + + for (i = 0; i < NUM_ITERATIONS; i++) { + xapic_write_reg(APIC_ICR, icr_val); + asm volatile("sti; hlt; cli"); + } + GUEST_DONE(); +} + +static void guest_vintr_handler(struct ex_regs *regs) +{ + vintr_rcvd++; + xapic_write_reg(APIC_EOI, 0x30); +} + +int main(int argc, char *argv[]) +{ + struct kvm_vm *vm; + struct kvm_vcpu *vcpu; + struct ucall uc; + uint64_t halt_exits, vintr_exits; + uint64_t *pvintr_rcvd; + + TEST_REQUIRE(kvm_cpu_has(X86_FEATURE_SVM)); + + /* Check the extension for binary stats */ + TEST_REQUIRE(kvm_has_cap(KVM_CAP_BINARY_STATS_FD)); + + vm = vm_create_with_one_vcpu(&vcpu, halter_guest_code); + + vm_init_descriptor_tables(vm); + vcpu_init_descriptor_tables(vcpu); + vm_install_exception_handler(vm, VINTR_VECTOR, guest_vintr_handler); + virt_pg_map(vm, APIC_DEFAULT_GPA, APIC_DEFAULT_GPA); + + vcpu_run(vcpu); + TEST_ASSERT_KVM_EXIT_REASON(vcpu, KVM_EXIT_IO); + + halt_exits = vcpu_get_stat(vcpu, "halt_exits"); + vintr_exits = vcpu_get_stat(vcpu, "irq_window_exits"); + pvintr_rcvd = (uint64_t *)addr_gva2hva(vm, (uint64_t)&vintr_rcvd); + + switch (get_ucall(vcpu, &uc)) { + case UCALL_ABORT: + REPORT_GUEST_ASSERT(uc); + /* NOT REACHED */ + case UCALL_DONE: + goto done; + default: + TEST_FAIL("Unknown ucall 0x%lx.", uc.cmd); + } + +done: + TEST_ASSERT(halt_exits == 0, + "Test Failed:\n" + "Guest executed VINTR followed by halts: %d times\n" + "The guest exited due to halt: %ld times and number\n" + "of vintr exits: %ld and vintr got re-injected: %ld times\n", + NUM_ITERATIONS, halt_exits, vintr_exits, *pvintr_rcvd); + + fprintf(stderr, + "Test Successful:\n" + "Guest executed VINTR followed by halts: %d times\n" + "The guest exited due to halt: %ld times and number\n" + "of vintr exits: %ld and vintr got re-injected: %ld times\n", + NUM_ITERATIONS, halt_exits, vintr_exits, *pvintr_rcvd); + + kvm_vm_free(vm); + return 0; +}