From patchwork Thu Apr 11 15:08:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Guerin X-Patchwork-Id: 788621 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65ABEDDD2 for ; Thu, 11 Apr 2024 15:30:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712849455; cv=none; b=j8zA01b6N7LrT6iUMMFfMTEFN8CxLV9pyuZA979aIfpf2F6nIsL5tkwumExB0bmhPGz9UqwP2xvWXIvNlhKyoYm2c9UzWHB2+FyfVxi2Qq0ON2kjcy6KJNFYKvZegIFA+MJrJXWSSNksnlcodf2a1mqlJzSTSMKKHxPlON/Q4J8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712849455; c=relaxed/simple; bh=bnqZLK1O/GH9Cl1N3XLcUoE2Qzj5ttpdC3dH5/Q4WFE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=RWUhJ7HG12YbQ9eGjdl913xXwdliyPLT8IEfUM3NkCqrTvJg6WldTW9HwmXTOQPrAd/IZFxp95vooOA4BmHwScrqpiWKsWRCvIuVOwQJkstwksOj04cWA5d99F6MUDRYF27LBlkl0x5iNq3UuuIlam3rLEYO9WCHR9MpmpAIHgg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DUzYfnnH; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DUzYfnnH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712849453; x=1744385453; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=bnqZLK1O/GH9Cl1N3XLcUoE2Qzj5ttpdC3dH5/Q4WFE=; b=DUzYfnnHTFcEdShkhpICOggpwaS1a5tYtKeTGQp225qQ8ykdBvqfMwh+ ohJFoUYSkric+n7LTlMU3V/tuSVV5awXvHcH0IXHFQKXIb8eTd8Lx9EG9 LL0rt1kP1Em3bcUH3pVFm9yLqE2Y5QVSz4Wf9UFTR4MezS4CvW4y77wNo QCf1lI8MZiIobjOUgUFkpw3JGSFWhD7UwXFVAThRoI5gUkLFqM2xAXnkC C1hbXqhCXqK4zGto8lrLDtdKZCaQWbt3oIYhaGtLJlk3M5C2dWQQG0eYh sDdy4D+9wl0lvdVSYspDj4gQUeDkgr+Gf/Yl3D5c1EZSXtbSRRt1BAvUR g==; X-CSE-ConnectionGUID: /tTmfbNqTM6Dm6Pm8vT7AA== X-CSE-MsgGUID: DlC/xAw+Tqmvfh9alojvEg== X-IronPort-AV: E=McAfee;i="6600,9927,11041"; a="8142521" X-IronPort-AV: E=Sophos;i="6.07,193,1708416000"; d="scan'208";a="8142521" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2024 08:30:53 -0700 X-CSE-ConnectionGUID: /lshN0PtSDKihqk3ZdMwwg== X-CSE-MsgGUID: C+2dd2eVTlSUbW5cMsSU+w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,193,1708416000"; d="scan'208";a="25584750" Received: from silpixa00400295.ir.intel.com ([10.237.213.194]) by orviesa003.jf.intel.com with ESMTP; 11 Apr 2024 08:30:52 -0700 From: Adam Guerin To: herbert@gondor.apana.org.au Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com, Adam Guerin , Giovanni Cabiddu Subject: [PATCH 1/2] crypto: qat - improve error message in adf_get_arbiter_mapping() Date: Thu, 11 Apr 2024 16:08:19 +0100 Message-Id: <20240411150819.240050-1-adam.guerin@intel.com> X-Mailer: git-send-email 2.40.1 Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organisation: Intel Research and Development Ireland Ltd - Co. Reg. #308263 - Collinstown Industrial Park, Leixlip, County Kildare, Ireland Improve error message to be more readable. Fixes: 5da6a2d ("crypto: qat - generate dynamically arbiter mappings") Signed-off-by: Adam Guerin Reviewed-by: Giovanni Cabiddu --- drivers/crypto/intel/qat/qat_420xx/adf_420xx_hw_data.c | 2 +- drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) base-commit: 0419fa6732b2b98ea185ac05f2a3c430b7de2abb diff --git a/drivers/crypto/intel/qat/qat_420xx/adf_420xx_hw_data.c b/drivers/crypto/intel/qat/qat_420xx/adf_420xx_hw_data.c index d255cb3ebd9c..78f0ea49254d 100644 --- a/drivers/crypto/intel/qat/qat_420xx/adf_420xx_hw_data.c +++ b/drivers/crypto/intel/qat/qat_420xx/adf_420xx_hw_data.c @@ -298,7 +298,7 @@ static const u32 *adf_get_arbiter_mapping(struct adf_accel_dev *accel_dev) { if (adf_gen4_init_thd2arb_map(accel_dev)) dev_warn(&GET_DEV(accel_dev), - "Generate of the thread to arbiter map failed"); + "Failed to generate thread to arbiter mapping"); return GET_HW_DATA(accel_dev)->thd_to_arb_map; } diff --git a/drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c b/drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c index 1e77e189a938..9fd7ec53b9f3 100644 --- a/drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c +++ b/drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c @@ -210,7 +210,7 @@ static const u32 *adf_get_arbiter_mapping(struct adf_accel_dev *accel_dev) { if (adf_gen4_init_thd2arb_map(accel_dev)) dev_warn(&GET_DEV(accel_dev), - "Generate of the thread to arbiter map failed"); + "Failed to generate thread to arbiter mapping"); return GET_HW_DATA(accel_dev)->thd_to_arb_map; } From patchwork Thu Apr 11 15:08:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Guerin X-Patchwork-Id: 788040 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 241A014A83 for ; Thu, 11 Apr 2024 15:31:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712849469; cv=none; b=kPGXw1X4RrXnZD3CLu+FmhjZTFLF5EdwWts8p+396h2nv7GrTyHjt7Yte6dv28ePLwvKt85YRNqtbGzVJAOofnlQYbJ+Tf43bxXKWHIblZOIFoL7vYG3DiUBvurfWPwuBtjIqwebwap9SZ13Khn8gwSAA2Y9lPgzagQVvEWmdH4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712849469; c=relaxed/simple; bh=KZTxlNi/B40PE/etAgygnfvqYna8Yo5iqHWxrTOx2zs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=oWvOKAZZfqwYk1Hr2m+xsJUZ++uBNogh3evWQeW+RWyMYgoCjM+kYvfkurfu+VKuvHQO5vmV3opL5Z+sEY8oQrkBmUoruRitx9D4T0OaXO13g0EmOnl9muODJt2lNEEReW0QwwZOkwoSBGSZLBCqshUwYU7AGis7/B1Fn7odQYM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=cWsqWhtb; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cWsqWhtb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712849468; x=1744385468; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=KZTxlNi/B40PE/etAgygnfvqYna8Yo5iqHWxrTOx2zs=; b=cWsqWhtbT88VR7MGOj+GbAZZ9+e+6vObc7I7s1S3n2wMJEFr5RxAMuKt rZkiJX54OOsypK/IE+GO4k5TCfimwY1AI1IryzIA2K3srMz//vbedTTKz 4RlAl76rgpg+BBd9GTqFl7rX+u2HnrbMpK6G/0sKXQ096RFRb4F+s8Mq5 We4xVw83RBk82GqZ8c3Cv2zO208lCWlapkGgAP+qFwCbdUqqyJ3QYWENs WAg7iqJnEb2FA303CtT+biDaXGlrx87fWlzjJ+/ZTNdzLeTdmmExzZ1Us HTxwMkSiuiys4Vene7/hQm8BBamcgEmiwaCqHukaThXSXCLSlgA684hg9 g==; X-CSE-ConnectionGUID: kFw8J6fwTj+nbCle22h/KQ== X-CSE-MsgGUID: mwS1xp31QQ+ylcY8nUJwcw== X-IronPort-AV: E=McAfee;i="6600,9927,11041"; a="8142572" X-IronPort-AV: E=Sophos;i="6.07,193,1708416000"; d="scan'208";a="8142572" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2024 08:31:07 -0700 X-CSE-ConnectionGUID: 2QXTvmUXT/665R5cCXwHsQ== X-CSE-MsgGUID: 0H8obsxLQm2Qi+8TqSfiVQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,193,1708416000"; d="scan'208";a="25584859" Received: from silpixa00400295.ir.intel.com ([10.237.213.194]) by orviesa003.jf.intel.com with ESMTP; 11 Apr 2024 08:31:07 -0700 From: Adam Guerin To: herbert@gondor.apana.org.au Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com, Adam Guerin , Giovanni Cabiddu Subject: [PATCH 2/2] crypto: qat - improve error logging to be consistent across features Date: Thu, 11 Apr 2024 16:08:21 +0100 Message-Id: <20240411150819.240050-2-adam.guerin@intel.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240411150819.240050-1-adam.guerin@intel.com> References: <20240411150819.240050-1-adam.guerin@intel.com> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organisation: Intel Research and Development Ireland Ltd - Co. Reg. #308263 - Collinstown Industrial Park, Leixlip, County Kildare, Ireland Improve error logging in rate limiting feature. Staying consistent with the error logging found in the telemetry feature. Fixes: d9fb840 ("crypto: qat - add rate limiting feature to qat_4xxx") Signed-off-by: Adam Guerin Reviewed-by: Giovanni Cabiddu --- drivers/crypto/intel/qat/qat_common/adf_rl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/intel/qat/qat_common/adf_rl.c b/drivers/crypto/intel/qat/qat_common/adf_rl.c index 65f752f4792a..346ef8bee99d 100644 --- a/drivers/crypto/intel/qat/qat_common/adf_rl.c +++ b/drivers/crypto/intel/qat/qat_common/adf_rl.c @@ -1125,7 +1125,7 @@ int adf_rl_start(struct adf_accel_dev *accel_dev) } if ((fw_caps & RL_CAPABILITY_MASK) != RL_CAPABILITY_VALUE) { - dev_info(&GET_DEV(accel_dev), "not supported\n"); + dev_info(&GET_DEV(accel_dev), "feature not supported by FW\n"); ret = -EOPNOTSUPP; goto ret_free; }