From patchwork Fri Apr 12 00:21:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan \(OSS\)" X-Patchwork-Id: 788659 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2077.outbound.protection.outlook.com [40.107.15.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C33E1C33; Fri, 12 Apr 2024 00:13:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.15.77 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712880806; cv=fail; b=uTRt6FTLq39KF6jPokP0c8iANeiv+mpZgVOBC1dZ75eHTzyLEJ1yg68m2X9chgDN7NdW2oI5t1JNV59UiPSy6lkh7aouZgnVVrLO71Jib+u7WLVzkOcFE8RA5t4Ql8VhiszRkJ9VmRkoybosxI2txC+oEQ4qvdtBPPIcH7mlkd8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712880806; c=relaxed/simple; bh=RhCldLpWFoBisg6JxF8FQ42efMI/x7hxyuGNT8KbSHI=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=lmQbQaaWpzY+rU6q5NuPMOKhz6EAEHYOLNkxdGtAaH8+jEPHbNFu4kJWyKgnA3l+SwuQE9JptCpmL1lpW1MJeauhuEjvGQq09mNHFhI3oXXDIa6B/My1J1eiCpTVTwiCqM9JiooHgzsqT3rzsfgZNoRl9Dhx3Lgs0U8LlGAoJJ4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=IP91G4Du; arc=fail smtp.client-ip=40.107.15.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="IP91G4Du" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OVSQykCGrBwiilL1RK9zDkuHInK9UKMS47uklI0fNwJo5gxi2bpVq2FGQ5HQVhpiFR8ZCOWe6VSdOKFxvumRI1dW2XF8ktYnLoKBTMVT3Ka58phT+b9S5TC8xZeu+45XJ17JRv9HLNHBIRoz2rNxbKyKdHkA8rDS94XaIh+pWeaPc62glPa+pKyDnNUSJMBCTELhIaRRe7G4KqF6EF8xYH8UBPxId53SLtY9tXp5NhOGEXQOMG1ERslb0K2zkLSp8BVMpwIfv+GvWWe4uXMlfouxO4OKjtc/VwVlrj771rX5N93SxGkM6oPLwTRyoC8OuNnqzaFzBvnk5AvBwtW1AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y32EPUygoezOrwpSdGDK5Cezq+RoDLA6Ci/XuseYkwM=; b=FBmxoILX1UQd5eipnjOl/iDRIHFCU3kcDIZgruNWYe1OsuyViB5CyqwfffkY/xh3IFHGXVBeNsHq4BAzrKxFlOvQsRPmFdcebJicU1pH/fCcqgFm5lgu7ib1iwDy4uUiOqCCKFD+RWpV2MlIxhkuE3GNzUQvYwTFsCHIjSEKqNglJaXvCtGiplRo4OXtZ/GidIJEpQx2sbPlmNmm9bLp64gzX/VZiwxBUHU98DXajbGpu7FmKzGkqUO506RtnMii6k/HdHWDmbqEdm+0/Gs1lRmqaWyZaz8iIUDhV4XrxdlhrN/XN1NOPHhEKXY43SprOkYgxmQgk7cUCTO8vMx4HQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y32EPUygoezOrwpSdGDK5Cezq+RoDLA6Ci/XuseYkwM=; b=IP91G4DuHjlTUWTamlXwhnDwvt8Ft6rPEptkwn1TRkKYZidd1aKPw69KsHoXFBchXumPz1CE0AaQcbH0gWwsBElOdfy8VXZ/23pku5XlqZXDvvM76XqvZ+OjTW4ZCIMscuwv0kJJkMEqyk4SsdGDQ81XmsfzqJkp+vkI9veRg5U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.55; Fri, 12 Apr 2024 00:13:21 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7386.037; Fri, 12 Apr 2024 00:13:21 +0000 From: "Peng Fan (OSS)" Date: Fri, 12 Apr 2024 08:21:19 +0800 Subject: [PATCH v9 1/4] firmware: arm_scmi: introduce helper get_max_msg_size Message-Id: <20240412-pinctrl-scmi-v9-1-b817344d3a9a@nxp.com> References: <20240412-pinctrl-scmi-v9-0-b817344d3a9a@nxp.com> In-Reply-To: <20240412-pinctrl-scmi-v9-0-b817344d3a9a@nxp.com> To: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Dan Carpenter Cc: Dhruva Gole , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1712881290; l=2695; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=fC1f9Mz+AZ7lC+TNU94i2E/beyKrQPUiXgoBP0YzZ74=; b=OWKxrw9ZZCr68dgQBzT6CIz1bMZDFPVrtHh03miHFm7/FTQeSEo29mpNmafConzXne3ZFHsuR uYoyvrruUbdAxU3H7c6tiN+KfEbvC9V4o/xkoNgX202KI65/TihAog7 X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0036.apcprd02.prod.outlook.com (2603:1096:4:1f6::20) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM8PR04MB7970:EE_ X-MS-Office365-Filtering-Correlation-Id: dbc3ff96-531c-4a52-c697-08dc5a855ce3 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KgaywSO+DSPV90Ifrs/x6QgWLmkTwU97qvoqeeAVlQEXLPfHliR83Mlp/DJk1+7XRSQ3ucHsLOSZ8icb5YYmlCS4LH0h9yYzs1Fv8raYt6mpxg0SM95UMZQpBAdiLA7ML5BhpvwrWQFkbRX1LtVsHW8+3e7zc3OsT8+jzh8n0iLTlT23nm2+rSe42rEVnBlcwx6X2ncLJd1KvDWjrdfQvjzAT5paJojlNgohPIksFROax1JGj1l+d7nEQR5jgk0mPB0BDAl3mf5vT5HrzR7TgAQF5jhwk1asg53XZArfTu8KKrgHbB8OCjQJX8CFms7Q5xTvjnPXfAn8fT23bfY5fnetU8o1hJxCVA+oDS6wVwhoZsqyHHDZzb0zQtSjCiPSxz+UdjCBO/p5eW4ty1komxBWtWBftT6wiptfO7wd3oBna16x8lKdsvhMtPZhxqDonAQXnd0njT/NwXsUaxyDk58D5LML4/wOUzSotEFVUWNYIqAzJA0mvDDB6cjpwTTxZBQV9r9CmyCrHpY4Vdx2SZhPpmDg074XlDYc721r/6R/LMs8B9z6W8ewuASFZrULZgYY7eTsKI9POoVoW8ZVZa+fk97jDOr8gAbvsk4mHfZC4Rg8cKJ0yaOc5lzKLf27CvqZi9KCWgTZBI0el1fCeN/zC1+AJjAtoz1tO9wMdxYPVbLnd3wpQCTZRadB5bqDCrA0Se0yqYU+oGAwt5Zgbbiswsdh+u1Wvokcs18odyI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR04MB9417.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(52116005)(7416005)(376005)(38350700005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?rQXhGj+2nvamdYFvPAdYBBZx1nka?= =?utf-8?q?82UhaheX4Mm8VBOd74Dj9UFk+bESSgeT2CKNuR8h1gCYSgwoM9nbXzDZyMT9WgG23?= =?utf-8?q?swQpcJ040gptm8cuNw/CkipkJHYbUvPtENDq71rmS3a6Tw7iW2/C38E8ZEYWRW94y?= =?utf-8?q?EspoRZd00sT702Q6EAAQoK9ZfeR1YOXyrQKLzcMgwtTULPbdy6BzViIGYBIdrjyFP?= =?utf-8?q?i95R0DcELYU1JqVGuCcIJtmUV3HkwcmeEcqqi8Vy+MN2wwYlpDJoAmvSSXTVZsTOg?= =?utf-8?q?M7nbgA9sopucck73Hbe9nSaaU+dx83eOFxxrCvv9PBD4GZmG/UlTB24SI41jgon0q?= =?utf-8?q?hDdoghaH+8XrM0eDHAawwwWKK6eV6Fpq0E+/cZbC+dP+Uk6mjGUZfTBZSFtiEg4o8?= =?utf-8?q?d0t6wAcpBeGwXI9TB1dZLL5csN8lkKTpzciKWj8LZ6zjRPyN29KZOD8QNZlV2a127?= =?utf-8?q?SigrVWLvOyItvlHGP5QOCgajO6zQoCHj+Xc7zyyKNPIPiw0S24TvMwxk7vw2+GDea?= =?utf-8?q?iWH+UFEnV/TLBQExASrQQMBIQkyGo5eucOoSa16hlnzujhTzIkysetNsXxYMhsQus?= =?utf-8?q?MIqlfoWYJw2Hk7GenN+IgX0Z556AzEBYVwT1PC5MSG7qvKhz8imIHz9YoajalV42l?= =?utf-8?q?waJGmWCDHoOKkOfadnX/PBZAkSdvbR7IFCqD9LYV7uw40L8n57xPxiSJX7RVdD0/7?= =?utf-8?q?k5tzORGcZe9X3jv8v6pUsHFFVhYQ9PQID2lUYkJhx4T84uy4I28XGMBY2w7BaXBjQ?= =?utf-8?q?y3xhFkdUP+tZlXwzTlDYyfzyygFBKm7cpruqF/1ynUfJV0Qln9BdBgBMeIj2b4Jrc?= =?utf-8?q?0/PCFZjSjBvXuB6mc+IxIyiPxFA4Lyia3B4GvFe9seWKfqcOEy5uz7rJBz0+vxlbR?= =?utf-8?q?k/+dPxI8wO1NIQFovk+EpPkbooyEDWWIJ6GkWkxZ16OxZWcq35h2P6VOPhyv9VCk4?= =?utf-8?q?QbgZfhJm4KyPw8ZeH7OX9CNSEXNnOhHBvQOXJW5fnV0mkjuf64FG6CZSXoavHbsS+?= =?utf-8?q?+sY4QEYmPfxREV2Jr5ltuzpgC/EwBAhtuSawnNR77EyD/3eUZMr0K5RLIlCmlm05Z?= =?utf-8?q?hAwuIG18ZGLfguqfA/WpUAO4NUCKquJ75U/KtK3ugi3kUgNcj5peunaBb8NlSu+UN?= =?utf-8?q?b6CgWD56/nqaK6eNmwq9eaF58OdFMXH1twTAzQ5csRjvmWhIR7gunq9UbwjtnG9n8?= =?utf-8?q?cmbbPXjjDHM1trMceSceEN65tdfACyc6v+HUCrPVWQasrVuivX6SKIOCXwAdz7rSX?= =?utf-8?q?OeLSRarTQQMnP0u1Yn6VdTm1yJGSXusxf6cdzcZF4ZsNz6r9cigJPL7H35dn8ou8e?= =?utf-8?q?Y6kzHVMjc+pShdrPsSlRbZ+wGdp8vUsPKZ8cQWgMWW5jqB1KJqNhek3jw7o1uUkK/?= =?utf-8?q?fBPhpCvfUXPiO6Me1YNJBOSIQ1aSBXI/goz1p1scpK+S9oEixtqFf6n/Y3oq35t4P?= =?utf-8?q?W1ayLEOEuSQsa2fDCluQds4qrMP7ohqmZ2jYMlMi4bWX6g6td9qU6URL9e1ZFk/9I?= =?utf-8?q?v9F12RKyz6Iz?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: dbc3ff96-531c-4a52-c697-08dc5a855ce3 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 00:13:21.6230 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6GCxTuZdOTM0qWrUgksjH/7eSpRZ8UqaVk1CYhnHpREq4RcktyKd1I6V5pvk2GBO+vAZ+iGgfZTXGj1nS8Axsw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7970 From: Peng Fan When Agent sending data to SCMI server, the Agent driver could check the size to avoid protocol buffer overflow. So introduce the helper get_max_msg_size. Reviewed-by: Cristian Marussi Reviewed-by: Dhruva Gole Signed-off-by: Peng Fan --- drivers/firmware/arm_scmi/driver.c | 15 +++++++++++++++ drivers/firmware/arm_scmi/protocols.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 36e3eb50a8d4..a1e0e8fa4bb7 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -1537,6 +1537,20 @@ static int scmi_common_extended_name_get(const struct scmi_protocol_handle *ph, return ret; } +/** + * scmi_common_get_max_msg_size - Get maximum message size + * @ph: A protocol handle reference. + * + * Return: Maximum message size for the current protocol. + */ +static int scmi_common_get_max_msg_size(const struct scmi_protocol_handle *ph) +{ + const struct scmi_protocol_instance *pi = ph_to_pi(ph); + struct scmi_info *info = handle_to_scmi_info(pi->handle); + + return info->desc->max_msg_size; +} + /** * struct scmi_iterator - Iterator descriptor * @msg: A reference to the message TX buffer; filled by @prepare_message with @@ -1848,6 +1862,7 @@ static int scmi_protocol_msg_check(const struct scmi_protocol_handle *ph, static const struct scmi_proto_helpers_ops helpers_ops = { .extended_name_get = scmi_common_extended_name_get, + .get_max_msg_size = scmi_common_get_max_msg_size, .iter_response_init = scmi_iterator_init, .iter_response_run = scmi_iterator_run, .protocol_msg_check = scmi_protocol_msg_check, diff --git a/drivers/firmware/arm_scmi/protocols.h b/drivers/firmware/arm_scmi/protocols.h index 317d3fb32676..3e91536a77a3 100644 --- a/drivers/firmware/arm_scmi/protocols.h +++ b/drivers/firmware/arm_scmi/protocols.h @@ -258,6 +258,7 @@ struct scmi_fc_info { * @fastchannel_init: A common helper used to initialize FC descriptors by * gathering FC descriptions from the SCMI platform server. * @fastchannel_db_ring: A common helper to ring a FC doorbell. + * @get_max_msg_size: A common helper to get the maximum message size. */ struct scmi_proto_helpers_ops { int (*extended_name_get)(const struct scmi_protocol_handle *ph, @@ -277,6 +278,7 @@ struct scmi_proto_helpers_ops { struct scmi_fc_db_info **p_db, u32 *rate_limit); void (*fastchannel_db_ring)(struct scmi_fc_db_info *db); + int (*get_max_msg_size)(const struct scmi_protocol_handle *ph); }; /** From patchwork Fri Apr 12 00:21:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan \(OSS\)" X-Patchwork-Id: 788433 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2052.outbound.protection.outlook.com [40.107.15.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1DF579F2; Fri, 12 Apr 2024 00:13:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.15.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712880811; cv=fail; b=RVJMDGXkH2QqvAB0hMuCP5CmVN9977BDtUWVbXwv0Ojr4sLjpCiSDRkYgUAGFaiYmmUbKZitt+S/H39l1QAccb9ffJHBP35MDi0ItezCRdtx1omINohq0qFPZJU3qzZ+NDtp1DRpIZC/oanUWdmvKg1VK92xpjONOff4senyTxQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712880811; c=relaxed/simple; bh=E++RdVjEyJKaeRP3uQ6km4a3etsBjQNzluyId+6G+dQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=PJiupqma5suJVx20wgCTYxbhRtKt3D6GkzIgI1BkzXEgYgjcNbK8Ffwq5l2EEf7WJXyv3ip3fFZv1Tworzd/mpfBHHUYiyw5kmYhD0b9fZfmWnK4+4/x/k6fnznAPFME26cvbrewaDvtxmAOV+mOb4nlaoToxmr0mzEDaChdXMg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=PrVKTz6j; arc=fail smtp.client-ip=40.107.15.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="PrVKTz6j" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DjwUiOLxH4CtoMbI6XgJftxF3iEqFgg0KRVzi74lb6OPfQLxSfRD7XSRU9iUB8bYRrgdfaLhi43AIOI2qdDelwbH4rul8kY7SGF+HHnfw2JatWdMTP07jTu+X8/mvzeOmuBhVl60dm2y8rrFnoa5fnjcfctz0ZWMbwiQVM2n7avVcVqa8eCHgzao+50gN9BHI5TaJjC/G2cBzUS44nzeNUuk9zHAJJKZuKfdyNkQPzGZ/nzk/nUjsx7E1HFGehZolhCX/3Y5e/iMtLospD2IgOY98wWOeFhwmqFgBn/P5J0NtbOMiI+EF9xkAmU0gJSwzQuaHrcip3xhZp7XEHGzvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pBQe0Od3+rHWfruV+PspmNFR5QiiEhNYWfshtcWJTzM=; b=QzbUBqXEp2iUUk3TxnL5vxTbt2Nu+ycGSZMGsmUFQ119q8BQfR+68dxQE5CgwOvbx1skecwrEA8XwqPK3bo+4ac8Of2C/aXsptHxAiwa1XbXuxGa9ZoqsZaf8d0za9i+kh8i19eVrpXtzZT2x4HsJfWF+bxDw3tLy4z/M4rjYfJdYe6Gx1Nk+F0e8RaN4/tnpZZR2iTX8TAxf7BR8CrSv2hwT9zC3w/fIM2/qe/JasKB4+0SuxE1zCZ3tqeNoImtzDHx99SQtnMzU1LX0pJQTR6N0slfwQlkuswLmXn7OghVTbcbkkdRE7QSlFAgDrTSz5CJeAcidWHCVox0DyCprA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pBQe0Od3+rHWfruV+PspmNFR5QiiEhNYWfshtcWJTzM=; b=PrVKTz6jNTI4xU4jVVvyaOzVhzJw9nwiz1NbcnkZv5alwCFjoBGVJiEdG1Qe8usPj480RZLjS512y0grANR2cMXiHB093maazvJQ43Xe9FG4Cvyr3xTI+Qj6XM6CRjACwn2lC83BQaGqu3rvoUAwiHHcXexonH/rlUJsL9GeSs4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.55; Fri, 12 Apr 2024 00:13:25 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7386.037; Fri, 12 Apr 2024 00:13:25 +0000 From: "Peng Fan (OSS)" Date: Fri, 12 Apr 2024 08:21:20 +0800 Subject: [PATCH v9 2/4] dt-bindings: firmware: arm,scmi: support pinctrl protocol Message-Id: <20240412-pinctrl-scmi-v9-2-b817344d3a9a@nxp.com> References: <20240412-pinctrl-scmi-v9-0-b817344d3a9a@nxp.com> In-Reply-To: <20240412-pinctrl-scmi-v9-0-b817344d3a9a@nxp.com> To: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Dan Carpenter Cc: Dhruva Gole , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1712881290; l=2404; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=DFipHsGSFA9e8Nki9cC2yHmdVxAiRFl+Y09BDYDmlDA=; b=ereRO0xZDMytxw4d03hXxnLmm7SSi0K/35MXrbSAOfk/dXUHsZG6ra4Q1ouaKehZw4AyPQvoU C/0WSH7L5msAfTmTMgDAvJMvkzX9hGNRi/iebgirBEoHUrcjeJZt/Wo X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0036.apcprd02.prod.outlook.com (2603:1096:4:1f6::20) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM8PR04MB7970:EE_ X-MS-Office365-Filtering-Correlation-Id: 02623f73-549f-438b-d0fb-08dc5a855f61 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3maq2RiSuXi0qYi4UTBkrOAQ44dvKiU6kSmjwXyIu+85vDMGfY00SUxejPT0ATBQQyO4MrqriKwSSOqpeU+08Eps67FqMkNSeGtY8QeUqRYWx8/A1iaA1O6gfJyKcs4RtmirRckySzmf1qCrhk6yBYUESlJ16hjrRFYzuTTY2WrWKldqTyadOSpAFNgS3wS/ijfFj3VY+O69WLVTqRHYT1SCA5fYEdyzjYgcfh8Gne2eg2MKS67xYv9F9Nt4HNYIYPtxx6OjanGP0qtbG1avYUjNWYTgkCDWPFkVRcmvuXJEaLYBE43X/qcmXoBPBDtbsh8T6G+Id+0JKjkzGvd5+k7OONlIigeTA9yYC0sbcbU8hUARjYz1IKjvZ9F3JtT2+lLQmh1apg+p+pGOeBbv87u60qZeX+TD+8E2g81PVadbenwq/Tb5imyrsVCso/TkBbbsq7YPH1okHHH6DEAIsM0P2dmjUWQz26soQNTCTXMuR6JCON1sZ3yN9QVFkEQU6laV4wDq+5Z5bYOERooOu3Ol+RUYvSqYVZSusaXJcI9rO+JPxcfmIxT6/wPj2OsuwnU6ZZ4JeBfQ5gsu007sqfg3nc+dFNJR82MiDHGtoUceh8truBOO3eFH+8QAmzFYRfS2l1KC44+M9iGJ9lcPlOXoKJFETsHu3gAuMBkGyXsblt57KHxjcnNBDVvlY+zg4nrLVShv24mZeWWmcEuPf3ci94SXS+Nb8vSvNT6/8TA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR04MB9417.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(52116005)(7416005)(376005)(38350700005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?rCCsL5QX3HGmRZxcFJjxeQXf+q0x?= =?utf-8?q?zishJoWehnn3RlzHCMTBoK2yP/9/Zx+cYaO6UEtJsYa5N2xYN/zr4NYGmKZRk/riP?= =?utf-8?q?sILBChXC/6jYIt6xeoQRQRL+aIiyJVxzrusendMNqmJ1uMHaXqd4vzhW4+rxBQZJ6?= =?utf-8?q?fILTFJdT7HZjHS/+P4uzvJOg63S0mjudfSMeQPvoa1KmxWKv6ooG+nY9z726MYZ0m?= =?utf-8?q?WyH2bYhZWlxsSp68n64YI75s2OqOiuX6ge3yKstp21mQUE0wrSxdT5mCrLY3BeQhH?= =?utf-8?q?wcYrEgb1WNSukses+8znEqGxwJkoLyzarvPB81kfAPeaMN1Dr0RKvGmo+UoVpnPcy?= =?utf-8?q?Lf11PubywCv8XNiJwWXNs8tGSMt0NA4ikbTFFcHnWO1bMF1zNLge/nFNKr56GxX8F?= =?utf-8?q?aKlBFeRb0Wz2dIUZI2w1V2VQiPxbMMARLXO+emge3ML8YJb1Dhmc+CtjjQ17Woxcl?= =?utf-8?q?bPnzXYB+sk9DsMtLZPJrIeI6zhLddocEdHkDDK/y7fEIVokXJI+S/xB+2cB7keXLI?= =?utf-8?q?+1yWV5Gqisl9PL15Wi2bt77a1Oe8rdgEvQE5FhtmU0+LLBOXpqbDlsYB7Md46+BjU?= =?utf-8?q?cUGxfB7wS8C2s4UmrQZvoAYwqa4JrozpP6ojYLCRN+goSeiJGc+iegNndSu3E7Db9?= =?utf-8?q?XTjsQ6H6atn4MV0TjbEbNRsqiyM1Fa/frjEudlDQtHScaGyvILrD/dKOGg1bf8DkN?= =?utf-8?q?E0PfAg9DOMhyZJ8iyYdWhQXZ1ZboZJIcwXxFLFIPKJ3QXeD49Y1g34iX3aKxjj4Rc?= =?utf-8?q?JCTiTDIbe9Ntst3GUMSyQIQ9n+EoefeROO7v9SeK4dU36pEJrkbc4GRE/ejNVYGxL?= =?utf-8?q?zyBYUpcQDPcFs39VVkoFwsZjT7gOBS0BscpuMKlzTUKCn73RT5HplIBMSAuO1CeAD?= =?utf-8?q?1+OXGc5fCFaaSBMY3FSiZJK2fR3eIRRSOn8lWddr7N/AbY+nytPR04w4XtBmgtEZ1?= =?utf-8?q?NwCcC7mpF14WMaWq5VHf7piO9IF9IT0y0I4JNDOiO5RPdWtIVctiOHi8TyZZ0LXt/?= =?utf-8?q?Zcv1LkO1Pq3xhnMiWt5M9Jc2rtbClH0Y/HnjTraCFV/wCjlXP5newFiDuS9OFoC7I?= =?utf-8?q?RkYiIN1Fi9wI88k3chXpcwh5Fvpbc29NZ9l80berm7mt1Fa2xPX8rLPbLpXAgD8rq?= =?utf-8?q?Iz+I1QtE2i+QodRIQNAfoGmret9GNJ5VlqXgl7yee5jDTVXDHfCT/7wBONuNxg5m4?= =?utf-8?q?8PitTZ0uWIZpa79DgHNHuHXOr3XDD01FoC4GUAywVU90+2/5fVmIjnTUh3BmlGYR5?= =?utf-8?q?bEi0AZNTjcgUPW67PW+QztXLkjuc4uWlc4olqpbdm3nqa6DEE9vEP5jKxTrP4eRn4?= =?utf-8?q?i6qSEEBvyS5mEwdkr7zp8tKNTWa/WAUAqMo8ERF9cPxbuR+slIyvvY14rVog7ZxKK?= =?utf-8?q?d8C5tqtjYCM77ZJ7KaAeKQePMlBIL3C+14ceG5VcNUw+1vVYBneFTV/n+nu8PfI7V?= =?utf-8?q?zVmK/Ps97gOeP+oMgdlgXquCcfWZzKp1Fp029HMdpSXrd7cnaN4JGI58acwydkULJ?= =?utf-8?q?a3D+odZVHEAD?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02623f73-549f-438b-d0fb-08dc5a855f61 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 00:13:25.8387 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: abPGrTC/Q3g+j1Yt68FnRVXrEhTQTCXAcKt2oTzfyXsxxrgQtYx9cGvwbifKwtnD0ZnMBXv8j3AwN7t5JaBb7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7970 From: Peng Fan Add SCMI v3.2 pinctrl protocol bindings and example. Reviewed-by: Rob Herring Reviewed-by: Linus Walleij Reviewed-by: Dhruva Gole Signed-off-by: Peng Fan --- .../devicetree/bindings/firmware/arm,scmi.yaml | 50 ++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml index 4591523b51a0..e9d3f043c4ed 100644 --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml @@ -247,6 +247,37 @@ properties: reg: const: 0x18 + protocol@19: + type: object + allOf: + - $ref: '#/$defs/protocol-node' + - $ref: /schemas/pinctrl/pinctrl.yaml + + unevaluatedProperties: false + + properties: + reg: + const: 0x19 + + patternProperties: + '-pins$': + type: object + allOf: + - $ref: /schemas/pinctrl/pincfg-node.yaml# + - $ref: /schemas/pinctrl/pinmux-node.yaml# + unevaluatedProperties: false + + description: + A pin multiplexing sub-node describes how to configure a + set of pins in some desired function. + A single sub-node may define several pin configurations. + This sub-node is using the default pinctrl bindings to configure + pin multiplexing and using SCMI protocol to apply a specified + configuration. + + required: + - reg + additionalProperties: false $defs: @@ -401,6 +432,25 @@ examples: scmi_powercap: protocol@18 { reg = <0x18>; }; + + scmi_pinctrl: protocol@19 { + reg = <0x19>; + + i2c2-pins { + groups = "g_i2c2_a", "g_i2c2_b"; + function = "f_i2c2"; + }; + + mdio-pins { + groups = "g_avb_mdio"; + drive-strength = <24>; + }; + + keys_pins: keys-pins { + pins = "gpio_5_17", "gpio_5_20", "gpio_5_22", "gpio_2_1"; + bias-pull-up; + }; + }; }; }; From patchwork Fri Apr 12 00:21:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan \(OSS\)" X-Patchwork-Id: 788658 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2059.outbound.protection.outlook.com [40.107.15.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B225BD299; Fri, 12 Apr 2024 00:13:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.15.59 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712880816; cv=fail; b=QMzVaXFitMzKE6rkdjqR6CUz59G1ven9k7VoDm4Cx7CvosatZV5uMMZ1hBI4ANKTYRXji4ZnIAv7dDugcNM4MLLsLd8UnKHYmaELVgaJ2vLYbg4+mCw5zXHb15/9RKAqUY6PeowKMQJ8d9oesmSOD9wFv59Cpuh5HSmia4Kenv4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712880816; c=relaxed/simple; bh=YlwrH+eQS9F7MOeVCzzuGup799W4C6ZI78AJteK4rKw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=eVqdfUE1PGGucerfkprxgdFb9XMB9d1ScY0gb1W2G+QSKelvVon5YbfERUk4RMm27SW3DJseLJn8tnfnP4xFcO2CjC1EBveEhnNIEm6QMEyHRLOCn6648X4+Fo7XmoXFxRFMWNo5I1pcovfehNTS2nfZFVk0zwNkU/TZsRj3yEQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=Fx5tt33A; arc=fail smtp.client-ip=40.107.15.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="Fx5tt33A" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l9Pdi2wW5Ob+yg5uT08YwW6vEwYoqoYDNRhWM4jBQGKfy0XWb/ADD4JqFFYg05WMS6kZmdpBOXi826xfDj6NTJWp/VrkN6yGnodKFnu3C1kqD3XQ32ihKJvQeFPL1hmxtcXn9OK/qbXIbt7fF0Mw3tESw7AuaEMjPLU3D0ujyrhMEzZTKa1UkxNpaexoSdMvrp2EywMbvUW0d8BSVitFdpjPS4I689i44qRt08A+dBm1RO+1DdNjeMeeXM5ObjLiN4jnLRpwwNvQvdfvcYARYnyliUIBF19igTO/e1Ur7ThZlNxp464qPI2+M4kmsCxNTEzzkXMwhedut/2Yacm8Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E6cSrPxrT85E+2sEoi3YYX8D8I3wXNefinoNnLyn7Qk=; b=DKVtCMzO0+h4p705bMKHehNQaC+m8p4iwCRQ9KwVQvHrs1ulQRFY0dZ4jkid7pjKHm4iKCQDC8KLLfoVX/6oHQHNoE/4g0uHrlba5T30QFfg0am/LsX5+0yeLKRRitt3umeowNY4ah/gJGp7DQ9klFz1e2lqUkDqdr4cdLwOBjy4l604Xc6qotSNRNySyzwA1Wrm+ztDnpNjD7SZSakeGtcbSd6nt5vBd2JXZa0rBA4jxskfULPF4kKQpxqxjI3dX2eWuPFJMq96fo5x2e5nYxKcStmPdmQYQcaSL5yLfXfhu72p/8eyAj0pXaNbRO8Wok6usMQGKOOWnLRxSfKmFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E6cSrPxrT85E+2sEoi3YYX8D8I3wXNefinoNnLyn7Qk=; b=Fx5tt33AvvLBgLDicdtmV0HYTgeA5T0eohz5gZ7FSsgTIDwAuXZ9TqrZ3SuwRpXWgBK7g4KrQUffqT//wECO2FksQRRBRlKYtt93PauNgfxtX0RxcnvBOfrTtf6o8cloqHZfC1+BjnL+4pvThLqYUlzkAhP7DUUI0KjVHV0xYEQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.55; Fri, 12 Apr 2024 00:13:30 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7386.037; Fri, 12 Apr 2024 00:13:30 +0000 From: "Peng Fan (OSS)" Date: Fri, 12 Apr 2024 08:21:21 +0800 Subject: [PATCH v9 3/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support Message-Id: <20240412-pinctrl-scmi-v9-3-b817344d3a9a@nxp.com> References: <20240412-pinctrl-scmi-v9-0-b817344d3a9a@nxp.com> In-Reply-To: <20240412-pinctrl-scmi-v9-0-b817344d3a9a@nxp.com> To: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Dan Carpenter Cc: Dhruva Gole , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan , Oleksii Moisieiev X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1712881290; l=30412; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=YuGhTXxfU5NKLJFYyDuKKzadNTpWoQRGvlpy5+5N94w=; b=nXaqq1WOyi9hvVNFDrBpaor/qtrR7jcm1HideVW6i3z/5szg02fiwdQAsuhh8CP0H1EKCGHWQ YBjAaEWO0X/AwglAT4xYZJmh4GETGDNNOB/nS0YzfihfHnT4VUDA7Ef X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0036.apcprd02.prod.outlook.com (2603:1096:4:1f6::20) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM8PR04MB7970:EE_ X-MS-Office365-Filtering-Correlation-Id: b4a39407-1ca9-4265-d20a-08dc5a85621a X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HnNrpKKDqR3qRixgerXO6N3wfp2MFsmE2zA77geEVfHnmxNNdFg1Js3qO5gMqs6FTp9fruV7P0VKXIyfOZXj+I5ixW5BCuOnQMVpodZfloLTnEcQoCkrjeyVJmK21FLzhZbv7HcvsSZFVdVg60S6VmxxHpPRvEaMvbqzNKyeAV/jv2Pa0tc552XWAB4PHjp8bGg95iuiI3fENbakcqMmEOjbe9SPB3PlfOiIZ/8IrfdooxlXM1Kxs6yPvPyFqQ7naGPheWFBTJUoJnzt7H81HVS7rkTaLMTf+fZPhKcte1Ayo0//2gQnVM6cEMLK506Ig8vRKNp+cPjcNzdM+/gtxrEmzaEZQcp53Ja+z6E/XcIZSk8M3OAG/+NdT46YbwaL2xxYx3byRVdeO8n5HOJO8FXdYdR1NBND2sf1tH8xHWnlwomiTtMx83gS8KGkcP/rLAYX4GkfkC/KbAWk3Rk0hHifpt+B+NOJNdtZe45x2NErG1RDiB5vWzNpt5NvL+lZpumR4KqOoIk4EGi8pNPRo4bu+GPSeY1yq6bTySGmjiz3d39ArrO6hvlvH3llDredPxZUtd1jHLkM0xupY29vudtWO+Ezh8IjW85C1ZjjQO+UmUFeajJJF+E7h7wLaneoX7KEPyqAykP1ELWaLYR6249e9eVXUlasL5sy03yB0eVC4POeByA3n8JChw68GQUk4/A0WbaSSQa9cBcl2ZJwBAGTtXE52LdSskoQ2UEUMjI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR04MB9417.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(52116005)(7416005)(376005)(38350700005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?V2zm64YULp8q00WLS2EZCCznnh4y?= =?utf-8?q?iycvPfCZCMeY0Max20KciAzJ4a9D6nVq+mc8auBXL0K9eq0vAhnqcEqw/e8BDxtHt?= =?utf-8?q?v9cAfMDQt/8LzIMl17WbuiO1KS9JgrojrqtDWoU6iu70mUD4HTvui5WkPMECg226A?= =?utf-8?q?RGT4SiMa/kRCiN8DrxfdANmSEz7yfr6WBH8DgTxpAJg0I+OdhXoRDWiRLRG+D1ANL?= =?utf-8?q?ji7fZwPr7TMXOLE4Uu/FOF5Lvk8iGoqvALyfOxKrD4eWMKrNKdfv9bcMOMfh5gdgu?= =?utf-8?q?JpuqOdhPvvCgMyqMnfvqmhEjkAGffaYY3Ni9QVLcmzC+VmeRnAjiqecKIRr1ynoSU?= =?utf-8?q?GrnyCDeFMywztOGPtDY0mR7Z49YG2HGS7MHON8GlpaPcIGCoFl+m0qItN8+h0UjAn?= =?utf-8?q?bLSjWDcaXiCR9xtk3T/cWKSFXV5aBCXDBe21ucxj8eInSOS0ehfyk2DaTcvnAyy5B?= =?utf-8?q?7VGjqC4Z3PcGjNkVUcrFLGdzJ6Ex0n2VgHKMjrjIoNsSquE3QClQpOOjh+uZqsBaX?= =?utf-8?q?mQR7Fmh5u+za9QDfEi3vvUyvF4scW64lJ7KSt54kzwsn3nys28PZImGBp6rFWNVPM?= =?utf-8?q?Xo6itBfRB+fQFJkcYB6BhuTjDD4CJOHuU8QaFe/eIQbqg8s550fB9DOxJPK8HwUQO?= =?utf-8?q?OPY8CdU3hzPhJuuITeBP5cv7o803PVGHouaDEKnpZ49S/Eelb9RIFYlh1u3NJdYP/?= =?utf-8?q?xCqRFSE0OH1TJNytekXo0sa0LEY/NKz7ZKDLTBNVCenXliCLd7FmgKgn5RUjR2iwi?= =?utf-8?q?Kmslbsscb9KY1tAf6OgXvz6NYRw2JMcAQ+PlQeCngUPgAL3lo+1bQGiV8DQKL6Le1?= =?utf-8?q?TWDus/8QAk+UUxUPHcgn0db6MP0yykx873hFVaRgqAC9NlwLisZwrGdgWhGUiVJi5?= =?utf-8?q?Or6GWYWdzTM5WFs/sF7WglZ/FfCeHfPHbIdEWhViazeyDA8d1mqLl4UBKb7OVBUqD?= =?utf-8?q?dOmUuQIJ4NPpykcoBIdAzIvFlbB7dVG5M0A+c3YSSyEE8Fad+geXOg2O0788iJd/J?= =?utf-8?q?zUy6TQcHGb/Rriyc11051XZqN92Tmd0qJlcOtrlwIjMa+5yFofVAHqjCrRwkBkGMj?= =?utf-8?q?Az+xJc5ZPHpY7k458o34H0R5OMfTXPxNg+bpk8Psd1Ksdq5U2+hNjS073qmKAqU6R?= =?utf-8?q?a40VfjBiolYNYOvTxHLHPN2KqcX0d4UhG4im+VVrZ5V5shLjqhJ7qBTr7gmTqVdnx?= =?utf-8?q?fmsS8JgBcMtT57Xl5/Y/4C3DO0HZs9B2ozfEWezlTE7Gov++csls5ZxUXZgBOfnhD?= =?utf-8?q?MIGgw/GYXaZDyhKQ04dULsuA4eqrfG3fpnnagJLOyJGa/r5wZ4IMTsDn0I1eOZIxE?= =?utf-8?q?ZdHvLob4YgmAejvWegRv3rYRpj2O0Qwu2NvR6v/PO25HWQQwatQJW2pwgiK5BzdS8?= =?utf-8?q?TkQcolNlBIxPrJsAOH1KJhk0X2fDVFLlQ1IFKO+BDW5qhUO95pUScdNR0kSsx1q6o?= =?utf-8?q?k+dzImP1uuj17jp7DFB27O/7ejb1bsQF4Qzp6RZ8OlRxl32YKWqZgGRdNjFGz3jpV?= =?utf-8?q?9mGJfL0GosWB?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b4a39407-1ca9-4265-d20a-08dc5a85621a X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 00:13:30.4769 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HmwpIFJHcpzYAry2iVqZsTd6XKOGpQe0DWzWuFS15OmewZJfBsiarxw0FKyBEAx/+TdZoCcPazdNsHJD/j7Dpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7970 From: Peng Fan Add basic implementation of the SCMI v3.2 pincontrol protocol. Co-developed-by: Oleksii Moisieiev Signed-off-by: Oleksii Moisieiev Co-developed-by: Cristian Marussi Signed-off-by: Cristian Marussi Signed-off-by: Peng Fan --- drivers/firmware/arm_scmi/Makefile | 3 +- drivers/firmware/arm_scmi/driver.c | 2 + drivers/firmware/arm_scmi/pinctrl.c | 916 ++++++++++++++++++++++++++++++++++ drivers/firmware/arm_scmi/protocols.h | 1 + include/linux/scmi_protocol.h | 84 ++++ 5 files changed, 1005 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/arm_scmi/Makefile b/drivers/firmware/arm_scmi/Makefile index a7bc4796519c..fd59f58ce8a2 100644 --- a/drivers/firmware/arm_scmi/Makefile +++ b/drivers/firmware/arm_scmi/Makefile @@ -10,7 +10,8 @@ scmi-transport-$(CONFIG_ARM_SCMI_TRANSPORT_SMC) += smc.o scmi-transport-$(CONFIG_ARM_SCMI_HAVE_MSG) += msg.o scmi-transport-$(CONFIG_ARM_SCMI_TRANSPORT_VIRTIO) += virtio.o scmi-transport-$(CONFIG_ARM_SCMI_TRANSPORT_OPTEE) += optee.o -scmi-protocols-y = base.o clock.o perf.o power.o reset.o sensors.o system.o voltage.o powercap.o +scmi-protocols-y := base.o clock.o perf.o power.o reset.o sensors.o system.o voltage.o powercap.o +scmi-protocols-y += pinctrl.o scmi-module-objs := $(scmi-driver-y) $(scmi-protocols-y) $(scmi-transport-y) obj-$(CONFIG_ARM_SCMI_PROTOCOL) += scmi-core.o diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index a1e0e8fa4bb7..08ecb918e684 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -3209,6 +3209,7 @@ static int __init scmi_driver_init(void) scmi_voltage_register(); scmi_system_register(); scmi_powercap_register(); + scmi_pinctrl_register(); return platform_driver_register(&scmi_driver); } @@ -3226,6 +3227,7 @@ static void __exit scmi_driver_exit(void) scmi_voltage_unregister(); scmi_system_unregister(); scmi_powercap_unregister(); + scmi_pinctrl_unregister(); scmi_transports_exit(); diff --git a/drivers/firmware/arm_scmi/pinctrl.c b/drivers/firmware/arm_scmi/pinctrl.c new file mode 100644 index 000000000000..a2a7f880d6a3 --- /dev/null +++ b/drivers/firmware/arm_scmi/pinctrl.c @@ -0,0 +1,916 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * System Control and Management Interface (SCMI) Pinctrl Protocol + * + * Copyright (C) 2024 EPAM + * Copyright 2024 NXP + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "common.h" +#include "protocols.h" + +/* Updated only after ALL the mandatory features for that version are merged */ +#define SCMI_PROTOCOL_SUPPORTED_VERSION 0x10000 + +#define GET_GROUPS_NR(x) le32_get_bits((x), GENMASK(31, 16)) +#define GET_PINS_NR(x) le32_get_bits((x), GENMASK(15, 0)) +#define GET_FUNCTIONS_NR(x) le32_get_bits((x), GENMASK(15, 0)) + +#define EXT_NAME_FLAG(x) le32_get_bits((x), BIT(31)) +#define NUM_ELEMS(x) le32_get_bits((x), GENMASK(15, 0)) + +#define REMAINING(x) le32_get_bits((x), GENMASK(31, 16)) +#define RETURNED(x) le32_get_bits((x), GENMASK(11, 0)) + +#define CONFIG_FLAG_MASK GENMASK(19, 18) +#define SELECTOR_MASK GENMASK(17, 16) +#define SKIP_CONFIGS_MASK GENMASK(15, 8) +#define CONFIG_TYPE_MASK GENMASK(7, 0) + +enum scmi_pinctrl_protocol_cmd { + PINCTRL_ATTRIBUTES = 0x3, + PINCTRL_LIST_ASSOCIATIONS = 0x4, + PINCTRL_SETTINGS_GET = 0x5, + PINCTRL_SETTINGS_CONFIGURE = 0x6, + PINCTRL_REQUEST = 0x7, + PINCTRL_RELEASE = 0x8, + PINCTRL_NAME_GET = 0x9, + PINCTRL_SET_PERMISSIONS = 0xa, +}; + +struct scmi_msg_settings_conf { + __le32 identifier; + __le32 function_id; + __le32 attributes; + __le32 configs[]; +}; + +struct scmi_msg_settings_get { + __le32 identifier; + __le32 attributes; +}; + +struct scmi_resp_settings_get { + __le32 function_selected; + __le32 num_configs; + __le32 configs[]; +}; + +struct scmi_msg_pinctrl_protocol_attributes { + __le32 attributes_low; + __le32 attributes_high; +}; + +struct scmi_msg_pinctrl_attributes { + __le32 identifier; + __le32 flags; +}; + +struct scmi_resp_pinctrl_attributes { + __le32 attributes; + u8 name[SCMI_SHORT_NAME_MAX_SIZE]; +}; + +struct scmi_msg_pinctrl_list_assoc { + __le32 identifier; + __le32 flags; + __le32 index; +}; + +struct scmi_resp_pinctrl_list_assoc { + __le32 flags; + __le16 array[]; +}; + +struct scmi_msg_request { + __le32 identifier; + __le32 flags; +}; + +struct scmi_group_info { + char name[SCMI_MAX_STR_SIZE]; + bool present; + u32 *group_pins; + u32 nr_pins; +}; + +struct scmi_function_info { + char name[SCMI_MAX_STR_SIZE]; + bool present; + u32 *groups; + u32 nr_groups; +}; + +struct scmi_pin_info { + char name[SCMI_MAX_STR_SIZE]; + bool present; +}; + +struct scmi_pinctrl_info { + u32 version; + int nr_groups; + int nr_functions; + int nr_pins; + struct scmi_group_info *groups; + struct scmi_function_info *functions; + struct scmi_pin_info *pins; +}; + +static int scmi_pinctrl_attributes_get(const struct scmi_protocol_handle *ph, + struct scmi_pinctrl_info *pi) +{ + int ret; + struct scmi_xfer *t; + struct scmi_msg_pinctrl_protocol_attributes *attr; + + ret = ph->xops->xfer_get_init(ph, PROTOCOL_ATTRIBUTES, 0, sizeof(*attr), &t); + if (ret) + return ret; + + attr = t->rx.buf; + + ret = ph->xops->do_xfer(ph, t); + if (!ret) { + pi->nr_functions = GET_FUNCTIONS_NR(attr->attributes_high); + pi->nr_groups = GET_GROUPS_NR(attr->attributes_low); + pi->nr_pins = GET_PINS_NR(attr->attributes_low); + if (pi->nr_pins == 0) { + dev_warn(ph->dev, "returned zero pins\n"); + ret = -EINVAL; + } + } + + ph->xops->xfer_put(ph, t); + return ret; +} + +static int scmi_pinctrl_count_get(const struct scmi_protocol_handle *ph, + enum scmi_pinctrl_selector_type type) +{ + struct scmi_pinctrl_info *pi = ph->get_priv(ph); + + switch (type) { + case PIN_TYPE: + return pi->nr_pins; + case GROUP_TYPE: + return pi->nr_groups; + case FUNCTION_TYPE: + return pi->nr_functions; + default: + return -EINVAL; + } +} + +static int scmi_pinctrl_validate_id(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type) +{ + int value; + + value = scmi_pinctrl_count_get(ph, type); + if (value < 0) + return value; + + if (selector >= value || value == 0) + return -EINVAL; + + return 0; +} + +static int scmi_pinctrl_attributes(const struct scmi_protocol_handle *ph, + enum scmi_pinctrl_selector_type type, + u32 selector, char *name, + u32 *n_elems) +{ + int ret; + struct scmi_xfer *t; + struct scmi_msg_pinctrl_attributes *tx; + struct scmi_resp_pinctrl_attributes *rx; + bool ext_name_flag; + + if (!name) + return -EINVAL; + + ret = scmi_pinctrl_validate_id(ph, selector, type); + if (ret) + return ret; + + ret = ph->xops->xfer_get_init(ph, PINCTRL_ATTRIBUTES, sizeof(*tx), + sizeof(*rx), &t); + if (ret) + return ret; + + tx = t->tx.buf; + rx = t->rx.buf; + tx->identifier = cpu_to_le32(selector); + tx->flags = cpu_to_le32(type); + + ret = ph->xops->do_xfer(ph, t); + if (!ret) { + if (n_elems) + *n_elems = NUM_ELEMS(rx->attributes); + + strscpy(name, rx->name, SCMI_SHORT_NAME_MAX_SIZE); + + ext_name_flag = !!EXT_NAME_FLAG(rx->attributes); + } + + ph->xops->xfer_put(ph, t); + + if (ret) + return ret; + /* + * If supported overwrite short name with the extended one; + * on error just carry on and use already provided short name. + */ + if (ext_name_flag) + ret = ph->hops->extended_name_get(ph, PINCTRL_NAME_GET, + selector, (u32 *)&type, name, + SCMI_MAX_STR_SIZE); + return ret; +} + +struct scmi_pinctrl_ipriv { + u32 selector; + enum scmi_pinctrl_selector_type type; + u32 *array; +}; + +static void iter_pinctrl_assoc_prepare_message(void *message, + u32 desc_index, + const void *priv) +{ + struct scmi_msg_pinctrl_list_assoc *msg = message; + const struct scmi_pinctrl_ipriv *p = priv; + + msg->identifier = cpu_to_le32(p->selector); + msg->flags = cpu_to_le32(p->type); + msg->index = cpu_to_le32(desc_index); +} + +static int iter_pinctrl_assoc_update_state(struct scmi_iterator_state *st, + const void *response, void *priv) +{ + const struct scmi_resp_pinctrl_list_assoc *r = response; + + st->num_returned = RETURNED(r->flags); + st->num_remaining = REMAINING(r->flags); + + return 0; +} + +static int +iter_pinctrl_assoc_process_response(const struct scmi_protocol_handle *ph, + const void *response, + struct scmi_iterator_state *st, void *priv) +{ + const struct scmi_resp_pinctrl_list_assoc *r = response; + struct scmi_pinctrl_ipriv *p = priv; + + p->array[st->desc_index + st->loop_idx] = + le16_to_cpu(r->array[st->loop_idx]); + + return 0; +} + +static int scmi_pinctrl_list_associations(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + u16 size, u32 *array) +{ + int ret; + void *iter; + struct scmi_iterator_ops ops = { + .prepare_message = iter_pinctrl_assoc_prepare_message, + .update_state = iter_pinctrl_assoc_update_state, + .process_response = iter_pinctrl_assoc_process_response, + }; + struct scmi_pinctrl_ipriv ipriv = { + .selector = selector, + .type = type, + .array = array, + }; + + if (!array || !size || type == PIN_TYPE) + return -EINVAL; + + ret = scmi_pinctrl_validate_id(ph, selector, type); + if (ret) + return ret; + + iter = ph->hops->iter_response_init(ph, &ops, size, + PINCTRL_LIST_ASSOCIATIONS, + sizeof(struct scmi_msg_pinctrl_list_assoc), + &ipriv); + if (IS_ERR(iter)) + return PTR_ERR(iter); + + return ph->hops->iter_response_run(iter); +} + +struct scmi_settings_get_ipriv { + u32 selector; + enum scmi_pinctrl_selector_type type; + bool get_all; + unsigned int *nr_configs; + enum scmi_pinctrl_conf_type *config_types; + u32 *config_values; +}; + +static void +iter_pinctrl_settings_get_prepare_message(void *message, u32 desc_index, + const void *priv) +{ + struct scmi_msg_settings_get *msg = message; + const struct scmi_settings_get_ipriv *p = priv; + u32 attributes; + + attributes = FIELD_PREP(SELECTOR_MASK, p->type); + + if (p->get_all) { + attributes |= FIELD_PREP(CONFIG_FLAG_MASK, 1) | + FIELD_PREP(SKIP_CONFIGS_MASK, desc_index); + } else { + attributes |= FIELD_PREP(CONFIG_TYPE_MASK, p->config_types[0]); + } + + msg->attributes = cpu_to_le32(attributes); + msg->identifier = cpu_to_le32(p->selector); +} + +static int +iter_pinctrl_settings_get_update_state(struct scmi_iterator_state *st, + const void *response, void *priv) +{ + const struct scmi_resp_settings_get *r = response; + struct scmi_settings_get_ipriv *p = priv; + + if (p->get_all) { + st->num_returned = le32_get_bits(r->num_configs, GENMASK(7, 0)); + st->num_remaining = le32_get_bits(r->num_configs, GENMASK(31, 24)); + } else { + st->num_returned = 1; + st->num_remaining = 0; + } + + return 0; +} + +static int +iter_pinctrl_settings_get_process_response(const struct scmi_protocol_handle *ph, + const void *response, + struct scmi_iterator_state *st, + void *priv) +{ + const struct scmi_resp_settings_get *r = response; + struct scmi_settings_get_ipriv *p = priv; + u32 type = le32_get_bits(r->configs[st->loop_idx * 2], GENMASK(7, 0)); + u32 val = le32_to_cpu(r->configs[st->loop_idx * 2 + 1]); + + if (p->get_all) { + p->config_types[st->desc_index + st->loop_idx] = type; + } else { + if (p->config_types[0] != type) + return -EINVAL; + } + + p->config_values[st->desc_index + st->loop_idx] = val; + ++*p->nr_configs; + + return 0; +} + +static int +scmi_pinctrl_settings_get(const struct scmi_protocol_handle *ph, u32 selector, + enum scmi_pinctrl_selector_type type, + unsigned int *nr_configs, + enum scmi_pinctrl_conf_type *config_types, + u32 *config_values) +{ + int ret; + void *iter; + unsigned int max_configs = *nr_configs; + struct scmi_iterator_ops ops = { + .prepare_message = iter_pinctrl_settings_get_prepare_message, + .update_state = iter_pinctrl_settings_get_update_state, + .process_response = iter_pinctrl_settings_get_process_response, + }; + struct scmi_settings_get_ipriv ipriv = { + .selector = selector, + .type = type, + .get_all = (max_configs > 1), + .nr_configs = nr_configs, + .config_types = config_types, + .config_values = config_values, + }; + + if (!config_types || !config_values || type == FUNCTION_TYPE) + return -EINVAL; + + ret = scmi_pinctrl_validate_id(ph, selector, type); + if (ret) + return ret; + + /* Prepare to count returned configs */ + *nr_configs = 0; + iter = ph->hops->iter_response_init(ph, &ops, max_configs, + PINCTRL_SETTINGS_GET, + sizeof(struct scmi_msg_settings_get), + &ipriv); + if (IS_ERR(iter)) + return PTR_ERR(iter); + + return ph->hops->iter_response_run(iter); +} + +static int scmi_pinctrl_settings_get_one(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + enum scmi_pinctrl_conf_type config_type, + u32 *config_value) +{ + unsigned int nr_configs = 1; + + return scmi_pinctrl_settings_get(ph, selector, type, &nr_configs, + &config_type, config_value); +} + +static int scmi_pinctrl_settings_get_all(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + unsigned int *nr_configs, + enum scmi_pinctrl_conf_type *config_types, + u32 *config_values) +{ + if (!nr_configs || *nr_configs == 0) + return -EINVAL; + + return scmi_pinctrl_settings_get(ph, selector, type, nr_configs, + config_types, config_values); +} + +static int +scmi_pinctrl_settings_conf(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + u32 nr_configs, + enum scmi_pinctrl_conf_type *config_type, + u32 *config_value) +{ + struct scmi_xfer *t; + struct scmi_msg_settings_conf *tx; + u32 attributes; + int ret, i; + u32 configs_in_chunk, conf_num = 0; + u32 chunk; + int max_msg_size = ph->hops->get_max_msg_size(ph); + + if (!config_type || !config_value || type == FUNCTION_TYPE) + return -EINVAL; + + ret = scmi_pinctrl_validate_id(ph, selector, type); + if (ret) + return ret; + + configs_in_chunk = (max_msg_size - sizeof(*tx)) / (sizeof(__le32) * 2); + while (conf_num < nr_configs) { + chunk = (nr_configs - conf_num > configs_in_chunk) ? + configs_in_chunk : nr_configs - conf_num; + + ret = ph->xops->xfer_get_init(ph, PINCTRL_SETTINGS_CONFIGURE, + sizeof(*tx) + + chunk * 2 * sizeof(__le32), 0, &t); + if (ret) + break; + + tx = t->tx.buf; + tx->identifier = cpu_to_le32(selector); + tx->function_id = cpu_to_le32(0xFFFFFFFF); + attributes = FIELD_PREP(GENMASK(1, 0), type) | + FIELD_PREP(GENMASK(9, 2), chunk); + tx->attributes = cpu_to_le32(attributes); + + for (i = 0; i < chunk; i++) { + tx->configs[i * 2] = + cpu_to_le32(config_type[conf_num + i]); + tx->configs[i * 2 + 1] = + cpu_to_le32(config_value[conf_num + i]); + } + + ret = ph->xops->do_xfer(ph, t); + + ph->xops->xfer_put(ph, t); + + if (ret) + break; + + conf_num += chunk; + } + + return ret; +} + +static int scmi_pinctrl_function_select(const struct scmi_protocol_handle *ph, + u32 group, + enum scmi_pinctrl_selector_type type, + u32 function_id) +{ + int ret; + struct scmi_xfer *t; + struct scmi_msg_settings_conf *tx; + u32 attributes; + + ret = scmi_pinctrl_validate_id(ph, group, type); + if (ret) + return ret; + + ret = ph->xops->xfer_get_init(ph, PINCTRL_SETTINGS_CONFIGURE, + sizeof(*tx), 0, &t); + if (ret) + return ret; + + tx = t->tx.buf; + tx->identifier = cpu_to_le32(group); + tx->function_id = cpu_to_le32(function_id); + attributes = FIELD_PREP(GENMASK(1, 0), type) | BIT(10); + tx->attributes = cpu_to_le32(attributes); + + ret = ph->xops->do_xfer(ph, t); + ph->xops->xfer_put(ph, t); + + return ret; +} + +static int scmi_pinctrl_request_free(const struct scmi_protocol_handle *ph, + u32 identifier, + enum scmi_pinctrl_selector_type type, + enum scmi_pinctrl_protocol_cmd cmd) +{ + int ret; + struct scmi_xfer *t; + struct scmi_msg_request *tx; + + if (type == FUNCTION_TYPE) + return -EINVAL; + + if (cmd != PINCTRL_REQUEST && cmd != PINCTRL_RELEASE) + return -EINVAL; + + ret = scmi_pinctrl_validate_id(ph, identifier, type); + if (ret) + return ret; + + ret = ph->xops->xfer_get_init(ph, cmd, sizeof(*tx), 0, &t); + if (ret) + return ret; + + tx = t->tx.buf; + tx->identifier = cpu_to_le32(identifier); + tx->flags = cpu_to_le32(type); + + ret = ph->xops->do_xfer(ph, t); + ph->xops->xfer_put(ph, t); + + return ret; +} + +static int scmi_pinctrl_pin_request(const struct scmi_protocol_handle *ph, + u32 pin) +{ + return scmi_pinctrl_request_free(ph, pin, PIN_TYPE, PINCTRL_REQUEST); +} + +static int scmi_pinctrl_pin_free(const struct scmi_protocol_handle *ph, u32 pin) +{ + return scmi_pinctrl_request_free(ph, pin, PIN_TYPE, PINCTRL_RELEASE); +} + +static int scmi_pinctrl_get_group_info(const struct scmi_protocol_handle *ph, + u32 selector, + struct scmi_group_info *group) +{ + int ret; + + ret = scmi_pinctrl_attributes(ph, GROUP_TYPE, selector, group->name, + &group->nr_pins); + if (ret) + return ret; + + if (!group->nr_pins) { + dev_err(ph->dev, "Group %d has 0 elements", selector); + return -ENODATA; + } + + group->group_pins = kmalloc_array(group->nr_pins, + sizeof(*group->group_pins), + GFP_KERNEL); + if (!group->group_pins) + return -ENOMEM; + + ret = scmi_pinctrl_list_associations(ph, selector, GROUP_TYPE, + group->nr_pins, group->group_pins); + if (ret) { + kfree(group->group_pins); + return ret; + } + + group->present = true; + return 0; +} + +static int scmi_pinctrl_get_group_name(const struct scmi_protocol_handle *ph, + u32 selector, const char **name) +{ + struct scmi_pinctrl_info *pi = ph->get_priv(ph); + + if (!name) + return -EINVAL; + + if (selector >= pi->nr_groups || pi->nr_groups == 0) + return -EINVAL; + + if (!pi->groups[selector].present) { + int ret; + + ret = scmi_pinctrl_get_group_info(ph, selector, + &pi->groups[selector]); + if (ret) + return ret; + } + + *name = pi->groups[selector].name; + + return 0; +} + +static int scmi_pinctrl_group_pins_get(const struct scmi_protocol_handle *ph, + u32 selector, const u32 **pins, + u32 *nr_pins) +{ + struct scmi_pinctrl_info *pi = ph->get_priv(ph); + + if (!pins || !nr_pins) + return -EINVAL; + + if (selector >= pi->nr_groups || pi->nr_groups == 0) + return -EINVAL; + + if (!pi->groups[selector].present) { + int ret; + + ret = scmi_pinctrl_get_group_info(ph, selector, + &pi->groups[selector]); + if (ret) + return ret; + } + + *pins = pi->groups[selector].group_pins; + *nr_pins = pi->groups[selector].nr_pins; + + return 0; +} + +static int scmi_pinctrl_get_function_info(const struct scmi_protocol_handle *ph, + u32 selector, + struct scmi_function_info *func) +{ + int ret; + + ret = scmi_pinctrl_attributes(ph, FUNCTION_TYPE, selector, func->name, + &func->nr_groups); + if (ret) + return ret; + + if (!func->nr_groups) { + dev_err(ph->dev, "Function %d has 0 elements", selector); + return -ENODATA; + } + + func->groups = kmalloc_array(func->nr_groups, sizeof(*func->groups), + GFP_KERNEL); + if (!func->groups) + return -ENOMEM; + + ret = scmi_pinctrl_list_associations(ph, selector, FUNCTION_TYPE, + func->nr_groups, func->groups); + if (ret) { + kfree(func->groups); + return ret; + } + + func->present = true; + return 0; +} + +static int scmi_pinctrl_get_function_name(const struct scmi_protocol_handle *ph, + u32 selector, const char **name) +{ + struct scmi_pinctrl_info *pi = ph->get_priv(ph); + + if (!name) + return -EINVAL; + + if (selector >= pi->nr_functions || pi->nr_functions == 0) + return -EINVAL; + + if (!pi->functions[selector].present) { + int ret; + + ret = scmi_pinctrl_get_function_info(ph, selector, + &pi->functions[selector]); + if (ret) + return ret; + } + + *name = pi->functions[selector].name; + return 0; +} + +static int +scmi_pinctrl_function_groups_get(const struct scmi_protocol_handle *ph, + u32 selector, u32 *nr_groups, + const u32 **groups) +{ + struct scmi_pinctrl_info *pi = ph->get_priv(ph); + + if (!groups || !nr_groups) + return -EINVAL; + + if (selector >= pi->nr_functions || pi->nr_functions == 0) + return -EINVAL; + + if (!pi->functions[selector].present) { + int ret; + + ret = scmi_pinctrl_get_function_info(ph, selector, + &pi->functions[selector]); + if (ret) + return ret; + } + + *groups = pi->functions[selector].groups; + *nr_groups = pi->functions[selector].nr_groups; + + return 0; +} + +static int scmi_pinctrl_mux_set(const struct scmi_protocol_handle *ph, + u32 selector, u32 group) +{ + return scmi_pinctrl_function_select(ph, group, GROUP_TYPE, selector); +} + +static int scmi_pinctrl_get_pin_info(const struct scmi_protocol_handle *ph, + u32 selector, struct scmi_pin_info *pin) +{ + int ret; + + if (!pin) + return -EINVAL; + + ret = scmi_pinctrl_attributes(ph, PIN_TYPE, selector, pin->name, NULL); + if (ret) + return ret; + + pin->present = true; + return 0; +} + +static int scmi_pinctrl_get_pin_name(const struct scmi_protocol_handle *ph, + u32 selector, const char **name) +{ + struct scmi_pinctrl_info *pi = ph->get_priv(ph); + + if (!name) + return -EINVAL; + + if (selector >= pi->nr_pins) + return -EINVAL; + + if (!pi->pins[selector].present) { + int ret; + + ret = scmi_pinctrl_get_pin_info(ph, selector, &pi->pins[selector]); + if (ret) + return ret; + } + + *name = pi->pins[selector].name; + + return 0; +} + +static int scmi_pinctrl_name_get(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + const char **name) +{ + switch (type) { + case PIN_TYPE: + return scmi_pinctrl_get_pin_name(ph, selector, name); + case GROUP_TYPE: + return scmi_pinctrl_get_group_name(ph, selector, name); + case FUNCTION_TYPE: + return scmi_pinctrl_get_function_name(ph, selector, name); + default: + return -EINVAL; + } +} + +static const struct scmi_pinctrl_proto_ops pinctrl_proto_ops = { + .count_get = scmi_pinctrl_count_get, + .name_get = scmi_pinctrl_name_get, + .group_pins_get = scmi_pinctrl_group_pins_get, + .function_groups_get = scmi_pinctrl_function_groups_get, + .mux_set = scmi_pinctrl_mux_set, + .settings_get_one = scmi_pinctrl_settings_get_one, + .settings_get_all = scmi_pinctrl_settings_get_all, + .settings_conf = scmi_pinctrl_settings_conf, + .pin_request = scmi_pinctrl_pin_request, + .pin_free = scmi_pinctrl_pin_free, +}; + +static int scmi_pinctrl_protocol_init(const struct scmi_protocol_handle *ph) +{ + int ret; + u32 version; + struct scmi_pinctrl_info *pinfo; + + ret = ph->xops->version_get(ph, &version); + if (ret) + return ret; + + dev_dbg(ph->dev, "Pinctrl Version %d.%d\n", + PROTOCOL_REV_MAJOR(version), PROTOCOL_REV_MINOR(version)); + + pinfo = devm_kzalloc(ph->dev, sizeof(*pinfo), GFP_KERNEL); + if (!pinfo) + return -ENOMEM; + + ret = scmi_pinctrl_attributes_get(ph, pinfo); + if (ret) + return ret; + + pinfo->pins = devm_kcalloc(ph->dev, pinfo->nr_pins, + sizeof(*pinfo->pins), GFP_KERNEL); + if (!pinfo->pins) + return -ENOMEM; + + pinfo->groups = devm_kcalloc(ph->dev, pinfo->nr_groups, + sizeof(*pinfo->groups), GFP_KERNEL); + if (!pinfo->groups) + return -ENOMEM; + + pinfo->functions = devm_kcalloc(ph->dev, pinfo->nr_functions, + sizeof(*pinfo->functions), GFP_KERNEL); + if (!pinfo->functions) + return -ENOMEM; + + pinfo->version = version; + + return ph->set_priv(ph, pinfo, version); +} + +static int scmi_pinctrl_protocol_deinit(const struct scmi_protocol_handle *ph) +{ + int i; + struct scmi_pinctrl_info *pi = ph->get_priv(ph); + + /* Free groups_pins allocated in scmi_pinctrl_get_group_info */ + for (i = 0; i < pi->nr_groups; i++) { + if (pi->groups[i].present) { + kfree(pi->groups[i].group_pins); + pi->groups[i].present = false; + } + } + + /* Free groups allocated in scmi_pinctrl_get_function_info */ + for (i = 0; i < pi->nr_functions; i++) { + if (pi->functions[i].present) { + kfree(pi->functions[i].groups); + pi->functions[i].present = false; + } + } + + return 0; +} + +static const struct scmi_protocol scmi_pinctrl = { + .id = SCMI_PROTOCOL_PINCTRL, + .owner = THIS_MODULE, + .instance_init = &scmi_pinctrl_protocol_init, + .instance_deinit = &scmi_pinctrl_protocol_deinit, + .ops = &pinctrl_proto_ops, + .supported_version = SCMI_PROTOCOL_SUPPORTED_VERSION, +}; +DEFINE_SCMI_PROTOCOL_REGISTER_UNREGISTER(pinctrl, scmi_pinctrl) diff --git a/drivers/firmware/arm_scmi/protocols.h b/drivers/firmware/arm_scmi/protocols.h index 3e91536a77a3..c02cbfd2bb03 100644 --- a/drivers/firmware/arm_scmi/protocols.h +++ b/drivers/firmware/arm_scmi/protocols.h @@ -355,6 +355,7 @@ void __exit scmi_##name##_unregister(void) \ DECLARE_SCMI_REGISTER_UNREGISTER(base); DECLARE_SCMI_REGISTER_UNREGISTER(clock); DECLARE_SCMI_REGISTER_UNREGISTER(perf); +DECLARE_SCMI_REGISTER_UNREGISTER(pinctrl); DECLARE_SCMI_REGISTER_UNREGISTER(power); DECLARE_SCMI_REGISTER_UNREGISTER(reset); DECLARE_SCMI_REGISTER_UNREGISTER(sensors); diff --git a/include/linux/scmi_protocol.h b/include/linux/scmi_protocol.h index a3addb07e00a..3a9bb5b9a9e8 100644 --- a/include/linux/scmi_protocol.h +++ b/include/linux/scmi_protocol.h @@ -737,6 +737,89 @@ struct scmi_powercap_proto_ops { u32 *power_thresh_high); }; +enum scmi_pinctrl_selector_type { + PIN_TYPE = 0, + GROUP_TYPE, + FUNCTION_TYPE, +}; + +enum scmi_pinctrl_conf_type { + SCMI_PIN_DEFAULT = 0, + SCMI_PIN_BIAS_BUS_HOLD = 1, + SCMI_PIN_BIAS_DISABLE = 2, + SCMI_PIN_BIAS_HIGH_IMPEDANCE = 3, + SCMI_PIN_BIAS_PULL_UP = 4, + SCMI_PIN_BIAS_PULL_DEFAULT = 5, + SCMI_PIN_BIAS_PULL_DOWN = 6, + SCMI_PIN_DRIVE_OPEN_DRAIN = 7, + SCMI_PIN_DRIVE_OPEN_SOURCE = 8, + SCMI_PIN_DRIVE_PUSH_PULL = 9, + SCMI_PIN_DRIVE_STRENGTH = 10, + SCMI_PIN_INPUT_DEBOUNCE = 11, + SCMI_PIN_INPUT_MODE = 12, + SCMI_PIN_PULL_MODE = 13, + SCMI_PIN_INPUT_VALUE = 14, + SCMI_PIN_INPUT_SCHMITT = 15, + SCMI_PIN_LOW_POWER_MODE = 16, + SCMI_PIN_OUTPUT_MODE = 17, + SCMI_PIN_OUTPUT_VALUE = 18, + SCMI_PIN_POWER_SOURCE = 19, + SCMI_PIN_SLEW_RATE = 20, + SCMI_PIN_OEM_START = 192, + SCMI_PIN_OEM_END = 255, +}; + +/** + * struct scmi_pinctrl_proto_ops - represents the various operations provided + * by SCMI Pinctrl Protocol + * + * @count_get: returns count of the registered elements in given type + * @name_get: returns name by index of given type + * @group_pins_get: returns the set of pins, assigned to the specified group + * @function_groups_get: returns the set of groups, assigned to the specified + * function + * @mux_set: set muxing function for groups of pins + * @settings_get_one: returns one configuration parameter for pin or group + * specified by config_type + * @settings_get_all: returns all configuration parameters for pin or group + * @settings_conf: sets the configuration parameter for pin or group + * @pin_request: aquire pin before selecting mux setting + * @pin_free: frees pin, acquired by request_pin call + */ +struct scmi_pinctrl_proto_ops { + int (*count_get)(const struct scmi_protocol_handle *ph, + enum scmi_pinctrl_selector_type type); + int (*name_get)(const struct scmi_protocol_handle *ph, u32 selector, + enum scmi_pinctrl_selector_type type, + const char **name); + int (*group_pins_get)(const struct scmi_protocol_handle *ph, + u32 selector, const unsigned int **pins, + unsigned int *nr_pins); + int (*function_groups_get)(const struct scmi_protocol_handle *ph, + u32 selector, unsigned int *nr_groups, + const unsigned int **groups); + int (*mux_set)(const struct scmi_protocol_handle *ph, u32 selector, + u32 group); + int (*settings_get_one)(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + enum scmi_pinctrl_conf_type config_type, + u32 *config_value); + int (*settings_get_all)(const struct scmi_protocol_handle *ph, + u32 selector, + enum scmi_pinctrl_selector_type type, + unsigned int *nr_configs, + enum scmi_pinctrl_conf_type *config_types, + u32 *config_values); + int (*settings_conf)(const struct scmi_protocol_handle *ph, + u32 selector, enum scmi_pinctrl_selector_type type, + unsigned int nr_configs, + enum scmi_pinctrl_conf_type *config_type, + u32 *config_value); + int (*pin_request)(const struct scmi_protocol_handle *ph, u32 pin); + int (*pin_free)(const struct scmi_protocol_handle *ph, u32 pin); +}; + /** * struct scmi_notify_ops - represents notifications' operations provided by * SCMI core @@ -842,6 +925,7 @@ enum scmi_std_protocol { SCMI_PROTOCOL_RESET = 0x16, SCMI_PROTOCOL_VOLTAGE = 0x17, SCMI_PROTOCOL_POWERCAP = 0x18, + SCMI_PROTOCOL_PINCTRL = 0x19, }; enum scmi_system_events { From patchwork Fri Apr 12 00:21:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan \(OSS\)" X-Patchwork-Id: 788432 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2059.outbound.protection.outlook.com [40.107.15.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0B46259C; Fri, 12 Apr 2024 00:13:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.15.59 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712880821; cv=fail; b=CFo79iyVfFvmDUw/mDj848ViDeQDNS5dK3Lm9RtrEFHuwDTURc+awFqkPyyV3CQwEBdJtSeo6BGrcakzTzKuvXFYGYfNPqierDZvzHgiSMk7OtME+rL3sDvIgm7lC+O9mVvDlZymQ6gRchJXI32sq86hDpBC5tzc7ZRlLhbKy5g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712880821; c=relaxed/simple; bh=7Z2tRgO6oRQ0/W9Dx1T02HNy3A7OLUJWRAQZ2S2tEB4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=afCTxXoiyzdlwqjpGLHYVmNdfnEK7x/sOqO0YKX4zjnb8kpUkUg3EzCwqA1q1TfmNcGmihe4hEreNELUPdhzWPXrJFwujXC9u0XL5q8zWMXpvGat3b5GvLmgOlbQnH0eMHBVxPyMsXP6Ely16aK32TUeya3/rzNG2lIZ86rDAeo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=VDJHk7dG; arc=fail smtp.client-ip=40.107.15.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="VDJHk7dG" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=afk1iKxT57EDUxt7Wt1CxTE8Fa46gb1EjSU8Z8uCu4ejTGOZ8+0eEgYoq9J0Lwj2AmzlymFZfTvyI1HfvcTO9iSBehKFt0iYnMJ8dA2lWXuSf4moV4WZwVsniloB1paqKNmDinVE9Fky3uxjPWxGI2J5E217+OVeD9BjcXiYFrPWZG/1eHAwk9AtkZM/jJRPGBneA2YDiYT2sHiqEfmUHmweveJVuv/Rnr/gsPWiXPtgDodCDeyQjGjSwx9j8LtxBUJxvMFERIjI2DoYmFzATlJJumLID3W8BaSgabm5eY5dxg6/EcOTspfBIek+Q8uM5/bkcCA0KNt8cRX1xJ7mIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YrWyZTDNukgiNUCKnVSqOjv6er7VIX9OOGY0qRGlBcQ=; b=AGl9xgBq2lBWvSa4NJ1TXk4BWX78cmNNTlCGuoT57GjIeYQVQs5qPf0/LKJYtVDDjPd6fL92WwanurMKKDzxx9DRO7EL+oySsUv87qdUnQ7Ux0HblEUtPko+chwpHHrBpjjnwq+HuD+YfuRbIyxQT5hU8CaQhIOOFBBsDXVwV/SeTZm3aF45KjobfMQb6O7bDWGC2AvZ92mGfAHXx9BtCcQkR1yD8TaeKY+1AnATUgtqGbawE1lAkBAlJux/odu/WxAjx2FeI/fJEDZiaKHg1PqzrbPi5HHujVuGRiUpm1DCy/sUWSVqRNhReFrBOaKRaY1LXwRCwxEliG7odEUNwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YrWyZTDNukgiNUCKnVSqOjv6er7VIX9OOGY0qRGlBcQ=; b=VDJHk7dG9KsetRMYVYC58f+/QJ4Zbo7ZQkUJU6I6hMz+8w12r+51hdYoMYo+hjDb8hJ1MkMNglvtvMbgOm37lvD42WvI/qmNs19omJbjX51aJ+32yxIfpqSvp6ueq4u/UbK/X+65UoecCFH3u6XE3n2wTt8qMC0BzVXLbi4gpcY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM8PR04MB7970.eurprd04.prod.outlook.com (2603:10a6:20b:24f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.55; Fri, 12 Apr 2024 00:13:35 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7386.037; Fri, 12 Apr 2024 00:13:35 +0000 From: "Peng Fan (OSS)" Date: Fri, 12 Apr 2024 08:21:22 +0800 Subject: [PATCH v9 4/4] pinctrl: Implementation of the generic scmi-pinctrl driver Message-Id: <20240412-pinctrl-scmi-v9-4-b817344d3a9a@nxp.com> References: <20240412-pinctrl-scmi-v9-0-b817344d3a9a@nxp.com> In-Reply-To: <20240412-pinctrl-scmi-v9-0-b817344d3a9a@nxp.com> To: Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Dan Carpenter Cc: Dhruva Gole , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan , Oleksii Moisieiev X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1712881290; l=18286; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=5LE/T4pxx22bA6Cfq3V+7W+OxEZdT/+5oGR7VGvEF0Y=; b=xflUItwUf3wD4CpOGAJQwizb0ZMr+I4q4FY0Om25kCn30JL7cazhu+ZodoDoFWg/fMVF+h6vl lq9OZb5Pg1UAyIm7zRAw1OyhHf4sLVKx8Jmxv/XOoR6iJJHwMsF2bdG X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI1PR02CA0036.apcprd02.prod.outlook.com (2603:1096:4:1f6::20) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|AM8PR04MB7970:EE_ X-MS-Office365-Filtering-Correlation-Id: a30de4dd-2660-4af0-d4c4-08dc5a8564d1 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XKGdxhRcxzu+ImpCqN7XxFslyAjAr29LDmhsNx/tvpi8lbLU0vLqEVA06qJMcUrqwOzjjTTic584GcyRtrpYZQRMrxntAJI/JX+ASxu4Fatu8tDmJNZUycU89h2vwv3QXj6j2RRPeMcMt47ABI3F81IkQK+W9sM7xHUtz+fO7RgxuAuk/A9hAvbbbTotjpbfCZqaBxG+xn5j/lFX1NE78cfUhhZ+467VY679dkdW9lfC/sQnN7w88WwuZadrQQQ3zUQ61Wbr5c+rQFbGGHkD1p9DfzxO5O/xgpKyTOyIbvUNINTL2PkrdyxRCuR3Mg/Bc/+rv7jA7Wc0t+3QYSjXL8wnRtVu8n9B6oCri7bbNCJO+kINdtU1Az/i7KnrsF+neEYeaj82++cqYA5BpDnAqSSP7HIs/xY9hn8YgrYN2xsVv0AQcvKRYzBHSIQFr0WcypHfR9ynK/XAH680wgZgLOZ9Fm6JC3TmDEnAphuHIpv41/jefzGPClSuogYdrXpmxTza56nwvbAt3mPRrDFBTfjOEXZkhhQPeV4DLp74TuvTdPvJzVND/BCtKdHam9rgBXtRLYePtxw0Y3N6CWbx1NeMGh0T/1B0OZDsDeIM1plZcNVEexrvsReHpJnHi+XEZ6uiJtNPuGBG6hoyRDJSBdtf/oLgmIyhjZ5z3hLeI+WxCHE8znZMEr1XU+2f2y0H12mQG/ivlAfqgxD3+CFZuyISfBs3vP3OIPkhLiOJj10= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR04MB9417.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(52116005)(7416005)(376005)(38350700005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?4qMOMuqdMG70Eh3XmPRj7ExAlEhr?= =?utf-8?q?V5kZ8/CsGmh+x/FiOppiyEMAf97OLpeYhx1CpM1YaYthU+8RRyf35kWL5qszzB+Q4?= =?utf-8?q?Bh/nqufDwppYk5x8/Gj8pIBK+qvGOvi2MJr6ZVPuoLve26mG/bUCkh4GYUMhSnmIs?= =?utf-8?q?ue3IZClZDfjA4WsdOJYrGP3E8HGcTB6c87Bvv49UNKSzQCvHCsJp3Q9g+STxVRRPh?= =?utf-8?q?WpHH8sN/mf+RXj/bR//fB0y9QqyhZ0blTuJSGxVhKbiMPY1vDSdjm9ZH9Q6VGmhLk?= =?utf-8?q?cPvOuL6gCiOEsyXj313USQ54JGKJnO4roww5d3kdxUqqKqr3fK6a/Hjn5up/5UdTg?= =?utf-8?q?EnfSAhFT7C0qyKQ303juNUm79MmXpv7GtfYCMCPpqdwi0UekdsaLRS9Igo5aiXPqt?= =?utf-8?q?kiYH6dPFug4fuf4T3WRJoWOqF/QUnHE3rCUqvCvjMfY7OMvnIJFR/3ji8lq95H0q5?= =?utf-8?q?DUPfTcxsHOBYUE9ikfC4F+7vNWnow3E3TVDfCNaWunjCH6/Cp+m2jbYdjq/8E7TLA?= =?utf-8?q?Oq6MpurFVDiO9T4PMwqTAF89aXz7L1TIvUjXO5pD92ityjnuMac9cp/sUBZlqc6SB?= =?utf-8?q?ncgJBRvB/pWYTu+0uIdkyfhAAEWTTNGNwv81sHiLCRiSBovkBhnrah53hAQHM1UiJ?= =?utf-8?q?9C/ioV2r6ddiHkBWzb02Jw0ViVFWrDTZEF51E8GuUFwaDS0BzKP2ILfVQy/zQLI/+?= =?utf-8?q?wv7l0hyWaGHVvgvdvGy1+4HORroFQeYTA5uuaAUtcVhVfekYn/m9ARVafqrygvQNs?= =?utf-8?q?xACjyuqMJuWd96/b7dJT4Yie/a2roUfM8dLP28mxxzzJySMour3pucGeWJelMHPN1?= =?utf-8?q?TKLCHtPOVjpomD47pGk2mNn2AuiDPjMY4vz40zMZC6lY3nlmRdBGit1htyuLyPPYS?= =?utf-8?q?Egv1xWC526uncOZrMvoeK7JSELy3DxDydu3kQsz6ii4zb4nnSXztu/oqHSzzDlZkF?= =?utf-8?q?m/t50Zm6ZAYsOHYtrJBCxF7RQSS8sfQsmZ6mNfjbP0Jkjz2pRV7DnwbLpcoxIUU11?= =?utf-8?q?TkOwsweb9XBxza4rjarPiGU2NaxKPxdZF2M6aLy/Dcb0mDiJwBgspmGvZp3bw5zrj?= =?utf-8?q?TNMFAyZe1F6h3xt4VD4giYfaUYqTkeMPWPnxoYgYIzaBZsLE11hlx5wPWi2oZT9Or?= =?utf-8?q?sDHNKIoavjXvuLCd7ikS3ceJfH03iDCF8vMZsmfigjDMXFSC8I3bTRincWhbbMoN7?= =?utf-8?q?KIj2NQcVbkdn+e0PoQVqv+3+lsWyqa/QTbfOZPwPhdUdqg6RPUbHAaTn5yVtHGsp8?= =?utf-8?q?c56ShO/4l3NPR4IVDxQZ2qsgTEzuIdDkGSm/UIUqynypdRKb3pCZ0ibKDYGznyszq?= =?utf-8?q?OmKxV+iI6240pSjHVt/euJGkI1yv15b0y0P9lhaIOQO0XTGLRzXuOGb0ek79ZXSMg?= =?utf-8?q?K07Y+YOlWtXnQaAH7mstOnhmN4ERRgaqb6iiujl122bz0ymZ5Ki08qAi60Fg5xPnA?= =?utf-8?q?0DWRIuH1ez2H+7m6x2hHzKPhLqAc8nkBozkebWYuAwft2f/SuCGw02dpDaiDQjaoI?= =?utf-8?q?KcuoyysVg4yF?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a30de4dd-2660-4af0-d4c4-08dc5a8564d1 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 00:13:34.9515 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mQ01YYxaOLCwSBgIsC7QAm8qbE7kUvB+ra2i5EjaGg9Kwx57Of7QnA9jRRXY0SzVbX54hc68NSfw0xXxNBMnRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7970 From: Peng Fan scmi-pinctrl driver implements pinctrl driver interface and using SCMI protocol to redirect messages from pinctrl subsystem SDK to SCMI platform firmware, which does the changes in HW. Co-developed-by: Oleksii Moisieiev Signed-off-by: Oleksii Moisieiev Reviewed-by: Dhruva Gole Signed-off-by: Peng Fan --- MAINTAINERS | 1 + drivers/pinctrl/Kconfig | 11 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/pinctrl-scmi.c | 564 +++++++++++++++++++++++++++++++++++++++++ 4 files changed, 577 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index cfb8f4918961..ae7795413d2a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -21609,6 +21609,7 @@ F: drivers/cpufreq/sc[mp]i-cpufreq.c F: drivers/firmware/arm_scmi/ F: drivers/firmware/arm_scpi.c F: drivers/hwmon/scmi-hwmon.c +F: drivers/pinctrl/pinctrl-scmi.c F: drivers/pmdomain/arm/ F: drivers/powercap/arm_scmi_powercap.c F: drivers/regulator/scmi-regulator.c diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 1be05efccc29..7e4f93a3bc7a 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -450,6 +450,17 @@ config PINCTRL_ROCKCHIP help This support pinctrl and GPIO driver for Rockchip SoCs. +config PINCTRL_SCMI + tristate "Pinctrl driver using SCMI protocol interface" + depends on ARM_SCMI_PROTOCOL || COMPILE_TEST + select PINMUX + select GENERIC_PINCONF + help + This driver provides support for pinctrl which is controlled + by firmware that implements the SCMI interface. + It uses SCMI Message Protocol to interact with the + firmware providing all the pinctrl controls. + config PINCTRL_SINGLE tristate "One-register-per-pin type device tree based pinctrl driver" depends on OF diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile index 2152539b53d5..cc809669405a 100644 --- a/drivers/pinctrl/Makefile +++ b/drivers/pinctrl/Makefile @@ -45,6 +45,7 @@ obj-$(CONFIG_PINCTRL_PIC32) += pinctrl-pic32.o obj-$(CONFIG_PINCTRL_PISTACHIO) += pinctrl-pistachio.o obj-$(CONFIG_PINCTRL_RK805) += pinctrl-rk805.o obj-$(CONFIG_PINCTRL_ROCKCHIP) += pinctrl-rockchip.o +obj-$(CONFIG_PINCTRL_SCMI) += pinctrl-scmi.o obj-$(CONFIG_PINCTRL_SINGLE) += pinctrl-single.o obj-$(CONFIG_PINCTRL_ST) += pinctrl-st.o obj-$(CONFIG_PINCTRL_STMFX) += pinctrl-stmfx.o diff --git a/drivers/pinctrl/pinctrl-scmi.c b/drivers/pinctrl/pinctrl-scmi.c new file mode 100644 index 000000000000..0f55f000a679 --- /dev/null +++ b/drivers/pinctrl/pinctrl-scmi.c @@ -0,0 +1,564 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * System Control and Power Interface (SCMI) Protocol based pinctrl driver + * + * Copyright (C) 2024 EPAM + * Copyright 2024 NXP + */ + +#include +#include +#include +#include +#include +#include +#include + +#include +#include +#include +#include +#include + +#include "pinctrl-utils.h" +#include "core.h" +#include "pinconf.h" + +#define DRV_NAME "scmi-pinctrl" + +/* Define num configs, if not large than 4 use stack, else use kcalloc */ +#define SCMI_NUM_CONFIGS 4 + +static const struct scmi_pinctrl_proto_ops *pinctrl_ops; + +struct scmi_pinctrl { + struct device *dev; + struct scmi_protocol_handle *ph; + struct pinctrl_dev *pctldev; + struct pinctrl_desc pctl_desc; + struct pinfunction *functions; + unsigned int nr_functions; + struct pinctrl_pin_desc *pins; + unsigned int nr_pins; +}; + +static int pinctrl_scmi_get_groups_count(struct pinctrl_dev *pctldev) +{ + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->count_get(pmx->ph, GROUP_TYPE); +} + +static const char *pinctrl_scmi_get_group_name(struct pinctrl_dev *pctldev, + unsigned int selector) +{ + int ret; + const char *name; + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + ret = pinctrl_ops->name_get(pmx->ph, selector, GROUP_TYPE, &name); + if (ret) { + dev_err(pmx->dev, "get name failed with err %d", ret); + return NULL; + } + + return name; +} + +static int pinctrl_scmi_get_group_pins(struct pinctrl_dev *pctldev, + unsigned int selector, + const unsigned int **pins, + unsigned int *num_pins) +{ + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->group_pins_get(pmx->ph, selector, pins, num_pins); +} + +static const struct pinctrl_ops pinctrl_scmi_pinctrl_ops = { + .get_groups_count = pinctrl_scmi_get_groups_count, + .get_group_name = pinctrl_scmi_get_group_name, + .get_group_pins = pinctrl_scmi_get_group_pins, +#ifdef CONFIG_OF + .dt_node_to_map = pinconf_generic_dt_node_to_map_all, + .dt_free_map = pinconf_generic_dt_free_map, +#endif +}; + +static int pinctrl_scmi_get_functions_count(struct pinctrl_dev *pctldev) +{ + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->count_get(pmx->ph, FUNCTION_TYPE); +} + +static const char *pinctrl_scmi_get_function_name(struct pinctrl_dev *pctldev, + unsigned int selector) +{ + int ret; + const char *name; + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + ret = pinctrl_ops->name_get(pmx->ph, selector, FUNCTION_TYPE, &name); + if (ret) { + dev_err(pmx->dev, "get name failed with err %d", ret); + return NULL; + } + + return name; +} + +static int pinctrl_scmi_get_function_groups(struct pinctrl_dev *pctldev, + unsigned int selector, + const char * const **p_groups, + unsigned int * const p_num_groups) +{ + struct pinfunction *func; + const unsigned int *group_ids; + unsigned int num_groups; + const char **groups; + int ret, i; + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + if (!p_groups || !p_num_groups) + return -EINVAL; + + if (selector >= pmx->nr_functions) + return -EINVAL; + + func = &pmx->functions[selector]; + if (func->ngroups) + goto done; + + ret = pinctrl_ops->function_groups_get(pmx->ph, selector, &num_groups, + &group_ids); + if (ret) { + dev_err(pmx->dev, "Unable to get function groups, err %d", ret); + return ret; + } + if (!num_groups) + return -EINVAL; + + groups = kcalloc(num_groups, sizeof(*groups), GFP_KERNEL); + if (!groups) + return -ENOMEM; + + for (i = 0; i < num_groups; i++) { + groups[i] = pinctrl_scmi_get_group_name(pctldev, group_ids[i]); + if (!groups[i]) { + ret = -EINVAL; + goto err_free; + } + } + + func->ngroups = num_groups; + func->groups = groups; +done: + *p_groups = func->groups; + *p_num_groups = func->ngroups; + + return 0; + +err_free: + kfree(groups); + + return ret; +} + +static int pinctrl_scmi_func_set_mux(struct pinctrl_dev *pctldev, + unsigned int selector, unsigned int group) +{ + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->mux_set(pmx->ph, selector, group); +} + +static int pinctrl_scmi_request(struct pinctrl_dev *pctldev, + unsigned int offset) +{ + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->pin_request(pmx->ph, offset); +} + +static int pinctrl_scmi_free(struct pinctrl_dev *pctldev, unsigned int offset) +{ + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + + return pinctrl_ops->pin_free(pmx->ph, offset); +} + +static const struct pinmux_ops pinctrl_scmi_pinmux_ops = { + .request = pinctrl_scmi_request, + .free = pinctrl_scmi_free, + .get_functions_count = pinctrl_scmi_get_functions_count, + .get_function_name = pinctrl_scmi_get_function_name, + .get_function_groups = pinctrl_scmi_get_function_groups, + .set_mux = pinctrl_scmi_func_set_mux, +}; + +static int pinctrl_scmi_map_pinconf_type(enum pin_config_param param, + enum scmi_pinctrl_conf_type *type) +{ + u32 arg = param; + + switch (arg) { + case PIN_CONFIG_BIAS_BUS_HOLD: + *type = SCMI_PIN_BIAS_BUS_HOLD; + break; + case PIN_CONFIG_BIAS_DISABLE: + *type = SCMI_PIN_BIAS_DISABLE; + break; + case PIN_CONFIG_BIAS_HIGH_IMPEDANCE: + *type = SCMI_PIN_BIAS_HIGH_IMPEDANCE; + break; + case PIN_CONFIG_BIAS_PULL_DOWN: + *type = SCMI_PIN_BIAS_PULL_DOWN; + break; + case PIN_CONFIG_BIAS_PULL_PIN_DEFAULT: + *type = SCMI_PIN_BIAS_PULL_DEFAULT; + break; + case PIN_CONFIG_BIAS_PULL_UP: + *type = SCMI_PIN_BIAS_PULL_UP; + break; + case PIN_CONFIG_DRIVE_OPEN_DRAIN: + *type = SCMI_PIN_DRIVE_OPEN_DRAIN; + break; + case PIN_CONFIG_DRIVE_OPEN_SOURCE: + *type = SCMI_PIN_DRIVE_OPEN_SOURCE; + break; + case PIN_CONFIG_DRIVE_PUSH_PULL: + *type = SCMI_PIN_DRIVE_PUSH_PULL; + break; + case PIN_CONFIG_DRIVE_STRENGTH: + *type = SCMI_PIN_DRIVE_STRENGTH; + break; + case PIN_CONFIG_DRIVE_STRENGTH_UA: + *type = SCMI_PIN_DRIVE_STRENGTH; + break; + case PIN_CONFIG_INPUT_DEBOUNCE: + *type = SCMI_PIN_INPUT_DEBOUNCE; + break; + case PIN_CONFIG_INPUT_ENABLE: + *type = SCMI_PIN_INPUT_MODE; + break; + case PIN_CONFIG_INPUT_SCHMITT: + *type = SCMI_PIN_INPUT_SCHMITT; + break; + case PIN_CONFIG_INPUT_SCHMITT_ENABLE: + *type = SCMI_PIN_INPUT_MODE; + break; + case PIN_CONFIG_MODE_LOW_POWER: + *type = SCMI_PIN_LOW_POWER_MODE; + break; + case PIN_CONFIG_OUTPUT: + *type = SCMI_PIN_OUTPUT_VALUE; + break; + case PIN_CONFIG_OUTPUT_ENABLE: + *type = SCMI_PIN_OUTPUT_MODE; + break; + case PIN_CONFIG_OUTPUT_IMPEDANCE_OHMS: + *type = SCMI_PIN_OUTPUT_VALUE; + break; + case PIN_CONFIG_POWER_SOURCE: + *type = SCMI_PIN_POWER_SOURCE; + break; + case PIN_CONFIG_SLEW_RATE: + *type = SCMI_PIN_SLEW_RATE; + break; + case SCMI_PIN_OEM_START ... SCMI_PIN_OEM_END: + *type = arg; + break; + default: + return -EINVAL; + } + + return 0; +} + +static int pinctrl_scmi_pinconf_get(struct pinctrl_dev *pctldev, + unsigned int pin, unsigned long *config) +{ + int ret; + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + enum pin_config_param config_type; + enum scmi_pinctrl_conf_type type; + u32 config_value; + + if (!config) + return -EINVAL; + + config_type = pinconf_to_config_param(*config); + + ret = pinctrl_scmi_map_pinconf_type(config_type, &type); + if (ret) + return ret; + + ret = pinctrl_ops->settings_get_one(pmx->ph, pin, PIN_TYPE, type, + &config_value); + if (ret) + return ret; + + *config = pinconf_to_config_packed(config_type, config_value); + + return 0; +} + +static int +pinctrl_scmi_alloc_configs(struct pinctrl_dev *pctldev, u32 num_configs, + u32 **p_config_value, + enum scmi_pinctrl_conf_type **p_config_type) +{ + if (num_configs <= SCMI_NUM_CONFIGS) + return 0; + + *p_config_value = kcalloc(num_configs, sizeof(**p_config_value), GFP_KERNEL); + if (!*p_config_value) + return -ENOMEM; + + *p_config_type = kcalloc(num_configs, sizeof(**p_config_type), GFP_KERNEL); + if (!*p_config_type) { + kfree(*p_config_value); + return -ENOMEM; + } + + return 0; +} + +static void +pinctrl_scmi_free_configs(struct pinctrl_dev *pctldev, u32 num_configs, + u32 **p_config_value, + enum scmi_pinctrl_conf_type **p_config_type) +{ + if (num_configs <= SCMI_NUM_CONFIGS) + return; + + kfree(*p_config_value); + kfree(*p_config_type); +} + +static int pinctrl_scmi_pinconf_set(struct pinctrl_dev *pctldev, + unsigned int pin, + unsigned long *configs, + unsigned int num_configs) +{ + int i, ret; + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + enum scmi_pinctrl_conf_type config_type[SCMI_NUM_CONFIGS]; + u32 config_value[SCMI_NUM_CONFIGS]; + enum scmi_pinctrl_conf_type *p_config_type = config_type; + u32 *p_config_value = config_value; + enum pin_config_param param; + + if (!configs || !num_configs) + return -EINVAL; + + ret = pinctrl_scmi_alloc_configs(pctldev, num_configs, &p_config_type, + &p_config_value); + if (ret) + return ret; + + for (i = 0; i < num_configs; i++) { + param = pinconf_to_config_param(configs[i]); + ret = pinctrl_scmi_map_pinconf_type(param, &p_config_type[i]); + if (ret) { + dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); + goto free_config; + } + p_config_value[i] = pinconf_to_config_argument(configs[i]); + } + + ret = pinctrl_ops->settings_conf(pmx->ph, pin, PIN_TYPE, num_configs, + p_config_type, p_config_value); + if (ret) + dev_err(pmx->dev, "Error parsing config %d\n", ret); + +free_config: + pinctrl_scmi_free_configs(pctldev, num_configs, &p_config_type, + &p_config_value); + return ret; +} + +static int pinctrl_scmi_pinconf_group_set(struct pinctrl_dev *pctldev, + unsigned int group, + unsigned long *configs, + unsigned int num_configs) +{ + int i, ret; + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + enum scmi_pinctrl_conf_type config_type[SCMI_NUM_CONFIGS]; + u32 config_value[SCMI_NUM_CONFIGS]; + enum scmi_pinctrl_conf_type *p_config_type = config_type; + u32 *p_config_value = config_value; + enum pin_config_param param; + + if (!configs || !num_configs) + return -EINVAL; + + ret = pinctrl_scmi_alloc_configs(pctldev, num_configs, &p_config_type, + &p_config_value); + if (ret) + return ret; + + for (i = 0; i < num_configs; i++) { + param = pinconf_to_config_param(configs[i]); + ret = pinctrl_scmi_map_pinconf_type(param, &p_config_type[i]); + if (ret) { + dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); + goto free_config; + } + + p_config_value[i] = pinconf_to_config_argument(configs[i]); + } + + ret = pinctrl_ops->settings_conf(pmx->ph, group, GROUP_TYPE, + num_configs, p_config_type, + p_config_value); + if (ret) + dev_err(pmx->dev, "Error parsing config %d", ret); + +free_config: + pinctrl_scmi_free_configs(pctldev, num_configs, &p_config_type, + &p_config_value); + return ret; +}; + +static int pinctrl_scmi_pinconf_group_get(struct pinctrl_dev *pctldev, + unsigned int group, + unsigned long *config) +{ + int ret; + struct scmi_pinctrl *pmx = pinctrl_dev_get_drvdata(pctldev); + enum pin_config_param config_type; + enum scmi_pinctrl_conf_type type; + u32 config_value; + + if (!config) + return -EINVAL; + + config_type = pinconf_to_config_param(*config); + ret = pinctrl_scmi_map_pinconf_type(config_type, &type); + if (ret) { + dev_err(pmx->dev, "Error map pinconf_type %d\n", ret); + return ret; + } + + ret = pinctrl_ops->settings_get_one(pmx->ph, group, GROUP_TYPE, type, + &config_value); + if (ret) + return ret; + + *config = pinconf_to_config_packed(config_type, config_value); + + return 0; +} + +static const struct pinconf_ops pinctrl_scmi_pinconf_ops = { + .is_generic = true, + .pin_config_get = pinctrl_scmi_pinconf_get, + .pin_config_set = pinctrl_scmi_pinconf_set, + .pin_config_group_set = pinctrl_scmi_pinconf_group_set, + .pin_config_group_get = pinctrl_scmi_pinconf_group_get, + .pin_config_config_dbg_show = pinconf_generic_dump_config, +}; + +static int pinctrl_scmi_get_pins(struct scmi_pinctrl *pmx, + struct pinctrl_desc *desc) +{ + struct pinctrl_pin_desc *pins; + unsigned int npins; + int ret, i; + + npins = pinctrl_ops->count_get(pmx->ph, PIN_TYPE); + /* + * npins will never be zero, the scmi pinctrl driver has bailed out + * if npins is zero. + */ + pins = devm_kmalloc_array(pmx->dev, npins, sizeof(*pins), GFP_KERNEL); + if (!pins) + return -ENOMEM; + + for (i = 0; i < npins; i++) { + pins[i].number = i; + /* + * The memory for name is handled by the scmi firmware driver, + * no need free here + */ + ret = pinctrl_ops->name_get(pmx->ph, i, PIN_TYPE, &pins[i].name); + if (ret) + return dev_err_probe(pmx->dev, ret, + "Can't get name for pin %d", i); + } + + desc->npins = npins; + desc->pins = pins; + dev_dbg(pmx->dev, "got pins %u", npins); + + return 0; +} + +static int scmi_pinctrl_probe(struct scmi_device *sdev) +{ + int ret; + struct device *dev = &sdev->dev; + struct scmi_pinctrl *pmx; + const struct scmi_handle *handle; + struct scmi_protocol_handle *ph; + + if (!sdev->handle) + return -EINVAL; + + handle = sdev->handle; + + pinctrl_ops = handle->devm_protocol_get(sdev, SCMI_PROTOCOL_PINCTRL, &ph); + if (IS_ERR(pinctrl_ops)) + return PTR_ERR(pinctrl_ops); + + pmx = devm_kzalloc(dev, sizeof(*pmx), GFP_KERNEL); + if (!pmx) + return -ENOMEM; + + pmx->ph = ph; + + pmx->dev = dev; + pmx->pctl_desc.name = DRV_NAME; + pmx->pctl_desc.owner = THIS_MODULE; + pmx->pctl_desc.pctlops = &pinctrl_scmi_pinctrl_ops; + pmx->pctl_desc.pmxops = &pinctrl_scmi_pinmux_ops; + pmx->pctl_desc.confops = &pinctrl_scmi_pinconf_ops; + + ret = pinctrl_scmi_get_pins(pmx, &pmx->pctl_desc); + if (ret) + return ret; + + ret = devm_pinctrl_register_and_init(dev, &pmx->pctl_desc, pmx, + &pmx->pctldev); + if (ret) + return dev_err_probe(dev, ret, "Failed to register pinctrl\n"); + + pmx->nr_functions = pinctrl_scmi_get_functions_count(pmx->pctldev); + pmx->functions = devm_kcalloc(dev, pmx->nr_functions, + sizeof(*pmx->functions), GFP_KERNEL); + if (!pmx->functions) + return -ENOMEM; + + return pinctrl_enable(pmx->pctldev); +} + +static const struct scmi_device_id scmi_id_table[] = { + { SCMI_PROTOCOL_PINCTRL, "pinctrl" }, + { } +}; +MODULE_DEVICE_TABLE(scmi, scmi_id_table); + +static struct scmi_driver scmi_pinctrl_driver = { + .name = DRV_NAME, + .probe = scmi_pinctrl_probe, + .id_table = scmi_id_table, +}; +module_scmi_driver(scmi_pinctrl_driver); + +MODULE_AUTHOR("Oleksii Moisieiev "); +MODULE_AUTHOR("Peng Fan "); +MODULE_DESCRIPTION("ARM SCMI pin controller driver"); +MODULE_LICENSE("GPL");