From patchwork Wed Oct 16 10:04:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Quadros X-Patchwork-Id: 176447 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp7138872ill; Wed, 16 Oct 2019 03:05:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqw8GmpsdBf3QGZlAcLJu57N0paygP7uW3rn2T04JxPT+iR5QbBhvOyo86jnsAh09PerpVGi X-Received: by 2002:aa7:dc50:: with SMTP id g16mr26251896edu.67.1571220315232; Wed, 16 Oct 2019 03:05:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571220315; cv=none; d=google.com; s=arc-20160816; b=jhAztbb+DErmMfCU4b6dMjc8JLDZ2AhKCtYOCM2AWeSeUdL2rfHQwPPjCL3wjFKDYd PG272syYcERQAw/IgGDLrHw7AqNHwZe3mVw7AhI5lUZWAd8FHFEfAJ/KOthFIQ4aWsVs AZ2XLUiDixcyT3Pz4Sw0ScMaIq8tz8I3/9qrHJw5dI3OEImOon27wmEig2xHn6CL+NEP Cisvhaw3f69J0jZxhHyCrTTD56R2VbtLTegQRrIwNF3SiCDYrVFc0trwALCwd4TAzdoP kF83/EGVX8xOzafRdZaG/2IDeSKgVZajL2+bdmyxNhDssEaaV1C+jaI5BrqPQPRSzB7D 7poA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=X9OoVAqkmWigRFAcfWsbH/rWq/4QTLvI1rJbdzVDNHU=; b=pczkYzOSxvibftmpg3nnA8ksOsyLGcn7eHLDfZdkY6yrtESUCuKWkZQPfXvHFeF5pH 08hNotc00A8IeUWIEK6fRqO6kDLGuLWJqCANu8xOFllOMXxNzxfGghML3UZr6gJFqguq nV+W0ZxydCrjChKf2yp49ThNHM0+Cu3b8x2Mh8OwK+1+EpMm3Lwm9B+Kf3EJHYm8mC7S G/OVEHym/RTTBuKKSkCsYFgvMfx2NAHrTCRLZqMqCVwvNJ3Hb9kcd65VwqFZpHy7vKV2 NfSYrpw3YEZuDEHxJONrS3JO3ME7yWNgphR6KpmCv7c/Gtz0aq3RUuMr4lDBe+9JaGnV dQ8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="Fb7/biK5"; spf=pass (google.com: best guess record for domain of linux-usb-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t49si17839113edd.198.2019.10.16.03.05.15; Wed, 16 Oct 2019 03:05:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-usb-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="Fb7/biK5"; spf=pass (google.com: best guess record for domain of linux-usb-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392192AbfJPKFO (ORCPT + 5 others); Wed, 16 Oct 2019 06:05:14 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:40708 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728358AbfJPKFM (ORCPT ); Wed, 16 Oct 2019 06:05:12 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x9GA50e8076555; Wed, 16 Oct 2019 05:05:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1571220300; bh=X9OoVAqkmWigRFAcfWsbH/rWq/4QTLvI1rJbdzVDNHU=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=Fb7/biK5lCA0Y4A/v4Mzjl8g6rlJ/oCFT96AJT9GohkKpcWgd4GRzAgm5t9htLC9p fG0nnf+QUVk6tqAnsbW5LrKYc48XMnbJhz9WTHERNHYa26nyx65UyvLsp21P6GY+j0 EIIkIC953c2o74sqWGX2BBpTmmNu2QC2iPCb+Zqs= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x9GA50aM047863 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 16 Oct 2019 05:05:00 -0500 Received: from DLEE102.ent.ti.com (157.170.170.32) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 16 Oct 2019 05:04:52 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Wed, 16 Oct 2019 05:04:52 -0500 Received: from lta0400828a.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id x9GA4sKC001596; Wed, 16 Oct 2019 05:04:57 -0500 From: Roger Quadros To: , CC: , , , , , , Roger Quadros Subject: [PATCH v2 1/2] usb: cdns3: fix cdns3_core_init_role() Date: Wed, 16 Oct 2019 13:04:51 +0300 Message-ID: <20191016100452.32613-2-rogerq@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191016100452.32613-1-rogerq@ti.com> References: <20191016100452.32613-1-rogerq@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org At startup we should trigger the HW state machine only if it is OTG mode. Otherwise we should just start the respective role. Initialize idle role by default. If we don't do this then cdns3_idle_role_stop() is not called when switching to host/device role and so lane switch mechanism doesn't work. This results to super-speed device not working in one orientation if it was plugged before driver probe. Signed-off-by: Roger Quadros Signed-off-by: Sekhar Nori Reviewed-by: Pawel Laszczak Tested-by: Pawel Laszczak --- drivers/usb/cdns3/core.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c index 06f1e105be4e..c2123ef8d8a3 100644 --- a/drivers/usb/cdns3/core.c +++ b/drivers/usb/cdns3/core.c @@ -160,10 +160,30 @@ static int cdns3_core_init_role(struct cdns3 *cdns) if (ret) goto err; - if (cdns->dr_mode != USB_DR_MODE_OTG) { + /* Initialize idle role to start with */ + ret = cdns3_role_start(cdns, USB_ROLE_NONE); + if (ret) + goto err; + + switch (cdns->dr_mode) { + case USB_DR_MODE_OTG: ret = cdns3_hw_role_switch(cdns); if (ret) goto err; + break; + case USB_DR_MODE_PERIPHERAL: + ret = cdns3_role_start(cdns, USB_ROLE_DEVICE); + if (ret) + goto err; + break; + case USB_DR_MODE_HOST: + ret = cdns3_role_start(cdns, USB_ROLE_HOST); + if (ret) + goto err; + break; + default: + ret = -EINVAL; + goto err; } return ret;