From patchwork Thu Oct 17 07:58:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Quadros X-Patchwork-Id: 176550 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp563696ill; Thu, 17 Oct 2019 00:58:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqxbtzKv8KWnOkht418ysl2OTv7gUXyu26nnWB+slrmiJRw4RW0SVP0fAMrTWGV9x23//sq5 X-Received: by 2002:a17:906:fac6:: with SMTP id lu6mr2175984ejb.126.1571299100907; Thu, 17 Oct 2019 00:58:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571299100; cv=none; d=google.com; s=arc-20160816; b=ItexaCVwHLMAfu0kEqJwZ4fU5vbOFAMhEujjvF5RkcOicWjLAAhiUbQW/a16e5J9MW JJBzU+tEzrmdySXyehEcwqt/I951c3xl+yX88gVSYJdhaz/JlpEyF5Qfe0ZBau96udxc OoMLFX3UGw2QdQhNohfrYLds8LQ5szqC2YOudEnrhuWsghUaLSzNfz+L89O0JsOBQ8aq 1Rvccc7H8KTX1Lv14VWz9Lshnzc0iP/z42jYAwHySBa+wSGVPFWvwftScs60FVklR5XX AaE7VLlGDf/+d/3lTMwxW9T7rqUy9SjbDyEQblwTaqPqTv7TskwTANXBb197rrZnnmOf HqwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=PB8P3M92Qr+BuxLmFcudWc9V7nMyMBfC6vJnswIve6k=; b=BRzorUIFo31lQp7a9jgAFS+uvqqSjadLNLrwTHO6eKlIwdjo7r91xETJK9GuIs5E0b VbW1sQ3FHXKpf1Vrf+ZgStta5BMW1w2RM4MTMus8d9VKBDoCrx/1UNk4kbwypP9VJMVE 1iRUTgbhK/SxLclOE3k0VxFirMjkLwI2AhLZrMAKnX5j98YmasS6Ab8teiCztLbjDNqw aLSABJW0ZdWRKL4UGyQXTLaGLvEsIGYRithbDuK3ZUbj8tHisgEQYHcge8RW5vZE9bat sTTPetqAQpqjpyyR/vXKeLhOabU7/xqyolVv47ADrSyO5SvP4BWR9IOsozv2ADphvLO2 UByQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=WAOLY0Cq; spf=pass (google.com: best guess record for domain of linux-usb-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f21si1023798edb.379.2019.10.17.00.58.20; Thu, 17 Oct 2019 00:58:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-usb-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=WAOLY0Cq; spf=pass (google.com: best guess record for domain of linux-usb-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408010AbfJQH6R (ORCPT + 5 others); Thu, 17 Oct 2019 03:58:17 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:50140 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732594AbfJQH6Q (ORCPT ); Thu, 17 Oct 2019 03:58:16 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x9H7w560017305; Thu, 17 Oct 2019 02:58:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1571299085; bh=PB8P3M92Qr+BuxLmFcudWc9V7nMyMBfC6vJnswIve6k=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=WAOLY0CqXUZDnoyC1csA83T49deZ5hd4eG12f+WZF94jFvUSVUOBs4xgUbk9l5sSq T16gihJO88TT9GDyOaVobwU1KyT/4akLLQoFdyDm7JZRyM3dWa41xT/2M2DHsbVxAG 2+eM4Up+0t77bVga4ROmziYW9qTye9JxGpvjaY0c= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x9H7w5Ke015520 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 17 Oct 2019 02:58:05 -0500 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Thu, 17 Oct 2019 02:57:57 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Thu, 17 Oct 2019 02:58:05 -0500 Received: from lta0400828a.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x9H7w2Gd102521; Thu, 17 Oct 2019 02:58:03 -0500 From: Roger Quadros To: , CC: , , , , , , Roger Quadros Subject: [PATCH] usb: cdns3: Error out if USB_DR_MODE_UNKNOWN in cdns3_core_init_role() Date: Thu, 17 Oct 2019 10:58:01 +0300 Message-ID: <20191017075801.8734-1-rogerq@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191016131808.GB56859@kroah.com> References: <20191016131808.GB56859@kroah.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org USB_DR_MODE_UNKNOWN should be treated as error as it is done in cdns3_drd_update_mode(). Fixes: 02ffc26df96b ("usb: cdns3: fix cdns3_core_init_role()") Signed-off-by: Roger Quadros --- drivers/usb/cdns3/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c index 1109dc5a4c39..c2123ef8d8a3 100644 --- a/drivers/usb/cdns3/core.c +++ b/drivers/usb/cdns3/core.c @@ -166,7 +166,6 @@ static int cdns3_core_init_role(struct cdns3 *cdns) goto err; switch (cdns->dr_mode) { - case USB_DR_MODE_UNKNOWN: case USB_DR_MODE_OTG: ret = cdns3_hw_role_switch(cdns); if (ret) @@ -182,6 +181,9 @@ static int cdns3_core_init_role(struct cdns3 *cdns) if (ret) goto err; break; + default: + ret = -EINVAL; + goto err; } return ret;