From patchwork Tue May 21 12:09:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Selvaraj via B4 Relay X-Patchwork-Id: 798278 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 447647581A; Tue, 21 May 2024 12:10:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716293428; cv=none; b=Psdw/q55pRMsudD6tU5lXaRhSc6/JXaevY377SsqxljIfgGDLq+GrAXf0a+EXzGJSPY+iFAmBP7HzNMYqty1MqNpiMsPHrNQA2VaKGGiM9hn7QC6SW+sM46HcmvrpRV2RKhEfyI3k7m+VKm51Nfl1zLDVp/UKpiDYhYeLvVR7YI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716293428; c=relaxed/simple; bh=UG5eBhNRoib+nYNoHj5imPkbdo4AU8SmjD6PNxoq7gM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=j3QtDsch+f0v5ldB1MKzLtiqHTBWmkoka1X4pG+0bhHC4nIen3lHpnfVToWCFy4qPutYa3rZrSXwKk+MU+MywoZdIfWzRcI7zG5IfbVvaScGIfdbpU8nL1XuwQQXFmMnJCeT4zbRRcjXR7VcMT1I8g9pdzrdZ3AeWWIqF0Ci/uQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TSdto/ub; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TSdto/ub" Received: by smtp.kernel.org (Postfix) with ESMTPS id DF557C32789; Tue, 21 May 2024 12:10:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716293428; bh=UG5eBhNRoib+nYNoHj5imPkbdo4AU8SmjD6PNxoq7gM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=TSdto/ubvqOF+SkOLydd0ua3x4Pl9NScjWMBvqtnI9PYHJh8J5bZTpH3GrPOSRZN2 U29YccWmqw1Cy3I1WNW+vs2zHvq2bzYNjZx2h//LviDPr4LmvJ26Xuhpv8loeTu+AK 60kDmDJJrmK8WhZldFEO60CJ4pYlNRVX8erLRBLKXurZSvKCbyhUPuaLqPck+OfUKF YM5xwPYd8AYv6tBvopacHX2hqmLniGRNGiqsn4uHyOajGjWEykrUkHNtasYFuqawQ+ ItB8OxzH9e1MK4mBE1KwsEP5v8XQYcdmkg28bPdzYggGzFTSfwxcAvFEHmk7nyl7gP VJ9CizJDi5AAQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6191C25B7A; Tue, 21 May 2024 12:10:27 +0000 (UTC) From: Joel Selvaraj via B4 Relay Date: Tue, 21 May 2024 07:09:45 -0500 Subject: [PATCH 1/2] dt-bindings: input: document Novatek NVT touchscreen controller Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240521-nvt-ts-devicetree-regulator-support-v1-1-8d766c639dca@gmail.com> References: <20240521-nvt-ts-devicetree-regulator-support-v1-0-8d766c639dca@gmail.com> In-Reply-To: <20240521-nvt-ts-devicetree-regulator-support-v1-0-8d766c639dca@gmail.com> To: Hans de Goede , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Joel Selvaraj X-Mailer: b4 0.14-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1716293427; l=2805; i=joelselvaraj.oss@gmail.com; s=20240420; h=from:subject:message-id; bh=95WsWhwuKwzTjQEHVYwidX2cErhdi13Wf2Y2e3kqVx4=; b=DFdnkNQ88kGuYJgJN2dt9CqbycC27i5ly3Gg5cl4PZJMTdk2g+tzWNiUokTLfTH1ME1f9Lpvb tx0rruaBrubDIWMG71ap8cQ3MWdbsPkNF/C+TMRmEk4l7kY3X7iozMm X-Developer-Key: i=joelselvaraj.oss@gmail.com; a=ed25519; pk=qT4gsuVtlPE0Dpr+tQA/Fumm7wzVP6qfeVaY+6pX04s= X-Endpoint-Received: by B4 Relay for joelselvaraj.oss@gmail.com/20240420 with auth_id=165 X-Original-From: Joel Selvaraj Reply-To: joelselvaraj.oss@gmail.com From: Joel Selvaraj Document the Novatek NVT touchscreen driver which is used in devices like the Xiaomi Poco F1 [1]. Also, include the devictree binding file in the MAINTAINERS file. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts?h=v6.9 Signed-off-by: Joel Selvaraj --- .../bindings/input/touchscreen/novatek,nvt-ts.yaml | 62 ++++++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 63 insertions(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/novatek,nvt-ts.yaml b/Documentation/devicetree/bindings/input/touchscreen/novatek,nvt-ts.yaml new file mode 100644 index 0000000000000..7839c6a028e4a --- /dev/null +++ b/Documentation/devicetree/bindings/input/touchscreen/novatek,nvt-ts.yaml @@ -0,0 +1,62 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/touchscreen/novatek,nvt-ts.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Novatek NVT Touchscreen Controller + +maintainers: + - Hans de Goede + +allOf: + - $ref: touchscreen.yaml# + +properties: + compatible: + enum: + - novatek,nvt-ts + - novatek,nt36672a-ts + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + reset-gpios: + maxItems: 1 + + vcc-supply: true + iovcc-supply: true + +unevaluatedProperties: false + +required: + - compatible + - reg + - interrupts + +examples: + - | + #include + #include + i2c { + #address-cells = <1>; + #size-cells = <0>; + touchscreen@1 { + compatible = "novatek,nt36672a-ts"; + reg = <0x01>; + interrupts-extended = <&tlmm 31 IRQ_TYPE_EDGE_RISING>; + reset-gpios = <&tlmm 32 GPIO_ACTIVE_LOW>; + vcc-supply = <&vreg_l22a_2p85>; + iovcc-supply = <&vreg_l14a_1p8>; + pinctrl-0 = <&ts_int_default &ts_reset_default>; + pinctrl-1 = <&ts_int_sleep &ts_reset_sleep>; + pinctrl-names = "default", "sleep"; + touchscreen-size-x = <1080>; + touchscreen-size-y = <2246>; + }; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index 90754a451bcfc..e1f744992b15f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -15942,6 +15942,7 @@ NOVATEK NVT-TS I2C TOUCHSCREEN DRIVER M: Hans de Goede L: linux-input@vger.kernel.org S: Maintained +F: Documentation/devicetree/bindings/input/touchscreen/novatek,nvt-ts.yaml F: drivers/input/touchscreen/novatek-nvt-ts.c NSDEPS From patchwork Tue May 21 12:09:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Selvaraj via B4 Relay X-Patchwork-Id: 798060 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4471975803; Tue, 21 May 2024 12:10:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716293428; cv=none; b=O1oTkOdEThu3toYNEIS1FR4DA8pp6fsy0nGTi91Vya7RitQ7L/T6pmIJxzNHuXYx7bLebg85U6nDKVmieei4eTtyx7eXoZ8Lmfi+1In7x4VAIJzVKGl+MzY+350vsLrNh+KvQFbS59bsuRNey53gg6AwI0Tahf74lubIgBUY/uk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716293428; c=relaxed/simple; bh=OdYZn52F6VF1uhjqjjPzVuFAHrHpPEZt905OhIkUFNg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BBBiJw05vAYF22Ae3eocH5p5meAuO63WzZksapRaHujW/kqjG/4X3N/UziPJ0e5BD0CW4ackv0ynDxmHxxCC2q2mvFqGXNM1Lg5s7+FkOWNMTctJKuWnkqBpJ2VpQyygS34MgLM4QUga6olXmJLENsJfGVJLDzFowk2+Rz+dJAA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Kqtx7pqH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Kqtx7pqH" Received: by smtp.kernel.org (Postfix) with ESMTPS id E8101C4AF0B; Tue, 21 May 2024 12:10:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716293428; bh=OdYZn52F6VF1uhjqjjPzVuFAHrHpPEZt905OhIkUFNg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=Kqtx7pqHMhTaam9MFyIegtO3DA6uJCRfyFca94yYpg7bxyvWdlTr79lFrl/8bYpt5 QQh7Nuc8c7zIxFdfLuGTbKxBxuHK09Ln5e3u4iU5oiCQzaVxiZ6klQdI9hykmjMDEH cpDA5+BbaYaDWuVqQolJwlJeDkglnXE1K6diBqMuWU9FSe18JAvJdu35//US2WYSDw lQrXMMaGC7voWjL2J6Dhh6qHWGsieUIBgoYRMRpeGhb6NX+Fx/ar7TLBqJmNBTODnt F+wI8NFkhORqogd+rvhD0liGagtXDG1Sd7AqSoiYpmWrxRCM6D3TBNMCCHTufOtmlH PUpBWzryPXrzQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1DE2C25B7C; Tue, 21 May 2024 12:10:27 +0000 (UTC) From: Joel Selvaraj via B4 Relay Date: Tue, 21 May 2024 07:09:46 -0500 Subject: [PATCH 2/2] Input: novatek-nvt-ts: add support for NT36672A touchscreen Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240521-nvt-ts-devicetree-regulator-support-v1-2-8d766c639dca@gmail.com> References: <20240521-nvt-ts-devicetree-regulator-support-v1-0-8d766c639dca@gmail.com> In-Reply-To: <20240521-nvt-ts-devicetree-regulator-support-v1-0-8d766c639dca@gmail.com> To: Hans de Goede , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Joel Selvaraj X-Mailer: b4 0.14-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1716293427; l=5393; i=joelselvaraj.oss@gmail.com; s=20240420; h=from:subject:message-id; bh=YdF+1/EluDURAn87EosfJ/ZwGhhN9IKd2kxlFEmen+c=; b=I+Jnn6QR1nh843pLr0rEf96p2m4czhTgNStHL7im12iz1E6oXP6k+cVh8noIMbLwUMnzI76p2 S/ekfKH+VPVAhlW7xWeHILyZkzUG5I9nHnTUX8WmBOB7IMuI5pobPDU X-Developer-Key: i=joelselvaraj.oss@gmail.com; a=ed25519; pk=qT4gsuVtlPE0Dpr+tQA/Fumm7wzVP6qfeVaY+6pX04s= X-Endpoint-Received: by B4 Relay for joelselvaraj.oss@gmail.com/20240420 with auth_id=165 X-Original-From: Joel Selvaraj Reply-To: joelselvaraj.oss@gmail.com From: Joel Selvaraj Extend the novatek touchscreen driver to support NT36672A chip which is found in phones like Xiaomi Poco F1 [1]. Added devicetree support for the driver and used i2c chip data to handle the variation in chip id and wake type. Also added vcc and iovcc regulators which are used to power the touchscreen hardware. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dts?h=v6.9 Signed-off-by: Joel Selvaraj --- drivers/input/touchscreen/novatek-nvt-ts.c | 78 +++++++++++++++++++++++++++--- 1 file changed, 72 insertions(+), 6 deletions(-) diff --git a/drivers/input/touchscreen/novatek-nvt-ts.c b/drivers/input/touchscreen/novatek-nvt-ts.c index 1a797e410a3fa..83b881e14a0f3 100644 --- a/drivers/input/touchscreen/novatek-nvt-ts.c +++ b/drivers/input/touchscreen/novatek-nvt-ts.c @@ -31,9 +31,6 @@ #define NVT_TS_PARAMS_CHIP_ID 0x0e #define NVT_TS_PARAMS_SIZE 0x0f -#define NVT_TS_SUPPORTED_WAKE_TYPE 0x05 -#define NVT_TS_SUPPORTED_CHIP_ID 0x05 - #define NVT_TS_MAX_TOUCHES 10 #define NVT_TS_MAX_SIZE 4096 @@ -51,11 +48,18 @@ static const int nvt_ts_irq_type[4] = { IRQF_TRIGGER_HIGH }; +struct nvt_ts_i2c_chip_data { + u8 wake_type; + u8 chip_id; +}; + struct nvt_ts_data { struct i2c_client *client; struct input_dev *input; struct gpio_desc *reset_gpio; + struct regulator_bulk_data regulators[2]; struct touchscreen_properties prop; + const struct nvt_ts_i2c_chip_data *chip; int max_touches; u8 buf[NVT_TS_TOUCH_SIZE * NVT_TS_MAX_TOUCHES]; }; @@ -139,9 +143,23 @@ static irqreturn_t nvt_ts_irq(int irq, void *dev_id) return IRQ_HANDLED; } +static void nvt_ts_disable_regulators(void *_data) +{ + struct nvt_ts_data *data = _data; + + regulator_bulk_disable(ARRAY_SIZE(data->regulators), data->regulators); +} + static int nvt_ts_start(struct input_dev *dev) { struct nvt_ts_data *data = input_get_drvdata(dev); + int error; + + error = regulator_bulk_enable(ARRAY_SIZE(data->regulators), data->regulators); + if (error) { + dev_err(&data->client->dev, "failed to enable regulators\n"); + return error; + } enable_irq(data->client->irq); gpiod_set_value_cansleep(data->reset_gpio, 0); @@ -155,6 +173,7 @@ static void nvt_ts_stop(struct input_dev *dev) disable_irq(data->client->irq); gpiod_set_value_cansleep(data->reset_gpio, 1); + nvt_ts_disable_regulators(data); } static int nvt_ts_suspend(struct device *dev) @@ -199,9 +218,37 @@ static int nvt_ts_probe(struct i2c_client *client) if (!data) return -ENOMEM; + data->chip = device_get_match_data(&client->dev); + if (!data->chip) + return -EINVAL; + data->client = client; i2c_set_clientdata(client, data); + /* + * VCC is the analog voltage supply + * IOVCC is the digital voltage supply + */ + data->regulators[0].supply = "vcc"; + data->regulators[1].supply = "iovcc"; + error = devm_regulator_bulk_get(dev, ARRAY_SIZE(data->regulators), data->regulators); + if (error) { + dev_err(dev, "cannot get regulators: %d\n", error); + return error; + } + + error = regulator_bulk_enable(ARRAY_SIZE(data->regulators), data->regulators); + if (error) { + dev_err(dev, "failed to enable regulators\n"); + return error; + } + + error = devm_add_action_or_reset(dev, nvt_ts_disable_regulators, data); + if (error) { + dev_err(dev, "failed to install regulator disable handler\n"); + return error; + } + data->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); error = PTR_ERR_OR_ZERO(data->reset_gpio); if (error) { @@ -225,8 +272,8 @@ static int nvt_ts_probe(struct i2c_client *client) if (width > NVT_TS_MAX_SIZE || height >= NVT_TS_MAX_SIZE || data->max_touches > NVT_TS_MAX_TOUCHES || irq_type >= ARRAY_SIZE(nvt_ts_irq_type) || - data->buf[NVT_TS_PARAMS_WAKE_TYPE] != NVT_TS_SUPPORTED_WAKE_TYPE || - data->buf[NVT_TS_PARAMS_CHIP_ID] != NVT_TS_SUPPORTED_CHIP_ID) { + data->buf[NVT_TS_PARAMS_WAKE_TYPE] != data->chip->wake_type || + data->buf[NVT_TS_PARAMS_CHIP_ID] != data->chip->chip_id) { dev_err(dev, "Unsupported touchscreen parameters: %*ph\n", NVT_TS_PARAMS_SIZE, data->buf); return -EIO; @@ -277,8 +324,26 @@ static int nvt_ts_probe(struct i2c_client *client) return 0; } +static const struct nvt_ts_i2c_chip_data nvt_ts_data = { + .wake_type = 0x05, + .chip_id = 0x05, +}; + +static const struct nvt_ts_i2c_chip_data nvt_nt36672a_ts_data = { + .wake_type = 0x01, + .chip_id = 0x08, +}; + +static const struct of_device_id nvt_ts_of_match[] = { + { .compatible = "novatek,nvt-ts", .data = &nvt_ts_data }, + { .compatible = "novatek,nt36672a-ts", .data = &nvt_nt36672a_ts_data }, + { } +}; +MODULE_DEVICE_TABLE(of, nvt_ts_of_match); + static const struct i2c_device_id nvt_ts_i2c_id[] = { - { "NVT-ts" }, + { "NVT-ts", (unsigned long) &nvt_ts_data }, + { "NT36672A-ts", (unsigned long) &nvt_nt36672a_ts_data }, { } }; MODULE_DEVICE_TABLE(i2c, nvt_ts_i2c_id); @@ -287,6 +352,7 @@ static struct i2c_driver nvt_ts_driver = { .driver = { .name = "novatek-nvt-ts", .pm = pm_sleep_ptr(&nvt_ts_pm_ops), + .of_match_table = nvt_ts_of_match, }, .probe = nvt_ts_probe, .id_table = nvt_ts_i2c_id,