From patchwork Wed Jul 17 06:33:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaowei Pu X-Patchwork-Id: 813087 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2056.outbound.protection.outlook.com [40.107.255.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFCE013ACC; Wed, 17 Jul 2024 06:33:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.255.56 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721198018; cv=fail; b=E9GENnkIAxZGTCS6JbtKirUEnsN3jj8gJiDluyG49loA6WNmkli5MUtWZQpQUFotMRM9F6J6/Xs7yMYmP7fpXJ9iVGgQVOdvJ68SPmHOo+O789g6AXaGnvPgP2L0Coqc836pkEdOqytQJjOnxv2G1ezbT0tCrASwxYUq/nArtx0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721198018; c=relaxed/simple; bh=765OpcBKuMHUf3wAF87WQVSvxVNX1zGmsLwg64jnOUA=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=iH5/OmUnO5oNbINCWuqmBUqA0uuoAkXKiRju+x4XgXDJ+yeDc29wVNc1JgQSTdHoh7cz7S67MNbFZctPn2TjtjLeK68JKIuXt1umpARHB6PH3f9geleq6qJmlqi5ABf5EGFn2w1kMjOhroL9Vh7ppcodCzAojd3Vw799/P3a4fs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=oppo.com; spf=pass smtp.mailfrom=oppo.com; dkim=pass (1024-bit key) header.d=oppo.com header.i=@oppo.com header.b=oW2ER1gc; arc=fail smtp.client-ip=40.107.255.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=oppo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oppo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=oppo.com header.i=@oppo.com header.b="oW2ER1gc" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rpWof34FGU5sJOrHGlRx/aYK4vJblDqOr3y1A68aUhtrBg/zRri3gBX21StlDJHcWwADmz1vZ9yIBzT8pwBfL/ickbvDNngd64DAhx/CwMaMUQBj5FU5ogQq1sQgzrhDhmz0G/fkvxhpW2qC0gENSD4Xb3wL0SIhr0K9y1f3Cp5bjvYnn//xrCE57ct0IMvhDXFaoP61CWjQSgs5TDITjAxCeptj2Zr9iR6HRHQU0MnZPFJeK8yqI82oFvbgAJDeihoWnj71CeA1qrF/cM7yr6o272P3Ux9D5O9J51sVyxo6LYElz/RWRMl48iE9WePtYvq7aHzrUbfUXX/bjFjEBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NnqwCsUlYNUICfXfBAYhv3o9jxzb/xg0/Zu00y+Wtrw=; b=IrcTWqIv3XWXZ/VdctwzsY+/jaOe4yV86LQnPevHYZQ50XUD2oa2QKW4nD+qTlR7vDtOBo+3NgCdlZusORLUDrIxVPrDUX942u/L3l6oK+MUV8JHKPQjER4k1fG5tKPqUAGRDFMET72fLzHrtThY4rUOczuJfxGJasDH9wHXl72E4/FifB/ie313DDE1Isvjav1BnWYbwUOjBJ9QVK4bq5XtlrcwZKWCfjJTFV8EvuzUy23TY1oTnyQedVK9Opogw/K0Ngd2uExOomSLSq85FGsmJfqyER/VkZw25TJk7qOgCzqifr7P7CaOoudn5nkRH1AiOzB88J7h3jmK+8eZbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oppo.com; dmarc=pass action=none header.from=oppo.com; dkim=pass header.d=oppo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oppo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NnqwCsUlYNUICfXfBAYhv3o9jxzb/xg0/Zu00y+Wtrw=; b=oW2ER1gcbYaNFfKHIhejyDaqIg7CW9i6Dl9vRYthylGbBZcEDaD/g4+49TJHNrtJZ75U++6w4rTBcMM6M/7P1JmyCodoIZZh9+JP8j0xa0R80svEHpyhPNkZge1OeJD0RBFAiFffPQwOQ+0VeSUgFMr+nw+ocZBLL6TreCHBDPs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oppo.com; Received: from SEYPR02MB8152.apcprd02.prod.outlook.com (2603:1096:101:206::6) by TYSPR02MB7218.apcprd02.prod.outlook.com (2603:1096:400:46e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.30; Wed, 17 Jul 2024 06:33:33 +0000 Received: from SEYPR02MB8152.apcprd02.prod.outlook.com ([fe80::6bae:c194:2032:70d7]) by SEYPR02MB8152.apcprd02.prod.outlook.com ([fe80::6bae:c194:2032:70d7%4]) with mapi id 15.20.7762.027; Wed, 17 Jul 2024 06:33:33 +0000 From: Gaowei Pu To: rafael@kernel.org, viresh.kumar@linaro.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Gaowei Pu Subject: [PATCH] cpufreq: queue policy->update work to rt thread to reduce its schedule latency Date: Wed, 17 Jul 2024 14:33:21 +0800 Message-Id: <20240717063321.629-1-pugaowei@oppo.com> X-Mailer: git-send-email 2.17.1 X-ClientProxiedBy: SG2PR03CA0128.apcprd03.prod.outlook.com (2603:1096:4:91::32) To SEYPR02MB8152.apcprd02.prod.outlook.com (2603:1096:101:206::6) Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEYPR02MB8152:EE_|TYSPR02MB7218:EE_ X-MS-Office365-Filtering-Correlation-Id: 59978cba-884e-418f-296e-08dca62a6184 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: 5XHZKsKCeaWrNWoWL6VS9RWdFhj97gHDSx+USuwrTOkYSTh/CnzAsroSXxL2JKbdx+/BQh8QwmDmBxiicsX+QkHxh64h0U8CppLHsG5e9SsqgH+IJMRrxvXxI63Fjvb1FeWj93C9YoPk9X/C4Hk0ceSRTS/9/J8uEi9+x0QZdzU6KczuZ0DrDIsho2HXmDQ9zRCb2rCqtsKRJyWvdP+f4CZldP8VCk79a9CBelD9l3X5cZwkB/Ur50sZDuHtFpZxwUHdfirNso8uIGw3ECHmq6g5lvdWyRraVmVRsz+9q5oloiJqLdfySkcHt0obxDEDeSg+xcVOtSqYzYI4umW9OHU0XUiQ8EKJdIc+QmD8OzgXryo4Oh9R1lpn8wtZFC11zFtCM4frjkWSW62D0o2Z6QUJuVz12QjFvwouPKtiVpCankqv6CcH7zIMHcaNkIseHT54uqPC5hBD7M5wX95EkoFXygLYvh3l2i8JQrPZV7cdQekOu1hjkLHqrcDMGslrF1a/9YDCdrSIaZh4h3QKtyhwv/FTt4JZ0n0u05QDfl+oWQy+osrFyh0A8RArdcJS678o/Jci9PVBUzUxl6wv5EF6do08DtA8sBHjmvKL30Fjs1+b9+/AylTEmLEnJ84TKAWLIji2zA/FFazHcb+cxEXBQjRUwEFTZZlJB4GJsVcQw6TR5Tt6dYe9+qU+YNJM+B861+gZsj7wuHRBesfMRTisTJY1r1Q0XVOT9bAEJjUmcjuDukfsAJa1GS7EtHiKpA23hIp9AXUB6HKBZrF0x6ENmaiGU2aJeovx/2QcYSNVrY/h8e35l6Fgjje1PvFj0RUKFT6QsOEO5MeIFYhXR9b62yoH6bwXn5Td27yoCUdIXmvntIJ83dmJU9O2Gd+hotI6icHgEqJA2EgFRvSg/zKF1aFDQ+CR/gCnHUKjISZB0SaF8J6ou6eIm8zEbH/2qUdyMju1fMNdDKsdjyiKNrJ+gZj42pSIDwBSITlbdlYvZyH47R8ewjNX6oOGUSVX5BV9kAIu/EkpFI7vV/FxNU6ZZMh7aT2DCeWjIPQA1lZPWqZ7HgLlLO0y///r+EguVfInflOMF1NkGRXcmTmLqkk8YyDuh05yEpCBfyFE4VGOOMvoI6U54L6vCTqd+nf23+YySUus0YB6pdoEBHxSSKyVrB6hPBs/9aBIfv6Tk5e/+N8hXV40liEeBm4B8UtLh84KIchwZIqbOJLhsUXxKIVaoNb/Cb+9UPWSwELJOy1Gm+24mEFl0AGEICjxMlTlSu5Bjnl0d9pnsbzi4ogY9Q7qf9Dn2pHcYqGxqFPqixzMzUj5QoXuhPw50SxI323PpHymTDgGO40EuPvwl/sEmfzQlLbJ+BgFgGRVkJn344L/hZJ2RaGZdAWZ4qw7WamvM4rSmxhu0rqiEnO17P4EHA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEYPR02MB8152.apcprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(52116014)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Bek2uXo5kEeqasBj9T20u8xJx2/JXNzdXmrxcF+ZiGkESNBkcdNawJeidoM58RqgpyJP5+I7FazUTUzKLNFAXrrx8CDeVMk0hl4O4+7oVt5PvehhVJvRxbUOal7ylTIsctf8fmwhBxTCEtJfUx7+9Eir44KSkvtf9xLyB1kHPFpXYlHUNbMEQwYyDbf/rWf64+Q1KQtR9V2K6cfj18uvt1B151zyKTJPadBZxslGUS1eEhGM7Wu/r9EZkyi7yNRaz9sb4JLyJ1sCDn+g/gZ0FfOMrO2DlfUNuPxWD2Ey685DcH079gCv3Y3pIRVmwTDTFJ7EptLtbyDG7LC7GN8xk+9xlEcIDNskT5RUYzapApsOnHRResadmcUx1+XAC6zAXse3ZENpWff1xyEN2kT2NIrrPWmdB2FGzfeI65VGVPuDjL3RVNS62yaoEdu87ZdCYuH7FfAhe0wRLkdVgMO1+HXHrmqFSlKuHOwnA9KMon/fqFChJMXkN6gISMcvnNyTRRUwMsMfHRfxxkaPHXLDn2zCAnxIuJIDoaEW2jhGrHyD4w5FPDBvyV1k0tKoY5O1s2XWwUdFkxveWXQHUCyaGezwz7W1qE4fBHC7ISlyvpqpcDaQ78hFpJNqkqTqAIbR0NyxoURZcrBgLJ/qzb5hUZdGqZx5NX5MQIWgbhxDUIqK0iXY9yJriKb0bZfP1WwUeYQ35g0xSgNpcdXVei1Rqaj1TmSlLkCBlUfDFYthO4Av4EB7az2uYJal4HvxIDdPmImIFOxDfH4rhlzvb0IL5Ykcd/BBR5lWLH88SxpuV2ynrZy1OJYYrON7pp84Y1prK1oEbox83M0hdoA+W0SYVe9CG4yM3DZTcyZ1/N90pOcziqaEd1Og605SmjI3r7VHCbu9RAwhA4mazJiyRd1y2tka/mRslTEH0jV7yrnqhh4eA2udM9UpQcL2AW9jNSQZ26kz6IqLocQzZMTkJXDWdbcvOYFMlB0psHfuKlYVNp6KU8YLaByOibx9kewbJfXTXUlxypgyVl6xROS2Lr+FSXtbc5h7li7d1hBDhW7FSGDFPiczJRxw32iXPjzNnPQ48RsYDwlt7Vvks8SavSiFzXj9zI4VQEHqQL8sFbMUCUZsJll6VPe4DznyuaMbcHBkJkfTAXlsJV+m81FDLXuuQOXSe4BVCNAlrlwz3gbOnzm6LpdVhPNXxK7FkUM+ie/MzXpuUnPsMXIfw5etq69fZ1lFF0JrckNpvHQ0+UpSx5K0Iw4LFBUR3/7lygCSLFt2ik3g5t4BEpwxfLVgZ6jom0BmYVIjK3HrQSjAGdSFoBFTBJm+jy3WDlm/akhji0wHnF4U5pDSHEFBFBg4e5gwmP8bjJBH8jhuhQkmQj6yLN7YK3724ZhcKZM5UhBzv24ErG0u4iSG8C5blm5IR2imrP26iC9gPIYi5LAq/nhEMhWJo4LKVKBtAwOWi9uBkuqQi7dl+egke1mkmfV6aui7PgrCQX4Nhgys4X5bc7xO2tKbm2uHGQSaZoyEME4ejrBl1pyw4GBvKIKXhXXOVUZCR7WFJTfCGh8fWh/EAAE1GKyUq2nVjVkrT5uwEnRGKpXo X-OriginatorOrg: oppo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59978cba-884e-418f-296e-08dca62a6184 X-MS-Exchange-CrossTenant-AuthSource: SEYPR02MB8152.apcprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2024 06:33:33.7437 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1h5DKnri/Z1+tMtmEuVCc40n11g0JL774JWQ1JL1iObiTbPXADTbZ3hs2bRe6VK0vybjrfUWU/7fG2yE1jauPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYSPR02MB7218 Currently we encountered a problem that the cpufreq boost latency is about 10 milliseconds or worse when we boost through cpufreq QOS request under high workload scenarios, while the boost latency mainly consumed by schedule latency of policy->update work. We should ensure the low schedule latency of cpu frequency limits work to meet performance and power demands. so queue the policy->update work to rt thread to reduce its schedule latency. Signed-off-by: Gaowei Pu --- drivers/cpufreq/cpufreq.c | 24 ++++++++++++++++++------ include/linux/cpufreq.h | 4 +++- 2 files changed, 21 insertions(+), 7 deletions(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index a45aac17c20f..e6e42a3ba9ab 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1193,7 +1193,7 @@ void refresh_frequency_limits(struct cpufreq_policy *policy) } EXPORT_SYMBOL(refresh_frequency_limits); -static void handle_update(struct work_struct *work) +static void handle_update(struct kthread_work *work) { struct cpufreq_policy *policy = container_of(work, struct cpufreq_policy, update); @@ -1209,7 +1209,7 @@ static int cpufreq_notifier_min(struct notifier_block *nb, unsigned long freq, { struct cpufreq_policy *policy = container_of(nb, struct cpufreq_policy, nb_min); - schedule_work(&policy->update); + kthread_queue_work(policy->worker, &policy->update); return 0; } @@ -1218,7 +1218,7 @@ static int cpufreq_notifier_max(struct notifier_block *nb, unsigned long freq, { struct cpufreq_policy *policy = container_of(nb, struct cpufreq_policy, nb_max); - schedule_work(&policy->update); + kthread_queue_work(policy->worker, &policy->update); return 0; } @@ -1301,15 +1301,25 @@ static struct cpufreq_policy *cpufreq_policy_alloc(unsigned int cpu) goto err_min_qos_notifier; } + policy->worker = kthread_create_worker_on_cpu(cpu, 0, "policy_worker%d", cpu); + if (IS_ERR(policy->worker)) { + dev_err(dev, "Failed to create policy_worker%d\n", cpu); + goto err_max_qos_notifier; + } + + sched_set_fifo_low(policy->worker->task); INIT_LIST_HEAD(&policy->policy_list); init_rwsem(&policy->rwsem); spin_lock_init(&policy->transition_lock); init_waitqueue_head(&policy->transition_wait); - INIT_WORK(&policy->update, handle_update); + kthread_init_work(&policy->update, handle_update); policy->cpu = cpu; return policy; +err_max_qos_notifier: + freq_qos_remove_notifier(&policy->constraints, FREQ_QOS_MAX, + &policy->nb_max); err_min_qos_notifier: freq_qos_remove_notifier(&policy->constraints, FREQ_QOS_MIN, &policy->nb_min); @@ -1353,7 +1363,9 @@ static void cpufreq_policy_free(struct cpufreq_policy *policy) &policy->nb_min); /* Cancel any pending policy->update work before freeing the policy. */ - cancel_work_sync(&policy->update); + kthread_cancel_work_sync(&policy->update); + if (policy->worker) + kthread_destroy_worker(policy->worker); if (policy->max_freq_req) { /* @@ -1802,7 +1814,7 @@ static unsigned int cpufreq_verify_current_freq(struct cpufreq_policy *policy, b cpufreq_out_of_sync(policy, new_freq); if (update) - schedule_work(&policy->update); + kthread_queue_work(policy->worker, &policy->update); } return new_freq; diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index 20f7e98ee8af..73029daddfc5 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -20,6 +20,7 @@ #include #include #include +#include /********************************************************************* * CPUFREQ INTERFACE * @@ -77,8 +78,9 @@ struct cpufreq_policy { void *governor_data; char last_governor[CPUFREQ_NAME_LEN]; /* last governor used */ - struct work_struct update; /* if update_policy() needs to be + struct kthread_work update; /* if update_policy() needs to be * called, but you're in IRQ context */ + struct kthread_worker *worker; struct freq_constraints constraints; struct freq_qos_request *min_freq_req;