From patchwork Fri Nov 8 18:49:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 178942 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp3138736ilf; Fri, 8 Nov 2019 11:06:03 -0800 (PST) X-Google-Smtp-Source: APXvYqxQ1Q/Y1eUIJ3TP0IcBu3K3KzJcna5MWK2fohwVyvgBxAK3Te/iWDJJg5hFVETe+LtlFmAr X-Received: by 2002:a17:906:a40e:: with SMTP id l14mr10257764ejz.168.1573239963779; Fri, 08 Nov 2019 11:06:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573239963; cv=none; d=google.com; s=arc-20160816; b=ZzxdETC6pn3c2nXpkOiTCfkEddyeFEP7gYZ8jGqsX4czCIl1LSkTuMnOcxnECtWRXc Fec7W5YA7bnAUzvKnx2DBQhga81oqmxLEw+0dcdKjo7q6VpNZzO3moV5k4l3ISFm627Z PuHK395bXFpK1+QyC8RhSmt1MJTvK10DLGKP+Qdj69xDEn6uf36xXbNu2sCRLXJtkF4U BNYoxY40GrnKH8xMKcGyEbWWmDHtsXt8kKdOpTUu6K3iPasfhw48VljrhBD4kdQdH+gT d2bTOX0o50HVpprc6YICxQ4ioBMIFQCtxPBhzX6WUrVCPtxSEadZMBoUIZ3BcU40xJZT q8JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=LWMiEf3TaIdHRIHew+RaTagdTfFU1oPdrxPc65bxZlw=; b=CByYq+lDwbkRbXM255VDlzpH/9c852vPiUGUhTLQ59l1hrToFYrRSu8Bxmei0tKFz2 iZYplvskrEO2cpN1llyWkseD+cqmf8vWEF1BQMjzFgBQvbNchnrYlF21c5t/ylqAZ7Vy WW1pWdYsMDS3lYHNmmYPLC31WlHDzoHPUU//ZPoDbkfpMZGuEZ7/GXp6O0+WIfvJ/noZ el/kNwUQScZO1EUeqw/LctIpBOyH2KiJZHcVfmInvVFWrYFDfd9nyfFxQU1chW9AOF+r l3a4YhsG377bCqsmM0i2fN0G+2t9DK1HXCknG7HBu9G1QoyKg83+1Jz0kGTjX3Ed0Had PKAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KqCuyFAu; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w14si4322250ejv.112.2019.11.08.11.06.03; Fri, 08 Nov 2019 11:06:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KqCuyFAu; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731745AbfKHTFz (ORCPT + 14 others); Fri, 8 Nov 2019 14:05:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:36114 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731327AbfKHTFy (ORCPT ); Fri, 8 Nov 2019 14:05:54 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BA33A21D7B; Fri, 8 Nov 2019 19:05:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573239953; bh=bvGk2PFPjcyhGJhlCfWTtMGwXqeLi/+EaaoNSMmvMW0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KqCuyFAupjauEVWPoh0hCSk5JAlnSwT9aYN6fc7wAiXjuIkbiQ5XAOLzPaXCVgPlX dl62WAGR8QcR1habuSIP5Tb1OJN0Uf62VSGxtSF+tO1+AkrwaByr28BNo8Aj+dRpj3 s1USxJWm9LzH8uoL0hX1UNGMRvnj5XyabaCcPtGk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "kernelci.org bot" , Nicolas Saenz Julienne , Masahiro Yamada , Russell King , Sasha Levin Subject: [PATCH 5.3 039/140] ARM: 8908/1: add __always_inline to functions called from __get_user_check() Date: Fri, 8 Nov 2019 19:49:27 +0100 Message-Id: <20191108174907.870917431@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191108174900.189064908@linuxfoundation.org> References: <20191108174900.189064908@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Masahiro Yamada [ Upstream commit 851140ab0d083c78e5723a8b1cbd258f567a7aff ] KernelCI reports that bcm2835_defconfig is no longer booting since commit ac7c3e4ff401 ("compiler: enable CONFIG_OPTIMIZE_INLINING forcibly") (https://lkml.org/lkml/2019/9/26/825). I also received a regression report from Nicolas Saenz Julienne (https://lkml.org/lkml/2019/9/27/263). This problem has cropped up on bcm2835_defconfig because it enables CONFIG_CC_OPTIMIZE_FOR_SIZE. The compiler tends to prefer not inlining functions with -Os. I was able to reproduce it with other boards and defconfig files by manually enabling CONFIG_CC_OPTIMIZE_FOR_SIZE. The __get_user_check() specifically uses r0, r1, r2 registers. So, uaccess_save_and_enable() and uaccess_restore() must be inlined. Otherwise, those register assignments would be entirely dropped, according to my analysis of the disassembly. Prior to commit 9012d011660e ("compiler: allow all arches to enable CONFIG_OPTIMIZE_INLINING"), the 'inline' marker was always enough for inlining functions, except on x86. Since that commit, all architectures can enable CONFIG_OPTIMIZE_INLINING. So, __always_inline is now the only guaranteed way of forcible inlining. I added __always_inline to 4 functions in the call-graph from the __get_user_check() macro. Fixes: 9012d011660e ("compiler: allow all arches to enable CONFIG_OPTIMIZE_INLINING") Reported-by: "kernelci.org bot" Reported-by: Nicolas Saenz Julienne Signed-off-by: Masahiro Yamada Tested-by: Nicolas Saenz Julienne Signed-off-by: Russell King Signed-off-by: Sasha Levin --- arch/arm/include/asm/domain.h | 8 ++++---- arch/arm/include/asm/uaccess.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) -- 2.20.1 diff --git a/arch/arm/include/asm/domain.h b/arch/arm/include/asm/domain.h index 567dbede4785c..f1d0a7807cd0e 100644 --- a/arch/arm/include/asm/domain.h +++ b/arch/arm/include/asm/domain.h @@ -82,7 +82,7 @@ #ifndef __ASSEMBLY__ #ifdef CONFIG_CPU_CP15_MMU -static inline unsigned int get_domain(void) +static __always_inline unsigned int get_domain(void) { unsigned int domain; @@ -94,7 +94,7 @@ static inline unsigned int get_domain(void) return domain; } -static inline void set_domain(unsigned val) +static __always_inline void set_domain(unsigned int val) { asm volatile( "mcr p15, 0, %0, c3, c0 @ set domain" @@ -102,12 +102,12 @@ static inline void set_domain(unsigned val) isb(); } #else -static inline unsigned int get_domain(void) +static __always_inline unsigned int get_domain(void) { return 0; } -static inline void set_domain(unsigned val) +static __always_inline void set_domain(unsigned int val) { } #endif diff --git a/arch/arm/include/asm/uaccess.h b/arch/arm/include/asm/uaccess.h index 303248e5b990f..98c6b91be4a8a 100644 --- a/arch/arm/include/asm/uaccess.h +++ b/arch/arm/include/asm/uaccess.h @@ -22,7 +22,7 @@ * perform such accesses (eg, via list poison values) which could then * be exploited for priviledge escalation. */ -static inline unsigned int uaccess_save_and_enable(void) +static __always_inline unsigned int uaccess_save_and_enable(void) { #ifdef CONFIG_CPU_SW_DOMAIN_PAN unsigned int old_domain = get_domain(); @@ -37,7 +37,7 @@ static inline unsigned int uaccess_save_and_enable(void) #endif } -static inline void uaccess_restore(unsigned int flags) +static __always_inline void uaccess_restore(unsigned int flags) { #ifdef CONFIG_CPU_SW_DOMAIN_PAN /* Restore the user access mask */ From patchwork Fri Nov 8 18:51:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 178947 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp3148404ilf; Fri, 8 Nov 2019 11:13:21 -0800 (PST) X-Google-Smtp-Source: APXvYqytbUuhr9+rfgjNb7OzhUNNR35HdPH2TN+Au9xL7lfawGk3k6aIM5n4bMUoDHQnKVQyS3rQ X-Received: by 2002:a50:ed12:: with SMTP id j18mr12546858eds.172.1573240256528; Fri, 08 Nov 2019 11:10:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573240256; cv=none; d=google.com; s=arc-20160816; b=QkFq+mwhFjjd5xWUOiA0Nnahf4gYR84wAXZXV+KSuyWtY/MY1SDdImS518Pagxdsg0 waNbuALjIcrPKyx+hlkLUnFBSlDVZDT6/C0mHWqHNy5O5PM6fgdyOrjN3wpo56AJ363q RPGlxSnCUfaMTXqvVMaAQb3jcAW6Hif2Pxestzcqk1JTXEZLhcFqJ0tNkiIWP8WS4N+l JzqTiRGSqjAiZAzvHBs34tXCNr0icx3Jb8B7TjDHkR1aIPGwCUZqEpIiJhSTxD8RRyqX R2nUUmPMPOKrLrxM4+tRHjcgT02jxcBMhB4xAcvxKinFHDMA8Uw54Bzvb5TqWBVYWsXs FG3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=5X8kjKnDS687RsmPRh6VH7w/TV7rW8oelhh/l+fdJko=; b=BnLG5IKyVeSjJ+uE7KwYIWf0iZHlSMxPVZPY7gXC5d3+Z9W2Lok4oN0F1JvYAX/Hgj tr6+vXGOuS6Vm8+yIQq7LlF/Y53dtr8g4cvLhmqHA+T/+x9l45e5F4m+BWQUWQcqPwqa ooLrMXn8OXSgj0+0gDntVaJCH5hD2MhmU1J947GjPmhlbgWdtDG4kFvbQty1rMpflkvC 41tw/k2hhffsaqS/EWa2wFmo7qo9uR/oFCUfK4/L6+ZrhJG8kIpSfksRiryc0Bykki7b CdECSOJaaArFQQ22QrZJZqoTyBL6nc0uT4I6JqXOYKc7MHmHruGj0HncfAF0LlKhMdFa YKiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="jl1a/VGi"; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w29si4908786edd.270.2019.11.08.11.10.56; Fri, 08 Nov 2019 11:10:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="jl1a/VGi"; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391159AbfKHTKs (ORCPT + 14 others); Fri, 8 Nov 2019 14:10:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:43102 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388212AbfKHTKr (ORCPT ); Fri, 8 Nov 2019 14:10:47 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9877B2087E; Fri, 8 Nov 2019 19:10:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573240247; bh=YgFdIDx7lKvpMrjO7Ql6gaMp8ykgcdrlVzFdJ08KVT8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jl1a/VGiXXOYZ7IeuD6j+J/yP9L+sPioN6A+n+wpwdTLHbLcC8cqibytIYjM10vJs 51le0u+8hDc+BZtmTuRUES0DQtM5b2uHa2xclPsoRW6d//WFZ9ZlC9MS25+yWlnire dsZwp1gd6iHqcCtoqFXoDrSna2LezD9vmBjKQWE0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Robert Tivy , Suman Anna , Tero Kristo , Mathieu Poirier Subject: [PATCH 5.3 139/140] arm64: dts: ti: k3-am65-main: Fix gic-its node unit-address Date: Fri, 8 Nov 2019 19:51:07 +0100 Message-Id: <20191108174913.315199103@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191108174900.189064908@linuxfoundation.org> References: <20191108174900.189064908@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Suman Anna commit 389ce1a7c5279ebfb682fab220b4021b2bd49c8b upstream. The gic-its node unit-address has an additional zero compared to the actual reg value. Fix it. Fixes: ea47eed33a3f ("arm64: dts: ti: Add Support for AM654 SoC") Reported-by: Robert Tivy Signed-off-by: Suman Anna Signed-off-by: Tero Kristo Signed-off-by: Mathieu Poirier Signed-off-by: Greg Kroah-Hartman --- arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi @@ -42,7 +42,7 @@ */ interrupts = ; - gic_its: gic-its@18200000 { + gic_its: gic-its@1820000 { compatible = "arm,gic-v3-its"; reg = <0x00 0x01820000 0x00 0x10000>; socionext,synquacer-pre-its = <0x1000000 0x400000>; From patchwork Fri Nov 8 18:51:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 178946 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp3146218ilf; Fri, 8 Nov 2019 11:11:36 -0800 (PST) X-Google-Smtp-Source: APXvYqwzegZEPONv3QdJD6Rkh7ggQZJ0hXX1alLgXJk/ThqcJpma4t+KhWRxV+WQ7e77/YvZpwIQ X-Received: by 2002:a50:cb86:: with SMTP id k6mr12396216edi.270.1573240296265; Fri, 08 Nov 2019 11:11:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573240296; cv=none; d=google.com; s=arc-20160816; b=P8vrWdbmBOw8LqubGyRNNgmbLFMy6Tmqd50LhNyqxxb3ZwA3IdY1W/rqAjzuxHylqM 1eZB1LuKtc2bmFG/BKWdMECfduJICoAXTFUET7ZBxJetJKE4jfrUiEFg3AMs8rWkTxhp Cq5BSi5/jHU2DjRG9WiiXE3roOlbAZ3U7UZ05VngVTCEsQ6c6rvepFGxYYq9/xS2q73T d/XIF/hHbJBlnJhYsniOrvE30Z33ASJrXDalg6w00WiDELKgrvZTWnsvfGAJw15pG1x7 6dyOFOLIKPLKcVN5YONds2QupKwaUhvx7UUP0pWqNcT1smu102qu3sEePU2OljJFQ5aX 0kQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=QaQjKNP+BSEAuqV2uII7VzqDMWABKwtP6HkjwQpc1OY=; b=vOI96aM5pX66dQ83y2DmkKxESUKcc09zLm/9XGquXovHx+t5IkWQh898EDUuDoEkbr Ebg9pLKQYFsJofjJZ3GRL7lZwUXRPQ6SWxDLO9vKPHtDsDN1HLqRVxuq5tuP73LFlEtu 1ce0alpY+zgUyWpqbHGtZi+t+HnZo6IYA9AJi/0yj62XkbP5Qh2F65QZLYogrKw6y2ZO 4NeQ16N5mtBYnq/G1/BAm6h2LByWkFv5hSHq2pduSvbqxeuVjmW+JPy/Vsu06PPfh4dP wicuYXsxCA3m0gzmT2VY1JWcxYJ6zC5ArptspVYMoSUYmVqwpgvivr1Rb03wOosNWDWV rexA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JCk2bWvp; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bi3si5196621edb.331.2019.11.08.11.11.35; Fri, 08 Nov 2019 11:11:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JCk2bWvp; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391936AbfKHTKw (ORCPT + 14 others); Fri, 8 Nov 2019 14:10:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:43182 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391934AbfKHTKv (ORCPT ); Fri, 8 Nov 2019 14:10:51 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A8CDA222C9; Fri, 8 Nov 2019 19:10:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573240250; bh=49HBYkfwhhhr3Yi35zOi9YBhBh7UK9S4nHQX2zOGc2c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JCk2bWvprto/3kWfbwGljX0kMttluykoL49f0pxSm6S0CWIiL9adqgLTaRx/Mjzlq Q/0kl+ap5FzSjGOjweUnlgOzN7dZcV6wSr7XnVGsZx2MGzbulw2RdQ37t9wQ4mhdtK 2LrwA4NzT2OgmYVJoSXSuoFo+K1On8rnMz3W4iwk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alan Stern , Roger Quadros , Felipe Balbi , Mathieu Poirier Subject: [PATCH 5.3 140/140] usb: gadget: udc: core: Fix segfault if udc_bind_to_driver() for pending driver fails Date: Fri, 8 Nov 2019 19:51:08 +0100 Message-Id: <20191108174913.368339213@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191108174900.189064908@linuxfoundation.org> References: <20191108174900.189064908@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Roger Quadros commit 163be6ff7739b12ff300d77897d340f661821da2 upstream. If a gadget driver is in the pending drivers list, a UDC becomes available and udc_bind_to_driver() fails, then it gets deleted from the pending list. i.e. list_del(&driver->pending) in check_pending_gadget_drivers(). Then if that gadget driver is unregistered, usb_gadget_unregister_driver() does a list_del(&driver->pending) again thus causing a page fault as that list entry has been poisoned by the previous list_del(). Fix this by using list_del_init() instead of list_del() in check_pending_gadget_drivers(). Test case: - Make sure no UDC is available - modprobe g_mass_storage file=wrongfile - Load UDC driver so it becomes available lun0: unable to open backing file: wrongfile - modprobe -r g_mass_storage [ 60.900431] Unable to handle kernel paging request at virtual address dead000000000108 [ 60.908346] Mem abort info: [ 60.911145] ESR = 0x96000044 [ 60.914227] Exception class = DABT (current EL), IL = 32 bits [ 60.920162] SET = 0, FnV = 0 [ 60.923217] EA = 0, S1PTW = 0 [ 60.926354] Data abort info: [ 60.929228] ISV = 0, ISS = 0x00000044 [ 60.933058] CM = 0, WnR = 1 [ 60.936011] [dead000000000108] address between user and kernel address ranges [ 60.943136] Internal error: Oops: 96000044 [#1] PREEMPT SMP [ 60.948691] Modules linked in: g_mass_storage(-) usb_f_mass_storage libcomposite xhci_plat_hcd xhci_hcd usbcore ti_am335x_adc kfifo_buf omap_rng cdns3 rng_core udc_core crc32_ce xfrm_user crct10dif_ce snd_so6 [ 60.993995] Process modprobe (pid: 834, stack limit = 0x00000000c2aebc69) [ 61.000765] CPU: 0 PID: 834 Comm: modprobe Not tainted 4.19.59-01963-g065f42a60499 #92 [ 61.008658] Hardware name: Texas Instruments SoC (DT) [ 61.014472] pstate: 60000005 (nZCv daif -PAN -UAO) [ 61.019253] pc : usb_gadget_unregister_driver+0x7c/0x108 [udc_core] [ 61.025503] lr : usb_gadget_unregister_driver+0x30/0x108 [udc_core] [ 61.031750] sp : ffff00001338fda0 [ 61.035049] x29: ffff00001338fda0 x28: ffff800846d40000 [ 61.040346] x27: 0000000000000000 x26: 0000000000000000 [ 61.045642] x25: 0000000056000000 x24: 0000000000000800 [ 61.050938] x23: ffff000008d7b0d0 x22: ffff0000088b07c8 [ 61.056234] x21: ffff000001100000 x20: ffff000002020260 [ 61.061530] x19: ffff0000010ffd28 x18: 0000000000000000 [ 61.066825] x17: 0000000000000000 x16: 0000000000000000 [ 61.072121] x15: 0000000000000000 x14: 0000000000000000 [ 61.077417] x13: ffff000000000000 x12: ffffffffffffffff [ 61.082712] x11: 0000000000000030 x10: 7f7f7f7f7f7f7f7f [ 61.088008] x9 : fefefefefefefeff x8 : 0000000000000000 [ 61.093304] x7 : ffffffffffffffff x6 : 000000000000ffff [ 61.098599] x5 : 8080000000000000 x4 : 0000000000000000 [ 61.103895] x3 : ffff000001100020 x2 : ffff800846d40000 [ 61.109190] x1 : dead000000000100 x0 : dead000000000200 [ 61.114486] Call trace: [ 61.116922] usb_gadget_unregister_driver+0x7c/0x108 [udc_core] [ 61.122828] usb_composite_unregister+0x10/0x18 [libcomposite] [ 61.128643] msg_cleanup+0x18/0xfce0 [g_mass_storage] [ 61.133682] __arm64_sys_delete_module+0x17c/0x1f0 [ 61.138458] el0_svc_common+0x90/0x158 [ 61.142192] el0_svc_handler+0x2c/0x80 [ 61.145926] el0_svc+0x8/0xc [ 61.148794] Code: eb03003f d10be033 54ffff21 a94d0281 (f9000420) [ 61.154869] ---[ end trace afb22e9b637bd9a7 ]--- Segmentation fault Acked-by: Alan Stern Signed-off-by: Roger Quadros Signed-off-by: Felipe Balbi Signed-off-by: Mathieu Poirier Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/udc/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/usb/gadget/udc/core.c +++ b/drivers/usb/gadget/udc/core.c @@ -1154,7 +1154,7 @@ static int check_pending_gadget_drivers( dev_name(&udc->dev)) == 0) { ret = udc_bind_to_driver(udc, driver); if (ret != -EPROBE_DEFER) - list_del(&driver->pending); + list_del_init(&driver->pending); break; }