From patchwork Thu Nov 14 08:40:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 179378 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp10756319ilf; Thu, 14 Nov 2019 00:40:36 -0800 (PST) X-Google-Smtp-Source: APXvYqzreT+thyf+qfa0HlgsdjU6veiactJhQrkbmcPF8BH7gJFLsKLmIuRgXdK81Ai9XQc+s7S9 X-Received: by 2002:a17:906:bce5:: with SMTP id op5mr7293257ejb.325.1573720836733; Thu, 14 Nov 2019 00:40:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1573720836; cv=none; d=google.com; s=arc-20160816; b=xQN/RBn+Jbe4c93UeCJ2l7HRR1id8yJHpOKA9HogFhkfmFXcLv4pYGE9enZxmzkHwj hQ2mymv9CD5Jrvdd6CosOzMTRThwyvDZm00eCSlUXTe2PIKPIaniTirP4z08dJwz244f /aJ+6ezZFySKCwUWRnWlNSC3qJnk0tJlbc6M8pcRwIIrMQLSrYkRSBMDptjIvENf5Rg6 gLlfQdXsuFYMizwW4P5vPSnuyhakf+PRK686bR/xXE6LxIslGZEy0ltk8EYATw24LFTG JGrjdTVu5G8ActNtcf1BOWBOeBLirsgPXWEvgwP+3ojGTkbmUxtPbbUySl2WNqTuPSqo D86Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=to:subject:message-id:date:from:mime-version:dkim-signature :delivered-to:sender:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mailing-list:dkim-signature :domainkey-signature; bh=Fix62tUDgdhS/yU0Lk0fPhh2ocKLTjR+4ixQ10K7srU=; b=0l+6YjT2GU3NW2wU9Tw1/sTS+eVxCEVeC+bxhTqB0mu0RgLAyjcrJNPWMdsiIPHcfg ZrYzDeqYclcVcJDCOaDmQE5b6qcqULnA3sGJSEbYp0hN8ev8i8uUzyAix4YbD9zxf60e hBI8FLyO3AzpSREsO6S+46sPt5iuHonIJsnjYxdV/PQPFB7+6s1DpdY8vKmt32a/6TvG SDzp0idFetBdqEGFWQf0SfdrQed/1VSaiDUTS7HzUvQQQU/hRu49fjJP04CNiSleKuXD QR1Z/n6GJ5dNnt009Sbt2+biUSgXeHdskNmdm3V3/iG5vPmql5gx3mZfgC4BLv19W52M MCuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=mp5ymXLF; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=v48oVSQj; spf=pass (google.com: domain of gcc-patches-return-513334-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="gcc-patches-return-513334-patch=linaro.org@gcc.gnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id d10si4142642edn.266.2019.11.14.00.40.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Nov 2019 00:40:36 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-513334-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=mp5ymXLF; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=v48oVSQj; spf=pass (google.com: domain of gcc-patches-return-513334-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="gcc-patches-return-513334-patch=linaro.org@gcc.gnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; q= dns; s=default; b=hRBL2V2cm4qr106yGg3znOsklPBiRFpkyMTt+tGJLo0MnJ vd7V6h30w7UBEvrGJuENV8SL8PZF1nWi09m9qWTVuE3YgHWxieUG1mAjDmjBVu28 Y5mpxeAwEAUpq4fz3Tu6pAEmkEqACjo4QsE0xxNNOMmxqMFrpWhmlFXkpm1zs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; s= default; bh=ei9SqIMRo/Hj6Kgh28NvO4/1ecg=; b=mp5ymXLFG7xkbRacDmQP GZExKUAsg5g/qxyG2VXATi2sUYzRJ4g11VNw2JOcNl1Vrzy5fpAHw8excDjhn6tL XZw4eXVQ5gkPdlo/M1SVGCUSQm/OmOimh2mtsjTSvlmGKgd73WbFapd70l7BLcgS mMljeKIY8k8gv6sqPFXNKls= Received: (qmail 37906 invoked by alias); 14 Nov 2019 08:40:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 37898 invoked by uid 89); 14 Nov 2019 08:40:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=upgraded, neonfparmv8, neon-fp-armv8 X-HELO: mail-lj1-f175.google.com Received: from mail-lj1-f175.google.com (HELO mail-lj1-f175.google.com) (209.85.208.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Nov 2019 08:40:22 +0000 Received: by mail-lj1-f175.google.com with SMTP id g3so5695931ljl.11 for ; Thu, 14 Nov 2019 00:40:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:from:date:message-id:subject:to; bh=m69AP06egVuZE25TvMNliy/8jzbnttyjQ3eOXPLC/ZA=; b=v48oVSQjwc/5oPAoW43M7ghRIyJAw2rXTrdXOQSTHRK7l3CPBgYVjuO8Wao0r7PUk3 /Sa1xc89191Gl/dLuOamZN/ds/usTD0TJgmWguSASBjWGk8z9+qmXMg7E9lLT26QsVF1 5lZyD6qjQU9zJNrgeR6MQQ1jMcXWfAD7GsE0vJRBwJfsI+riZc/ePDI1U8W8LnmK9/Tf d3c6fHVVVLFmdxmUHhN6PybrWo1akA/3H+ImfQjEfEaXOreidstj42JrIDah8Iy0Ha/y 1CV3MztBWG69QpGCQwjhVN6n71cYfCJV3e/Jbf7afz5oWFT6/7L2J5mpLzfEgvvdim5M 5Bcg== MIME-Version: 1.0 From: Christophe Lyon Date: Thu, 14 Nov 2019 09:40:08 +0100 Message-ID: Subject: [Patch][ARM] backport r266665 to gcc8 To: gcc Patches X-IsSubscribed: yes Hi, Is it OK to backport r266665 to gcc8 (Ensure dotproduct is only enabled on armv8 neon) ? I've noticed unnecessary failure of gcc.target/arm/simd/vdot-compile.c after I upgraded to recent binutils. Thanks, Christophe [ARM] Ensure dotproduct is only enabled on armv8 neon 2019-11-14 Christophe Lyon Backport r266665 from mainline. gcc/ 2018-11-30 Sam Tebbs * config/arm/arm.h (TARGET_DOTPROD): Add TARGET_VFP5 constraint. gcc/testsuite/ 2018-11-30 Sam Tebbs * gcc.target/arm/neon-dotprod-restriction.c: New file. * lib/target-supports.exp (check_effective_target_arm_v8_2a_dotprod_neon_ok_nocache): Include stdint.h. diff --git a/gcc/config/arm/arm.h b/gcc/config/arm/arm.h index b12ae38..febd6b0 100644 --- a/gcc/config/arm/arm.h +++ b/gcc/config/arm/arm.h @@ -211,7 +211,7 @@ extern tree arm_fp16_type_node; #define TARGET_NEON_RDMA (TARGET_NEON && arm_arch8_1) /* Supports the Dot Product AdvSIMD extensions. */ -#define TARGET_DOTPROD (TARGET_NEON \ +#define TARGET_DOTPROD (TARGET_NEON && TARGET_VFP5 \ && bitmap_bit_p (arm_active_target.isa, \ isa_bit_dotprod) \ && arm_arch8_2) diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp index e6b84041..857884d 100644 --- a/gcc/testsuite/lib/target-supports.exp +++ b/gcc/testsuite/lib/target-supports.exp @@ -4510,6 +4510,7 @@ proc check_effective_target_arm_v8_2a_dotprod_neon_ok_nocache { } { foreach flags {"" "-mfloat-abi=softfp -mfpu=neon-fp-armv8" "-mfloat-abi=hard -mfpu=neon-fp-armv8"} { if { [check_no_compiler_messages_nocache \ arm_v8_2a_dotprod_neon_ok object { + #include #if !defined (__ARM_FEATURE_DOTPROD) #error "__ARM_FEATURE_DOTPROD not defined" #endif