From patchwork Wed Sep 25 11:09:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830470 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp686188wrz; Wed, 25 Sep 2024 04:16:37 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV0VUeBhisqXsVyWmtDy0QnIvI4unjkVAA51l1ot5eu6BrscVcYVlE/qrMvI4JrwP7f6OpHrw==@linaro.org X-Google-Smtp-Source: AGHT+IGxbQFIBfMLJ+wiHAySUmvWGJkyqGB1PFjE6DJMbRHekCHebVF5G7BtErY6M9GH1R2kBe3X X-Received: by 2002:a05:620a:4088:b0:7a9:b283:d54b with SMTP id af79cd13be357-7ace745e36dmr365352185a.64.1727262996759; Wed, 25 Sep 2024 04:16:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262996; cv=none; d=google.com; s=arc-20240605; b=Sq0TQd9HvwcQwZxxyVvCvmG3tya1UG3n6xl2O2ODe6QMxY9NUAV9fdNYNGG5/icHEb E/+w2jGpNxMr0sRmINw/mTSIHmp4FK6ezBU/mlqRnu4v8nCBsL2OjOJ2GuUZPnrULIJ5 /+/jY8fzH5dSGpx1k3XxNUu4QDZ0tv12vSjN+QkFzOBxpqYJFBLYqPty01z2rTsNWTVi J8xkbdE62tF2UiqtI5qCteWAE0ZHJiLCsxZtqgg6jVaoLmf1A+RsdXwYprY9cIO8SKKk iLSc3mwit9Lg6Xf5PBMmGkRXgCCkFxSpr5axhsRz+dVU003z+X43/UEu/Q2tVfBSbU2a fcCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=9oZ3IpQaple1Z3PfVmp4WcXsaCdoKnlcVTgkKIqVxrI=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=ecVeI4rFf71mxxhT1RBmqPTvXbLpWkqPO8uadqjN25f1nVKFeb0kPEs31DpqpJxFt+ 7NjR+M4enpvxMPxf2cGRW/sE4L+DQ3aoQ/JjqFbN3LQzV/cgQYe2/nrsvi8I3iHHtBER XW5qb+pFTO7E0jtFIss34ipPmya8mSFwnHZ6nJT4LEPVkjwyqOm9F15HJX5rSc23jvtU uSg/Zl6fstOw5RRJDIakN4O1Fmzm5X6NwqBxb1wMyuLbp761vxdiG3IrixPEf0hjHbwd AsTScufp/7z6VgAu4jjNAL1ewUyoG7q6D+tBNy4z2aGACY50srnNbACL8SPofmyxTJN8 tMEQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dPTpWunP; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acde614719si365037685a.512.2024.09.25.04.16.36 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:16:36 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dPTpWunP; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPvO-0007w8-C3; Wed, 25 Sep 2024 07:11:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvK-0007oR-Vo for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvJ-0003VV-9U for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9oZ3IpQaple1Z3PfVmp4WcXsaCdoKnlcVTgkKIqVxrI=; b=dPTpWunPsi55Fl2rcv+I7ggDHUaxznfiLYmjeuzq4ZK18fAAHVIcwqUsp3z353A+4SW2FV LM0uWwmAMWYl6262+qxAZv/99ayPydHbiVxiuDajyawtHFOGnTtCj/Eqx2Z8Z5ZdbnX66/ 2h7OyLPDbVypp1js6SV2VxgFPVbqRtc= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-393-HUMLglk2OVWckTHsKsOnUg-1; Wed, 25 Sep 2024 07:11:04 -0400 X-MC-Unique: HUMLglk2OVWckTHsKsOnUg-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1DB551956048; Wed, 25 Sep 2024 11:11:03 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 418EF1956094; Wed, 25 Sep 2024 11:11:01 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 09/44] hw/acpi: replace assert(0) with g_assert_not_reached() Date: Wed, 25 Sep 2024 13:09:50 +0200 Message-ID: <20240925111029.24082-10-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-2-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- hw/acpi/aml-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 6d4517cfbe..006c506a37 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -534,7 +534,7 @@ void aml_append(Aml *parent_ctx, Aml *child) case AML_NO_OPCODE: break; default: - assert(0); + g_assert_not_reached(); break; } build_append_array(parent_ctx->buf, buf); From patchwork Wed Sep 25 11:09:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830445 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp684964wrz; Wed, 25 Sep 2024 04:13:53 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUh1M21bKl2j+j3Fq+77Sm6GqrqMYr1FnYbdxjHNQjxwGqFXeJX21B19idRC4GVa6n6b+7LJA==@linaro.org X-Google-Smtp-Source: AGHT+IEV/nBA5cbP+AxPhG6Vzz613BvbVGrDke8d2FUVMRDA86VkBqypOCXlzLmbaFPz2n/hk4vs X-Received: by 2002:a05:620a:1a9e:b0:7a9:b2d6:7fa0 with SMTP id af79cd13be357-7ace7467727mr377214185a.61.1727262833139; Wed, 25 Sep 2024 04:13:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262833; cv=none; d=google.com; s=arc-20240605; b=bjFTb2tqa0FC6hlNuo8GzdIRhCss9qqPwv9+XGOd35kXFiAthC9VedNLzBDceTONsx /Q6QDP5b3ItK2Ubt5rCeyCWOZN+6vz0eKPomr1vSkBdbpoAtCyDju5RDpl+pdW2HXQWL HzrcJxdLvSOSc19BN2xNQOYE0yhgY+w+y7GoXVQrpKJBU3YLT6uDz5neYjEmgV3gKxhR hTWf95qw6WJA6s7oYXc0VSiTnuxx9fDG2ZTF7CtoOuIBgKfTFASNLee4X2HjLlbmr9H+ XXr4wCjtYoUIEeA5EzOFd8i0KYyDacTOlFYZnXtAVsETmVZSaKqh1WGREHajjm0iBq2j KAkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=1zwoIHng/2YrhGhXdl+IAqqFZgtfXPkt04gu1iiKGeE=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=OpH0R/GdVlGr6QRCBa+itWLALpSNSMO+RVv0hDaZvNriKzLatpvcHU6kAoWLBIVfzi 4dlm2l1UB1HCCVe8ZphdKxYw2yDfrodSAGIg2h+bdTmOAs3nBd17mBdIdse7CNF94FrC lbcdbhwff32IfSA3x+ziC6k6H5PbIu4h5oyunzeoV5eAhrA9R27hMANR12ZX8Pk/YaPF pLs/Am+adjjxj8f7yBDzO29akXqer1TsLRRJrhBV4T/raZhkZIS7S96Z4ezJseBD93rd DJlG3W9O3671ZnaP1ASdG8XGFScilgvGr1hntuVNl59i02xVjZs6dxA1Nke5vOGapFAH NvCw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DyvCRUYL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acde62f4c2si374670585a.562.2024.09.25.04.13.52 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:13:53 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DyvCRUYL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPvT-0008KG-FH; Wed, 25 Sep 2024 07:11:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvR-0008Cb-5p for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvO-0003WE-7V for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262673; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1zwoIHng/2YrhGhXdl+IAqqFZgtfXPkt04gu1iiKGeE=; b=DyvCRUYL8v5GJSMPHHV7BO2EYJfpwNvQiG4nZnh6EzMHJC+XEzHtVDA/mdDm3u/X8+wTik fi83ZesRI7m/5tBiujuVSpvcU8v3X8OPOzbyb4KBfxG19DQk+Onv0gUc+ylRc1zZs9GBb6 Y5ZvD8chE5H03Ebfsgvc6r6gMI8ouEE= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-436-Lr_nrNK0NGuLGFc9UiRC9g-1; Wed, 25 Sep 2024 07:11:06 -0400 X-MC-Unique: Lr_nrNK0NGuLGFc9UiRC9g-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A74F1193EF48; Wed, 25 Sep 2024 11:11:05 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8BE161956094; Wed, 25 Sep 2024 11:11:03 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 10/44] hw/arm: replace assert(0) with g_assert_not_reached() Date: Wed, 25 Sep 2024 13:09:51 +0200 Message-ID: <20240925111029.24082-11-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-3-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- hw/arm/highbank.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c index 6915eb63c7..f103921d49 100644 --- a/hw/arm/highbank.c +++ b/hw/arm/highbank.c @@ -199,7 +199,7 @@ static void calxeda_init(MachineState *machine, enum cxmachines machine_id) machine->cpu_type = ARM_CPU_TYPE_NAME("cortex-a15"); break; default: - assert(0); + g_assert_not_reached(); } for (n = 0; n < smp_cpus; n++) { From patchwork Wed Sep 25 11:09:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830472 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp686274wrz; Wed, 25 Sep 2024 04:16:50 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWBPfPtmAwc/FLegtibQxC102doimJk8SYdUHYOdju3ULKYIjwAuNsk2cqCsvPnuFdol8uJ/w==@linaro.org X-Google-Smtp-Source: AGHT+IHsCohAheJT9Q1CDSe9NJGR5IbApkNjC1ybGEPaOk9HNZyI+Ni5GYJKT4aCAM7O0xmN8omh X-Received: by 2002:a05:622a:14e:b0:458:3867:c13c with SMTP id d75a77b69052e-45b5dedf1dcmr39769941cf.19.1727263010216; Wed, 25 Sep 2024 04:16:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727263010; cv=none; d=google.com; s=arc-20240605; b=HFjV/JbqDiDJKKG5g5Kp5I5wHS7PhWGWEhEEvHtDFkOlktY93DZlnxXLM1xs8CR5m2 9QaD2BIo1EQIqF+aKK2Ad8gvEXiMke8ZsDgd4vIWIbNTRHoyi3wVKuzTpXTCuvcJyEbE dwVzTjqa5JAteK+fgs49SA9QouQGynwhSAgu3RYcymN5akb9YBZWd2zmrMEdHsrcF3lT 166R7Hm8KrbqUjvPte69xRmbfKQ0+r+OHji2jlxrzsAQFFoGs7pZL7YUug/Xif6yK/EM Cj9R4/1ljRlG8patMsN5QI3gYlSpbV97ywt9AB0F+kfbstCDDXBFwSRrfcISyRyxpMCh R1CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=9wA9ErZOcHxomx3D/S9htm5cMrsPvqAXtUE6ybaQrZM=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=RMkvB9JgpZpecZ4JcJZwpgvaZlgCiHcjdOEm2/zjN4Yvjt2hdtnhznXZmkDJzZ6fOz 398+tQoV6FJpIqIg9wm0MDCLo4kQlhwPG+yV27jFPK9nbzjkLEhj9MkddcftthATsNUh IfRZRK/d7stPYmQzhgVtqrrVymn8omHdvCvceqRBtvz55yFvjDrxhUqvrvgnpkbPfaf2 ggqrpzEFf3umny1kd5yYBKBcJFUZFkatkzqcKena1W4r2SF9iisM5sg6YS5jY3DxKR18 cBzvBN9iaOLmtvejR2xWNmz2SVtdcEnL/96DmRRKjBx6Dazf6L9cp01D7Kdezw8oBFvW wSXA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QOoyOWuY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45b526f4b0csi34477901cf.543.2024.09.25.04.16.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:16:50 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QOoyOWuY; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPvR-0008CX-7O; Wed, 25 Sep 2024 07:11:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvP-000813-5h for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvN-0003W4-Om for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262673; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9wA9ErZOcHxomx3D/S9htm5cMrsPvqAXtUE6ybaQrZM=; b=QOoyOWuY54k9eD4nLPjiakDqLlhyi1fWFTINeBfdu4vF1FOiEwsx7KCBfv0tDeuXVjfGdB l6psmze6Oe7xu4jvJvB08NCcJWcOP6iQ8gQIHKMx5zv2OIRkk8DjZP85Cur0idT1XAuPM4 O04ppuauyOBcxpyrTyfwE+rxooZLwyM= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-36-wiqXa1snP76_u_53dr6UZA-1; Wed, 25 Sep 2024 07:11:09 -0400 X-MC-Unique: wiqXa1snP76_u_53dr6UZA-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 14BFB193EF48; Wed, 25 Sep 2024 11:11:08 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6516A1956094; Wed, 25 Sep 2024 11:11:05 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 11/44] hw/net: replace assert(0) with g_assert_not_reached() Date: Wed, 25 Sep 2024 13:09:52 +0200 Message-ID: <20240925111029.24082-12-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-4-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- hw/net/i82596.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/i82596.c b/hw/net/i82596.c index 6cc8292a65..cd416a00ff 100644 --- a/hw/net/i82596.c +++ b/hw/net/i82596.c @@ -282,7 +282,7 @@ static void command_loop(I82596State *s) case CmdDump: case CmdDiagnose: printf("FIXME Command %d !!\n", cmd & 7); - assert(0); + g_assert_not_reached(); } /* update status */ From patchwork Wed Sep 25 11:09:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830456 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685318wrz; Wed, 25 Sep 2024 04:14:41 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVsJAm3yK9FlkTykBKmVpg7/DpFVZLCFrNffXesr4s4Ninn+CxMfD5socySL/7d1rDe98CcGQ==@linaro.org X-Google-Smtp-Source: AGHT+IHsH0hGOvlmiXdMK2lQ8kMj+RksWT1d33NTbq0jirrIE0qVkz5Y6i7zrHHOlkXdpwHPl6UB X-Received: by 2002:a05:620a:2946:b0:7ac:9bdd:6e6d with SMTP id af79cd13be357-7ace744d3bdmr404148185a.51.1727262881688; Wed, 25 Sep 2024 04:14:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262881; cv=none; d=google.com; s=arc-20240605; b=C6GtzEgKUTjROp0FsqxMzAqLRzm1kIdNjUHuOlyqPJuM/yfQinZuh3vfyuxVaFloAD /XLFu59/Eol4zAA1nq/5ix+I+Zd6GUR55zuRZ6FkwqXlomJf7xcqX6JU3oQGx4t4GGdb Y7GBuJKYLF2Vgb/uNuuT/3kHIPafxrsucYXgbPAPTRYhuX3lZYkG/5Szioivc5mKnD9n 7+oUsUttV8gY/Ro8gi5gZG88v87eSJOp0zAClKGh0UgH+TC3FSJ8DhKDv0E+h5t1jfVO k6y02po0t/3yNi8+oufX4pCA9K9nD83KRppIk4RXBFZ4Xx50cL5l4dxz4LIr/JUDZOyR goMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hVX5F6Pv9Y4G1nUu8Eh+Z6IKHmSKXDGevjC1ZtuA1IA=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=YGgoZQIUfX1v/BtSlyHwhtfsQiW8p6im5yBPys0gSTPlThOXgM25YrSGCf6PyAVGWD 4V4e/97JPymFNBbdcZ7nmUTcYUJEyaA4VlihSsW2/7Lc3C5R5vmlCbDZd8zwaHU/gC/+ kE34AwkKqUnHMcg/dxV/NkrCfkayCmo42hRebjSFYW4Sc5lK1l667faQvkv4KirWM7nh ZnBVXv4PmQNTxzjLAmv7DFXfsGtNu2NtDDctBiYeOUupcybb+c5MjORNdyq6rJdvgbcm rgIkld+BiCECkFbhfw1dIwGnni3/6BkrgRRt05hfML+SjX8FOvxMvFCILkGsdJ5FzhuV a6iw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EjGXXjss; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acde5fea50si372910685a.404.2024.09.25.04.14.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:14:41 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EjGXXjss; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPvX-0000Fk-DV; Wed, 25 Sep 2024 07:11:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvV-00009u-Te for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvR-0003WZ-5q for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hVX5F6Pv9Y4G1nUu8Eh+Z6IKHmSKXDGevjC1ZtuA1IA=; b=EjGXXjssFeAZ4xom40hI30+DqmwtUvEYufQgAFVuMOwxeq1uCMPLKI74vdjVkF/F2MrZhB wOg7TYPc/nwbc5A1PN+Va8YwKRI+KF6fA8r7eZV7gXMD/lRq8dYtn3w9s5iDUD2PgRTpPD UzlkWLPh0CWDOG/sYy0XfJijZ2FY/es= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-39-dN0GfTfrP5aMjr2fe6dJBQ-1; Wed, 25 Sep 2024 07:11:11 -0400 X-MC-Unique: dN0GfTfrP5aMjr2fe6dJBQ-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 42B801944DE5; Wed, 25 Sep 2024 11:11:10 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7AF881956094; Wed, 25 Sep 2024 11:11:08 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 12/44] migration: replace assert(0) with g_assert_not_reached() Date: Wed, 25 Sep 2024 13:09:53 +0200 Message-ID: <20240925111029.24082-13-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu Signed-off-by: Pierrick Bouvier Reviewed-by: Richard Henderson Message-ID: <20240919044641.386068-5-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- migration/migration-hmp-cmds.c | 2 +- migration/postcopy-ram.c | 14 +++++++------- migration/ram.c | 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c index 28165cfc9e..20d1a6e219 100644 --- a/migration/migration-hmp-cmds.c +++ b/migration/migration-hmp-cmds.c @@ -640,7 +640,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict) visit_type_bool(v, param, &p->direct_io, &err); break; default: - assert(0); + g_assert_not_reached(); } if (err) { diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c index 1c374b7ea1..f431bbc0d4 100644 --- a/migration/postcopy-ram.c +++ b/migration/postcopy-ram.c @@ -1411,40 +1411,40 @@ int postcopy_ram_incoming_init(MigrationIncomingState *mis) int postcopy_ram_incoming_cleanup(MigrationIncomingState *mis) { - assert(0); + g_assert_not_reached(); return -1; } int postcopy_ram_prepare_discard(MigrationIncomingState *mis) { - assert(0); + g_assert_not_reached(); return -1; } int postcopy_request_shared_page(struct PostCopyFD *pcfd, RAMBlock *rb, uint64_t client_addr, uint64_t rb_offset) { - assert(0); + g_assert_not_reached(); return -1; } int postcopy_ram_incoming_setup(MigrationIncomingState *mis) { - assert(0); + g_assert_not_reached(); return -1; } int postcopy_place_page(MigrationIncomingState *mis, void *host, void *from, RAMBlock *rb) { - assert(0); + g_assert_not_reached(); return -1; } int postcopy_place_page_zero(MigrationIncomingState *mis, void *host, RAMBlock *rb) { - assert(0); + g_assert_not_reached(); return -1; } @@ -1452,7 +1452,7 @@ int postcopy_wake_shared(struct PostCopyFD *pcfd, uint64_t client_addr, RAMBlock *rb) { - assert(0); + g_assert_not_reached(); return -1; } #endif diff --git a/migration/ram.c b/migration/ram.c index 67ca3d5d51..0aa5d34743 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1765,19 +1765,19 @@ bool ram_write_tracking_available(void) bool ram_write_tracking_compatible(void) { - assert(0); + g_assert_not_reached(); return false; } int ram_write_tracking_start(void) { - assert(0); + g_assert_not_reached(); return -1; } void ram_write_tracking_stop(void) { - assert(0); + g_assert_not_reached(); } #endif /* defined(__linux__) */ From patchwork Wed Sep 25 11:09:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830451 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685096wrz; Wed, 25 Sep 2024 04:14:08 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXvSgyF5WsVu1cqWSfJ7ssWFVvdGh+4uuf+VBhAthkfEBpIV6sXJLiTmvBq2Xhw21qJbWr5og==@linaro.org X-Google-Smtp-Source: AGHT+IEMN1GnwEPIJtcZnfKue7/x1hFLPv5n4BJRyLhwowZu/vL83f98soKFi1xnk11Q4EqXDTQp X-Received: by 2002:a05:6214:3c9a:b0:6c5:7b99:cab with SMTP id 6a1803df08f44-6cb1dd17659mr34611786d6.8.1727262848135; Wed, 25 Sep 2024 04:14:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262848; cv=none; d=google.com; s=arc-20240605; b=K0TdYmg9y/mjq4Qc0N0F/FSK3UBXGTH/Y4hkAuUJJJbrkLM1JPJJv1pmWe2qJ5UmP+ 9KGIYOmT7ixV1Q8YjwrerlT9/F4FWsLhGimySsRwW7DYWHmKc2EQO7AgXbEWkaxgL0+X vInN6xtFQ3eDBeYTcwNFqm+nVkd41Eh0CFF9ilk4v4K64+C07hh1KRVJSM/QoaUkH2pG X8VBrdQIulgxAglAyu675d3kqgcGMpoXBuvapUE2B0wuNB3W2EWSoa8urrWAjnlhjial I3WxsO3NcRSMBY24f+R2HWfFhGYoJSPJkggz1Bco4vC6AXWnl+iIbvdZnT1LaEeUjUM1 3ZFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7N7BKVbWAiFjTduC3wB4ybIMZXyqbe+MoDRqWm66aDo=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=fUFE/qmRDj4sS0WOWwnmH2Y7lpAPSmPKCOA7+U+3fnNgbdoANCiI0A1clXaDsTLBXJ 2FcF5abzWXeJytHAFfZ7jqAnZ5l0oXAArS9pv3pF8WLh/ZGMcrdPd5jPYF2TVyRJ7LCL UkFFjVW/l8zl0RY9uRbVl6aMZ6upk4ZSV6KpA6BgXtiwKc4HoFR/Dw/IQT8DW1IFvi4X 30pZysr/ldnZ8gszhZjKaZbSM5pUQUxo0KMW3MjF4CoidAmhKxiiCJ9BSCyxN6CcNHoL K6FddIORXjoNqxBJmjT+SbrL9HB64IWWolyKQJlPrUl4TG3stTZ6ZGWcn+h6hOunuFM/ WD0g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aQWwbrU3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6cb0f7751besi36779606d6.233.2024.09.25.04.14.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:14:08 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aQWwbrU3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPvY-0000LH-Ld; Wed, 25 Sep 2024 07:11:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvV-00009s-TX for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvS-0003Wy-Ap for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7N7BKVbWAiFjTduC3wB4ybIMZXyqbe+MoDRqWm66aDo=; b=aQWwbrU3bpbb2wBl/5u8eOX09OVz6yyFEb+f5YvMfKFgIzwEskpa/TmpBfUSWRpHqG1dV/ mPqJK4w6/9J3UBTmU116a8TmujqfCoRWGlLY9XmMu6+/byKx7emuxLcZS9SiM7DxouHSah n+A6vnRl/7PK07nR565xXb8EsSTTDaw= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-462-oUxlCSbcOlSGUtUM5vsKDA-1; Wed, 25 Sep 2024 07:11:14 -0400 X-MC-Unique: oUxlCSbcOlSGUtUM5vsKDA-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 357891944DE8; Wed, 25 Sep 2024 11:11:13 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 416E51956094; Wed, 25 Sep 2024 11:11:10 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 13/44] qobject: replace assert(0) with g_assert_not_reached() Date: Wed, 25 Sep 2024 13:09:54 +0200 Message-ID: <20240925111029.24082-14-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Kevin Wolf Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-6-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- qobject/qlit.c | 2 +- qobject/qnum.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/qobject/qlit.c b/qobject/qlit.c index be8332136c..a62865b642 100644 --- a/qobject/qlit.c +++ b/qobject/qlit.c @@ -118,7 +118,7 @@ QObject *qobject_from_qlit(const QLitObject *qlit) case QTYPE_QBOOL: return QOBJECT(qbool_from_bool(qlit->value.qbool)); default: - assert(0); + g_assert_not_reached(); } return NULL; diff --git a/qobject/qnum.c b/qobject/qnum.c index 2bbeaedc7b..2138b563a9 100644 --- a/qobject/qnum.c +++ b/qobject/qnum.c @@ -85,7 +85,7 @@ bool qnum_get_try_int(const QNum *qn, int64_t *val) return false; } - assert(0); + g_assert_not_reached(); return false; } @@ -123,7 +123,7 @@ bool qnum_get_try_uint(const QNum *qn, uint64_t *val) return false; } - assert(0); + g_assert_not_reached(); return false; } @@ -156,7 +156,7 @@ double qnum_get_double(QNum *qn) return qn->u.dbl; } - assert(0); + g_assert_not_reached(); return 0.0; } @@ -172,7 +172,7 @@ char *qnum_to_string(QNum *qn) return g_strdup_printf("%.17g", qn->u.dbl); } - assert(0); + g_assert_not_reached(); return NULL; } From patchwork Wed Sep 25 11:09:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830463 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp686039wrz; Wed, 25 Sep 2024 04:16:19 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXNig5kky49JngDiYfuSWmNBpdrT1ihDaU7nGK9Jwh3lQes6BLIIyIjIzP0He2bBuSlY8dgDw==@linaro.org X-Google-Smtp-Source: AGHT+IGutrnJl1mFuIab/Whwvysgjv3bLowAgYP2eauvY1udFDhME+UnP4S4o4mckQfD9YPd6uup X-Received: by 2002:a05:620a:f0d:b0:7a9:bb10:e072 with SMTP id af79cd13be357-7ace7401bc2mr333851285a.23.1727262979588; Wed, 25 Sep 2024 04:16:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262979; cv=none; d=google.com; s=arc-20240605; b=dyx8bJ4S/3s7uf2IcUF7vvCsv8kAJahzF6AJp5WtS1WH3TEWVc4Dq0oPU6Sjh+Z0qJ 6b4uC/LRfukG1obIrN/kQxIIQExHwJT3nTShb3JuOCEA7wrlV5aahTDar5/1mpnfmmy6 p6quZIjQR+WzVajfVYqtysu+h4tIG47iJAx54o1cnn7iL9xaJIpzvAg/BypXjoolD6BB iotb9obtQFL0B0toATnUN7YZ2JHP5jc6KNMSKPHOtuCx8/pWAY9O9dz53n41t1od9lLD 9EmPuplODDt7nUhN1Sc5hnXp74RMO6LofFaIFBvGWXpFlYNmuBX0tUHP/E/lLRGHCHZM hrlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=FIaPitvZwBfLvSiAb1b7GqbCUaofsa86VJPizr+59Y4=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=VCb9vrNd+51QYxEB1KTsFQKqRxIE/IiFkSjyT6IgUyTJyDor5Igb6Gwl98WSJ4BWUC DzZLMlplAs4PHsLY39zhCZMrk16XbeeYiSZvubzjEzG0MvNGu6l7HoDrfrjhSQTHSKJg Un6Lve6uVdzf+gXklOtVLspnuZlpyK3Z9YOhp1c95L3EcqLvW49GufW54tamTwKway0E jJFhNIwIsdNGDTZ5R4hOC7/Y4+EUH3Pn3LF5rC257JR8UjAfmxzBiquFaqBLcTX6amf/ XCKsaJ6FzJuGPSVX8aWWEFdbRCprVD57OztA81hh+Mk6uDZNp5nVEvGLmURD8JPAq0o7 gvYQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HjvstFYn; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acde5fec2esi363831185a.393.2024.09.25.04.16.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:16:19 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HjvstFYn; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPvZ-0000Qx-7T; Wed, 25 Sep 2024 07:11:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvY-0000IP-1k for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvW-0003XR-CE for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FIaPitvZwBfLvSiAb1b7GqbCUaofsa86VJPizr+59Y4=; b=HjvstFYnOlL/mafv0kZck0F9TZpUfGpfGzojmX3bbOMFYsUT5r71ZfCWFt25UkKLbfMwac exZ9Zcc2Tfeh0lJGy5i5Cy6Dak7WWoMgYqgV00WVy3h5pJNnb7LAIv5jndOWD7dEWPkZN1 IZjKu+aR59lOz2bffUtZf/nI3pQKNlk= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-w5LFXZmbOUy143G3VC8fTQ-1; Wed, 25 Sep 2024 07:11:16 -0400 X-MC-Unique: w5LFXZmbOUy143G3VC8fTQ-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 58C2619772E3; Wed, 25 Sep 2024 11:11:15 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A9633195609D; Wed, 25 Sep 2024 11:11:13 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 14/44] target/ppc: replace assert(0) with g_assert_not_reached() Date: Wed, 25 Sep 2024 13:09:55 +0200 Message-ID: <20240925111029.24082-15-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Daniel Henrique Barboza Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-7-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- target/ppc/dfp_helper.c | 8 ++++---- target/ppc/mmu_helper.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target/ppc/dfp_helper.c b/target/ppc/dfp_helper.c index 5967ea07a9..ecc3f79326 100644 --- a/target/ppc/dfp_helper.c +++ b/target/ppc/dfp_helper.c @@ -249,7 +249,7 @@ static void dfp_set_FPRF_from_FRT_with_context(struct PPC_DFP *dfp, fprf = 0x05; break; default: - assert(0); /* should never get here */ + g_assert_not_reached(); } dfp->env->fpscr &= ~FP_FPRF; dfp->env->fpscr |= (fprf << FPSCR_FPRF); @@ -1243,7 +1243,7 @@ void helper_##op(CPUPPCState *env, ppc_fprp_t *t, ppc_fprp_t *b) \ } else if (decNumberIsQNaN(&dfp.b)) { \ vt.VsrD(1) = -2; \ } else { \ - assert(0); \ + g_assert_not_reached(); \ } \ set_dfp64(t, &vt); \ } else { \ @@ -1252,7 +1252,7 @@ void helper_##op(CPUPPCState *env, ppc_fprp_t *t, ppc_fprp_t *b) \ } else if ((size) == 128) { \ vt.VsrD(1) = dfp.b.exponent + 6176; \ } else { \ - assert(0); \ + g_assert_not_reached(); \ } \ set_dfp64(t, &vt); \ } \ @@ -1300,7 +1300,7 @@ void helper_##op(CPUPPCState *env, ppc_fprp_t *t, ppc_fprp_t *a, \ raw_inf = 0x1e000; \ bias = 6176; \ } else { \ - assert(0); \ + g_assert_not_reached(); \ } \ \ if (unlikely((exp < 0) || (exp > max_exp))) { \ diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c index b0a0676beb..b167b37e0a 100644 --- a/target/ppc/mmu_helper.c +++ b/target/ppc/mmu_helper.c @@ -316,7 +316,7 @@ void ppc_tlb_invalidate_one(CPUPPCState *env, target_ulong addr) break; default: /* Should never reach here with other MMU models */ - assert(0); + g_assert_not_reached(); } #else ppc_tlb_invalidate_all(env); From patchwork Wed Sep 25 11:09:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830446 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp684990wrz; Wed, 25 Sep 2024 04:13:56 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVfgLIUaQmnAh7QFWl02ObR+I7U563Qel+/BiSzPW3xfz/yyLXGQrNICU6VGRgu+UtMqd6LUg==@linaro.org X-Google-Smtp-Source: AGHT+IExlAX+sxzHoPP8Tf+neDq7zsaxzDfZ6ebloZSITh4tPKJA0YN4TX+Unxp8D6hhSVy2875C X-Received: by 2002:a05:6214:4992:b0:6c3:703b:2320 with SMTP id 6a1803df08f44-6cb1dd16f35mr38875226d6.5.1727262836447; Wed, 25 Sep 2024 04:13:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262836; cv=none; d=google.com; s=arc-20240605; b=DlA/w4CTLIjwgZALmvwaQnrNV1T6pBZfRjACOjhcRsbpHZcn7C9iAiHNjkTjawGwX6 og/sdfCWZWCvdzzWfv6ZkDZOSwUpbHZ2nDptBe/F0Yc+lYONzvKKIBcHMPEZJZ+lQHmJ H8bYXpQukmvDyzWM5sXcwXOqxrHEqnAQTEjaXQ0Sv3AWIXXZP65wgv/kwMj/q+s+PgCH wTfPXdbXRUfGvQWUtUGZzIwsLzCfAGbAsOzClTBQuBW/rEjWOHZpxXrV3BWosxgqN8Ta g8ycqxglVIlkozf/jkHZpbAZJ8J2rynIKFB0xKpSGhzDxFrJGFz9Lsj9DCtk4U9B7Lyn 9kjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Tarhdj67DU5KXiaUURMLAZ+C4j5YJtHiJ/rbkIvQaQY=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=iFdrhGFsfEWSThIeILtLHfn3M7/zTJ9eTi7V+06TCadwux3j6TzXRD9333kKcmIRCW eNkbhUPaLuBT2vSlnrVeWK4qbvIZL9KXthCvq9jup0f1MYOtHsTGbPAWvrR6AbejW9AB eDqFFLXfhG1BKUwTbtIQZZKzEjpTptNaByrueiZG5NTK3iq9nbnbxa1Eg2iEXmS09n91 xNdk2pZYFDEgAKfkzYnogzxtKDqe21HgUF5Sd/uHPCPIAwsx2EteKECnDnh1R5cbxUqM g+t4rYALoSufaZUba3FMh8ab7ijC+kVVHyef75PzKZtJrBAlQMrYRhwIZ5bfMkuzPn/g icwA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GQFUR3nj; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6cb0f773375si36208566d6.229.2024.09.25.04.13.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:13:56 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GQFUR3nj; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPva-0000VS-GV; Wed, 25 Sep 2024 07:11:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvY-0000JM-6V for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvW-0003Xh-Nc for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262682; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tarhdj67DU5KXiaUURMLAZ+C4j5YJtHiJ/rbkIvQaQY=; b=GQFUR3njZLhUCRFSs49LS8r2nXCPgWfroQs3oTrlDttaa+DlMbfRmxqqzfBvEmXBDX3x9n Hro/Hbr+3mgeNgFOkxBzPz/19sVmMzemfPP1fMJIDN2DQKU242ZVIrWDEpVWmbwQVd6iZs f9ZX9Zt3eAZSi9Tu0tf7YoS8yqns5KQ= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-284-__aqHJIyMeuPPeO3AqAB1A-1; Wed, 25 Sep 2024 07:11:19 -0400 X-MC-Unique: __aqHJIyMeuPPeO3AqAB1A-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1C5B41944D01; Wed, 25 Sep 2024 11:11:18 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2788A1956094; Wed, 25 Sep 2024 11:11:15 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 15/44] block: replace assert(false) with g_assert_not_reached() Date: Wed, 25 Sep 2024 13:09:56 +0200 Message-ID: <20240925111029.24082-16-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Kevin Wolf Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-8-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- block/qcow2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/qcow2.c b/block/qcow2.c index dd359d241b..803ca73a2f 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -5299,7 +5299,7 @@ qcow2_get_specific_info(BlockDriverState *bs, Error **errp) } else { /* if this assertion fails, this probably means a new version was * added without having it covered here */ - assert(false); + g_assert_not_reached(); } if (encrypt_info) { From patchwork Wed Sep 25 11:09:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830443 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp684808wrz; Wed, 25 Sep 2024 04:13:26 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUSbPemiEyg5vlvlKmZKxcbyUwsQHwp7sbPHxc8jDe8pPobijLA+913unQtV+YDcHP6cKWRtQ==@linaro.org X-Google-Smtp-Source: AGHT+IFb3KkguUfcrA8fM7JQXj4WBerTfpqY0g85HmSMZX4skM0xz+5D/f3eqq1OvetEc1LMIC06 X-Received: by 2002:a05:622a:58e:b0:458:2aaf:5abb with SMTP id d75a77b69052e-45b5e63bb1cmr33521711cf.0.1727262806653; Wed, 25 Sep 2024 04:13:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262806; cv=none; d=google.com; s=arc-20240605; b=JfsTXvzRqh7+ynOwimRmp51tbCNikpuelqKn2jSMIg3iQB3dgtv0tROCD9qoJIpPPa 8lAI9gBY8AG9uP0xnx0d424d/QEJBCQKdyNBWHWWcRFJlqmHXd9JzXYfzrsy4m51nGKO VTogah2PVPfIDjyKw9enJ70TCTSZILKjaDQEy9ve0U19DyI4ibCVhYo5x5lrSNDyOH5O AvRnwYhZNCUQShZWlyWxSE8wUnfcEvgT7s6eh5L8h08kNiWS7kiCJluPPDyBKohUGh2l QbYkyDXptVFxPA3LxDbc1ODJkStz8PZu4cmREn743SwaaMdjM7qOwutPo3Xly7L1Sibh 8PPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=cSQmsoJI50CYehCgeJcog8+69WQRfLBe7hu3u3O/2uY=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=O+MlZUSZ4NCwMxpnzYN5yCl16nmLYVbkcitfejLkxjMfDR+0g58aZ/K7PV8wPMGZio ml3q90XHZEzu+h4IkoO+KiX4tsCaw6C08AR2RqjpO3ELxlMXoJ5LE3BdkMnXC2iQLMqL 9FyZ1hxkmzCyeiMCLOwJUzXeOAGzGs48D8v6qsB5DakgVe7mu8Q9+ruBZwFrWKmHD2gV PLAJeQSK4S6QYSUdJntE4iYt1gCodWKUOObO4z76XrBT5yCYYtXqS+lDo+dngWzsBYoy fO5+7gsX7qYoRMadQS7IivxxqM4Xgf2Cm9rp4NkQLyaZ4b9IPPyaa0Bj6cSP03+hfsY2 Z7hg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bNZ2NgOb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45b5275605bsi38919161cf.737.2024.09.25.04.13.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:13:26 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bNZ2NgOb; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPvd-0000k4-TX; Wed, 25 Sep 2024 07:11:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPva-0000Yr-Sr for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvZ-0003YS-3z for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262684; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cSQmsoJI50CYehCgeJcog8+69WQRfLBe7hu3u3O/2uY=; b=bNZ2NgObMsf7zoYgbE3gpFw/wFZmVqil6KfU11TeMqZEr8amcy8zy+SsiqnHnoEDMILDV8 iAzvACjc7WJ7Qq25AiukBSSEvmawxV7HVeUw/eTImd2iRqGLU3+IpjsFOwyUEz7sGWxYoQ EOutnT8etdadgVHDm9Du4EfGRDfwMFo= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-530-XszUVQqtOSCRIm5kVenwaQ-1; Wed, 25 Sep 2024 07:11:21 -0400 X-MC-Unique: XszUVQqtOSCRIm5kVenwaQ-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 173E219773DE; Wed, 25 Sep 2024 11:11:20 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A03301956094; Wed, 25 Sep 2024 11:11:18 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 16/44] hw/hyperv: replace assert(false) with g_assert_not_reached() Date: Wed, 25 Sep 2024 13:09:57 +0200 Message-ID: <20240925111029.24082-17-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Maciej S. Szmigiero Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-9-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- hw/hyperv/hyperv_testdev.c | 6 +++--- hw/hyperv/vmbus.c | 12 ++++++------ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/hyperv/hyperv_testdev.c b/hw/hyperv/hyperv_testdev.c index 9a56ddf83f..ef50e490c4 100644 --- a/hw/hyperv/hyperv_testdev.c +++ b/hw/hyperv/hyperv_testdev.c @@ -88,7 +88,7 @@ static TestSintRoute *sint_route_find(HypervTestDev *dev, return sint_route; } } - assert(false); + g_assert_not_reached(); return NULL; } @@ -187,7 +187,7 @@ static void msg_conn_destroy(HypervTestDev *dev, uint8_t conn_id) return; } } - assert(false); + g_assert_not_reached(); } static void evt_conn_handler(EventNotifier *notifier) @@ -237,7 +237,7 @@ static void evt_conn_destroy(HypervTestDev *dev, uint8_t conn_id) return; } } - assert(false); + g_assert_not_reached(); } static uint64_t hv_test_dev_read(void *opaque, hwaddr addr, unsigned size) diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c index 15e0d600c7..03f415bf22 100644 --- a/hw/hyperv/vmbus.c +++ b/hw/hyperv/vmbus.c @@ -1874,7 +1874,7 @@ static void send_create_gpadl(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); } static bool complete_create_gpadl(VMBus *vmbus) @@ -1889,7 +1889,7 @@ static bool complete_create_gpadl(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); return false; } @@ -1931,7 +1931,7 @@ static void send_teardown_gpadl(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); } static bool complete_teardown_gpadl(VMBus *vmbus) @@ -1946,7 +1946,7 @@ static bool complete_teardown_gpadl(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); return false; } @@ -1996,7 +1996,7 @@ static void send_open_channel(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); } static bool complete_open_channel(VMBus *vmbus) @@ -2020,7 +2020,7 @@ static bool complete_open_channel(VMBus *vmbus) } } - assert(false); + g_assert_not_reached(); return false; } From patchwork Wed Sep 25 11:09:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830461 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685507wrz; Wed, 25 Sep 2024 04:15:08 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV0v/fbZAxnu1dmSCpwFxnCngAQjReZRSoa+8kgv4kYQLZsrAj0NOKQjDEMfJH2pe4OFTV0rg==@linaro.org X-Google-Smtp-Source: AGHT+IGKDW+h5mVJDJf5UI6lChK7RuAn+5baadbACMUdhvbBswGVj9rdMgNHSuFrLEWsrQRVlC5l X-Received: by 2002:a05:622a:206:b0:454:e8e6:1474 with SMTP id d75a77b69052e-45b5dedf33bmr31453981cf.17.1727262908461; Wed, 25 Sep 2024 04:15:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262908; cv=none; d=google.com; s=arc-20240605; b=bAm3PTFT49uiebAp1yVj3QsJQ6Sj9NQdlC7Dff8jcRAOikyB319di3QNhPhLX9bxyz 86qMKh9KLJtmQlok8Xmb91FmIB5HQp/+v9qIxpDbfQnTxxHZ+jv+P2LOOxCiVkL7waPF G5ajt7DMydt2d0TG4Jp8tIO91DbKfXa6prtUqWT+cawQXg02bYW0A07Fbg2Rjn3Y9/rq Z5qbtFBhPQ6BaNnCoNzG7D+PtTuW9Dkn1D2kdh7oZS2Cgi7JG6VTl1VVEtXfx9NR55dI 6t0ps6NS1DdYBfWm9cPbc4a5za+R9PykOlaEYQsxCj4JjEwtBn9dhkfFL5GM1jOgcsWj g2ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=IGGPvMcSuORdD/jdCdMnCbXbJ4EG485+NacBfw/i2Xc=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=fe+q+zpa2JgGuyrGEQtGPLTQALr5xCNRjWSInQsjefCkWyz3jSovTh6Y4qkAi7e1Mx AcTCvXyayzTwn7t5hXAcfbVS7AGoG+nWHn1FFDTxxkecl5cRaYua2a2OLxKZ2jSBnP0V W0WeM4JNDSR74Abb09UFP3yJMFgCFKrHHCrH8Ce8I5kV5rCANeahRLCUm0tEKzAQUiRB 69nM1uPMUQIBoWqMODmi3EBLm/PSxQUymobWqQcfbyM9gnA9VWW45kIgyejfLfraUrNv KJviI2J/y+J1grAU0PFj0oKq0Gc8aTwww9CIW73rc9k8Wv6xAErnP5Jyumdk/1DjjcJJ HQJQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="M0LZw/ec"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45b526820c5si38639931cf.265.2024.09.25.04.15.08 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:15:08 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="M0LZw/ec"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPvf-0000qv-RB; Wed, 25 Sep 2024 07:11:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvb-0000Zb-2K for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvZ-0003Yb-EF for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262684; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IGGPvMcSuORdD/jdCdMnCbXbJ4EG485+NacBfw/i2Xc=; b=M0LZw/echS6CU7bR2mls1WwAyTmiJi0BkcziLC+csdBCunFM9XfpIsAqJ2J0/uHFHvcKi5 IO++O1NArhZnvj8CaA/+X4uVWJWZOICIXP1xznrj7mS1hO3P1Ic6Hculfh225jvvSRL1Ee +10ZwCYWCUdKZx9/yBlk0WGqLPiSlTw= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-r6bsu79aN7qwezR8HAdfTg-1; Wed, 25 Sep 2024 07:11:23 -0400 X-MC-Unique: r6bsu79aN7qwezR8HAdfTg-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 71B2A1935873; Wed, 25 Sep 2024 11:11:22 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B0A9E1956094; Wed, 25 Sep 2024 11:11:20 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 17/44] hw/net: replace assert(false) with g_assert_not_reached() Date: Wed, 25 Sep 2024 13:09:58 +0200 Message-ID: <20240925111029.24082-18-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-10-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- hw/net/e1000e_core.c | 2 +- hw/net/igb_core.c | 2 +- hw/net/net_rx_pkt.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index 3ae2a184d5..248381f976 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net/e1000e_core.c @@ -561,7 +561,7 @@ e1000e_rss_calc_hash(E1000ECore *core, type = NetPktRssIpV6Ex; break; default: - assert(false); + g_assert_not_reached(); return 0; } diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index bcd5f6cd9c..6be6140771 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -397,7 +397,7 @@ igb_rss_calc_hash(IGBCore *core, struct NetRxPkt *pkt, E1000E_RSSInfo *info) type = NetPktRssIpV6Udp; break; default: - assert(false); + g_assert_not_reached(); return 0; } diff --git a/hw/net/net_rx_pkt.c b/hw/net/net_rx_pkt.c index 32e5f3f9cf..6b9c4c9559 100644 --- a/hw/net/net_rx_pkt.c +++ b/hw/net/net_rx_pkt.c @@ -375,7 +375,7 @@ net_rx_pkt_calc_rss_hash(struct NetRxPkt *pkt, _net_rx_rss_prepare_udp(&rss_input[0], pkt, &rss_length); break; default: - assert(false); + g_assert_not_reached(); break; } From patchwork Wed Sep 25 11:09:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830448 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685047wrz; Wed, 25 Sep 2024 04:14:04 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCW2x7roAboyEGzZsRbIYAnC8HbHP03s7Q/hoJ2eWwqBg2hFkVq29IuWTIwGqWfJdSYrIyjklg==@linaro.org X-Google-Smtp-Source: AGHT+IEGiWzszCbvi0F0n/jwpsiRCva8NwbEHuSXcX7cW3442IwpLfdO/m0fVoBA9nPu8uT3WwXO X-Received: by 2002:a05:622a:4e95:b0:458:3215:960c with SMTP id d75a77b69052e-45b5def17efmr39452411cf.29.1727262843807; Wed, 25 Sep 2024 04:14:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262843; cv=none; d=google.com; s=arc-20240605; b=aQUq5YQowcIZgAL5/gyHxhPi2SPIlNOIUVP1a+xVAG3WZta+dRuBPqdpvwYMy5bQ6j MWgicGMdPFI3aAANpD1Y2MsEoSRbW9fTI8LK9Jqx0Yy/64QhLHMJjZZ6ktXIK60Ayhnw wk/e3IA6P0COSmqKr7Me2j0EDB1dVQOLt4EIgUc8mrMwtc/ur/YuAIGPD54BpZ6VMfVR gVchmH046ZR49OPgail6itolDd/IwEdGYyvcxirrlDFUQB7QQF5Z1UvJautOxEgveXvM MIfvb4103z1CF3l6mDIioSho2voBZoTjFbTRqppOYxQ1/PEqIUb/6fZmONE7G8k7Lpqw zGtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wq1B9h69gckEeGkVnGQTX9HCgcmht5vBk2iFpBgg+Fg=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=fez4EtV6bJ9gBnSAzwmUM2pMDgdRcFCiUJuhzX5KkRmba53JNI7rM7V2P5I4EhBT5a qfAl2bCEHktjP4c0/Kji+xmNv76JFVfP2Q2aJQ5gN7HnERrT7OY059SlDTZ1vkRehlcD PwPKyQuU4mjxGQEKX1a/RvF+AxPvxxHRwzP5Wfas4CUVNj1k4jrfOhoKSL6FDIFj/43Q n/J6E5F27jON+IqrVG94imM3x8UzQTzgI5dXiIljvajtImRdmK2r7q7VV/88hX+XRmEa NiLUzxcOtZMczQ9sAQ4iNY9+DJ/CHXfPbFgN8UQ2vOCfzzB1BMbvYWpLxysZji5atBsb 00vg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Gm+LhP+B; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45b526ec3fdsi35466211cf.468.2024.09.25.04.14.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:14:03 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Gm+LhP+B; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPvi-0001JK-KM; Wed, 25 Sep 2024 07:11:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPve-0000tB-U9 for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvd-0003a5-FA for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wq1B9h69gckEeGkVnGQTX9HCgcmht5vBk2iFpBgg+Fg=; b=Gm+LhP+BrzMXZGJic9b0TdJUvSGGaRRQVroUsVLXmoN9oSw0+8rIM5C9YFcsrVYTEEQQOo 3KOG4W7WPRh9fXu2LUB2Kduxk+CXUemoAr1I0YkbsFO7Ww89sA4x5Lk/+G5OuI98ZES8FC Vnxme3llHKZSwg67EYJE0BIekrKouq4= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-681-jkNVEQgxOe6omEpeXrrEqQ-1; Wed, 25 Sep 2024 07:11:25 -0400 X-MC-Unique: jkNVEQgxOe6omEpeXrrEqQ-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8981C196E0A4; Wed, 25 Sep 2024 11:11:24 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0347F1956094; Wed, 25 Sep 2024 11:11:22 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 18/44] hw/nvme: replace assert(false) with g_assert_not_reached() Date: Wed, 25 Sep 2024 13:09:59 +0200 Message-ID: <20240925111029.24082-19-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Klaus Jensen Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-11-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- hw/nvme/ctrl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 9e94a24054..2589e1968e 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -1816,7 +1816,7 @@ static uint16_t nvme_check_zone_state_for_write(NvmeZone *zone) trace_pci_nvme_err_zone_is_read_only(zslba); return NVME_ZONE_READ_ONLY; default: - assert(false); + g_assert_not_reached(); } return NVME_INTERNAL_DEV_ERROR; @@ -1870,7 +1870,7 @@ static uint16_t nvme_check_zone_state_for_read(NvmeZone *zone) trace_pci_nvme_err_zone_is_offline(zone->d.zslba); return NVME_ZONE_OFFLINE; default: - assert(false); + g_assert_not_reached(); } return NVME_INTERNAL_DEV_ERROR; @@ -4654,7 +4654,7 @@ static uint16_t nvme_io_cmd(NvmeCtrl *n, NvmeRequest *req) case NVME_CMD_IO_MGMT_SEND: return nvme_io_mgmt_send(n, req); default: - assert(false); + g_assert_not_reached(); } return NVME_INVALID_OPCODE | NVME_DNR; @@ -7205,7 +7205,7 @@ static uint16_t nvme_admin_cmd(NvmeCtrl *n, NvmeRequest *req) case NVME_ADM_CMD_DIRECTIVE_RECV: return nvme_directive_receive(n, req); default: - assert(false); + g_assert_not_reached(); } return NVME_INVALID_OPCODE | NVME_DNR; From patchwork Wed Sep 25 11:10:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830449 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685089wrz; Wed, 25 Sep 2024 04:14:07 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV/K0+zmBByZrtFcRNLAfT/Xdy1TA576Ouk4x/H552Weq3pZGVPXBb4g4HB4dRpfg1Saoydng==@linaro.org X-Google-Smtp-Source: AGHT+IHOum/V7vGBy9qCQjy7P0JJQ3wz5yqWiDXl4ysj23uQ+qZQeRI0al81ZtQQaIYlcyiQpNCm X-Received: by 2002:a05:620a:1926:b0:7ac:a10e:4e5d with SMTP id af79cd13be357-7ace7157d89mr428129285a.0.1727262847620; Wed, 25 Sep 2024 04:14:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262847; cv=none; d=google.com; s=arc-20240605; b=NYupULxvv+82yEpJvkhkQjBvRlZKZDl+VhzX1/fzDlz73y8EmW1xCeMGJ14F1RDj1B O2atDLsSsgd0uAXmFE+OE2M56llWkykCRr+lmYuWhFju10T7yRr68yhkWwRQOQkkCkYB CCy7e7bIj/OZ/hXAN7KIvwJcDsraYHNfH/w/eduwf+YipM7QO3yyo3ISmLVuGgentOPs km6JbWaApRCQqoa84y+MI3R3eGQS2G5Db6g84DGSphyOepYDpCsQY7GI6a+uEY34zAqt 1+J1l52+q5eLdDRlyDzAGdvBXVEBREgcwAYnNswfR7VyMTUnPWXd0p/HthHHzVltFLjX RZZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Od7z/DXKTWdjJQuh6kkHYLvKEg3qnz6S+3xr8klpiPU=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=K4RHtlFECVfRvXFVJ1aZH7ebeoaElhw59GeP2Y/nRtkPjCigoeZt0DHYEjih0OZkXS rxVq0+XaCdHqNirtCX1Q8HCKlnlJW1PRYgKHuDaIVXJMNPpoL7W4hK3k+Bgirp0XdtFR N9SCQSfy+4b/tM4N0aFoBnMn6nxcdpqkF+3Ayn+Obh2/wNuYUeSRP/WaEv4VVPjEY/wH FTRoi4K8GLQgOVzKHJWFyFxjkdtfZuHC2jEAvASYm/gaFwJp9401hO4W2sZmOjrXc1CJ S0mYSqfNMQ5gNRdbNQCyF4+XcBOTNnXhpuZdTA/vaLVxKsDlaRFD3DASTpMn/+sWG3eM X7Gg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WYWdM8n7; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acde60b93csi363974885a.460.2024.09.25.04.14.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:14:07 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WYWdM8n7; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPvm-0001iO-9E; Wed, 25 Sep 2024 07:11:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvh-0001GQ-KW for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvf-0003aW-RR for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Od7z/DXKTWdjJQuh6kkHYLvKEg3qnz6S+3xr8klpiPU=; b=WYWdM8n7q3zLsGYkcHrOQKtYMjY5N6WCetPkethe9BMegv9Boqjrh4DREZnZ4XxtnzteYL /373s8glbTD0JscECd3GvPp464yRMyu/364C9EdPv9bw8GI94ZavSMxATHYgg6L6ZJ2kh4 Tn4v7HC4tPDexB7ReO6NKM3UNH/S88Q= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-253-jL5lj4kiPhOS-0bOH7vZRQ-1; Wed, 25 Sep 2024 07:11:27 -0400 X-MC-Unique: jL5lj4kiPhOS-0bOH7vZRQ-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E6E0E1944D69; Wed, 25 Sep 2024 11:11:26 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4F5011956094; Wed, 25 Sep 2024 11:11:24 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 19/44] hw/pci: replace assert(false) with g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:00 +0200 Message-ID: <20240925111029.24082-20-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-12-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- hw/pci/pci-stub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci/pci-stub.c b/hw/pci/pci-stub.c index f0508682d2..c6950e21bd 100644 --- a/hw/pci/pci-stub.c +++ b/hw/pci/pci-stub.c @@ -46,13 +46,13 @@ void hmp_pcie_aer_inject_error(Monitor *mon, const QDict *qdict) /* kvm-all wants this */ MSIMessage pci_get_msi_message(PCIDevice *dev, int vector) { - g_assert(false); + g_assert_not_reached(); return (MSIMessage){}; } uint16_t pci_requester_id(PCIDevice *dev) { - g_assert(false); + g_assert_not_reached(); return 0; } From patchwork Wed Sep 25 11:10:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830465 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp686060wrz; Wed, 25 Sep 2024 04:16:21 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWZtThQr4zM6ptjmoxRzE2vhear32HUmuA03KYYTUx0C9V8TkAQ8VBTlpUSR6crC2qKqI4sXQ==@linaro.org X-Google-Smtp-Source: AGHT+IH0wXti4C+yzGe6ujRn4Lsfg+AQ/ollrjc/YlvDUsRAcU9IHAvU40O2IuOjmBhdlN8vVczW X-Received: by 2002:a05:620a:4544:b0:7a9:a6a7:dc2e with SMTP id af79cd13be357-7ace7401bb4mr482275785a.26.1727262981033; Wed, 25 Sep 2024 04:16:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262981; cv=none; d=google.com; s=arc-20240605; b=Q+HvovU7rUclYJcGfdOQm8NNb6uSku+K4VZ+LyPYx/Y65o1BJieRiPsMCPpMqa2iU5 ynigNE6OCrEzNLE0EE92KPKa9tXD07uzFGscSjHRBm/KzuVKHPdYXZjV0WRdUXH0FKO8 4+K15oaBwy5/YhD2ztivf5GeVMajuJbnHpxLP/r48OhRkBXlzeg3S9OffJy991YofnKQ wv63amhYMTLgsr2B9Oi6qoZi7qt4y8snIczXvii8SRYmyGDI5OPS8Uf0TIq2tP+gpqvG h6whY8cAl065okv7FSkCpowwtBtMTNZs7B4IFhKludsS/jlHvBtdqYOoV68K28fXqFKt ke1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=P3IhRmhquo3F0qLBHo1vJbRPHSzR8dkJy4GE+Sv3yws=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=jEFwfmVZKSwNtyZQ74gyurdt1LQWqNhOBB3VKK9uLLVfQG1LggUqLYFxEu/vVtR39y cOh1501XtaBdHq8J1lauiZ+BHdmg9j2OYWGh+E0Q+39eBFg/oBB25kqXr0XJhFmB0Woh R32bYbIYzXTsJ6Bjv8CZp2n98208i6f9f4MHsSmw62yybK9OtOzWed+SrvX6i7OUNfy5 oILdJwGt2u4qQ5pSrWUwSgS2LXMAiBMX4X/PaiJTFw7knSNB3btI1w5SXrsebABGEVk7 TpWYJZlgihvJO34jKkhRWE254JCqteEfNmRAcdJbKycETRkoXcam5LAvxqmnPHptT0vM HhxA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Pu6UzU6b; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acde528ec8si374963485a.18.2024.09.25.04.16.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:16:21 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Pu6UzU6b; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPvo-0001tE-3M; Wed, 25 Sep 2024 07:11:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvk-0001Zv-9g for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvi-0003aj-SA for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262693; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P3IhRmhquo3F0qLBHo1vJbRPHSzR8dkJy4GE+Sv3yws=; b=Pu6UzU6buLRi+S7B7xfIF1afO8N5RoIMH5ynutmjzVXKW7JIbYTaTceyMlIPfoSlZmUpp3 JW0/+9b0v7WsMHKX0bKTcAUwE62OMkIkSZchqjsVt4N0ls4fQtYqGVQs4MeNqmuXDCJehS KTmbN39tzklSI9g8MX1YJ0aT2KoUAKE= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-C_hfMQZ_Mr-6oKAiXOsM6w-1; Wed, 25 Sep 2024 07:11:30 -0400 X-MC-Unique: C_hfMQZ_Mr-6oKAiXOsM6w-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 613781956064; Wed, 25 Sep 2024 11:11:29 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 726F41956094; Wed, 25 Sep 2024 11:11:27 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 20/44] hw/ppc: replace assert(false) with g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:01 +0200 Message-ID: <20240925111029.24082-21-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Daniel Henrique Barboza Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-13-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- hw/ppc/spapr_events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c index cb0eeee587..38ac1cb786 100644 --- a/hw/ppc/spapr_events.c +++ b/hw/ppc/spapr_events.c @@ -645,7 +645,7 @@ static void spapr_hotplug_req_event(uint8_t hp_id, uint8_t hp_action, /* we shouldn't be signaling hotplug events for resources * that don't support them */ - g_assert(false); + g_assert_not_reached(); return; } From patchwork Wed Sep 25 11:10:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830438 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp684213wrz; Wed, 25 Sep 2024 04:12:04 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVOiql0x0CkvV4NipAxjYzsPHZAz6/GAeC2v2oT4hJAs1RQvY5FvRXtbo9j8UwFbfbwwsuk9w==@linaro.org X-Google-Smtp-Source: AGHT+IFVERWtZsqpyAXoH4O03KD9yqUC+XVx8WIHooWH5iKq10uehGIYTcxBktmy6NqCgOKi1q/T X-Received: by 2002:a05:620a:290e:b0:7ac:a0e6:70c with SMTP id af79cd13be357-7ace7461e2emr323657185a.60.1727262723740; Wed, 25 Sep 2024 04:12:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262723; cv=none; d=google.com; s=arc-20240605; b=ENYEUDjzwU/wKx2J8Jrv4foJlL64/jWVytpenwfoSxhd0KOZHVFuLGR7PTvK62I7TO PhOQnYp92aD5o+NclfAKCYkBwbuvv7ju3W4D/4J4OpOgkQd9LpYrQeD7uVTHlYdpDIVO XX38DdeUQMqFKAvS3PEHSCTPkVP4Izry25V5/Cwi3E45SqonPcNDGPx4XJI24QonQ44V GKq4reCxuNbC3fSDJgYUbGC9b2AOgdPpxCvOrkNLJj1s5JSNwxdYKf1csrfoNia1p8Po KiKNfJcxLiK3CBl96iThhn2LH7333CoaxDpuerHGkWvHVM5gu16/YPgVHD1fj9JZuW6j P++Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=cAeg+Ie663IEIZWiQO7e2V0IGemFx0hvCtiNmWMksEg=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=Z17KpaoS0F82Njb8yF1jOmzDes5z+exUBZ9NARKqDvowT7m3U9XSNRO4hARnl4V44Q Q4QSFO9CxXL1eeIOJf2KjsDYFLp1pTZcOqidzFtBK0HaxCir8b2oyinVIqoIn1gMydVY S57Fo78Ltk3mZM/9rIpqP1CiU4TNsAfhgtjAT7N9b8AaHlpYoTc2cFmdBRfJpOxHdDng TFKNH5G4dfR4te6hWmkCve2fbZ4nKs2GxOyc8+CbhgywvYI0qRToaX+jy7UGoMzvylN0 yHiUj4rxiqtnb6wiqtarFo/8FRxCkNgXA4v2L+cYO9znD6aHN4mpSQt04sHPQxsWlmnl 363g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=djdQEcQX; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acde5cdca2si367353485a.266.2024.09.25.04.12.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:12:03 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=djdQEcQX; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPvr-0002BK-Tm; Wed, 25 Sep 2024 07:11:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvm-0001m2-P0 for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvl-0003b8-9y for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cAeg+Ie663IEIZWiQO7e2V0IGemFx0hvCtiNmWMksEg=; b=djdQEcQXcOCBBiXjpHfl30ds//7iXZbhwQ4+9Uz8FJaVb3dwVpF/VqNDZXYrCUSxD1TOQ1 TcSHwIfkNt4WBonsDrWdGpWjvhHC6i55I3vNw4DyKKGrRhrVC7tgXnIcJl1GuQYAWxvyQU 7gzqbNYahUiPc5jFuepI1m+7et76SZg= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-44-Wj6-SXTePXSxtUlXXGQk5Q-1; Wed, 25 Sep 2024 07:11:32 -0400 X-MC-Unique: Wj6-SXTePXSxtUlXXGQk5Q-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9192D1944DF9; Wed, 25 Sep 2024 11:11:31 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E50731956096; Wed, 25 Sep 2024 11:11:29 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 21/44] migration: replace assert(false) with g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:02 +0200 Message-ID: <20240925111029.24082-22-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Fabiano Rosas Reviewed-by: Richard Henderson Reviewed-by: Peter Xu Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-14-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- migration/dirtyrate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index 1d9db81299..c03b13b624 100644 --- a/migration/dirtyrate.c +++ b/migration/dirtyrate.c @@ -228,7 +228,7 @@ static int time_unit_to_power(TimeUnit time_unit) case TIME_UNIT_MILLISECOND: return -3; default: - assert(false); /* unreachable */ + g_assert_not_reached(); return 0; } } From patchwork Wed Sep 25 11:10:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830471 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp686229wrz; Wed, 25 Sep 2024 04:16:42 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXrwqUHmCTuUcwqNr9DD7sBWhTuyviqVoZa+W+dnUcVcGMnswlmIgJaZt4+wHrcRGBkW9Ff3A==@linaro.org X-Google-Smtp-Source: AGHT+IFA7VAhqW8VxSAONodxc/ZPACXM22NV87jJpE/Tc0v6YQpU+R9UEss+x999SUnSmMLUyvGz X-Received: by 2002:a05:620a:2489:b0:7ac:b220:309a with SMTP id af79cd13be357-7ace73ffaabmr334061885a.15.1727263002701; Wed, 25 Sep 2024 04:16:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727263002; cv=none; d=google.com; s=arc-20240605; b=B0nQcq8XrGyhQEwyR7iOIal5wJUjrCbtShKcgBIL2c0GCOEEWxIqRGG65ONPqJnpim lMqvt+ufmImOMPZ9PLDJ/xKBvSiIxKgA646P8CZfCwtPnGBNbzTuSz5M3ogXqQTN6Ja1 SAkEN0I/aS2t0HJNTqvUH2V5nQPvZLjXXIVeFks2UDdoiGg6CCd+Lr7uxG0GBYP1DD/3 PjZ9kmTTF2U7RRbzz7CCVu4NVzM3M099FNFyjRBu41EmMvbH1j45IqbZjXxOw6IhixX+ GviaCEnlKEmeP2OapY7+oLDPGuhF3lKuO/fY2CBg0J7ue0t5xxBaM012/SkL8NY4FfMf T6kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/kR37MkxPuif1Gz9ZYXpS2krMiMxAaq8SdO6bqCWHmA=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=aTf8BfX39x36kRxTagtWCJLslMpvmvJMZYSKTQgHu/H/kJ1ud4tRfooF+ow5OFvgR3 8PdbdCeJVhr7FOBOTLQzC6xW72vvPrPcLi0pE7+PkRpiqZYDQoVCoBcuNzOPdhkGvDAz RHCCZpKc3y3lidn21wYhT+CGbpWh9DQjTl1cW4z1gSlhZwobMknvSEfkHOkI8//kIP/K 39dtMe0khH1gDif3v39O17gO9osHu4gQCH7FWlY38davbeuiiibgLfznnzh4OxAqLSd5 Q3b2s8aiTkMpNbA0ZJ1kxIf/PmDSUbbJAiXfHvyWXbKS5CFsCpmRunUsNNiCgFmiybNK ZolA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HZdYeQMq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acde62f543si384908685a.566.2024.09.25.04.16.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:16:42 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HZdYeQMq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from [::1] (helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPvu-0002lN-Se; Wed, 25 Sep 2024 07:11:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvp-00024W-RF for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvn-0003bT-R0 for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/kR37MkxPuif1Gz9ZYXpS2krMiMxAaq8SdO6bqCWHmA=; b=HZdYeQMqIy18nPMXt4nZlJlzj2f/EDb0YNAMn8wDM15Y+xP2xUEBe7VnW17A1bA6zO/Vyw m6ve+eObK4g50n5I3qqQ/HLdbb8KT8QLdlfxd+ZGikBMTeyhErsAyLe59rTeJympfb2WY/ UP+rfbfD9yvhz4AH0UauJjKXhcxWJcc= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-459-pzWi-xUaNNCN93WTMHlTzw-1; Wed, 25 Sep 2024 07:11:35 -0400 X-MC-Unique: pzWi-xUaNNCN93WTMHlTzw-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CB2F21944DE8; Wed, 25 Sep 2024 11:11:33 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 222661956094; Wed, 25 Sep 2024 11:11:31 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 22/44] target/i386/kvm: replace assert(false) with g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:03 +0200 Message-ID: <20240925111029.24082-23-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Reviewed-by: Thomas Huth Message-ID: <20240919044641.386068-15-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- target/i386/kvm/kvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index ada581c5d6..c8056ef83d 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -5771,7 +5771,7 @@ static int kvm_handle_rdmsr(X86CPU *cpu, struct kvm_run *run) } } - assert(false); + g_assert_not_reached(); } static int kvm_handle_wrmsr(X86CPU *cpu, struct kvm_run *run) @@ -5790,7 +5790,7 @@ static int kvm_handle_wrmsr(X86CPU *cpu, struct kvm_run *run) } } - assert(false); + g_assert_not_reached(); } static bool has_sgx_provisioning; From patchwork Wed Sep 25 11:10:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830440 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp684427wrz; Wed, 25 Sep 2024 04:12:31 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWjGi7XQF9lB82KTGUF+TD71OksRe8dTidj2N4z9vrJRyp1ZPkyZ7uYPHBY5SsldlQgFBR2rw==@linaro.org X-Google-Smtp-Source: AGHT+IFWZKL3kKyCtMP0/gqDaPvCd7ol3v5hyyp1GyB6RfCtHnibetOmMdmITPm1W5iwm2nwNOXZ X-Received: by 2002:a05:622a:47c3:b0:45b:6042:be44 with SMTP id d75a77b69052e-45b6042bff3mr23156151cf.42.1727262751448; Wed, 25 Sep 2024 04:12:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262751; cv=none; d=google.com; s=arc-20240605; b=e5LXKlodgp1eDVJ5evDgly+/kmcj9H000FTN8bLenwxopj4KF4WiZ7eqal3RoB+iMH 9XRwfcgb5z2zqB9atXgYxxl1MMt08yxilgGqTiUC9IhjwHFnnU3MCrOIug0YsrE46LPe 8rA0eyahtMiUKiUuSL8jkA4jpcARGqG919K5WqbnFZ1MdtnT1UpSeknA8/J5dm2GuEOs CcaQ9TfLXGMPKd5MHlXI0z9jMJtD5d/+9pOjkCeSk3e+HhgexPtJiFWCEJifg3w4dR/N +3scsX/9Ui/DrxxAQOsRfVw1UyHxCx0bwfnFb1eIRKVFr6AkoqfgE/kCowHQ2flR6Wcp OBCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3jDoCFaq6ptf4xbGNRtIyIgr5N+u+K+f5r+zr4TCbOU=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=QwEtUrsllOTrfdlVgVE3NeCp5JshAL283f9a4YEcyZB5tcgfieL/s7/+EFa4IZiDFr wPlNKEh1Zl8Qyp1bzzbpSHc8OVOnKaTwN/bpcklpKSPi6c2Nf2gd+z5P9zw3GhAlurX+ +BHeIf4SN3VJcmAAA7FQHqRg6iFiYBo7hSQK6MnsrjRTsp21XyjB34XQQcecUoyCaeUA i37eE5BsmDsqVVwKYCaqkVAo7aXg3P8IE2W1DGxhmkKbVwtc8WLiDjRxf4tK/HcXVfxQ D0bEof1C+4Zi1koeZ8pd2WrEQPqOlXTpYOdHd6tN2YdYl9T8kPMCOmZ4wCmncnOFfFMH fZRA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GcFM7sQL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45b52684a08si36027141cf.338.2024.09.25.04.12.31 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:12:31 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GcFM7sQL; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPw1-00037H-Jg; Wed, 25 Sep 2024 07:11:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvq-00028F-Do for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvo-0003bY-7k for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3jDoCFaq6ptf4xbGNRtIyIgr5N+u+K+f5r+zr4TCbOU=; b=GcFM7sQLrsNffY7wrFo4zaz/4Aw+Y0r6T/YSIzc3321Rd5dl3vHVl233CXXsTsIuq+elqm 4928KAdutnwqAZplLhYT7O5+DA/msqe/4gS8HySspwdZNwH0yszUR78uXvTiWjmodqrpDS wkBYqHMK7GTpMRHvXLnLekwa6gDXXEY= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-486-JtXRXY7kODOHfbu2bkXKwQ-1; Wed, 25 Sep 2024 07:11:38 -0400 X-MC-Unique: JtXRXY7kODOHfbu2bkXKwQ-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5E61419344E9; Wed, 25 Sep 2024 11:11:37 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B90B31956094; Wed, 25 Sep 2024 11:11:34 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 23/44] accel/tcg: remove break after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:04 +0200 Message-ID: <20240925111029.24082-24-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-16-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- accel/tcg/plugin-gen.c | 1 - 1 file changed, 1 deletion(-) diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c index ec89a085b4..2ee4c22bef 100644 --- a/accel/tcg/plugin-gen.c +++ b/accel/tcg/plugin-gen.c @@ -251,7 +251,6 @@ static void inject_mem_cb(struct qemu_plugin_dyn_cb *cb, break; default: g_assert_not_reached(); - break; } } From patchwork Wed Sep 25 11:10:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830450 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685091wrz; Wed, 25 Sep 2024 04:14:08 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXu8IUK4ed5BSe+vlh40vQn1nr65KqDCgwbX7WiVvbjaFqTyy4IvY1xCQ/eKb+bTwEtic3qGA==@linaro.org X-Google-Smtp-Source: AGHT+IF8/WbAKo9JJ326BMfhCJiBJYrL+jGkQDrXldT0Ziz0DN0PjxY0aDNWjli9ki815m3v0gLw X-Received: by 2002:ac8:7d8e:0:b0:458:532c:1e66 with SMTP id d75a77b69052e-45b5def47acmr31949251cf.33.1727262847736; Wed, 25 Sep 2024 04:14:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262847; cv=none; d=google.com; s=arc-20240605; b=M1BM9Y9YimPiy8ELgfTRupaU3hGf3IO+53pDgFWCvoced2Bs8mwPjvPD+YJIpLqRCZ liknoaZaupJG/dfFqm/2v27IyUix9nUtQTX+CbWbRg9BXRhrQcJBJK047ddi56cVkEsu LfaXYAntcFZspS8n/6jCk2+XfVI7FGQUNkXcFzRLlB7xh1jZaVV1gLhYI5ko295nOJaI YUIpRQ14wep7yMbeO0b1EzYgCyJnhLKeeH7Y0ChPZjRWVGdMR1ol84t9eySJWFCnOik2 a7AvtcSJFhNRkVOTRoBq2exa1cuR5iS0HeKjGErf2eUnMqlJbnG1jxrr13Gf8l8HCckV J8Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=psomKvE7sW8bRpqmZzwDOu56NbGS0iusAAvNKLEfVT4=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=K4mfYugBaULlsjaF8wRWoaHUr4j1dlhVD46B5fnAYFhBBUHB/V9ICw+Q6y5HwlbGF5 Ek4//dJML3WRWLuQTChw9iYq0k7VhaboxoAgzS3XnHVaRKh2f/YxA6u4yyPDHatdLrDw hmrASh2pjzmNBnRv7qzCfrnMVh5zW4xs/aCSIdp51fbbAq6nYpe5JUl9TKqZGbiqqstt RQUKz8LN7MHMhI/zO6UipV+K3V4ts7fuxVWjCZyy5NPefPQydyGgNSyPD71Do3r3b9n0 bH8goEhE0ITfQ9s4V9o3jo27YeXM2J0GXRxavAG5kQG7gGh/O5ShF5XKgG1ljxIx6b2M dvgQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OJSKJ4Iz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45b52570cddsi35752051cf.31.2024.09.25.04.14.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:14:07 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OJSKJ4Iz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPw5-0003mO-91; Wed, 25 Sep 2024 07:11:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvw-00031n-3h for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvu-0003jg-GK for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262704; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=psomKvE7sW8bRpqmZzwDOu56NbGS0iusAAvNKLEfVT4=; b=OJSKJ4IzMWMUFIFKgVYP7a4Ns6Pxq03Ti7RvfLQxx1CblYHVZaBHV7MmZhc0BHf1WXH1dY jbfy1hHPS+an3Fl97K0Fcu4lK0z9ejIJ116uFxYn8nrzMH8iB/VkczbOFvi3plqOBbyYOz 9OGz7uNyXexgAGCGg8intIqznUSKKjo= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-220-PQkBNgS_OHiZrSxqmfz8-g-1; Wed, 25 Sep 2024 07:11:40 -0400 X-MC-Unique: PQkBNgS_OHiZrSxqmfz8-g-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A76561944D25; Wed, 25 Sep 2024 11:11:39 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 19BDA1956094; Wed, 25 Sep 2024 11:11:37 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 24/44] block: remove break after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:05 +0200 Message-ID: <20240925111029.24082-25-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Richard W.M. Jones Reviewed-by: Kevin Wolf Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-17-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- block/ssh.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/ssh.c b/block/ssh.c index 27d582e0e3..871e1d4753 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -474,7 +474,6 @@ static int check_host_key(BDRVSSHState *s, SshHostKeyCheck *hkc, Error **errp) errp); } g_assert_not_reached(); - break; case SSH_HOST_KEY_CHECK_MODE_KNOWN_HOSTS: return check_host_key_knownhosts(s, errp); default: From patchwork Wed Sep 25 11:10:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830441 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp684496wrz; Wed, 25 Sep 2024 04:12:40 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWnRzBi7Bl6tQb4f1y6077d8j9p3tXP3fEANmJ6kxWv2ZN9FfZTAthGe5LAxWOSTKMDSAUjzw==@linaro.org X-Google-Smtp-Source: AGHT+IG8rwCPXh4pNpJhgq5LQFAKFJ48BdOcJulLT6gEYrBsux7KQCzUlKq2CoooSKbTPH7SVCuF X-Received: by 2002:a05:620a:2990:b0:7a9:d0ec:2d8f with SMTP id af79cd13be357-7ace73ffe1bmr297464285a.24.1727262760499; Wed, 25 Sep 2024 04:12:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262760; cv=none; d=google.com; s=arc-20240605; b=B9NJ+7WU9pgNVkpbO9D6pJ23VTpw5ZUol5eX0IYU3HKOiuABusHcb9anJYW5uHsN0J 56YSNlXCyuQbHUJbMuGxOCVOv5AntjSyDQtOp+ljSuSwLG907HYi6Q8TRhLPBg2BlKTP CIgKLIV8R2F6d+d5mWVhVcxYg+n6+9dXc7EPrR/L/SYkbqqdr/LRDvAyNZ0PJwQ1VT3B oH/nATZfMB1UmIGt9afokg8E20DpPP3Egf1uF/DqbCG6JXTKUcPFVidTIvTGJ1AphnhZ vsLvIpqdIzOxZQrUyJX2F+Qn6vwteeUbL8YbCVgtWryIF9Twn5/tkP3j8c3iqvG09GeG +CiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Y0nJbBNCKMab2Zx5w4V0rPW6WltkzyIXae2zmTSbYNw=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=jo81TEN82e9AkrpUs6MtFxX20J7atIv5iqAZ93CyK2VPl1SK347CB1hVo8nvEhEnp7 mts41hx9eX5saSPu0EHqudS2iXyiFxf8j9uT6OB03kZCdlk1QMj+DKV+clMXtyt6omLS 0W0ygf5+Atv6M2JYfVA1C0u2wHexjdWW3KASF4xuGcWlPoqax+uoFyqAono6BnnobBQ+ zKWy4/OdMiVMwdP6m8u7ZxUCWEEuytWnaoeJlYUqA5KyNRMixGLatba5NSnFkIlYJkt1 kQiJeYstXyVjw62IQEbL8uhxz1RMCU04KXrybO3T88X8TloxG84gU8OtR7ojORKQSkFr yuhg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=jU2L+mHz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acde60b741si364604785a.480.2024.09.25.04.12.40 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:12:40 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=jU2L+mHz; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPwA-00047J-KA; Wed, 25 Sep 2024 07:12:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvx-0003B2-8N for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvv-0003k8-DX for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y0nJbBNCKMab2Zx5w4V0rPW6WltkzyIXae2zmTSbYNw=; b=jU2L+mHzAvojXsnkZeC9mC/dxlKL/Vs+hLxy9jp00U/cuqBU/xk1hMJAjxy/3yE/MOsrNR m9WNhsXeONYS+LYJVcWz32uCNI4tWTf9w9ISxO3mIvMy+JPEKEoV99N2C3VzXQmGCJJIWm mXISMphY1kcvDxmwJxZi3vgYu3Q5oQo= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-126-5u35doFDP92V06F5ol9Uvg-1; Wed, 25 Sep 2024 07:11:43 -0400 X-MC-Unique: 5u35doFDP92V06F5ol9Uvg-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B6893193E8F6; Wed, 25 Sep 2024 11:11:42 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E46011956094; Wed, 25 Sep 2024 11:11:40 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 25/44] hw/acpi: remove break after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:06 +0200 Message-ID: <20240925111029.24082-26-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-18-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- hw/acpi/aml-build.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 006c506a37..34e0ddbde8 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -535,7 +535,6 @@ void aml_append(Aml *parent_ctx, Aml *child) break; default: g_assert_not_reached(); - break; } build_append_array(parent_ctx->buf, buf); build_free_array(buf); From patchwork Wed Sep 25 11:10:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830457 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685348wrz; Wed, 25 Sep 2024 04:14:46 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWcprShdQi/biLFAlSaWSc0/qY8v9vg15krJMrKg5e8s4p4Zvv373S7uzMuPZ5a+YWhCiL5yw==@linaro.org X-Google-Smtp-Source: AGHT+IH6G7ouyQ1taUrRAyntX8QV1zqo5Kna4IFo+gUNXY+CiVKy5Z+AYJ+6zfGY0g0hFUlAnDE1 X-Received: by 2002:a05:6214:4383:b0:6c8:f32:553c with SMTP id 6a1803df08f44-6cb1dd6d4admr30173226d6.25.1727262886481; Wed, 25 Sep 2024 04:14:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262886; cv=none; d=google.com; s=arc-20240605; b=e6Q0BBZrszjAyXzEYLcXFcVARuvJpM1wArvCFwhrzMMosXBSv3QZD4YvSi5j1KACUt KZhkE3KmJEgHEnmOi/ZiSkAwBGsftNxdKUteb60AtMr7b6yzEELa+dDNmzEtfvnEunJx 3nyzU9jhV9OvgybhkZc7wdB3JeFlNyQEeeFcFziT1JlFY//pUcrxJKoUYs3RSHwrLD79 OdGZ0zDEy3SGGuBSQZvHvBMKwvcOtkq5gCwlri/U50fUGdYeSyMe7gpyBySKbYRYHxmP eWH6uCXevW6/PCchZalo1RkZSJhGaNas9bJhCixIg77lk613eVQ89IM5fPeooZs25b6L MQ1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Ne4RYO3T4Aggh4ZeMVL/i1+027NVJOUy/TEZpPiDrNA=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=dgl2tcJFNv2cNlIYvxgb39OBg3cLpjnpWIGq9pxlYQ2/m5KklOCnqGkiPrhHIrHiRo nc8vrUNA0Ja0iNjITUQVyXWRV/LTfHe2ZRnzVXBJ+k+c9NKgHE7SXX/wo/KYzfOYp8UL jpsJbdlZGdtXTyv486esyaGUqbHPWKFGekg8TznDCuPhPQGvS0Gpz52OpOi7Iqv9GDWX iIs9VNj1h3AVjtvftd+8zPZvaQ7sYO4vqmjCsTJI2OT2cyc+ceC3ho3oppjF0MRzwZH/ dY7p1gFufPvuVWmh8A7/kQ4Ed+rKtkBzVMYWuGLpQpP0q6t1neGBRMEiYffZgV6qUmlQ udew==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XShj1p5z; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6cb0f4e7e1csi37204856d6.136.2024.09.25.04.14.46 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:14:46 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XShj1p5z; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPwJ-0004jo-K3; Wed, 25 Sep 2024 07:12:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPw0-0003RR-LN for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvx-0003kb-QF for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ne4RYO3T4Aggh4ZeMVL/i1+027NVJOUy/TEZpPiDrNA=; b=XShj1p5zMtYU0vaijU6rYG6DQ9iekELzTkBaC8nzxrpehNRQZim3bXRPBDvKRWcZ0A4+sS aqUOR01e+EzhdypiLfUnhdgNDChWijLcBVilJqdrlXVypNFFSj7DK6ngzcMTuNoFusZNGM fxGcPWQbqCYre/9HDvXdVKZ1wfnu/rc= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-DHRMpd3GOkuBHMZ9upNcOw-1; Wed, 25 Sep 2024 07:11:45 -0400 X-MC-Unique: DHRMpd3GOkuBHMZ9upNcOw-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E55391944D01; Wed, 25 Sep 2024 11:11:44 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 42CCC1956094; Wed, 25 Sep 2024 11:11:43 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 26/44] hw/net: remove break after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:07 +0200 Message-ID: <20240925111029.24082-27-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-19-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- hw/net/net_rx_pkt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/net/net_rx_pkt.c b/hw/net/net_rx_pkt.c index 6b9c4c9559..0ea8734474 100644 --- a/hw/net/net_rx_pkt.c +++ b/hw/net/net_rx_pkt.c @@ -376,7 +376,6 @@ net_rx_pkt_calc_rss_hash(struct NetRxPkt *pkt, break; default: g_assert_not_reached(); - break; } net_toeplitz_key_init(&key_data, key); From patchwork Wed Sep 25 11:10:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830439 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp684318wrz; Wed, 25 Sep 2024 04:12:16 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXI87E3Sm/15oydBR46DNjGIRvVlfDtE2dxHUQWoDaX2y05A85T8nIQ2l2MuizW76TzVjDiNA==@linaro.org X-Google-Smtp-Source: AGHT+IFpggQATxMQFJQ9LvRA5d5ZSkBMYos/2k4fW4QS825TgoMMN+5Pfbu359c2FEy+YArc4G9A X-Received: by 2002:a05:6902:1a45:b0:e20:2cc8:5a59 with SMTP id 3f1490d57ef6-e24d791a130mr1846271276.9.1727262736598; Wed, 25 Sep 2024 04:12:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262736; cv=none; d=google.com; s=arc-20240605; b=ZZjKV0Q9cm5n1nWUdyQVUz9NHokWiNUzwJd+JEo3Mgp5ZO7/sdQI4dHOT6zusydbq/ F1XcMrWzSGahbq+UyNpGloy9s9rGZT6Nq0GSXtm5oaoyX8/kfdK8EozF7FoKnJo572CB K7PvjbPlJyYSuJlyJebl1hb57mhw4QyVbbfNhpVnoqwwJdvlWWAFyjgBpvexgNeJ3KPL 0wxNbJ731VVbdp665J6pKAAxFo6IvsFkeVXfSViI0RQREiqe/u//WpAa7x3FQmN4rQyY yAgubFXTApHeP9L5d/2Om81saOns0w+pNVWpgwOIxEQACdWiRtEVdyoBMIhZbaAOlcxr bOwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=tZVzphQdjGjCU5nXoYO6/Y8Dt9zYl8M8DQY574lUcWs=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=AR4VKLEzcHhWwYct4gnr46YidVryrgwNLE0DosF+iiNyQvtnZR/JdjjVrsvjg0cKty l1i3IEzx/jdrtfON+mnjq4qW1E73fZoJOCTr1hauBCknSdJJUqWWIMcQ5ckDVOj2mmZZ SWrxG5BE29uQGk3KfN00Sy/ufvREzX74ihk/agMGC34MlZUMeef22I5IC8VmTL5bDtV4 1Po6cgvdgeyY9ITqcp6bjY22UnU0FF+v0GaG/wUHOxm65snlK4bWGioiCIb0fX220MHw nmCirL4uW7XxEwrP3RIgkq76o/0S+q8eo9DAmM4ILCgxkm+e2uKpV8rTw3F7Y3B1Pj8o w/pg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="eqLAtk/f"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45b5256f6b2si34553461cf.135.2024.09.25.04.12.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:12:16 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="eqLAtk/f"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPwD-0004Np-He; Wed, 25 Sep 2024 07:12:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPw3-0003gO-4H for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPw1-0003lE-AT for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tZVzphQdjGjCU5nXoYO6/Y8Dt9zYl8M8DQY574lUcWs=; b=eqLAtk/ftcVN8VIRROLVYzbISHGcF4K+uzhtY/Ml65/NJe5RV1KCEjk2iTiEUZlOWJX7/s bUsmNSmyx9bWsNMbkOJ4Fs2cu4zDUmauz6qPl3xFvKvdE1V1noEH1QFNHCVKELDV+mYVBF SBoiXLDRIjIzv15EKvp//YIjmyaahMM= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-x7kOWLPNOi2uCKuvlviotA-1; Wed, 25 Sep 2024 07:11:48 -0400 X-MC-Unique: x7kOWLPNOi2uCKuvlviotA-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CFD9F193E8F2; Wed, 25 Sep 2024 11:11:47 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 72F881956094; Wed, 25 Sep 2024 11:11:45 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 27/44] hw/scsi: remove break after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:08 +0200 Message-ID: <20240925111029.24082-28-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Kevin Wolf Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-20-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- hw/scsi/virtio-scsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 9f02ceea09..6637cfeaf5 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -357,7 +357,6 @@ static void virtio_scsi_do_one_tmf_bh(VirtIOSCSIReq *req) default: g_assert_not_reached(); - break; } out: From patchwork Wed Sep 25 11:10:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830467 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp686126wrz; Wed, 25 Sep 2024 04:16:28 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWtVaLptAOqsTVe5XQl7jWux3KSJ6jlZwekuwSiSV2Sq8iLThPHtsw6JpWbTD370vguDwvc9Q==@linaro.org X-Google-Smtp-Source: AGHT+IEoal0Am2PovgFatG0oPv/KS5hIHdiDVVpj/yNbm1KHuLEuJUbRsKirmWUNKrQ5J8mCOI47 X-Received: by 2002:a05:622a:1885:b0:457:c74a:638e with SMTP id d75a77b69052e-45b5e02c502mr38539641cf.38.1727262987889; Wed, 25 Sep 2024 04:16:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262987; cv=none; d=google.com; s=arc-20240605; b=UgLdr+LOmiq3sETuibke23+ktV5sTkjW6FaxlOMcjUPNpVDdWtCmVgzKGKwPLlDUKF x2Nq2mKRd/jSB+HCMRu+zoYIxG91y2d5U6JM7Cu4Bwu2p5q1vuGqE01sQ75+cG5OKhyn 1vP6qrOMFMdpMIfp+tiC+jV8NGzrq1vC05vS6foIe57deaUxH8Yvt4Mjw4KRjTZlA6Uu vq5qjkfPg5d6CJGozkPyV3tNqrc4Cf9A+2mBJQ6KT2E5XxtM3NYyQXkj79xxrIoOyIMp PU4YUiuPwJM3p0WAqLXWshfzUZbtki5SQMbBs3rJm0BOopIq6ZyDj89+rnw9hp9Z2nFb ybdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7DEh6045OUJp99Ba8zmy2nR/KEr7ul1oZPdI/Kx0ia4=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=lwquqqF27nxOI0sgJmLSHJXljFFzIXBcoQCozYapYR+uYcueH7k4XyZittyoLLVLIc +xvnncfPlfIOEHAjUiaOQIjshe0WTMauSx9dbrUBpkAZxNUoW0KQD12JWJ8NoYybkbyK VewBh4hZb+Ae9B/pYqNcU1vR3vou/2LJCQw9mhsSQTh8DENo5JHrVNsq9BWpboG/MLzH j2aumGXN0UO4vHX02l9ZK8DQjj13Z9fPPXdNH3WNaUlXX2kK+r5s8KhqdVfiVJ/XXfbY 8hubOdyJCEVH79TiY3sKeO8uTH9RNI6t0+Ly8aOmLKTFCPuwbDK56LD68Es2iQ1CsGcO 3abQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bWVZZ5gK; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45b5256ddd1si35151861cf.32.2024.09.25.04.16.27 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:16:27 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bWVZZ5gK; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPwR-0005Rj-Ce; Wed, 25 Sep 2024 07:12:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPw5-0003r0-KF for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPw3-0003lp-3x for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7DEh6045OUJp99Ba8zmy2nR/KEr7ul1oZPdI/Kx0ia4=; b=bWVZZ5gKcmAfZezb7qrskzizYC5zdobcEJh+CXXPmoLxW3h9VVZN+9axLxQFTGS2kKcnzN r4rbD9vfwF8XHFq0UreTBVCFR54rth+njKddEnQNJnnM8A20DfuJk0CyC3ogMu9j6VxZA7 LIFAOqTza/4MPYx58PWmQgTekQ5cPbQ= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-449-Mcut2KtkNPqbmUO8A6Lngg-1; Wed, 25 Sep 2024 07:11:51 -0400 X-MC-Unique: Mcut2KtkNPqbmUO8A6Lngg-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 396B81935868; Wed, 25 Sep 2024 11:11:50 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5BB021956094; Wed, 25 Sep 2024 11:11:48 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 28/44] hw/tpm: remove break after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:09 +0200 Message-ID: <20240925111029.24082-29-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-21-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- hw/tpm/tpm_spapr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/tpm/tpm_spapr.c b/hw/tpm/tpm_spapr.c index e084e987e6..5f7a0dfc61 100644 --- a/hw/tpm/tpm_spapr.c +++ b/hw/tpm/tpm_spapr.c @@ -206,7 +206,6 @@ static int tpm_spapr_do_crq(struct SpaprVioDevice *dev, uint8_t *crq_data) break; default: g_assert_not_reached(); - break; } trace_tpm_spapr_do_crq_get_version(be32_to_cpu(local_crq.data)); spapr_tpm_send_crq(dev, &local_crq); From patchwork Wed Sep 25 11:10:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830453 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685231wrz; Wed, 25 Sep 2024 04:14:28 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVGC8kwo7iq8QccBftjXAo3/Zeq2uKGXSfGf1aSX1pPYXrkBq0s4M7DZMolVhWUa5plZUeCuQ==@linaro.org X-Google-Smtp-Source: AGHT+IFtaw1raixJ5G6BIu17E0o5lf9CQWLKKLlYCvQYNAvbe+NWzDZm0/5psddTit6rvF063W4J X-Received: by 2002:ac8:5d4a:0:b0:458:38cf:410e with SMTP id d75a77b69052e-45b5dede402mr40598891cf.22.1727262868676; Wed, 25 Sep 2024 04:14:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262868; cv=none; d=google.com; s=arc-20240605; b=OZkSpNXcIeFOOH8HdJKgBSnOcM6Oe9vzbiCumbaFn1Qmvl23BP4U5tigNvMOn6hekD BMjUjnXR9sSPgjv6kfb9rOe5KRN+PtZDEGIIzDWpwskx6W17/UA7RHFStrsFWLGGMlL5 msuvhszAdvvSYVo6srYU2QzVpPRqOPBkSkBc1DF6Q/BhAyBh+Li4asY9MQYMExyQuNOr 7v2Jns9XWEZAqzTY8y/UEGvr4MTuLWvkqHnFlvfgnsfmBQQ8r8A4xon4dIT9nAefHUdD BFQa35zeInmhj/3hrkQyTxbU2hQuBeDHnm2h8SkPrpR/ahd0/3uFRrRhtBtKosNlpFyL kwzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Qdtu14VHAzFns9mQ0LRxyUg5oEigdbyZqaU2RCfM/Ds=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=Q4FzPRgrhF8aPUZ8T0/g2VGEIZ6243X7fMrQInDbLFBwt3F3F749lqhsC99WWDRBt/ pFA1Hle8SOkMdvCvSV0vxaGtaMdryh4dddYfGiQS1kuNtZoP9S9t9O0T9u0csZ0xeziM jTwk/CKdRFZz7ERrLh8H0dhIGZBf8NjL7qFA1wv2xqfbGyI+3L5iOwNvIUHoD9Sl3Bdf UGLLLP3u7kNRP3rbOTyO/Usl0gTooASLApSIJnjAfL6I4AXAMMOVjM1klNuwk5YTXlB6 hwWRyb28gK+P64iySMCCNbgVW5mhFLk6Ok/ndr60kAMYPG3WMjK4E3uq+23GDCoolJwE +1xA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DvNV+8at; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45b52682a56si38395621cf.376.2024.09.25.04.14.28 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:14:28 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DvNV+8at; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPwm-0006kE-9N; Wed, 25 Sep 2024 07:12:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPw6-0003u8-7S for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPw4-0003mD-QL for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qdtu14VHAzFns9mQ0LRxyUg5oEigdbyZqaU2RCfM/Ds=; b=DvNV+8at1TqRLaHisqFZcFpcHgbLvYviwAszrAx//2NQWSmjEOuM4pgcnayeISFtaXNmYZ I5VuPFgrw3wB1OTjiIpMkv7TvLDD4thIVsgZAu507QUqhArLOcl1Oj80N6jVwrzQN9ZeRM FhwNBT44/UbsuKvCmo9SFXYn+pM1teU= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-344-r5mYz0mUPFW1p7PJSbpl9Q-1; Wed, 25 Sep 2024 07:11:53 -0400 X-MC-Unique: r5mYz0mUPFW1p7PJSbpl9Q-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C566B193EF4E; Wed, 25 Sep 2024 11:11:52 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D03F61956094; Wed, 25 Sep 2024 11:11:50 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 29/44] target/arm: remove break after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:10 +0200 Message-ID: <20240925111029.24082-30-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-22-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- target/arm/hyp_gdbstub.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/arm/hyp_gdbstub.c b/target/arm/hyp_gdbstub.c index f120d55caa..1e861263b3 100644 --- a/target/arm/hyp_gdbstub.c +++ b/target/arm/hyp_gdbstub.c @@ -158,7 +158,6 @@ int insert_hw_watchpoint(target_ulong addr, target_ulong len, int type) break; default: g_assert_not_reached(); - break; } if (len <= 8) { /* we align the address and set the bits in BAS */ From patchwork Wed Sep 25 11:10:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830444 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp684865wrz; Wed, 25 Sep 2024 04:13:36 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCW5sFrMHmK2AYcxorqU9o8nX9MorOHC832nHltpjtqhBi3u3a5vzdOk9cGD+ySRDuRYlVRbbw==@linaro.org X-Google-Smtp-Source: AGHT+IE/WhjMeb4K/jB1Dfm1t0dlOjotpErWqpcVAc8IPi6NTgUsuZGYp3FsUpHd546v96rLy3W1 X-Received: by 2002:a05:620a:370d:b0:7a4:f2e9:814a with SMTP id af79cd13be357-7ace7461dd0mr304261985a.54.1727262816495; Wed, 25 Sep 2024 04:13:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262816; cv=none; d=google.com; s=arc-20240605; b=b+44WciBCIT4Oqu/v8MW/ExUW0V3wdzD8k+Ms1laP1KC1k/QDyhQq8qePk6zey7+oU zl/WgQfnzUHRPk4UmnYTMN4ds0JlvIh07iTjNqzVVwTBlbLhtI7Tn7WAvQdVeEmEyAUC mm9IUCRueqk2PUbqpGVZNMJcfZ+khSUyK8/8MPvp0XaQNqTqq+mWVXGetiQTB6nFIHAH V9ezyjqxnppejiyGMSMjzEbf4tDL7y7oZP9lhozmy/3QaSiNMrkddpocO4fNMg3/5u76 JAKe7a6avb38dAZeLfqclWuScEnqrj8vsueYVztU7EkZAz/0DzFG4RHNx/q/PtKZWMzR Ud4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Iu/VgyOBAMNIm9BxndVV79VY98Fkfv3UB6OxtHbaZ38=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=YmEMfauIIPWv2Rl1cxD9UoLBRM8lpLEgBu4CHp+KIebCiaAMPqZQAIB7+6O/70aL0e Qqx/v/zQnEN1INC2Xdds+y8uxDS2liMWdh1Sf+uw37bawHtrwJRXP0kprVBvlrggtRif A7wOS4xWQmuMdKvPlAkDOV3cRkYjH+H2a1pafN46oSMDbctuIspPSfPhDUwI7c0wrINm //83WzupCdcPS9O/EO/9rxfYTzaXq+Tfh0MPr1NXFKll3snzpuR07Hx7Dm1RYPJohtfZ 7Cy5pCsFfPTcU+AMLjRP+7ACI0hAyHHZpgtyRN6Ay0GJ9YxaBNB13hOfAsbZUlmCHlJ2 9sQQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Joi3QXzm; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acde5ccc40si375687585a.249.2024.09.25.04.13.36 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:13:36 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Joi3QXzm; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPxP-00017u-96; Wed, 25 Sep 2024 07:13:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwB-0004Hn-0o for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPw8-0003nB-Tn for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Iu/VgyOBAMNIm9BxndVV79VY98Fkfv3UB6OxtHbaZ38=; b=Joi3QXzmLazNUi2QaXq+jkuu8LDxHoMvkPi/eneCezaUoFAKxbQ5S8cS+ItjEc/cmtM+Eh lNe+Qt66CAFy3yX1vfW1eoRItzBrpOZCJNglDa7osd3gRj9ROtF2Tz6EOChdrRxu62gb0s yk+diDbhIv1X6Z7bJuV3eK/V09cE6q8= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-205-mP0B9BYKMTK0TuxZZhIEAw-1; Wed, 25 Sep 2024 07:11:55 -0400 X-MC-Unique: mP0B9BYKMTK0TuxZZhIEAw-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DA683193E8EF; Wed, 25 Sep 2024 11:11:54 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7601A1956094; Wed, 25 Sep 2024 11:11:53 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 30/44] target/riscv: remove break after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:11 +0200 Message-ID: <20240925111029.24082-31-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Reviewed-by: Daniel Henrique Barboza Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-23-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- target/riscv/monitor.c | 1 - target/riscv/insn_trans/trans_rvv.c.inc | 2 -- 2 files changed, 3 deletions(-) diff --git a/target/riscv/monitor.c b/target/riscv/monitor.c index f5b1ffe6c3..100005ea4e 100644 --- a/target/riscv/monitor.c +++ b/target/riscv/monitor.c @@ -184,7 +184,6 @@ static void mem_info_svxx(Monitor *mon, CPUArchState *env) break; default: g_assert_not_reached(); - break; } /* calculate virtual address bits */ diff --git a/target/riscv/insn_trans/trans_rvv.c.inc b/target/riscv/insn_trans/trans_rvv.c.inc index 3a3896ba06..f8928c44a8 100644 --- a/target/riscv/insn_trans/trans_rvv.c.inc +++ b/target/riscv/insn_trans/trans_rvv.c.inc @@ -3172,7 +3172,6 @@ static void load_element(TCGv_i64 dest, TCGv_ptr base, break; default: g_assert_not_reached(); - break; } } @@ -3257,7 +3256,6 @@ static void store_element(TCGv_i64 val, TCGv_ptr base, break; default: g_assert_not_reached(); - break; } } From patchwork Wed Sep 25 11:10:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830442 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp684668wrz; Wed, 25 Sep 2024 04:13:03 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV4HBYSKe7LlyLFHfEYCnF/FLO4fxlOOrvgag4HRLjNKottrc98Cpf88n2LUeipl6PjMwlX1A==@linaro.org X-Google-Smtp-Source: AGHT+IH6TUTEK54MuHdR5TXgGJxrgL/WuFkxjxi/DWQhH8E74H5hv9RGvcIAGWbZEIf9zneuQy3+ X-Received: by 2002:a05:620a:198e:b0:7a9:b744:fc38 with SMTP id af79cd13be357-7ace7400153mr300217885a.15.1727262783139; Wed, 25 Sep 2024 04:13:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262783; cv=none; d=google.com; s=arc-20240605; b=d0VkLBq19/Nv1QAwh2L88xl4VQ5P5N/4oLtDMHDxa8lYZLs0yUhDxyUBKzHSo07JuM 96O5fyg1SAJBTSIWh/7UPaQsGY+UaEuiaXsXw6YNyncmUE609/X6i0lK2qKIBP71rCOt 09ZS8SAXl8bxp1SVSmJ0osx0qaPoveOCivY0l+uxeUiBi0HYFzkAQAvHnpT7Jmh+0GOk /Qjt5MhVZQwZ6SPkBRHH9HGtWB9/O//gxg1mdxDpK8z6UK8lybifOCISvwibrDiT0uGE PvDHAAC7HpYPfjpNLK7rAY5Dh5w5555Oy3Q8+Rv7H7jAxdVg0+NdLx5m3vmjhBW03ZEw G/YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=XimUXKRctEutaL5eeVB2FMjJX/ijBkVZYDuZyCoDm3I=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=ONVegBJtwNVsXZ3UPyKnxoyDeJFdrgCdJLmxt5MezeC2iMvdH1X7KSLx3gTVmORcRH /4zuC1cvBL8/EYR11M3cDaOk42esjXYUohg/IG6l0KGnAccKWauZVyFAsKXOJiYb/nL4 hYH68dTZ2sglQL0HNjs8IMZyoumSmBVvF/ylSyP5zZL3FGf5V/GD9zYEBVgX7lw2UimU 5YRFN+BjMWhjZ4CMGBlBn8nlKhwunWSnw0Ycd0soIhbrtwaJ4eiFjsIgnflL7andeLI3 vUFQkYDj03zRvIkcKdDy8jWWXRFKXtbzhNPFclga2XMTlT5qHWbQHOdC9QAMu3LEEi1i HmCA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=M6kp8KTU; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acde5291b7si372605785a.23.2024.09.25.04.13.02 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:13:03 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=M6kp8KTU; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPwj-0006eQ-TP; Wed, 25 Sep 2024 07:12:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwD-0004Uu-R3 for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwB-0003ot-9e for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XimUXKRctEutaL5eeVB2FMjJX/ijBkVZYDuZyCoDm3I=; b=M6kp8KTUsGQn4Bx6azkAgll5kcPP45y1DU5E0id7Zfc0UKwe8U69uOmm/Y4tHKIq/BDQ53 KrjHqLRPpWfWolVlkd0Vn+Lm57QQJ7FU/DbPWvnwynUnf4JeevgVbJVS2WSm1kV4YrGpSL nIocEFP/V6iRV2VzdaPUml2C1XQiTJg= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-257-DkUUKFw3MV653hJlV5QtSA-1; Wed, 25 Sep 2024 07:11:59 -0400 X-MC-Unique: DkUUKFw3MV653hJlV5QtSA-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 15B7C1945105; Wed, 25 Sep 2024 11:11:57 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7D42A1956094; Wed, 25 Sep 2024 11:11:55 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 31/44] fpu: remove break after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:12 +0200 Message-ID: <20240925111029.24082-32-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-24-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- fpu/softfloat-parts.c.inc | 2 -- 1 file changed, 2 deletions(-) diff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc index a44649f4f4..cc6e06b976 100644 --- a/fpu/softfloat-parts.c.inc +++ b/fpu/softfloat-parts.c.inc @@ -1373,7 +1373,6 @@ static FloatPartsN *partsN(minmax)(FloatPartsN *a, FloatPartsN *b, break; default: g_assert_not_reached(); - break; } switch (b->cls) { case float_class_normal: @@ -1386,7 +1385,6 @@ static FloatPartsN *partsN(minmax)(FloatPartsN *a, FloatPartsN *b, break; default: g_assert_not_reached(); - break; } } From patchwork Wed Sep 25 11:10:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830454 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685301wrz; Wed, 25 Sep 2024 04:14:40 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXn23qJ9a0FgebKa73Iwih2nXc6uc0QQXlOqccvrkcq5QudceOJQZoj6WQUJqg6ym1rl/EH9g==@linaro.org X-Google-Smtp-Source: AGHT+IFTvfNFrFVMTC1vjiVNaq+L8JjykRhhgfZHz2zlxpv2aZYLE1JMIkzDibnZ83ELMWIKVFzR X-Received: by 2002:a05:620a:198f:b0:7a9:b856:434 with SMTP id af79cd13be357-7ace73e5efcmr341931185a.12.1727262879797; Wed, 25 Sep 2024 04:14:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262879; cv=none; d=google.com; s=arc-20240605; b=kAQWycjtPyN3kZ4GgbJ9OAAHs0is/lG2q9IZ94y+UkCLJbv+vdNcEohzcakSwRLChe i31Qaa3HHahaRUD9Syv/CqiltTN9vyXn9YlY9gCHy39Vx39ll7IxElKQNewrzt51S3xB wm0jh4lNDpSgvnBknZ3h8tEf1MW5GDt0NRxZ1ho+z8c3JiOSHwrxvt6v8l7SfN1RIcMN cCuwqYXGntX0O9bNpXWP0RJOWTFyEeoCOEpL9H8kNMJfJEIRiSv2fE4vHylzEhWtbZCt +fueQLSXoTIKimoCSdaIe8jkz51zsKbT+yQPjZswgBw2ashABa0aDMzrWlW5p6j6k8uY 24bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=AWrnKoybkcOqIXNneCbZ6Rc49euB/UmGK8Q/kaILYgw=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=BPTTmaJ5sygbGWk3uw+OP9Ht6wj5bAriec/2tP/XSGXU5Pw6w7AIAoqIxbz7zpehx9 288hAlshXhyfsPN4dcYE0GpTuAos76IO5cVHwS40qR8Y25wmWo3CJkla33ysBSLObJBc tFtErN2KgIbhZXCR3ELSTByJe8M0R7ST6d/pmGa+w+3zRrZwozbgvirYAzyw5B8J6eDJ T9lgXauu9eL8uarYLxgdtQMBTP7CvnY4Wqirsz+GSGjcRsCrQZnEAMEEGHGIf8JiVWbD /gaW35q6GoTLOuQDGPnlGTCZg/qY85iYQUvDP+wCHrh27Gb3ci8r+ATSXqoXQPJTJ7+L 19JA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EjBy7yWl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acde5ccbd0si403204485a.235.2024.09.25.04.14.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:14:39 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=EjBy7yWl; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPxN-0000pf-HV; Wed, 25 Sep 2024 07:13:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwC-0004PZ-II for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwA-0003oA-Pn for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AWrnKoybkcOqIXNneCbZ6Rc49euB/UmGK8Q/kaILYgw=; b=EjBy7yWlsRyLgHnDiHn4YezYN+5rbc16IGwiydjXtp69WgFKZH5Ls78g6U9Y4QDd3pm20/ PvH18GahpgDDjYKRmQRKNJktDpKoC4eajVuydpPGaXIwhHoixZUzad4QPkBLyzBkD2tIsM QEzepONq+TdHaV+MiDb/jQcNog4JIY0= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-354-oTYSWKH0PLuOQ16GchQi0Q-1; Wed, 25 Sep 2024 07:12:00 -0400 X-MC-Unique: oTYSWKH0PLuOQ16GchQi0Q-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 608A1196CE02; Wed, 25 Sep 2024 11:11:59 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D42E51956094; Wed, 25 Sep 2024 11:11:57 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 32/44] tcg/loongarch64: remove break after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:13 +0200 Message-ID: <20240925111029.24082-33-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-25-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- tcg/loongarch64/tcg-target.c.inc | 1 - 1 file changed, 1 deletion(-) diff --git a/tcg/loongarch64/tcg-target.c.inc b/tcg/loongarch64/tcg-target.c.inc index 5b7ed5c176..973601aec3 100644 --- a/tcg/loongarch64/tcg-target.c.inc +++ b/tcg/loongarch64/tcg-target.c.inc @@ -650,7 +650,6 @@ static int tcg_out_setcond_int(TCGContext *s, TCGCond cond, TCGReg ret, default: g_assert_not_reached(); - break; } return ret | flags; From patchwork Wed Sep 25 11:10:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830473 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp686277wrz; Wed, 25 Sep 2024 04:16:51 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXz9soA35MpZ5UDvkk2FEl+KkRTXHGPk07I86J+8RsdzEQfmxAknCJqvoO8Gw2izDtzjGn9zg==@linaro.org X-Google-Smtp-Source: AGHT+IHiAL0QqZu+TjqicOnUZ1ZrwEql9bSKuAIGy40whDSjUZw4arbujdXxlS9v8hwryYkEym1s X-Received: by 2002:a05:620a:2483:b0:7a9:b4d2:9d70 with SMTP id af79cd13be357-7ace73fd9e6mr380757885a.14.1727263010800; Wed, 25 Sep 2024 04:16:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727263010; cv=none; d=google.com; s=arc-20240605; b=LDjvwUOt7iMz+AeV5PZhj1NFDcD0c8hnHd0vO6u0+SKnzEMY+UrRJBqBQXSpeKtHnY YfEzxkI8fXFi3cPefAvFseXh766IKGU3pKbjkjOH0OWo2wHfUOnTxo8ghautrvpsP2HT 7twDLdzdYaFEyKXK34SqSz88dtsPg+lY3ZTM+xYleZ2paYmEm7yQUntth7XSCLLiufQ/ dBMtp89jyb3GbOsaLiURDdhTEh9LoqPrpvZrcUg7M3KGlc0YEeluyjCkV/VhaCmwGiQ0 qDCZ2eCjC0tSwcX1uJiJPmEDVT/4XirPOHbIz9eo8JJ0+gyu6OlXXkclNOA1Jo9oK6k0 /OFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=tI4/cDzqMiZaX+QC57XjuOqEXcKPrBnOpVVF8uKbOJE=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=CuQexASFWR6qz1aRh32fkIUaEK4oXtfJIC64PJQUIRRId6W2sad2ZEBU1XXNH0kS9l 1aGnC1l65wRNUmG3eQIDpRJyKfSjVzFtOU6Lq1kI6JbCBrvOqWHWbac9Zx3G8JudfI13 QoWJTMi/N7DLvZMpUumblsF9KYQmw6PIIE7HpH0W16iALoY5bP4wNkXdsMuwGx+a78yi GBKvwUkk/ENsnEWPg39AsssL0BlhgPZawW8ENHKl6AzNJeESAL49lCArRrcobQ8lKLyE 7lbDlISMQErDVhLF41ipPzdWXUD7R4NHIsPWA1trdIQbBHkmClxmtOFqNPHoWtf4LIyu V42A==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WDwpQEjC; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acde62f6a7si369729385a.571.2024.09.25.04.16.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:16:50 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WDwpQEjC; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPwR-0005Rf-C0; Wed, 25 Sep 2024 07:12:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwE-0004Vj-1L for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwC-0003pA-FO for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tI4/cDzqMiZaX+QC57XjuOqEXcKPrBnOpVVF8uKbOJE=; b=WDwpQEjCorzA02e2gmacsGRPUDnGkYk+kt7oGXpaKWKfpU1922jSV213tcXKkwCTn08lVh 6bdwhpw8Yw91LKkBW3BKPstd7LIGSYToP/pyLyIKc+uwjJTs1QXqRiinDPydri8hJvJED9 a7ubkug3hGoJaOYo9A61bxKX1yxt84E= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-478-QJAW_vO_Nze3j5PZXM-tVw-1; Wed, 25 Sep 2024 07:12:02 -0400 X-MC-Unique: QJAW_vO_Nze3j5PZXM-tVw-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8061A19367B8; Wed, 25 Sep 2024 11:12:01 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id ED93E1956094; Wed, 25 Sep 2024 11:11:59 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 33/44] include/qemu: remove return after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:14 +0200 Message-ID: <20240925111029.24082-34-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-26-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- include/qemu/pmem.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/qemu/pmem.h b/include/qemu/pmem.h index d2d7ad085c..e12a67ba2c 100644 --- a/include/qemu/pmem.h +++ b/include/qemu/pmem.h @@ -22,7 +22,6 @@ pmem_memcpy_persist(void *pmemdest, const void *src, size_t len) /* If 'pmem' option is 'on', we should always have libpmem support, or qemu will report a error and exit, never come here. */ g_assert_not_reached(); - return NULL; } static inline void From patchwork Wed Sep 25 11:10:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830462 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685810wrz; Wed, 25 Sep 2024 04:15:47 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVOZg6F4lW47UosR1zaCl9sy3RbMdGKT6IwKRQqKDq+JrrHlxcZRjaCXhGhP2zLblcE3J9rxg==@linaro.org X-Google-Smtp-Source: AGHT+IHGs4hE/e6NPVZLMhctS9VApdK7qvFiSmUDO9WMmKg0e/Vo74ngdCJvhhcbo9Y1qXlbSTfk X-Received: by 2002:a05:622a:5b0d:b0:458:52f0:9bd8 with SMTP id d75a77b69052e-45b5e0a9e36mr27185561cf.53.1727262947486; Wed, 25 Sep 2024 04:15:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262947; cv=none; d=google.com; s=arc-20240605; b=e7KNjOR+5pzEw+uQVvwf2d9s+ApP0oESK1c/oV/XJGgsYMtCz0VSecjzX+3clE4w4E vK9w9sMnBupPbYX1DNBOgEBjJYBxTiwDAJbhn18KKZht6OtkBosKNp1g2GoQ8VS+aJKD Udih0mXaSoLUwMem0nFmsn9ky3BEEZ+ogfNcmMuRygXywVGsmRv3ZfbWZSlJeOdNwVUA FAGGNpKpY3eYZwiL+xmZCus+I5eOimGLPDRHqN4wHpJ284j/dCcevZLekYXKg837CNni q70nMvF/7p36rt9ECuDgNMrurAT15foxckLLKPQkiaoB4LpvwfPM5Lb8tUtbyHnuRUc5 iRGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wkzBGKUlyRgU9QQA/Wd3XK/yIj4C76VWmvHNoa80fTE=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=fxWgmwZeFHSW3I/I7rc5WN8KZYjx0McBiZAgRbVPs+iPOsvLvP49NNPnU0BhlTwIFz VGdFy/wAQuyR1w/P0u4ypigxnlXvOnGRHFhR07nkC+lAtWGKOG0IdtxzNIDOwLRZsaCR Rs84eTqzritk/3FPnhYhbHmYQEYBY3WLVRoUWW2yP21PlXl2C66hwOCTjCRXvg4XzlTK ipDjAdojJR2SYjzk3Rosn3xR+Kpe7v5PaMHz3dZdPWcXOcCgrztlbo3krGRZtFIa+V7T +ifhB5znCt9/Nkgw7X/FsdgZXmJFSYDinNECZKS7ct3dgek2ua40V95QJlNsdmbqNY6C E1nw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QN9NuGXm; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45b52748a71si38578811cf.672.2024.09.25.04.15.47 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:15:47 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QN9NuGXm; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPxl-00035S-GU; Wed, 25 Sep 2024 07:13:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwJ-0004s6-0c for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwH-0003s2-In for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wkzBGKUlyRgU9QQA/Wd3XK/yIj4C76VWmvHNoa80fTE=; b=QN9NuGXm+8dFP5WANmh0JENlLNSLpFEDYCQ0t403vXbg4tpFcXLGEE9gCVWBkghcSjd3xQ WxcImpk36Skq3ZC3J8mGpKq7PeWf9wjAOCrtu0ZjATTGMGNvoiGkmsmgKM3e+QXgE2Xhc+ zC8VDTgMVQ5n3AwDKDh9FllN/DSTg8o= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-274-HawtOaWrMq6rbD9oxy_nEQ-1; Wed, 25 Sep 2024 07:12:05 -0400 X-MC-Unique: HawtOaWrMq6rbD9oxy_nEQ-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7FDCF19332AD; Wed, 25 Sep 2024 11:12:04 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8718E1956094; Wed, 25 Sep 2024 11:12:01 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 34/44] hw/hyperv: remove return after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:15 +0200 Message-ID: <20240925111029.24082-35-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-27-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- hw/hyperv/hyperv_testdev.c | 1 - hw/hyperv/vmbus.c | 3 --- 2 files changed, 4 deletions(-) diff --git a/hw/hyperv/hyperv_testdev.c b/hw/hyperv/hyperv_testdev.c index ef50e490c4..a630ca7047 100644 --- a/hw/hyperv/hyperv_testdev.c +++ b/hw/hyperv/hyperv_testdev.c @@ -89,7 +89,6 @@ static TestSintRoute *sint_route_find(HypervTestDev *dev, } } g_assert_not_reached(); - return NULL; } static void sint_route_destroy(HypervTestDev *dev, diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c index 03f415bf22..b36bd3d67d 100644 --- a/hw/hyperv/vmbus.c +++ b/hw/hyperv/vmbus.c @@ -1890,7 +1890,6 @@ static bool complete_create_gpadl(VMBus *vmbus) } g_assert_not_reached(); - return false; } static void handle_gpadl_teardown(VMBus *vmbus, @@ -1947,7 +1946,6 @@ static bool complete_teardown_gpadl(VMBus *vmbus) } g_assert_not_reached(); - return false; } static void handle_open_channel(VMBus *vmbus, vmbus_message_open_channel *msg, @@ -2021,7 +2019,6 @@ static bool complete_open_channel(VMBus *vmbus) } g_assert_not_reached(); - return false; } static void vdev_reset_on_close(VMBusDevice *vdev) From patchwork Wed Sep 25 11:10:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830469 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp686182wrz; Wed, 25 Sep 2024 04:16:36 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCU8lZ3nFOrZrx1l6Jo0WIcfoyLGqiOyt34wVlYNj1wt4Vq+n5IGQq3sK1I8VU3V1jDw91en+g==@linaro.org X-Google-Smtp-Source: AGHT+IGpY2zwzPFm1DCrSnlgWqUv+eFlHb4y7J9pBj4UZ3z7gD0HpENeAUBWHjNc//B2+0aWKriq X-Received: by 2002:a05:6214:440e:b0:6c5:5418:a055 with SMTP id 6a1803df08f44-6cb1dd6cf98mr40331366d6.30.1727262996261; Wed, 25 Sep 2024 04:16:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262996; cv=none; d=google.com; s=arc-20240605; b=ZYdeah6ROU05vpim/gE4gvhtzn0tp+C7zhLXndB6doB22YFJZhCY3LqXhD4Zote61Z ZWUWePfcAW0xtsiuVi75oCLUPSrL4v6K2ni++0NHuDv6T8TkJAnfyoWaOGZqaaKQQech 4ZRi0dhLRF9DLVAtDUJ/XZOkrmDhK1BK98lgFaFYndkdbLxON9/Qni27drSn4DIu1/6X r3Ks7UOMXcnlVclNwKZvKe3dIEXcD8PL094Mg3Dw4MXAdORDKz3MK84FfinAs7W5ewXm D89LWtLoTCPdntyMknuhpC8Uoi8MFxGDaQ29oSptRPMpMwVdzMwMqcL76KQOjcszPPI6 Nljg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=JiBT728skRmdm88rj1Bi2KyJhTYibecJXAT1gwEUtJE=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=K76bhLc8pnW9xKn0gKO0hZOqVAa9clWmKEm6UTQQlfT4Uh9H6cmErQgNz/Qcg9SFFI cCiHBwkiKTpskuurB2GcF/MzSf18gP0yfuZZY94QpmgObGobOZuX2klvBbq61XUPTgAY LCj9y4+qT+OyY9U+lAmlPMcLBa19zP1fp2YYagpk12LI9uTR4xTLuF2ckgg6wq36qQ53 618yuXlgj7LgnISc65EOYnx/P7brUuJpnjeryzqggItiWe0rgVRkYes+1P7H9O4iyniv 62Sg5NKyPW3z+9wqIPT6A9IazSQ/3nDIfn6KleubTCUsvLejj+9O/tZghq276b7mhC03 +nrg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SpwYuMJd; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6cb0f7a3060si36974346d6.435.2024.09.25.04.16.36 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:16:36 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SpwYuMJd; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPxq-0003lS-7H; Wed, 25 Sep 2024 07:13:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwJ-0004ui-Lu for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwH-0003s6-Se for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JiBT728skRmdm88rj1Bi2KyJhTYibecJXAT1gwEUtJE=; b=SpwYuMJdxhOoQJKrmAMF7qqN9YN6GvbNyk1fwJ2YPzjJXlEbEv+ZDYEii2+h9ZbX3mb1AN oJwqR59WfBqMGbYBjMbVDGjfVz+oH+NW7wd2KSsGTlwofSA1G/ZWYngCBZBYWdPs733TRw Jh9/z1r5lkVgZkhqNPjzrLkWNrNGKJA= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-mGe3v-JZNtyMHyZc5yM9OA-1; Wed, 25 Sep 2024 07:12:07 -0400 X-MC-Unique: mGe3v-JZNtyMHyZc5yM9OA-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 84593197701F; Wed, 25 Sep 2024 11:12:06 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F25E31956094; Wed, 25 Sep 2024 11:12:04 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 35/44] hw/net: remove return after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:16 +0200 Message-ID: <20240925111029.24082-36-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-28-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- hw/net/e1000e_core.c | 2 -- hw/net/igb_core.c | 2 -- hw/net/vmxnet3.c | 1 - 3 files changed, 5 deletions(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index 248381f976..2e4c50ddba 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net/e1000e_core.c @@ -562,7 +562,6 @@ e1000e_rss_calc_hash(E1000ECore *core, break; default: g_assert_not_reached(); - return 0; } return net_rx_pkt_calc_rss_hash(pkt, type, (uint8_t *) &core->mac[RSSRK]); @@ -841,7 +840,6 @@ e1000e_ring_free_descr_num(E1000ECore *core, const E1000ERingInfo *r) } g_assert_not_reached(); - return 0; } static inline bool diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 6be6140771..5dffa12c64 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -398,7 +398,6 @@ igb_rss_calc_hash(IGBCore *core, struct NetRxPkt *pkt, E1000E_RSSInfo *info) break; default: g_assert_not_reached(); - return 0; } return net_rx_pkt_calc_rss_hash(pkt, type, (uint8_t *) &core->mac[RSSRK]); @@ -747,7 +746,6 @@ igb_ring_free_descr_num(IGBCore *core, const E1000ERingInfo *r) } g_assert_not_reached(); - return 0; } static inline bool diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index bb8583c7ab..8aa8c46228 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -456,7 +456,6 @@ vmxnet3_setup_tx_offloads(VMXNET3State *s) default: g_assert_not_reached(); - return false; } return true; From patchwork Wed Sep 25 11:10:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830447 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp684981wrz; Wed, 25 Sep 2024 04:13:55 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXpfe0eYb89uME3Lh5ksGioIldooSSDEdzJtCppSWwMCBiw5GiFNWjms0CpR4sEmyIp30QlvQ==@linaro.org X-Google-Smtp-Source: AGHT+IGeEoavgdPDO6O6WCbdxJX/YvdRQ/aJiYxgYjUP3ILRDEwJDhmElEkH3tB9sEAk5pw+LCLo X-Received: by 2002:a05:620a:d8e:b0:7a9:be2f:651a with SMTP id af79cd13be357-7ace73e2becmr390117985a.2.1727262835401; Wed, 25 Sep 2024 04:13:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262835; cv=none; d=google.com; s=arc-20240605; b=QZaRJdmu4hjpIXPiHdiFZfLfZXAjhK2FE9IV2bZoBsRBbFk9U8v9MZ8yJxss/hvUhl rXNuh+jt6l8fJ6ekp2fTQ+kWQ91F4D1CwUfB+81hqVOORbp1avfvPU9QWL8DeHwSOEd/ kKxXiNI4fko+mKgqL6G4eZc9zxDOB4reBpf3/wDbiFM9zqQLC+3Lid+8p9uieuiVFAZ4 8FACM0r2ZRYYGjJU3GWqNLGVupsIh405ldWik4WgFKRmRSWeA4OIutrTnr4+QHtp2vou Su7gTrACspoObLR3Hc2lPAZhuKdX8FKiSzy4dJM5z76/+dHIXFzhvvIbtxT6CEEsnUA8 EDHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=8LsBFPRu54OFkPpjDHCv9iByYs2suDLcoK9INDup2jI=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=YKi+XRmbpStMcHO9JBwvMXhU/zTmaYDrG9n4Pc6fFfEiAr8aFR/NhVklr0Vm/UL2gm 3LtW1nwLoDm2kywriCoi5bV9o2uUz3Jj8j4LcnIalXT/gG5pgb+zSIeRQkREbnk0EmDk TocHlsFAzKuuX4Cn1Jismn6Q+MqrSK5UxHGnFs/T4CZcIpBQhoh4QhGdwwxeCNxR+u6U j0fVmqkXC0PTRvmX+JjdqMKJpDKtRJtikC2V6valLT4m75n72h9C3IztuKR2X77LQ1ku jz62TLSkApoheCCgrNd04zWnXKwxKrn+XRUJcTdwpMg0f0i+a0/2B6jLuFmht+qmHmpG qNpA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YxgrZbuv; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acde5cdc7csi375547185a.260.2024.09.25.04.13.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:13:55 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YxgrZbuv; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPxN-0000jG-Ab; Wed, 25 Sep 2024 07:13:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwM-00057h-Fi for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwK-0003tO-GT for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8LsBFPRu54OFkPpjDHCv9iByYs2suDLcoK9INDup2jI=; b=YxgrZbuvpfDPOI4QdCCSKCNDlQPQzY40UQWYdWincSLdxOwsZAy5ec1RXqkCJvqQ629zUm FTgBLdBD7qhjBbNXrwTbTT8UQS93pPl1ZhUWLwB5WxxiUB0HBK9NHkS3OwgcyThaUVJRZ5 VL0hQJJMNMRJYvUpTrQAd63cWUGxQLo= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-250-wwPKFfxKM6SpATKX0K3E6Q-1; Wed, 25 Sep 2024 07:12:10 -0400 X-MC-Unique: wwPKFfxKM6SpATKX0K3E6Q-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6E0CA193E8F5; Wed, 25 Sep 2024 11:12:09 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0F7931956094; Wed, 25 Sep 2024 11:12:06 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 36/44] hw/pci: remove return after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:17 +0200 Message-ID: <20240925111029.24082-37-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-29-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- hw/pci/pci-stub.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/pci/pci-stub.c b/hw/pci/pci-stub.c index c6950e21bd..3397d0c82e 100644 --- a/hw/pci/pci-stub.c +++ b/hw/pci/pci-stub.c @@ -47,13 +47,11 @@ void hmp_pcie_aer_inject_error(Monitor *mon, const QDict *qdict) MSIMessage pci_get_msi_message(PCIDevice *dev, int vector) { g_assert_not_reached(); - return (MSIMessage){}; } uint16_t pci_requester_id(PCIDevice *dev) { g_assert_not_reached(); - return 0; } /* Required by ahci.c */ From patchwork Wed Sep 25 11:10:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830468 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp686177wrz; Wed, 25 Sep 2024 04:16:35 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV6kRd21C5+AGWaWMTARHSJpxxNxDzCSUVBp0D9L6uffKD+2g7M9C2oulRfcEy+mJ4ZN8I3Pg==@linaro.org X-Google-Smtp-Source: AGHT+IEPuQu4rdLGi98Tfq2tTvepzgNKsF0vP5IFJCIaWEjIVjZIJCEK5QCDA5XM2bqlUb8dbL1O X-Received: by 2002:a05:622a:14c:b0:44f:f83d:469f with SMTP id d75a77b69052e-45b5dedea72mr28772911cf.14.1727262995580; Wed, 25 Sep 2024 04:16:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262995; cv=none; d=google.com; s=arc-20240605; b=fZVBvm8XBWtRPeCPz2ub+Lw0NkTSwi8972x2cNdTG8A0l3AX5T0ND97iZo6m+wRh2N iwP4Hp3fOc/Bj9lpy4pw9TnGni1+k/MKhgGWRpx7mfpdngQNtVwnYP2NgA+JpeRgAaNM bgezm8iFAIlW1YcVgQN/xrcf9Wpx9IDLRUXS5Vp1k89dGBwKFQ1Hdwa0ZDjkTZkxHNkb I2qsRUSQxsurWVce17F4OTNaps6WFnBKiDc8KNBfjNu/8c+cfUySkGfIAGWUE5y4pl9p ykBPfMCiMU4reoXJ/zJjb2t22cejLKow7AJ4nTPbsLohEEIbcD9dm8YvOvAoz1/OxQe6 hMNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/hiFZFF8hncyDRf8D3JNk/9vZTYM/dpbNvOPLfGO2Lc=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=I0joWERceWON+kR5PNYcp2nvPK4EMn11qR/4CORed7Bm0dhRSw1fYDZJF5kuC0ZUCU R9wwmIKUCk91ykKwGmQOzgCY/dp1kBI7Yq9wPysDJvP164OffCMNhO48xlB5ngihYTvZ F/1s3v7TlmUDKmB1NwHDe+nJkFfjyF1T/auMsj+2MhqRSxDZ1TiHJbMO+F2iIaq8AYcz bu9ORCeCvLI2ttH7yj8yfDbawissxYUKnbIZdcaBNVC8+JOMpeUQeO5M/1o4pk9W2AZ5 IoXk+IzLU5DZU7cN4dBsgMi8ZhjcTrY70/XODD3uZUXuup1c3WSsvgSaZx6JRia4dZby XDqg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="eo/iEryQ"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45b526fe17bsi35950101cf.583.2024.09.25.04.16.35 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:16:35 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="eo/iEryQ"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPxu-0004Jg-Dy; Wed, 25 Sep 2024 07:13:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwP-0005Lm-Dy for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwN-0003uQ-Vb for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/hiFZFF8hncyDRf8D3JNk/9vZTYM/dpbNvOPLfGO2Lc=; b=eo/iEryQbrDCCi+8X26dqThv51IIhJuELVXboKB847gst1xEYzPtEf0f//nNHSo59b6HbY IJfFk8FeedMf03LQs+tuNRnq2yZLdZDNbW5djfNH2zGBem8fSXIegmIVLtYmRRA/HsbNTu M5CJ2w7WBcuFjZweF7nh1nW76fElqGc= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-286-V0vj0oYUPJmBobGw0GdNCw-1; Wed, 25 Sep 2024 07:12:13 -0400 X-MC-Unique: V0vj0oYUPJmBobGw0GdNCw-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5E8471944D69; Wed, 25 Sep 2024 11:12:12 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5D9441956094; Wed, 25 Sep 2024 11:12:09 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 37/44] hw/ppc: remove return after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:18 +0200 Message-ID: <20240925111029.24082-38-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Cédric Le Goater Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-30-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- hw/ppc/ppc.c | 1 - hw/ppc/spapr_events.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/ppc/ppc.c b/hw/ppc/ppc.c index e6fa5580c0..fde4619412 100644 --- a/hw/ppc/ppc.c +++ b/hw/ppc/ppc.c @@ -267,7 +267,6 @@ static void power9_set_irq(void *opaque, int pin, int level) break; default: g_assert_not_reached(); - return; } } diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c index 38ac1cb786..4dbf8e2e2e 100644 --- a/hw/ppc/spapr_events.c +++ b/hw/ppc/spapr_events.c @@ -646,7 +646,6 @@ static void spapr_hotplug_req_event(uint8_t hp_id, uint8_t hp_action, * that don't support them */ g_assert_not_reached(); - return; } if (hp_id == RTAS_LOG_V6_HP_ID_DRC_COUNT) { From patchwork Wed Sep 25 11:10:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830460 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685427wrz; Wed, 25 Sep 2024 04:14:56 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCX7lZTICVvcLl/LCU6v1G7tytBphxFWImQoAq57Qc7ZsdI1rpnKJ5c0K2VH25+CyL0Wq7UOaw==@linaro.org X-Google-Smtp-Source: AGHT+IHJTfwB23mwPSShH+GY+r425krh4VzUncdd9uqHz+zHKfSCxbdxchD5db4d8U6aNAz53Ner X-Received: by 2002:a05:620a:2912:b0:79e:ffc6:c435 with SMTP id af79cd13be357-7ace746bcfamr334830085a.63.1727262896080; Wed, 25 Sep 2024 04:14:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262896; cv=none; d=google.com; s=arc-20240605; b=UqcpjzaAenMpx1U/sKWt2xydvWqVfAiCiTBIyUxl12/2tSRzV/dh25a3CFf++J9wOQ E5m+uH0I0pclRd6dvjWEuDiHM6mkVy3jMDttd+5MqIND1+CvndQsaj/q3kQ3Z6mTZNPb 5CSkH5rr3mahAY4l0MN34nxdZ7GPmmoiorIqXMkUx0VXbpFYPEOVvUDK0WksQZOda3ER Mkeg80G68ge472/WPmEPJF4Z2GKgp+umwTCAzSOkLZah0qSc9EOqCzL+hiImvnBBDJbB g21s+wSrmE1Jl1J5MhIIFQYvHitZVAGphXohkqIgRxQvSkDEyL6k6nVwRuCX+GKGU8Mk p3HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6/D/bPRFDYn7e9OOx5Rf9mgT3BrXmKOcHZORCuS7GII=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=D4XnyZ9hXYRM6toBRuZ0LCPrFlAa1sekElUFOe//dJfRCQozoP0IJcH9EPIjgR9sQe l9CEWaQqKGcj4ehynJ2pSAh/ZaOgv5irYcypsc9y41ch0aR/mSZoOOP1rbJnvtQn+YC1 8/NEDxU/bepBEmZJ4TKcPQepw58hgeMZVZFp1+vNdrQM+8XXQXFuE4h+VQ6MYj6wey3h o2AuEBcOqfmLCTmQzbqxWwcwNXoyZQFNFBixNfUh2jKpUUz+jnS01acdgeohiwpDnV5v hBWHM8gzeRtceiiIypWa4eILfZAcWX8Rg6UMMEkpYCak1yW82ePicOuT8rWfVzUSWFkR dz6g==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dtrY0VSV; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acde62e887si410629585a.563.2024.09.25.04.14.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:14:56 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dtrY0VSV; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPwf-0006Q4-Vx; Wed, 25 Sep 2024 07:12:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwT-0005hn-NW for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwS-0003wL-5P for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6/D/bPRFDYn7e9OOx5Rf9mgT3BrXmKOcHZORCuS7GII=; b=dtrY0VSVqP8+yYpERPiV5hShVGETuAKm2NNUaWwZiCzbUkfE2Vif2XaQk8/QnpH3w0tBcP Lrszx75D7orbyynM3Kc88UeaTjd+vGf9K29OyXlasdji5VaeXWVuMNpjj/R1iZ6oHW1igY VAbqphWIf61u5ddFpbCz6wzWXs2usAY= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-550-NYFunm4iMpC61fgE1iq5AQ-1; Wed, 25 Sep 2024 07:12:16 -0400 X-MC-Unique: NYFunm4iMpC61fgE1iq5AQ-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4A473193EF47; Wed, 25 Sep 2024 11:12:15 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 32739195609D; Wed, 25 Sep 2024 11:12:12 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 38/44] migration: remove return after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:19 +0200 Message-ID: <20240925111029.24082-39-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Signed-off-by: Pierrick Bouvier Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Message-ID: <20240919044641.386068-31-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- migration/dirtyrate.c | 1 - migration/postcopy-ram.c | 7 ------- migration/ram.c | 2 -- 3 files changed, 10 deletions(-) diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c index c03b13b624..5478d58de3 100644 --- a/migration/dirtyrate.c +++ b/migration/dirtyrate.c @@ -229,7 +229,6 @@ static int time_unit_to_power(TimeUnit time_unit) return -3; default: g_assert_not_reached(); - return 0; } } diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c index f431bbc0d4..0fe9d83d44 100644 --- a/migration/postcopy-ram.c +++ b/migration/postcopy-ram.c @@ -1412,40 +1412,34 @@ int postcopy_ram_incoming_init(MigrationIncomingState *mis) int postcopy_ram_incoming_cleanup(MigrationIncomingState *mis) { g_assert_not_reached(); - return -1; } int postcopy_ram_prepare_discard(MigrationIncomingState *mis) { g_assert_not_reached(); - return -1; } int postcopy_request_shared_page(struct PostCopyFD *pcfd, RAMBlock *rb, uint64_t client_addr, uint64_t rb_offset) { g_assert_not_reached(); - return -1; } int postcopy_ram_incoming_setup(MigrationIncomingState *mis) { g_assert_not_reached(); - return -1; } int postcopy_place_page(MigrationIncomingState *mis, void *host, void *from, RAMBlock *rb) { g_assert_not_reached(); - return -1; } int postcopy_place_page_zero(MigrationIncomingState *mis, void *host, RAMBlock *rb) { g_assert_not_reached(); - return -1; } int postcopy_wake_shared(struct PostCopyFD *pcfd, @@ -1453,7 +1447,6 @@ int postcopy_wake_shared(struct PostCopyFD *pcfd, RAMBlock *rb) { g_assert_not_reached(); - return -1; } #endif diff --git a/migration/ram.c b/migration/ram.c index 0aa5d34743..81eda2736a 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1766,13 +1766,11 @@ bool ram_write_tracking_available(void) bool ram_write_tracking_compatible(void) { g_assert_not_reached(); - return false; } int ram_write_tracking_start(void) { g_assert_not_reached(); - return -1; } void ram_write_tracking_stop(void) From patchwork Wed Sep 25 11:10:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830455 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685313wrz; Wed, 25 Sep 2024 04:14:41 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXuCWux0iBT/aDInH2tvr2T2zsgbMn9V/7pP6bMXDTrnxunWGyz4dzrHY2k1vlWI8sFtzVS9A==@linaro.org X-Google-Smtp-Source: AGHT+IFlCvh8exmdd5p0fRQX0VMZ0Qnm3D/ayY6YHntKxIuRkzkUSDD3f+UAvqobHfjF9Fq7aCUF X-Received: by 2002:a05:620a:1996:b0:7a9:a810:9930 with SMTP id af79cd13be357-7ace7402f62mr356079985a.23.1727262881280; Wed, 25 Sep 2024 04:14:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262881; cv=none; d=google.com; s=arc-20240605; b=gsipNN0ONrGBZ7qX8GDIFf1qnljoY+HejoHDbKFnK/BWD+Qsc7wIxuAHNBBahpkNPR 3FDR7CPPITOeT8SeROI0ilUKR7pajGUnf1289xG9zQs0TJLuTzj/6X5oZZKMq/DT2WIh 3vmCgrw/erLrPxQfHQb7q4XtR+tlrKMJ6ylSf1W0lZyGDDJszeDdrLfEXagooRF7w1BS XBNIo//uU9bpFaNjGG8LCJF6+heUBqZRyG71uy/It/+qqFquUnqz9GKoeCn+mldJGR1T DXuTEYdsdaBfTuxfs28k4OJszAdhAUUTm/h8m9eNa0uSLX3J/RUh7kb6dgAsRusNuAns S21g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Vyo/LNnRGhGjQKrTujAh2NlkCB5//86Ns8KFFI34pWI=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=QTv90WktdKsHuMnV8CqftBethqqgbzHUGYNPFQqiS7HQ+rMNCDABCMDKDm521nKvE0 pzxcFsPv9ZKeoFwcyL3cI2mK3uCApsjrEy3NhNDlKBiOSnt3i80SpJAuGwYU+8EEVle2 +eVxT9/qSoZYNzw8WRqe53UFnoplLbRDD4PiRailxUoiinoc64Wv95V8/m47zj3eFN7s qK6iXYVO02D2GmvkTohrPmzNsEoo55C013iyeIGej46EuoYKsXGthi9K0a+ryionq9n9 +zB7fAnVnIP5gQl2zbjXe8mwTke3w3WI0c6knzeie9IYWwdhBr5ntR8C2Rvvf8NXN+jy Z/Bw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UnvHQGl6; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acde646bf3si373801885a.725.2024.09.25.04.14.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:14:41 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UnvHQGl6; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPxi-0002qv-M1; Wed, 25 Sep 2024 07:13:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwX-0005yR-6T for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwV-0003xk-K9 for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vyo/LNnRGhGjQKrTujAh2NlkCB5//86Ns8KFFI34pWI=; b=UnvHQGl6cUnta7lbJ9H36jrEBQg7o0USmKJAuLVHXklGYnhkGRH+tOrYw7EAV84F4yRBEW 9oiV6gBS0VwV8tUgLznKLeZjN4LrG4CiN8R0tuO8EU6VqH8r2AiSHZpDpoa5z7tco8o7RQ S36utVO0nhLEGbccdo+9cKBSED5F7+4= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-639-B50DJvwZMZq296UnqNY2dQ-1; Wed, 25 Sep 2024 07:12:18 -0400 X-MC-Unique: B50DJvwZMZq296UnqNY2dQ-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8BBFC1977034; Wed, 25 Sep 2024 11:12:17 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AE74A1956094; Wed, 25 Sep 2024 11:12:15 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 39/44] qobject: remove return after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:20 +0200 Message-ID: <20240925111029.24082-40-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-32-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- qobject/qnum.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/qobject/qnum.c b/qobject/qnum.c index 2138b563a9..dd8ea49565 100644 --- a/qobject/qnum.c +++ b/qobject/qnum.c @@ -86,7 +86,6 @@ bool qnum_get_try_int(const QNum *qn, int64_t *val) } g_assert_not_reached(); - return false; } /** @@ -124,7 +123,6 @@ bool qnum_get_try_uint(const QNum *qn, uint64_t *val) } g_assert_not_reached(); - return false; } /** @@ -157,7 +155,6 @@ double qnum_get_double(QNum *qn) } g_assert_not_reached(); - return 0.0; } char *qnum_to_string(QNum *qn) @@ -173,7 +170,6 @@ char *qnum_to_string(QNum *qn) } g_assert_not_reached(); - return NULL; } /** From patchwork Wed Sep 25 11:10:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830458 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685409wrz; Wed, 25 Sep 2024 04:14:53 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXBlO62JgLy1VRY0QZ/AySx729QYqPD+VgMOTAjwDcEUbK1LPDTWAKkvjTICIhCCDC/5HBd3w==@linaro.org X-Google-Smtp-Source: AGHT+IFaSG5FdsV34XKUwD98OM2vpcmCtWgOR2Mqb7Tafmcze2qsqxl7ytHrg3nmkeRzhWmOiU/o X-Received: by 2002:a0c:f409:0:b0:6c5:acca:7105 with SMTP id 6a1803df08f44-6cb1dd91b3cmr37392896d6.26.1727262893506; Wed, 25 Sep 2024 04:14:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262893; cv=none; d=google.com; s=arc-20240605; b=RwHdZbNhxK4rh2wMsoWuTqGX21Wf2yCCJIlbvtPEo4a9y/vejU/0DnDJYYPUpbdEoD vqti78I4/2Kle6NagQXTKvE08Lc6qVcjFoUNk1Cni1ztWLeNO/ncQhFufR5oTrypYePE LW+Yx40VMmw+Ec9g/iaGKqGoVvSuus0WvCu421SEALJrBT2mmTIVvdawOVc6M7k/pWOy rJ5ySlYS5B5X2y6k5sgU2REKTKTDQbd/m0aaxj2qtOVrHKhC+Q0u5VQqP9wvWaCxq0VK hb1IZw1ewYFVymOWWcsCqCVphx0kIQQgmQueu+IWHQ50cIoH57yyQQqCBai/8J4WpQ6s bd+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Yz/orIHUEpC33CAjeYdFM5lmKKdA1H7fkZlK9jptMwc=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=KvMF1DimnxHX50ha1zHCoxUCvros9QeiW7avqz9kpsIyQjhn6cTnilpChFtLyGV9pB lsM+sXLXtRbo0c4dSzebQUt8ZE1i9QLBISN/lNHqUzAWalaAR2Sh3zhUA6uSSIMzfpJK KqlN+aY7r60bP3U1jO466ZvqYefql7W0MZU5ps11fOGNAQVH/RvWvThN+UMPP2HmDQ6h wmgpJz0/JmJe5mFwrsEJG+uk01TOJ9LEeZx6AO6LciGqk01NcmqSan0axgb0U2oabOKK G5gTPhfsM0SWYy1yOOrwWIAKuri+JsAopggF3cwbtM6fA1IBlP5uyJsTOpmguAnAkrVp 0dPw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MbRSAGgO; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6cb0f7da1a8si37262476d6.585.2024.09.25.04.14.53 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:14:53 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MbRSAGgO; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPxi-0002qm-MG; Wed, 25 Sep 2024 07:13:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwj-0006vH-Bj for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwW-0003xx-NM for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yz/orIHUEpC33CAjeYdFM5lmKKdA1H7fkZlK9jptMwc=; b=MbRSAGgOIvE7NoJHFI2FjJfVbZ0ZZanMIhXMpxY7M3klDZ41qOA9F6x62eO24w87PBcwdI JV0+qrGCg2LDD2t9JJAByr3mJlyaHZQyRCJlsRVaJhznv9IKHy1R0x5genvTZ4KUDYVjhD 7WgIUH/M2EZ58aOxg1oDUN3p7NaVWMg= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-691-KZhDlXreMsuI-hGin3VNWQ-1; Wed, 25 Sep 2024 07:12:20 -0400 X-MC-Unique: KZhDlXreMsuI-hGin3VNWQ-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B6BD119772E3; Wed, 25 Sep 2024 11:12:19 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 27E211956094; Wed, 25 Sep 2024 11:12:17 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 40/44] qom: remove return after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:21 +0200 Message-ID: <20240925111029.24082-41-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-33-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- qom/object.c | 1 - 1 file changed, 1 deletion(-) diff --git a/qom/object.c b/qom/object.c index 157a45c5f8..28c5b66eab 100644 --- a/qom/object.c +++ b/qom/object.c @@ -2079,7 +2079,6 @@ const char *object_get_canonical_path_component(const Object *obj) /* obj had a parent but was not a child, should never happen */ g_assert_not_reached(); - return NULL; } char *object_get_canonical_path(const Object *obj) From patchwork Wed Sep 25 11:10:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830459 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685423wrz; Wed, 25 Sep 2024 04:14:55 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWN8L48a111OFd3SITdX2BQxqPxhvbWaZguhGcYmV0jw5I4/aOvvJlC4Bswiz1Rl6djcPuCiA==@linaro.org X-Google-Smtp-Source: AGHT+IFMMl4Sxj5bmK0LrykOOkB5nB73gjhGBTy+I0adkUdmAx4BFlb4be9ZprwSOPCI7DYE2HIS X-Received: by 2002:ac8:5a87:0:b0:45b:c1f:3c18 with SMTP id d75a77b69052e-45b5e0ac32dmr37566721cf.60.1727262895628; Wed, 25 Sep 2024 04:14:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262895; cv=none; d=google.com; s=arc-20240605; b=dr9zBc8/ply6H8Loq6zSvFeL3IxqrS/zRJ7EZiIbPha9dar9S985qBxplfHGfbhBGQ lmSOw+yS5nSW6m66I4WL+pnQpda7xoSIsXv/XsMFXMyarQGhD562LO3wJ39e6DNGCAud 6PqkhoBfiVxW8SAkxwOt/BeTghHBSDN3RkhnGUuaySi/0CkDie/5j39Qkiu3h3tglnHQ vmd3ErAVxV5KePEFYwxzr1pUKxwsjD58g3xotJsWmAAacslJHQVirOE3QJFxH7Ks1cpD GzHTK272/8IIFeAi1JN87vGnUhzyLgQCPBbkalwXiUc9XSB4lMxdtcJVUDvxSw0IyTEt kQ2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Dmlz5z2+pOjtZz7qqBFHvrDUfQCdpfEWoNqDV06zcG4=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=VFVoCHWmIQntlcsW9srA0umZwL9x2EoEZHykZAsgf8ladiLiXGEN7Ksiw/JvNyEqe1 1QSJ2E5nrU3SnMtgQAPm95YLhAvXXaTZcpQ/FB7Q8MQ1iPAO/OVkvzsLoK5nF9KSgEhv Da3JIoWOVr/G0kaPXr+cizU/coLTzBuI57eBRWELAOyVt1LcgpOlbU8YDXmcC7lEn1Xo j/G3BuXn4bueR2hpZDrUIR1hxtpNT+J1UqZ8Nz9hWsUjvSPoO/JYajzWwWvEJxOzRRPK qv/fn9MmvUkzkQUneQ8F0l+mbq0eZCUF0yTR/YoRb6GsIpR9BQNEHQhoPxWLL0SK8UxT 8Ldw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PfTjiic6; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45b5256f56bsi35412711cf.52.2024.09.25.04.14.55 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:14:55 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PfTjiic6; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPxw-0004h9-Vo; Wed, 25 Sep 2024 07:13:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwb-0006Ka-6L for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwY-0003yO-ND for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Dmlz5z2+pOjtZz7qqBFHvrDUfQCdpfEWoNqDV06zcG4=; b=PfTjiic6uCQ72d+k3YtPk54fdmVOQqp/KmLfZHR7lt2kyFhnRPIN4/hTICu6CZSlrKMliQ hcEfQ9dEeTwsfaKwMUxAAjy5plpHHphGNgZ5xHmTwiX4x4KLBBio95BRoaFb9ItAS4Q7Xd 9kQPHKYclFflyn6YQnL8JHMv2uPqKD4= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-173-drK5T_0bOpmwOAa4dYIE2Q-1; Wed, 25 Sep 2024 07:12:22 -0400 X-MC-Unique: drK5T_0bOpmwOAa4dYIE2Q-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E80CD1944D69; Wed, 25 Sep 2024 11:12:21 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6776D1956094; Wed, 25 Sep 2024 11:12:20 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 41/44] tests/qtest: remove return after g_assert_not_reached() Date: Wed, 25 Sep 2024 13:10:22 +0200 Message-ID: <20240925111029.24082-42-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-34-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- tests/qtest/acpi-utils.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qtest/acpi-utils.c b/tests/qtest/acpi-utils.c index 673fc97586..9dc24fbe5a 100644 --- a/tests/qtest/acpi-utils.c +++ b/tests/qtest/acpi-utils.c @@ -156,5 +156,4 @@ uint64_t acpi_find_rsdp_address_uefi(QTestState *qts, uint64_t start, g_usleep(TEST_DELAY); } g_assert_not_reached(); - return 0; } From patchwork Wed Sep 25 11:10:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830466 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp686082wrz; Wed, 25 Sep 2024 04:16:23 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXffhMgwjlrBSEL0cuQwRvteIS9g26KKoF7R6CFmSF9P55BX8Hp8jkFHIUt/CBYi5qEijhyzQ==@linaro.org X-Google-Smtp-Source: AGHT+IHubY3+aYXG2SppZhQfXDyCvA67K6WbJ3OhH7GCSF3yUb8Fr0AMrBzTiJeg7NPqXWXWS59q X-Received: by 2002:ad4:576a:0:b0:6c3:62e5:b416 with SMTP id 6a1803df08f44-6ca8d2ee2f2mr95912266d6.10.1727262982816; Wed, 25 Sep 2024 04:16:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262982; cv=none; d=google.com; s=arc-20240605; b=aRdxxpaNCgjZBhJKhipldIYCh0XBxlu9lttxBh1jljGckJXbBt9CzsXRNl2Yw/2ZK3 M4Jt7RTvEeto0qrzahO2dz8OYD1t2FQ/ULaadJbSbDUuvnnW+NBziL5/EpZIYN+89Y03 0DgAn5KQweBuNj0kCweJOHZ/PmQG31gLasCQFtKj35HJR/z7d88LAN9xTYWS3F4cfJoQ Er+T0H0OLC6wDydmFkyKos60vbYeQdI8cDE+nLM3TEoG7MOblu1Rm3CObwBFPHYQ1Vqj A+3u4gY2nT/oLfUjQjIKmpDrbLSDdPlV8qxgDxSItn/1lsJ5HsvNhmmXiN6EqoqI65Ix 1QVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=htGtxccsCyLJzJw3INxtPFKpLYjofSjahFL8NefGrrs=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=e6Z/twDfaeUaP38v8fwoWa+sZonxnvC0ejyxajmd8X+UveEYprdbK+ARrNG5Afz99Q wM3SAhq/4vjiifn8DyoA1Plv9gAZqjgwcB3Pjc9fJqakiT2RcdoENFmS9Afh8bSmPTV0 qvxLRqhfFsKse0By+rCkdeuAQoTIpzo7JQvIhwtpcMQgP6cIL3gl6GQ52V589kXZWDOK BvXzNyS5D15sG8LEm8hZQaehG8RPOsInCOtnjKANYK6LrLF12QbGXi5YnQWlnXhH9l9T 1y+igsCH/oYT0uZqU1O/l1rrWgjDUWFzQNwlit4vuuTgsQa6L5XNz6cflBJHZFlK9T20 Qqow==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=G9Z+Ssig; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6cb0f4e99b1si37324586d6.166.2024.09.25.04.16.22 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:16:22 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=G9Z+Ssig; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPy0-0005EP-Oz; Wed, 25 Sep 2024 07:13:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwe-0006ah-6J for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwb-000402-Hb for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=htGtxccsCyLJzJw3INxtPFKpLYjofSjahFL8NefGrrs=; b=G9Z+SsigBXA1/MPivInHic2l/XM4qqj83PG/I7Tts66myKZUuuf//lS+vFNSIsz62r0oiz dkBlRZJsmawyeeE6kxXjTY0iW1A2qrjzhQnpLvOKxuzDd7JvGMosa0ZfuRORPRr6/ntU4d vQLJ9VMa443SVsXMNeMLoQb+P9MolI4= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-joDpd0owP4eGgj2l8crWzg-1; Wed, 25 Sep 2024 07:12:25 -0400 X-MC-Unique: joDpd0owP4eGgj2l8crWzg-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 816AD1955E75; Wed, 25 Sep 2024 11:12:24 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9D2041956094; Wed, 25 Sep 2024 11:12:22 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 42/44] scripts/checkpatch.pl: emit error when using assert(false) Date: Wed, 25 Sep 2024 13:10:23 +0200 Message-ID: <20240925111029.24082-43-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-35-pierrick.bouvier@linaro.org> [thuth: Split long line to avoid checkpatch error] Signed-off-by: Thomas Huth --- scripts/checkpatch.pl | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 65b6f46f90..1b21249c91 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3102,6 +3102,10 @@ sub process { if ($line =~ /\b(g_)?assert\(0\)/) { ERROR("use g_assert_not_reached() instead of assert(0)\n" . $herecurr); } + if ($line =~ /\b(g_)?assert\(false\)/) { + ERROR("use g_assert_not_reached() instead of assert(false)\n" . + $herecurr); + } if ($line =~ /\bstrerrorname_np\(/) { ERROR("use strerror() instead of strerrorname_np()\n" . $herecurr); } From patchwork Wed Sep 25 11:10:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830464 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp686052wrz; Wed, 25 Sep 2024 04:16:20 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUC7uf45s7SDmWYekst6dyPxHDn/cHw/4P0mG1PRcvibRPpPlYQSwQmB0ZYmavwHW2c27UuaQ==@linaro.org X-Google-Smtp-Source: AGHT+IFIEw1VBhgLoij0zkuXZju00C+3MN5vydjtEKALIiSzZxu9xiQiHb/3qwP0uEfHvQpyy7Id X-Received: by 2002:a05:622a:1a23:b0:457:9b12:2297 with SMTP id d75a77b69052e-45b5df1c38fmr33395361cf.35.1727262980578; Wed, 25 Sep 2024 04:16:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262980; cv=none; d=google.com; s=arc-20240605; b=C1IQp/aweZuXZAVTzspxS5Eda2Vs9w4JU+HxrAChcGDAEgo3/WtfBPOElfEKLqxtrM TbktjK9wyza3MTZ4+Ii8P7EDchrnMa0mpA4jTWN/3I8h7DFPTO1JzJH17m25sOC6ZkEo 6gnUfuqDQDf9yVyf9PdXEYWuB7mJHMvR4kwwdf576cef0lo1fR/d0OtHlKoov4JdwAoj 7HbPTTLQQczM8d7yFNknB1reKoGpdPHa0Gr24xgoix6xGJK8G+gBRN9GC4AVx6iPKt8q Kh/qONFH7iUBQxz64cD4QvDGppLd6ZC9ObNx2tIihFfVWR1iOA7mOhXIThH2GNQaOJsy CAeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=mnhOt4A+tUtlf00Ic65PLK009/y0PlsO2AKKzYEyQmE=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=DRDWA+oEyl+gTtiqxZDVGqntmV4RHOd0fMj8k5J1Db8Gi55yxEQ1IYLaXVTj/SjB49 E8MD50VJ0sy46y+m5aXdWBwuaBz88Llfon5g3BJfqCRpcH2iqAFQbp7lbxpqXJEz9rIn ceQegdUnFCizpo9yvkT45Cq7WUya+ojP2gVRnzHrFId0zPDOH5z7CAiPOz6tT6aYhaEg tzFApy0H1u6/roZAQ3Yw7BSvD5Tnq8tYHF4kW0xNYBOgomtT8VEFItqAX8s+IuVna2kM eEZUVJeeVTXHPydm/p7w3SGLnJZqk+N4METfQZN8o14XOlQ3B8smd7+BZQm6vLf8Ps5e 91qA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FW4Zubky; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45b526849easi35133031cf.354.2024.09.25.04.16.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:16:20 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FW4Zubky; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPxp-0003fx-D1; Wed, 25 Sep 2024 07:13:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwf-0006gE-Kz for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwd-00040q-UY for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262750; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mnhOt4A+tUtlf00Ic65PLK009/y0PlsO2AKKzYEyQmE=; b=FW4ZubkyVexbbjSd6pRROpWiYJDbcdzSKgX/LWM0e+GzTuzOYmLCwVz03lqDSGxKhftfkS I2alLeLUD5hoSjOQxL5ltfM/ykexoCsKTl0/hma8i7k1znZHopbAAaomHzhFr4elKjl7vn Wd8qUpgQkopUHHHvkJ7zn2BVTO/mTFc= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-655-s5A0gX_2OryNHjlTTnehCw-1; Wed, 25 Sep 2024 07:12:28 -0400 X-MC-Unique: s5A0gX_2OryNHjlTTnehCw-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 113991955E75; Wed, 25 Sep 2024 11:12:27 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 395101956094; Wed, 25 Sep 2024 11:12:24 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 43/44] .gitlab-ci.d: Split build and test in cross build job templates Date: Wed, 25 Sep 2024 13:10:24 +0200 Message-ID: <20240925111029.24082-44-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Peter Maydell In the native_build_job_template we have separate steps in the script for the build and the test steps. This is helpful because then gitlab will give separate timestamps in the log view for each, and you can see how long it took to compile vs how long to test. In the templates in crossbuild-template.yml, however, we do both the build and test in a single 'make' invocation, and so we don't get the separate timing information. Split the build and test, in the same way we do in the native build template. This will also give us a place to separate out how parallel we want to do the build by default from how parallel we want to do the tests by default, which might be helpful in future. Signed-off-by: Peter Maydell Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Message-ID: <20240918125449.3125571-2-peter.maydell@linaro.org> Signed-off-by: Thomas Huth --- .gitlab-ci.d/crossbuild-template.yml | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/.gitlab-ci.d/crossbuild-template.yml b/.gitlab-ci.d/crossbuild-template.yml index 2ce0432eb7..d1cb7a35db 100644 --- a/.gitlab-ci.d/crossbuild-template.yml +++ b/.gitlab-ci.d/crossbuild-template.yml @@ -9,6 +9,7 @@ when: always timeout: 80m before_script: + - JOBS=$(expr $(nproc) + 1) - cat /packages.txt script: - export CCACHE_BASEDIR="$(pwd)" @@ -24,7 +25,11 @@ i386-softmmu microblaze-softmmu mips-softmmu mipsel-softmmu mips64-softmmu ppc-softmmu riscv32-softmmu sh4-softmmu sparc-softmmu xtensa-softmmu $CROSS_SKIP_TARGETS" - - make -j$(expr $(nproc) + 1) all check-build $MAKE_CHECK_ARGS + - make -j"$JOBS" all check-build + - if test -n "$MAKE_CHECK_ARGS"; + then + $MAKE -j"$JOBS" $MAKE_CHECK_ARGS ; + fi - if grep -q "EXESUF=.exe" config-host.mak; then make installer; version="$(git describe --match v[0-9]* 2>/dev/null || git rev-parse --short HEAD)"; @@ -46,6 +51,8 @@ paths: - ccache/ key: "$CI_JOB_NAME" + before_script: + - JOBS=$(expr $(nproc) + 1) script: - export CCACHE_BASEDIR="$(pwd)" - export CCACHE_DIR="$CCACHE_BASEDIR/ccache" @@ -55,7 +62,11 @@ - cd build - ../configure --enable-werror --disable-docs $QEMU_CONFIGURE_OPTS --disable-tools --enable-${ACCEL:-kvm} $EXTRA_CONFIGURE_OPTS - - make -j$(expr $(nproc) + 1) all check-build $MAKE_CHECK_ARGS + - make -j"$JOBS" all check-build + - if test -n "$MAKE_CHECK_ARGS"; + then + $MAKE -j"$JOBS" $MAKE_CHECK_ARGS ; + fi .cross_user_build_job: extends: .base_job_template @@ -65,6 +76,8 @@ paths: - ccache/ key: "$CI_JOB_NAME" + before_script: + - JOBS=$(expr $(nproc) + 1) script: - export CCACHE_BASEDIR="$(pwd)" - export CCACHE_DIR="$CCACHE_BASEDIR/ccache" @@ -76,7 +89,11 @@ alpha-linux-user m68k-linux-user microblazeel-linux-user or1k-linux-user ppc-linux-user sparc-linux-user xtensa-linux-user $CROSS_SKIP_TARGETS" - - make -j$(expr $(nproc) + 1) all check-build $MAKE_CHECK_ARGS + - make -j"$JOBS" all check-build + - if test -n "$MAKE_CHECK_ARGS"; + then + $MAKE -j"$JOBS" $MAKE_CHECK_ARGS ; + fi # We can still run some tests on some of our cross build jobs. They can add this # template to their extends to save the build logs and test results From patchwork Wed Sep 25 11:10:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830452 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685176wrz; Wed, 25 Sep 2024 04:14:22 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWn6j1T74IP+XnTqB1O3mwrIRG3wb2Pf6Enh2zlpaVHmXvnwRUBRgsh1+CBy3n9Tv2GK+yofQ==@linaro.org X-Google-Smtp-Source: AGHT+IFYcntwSGjPt4307So6GFuRMlsaxEiqVtEJF66sPYCcg8r0qsMTa00dGGHlsg6E2ufKYA4X X-Received: by 2002:a05:620a:4105:b0:79f:b3d:bed1 with SMTP id af79cd13be357-7ace744d5d3mr398929485a.49.1727262862153; Wed, 25 Sep 2024 04:14:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262862; cv=none; d=google.com; s=arc-20240605; b=cDHnzRZCHPmzWswX5aPdJxtwMN/os62lDOMOVMO9sNbdMHr0WcS+tO+gq8BM7+d+Fk aW3EXZMpjLsGz6bMar2HXrbTGFZBY+pyebf6xc0LH/tNimP/piaLfFXYiP9Pz9URDlwp gP5QE9e7UAUXtY5oVGPS/7SxrSLxH/ktGJadHuXdI4TEZDDl89QhlPjyaRIRM1dcjQG4 YRXyhePE48l6YCNgFj5IkUV7LkNPav5PMsQt4K00iGdgEyhrL1pbOWXJ1Mqr+PA1MHqS QAV/7Y2ZAySSZIPIkJo/DmmK3hJ11J5mmiZz5uAKGjdKwBmIwozpnfWJuZxv37OdrqPV b6KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=UwWnn7F0IA8668O/RtqUw3SrdoOv+JBapXUjElCJD7U=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=kajQAChWtHLBr/2yDE5NJIsMGJCFOgaJQ0/9bWKMTksL2LEQLlfwcicV3K9A6l+lOA 4B0/iZpRTHTr0+8/pP2SRKtMNoxz41jZhT4hq9CTON7gRbK6pAMIajF7TDww52NUKtnA U4JJ4UPRnEiDRM3OUFgUgMuFD7ud8kEs6EtQiqKfCcULFJx4YH/zFBMuj6TH55eXabt8 cNe//DpkI6JnjPZhYRvzuYns6X/UfyBUeyr2C9Yj/VjLUn1MwyHTxVOqiO6OUHsoROYJ 5EB+mA2bWpyuHBUP3UEujp9x1fnGqhaTn1EScgogiV+Tz+EHkKfOcDzmJja9qbbB3nRQ 9NwQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=b8FO9+Sg; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7acde60b7c8si366831385a.472.2024.09.25.04.14.21 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:14:22 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=b8FO9+Sg; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPyB-00067l-OC; Wed, 25 Sep 2024 07:14:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwi-0006tf-Tk for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwg-00042R-Ra for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UwWnn7F0IA8668O/RtqUw3SrdoOv+JBapXUjElCJD7U=; b=b8FO9+Sgs4rUHecM32SCbiQlofPj+cs8QDF4TyMKhkQUyDqaXwjjFUtMUTyZv0YBlyIww5 hR65a+vez1RzwRYyL82epJg3JQy06KLyhKJA0n4W/yxhwSytnLw+hLNW677emWLpJpxDZl Etn6MW357NLRR1ds4ZNjTh8AWR9mkCM= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-25-bIjS_JP6OrKnqZHEVMq5cQ-1; Wed, 25 Sep 2024 07:12:31 -0400 X-MC-Unique: bIjS_JP6OrKnqZHEVMq5cQ-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1BFDE19772E6; Wed, 25 Sep 2024 11:12:30 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BF4591956094; Wed, 25 Sep 2024 11:12:27 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 44/44] .gitlab-ci.d: Make separate collapsible log sections for build and test Date: Wed, 25 Sep 2024 13:10:25 +0200 Message-ID: <20240925111029.24082-45-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Peter Maydell GitLab lets a CI job create its own collapsible log sections by emitting special escape codes, as documented here: https://docs.gitlab.com/ee/ci/yaml/script.html#expand-and-collapse-job-log-sections Use these to make "configure", "build" and "test" separate collapsible stages. As recommended by the GitLab docs, we use some shell which is sourced in the CI job to define functions to emit the magic lines that start and end sections, to hide the ugliness of the printf lines from the log. Signed-off-by: Peter Maydell Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Message-ID: <20240918125449.3125571-3-peter.maydell@linaro.org> Signed-off-by: Thomas Huth --- .gitlab-ci.d/buildtest-template.yml | 14 ++++++++++++++ .gitlab-ci.d/buildtest.yml | 1 + .gitlab-ci.d/crossbuild-template.yml | 25 ++++++++++++++++++++++++ scripts/ci/gitlab-ci-section | 29 ++++++++++++++++++++++++++++ 4 files changed, 69 insertions(+) create mode 100644 scripts/ci/gitlab-ci-section diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-template.yml index 5f2fc7e6f4..8c69c60d21 100644 --- a/.gitlab-ci.d/buildtest-template.yml +++ b/.gitlab-ci.d/buildtest-template.yml @@ -8,8 +8,11 @@ key: "$CI_JOB_NAME" when: always before_script: + - source scripts/ci/gitlab-ci-section + - section_start setup "Pre-script setup" - JOBS=$(expr $(nproc) + 1) - cat /packages.txt + - section_end setup script: - export CCACHE_BASEDIR="$(pwd)" - export CCACHE_DIR="$CCACHE_BASEDIR/ccache" @@ -19,6 +22,7 @@ - mkdir build - cd build - ccache --zero-stats + - section_start configure "Running configure" - ../configure --enable-werror --disable-docs --enable-fdt=system ${TARGETS:+--target-list="$TARGETS"} $CONFIGURE_ARGS || @@ -27,11 +31,16 @@ then pyvenv/bin/meson configure . -Dbackend_max_links="$LD_JOBS" ; fi || exit 1; + - section_end configure + - section_start build "Building QEMU" - $MAKE -j"$JOBS" + - section_end build + - section_start test "Running tests" - if test -n "$MAKE_CHECK_ARGS"; then $MAKE -j"$JOBS" $MAKE_CHECK_ARGS ; fi + - section_end test - ccache --show-stats # We jump some hoops in common_test_job_template to avoid @@ -54,6 +63,8 @@ stage: test image: $CI_REGISTRY_IMAGE/qemu/$IMAGE:$QEMU_CI_CONTAINER_TAG script: + - source scripts/ci/gitlab-ci-section + - section_start buildenv "Setting up to run tests" - scripts/git-submodule.sh update roms/SLOF - meson subprojects download $(cd build/subprojects && echo *) - cd build @@ -63,7 +74,10 @@ - if [ "x${QEMU_TEST_CACHE_DIR}" != "x" ]; then $MAKE precache-functional ; fi + - section_end buildenv + - section_start test "Running tests" - $MAKE NINJA=":" $MAKE_CHECK_ARGS + - section_end test .native_test_job_template: extends: .common_test_job_template diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index 2ab8c4806e..87848c2ffe 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -188,6 +188,7 @@ build-previous-qemu: # Override the default flags as we need more to grab the old version GIT_FETCH_EXTRA_FLAGS: --prune --quiet before_script: + - source scripts/ci/gitlab-ci-section - export QEMU_PREV_VERSION="$(sed 's/\([0-9.]*\)\.[0-9]*/v\1.0/' VERSION)" - git remote add upstream https://gitlab.com/qemu-project/qemu - git fetch upstream refs/tags/$QEMU_PREV_VERSION:refs/tags/$QEMU_PREV_VERSION diff --git a/.gitlab-ci.d/crossbuild-template.yml b/.gitlab-ci.d/crossbuild-template.yml index d1cb7a35db..45a9810355 100644 --- a/.gitlab-ci.d/crossbuild-template.yml +++ b/.gitlab-ci.d/crossbuild-template.yml @@ -9,8 +9,11 @@ when: always timeout: 80m before_script: + - source scripts/ci/gitlab-ci-section + - section_start setup "Pre-script setup" - JOBS=$(expr $(nproc) + 1) - cat /packages.txt + - section_end setup script: - export CCACHE_BASEDIR="$(pwd)" - export CCACHE_DIR="$CCACHE_BASEDIR/ccache" @@ -19,22 +22,30 @@ - mkdir build - cd build - ccache --zero-stats + - section_start configure "Running configure" - ../configure --enable-werror --disable-docs --enable-fdt=system --disable-user $QEMU_CONFIGURE_OPTS $EXTRA_CONFIGURE_OPTS --target-list-exclude="arm-softmmu i386-softmmu microblaze-softmmu mips-softmmu mipsel-softmmu mips64-softmmu ppc-softmmu riscv32-softmmu sh4-softmmu sparc-softmmu xtensa-softmmu $CROSS_SKIP_TARGETS" + - section_end configure + - section_start build "Building QEMU" - make -j"$JOBS" all check-build + - section_end build + - section_start test "Running tests" - if test -n "$MAKE_CHECK_ARGS"; then $MAKE -j"$JOBS" $MAKE_CHECK_ARGS ; fi + - section_end test + - section_start installer "Building the installer" - if grep -q "EXESUF=.exe" config-host.mak; then make installer; version="$(git describe --match v[0-9]* 2>/dev/null || git rev-parse --short HEAD)"; mv -v qemu-setup*.exe qemu-setup-${version}.exe; fi + - section_end installer - ccache --show-stats # Job to cross-build specific accelerators. @@ -52,6 +63,7 @@ - ccache/ key: "$CI_JOB_NAME" before_script: + - source scripts/ci/gitlab-ci-section - JOBS=$(expr $(nproc) + 1) script: - export CCACHE_BASEDIR="$(pwd)" @@ -60,13 +72,19 @@ - export PATH="$CCACHE_WRAPPERSDIR:$PATH" - mkdir build - cd build + - section_start configure "Running configure" - ../configure --enable-werror --disable-docs $QEMU_CONFIGURE_OPTS --disable-tools --enable-${ACCEL:-kvm} $EXTRA_CONFIGURE_OPTS + - section_end configure + - section_start build "Building QEMU" - make -j"$JOBS" all check-build + - section_end build + - section_start test "Running tests" - if test -n "$MAKE_CHECK_ARGS"; then $MAKE -j"$JOBS" $MAKE_CHECK_ARGS ; fi + - section_end test .cross_user_build_job: extends: .base_job_template @@ -77,6 +95,7 @@ - ccache/ key: "$CI_JOB_NAME" before_script: + - source scripts/ci/gitlab-ci-section - JOBS=$(expr $(nproc) + 1) script: - export CCACHE_BASEDIR="$(pwd)" @@ -84,16 +103,22 @@ - export CCACHE_MAXSIZE="500M" - mkdir build - cd build + - section_start configure "Running configure" - ../configure --enable-werror --disable-docs $QEMU_CONFIGURE_OPTS --disable-system --target-list-exclude="aarch64_be-linux-user alpha-linux-user m68k-linux-user microblazeel-linux-user or1k-linux-user ppc-linux-user sparc-linux-user xtensa-linux-user $CROSS_SKIP_TARGETS" + - section_end configure + - section_start build "Building QEMU" - make -j"$JOBS" all check-build + - section_end build + - section_start test "Running tests" - if test -n "$MAKE_CHECK_ARGS"; then $MAKE -j"$JOBS" $MAKE_CHECK_ARGS ; fi + - section_end test # We can still run some tests on some of our cross build jobs. They can add this # template to their extends to save the build logs and test results diff --git a/scripts/ci/gitlab-ci-section b/scripts/ci/gitlab-ci-section new file mode 100644 index 0000000000..9bbe80420d --- /dev/null +++ b/scripts/ci/gitlab-ci-section @@ -0,0 +1,29 @@ +# Copyright (c) 2024 Linaro Ltd +# SPDX-License-Identifier: GPL-2.0-or-later + +# gitlab-ci-section: This is a shell script fragment which defines +# functions section_start and section_end which will emit marker lines +# that GitLab will interpret as the beginning or end of a "collapsible +# section" in a CI job log. See +# https://docs.gitlab.com/ee/ci/yaml/script.html#expand-and-collapse-job-log-sections +# +# This is intended to be sourced in the before_script section of +# a CI config; the section_start and section_end functions will +# then be available for use in the before_script and script sections. + +# Section names are [-_.A-Za-z0-9] and the section_start pairs with +# a section_end with the same section name. +# The description can be any printable text without newlines; this is +# what will appear in the log. + +# Usage: +# section_start section_name "Description of the section" +section_start () { + printf "section_start:%s:%s\r\e[0K%s\n" "$(date +%s)" "$1" "$2" +} + +# Usage: +# section_end section_name +section_end () { + printf "section_end:%s:%s\r\e[0K\n" "$(date +%s)" "$1" +}