From patchwork Mon Oct 7 23:36:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 833359 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6382191F8C for ; Mon, 7 Oct 2024 23:37:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728344231; cv=none; b=uVsPqhA44/j1hkFK9NoDW3rljUn+YjlKMO8xKzBXaCltbDwB695cSdhJVxItCIXf0OavOdnR5cuajU9B9ktjpIM/TLNOAJZI3PC5/ZzloL94ZPi8lSRR7X0ZfeJc6usmdAulJI9CXFgA7jBiJ3MOPVhX7TnETU0rShdnPoCQq/M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728344231; c=relaxed/simple; bh=YQocvzYtQugoKxgD8nHuIxgQRJHdd9/v/IZp+pC+8dE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dGFN2y5EcpOZrmhOUi/yP9HqBIEeYjP84N/ZGufnRuqbnGiT6/v29fofLfZR5mqIkDEytji6p/DRZkqX0Y0ToaQXVKd7/Yenm6mAPqSua8MZ+Rtm6nHVOsFK2v1ElGlH7g78AKUytG+Hu/tcQm41nQibgo6K00J/i1IoWnI57y0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gwQnu9Ks; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gwQnu9Ks" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-539885dd4bcso6189597e87.0 for ; Mon, 07 Oct 2024 16:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728344228; x=1728949028; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CQLfPZ1C+8kI9P19huvG/Kxk4mb+t0/CSSYBX15+NYM=; b=gwQnu9Ksa+XsBCX4oLTowk5M8ZXVlKwBgXwB3yzbnOIsuwcyY3pZel+53uwvgp/h+7 3FQth4C/MVPbUBTDxkDwUdw1SBzH2Y6GiSd7PEtiaNPqX5iipAXP5FDpp0eJhJh0uHEk cYEOXWpbvuC8ZZa05yynHK16qPXItkOYoeUDSrcuiuBLd+t/v/Z6QkTkdryosU7o3TRF R9xQ3ZHoxcU/jDYnEN62rYTXnNMInLA1rRl6AkYCIe+CnO+AWGAlgb+Dm7khFWQAsHCn PKcPG3GSPKEwwttAQfl+ZkvmNboZkLNBJD+HaLJCHu+/AIISVCXrUHSvjE0oFEkfQo0B TvNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728344228; x=1728949028; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CQLfPZ1C+8kI9P19huvG/Kxk4mb+t0/CSSYBX15+NYM=; b=C8KGtO9aSDvMYbLONHr0FhLDBnPnTn51QLmBZusnUfuwAaHWUGw/W+zWyaMU9etNUI oh65mVDvVre00L24aJsGIUt/M51P6AktHL3PjHBQq3envfEZLkf4FsAeoovsxX4ieSWI v1yyU6vpLUH25afDWv9dMzJLcia1RaEjJ8h1paYdC0Me3NwAqoOl9am7jvVVf0KdpyPJ z+JtINnp5IA8Ry0uHmXOwU8LXYY6/w5ZNUrj6hhJwAiVNQya95FPqfXO4F5QxIHuEDXr G3D51NVZTPFJzGKVPdq4eufk6PhfFZNdPwbNzZ3oYh179R5MaVZkEJcNz++Ty9W5QjuX r7GA== X-Forwarded-Encrypted: i=1; AJvYcCV4izO1HbvCLEQQniMMQJuKMEHdoHEQbLg36Sx0mP1zDLCB15yq+CVCKwutJ46wx3mlD+LJikWua0AMXf0i@vger.kernel.org X-Gm-Message-State: AOJu0YzM4l1zEb6uzJHqKg6LcPFCUjAHjHIx2z/0WA1kUuW7I1gIMnaI o9JtG3flwzrRfWbyT/1P3oPgNXav4tgeBORjokIw4khPodCjiwoTUwzqDBYGULo= X-Google-Smtp-Source: AGHT+IHAafBH9iXxZ06NKjJKiojqYjIYWAGrzT88XaX5aKORPvqqhBENvj5aMrFvDMFNdGahwiqgLQ== X-Received: by 2002:a05:6512:3ba6:b0:52c:d645:eda7 with SMTP id 2adb3069b0e04-539ab87712emr7373147e87.18.1728344227991; Mon, 07 Oct 2024 16:37:07 -0700 (PDT) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-539afec1300sm1002256e87.17.2024.10.07.16.37.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 16:37:06 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 08 Oct 2024 02:36:59 +0300 Subject: [PATCH 1/2] arm64: dts: qcom: sm8550: correct MDSS interconnects Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241008-fix-sm8x50-mdp-icc-v1-1-77ffd361b8de@linaro.org> References: <20241008-fix-sm8x50-mdp-icc-v1-0-77ffd361b8de@linaro.org> In-Reply-To: <20241008-fix-sm8x50-mdp-icc-v1-0-77ffd361b8de@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong Cc: Abhinav Kumar , Rob Clark , Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org, stable@kernel.org X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1572; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=YQocvzYtQugoKxgD8nHuIxgQRJHdd9/v/IZp+pC+8dE=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnBHCeEpL543RrUo9Z7rVDf0efOxV1fnhzZJITr iRfdb/o/jOJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZwRwngAKCRCLPIo+Aiko 1QFXB/4u855teCcg8ExURYV6FCQ8peftzz6joCv38Tr0CKTKHy2CcAG8NbBxqvAN2J2PSMPgvRD MRwHus6hw2GV2WLtoCv/IiAMY4c7TpHXlsVWjc+hurwgqgay2NWVJ7gBdrqlPpYPcZ/zpB7BllG SR2fqZgfMUwh2RrauwjF3c5xUxFcq/WzmVHvRg54zdDOEjQ8e1G9ANQJ8WHA6RLA/g5piIddWI8 NfO5PqNErESUpBZEuSZJaGZa/4Z5/Lcvm+Td20f8q2wY/z1wwW9ncvxdjcO9dOPzuyoXPZMceQU 98N0JCD9zH9JE3zzcJji6Shs1acdd/aVlqgkHQLt1A6OnhH/ X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A SM8550 lists two interconnects for the display subsystem, mdp0-mem (between MDP and LLCC) and mdp1-mem (between LLCC and EBI, memory). The second interconnect is a misuse. mdpN-mem paths should be used for several outboud MDP interconnects rather than the path between LLCC and memory. This kind of misuse can result in bandwidth underflows, possibly degradating picture quality as the required memory bandwidth is divided between all mdpN-mem paths (and LLCC-EBI should not be a part of such division). Drop the second path and use direct MDP-EBI path for mdp0-mem until we support separate MDP-LLCC and LLCC-EBI paths. Fixes: d7da51db5b81 ("arm64: dts: qcom: sm8550: add display hardware devices") Cc: stable@kernel.org Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi index 9dc0ee3eb98f..cca10f9faa14 100644 --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi @@ -2871,9 +2871,8 @@ mdss: display-subsystem@ae00000 { power-domains = <&dispcc MDSS_GDSC>; - interconnects = <&mmss_noc MASTER_MDP 0 &gem_noc SLAVE_LLCC 0>, - <&mc_virt MASTER_LLCC 0 &mc_virt SLAVE_EBI1 0>; - interconnect-names = "mdp0-mem", "mdp1-mem"; + interconnects = <&mmss_noc MASTER_MDP 0 &mc_virt SLAVE_EBI1 0>; + interconnect-names = "mdp0-mem"; iommus = <&apps_smmu 0x1c00 0x2>; From patchwork Mon Oct 7 23:37:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 834105 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4450F193099 for ; Mon, 7 Oct 2024 23:37:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728344235; cv=none; b=rn/ohK61M51ZbiVlMiPjudM/vha3uaKUTBUohg5xiv2oBay5vIDxKQuEEe3G6w+TGwC4UTNNyK+7AYJFvE4SGxQyhUUPpjG3DAbnB1XRbf3z8XJyNUM25OuJW1UkNWaXh/OzDBv9B/EYGTkjs8F1UD0FZwPeuqfv2NJdxcH/5yY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728344235; c=relaxed/simple; bh=znBSTsvoia8jtv0vOla1luWvWrIdThhCQ3A7+DTU46M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AANHp1wngBiNW6B64xn2x/bMNMw0YkJUN7fT+O5iMlQoWBD/vka6BRE63TQaXsXDIXDTe5MGUA84ndvx4DwU7/X1cyQyzdxMrSxK4sqfcoEC3hDpQMfWrBbR3lOER9w02vPINGLQTuTJ1JUZo+h35BXbISCia4B4VHvnmHM30EA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=QQwh/ook; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QQwh/ook" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5398f3be400so5648741e87.0 for ; Mon, 07 Oct 2024 16:37:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728344231; x=1728949031; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tXGWJXNTWFyBHQiOjJ39OoJK5jFoxYtKruKryESO2Ts=; b=QQwh/ookSzrN2JWieKZKMgwx5n+6VbVZMslERL3U5lhWXR011dwB4pf8gabMyMBSn5 gfUounsKUTYsw0h25X0y1uLep86ZCHgBQhun68OWDrAfKxwv1lsS6e5YkSFQaVBWgfYp fKk15azQMKIA30/h9lQid6UeNhT2ULjTL+bSXrA1sVGNhi4apgxwaJXKSysIuNNOeqQA FTq7Iz1GluACSutQwrhtJwHbCt+et5vxW1s9LulUvUYQhatbTGOey8NO7s1jwJk5T7nD JaWqjpUI/kGXUanpKB3okSX4IbJcCYnU9/OrQWk/ZY4pp0myRyeIBLAjrjlG0Y1ZMGDo pDew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728344231; x=1728949031; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tXGWJXNTWFyBHQiOjJ39OoJK5jFoxYtKruKryESO2Ts=; b=IPIuILDvhfTJrZUbQz0R/X1/s4iAI+IuVz5kx4ZEn2XXPnXSlF1V9UlSCiUsDjwnLQ FDYZtgNioSEynVQvFZicBgIvDw8kbl+hATmH943uH/+Zsi0qXO+67ic77ipDORfBLRT8 owmHjuMMtdIvfCvFUkxbDQfxOPROxxQEnaENiZwz30BhqwdWupJOW/bnPpPeutkoUAXO U+zqo5Vl1CNnhtP4bjt9bycAR/loIIX/ELsX+7apbQ+BVhYGJRM8/dbR2zcCCBHAYtIa kR+Fi4f539hdIZS0P9oFqUdccdchcInnZzTLbym8QXlZ0o8an2jiaYf4ILKPU5uI+BNx 0ubA== X-Forwarded-Encrypted: i=1; AJvYcCXnveCyXoYraG2tu5Ax7cIGfBYz96diufWDwse3vItde8GDeIGd77Gd0UtvtIaHoEVT88Gr5cVKVbKDjHP4@vger.kernel.org X-Gm-Message-State: AOJu0YyWdKR6kfddbFWAvf4G9WNL0GKfZFocAMK6x0WTU/ku8Chn8CtG e/W1GXfVCWygd/gwOfMzHH/7Fhs3E95QaVvl8gm+Bao8/O0YkHUokgOqNaQHCc4= X-Google-Smtp-Source: AGHT+IE+4VzcRhbm1VFqYCLGq2Nrkh1v+z8RzQxhbXAwdRI0uxpOV12A3qgzgle5GzStCLctDb2jwA== X-Received: by 2002:a05:6512:b14:b0:536:53f0:2f8e with SMTP id 2adb3069b0e04-539ab9dd5f6mr6662392e87.37.1728344231168; Mon, 07 Oct 2024 16:37:11 -0700 (PDT) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-539afec1300sm1002256e87.17.2024.10.07.16.37.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Oct 2024 16:37:09 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 08 Oct 2024 02:37:00 +0300 Subject: [PATCH 2/2] arm64: dts: qcom: sm8650: correct MDSS interconnects Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241008-fix-sm8x50-mdp-icc-v1-2-77ffd361b8de@linaro.org> References: <20241008-fix-sm8x50-mdp-icc-v1-0-77ffd361b8de@linaro.org> In-Reply-To: <20241008-fix-sm8x50-mdp-icc-v1-0-77ffd361b8de@linaro.org> To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong Cc: Abhinav Kumar , Rob Clark , Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org, stable@kernel.org X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1619; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=znBSTsvoia8jtv0vOla1luWvWrIdThhCQ3A7+DTU46M=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnBHCeZFq3YI77GP+xE8vYq8jrRhjgLpkER4n3s EJe/us/uoCJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZwRwngAKCRCLPIo+Aiko 1S+ZCACjueCogk9kziFFtp2pQBwNgoEJIQOWFaoFCx6WssaAdkVv7aXZZB9N9+b8VXHEpE2XPfd bmvT9i3GzdC+IxJDCl6EjWpnP6MRhvvu+eZaBaIZtkr+MrW+o2BsXiHFt+rcwGzu6qiU4Q1iWYT N0jvH556UF45CesUsd/Pjr8oeL8E0ASt2e3/V8NTiujHTAoBUdEsOKvknFW5k3ZPWEA4LgpFYPS vXUn6zzsTVsuz3YXzGsuiQEtvrvSpfvENMd2JTix0FNJqLIN9iFuXd7mqWkzCBNel66CHeBgsqk W6kyjEqsoVwA/oQxEnmlq1+uggMQ14WFVo+gCL0TaqKxBKWS X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A SM8650 lists two interconnects for the display subsystem, mdp0-mem (between MDP and LLCC) and mdp1-mem (between LLCC and EBI, memory). The second interconnect is a misuse. mdpN-mem paths should be used for several outboud MDP interconnects rather than the path between LLCC and memory. This kind of misuse can result in bandwidth underflows, possibly degradating picture quality as the required memory bandwidth is divided between all mdpN-mem paths (and LLCC-EBI should not be a part of such division). Drop the second path and use direct MDP-EBI path for mdp0-mem until we support separate MDP-LLCC and LLCC-EBI paths. Fixes: 10e024671295 ("arm64: dts: qcom: sm8650: add interconnect dependent device nodes") Cc: stable@kernel.org Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi index 01ac3769ffa6..455774516b08 100644 --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi @@ -3455,11 +3455,8 @@ mdss: display-subsystem@ae00000 { resets = <&dispcc DISP_CC_MDSS_CORE_BCR>; interconnects = <&mmss_noc MASTER_MDP QCOM_ICC_TAG_ALWAYS - &gem_noc SLAVE_LLCC QCOM_ICC_TAG_ALWAYS>, - <&mc_virt MASTER_LLCC QCOM_ICC_TAG_ALWAYS &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; - interconnect-names = "mdp0-mem", - "mdp1-mem"; + interconnect-names = "mdp0-mem"; power-domains = <&dispcc MDSS_GDSC>;