From patchwork Wed Nov 27 14:15:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ross Burton X-Patchwork-Id: 180305 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp6177945ilf; Wed, 27 Nov 2019 06:15:30 -0800 (PST) X-Google-Smtp-Source: APXvYqwRiFxJrDCT/kBlMukk1LkJAtOgYZv3LWntq9+VPD48EISSydgq/5hRxIl960QykumRwzjW X-Received: by 2002:aa7:870c:: with SMTP id b12mr47531700pfo.30.1574864130807; Wed, 27 Nov 2019 06:15:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574864130; cv=none; d=google.com; s=arc-20160816; b=vZ0uQZn3pKYUEnl2d+T50p9R+1yQ+A7V82YF392cEa5/x+tslELg1l8jWJYf7WxohC fT7wAErRZsZwXQ4qjWTWc6Jk77DrNc+XZihIff6+va0l5MskIHFdYF/Ek4V/Jy/SQnfQ 9fNcD/MKbfCD3ImTdmGb+0ATZOCC2ULsRd7+xNvdL4yv0pPpW6WmPHBUgDoKkykEyjXZ aCDCd/+clSZXl+pbvdWG2ltGfzwq8wtmcx0Z8cfTaSB9odGqE9cpspylpmhktLJQYeyz 3XHNLSgT84s8ixY9KuSp376w9k1ci2Z3H/xYMevhFwawUKU0ATHSe9nUtXHJ/jTMXf7f CdQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:delivered-to; bh=w2kSJ4yhR/2058fsTpbr5UhJwh9Yw1BL9rCTBQMy7e4=; b=Qmqumsgg6s3VoxDqFEfhp0qHOHBMh4PPExIqKLzyW3fsauhzP0OKWw6pEwwkIBBrTj Z6Xzke4OiaBS7h5DYrOtpdrFV9XreTwu/e88zaaKc4vAw7xkQ8waqq1TmEHjCZjcrzKx nE0ff/zP75rc7a1acS5E1OrMZ+9QN/wJxNBR7P6pfxsDAJeJSWPfDiWVDvdcsfBG5AVj enN7YV6GwwsQSlxyBa9hAl6j21vNFGbKLy42lUyQ9We+Dp+TtEniF0SLqU5N7v2/eae+ TjaTUhhtjleWatDvaYVgokfufLNK7oLYidq/jhdLjn0kIAU91WXoqw5Kqv1QxkRvz/yD /8KA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=XSK4N6PK; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id i2si6915278pjw.98.2019.11.27.06.15.30; Wed, 27 Nov 2019 06:15:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=XSK4N6PK; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from ec2-34-214-78-129.us-west-2.compute.amazonaws.com (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id 3A9B77FC14; Wed, 27 Nov 2019 14:15:27 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mail.openembedded.org (Postfix) with ESMTP id 41E5C7F9B2 for ; Wed, 27 Nov 2019 14:15:24 +0000 (UTC) Received: by mail-wm1-f47.google.com with SMTP id y5so7664347wmi.5 for ; Wed, 27 Nov 2019 06:15:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=OQMmLcXgzEyYga/RS6cxRNb8Sg51AztyKvjmbsyv0gE=; b=XSK4N6PKNm+ntcAeSUVwIaEg9m63HqAk92BDw5mJaV9n0Ur6MgpdKwcu2CE90hgl5w VuR2QWe2JiCqFCcBpxG1iMoQbWzBMvzlYSmIp+/HOHeUmmZLX6WkBU7RtsiHjFDENoEW 411Po9FBGidA2fk6HYqe7Pgn+fWEPOHTk8/SGmIm+Kw130fMODi3Mz0wFOZymk8ql2ok 3l0ZQ/hdSz374++restgGPxgym4LOCsY59RhovpGH+MwZocMSh4/MCgB0KlcoZsBAqrR bh3AWnpPPGGTyXqIh13l4sWFY1DLRl6qIxRgAwLFznQhqyUJD39DflQLvL7a6xibijR9 L9Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=OQMmLcXgzEyYga/RS6cxRNb8Sg51AztyKvjmbsyv0gE=; b=NFspK/wH1fqp3mI5rXnFrzCZSAl2pmzwSTZ+DSj+RMVxdXTl104TsrFLm7w6HCYQD3 xakAG9TnxcBKdGbsv3hSUinPFMV+X3GxxNNfe8cVmhDBngzO8s8Pk+Kxg+/oFslqbDIo FFS/uReiGXseqGGRgEcneXrGr/tO/kD/z3YmadEeqfYZkS0zJvMKMjw2DqjWlzK6AJSW J9HO4iiufA4M3lob4i4sdofoKzR/hukvF3e33co02Ut324B6duU0DT4WeEW5uObCbIJJ EK3HNIg7q6T8B6ycawBPqbr5gOmMkQhyETZ+Mjv52v+gy19AMz7IzHR/9ipjjdbQhxPl 1cCg== X-Gm-Message-State: APjAAAWPqgRexWPIW2/3EBQ1TK/0O90HW0u2sIcF3YDTVml0nNzoAa5b UwYmd3uL4YPQ1n7mQcf/Y6ArRIr6TVc= X-Received: by 2002:a1c:c906:: with SMTP id f6mr4842047wmb.14.1574864124717; Wed, 27 Nov 2019 06:15:24 -0800 (PST) Received: from flashheart.burtonini.com (35.106.2.81.in-addr.arpa. [81.2.106.35]) by smtp.gmail.com with ESMTPSA id u16sm19241963wrr.65.2019.11.27.06.15.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Nov 2019 06:15:24 -0800 (PST) From: Ross Burton To: openembedded-core@lists.openembedded.org Date: Wed, 27 Nov 2019 14:15:21 +0000 Message-Id: <20191127141521.8739-1-ross.burton@intel.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [OE-core] [PATCH] insane: fix GitHub /archive/ test X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org This test was failing to split the URL list to individual URLs, so if SRC_URI is something like this then the test incorrectly triggers: SRC_URI = "git://github.com/foo http://example.com/archive/foo" Fix this by splitting the SRC_URI list and iterating through the URIs one at time. [ YOCTO #13660 ] Signed-off-by: Ross Burton --- meta/classes/insane.bbclass | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.20.1 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index f856cf6a2b6..0564f9c2a41 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass @@ -893,9 +893,9 @@ def package_qa_check_src_uri(pn, d, messages): if "${PN}" in d.getVar("SRC_URI", False): package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses PN not BPN" % pn, d) - pn = d.getVar("SRC_URI") - if re.search(r"github\.com/.+/.+/archive/.+", pn): - package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses unstable GitHub archives" % pn, d) + for url in d.getVar("SRC_URI").split(): + if re.search(r"github\.com/.+/.+/archive/.+", url): + package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses unstable GitHub archives" % pn, d) # The PACKAGE FUNC to scan each package