From patchwork Sun Nov 3 03:43:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Sunil Dhamne X-Patchwork-Id: 840545 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F07658210 for ; Sun, 3 Nov 2024 03:46:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730605606; cv=none; b=gAmHXlHzCoQ7u2mGvbrTrGkRHjIBiZkaGEMPEpo3jQ6jWmzcYrnt71yUzme5+rnpGBP32f61UridWQESpTQjMB6T3xUiRS5TRcqwIQcnu4XesEMpRjZuUy70eDmWflveUBK6UVTk/t3kSu2tiFPWFSdPK1m+q21HhttiawSHM9w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730605606; c=relaxed/simple; bh=UD37Q3kv+0zSTiaCDIGf4tHsYG947h5UUXOysx/iLUs=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Kw35vySQfZW9hFJ5MayflmLBuOzxslr83wagjzrjg92odHQxqPRBz0J6gcSoVlhmjnCTvV0VodVtx7z1j31g76VlCXXh5Doc8kj4XRUF3HE9C7Uce2Mwyhv9IjNxoQW93fvj4mDeVRavYNvmPoXO7EFitEFv0joF+V91BeGxbQU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--amitsd.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=IRvEtCSZ; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--amitsd.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="IRvEtCSZ" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-e30ceaa5feeso5782150276.2 for ; Sat, 02 Nov 2024 20:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730605604; x=1731210404; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=V3/D4cNuA+god4pAH3Cm6vq8553sgmtxzLl09CBk8Y8=; b=IRvEtCSZlyKmRP8Q70/LVVeaQBCbNANOqVbM1CqPi2ssRr4HkB6bl7q0sTWJmR5+5x yHAA4ybC7RLtL5W79YCVe4Ehx7x7YZU2JUBD1eVybuyeio4+X+1JisAohwmz1BQvagjG 52s822bAgO0k/XNZgyQp9hzDRHRrVmoAxHoksFMpfSdT+HH28jyS2rPRjaj1LWTYD5aN ktUcp/NYTEjIivcVeIV04J4sAqG+zPD2aC6V4poAX+92qpMlkqAc+SOocz4wFw7zS674 kfY4TMghiE94F6wK72cFAPiBlr2vm/o65FObN9cwd0bQUNvXDrNppq7YVCpKURknRYys 77hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730605604; x=1731210404; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V3/D4cNuA+god4pAH3Cm6vq8553sgmtxzLl09CBk8Y8=; b=nBM40UfHQbPDBahYw4VHYltoZQoWXqPAMNb0nCOcKkdN7EhaoWfk6z3/+yuw+wTCJn xpM15XxL2NEzZPWtTixhLbrG6sSxVYdql3V2f/cEBpV3Y5BZR9izZNTtGxlZav0bytNS 2xiZI4CITWY9XKtCqB/Gc1QiSwWrPnpfKJCUOPYvSrQpRyGGLlDoP4zLRa5puO/8AjAm ueASRHq8kXXMuKbHDowcQn5+S5L49vzz1nbCDjessbkfW5a3MLUAS3b3/0YEWlJgQQCy KYUAzzB2R1B7N8EVnXsvbHxqg9iHT9eYVotCbYEAh1jyXAJr/TEAbJq/K6aFbh3kDf8a JMxA== X-Forwarded-Encrypted: i=1; AJvYcCWvtfhilfZ11qVO+iKZpMdDlzTdb6X9dB9cwU5+3N5jb1yzFw7yLPfCfyjG1VtwAoegvBoiQ7peD90=@vger.kernel.org X-Gm-Message-State: AOJu0YzdqCIy1PVYPhptMLxSfdGEiEbBRvviAwHJfrphZuonLJdDMxTy CZf/T2a0vUTHUakbpdLgR7ZZqwkrv13JXY9OQhzMKh1A7VJsNxnEd9q1kcr/G4tsnVYlnt8fRbr cPQ== X-Google-Smtp-Source: AGHT+IHzb0iRIstFF5hN4PGd2zA1+ThWNXNbtoz4ikdltRmzRF3u92SdPOFeBkTUGKp0h2hZRT1/GG15QsI= X-Received: from amitsd-gti.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:827]) (user=amitsd job=sendgmr) by 2002:a25:a045:0:b0:e30:da65:7240 with SMTP id 3f1490d57ef6-e33025536damr8488276.3.1730605603649; Sat, 02 Nov 2024 20:46:43 -0700 (PDT) Date: Sat, 2 Nov 2024 20:43:28 -0700 In-Reply-To: <20241103034402.2460252-1-amitsd@google.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241103034402.2460252-1-amitsd@google.com> X-Mailer: git-send-email 2.47.0.199.ga7371fff76-goog Message-ID: <20241103034402.2460252-2-amitsd@google.com> Subject: [PATCH v2 1/3] dt-bindings: connector: Add time property for Sink BC12 detection completion From: Amit Sunil Dhamne To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com Cc: dmitry.baryshkov@linaro.org, kyletso@google.com, rdbabiera@google.com, badhri@google.com, linux@roeck-us.net, xu.yang_2@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Amit Sunil Dhamne , Krzysztof Kozlowski This commit adds a new time property for Battery charger (BC1.2) type detection completion process (based on BCv1.2 detection spec) when typec port connects in a potential sink role. BC1.2 detection is used by some Type C port controllers implementations (such as "maxim,max33359") to detect the type of charger port. Signed-off-by: Amit Sunil Dhamne Reviewed-by: Krzysztof Kozlowski --- .../devicetree/bindings/connector/usb-connector.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml index 21a0c58c65cd..67700440e23b 100644 --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml @@ -283,6 +283,16 @@ properties: maximum: 200 default: 200 + sink-bc12-completion-time-ms: + description: Represents the max time in ms that a port in sink role takes + to complete Battery Charger (BC1.2) Detection. BC1.2 detection is a + hardware mechanism, which in some TCPC implementations, can run in + parallel once the Type-C connection state machine reaches the "potential + connect as sink" state. In TCPCs where this causes delays to respond to + the incoming PD messages, sink-bc12-completion-time-ms is used to delay + PD negotiation till BC1.2 detection completes. + default: 0 + dependencies: sink-vdos-v1: [ sink-vdos ] sink-vdos: [ sink-vdos-v1 ] @@ -426,6 +436,7 @@ examples: sink-wait-cap-time-ms = <465>; ps-source-off-time-ms = <835>; cc-debounce-time-ms = <101>; + sink-bc12-completion-time-ms = <500>; }; }; From patchwork Sun Nov 3 03:43:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Sunil Dhamne X-Patchwork-Id: 840544 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E8851386C6 for ; Sun, 3 Nov 2024 03:46:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730605609; cv=none; b=ieSRCoQ+TIfLHuPYrI6QBnQGcdTssS8EP2AwZ5opzB7e2ODku2oeeOQhmq32iL+A0AcHWnS61GEB4aY87NqAhyIWmAkeh2epCbv/cvMfEKQyhdxUCbfKuvVSSe9EwJODsdTcJXY+AcBBbO4Ggb3YP76TLh6m+3THx8KTDYeocaU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730605609; c=relaxed/simple; bh=/DV8HzPWj9MRXa5IjLFG3GwszeHV8alTweaJrPIHLIk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Pdv5THDWknAUxe9So9Po2uUX1fQG/8ek8Vd9JbWVD4jxCMj5d9/0QddIRg6QPzdGNfGT/1OSuvTEQ9cET9jMDN7yX87azhOz9HRvsHGEwSypVCRYhfXS/hGpd/JRCEhicG4T+OSFeqL2S9/bq/jEtvJOWHK6dsLlCHxob8GNesA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--amitsd.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=JTQNWXAR; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--amitsd.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="JTQNWXAR" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-6ea33aad097so51816487b3.0 for ; Sat, 02 Nov 2024 20:46:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730605606; x=1731210406; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=TowRVRNLRnA95PP1YhuZFO986FuoFxFM7Ex1kZPLyXQ=; b=JTQNWXARHYTtS4uI3fKUElUZ6G2ypCpZWDN2QYUgV5bTgU5Ua2LaogxborBiGS1LDV a00t3iP197MRu+eKPflUEjhLyFusWaDfjqgtRsnjdSPs4jJlx60bvfxoDcXV9yRlKppJ wKKE/GnTWwGOE0/1QCWT8p4onChyLMEgxiEsiQOi6qRujPUyM6bbc2FgIUDZsR8GyRGo niDpB2nds7NrGZnduGVKzehWjn+Yg82rtvMYJ6XP6E76aFg2aOpVwIEeiShj8y8qhcyW 7MD7DsmojB6+QRQC+tqhvXNwG2h0qe5QNT89v0Ujl0Lcqe2WRegwbzUjJt9VSkHosv7x iD8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730605606; x=1731210406; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TowRVRNLRnA95PP1YhuZFO986FuoFxFM7Ex1kZPLyXQ=; b=p0WjKnEVSq1HpZ+xyQ3hZiMO68DUtCaFrT2Ed0Btn/WLod/YfMIvJY6Yi59yIiezhG JinMnoGp//DI6PJv61vN0ZPOBWFK30nwG6tZhGhLmueSWTBZASkaZnDwIEp7ITs09Fbo t4i2WalC8SfBUb3sLW1jatZKC815SDvxyplKrLSURHnVTP3AUcKRzRPN+MxdGarMWSht u7me7r+oQ7RmiWmXWzirpFiS0Ct2eo+VGpXEeBpzycEUUvBSMbbB8ILrUPY0vvCDcCqg /OjWANjLIOMFx9J0oy8Nmj/I+b6jZWMZUUADCiNPKM56JFTF0X+QVPo6ythh1J4jykmN 9n6Q== X-Forwarded-Encrypted: i=1; AJvYcCUNVjlB7lXuaQsDXzWd+tYwsxM4gPRBqZrfJzrDEwioCxkvRvIeyCKuaHdwQButjEtyNBNmg8UMfA8=@vger.kernel.org X-Gm-Message-State: AOJu0YxmFRkD64wufW6gtpIfoQEulJSVHNyHQSd6A/vIDRGC+NGsfrdQ WGXtSzyczoULme6xR9187wm58qFE5vt6qhlkZZzCHRXBwZjzfs7jhRW44v4+CvyTfDT+bQ4uFLK eaw== X-Google-Smtp-Source: AGHT+IHmE/kRn11bYNZn6cr3lE/xj6nOQF+TDhhrTDBqem535PO/7FKEx7RglgarpoJtTeWMpgmie/77OUc= X-Received: from amitsd-gti.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:827]) (user=amitsd job=sendgmr) by 2002:a05:690c:630c:b0:6ea:881b:b545 with SMTP id 00721157ae682-6ea881bb908mr434707b3.4.1730605606556; Sat, 02 Nov 2024 20:46:46 -0700 (PDT) Date: Sat, 2 Nov 2024 20:43:30 -0700 In-Reply-To: <20241103034402.2460252-1-amitsd@google.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241103034402.2460252-1-amitsd@google.com> X-Mailer: git-send-email 2.47.0.199.ga7371fff76-goog Message-ID: <20241103034402.2460252-4-amitsd@google.com> Subject: [PATCH v2 3/3] usb: typec: tcpm: Add support for sink-bc12-completion-time-ms DT property From: Amit Sunil Dhamne To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com Cc: dmitry.baryshkov@linaro.org, kyletso@google.com, rdbabiera@google.com, badhri@google.com, linux@roeck-us.net, xu.yang_2@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Amit Sunil Dhamne Add support for parsing DT time property "sink-bc12-completion-time-ms". This timer is used to relax the PD state machine during Sink attach to allow completion of Battery Charging (BC1.2) charger type detection in TCPC before PD negotiations. BC1.2 detection is a hardware mechanism to detect charger port type that is run by some controllers (such as "maxim,max33359") in parallel to Type-C connection state machines. This is to ensure that BC1.2 completes before PD is enabled as running BC1.2 in parallel with PD negotiation results in delays violating timer constraints in PD spec. This is an optional timer and will not add any delay unless explicitly set. Signed-off-by: Amit Sunil Dhamne Reviewed-by: Badhri Jagan Sridharan --- drivers/usb/typec/tcpm/tcpm.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index b3d5d1d48937..8b325b93b5a9 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -319,6 +319,7 @@ struct pd_timings { u32 sink_wait_cap_time; u32 ps_src_off_time; u32 cc_debounce_time; + u32 snk_bc12_cmpletion_time; }; struct tcpm_port { @@ -4978,7 +4979,16 @@ static void run_state_machine(struct tcpm_port *port) if (ret < 0) tcpm_set_state(port, SNK_UNATTACHED, 0); else - tcpm_set_state(port, SNK_STARTUP, 0); + /* + * For Type C port controllers that use Battery Charging + * Detection (based on BCv1.2 spec) to detect USB + * charger type, add a delay of "snk_bc12_cmpletion_time" + * before transitioning to SNK_STARTUP to allow BC1.2 + * detection to complete before PD is eventually enabled + * in later states. + */ + tcpm_set_state(port, SNK_STARTUP, + port->timings.snk_bc12_cmpletion_time); break; case SNK_STARTUP: opmode = tcpm_get_pwr_opmode(port->polarity ? @@ -7090,6 +7100,10 @@ static void tcpm_fw_get_timings(struct tcpm_port *port, struct fwnode_handle *fw port->timings.cc_debounce_time = val; else port->timings.cc_debounce_time = PD_T_CC_DEBOUNCE; + + ret = fwnode_property_read_u32(fwnode, "sink-bc12-completion-time-ms", &val); + if (!ret) + port->timings.snk_bc12_cmpletion_time = val; } static int tcpm_fw_get_caps(struct tcpm_port *port, struct fwnode_handle *fwnode)