From patchwork Thu Dec 19 17:57:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Khem Raj X-Patchwork-Id: 182145 Delivered-To: patch@linaro.org Received: by 2002:a92:d0a:0:0:0:0:0 with SMTP id 10csp804112iln; Thu, 19 Dec 2019 09:57:54 -0800 (PST) X-Google-Smtp-Source: APXvYqxK9CoA3xZalUNtWgWAUH2qxuRvKIf5s9N5mBmBTsAwQSYKP7e8YtGYeDA75/o1gvUXx6lT X-Received: by 2002:a17:902:d711:: with SMTP id w17mr10454686ply.303.1576778274770; Thu, 19 Dec 2019 09:57:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576778274; cv=none; d=google.com; s=arc-20160816; b=Ar9AaFKJrnkIV+hthowflb3/XP33fWn/NtnW7+GhjUKScSqcC1au3x23B6fllV5zYk abyG79YqFeji5CDh5NL3aKbgpxZ0JmFkyVQa6HPcpTwigcfrtOWxHAmq2gEsZ9Cw/GJF XCgdoyOzJb0jyV+PcFeEr3uMek85qYHM2C4iJbxeSuVNbQ4evAoq3JRO7AkHEBsOYE0y QyaqHPDnWMnAEaRREhP2qEtHGwcxlMc7zmoMfcf4p/SDxwp5mgHPi79n2D/sJ42X7vhU NmaDLgnWRdjFLrM+ioo5pt7Lhh/VfAB+hx0t9QYIsUspAYovVzn3ZsUf5ZpW0zU0//y/ 1wyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:dkim-signature:delivered-to; bh=oIIrjP2I+Ebte9ElT6eUhL/kks8hFAgXF7qbvy/aHro=; b=UQusJIeKxAVhZMt08xRT74+lHiuoDiiC9UceMhwvwPxHYl5eO3udkYy93mk/k0f+eG +xq0roq5PR3t4wDrFzj+GfsofDV97yR7PVvcU3SW4qf6q4eTW3EDEmgh5h8wNwCN0aR5 tP7x/cvZRovchBFsPrvvmsn9l2QJyG+HiR0ueEtBwmSgcV7KGxmcy4XBRefld1dnnf80 mv4BqE8MmdQLp9Q9M0j9Htw+aRjgKKgEw3LIIFGtI47jTkscT/r29KcButUYNX+LMxcD eqC3CYpEM9kOjneh2R3nzz+A8AGKznijd2FwNuurttqfCg1hrBk6XoLArrOejnR8PKWf +z7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=bPIrxxfE; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id 69si5838777pgh.428.2019.12.19.09.57.54; Thu, 19 Dec 2019 09:57:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@gmail.com header.s=20161025 header.b=bPIrxxfE; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from ec2-34-214-78-129.us-west-2.compute.amazonaws.com (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id 121B37FDB6; Thu, 19 Dec 2019 17:57:48 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by mail.openembedded.org (Postfix) with ESMTP id E350F7FD7A for ; Thu, 19 Dec 2019 17:57:45 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id l127so3696539pfl.1 for ; Thu, 19 Dec 2019 09:57:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SKubNXSG3dtc87MI0E1cHQ53Dximp/vpYRxUQZIec9M=; b=bPIrxxfEar5V86zhofXlGOataE5R0GVmRgN1MoMRBqLp4H1hhQNjxe/NQgQVgM/tzQ VeYSA7CJK0iNS83rtZnMYrB0lRkysOF38iiyWdZbZrPo/oZ1FLf9cXObtWHBJeN0CwUL wy2opEhrpJIsKd4jKYzd7JbKXtv/iUO46Z1RIzGGoQ+5hDxEBtZMdPjZPDw21Kt4HyD6 Eh0W22GHWPtWHGN+s3ejYd12pzxJgSoyKlwN0+8jcXArZllEV9fOEwU0pfkJxzzSotqW zHxjrrw7NvxI4vv0IQ5TkvotdKLjEpJ5tIXuJ9Q43Y0l6G+6X1zdzl3++BtEtRh0+w6E oCUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SKubNXSG3dtc87MI0E1cHQ53Dximp/vpYRxUQZIec9M=; b=bk3U+V8GtLt6w2IWHw+SleUabQpLQttA77Q7EBZji67egwMbIpe8Ey5GAUHRVDpI+A db7CmgydYFsasC4rWEX7w6o+lfJ4VN4Ve96QG7pahgdGFIg+rvp5Uq9HFRDfJE8AynBA LXqH/Cnl7cFPxfCOEJ7NpXa4f6IVfw0XpCsTUjruD5vkigoIzKLFAs6L+0be+aZrxQ2v h6+AJ3LKJ3wF0bzoJAI1JXmLqOqh6sVo1eWUeVYEQygZ49+CbpmCjgTqRYproRGfiWlt qZJDkw0f2t8PPU7JXK8dAmsZp/Tu64p1cWF+H1WmVrVLZz/FXmRiD/MfeqQRT9ihmziO WlnA== X-Gm-Message-State: APjAAAUo2x9N0Sb1AoqksbREl/Puh/LerUDw7BOXVVK2yclcz3JGX49S OSb2pt/GTYnoLQspSgbRHewrbqR0+2k= X-Received: by 2002:a63:2142:: with SMTP id s2mr10256680pgm.54.1576778266239; Thu, 19 Dec 2019 09:57:46 -0800 (PST) Received: from apollo.hsd1.ca.comcast.net ([2601:646:9200:4e0::4b]) by smtp.gmail.com with ESMTPSA id x18sm9193565pfr.26.2019.12.19.09.57.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 09:57:45 -0800 (PST) From: Khem Raj To: openembedded-core@lists.openembedded.org Date: Thu, 19 Dec 2019 09:57:36 -0800 Message-Id: <20191219175736.1324263-1-raj.khem@gmail.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Subject: [OE-core] [PATCH V2] cmake: Add a knob for cmake VERBOSE settings X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org Setting VERBOSE always, while is fine on one hand for debugging, its coming at an expense of creating lots and lots of logs, e.g. qtwebkit compile logs alone with VERBOSE is 163MB, there are many other large packages which use cmake e.g. WPE, webkitgtk etc which are in same range with out this option on, the logs reduce to 861K and also speeds up build a notch If user needs to disable these logs for a recipe or globally CMAKE_VERBOSE = "" in recipe or in global metadata e.g. local.conf Signed-off-by: Khem Raj Cc: Ross Burton Cc: Andre McCurdy --- v2: Make a knob for verbose option and keep the defaults as such meta/classes/cmake.bbclass | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) -- 2.24.1 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core diff --git a/meta/classes/cmake.bbclass b/meta/classes/cmake.bbclass index 8ccb1eefc7..14796ac053 100644 --- a/meta/classes/cmake.bbclass +++ b/meta/classes/cmake.bbclass @@ -181,9 +181,20 @@ cmake_do_configure() { -Wno-dev } +# To disable verbose cmake logs for a given recipe or globally config metadata e.g. local.conf +# add following +# +# CMAKE_VERBOSE = "" +# + +CMAKE_VERBOSE ??= "-v" + +EXTRA_OECMAKE_BUILD_append = " ${CMAKE_VERBOSE}" + +# Then run do_compile again cmake_runcmake_build() { - bbnote ${DESTDIR:+DESTDIR=${DESTDIR} }VERBOSE=1 cmake --build '${B}' "$@" -- ${EXTRA_OECMAKE_BUILD} - eval ${DESTDIR:+DESTDIR=${DESTDIR} }VERBOSE=1 cmake --build '${B}' "$@" -- ${EXTRA_OECMAKE_BUILD} + bbnote ${DESTDIR:+DESTDIR=${DESTDIR} } cmake --build '${B}' "$@" -- ${EXTRA_OECMAKE_BUILD} + eval ${DESTDIR:+DESTDIR=${DESTDIR} } cmake --build '${B}' "$@" -- ${EXTRA_OECMAKE_BUILD} } cmake_do_compile() {