From patchwork Thu Dec 19 18:34:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 182178 Delivered-To: patch@linaro.org Received: by 2002:a92:d0a:0:0:0:0:0 with SMTP id 10csp869656iln; Thu, 19 Dec 2019 10:54:23 -0800 (PST) X-Google-Smtp-Source: APXvYqwbEJsI9YxVURh00UPZZpuMXonrCVXPYb3xozcKijhEtaFPEEQCL6LIu7vfJx8dhqtWGr7r X-Received: by 2002:a9d:7a8f:: with SMTP id l15mr9896876otn.109.1576781663480; Thu, 19 Dec 2019 10:54:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576781663; cv=none; d=google.com; s=arc-20160816; b=htRowlt+v/mL5WDw/DD0ArhFDU/ZFKgoUm3+NAgXgnZXjnJgmcYOA6Bgv3zrylR3bO GucgKxuE9+HZzhCx2t3E7Q/3HirVC0cfVhkV0/DJT7GA89HZFD7D4BFhBKnF7XAkKSgi IQjfBIKE7mkndo867XegVnalnqYe5QjMmVNm+7Z3ke7wBtfgYLVhnE0LVSxD5Lbt6/g8 uvLe6wsUea985K4l/cn04JbkVGDhLKJBw8jfNStgTuJk4O1x326vqa9JLPJcEMyAT+fH r67oiApQ5mk2mXpjJQeRVTcMQTuWXAaU1iftA/mNYi0KhZTxGmcmxWupDhBWae3847fo POjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jlvdr3mvVo991JtkD+UyLyR1G5zJ5ZY8TDXQ0NiQtmE=; b=QVfwoE39r4+RfuIILwsb9dLf855nDTHCJJ04XiwAUMOwNNXu4WMvKL61RpqOWAO5JX rDUczOnrjwIHLX6FepG9kTKrTtS51uy9yrO/8+2Zfl20skJZSrznN1UOBvCiqk/p3jV+ omzBkOHnmy3rFZKUkC4Dmz9OauV8jaY6OO4Ime0nMQ6QNOTIgAwQas9r6ICBVw1lgpmx KZ8OPOd0ZmwSetwqWv55ixE+tXWGcPPH8k4dSJ8MQKNiE2eBIovXNi01xjwnCMTMXqMU EZsrDSdg6UbJN9kbvtpx5b7KnayzlXxYAzmyclk47Z273A4x9QK4s0cjxdlhKDG9fzRJ jtMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=An3WehkW; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t20si3615561otr.64.2019.12.19.10.54.23; Thu, 19 Dec 2019 10:54:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=An3WehkW; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730320AbfLSSyW (ORCPT + 14 others); Thu, 19 Dec 2019 13:54:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:49720 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730485AbfLSSyT (ORCPT ); Thu, 19 Dec 2019 13:54:19 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 401C3222C2; Thu, 19 Dec 2019 18:54:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576781658; bh=cbwsBuEqEqia5+bAaY56n4OPjROO8sIYdADYQJI11w0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=An3WehkWnTED1GxJzspdCWxJrj5a8w4zY3ifbpVmDUsXXfas/SCLJjSa4w5tvfjna dShkC90AjvU8JlGPDdQkKPT6jCT6QDmowVuqt0JztWJt6x/ZnLbETHKqLZCRTZaauc uUWBhDv92TwCs+/ZUEOmULmkpMFnq36t0RsOxGwQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chris Lew , Srinivas Kandagatla , Bjorn Andersson Subject: [PATCH 5.4 27/80] rpmsg: glink: Free pending deferred work on remove Date: Thu, 19 Dec 2019 19:34:19 +0100 Message-Id: <20191219183103.008476749@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191219183031.278083125@linuxfoundation.org> References: <20191219183031.278083125@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Bjorn Andersson commit 278bcb7300f61785dba63840bd2a8cf79f14554c upstream. By just cancelling the deferred rx worker during GLINK instance teardown any pending deferred commands are leaked, so free them. Fixes: b4f8e52b89f6 ("rpmsg: Introduce Qualcomm RPM glink driver") Cc: stable@vger.kernel.org Acked-by: Chris Lew Tested-by: Srinivas Kandagatla Signed-off-by: Bjorn Andersson Signed-off-by: Greg Kroah-Hartman --- drivers/rpmsg/qcom_glink_native.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) --- a/drivers/rpmsg/qcom_glink_native.c +++ b/drivers/rpmsg/qcom_glink_native.c @@ -1562,6 +1562,18 @@ static void qcom_glink_work(struct work_ } } +static void qcom_glink_cancel_rx_work(struct qcom_glink *glink) +{ + struct glink_defer_cmd *dcmd; + struct glink_defer_cmd *tmp; + + /* cancel any pending deferred rx_work */ + cancel_work_sync(&glink->rx_work); + + list_for_each_entry_safe(dcmd, tmp, &glink->rx_queue, node) + kfree(dcmd); +} + struct qcom_glink *qcom_glink_native_probe(struct device *dev, unsigned long features, struct qcom_glink_pipe *rx, @@ -1639,7 +1651,7 @@ void qcom_glink_native_remove(struct qco int ret; disable_irq(glink->irq); - cancel_work_sync(&glink->rx_work); + qcom_glink_cancel_rx_work(glink); ret = device_for_each_child(glink->dev, NULL, qcom_glink_remove_device); if (ret)