From patchwork Tue Feb 11 14:35:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 864390 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C1DA24E4BF; Tue, 11 Feb 2025 14:35:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739284522; cv=none; b=iXDPgSOjp/jeLpAWBvKBwW4HaMfB/CWbXGK0FxO7/fqM1nkeQNdGVUDDyZ4q/ULw+E3/7epGxGwsvAS3KjAmfCVoy1mJ0xa4SXMVF7++RShAPwFKCm1SQwNZUQofq+hJrdTkCCjL5SOQV9B7cEl7gEAjd7w1vM97Irld4vMhYqc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739284522; c=relaxed/simple; bh=lmGmSqy2PmFW0zQzBa1szjl9SrAN6tvuVOB7IH0j+EE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OgAC2XN6iRp7v8b63DZqToYPfHSUkDFcMlki0gzHqupQ5SVlJ+/agjIWH6dtb2V5zwH0me9PNZSrxcBgSf5jp9nI5l1nM/Bzs/0Zj8WJACcATSdfQgAXNu5/qxxvZ8N+m69spJSoPgls4WU3Ag810lMEWd3zld0NzRfQP5pLVIY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KhjVk9JQ; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KhjVk9JQ" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-307d4eaab17so3969931fa.1; Tue, 11 Feb 2025 06:35:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739284519; x=1739889319; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XcwRtnPDk8zSNNP9D2au5calZ66hB6xZSQOd9iufapI=; b=KhjVk9JQMkGMeXt61mHkHBnzdijEezfw4Pniw0hZbfiM4n6YsCV3XKK72azkho+a5S 8aKyYHsrV6P3ShP/uySAzkFM1JQ593p3aR21Q3qs8NUkj6Q18RT0EsC0fKhpElbkDQw8 3qGPwgS/uqPYaJXckOqDtMsDOaJyk58CyzzFas0YJ9fZjvGv+UHT4fPs5gOLVvePX33b xXRisOK/I1sAWiyYixnRppGiXbz6trVq0BapaDXn4w/t5VIhazMpacmy5azvS5h2pEPs xEE7leIJLUU2DlLGfGkrynIL+hkkFgSxJK//eyXosfw3kDbYPC/AsEWu/9F8h+afRd/Y r3cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739284519; x=1739889319; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XcwRtnPDk8zSNNP9D2au5calZ66hB6xZSQOd9iufapI=; b=d5HGcpo47ISoOZGp4rC/pejqx5tdJI7AxMjjhuUlzl6B5nXuJyyjdYOP0Wrbn7ZeM1 s3X01oE2pl0EttA4sgsYG9o4oPxsTEsx5iI4OuIRNBJgVmB6Ez/R5S65POubhs8mJd1U AoYXkUM2ALqjGmplU5HdWxh3hN8AKornUg58hVFEhTcRB96R0awNgjDwRd/W8RUu8Pa/ EoqVNqsqo3Pz3jZsw74TWJq9wdRagKLSoqKzk+7jT/PWZiiC/mqwFwoVbpsRLUOHUcQD kPSXbZDI9GlxG3H9Gntp2irSVWy7G3Va8EkRV00nxA7LPPC+hCDfgaKIOyajN31V6KF5 /eHw== X-Forwarded-Encrypted: i=1; AJvYcCU0tfXdLhapix4urDDa/lI23Yc0/RpZfOKDhQCvdlZiqFIAlP5T3VeNffn5R5rAlmImSWJqzpLkw7+o@vger.kernel.org, AJvYcCXmuS7pKwQoiJTAmkK8BwQiTHutiXfpFy7rvthRsZjZU85RzIUOR6rhUYvJcLzerMTSVQGHPqtMzeerHg==@vger.kernel.org X-Gm-Message-State: AOJu0YyymxCLa6eW4GkI3rKpS84P1vxHR+W+6O3HVtIs+FBXn5HzP5GY R1LoLO1O5DYLitk0sBPtSIUPA1Ef+z/tXUaBPNH1/c1uxOZvcYyU X-Gm-Gg: ASbGnctYvtuKOzE+GBF8m377Ytz2F/eK3RLePVfoNTVV+ftgnyQtFD7LG3uB8Bur8LZ OBCpZpUlnXtSOtXUeWJuzbXDtun00RNSEIMUgU0NxheFyCsiVu2IZAYkTQdIMN0Z0nsMHrJPWLe 6sV7idIYUIpYrmfWpBP/c/IiB9kjpvQXmZi6kmBQCkDKwZmDVLgHh92UFNrfeGaAm2Y6L0oo8xY cTXAlsNE/yv8xZ57v3i7D82/GzKUuH3j1g62bj9zMNa3zi+i8Td+o9euXbHTonT/PzE+X5JIN7O CuHfr8CxpM7aMyXaqpVsNxhhK0X/2ejN6r9r75/05QY9qKm6QsHEhHjj9eMYDg== X-Google-Smtp-Source: AGHT+IGWcmtd/lkyNRQWblrSGSREKL9mXekrYldPQ/fxQv1VUl9qf+6UXVjP6HuN4rmhs5qvbSQOhg== X-Received: by 2002:a05:651c:221f:b0:308:f6cf:362d with SMTP id 38308e7fff4ca-308fbe2fedamr3735331fa.4.1739284518952; Tue, 11 Feb 2025 06:35:18 -0800 (PST) Received: from laptok.lan (89-64-31-140.dynamic.chello.pl. [89.64.31.140]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-308ee4173edsm6132191fa.0.2025.02.11.06.35.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2025 06:35:18 -0800 (PST) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v4 1/6] MAINTAINERS: Update hid-universal-pidff entry Date: Tue, 11 Feb 2025 15:35:07 +0100 Message-ID: <20250211143512.720818-2-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250211143512.720818-1-tomasz.pakula.oficjalny@gmail.com> References: <20250211143512.720818-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add Oleg Makarenko as co-maintainer Signed-off-by: Tomasz Pakuła --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index a7c37bb8f083..aa87d5d56ee7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10258,9 +10258,10 @@ F: include/linux/hid-sensor-* HID UNIVERSAL PIDFF DRIVER M: Tomasz Pakuła +M: Oleg Makarenko L: linux-input@vger.kernel.org S: Maintained -B: https://github.com/Lawstorant/hid-universal-pidff/issues +B: https://github.com/JacKeTUs/universal-pidff/issues F: drivers/hid/hid-universal-pidff.c HID VRC-2 CAR CONTROLLER DRIVER From patchwork Tue Feb 11 14:35:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 864389 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C34D250BF5; Tue, 11 Feb 2025 14:35:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739284525; cv=none; b=g5Iz+uf9ofX48/MrXMoVi55PXYY06wktNt4sStjBCleeMHwYgGJ9bfz86wvHCYFWspUcgHlRTKaHrW8R4kQqtir+hqaeTTinWxYVt3vraFbsxMe7/wLnV24fbO73Aw6IaW2PJH+4/PsY69yzzgCz8O7bu+AhX8Y6TjXTzb89B5k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739284525; c=relaxed/simple; bh=63N2CLR+q6W1xHPej8KWz2+AOl28NpDYsKe9GLcAMvY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MzAIPnBUc+Yc2dgEeWIOizeY3I7GCTx5m/KFSB2ZlcTbCpm2GWhWh1bKfjTwutXzdcMtH0FWnjG7GzjuDZmNy2IrhKY+jQQq+qQfwGmG0yeCDzalzO7eT2UjSfsfMdQZBIxngH4LVZ8CtmXBB4TmgF602Y2LPQW6eKDSSRVFd/4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gt4VidWc; arc=none smtp.client-ip=209.85.208.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gt4VidWc" Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-308e4bcd978so3324981fa.1; Tue, 11 Feb 2025 06:35:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739284521; x=1739889321; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Kdkw8SKc2jEdMzydhzBcIQXPPdM4NJNLnID5/f9u6lI=; b=gt4VidWckzF3cZKomr2Ojzt/ZydYiGHB9KGw92+VOCu7Vl97gaAAAwBbiUhsvboUbk JcZj9pL5Bf5u3rP8iIIF05OyldQQNXyIX5OFA84R2+ylAI/Vnj6OrXoa9UW/nul/HGH9 GgRHdJ2Z/BoJ8vkFp2mJHUjqMjgJ/LHWib0lKni906rYoVELGVfdIjEOorwrr0OMk6bp 0L56PI68GJLXsUHN2fiEDPIXKf3ftkUfNmrctypzyJDspqqeMPj7sILqX6bQ3nCauFcs jySHCRM3ftSEsVrjVsfeGfgh5rV7i/DXBoyGEHutjgFhSqOvsGn68eZB8nH2sXxWwyno mlMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739284521; x=1739889321; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Kdkw8SKc2jEdMzydhzBcIQXPPdM4NJNLnID5/f9u6lI=; b=RZbBTLVCdh1pWD420z6y9taBK7+NR6J2Z5GUNp5u+WoPvForp0w7mMui1+m5SZd4B8 +re5mDV8etL89myL3jMajEosYXVbzaOb/E8/QlVKxUSx/SKgfXBv968p1ds9wAEbe4GN hNVp8hnddr2pgyBCZXM2aXHIiYxr5t8vyjVkclkvHYoLFL1p6v0AmmB13ZuMGBrYAEFr SvSaX8P406tF1F5WZqq9ZixFOZK++Bv/Qnb7FPa1c8VFDUakcLh3YFwJ4Ii+lCm3Bi6+ AJypc7R8dhAiQVn2QSt+PjDPrF001QZxqT0PTBBYDmEcGFvAYTx6owUICAgbbwYKzgfU OdZw== X-Forwarded-Encrypted: i=1; AJvYcCVUHtUSqQ8s/Jo/iJpNDNGKQVv/YbFNZidn7RzYlNiJXXwCpztwIzF+mCQopQRWPYqgNflXi57K83znig==@vger.kernel.org, AJvYcCW4q0EQywnKI3RiS0yGGY0wscXvpOq92k+JsuUfK0Uwbb53Y4Ir7qDZOozPezI7SEscNYGrLJW/US29@vger.kernel.org X-Gm-Message-State: AOJu0Yz+8XCx2So+QUSA8oPEM638CwHFZPzfGF7ZbB3t5vuUe3a/oNYO UyVjaiOGu109ob2qupK3bZ+92FuOJhCCRb0ODh+egfKmSTMMF7BJ X-Gm-Gg: ASbGncstwACytmwVlqGT+9/9iz1XzjZARBRi64URAgAUIGfFSrjHOw4yqtJGRAp8kX5 1pm20PW961xAIX+nNPuGqq7bEiC7fVWgxEfKo+oSCwikkWpa8voRsUu37cbwIyxilDf+EbE7taa wR7yluKTFmVX3bFVVPNqno/9ppdqaBo4L79r6KSbr/M4dHpAuPYWvbLodqe4O1SFR85c2Z7K0go QH9IsIDinRyfkQ4iv5k/m6lmSjV8ElMZ06yr7J6WVwgx/JfDLlOdWvoxcUcww2vMDzwlSrI4nZc hwm6iqXDvJ2liiB2+3/dSfkCp30O20GWgSAzdQgkJgzDz6TVFnKibkhToNaC8A== X-Google-Smtp-Source: AGHT+IG3ip/jSb8wAk87NjyS3bhJUfHYby9ii42OFaym56d9/LZdyQO6xhU3OmzDIQN260D7H6jRGg== X-Received: by 2002:a05:651c:1503:b0:302:40ee:4c34 with SMTP id 38308e7fff4ca-307e57fcee3mr25830201fa.4.1739284521295; Tue, 11 Feb 2025 06:35:21 -0800 (PST) Received: from laptok.lan (89-64-31-140.dynamic.chello.pl. [89.64.31.140]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-308ee4173edsm6132191fa.0.2025.02.11.06.35.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2025 06:35:20 -0800 (PST) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v4 3/6] HID: hid-universal-pidff: Add Asetek wheelbases support Date: Tue, 11 Feb 2025 15:35:09 +0100 Message-ID: <20250211143512.720818-4-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250211143512.720818-1-tomasz.pakula.oficjalny@gmail.com> References: <20250211143512.720818-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Adds Asetek vendor id and product ids for: - Invicta - Forte - La Prima - Tony Kanaan v2: - Misc spelling fix in driver loaded info v3: - Chanage Oleg's name order Signed-off-by: Tomasz Pakuła --- drivers/hid/hid-ids.h | 6 ++++++ drivers/hid/hid-universal-pidff.c | 10 +++++++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index dbac05649e9d..860adabbc625 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -189,6 +189,12 @@ #define USB_DEVICE_ID_APPLE_TOUCHBAR_BACKLIGHT 0x8102 #define USB_DEVICE_ID_APPLE_TOUCHBAR_DISPLAY 0x8302 +#define USB_VENDOR_ID_ASETEK 0x2433 +#define USB_DEVICE_ID_ASETEK_INVICTA 0xf300 +#define USB_DEVICE_ID_ASETEK_FORTE 0xf301 +#define USB_DEVICE_ID_ASETEK_LA_PRIMA 0xf303 +#define USB_DEVICE_ID_ASETEK_TONY_KANAAN 0xf306 + #define USB_VENDOR_ID_ASUS 0x0486 #define USB_DEVICE_ID_ASUS_T91MT 0x0185 #define USB_DEVICE_ID_ASUSTEK_MULTITOUCH_YFO 0x0186 diff --git a/drivers/hid/hid-universal-pidff.c b/drivers/hid/hid-universal-pidff.c index 1b713b741d19..5b89ec7b5c26 100644 --- a/drivers/hid/hid-universal-pidff.c +++ b/drivers/hid/hid-universal-pidff.c @@ -4,7 +4,7 @@ * hid-pidff wrapper for PID-enabled devices * Handles device reports, quirks and extends usable button range * - * Copyright (c) 2024, 2025 Makarenko Oleg + * Copyright (c) 2024, 2025 Oleg Makarenko * Copyright (c) 2024, 2025 Tomasz Pakuła */ @@ -104,7 +104,7 @@ static int universal_pidff_probe(struct hid_device *hdev, goto err; } - hid_info(hdev, "Universal pidff driver loaded sucesfully!"); + hid_info(hdev, "Universal pidff driver loaded sucessfully!"); return 0; err: @@ -179,6 +179,10 @@ static const struct hid_device_id universal_pidff_devices[] = { .driver_data = HID_PIDFF_QUIRK_PERIODIC_SINE_ONLY }, { HID_USB_DEVICE(USB_VENDOR_ID_LITE_STAR, USB_DEVICE_LITE_STAR_GT987_FF), .driver_data = HID_PIDFF_QUIRK_PERIODIC_SINE_ONLY }, + { HID_USB_DEVICE(USB_VENDOR_ID_ASETEK, USB_DEVICE_ID_ASETEK_INVICTA) }, + { HID_USB_DEVICE(USB_VENDOR_ID_ASETEK, USB_DEVICE_ID_ASETEK_FORTE) }, + { HID_USB_DEVICE(USB_VENDOR_ID_ASETEK, USB_DEVICE_ID_ASETEK_LA_PRIMA) }, + { HID_USB_DEVICE(USB_VENDOR_ID_ASETEK, USB_DEVICE_ID_ASETEK_TONY_KANAAN) }, { } }; MODULE_DEVICE_TABLE(hid, universal_pidff_devices); @@ -194,5 +198,5 @@ module_hid_driver(universal_pidff); MODULE_DESCRIPTION("Universal driver for USB PID Force Feedback devices"); MODULE_LICENSE("GPL"); -MODULE_AUTHOR("Makarenko Oleg "); +MODULE_AUTHOR("Oleg Makarenko "); MODULE_AUTHOR("Tomasz Pakuła "); From patchwork Tue Feb 11 14:35:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Tomasz_Paku=C5=82a?= X-Patchwork-Id: 864388 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88E80250C13; Tue, 11 Feb 2025 14:35:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739284527; cv=none; b=avUGZjtynd/WiTKnBrDlDe2b+wnqXAZ16dzIaAqB3oRoC/P9xnfFdjzlZ+2gKjNN/sh0Pf1qaTKftz+FCvSG7RX/HY5SOUQIQTxYJmW28GeF+f9hVv/Z60zxNcygq1fgLsxAIQW4tpNBPAIv/1jk4Th4Rp0qAkYq9AAUDsZksCE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739284527; c=relaxed/simple; bh=kNGRVi3mkE4Ik7DuVSzb0dE3caW/bhvIv27XtZ4uEmE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=msrIsFMhmWniyKx7yAqTmy+aHOYEBwoH48uW6kTjT8azYbXxTXNekTZk7xnP88o6kjkvX3XNAtBRtCOT6jhHowOJLsTX4fZI+cPr79BXZ0DfCtyB8NFcf2Zq/vmAozzB6TssJaac3B9wmo1j+eHLsfbn9HuPPbkhOaoLYWS+kiI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BHBdrb0Y; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BHBdrb0Y" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-308e13e5e9bso1760371fa.0; Tue, 11 Feb 2025 06:35:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739284523; x=1739889323; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w2CWaXsm/K/mNvLz1mhLGG+mDBgTiXMcIaNXAmCgOmw=; b=BHBdrb0YRCoWnQ781G8bomRhLrbp6Tq/6zsri1vW0LgsKDzG17u3zgp36grJdBrFWz +LUNDd5GFtwJDt9wpfArz90YiPjrr4YDwl/ip0cUtxhUlWVV4GPOsSpn+kVOycu5em5j bNMJHJpYiNJfSMOkTLNQcA3hSOPgJTtqtoIY1WBi0Vaco4qPDpKPYnBBujEECclj0azS J58Suq5v7kN0j2qUrO8mCBrZurhsjuzZsH3apWxpja5d/LKCLTAHvfxOYFkfXTnWVBNl LrzSPu+TXRhMjIGE8GKLQVkTSeDn6bTLeEiy7g1Zizye0rlRnehEIU9fv8W1SmwfhgwD 9I7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739284523; x=1739889323; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w2CWaXsm/K/mNvLz1mhLGG+mDBgTiXMcIaNXAmCgOmw=; b=aDHXdU8RZd2YmzG9JUL6mr2KJDC7oOnR18rBjn2kGmCa6PvPKtTq6f5xyXJ+BFCKnK 7oezHV02vnzs2Wajwl37kcBlrGpgfv+7O8QvsE14Lmu1kvqbKco0qShJpfoci6F90nxd Co8+Dk3vjBY4Du46zL2JOozFbB2cPp+hrMi1qqPSqqr63DtEUQ+GuSIkHhXbGBumlHlN rSvUgBuWW9Xb74PdKK/P1qdoj5uDDn764z7Ohlq9qPlPPQ/7Gn9HED7KEgTwKPwJih05 HxrCiUyO2dgk+hLkRand56fecKKpMAeuD50vaBgpGA3eod5sIKrKQe2CxPoFhPXJkyAm tyUA== X-Forwarded-Encrypted: i=1; AJvYcCXLEB5cOXbVMeuIaJW6diy15+Gcjvj2dwQ7n1EAbJSoosxicLY44OwR1ZQAwAEFRQnoCMujnTyVJQFv2A==@vger.kernel.org, AJvYcCXi1Xh2RncLFlmNAA9s+79I37RN+trJRADXBTPQazkr+LLH4dbBYaIuN/um4R1nRO/ZIg6SQmc16E9U@vger.kernel.org X-Gm-Message-State: AOJu0Yxt4mjFwrLEf5MvgiiWtryMeHsPSiZmvarS2dmmcl3CrlQ5CXrk ZEV3PAnT85Y4pNWmAAsSxfT82iHr1VKfm9MVuTcPGECLgWyrk6UM X-Gm-Gg: ASbGncuiMH3OUdOnY6aF8nJQ7OrKjXvmd28C/56Np87DeMxwnZ/qOEP5fzzvn7U5QVl uO0vdJ+zIA3OAnIK/uJx8sSjTEU2PqPthlHWwF/uInSJbZVnQ5WHOoWYJKUGQ9XN+wpSwxDS6y0 VGUX4UjR7vO43xspT5Ya4djL8/VMQ8XkXIwfZzZJiBbf6gHbhNTLtrNxcn59pX7CqbI+lutqmMk PzRGFDxzp1GeNFICADFbfF650RPInesDShObEMeXglfHYRbDebwaFnFrD2eEZXXkVdbo26fHHZ+ VT/QWc5cF/WDA/B7CjuUdFVSx70HGqPqy4bPQlvwJE7b5R1YWwSGuWP+JVaIrA== X-Google-Smtp-Source: AGHT+IG2Rfg0SAnGo3nILEQO9fk+OZuBcfkOKhljstX+OhUXxYAa4lArhdIpDHV5kKyPe3PEmakW7A== X-Received: by 2002:a2e:bc21:0:b0:300:17a3:7ae1 with SMTP id 38308e7fff4ca-308fbeb2296mr3260311fa.9.1739284523395; Tue, 11 Feb 2025 06:35:23 -0800 (PST) Received: from laptok.lan (89-64-31-140.dynamic.chello.pl. [89.64.31.140]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-308ee4173edsm6132191fa.0.2025.02.11.06.35.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2025 06:35:23 -0800 (PST) From: =?utf-8?q?Tomasz_Paku=C5=82a?= To: jikos@kernel.org, bentiss@kernel.org Cc: oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v4 5/6] HID: pidff: Support device error response from PID_BLOCK_LOAD Date: Tue, 11 Feb 2025 15:35:11 +0100 Message-ID: <20250211143512.720818-6-tomasz.pakula.oficjalny@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250211143512.720818-1-tomasz.pakula.oficjalny@gmail.com> References: <20250211143512.720818-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 If an error happens on the device, the driver will no longer fall into the trap of reading this status 60 times before it decides that this reply won't change to success/memory full. Greatly reduces communication overhead during device error situation. Signed-off-by: Tomasz Pakuła --- drivers/hid/usbhid/hid-pidff.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index e2508a4d754d..d5734cbf745d 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -138,7 +138,8 @@ static const u8 pidff_effect_types[] = { #define PID_BLOCK_LOAD_SUCCESS 0 #define PID_BLOCK_LOAD_FULL 1 -static const u8 pidff_block_load_status[] = { 0x8c, 0x8d }; +#define PID_BLOCK_LOAD_ERROR 2 +static const u8 pidff_block_load_status[] = { 0x8c, 0x8d, 0x8e}; #define PID_EFFECT_START 0 #define PID_EFFECT_STOP 1 @@ -666,6 +667,11 @@ static int pidff_request_effect_upload(struct pidff_device *pidff, int efnum) pidff->block_load[PID_RAM_POOL_AVAILABLE].value[0] : -1); return -ENOSPC; } + if (pidff->block_load_status->value[0] == + pidff->status_id[PID_BLOCK_LOAD_ERROR]) { + hid_dbg(pidff->hid, "device error during effect creation\n"); + return -EREMOTEIO; + } } hid_err(pidff->hid, "pid_block_load failed 60 times\n"); return -EIO;