From patchwork Fri Mar 20 11:45:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 184716 Delivered-To: patch@linaro.org Received: by 2002:a92:1f12:0:0:0:0:0 with SMTP id i18csp627975ile; Fri, 20 Mar 2020 04:47:02 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvEKkKp1wt+dOU7JhwgzECI1/20fpUh7dXNzlJuReIZdQn6oLUgP+O7wwG9mAjaozqbjuE2 X-Received: by 2002:ae9:f511:: with SMTP id o17mr1389609qkg.367.1584704822591; Fri, 20 Mar 2020 04:47:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1584704822; cv=none; d=google.com; s=arc-20160816; b=qtY+C6u557xLvxg5TNm77dA72IF2TLJdFZaMaAVM6tVy0DA+ZtLUPOmQADrULZkdzA dBm1K4gX3JFO+4GNGfM7giuZ170j+Q3b3alQXP3RRnwYFTeCcdGt9mOinxMs/MWHl8HX G0lZZT5r1Qfl30paK5mSmIXCH9TxlG9qhone08F2hx10DoxbMDVMrwLEv6BgEFF/WVML UHoklZmmt5cUNsKmXGKw2JvtueSd2SWbroDa3A1Y1TtdWfS0X2AvvtR4YEWkA4m7C2Hw Np0qve7/mS81421APAHM7zr1QO8eT2jmFxb7oT4Mpx0/Vk18N2d4X0RmbdGI1kXvwik7 xU2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature; bh=TDipM9rGYjEtiaI6CSouTQvfuQ8pFm/kQ+ylrt2XN9A=; b=v/y2HXMb+btAtemUZZnogRFkbXRU3ZZMUpXvNT+Jl9J3XMHhvjz34sKIvxfWYBBwY4 DuIWdAvTKh25jBEeLaF0T+7HZJFv0EHVFe/AoYwciRL7q9jT7pvnbgFpJCjNhVBmDlFZ /CbgV9WvWcYPPCd1mxNjdHRQqPwl51KBnrg8rNkQJ4heSV/L1FBV8olWFBF6Iyr9uSw+ fcaRxDxITvkB9Grcdq2YKgsiKBS83H5TQK6XDnSa4jtZqeAsLEuKPcTdVI8deD5DtOd2 gvKTy5avRA8ulUSJTvhjivFKUSA3GnaDCIlnV9SpnGGj67dTk5n+HQn0N1FPtvFOqNMg s0hA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=SDgifskk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id l16si3031641qvz.59.2020.03.20.04.47.02 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Mar 2020 04:47:02 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=SDgifskk; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:51252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFG7C-0008H0-4v for patch@linaro.org; Fri, 20 Mar 2020 07:47:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50965) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jFG64-0007Jh-F6 for qemu-devel@nongnu.org; Fri, 20 Mar 2020 07:45:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jFG5z-0008Dw-PE for qemu-devel@nongnu.org; Fri, 20 Mar 2020 07:45:52 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:51158) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jFG5z-0008Cp-76 for qemu-devel@nongnu.org; Fri, 20 Mar 2020 07:45:47 -0400 Received: by mail-wm1-x341.google.com with SMTP id d198so417290wmd.0 for ; Fri, 20 Mar 2020 04:45:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=TDipM9rGYjEtiaI6CSouTQvfuQ8pFm/kQ+ylrt2XN9A=; b=SDgifskkg/4S5zCku6kzcpWqsrCeZMxlLovTNGUEyQ81akCZZYLoj7bWk7DGqIA3Jo BTGzwgPs8IFGfVEMSrUTO6EsR4u6+67zsjNgUh5n7oftHhoC7AukB0VPYh15k7dznPXI 0XMvC6VgNfvPmPHxtV6mffScgcoqfZodrdAo5sVd6BJO4h4epddyxscHgxQY2Oj59pZ1 Q5Pe0W/Ub+rZkBUHVZrPWCDndxjFNP/b6/4D2y6+kqMU7tyZ8/4NKpVltWS1sy92jXYX lZHMvPCDjS9czDtpRUq4VnEhdIzmN+7aW/14T1W5Iur6McCUVbZxy8c3wiv+EaNBQYa/ 05aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=TDipM9rGYjEtiaI6CSouTQvfuQ8pFm/kQ+ylrt2XN9A=; b=ldn7xtakk0WLKK88bbtbnVg0BJRuHVcx1tOdgpl8KT/YZJgHG5F9nBpZfHo/6bBXtp I8TcHmsKeIIYrTq+w0LYaCgb/XvB2csRjcnMMhYKTm5hBhrcT1ptrY9IsLLt6B8ZlHx4 Nymqb0PxR7yIk0CJqoellj+kZU4AAgoHwaE65mwHO4Hd/1y51EJibt8fnBNBwAksFylF zuWjL9GL59zmylm/6uUDesKzqmi12JDJo1cnHzZ+mdKyNxHEuaLZlmSW5+QOJy+JuNEQ yTKS5yKUjQPXIoRiNxkdi6UoukIt5Sr2yYhh49SKEKrGWKWS00ijwJc1AXYMTtnvYIQD 9xjA== X-Gm-Message-State: ANhLgQ0YBxQmPU76ybELLiTZdhn0tbAPIefmzJv45MFA9pOfr3W1jqyU cqDwrz6jC2FRWyUMC3DVGSXuQA== X-Received: by 2002:a1c:7209:: with SMTP id n9mr9663782wmc.188.1584704745947; Fri, 20 Mar 2020 04:45:45 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id n18sm7896591wrw.34.2020.03.20.04.45.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2020 04:45:44 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id D2A721FF7E; Fri, 20 Mar 2020 11:45:43 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [RFC PATCH for 5.0] configure: disable MTTCG for MIPS guests Date: Fri, 20 Mar 2020 11:45:22 +0000 Message-Id: <20200320114522.16273-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Markovic , =?utf-8?q?Alex_?= =?utf-8?q?Benn=C3=A9e?= , Aleksandar Rikalo , Aurelien Jarno , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" While debugging check-acceptance failures I found an instability in the mips64el test case. Briefly the test case: retry.py -n 100 -c -- ./mips64el-softmmu/qemu-system-mips64el \ -display none -vga none -serial mon:stdio \ -machine malta -kernel ./vmlinux-4.7.0-rc1.I6400 \ -cpu I6400 -smp 8 -vga std \ -append "printk.time=0 clocksource=GIC console=tty0 console=ttyS0 panic=-1" \ --no-reboot Reports about a 9% failure rate: Results summary: 0: 91 times (91.00%), avg time 5.547 (0.45 varience/0.67 deviation) -6: 9 times (9.00%), avg time 3.394 (0.02 varience/0.13 deviation) Ran command 100 times, 91 passes When re-run with "--accel tcg,thread=single" the instability goes away. Results summary: 0: 100 times (100.00%), avg time 17.318 (249.76 varience/15.80 deviation) Ran command 100 times, 100 passes Which seems to indicate there is some aspect of the MIPS MTTCG fixes that has been missed. Ideally we would fix that but I'm afraid I don't have time to investigate and am not super familiar with the architecture anyway. I've disabled all the mips guests as I assume it's a fundamental synchronisation primitive that is broken but I haven't tested them all (there are a lot!). Signed-off-by: Alex Bennée Cc: Aleksandar Markovic Cc: Aurelien Jarno Cc: Aleksandar Rikalo Cc: Philippe Mathieu-Daudé --- configure | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.20.1 Acked-by: Philippe Mathieu-Daudé diff --git a/configure b/configure index 206d22c5153..002792d21dc 100755 --- a/configure +++ b/configure @@ -7832,19 +7832,19 @@ case "$target_name" in echo "TARGET_ABI32=y" >> $config_target_mak ;; mips|mipsel) - mttcg="yes" + mttcg="no" TARGET_ARCH=mips echo "TARGET_ABI_MIPSO32=y" >> $config_target_mak ;; mipsn32|mipsn32el) - mttcg="yes" + mttcg="no" TARGET_ARCH=mips64 TARGET_BASE_ARCH=mips echo "TARGET_ABI_MIPSN32=y" >> $config_target_mak echo "TARGET_ABI32=y" >> $config_target_mak ;; mips64|mips64el) - mttcg="yes" + mttcg="no" TARGET_ARCH=mips64 TARGET_BASE_ARCH=mips echo "TARGET_ABI_MIPSN64=y" >> $config_target_mak