From patchwork Sat Jun 13 14:52:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grygorii Strashko X-Patchwork-Id: 187889 Delivered-To: patch@linaro.org Received: by 2002:a92:cf06:0:0:0:0:0 with SMTP id c6csp1297542ilo; Sat, 13 Jun 2020 07:53:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVKamDql+gBPuIzRTX+fIn6s5d7SiRnFf+hiHGMrK0Kwht0yLiP2QjnS6Dn3qqkTuDW3M6 X-Received: by 2002:a17:906:e115:: with SMTP id gj21mr17253704ejb.528.1592060000313; Sat, 13 Jun 2020 07:53:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592060000; cv=none; d=google.com; s=arc-20160816; b=w7U19nv6mmvMhYNo0192YoHYgWYTFMjIq6qoRTp1eiXQCK/2IbuVT4OjMcjgay5P7K 321nIvNV8sGuth7Ggft+IS6wMtWu7Syq6scc5b0I8+BRn8opq+J/o+J69ojZry4begAx 7eZo37CfHLW7ema0lkuOtXj71Cv4Y3VlcseDGZPDFz9kSJXorBdUm+mlCuwJLgrq2uQk BrnG3+TrL4i/j0KpK8nEqXdMHk4vyj1OnOiwhPytUKV8RBZxsl5h3rdlmuoDWWCRUAw4 48J+Iq5+mA60wDNHQ/1xwqcbhqxHGlo8zJH1sfE63gNL+VyrIEwIE2fjcEA/5GwadffI gR7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=8De/AOe/EMoDc+bfjvKtDPFHMj8PcrduA+Vt49AOtzs=; b=SzsB3g1N5IeNvBXA5ZR0zYtYTm22weD3y/tUtBKBb0aP1WRMM+u5/A26jjmcarvi9Y sHGUK50c7GaawFTfzjeCSEuDJRgUnoIyMEfcmF4rUOFTUGaXecBkQId6738uFkM98kFm H7fjkc/ytMctGEu4BcorMFGhZuN7O+SOmRmfNRXsHPRL4MwwCRg6Th0tOmYbQMTlE1zM FxiuXhCx9F6gDnMoJ1rnCCs5y8OFsE4qrI8nELxqzJKukV2O9YY/RMnBjOCQlgRgT2OH oPXRPk4TjoSuW/oQU0Y+52xb+A4gDjeELmRdpzyfthMbMf92D9V5dAYQkKp7mm9axbos g3MQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=ikFcrtcW; spf=pass (google.com: domain of linux-omap-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-omap-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t16si5900910ejs.182.2020.06.13.07.53.19; Sat, 13 Jun 2020 07:53:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-omap-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=ikFcrtcW; spf=pass (google.com: domain of linux-omap-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-omap-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726323AbgFMOxQ (ORCPT + 4 others); Sat, 13 Jun 2020 10:53:16 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:46418 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726258AbgFMOxP (ORCPT ); Sat, 13 Jun 2020 10:53:15 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 05DErCMF069643; Sat, 13 Jun 2020 09:53:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1592059992; bh=8De/AOe/EMoDc+bfjvKtDPFHMj8PcrduA+Vt49AOtzs=; h=From:To:CC:Subject:Date; b=ikFcrtcWIXoH4iLc1VGrho4FbZjeF4K2G8RLquAzj7DhbonL8UZThv9jOOxojrpl/ VOyHTwNqZRp+ep7/DGHikgKfjLP0ojQIa1hiabZ2a9ns9z5J8QHZNJqvaljEejTZlq Kg7s+ECRiXVA54hasPLeFCaKD4qSFXkuYEmJixsQ= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 05DErB6f087975 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 13 Jun 2020 09:53:11 -0500 Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Sat, 13 Jun 2020 09:53:11 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Sat, 13 Jun 2020 09:53:11 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 05DErAZg008051; Sat, 13 Jun 2020 09:53:11 -0500 From: Grygorii Strashko To: "David S. Miller" , , Jakub Kicinski CC: Sekhar Nori , , , Grygorii Strashko Subject: [PATCH] net: ethernet: ti: am65-cpsw-nuss: fix ale parameters init Date: Sat, 13 Jun 2020 17:52:59 +0300 Message-ID: <20200613145259.17044-1-grygorii.strashko@ti.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org The ALE parameters structure is created on stack, so it has to be reset before passing to cpsw_ale_create() to avoid garbage values. Fixes: 93a76530316a ("net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver") Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c index 87a4775ed53a..1492648247d9 100644 --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c @@ -1981,7 +1981,7 @@ MODULE_DEVICE_TABLE(of, am65_cpsw_nuss_of_mtable); static int am65_cpsw_nuss_probe(struct platform_device *pdev) { - struct cpsw_ale_params ale_params; + struct cpsw_ale_params ale_params = { 0 }; const struct of_device_id *of_id; struct device *dev = &pdev->dev; struct am65_cpsw_common *common;