From patchwork Mon Jan 30 21:17:15 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 92936 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp1770034qgi; Mon, 30 Jan 2017 21:18:11 -0800 (PST) X-Received: by 10.98.36.134 with SMTP id k6mr26836407pfk.41.1485839891410; Mon, 30 Jan 2017 21:18:11 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 22si14791815pfr.164.2017.01.30.21.18.11; Mon, 30 Jan 2017 21:18:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752216AbdAaFRa (ORCPT + 25 others); Tue, 31 Jan 2017 00:17:30 -0500 Received: from mail-pf0-f172.google.com ([209.85.192.172]:35580 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750994AbdAaFQk (ORCPT ); Tue, 31 Jan 2017 00:16:40 -0500 Received: by mail-pf0-f172.google.com with SMTP id f144so99467250pfa.2 for ; Mon, 30 Jan 2017 21:16:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=SMo7yR6kZ9JqyQnjfB97Il7pajYcqj2hSR4J7Fsd06Q=; b=UV8MFIHhywG3hzh0dCbrQ1yPm1AWMnRaF7bqqW9ALKQ+rAQ4RNC2dDseZ64KB2pYNb 6nQBCiOlg6y+OaBU44FXmjMjL8FeRzNYcRpB04dhHlGdwJ5Ie1lDyrX640qv9C+ZFH8g ZCiruNK0fC8ObcYTlkirGIk+InKJki/pDxDu0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=SMo7yR6kZ9JqyQnjfB97Il7pajYcqj2hSR4J7Fsd06Q=; b=Yo9234e5pKiJZELeD+yzLjZKfl/fheDe2QU1F9UGvxCipSwIyLXtQgS8Dx6VarN/GX fd51MgtmTZGFX2rRROlt7NADfdRD+tjwKRVifx2ut/IegYQk1K1ytPQbjKgqnkJQmCmC 8aKuRhbrylW5UgHeMiFkg/+AJH3SixpAgxz9S6Vo1Lb71rdAb92tzRhvhlsdzcIg/X5V 8MwJmueaQaBksSvKy1zIMwmSaF2vxu9PgvDghhUNHIGU0mQxg3h//zjGwpBAE2+FUYiE znq2HgPPS0QwJGHpChj+2wpW2GZhW2Uni9fkSV1PsY6QwawHmsUasiJj1qnDmYHL+9Np KROw== X-Gm-Message-State: AIkVDXIn7m8ajy4mm1EKbacdKLFJkG4CwP6UFRCNBAIN8LvG5LNQoabULYiKcLbe5W42nXtP X-Received: by 10.99.115.71 with SMTP id d7mr28182104pgn.56.1485839771124; Mon, 30 Jan 2017 21:16:11 -0800 (PST) Received: from localhost.localdomain (ip68-111-223-48.sd.sd.cox.net. [68.111.223.48]) by smtp.gmail.com with ESMTPSA id p66sm36539437pfb.88.2017.01.30.21.16.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jan 2017 21:16:09 -0800 (PST) From: Bjorn Andersson To: Rob Herring , Mark Rutland , Jonathan Cameron Cc: Lee Jones , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Richard Purdie , Pavel Machek , Jingoo Han , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-leds@vger.kernel.org Subject: [PATCH v6 1/5] devicetree: mfd: Add binding for the TI LM3533 Date: Mon, 30 Jan 2017 13:17:15 -0800 Message-Id: <20170130211719.31017-1-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bjorn Andersson Add the binding for the Texas Instruments LM3533 lighting power solution. Acked-by: Jonathan Cameron Acked-by: Rob Herring Acked-for-MFD-by: Lee Jones Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- Changes since v5: - None Changes since v4: - Acks from Jonathan, Lee and Rob Changes since v3: - Added compatible to sub-nodes, per Lee's requested to treat them as separate pieces. Documentation/devicetree/bindings/mfd/lm3533.txt | 205 +++++++++++++++++++++++ 1 file changed, 205 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/lm3533.txt -- 2.11.0 diff --git a/Documentation/devicetree/bindings/mfd/lm3533.txt b/Documentation/devicetree/bindings/mfd/lm3533.txt new file mode 100644 index 000000000000..909281096ba2 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/lm3533.txt @@ -0,0 +1,205 @@ +Texas Instruments LM3533 binding + +This binding describes the Texas Instruments LM3533, a lighting power solution +for smartphone handsets. The common properties are described directly in the +node, while each individual component are described in an optional subnode. + +- compatible: + Usage: required + Value type: + Definition: must be: + "ti,lm3533" + +- reg: + Usage: required + Value type: + Definition: i2c address of the LM3533 chip + +- als-supply: + Usage: optional + Value type: + Definition: reference to regulator powering the V_als input; as + specified in "../regulator/regulator.txt" + +- hwen-gpios: + Usage: required + Value type: + Definition: reference to gpio pin connected to the HWEN input; as + specified in "../gpio/gpio.txt" + +- ti,boost-freq-hz: + Usage: required + Value type: + Definition: switch-frequency of the boost converter, must be either: + 500000 or 1000000 + +- ti,boost-ovp-mv: + Usage: required + Value type: + Definition: over-voltage protection limit, in mV. Must be one of: + 16000, 24000, 32000 or 40000 + +- #address-cells: + Usage: required + Value type: + Definition: must be 1 + +- #size-cells: + Usage: required + Value type: + Definition: must be 0 + += ALS SUBNODE +The ambient light sensor subnode carrying the light sensor related properties. + +- compatible: + Usage: required + Value type: + Definition: must be: + "ti,lm3533-als" + +- ti,als-resistance-ohm: + Usage: required (unless ti,pwm-mode is specified) + Value type: + Definition: specifies the resistor value (R_als), in Ohm. Valid values + ranges from 200000 to 1574 Ohm. + +- ti,pwm-mode: + Usage: optional + Value type: + Definition: specifies, if present, that the als should operate in PWM + mode - rather than analog mode + += BACKLIGHT NODES +Backlight subnodes carrying the backlight related properties. + +- compatible: + Usage: required + Value type: + Definition: must be: + "ti,lm3533-backlight" + +- reg: + Usage: required + Value type: + Definition: specifies which of the two backlights this node corresponds + to + +- default-brightness: + Usage: optional + Value type: <32> + Definition: specifies the default brightness for the backlight, in + units of brightness [0-255] + +- label: + Usage: required + Value type: + Definition: specifies a name of this backlight + +- led-max-microamp: + Usage: required + Value type: + Definition: specifies the max current for this backlight, in uA, as + described in "../leds/common.txt" + +- ti,pwm-zones: + Usage: optional + Value type: + Definition: lists the ALS zones to be PWM controlled for this backlight, + the values in the list are in the range [0 - 4] + += LED NODES +LED subnodes carrying the LED related properties. + +- compatible: + Usage: required + Value type: + Definition: must be: + "ti,lm3533-led" + +- reg: + Usage: required + Value type: + Definition: specifies which of the four LEDs this node corresponds to + +- linux,default-trigger: + Usage: optional + Value type: + Definition: specifies the default trigger for the LED, as described in + "../leds/common.txt" + +- label: + Usage: required + Value type: + Definition: specifies a name of this LED, as described in + "../leds/common.txt" + +- led-max-microamp: + Usage: required + Value type: + Definition: specifies the max current for this LED, in uA, as described + in "../leds/common.txt" + +- ti,pwm-zones: + Usage: optional + Value type: + Definition: lists the ALS zones to be PWM controlled for this LED, the + values in the list are in the range [0 - 4] + += EXAMPLE + +i2c@12460000 { + compatible = "qcom,i2c-qup-v1.1.1"; + ... + + lm3533@36 { + compatible = "ti,lm3533"; + reg = <0x36>; + + als-supply = <&pm8921_l11>; + hwen-gpios = <&pm8921_gpio 26 GPIO_ACTIVE_HIGH>; + + ti,boost-freq-hz = <500000>; + ti,boost-ovp-mv = <24000>; + + #address-cells = <1>; + #size-cells = <0>; + + als { + compatible = "ti,lm3533-als"; + ti,als-resistance-ohm = <200000>; + }; + + backlight@0 { + compatible = "ti,lm3533-backlight"; + reg = <0>; + label = "backlight"; + + led-max-microamp = <20200>; + }; + + led@0 { + compatible = "ti,lm3533-led"; + reg = <0>; + label = "red"; + + led-max-microamp = <5000>; + }; + + led@1 { + compatible = "ti,lm3533-led"; + reg = <1>; + label = "green"; + + led-max-microamp = <5000>; + }; + + led@2 { + compatible = "ti,lm3533-led"; + reg = <2>; + label = "blue"; + + led-max-microamp = <5000>; + }; + }; + From patchwork Mon Jan 30 21:17:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 92940 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp1770255qgi; Mon, 30 Jan 2017 21:19:16 -0800 (PST) X-Received: by 10.84.210.232 with SMTP id a95mr36848009pli.31.1485839956768; Mon, 30 Jan 2017 21:19:16 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g21si10301634pgj.268.2017.01.30.21.19.16; Mon, 30 Jan 2017 21:19:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751999AbdAaFR2 (ORCPT + 25 others); Tue, 31 Jan 2017 00:17:28 -0500 Received: from mail-pf0-f175.google.com ([209.85.192.175]:33048 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751120AbdAaFQk (ORCPT ); Tue, 31 Jan 2017 00:16:40 -0500 Received: by mail-pf0-f175.google.com with SMTP id y143so99474126pfb.0 for ; Mon, 30 Jan 2017 21:16:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6EPXRnNeIw1tmWqO4nItfg+5gdJUY+DKPsWuAZQ3r08=; b=Zadv4IgK1K/ZKsm30U6w2skT33ucd6qzhjzMiOwXf2fybJa3oEC06KwLhCYmrIq8sh sth9OWNk5HyyyNI6rUM8lXHcmpYQCNQe5XoNXrKFDyor2/OYVpNpfokjIMLrMm0e3S3b CnwEoJUDQS7a12pu/MSx/YXjnrIqPQZakVtSE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6EPXRnNeIw1tmWqO4nItfg+5gdJUY+DKPsWuAZQ3r08=; b=IpeCDDs/NdusCt96xqKShEcrRPW49NZIHUfQMUokX3/1xyXce9QEGfSLyvv/f0Q07o GpVJ1LzKMDpOsehf0EPJpce7j+mmqubSttLCPZMhMevq09pAhMan41hhfHhSjitzQsDn tN8QefVeSmt17G4j66r6hci2XocOkS3ktNgqpFvjqiNor7eQLZn3s6R8OZF27itVW0mz qK/4aMf2/s/WOg3xo4bVD5Qcga7vTMcZiA6BaPIl1nTN8Hi6A8ZPbMIpjz1B6e3nWoTB KLaViEikzX23UVbhge8dR9KmpHWv5vCNoJobXMGrAobZBqUKQ16RpvejqOItIgGh4IEt E1sw== X-Gm-Message-State: AIkVDXIHpTHMWqd4PWvWv9aimO1gipCW9HQfGHAGu1MT1NpYI5ONBEOR16DDYpabJLdbZAs2 X-Received: by 10.84.162.204 with SMTP id o12mr37080071plg.132.1485839774125; Mon, 30 Jan 2017 21:16:14 -0800 (PST) Received: from localhost.localdomain (ip68-111-223-48.sd.sd.cox.net. [68.111.223.48]) by smtp.gmail.com with ESMTPSA id p66sm36539437pfb.88.2017.01.30.21.16.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jan 2017 21:16:12 -0800 (PST) From: Bjorn Andersson To: Lee Jones Cc: Rob Herring , Mark Rutland , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Richard Purdie , Pavel Machek , Jingoo Han , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-leds@vger.kernel.org Subject: [PATCH v6 2/5] mfd: lm3533: Support initialization from Device Tree Date: Mon, 30 Jan 2017 13:17:16 -0800 Message-Id: <20170130211719.31017-2-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170130211719.31017-1-bjorn.andersson@linaro.org> References: <20170130211719.31017-1-bjorn.andersson@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bjorn Andersson Implement support for initialization of the lm3533 driver core and probing child devices from Device Tree. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- drivers/mfd/lm3533-core.c | 82 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 82 insertions(+) Note that this patch can be merged independently of the other patches in the series. Changes since v5: - Added comment re of_platform_populate() Changes since v4: - Moved of_node check into lm3533_pdata_from_of_node() Changes since v3: - Moved parsing of child of nodes into each child driver - Use of_platform_populate() to instanciate child devices -- 2.11.0 diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c index 5abcbb2e8849..89c79328c78e 100644 --- a/drivers/mfd/lm3533-core.c +++ b/drivers/mfd/lm3533-core.c @@ -18,6 +18,8 @@ #include #include #include +#include +#include #include #include #include @@ -512,6 +514,16 @@ static int lm3533_device_init(struct lm3533 *lm3533) lm3533_device_bl_init(lm3533); lm3533_device_led_init(lm3533); + /* + * Check of_node as of_platform_populate treats NULL as the root node, + * which would cause side effects in certain unlikely DT/non-DT hybrid + * solutions. + */ + if (lm3533->dev->of_node) { + of_platform_populate(lm3533->dev->of_node, NULL, NULL, + lm3533->dev); + } + ret = sysfs_create_group(&lm3533->dev->kobj, &lm3533_attribute_group); if (ret < 0) { dev_err(lm3533->dev, "failed to create sysfs attributes\n"); @@ -588,10 +600,76 @@ static const struct regmap_config regmap_config = { .precious_reg = lm3533_precious_register, }; +static int lm3533_of_parse_enum(struct device *dev, const char *propname, + const unsigned int *match, size_t num_matches) +{ + size_t i; + int ret; + u32 val; + + ret = of_property_read_u32(dev->of_node, propname, &val); + if (ret < 0) { + dev_err(dev, "failed to parse %s\n", propname); + return ret; + } + + for (i = 0; i < num_matches; i++) { + if (val == match[i]) + return i; + } + + dev_err(dev, "unsupported value of %s\n", propname); + return -EINVAL; +} + +static int lm3533_pdata_from_of_node(struct device *dev) +{ + struct lm3533_platform_data *pdata; + int ret; + const unsigned int freqs[] = { + [LM3533_BOOST_FREQ_500KHZ] = 500000, + [LM3533_BOOST_FREQ_1000KHZ] = 1000000, + }; + const unsigned int ovps[] = { + [LM3533_BOOST_OVP_16V] = 16000, + [LM3533_BOOST_OVP_24V] = 24000, + [LM3533_BOOST_OVP_32V] = 32000, + [LM3533_BOOST_OVP_40V] = 40000, + }; + + if (!dev->of_node) + return 0; + + pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); + if (!pdata) + return -ENOMEM; + + pdata->gpio_hwen = of_get_named_gpio(dev->of_node, "hwen-gpios", 0); + if (pdata->gpio_hwen < 0) + return pdata->gpio_hwen; + + ret = lm3533_of_parse_enum(dev, "ti,boost-freq-hz", + freqs, ARRAY_SIZE(freqs)); + if (ret < 0) + return ret; + pdata->boost_freq = ret; + + ret = lm3533_of_parse_enum(dev, "ti,boost-ovp-mv", + ovps, ARRAY_SIZE(ovps)); + if (ret < 0) + return ret; + pdata->boost_ovp = ret; + + dev->platform_data = pdata; + + return 0; +} + static int lm3533_i2c_probe(struct i2c_client *i2c, const struct i2c_device_id *id) { struct lm3533 *lm3533; + int ret; dev_dbg(&i2c->dev, "%s\n", __func__); @@ -608,6 +686,10 @@ static int lm3533_i2c_probe(struct i2c_client *i2c, lm3533->dev = &i2c->dev; lm3533->irq = i2c->irq; + ret = lm3533_pdata_from_of_node(lm3533->dev); + if (ret < 0) + return ret; + return lm3533_device_init(lm3533); } From patchwork Mon Jan 30 21:17:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 92938 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp1770242qgi; Mon, 30 Jan 2017 21:19:13 -0800 (PST) X-Received: by 10.99.171.75 with SMTP id k11mr28027030pgp.16.1485839953103; Mon, 30 Jan 2017 21:19:13 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g21si10301634pgj.268.2017.01.30.21.19.12; Mon, 30 Jan 2017 21:19:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752116AbdAaFR3 (ORCPT + 25 others); Tue, 31 Jan 2017 00:17:29 -0500 Received: from mail-pf0-f177.google.com ([209.85.192.177]:33062 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751112AbdAaFQk (ORCPT ); Tue, 31 Jan 2017 00:16:40 -0500 Received: by mail-pf0-f177.google.com with SMTP id y143so99475025pfb.0 for ; Mon, 30 Jan 2017 21:16:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=y35h+MelpKUAxl771EHAnoIY3xFOWMrdRh5CqbKCyqw=; b=hhoQzRz5ypsfK9otp0tmBsgrfYJO+rMW1+4AXRHW+GZ3r6pzVUDpqzHj3zazIIjKg4 Mg0jct4KRwLl995/6tdx0s3MvU5EPDMsh8ZRcy3fxKhwKMKEcQWHhQQxJG6FEve0X0OZ qc7yAXiHa1U06YXULjBgBPIJJt3/mlgO/Nk68= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=y35h+MelpKUAxl771EHAnoIY3xFOWMrdRh5CqbKCyqw=; b=ndV5qLhogp/9aqwsnbjELzJ/Hpg2WkIVQI9mKvvsDXNx7EYpI6F97jgWU4/W5EBCa8 hJOMGWJxb3MjtWuTWPB985uMCeb/4KHyYY586GPfNfSpAmcPGMfMYiDr2qME2b8CB1dm XtsZoVRIiGtWVcAoXxsG3aV3kaxDTlG0LW54HWhgMrSkU4ygkFChpdn7JP05EbUgU+Aj H49j3r/G+5pei9+iz+E0lkEVL4UwTL6XP0gzFAB7xfHqfHRD1kvIVUtLw11KAta8R1Ip jIXAJI7RiafTXMurJCsDwTzbQvIfB3DkeemVLLjRN5vp3DZsj/NiMnWRTwDGVAv/KL8h 4VcQ== X-Gm-Message-State: AIkVDXKWCe+XXW9IQGCOUHVHy1fBBVpXBoWfqdbzdFFxmKJcYSlzRFGi8mVovrVetIsnfGHP X-Received: by 10.98.106.132 with SMTP id f126mr27456854pfc.1.1485839777376; Mon, 30 Jan 2017 21:16:17 -0800 (PST) Received: from localhost.localdomain (ip68-111-223-48.sd.sd.cox.net. [68.111.223.48]) by smtp.gmail.com with ESMTPSA id p66sm36539437pfb.88.2017.01.30.21.16.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jan 2017 21:16:16 -0800 (PST) From: Bjorn Andersson To: Lee Jones , Jingoo Han Cc: Rob Herring , Mark Rutland , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Richard Purdie , Pavel Machek , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-leds@vger.kernel.org Subject: [PATCH v6 3/5] backlight: lm3533: Support initialization from Device Tree Date: Mon, 30 Jan 2017 13:17:17 -0800 Message-Id: <20170130211719.31017-3-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170130211719.31017-1-bjorn.andersson@linaro.org> References: <20170130211719.31017-1-bjorn.andersson@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bjorn Andersson Implement support for initialization of the lm3533 backlight from Device Tree. Acked-by: Jingoo Han Acked-by: Pavel Machek Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- Note that this patch can be merged independently of the other patches in the series. Changes since v5: - None Changes since v4: - Acks from Pavel and Jingoo Changes since v3: - Moved backlight DT parsing from mfd driver - Gave driver its own compatible drivers/video/backlight/lm3533_bl.c | 98 +++++++++++++++++++++++++++++++++++-- 1 file changed, 95 insertions(+), 3 deletions(-) -- 2.11.0 Acked-by: Daniel Thompson diff --git a/drivers/video/backlight/lm3533_bl.c b/drivers/video/backlight/lm3533_bl.c index 0e2337f367b6..2f132199e604 100644 --- a/drivers/video/backlight/lm3533_bl.c +++ b/drivers/video/backlight/lm3533_bl.c @@ -22,6 +22,7 @@ #define LM3533_HVCTRLBANK_COUNT 2 +#define LM3533_BL_DEFAULT_BRIGHTNESS 200 #define LM3533_BL_MAX_BRIGHTNESS 255 #define LM3533_REG_CTRLBANK_AB_BCONF 0x1a @@ -269,6 +270,86 @@ static int lm3533_bl_setup(struct lm3533_bl *bl, return lm3533_ctrlbank_set_pwm(&bl->cb, pdata->pwm); } +static int lm3533_of_parse_pwm_zones(struct device_node *node) +{ + const char *propname = "ti,pwm-zones"; + u32 zones[5]; + int count; + int ret; + int i; + + count = of_property_count_u32_elems(node, propname); + if (count == -EINVAL) + return 0; + if (count <= 0) + return count; + if (count >= ARRAY_SIZE(zones)) + return -EINVAL; + + ret = of_property_read_u32_array(node, propname, zones, count); + if (ret < 0) + return ret; + + /* Enable pwm input, and enable the selected zones */ + ret = BIT(0); + for (i = 0; i < count; i++) + ret |= BIT(zones[i] + 1); + + return ret; +} + +static struct lm3533_bl_platform_data *lm3533_bl_of_parse(struct device *dev, + int *id) +{ + struct lm3533_bl_platform_data *bl_pdata; + struct device_node *node = dev->of_node; + int ret; + u32 reg; + u32 val; + + bl_pdata = devm_kzalloc(dev, sizeof(*bl_pdata), GFP_KERNEL); + if (!bl_pdata) + return NULL; + + ret = of_property_read_u32(node, "reg", ®); + if (ret < 0) { + dev_err(dev, "invalid reg property\n"); + return NULL; + } + *id = reg; + + ret = of_property_read_string(node, "label", + (const char **)&bl_pdata->name); + if (ret < 0) { + dev_err(dev, "unable to parse label\n"); + return NULL; + } + + ret = of_property_read_u32(node, "led-max-microamp", &val); + if (ret < 0) { + dev_err(dev, "unable to parse led-max-microamp\n"); + return NULL; + } + bl_pdata->max_current = val; + + val = LM3533_BL_DEFAULT_BRIGHTNESS; + ret = of_property_read_u32(node, "default-brightness", &val); + if (ret < 0 && ret != -EINVAL) { + dev_err(dev, "unable to parse default-brightness\n"); + return NULL; + } + bl_pdata->default_brightness = val; + + ret = lm3533_of_parse_pwm_zones(node); + if (ret < 0) { + dev_err(dev, "failed to parse ti,pwm-zones\n"); + return NULL; + } + bl_pdata->pwm = ret; + + return bl_pdata; +} + static int lm3533_bl_probe(struct platform_device *pdev) { struct lm3533 *lm3533; @@ -277,6 +358,7 @@ static int lm3533_bl_probe(struct platform_device *pdev) struct backlight_device *bd; struct backlight_properties props; int ret; + int id; dev_dbg(&pdev->dev, "%s\n", __func__); @@ -284,14 +366,17 @@ static int lm3533_bl_probe(struct platform_device *pdev) if (!lm3533) return -EINVAL; + id = pdev->id; pdata = dev_get_platdata(&pdev->dev); + if (!pdata) + pdata = lm3533_bl_of_parse(&pdev->dev, &id); if (!pdata) { dev_err(&pdev->dev, "no platform data\n"); return -EINVAL; } - if (pdev->id < 0 || pdev->id >= LM3533_HVCTRLBANK_COUNT) { - dev_err(&pdev->dev, "illegal backlight id %d\n", pdev->id); + if (id < 0 || id >= LM3533_HVCTRLBANK_COUNT) { + dev_err(&pdev->dev, "illegal backlight id %d\n", id); return -EINVAL; } @@ -300,7 +385,7 @@ static int lm3533_bl_probe(struct platform_device *pdev) return -ENOMEM; bl->lm3533 = lm3533; - bl->id = pdev->id; + bl->id = id; bl->cb.lm3533 = lm3533; bl->cb.id = lm3533_bl_get_ctrlbank_id(bl); @@ -394,10 +479,17 @@ static void lm3533_bl_shutdown(struct platform_device *pdev) lm3533_ctrlbank_disable(&bl->cb); } +static const struct of_device_id lm3533_bl_of_match[] = { + { .compatible = "ti,lm3533-backlight", }, + { }, +}; +MODULE_DEVICE_TABLE(of, lm3533_bl_of_match); + static struct platform_driver lm3533_bl_driver = { .driver = { .name = "lm3533-backlight", .pm = &lm3533_bl_pm_ops, + .of_match_table = lm3533_bl_of_match, }, .probe = lm3533_bl_probe, .remove = lm3533_bl_remove, From patchwork Mon Jan 30 21:17:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 92937 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp1770125qgi; Mon, 30 Jan 2017 21:18:39 -0800 (PST) X-Received: by 10.98.157.83 with SMTP id i80mr26975153pfd.177.1485839919723; Mon, 30 Jan 2017 21:18:39 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f3si13706003pld.136.2017.01.30.21.18.39; Mon, 30 Jan 2017 21:18:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752167AbdAaFRa (ORCPT + 25 others); Tue, 31 Jan 2017 00:17:30 -0500 Received: from mail-pf0-f178.google.com ([209.85.192.178]:35619 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751208AbdAaFQk (ORCPT ); Tue, 31 Jan 2017 00:16:40 -0500 Received: by mail-pf0-f178.google.com with SMTP id f144so99469546pfa.2 for ; Mon, 30 Jan 2017 21:16:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ZjWqJRmKI97csunTlNq3KcT10987R40nPy9TMfIKE/s=; b=VCc9QHhwebS/atmTpZXUR4Q9ZS9rafXc/SFXb8fh7b1Ot+qJ9hdSyPh5JZts3WxcUj 96V5FYvsvNBvT91726nWf9dAhef7jNfT/ju2IOqa7oSE5udm1LX8/R8/Ji10/eLt+G60 4fz4hhLzZerNAG8gOxbD0QMH0hK8qhOhL/eh8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ZjWqJRmKI97csunTlNq3KcT10987R40nPy9TMfIKE/s=; b=fWXgVZw8uUcaU8YhvLtWrIRdz0hlNwzP1F3gC83ch0JeI6x+RW2GDTmhQFOk/0FR4j +eJvxk7hxmE/ZF+B22KleetbPcr4WBRsMnqv6s3u8QQBlx31Cdu5MVE5+lgL58XQK4Ns 1WWTKKzEkDVrjdzqMqrM5y4J43wKjJWYm8cXknh8lZ4RRqqc0cQ8XWa82nKhvvgfDxsF 9iOdJpaF8eOqYO84uGVAajZBUqvTuPm4ZxkloQrVCC3LcxhDFZdXN1k4cOoC2hjqBSqD SJcdPFnLDiXukt6w7rTqhRYyImHLs2KkZ0CUAAr7heB43qFdhi57XxLQ/joi02sXOiyM Jdwg== X-Gm-Message-State: AIkVDXIiCamcWibAGS8COQ6FuqbtbL+JYFPSkb7ztX0nEEmYo8PiL2JEUk7lDIBo3thtxIaP X-Received: by 10.84.211.137 with SMTP id c9mr36719827pli.8.1485839780023; Mon, 30 Jan 2017 21:16:20 -0800 (PST) Received: from localhost.localdomain (ip68-111-223-48.sd.sd.cox.net. [68.111.223.48]) by smtp.gmail.com with ESMTPSA id p66sm36539437pfb.88.2017.01.30.21.16.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jan 2017 21:16:18 -0800 (PST) From: Bjorn Andersson To: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones Subject: [PATCH v6 4/5] iio: light: lm3533-als: Support initialization from Device Tree Date: Mon, 30 Jan 2017 13:17:18 -0800 Message-Id: <20170130211719.31017-4-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170130211719.31017-1-bjorn.andersson@linaro.org> References: <20170130211719.31017-1-bjorn.andersson@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bjorn Andersson Implement support for initialization of the lm3533 als driver from Device Tree. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- Note that this patch can be merged independently of the other patches in the series. Changes since v5: - None Changes since v4: - None Changes since v3: - Moved als DT parsing from mfd driver - Gave driver its own compatible drivers/iio/light/lm3533-als.c | 40 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 39 insertions(+), 1 deletion(-) -- 2.11.0 diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c index f409c2047c05..eef9f06eb0b1 100644 --- a/drivers/iio/light/lm3533-als.c +++ b/drivers/iio/light/lm3533-als.c @@ -20,6 +20,7 @@ #include #include #include +#include #include #include #include @@ -831,6 +832,32 @@ static const struct iio_info lm3533_als_info = { .read_raw = &lm3533_als_read_raw, }; +static struct lm3533_als_platform_data *lm3533_als_of_parse(struct device *dev) +{ + struct lm3533_als_platform_data *als_pdata; + struct device_node *node = dev->of_node; + int ret; + u32 val; + + als_pdata = devm_kzalloc(dev, sizeof(*als_pdata), GFP_KERNEL); + if (!als_pdata) + return NULL; + + als_pdata->pwm_mode = of_property_read_bool(node, "ti,pwm-mode"); + + ret = of_property_read_u32(node, "ti,als-resistance-ohm", &val); + if (ret < 0 && ret != -EINVAL) { + dev_err(dev, "unable to read ti,als-resistance-ohm"); + return NULL; + } + + /* Leave at high-Z, if the property was omitted or specified as 0 */ + if (!ret && val != 0) + als_pdata->r_select = 200000 / val; + + return als_pdata; +} + static int lm3533_als_probe(struct platform_device *pdev) { struct lm3533 *lm3533; @@ -843,7 +870,11 @@ static int lm3533_als_probe(struct platform_device *pdev) if (!lm3533) return -EINVAL; - pdata = pdev->dev.platform_data; + if (pdev->dev.of_node) + pdata = lm3533_als_of_parse(&pdev->dev); + else + pdata = pdev->dev.platform_data; + if (!pdata) { dev_err(&pdev->dev, "no platform data\n"); return -EINVAL; @@ -914,9 +945,16 @@ static int lm3533_als_remove(struct platform_device *pdev) return 0; } +static const struct of_device_id lm3533_als_of_match[] = { + { .compatible = "ti,lm3533-als", }, + { }, +}; +MODULE_DEVICE_TABLE(of, lm3533_als_of_match); + static struct platform_driver lm3533_als_driver = { .driver = { .name = "lm3533-als", + .of_match_table = lm3533_als_of_match, }, .probe = lm3533_als_probe, .remove = lm3533_als_remove, From patchwork Mon Jan 30 21:17:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Andersson X-Patchwork-Id: 92939 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp1770245qgi; Mon, 30 Jan 2017 21:19:13 -0800 (PST) X-Received: by 10.84.130.99 with SMTP id 90mr37025127plc.167.1485839953479; Mon, 30 Jan 2017 21:19:13 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g21si10301634pgj.268.2017.01.30.21.19.13; Mon, 30 Jan 2017 21:19:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752061AbdAaFR2 (ORCPT + 25 others); Tue, 31 Jan 2017 00:17:28 -0500 Received: from mail-pf0-f176.google.com ([209.85.192.176]:33907 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751388AbdAaFQk (ORCPT ); Tue, 31 Jan 2017 00:16:40 -0500 Received: by mail-pf0-f176.google.com with SMTP id e4so99103970pfg.1 for ; Mon, 30 Jan 2017 21:16:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ECuZmmpgcM/FgKxC8Ru3LG+qtAzvB5kie4yUheomvJs=; b=OXCr/LiKKA1YvV34dt3dz8oRb+eyzkd1YCoZuSX13ALM7gCIkqmuD9MQroDg14UR1b PceAvMuCGSM9/yWYQ0ZegrvnLOywpModdcEiztG1wXTLf45CSe54JICQ4oUKQLE+OXxC MdfRikY9fXzchvFNh+zUNRSTaqm+xmMeWGmow= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ECuZmmpgcM/FgKxC8Ru3LG+qtAzvB5kie4yUheomvJs=; b=aMM6igBLkBp0RJC6kP+r64JAsqGtsMvaZOSXAYcDBTLXEQY9IcWN7GkWlTd1SwheIS 3IsX/l8JuAktMLkjb0iT42lWAyuig4QhWzOEI3/2gvcY/6ZwvNHVVBssCID75KebuShB wGjWb+NlMd+9SoKKYZ1+Sn8dK4FTdH0SPclaKmiPCTpamgyh4YW/a2riKWiHJykmh6Ro 6e2mPNF2xEm30IbOEe5DbLruZ676gYbWbEIoEKbPrJcLCuTdKnfZWP5UhW9shlaWzYNO f2e8uLSKi/NbOtUxUQuYANy8Q9X8uX3b8dqvGmU1oRHHJ7tTMkJzxDt68Tft4IAcBAMZ L3Ug== X-Gm-Message-State: AIkVDXLfM1ub3j/KH7KCfnYyW1C7YX5doi94YYt6lm3PVUJqZk9Np/SPRS/mUyVf6Af77tM/ X-Received: by 10.98.13.18 with SMTP id v18mr27279571pfi.62.1485839781930; Mon, 30 Jan 2017 21:16:21 -0800 (PST) Received: from localhost.localdomain (ip68-111-223-48.sd.sd.cox.net. [68.111.223.48]) by smtp.gmail.com with ESMTPSA id p66sm36539437pfb.88.2017.01.30.21.16.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jan 2017 21:16:20 -0800 (PST) From: Bjorn Andersson To: Richard Purdie , Pavel Machek Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones Subject: [PATCH v6 5/5] leds: lm3533: Support initialization from Device Tree Date: Mon, 30 Jan 2017 13:17:19 -0800 Message-Id: <20170130211719.31017-5-bjorn.andersson@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170130211719.31017-1-bjorn.andersson@linaro.org> References: <20170130211719.31017-1-bjorn.andersson@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bjorn Andersson Implement support for initialization of the lm3533 LED driver from Device Tree. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- Note that this patch can be merged independently of the other patches in the series. Changes since v5: - None Changes since v4: - None Changes since v3: - Moved LED DT parsing from mfd driver - Gave driver its own compatible drivers/leds/leds-lm3533.c | 98 ++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 95 insertions(+), 3 deletions(-) -- 2.11.0 diff --git a/drivers/leds/leds-lm3533.c b/drivers/leds/leds-lm3533.c index 5b529dc013d2..3eedad0ea9df 100644 --- a/drivers/leds/leds-lm3533.c +++ b/drivers/leds/leds-lm3533.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include @@ -648,12 +649,92 @@ static int lm3533_led_setup(struct lm3533_led *led, return lm3533_ctrlbank_set_pwm(&led->cb, pdata->pwm); } +static int lm3533_of_parse_pwm_zones(struct device_node *node) +{ + const char *propname = "ti,pwm-zones"; + u32 zones[5]; + int count; + int ret; + int i; + + count = of_property_count_u32_elems(node, propname); + if (count == -EINVAL) + return 0; + if (count <= 0) + return count; + if (count >= ARRAY_SIZE(zones)) + return -EINVAL; + + ret = of_property_read_u32_array(node, propname, zones, count); + if (ret < 0) + return ret; + + /* Enable pwm input, and enable the selected zones */ + ret = BIT(0); + for (i = 0; i < count; i++) + ret |= BIT(zones[i] + 1); + + return ret; +} + +static struct lm3533_led_platform_data *lm3533_led_of_parse(struct device *dev, + int *id) +{ + struct lm3533_led_platform_data *led_pdata; + struct device_node *node = dev->of_node; + int ret; + u32 reg; + u32 val; + + led_pdata = devm_kzalloc(dev, sizeof(*led_pdata), GFP_KERNEL); + if (!led_pdata) + return NULL; + + ret = of_property_read_u32(node, "reg", ®); + if (ret < 0) { + dev_err(dev, "invalid reg property\n"); + return NULL; + } + *id = reg; + + ret = of_property_read_string(node, "label", + (const char **)&led_pdata->name); + if (ret < 0) { + dev_err(dev, "unable to parse label\n"); + return NULL; + } + + ret = of_property_read_u32(node, "led-max-microamp", &val); + if (ret < 0) { + dev_err(dev, "unable to parse led-max-microamp\n"); + return NULL; + } + led_pdata->max_current = val; + + ret = of_property_read_string(node, "linux,default-trigger", + &led_pdata->default_trigger); + if (ret < 0 && ret != -EINVAL) { + dev_err(dev, "unable to parse default-trigger\n"); + return NULL; + } + + ret = lm3533_of_parse_pwm_zones(node); + if (ret < 0) { + dev_err(dev, "failed to parse ti,pwm-zones\n"); + return NULL; + } + led_pdata->pwm = ret; + + return led_pdata; +} + static int lm3533_led_probe(struct platform_device *pdev) { struct lm3533 *lm3533; struct lm3533_led_platform_data *pdata; struct lm3533_led *led; int ret; + int id; dev_dbg(&pdev->dev, "%s\n", __func__); @@ -661,14 +742,18 @@ static int lm3533_led_probe(struct platform_device *pdev) if (!lm3533) return -EINVAL; + id = pdev->id; pdata = dev_get_platdata(&pdev->dev); + if (!pdata) + pdata = lm3533_led_of_parse(&pdev->dev, &id); + if (!pdata) { dev_err(&pdev->dev, "no platform data\n"); return -EINVAL; } - if (pdev->id < 0 || pdev->id >= LM3533_LVCTRLBANK_COUNT) { - dev_err(&pdev->dev, "illegal LED id %d\n", pdev->id); + if (id < 0 || id >= LM3533_LVCTRLBANK_COUNT) { + dev_err(&pdev->dev, "illegal LED id %d\n", id); return -EINVAL; } @@ -684,7 +769,7 @@ static int lm3533_led_probe(struct platform_device *pdev) led->cdev.blink_set = lm3533_led_blink_set; led->cdev.brightness = LED_OFF; led->cdev.groups = lm3533_led_attribute_groups, - led->id = pdev->id; + led->id = id; mutex_init(&led->mutex); @@ -739,9 +824,16 @@ static void lm3533_led_shutdown(struct platform_device *pdev) lm3533_led_set(&led->cdev, LED_OFF); /* disable blink */ } +static const struct of_device_id lm3533_led_of_match[] = { + { .compatible = "ti,lm3533-led", }, + { }, +}; +MODULE_DEVICE_TABLE(of, lm3533_led_of_match); + static struct platform_driver lm3533_led_driver = { .driver = { .name = "lm3533-leds", + .of_match_table = lm3533_led_of_match, }, .probe = lm3533_led_probe, .remove = lm3533_led_remove,